ipv6: fix an oops when force unload ipv6 module

[safe/jmp/linux-2.6] / net / ipv4 / ipip.c

diff --git a/net/ipv4/ipip.c b/net/ipv4/ipip.c
index a2ca53d..eda04fe 100644 (file)
--- a/net/ipv4/ipip.c
+++ b/net/ipv4/ipip.c
@@ -119,7 +119,7 @@
 #define HASH_SIZE  16
 #define HASH(addr) (((__force u32)addr^((__force u32)addr>>4))&0xF)
 
-static int ipip_net_id;
+static int ipip_net_id __read_mostly;
 struct ipip_net {
        struct ip_tunnel *tunnels_r_l[HASH_SIZE];
        struct ip_tunnel *tunnels_r[HASH_SIZE];
@@ -446,25 +446,27 @@ static netdev_tx_t ipip_tunnel_xmit(struct sk_buff *skb, struct net_device *dev)
                goto tx_error;
        }
 
-       if (tiph->frag_off)
+       df |= old_iph->frag_off & htons(IP_DF);
+
+       if (df) {
                mtu = dst_mtu(&rt->u.dst) - sizeof(struct iphdr);
-       else
-               mtu = skb_dst(skb) ? dst_mtu(skb_dst(skb)) : dev->mtu;
 
-       if (mtu < 68) {
-               stats->collisions++;
-               ip_rt_put(rt);
-               goto tx_error;
-       }
-       if (skb_dst(skb))
-               skb_dst(skb)->ops->update_pmtu(skb_dst(skb), mtu);
+               if (mtu < 68) {
+                       stats->collisions++;
+                       ip_rt_put(rt);
+                       goto tx_error;
+               }
 
-       df |= (old_iph->frag_off&htons(IP_DF));
+               if (skb_dst(skb))
+                       skb_dst(skb)->ops->update_pmtu(skb_dst(skb), mtu);
 
-       if ((old_iph->frag_off&htons(IP_DF)) && mtu < ntohs(old_iph->tot_len)) {
-               icmp_send(skb, ICMP_DEST_UNREACH, ICMP_FRAG_NEEDED, htonl(mtu));
-               ip_rt_put(rt);
-               goto tx_error;
+               if ((old_iph->frag_off & htons(IP_DF)) &&
+                   mtu < ntohs(old_iph->tot_len)) {
+                       icmp_send(skb, ICMP_DEST_UNREACH, ICMP_FRAG_NEEDED,
+                                 htonl(mtu));
+                       ip_rt_put(rt);
+                       goto tx_error;
+               }
        }
 
        if (tunnel->err_count > 0) {
@@ -773,17 +775,8 @@ static void ipip_destroy_tunnels(struct ipip_net *ipn, struct list_head *head)
 
 static int ipip_init_net(struct net *net)
 {
+       struct ipip_net *ipn = net_generic(net, ipip_net_id);
        int err;
-       struct ipip_net *ipn;
-
-       err = -ENOMEM;
-       ipn = kzalloc(sizeof(struct ipip_net), GFP_KERNEL);
-       if (ipn == NULL)
-               goto err_alloc;
-
-       err = net_assign_generic(net, ipip_net_id, ipn);
-       if (err < 0)
-               goto err_assign;
 
        ipn->tunnels[0] = ipn->tunnels_wc;
        ipn->tunnels[1] = ipn->tunnels_l;
@@ -810,29 +803,26 @@ err_reg_dev:
        free_netdev(ipn->fb_tunnel_dev);
 err_alloc_dev:
        /* nothing */
-err_assign:
-       kfree(ipn);
-err_alloc:
        return err;
 }
 
 static void ipip_exit_net(struct net *net)
 {
-       struct ipip_net *ipn;
+       struct ipip_net *ipn = net_generic(net, ipip_net_id);
        LIST_HEAD(list);
 
-       ipn = net_generic(net, ipip_net_id);
        rtnl_lock();
        ipip_destroy_tunnels(ipn, &list);
        unregister_netdevice_queue(ipn->fb_tunnel_dev, &list);
        unregister_netdevice_many(&list);
        rtnl_unlock();
-       kfree(ipn);
 }
 
 static struct pernet_operations ipip_net_ops = {
        .init = ipip_init_net,
        .exit = ipip_exit_net,
+       .id   = &ipip_net_id,
+       .size = sizeof(struct ipip_net),
 };
 
 static int __init ipip_init(void)
@@ -846,7 +836,7 @@ static int __init ipip_init(void)
                return -EAGAIN;
        }
 
-       err = register_pernet_gen_device(&ipip_net_id, &ipip_net_ops);
+       err = register_pernet_device(&ipip_net_ops);
        if (err)
                xfrm4_tunnel_deregister(&ipip_handler, AF_INET);
 
@@ -858,7 +848,7 @@ static void __exit ipip_fini(void)
        if (xfrm4_tunnel_deregister(&ipip_handler, AF_INET))
                printk(KERN_INFO "ipip close: can't deregister tunnel\n");
 
-       unregister_pernet_gen_device(ipip_net_id, &ipip_net_ops);
+       unregister_pernet_device(&ipip_net_ops);
 }
 
 module_init(ipip_init);