[NET] CORE: Introducing new memory accounting interface.
[safe/jmp/linux-2.6] / net / core / netpoll.c
index 4581ece..6faa128 100644 (file)
@@ -9,7 +9,6 @@
  * Copyright (C) 2002  Red Hat, Inc.
  */
 
-#include <linux/smp_lock.h>
 #include <linux/netdevice.h>
 #include <linux/etherdevice.h>
 #include <linux/string.h>
@@ -40,8 +39,6 @@ static struct sk_buff_head skb_pool;
 static atomic_t trapped;
 
 #define USEC_PER_POLL  50
-#define NETPOLL_RX_ENABLED  1
-#define NETPOLL_RX_DROP     2
 
 #define MAX_SKB_SIZE \
                (MAX_UDP_CHUNK + sizeof(struct udphdr) + \
@@ -67,8 +64,9 @@ static void queue_process(struct work_struct *work)
 
                local_irq_save(flags);
                netif_tx_lock(dev);
-               if (netif_queue_stopped(dev) ||
-                   dev->hard_start_xmit(skb, dev) != NETDEV_TX_OK) {
+               if ((netif_queue_stopped(dev) ||
+                    netif_subqueue_stopped(dev, skb)) ||
+                    dev->hard_start_xmit(skb, dev) != NETDEV_TX_OK) {
                        skb_queue_head(&npinfo->txq, skb);
                        netif_tx_unlock(dev);
                        local_irq_restore(flags);
@@ -86,7 +84,7 @@ static __sum16 checksum_udp(struct sk_buff *skb, struct udphdr *uh,
 {
        __wsum psum;
 
-       if (uh->check == 0 || skb->ip_summed == CHECKSUM_UNNECESSARY)
+       if (uh->check == 0 || skb_csum_unnecessary(skb))
                return 0;
 
        psum = csum_tcpudp_nofold(saddr, daddr, ulen, IPPROTO_UDP, 0);
@@ -116,51 +114,67 @@ static __sum16 checksum_udp(struct sk_buff *skb, struct udphdr *uh,
  * network adapter, forcing superfluous retries and possibly timeouts.
  * Thus, we set our budget to greater than 1.
  */
-static void poll_napi(struct netpoll *np)
+static int poll_one_napi(struct netpoll_info *npinfo,
+                        struct napi_struct *napi, int budget)
 {
-       struct netpoll_info *npinfo = np->dev->npinfo;
-       int budget = 16;
+       int work;
 
-       if (test_bit(__LINK_STATE_RX_SCHED, &np->dev->state) &&
-           npinfo->poll_owner != smp_processor_id() &&
-           spin_trylock(&npinfo->poll_lock)) {
-               npinfo->rx_flags |= NETPOLL_RX_DROP;
-               atomic_inc(&trapped);
+       /* net_rx_action's ->poll() invocations and our's are
+        * synchronized by this test which is only made while
+        * holding the napi->poll_lock.
+        */
+       if (!test_bit(NAPI_STATE_SCHED, &napi->state))
+               return budget;
 
-               np->dev->poll(np->dev, &budget);
+       atomic_inc(&trapped);
 
-               atomic_dec(&trapped);
-               npinfo->rx_flags &= ~NETPOLL_RX_DROP;
-               spin_unlock(&npinfo->poll_lock);
-       }
+       work = napi->poll(napi, budget);
+
+       atomic_dec(&trapped);
+
+       return budget - work;
 }
 
-static void service_arp_queue(struct netpoll_info *npi)
+static void poll_napi(struct net_device *dev)
 {
-       struct sk_buff *skb;
+       struct napi_struct *napi;
+       int budget = 16;
 
-       if (unlikely(!npi))
-               return;
+       list_for_each_entry(napi, &dev->napi_list, dev_list) {
+               if (napi->poll_owner != smp_processor_id() &&
+                   spin_trylock(&napi->poll_lock)) {
+                       budget = poll_one_napi(dev->npinfo, napi, budget);
+                       spin_unlock(&napi->poll_lock);
 
-       skb = skb_dequeue(&npi->arp_tx);
+                       if (!budget)
+                               break;
+               }
+       }
+}
 
-       while (skb != NULL) {
-               arp_reply(skb);
-               skb = skb_dequeue(&npi->arp_tx);
+static void service_arp_queue(struct netpoll_info *npi)
+{
+       if (npi) {
+               struct sk_buff *skb;
+
+               while ((skb = skb_dequeue(&npi->arp_tx)))
+                       arp_reply(skb);
        }
 }
 
 void netpoll_poll(struct netpoll *np)
 {
-       if (!np->dev || !netif_running(np->dev) || !np->dev->poll_controller)
+       struct net_device *dev = np->dev;
+
+       if (!dev || !netif_running(dev) || !dev->poll_controller)
                return;
 
        /* Process pending work on NIC */
-       np->dev->poll_controller(np->dev);
-       if (np->dev->poll)
-               poll_napi(np);
+       dev->poll_controller(dev);
 
-       service_arp_queue(np->dev->npinfo);
+       poll_napi(dev);
+
+       service_arp_queue(dev->npinfo);
 
        zap_completion_queue();
 }
@@ -233,6 +247,17 @@ repeat:
        return skb;
 }
 
+static int netpoll_owner_active(struct net_device *dev)
+{
+       struct napi_struct *napi;
+
+       list_for_each_entry(napi, &dev->napi_list, dev_list) {
+               if (napi->poll_owner == smp_processor_id())
+                       return 1;
+       }
+       return 0;
+}
+
 static void netpoll_send_skb(struct netpoll *np, struct sk_buff *skb)
 {
        int status = NETDEV_TX_BUSY;
@@ -246,27 +271,28 @@ static void netpoll_send_skb(struct netpoll *np, struct sk_buff *skb)
        }
 
        /* don't get messages out of order, and no recursion */
-       if (skb_queue_len(&npinfo->txq) == 0 &&
-                   npinfo->poll_owner != smp_processor_id()) {
+       if (skb_queue_len(&npinfo->txq) == 0 && !netpoll_owner_active(dev)) {
                unsigned long flags;
 
                local_irq_save(flags);
-               if (netif_tx_trylock(dev)) {
-                       /* try until next clock tick */
-                       for (tries = jiffies_to_usecs(1)/USEC_PER_POLL;
-                                       tries > 0; --tries) {
-                               if (!netif_queue_stopped(dev))
+               /* try until next clock tick */
+               for (tries = jiffies_to_usecs(1)/USEC_PER_POLL;
+                    tries > 0; --tries) {
+                       if (netif_tx_trylock(dev)) {
+                               if (!netif_queue_stopped(dev) &&
+                                   !netif_subqueue_stopped(dev, skb))
                                        status = dev->hard_start_xmit(skb, dev);
+                               netif_tx_unlock(dev);
 
                                if (status == NETDEV_TX_OK)
                                        break;
 
-                               /* tickle device maybe there is some cleanup */
-                               netpoll_poll(np);
-
-                               udelay(USEC_PER_POLL);
                        }
-                       netif_tx_unlock(dev);
+
+                       /* tickle device maybe there is some cleanup */
+                       netpoll_poll(np);
+
+                       udelay(USEC_PER_POLL);
                }
                local_irq_restore(flags);
        }
@@ -293,10 +319,12 @@ void netpoll_send_udp(struct netpoll *np, const char *msg, int len)
        if (!skb)
                return;
 
-       memcpy(skb->data, msg, len);
+       skb_copy_to_linear_data(skb, msg, len);
        skb->len += len;
 
-       skb->h.uh = udph = (struct udphdr *) skb_push(skb, sizeof(*udph));
+       skb_push(skb, sizeof(*udph));
+       skb_reset_transport_header(skb);
+       udph = udp_hdr(skb);
        udph->source = htons(np->local_port);
        udph->dest = htons(np->remote_port);
        udph->len = htons(udp_len);
@@ -308,7 +336,9 @@ void netpoll_send_udp(struct netpoll *np, const char *msg, int len)
        if (udph->check == 0)
                udph->check = CSUM_MANGLED_0;
 
-       skb->nh.iph = iph = (struct iphdr *)skb_push(skb, sizeof(*iph));
+       skb_push(skb, sizeof(*iph));
+       skb_reset_network_header(skb);
+       iph = ip_hdr(skb);
 
        /* iph->version = 4; iph->ihl = 5; */
        put_unaligned(0x45, (unsigned char *)iph);
@@ -324,10 +354,10 @@ void netpoll_send_udp(struct netpoll *np, const char *msg, int len)
        iph->check    = ip_fast_csum((unsigned char *)iph, iph->ihl);
 
        eth = (struct ethhdr *) skb_push(skb, ETH_HLEN);
-       skb->mac.raw = skb->data;
+       skb_reset_mac_header(skb);
        skb->protocol = eth->h_proto = htons(ETH_P_IP);
-       memcpy(eth->h_source, np->local_mac, 6);
-       memcpy(eth->h_dest, np->remote_mac, 6);
+       memcpy(eth->h_source, np->dev->dev_addr, ETH_ALEN);
+       memcpy(eth->h_dest, np->remote_mac, ETH_ALEN);
 
        skb->dev = np->dev;
 
@@ -359,8 +389,9 @@ static void arp_reply(struct sk_buff *skb)
                                 (2 * sizeof(u32)))))
                return;
 
-       skb->h.raw = skb->nh.raw = skb->data;
-       arp = skb->nh.arph;
+       skb_reset_network_header(skb);
+       skb_reset_transport_header(skb);
+       arp = arp_hdr(skb);
 
        if ((arp->ar_hrd != htons(ARPHRD_ETHER) &&
             arp->ar_hrd != htons(ARPHRD_IEEE802)) ||
@@ -379,7 +410,8 @@ static void arp_reply(struct sk_buff *skb)
        memcpy(&tip, arp_ptr, 4);
 
        /* Should we ignore arp? */
-       if (tip != htonl(np->local_ip) || LOOPBACK(tip) || MULTICAST(tip))
+       if (tip != htonl(np->local_ip) ||
+           ipv4_is_loopback(tip) || ipv4_is_multicast(tip))
                return;
 
        size = sizeof(struct arphdr) + 2 * (skb->dev->addr_len + 4);
@@ -389,17 +421,15 @@ static void arp_reply(struct sk_buff *skb)
        if (!send_skb)
                return;
 
-       send_skb->nh.raw = send_skb->data;
+       skb_reset_network_header(send_skb);
        arp = (struct arphdr *) skb_put(send_skb, size);
        send_skb->dev = skb->dev;
        send_skb->protocol = htons(ETH_P_ARP);
 
        /* Fill the device header for the ARP frame */
-
-       if (np->dev->hard_header &&
-           np->dev->hard_header(send_skb, skb->dev, ptype,
-                                sha, np->local_mac,
-                                send_skb->len) < 0) {
+       if (dev_hard_header(send_skb, skb->dev, ptype,
+                           sha, np->dev->dev_addr,
+                           send_skb->len) < 0) {
                kfree_skb(send_skb);
                return;
        }
@@ -442,8 +472,8 @@ int __netpoll_rx(struct sk_buff *skb)
        if (skb->dev->type != ARPHRD_ETHER)
                goto out;
 
-       /* check if netpoll clients need ARP */
-       if (skb->protocol == __constant_htons(ETH_P_ARP) &&
+       /* if receive ARP during middle of NAPI poll, then queue */
+       if (skb->protocol == htons(ETH_P_ARP) &&
            atomic_read(&trapped)) {
                skb_queue_tail(&npi->arp_tx, skb);
                return 1;
@@ -504,6 +534,9 @@ int __netpoll_rx(struct sk_buff *skb)
        return 1;
 
 out:
+       /* If packet received while already in poll then just
+        * silently drop.
+        */
        if (atomic_read(&trapped)) {
                kfree_skb(skb);
                return 1;
@@ -512,6 +545,23 @@ out:
        return 0;
 }
 
+void netpoll_print_options(struct netpoll *np)
+{
+       DECLARE_MAC_BUF(mac);
+       printk(KERN_INFO "%s: local port %d\n",
+                        np->name, np->local_port);
+       printk(KERN_INFO "%s: local IP %d.%d.%d.%d\n",
+                        np->name, HIPQUAD(np->local_ip));
+       printk(KERN_INFO "%s: interface %s\n",
+                        np->name, np->dev_name);
+       printk(KERN_INFO "%s: remote port %d\n",
+                        np->name, np->remote_port);
+       printk(KERN_INFO "%s: remote IP %d.%d.%d.%d\n",
+                        np->name, HIPQUAD(np->remote_ip));
+       printk(KERN_INFO "%s: remote ethernet address %s\n",
+                        np->name, print_mac(mac, np->remote_mac));
+}
+
 int netpoll_parse_options(struct netpoll *np, char *opt)
 {
        char *cur=opt, *delim;
@@ -524,7 +574,6 @@ int netpoll_parse_options(struct netpoll *np, char *opt)
                cur = delim;
        }
        cur++;
-       printk(KERN_INFO "%s: local port %d\n", np->name, np->local_port);
 
        if (*cur != '/') {
                if ((delim = strchr(cur, '/')) == NULL)
@@ -532,9 +581,6 @@ int netpoll_parse_options(struct netpoll *np, char *opt)
                *delim = 0;
                np->local_ip = ntohl(in_aton(cur));
                cur = delim;
-
-               printk(KERN_INFO "%s: local IP %d.%d.%d.%d\n",
-                      np->name, HIPQUAD(np->local_ip));
        }
        cur++;
 
@@ -548,8 +594,6 @@ int netpoll_parse_options(struct netpoll *np, char *opt)
        }
        cur++;
 
-       printk(KERN_INFO "%s: interface %s\n", np->name, np->dev_name);
-
        if (*cur != '@') {
                /* dst port */
                if ((delim = strchr(cur, '@')) == NULL)
@@ -559,7 +603,6 @@ int netpoll_parse_options(struct netpoll *np, char *opt)
                cur = delim;
        }
        cur++;
-       printk(KERN_INFO "%s: remote port %d\n", np->name, np->remote_port);
 
        /* dst ip */
        if ((delim = strchr(cur, '/')) == NULL)
@@ -568,9 +611,6 @@ int netpoll_parse_options(struct netpoll *np, char *opt)
        np->remote_ip = ntohl(in_aton(cur));
        cur = delim + 1;
 
-       printk(KERN_INFO "%s: remote IP %d.%d.%d.%d\n",
-              np->name, HIPQUAD(np->remote_ip));
-
        if (*cur != 0) {
                /* MAC address */
                if ((delim = strchr(cur, ':')) == NULL)
@@ -601,15 +641,7 @@ int netpoll_parse_options(struct netpoll *np, char *opt)
                np->remote_mac[5] = simple_strtol(cur, NULL, 16);
        }
 
-       printk(KERN_INFO "%s: remote ethernet address "
-              "%02x:%02x:%02x:%02x:%02x:%02x\n",
-              np->name,
-              np->remote_mac[0],
-              np->remote_mac[1],
-              np->remote_mac[2],
-              np->remote_mac[3],
-              np->remote_mac[4],
-              np->remote_mac[5]);
+       netpoll_print_options(np);
 
        return 0;
 
@@ -628,7 +660,7 @@ int netpoll_setup(struct netpoll *np)
        int err;
 
        if (np->dev_name)
-               ndev = dev_get_by_name(np->dev_name);
+               ndev = dev_get_by_name(&init_net, np->dev_name);
        if (!ndev) {
                printk(KERN_ERR "%s: %s doesn't exist, aborting.\n",
                       np->name, np->dev_name);
@@ -643,10 +675,7 @@ int netpoll_setup(struct netpoll *np)
                        goto release;
                }
 
-               npinfo->rx_flags = 0;
                npinfo->rx_np = NULL;
-               spin_lock_init(&npinfo->poll_lock);
-               npinfo->poll_owner = -1;
 
                spin_lock_init(&npinfo->rx_lock);
                skb_queue_head_init(&npinfo->arp_tx);
@@ -707,9 +736,6 @@ int netpoll_setup(struct netpoll *np)
                }
        }
 
-       if (is_zero_ether_addr(np->local_mac) && ndev->dev_addr)
-               memcpy(np->local_mac, ndev->dev_addr, 6);
-
        if (!np->local_ip) {
                rcu_read_lock();
                in_dev = __in_dev_get_rcu(ndev);
@@ -730,7 +756,6 @@ int netpoll_setup(struct netpoll *np)
 
        if (np->rx_hook) {
                spin_lock_irqsave(&npinfo->rx_lock, flags);
-               npinfo->rx_flags |= NETPOLL_RX_ENABLED;
                npinfo->rx_np = np;
                spin_unlock_irqrestore(&npinfo->rx_lock, flags);
        }
@@ -772,18 +797,18 @@ void netpoll_cleanup(struct netpoll *np)
                        if (npinfo->rx_np == np) {
                                spin_lock_irqsave(&npinfo->rx_lock, flags);
                                npinfo->rx_np = NULL;
-                               npinfo->rx_flags &= ~NETPOLL_RX_ENABLED;
                                spin_unlock_irqrestore(&npinfo->rx_lock, flags);
                        }
 
-                       np->dev->npinfo = NULL;
                        if (atomic_dec_and_test(&npinfo->refcnt)) {
                                skb_queue_purge(&npinfo->arp_tx);
                                skb_queue_purge(&npinfo->txq);
                                cancel_rearming_delayed_work(&npinfo->tx_work);
-                               flush_scheduled_work();
 
+                               /* clean after last, unfinished work */
+                               __skb_queue_purge(&npinfo->txq);
                                kfree(npinfo);
+                               np->dev->npinfo = NULL;
                        }
                }
 
@@ -808,6 +833,7 @@ void netpoll_set_trap(int trap)
 
 EXPORT_SYMBOL(netpoll_set_trap);
 EXPORT_SYMBOL(netpoll_trap);
+EXPORT_SYMBOL(netpoll_print_options);
 EXPORT_SYMBOL(netpoll_parse_options);
 EXPORT_SYMBOL(netpoll_setup);
 EXPORT_SYMBOL(netpoll_cleanup);