drm/vmwgfx: return -EFAULT for copy_to_user errors
[safe/jmp/linux-2.6] / kernel / power / swap.c
index 917aba1..b0bb217 100644 (file)
@@ -13,8 +13,6 @@
 
 #include <linux/module.h>
 #include <linux/file.h>
-#include <linux/utsname.h>
-#include <linux/version.h>
 #include <linux/delay.h>
 #include <linux/bitops.h>
 #include <linux/genhd.h>
 #include <linux/swap.h>
 #include <linux/swapops.h>
 #include <linux/pm.h>
+#include <linux/slab.h>
 
 #include "power.h"
 
-extern char resume_file[];
-
 #define SWSUSP_SIG     "S1SUSPEND"
 
+/*
+ *     The swap map is a data structure used for keeping track of each page
+ *     written to a swap partition.  It consists of many swap_map_page
+ *     structures that contain each an array of MAP_PAGE_SIZE swap entries.
+ *     These structures are stored on the swap and linked together with the
+ *     help of the .next_swap member.
+ *
+ *     The swap map is created during suspend.  The swap map pages are
+ *     allocated and populated one at a time, so we only need one memory
+ *     page to set up the entire structure.
+ *
+ *     During resume we also only need to use one swap_map_page structure
+ *     at a time.
+ */
+
+#define MAP_PAGE_ENTRIES       (PAGE_SIZE / sizeof(sector_t) - 1)
+
+struct swap_map_page {
+       sector_t entries[MAP_PAGE_ENTRIES];
+       sector_t next_swap;
+};
+
+/**
+ *     The swap_map_handle structure is used for handling swap in
+ *     a file-alike way
+ */
+
+struct swap_map_handle {
+       struct swap_map_page *cur;
+       sector_t cur_swap;
+       sector_t first_sector;
+       unsigned int k;
+};
+
 struct swsusp_header {
        char reserved[PAGE_SIZE - 20 - sizeof(sector_t) - sizeof(int)];
        sector_t image;
@@ -42,118 +73,133 @@ struct swsusp_header {
 
 static struct swsusp_header *swsusp_header;
 
-/*
- * General things
+/**
+ *     The following functions are used for tracing the allocated
+ *     swap pages, so that they can be freed in case of an error.
  */
 
-static unsigned short root_swap = 0xffff;
-static struct block_device *resume_bdev;
+struct swsusp_extent {
+       struct rb_node node;
+       unsigned long start;
+       unsigned long end;
+};
 
-/**
- *     submit - submit BIO request.
- *     @rw:    READ or WRITE.
- *     @off    physical offset of page.
- *     @page:  page we're reading or writing.
- *     @bio_chain: list of pending biod (for async reading)
- *
- *     Straight from the textbook - allocate and initialize the bio.
- *     If we're reading, make sure the page is marked as dirty.
- *     Then submit it and, if @bio_chain == NULL, wait.
- */
-static int submit(int rw, pgoff_t page_off, struct page *page,
-                       struct bio **bio_chain)
-{
-       struct bio *bio;
+static struct rb_root swsusp_extents = RB_ROOT;
 
-       bio = bio_alloc(__GFP_WAIT | __GFP_HIGH, 1);
-       if (!bio)
+static int swsusp_extents_insert(unsigned long swap_offset)
+{
+       struct rb_node **new = &(swsusp_extents.rb_node);
+       struct rb_node *parent = NULL;
+       struct swsusp_extent *ext;
+
+       /* Figure out where to put the new node */
+       while (*new) {
+               ext = container_of(*new, struct swsusp_extent, node);
+               parent = *new;
+               if (swap_offset < ext->start) {
+                       /* Try to merge */
+                       if (swap_offset == ext->start - 1) {
+                               ext->start--;
+                               return 0;
+                       }
+                       new = &((*new)->rb_left);
+               } else if (swap_offset > ext->end) {
+                       /* Try to merge */
+                       if (swap_offset == ext->end + 1) {
+                               ext->end++;
+                               return 0;
+                       }
+                       new = &((*new)->rb_right);
+               } else {
+                       /* It already is in the tree */
+                       return -EINVAL;
+               }
+       }
+       /* Add the new node and rebalance the tree. */
+       ext = kzalloc(sizeof(struct swsusp_extent), GFP_KERNEL);
+       if (!ext)
                return -ENOMEM;
-       bio->bi_sector = page_off * (PAGE_SIZE >> 9);
-       bio->bi_bdev = resume_bdev;
-       bio->bi_end_io = end_swap_bio_read;
 
-       if (bio_add_page(bio, page, PAGE_SIZE, 0) < PAGE_SIZE) {
-               printk("swsusp: ERROR: adding page to bio at %ld\n", page_off);
-               bio_put(bio);
-               return -EFAULT;
-       }
+       ext->start = swap_offset;
+       ext->end = swap_offset;
+       rb_link_node(&ext->node, parent, new);
+       rb_insert_color(&ext->node, &swsusp_extents);
+       return 0;
+}
+
+/**
+ *     alloc_swapdev_block - allocate a swap page and register that it has
+ *     been allocated, so that it can be freed in case of an error.
+ */
 
-       lock_page(page);
-       bio_get(bio);
+sector_t alloc_swapdev_block(int swap)
+{
+       unsigned long offset;
 
-       if (bio_chain == NULL) {
-               submit_bio(rw | (1 << BIO_RW_SYNC), bio);
-               wait_on_page_locked(page);
-               if (rw == READ)
-                       bio_set_pages_dirty(bio);
-               bio_put(bio);
-       } else {
-               if (rw == READ)
-                       get_page(page); /* These pages are freed later */
-               bio->bi_private = *bio_chain;
-               *bio_chain = bio;
-               submit_bio(rw | (1 << BIO_RW_SYNC), bio);
+       offset = swp_offset(get_swap_page_of_type(swap));
+       if (offset) {
+               if (swsusp_extents_insert(offset))
+                       swap_free(swp_entry(swap, offset));
+               else
+                       return swapdev_block(swap, offset);
        }
        return 0;
 }
 
-static int bio_read_page(pgoff_t page_off, void *addr, struct bio **bio_chain)
-{
-       return submit(READ, page_off, virt_to_page(addr), bio_chain);
-}
+/**
+ *     free_all_swap_pages - free swap pages allocated for saving image data.
+ *     It also frees the extents used to register which swap entres had been
+ *     allocated.
+ */
 
-static int bio_write_page(pgoff_t page_off, void *addr, struct bio **bio_chain)
+void free_all_swap_pages(int swap)
 {
-       return submit(WRITE, page_off, virt_to_page(addr), bio_chain);
+       struct rb_node *node;
+
+       while ((node = swsusp_extents.rb_node)) {
+               struct swsusp_extent *ext;
+               unsigned long offset;
+
+               ext = container_of(node, struct swsusp_extent, node);
+               rb_erase(node, &swsusp_extents);
+               for (offset = ext->start; offset <= ext->end; offset++)
+                       swap_free(swp_entry(swap, offset));
+
+               kfree(ext);
+       }
 }
 
-static int wait_on_bio_chain(struct bio **bio_chain)
+int swsusp_swap_in_use(void)
 {
-       struct bio *bio;
-       struct bio *next_bio;
-       int ret = 0;
-
-       if (bio_chain == NULL)
-               return 0;
-
-       bio = *bio_chain;
-       if (bio == NULL)
-               return 0;
-       while (bio) {
-               struct page *page;
-
-               next_bio = bio->bi_private;
-               page = bio->bi_io_vec[0].bv_page;
-               wait_on_page_locked(page);
-               if (!PageUptodate(page) || PageError(page))
-                       ret = -EIO;
-               put_page(page);
-               bio_put(bio);
-               bio = next_bio;
-       }
-       *bio_chain = NULL;
-       return ret;
+       return (swsusp_extents.rb_node != NULL);
 }
 
 /*
+ * General things
+ */
+
+static unsigned short root_swap = 0xffff;
+struct block_device *hib_resume_bdev;
+
+/*
  * Saving part
  */
 
-static int mark_swapfiles(sector_t start, unsigned int flags)
+static int mark_swapfiles(struct swap_map_handle *handle, unsigned int flags)
 {
        int error;
 
-       bio_read_page(swsusp_resume_block, swsusp_header, NULL);
+       hib_bio_read_page(swsusp_resume_block, swsusp_header, NULL);
        if (!memcmp("SWAP-SPACE",swsusp_header->sig, 10) ||
            !memcmp("SWAPSPACE2",swsusp_header->sig, 10)) {
                memcpy(swsusp_header->orig_sig,swsusp_header->sig, 10);
                memcpy(swsusp_header->sig,SWSUSP_SIG, 10);
-               swsusp_header->image = start;
+               swsusp_header->image = handle->first_sector;
                swsusp_header->flags = flags;
-               error = bio_write_page(swsusp_resume_block,
+               error = hib_bio_write_page(swsusp_resume_block,
                                        swsusp_header, NULL);
        } else {
-               printk(KERN_ERR "swsusp: Swap header not found!\n");
+               printk(KERN_ERR "PM: Swap header not found!\n");
                error = -ENODEV;
        }
        return error;
@@ -162,25 +208,26 @@ static int mark_swapfiles(sector_t start, unsigned int flags)
 /**
  *     swsusp_swap_check - check if the resume device is a swap device
  *     and get its index (if so)
+ *
+ *     This is called before saving image
  */
-
-static int swsusp_swap_check(void) /* This is called before saving image */
+static int swsusp_swap_check(void)
 {
        int res;
 
        res = swap_type_of(swsusp_resume_device, swsusp_resume_block,
-                       &resume_bdev);
+                       &hib_resume_bdev);
        if (res < 0)
                return res;
 
        root_swap = res;
-       res = blkdev_get(resume_bdev, FMODE_WRITE, O_RDWR);
+       res = blkdev_get(hib_resume_bdev, FMODE_WRITE);
        if (res)
                return res;
 
-       res = set_blocksize(resume_bdev, PAGE_SIZE);
+       res = set_blocksize(hib_resume_bdev, PAGE_SIZE);
        if (res < 0)
-               blkdev_put(resume_bdev);
+               blkdev_put(hib_resume_bdev, FMODE_WRITE);
 
        return res;
 }
@@ -211,42 +258,9 @@ static int write_page(void *buf, sector_t offset, struct bio **bio_chain)
        } else {
                src = buf;
        }
-       return bio_write_page(offset, src, bio_chain);
+       return hib_bio_write_page(offset, src, bio_chain);
 }
 
-/*
- *     The swap map is a data structure used for keeping track of each page
- *     written to a swap partition.  It consists of many swap_map_page
- *     structures that contain each an array of MAP_PAGE_SIZE swap entries.
- *     These structures are stored on the swap and linked together with the
- *     help of the .next_swap member.
- *
- *     The swap map is created during suspend.  The swap map pages are
- *     allocated and populated one at a time, so we only need one memory
- *     page to set up the entire structure.
- *
- *     During resume we also only need to use one swap_map_page structure
- *     at a time.
- */
-
-#define MAP_PAGE_ENTRIES       (PAGE_SIZE / sizeof(sector_t) - 1)
-
-struct swap_map_page {
-       sector_t entries[MAP_PAGE_ENTRIES];
-       sector_t next_swap;
-};
-
-/**
- *     The swap_map_handle structure is used for handling swap in
- *     a file-alike way
- */
-
-struct swap_map_handle {
-       struct swap_map_page *cur;
-       sector_t cur_swap;
-       unsigned int k;
-};
-
 static void release_swap_writer(struct swap_map_handle *handle)
 {
        if (handle->cur)
@@ -256,16 +270,33 @@ static void release_swap_writer(struct swap_map_handle *handle)
 
 static int get_swap_writer(struct swap_map_handle *handle)
 {
+       int ret;
+
+       ret = swsusp_swap_check();
+       if (ret) {
+               if (ret != -ENOSPC)
+                       printk(KERN_ERR "PM: Cannot find swap device, try "
+                                       "swapon -a.\n");
+               return ret;
+       }
        handle->cur = (struct swap_map_page *)get_zeroed_page(GFP_KERNEL);
-       if (!handle->cur)
-               return -ENOMEM;
+       if (!handle->cur) {
+               ret = -ENOMEM;
+               goto err_close;
+       }
        handle->cur_swap = alloc_swapdev_block(root_swap);
        if (!handle->cur_swap) {
-               release_swap_writer(handle);
-               return -ENOSPC;
+               ret = -ENOSPC;
+               goto err_rel;
        }
        handle->k = 0;
+       handle->first_sector = handle->cur_swap;
        return 0;
+err_rel:
+       release_swap_writer(handle);
+err_close:
+       swsusp_close(FMODE_WRITE);
+       return ret;
 }
 
 static int swap_write_page(struct swap_map_handle *handle, void *buf,
@@ -282,7 +313,7 @@ static int swap_write_page(struct swap_map_handle *handle, void *buf,
                return error;
        handle->cur->entries[handle->k++] = offset;
        if (handle->k >= MAP_PAGE_ENTRIES) {
-               error = wait_on_bio_chain(bio_chain);
+               error = hib_wait_on_bio_chain(bio_chain);
                if (error)
                        goto out;
                offset = alloc_swapdev_block(root_swap);
@@ -308,6 +339,24 @@ static int flush_swap_writer(struct swap_map_handle *handle)
                return -EINVAL;
 }
 
+static int swap_writer_finish(struct swap_map_handle *handle,
+               unsigned int flags, int error)
+{
+       if (!error) {
+               flush_swap_writer(handle);
+               printk(KERN_INFO "PM: S");
+               error = mark_swapfiles(handle, flags);
+               printk("|\n");
+       }
+
+       if (error)
+               free_all_swap_pages(root_swap);
+       release_swap_writer(handle);
+       swsusp_close(FMODE_WRITE);
+
+       return error;
+}
+
 /**
  *     save_image - save the suspend image data
  */
@@ -318,40 +367,41 @@ static int save_image(struct swap_map_handle *handle,
 {
        unsigned int m;
        int ret;
-       int error = 0;
        int nr_pages;
        int err2;
        struct bio *bio;
        struct timeval start;
        struct timeval stop;
 
-       printk("Saving image data pages (%u pages) ...     ", nr_to_write);
+       printk(KERN_INFO "PM: Saving image data pages (%u pages) ...     ",
+               nr_to_write);
        m = nr_to_write / 100;
        if (!m)
                m = 1;
        nr_pages = 0;
        bio = NULL;
        do_gettimeofday(&start);
-       do {
-               ret = snapshot_read_next(snapshot, PAGE_SIZE);
-               if (ret > 0) {
-                       error = swap_write_page(handle, data_of(*snapshot),
-                                               &bio);
-                       if (error)
-                               break;
-                       if (!(nr_pages % m))
-                               printk("\b\b\b\b%3d%%", nr_pages / m);
-                       nr_pages++;
-               }
-       } while (ret > 0);
-       err2 = wait_on_bio_chain(&bio);
+       while (1) {
+               ret = snapshot_read_next(snapshot);
+               if (ret <= 0)
+                       break;
+               ret = swap_write_page(handle, data_of(*snapshot), &bio);
+               if (ret)
+                       break;
+               if (!(nr_pages % m))
+                       printk(KERN_CONT "\b\b\b\b%3d%%", nr_pages / m);
+               nr_pages++;
+       }
+       err2 = hib_wait_on_bio_chain(&bio);
        do_gettimeofday(&stop);
-       if (!error)
-               error = err2;
-       if (!error)
-               printk("\b\b\b\bdone\n");
+       if (!ret)
+               ret = err2;
+       if (!ret)
+               printk(KERN_CONT "\b\b\b\bdone\n");
+       else
+               printk(KERN_CONT "\n");
        swsusp_show_speed(&start, &stop, nr_to_write, "Wrote");
-       return error;
+       return ret;
 }
 
 /**
@@ -365,7 +415,7 @@ static int enough_swap(unsigned int nr_pages)
 {
        unsigned int free_swap = count_swap_pages(root_swap, 1);
 
-       pr_debug("swsusp: free swap pages: %u\n", free_swap);
+       pr_debug("PM: Free swap pages: %u\n", free_swap);
        return free_swap > nr_pages + PAGES_FOR_IO;
 }
 
@@ -384,50 +434,34 @@ int swsusp_write(unsigned int flags)
        struct swap_map_handle handle;
        struct snapshot_handle snapshot;
        struct swsusp_info *header;
+       unsigned long pages;
        int error;
 
-       error = swsusp_swap_check();
+       pages = snapshot_get_image_size();
+       error = get_swap_writer(&handle);
        if (error) {
-               printk(KERN_ERR "swsusp: Cannot find swap device, try "
-                               "swapon -a.\n");
+               printk(KERN_ERR "PM: Cannot get swap writer\n");
                return error;
        }
+       if (!enough_swap(pages)) {
+               printk(KERN_ERR "PM: Not enough free swap\n");
+               error = -ENOSPC;
+               goto out_finish;
+       }
        memset(&snapshot, 0, sizeof(struct snapshot_handle));
-       error = snapshot_read_next(&snapshot, PAGE_SIZE);
+       error = snapshot_read_next(&snapshot);
        if (error < PAGE_SIZE) {
                if (error >= 0)
                        error = -EFAULT;
 
-               goto out;
+               goto out_finish;
        }
        header = (struct swsusp_info *)data_of(snapshot);
-       if (!enough_swap(header->pages)) {
-               printk(KERN_ERR "swsusp: Not enough free swap\n");
-               error = -ENOSPC;
-               goto out;
-       }
-       error = get_swap_writer(&handle);
-       if (!error) {
-               sector_t start = handle.cur_swap;
-
-               error = swap_write_page(&handle, header, NULL);
-               if (!error)
-                       error = save_image(&handle, &snapshot,
-                                       header->pages - 1);
-
-               if (!error) {
-                       flush_swap_writer(&handle);
-                       printk("S");
-                       error = mark_swapfiles(start, flags);
-                       printk("|\n");
-               }
-       }
-       if (error)
-               free_all_swap_pages(root_swap);
-
-       release_swap_writer(&handle);
- out:
-       swsusp_close();
+       error = swap_write_page(&handle, header, NULL);
+       if (!error)
+               error = save_image(&handle, &snapshot, pages - 1);
+out_finish:
+       error = swap_writer_finish(&handle, flags, error);
        return error;
 }
 
@@ -443,18 +477,21 @@ static void release_swap_reader(struct swap_map_handle *handle)
        handle->cur = NULL;
 }
 
-static int get_swap_reader(struct swap_map_handle *handle, sector_t start)
+static int get_swap_reader(struct swap_map_handle *handle,
+               unsigned int *flags_p)
 {
        int error;
 
-       if (!start)
+       *flags_p = swsusp_header->flags;
+
+       if (!swsusp_header->image) /* how can this happen? */
                return -EINVAL;
 
        handle->cur = (struct swap_map_page *)get_zeroed_page(__GFP_WAIT | __GFP_HIGH);
        if (!handle->cur)
                return -ENOMEM;
 
-       error = bio_read_page(start, handle->cur, NULL);
+       error = hib_bio_read_page(swsusp_header->image, handle->cur, NULL);
        if (error) {
                release_swap_reader(handle);
                return error;
@@ -474,21 +511,28 @@ static int swap_read_page(struct swap_map_handle *handle, void *buf,
        offset = handle->cur->entries[handle->k];
        if (!offset)
                return -EFAULT;
-       error = bio_read_page(offset, buf, bio_chain);
+       error = hib_bio_read_page(offset, buf, bio_chain);
        if (error)
                return error;
        if (++handle->k >= MAP_PAGE_ENTRIES) {
-               error = wait_on_bio_chain(bio_chain);
+               error = hib_wait_on_bio_chain(bio_chain);
                handle->k = 0;
                offset = handle->cur->next_swap;
                if (!offset)
                        release_swap_reader(handle);
                else if (!error)
-                       error = bio_read_page(offset, handle->cur, NULL);
+                       error = hib_bio_read_page(offset, handle->cur, NULL);
        }
        return error;
 }
 
+static int swap_reader_finish(struct swap_map_handle *handle)
+{
+       release_swap_reader(handle);
+
+       return 0;
+}
+
 /**
  *     load_image - load the image using the swap map handle
  *     @handle and the snapshot handle @snapshot
@@ -507,7 +551,8 @@ static int load_image(struct swap_map_handle *handle,
        int err2;
        unsigned nr_pages;
 
-       printk("Loading image data pages (%u pages) ...     ", nr_to_read);
+       printk(KERN_INFO "PM: Loading image data pages (%u pages) ...     ",
+               nr_to_read);
        m = nr_to_read / 100;
        if (!m)
                m = 1;
@@ -515,21 +560,21 @@ static int load_image(struct swap_map_handle *handle,
        bio = NULL;
        do_gettimeofday(&start);
        for ( ; ; ) {
-               error = snapshot_write_next(snapshot, PAGE_SIZE);
+               error = snapshot_write_next(snapshot);
                if (error <= 0)
                        break;
                error = swap_read_page(handle, data_of(*snapshot), &bio);
                if (error)
                        break;
                if (snapshot->sync_read)
-                       error = wait_on_bio_chain(&bio);
+                       error = hib_wait_on_bio_chain(&bio);
                if (error)
                        break;
                if (!(nr_pages % m))
                        printk("\b\b\b\b%3d%%", nr_pages / m);
                nr_pages++;
        }
-       err2 = wait_on_bio_chain(&bio);
+       err2 = hib_wait_on_bio_chain(&bio);
        do_gettimeofday(&stop);
        if (!error)
                error = err2;
@@ -538,7 +583,8 @@ static int load_image(struct swap_map_handle *handle,
                snapshot_write_finalize(snapshot);
                if (!snapshot_image_loaded(snapshot))
                        error = -ENODATA;
-       }
+       } else
+               printk("\n");
        swsusp_show_speed(&start, &stop, nr_to_read, "Read");
        return error;
 }
@@ -556,30 +602,24 @@ int swsusp_read(unsigned int *flags_p)
        struct snapshot_handle snapshot;
        struct swsusp_info *header;
 
-       *flags_p = swsusp_header->flags;
-       if (IS_ERR(resume_bdev)) {
-               pr_debug("swsusp: block device not initialised\n");
-               return PTR_ERR(resume_bdev);
-       }
-
        memset(&snapshot, 0, sizeof(struct snapshot_handle));
-       error = snapshot_write_next(&snapshot, PAGE_SIZE);
+       error = snapshot_write_next(&snapshot);
        if (error < PAGE_SIZE)
                return error < 0 ? error : -EFAULT;
        header = (struct swsusp_info *)data_of(snapshot);
-       error = get_swap_reader(&handle, swsusp_header->image);
+       error = get_swap_reader(&handle, flags_p);
+       if (error)
+               goto end;
        if (!error)
                error = swap_read_page(&handle, header, NULL);
        if (!error)
                error = load_image(&handle, &snapshot, header->pages - 1);
-       release_swap_reader(&handle);
-
-       blkdev_put(resume_bdev);
-
+       swap_reader_finish(&handle);
+end:
        if (!error)
-               pr_debug("swsusp: Reading resume file was successful\n");
+               pr_debug("PM: Image successfully loaded\n");
        else
-               pr_debug("swsusp: Error %d resuming\n", error);
+               pr_debug("PM: Error %d resuming\n", error);
        return error;
 }
 
@@ -591,33 +631,35 @@ int swsusp_check(void)
 {
        int error;
 
-       resume_bdev = open_by_devnum(swsusp_resume_device, FMODE_READ);
-       if (!IS_ERR(resume_bdev)) {
-               set_blocksize(resume_bdev, PAGE_SIZE);
+       hib_resume_bdev = open_by_devnum(swsusp_resume_device, FMODE_READ);
+       if (!IS_ERR(hib_resume_bdev)) {
+               set_blocksize(hib_resume_bdev, PAGE_SIZE);
                memset(swsusp_header, 0, PAGE_SIZE);
-               error = bio_read_page(swsusp_resume_block,
+               error = hib_bio_read_page(swsusp_resume_block,
                                        swsusp_header, NULL);
                if (error)
-                       return error;
+                       goto put;
 
                if (!memcmp(SWSUSP_SIG, swsusp_header->sig, 10)) {
                        memcpy(swsusp_header->sig, swsusp_header->orig_sig, 10);
                        /* Reset swap signature now */
-                       error = bio_write_page(swsusp_resume_block,
+                       error = hib_bio_write_page(swsusp_resume_block,
                                                swsusp_header, NULL);
                } else {
-                       return -EINVAL;
+                       error = -EINVAL;
                }
+
+put:
                if (error)
-                       blkdev_put(resume_bdev);
+                       blkdev_put(hib_resume_bdev, FMODE_READ);
                else
-                       pr_debug("swsusp: Signature found, resuming\n");
+                       pr_debug("PM: Signature found, resuming\n");
        } else {
-               error = PTR_ERR(resume_bdev);
+               error = PTR_ERR(hib_resume_bdev);
        }
 
        if (error)
-               pr_debug("swsusp: Error %d check for resume file\n", error);
+               pr_debug("PM: Error %d checking image file\n", error);
 
        return error;
 }
@@ -626,14 +668,14 @@ int swsusp_check(void)
  *     swsusp_close - close swap device.
  */
 
-void swsusp_close(void)
+void swsusp_close(fmode_t mode)
 {
-       if (IS_ERR(resume_bdev)) {
-               pr_debug("swsusp: block device not initialised\n");
+       if (IS_ERR(hib_resume_bdev)) {
+               pr_debug("PM: Image device not initialised\n");
                return;
        }
 
-       blkdev_put(resume_bdev);
+       blkdev_put(hib_resume_bdev, mode);
 }
 
 static int swsusp_header_init(void)