udf: Fix regression in UDF anchor block detection
[safe/jmp/linux-2.6] / fs / udf / inode.c
index 487bdb7..6e74b11 100644 (file)
@@ -37,6 +37,7 @@
 #include <linux/buffer_head.h>
 #include <linux/writeback.h>
 #include <linux/slab.h>
+#include <linux/crc-itu-t.h>
 
 #include "udf_i.h"
 #include "udf_sb.h"
@@ -52,7 +53,7 @@ static int udf_update_inode(struct inode *, int);
 static void udf_fill_inode(struct inode *, struct buffer_head *);
 static int udf_alloc_i_data(struct inode *inode, size_t size);
 static struct buffer_head *inode_getblk(struct inode *, sector_t, int *,
-                                       long *, int *);
+                                       sector_t *, int *);
 static int8_t udf_insert_aext(struct inode *, struct extent_position,
                              kernel_lb_addr, uint32_t);
 static void udf_split_extents(struct inode *, int *, int, int,
@@ -66,22 +67,7 @@ static void udf_update_extents(struct inode *,
                               struct extent_position *);
 static int udf_get_block(struct inode *, sector_t, struct buffer_head *, int);
 
-/*
- * udf_delete_inode
- *
- * PURPOSE
- *     Clean-up before the specified inode is destroyed.
- *
- * DESCRIPTION
- *     This routine is called when the kernel destroys an inode structure
- *     ie. when iput() finds i_count == 0.
- *
- * HISTORY
- *     July 1, 1997 - Andrew E. Mileski
- *     Written, tested, and released.
- *
- *  Called at the last iput() if i_nlink is zero.
- */
+
 void udf_delete_inode(struct inode *inode)
 {
        truncate_inode_pages(&inode->i_data, 0);
@@ -112,16 +98,18 @@ no_delete:
  */
 void udf_clear_inode(struct inode *inode)
 {
+       struct udf_inode_info *iinfo;
        if (!(inode->i_sb->s_flags & MS_RDONLY)) {
                lock_kernel();
                /* Discard preallocation for directories, symlinks, etc. */
                udf_discard_prealloc(inode);
                udf_truncate_tail_extent(inode);
                unlock_kernel();
-               write_inode_now(inode, 1);
+               write_inode_now(inode, 0);
        }
-       kfree(UDF_I_DATA(inode));
-       UDF_I_DATA(inode) = NULL;
+       iinfo = UDF_I(inode);
+       kfree(iinfo->i_ext.i_data);
+       iinfo->i_ext.i_data = NULL;
 }
 
 static int udf_writepage(struct page *page, struct writeback_control *wbc)
@@ -161,6 +149,7 @@ void udf_expand_file_adinicb(struct inode *inode, int newsize, int *err)
 {
        struct page *page;
        char *kaddr;
+       struct udf_inode_info *iinfo = UDF_I(inode);
        struct writeback_control udf_wbc = {
                .sync_mode = WB_SYNC_NONE,
                .nr_to_write = 1,
@@ -169,11 +158,11 @@ void udf_expand_file_adinicb(struct inode *inode, int newsize, int *err)
        /* from now on we have normal address_space methods */
        inode->i_data.a_ops = &udf_aops;
 
-       if (!UDF_I_LENALLOC(inode)) {
+       if (!iinfo->i_lenAlloc) {
                if (UDF_QUERY_FLAG(inode->i_sb, UDF_FLAG_USE_SHORT_AD))
-                       UDF_I_ALLOCTYPE(inode) = ICBTAG_FLAG_AD_SHORT;
+                       iinfo->i_alloc_type = ICBTAG_FLAG_AD_SHORT;
                else
-                       UDF_I_ALLOCTYPE(inode) = ICBTAG_FLAG_AD_LONG;
+                       iinfo->i_alloc_type = ICBTAG_FLAG_AD_LONG;
                mark_inode_dirty(inode);
                return;
        }
@@ -183,21 +172,21 @@ void udf_expand_file_adinicb(struct inode *inode, int newsize, int *err)
 
        if (!PageUptodate(page)) {
                kaddr = kmap(page);
-               memset(kaddr + UDF_I_LENALLOC(inode), 0x00,
-                      PAGE_CACHE_SIZE - UDF_I_LENALLOC(inode));
-               memcpy(kaddr, UDF_I_DATA(inode) + UDF_I_LENEATTR(inode),
-                      UDF_I_LENALLOC(inode));
+               memset(kaddr + iinfo->i_lenAlloc, 0x00,
+                      PAGE_CACHE_SIZE - iinfo->i_lenAlloc);
+               memcpy(kaddr, iinfo->i_ext.i_data + iinfo->i_lenEAttr,
+                       iinfo->i_lenAlloc);
                flush_dcache_page(page);
                SetPageUptodate(page);
                kunmap(page);
        }
-       memset(UDF_I_DATA(inode) + UDF_I_LENEATTR(inode), 0x00,
-              UDF_I_LENALLOC(inode));
-       UDF_I_LENALLOC(inode) = 0;
+       memset(iinfo->i_ext.i_data + iinfo->i_lenEAttr, 0x00,
+              iinfo->i_lenAlloc);
+       iinfo->i_lenAlloc = 0;
        if (UDF_QUERY_FLAG(inode->i_sb, UDF_FLAG_USE_SHORT_AD))
-               UDF_I_ALLOCTYPE(inode) = ICBTAG_FLAG_AD_SHORT;
+               iinfo->i_alloc_type = ICBTAG_FLAG_AD_SHORT;
        else
-               UDF_I_ALLOCTYPE(inode) = ICBTAG_FLAG_AD_LONG;
+               iinfo->i_alloc_type = ICBTAG_FLAG_AD_LONG;
 
        inode->i_data.a_ops->writepage(page, &udf_wbc);
        page_cache_release(page);
@@ -216,9 +205,10 @@ struct buffer_head *udf_expand_dir_adinicb(struct inode *inode, int *block,
        struct extent_position epos;
 
        struct udf_fileident_bh sfibh, dfibh;
-       loff_t f_pos = udf_ext0_offset(inode) >> 2;
-       int size = (udf_ext0_offset(inode) + inode->i_size) >> 2;
+       loff_t f_pos = udf_ext0_offset(inode);
+       int size = udf_ext0_offset(inode) + inode->i_size;
        struct fileIdentDesc cfi, *sfi, *dfi;
+       struct udf_inode_info *iinfo = UDF_I(inode);
 
        if (UDF_QUERY_FLAG(inode->i_sb, UDF_FLAG_USE_SHORT_AD))
                alloctype = ICBTAG_FLAG_AD_SHORT;
@@ -226,20 +216,20 @@ struct buffer_head *udf_expand_dir_adinicb(struct inode *inode, int *block,
                alloctype = ICBTAG_FLAG_AD_LONG;
 
        if (!inode->i_size) {
-               UDF_I_ALLOCTYPE(inode) = alloctype;
+               iinfo->i_alloc_type = alloctype;
                mark_inode_dirty(inode);
                return NULL;
        }
 
        /* alloc block, and copy data to it */
        *block = udf_new_block(inode->i_sb, inode,
-                              UDF_I_LOCATION(inode).partitionReferenceNum,
-                              UDF_I_LOCATION(inode).logicalBlockNum, err);
+                              iinfo->i_location.partitionReferenceNum,
+                              iinfo->i_location.logicalBlockNum, err);
        if (!(*block))
                return NULL;
        newblock = udf_get_pblock(inode->i_sb, *block,
-                                 UDF_I_LOCATION(inode).partitionReferenceNum,
-                                 0);
+                                 iinfo->i_location.partitionReferenceNum,
+                               0);
        if (!newblock)
                return NULL;
        dbh = udf_tgetblk(inode->i_sb, newblock);
@@ -252,19 +242,19 @@ struct buffer_head *udf_expand_dir_adinicb(struct inode *inode, int *block,
        mark_buffer_dirty_inode(dbh, inode);
 
        sfibh.soffset = sfibh.eoffset =
-                       (f_pos & ((inode->i_sb->s_blocksize - 1) >> 2)) << 2;
+                       f_pos & (inode->i_sb->s_blocksize - 1);
        sfibh.sbh = sfibh.ebh = NULL;
        dfibh.soffset = dfibh.eoffset = 0;
        dfibh.sbh = dfibh.ebh = dbh;
-       while ((f_pos < size)) {
-               UDF_I_ALLOCTYPE(inode) = ICBTAG_FLAG_AD_IN_ICB;
+       while (f_pos < size) {
+               iinfo->i_alloc_type = ICBTAG_FLAG_AD_IN_ICB;
                sfi = udf_fileident_read(inode, &f_pos, &sfibh, &cfi, NULL,
                                         NULL, NULL, NULL);
                if (!sfi) {
                        brelse(dbh);
                        return NULL;
                }
-               UDF_I_ALLOCTYPE(inode) = alloctype;
+               iinfo->i_alloc_type = alloctype;
                sfi->descTag.tagLocation = cpu_to_le32(*block);
                dfibh.soffset = dfibh.eoffset;
                dfibh.eoffset += (sfibh.eoffset - sfibh.soffset);
@@ -272,23 +262,23 @@ struct buffer_head *udf_expand_dir_adinicb(struct inode *inode, int *block,
                if (udf_write_fi(inode, sfi, dfi, &dfibh, sfi->impUse,
                                 sfi->fileIdent +
                                        le16_to_cpu(sfi->lengthOfImpUse))) {
-                       UDF_I_ALLOCTYPE(inode) = ICBTAG_FLAG_AD_IN_ICB;
+                       iinfo->i_alloc_type = ICBTAG_FLAG_AD_IN_ICB;
                        brelse(dbh);
                        return NULL;
                }
        }
        mark_buffer_dirty_inode(dbh, inode);
 
-       memset(UDF_I_DATA(inode) + UDF_I_LENEATTR(inode), 0,
-               UDF_I_LENALLOC(inode));
-       UDF_I_LENALLOC(inode) = 0;
+       memset(iinfo->i_ext.i_data + iinfo->i_lenEAttr, 0,
+               iinfo->i_lenAlloc);
+       iinfo->i_lenAlloc = 0;
        eloc.logicalBlockNum = *block;
        eloc.partitionReferenceNum =
-                               UDF_I_LOCATION(inode).partitionReferenceNum;
-       elen = inode->i_size;
-       UDF_I_LENEXTENTS(inode) = elen;
+                               iinfo->i_location.partitionReferenceNum;
+       elen = inode->i_sb->s_blocksize;
+       iinfo->i_lenExtents = elen;
        epos.bh = NULL;
-       epos.block = UDF_I_LOCATION(inode);
+       epos.block = iinfo->i_location;
        epos.offset = udf_file_entry_alloc_offset(inode);
        udf_add_aext(inode, &epos, eloc, elen, 0);
        /* UniqueID stuff */
@@ -303,7 +293,8 @@ static int udf_get_block(struct inode *inode, sector_t block,
 {
        int err, new;
        struct buffer_head *bh;
-       unsigned long phys;
+       sector_t phys = 0;
+       struct udf_inode_info *iinfo;
 
        if (!create) {
                phys = udf_block_map(inode, block);
@@ -318,12 +309,10 @@ static int udf_get_block(struct inode *inode, sector_t block,
 
        lock_kernel();
 
-       if (block < 0)
-               goto abort_negative;
-
-       if (block == UDF_I_NEXT_ALLOC_BLOCK(inode) + 1) {
-               UDF_I_NEXT_ALLOC_BLOCK(inode)++;
-               UDF_I_NEXT_ALLOC_GOAL(inode)++;
+       iinfo = UDF_I(inode);
+       if (block == iinfo->i_next_alloc_block + 1) {
+               iinfo->i_next_alloc_block++;
+               iinfo->i_next_alloc_goal++;
        }
 
        err = 0;
@@ -341,10 +330,6 @@ static int udf_get_block(struct inode *inode, sector_t block,
 abort:
        unlock_kernel();
        return err;
-
-abort_negative:
-       udf_warning(inode->i_sb, "udf_get_block", "block < 0");
-       goto abort;
 }
 
 static struct buffer_head *udf_getblk(struct inode *inode, long block,
@@ -380,20 +365,22 @@ int udf_extend_file(struct inode *inode, struct extent_position *last_pos,
        struct super_block *sb = inode->i_sb;
        kernel_lb_addr prealloc_loc = {};
        int prealloc_len = 0;
+       struct udf_inode_info *iinfo;
 
        /* The previous extent is fake and we should not extend by anything
         * - there's nothing to do... */
        if (!blocks && fake)
                return 0;
 
+       iinfo = UDF_I(inode);
        /* Round the last extent up to a multiple of block size */
        if (last_ext->extLength & (sb->s_blocksize - 1)) {
                last_ext->extLength =
                        (last_ext->extLength & UDF_EXTENT_FLAG_MASK) |
                        (((last_ext->extLength & UDF_EXTENT_LENGTH_MASK) +
                          sb->s_blocksize - 1) & ~(sb->s_blocksize - 1));
-               UDF_I_LENEXTENTS(inode) =
-                       (UDF_I_LENEXTENTS(inode) + sb->s_blocksize - 1) &
+               iinfo->i_lenExtents =
+                       (iinfo->i_lenExtents + sb->s_blocksize - 1) &
                        ~(sb->s_blocksize - 1);
        }
 
@@ -470,9 +457,9 @@ out:
        }
 
        /* last_pos should point to the last written extent... */
-       if (UDF_I_ALLOCTYPE(inode) == ICBTAG_FLAG_AD_SHORT)
+       if (iinfo->i_alloc_type == ICBTAG_FLAG_AD_SHORT)
                last_pos->offset -= sizeof(short_ad);
-       else if (UDF_I_ALLOCTYPE(inode) == ICBTAG_FLAG_AD_LONG)
+       else if (iinfo->i_alloc_type == ICBTAG_FLAG_AD_LONG)
                last_pos->offset -= sizeof(long_ad);
        else
                return -1;
@@ -481,7 +468,7 @@ out:
 }
 
 static struct buffer_head *inode_getblk(struct inode *inode, sector_t block,
-                                       int *err, long *phys, int *new)
+                                       int *err, sector_t *phys, int *new)
 {
        static sector_t last_block;
        struct buffer_head *result = NULL;
@@ -495,11 +482,12 @@ static struct buffer_head *inode_getblk(struct inode *inode, sector_t block,
        uint32_t newblocknum, newblock;
        sector_t offset = 0;
        int8_t etype;
-       int goal = 0, pgoal = UDF_I_LOCATION(inode).logicalBlockNum;
+       struct udf_inode_info *iinfo = UDF_I(inode);
+       int goal = 0, pgoal = iinfo->i_location.logicalBlockNum;
        int lastblock = 0;
 
        prev_epos.offset = udf_file_entry_alloc_offset(inode);
-       prev_epos.block = UDF_I_LOCATION(inode);
+       prev_epos.block = iinfo->i_location;
        prev_epos.bh = NULL;
        cur_epos = next_epos = prev_epos;
        b_off = (loff_t)block << inode->i_sb->s_blocksize_bits;
@@ -649,23 +637,23 @@ static struct buffer_head *inode_getblk(struct inode *inode, sector_t block,
        if ((laarr[c].extLength >> 30) == (EXT_NOT_RECORDED_ALLOCATED >> 30))
                newblocknum = laarr[c].extLocation.logicalBlockNum + offset;
        else { /* otherwise, allocate a new block */
-               if (UDF_I_NEXT_ALLOC_BLOCK(inode) == block)
-                       goal = UDF_I_NEXT_ALLOC_GOAL(inode);
+               if (iinfo->i_next_alloc_block == block)
+                       goal = iinfo->i_next_alloc_goal;
 
                if (!goal) {
                        if (!(goal = pgoal)) /* XXX: what was intended here? */
-                               goal = UDF_I_LOCATION(inode).logicalBlockNum+1;
+                               goal = iinfo->i_location.logicalBlockNum + 1;
                }
 
                newblocknum = udf_new_block(inode->i_sb, inode,
-                               UDF_I_LOCATION(inode).partitionReferenceNum,
+                               iinfo->i_location.partitionReferenceNum,
                                goal, err);
                if (!newblocknum) {
                        brelse(prev_epos.bh);
                        *err = -ENOSPC;
                        return NULL;
                }
-               UDF_I_LENEXTENTS(inode) += inode->i_sb->s_blocksize;
+               iinfo->i_lenExtents += inode->i_sb->s_blocksize;
        }
 
        /* if the extent the requsted block is located in contains multiple
@@ -690,14 +678,14 @@ static struct buffer_head *inode_getblk(struct inode *inode, sector_t block,
        brelse(prev_epos.bh);
 
        newblock = udf_get_pblock(inode->i_sb, newblocknum,
-                               UDF_I_LOCATION(inode).partitionReferenceNum, 0);
+                               iinfo->i_location.partitionReferenceNum, 0);
        if (!newblock)
                return NULL;
        *phys = newblock;
        *err = 0;
        *new = 1;
-       UDF_I_NEXT_ALLOC_BLOCK(inode) = block;
-       UDF_I_NEXT_ALLOC_GOAL(inode) = newblocknum;
+       iinfo->i_next_alloc_block = block;
+       iinfo->i_next_alloc_goal = newblocknum;
        inode->i_ctime = current_fs_time(inode->i_sb);
 
        if (IS_SYNC(inode))
@@ -756,7 +744,7 @@ static void udf_split_extents(struct inode *inode, int *c, int offset,
                laarr[curr].extLocation.logicalBlockNum = newblocknum;
                if (etype == (EXT_NOT_RECORDED_NOT_ALLOCATED >> 30))
                        laarr[curr].extLocation.partitionReferenceNum =
-                               UDF_I_LOCATION(inode).partitionReferenceNum;
+                               UDF_I(inode)->i_location.partitionReferenceNum;
                laarr[curr].extLength = EXT_RECORDED_ALLOCATED |
                        blocksize;
                curr++;
@@ -863,7 +851,7 @@ static void udf_prealloc_extents(struct inode *inode, int c, int lastblock,
                                        (*endnum)--;
                                }
                        }
-                       UDF_I_LENEXTENTS(inode) +=
+                       UDF_I(inode)->i_lenExtents +=
                                numalloc << inode->i_sb->s_blocksize_bits;
                }
        }
@@ -1026,6 +1014,7 @@ void udf_truncate(struct inode *inode)
 {
        int offset;
        int err;
+       struct udf_inode_info *iinfo;
 
        if (!(S_ISREG(inode->i_mode) || S_ISDIR(inode->i_mode) ||
              S_ISLNK(inode->i_mode)))
@@ -1034,23 +1023,24 @@ void udf_truncate(struct inode *inode)
                return;
 
        lock_kernel();
-       if (UDF_I_ALLOCTYPE(inode) == ICBTAG_FLAG_AD_IN_ICB) {
+       iinfo = UDF_I(inode);
+       if (iinfo->i_alloc_type == ICBTAG_FLAG_AD_IN_ICB) {
                if (inode->i_sb->s_blocksize <
                                (udf_file_entry_alloc_offset(inode) +
                                 inode->i_size)) {
                        udf_expand_file_adinicb(inode, inode->i_size, &err);
-                       if (UDF_I_ALLOCTYPE(inode) == ICBTAG_FLAG_AD_IN_ICB) {
-                               inode->i_size = UDF_I_LENALLOC(inode);
+                       if (iinfo->i_alloc_type == ICBTAG_FLAG_AD_IN_ICB) {
+                               inode->i_size = iinfo->i_lenAlloc;
                                unlock_kernel();
                                return;
                        } else
                                udf_truncate_extents(inode);
                } else {
                        offset = inode->i_size & (inode->i_sb->s_blocksize - 1);
-                       memset(UDF_I_DATA(inode) + UDF_I_LENEATTR(inode) +
-                               offset, 0x00, inode->i_sb->s_blocksize -
+                       memset(iinfo->i_ext.i_data + iinfo->i_lenEAttr + offset,
+                               0x00, inode->i_sb->s_blocksize -
                                offset - udf_file_entry_alloc_offset(inode));
-                       UDF_I_LENALLOC(inode) = inode->i_size;
+                       iinfo->i_lenAlloc = inode->i_size;
                }
        } else {
                block_truncate_page(inode->i_mapping, inode->i_size,
@@ -1071,6 +1061,7 @@ static void __udf_read_inode(struct inode *inode)
        struct buffer_head *bh = NULL;
        struct fileEntry *fe;
        uint16_t ident;
+       struct udf_inode_info *iinfo = UDF_I(inode);
 
        /*
         * Set defaults, but the inode is still incomplete!
@@ -1084,7 +1075,7 @@ static void __udf_read_inode(struct inode *inode)
         *      i_nlink = 1
         *      i_op = NULL;
         */
-       bh = udf_read_ptagged(inode->i_sb, UDF_I_LOCATION(inode), 0, &ident);
+       bh = udf_read_ptagged(inode->i_sb, iinfo->i_location, 0, &ident);
        if (!bh) {
                printk(KERN_ERR "udf: udf_read_inode(ino %ld) failed !bh\n",
                       inode->i_ino);
@@ -1104,42 +1095,36 @@ static void __udf_read_inode(struct inode *inode)
        fe = (struct fileEntry *)bh->b_data;
 
        if (fe->icbTag.strategyType == cpu_to_le16(4096)) {
-               struct buffer_head *ibh = NULL, *nbh = NULL;
-               struct indirectEntry *ie;
+               struct buffer_head *ibh;
 
-               ibh = udf_read_ptagged(inode->i_sb, UDF_I_LOCATION(inode), 1,
+               ibh = udf_read_ptagged(inode->i_sb, iinfo->i_location, 1,
                                        &ident);
-               if (ident == TAG_IDENT_IE) {
-                       if (ibh) {
-                               kernel_lb_addr loc;
-                               ie = (struct indirectEntry *)ibh->b_data;
-
-                               loc = lelb_to_cpu(ie->indirectICB.extLocation);
-
-                               if (ie->indirectICB.extLength &&
-                                   (nbh = udf_read_ptagged(inode->i_sb, loc, 0,
-                                                           &ident))) {
-                                       if (ident == TAG_IDENT_FE ||
-                                           ident == TAG_IDENT_EFE) {
-                                               memcpy(&UDF_I_LOCATION(inode),
-                                                      &loc,
-                                                      sizeof(kernel_lb_addr));
-                                               brelse(bh);
-                                               brelse(ibh);
-                                               brelse(nbh);
-                                               __udf_read_inode(inode);
-                                               return;
-                                       } else {
-                                               brelse(nbh);
-                                               brelse(ibh);
-                                       }
-                               } else {
+               if (ident == TAG_IDENT_IE && ibh) {
+                       struct buffer_head *nbh = NULL;
+                       kernel_lb_addr loc;
+                       struct indirectEntry *ie;
+
+                       ie = (struct indirectEntry *)ibh->b_data;
+                       loc = lelb_to_cpu(ie->indirectICB.extLocation);
+
+                       if (ie->indirectICB.extLength &&
+                               (nbh = udf_read_ptagged(inode->i_sb, loc, 0,
+                                                       &ident))) {
+                               if (ident == TAG_IDENT_FE ||
+                                       ident == TAG_IDENT_EFE) {
+                                       memcpy(&iinfo->i_location,
+                                               &loc,
+                                               sizeof(kernel_lb_addr));
+                                       brelse(bh);
                                        brelse(ibh);
+                                       brelse(nbh);
+                                       __udf_read_inode(inode);
+                                       return;
                                }
+                               brelse(nbh);
                        }
-               } else {
-                       brelse(ibh);
                }
+               brelse(ibh);
        } else if (fe->icbTag.strategyType != cpu_to_le16(4)) {
                printk(KERN_ERR "udf: unsupported strategy type: %d\n",
                       le16_to_cpu(fe->icbTag.strategyType));
@@ -1156,53 +1141,53 @@ static void udf_fill_inode(struct inode *inode, struct buffer_head *bh)
 {
        struct fileEntry *fe;
        struct extendedFileEntry *efe;
-       time_t convtime;
-       long convtime_usec;
        int offset;
        struct udf_sb_info *sbi = UDF_SB(inode->i_sb);
+       struct udf_inode_info *iinfo = UDF_I(inode);
 
        fe = (struct fileEntry *)bh->b_data;
        efe = (struct extendedFileEntry *)bh->b_data;
 
        if (fe->icbTag.strategyType == cpu_to_le16(4))
-               UDF_I_STRAT4096(inode) = 0;
+               iinfo->i_strat4096 = 0;
        else /* if (fe->icbTag.strategyType == cpu_to_le16(4096)) */
-               UDF_I_STRAT4096(inode) = 1;
+               iinfo->i_strat4096 = 1;
 
-       UDF_I_ALLOCTYPE(inode) = le16_to_cpu(fe->icbTag.flags) &
+       iinfo->i_alloc_type = le16_to_cpu(fe->icbTag.flags) &
                                                        ICBTAG_FLAG_AD_MASK;
-       UDF_I_UNIQUE(inode) = 0;
-       UDF_I_LENEATTR(inode) = 0;
-       UDF_I_LENEXTENTS(inode) = 0;
-       UDF_I_LENALLOC(inode) = 0;
-       UDF_I_NEXT_ALLOC_BLOCK(inode) = 0;
-       UDF_I_NEXT_ALLOC_GOAL(inode) = 0;
+       iinfo->i_unique = 0;
+       iinfo->i_lenEAttr = 0;
+       iinfo->i_lenExtents = 0;
+       iinfo->i_lenAlloc = 0;
+       iinfo->i_next_alloc_block = 0;
+       iinfo->i_next_alloc_goal = 0;
        if (fe->descTag.tagIdent == cpu_to_le16(TAG_IDENT_EFE)) {
-               UDF_I_EFE(inode) = 1;
-               UDF_I_USE(inode) = 0;
+               iinfo->i_efe = 1;
+               iinfo->i_use = 0;
                if (udf_alloc_i_data(inode, inode->i_sb->s_blocksize -
                                        sizeof(struct extendedFileEntry))) {
                        make_bad_inode(inode);
                        return;
                }
-               memcpy(UDF_I_DATA(inode),
+               memcpy(iinfo->i_ext.i_data,
                       bh->b_data + sizeof(struct extendedFileEntry),
                       inode->i_sb->s_blocksize -
                                        sizeof(struct extendedFileEntry));
        } else if (fe->descTag.tagIdent == cpu_to_le16(TAG_IDENT_FE)) {
-               UDF_I_EFE(inode) = 0;
-               UDF_I_USE(inode) = 0;
+               iinfo->i_efe = 0;
+               iinfo->i_use = 0;
                if (udf_alloc_i_data(inode, inode->i_sb->s_blocksize -
                                                sizeof(struct fileEntry))) {
                        make_bad_inode(inode);
                        return;
                }
-               memcpy(UDF_I_DATA(inode), bh->b_data + sizeof(struct fileEntry),
+               memcpy(iinfo->i_ext.i_data,
+                      bh->b_data + sizeof(struct fileEntry),
                       inode->i_sb->s_blocksize - sizeof(struct fileEntry));
        } else if (fe->descTag.tagIdent == cpu_to_le16(TAG_IDENT_USE)) {
-               UDF_I_EFE(inode) = 0;
-               UDF_I_USE(inode) = 1;
-               UDF_I_LENALLOC(inode) = le32_to_cpu(
+               iinfo->i_efe = 0;
+               iinfo->i_use = 1;
+               iinfo->i_lenAlloc = le32_to_cpu(
                                ((struct unallocSpaceEntry *)bh->b_data)->
                                 lengthAllocDescs);
                if (udf_alloc_i_data(inode, inode->i_sb->s_blocksize -
@@ -1210,7 +1195,7 @@ static void udf_fill_inode(struct inode *inode, struct buffer_head *bh)
                        make_bad_inode(inode);
                        return;
                }
-               memcpy(UDF_I_DATA(inode),
+               memcpy(iinfo->i_ext.i_data,
                       bh->b_data + sizeof(struct unallocSpaceEntry),
                       inode->i_sb->s_blocksize -
                                        sizeof(struct unallocSpaceEntry));
@@ -1234,84 +1219,51 @@ static void udf_fill_inode(struct inode *inode, struct buffer_head *bh)
                inode->i_nlink = 1;
 
        inode->i_size = le64_to_cpu(fe->informationLength);
-       UDF_I_LENEXTENTS(inode) = inode->i_size;
+       iinfo->i_lenExtents = inode->i_size;
 
        inode->i_mode = udf_convert_permissions(fe);
        inode->i_mode &= ~UDF_SB(inode->i_sb)->s_umask;
 
-       if (UDF_I_EFE(inode) == 0) {
+       if (iinfo->i_efe == 0) {
                inode->i_blocks = le64_to_cpu(fe->logicalBlocksRecorded) <<
                        (inode->i_sb->s_blocksize_bits - 9);
 
-               if (udf_stamp_to_time(&convtime, &convtime_usec,
-                                     lets_to_cpu(fe->accessTime))) {
-                       inode->i_atime.tv_sec = convtime;
-                       inode->i_atime.tv_nsec = convtime_usec * 1000;
-               } else {
+               if (!udf_disk_stamp_to_time(&inode->i_atime, fe->accessTime))
                        inode->i_atime = sbi->s_record_time;
-               }
 
-               if (udf_stamp_to_time(&convtime, &convtime_usec,
-                                     lets_to_cpu(fe->modificationTime))) {
-                       inode->i_mtime.tv_sec = convtime;
-                       inode->i_mtime.tv_nsec = convtime_usec * 1000;
-               } else {
+               if (!udf_disk_stamp_to_time(&inode->i_mtime,
+                                           fe->modificationTime))
                        inode->i_mtime = sbi->s_record_time;
-               }
 
-               if (udf_stamp_to_time(&convtime, &convtime_usec,
-                                     lets_to_cpu(fe->attrTime))) {
-                       inode->i_ctime.tv_sec = convtime;
-                       inode->i_ctime.tv_nsec = convtime_usec * 1000;
-               } else {
+               if (!udf_disk_stamp_to_time(&inode->i_ctime, fe->attrTime))
                        inode->i_ctime = sbi->s_record_time;
-               }
 
-               UDF_I_UNIQUE(inode) = le64_to_cpu(fe->uniqueID);
-               UDF_I_LENEATTR(inode) = le32_to_cpu(fe->lengthExtendedAttr);
-               UDF_I_LENALLOC(inode) = le32_to_cpu(fe->lengthAllocDescs);
-               offset = sizeof(struct fileEntry) + UDF_I_LENEATTR(inode);
+               iinfo->i_unique = le64_to_cpu(fe->uniqueID);
+               iinfo->i_lenEAttr = le32_to_cpu(fe->lengthExtendedAttr);
+               iinfo->i_lenAlloc = le32_to_cpu(fe->lengthAllocDescs);
+               offset = sizeof(struct fileEntry) + iinfo->i_lenEAttr;
        } else {
                inode->i_blocks = le64_to_cpu(efe->logicalBlocksRecorded) <<
                    (inode->i_sb->s_blocksize_bits - 9);
 
-               if (udf_stamp_to_time(&convtime, &convtime_usec,
-                                     lets_to_cpu(efe->accessTime))) {
-                       inode->i_atime.tv_sec = convtime;
-                       inode->i_atime.tv_nsec = convtime_usec * 1000;
-               } else {
+               if (!udf_disk_stamp_to_time(&inode->i_atime, efe->accessTime))
                        inode->i_atime = sbi->s_record_time;
-               }
 
-               if (udf_stamp_to_time(&convtime, &convtime_usec,
-                                     lets_to_cpu(efe->modificationTime))) {
-                       inode->i_mtime.tv_sec = convtime;
-                       inode->i_mtime.tv_nsec = convtime_usec * 1000;
-               } else {
+               if (!udf_disk_stamp_to_time(&inode->i_mtime,
+                                           efe->modificationTime))
                        inode->i_mtime = sbi->s_record_time;
-               }
 
-               if (udf_stamp_to_time(&convtime, &convtime_usec,
-                                     lets_to_cpu(efe->createTime))) {
-                       UDF_I_CRTIME(inode).tv_sec = convtime;
-                       UDF_I_CRTIME(inode).tv_nsec = convtime_usec * 1000;
-               } else {
-                       UDF_I_CRTIME(inode) = sbi->s_record_time;
-               }
+               if (!udf_disk_stamp_to_time(&iinfo->i_crtime, efe->createTime))
+                       iinfo->i_crtime = sbi->s_record_time;
 
-               if (udf_stamp_to_time(&convtime, &convtime_usec,
-                                     lets_to_cpu(efe->attrTime))) {
-                       inode->i_ctime.tv_sec = convtime;
-                       inode->i_ctime.tv_nsec = convtime_usec * 1000;
-               } else {
+               if (!udf_disk_stamp_to_time(&inode->i_ctime, efe->attrTime))
                        inode->i_ctime = sbi->s_record_time;
-               }
 
-               UDF_I_UNIQUE(inode) = le64_to_cpu(efe->uniqueID);
-               UDF_I_LENEATTR(inode) = le32_to_cpu(efe->lengthExtendedAttr);
-               UDF_I_LENALLOC(inode) = le32_to_cpu(efe->lengthAllocDescs);
+               iinfo->i_unique = le64_to_cpu(efe->uniqueID);
+               iinfo->i_lenEAttr = le32_to_cpu(efe->lengthExtendedAttr);
+               iinfo->i_lenAlloc = le32_to_cpu(efe->lengthAllocDescs);
                offset = sizeof(struct extendedFileEntry) +
-                                                       UDF_I_LENEATTR(inode);
+                                                       iinfo->i_lenEAttr;
        }
 
        switch (fe->icbTag.fileType) {
@@ -1324,7 +1276,8 @@ static void udf_fill_inode(struct inode *inode, struct buffer_head *bh)
        case ICBTAG_FILE_TYPE_REALTIME:
        case ICBTAG_FILE_TYPE_REGULAR:
        case ICBTAG_FILE_TYPE_UNDEF:
-               if (UDF_I_ALLOCTYPE(inode) == ICBTAG_FLAG_AD_IN_ICB)
+       case ICBTAG_FILE_TYPE_VAT20:
+               if (iinfo->i_alloc_type == ICBTAG_FLAG_AD_IN_ICB)
                        inode->i_data.a_ops = &udf_adinicb_aops;
                else
                        inode->i_data.a_ops = &udf_aops;
@@ -1349,6 +1302,15 @@ static void udf_fill_inode(struct inode *inode, struct buffer_head *bh)
                inode->i_op = &page_symlink_inode_operations;
                inode->i_mode = S_IFLNK | S_IRWXUGO;
                break;
+       case ICBTAG_FILE_TYPE_MAIN:
+               udf_debug("METADATA FILE-----\n");
+               break;
+       case ICBTAG_FILE_TYPE_MIRROR:
+               udf_debug("METADATA MIRROR FILE-----\n");
+               break;
+       case ICBTAG_FILE_TYPE_BITMAP:
+               udf_debug("METADATA BITMAP FILE-----\n");
+               break;
        default:
                printk(KERN_ERR "udf: udf_fill_inode(ino %ld) failed unknown "
                                "file type=%d\n", inode->i_ino,
@@ -1371,9 +1333,10 @@ static void udf_fill_inode(struct inode *inode, struct buffer_head *bh)
 
 static int udf_alloc_i_data(struct inode *inode, size_t size)
 {
-       UDF_I_DATA(inode) = kmalloc(size, GFP_KERNEL);
+       struct udf_inode_info *iinfo = UDF_I(inode);
+       iinfo->i_ext.i_data = kmalloc(size, GFP_KERNEL);
 
-       if (!UDF_I_DATA(inode)) {
+       if (!iinfo->i_ext.i_data) {
                printk(KERN_ERR "udf:udf_alloc_i_data (ino %ld) "
                                "no free memory\n", inode->i_ino);
                return -ENOMEM;
@@ -1401,21 +1364,6 @@ static mode_t udf_convert_permissions(struct fileEntry *fe)
        return mode;
 }
 
-/*
- * udf_write_inode
- *
- * PURPOSE
- *     Write out the specified inode.
- *
- * DESCRIPTION
- *     This routine is called whenever an inode is synced.
- *     Currently this routine is just a placeholder.
- *
- * HISTORY
- *     July 1, 1997 - Andrew E. Mileski
- *     Written, tested, and released.
- */
-
 int udf_write_inode(struct inode *inode, int sync)
 {
        int ret;
@@ -1440,14 +1388,14 @@ static int udf_update_inode(struct inode *inode, int do_sync)
        uint32_t udfperms;
        uint16_t icbflags;
        uint16_t crclen;
-       kernel_timestamp cpu_time;
        int err = 0;
        struct udf_sb_info *sbi = UDF_SB(inode->i_sb);
        unsigned char blocksize_bits = inode->i_sb->s_blocksize_bits;
+       struct udf_inode_info *iinfo = UDF_I(inode);
 
        bh = udf_tread(inode->i_sb,
                        udf_get_lb_pblock(inode->i_sb,
-                                         UDF_I_LOCATION(inode), 0));
+                                         iinfo->i_location, 0));
        if (!bh) {
                udf_debug("bread failure\n");
                return -EIO;
@@ -1462,19 +1410,19 @@ static int udf_update_inode(struct inode *inode, int do_sync)
                struct unallocSpaceEntry *use =
                        (struct unallocSpaceEntry *)bh->b_data;
 
-               use->lengthAllocDescs = cpu_to_le32(UDF_I_LENALLOC(inode));
+               use->lengthAllocDescs = cpu_to_le32(iinfo->i_lenAlloc);
                memcpy(bh->b_data + sizeof(struct unallocSpaceEntry),
-                      UDF_I_DATA(inode), inode->i_sb->s_blocksize -
+                      iinfo->i_ext.i_data, inode->i_sb->s_blocksize -
                                        sizeof(struct unallocSpaceEntry));
                crclen = sizeof(struct unallocSpaceEntry) +
-                               UDF_I_LENALLOC(inode) - sizeof(tag);
+                               iinfo->i_lenAlloc - sizeof(tag);
                use->descTag.tagLocation = cpu_to_le32(
-                                               UDF_I_LOCATION(inode).
+                                               iinfo->i_location.
                                                        logicalBlockNum);
                use->descTag.descCRCLength = cpu_to_le16(crclen);
-               use->descTag.descCRC = cpu_to_le16(udf_crc((char *)use +
-                                                          sizeof(tag), crclen,
-                                                          0));
+               use->descTag.descCRC = cpu_to_le16(crc_itu_t(0, (char *)use +
+                                                          sizeof(tag),
+                                                          crclen));
                use->descTag.tagChecksum = udf_tag_checksum(&use->descTag);
 
                mark_buffer_dirty(bh);
@@ -1534,31 +1482,29 @@ static int udf_update_inode(struct inode *inode, int do_sync)
                dsea->minorDeviceIdent = cpu_to_le32(iminor(inode));
        }
 
-       if (UDF_I_EFE(inode) == 0) {
-               memcpy(bh->b_data + sizeof(struct fileEntry), UDF_I_DATA(inode),
+       if (iinfo->i_efe == 0) {
+               memcpy(bh->b_data + sizeof(struct fileEntry),
+                      iinfo->i_ext.i_data,
                       inode->i_sb->s_blocksize - sizeof(struct fileEntry));
                fe->logicalBlocksRecorded = cpu_to_le64(
                        (inode->i_blocks + (1 << (blocksize_bits - 9)) - 1) >>
                        (blocksize_bits - 9));
 
-               if (udf_time_to_stamp(&cpu_time, inode->i_atime))
-                       fe->accessTime = cpu_to_lets(cpu_time);
-               if (udf_time_to_stamp(&cpu_time, inode->i_mtime))
-                       fe->modificationTime = cpu_to_lets(cpu_time);
-               if (udf_time_to_stamp(&cpu_time, inode->i_ctime))
-                       fe->attrTime = cpu_to_lets(cpu_time);
+               udf_time_to_disk_stamp(&fe->accessTime, inode->i_atime);
+               udf_time_to_disk_stamp(&fe->modificationTime, inode->i_mtime);
+               udf_time_to_disk_stamp(&fe->attrTime, inode->i_ctime);
                memset(&(fe->impIdent), 0, sizeof(regid));
                strcpy(fe->impIdent.ident, UDF_ID_DEVELOPER);
                fe->impIdent.identSuffix[0] = UDF_OS_CLASS_UNIX;
                fe->impIdent.identSuffix[1] = UDF_OS_ID_LINUX;
-               fe->uniqueID = cpu_to_le64(UDF_I_UNIQUE(inode));
-               fe->lengthExtendedAttr = cpu_to_le32(UDF_I_LENEATTR(inode));
-               fe->lengthAllocDescs = cpu_to_le32(UDF_I_LENALLOC(inode));
+               fe->uniqueID = cpu_to_le64(iinfo->i_unique);
+               fe->lengthExtendedAttr = cpu_to_le32(iinfo->i_lenEAttr);
+               fe->lengthAllocDescs = cpu_to_le32(iinfo->i_lenAlloc);
                fe->descTag.tagIdent = cpu_to_le16(TAG_IDENT_FE);
                crclen = sizeof(struct fileEntry);
        } else {
                memcpy(bh->b_data + sizeof(struct extendedFileEntry),
-                      UDF_I_DATA(inode),
+                      iinfo->i_ext.i_data,
                       inode->i_sb->s_blocksize -
                                        sizeof(struct extendedFileEntry));
                efe->objectSize = cpu_to_le64(inode->i_size);
@@ -1566,41 +1512,37 @@ static int udf_update_inode(struct inode *inode, int do_sync)
                        (inode->i_blocks + (1 << (blocksize_bits - 9)) - 1) >>
                        (blocksize_bits - 9));
 
-               if (UDF_I_CRTIME(inode).tv_sec > inode->i_atime.tv_sec ||
-                   (UDF_I_CRTIME(inode).tv_sec == inode->i_atime.tv_sec &&
-                    UDF_I_CRTIME(inode).tv_nsec > inode->i_atime.tv_nsec))
-                       UDF_I_CRTIME(inode) = inode->i_atime;
-
-               if (UDF_I_CRTIME(inode).tv_sec > inode->i_mtime.tv_sec ||
-                   (UDF_I_CRTIME(inode).tv_sec == inode->i_mtime.tv_sec &&
-                    UDF_I_CRTIME(inode).tv_nsec > inode->i_mtime.tv_nsec))
-                       UDF_I_CRTIME(inode) = inode->i_mtime;
-
-               if (UDF_I_CRTIME(inode).tv_sec > inode->i_ctime.tv_sec ||
-                   (UDF_I_CRTIME(inode).tv_sec == inode->i_ctime.tv_sec &&
-                    UDF_I_CRTIME(inode).tv_nsec > inode->i_ctime.tv_nsec))
-                       UDF_I_CRTIME(inode) = inode->i_ctime;
-
-               if (udf_time_to_stamp(&cpu_time, inode->i_atime))
-                       efe->accessTime = cpu_to_lets(cpu_time);
-               if (udf_time_to_stamp(&cpu_time, inode->i_mtime))
-                       efe->modificationTime = cpu_to_lets(cpu_time);
-               if (udf_time_to_stamp(&cpu_time, UDF_I_CRTIME(inode)))
-                       efe->createTime = cpu_to_lets(cpu_time);
-               if (udf_time_to_stamp(&cpu_time, inode->i_ctime))
-                       efe->attrTime = cpu_to_lets(cpu_time);
+               if (iinfo->i_crtime.tv_sec > inode->i_atime.tv_sec ||
+                   (iinfo->i_crtime.tv_sec == inode->i_atime.tv_sec &&
+                    iinfo->i_crtime.tv_nsec > inode->i_atime.tv_nsec))
+                       iinfo->i_crtime = inode->i_atime;
+
+               if (iinfo->i_crtime.tv_sec > inode->i_mtime.tv_sec ||
+                   (iinfo->i_crtime.tv_sec == inode->i_mtime.tv_sec &&
+                    iinfo->i_crtime.tv_nsec > inode->i_mtime.tv_nsec))
+                       iinfo->i_crtime = inode->i_mtime;
+
+               if (iinfo->i_crtime.tv_sec > inode->i_ctime.tv_sec ||
+                   (iinfo->i_crtime.tv_sec == inode->i_ctime.tv_sec &&
+                    iinfo->i_crtime.tv_nsec > inode->i_ctime.tv_nsec))
+                       iinfo->i_crtime = inode->i_ctime;
+
+               udf_time_to_disk_stamp(&efe->accessTime, inode->i_atime);
+               udf_time_to_disk_stamp(&efe->modificationTime, inode->i_mtime);
+               udf_time_to_disk_stamp(&efe->createTime, iinfo->i_crtime);
+               udf_time_to_disk_stamp(&efe->attrTime, inode->i_ctime);
 
                memset(&(efe->impIdent), 0, sizeof(regid));
                strcpy(efe->impIdent.ident, UDF_ID_DEVELOPER);
                efe->impIdent.identSuffix[0] = UDF_OS_CLASS_UNIX;
                efe->impIdent.identSuffix[1] = UDF_OS_ID_LINUX;
-               efe->uniqueID = cpu_to_le64(UDF_I_UNIQUE(inode));
-               efe->lengthExtendedAttr = cpu_to_le32(UDF_I_LENEATTR(inode));
-               efe->lengthAllocDescs = cpu_to_le32(UDF_I_LENALLOC(inode));
+               efe->uniqueID = cpu_to_le64(iinfo->i_unique);
+               efe->lengthExtendedAttr = cpu_to_le32(iinfo->i_lenEAttr);
+               efe->lengthAllocDescs = cpu_to_le32(iinfo->i_lenAlloc);
                efe->descTag.tagIdent = cpu_to_le16(TAG_IDENT_EFE);
                crclen = sizeof(struct extendedFileEntry);
        }
-       if (UDF_I_STRAT4096(inode)) {
+       if (iinfo->i_strat4096) {
                fe->icbTag.strategyType = cpu_to_le16(4096);
                fe->icbTag.strategyParameter = cpu_to_le16(1);
                fe->icbTag.numEntries = cpu_to_le16(2);
@@ -1624,7 +1566,7 @@ static int udf_update_inode(struct inode *inode, int do_sync)
        else if (S_ISSOCK(inode->i_mode))
                fe->icbTag.fileType = ICBTAG_FILE_TYPE_SOCKET;
 
-       icbflags =      UDF_I_ALLOCTYPE(inode) |
+       icbflags =      iinfo->i_alloc_type |
                        ((inode->i_mode & S_ISUID) ? ICBTAG_FLAG_SETUID : 0) |
                        ((inode->i_mode & S_ISGID) ? ICBTAG_FLAG_SETGID : 0) |
                        ((inode->i_mode & S_ISVTX) ? ICBTAG_FLAG_STICKY : 0) |
@@ -1639,11 +1581,12 @@ static int udf_update_inode(struct inode *inode, int do_sync)
                fe->descTag.descVersion = cpu_to_le16(2);
        fe->descTag.tagSerialNum = cpu_to_le16(sbi->s_serial_number);
        fe->descTag.tagLocation = cpu_to_le32(
-                                       UDF_I_LOCATION(inode).logicalBlockNum);
-       crclen += UDF_I_LENEATTR(inode) + UDF_I_LENALLOC(inode) - sizeof(tag);
+                                       iinfo->i_location.logicalBlockNum);
+       crclen += iinfo->i_lenEAttr + iinfo->i_lenAlloc -
+                                                               sizeof(tag);
        fe->descTag.descCRCLength = cpu_to_le16(crclen);
-       fe->descTag.descCRC = cpu_to_le16(udf_crc((char *)fe + sizeof(tag),
-                                                 crclen, 0));
+       fe->descTag.descCRC = cpu_to_le16(crc_itu_t(0, (char *)fe + sizeof(tag),
+                                                 crclen));
        fe->descTag.tagChecksum = udf_tag_checksum(&fe->descTag);
 
        /* write the data blocks */
@@ -1671,7 +1614,7 @@ struct inode *udf_iget(struct super_block *sb, kernel_lb_addr ino)
                return NULL;
 
        if (inode->i_state & I_NEW) {
-               memcpy(&UDF_I_LOCATION(inode), &ino, sizeof(kernel_lb_addr));
+               memcpy(&UDF_I(inode)->i_location, &ino, sizeof(kernel_lb_addr));
                __udf_read_inode(inode);
                unlock_new_inode(inode);
        }
@@ -1703,17 +1646,18 @@ int8_t udf_add_aext(struct inode *inode, struct extent_position *epos,
        struct allocExtDesc *aed;
        int8_t etype;
        uint8_t *ptr;
+       struct udf_inode_info *iinfo = UDF_I(inode);
 
        if (!epos->bh)
-               ptr = UDF_I_DATA(inode) + epos->offset -
+               ptr = iinfo->i_ext.i_data + epos->offset -
                        udf_file_entry_alloc_offset(inode) +
-                       UDF_I_LENEATTR(inode);
+                       iinfo->i_lenEAttr;
        else
                ptr = epos->bh->b_data + epos->offset;
 
-       if (UDF_I_ALLOCTYPE(inode) == ICBTAG_FLAG_AD_SHORT)
+       if (iinfo->i_alloc_type == ICBTAG_FLAG_AD_SHORT)
                adsize = sizeof(short_ad);
-       else if (UDF_I_ALLOCTYPE(inode) == ICBTAG_FLAG_AD_LONG)
+       else if (iinfo->i_alloc_type == ICBTAG_FLAG_AD_LONG)
                adsize = sizeof(long_ad);
        else
                return -1;
@@ -1759,11 +1703,9 @@ int8_t udf_add_aext(struct inode *inode, struct extent_position *epos,
 
                        if (epos->bh) {
                                aed = (struct allocExtDesc *)epos->bh->b_data;
-                               aed->lengthAllocDescs =
-                                       cpu_to_le32(le32_to_cpu(
-                                       aed->lengthAllocDescs) + adsize);
+                               le32_add_cpu(&aed->lengthAllocDescs, adsize);
                        } else {
-                               UDF_I_LENALLOC(inode) += adsize;
+                               iinfo->i_lenAlloc += adsize;
                                mark_inode_dirty(inode);
                        }
                }
@@ -1773,7 +1715,7 @@ int8_t udf_add_aext(struct inode *inode, struct extent_position *epos,
                else
                        udf_new_tag(nbh->b_data, TAG_IDENT_AED, 2, 1,
                                    epos->block.logicalBlockNum, sizeof(tag));
-               switch (UDF_I_ALLOCTYPE(inode)) {
+               switch (iinfo->i_alloc_type) {
                case ICBTAG_FLAG_AD_SHORT:
                        sad = (short_ad *)sptr;
                        sad->extLength = cpu_to_le32(EXT_NEXT_EXTENT_ALLOCDECS |
@@ -1807,13 +1749,11 @@ int8_t udf_add_aext(struct inode *inode, struct extent_position *epos,
        etype = udf_write_aext(inode, epos, eloc, elen, inc);
 
        if (!epos->bh) {
-               UDF_I_LENALLOC(inode) += adsize;
+               iinfo->i_lenAlloc += adsize;
                mark_inode_dirty(inode);
        } else {
                aed = (struct allocExtDesc *)epos->bh->b_data;
-               aed->lengthAllocDescs =
-                       cpu_to_le32(le32_to_cpu(aed->lengthAllocDescs) +
-                                   adsize);
+               le32_add_cpu(&aed->lengthAllocDescs, adsize);
                if (!UDF_QUERY_FLAG(inode->i_sb, UDF_FLAG_STRICT) ||
                                UDF_SB(inode->i_sb)->s_udfrev >= 0x0201)
                        udf_update_tag(epos->bh->b_data,
@@ -1834,15 +1774,16 @@ int8_t udf_write_aext(struct inode *inode, struct extent_position *epos,
        uint8_t *ptr;
        short_ad *sad;
        long_ad *lad;
+       struct udf_inode_info *iinfo = UDF_I(inode);
 
        if (!epos->bh)
-               ptr = UDF_I_DATA(inode) + epos->offset -
+               ptr = iinfo->i_ext.i_data + epos->offset -
                        udf_file_entry_alloc_offset(inode) +
-                       UDF_I_LENEATTR(inode);
+                       iinfo->i_lenEAttr;
        else
                ptr = epos->bh->b_data + epos->offset;
 
-       switch (UDF_I_ALLOCTYPE(inode)) {
+       switch (iinfo->i_alloc_type) {
        case ICBTAG_FLAG_AD_SHORT:
                sad = (short_ad *)ptr;
                sad->extLength = cpu_to_le32(elen);
@@ -1910,15 +1851,16 @@ int8_t udf_current_aext(struct inode *inode, struct extent_position *epos,
        uint8_t *ptr;
        short_ad *sad;
        long_ad *lad;
+       struct udf_inode_info *iinfo = UDF_I(inode);
 
        if (!epos->bh) {
                if (!epos->offset)
                        epos->offset = udf_file_entry_alloc_offset(inode);
-               ptr = UDF_I_DATA(inode) + epos->offset -
+               ptr = iinfo->i_ext.i_data + epos->offset -
                        udf_file_entry_alloc_offset(inode) +
-                       UDF_I_LENEATTR(inode);
+                       iinfo->i_lenEAttr;
                alen = udf_file_entry_alloc_offset(inode) +
-                                                       UDF_I_LENALLOC(inode);
+                                                       iinfo->i_lenAlloc;
        } else {
                if (!epos->offset)
                        epos->offset = sizeof(struct allocExtDesc);
@@ -1928,7 +1870,7 @@ int8_t udf_current_aext(struct inode *inode, struct extent_position *epos,
                                                        lengthAllocDescs);
        }
 
-       switch (UDF_I_ALLOCTYPE(inode)) {
+       switch (iinfo->i_alloc_type) {
        case ICBTAG_FLAG_AD_SHORT:
                sad = udf_get_fileshortad(ptr, alen, &epos->offset, inc);
                if (!sad)
@@ -1936,7 +1878,7 @@ int8_t udf_current_aext(struct inode *inode, struct extent_position *epos,
                etype = le32_to_cpu(sad->extLength) >> 30;
                eloc->logicalBlockNum = le32_to_cpu(sad->extPosition);
                eloc->partitionReferenceNum =
-                               UDF_I_LOCATION(inode).partitionReferenceNum;
+                               iinfo->i_location.partitionReferenceNum;
                *elen = le32_to_cpu(sad->extLength) & UDF_EXTENT_LENGTH_MASK;
                break;
        case ICBTAG_FLAG_AD_LONG:
@@ -1949,7 +1891,7 @@ int8_t udf_current_aext(struct inode *inode, struct extent_position *epos,
                break;
        default:
                udf_debug("alloc_type = %d unsupported\n",
-                               UDF_I_ALLOCTYPE(inode));
+                               iinfo->i_alloc_type);
                return -1;
        }
 
@@ -1984,15 +1926,17 @@ int8_t udf_delete_aext(struct inode *inode, struct extent_position epos,
        int adsize;
        int8_t etype;
        struct allocExtDesc *aed;
+       struct udf_inode_info *iinfo;
 
        if (epos.bh) {
                get_bh(epos.bh);
                get_bh(epos.bh);
        }
 
-       if (UDF_I_ALLOCTYPE(inode) == ICBTAG_FLAG_AD_SHORT)
+       iinfo = UDF_I(inode);
+       if (iinfo->i_alloc_type == ICBTAG_FLAG_AD_SHORT)
                adsize = sizeof(short_ad);
-       else if (UDF_I_ALLOCTYPE(inode) == ICBTAG_FLAG_AD_LONG)
+       else if (iinfo->i_alloc_type == ICBTAG_FLAG_AD_LONG)
                adsize = sizeof(long_ad);
        else
                adsize = 0;
@@ -2019,13 +1963,11 @@ int8_t udf_delete_aext(struct inode *inode, struct extent_position epos,
                udf_write_aext(inode, &oepos, eloc, elen, 1);
                udf_write_aext(inode, &oepos, eloc, elen, 1);
                if (!oepos.bh) {
-                       UDF_I_LENALLOC(inode) -= (adsize * 2);
+                       iinfo->i_lenAlloc -= (adsize * 2);
                        mark_inode_dirty(inode);
                } else {
                        aed = (struct allocExtDesc *)oepos.bh->b_data;
-                       aed->lengthAllocDescs =
-                               cpu_to_le32(le32_to_cpu(aed->lengthAllocDescs) -
-                                           (2 * adsize));
+                       le32_add_cpu(&aed->lengthAllocDescs, -(2 * adsize));
                        if (!UDF_QUERY_FLAG(inode->i_sb, UDF_FLAG_STRICT) ||
                            UDF_SB(inode->i_sb)->s_udfrev >= 0x0201)
                                udf_update_tag(oepos.bh->b_data,
@@ -2038,13 +1980,11 @@ int8_t udf_delete_aext(struct inode *inode, struct extent_position epos,
        } else {
                udf_write_aext(inode, &oepos, eloc, elen, 1);
                if (!oepos.bh) {
-                       UDF_I_LENALLOC(inode) -= adsize;
+                       iinfo->i_lenAlloc -= adsize;
                        mark_inode_dirty(inode);
                } else {
                        aed = (struct allocExtDesc *)oepos.bh->b_data;
-                       aed->lengthAllocDescs =
-                               cpu_to_le32(le32_to_cpu(aed->lengthAllocDescs) -
-                                           adsize);
+                       le32_add_cpu(&aed->lengthAllocDescs, -adsize);
                        if (!UDF_QUERY_FLAG(inode->i_sb, UDF_FLAG_STRICT) ||
                            UDF_SB(inode->i_sb)->s_udfrev >= 0x0201)
                                udf_update_tag(oepos.bh->b_data,
@@ -2070,14 +2010,11 @@ int8_t inode_bmap(struct inode *inode, sector_t block,
        loff_t lbcount = 0, bcount =
            (loff_t) block << blocksize_bits;
        int8_t etype;
+       struct udf_inode_info *iinfo;
 
-       if (block < 0) {
-               printk(KERN_ERR "udf: inode_bmap: block < 0\n");
-               return -1;
-       }
-
+       iinfo = UDF_I(inode);
        pos->offset = 0;
-       pos->block = UDF_I_LOCATION(inode);
+       pos->block = iinfo->i_location;
        pos->bh = NULL;
        *elen = 0;
 
@@ -2085,7 +2022,7 @@ int8_t inode_bmap(struct inode *inode, sector_t block,
                etype = udf_next_aext(inode, pos, eloc, elen, 1);
                if (etype == -1) {
                        *offset = (bcount - lbcount) >> blocksize_bits;
-                       UDF_I_LENEXTENTS(inode) = lbcount;
+                       iinfo->i_lenExtents = lbcount;
                        return -1;
                }
                lbcount += *elen;