[GFS2] Fix Kconfig
[safe/jmp/linux-2.6] / fs / gfs2 / log.c
index f6d0013..291415d 100644 (file)
@@ -1,10 +1,10 @@
 /*
  * Copyright (C) Sistina Software, Inc.  1997-2003 All rights reserved.
- * Copyright (C) 2004-2005 Red Hat, Inc.  All rights reserved.
+ * Copyright (C) 2004-2006 Red Hat, Inc.  All rights reserved.
  *
  * This copyrighted material is made available to anyone wishing to use,
  * modify, copy, or redistribute it subject to the terms and conditions
- * of the GNU General Public License v.2.
+ * of the GNU General Public License version 2.
  */
 
 #include <linux/sched.h>
 #include <linux/spinlock.h>
 #include <linux/completion.h>
 #include <linux/buffer_head.h>
-#include <asm/semaphore.h>
+#include <linux/gfs2_ondisk.h>
+#include <linux/crc32.h>
+#include <linux/lm_interface.h>
+#include <linux/delay.h>
 
 #include "gfs2.h"
+#include "incore.h"
 #include "bmap.h"
 #include "glock.h"
 #include "log.h"
 #include "lops.h"
 #include "meta_io.h"
+#include "util.h"
+#include "dir.h"
 
 #define PULL 1
 
-static inline int is_done(struct gfs2_sbd *sdp, atomic_t *a)
-{
-       int done;
-       gfs2_log_lock(sdp);
-       done = atomic_read(a) ? 0 : 1;
-       gfs2_log_unlock(sdp);
-       return done;
-}
-
-static void do_lock_wait(struct gfs2_sbd *sdp, wait_queue_head_t *wq,
-                        atomic_t *a)
-{
-       gfs2_log_unlock(sdp);
-       wait_event(*wq, is_done(sdp, a));
-       gfs2_log_lock(sdp);
-}
-
-static void lock_for_trans(struct gfs2_sbd *sdp)
-{
-       gfs2_log_lock(sdp);
-       do_lock_wait(sdp, &sdp->sd_log_trans_wq, &sdp->sd_log_flush_count);
-       atomic_inc(&sdp->sd_log_trans_count);
-       gfs2_log_unlock(sdp);
-}
-
-static void unlock_from_trans(struct gfs2_sbd *sdp)
-{
-       gfs2_assert_warn(sdp, atomic_read(&sdp->sd_log_trans_count));
-       if (atomic_dec_and_test(&sdp->sd_log_trans_count))
-               wake_up(&sdp->sd_log_flush_wq);
-}
-
-void gfs2_lock_for_flush(struct gfs2_sbd *sdp)
-{
-       gfs2_log_lock(sdp);
-       atomic_inc(&sdp->sd_log_flush_count);
-       do_lock_wait(sdp, &sdp->sd_log_flush_wq, &sdp->sd_log_trans_count);
-       gfs2_log_unlock(sdp);
-}
-
-void gfs2_unlock_from_flush(struct gfs2_sbd *sdp)
-{
-       gfs2_assert_warn(sdp, atomic_read(&sdp->sd_log_flush_count));
-       if (atomic_dec_and_test(&sdp->sd_log_flush_count))
-               wake_up(&sdp->sd_log_trans_wq);
-}
-
 /**
  * gfs2_struct2blk - compute stuff
  * @sdp: the filesystem
@@ -92,19 +51,105 @@ unsigned int gfs2_struct2blk(struct gfs2_sbd *sdp, unsigned int nstruct,
        first = (sdp->sd_sb.sb_bsize - sizeof(struct gfs2_log_descriptor)) / ssize;
 
        if (nstruct > first) {
-               second = (sdp->sd_sb.sb_bsize - sizeof(struct gfs2_meta_header)) / ssize;
-               blks += DIV_RU(nstruct - first, second);
+               second = (sdp->sd_sb.sb_bsize -
+                         sizeof(struct gfs2_meta_header)) / ssize;
+               blks += DIV_ROUND_UP(nstruct - first, second);
        }
 
        return blks;
 }
 
-void gfs2_ail1_start(struct gfs2_sbd *sdp, int flags)
+/**
+ * gfs2_ail1_start_one - Start I/O on a part of the AIL
+ * @sdp: the filesystem
+ * @tr: the part of the AIL
+ *
+ */
+
+static void gfs2_ail1_start_one(struct gfs2_sbd *sdp, struct gfs2_ail *ai)
+{
+       struct gfs2_bufdata *bd, *s;
+       struct buffer_head *bh;
+       int retry;
+
+       BUG_ON(!spin_is_locked(&sdp->sd_log_lock));
+
+       do {
+               retry = 0;
+
+               list_for_each_entry_safe_reverse(bd, s, &ai->ai_ail1_list,
+                                                bd_ail_st_list) {
+                       bh = bd->bd_bh;
+
+                       gfs2_assert(sdp, bd->bd_ail == ai);
+
+                       if (!buffer_busy(bh)) {
+                               if (!buffer_uptodate(bh)) {
+                                       gfs2_log_unlock(sdp);
+                                       gfs2_io_error_bh(sdp, bh);
+                                       gfs2_log_lock(sdp);
+                               }
+                               list_move(&bd->bd_ail_st_list, &ai->ai_ail2_list);
+                               continue;
+                       }
+
+                       if (!buffer_dirty(bh))
+                               continue;
+
+                       list_move(&bd->bd_ail_st_list, &ai->ai_ail1_list);
+
+                       gfs2_log_unlock(sdp);
+                       wait_on_buffer(bh);
+                       ll_rw_block(WRITE, 1, &bh);
+                       gfs2_log_lock(sdp);
+
+                       retry = 1;
+                       break;
+               }
+       } while (retry);
+}
+
+/**
+ * gfs2_ail1_empty_one - Check whether or not a trans in the AIL has been synced
+ * @sdp: the filesystem
+ * @ai: the AIL entry
+ *
+ */
+
+static int gfs2_ail1_empty_one(struct gfs2_sbd *sdp, struct gfs2_ail *ai, int flags)
+{
+       struct gfs2_bufdata *bd, *s;
+       struct buffer_head *bh;
+
+       list_for_each_entry_safe_reverse(bd, s, &ai->ai_ail1_list,
+                                        bd_ail_st_list) {
+               bh = bd->bd_bh;
+
+               gfs2_assert(sdp, bd->bd_ail == ai);
+
+               if (buffer_busy(bh)) {
+                       if (flags & DIO_ALL)
+                               continue;
+                       else
+                               break;
+               }
+
+               if (!buffer_uptodate(bh))
+                       gfs2_io_error_bh(sdp, bh);
+
+               list_move(&bd->bd_ail_st_list, &ai->ai_ail2_list);
+       }
+
+       return list_empty(&ai->ai_ail1_list);
+}
+
+static void gfs2_ail1_start(struct gfs2_sbd *sdp, int flags)
 {
        struct list_head *head = &sdp->sd_ail1_list;
-       uint64_t sync_gen;
-       struct list_head *first, *tmp;
-       struct gfs2_ail *first_ai, *ai;
+       u64 sync_gen;
+       struct list_head *first;
+       struct gfs2_ail *first_ai, *ai, *tmp;
+       int done = 0;
 
        gfs2_log_lock(sdp);
        if (list_empty(head)) {
@@ -116,28 +161,25 @@ void gfs2_ail1_start(struct gfs2_sbd *sdp, int flags)
        first = head->prev;
        first_ai = list_entry(first, struct gfs2_ail, ai_list);
        first_ai->ai_sync_gen = sync_gen;
-       gfs2_ail1_start_one(sdp, first_ai);
+       gfs2_ail1_start_one(sdp, first_ai); /* This may drop log lock */
 
        if (flags & DIO_ALL)
                first = NULL;
 
-       for (;;) {
-               if (first &&
-                   (head->prev != first ||
-                    gfs2_ail1_empty_one(sdp, first_ai, 0)))
+       while(!done) {
+               if (first && (head->prev != first ||
+                             gfs2_ail1_empty_one(sdp, first_ai, 0)))
                        break;
 
-               for (tmp = head->prev; tmp != head; tmp = tmp->prev) {
-                       ai = list_entry(tmp, struct gfs2_ail, ai_list);
+               done = 1;
+               list_for_each_entry_safe_reverse(ai, tmp, head, ai_list) {
                        if (ai->ai_sync_gen >= sync_gen)
                                continue;
                        ai->ai_sync_gen = sync_gen;
-                       gfs2_ail1_start_one(sdp, ai);
+                       gfs2_ail1_start_one(sdp, ai); /* This may drop log lock */
+                       done = 0;
                        break;
                }
-
-               if (tmp == head)
-                       break;
        }
 
        gfs2_log_unlock(sdp);
@@ -164,6 +206,31 @@ int gfs2_ail1_empty(struct gfs2_sbd *sdp, int flags)
        return ret;
 }
 
+
+/**
+ * gfs2_ail2_empty_one - Check whether or not a trans in the AIL has been synced
+ * @sdp: the filesystem
+ * @ai: the AIL entry
+ *
+ */
+
+static void gfs2_ail2_empty_one(struct gfs2_sbd *sdp, struct gfs2_ail *ai)
+{
+       struct list_head *head = &ai->ai_ail2_list;
+       struct gfs2_bufdata *bd;
+
+       while (!list_empty(head)) {
+               bd = list_entry(head->prev, struct gfs2_bufdata,
+                               bd_ail_st_list);
+               gfs2_assert(sdp, bd->bd_ail == ai);
+               bd->bd_ail = NULL;
+               list_del(&bd->bd_ail_st_list);
+               list_del(&bd->bd_ail_gl_list);
+               atomic_dec(&bd->bd_gl->gl_ail_count);
+               brelse(bd->bd_bh);
+       }
+}
+
 static void ail2_empty(struct gfs2_sbd *sdp, unsigned int new_tail)
 {
        struct gfs2_ail *ai, *safe;
@@ -195,57 +262,39 @@ static void ail2_empty(struct gfs2_sbd *sdp, unsigned int new_tail)
  * @sdp: The GFS2 superblock
  * @blks: The number of blocks to reserve
  *
+ * Note that we never give out the last 6 blocks of the journal. Thats
+ * due to the fact that there is are a small number of header blocks
+ * associated with each log flush. The exact number can't be known until
+ * flush time, so we ensure that we have just enough free blocks at all
+ * times to avoid running out during a log flush.
+ *
  * Returns: errno
  */
 
 int gfs2_log_reserve(struct gfs2_sbd *sdp, unsigned int blks)
 {
-       LIST_HEAD(list);
        unsigned int try = 0;
 
        if (gfs2_assert_warn(sdp, blks) ||
            gfs2_assert_warn(sdp, blks <= sdp->sd_jdesc->jd_blocks))
                return -EINVAL;
 
-       for (;;) {
-               gfs2_log_lock(sdp);
-
-               if (list_empty(&list)) {
-                       list_add_tail(&list, &sdp->sd_log_blks_list);
-                       while (sdp->sd_log_blks_list.next != &list) {
-                               DECLARE_WAITQUEUE(__wait_chan, current);
-                               set_current_state(TASK_UNINTERRUPTIBLE);
-                               add_wait_queue(&sdp->sd_log_blks_wait,
-                                              &__wait_chan);
-                               gfs2_log_unlock(sdp);
-                               schedule();
-                               gfs2_log_lock(sdp);
-                               remove_wait_queue(&sdp->sd_log_blks_wait,
-                                                 &__wait_chan);
-                               set_current_state(TASK_RUNNING);
-                       }
-               }
-
-               /* Never give away the last block so we can
-                  always pull the tail if we need to. */
-               if (sdp->sd_log_blks_free > blks) {
-                       sdp->sd_log_blks_free -= blks;
-                       list_del(&list);
-                       gfs2_log_unlock(sdp);
-                       wake_up(&sdp->sd_log_blks_wait);
-                       break;
-               }
-
+       mutex_lock(&sdp->sd_log_reserve_mutex);
+       gfs2_log_lock(sdp);
+       while(sdp->sd_log_blks_free <= (blks + 6)) {
                gfs2_log_unlock(sdp);
-
                gfs2_ail1_empty(sdp, 0);
-               gfs2_log_flush(sdp);
+               gfs2_log_flush(sdp, NULL);
 
                if (try++)
                        gfs2_ail1_start(sdp, 0);
+               gfs2_log_lock(sdp);
        }
+       sdp->sd_log_blks_free -= blks;
+       gfs2_log_unlock(sdp);
+       mutex_unlock(&sdp->sd_log_reserve_mutex);
 
-       lock_for_trans(sdp);
+       down_read(&sdp->sd_log_flush_lock);
 
        return 0;
 }
@@ -259,25 +308,29 @@ int gfs2_log_reserve(struct gfs2_sbd *sdp, unsigned int blks)
 
 void gfs2_log_release(struct gfs2_sbd *sdp, unsigned int blks)
 {
-       unlock_from_trans(sdp);
 
        gfs2_log_lock(sdp);
        sdp->sd_log_blks_free += blks;
        gfs2_assert_withdraw(sdp,
                             sdp->sd_log_blks_free <= sdp->sd_jdesc->jd_blocks);
        gfs2_log_unlock(sdp);
+       up_read(&sdp->sd_log_flush_lock);
 }
 
-static uint64_t log_bmap(struct gfs2_sbd *sdp, unsigned int lbn)
+static u64 log_bmap(struct gfs2_sbd *sdp, unsigned int lbn)
 {
-       int new = 0;
-       uint64_t dbn;
+       struct inode *inode = sdp->sd_jdesc->jd_inode;
        int error;
+       struct buffer_head bh_map = { .b_state = 0, .b_blocknr = 0 };
 
-       error = gfs2_block_map(sdp->sd_jdesc->jd_inode, lbn, &new, &dbn, NULL);
-       gfs2_assert_withdraw(sdp, !error && dbn);
+       bh_map.b_size = 1 << inode->i_blkbits;
+       error = gfs2_block_map(inode, lbn, 0, &bh_map);
+       if (error || !bh_map.b_blocknr)
+               printk(KERN_INFO "error=%d, dbn=%llu lbn=%u", error,
+                      (unsigned long long)bh_map.b_blocknr, lbn);
+       gfs2_assert_withdraw(sdp, !error && bh_map.b_blocknr);
 
-       return dbn;
+       return bh_map.b_blocknr;
 }
 
 /**
@@ -292,8 +345,7 @@ static uint64_t log_bmap(struct gfs2_sbd *sdp, unsigned int lbn)
  * Returns: the distance in blocks
  */
 
-static inline unsigned int log_distance(struct gfs2_sbd *sdp,
-                                       unsigned int newer,
+static inline unsigned int log_distance(struct gfs2_sbd *sdp, unsigned int newer,
                                        unsigned int older)
 {
        int dist;
@@ -312,11 +364,10 @@ static unsigned int current_tail(struct gfs2_sbd *sdp)
 
        gfs2_log_lock(sdp);
 
-       if (list_empty(&sdp->sd_ail1_list))
+       if (list_empty(&sdp->sd_ail1_list)) {
                tail = sdp->sd_log_head;
-       else {
-               ai = list_entry(sdp->sd_ail1_list.prev,
-                               struct gfs2_ail, ai_list);
+       } else {
+               ai = list_entry(sdp->sd_ail1_list.prev, struct gfs2_ail, ai_list);
                tail = ai->ai_first;
        }
 
@@ -328,8 +379,7 @@ static unsigned int current_tail(struct gfs2_sbd *sdp)
 static inline void log_incr_head(struct gfs2_sbd *sdp)
 {
        if (sdp->sd_log_flush_head == sdp->sd_log_tail)
-               gfs2_assert_withdraw(sdp,
-                               sdp->sd_log_flush_head == sdp->sd_log_head);
+               gfs2_assert_withdraw(sdp, sdp->sd_log_flush_head == sdp->sd_log_head);
 
        if (++sdp->sd_log_flush_head == sdp->sd_jdesc->jd_blocks) {
                sdp->sd_log_flush_head = 0;
@@ -346,7 +396,7 @@ static inline void log_incr_head(struct gfs2_sbd *sdp)
 
 struct buffer_head *gfs2_log_get_buf(struct gfs2_sbd *sdp)
 {
-       uint64_t blkno = log_bmap(sdp, sdp->sd_log_flush_head);
+       u64 blkno = log_bmap(sdp, sdp->sd_log_flush_head);
        struct gfs2_log_buf *lb;
        struct buffer_head *bh;
 
@@ -376,7 +426,7 @@ struct buffer_head *gfs2_log_get_buf(struct gfs2_sbd *sdp)
 struct buffer_head *gfs2_log_fake_buf(struct gfs2_sbd *sdp,
                                      struct buffer_head *real)
 {
-       uint64_t blkno = log_bmap(sdp, sdp->sd_log_flush_head);
+       u64 blkno = log_bmap(sdp, sdp->sd_log_flush_head);
        struct gfs2_log_buf *lb;
        struct buffer_head *bh;
 
@@ -387,8 +437,7 @@ struct buffer_head *gfs2_log_fake_buf(struct gfs2_sbd *sdp,
        bh = lb->lb_bh = alloc_buffer_head(GFP_NOFS | __GFP_NOFAIL);
        atomic_set(&bh->b_count, 1);
        bh->b_state = (1 << BH_Mapped) | (1 << BH_Uptodate);
-       set_bh_page(bh, virt_to_page(real->b_data),
-                   ((unsigned long)real->b_data) & (PAGE_SIZE - 1));
+       set_bh_page(bh, real->b_page, bh_offset(real));
        bh->b_blocknr = blkno;
        bh->b_size = sdp->sd_sb.sb_bsize;
        bh->b_bdev = sdp->sd_vfs->s_bdev;
@@ -405,9 +454,8 @@ static void log_pull_tail(struct gfs2_sbd *sdp, unsigned int new_tail, int pull)
        ail2_empty(sdp, new_tail);
 
        gfs2_log_lock(sdp);
-       sdp->sd_log_blks_free += dist - ((pull) ? 1 : 0);
-       gfs2_assert_withdraw(sdp,
-                            sdp->sd_log_blks_free <= sdp->sd_jdesc->jd_blocks);
+       sdp->sd_log_blks_free += dist - (pull ? 1 : 0);
+       gfs2_assert_withdraw(sdp, sdp->sd_log_blks_free <= sdp->sd_jdesc->jd_blocks);
        gfs2_log_unlock(sdp);
 
        sdp->sd_log_tail = new_tail;
@@ -420,15 +468,13 @@ static void log_pull_tail(struct gfs2_sbd *sdp, unsigned int new_tail, int pull)
  * Returns: the initialized log buffer descriptor
  */
 
-static void log_write_header(struct gfs2_sbd *sdp, uint32_t flags, int pull)
+static void log_write_header(struct gfs2_sbd *sdp, u32 flags, int pull)
 {
-       uint64_t blkno = log_bmap(sdp, sdp->sd_log_flush_head);
+       u64 blkno = log_bmap(sdp, sdp->sd_log_flush_head);
        struct buffer_head *bh;
        struct gfs2_log_header *lh;
        unsigned int tail;
-       uint32_t hash;
-
-       atomic_inc(&sdp->sd_log_flush_ondisk);
+       u32 hash;
 
        bh = sb_getblk(sdp->sd_vfs, blkno);
        lock_buffer(bh);
@@ -443,12 +489,12 @@ static void log_write_header(struct gfs2_sbd *sdp, uint32_t flags, int pull)
        lh = (struct gfs2_log_header *)bh->b_data;
        memset(lh, 0, sizeof(struct gfs2_log_header));
        lh->lh_header.mh_magic = cpu_to_be32(GFS2_MAGIC);
-       lh->lh_header.mh_type = cpu_to_be16(GFS2_METATYPE_LH);
-       lh->lh_header.mh_format = cpu_to_be16(GFS2_FORMAT_LH);
-       lh->lh_sequence = be64_to_cpu(sdp->sd_log_sequence++);
-       lh->lh_flags = be32_to_cpu(flags);
-       lh->lh_tail = be32_to_cpu(tail);
-       lh->lh_blkno = be32_to_cpu(sdp->sd_log_flush_head);
+       lh->lh_header.mh_type = cpu_to_be32(GFS2_METATYPE_LH);
+       lh->lh_header.mh_format = cpu_to_be32(GFS2_FORMAT_LH);
+       lh->lh_sequence = cpu_to_be64(sdp->sd_log_sequence++);
+       lh->lh_flags = cpu_to_be32(flags);
+       lh->lh_tail = cpu_to_be32(tail);
+       lh->lh_blkno = cpu_to_be32(sdp->sd_log_flush_head);
        hash = gfs2_disk_hash(bh->b_data, sizeof(struct gfs2_log_header));
        lh->lh_hash = cpu_to_be32(hash);
 
@@ -471,11 +517,6 @@ static void log_flush_commit(struct gfs2_sbd *sdp)
        struct list_head *head = &sdp->sd_log_flush_list;
        struct gfs2_log_buf *lb;
        struct buffer_head *bh;
-       unsigned int d;
-
-       d = log_distance(sdp, sdp->sd_log_flush_head, sdp->sd_log_head);
-
-       gfs2_assert_withdraw(sdp, d + 1 == sdp->sd_log_blks_reserved);
 
        while (!list_empty(head)) {
                lb = list_entry(head->next, struct gfs2_log_buf, lb_list);
@@ -498,37 +539,36 @@ static void log_flush_commit(struct gfs2_sbd *sdp)
 }
 
 /**
- * gfs2_log_flush_i - flush incore transaction(s)
+ * gfs2_log_flush - flush incore transaction(s)
  * @sdp: the filesystem
  * @gl: The glock structure to flush.  If NULL, flush the whole incore log
  *
  */
 
-void gfs2_log_flush_i(struct gfs2_sbd *sdp, struct gfs2_glock *gl)
+void gfs2_log_flush(struct gfs2_sbd *sdp, struct gfs2_glock *gl)
 {
        struct gfs2_ail *ai;
 
-       atomic_inc(&sdp->sd_log_flush_incore);
+       down_write(&sdp->sd_log_flush_lock);
+
+       if (gl) {
+               gfs2_log_lock(sdp);
+               if (list_empty(&gl->gl_le.le_list)) {
+                       gfs2_log_unlock(sdp);
+                       up_write(&sdp->sd_log_flush_lock);
+                       return;
+               }
+               gfs2_log_unlock(sdp);
+       }
 
        ai = kzalloc(sizeof(struct gfs2_ail), GFP_NOFS | __GFP_NOFAIL);
        INIT_LIST_HEAD(&ai->ai_ail1_list);
        INIT_LIST_HEAD(&ai->ai_ail2_list);
 
-       gfs2_lock_for_flush(sdp);
-       down(&sdp->sd_log_flush_lock);
-
-       gfs2_assert_withdraw(sdp,
-                       sdp->sd_log_num_buf == sdp->sd_log_commited_buf);
+       gfs2_assert_withdraw(sdp, sdp->sd_log_num_buf == sdp->sd_log_commited_buf);
        gfs2_assert_withdraw(sdp,
                        sdp->sd_log_num_revoke == sdp->sd_log_commited_revoke);
 
-       if (gl && list_empty(&gl->gl_le.le_list)) {
-               up(&sdp->sd_log_flush_lock);
-               gfs2_unlock_from_flush(sdp);
-               kfree(ai);
-               return;
-       }
-
        sdp->sd_log_flush_head = sdp->sd_log_head;
        sdp->sd_log_flush_wrapped = 0;
        ai->ai_first = sdp->sd_log_flush_head;
@@ -540,31 +580,29 @@ void gfs2_log_flush_i(struct gfs2_sbd *sdp, struct gfs2_glock *gl)
                log_write_header(sdp, 0, PULL);
        lops_after_commit(sdp, ai);
 
+       gfs2_log_lock(sdp);
        sdp->sd_log_head = sdp->sd_log_flush_head;
-       if (sdp->sd_log_flush_wrapped)
-               sdp->sd_log_wraps++;
-
-       sdp->sd_log_blks_reserved =
-               sdp->sd_log_commited_buf =
-               sdp->sd_log_commited_revoke = 0;
+       sdp->sd_log_blks_free -= sdp->sd_log_num_hdrs;
+       sdp->sd_log_blks_reserved = 0;
+       sdp->sd_log_commited_buf = 0;
+       sdp->sd_log_num_hdrs = 0;
+       sdp->sd_log_commited_revoke = 0;
 
-       gfs2_log_lock(sdp);
        if (!list_empty(&ai->ai_ail1_list)) {
                list_add(&ai->ai_list, &sdp->sd_ail1_list);
                ai = NULL;
        }
        gfs2_log_unlock(sdp);
 
-       up(&sdp->sd_log_flush_lock);
        sdp->sd_vfs->s_dirt = 0;
-       gfs2_unlock_from_flush(sdp);
+       up_write(&sdp->sd_log_flush_lock);
 
        kfree(ai);
 }
 
 static void log_refund(struct gfs2_sbd *sdp, struct gfs2_trans *tr)
 {
-       unsigned int reserved = 1;
+       unsigned int reserved = 0;
        unsigned int old;
 
        gfs2_log_lock(sdp);
@@ -575,19 +613,21 @@ static void log_refund(struct gfs2_sbd *sdp, struct gfs2_trans *tr)
        gfs2_assert_withdraw(sdp, ((int)sdp->sd_log_commited_revoke) >= 0);
 
        if (sdp->sd_log_commited_buf)
-               reserved += 1 + sdp->sd_log_commited_buf + sdp->sd_log_commited_buf/503;
+               reserved += sdp->sd_log_commited_buf;
        if (sdp->sd_log_commited_revoke)
                reserved += gfs2_struct2blk(sdp, sdp->sd_log_commited_revoke,
-                                           sizeof(uint64_t));
+                                           sizeof(u64));
+       if (reserved)
+               reserved++;
 
        old = sdp->sd_log_blks_free;
        sdp->sd_log_blks_free += tr->tr_reserved -
                                 (reserved - sdp->sd_log_blks_reserved);
 
+       gfs2_assert_withdraw(sdp, sdp->sd_log_blks_free >= old);
        gfs2_assert_withdraw(sdp,
-                            sdp->sd_log_blks_free >= old);
-       gfs2_assert_withdraw(sdp,
-                            sdp->sd_log_blks_free <= sdp->sd_jdesc->jd_blocks);
+                            sdp->sd_log_blks_free <= sdp->sd_jdesc->jd_blocks +
+                            sdp->sd_log_num_hdrs);
 
        sdp->sd_log_blks_reserved = reserved;
 
@@ -608,16 +648,12 @@ void gfs2_log_commit(struct gfs2_sbd *sdp, struct gfs2_trans *tr)
        lops_incore_commit(sdp, tr);
 
        sdp->sd_vfs->s_dirt = 1;
-       unlock_from_trans(sdp);
-
-       kfree(tr);
+       up_read(&sdp->sd_log_flush_lock);
 
        gfs2_log_lock(sdp);
-       if (sdp->sd_log_num_buf > gfs2_tune_get(sdp, gt_incore_log_blocks)) {
-               gfs2_log_unlock(sdp);
-               gfs2_log_flush(sdp);
-       } else
-               gfs2_log_unlock(sdp);
+       if (sdp->sd_log_num_buf > gfs2_tune_get(sdp, gt_incore_log_blocks))
+               wake_up_process(sdp->sd_logd_process);
+       gfs2_log_unlock(sdp);
 }
 
 /**
@@ -628,15 +664,16 @@ void gfs2_log_commit(struct gfs2_sbd *sdp, struct gfs2_trans *tr)
 
 void gfs2_log_shutdown(struct gfs2_sbd *sdp)
 {
-       down(&sdp->sd_log_flush_lock);
+       down_write(&sdp->sd_log_flush_lock);
 
-       gfs2_assert_withdraw(sdp, !atomic_read(&sdp->sd_log_trans_count));
        gfs2_assert_withdraw(sdp, !sdp->sd_log_blks_reserved);
        gfs2_assert_withdraw(sdp, !sdp->sd_log_num_gl);
        gfs2_assert_withdraw(sdp, !sdp->sd_log_num_buf);
+       gfs2_assert_withdraw(sdp, !sdp->sd_log_num_jdata);
        gfs2_assert_withdraw(sdp, !sdp->sd_log_num_revoke);
        gfs2_assert_withdraw(sdp, !sdp->sd_log_num_rg);
        gfs2_assert_withdraw(sdp, !sdp->sd_log_num_databuf);
+       gfs2_assert_withdraw(sdp, !sdp->sd_log_num_hdrs);
        gfs2_assert_withdraw(sdp, list_empty(&sdp->sd_ail1_list));
 
        sdp->sd_log_flush_head = sdp->sd_log_head;
@@ -644,16 +681,31 @@ void gfs2_log_shutdown(struct gfs2_sbd *sdp)
 
        log_write_header(sdp, GFS2_LOG_HEAD_UNMOUNT, 0);
 
-       gfs2_assert_withdraw(sdp, sdp->sd_log_blks_free ==
-                            sdp->sd_jdesc->jd_blocks);
-       gfs2_assert_withdraw(sdp, sdp->sd_log_head == sdp->sd_log_tail);
-       gfs2_assert_withdraw(sdp, list_empty(&sdp->sd_ail2_list));
+       gfs2_assert_warn(sdp, sdp->sd_log_blks_free == sdp->sd_jdesc->jd_blocks);
+       gfs2_assert_warn(sdp, sdp->sd_log_head == sdp->sd_log_tail);
+       gfs2_assert_warn(sdp, list_empty(&sdp->sd_ail2_list));
 
        sdp->sd_log_head = sdp->sd_log_flush_head;
-       if (sdp->sd_log_flush_wrapped)
-               sdp->sd_log_wraps++;
        sdp->sd_log_tail = sdp->sd_log_head;
 
-       up(&sdp->sd_log_flush_lock);
+       up_write(&sdp->sd_log_flush_lock);
+}
+
+
+/**
+ * gfs2_meta_syncfs - sync all the buffers in a filesystem
+ * @sdp: the filesystem
+ *
+ */
+
+void gfs2_meta_syncfs(struct gfs2_sbd *sdp)
+{
+       gfs2_log_flush(sdp, NULL);
+       for (;;) {
+               gfs2_ail1_start(sdp, DIO_ALL);
+               if (gfs2_ail1_empty(sdp, DIO_ALL))
+                       break;
+               msleep(10);
+       }
 }