lib: Introduce generic list_sort function
[safe/jmp/linux-2.6] / fs / cifs / transport.c
index 4d076be..07b8e71 100644 (file)
@@ -103,132 +103,8 @@ DeleteMidQEntry(struct mid_q_entry *midEntry)
        mempool_free(midEntry, cifs_mid_poolp);
 }
 
-struct oplock_q_entry *
-AllocOplockQEntry(struct inode *pinode, __u16 fid, struct cifsTconInfo *tcon)
-{
-       struct oplock_q_entry *temp;
-       if ((pinode == NULL) || (tcon == NULL)) {
-               cERROR(1, ("Null parms passed to AllocOplockQEntry"));
-               return NULL;
-       }
-       temp = (struct oplock_q_entry *) kmem_cache_alloc(cifs_oplock_cachep,
-                                                      GFP_KERNEL);
-       if (temp == NULL)
-               return temp;
-       else {
-               temp->pinode = pinode;
-               temp->tcon = tcon;
-               temp->netfid = fid;
-               spin_lock(&GlobalMid_Lock);
-               list_add_tail(&temp->qhead, &GlobalOplock_Q);
-               spin_unlock(&GlobalMid_Lock);
-       }
-       return temp;
-
-}
-
-void DeleteOplockQEntry(struct oplock_q_entry *oplockEntry)
-{
-       spin_lock(&GlobalMid_Lock);
-    /* should we check if list empty first? */
-       list_del(&oplockEntry->qhead);
-       spin_unlock(&GlobalMid_Lock);
-       kmem_cache_free(cifs_oplock_cachep, oplockEntry);
-}
-
-
-void DeleteTconOplockQEntries(struct cifsTconInfo *tcon)
-{
-       struct oplock_q_entry *temp;
-
-       if (tcon == NULL)
-               return;
-
-       spin_lock(&GlobalMid_Lock);
-       list_for_each_entry(temp, &GlobalOplock_Q, qhead) {
-               if ((temp->tcon) && (temp->tcon == tcon)) {
-                       list_del(&temp->qhead);
-                       kmem_cache_free(cifs_oplock_cachep, temp);
-               }
-       }
-       spin_unlock(&GlobalMid_Lock);
-}
-
-int
-smb_send(struct socket *ssocket, struct smb_hdr *smb_buffer,
-        unsigned int smb_buf_length, struct sockaddr *sin, bool noblocksnd)
-{
-       int rc = 0;
-       int i = 0;
-       struct msghdr smb_msg;
-       struct kvec iov;
-       unsigned len = smb_buf_length + 4;
-
-       if (ssocket == NULL)
-               return -ENOTSOCK; /* BB eventually add reconnect code here */
-       iov.iov_base = smb_buffer;
-       iov.iov_len = len;
-
-       smb_msg.msg_name = sin;
-       smb_msg.msg_namelen = sizeof(struct sockaddr);
-       smb_msg.msg_control = NULL;
-       smb_msg.msg_controllen = 0;
-       if (noblocksnd)
-               smb_msg.msg_flags = MSG_DONTWAIT + MSG_NOSIGNAL;
-       else
-               smb_msg.msg_flags = MSG_NOSIGNAL;
-
-       /* smb header is converted in header_assemble. bcc and rest of SMB word
-          area, and byte area if necessary, is converted to littleendian in
-          cifssmb.c and RFC1001 len is converted to bigendian in smb_send
-          Flags2 is converted in SendReceive */
-
-       smb_buffer->smb_buf_length = cpu_to_be32(smb_buffer->smb_buf_length);
-       cFYI(1, ("Sending smb of length %d", smb_buf_length));
-       dump_smb(smb_buffer, len);
-
-       while (len > 0) {
-               rc = kernel_sendmsg(ssocket, &smb_msg, &iov, 1, len);
-               if ((rc == -ENOSPC) || (rc == -EAGAIN)) {
-                       i++;
-               /* smaller timeout here than send2 since smaller size */
-               /* Although it may not be required, this also is smaller
-                  oplock break time */
-                       if (i > 12) {
-                               cERROR(1,
-                                  ("sends on sock %p stuck for 7 seconds",
-                                   ssocket));
-                               rc = -EAGAIN;
-                               break;
-                       }
-                       msleep(1 << i);
-                       continue;
-               }
-               if (rc < 0)
-                       break;
-               else
-                       i = 0; /* reset i after each successful send */
-               iov.iov_base += rc;
-               iov.iov_len -= rc;
-               len -= rc;
-       }
-
-       if (rc < 0) {
-               cERROR(1, ("Error %d sending data on socket to server", rc));
-       } else {
-               rc = 0;
-       }
-
-       /* Don't want to modify the buffer as a
-          side effect of this call. */
-       smb_buffer->smb_buf_length = smb_buf_length;
-
-       return rc;
-}
-
 static int
-smb_send2(struct TCP_Server_Info *server, struct kvec *iov, int n_vec,
-         struct sockaddr *sin, bool noblocksnd)
+smb_sendv(struct TCP_Server_Info *server, struct kvec *iov, int n_vec)
 {
        int rc = 0;
        int i = 0;
@@ -243,11 +119,11 @@ smb_send2(struct TCP_Server_Info *server, struct kvec *iov, int n_vec,
        if (ssocket == NULL)
                return -ENOTSOCK; /* BB eventually add reconnect code here */
 
-       smb_msg.msg_name = sin;
+       smb_msg.msg_name = (struct sockaddr *) &server->addr.sockAddr;
        smb_msg.msg_namelen = sizeof(struct sockaddr);
        smb_msg.msg_control = NULL;
        smb_msg.msg_controllen = 0;
-       if (noblocksnd)
+       if (server->noblocksnd)
                smb_msg.msg_flags = MSG_DONTWAIT + MSG_NOSIGNAL;
        else
                smb_msg.msg_flags = MSG_NOSIGNAL;
@@ -272,7 +148,25 @@ smb_send2(struct TCP_Server_Info *server, struct kvec *iov, int n_vec,
                                    n_vec - first_vec, total_len);
                if ((rc == -ENOSPC) || (rc == -EAGAIN)) {
                        i++;
-                       if (i >= 14) {
+                       /* if blocking send we try 3 times, since each can block
+                          for 5 seconds. For nonblocking  we have to try more
+                          but wait increasing amounts of time allowing time for
+                          socket to clear.  The overall time we wait in either
+                          case to send on the socket is about 15 seconds.
+                          Similarly we wait for 15 seconds for
+                          a response from the server in SendReceive[2]
+                          for the server to send a response back for
+                          most types of requests (except SMB Write
+                          past end of file which can be slow, and
+                          blocking lock operations). NFS waits slightly longer
+                          than CIFS, but this can make it take longer for
+                          nonresponsive servers to be detected and 15 seconds
+                          is more than enough time for modern networks to
+                          send a packet.  In most cases if we fail to send
+                          after the retries we will kill the socket and
+                          reconnect which may clear the network problem.
+                       */
+                       if ((i >= 14) || (!server->noblocksnd && (i > 2))) {
                                cERROR(1,
                                   ("sends on sock %p stuck for 15 seconds",
                                    ssocket));
@@ -339,42 +233,55 @@ smb_send2(struct TCP_Server_Info *server, struct kvec *iov, int n_vec,
        return rc;
 }
 
+int
+smb_send(struct TCP_Server_Info *server, struct smb_hdr *smb_buffer,
+        unsigned int smb_buf_length)
+{
+       struct kvec iov;
+
+       iov.iov_base = smb_buffer;
+       iov.iov_len = smb_buf_length + 4;
+
+       return smb_sendv(server, &iov, 1);
+}
+
 static int wait_for_free_request(struct cifsSesInfo *ses, const int long_op)
 {
        if (long_op == CIFS_ASYNC_OP) {
                /* oplock breaks must not be held up */
                atomic_inc(&ses->server->inFlight);
-       } else {
-               spin_lock(&GlobalMid_Lock);
-               while (1) {
-                       if (atomic_read(&ses->server->inFlight) >=
-                                       cifs_max_pending){
-                               spin_unlock(&GlobalMid_Lock);
+               return 0;
+       }
+
+       spin_lock(&GlobalMid_Lock);
+       while (1) {
+               if (atomic_read(&ses->server->inFlight) >=
+                               cifs_max_pending){
+                       spin_unlock(&GlobalMid_Lock);
 #ifdef CONFIG_CIFS_STATS2
-                               atomic_inc(&ses->server->num_waiters);
+                       atomic_inc(&ses->server->num_waiters);
 #endif
-                               wait_event(ses->server->request_q,
-                                       atomic_read(&ses->server->inFlight)
-                                        < cifs_max_pending);
+                       wait_event(ses->server->request_q,
+                                  atomic_read(&ses->server->inFlight)
+                                    < cifs_max_pending);
 #ifdef CONFIG_CIFS_STATS2
-                               atomic_dec(&ses->server->num_waiters);
+                       atomic_dec(&ses->server->num_waiters);
 #endif
-                               spin_lock(&GlobalMid_Lock);
-                       } else {
-                               if (ses->server->tcpStatus == CifsExiting) {
-                                       spin_unlock(&GlobalMid_Lock);
-                                       return -ENOENT;
-                               }
-
-                               /* can not count locking commands against total
-                                  as they are allowed to block on server */
-
-                               /* update # of requests on the wire to server */
-                               if (long_op != CIFS_BLOCKING_OP)
-                                       atomic_inc(&ses->server->inFlight);
+                       spin_lock(&GlobalMid_Lock);
+               } else {
+                       if (ses->server->tcpStatus == CifsExiting) {
                                spin_unlock(&GlobalMid_Lock);
-                               break;
+                               return -ENOENT;
                        }
+
+                       /* can not count locking commands against total
+                          as they are allowed to block on server */
+
+                       /* update # of requests on the wire to server */
+                       if (long_op != CIFS_BLOCKING_OP)
+                               atomic_inc(&ses->server->inFlight);
+                       spin_unlock(&GlobalMid_Lock);
+                       break;
                }
        }
        return 0;
@@ -385,10 +292,14 @@ static int allocate_mid(struct cifsSesInfo *ses, struct smb_hdr *in_buf,
 {
        if (ses->server->tcpStatus == CifsExiting) {
                return -ENOENT;
-       } else if (ses->server->tcpStatus == CifsNeedReconnect) {
+       }
+
+       if (ses->server->tcpStatus == CifsNeedReconnect) {
                cFYI(1, ("tcp session dead - return to caller to retry"));
                return -EAGAIN;
-       } else if (ses->status != CifsGood) {
+       }
+
+       if (ses->status != CifsGood) {
                /* check if SMB session is bad because we are setting it up */
                if ((in_buf->Command != SMB_COM_SESSION_SETUP_ANDX) &&
                        (in_buf->Command != SMB_COM_NEGOTIATE))
@@ -525,14 +436,17 @@ SendReceive2(const unsigned int xid, struct cifsSesInfo *ses,
                return rc;
        }
        rc = cifs_sign_smb2(iov, n_vec, ses->server, &midQ->sequence_number);
+       if (rc) {
+               mutex_unlock(&ses->server->srv_mutex);
+               cifs_small_buf_release(in_buf);
+               goto out;
+       }
 
        midQ->midState = MID_REQUEST_SUBMITTED;
 #ifdef CONFIG_CIFS_STATS2
        atomic_inc(&ses->server->inSend);
 #endif
-       rc = smb_send2(ses->server, iov, n_vec,
-                     (struct sockaddr *) &(ses->server->addr.sockAddr),
-                      ses->server->noblocksnd);
+       rc = smb_sendv(ses->server, iov, n_vec);
 #ifdef CONFIG_CIFS_STATS2
        atomic_dec(&ses->server->inSend);
        midQ->when_sent = jiffies;
@@ -573,10 +487,8 @@ SendReceive2(const unsigned int xid, struct cifsSesInfo *ses,
        wait_for_response(ses, midQ, timeout, 10 * HZ);
 
        spin_lock(&GlobalMid_Lock);
-       if (midQ->resp_buf) {
-               spin_unlock(&GlobalMid_Lock);
-               receive_len = midQ->resp_buf->smb_buf_length;
-       } else {
+
+       if (midQ->resp_buf == NULL) {
                cERROR(1, ("No response to cmd %d mid %d",
                        midQ->command, midQ->mid));
                if (midQ->midState == MID_REQUEST_SUBMITTED) {
@@ -604,53 +516,59 @@ SendReceive2(const unsigned int xid, struct cifsSesInfo *ses,
                return rc;
        }
 
+       spin_unlock(&GlobalMid_Lock);
+       receive_len = midQ->resp_buf->smb_buf_length;
+
        if (receive_len > CIFSMaxBufSize + MAX_CIFS_HDR_SIZE) {
                cERROR(1, ("Frame too large received.  Length: %d  Xid: %d",
                        receive_len, xid));
                rc = -EIO;
-       } else {                /* rcvd frame is ok */
-               if (midQ->resp_buf &&
-                       (midQ->midState == MID_RESPONSE_RECEIVED)) {
-
-                       iov[0].iov_base = (char *)midQ->resp_buf;
-                       if (midQ->largeBuf)
-                               *pRespBufType = CIFS_LARGE_BUFFER;
-                       else
-                               *pRespBufType = CIFS_SMALL_BUFFER;
-                       iov[0].iov_len = receive_len + 4;
-
-                       dump_smb(midQ->resp_buf, 80);
-                       /* convert the length into a more usable form */
-                       if ((receive_len > 24) &&
-                          (ses->server->secMode & (SECMODE_SIGN_REQUIRED |
-                                       SECMODE_SIGN_ENABLED))) {
-                               rc = cifs_verify_signature(midQ->resp_buf,
+               goto out;
+       }
+
+       /* rcvd frame is ok */
+
+       if (midQ->resp_buf &&
+           (midQ->midState == MID_RESPONSE_RECEIVED)) {
+
+               iov[0].iov_base = (char *)midQ->resp_buf;
+               if (midQ->largeBuf)
+                       *pRespBufType = CIFS_LARGE_BUFFER;
+               else
+                       *pRespBufType = CIFS_SMALL_BUFFER;
+               iov[0].iov_len = receive_len + 4;
+
+               dump_smb(midQ->resp_buf, 80);
+               /* convert the length into a more usable form */
+               if ((receive_len > 24) &&
+                   (ses->server->secMode & (SECMODE_SIGN_REQUIRED |
+                                            SECMODE_SIGN_ENABLED))) {
+                       rc = cifs_verify_signature(midQ->resp_buf,
                                                &ses->server->mac_signing_key,
                                                midQ->sequence_number+1);
-                               if (rc) {
-                                       cERROR(1, ("Unexpected SMB signature"));
-                                       /* BB FIXME add code to kill session */
-                               }
+                       if (rc) {
+                               cERROR(1, ("Unexpected SMB signature"));
+                               /* BB FIXME add code to kill session */
                        }
-
-                       /* BB special case reconnect tid and uid here? */
-                       rc = map_smb_to_linux_error(midQ->resp_buf,
-                                               flags & CIFS_LOG_ERROR);
-
-                       /* convert ByteCount if necessary */
-                       if (receive_len >= sizeof(struct smb_hdr) - 4
-                           /* do not count RFC1001 header */  +
-                           (2 * midQ->resp_buf->WordCount) + 2 /* bcc */ )
-                               BCC(midQ->resp_buf) =
-                                       le16_to_cpu(BCC_LE(midQ->resp_buf));
-                       if ((flags & CIFS_NO_RESP) == 0)
-                               midQ->resp_buf = NULL;  /* mark it so buf will
-                                                          not be freed by
-                                                          DeleteMidQEntry */
-               } else {
-                       rc = -EIO;
-                       cFYI(1, ("Bad MID state?"));
                }
+
+               /* BB special case reconnect tid and uid here? */
+               rc = map_smb_to_linux_error(midQ->resp_buf,
+                                           flags & CIFS_LOG_ERROR);
+
+               /* convert ByteCount if necessary */
+               if (receive_len >= sizeof(struct smb_hdr) - 4
+                   /* do not count RFC1001 header */  +
+                   (2 * midQ->resp_buf->WordCount) + 2 /* bcc */ )
+                       BCC(midQ->resp_buf) =
+                               le16_to_cpu(BCC_LE(midQ->resp_buf));
+               if ((flags & CIFS_NO_RESP) == 0)
+                       midQ->resp_buf = NULL;  /* mark it so buf will
+                                                  not be freed by
+                                                  DeleteMidQEntry */
+       } else {
+               rc = -EIO;
+               cFYI(1, ("Bad MID state?"));
        }
 
 out:
@@ -687,6 +605,12 @@ SendReceive(const unsigned int xid, struct cifsSesInfo *ses,
           to the same server. We may make this configurable later or
           use ses->maxReq */
 
+       if (in_buf->smb_buf_length > CIFSMaxBufSize + MAX_CIFS_HDR_SIZE - 4) {
+               cERROR(1, ("Illegal length, greater than maximum frame, %d",
+                          in_buf->smb_buf_length));
+               return -EIO;
+       }
+
        rc = wait_for_free_request(ses, long_op);
        if (rc)
                return rc;
@@ -706,26 +630,17 @@ SendReceive(const unsigned int xid, struct cifsSesInfo *ses,
                return rc;
        }
 
-       if (in_buf->smb_buf_length > CIFSMaxBufSize + MAX_CIFS_HDR_SIZE - 4) {
-               cERROR(1, ("Illegal length, greater than maximum frame, %d",
-                       in_buf->smb_buf_length));
-               DeleteMidQEntry(midQ);
+       rc = cifs_sign_smb(in_buf, ses->server, &midQ->sequence_number);
+       if (rc) {
                mutex_unlock(&ses->server->srv_mutex);
-               /* Update # of requests on wire to server */
-               atomic_dec(&ses->server->inFlight);
-               wake_up(&ses->server->request_q);
-               return -EIO;
+               goto out;
        }
 
-       rc = cifs_sign_smb(in_buf, ses->server, &midQ->sequence_number);
-
        midQ->midState = MID_REQUEST_SUBMITTED;
 #ifdef CONFIG_CIFS_STATS2
        atomic_inc(&ses->server->inSend);
 #endif
-       rc = smb_send(ses->server->ssocket, in_buf, in_buf->smb_buf_length,
-                     (struct sockaddr *) &(ses->server->addr.sockAddr),
-                     ses->server->noblocksnd);
+       rc = smb_send(ses->server, in_buf, in_buf->smb_buf_length);
 #ifdef CONFIG_CIFS_STATS2
        atomic_dec(&ses->server->inSend);
        midQ->when_sent = jiffies;
@@ -764,10 +679,7 @@ SendReceive(const unsigned int xid, struct cifsSesInfo *ses,
        wait_for_response(ses, midQ, timeout, 10 * HZ);
 
        spin_lock(&GlobalMid_Lock);
-       if (midQ->resp_buf) {
-               spin_unlock(&GlobalMid_Lock);
-               receive_len = midQ->resp_buf->smb_buf_length;
-       } else {
+       if (midQ->resp_buf == NULL) {
                cERROR(1, ("No response for cmd %d mid %d",
                          midQ->command, midQ->mid));
                if (midQ->midState == MID_REQUEST_SUBMITTED) {
@@ -795,47 +707,52 @@ SendReceive(const unsigned int xid, struct cifsSesInfo *ses,
                return rc;
        }
 
+       spin_unlock(&GlobalMid_Lock);
+       receive_len = midQ->resp_buf->smb_buf_length;
+
        if (receive_len > CIFSMaxBufSize + MAX_CIFS_HDR_SIZE) {
                cERROR(1, ("Frame too large received.  Length: %d  Xid: %d",
                        receive_len, xid));
                rc = -EIO;
-       } else {                /* rcvd frame is ok */
-
-               if (midQ->resp_buf && out_buf
-                   && (midQ->midState == MID_RESPONSE_RECEIVED)) {
-                       out_buf->smb_buf_length = receive_len;
-                       memcpy((char *)out_buf + 4,
-                              (char *)midQ->resp_buf + 4,
-                              receive_len);
-
-                       dump_smb(out_buf, 92);
-                       /* convert the length into a more usable form */
-                       if ((receive_len > 24) &&
-                          (ses->server->secMode & (SECMODE_SIGN_REQUIRED |
-                                       SECMODE_SIGN_ENABLED))) {
-                               rc = cifs_verify_signature(out_buf,
+               goto out;
+       }
+
+       /* rcvd frame is ok */
+
+       if (midQ->resp_buf && out_buf
+           && (midQ->midState == MID_RESPONSE_RECEIVED)) {
+               out_buf->smb_buf_length = receive_len;
+               memcpy((char *)out_buf + 4,
+                      (char *)midQ->resp_buf + 4,
+                      receive_len);
+
+               dump_smb(out_buf, 92);
+               /* convert the length into a more usable form */
+               if ((receive_len > 24) &&
+                   (ses->server->secMode & (SECMODE_SIGN_REQUIRED |
+                                            SECMODE_SIGN_ENABLED))) {
+                       rc = cifs_verify_signature(out_buf,
                                                &ses->server->mac_signing_key,
                                                midQ->sequence_number+1);
-                               if (rc) {
-                                       cERROR(1, ("Unexpected SMB signature"));
-                                       /* BB FIXME add code to kill session */
-                               }
+                       if (rc) {
+                               cERROR(1, ("Unexpected SMB signature"));
+                               /* BB FIXME add code to kill session */
                        }
+               }
 
-                       *pbytes_returned = out_buf->smb_buf_length;
+               *pbytes_returned = out_buf->smb_buf_length;
 
-                       /* BB special case reconnect tid and uid here? */
-                       rc = map_smb_to_linux_error(out_buf, 0 /* no log */ );
+               /* BB special case reconnect tid and uid here? */
+               rc = map_smb_to_linux_error(out_buf, 0 /* no log */ );
 
-                       /* convert ByteCount if necessary */
-                       if (receive_len >= sizeof(struct smb_hdr) - 4
-                           /* do not count RFC1001 header */  +
-                           (2 * out_buf->WordCount) + 2 /* bcc */ )
-                               BCC(out_buf) = le16_to_cpu(BCC_LE(out_buf));
-               } else {
-                       rc = -EIO;
-                       cERROR(1, ("Bad MID state?"));
-               }
+               /* convert ByteCount if necessary */
+               if (receive_len >= sizeof(struct smb_hdr) - 4
+                   /* do not count RFC1001 header */  +
+                   (2 * out_buf->WordCount) + 2 /* bcc */ )
+                       BCC(out_buf) = le16_to_cpu(BCC_LE(out_buf));
+       } else {
+               rc = -EIO;
+               cERROR(1, ("Bad MID state?"));
        }
 
 out:
@@ -864,9 +781,7 @@ send_nt_cancel(struct cifsTconInfo *tcon, struct smb_hdr *in_buf,
                mutex_unlock(&ses->server->srv_mutex);
                return rc;
        }
-       rc = smb_send(ses->server->ssocket, in_buf, in_buf->smb_buf_length,
-             (struct sockaddr *) &(ses->server->addr.sockAddr),
-             ses->server->noblocksnd);
+       rc = smb_send(ses->server, in_buf, in_buf->smb_buf_length);
        mutex_unlock(&ses->server->srv_mutex);
        return rc;
 }
@@ -925,6 +840,12 @@ SendReceiveBlockingLock(const unsigned int xid, struct cifsTconInfo *tcon,
           to the same server. We may make this configurable later or
           use ses->maxReq */
 
+       if (in_buf->smb_buf_length > CIFSMaxBufSize + MAX_CIFS_HDR_SIZE - 4) {
+               cERROR(1, ("Illegal length, greater than maximum frame, %d",
+                          in_buf->smb_buf_length));
+               return -EIO;
+       }
+
        rc = wait_for_free_request(ses, CIFS_BLOCKING_OP);
        if (rc)
                return rc;
@@ -941,23 +862,18 @@ SendReceiveBlockingLock(const unsigned int xid, struct cifsTconInfo *tcon,
                return rc;
        }
 
-       if (in_buf->smb_buf_length > CIFSMaxBufSize + MAX_CIFS_HDR_SIZE - 4) {
-               mutex_unlock(&ses->server->srv_mutex);
-               cERROR(1, ("Illegal length, greater than maximum frame, %d",
-                       in_buf->smb_buf_length));
+       rc = cifs_sign_smb(in_buf, ses->server, &midQ->sequence_number);
+       if (rc) {
                DeleteMidQEntry(midQ);
-               return -EIO;
+               mutex_unlock(&ses->server->srv_mutex);
+               return rc;
        }
 
-       rc = cifs_sign_smb(in_buf, ses->server, &midQ->sequence_number);
-
        midQ->midState = MID_REQUEST_SUBMITTED;
 #ifdef CONFIG_CIFS_STATS2
        atomic_inc(&ses->server->inSend);
 #endif
-       rc = smb_send(ses->server->ssocket, in_buf, in_buf->smb_buf_length,
-                     (struct sockaddr *) &(ses->server->addr.sockAddr),
-                     ses->server->noblocksnd);
+       rc = smb_send(ses->server, in_buf, in_buf->smb_buf_length);
 #ifdef CONFIG_CIFS_STATS2
        atomic_dec(&ses->server->inSend);
        midQ->when_sent = jiffies;
@@ -1044,44 +960,48 @@ SendReceiveBlockingLock(const unsigned int xid, struct cifsTconInfo *tcon,
                cERROR(1, ("Frame too large received.  Length: %d  Xid: %d",
                        receive_len, xid));
                rc = -EIO;
-       } else {                /* rcvd frame is ok */
-
-               if (midQ->resp_buf && out_buf
-                   && (midQ->midState == MID_RESPONSE_RECEIVED)) {
-                       out_buf->smb_buf_length = receive_len;
-                       memcpy((char *)out_buf + 4,
-                              (char *)midQ->resp_buf + 4,
-                              receive_len);
-
-                       dump_smb(out_buf, 92);
-                       /* convert the length into a more usable form */
-                       if ((receive_len > 24) &&
-                          (ses->server->secMode & (SECMODE_SIGN_REQUIRED |
-                                       SECMODE_SIGN_ENABLED))) {
-                               rc = cifs_verify_signature(out_buf,
-                                               &ses->server->mac_signing_key,
-                                               midQ->sequence_number+1);
-                               if (rc) {
-                                       cERROR(1, ("Unexpected SMB signature"));
-                                       /* BB FIXME add code to kill session */
-                               }
-                       }
+               goto out;
+       }
 
-                       *pbytes_returned = out_buf->smb_buf_length;
+       /* rcvd frame is ok */
 
-                       /* BB special case reconnect tid and uid here? */
-                       rc = map_smb_to_linux_error(out_buf, 0 /* no log */ );
+       if ((out_buf == NULL) || (midQ->midState != MID_RESPONSE_RECEIVED)) {
+               rc = -EIO;
+               cERROR(1, ("Bad MID state?"));
+               goto out;
+       }
 
-                       /* convert ByteCount if necessary */
-                       if (receive_len >= sizeof(struct smb_hdr) - 4
-                           /* do not count RFC1001 header */  +
-                           (2 * out_buf->WordCount) + 2 /* bcc */ )
-                               BCC(out_buf) = le16_to_cpu(BCC_LE(out_buf));
-               } else {
-                       rc = -EIO;
-                       cERROR(1, ("Bad MID state?"));
+       out_buf->smb_buf_length = receive_len;
+       memcpy((char *)out_buf + 4,
+              (char *)midQ->resp_buf + 4,
+              receive_len);
+
+       dump_smb(out_buf, 92);
+       /* convert the length into a more usable form */
+       if ((receive_len > 24) &&
+           (ses->server->secMode & (SECMODE_SIGN_REQUIRED |
+                                    SECMODE_SIGN_ENABLED))) {
+               rc = cifs_verify_signature(out_buf,
+                                          &ses->server->mac_signing_key,
+                                          midQ->sequence_number+1);
+               if (rc) {
+                       cERROR(1, ("Unexpected SMB signature"));
+                       /* BB FIXME add code to kill session */
                }
        }
+
+       *pbytes_returned = out_buf->smb_buf_length;
+
+       /* BB special case reconnect tid and uid here? */
+       rc = map_smb_to_linux_error(out_buf, 0 /* no log */ );
+
+       /* convert ByteCount if necessary */
+       if (receive_len >= sizeof(struct smb_hdr) - 4
+           /* do not count RFC1001 header */  +
+           (2 * out_buf->WordCount) + 2 /* bcc */ )
+               BCC(out_buf) = le16_to_cpu(BCC_LE(out_buf));
+
+out:
        DeleteMidQEntry(midQ);
        if (rstart && rc == -EACCES)
                return -ERESTARTSYS;