ceph: handle kmalloc() failure
[safe/jmp/linux-2.6] / fs / ceph / messenger.c
index b48abc0..a32f0f8 100644 (file)
@@ -12,6 +12,8 @@
 
 #include "super.h"
 #include "messenger.h"
+#include "decode.h"
+#include "pagelist.h"
 
 /*
  * Ceph uses the messenger to exchange ceph_msg messages with other
@@ -97,6 +99,12 @@ const char *pr_addr(const struct sockaddr_storage *ss)
        return s;
 }
 
+static void encode_my_addr(struct ceph_messenger *msgr)
+{
+       memcpy(&msgr->my_enc_addr, &msgr->inst.addr, sizeof(msgr->my_enc_addr));
+       ceph_encode_addr(&msgr->my_enc_addr);
+}
+
 /*
  * work queue for all reading and writing to/from the socket.
  */
@@ -309,15 +317,21 @@ static void reset_connection(struct ceph_connection *con)
 {
        /* reset connection, out_queue, msg_ and connect_seq */
        /* discard existing out_queue and msg_seq */
-       mutex_lock(&con->out_mutex);
        ceph_msg_remove_list(&con->out_queue);
        ceph_msg_remove_list(&con->out_sent);
 
+       if (con->in_msg) {
+               ceph_msg_put(con->in_msg);
+               con->in_msg = NULL;
+       }
+
        con->connect_seq = 0;
        con->out_seq = 0;
-       con->out_msg = NULL;
+       if (con->out_msg) {
+               ceph_msg_put(con->out_msg);
+               con->out_msg = NULL;
+       }
        con->in_seq = 0;
-       mutex_unlock(&con->out_mutex);
 }
 
 /*
@@ -328,22 +342,17 @@ void ceph_con_close(struct ceph_connection *con)
        dout("con_close %p peer %s\n", con, pr_addr(&con->peer_addr.in_addr));
        set_bit(CLOSED, &con->state);  /* in case there's queued work */
        clear_bit(STANDBY, &con->state);  /* avoid connect_seq bump */
+       clear_bit(LOSSYTX, &con->state);  /* so we retry next connect */
+       clear_bit(KEEPALIVE_PENDING, &con->state);
+       clear_bit(WRITE_PENDING, &con->state);
+       mutex_lock(&con->mutex);
        reset_connection(con);
+       cancel_delayed_work(&con->work);
+       mutex_unlock(&con->mutex);
        queue_con(con);
 }
 
 /*
- * clean up connection state
- */
-void ceph_con_shutdown(struct ceph_connection *con)
-{
-       dout("con_shutdown %p\n", con);
-       reset_connection(con);
-       set_bit(DEAD, &con->state);
-       con_close_socket(con); /* silently ignore errors */
-}
-
-/*
  * Reopen a closed connection, with a new peer address.
  */
 void ceph_con_open(struct ceph_connection *con, struct ceph_entity_addr *addr)
@@ -352,10 +361,19 @@ void ceph_con_open(struct ceph_connection *con, struct ceph_entity_addr *addr)
        set_bit(OPENING, &con->state);
        clear_bit(CLOSED, &con->state);
        memcpy(&con->peer_addr, addr, sizeof(*addr));
+       con->delay = 0;      /* reset backoff memory */
        queue_con(con);
 }
 
 /*
+ * return true if this connection ever successfully opened
+ */
+bool ceph_con_opened(struct ceph_connection *con)
+{
+       return con->connect_seq > 0;
+}
+
+/*
  * generic get/put
  */
 struct ceph_connection *ceph_con_get(struct ceph_connection *con)
@@ -373,7 +391,7 @@ void ceph_con_put(struct ceph_connection *con)
             atomic_read(&con->nref), atomic_read(&con->nref) - 1);
        BUG_ON(atomic_read(&con->nref) == 0);
        if (atomic_dec_and_test(&con->nref)) {
-               ceph_con_shutdown(con);
+               BUG_ON(con->sock);
                kfree(con);
        }
 }
@@ -387,7 +405,7 @@ void ceph_con_init(struct ceph_messenger *msgr, struct ceph_connection *con)
        memset(con, 0, sizeof(*con));
        atomic_set(&con->nref, 1);
        con->msgr = msgr;
-       mutex_init(&con->out_mutex);
+       mutex_init(&con->mutex);
        INIT_LIST_HEAD(&con->out_queue);
        INIT_LIST_HEAD(&con->out_sent);
        INIT_DELAYED_WORK(&con->work, con_work);
@@ -426,7 +444,7 @@ static void prepare_write_message_footer(struct ceph_connection *con, int v)
        con->out_kvec_bytes += sizeof(m->footer);
        con->out_kvec_left++;
        con->out_more = m->more_to_follow;
-       con->out_msg = NULL;   /* we're done with this one */
+       con->out_msg_done = true;
 }
 
 /*
@@ -439,6 +457,7 @@ static void prepare_write_message(struct ceph_connection *con)
 
        con->out_kvec_bytes = 0;
        con->out_kvec_is_msg = true;
+       con->out_msg_done = false;
 
        /* Sneak an ack in there first?  If we can get it into the same
         * TCP packet that's a good thing. */
@@ -452,11 +471,16 @@ static void prepare_write_message(struct ceph_connection *con)
                con->out_kvec_bytes = 1 + sizeof(con->out_temp_ack);
        }
 
-       /* move message to sending/sent list */
        m = list_first_entry(&con->out_queue,
                       struct ceph_msg, list_head);
-       list_move_tail(&m->list_head, &con->out_sent);
-       con->out_msg = m;   /* we don't bother taking a reference here. */
+       con->out_msg = m;
+       if (test_bit(LOSSYTX, &con->state)) {
+               list_del_init(&m->list_head);
+       } else {
+               /* put message on sent list */
+               ceph_msg_get(m);
+               list_move_tail(&m->list_head, &con->out_sent);
+       }
 
        m->hdr.seq = cpu_to_le64(++con->out_seq);
 
@@ -554,13 +578,52 @@ static void prepare_write_keepalive(struct ceph_connection *con)
  * Connection negotiation.
  */
 
+static void prepare_connect_authorizer(struct ceph_connection *con)
+{
+       void *auth_buf;
+       int auth_len = 0;
+       int auth_protocol = 0;
+
+       mutex_unlock(&con->mutex);
+       if (con->ops->get_authorizer)
+               con->ops->get_authorizer(con, &auth_buf, &auth_len,
+                                        &auth_protocol, &con->auth_reply_buf,
+                                        &con->auth_reply_buf_len,
+                                        con->auth_retry);
+       mutex_lock(&con->mutex);
+
+       con->out_connect.authorizer_protocol = cpu_to_le32(auth_protocol);
+       con->out_connect.authorizer_len = cpu_to_le32(auth_len);
+
+       con->out_kvec[con->out_kvec_left].iov_base = auth_buf;
+       con->out_kvec[con->out_kvec_left].iov_len = auth_len;
+       con->out_kvec_left++;
+       con->out_kvec_bytes += auth_len;
+}
+
 /*
  * We connected to a peer and are saying hello.
  */
-static void prepare_write_connect(struct ceph_messenger *msgr,
-                                 struct ceph_connection *con)
+static void prepare_write_banner(struct ceph_messenger *msgr,
+                                struct ceph_connection *con)
 {
        int len = strlen(CEPH_BANNER);
+
+       con->out_kvec[0].iov_base = CEPH_BANNER;
+       con->out_kvec[0].iov_len = len;
+       con->out_kvec[1].iov_base = &msgr->my_enc_addr;
+       con->out_kvec[1].iov_len = sizeof(msgr->my_enc_addr);
+       con->out_kvec_left = 2;
+       con->out_kvec_bytes = len + sizeof(msgr->my_enc_addr);
+       con->out_kvec_cur = con->out_kvec;
+       con->out_more = 0;
+       set_bit(WRITE_PENDING, &con->state);
+}
+
+static void prepare_write_connect(struct ceph_messenger *msgr,
+                                 struct ceph_connection *con,
+                                 int after_banner)
+{
        unsigned global_seq = get_global_seq(con->msgr, 0);
        int proto;
 
@@ -580,43 +643,27 @@ static void prepare_write_connect(struct ceph_messenger *msgr,
 
        dout("prepare_write_connect %p cseq=%d gseq=%d proto=%d\n", con,
             con->connect_seq, global_seq, proto);
+
+       con->out_connect.features = CEPH_FEATURE_SUPPORTED;
        con->out_connect.host_type = cpu_to_le32(CEPH_ENTITY_TYPE_CLIENT);
        con->out_connect.connect_seq = cpu_to_le32(con->connect_seq);
        con->out_connect.global_seq = cpu_to_le32(global_seq);
        con->out_connect.protocol_version = cpu_to_le32(proto);
        con->out_connect.flags = 0;
-       if (test_bit(LOSSYTX, &con->state))
-               con->out_connect.flags = CEPH_MSG_CONNECT_LOSSY;
 
-       con->out_kvec[0].iov_base = CEPH_BANNER;
-       con->out_kvec[0].iov_len = len;
-       con->out_kvec[1].iov_base = &msgr->inst.addr;
-       con->out_kvec[1].iov_len = sizeof(msgr->inst.addr);
-       con->out_kvec[2].iov_base = &con->out_connect;
-       con->out_kvec[2].iov_len = sizeof(con->out_connect);
-       con->out_kvec_left = 3;
-       con->out_kvec_bytes = len + sizeof(msgr->inst.addr) +
-               sizeof(con->out_connect);
+       if (!after_banner) {
+               con->out_kvec_left = 0;
+               con->out_kvec_bytes = 0;
+       }
+       con->out_kvec[con->out_kvec_left].iov_base = &con->out_connect;
+       con->out_kvec[con->out_kvec_left].iov_len = sizeof(con->out_connect);
+       con->out_kvec_left++;
+       con->out_kvec_bytes += sizeof(con->out_connect);
        con->out_kvec_cur = con->out_kvec;
        con->out_more = 0;
        set_bit(WRITE_PENDING, &con->state);
-}
 
-static void prepare_write_connect_retry(struct ceph_messenger *msgr,
-                                       struct ceph_connection *con)
-{
-       dout("prepare_write_connect_retry %p\n", con);
-       con->out_connect.connect_seq = cpu_to_le32(con->connect_seq);
-       con->out_connect.global_seq =
-               cpu_to_le32(get_global_seq(con->msgr, 0));
-
-       con->out_kvec[0].iov_base = &con->out_connect;
-       con->out_kvec[0].iov_len = sizeof(con->out_connect);
-       con->out_kvec_left = 1;
-       con->out_kvec_bytes = sizeof(con->out_connect);
-       con->out_kvec_cur = con->out_kvec;
-       con->out_more = 0;
-       set_bit(WRITE_PENDING, &con->state);
+       prepare_connect_authorizer(con);
 }
 
 
@@ -694,6 +741,11 @@ static int write_partial_msg_pages(struct ceph_connection *con)
                        page = msg->pages[con->out_msg_pos.page];
                        if (crc)
                                kaddr = kmap(page);
+               } else if (msg->pagelist) {
+                       page = list_first_entry(&msg->pagelist->head,
+                                               struct page, lru);
+                       if (crc)
+                               kaddr = kmap(page);
                } else {
                        page = con->msgr->zero_page;
                        if (crc)
@@ -716,7 +768,7 @@ static int write_partial_msg_pages(struct ceph_connection *con)
                                      MSG_DONTWAIT | MSG_NOSIGNAL |
                                      MSG_MORE);
 
-               if (crc && msg->pages)
+               if (crc && (msg->pages || msg->pagelist))
                        kunmap(page);
 
                if (ret <= 0)
@@ -728,6 +780,9 @@ static int write_partial_msg_pages(struct ceph_connection *con)
                        con->out_msg_pos.page_pos = 0;
                        con->out_msg_pos.page++;
                        con->out_msg_pos.did_page_crc = 0;
+                       if (msg->pagelist)
+                               list_move_tail(&page->lru,
+                                              &msg->pagelist->head);
                }
        }
 
@@ -771,6 +826,12 @@ out:
 /*
  * Prepare to read connection handshake, or an ack.
  */
+static void prepare_read_banner(struct ceph_connection *con)
+{
+       dout("prepare_read_banner %p\n", con);
+       con->in_base_pos = 0;
+}
+
 static void prepare_read_connect(struct ceph_connection *con)
 {
        dout("prepare_read_connect %p\n", con);
@@ -822,11 +883,11 @@ static int read_partial(struct ceph_connection *con,
 /*
  * Read all or part of the connect-side handshake on a new connection
  */
-static int read_partial_connect(struct ceph_connection *con)
+static int read_partial_banner(struct ceph_connection *con)
 {
        int ret, to = 0;
 
-       dout("read_partial_connect %p at %d\n", con, con->in_base_pos);
+       dout("read_partial_banner %p at %d\n", con, con->in_base_pos);
 
        /* peer's banner */
        ret = read_partial(con, &to, strlen(CEPH_BANNER), con->in_banner);
@@ -840,15 +901,31 @@ static int read_partial_connect(struct ceph_connection *con)
                           &con->peer_addr_for_me);
        if (ret <= 0)
                goto out;
+out:
+       return ret;
+}
+
+static int read_partial_connect(struct ceph_connection *con)
+{
+       int ret, to = 0;
+
+       dout("read_partial_connect %p at %d\n", con, con->in_base_pos);
+
        ret = read_partial(con, &to, sizeof(con->in_reply), &con->in_reply);
        if (ret <= 0)
                goto out;
+       ret = read_partial(con, &to, le32_to_cpu(con->in_reply.authorizer_len),
+                          con->auth_reply_buf);
+       if (ret <= 0)
+               goto out;
 
-       dout("read_partial_connect %p connect_seq = %u, global_seq = %u\n",
-            con, le32_to_cpu(con->in_reply.connect_seq),
+       dout("read_partial_connect %p tag %d, con_seq = %u, g_seq = %u\n",
+            con, (int)con->in_reply.tag,
+            le32_to_cpu(con->in_reply.connect_seq),
             le32_to_cpu(con->in_reply.global_seq));
 out:
        return ret;
+
 }
 
 /*
@@ -884,9 +961,9 @@ static int addr_port(struct sockaddr_storage *ss)
 {
        switch (ss->ss_family) {
        case AF_INET:
-               return ((struct sockaddr_in *)ss)->sin_port;
+               return ntohs(((struct sockaddr_in *)ss)->sin_port);
        case AF_INET6:
-               return ((struct sockaddr_in6 *)ss)->sin6_port;
+               return ntohs(((struct sockaddr_in6 *)ss)->sin6_port);
        }
        return 0;
 }
@@ -969,29 +1046,31 @@ bad:
        return -EINVAL;
 }
 
-static int process_connect(struct ceph_connection *con)
+static int process_banner(struct ceph_connection *con)
 {
-       dout("process_connect on %p tag %d\n", con, (int)con->in_tag);
+       dout("process_banner on %p\n", con);
 
        if (verify_hello(con) < 0)
                return -1;
 
+       ceph_decode_addr(&con->actual_peer_addr);
+       ceph_decode_addr(&con->peer_addr_for_me);
+
        /*
         * Make sure the other end is who we wanted.  note that the other
         * end may not yet know their ip address, so if it's 0.0.0.0, give
         * them the benefit of the doubt.
         */
-       if (!ceph_entity_addr_is_local(&con->peer_addr,
-                                      &con->actual_peer_addr) &&
+       if (memcmp(&con->peer_addr, &con->actual_peer_addr,
+                  sizeof(con->peer_addr)) != 0 &&
            !(addr_is_blank(&con->actual_peer_addr.in_addr) &&
              con->actual_peer_addr.nonce == con->peer_addr.nonce)) {
-               pr_err("wrong peer, want %s/%d, "
-                      "got %s/%d, wtf\n",
-                      pr_addr(&con->peer_addr.in_addr),
-                      con->peer_addr.nonce,
-                      pr_addr(&con->actual_peer_addr.in_addr),
-                      con->actual_peer_addr.nonce);
-               con->error_msg = "protocol error, wrong peer";
+               pr_warning("wrong peer, want %s/%lld, got %s/%lld\n",
+                          pr_addr(&con->peer_addr.in_addr),
+                          le64_to_cpu(con->peer_addr.nonce),
+                          pr_addr(&con->actual_peer_addr.in_addr),
+                          le64_to_cpu(con->actual_peer_addr.nonce));
+               con->error_msg = "wrong peer at address";
                return -1;
        }
 
@@ -1005,15 +1084,47 @@ static int process_connect(struct ceph_connection *con)
                       &con->peer_addr_for_me.in_addr,
                       sizeof(con->peer_addr_for_me.in_addr));
                addr_set_port(&con->msgr->inst.addr.in_addr, port);
-               dout("process_connect learned my addr is %s\n",
+               encode_my_addr(con->msgr);
+               dout("process_banner learned my addr is %s\n",
                     pr_addr(&con->msgr->inst.addr.in_addr));
        }
 
+       set_bit(NEGOTIATING, &con->state);
+       prepare_read_connect(con);
+       return 0;
+}
+
+static void fail_protocol(struct ceph_connection *con)
+{
+       reset_connection(con);
+       set_bit(CLOSED, &con->state);  /* in case there's queued work */
+
+       mutex_unlock(&con->mutex);
+       if (con->ops->bad_proto)
+               con->ops->bad_proto(con);
+       mutex_lock(&con->mutex);
+}
+
+static int process_connect(struct ceph_connection *con)
+{
+       u64 sup_feat = CEPH_FEATURE_SUPPORTED;
+       u64 req_feat = CEPH_FEATURE_REQUIRED;
+       u64 server_feat = le64_to_cpu(con->in_reply.features);
+
+       dout("process_connect on %p tag %d\n", con, (int)con->in_tag);
+
        switch (con->in_reply.tag) {
+       case CEPH_MSGR_TAG_FEATURES:
+               pr_err("%s%lld %s feature set mismatch,"
+                      " my %llx < server's %llx, missing %llx\n",
+                      ENTITY_NAME(con->peer_name),
+                      pr_addr(&con->peer_addr.in_addr),
+                      sup_feat, server_feat, server_feat & ~sup_feat);
+               con->error_msg = "missing required protocol features";
+               fail_protocol(con);
+               return -1;
+
        case CEPH_MSGR_TAG_BADPROTOVER:
-               dout("process_connect got BADPROTOVER my %d != their %d\n",
-                    le32_to_cpu(con->out_connect.protocol_version),
-                    le32_to_cpu(con->in_reply.protocol_version));
                pr_err("%s%lld %s protocol version mismatch,"
                       " my %d != server's %d\n",
                       ENTITY_NAME(con->peer_name),
@@ -1021,12 +1132,23 @@ static int process_connect(struct ceph_connection *con)
                       le32_to_cpu(con->out_connect.protocol_version),
                       le32_to_cpu(con->in_reply.protocol_version));
                con->error_msg = "protocol version mismatch";
-               if (con->ops->bad_proto)
-                       con->ops->bad_proto(con);
-               reset_connection(con);
-               set_bit(CLOSED, &con->state);  /* in case there's queued work */
+               fail_protocol(con);
                return -1;
 
+       case CEPH_MSGR_TAG_BADAUTHORIZER:
+               con->auth_retry++;
+               dout("process_connect %p got BADAUTHORIZER attempt %d\n", con,
+                    con->auth_retry);
+               if (con->auth_retry == 2) {
+                       con->error_msg = "connect authorization failure";
+                       reset_connection(con);
+                       set_bit(CLOSED, &con->state);
+                       return -1;
+               }
+               con->auth_retry = 1;
+               prepare_write_connect(con->msgr, con, 0);
+               prepare_read_connect(con);
+               break;
 
        case CEPH_MSGR_TAG_RESETSESSION:
                /*
@@ -1042,13 +1164,15 @@ static int process_connect(struct ceph_connection *con)
                       ENTITY_NAME(con->peer_name),
                       pr_addr(&con->peer_addr.in_addr));
                reset_connection(con);
-               prepare_write_connect_retry(con->msgr, con);
+               prepare_write_connect(con->msgr, con, 0);
                prepare_read_connect(con);
 
                /* Tell ceph about it. */
+               mutex_unlock(&con->mutex);
                pr_info("reset on %s%lld\n", ENTITY_NAME(con->peer_name));
                if (con->ops->peer_reset)
                        con->ops->peer_reset(con);
+               mutex_lock(&con->mutex);
                break;
 
        case CEPH_MSGR_TAG_RETRY_SESSION:
@@ -1060,7 +1184,7 @@ static int process_connect(struct ceph_connection *con)
                     le32_to_cpu(con->out_connect.connect_seq),
                     le32_to_cpu(con->in_connect.connect_seq));
                con->connect_seq = le32_to_cpu(con->in_connect.connect_seq);
-               prepare_write_connect_retry(con->msgr, con);
+               prepare_write_connect(con->msgr, con, 0);
                prepare_read_connect(con);
                break;
 
@@ -1069,19 +1193,27 @@ static int process_connect(struct ceph_connection *con)
                 * If we sent a smaller global_seq than the peer has, try
                 * again with a larger value.
                 */
-               dout("process_connect got RETRY_GLOBAL my %u, peer_gseq = %u\n",
+               dout("process_connect got RETRY_GLOBAL my %u peer_gseq %u\n",
                     con->peer_global_seq,
                     le32_to_cpu(con->in_connect.global_seq));
                get_global_seq(con->msgr,
                               le32_to_cpu(con->in_connect.global_seq));
-               prepare_write_connect_retry(con->msgr, con);
+               prepare_write_connect(con->msgr, con, 0);
                prepare_read_connect(con);
                break;
 
        case CEPH_MSGR_TAG_READY:
+               if (req_feat & ~server_feat) {
+                       pr_err("%s%lld %s protocol feature mismatch,"
+                              " my required %llx > server's %llx, need %llx\n",
+                              ENTITY_NAME(con->peer_name),
+                              pr_addr(&con->peer_addr.in_addr),
+                              req_feat, server_feat, req_feat & ~server_feat);
+                       con->error_msg = "missing required protocol features";
+                       fail_protocol(con);
+                       return -1;
+               }
                clear_bit(CONNECTING, &con->state);
-               if (con->in_reply.flags & CEPH_MSG_CONNECT_LOSSY)
-                       set_bit(LOSSYRX, &con->state);
                con->peer_global_seq = le32_to_cpu(con->in_reply.global_seq);
                con->connect_seq++;
                dout("process_connect got READY gseq %d cseq %d (%d)\n",
@@ -1091,7 +1223,9 @@ static int process_connect(struct ceph_connection *con)
                WARN_ON(con->connect_seq !=
                        le32_to_cpu(con->in_reply.connect_seq));
 
-               con->delay = 0;  /* reset backoff memory */
+               if (con->in_reply.flags & CEPH_MSG_CONNECT_LOSSY)
+                       set_bit(LOSSYTX, &con->state);
+
                prepare_read_tag(con);
                break;
 
@@ -1134,7 +1268,6 @@ static void process_ack(struct ceph_connection *con)
        u64 ack = le64_to_cpu(con->in_temp_ack);
        u64 seq;
 
-       mutex_lock(&con->out_mutex);
        while (!list_empty(&con->out_sent)) {
                m = list_first_entry(&con->out_sent, struct ceph_msg,
                                     list_head);
@@ -1145,15 +1278,40 @@ static void process_ack(struct ceph_connection *con)
                     le16_to_cpu(m->hdr.type), m);
                ceph_msg_remove(m);
        }
-       mutex_unlock(&con->out_mutex);
        prepare_read_tag(con);
 }
 
 
 
 
+static int read_partial_message_section(struct ceph_connection *con,
+                                       struct kvec *section, unsigned int sec_len,
+                                       u32 *crc)
+{
+       int left;
+       int ret;
+
+       BUG_ON(!section);
 
+       while (section->iov_len < sec_len) {
+               BUG_ON(section->iov_base == NULL);
+               left = sec_len - section->iov_len;
+               ret = ceph_tcp_recvmsg(con->sock, (char *)section->iov_base +
+                                      section->iov_len, left);
+               if (ret <= 0)
+                       return ret;
+               section->iov_len += ret;
+               if (section->iov_len == sec_len)
+                       *crc = crc32c(0, section->iov_base,
+                                     section->iov_len);
+       }
 
+       return 1;
+}
+
+static struct ceph_msg *ceph_alloc_msg(struct ceph_connection *con,
+                               struct ceph_msg_header *hdr,
+                               int *skip);
 /*
  * read (part of) a message.
  */
@@ -1162,9 +1320,10 @@ static int read_partial_message(struct ceph_connection *con)
        struct ceph_msg *m = con->in_msg;
        void *p;
        int ret;
-       int to, want, left;
+       int to, left;
        unsigned front_len, middle_len, data_len, data_off;
        int datacrc = con->msgr->nocrc;
+       int skip;
 
        dout("read_partial_message con %p msg %p\n", con, m);
 
@@ -1188,7 +1347,6 @@ static int read_partial_message(struct ceph_connection *con)
                        }
                }
        }
-
        front_len = le32_to_cpu(con->in_hdr.front_len);
        if (front_len > CEPH_MSG_MAX_FRONT_LEN)
                return -EIO;
@@ -1198,13 +1356,14 @@ static int read_partial_message(struct ceph_connection *con)
        data_len = le32_to_cpu(con->in_hdr.data_len);
        if (data_len > CEPH_MSG_MAX_DATA_LEN)
                return -EIO;
+       data_off = le16_to_cpu(con->in_hdr.data_off);
 
        /* allocate message? */
        if (!con->in_msg) {
                dout("got hdr type %d front %d data %d\n", con->in_hdr.type,
                     con->in_hdr.front_len, con->in_hdr.data_len);
-               con->in_msg = con->ops->alloc_msg(con, &con->in_hdr);
-               if (!con->in_msg) {
+               con->in_msg = ceph_alloc_msg(con, &con->in_hdr, &skip);
+               if (skip) {
                        /* skip this message */
                        dout("alloc_msg returned NULL, skipping message\n");
                        con->in_base_pos = -front_len - middle_len - data_len -
@@ -1215,82 +1374,35 @@ static int read_partial_message(struct ceph_connection *con)
                if (IS_ERR(con->in_msg)) {
                        ret = PTR_ERR(con->in_msg);
                        con->in_msg = NULL;
-                       con->error_msg = "out of memory for incoming message";
+                       con->error_msg =
+                               "error allocating memory for incoming message";
                        return ret;
                }
                m = con->in_msg;
                m->front.iov_len = 0;    /* haven't read it yet */
-               memcpy(&m->hdr, &con->in_hdr, sizeof(con->in_hdr));
+               if (m->middle)
+                       m->middle->vec.iov_len = 0;
+
+               con->in_msg_pos.page = 0;
+               con->in_msg_pos.page_pos = data_off & ~PAGE_MASK;
+               con->in_msg_pos.data_pos = 0;
        }
 
        /* front */
-       while (m->front.iov_len < front_len) {
-               BUG_ON(m->front.iov_base == NULL);
-               left = front_len - m->front.iov_len;
-               ret = ceph_tcp_recvmsg(con->sock, (char *)m->front.iov_base +
-                                      m->front.iov_len, left);
-               if (ret <= 0)
-                       return ret;
-               m->front.iov_len += ret;
-               if (m->front.iov_len == front_len)
-                       con->in_front_crc = crc32c(0, m->front.iov_base,
-                                                     m->front.iov_len);
-       }
+       ret = read_partial_message_section(con, &m->front, front_len,
+                                          &con->in_front_crc);
+       if (ret <= 0)
+               return ret;
 
        /* middle */
-       while (middle_len > 0 && (!m->middle ||
-                                 m->middle->vec.iov_len < middle_len)) {
-               if (m->middle == NULL) {
-                       ret = -EOPNOTSUPP;
-                       if (con->ops->alloc_middle)
-                               ret = con->ops->alloc_middle(con, m);
-                       if (ret < 0) {
-                               dout("alloc_middle failed, skipping payload\n");
-                               con->in_base_pos = -middle_len - data_len
-                                       - sizeof(m->footer);
-                               ceph_msg_put(con->in_msg);
-                               con->in_msg = NULL;
-                               con->in_tag = CEPH_MSGR_TAG_READY;
-                               return 0;
-                       }
-                       m->middle->vec.iov_len = 0;
-               }
-               left = middle_len - m->middle->vec.iov_len;
-               ret = ceph_tcp_recvmsg(con->sock,
-                                      (char *)m->middle->vec.iov_base +
-                                      m->middle->vec.iov_len, left);
+       if (m->middle) {
+               ret = read_partial_message_section(con, &m->middle->vec, middle_len,
+                                                  &con->in_middle_crc);
                if (ret <= 0)
                        return ret;
-               m->middle->vec.iov_len += ret;
-               if (m->middle->vec.iov_len == middle_len)
-                       con->in_middle_crc = crc32c(0, m->middle->vec.iov_base,
-                                                     m->middle->vec.iov_len);
        }
 
        /* (page) data */
-       data_off = le16_to_cpu(m->hdr.data_off);
-       if (data_len == 0)
-               goto no_data;
-
-       if (m->nr_pages == 0) {
-               con->in_msg_pos.page = 0;
-               con->in_msg_pos.page_pos = data_off & ~PAGE_MASK;
-               con->in_msg_pos.data_pos = 0;
-               /* find pages for data payload */
-               want = calc_pages_for(data_off & ~PAGE_MASK, data_len);
-               ret = -1;
-               if (con->ops->prepare_pages)
-                       ret = con->ops->prepare_pages(con, m, want);
-               if (ret < 0) {
-                       dout("%p prepare_pages failed, skipping payload\n", m);
-                       con->in_base_pos = -data_len - sizeof(m->footer);
-                       ceph_msg_put(con->in_msg);
-                       con->in_msg = NULL;
-                       con->in_tag = CEPH_MSGR_TAG_READY;
-                       return 0;
-               }
-               BUG_ON(m->nr_pages < want);
-       }
        while (con->in_msg_pos.data_pos < data_len) {
                left = min((int)(data_len - con->in_msg_pos.data_pos),
                           (int)(PAGE_SIZE - con->in_msg_pos.page_pos));
@@ -1313,7 +1425,6 @@ static int read_partial_message(struct ceph_connection *con)
                }
        }
 
-no_data:
        /* footer */
        to = sizeof(m->hdr) + sizeof(m->footer);
        while (con->in_base_pos < to) {
@@ -1358,17 +1469,17 @@ no_data:
  */
 static void process_message(struct ceph_connection *con)
 {
-       struct ceph_msg *msg = con->in_msg;
+       struct ceph_msg *msg;
 
+       msg = con->in_msg;
        con->in_msg = NULL;
 
        /* if first message, set peer_name */
        if (con->peer_name.type == 0)
                con->peer_name = msg->hdr.src.name;
 
-       mutex_lock(&con->out_mutex);
        con->in_seq++;
-       mutex_unlock(&con->out_mutex);
+       mutex_unlock(&con->mutex);
 
        dout("===== %p %llu from %s%lld %d=%s len %d+%d (%u %u %u) =====\n",
             msg, le64_to_cpu(msg->hdr.seq),
@@ -1379,6 +1490,8 @@ static void process_message(struct ceph_connection *con)
             le32_to_cpu(msg->hdr.data_len),
             con->in_front_crc, con->in_middle_crc, con->in_data_crc);
        con->ops->dispatch(con, msg);
+
+       mutex_lock(&con->mutex);
        prepare_read_tag(con);
 }
 
@@ -1395,7 +1508,7 @@ static int try_write(struct ceph_connection *con)
        dout("try_write start %p state %lu nref %d\n", con, con->state,
             atomic_read(&con->nref));
 
-       mutex_lock(&con->out_mutex);
+       mutex_lock(&con->mutex);
 more:
        dout("try_write out_kvec_bytes %d\n", con->out_kvec_bytes);
 
@@ -1409,10 +1522,13 @@ more:
                if (test_and_clear_bit(STANDBY, &con->state))
                        con->connect_seq++;
 
-               prepare_write_connect(msgr, con);
-               prepare_read_connect(con);
+               prepare_write_banner(msgr, con);
+               prepare_write_connect(msgr, con, 1);
+               prepare_read_banner(con);
                set_bit(CONNECTING, &con->state);
+               clear_bit(NEGOTIATING, &con->state);
 
+               BUG_ON(con->in_msg);
                con->in_tag = CEPH_MSGR_TAG_READY;
                dout("try_write initiating connect on %p new state %lu\n",
                     con, con->state);
@@ -1440,14 +1556,16 @@ more_kvec:
                ret = write_partial_kvec(con);
                if (ret <= 0)
                        goto done;
-               if (ret < 0) {
-                       dout("try_write write_partial_kvec err %d\n", ret);
-                       goto done;
-               }
        }
 
        /* msg pages? */
        if (con->out_msg) {
+               if (con->out_msg_done) {
+                       ceph_msg_put(con->out_msg);
+                       con->out_msg = NULL;   /* we're done with this one */
+                       goto do_next;
+               }
+
                ret = write_partial_msg_pages(con);
                if (ret == 1)
                        goto more_kvec;  /* we need to send the footer, too! */
@@ -1460,6 +1578,7 @@ more_kvec:
                }
        }
 
+do_next:
        if (!test_bit(CONNECTING, &con->state)) {
                /* is anything else pending? */
                if (!list_empty(&con->out_queue)) {
@@ -1482,7 +1601,7 @@ more_kvec:
 done:
        ret = 0;
 out:
-       mutex_unlock(&con->out_mutex);
+       mutex_unlock(&con->mutex);
        dout("try_write done on %p\n", con);
        return ret;
 }
@@ -1506,11 +1625,22 @@ static int try_read(struct ceph_connection *con)
        dout("try_read start on %p\n", con);
        msgr = con->msgr;
 
+       mutex_lock(&con->mutex);
+
 more:
        dout("try_read tag %d in_base_pos %d\n", (int)con->in_tag,
             con->in_base_pos);
        if (test_bit(CONNECTING, &con->state)) {
-               dout("try_read connecting\n");
+               if (!test_bit(NEGOTIATING, &con->state)) {
+                       dout("try_read connecting\n");
+                       ret = read_partial_banner(con);
+                       if (ret <= 0)
+                               goto done;
+                       if (process_banner(con) < 0) {
+                               ret = -1;
+                               goto out;
+                       }
+               }
                ret = read_partial_connect(con);
                if (ret <= 0)
                        goto done;
@@ -1590,6 +1720,7 @@ more:
 done:
        ret = 0;
 out:
+       mutex_unlock(&con->mutex);
        dout("try_read done on %p\n", con);
        return ret;
 
@@ -1683,7 +1814,7 @@ done:
        clear_bit(BUSY, &con->state);
        dout("con->state=%lu\n", con->state);
        if (test_bit(QUEUED, &con->state)) {
-               if (!backoff) {
+               if (!backoff || test_bit(OPENING, &con->state)) {
                        dout("con_work %p QUEUED reset, looping\n", con);
                        goto more;
                }
@@ -1713,39 +1844,50 @@ static void ceph_fault(struct ceph_connection *con)
                goto out;
        }
 
-       clear_bit(BUSY, &con->state);  /* to avoid an improbable race */
+       mutex_lock(&con->mutex);
+       if (test_bit(CLOSED, &con->state))
+               goto out_unlock;
 
        con_close_socket(con);
-       con->in_msg = NULL;
+
+       if (con->in_msg) {
+               ceph_msg_put(con->in_msg);
+               con->in_msg = NULL;
+       }
+
+       /* Requeue anything that hasn't been acked */
+       list_splice_init(&con->out_sent, &con->out_queue);
 
        /* If there are no messages in the queue, place the connection
         * in a STANDBY state (i.e., don't try to reconnect just yet). */
-       mutex_lock(&con->out_mutex);
        if (list_empty(&con->out_queue) && !con->out_keepalive_pending) {
                dout("fault setting STANDBY\n");
                set_bit(STANDBY, &con->state);
-               mutex_unlock(&con->out_mutex);
-               goto out;
+       } else {
+               /* retry after a delay. */
+               if (con->delay == 0)
+                       con->delay = BASE_DELAY_INTERVAL;
+               else if (con->delay < MAX_DELAY_INTERVAL)
+                       con->delay *= 2;
+               dout("fault queueing %p delay %lu\n", con, con->delay);
+               con->ops->get(con);
+               if (queue_delayed_work(ceph_msgr_wq, &con->work,
+                                      round_jiffies_relative(con->delay)) == 0)
+                       con->ops->put(con);
        }
 
-       /* Requeue anything that hasn't been acked, and retry after a
-        * delay. */
-       list_splice_init(&con->out_sent, &con->out_queue);
-       mutex_unlock(&con->out_mutex);
-
-       if (con->delay == 0)
-               con->delay = BASE_DELAY_INTERVAL;
-       else if (con->delay < MAX_DELAY_INTERVAL)
-               con->delay *= 2;
-
-       /* explicitly schedule work to try to reconnect again later. */
-       dout("fault queueing %p delay %lu\n", con, con->delay);
-       con->ops->get(con);
-       if (queue_delayed_work(ceph_msgr_wq, &con->work,
-                              round_jiffies_relative(con->delay)) == 0)
-               con->ops->put(con);
-
+out_unlock:
+       mutex_unlock(&con->mutex);
 out:
+       /*
+        * in case we faulted due to authentication, invalidate our
+        * current tickets so that we can get new ones.
+         */
+       if (con->auth_retry && con->ops->invalidate_authorizer) {
+               dout("calling invalidate_authorizer()\n");
+               con->ops->invalidate_authorizer(con);
+       }
+
        if (con->ops->fault)
                con->ops->fault(con);
 }
@@ -1778,8 +1920,9 @@ struct ceph_messenger *ceph_messenger_create(struct ceph_entity_addr *myaddr)
                msgr->inst.addr = *myaddr;
 
        /* select a random nonce */
-       get_random_bytes(&msgr->inst.addr.nonce,
-                        sizeof(msgr->inst.addr.nonce));
+       msgr->inst.addr.type = 0;
+       get_random_bytes(&msgr->inst.addr.nonce, sizeof(msgr->inst.addr.nonce));
+       encode_my_addr(msgr);
 
        dout("messenger_create %p\n", msgr);
        return msgr;
@@ -1806,12 +1949,14 @@ void ceph_con_send(struct ceph_connection *con, struct ceph_msg *msg)
        }
 
        /* set src+dst */
-       msg->hdr.src = con->msgr->inst;
-       msg->hdr.orig_src = con->msgr->inst;
-       msg->hdr.dst_erank = con->peer_addr.erank;
+       msg->hdr.src.name = con->msgr->inst.name;
+       msg->hdr.src.addr = con->msgr->my_enc_addr;
+       msg->hdr.orig_src = msg->hdr.src;
+
+       BUG_ON(msg->front.iov_len != le32_to_cpu(msg->hdr.front_len));
 
        /* queue */
-       mutex_lock(&con->out_mutex);
+       mutex_lock(&con->mutex);
        BUG_ON(!list_empty(&msg->list_head));
        list_add_tail(&msg->list_head, &con->out_queue);
        dout("----- %p to %s%lld %d=%s len %d+%d+%d -----\n", msg,
@@ -1820,7 +1965,7 @@ void ceph_con_send(struct ceph_connection *con, struct ceph_msg *msg)
             le32_to_cpu(msg->hdr.front_len),
             le32_to_cpu(msg->hdr.middle_len),
             le32_to_cpu(msg->hdr.data_len));
-       mutex_unlock(&con->out_mutex);
+       mutex_unlock(&con->mutex);
 
        /* if there wasn't anything waiting to send before, queue
         * new work */
@@ -1833,14 +1978,16 @@ void ceph_con_send(struct ceph_connection *con, struct ceph_msg *msg)
  */
 void ceph_con_revoke(struct ceph_connection *con, struct ceph_msg *msg)
 {
-       mutex_lock(&con->out_mutex);
+       mutex_lock(&con->mutex);
        if (!list_empty(&msg->list_head)) {
                dout("con_revoke %p msg %p\n", con, msg);
                list_del_init(&msg->list_head);
                ceph_msg_put(msg);
                msg->hdr.seq = 0;
-               if (con->out_msg == msg)
+               if (con->out_msg == msg) {
+                       ceph_msg_put(con->out_msg);
                        con->out_msg = NULL;
+               }
                if (con->out_kvec_is_msg) {
                        con->out_skip = con->out_kvec_bytes;
                        con->out_kvec_is_msg = false;
@@ -1848,7 +1995,36 @@ void ceph_con_revoke(struct ceph_connection *con, struct ceph_msg *msg)
        } else {
                dout("con_revoke %p msg %p - not queued (sent?)\n", con, msg);
        }
-       mutex_unlock(&con->out_mutex);
+       mutex_unlock(&con->mutex);
+}
+
+/*
+ * Revoke a message that we may be reading data into
+ */
+void ceph_con_revoke_message(struct ceph_connection *con, struct ceph_msg *msg)
+{
+       mutex_lock(&con->mutex);
+       if (con->in_msg && con->in_msg == msg) {
+               unsigned front_len = le32_to_cpu(con->in_hdr.front_len);
+               unsigned middle_len = le32_to_cpu(con->in_hdr.middle_len);
+               unsigned data_len = le32_to_cpu(con->in_hdr.data_len);
+
+               /* skip rest of message */
+               dout("con_revoke_pages %p msg %p revoked\n", con, msg);
+                       con->in_base_pos = con->in_base_pos -
+                               sizeof(struct ceph_msg_header) -
+                               front_len -
+                               middle_len -
+                               data_len -
+                               sizeof(struct ceph_msg_footer);
+               ceph_msg_put(con->in_msg);
+               con->in_msg = NULL;
+               con->in_tag = CEPH_MSGR_TAG_READY;
+       } else {
+               dout("con_revoke_pages %p msg %p pages %p no-op\n",
+                    con, con->in_msg, msg);
+       }
+       mutex_unlock(&con->mutex);
 }
 
 /*
@@ -1874,7 +2050,7 @@ struct ceph_msg *ceph_msg_new(int type, int front_len,
        m = kmalloc(sizeof(*m), GFP_NOFS);
        if (m == NULL)
                goto out;
-       atomic_set(&m->nref, 1);
+       kref_init(&m->kref);
        INIT_LIST_HEAD(&m->list_head);
 
        m->hdr.type = cpu_to_le16(type);
@@ -1916,6 +2092,7 @@ struct ceph_msg *ceph_msg_new(int type, int front_len,
        /* data */
        m->nr_pages = calc_pages_for(page_off, page_len);
        m->pages = pages;
+       m->pagelist = NULL;
 
        dout("ceph_msg_new %p page %d~%d -> %d\n", m, page_off, page_len,
             m->nr_pages);
@@ -1929,31 +2106,13 @@ out:
 }
 
 /*
- * Generic message allocator, for incoming messages.
- */
-struct ceph_msg *ceph_alloc_msg(struct ceph_connection *con,
-                               struct ceph_msg_header *hdr)
-{
-       int type = le16_to_cpu(hdr->type);
-       int front_len = le32_to_cpu(hdr->front_len);
-       struct ceph_msg *msg = ceph_msg_new(type, front_len, 0, 0, NULL);
-
-       if (!msg) {
-               pr_err("unable to allocate msg type %d len %d\n",
-                      type, front_len);
-               return ERR_PTR(-ENOMEM);
-       }
-       return msg;
-}
-
-/*
  * Allocate "middle" portion of a message, if it is needed and wasn't
  * allocated by alloc_msg.  This allows us to read a small fixed-size
  * per-type header in the front and then gracefully fail (i.e.,
  * propagate the error to the caller based on info in the front) when
  * the middle is too large.
  */
-int ceph_alloc_middle(struct ceph_connection *con, struct ceph_msg *msg)
+static int ceph_alloc_middle(struct ceph_connection *con, struct ceph_msg *msg)
 {
        int type = le16_to_cpu(msg->hdr.type);
        int middle_len = le32_to_cpu(msg->hdr.middle_len);
@@ -1963,12 +2122,58 @@ int ceph_alloc_middle(struct ceph_connection *con, struct ceph_msg *msg)
        BUG_ON(!middle_len);
        BUG_ON(msg->middle);
 
-       msg->middle = ceph_buffer_new_alloc(middle_len, GFP_NOFS);
+       msg->middle = ceph_buffer_new(middle_len, GFP_NOFS);
        if (!msg->middle)
                return -ENOMEM;
        return 0;
 }
 
+/*
+ * Generic message allocator, for incoming messages.
+ */
+static struct ceph_msg *ceph_alloc_msg(struct ceph_connection *con,
+                               struct ceph_msg_header *hdr,
+                               int *skip)
+{
+       int type = le16_to_cpu(hdr->type);
+       int front_len = le32_to_cpu(hdr->front_len);
+       int middle_len = le32_to_cpu(hdr->middle_len);
+       struct ceph_msg *msg = NULL;
+       int ret;
+
+       if (con->ops->alloc_msg) {
+               mutex_unlock(&con->mutex);
+               msg = con->ops->alloc_msg(con, hdr, skip);
+               mutex_lock(&con->mutex);
+               if (IS_ERR(msg))
+                       return msg;
+
+               if (*skip)
+                       return NULL;
+       }
+       if (!msg) {
+               *skip = 0;
+               msg = ceph_msg_new(type, front_len, 0, 0, NULL);
+               if (!msg) {
+                       pr_err("unable to allocate msg type %d len %d\n",
+                              type, front_len);
+                       return ERR_PTR(-ENOMEM);
+               }
+       }
+       memcpy(&msg->hdr, &con->in_hdr, sizeof(con->in_hdr));
+
+       if (middle_len) {
+               ret = ceph_alloc_middle(con, msg);
+
+               if (ret < 0) {
+                       ceph_msg_put(msg);
+                       return msg;
+               }
+       }
+
+       return msg;
+}
+
 
 /*
  * Free a generically kmalloc'd message.
@@ -1986,34 +2191,49 @@ void ceph_msg_kfree(struct ceph_msg *m)
 /*
  * Drop a msg ref.  Destroy as needed.
  */
-void ceph_msg_put(struct ceph_msg *m)
-{
-       dout("ceph_msg_put %p %d -> %d\n", m, atomic_read(&m->nref),
-            atomic_read(&m->nref)-1);
-       if (atomic_read(&m->nref) <= 0) {
-               pr_err("bad ceph_msg_put on %p %llu %d=%s %d+%d\n",
-                      m, le64_to_cpu(m->hdr.seq),
-                      le16_to_cpu(m->hdr.type),
-                      ceph_msg_type_name(le16_to_cpu(m->hdr.type)),
-                      le32_to_cpu(m->hdr.front_len),
-                      le32_to_cpu(m->hdr.data_len));
-               WARN_ON(1);
-       }
-       if (atomic_dec_and_test(&m->nref)) {
-               dout("ceph_msg_put last one on %p\n", m);
-               WARN_ON(!list_empty(&m->list_head));
-
-               /* drop middle, data, if any */
-               if (m->middle) {
-                       ceph_buffer_put(m->middle);
-                       m->middle = NULL;
-               }
-               m->nr_pages = 0;
-               m->pages = NULL;
+void ceph_msg_last_put(struct kref *kref)
+{
+       struct ceph_msg *m = container_of(kref, struct ceph_msg, kref);
+
+       dout("ceph_msg_put last one on %p\n", m);
+       WARN_ON(!list_empty(&m->list_head));
 
-               if (m->pool)
-                       ceph_msgpool_put(m->pool, m);
-               else
-                       ceph_msg_kfree(m);
+       /* drop middle, data, if any */
+       if (m->middle) {
+               ceph_buffer_put(m->middle);
+               m->middle = NULL;
        }
+       m->nr_pages = 0;
+       m->pages = NULL;
+
+       if (m->pagelist) {
+               ceph_pagelist_release(m->pagelist);
+               kfree(m->pagelist);
+               m->pagelist = NULL;
+       }
+
+       if (m->pool)
+               ceph_msgpool_put(m->pool, m);
+       else
+               ceph_msg_kfree(m);
+}
+
+void ceph_msg_dump(struct ceph_msg *msg)
+{
+       pr_debug("msg_dump %p (front_max %d nr_pages %d)\n", msg,
+                msg->front_max, msg->nr_pages);
+       print_hex_dump(KERN_DEBUG, "header: ",
+                      DUMP_PREFIX_OFFSET, 16, 1,
+                      &msg->hdr, sizeof(msg->hdr), true);
+       print_hex_dump(KERN_DEBUG, " front: ",
+                      DUMP_PREFIX_OFFSET, 16, 1,
+                      msg->front.iov_base, msg->front.iov_len, true);
+       if (msg->middle)
+               print_hex_dump(KERN_DEBUG, "middle: ",
+                              DUMP_PREFIX_OFFSET, 16, 1,
+                              msg->middle->vec.iov_base,
+                              msg->middle->vec.iov_len, true);
+       print_hex_dump(KERN_DEBUG, "footer: ",
+                      DUMP_PREFIX_OFFSET, 16, 1,
+                      &msg->footer, sizeof(msg->footer), true);
 }