cifs: refactor new_inode() calls and inode initialization
[safe/jmp/linux-2.6] / fs / btrfs / extent-tree.c
index fbd6a8f..293da65 100644 (file)
@@ -49,10 +49,10 @@ struct pending_extent_op {
        int del;
 };
 
-static int finish_current_insert(struct btrfs_trans_handle *trans, struct
-                                btrfs_root *extent_root, int all);
-static int del_pending_extents(struct btrfs_trans_handle *trans, struct
-                              btrfs_root *extent_root, int all);
+static int finish_current_insert(struct btrfs_trans_handle *trans,
+                                struct btrfs_root *extent_root, int all);
+static int del_pending_extents(struct btrfs_trans_handle *trans,
+                              struct btrfs_root *extent_root, int all);
 static int pin_down_bytes(struct btrfs_trans_handle *trans,
                          struct btrfs_root *root,
                          u64 bytenr, u64 num_bytes, int is_data);
@@ -247,7 +247,7 @@ static int cache_block_group(struct btrfs_root *root,
        if (ret < 0)
                goto err;
 
-       while(1) {
+       while (1) {
                leaf = path->nodes[0];
                slot = path->slots[0];
                if (slot >= btrfs_header_nritems(leaf)) {
@@ -292,9 +292,8 @@ err:
 /*
  * return the block group that starts at or after bytenr
  */
-static struct btrfs_block_group_cache *btrfs_lookup_first_block_group(struct
-                                                      btrfs_fs_info *info,
-                                                        u64 bytenr)
+static struct btrfs_block_group_cache *
+btrfs_lookup_first_block_group(struct btrfs_fs_info *info, u64 bytenr)
 {
        struct btrfs_block_group_cache *cache;
 
@@ -306,9 +305,9 @@ static struct btrfs_block_group_cache *btrfs_lookup_first_block_group(struct
 /*
  * return the block group that contains teh given bytenr
  */
-struct btrfs_block_group_cache *btrfs_lookup_block_group(struct
-                                                        btrfs_fs_info *info,
-                                                        u64 bytenr)
+struct btrfs_block_group_cache *btrfs_lookup_block_group(
+                                                struct btrfs_fs_info *info,
+                                                u64 bytenr)
 {
        struct btrfs_block_group_cache *cache;
 
@@ -492,7 +491,7 @@ int btrfs_lookup_extent(struct btrfs_root *root, u64 start, u64 len)
  * to the key objectid.
  */
 
-static int noinline lookup_extent_backref(struct btrfs_trans_handle *trans,
+static noinline int lookup_extent_backref(struct btrfs_trans_handle *trans,
                                          struct btrfs_root *root,
                                          struct btrfs_path *path,
                                          u64 bytenr, u64 parent,
@@ -537,7 +536,7 @@ out:
  * updates all the backrefs that are pending on update_list for the
  * extent_root
  */
-static int noinline update_backrefs(struct btrfs_trans_handle *trans,
+static noinline int update_backrefs(struct btrfs_trans_handle *trans,
                                    struct btrfs_root *extent_root,
                                    struct btrfs_path *path,
                                    struct list_head *update_list)
@@ -573,9 +572,11 @@ loop:
            btrfs_ref_generation(leaf, ref) != op->orig_generation ||
            (ref_objectid != op->level &&
             ref_objectid != BTRFS_MULTIPLE_OBJECTIDS)) {
-               printk(KERN_ERR "couldn't find %Lu, parent %Lu, root %Lu, "
-                      "owner %u\n", op->bytenr, op->orig_parent,
-                      ref_root, op->level);
+               printk(KERN_ERR "btrfs couldn't find %llu, parent %llu, "
+                      "root %llu, owner %u\n",
+                      (unsigned long long)op->bytenr,
+                      (unsigned long long)op->orig_parent,
+                      (unsigned long long)ref_root, op->level);
                btrfs_print_leaf(extent_root, leaf);
                BUG();
        }
@@ -620,7 +621,7 @@ out:
        return 0;
 }
 
-static int noinline insert_extents(struct btrfs_trans_handle *trans,
+static noinline int insert_extents(struct btrfs_trans_handle *trans,
                                   struct btrfs_root *extent_root,
                                   struct btrfs_path *path,
                                   struct list_head *insert_list, int nr)
@@ -781,7 +782,7 @@ static int noinline insert_extents(struct btrfs_trans_handle *trans,
        return ret;
 }
 
-static int noinline insert_extent_backref(struct btrfs_trans_handle *trans,
+static noinline int insert_extent_backref(struct btrfs_trans_handle *trans,
                                          struct btrfs_root *root,
                                          struct btrfs_path *path,
                                          u64 bytenr, u64 parent,
@@ -840,7 +841,7 @@ out:
        return ret;
 }
 
-static int noinline remove_extent_backref(struct btrfs_trans_handle *trans,
+static noinline int remove_extent_backref(struct btrfs_trans_handle *trans,
                                          struct btrfs_root *root,
                                          struct btrfs_path *path)
 {
@@ -868,15 +869,43 @@ static int noinline remove_extent_backref(struct btrfs_trans_handle *trans,
 static void btrfs_issue_discard(struct block_device *bdev,
                                u64 start, u64 len)
 {
-#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,28)
        blkdev_issue_discard(bdev, start >> 9, len >> 9, GFP_KERNEL);
+}
+#endif
+
+static int btrfs_discard_extent(struct btrfs_root *root, u64 bytenr,
+                               u64 num_bytes)
+{
+#ifdef BIO_RW_DISCARD
+       int ret;
+       u64 map_length = num_bytes;
+       struct btrfs_multi_bio *multi = NULL;
+
+       /* Tell the block device(s) that the sectors can be discarded */
+       ret = btrfs_map_block(&root->fs_info->mapping_tree, READ,
+                             bytenr, &map_length, &multi, 0);
+       if (!ret) {
+               struct btrfs_bio_stripe *stripe = multi->stripes;
+               int i;
+
+               if (map_length > num_bytes)
+                       map_length = num_bytes;
+
+               for (i = 0; i < multi->num_stripes; i++, stripe++) {
+                       btrfs_issue_discard(stripe->dev->bdev,
+                                           stripe->physical,
+                                           map_length);
+               }
+               kfree(multi);
+       }
+
+       return ret;
 #else
-       blkdev_issue_discard(bdev, start >> 9, len >> 9);
+       return 0;
 #endif
 }
-#endif
 
-static int noinline free_extents(struct btrfs_trans_handle *trans,
+static noinline int free_extents(struct btrfs_trans_handle *trans,
                                 struct btrfs_root *extent_root,
                                 struct list_head *del_list)
 {
@@ -905,10 +934,11 @@ search:
                                    extent_root->root_key.objectid,
                                    op->orig_generation, op->level, 1);
        if (ret) {
-               printk("Unable to find backref byte nr %Lu root %Lu gen %Lu "
-                      "owner %u\n", op->bytenr,
-                      extent_root->root_key.objectid, op->orig_generation,
-                      op->level);
+               printk(KERN_ERR "btrfs unable to find backref byte nr %llu "
+                      "root %llu gen %llu owner %u\n",
+                      (unsigned long long)op->bytenr,
+                      (unsigned long long)extent_root->root_key.objectid,
+                      (unsigned long long)op->orig_generation, op->level);
                btrfs_print_leaf(extent_root, path->nodes[0]);
                WARN_ON(1);
                goto out;
@@ -1051,11 +1081,11 @@ search:
                super_used = btrfs_super_bytes_used(&info->super_copy);
                btrfs_set_super_bytes_used(&info->super_copy,
                                           super_used - bytes_freed);
-               spin_unlock(&info->delalloc_lock);
 
                root_used = btrfs_root_used(&extent_root->root_item);
                btrfs_set_root_used(&extent_root->root_item,
                                    root_used - bytes_freed);
+               spin_unlock(&info->delalloc_lock);
 
                /* delete the items */
                ret = btrfs_del_items(trans, extent_root, path,
@@ -1069,10 +1099,6 @@ search:
                for (pos = cur, n = pos->next; pos != end;
                     pos = n, n = pos->next) {
                        struct pending_extent_op *tmp;
-#ifdef BIO_RW_DISCARD
-                       u64 map_length;
-                       struct btrfs_multi_bio *multi = NULL;
-#endif
                        tmp = list_entry(pos, struct pending_extent_op, list);
 
                        /*
@@ -1084,28 +1110,6 @@ search:
                                                 tmp->del);
                        BUG_ON(ret);
 
-#ifdef BIO_RW_DISCARD
-                       map_length = tmp->num_bytes;
-                       ret = btrfs_map_block(&info->mapping_tree, READ,
-                                             tmp->bytenr, &map_length, &multi,
-                                             0);
-                       if (!ret) {
-                               struct btrfs_bio_stripe *stripe;
-                               int i;
-
-                               stripe = multi->stripes;
-
-                               if (map_length > tmp->num_bytes)
-                                       map_length = tmp->num_bytes;
-
-                               for (i = 0; i < multi->num_stripes;
-                                    i++, stripe++)
-                                       btrfs_issue_discard(stripe->dev->bdev,
-                                                           stripe->physical,
-                                                           map_length);
-                               kfree(multi);
-                       }
-#endif
                        list_del_init(&tmp->list);
                        unlock_extent(&info->extent_ins, tmp->bytenr,
                                      tmp->bytenr + tmp->num_bytes - 1,
@@ -1276,7 +1280,9 @@ static int __btrfs_inc_extent_ref(struct btrfs_trans_handle *trans,
        btrfs_item_key_to_cpu(l, &key, path->slots[0]);
        if (key.objectid != bytenr) {
                btrfs_print_leaf(root->fs_info->extent_root, path->nodes[0]);
-               printk("wanted %Lu found %Lu\n", bytenr, key.objectid);
+               printk(KERN_ERR "btrfs wanted %llu found %llu\n",
+                      (unsigned long long)bytenr,
+                      (unsigned long long)key.objectid);
                BUG();
        }
        BUG_ON(key.type != BTRFS_EXTENT_ITEM_KEY);
@@ -1347,7 +1353,8 @@ int btrfs_lookup_extent_ref(struct btrfs_trans_handle *trans,
                goto out;
        if (ret != 0) {
                btrfs_print_leaf(root, path->nodes[0]);
-               printk("failed to find block number %Lu\n", bytenr);
+               printk(KERN_INFO "btrfs failed to find block number %llu\n",
+                      (unsigned long long)bytenr);
                BUG();
        }
        l = path->nodes[0];
@@ -1732,7 +1739,7 @@ int btrfs_write_dirty_block_groups(struct btrfs_trans_handle *trans,
        if (!path)
                return -ENOMEM;
 
-       while(1) {
+       while (1) {
                cache = NULL;
                spin_lock(&root->fs_info->block_group_cache_lock);
                for (n = rb_first(&root->fs_info->block_group_cache_tree);
@@ -1915,10 +1922,8 @@ static int do_chunk_alloc(struct btrfs_trans_handle *trans,
        spin_unlock(&space_info->lock);
 
        ret = btrfs_alloc_chunk(trans, extent_root, flags);
-       if (ret) {
-printk("space info full %Lu\n", flags);
+       if (ret)
                space_info->full = 1;
-       }
 out:
        mutex_unlock(&extent_root->fs_info->chunk_mutex);
        return ret;
@@ -1935,7 +1940,7 @@ static int update_block_group(struct btrfs_trans_handle *trans,
        u64 old_val;
        u64 byte_in_group;
 
-       while(total) {
+       while (total) {
                cache = btrfs_lookup_block_group(info, bytenr);
                if (!cache)
                        return -1;
@@ -1965,6 +1970,11 @@ static int update_block_group(struct btrfs_trans_handle *trans,
                        spin_unlock(&cache->space_info->lock);
                        if (mark_free) {
                                int ret;
+
+                               ret = btrfs_discard_extent(root, bytenr,
+                                                          num_bytes);
+                               WARN_ON(ret);
+
                                ret = btrfs_add_free_space(cache, bytenr,
                                                           num_bytes);
                                WARN_ON(ret);
@@ -2078,7 +2088,7 @@ int btrfs_copy_pinned(struct btrfs_root *root, struct extent_io_tree *copy)
        int ret;
 
        mutex_lock(&root->fs_info->pinned_mutex);
-       while(1) {
+       while (1) {
                ret = find_first_extent_bit(pinned_extents, last,
                                            &start, &end, EXTENT_DIRTY);
                if (ret)
@@ -2099,13 +2109,17 @@ int btrfs_finish_extent_commit(struct btrfs_trans_handle *trans,
        int ret;
 
        mutex_lock(&root->fs_info->pinned_mutex);
-       while(1) {
+       while (1) {
                ret = find_first_extent_bit(unpin, 0, &start, &end,
                                            EXTENT_DIRTY);
                if (ret)
                        break;
+
+               ret = btrfs_discard_extent(root, start, end + 1 - start);
+
                btrfs_update_pinned_extents(root, start, end + 1 - start, 0);
                clear_extent_dirty(unpin, start, end, GFP_NOFS);
+
                if (need_resched()) {
                        mutex_unlock(&root->fs_info->pinned_mutex);
                        cond_resched();
@@ -2113,7 +2127,7 @@ int btrfs_finish_extent_commit(struct btrfs_trans_handle *trans,
                }
        }
        mutex_unlock(&root->fs_info->pinned_mutex);
-       return 0;
+       return ret;
 }
 
 static int finish_current_insert(struct btrfs_trans_handle *trans,
@@ -2242,6 +2256,7 @@ again:
                                  extent_op->bytenr + extent_op->num_bytes - 1,
                                  EXTENT_WRITEBACK, GFP_NOFS);
                if (extent_op->del) {
+                       u64 used;
                        list_del_init(&extent_op->list);
                        unlock_extent(&info->extent_ins, extent_op->bytenr,
                                      extent_op->bytenr + extent_op->num_bytes
@@ -2253,6 +2268,15 @@ again:
                                             extent_op->num_bytes, 0);
                        mutex_unlock(&extent_root->fs_info->pinned_mutex);
 
+                       spin_lock(&info->delalloc_lock);
+                       used = btrfs_super_bytes_used(&info->super_copy);
+                       btrfs_set_super_bytes_used(&info->super_copy,
+                                       used - extent_op->num_bytes);
+                       used = btrfs_root_used(&extent_root->root_item);
+                       btrfs_set_root_used(&extent_root->root_item,
+                                       used - extent_op->num_bytes);
+                       spin_unlock(&info->delalloc_lock);
+
                        ret = update_block_group(trans, extent_root,
                                                 extent_op->bytenr,
                                                 extent_op->num_bytes,
@@ -2375,7 +2399,7 @@ static int __free_extent(struct btrfs_trans_handle *trans,
        if (ret == 0) {
                struct btrfs_key found_key;
                extent_slot = path->slots[0];
-               while(extent_slot > 0) {
+               while (extent_slot > 0) {
                        extent_slot--;
                        btrfs_item_key_to_cpu(path->nodes[0], &found_key,
                                              extent_slot);
@@ -2397,8 +2421,8 @@ static int __free_extent(struct btrfs_trans_handle *trans,
                                                &key, path, -1, 1);
                        if (ret) {
                                printk(KERN_ERR "umm, got %d back from search"
-                                      ", was looking for %Lu\n", ret,
-                                      bytenr);
+                                      ", was looking for %llu\n", ret,
+                                      (unsigned long long)bytenr);
                                btrfs_print_leaf(extent_root, path->nodes[0]);
                        }
                        BUG_ON(ret);
@@ -2407,9 +2431,12 @@ static int __free_extent(struct btrfs_trans_handle *trans,
        } else {
                btrfs_print_leaf(extent_root, path->nodes[0]);
                WARN_ON(1);
-               printk("Unable to find ref byte nr %Lu root %Lu "
-                      "gen %Lu owner %Lu\n", bytenr,
-                      root_objectid, ref_generation, owner_objectid);
+               printk(KERN_ERR "btrfs unable to find ref byte nr %llu "
+                      "root %llu gen %llu owner %llu\n",
+                      (unsigned long long)bytenr,
+                      (unsigned long long)root_objectid,
+                      (unsigned long long)ref_generation,
+                      (unsigned long long)owner_objectid);
        }
 
        leaf = path->nodes[0];
@@ -2448,10 +2475,6 @@ static int __free_extent(struct btrfs_trans_handle *trans,
        if (refs == 0) {
                u64 super_used;
                u64 root_used;
-#ifdef BIO_RW_DISCARD
-               u64 map_length = num_bytes;
-               struct btrfs_multi_bio *multi = NULL;
-#endif
 
                if (pin) {
                        mutex_lock(&root->fs_info->pinned_mutex);
@@ -2467,44 +2490,25 @@ static int __free_extent(struct btrfs_trans_handle *trans,
                super_used = btrfs_super_bytes_used(&info->super_copy);
                btrfs_set_super_bytes_used(&info->super_copy,
                                           super_used - num_bytes);
-               spin_unlock(&info->delalloc_lock);
 
                /* block accounting for root item */
                root_used = btrfs_root_used(&root->root_item);
                btrfs_set_root_used(&root->root_item,
                                           root_used - num_bytes);
+               spin_unlock(&info->delalloc_lock);
                ret = btrfs_del_items(trans, extent_root, path, path->slots[0],
                                      num_to_del);
                BUG_ON(ret);
                btrfs_release_path(extent_root, path);
-               ret = update_block_group(trans, root, bytenr, num_bytes, 0,
-                                        mark_free);
-               BUG_ON(ret);
 
                if (owner_objectid >= BTRFS_FIRST_FREE_OBJECTID) {
                        ret = btrfs_del_csums(trans, root, bytenr, num_bytes);
                        BUG_ON(ret);
                }
 
-#ifdef BIO_RW_DISCARD
-               /* Tell the block device(s) that the sectors can be discarded */
-               ret = btrfs_map_block(&root->fs_info->mapping_tree, READ,
-                                     bytenr, &map_length, &multi, 0);
-               if (!ret) {
-                       struct btrfs_bio_stripe *stripe = multi->stripes;
-                       int i;
-
-                       if (map_length > num_bytes)
-                               map_length = num_bytes;
-
-                       for (i = 0; i < multi->num_stripes; i++, stripe++) {
-                               btrfs_issue_discard(stripe->dev->bdev,
-                                                   stripe->physical,
-                                                    map_length);
-                       }
-                       kfree(multi);
-               }
-#endif
+               ret = update_block_group(trans, root, bytenr, num_bytes, 0,
+                                        mark_free);
+               BUG_ON(ret);
        }
        btrfs_free_path(path);
        finish_current_insert(trans, extent_root, 0);
@@ -2515,8 +2519,8 @@ static int __free_extent(struct btrfs_trans_handle *trans,
  * find all the blocks marked as pending in the radix tree and remove
  * them from the extent map
  */
-static int del_pending_extents(struct btrfs_trans_handle *trans, struct
-                              btrfs_root *extent_root, int all)
+static int del_pending_extents(struct btrfs_trans_handle *trans,
+                              struct btrfs_root *extent_root, int all)
 {
        int ret;
        int err = 0;
@@ -2537,7 +2541,7 @@ static int del_pending_extents(struct btrfs_trans_handle *trans, struct
 
 again:
        mutex_lock(&info->extent_ins_mutex);
-       while(1) {
+       while (1) {
                ret = find_first_extent_bit(pending_del, search, &start, &end,
                                            EXTENT_WRITEBACK);
                if (ret) {
@@ -2751,7 +2755,7 @@ static u64 stripe_align(struct btrfs_root *root, u64 val)
  * ins->offset == number of blocks
  * Any available blocks before search_start are skipped.
  */
-static int noinline find_free_extent(struct btrfs_trans_handle *trans,
+static noinline int find_free_extent(struct btrfs_trans_handle *trans,
                                     struct btrfs_root *orig_root,
                                     u64 num_bytes, u64 empty_size,
                                     u64 search_start, u64 search_end,
@@ -2760,7 +2764,7 @@ static int noinline find_free_extent(struct btrfs_trans_handle *trans,
                                     int data)
 {
        int ret = 0;
-       struct btrfs_root * root = orig_root->fs_info->extent_root;
+       struct btrfs_root *root = orig_root->fs_info->extent_root;
        u64 total_needed = num_bytes;
        u64 *last_ptr = NULL;
        u64 last_wanted = 0;
@@ -2993,8 +2997,10 @@ loop_check:
                        *last_ptr = ins->objectid + ins->offset;
                ret = 0;
        } else if (!ret) {
-               printk(KERN_ERR "we were searching for %Lu bytes, num_bytes %Lu,"
-                      " loop %d, allowed_alloc %d\n", total_needed, num_bytes,
+               printk(KERN_ERR "btrfs searching for %llu bytes, "
+                      "num_bytes %llu, loop %d, allowed_alloc %d\n",
+                      (unsigned long long)total_needed,
+                      (unsigned long long)num_bytes,
                       loop, allowed_chunk_alloc);
                ret = -ENOSPC;
        }
@@ -3010,19 +3016,22 @@ static void dump_space_info(struct btrfs_space_info *info, u64 bytes)
        struct btrfs_block_group_cache *cache;
        struct list_head *l;
 
-       printk(KERN_INFO "space_info has %Lu free, is %sfull\n",
-              info->total_bytes - info->bytes_used - info->bytes_pinned -
-              info->bytes_reserved, (info->full) ? "" : "not ");
+       printk(KERN_INFO "space_info has %llu free, is %sfull\n",
+              (unsigned long long)(info->total_bytes - info->bytes_used -
+                                   info->bytes_pinned - info->bytes_reserved),
+              (info->full) ? "" : "not ");
 
        down_read(&info->groups_sem);
        list_for_each(l, &info->block_groups) {
                cache = list_entry(l, struct btrfs_block_group_cache, list);
                spin_lock(&cache->lock);
-               printk(KERN_INFO "block group %Lu has %Lu bytes, %Lu used "
-                      "%Lu pinned %Lu reserved\n",
-                      cache->key.objectid, cache->key.offset,
-                      btrfs_block_group_used(&cache->item),
-                      cache->pinned, cache->reserved);
+               printk(KERN_INFO "block group %llu has %llu bytes, %llu used "
+                      "%llu pinned %llu reserved\n",
+                      (unsigned long long)cache->key.objectid,
+                      (unsigned long long)cache->key.offset,
+                      (unsigned long long)btrfs_block_group_used(&cache->item),
+                      (unsigned long long)cache->pinned,
+                      (unsigned long long)cache->reserved);
                btrfs_dump_free_space(cache, bytes);
                spin_unlock(&cache->lock);
        }
@@ -3043,15 +3052,15 @@ static int __btrfs_reserve_extent(struct btrfs_trans_handle *trans,
 
        if (data) {
                alloc_profile = info->avail_data_alloc_bits &
-                               info->data_alloc_profile;
+                       info->data_alloc_profile;
                data = BTRFS_BLOCK_GROUP_DATA | alloc_profile;
        } else if (root == root->fs_info->chunk_root) {
                alloc_profile = info->avail_system_alloc_bits &
-                               info->system_alloc_profile;
+                       info->system_alloc_profile;
                data = BTRFS_BLOCK_GROUP_SYSTEM | alloc_profile;
        } else {
                alloc_profile = info->avail_metadata_alloc_bits &
-                               info->metadata_alloc_profile;
+                       info->metadata_alloc_profile;
                data = BTRFS_BLOCK_GROUP_METADATA | alloc_profile;
        }
 again:
@@ -3090,8 +3099,9 @@ again:
                struct btrfs_space_info *sinfo;
 
                sinfo = __find_space_info(root->fs_info, data);
-               printk("allocation failed flags %Lu, wanted %Lu\n",
-                      data, num_bytes);
+               printk(KERN_ERR "btrfs allocation failed flags %llu, "
+                      "wanted %llu\n", (unsigned long long)data,
+                      (unsigned long long)num_bytes);
                dump_space_info(sinfo, num_bytes);
                BUG();
        }
@@ -3102,16 +3112,22 @@ again:
 int btrfs_free_reserved_extent(struct btrfs_root *root, u64 start, u64 len)
 {
        struct btrfs_block_group_cache *cache;
+       int ret = 0;
 
        cache = btrfs_lookup_block_group(root->fs_info, start);
        if (!cache) {
-               printk(KERN_ERR "Unable to find block group for %Lu\n", start);
+               printk(KERN_ERR "Unable to find block group for %llu\n",
+                      (unsigned long long)start);
                return -ENOSPC;
        }
+
+       ret = btrfs_discard_extent(root, start, len);
+
        btrfs_add_free_space(cache, start, len);
        put_block_group(cache);
        update_reserved_extents(root, start, len, 0);
-       return 0;
+
+       return ret;
 }
 
 int btrfs_reserve_extent(struct btrfs_trans_handle *trans,
@@ -3154,11 +3170,11 @@ static int __btrfs_alloc_reserved_extent(struct btrfs_trans_handle *trans,
        spin_lock(&info->delalloc_lock);
        super_used = btrfs_super_bytes_used(&info->super_copy);
        btrfs_set_super_bytes_used(&info->super_copy, super_used + num_bytes);
-       spin_unlock(&info->delalloc_lock);
 
        /* block accounting for root item */
        root_used = btrfs_root_used(&root->root_item);
        btrfs_set_root_used(&root->root_item, root_used + num_bytes);
+       spin_unlock(&info->delalloc_lock);
 
        if (root == extent_root) {
                struct pending_extent_op *extent_op;
@@ -3228,10 +3244,12 @@ static int __btrfs_alloc_reserved_extent(struct btrfs_trans_handle *trans,
        }
 
 update_block:
-       ret = update_block_group(trans, root, ins->objectid, ins->offset, 1, 0);
+       ret = update_block_group(trans, root, ins->objectid,
+                                ins->offset, 1, 0);
        if (ret) {
-               printk("update block group failed for %Lu %Lu\n",
-                      ins->objectid, ins->offset);
+               printk(KERN_ERR "btrfs update block group failed for %llu "
+                      "%llu\n", (unsigned long long)ins->objectid,
+                      (unsigned long long)ins->offset);
                BUG();
        }
 out:
@@ -3413,7 +3431,7 @@ int btrfs_drop_leaf_ref(struct btrfs_trans_handle *trans,
        return 0;
 }
 
-static int noinline cache_drop_leaf_ref(struct btrfs_trans_handle *trans,
+static noinline int cache_drop_leaf_ref(struct btrfs_trans_handle *trans,
                                        struct btrfs_root *root,
                                        struct btrfs_leaf_ref *ref)
 {
@@ -3438,15 +3456,15 @@ static int noinline cache_drop_leaf_ref(struct btrfs_trans_handle *trans,
        return 0;
 }
 
-static int drop_snap_lookup_refcount(struct btrfs_root *root, u64 start, u64 len,
-                             u32 *refs)
+static int drop_snap_lookup_refcount(struct btrfs_root *root, u64 start,
+                                    u64 len, u32 *refs)
 {
        int ret;
 
        ret = btrfs_lookup_extent_ref(NULL, root, start, len, refs);
        BUG_ON(ret);
 
-#if 0 // some debugging code in case we see problems here
+#if 0 /* some debugging code in case we see problems here */
        /* if the refs count is one, it won't get increased again.  But
         * if the ref count is > 1, someone may be decreasing it at
         * the same time we are.
@@ -3467,8 +3485,8 @@ static int drop_snap_lookup_refcount(struct btrfs_root *root, u64 start, u64 len
                        free_extent_buffer(eb);
                }
                if (*refs == 1) {
-                       printk("block %llu went down to one during drop_snap\n",
-                              (unsigned long long)start);
+                       printk(KERN_ERR "btrfs block %llu went down to one "
+                              "during drop_snap\n", (unsigned long long)start);
                }
 
        }
@@ -3482,7 +3500,7 @@ static int drop_snap_lookup_refcount(struct btrfs_root *root, u64 start, u64 len
  * helper function for drop_snapshot, this walks down the tree dropping ref
  * counts as it goes.
  */
-static int noinline walk_down_tree(struct btrfs_trans_handle *trans,
+static noinline int walk_down_tree(struct btrfs_trans_handle *trans,
                                   struct btrfs_root *root,
                                   struct btrfs_path *path, int *level)
 {
@@ -3509,7 +3527,7 @@ static int noinline walk_down_tree(struct btrfs_trans_handle *trans,
        /*
         * walk down to the last node level and free all the leaves
         */
-       while(*level >= 0) {
+       while (*level >= 0) {
                WARN_ON(*level < 0);
                WARN_ON(*level >= BTRFS_MAX_LEVEL);
                cur = path->nodes[*level];
@@ -3569,10 +3587,6 @@ static int noinline walk_down_tree(struct btrfs_trans_handle *trans,
                                *level = 0;
                                break;
                        }
-                       if (printk_ratelimit()) {
-                               printk("leaf ref miss for bytenr %llu\n",
-                                      (unsigned long long)bytenr);
-                       }
                }
                next = btrfs_find_tree_block(root, bytenr, blocksize);
                if (!next || !btrfs_buffer_uptodate(next, ptr_gen)) {
@@ -3634,7 +3648,7 @@ out:
  * walk_down_tree. The main difference is that it checks reference
  * counts while tree blocks are locked.
  */
-static int noinline walk_down_subtree(struct btrfs_trans_handle *trans,
+static noinline int walk_down_subtree(struct btrfs_trans_handle *trans,
                                      struct btrfs_root *root,
                                      struct btrfs_path *path, int *level)
 {
@@ -3723,7 +3737,7 @@ out:
  * to find the first node higher up where we haven't yet gone through
  * all the slots
  */
-static int noinline walk_up_tree(struct btrfs_trans_handle *trans,
+static noinline int walk_up_tree(struct btrfs_trans_handle *trans,
                                 struct btrfs_root *root,
                                 struct btrfs_path *path,
                                 int *level, int max_level)
@@ -3832,7 +3846,7 @@ int btrfs_drop_snapshot(struct btrfs_trans_handle *trans, struct btrfs_root
                        }
                }
        }
-       while(1) {
+       while (1) {
                wret = walk_down_tree(trans, root, path, &level);
                if (wret > 0)
                        break;
@@ -3913,7 +3927,7 @@ static unsigned long calc_ra(unsigned long start, unsigned long last,
        return min(last, start + nr - 1);
 }
 
-static int noinline relocate_inode_pages(struct inode *inode, u64 start,
+static noinline int relocate_inode_pages(struct inode *inode, u64 start,
                                         u64 len)
 {
        u64 page_start;
@@ -3984,10 +3998,10 @@ again:
                }
                set_page_extent_mapped(page);
 
-               btrfs_set_extent_delalloc(inode, page_start, page_end);
                if (i == first_index)
                        set_extent_bits(io_tree, page_start, page_end,
                                        EXTENT_BOUNDARY, GFP_NOFS);
+               btrfs_set_extent_delalloc(inode, page_start, page_end);
 
                set_page_dirty(page);
                total_dirty++;
@@ -4004,7 +4018,7 @@ out_unlock:
        return ret;
 }
 
-static int noinline relocate_data_extent(struct inode *reloc_inode,
+static noinline int relocate_data_extent(struct inode *reloc_inode,
                                         struct btrfs_key *extent_key,
                                         u64 offset)
 {
@@ -4080,7 +4094,7 @@ static int is_cowonly_root(u64 root_objectid)
        return 0;
 }
 
-static int noinline __next_ref_path(struct btrfs_trans_handle *trans,
+static noinline int __next_ref_path(struct btrfs_trans_handle *trans,
                                    struct btrfs_root *extent_root,
                                    struct btrfs_ref_path *ref_path,
                                    int first_time)
@@ -4112,11 +4126,10 @@ walk_down:
                if (level < ref_path->lowest_level)
                        break;
 
-               if (level >= 0) {
+               if (level >= 0)
                        bytenr = ref_path->nodes[level];
-               } else {
+               else
                        bytenr = ref_path->extent_start;
-               }
                BUG_ON(bytenr == 0);
 
                parent = ref_path->nodes[level + 1];
@@ -4163,11 +4176,12 @@ walk_up:
        level = ref_path->current_level;
        while (level < BTRFS_MAX_LEVEL - 1) {
                u64 ref_objectid;
-               if (level >= 0) {
+
+               if (level >= 0)
                        bytenr = ref_path->nodes[level];
-               } else {
+               else
                        bytenr = ref_path->extent_start;
-               }
+
                BUG_ON(bytenr == 0);
 
                key.objectid = bytenr;
@@ -4292,7 +4306,7 @@ static int btrfs_next_ref_path(struct btrfs_trans_handle *trans,
        return __next_ref_path(trans, extent_root, ref_path, 0);
 }
 
-static int noinline get_new_locations(struct inode *reloc_inode,
+static noinline int get_new_locations(struct inode *reloc_inode,
                                      struct btrfs_key *extent_key,
                                      u64 offset, int no_fragment,
                                      struct disk_extent **extents,
@@ -4395,7 +4409,7 @@ static int noinline get_new_locations(struct inode *reloc_inode,
                path->slots[0]++;
        }
 
-       WARN_ON(cur_pos + offset > last_byte);
+       BUG_ON(cur_pos + offset > last_byte);
        if (cur_pos + offset < last_byte) {
                ret = -ENOENT;
                goto out;
@@ -4413,7 +4427,7 @@ out:
        return ret;
 }
 
-static int noinline replace_one_extent(struct btrfs_trans_handle *trans,
+static noinline int replace_one_extent(struct btrfs_trans_handle *trans,
                                        struct btrfs_root *root,
                                        struct btrfs_path *path,
                                        struct btrfs_key *extent_key,
@@ -4771,7 +4785,7 @@ int btrfs_reloc_tree_cache_ref(struct btrfs_trans_handle *trans,
        return 0;
 }
 
-static int noinline invalidate_extent_cache(struct btrfs_root *root,
+static noinline int invalidate_extent_cache(struct btrfs_root *root,
                                        struct extent_buffer *leaf,
                                        struct btrfs_block_group_cache *group,
                                        struct btrfs_root *target_root)
@@ -4819,7 +4833,7 @@ static int noinline invalidate_extent_cache(struct btrfs_root *root,
        return 0;
 }
 
-static int noinline replace_extents_in_leaf(struct btrfs_trans_handle *trans,
+static noinline int replace_extents_in_leaf(struct btrfs_trans_handle *trans,
                                        struct btrfs_root *root,
                                        struct extent_buffer *leaf,
                                        struct btrfs_block_group_cache *group,
@@ -5028,7 +5042,7 @@ int btrfs_cleanup_reloc_trees(struct btrfs_root *root)
        return 0;
 }
 
-static int noinline init_reloc_tree(struct btrfs_trans_handle *trans,
+static noinline int init_reloc_tree(struct btrfs_trans_handle *trans,
                                    struct btrfs_root *root)
 {
        struct btrfs_root *reloc_root;
@@ -5095,7 +5109,7 @@ static int noinline init_reloc_tree(struct btrfs_trans_handle *trans,
  * tree blocks are shared between reloc trees, so they are also shared
  * between subvols.
  */
-static int noinline relocate_one_path(struct btrfs_trans_handle *trans,
+static noinline int relocate_one_path(struct btrfs_trans_handle *trans,
                                      struct btrfs_root *root,
                                      struct btrfs_path *path,
                                      struct btrfs_key *first_key,
@@ -5192,7 +5206,7 @@ static int noinline relocate_one_path(struct btrfs_trans_handle *trans,
        return 0;
 }
 
-static int noinline relocate_tree_block(struct btrfs_trans_handle *trans,
+static noinline int relocate_tree_block(struct btrfs_trans_handle *trans,
                                        struct btrfs_root *root,
                                        struct btrfs_path *path,
                                        struct btrfs_key *first_key,
@@ -5210,7 +5224,7 @@ static int noinline relocate_tree_block(struct btrfs_trans_handle *trans,
        return 0;
 }
 
-static int noinline del_extent_zero(struct btrfs_trans_handle *trans,
+static noinline int del_extent_zero(struct btrfs_trans_handle *trans,
                                    struct btrfs_root *extent_root,
                                    struct btrfs_path *path,
                                    struct btrfs_key *extent_key)
@@ -5226,7 +5240,7 @@ out:
        return ret;
 }
 
-static struct btrfs_root noinline *read_ref_root(struct btrfs_fs_info *fs_info,
+static noinline struct btrfs_root *read_ref_root(struct btrfs_fs_info *fs_info,
                                                struct btrfs_ref_path *ref_path)
 {
        struct btrfs_key root_key;
@@ -5241,7 +5255,7 @@ static struct btrfs_root noinline *read_ref_root(struct btrfs_fs_info *fs_info,
        return btrfs_read_fs_root_no_name(fs_info, &root_key);
 }
 
-static int noinline relocate_one_extent(struct btrfs_root *extent_root,
+static noinline int relocate_one_extent(struct btrfs_root *extent_root,
                                        struct btrfs_path *path,
                                        struct btrfs_key *extent_key,
                                        struct btrfs_block_group_cache *group,
@@ -5269,8 +5283,8 @@ static int noinline relocate_one_extent(struct btrfs_root *extent_root,
 
        ref_path = kmalloc(sizeof(*ref_path), GFP_NOFS);
        if (!ref_path) {
-              ret = -ENOMEM;
-              goto out;
+               ret = -ENOMEM;
+               goto out;
        }
 
        for (loops = 0; ; loops++) {
@@ -5490,7 +5504,7 @@ out:
        return ret;
 }
 
-static struct inode noinline *create_reloc_inode(struct btrfs_fs_info *fs_info,
+static noinline struct inode *create_reloc_inode(struct btrfs_fs_info *fs_info,
                                        struct btrfs_block_group_cache *group)
 {
        struct inode *inode = NULL;
@@ -5565,7 +5579,7 @@ int btrfs_reloc_clone_csums(struct inode *inode, u64 file_pos, u64 len)
        BUG_ON(ordered->file_offset != file_pos || ordered->len != len);
 
        disk_bytenr = file_pos + BTRFS_I(inode)->index_cnt;
-       ret = btrfs_lookup_csums_range(root, disk_bytenr,
+       ret = btrfs_lookup_csums_range(root->fs_info->csum_root, disk_bytenr,
                                       disk_bytenr + len - 1, &list);
 
        while (!list_empty(&list)) {
@@ -5610,7 +5624,7 @@ int btrfs_relocate_block_group(struct btrfs_root *root, u64 group_start)
        block_group = btrfs_lookup_block_group(info, group_start);
        BUG_ON(!block_group);
 
-       printk("btrfs relocating block group %llu flags %llu\n",
+       printk(KERN_INFO "btrfs relocating block group %llu flags %llu\n",
               (unsigned long long)block_group->key.objectid,
               (unsigned long long)block_group->flags);
 
@@ -5642,7 +5656,7 @@ again:
        btrfs_remove_leaf_refs(info->tree_root, (u64)-1, 1);
        mutex_unlock(&root->fs_info->cleaner_mutex);
 
-       while(1) {
+       while (1) {
                ret = btrfs_search_slot(NULL, root, &key, path, 0, 0);
                if (ret < 0)
                        goto out;
@@ -5702,11 +5716,10 @@ next:
        if (pass == 0) {
                btrfs_wait_ordered_range(reloc_inode, 0, (u64)-1);
                invalidate_mapping_pages(reloc_inode->i_mapping, 0, -1);
-               WARN_ON(reloc_inode->i_mapping->nrpages);
        }
 
        if (total_found > 0) {
-               printk("btrfs found %llu extents in pass %d\n",
+               printk(KERN_INFO "btrfs found %llu extents in pass %d\n",
                       (unsigned long long)total_found, pass);
                pass++;
                if (total_found == skipped && pass > 2) {
@@ -5748,7 +5761,7 @@ static int find_first_block_group(struct btrfs_root *root,
        if (ret < 0)
                goto out;
 
-       while(1) {
+       while (1) {
                slot = path->slots[0];
                leaf = path->nodes[0];
                if (slot >= btrfs_header_nritems(leaf)) {
@@ -5819,7 +5832,7 @@ int btrfs_read_block_groups(struct btrfs_root *root)
        if (!path)
                return -ENOMEM;
 
-       while(1) {
+       while (1) {
                ret = find_first_block_group(root, path, &key);
                if (ret > 0) {
                        ret = 0;