NFSv4: Fix up the documentation for nfs_do_refmount
[safe/jmp/linux-2.6] / fs / bfs / inode.c
index 64e0fb3..f22a7d3 100644 (file)
@@ -1,8 +1,10 @@
 /*
  *     fs/bfs/inode.c
  *     BFS superblock and inode operations.
- *     Copyright (C) 1999,2000 Tigran Aivazian <tigran@veritas.com>
+ *     Copyright (C) 1999-2006 Tigran Aivazian <tigran@aivazian.fsnet.co.uk>
  *     From fs/minix, Copyright (C) 1991, 1992 Linus Torvalds.
+ *
+ *      Made endianness-clean by Andrew Stribblehill <ads@wompom.org>, 2005.
  */
 
 #include <linux/module.h>
 #include <linux/smp_lock.h>
 #include <linux/buffer_head.h>
 #include <linux/vfs.h>
+#include <linux/writeback.h>
 #include <asm/uaccess.h>
 #include "bfs.h"
 
-MODULE_AUTHOR("Tigran A. Aivazian <tigran@veritas.com>");
+MODULE_AUTHOR("Tigran Aivazian <tigran@aivazian.fsnet.co.uk>");
 MODULE_DESCRIPTION("SCO UnixWare BFS filesystem for Linux");
 MODULE_LICENSE("GPL");
 
@@ -28,172 +31,236 @@ MODULE_LICENSE("GPL");
 #define dprintf(x...)
 #endif
 
-void dump_imap(const char *prefix, struct super_block * s);
+static void bfs_write_super(struct super_block *s);
+void dump_imap(const char *prefix, struct super_block *s);
 
-static void bfs_read_inode(struct inode * inode)
+struct inode *bfs_iget(struct super_block *sb, unsigned long ino)
 {
-       unsigned long ino = inode->i_ino;
-       struct bfs_inode * di;
-       struct buffer_head * bh;
+       struct bfs_inode *di;
+       struct inode *inode;
+       struct buffer_head *bh;
        int block, off;
 
-       if (ino < BFS_ROOT_INO || ino > BFS_SB(inode->i_sb)->si_lasti) {
+       inode = iget_locked(sb, ino);
+       if (IS_ERR(inode))
+               return ERR_PTR(-ENOMEM);
+       if (!(inode->i_state & I_NEW))
+               return inode;
+
+       if ((ino < BFS_ROOT_INO) || (ino > BFS_SB(inode->i_sb)->si_lasti)) {
                printf("Bad inode number %s:%08lx\n", inode->i_sb->s_id, ino);
-               make_bad_inode(inode);
-               return;
+               goto error;
        }
 
-       block = (ino - BFS_ROOT_INO)/BFS_INODES_PER_BLOCK + 1;
+       block = (ino - BFS_ROOT_INO) / BFS_INODES_PER_BLOCK + 1;
        bh = sb_bread(inode->i_sb, block);
        if (!bh) {
-               printf("Unable to read inode %s:%08lx\n", inode->i_sb->s_id, ino);
-               make_bad_inode(inode);
-               return;
+               printf("Unable to read inode %s:%08lx\n", inode->i_sb->s_id,
+                                                                       ino);
+               goto error;
        }
 
        off = (ino - BFS_ROOT_INO) % BFS_INODES_PER_BLOCK;
        di = (struct bfs_inode *)bh->b_data + off;
 
-       inode->i_mode = 0x0000FFFF & di->i_mode;
-       if (di->i_vtype == BFS_VDIR) {
+       inode->i_mode = 0x0000FFFF & le32_to_cpu(di->i_mode);
+       if (le32_to_cpu(di->i_vtype) == BFS_VDIR) {
                inode->i_mode |= S_IFDIR;
                inode->i_op = &bfs_dir_inops;
                inode->i_fop = &bfs_dir_operations;
-       } else if (di->i_vtype == BFS_VREG) {
+       } else if (le32_to_cpu(di->i_vtype) == BFS_VREG) {
                inode->i_mode |= S_IFREG;
                inode->i_op = &bfs_file_inops;
                inode->i_fop = &bfs_file_operations;
                inode->i_mapping->a_ops = &bfs_aops;
        }
 
-       inode->i_uid = di->i_uid;
-       inode->i_gid = di->i_gid;
-       inode->i_nlink = di->i_nlink;
+       BFS_I(inode)->i_sblock =  le32_to_cpu(di->i_sblock);
+       BFS_I(inode)->i_eblock =  le32_to_cpu(di->i_eblock);
+       BFS_I(inode)->i_dsk_ino = le16_to_cpu(di->i_ino);
+       inode->i_uid =  le32_to_cpu(di->i_uid);
+       inode->i_gid =  le32_to_cpu(di->i_gid);
+       inode->i_nlink =  le32_to_cpu(di->i_nlink);
        inode->i_size = BFS_FILESIZE(di);
        inode->i_blocks = BFS_FILEBLOCKS(di);
-       inode->i_blksize = PAGE_SIZE;
-       inode->i_atime.tv_sec = di->i_atime;
-       inode->i_mtime.tv_sec = di->i_mtime;
-       inode->i_ctime.tv_sec = di->i_ctime;
+       inode->i_atime.tv_sec =  le32_to_cpu(di->i_atime);
+       inode->i_mtime.tv_sec =  le32_to_cpu(di->i_mtime);
+       inode->i_ctime.tv_sec =  le32_to_cpu(di->i_ctime);
        inode->i_atime.tv_nsec = 0;
        inode->i_mtime.tv_nsec = 0;
        inode->i_ctime.tv_nsec = 0;
-       BFS_I(inode)->i_dsk_ino = di->i_ino; /* can be 0 so we store a copy */
-       BFS_I(inode)->i_sblock = di->i_sblock;
-       BFS_I(inode)->i_eblock = di->i_eblock;
 
        brelse(bh);
+       unlock_new_inode(inode);
+       return inode;
+
+error:
+       iget_failed(inode);
+       return ERR_PTR(-EIO);
 }
 
-static int bfs_write_inode(struct inode * inode, int unused)
+static int bfs_write_inode(struct inode *inode, struct writeback_control *wbc)
 {
-       unsigned long ino = inode->i_ino;
-       struct bfs_inode * di;
-       struct buffer_head * bh;
+       struct bfs_sb_info *info = BFS_SB(inode->i_sb);
+       unsigned int ino = (u16)inode->i_ino;
+        unsigned long i_sblock;
+       struct bfs_inode *di;
+       struct buffer_head *bh;
        int block, off;
+       int err = 0;
 
-       if (ino < BFS_ROOT_INO || ino > BFS_SB(inode->i_sb)->si_lasti) {
-               printf("Bad inode number %s:%08lx\n", inode->i_sb->s_id, ino);
+        dprintf("ino=%08x\n", ino);
+
+       if ((ino < BFS_ROOT_INO) || (ino > BFS_SB(inode->i_sb)->si_lasti)) {
+               printf("Bad inode number %s:%08x\n", inode->i_sb->s_id, ino);
                return -EIO;
        }
 
-       lock_kernel();
-       block = (ino - BFS_ROOT_INO)/BFS_INODES_PER_BLOCK + 1;
+       mutex_lock(&info->bfs_lock);
+       block = (ino - BFS_ROOT_INO) / BFS_INODES_PER_BLOCK + 1;
        bh = sb_bread(inode->i_sb, block);
        if (!bh) {
-               printf("Unable to read inode %s:%08lx\n", inode->i_sb->s_id, ino);
-               unlock_kernel();
+               printf("Unable to read inode %s:%08x\n",
+                               inode->i_sb->s_id, ino);
+               mutex_unlock(&info->bfs_lock);
                return -EIO;
        }
 
-       off = (ino - BFS_ROOT_INO)%BFS_INODES_PER_BLOCK;
+       off = (ino - BFS_ROOT_INO) % BFS_INODES_PER_BLOCK;
        di = (struct bfs_inode *)bh->b_data + off;
 
-       if (inode->i_ino == BFS_ROOT_INO)
-               di->i_vtype = BFS_VDIR;
+       if (ino == BFS_ROOT_INO)
+               di->i_vtype = cpu_to_le32(BFS_VDIR);
        else
-               di->i_vtype = BFS_VREG;
-
-       di->i_ino = inode->i_ino;
-       di->i_mode = inode->i_mode;
-       di->i_uid = inode->i_uid;
-       di->i_gid = inode->i_gid;
-       di->i_nlink = inode->i_nlink;
-       di->i_atime = inode->i_atime.tv_sec;
-       di->i_mtime = inode->i_mtime.tv_sec;
-       di->i_ctime = inode->i_ctime.tv_sec;
-       di->i_sblock = BFS_I(inode)->i_sblock;
-       di->i_eblock = BFS_I(inode)->i_eblock;
-       di->i_eoffset = di->i_sblock * BFS_BSIZE + inode->i_size - 1;
+               di->i_vtype = cpu_to_le32(BFS_VREG);
+
+       di->i_ino = cpu_to_le16(ino);
+       di->i_mode = cpu_to_le32(inode->i_mode);
+       di->i_uid = cpu_to_le32(inode->i_uid);
+       di->i_gid = cpu_to_le32(inode->i_gid);
+       di->i_nlink = cpu_to_le32(inode->i_nlink);
+       di->i_atime = cpu_to_le32(inode->i_atime.tv_sec);
+       di->i_mtime = cpu_to_le32(inode->i_mtime.tv_sec);
+       di->i_ctime = cpu_to_le32(inode->i_ctime.tv_sec);
+        i_sblock = BFS_I(inode)->i_sblock;
+       di->i_sblock = cpu_to_le32(i_sblock);
+       di->i_eblock = cpu_to_le32(BFS_I(inode)->i_eblock);
+       di->i_eoffset = cpu_to_le32(i_sblock * BFS_BSIZE + inode->i_size - 1);
 
        mark_buffer_dirty(bh);
+       if (wbc->sync_mode == WB_SYNC_ALL) {
+               sync_dirty_buffer(bh);
+               if (buffer_req(bh) && !buffer_uptodate(bh))
+                       err = -EIO;
+       }
        brelse(bh);
-       unlock_kernel();
-       return 0;
+       mutex_unlock(&info->bfs_lock);
+       return err;
 }
 
-static void bfs_delete_inode(struct inode * inode)
+static void bfs_delete_inode(struct inode *inode)
 {
        unsigned long ino = inode->i_ino;
-       struct bfs_inode * di;
-       struct buffer_head * bh;
+       struct bfs_inode *di;
+       struct buffer_head *bh;
        int block, off;
-       struct super_block * s = inode->i_sb;
-       struct bfs_sb_info * info = BFS_SB(s);
+       struct super_block *s = inode->i_sb;
+       struct bfs_sb_info *info = BFS_SB(s);
+       struct bfs_inode_info *bi = BFS_I(inode);
+
+       dprintf("ino=%08lx\n", ino);
 
-       dprintf("ino=%08lx\n", inode->i_ino);
+       truncate_inode_pages(&inode->i_data, 0);
 
-       if (inode->i_ino < BFS_ROOT_INO || inode->i_ino > info->si_lasti) {
-               printf("invalid ino=%08lx\n", inode->i_ino);
+       if ((ino < BFS_ROOT_INO) || (ino > info->si_lasti)) {
+               printf("invalid ino=%08lx\n", ino);
                return;
        }
        
        inode->i_size = 0;
        inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME_SEC;
-       lock_kernel();
+       mutex_lock(&info->bfs_lock);
        mark_inode_dirty(inode);
-       block = (ino - BFS_ROOT_INO)/BFS_INODES_PER_BLOCK + 1;
+
+       block = (ino - BFS_ROOT_INO) / BFS_INODES_PER_BLOCK + 1;
        bh = sb_bread(s, block);
        if (!bh) {
-               printf("Unable to read inode %s:%08lx\n", inode->i_sb->s_id, ino);
-               unlock_kernel();
+               printf("Unable to read inode %s:%08lx\n",
+                                       inode->i_sb->s_id, ino);
+               mutex_unlock(&info->bfs_lock);
                return;
        }
-       off = (ino - BFS_ROOT_INO)%BFS_INODES_PER_BLOCK;
+       off = (ino - BFS_ROOT_INO) % BFS_INODES_PER_BLOCK;
        di = (struct bfs_inode *)bh->b_data + off;
-       if (di->i_ino) {
-               info->si_freeb += BFS_FILEBLOCKS(di);
-               info->si_freei++;
-               clear_bit(di->i_ino, info->si_imap);
-               dump_imap("delete_inode", s);
-       }
-       di->i_ino = 0;
-       di->i_sblock = 0;
+       memset((void *)di, 0, sizeof(struct bfs_inode));
        mark_buffer_dirty(bh);
        brelse(bh);
 
-       /* if this was the last file, make the previous 
-          block "last files last block" even if there is no real file there,
-          saves us 1 gap */
-       if (info->si_lf_eblk == BFS_I(inode)->i_eblock) {
-               info->si_lf_eblk = BFS_I(inode)->i_sblock - 1;
+        if (bi->i_dsk_ino) {
+               if (bi->i_sblock)
+                       info->si_freeb += bi->i_eblock + 1 - bi->i_sblock;
+               info->si_freei++;
+               clear_bit(ino, info->si_imap);
+               dump_imap("delete_inode", s);
+        }
+
+       /*
+        * If this was the last file, make the previous block
+        * "last block of the last file" even if there is no
+        * real file there, saves us 1 gap.
+        */
+       if (info->si_lf_eblk == bi->i_eblock) {
+               info->si_lf_eblk = bi->i_sblock - 1;
                mark_buffer_dirty(info->si_sbh);
        }
-       unlock_kernel();
+       mutex_unlock(&info->bfs_lock);
        clear_inode(inode);
 }
 
+static int bfs_sync_fs(struct super_block *sb, int wait)
+{
+       struct bfs_sb_info *info = BFS_SB(sb);
+
+       mutex_lock(&info->bfs_lock);
+       mark_buffer_dirty(info->si_sbh);
+       sb->s_dirt = 0;
+       mutex_unlock(&info->bfs_lock);
+
+       return 0;
+}
+
+static void bfs_write_super(struct super_block *sb)
+{
+       if (!(sb->s_flags & MS_RDONLY))
+               bfs_sync_fs(sb, 1);
+       else
+               sb->s_dirt = 0;
+}
+
 static void bfs_put_super(struct super_block *s)
 {
        struct bfs_sb_info *info = BFS_SB(s);
+
+       if (!info)
+               return;
+
+       lock_kernel();
+
+       if (s->s_dirt)
+               bfs_write_super(s);
+
        brelse(info->si_sbh);
+       mutex_destroy(&info->bfs_lock);
        kfree(info->si_imap);
        kfree(info);
        s->s_fs_info = NULL;
+
+       unlock_kernel();
 }
 
-static int bfs_statfs(struct super_block *s, struct kstatfs *buf)
+static int bfs_statfs(struct dentry *dentry, struct kstatfs *buf)
 {
+       struct super_block *s = dentry->d_sb;
        struct bfs_sb_info *info = BFS_SB(s);
        u64 id = huge_encode_dev(s->s_bdev->bd_dev);
        buf->f_type = BFS_MAGIC;
@@ -208,21 +275,12 @@ static int bfs_statfs(struct super_block *s, struct kstatfs *buf)
        return 0;
 }
 
-static void bfs_write_super(struct super_block *s)
-{
-       lock_kernel();
-       if (!(s->s_flags & MS_RDONLY))
-               mark_buffer_dirty(BFS_SB(s)->si_sbh);
-       s->s_dirt = 0;
-       unlock_kernel();
-}
-
-static kmem_cache_t * bfs_inode_cachep;
+static struct kmem_cache *bfs_inode_cachep;
 
 static struct inode *bfs_alloc_inode(struct super_block *sb)
 {
        struct bfs_inode_info *bi;
-       bi = kmem_cache_alloc(bfs_inode_cachep, SLAB_KERNEL);
+       bi = kmem_cache_alloc(bfs_inode_cachep, GFP_KERNEL);
        if (!bi)
                return NULL;
        return &bi->vfs_inode;
@@ -233,21 +291,20 @@ static void bfs_destroy_inode(struct inode *inode)
        kmem_cache_free(bfs_inode_cachep, BFS_I(inode));
 }
 
-static void init_once(void * foo, kmem_cache_t * cachep, unsigned long flags)
+static void init_once(void *foo)
 {
        struct bfs_inode_info *bi = foo;
 
-       if ((flags & (SLAB_CTOR_VERIFY|SLAB_CTOR_CONSTRUCTOR)) ==
-           SLAB_CTOR_CONSTRUCTOR)
-               inode_init_once(&bi->vfs_inode);
+       inode_init_once(&bi->vfs_inode);
 }
+
 static int init_inodecache(void)
 {
        bfs_inode_cachep = kmem_cache_create("bfs_inode_cache",
                                             sizeof(struct bfs_inode_info),
-                                            0, SLAB_RECLAIM_ACCOUNT,
-                                            init_once, NULL);
+                                            0, (SLAB_RECLAIM_ACCOUNT|
+                                               SLAB_MEM_SPREAD),
+                                            init_once);
        if (bfs_inode_cachep == NULL)
                return -ENOMEM;
        return 0;
@@ -255,136 +312,191 @@ static int init_inodecache(void)
 
 static void destroy_inodecache(void)
 {
-       if (kmem_cache_destroy(bfs_inode_cachep))
-               printk(KERN_INFO "bfs_inode_cache: not all structures were freed\n");
+       kmem_cache_destroy(bfs_inode_cachep);
 }
 
-static struct super_operations bfs_sops = {
+static const struct super_operations bfs_sops = {
        .alloc_inode    = bfs_alloc_inode,
        .destroy_inode  = bfs_destroy_inode,
-       .read_inode     = bfs_read_inode,
        .write_inode    = bfs_write_inode,
        .delete_inode   = bfs_delete_inode,
        .put_super      = bfs_put_super,
        .write_super    = bfs_write_super,
+       .sync_fs        = bfs_sync_fs,
        .statfs         = bfs_statfs,
 };
 
-void dump_imap(const char *prefix, struct super_block * s)
+void dump_imap(const char *prefix, struct super_block *s)
 {
-#if 0
+#ifdef DEBUG
        int i;
        char *tmpbuf = (char *)get_zeroed_page(GFP_KERNEL);
 
        if (!tmpbuf)
                return;
-       for (i=BFS_SB(s)->si_lasti; i>=0; i--) {
-               if (i>PAGE_SIZE-100) break;
+       for (i = BFS_SB(s)->si_lasti; i >= 0; i--) {
+               if (i > PAGE_SIZE - 100) break;
                if (test_bit(i, BFS_SB(s)->si_imap))
                        strcat(tmpbuf, "1");
                else
                        strcat(tmpbuf, "0");
        }
-       printk(KERN_ERR "BFS-fs: %s: lasti=%08lx <%s>\n", prefix, BFS_SB(s)->si_lasti, tmpbuf);
+       printf("BFS-fs: %s: lasti=%08lx <%s>\n",
+                               prefix, BFS_SB(s)->si_lasti, tmpbuf);
        free_page((unsigned long)tmpbuf);
 #endif
 }
 
 static int bfs_fill_super(struct super_block *s, void *data, int silent)
 {
-       struct buffer_head * bh;
-       struct bfs_super_block * bfs_sb;
-       struct inode * inode;
-       int i, imap_len;
-       struct bfs_sb_info * info;
-
-       info = kmalloc(sizeof(*info), GFP_KERNEL);
+       struct buffer_head *bh;
+       struct bfs_super_block *bfs_sb;
+       struct inode *inode;
+       unsigned i, imap_len;
+       struct bfs_sb_info *info;
+       int ret = -EINVAL;
+       unsigned long i_sblock, i_eblock, i_eoff, s_size;
+
+       info = kzalloc(sizeof(*info), GFP_KERNEL);
        if (!info)
                return -ENOMEM;
+       mutex_init(&info->bfs_lock);
        s->s_fs_info = info;
-       memset(info, 0, sizeof(*info));
 
        sb_set_blocksize(s, BFS_BSIZE);
 
-       bh = sb_bread(s, 0);
-       if(!bh)
+       info->si_sbh = sb_bread(s, 0);
+       if (!info->si_sbh)
                goto out;
-       bfs_sb = (struct bfs_super_block *)bh->b_data;
-       if (bfs_sb->s_magic != BFS_MAGIC) {
+       bfs_sb = (struct bfs_super_block *)info->si_sbh->b_data;
+       if (le32_to_cpu(bfs_sb->s_magic) != BFS_MAGIC) {
                if (!silent)
                        printf("No BFS filesystem on %s (magic=%08x)\n", 
-                               s->s_id, bfs_sb->s_magic);
-               goto out;
+                               s->s_id,  le32_to_cpu(bfs_sb->s_magic));
+               goto out1;
        }
        if (BFS_UNCLEAN(bfs_sb, s) && !silent)
                printf("%s is unclean, continuing\n", s->s_id);
 
        s->s_magic = BFS_MAGIC;
-       info->si_bfs_sb = bfs_sb;
-       info->si_sbh = bh;
-       info->si_lasti = (bfs_sb->s_start - BFS_BSIZE)/sizeof(struct bfs_inode) 
-                       + BFS_ROOT_INO - 1;
 
-       imap_len = info->si_lasti/8 + 1;
-       info->si_imap = kmalloc(imap_len, GFP_KERNEL);
+       if (le32_to_cpu(bfs_sb->s_start) > le32_to_cpu(bfs_sb->s_end)) {
+               printf("Superblock is corrupted\n");
+               goto out1;
+       }
+
+       info->si_lasti = (le32_to_cpu(bfs_sb->s_start) - BFS_BSIZE) /
+                                       sizeof(struct bfs_inode)
+                                       + BFS_ROOT_INO - 1;
+       imap_len = (info->si_lasti / 8) + 1;
+       info->si_imap = kzalloc(imap_len, GFP_KERNEL);
        if (!info->si_imap)
-               goto out;
-       memset(info->si_imap, 0, imap_len);
-       for (i=0; i<BFS_ROOT_INO; i++) 
+               goto out1;
+       for (i = 0; i < BFS_ROOT_INO; i++)
                set_bit(i, info->si_imap);
 
        s->s_op = &bfs_sops;
-       inode = iget(s, BFS_ROOT_INO);
-       if (!inode) {
-               kfree(info->si_imap);
-               goto out;
+       inode = bfs_iget(s, BFS_ROOT_INO);
+       if (IS_ERR(inode)) {
+               ret = PTR_ERR(inode);
+               goto out2;
        }
        s->s_root = d_alloc_root(inode);
        if (!s->s_root) {
                iput(inode);
-               kfree(info->si_imap);
-               goto out;
+               ret = -ENOMEM;
+               goto out2;
        }
 
-       info->si_blocks = (bfs_sb->s_end + 1)>>BFS_BSIZE_BITS; /* for statfs(2) */
-       info->si_freeb = (bfs_sb->s_end + 1 - bfs_sb->s_start)>>BFS_BSIZE_BITS;
+       info->si_blocks = (le32_to_cpu(bfs_sb->s_end) + 1) >> BFS_BSIZE_BITS;
+       info->si_freeb = (le32_to_cpu(bfs_sb->s_end) + 1
+                       - le32_to_cpu(bfs_sb->s_start)) >> BFS_BSIZE_BITS;
        info->si_freei = 0;
        info->si_lf_eblk = 0;
-       info->si_lf_sblk = 0;
-       info->si_lf_ioff = 0;
-       for (i=BFS_ROOT_INO; i<=info->si_lasti; i++) {
-               inode = iget(s,i);
-               if (BFS_I(inode)->i_dsk_ino == 0)
+
+       /* can we read the last block? */
+       bh = sb_bread(s, info->si_blocks - 1);
+       if (!bh) {
+               printf("Last block not available: %lu\n", info->si_blocks - 1);
+               ret = -EIO;
+               goto out3;
+       }
+       brelse(bh);
+
+       bh = NULL;
+       for (i = BFS_ROOT_INO; i <= info->si_lasti; i++) {
+               struct bfs_inode *di;
+               int block = (i - BFS_ROOT_INO) / BFS_INODES_PER_BLOCK + 1;
+               int off = (i - BFS_ROOT_INO) % BFS_INODES_PER_BLOCK;
+               unsigned long eblock;
+
+               if (!off) {
+                       brelse(bh);
+                       bh = sb_bread(s, block);
+               }
+
+               if (!bh)
+                       continue;
+
+               di = (struct bfs_inode *)bh->b_data + off;
+
+               /* test if filesystem is not corrupted */
+
+               i_eoff = le32_to_cpu(di->i_eoffset);
+               i_sblock = le32_to_cpu(di->i_sblock);
+               i_eblock = le32_to_cpu(di->i_eblock);
+               s_size = le32_to_cpu(bfs_sb->s_end);
+
+               if (i_sblock > info->si_blocks ||
+                       i_eblock > info->si_blocks ||
+                       i_sblock > i_eblock ||
+                       i_eoff > s_size ||
+                       i_sblock * BFS_BSIZE > i_eoff) {
+
+                       printf("Inode 0x%08x corrupted\n", i);
+
+                       brelse(bh);
+                       ret = -EIO;
+                       goto out3;
+               }
+
+               if (!di->i_ino) {
                        info->si_freei++;
-               else {
-                       set_bit(i, info->si_imap);
-                       info->si_freeb -= inode->i_blocks;
-                       if (BFS_I(inode)->i_eblock > info->si_lf_eblk) {
-                               info->si_lf_eblk = BFS_I(inode)->i_eblock;
-                               info->si_lf_sblk = BFS_I(inode)->i_sblock;
-                               info->si_lf_ioff = BFS_INO2OFF(i);
-                       }
+                       continue;
                }
-               iput(inode);
+               set_bit(i, info->si_imap);
+               info->si_freeb -= BFS_FILEBLOCKS(di);
+
+               eblock =  le32_to_cpu(di->i_eblock);
+               if (eblock > info->si_lf_eblk)
+                       info->si_lf_eblk = eblock;
        }
+       brelse(bh);
        if (!(s->s_flags & MS_RDONLY)) {
-               mark_buffer_dirty(bh);
+               mark_buffer_dirty(info->si_sbh);
                s->s_dirt = 1;
        } 
        dump_imap("read_super", s);
        return 0;
 
+out3:
+       dput(s->s_root);
+       s->s_root = NULL;
+out2:
+       kfree(info->si_imap);
+out1:
+       brelse(info->si_sbh);
 out:
-       brelse(bh);
+       mutex_destroy(&info->bfs_lock);
        kfree(info);
        s->s_fs_info = NULL;
-       return -EINVAL;
+       return ret;
 }
 
-static struct super_block *bfs_get_sb(struct file_system_type *fs_type,
-       int flags, const char *dev_name, void *data)
+static int bfs_get_sb(struct file_system_type *fs_type,
+       int flags, const char *dev_name, void *data, struct vfsmount *mnt)
 {
-       return get_sb_bdev(fs_type, flags, dev_name, data, bfs_fill_super);
+       return get_sb_bdev(fs_type, flags, dev_name, data, bfs_fill_super, mnt);
 }
 
 static struct file_system_type bfs_fs_type = {