Remove obsolete #include <linux/config.h>
[safe/jmp/linux-2.6] / fs / 9p / vfs_inode.c
index ef78af7..2f580a1 100644 (file)
@@ -1,15 +1,14 @@
 /*
  *  linux/fs/9p/vfs_inode.c
  *
- * This file contians vfs inode ops for the 9P2000 protocol.
+ * This file contains vfs inode ops for the 9P2000 protocol.
  *
  *  Copyright (C) 2004 by Eric Van Hensbergen <ericvh@gmail.com>
  *  Copyright (C) 2002 by Ron Minnich <rminnich@lanl.gov>
  *
  *  This program is free software; you can redistribute it and/or modify
- *  it under the terms of the GNU General Public License as published by
- *  the Free Software Foundation; either version 2 of the License, or
- *  (at your option) any later version.
+ *  it under the terms of the GNU General Public License version 2
+ *  as published by the Free Software Foundation.
  *
  *  This program is distributed in the hope that it will be useful,
  *  but WITHOUT ANY WARRANTY; without even the implied warranty of
 #include "v9fs.h"
 #include "9p.h"
 #include "v9fs_vfs.h"
-#include "conv.h"
 #include "fid.h"
 
 static struct inode_operations v9fs_dir_inode_operations;
+static struct inode_operations v9fs_dir_inode_operations_ext;
 static struct inode_operations v9fs_file_inode_operations;
 static struct inode_operations v9fs_symlink_inode_operations;
 
@@ -54,7 +53,7 @@ static struct inode_operations v9fs_symlink_inode_operations;
  *
  */
 
-static inline int unixmode2p9mode(struct v9fs_session_info *v9ses, int mode)
+static int unixmode2p9mode(struct v9fs_session_info *v9ses, int mode)
 {
        int res;
        res = mode & 0777;
@@ -92,7 +91,7 @@ static inline int unixmode2p9mode(struct v9fs_session_info *v9ses, int mode)
  *
  */
 
-static inline int p9mode2unixmode(struct v9fs_session_info *v9ses, int mode)
+static int p9mode2unixmode(struct v9fs_session_info *v9ses, int mode)
 {
        int res;
 
@@ -125,112 +124,65 @@ static inline int p9mode2unixmode(struct v9fs_session_info *v9ses, int mode)
        return res;
 }
 
-/**
- * v9fs_blank_mistat - helper function to setup a 9P stat structure
- * @v9ses: 9P session info (for determining extended mode)
- * @mistat: structure to initialize
- *
- */
-
-static inline void
-v9fs_blank_mistat(struct v9fs_session_info *v9ses, struct v9fs_stat *mistat)
-{
-       mistat->type = ~0;
-       mistat->dev = ~0;
-       mistat->qid.type = ~0;
-       mistat->qid.version = ~0;
-       *((long long *)&mistat->qid.path) = ~0;
-       mistat->mode = ~0;
-       mistat->atime = ~0;
-       mistat->mtime = ~0;
-       mistat->length = ~0;
-       mistat->name = mistat->data;
-       mistat->uid = mistat->data;
-       mistat->gid = mistat->data;
-       mistat->muid = mistat->data;
-       if (v9ses->extended) {
-               mistat->n_uid = ~0;
-               mistat->n_gid = ~0;
-               mistat->n_muid = ~0;
-               mistat->extension = mistat->data;
-       }
-       *mistat->data = 0;
-}
-
-/**
- * v9fs_mistat2unix - convert mistat to unix stat
- * @mistat: Plan 9 metadata (mistat) structure
- * @stat: unix metadata (stat) structure to populate
- * @sb: superblock
- *
- */
-
-static void
-v9fs_mistat2unix(struct v9fs_stat *mistat, struct stat *buf,
-                struct super_block *sb)
+int v9fs_uflags2omode(int uflags)
 {
-       struct v9fs_session_info *v9ses = sb ? sb->s_fs_info : NULL;
-
-       buf->st_nlink = 1;
+       int ret;
 
-       buf->st_atime = mistat->atime;
-       buf->st_mtime = mistat->mtime;
-       buf->st_ctime = mistat->mtime;
+       ret = 0;
+       switch (uflags&3) {
+       default:
+       case O_RDONLY:
+               ret = V9FS_OREAD;
+               break;
 
-       if (v9ses && v9ses->extended) {
-               /* TODO: string to uid mapping via user-space daemon */
-               buf->st_uid = mistat->n_uid;
-               buf->st_gid = mistat->n_gid;
+       case O_WRONLY:
+               ret = V9FS_OWRITE;
+               break;
 
-               sscanf(mistat->uid, "%x", (unsigned int *)&buf->st_uid);
-               sscanf(mistat->gid, "%x", (unsigned int *)&buf->st_gid);
-       } else {
-               buf->st_uid = v9ses->uid;
-               buf->st_gid = v9ses->gid;
+       case O_RDWR:
+               ret = V9FS_ORDWR;
+               break;
        }
 
-       buf->st_uid = (unsigned short)-1;
-       buf->st_gid = (unsigned short)-1;
+       if (uflags & O_EXCL)
+               ret |= V9FS_OEXCL;
 
-       if (v9ses && v9ses->extended) {
-               if (mistat->n_uid != -1)
-                       sscanf(mistat->uid, "%x", (unsigned int *)&buf->st_uid);
+       if (uflags & O_TRUNC)
+               ret |= V9FS_OTRUNC;
 
-               if (mistat->n_gid != -1)
-                       sscanf(mistat->gid, "%x", (unsigned int *)&buf->st_gid);
-       }
+       if (uflags & O_APPEND)
+               ret |= V9FS_OAPPEND;
 
-       if (buf->st_uid == (unsigned short)-1)
-               buf->st_uid = v9ses->uid;
-       if (buf->st_gid == (unsigned short)-1)
-               buf->st_gid = v9ses->gid;
-
-       buf->st_mode = p9mode2unixmode(v9ses, mistat->mode);
-       if ((S_ISBLK(buf->st_mode)) || (S_ISCHR(buf->st_mode))) {
-               char type = 0;
-               int major = -1;
-               int minor = -1;
-               sscanf(mistat->extension, "%c %u %u", &type, &major, &minor);
-               switch (type) {
-               case 'c':
-                       buf->st_mode &= ~S_IFBLK;
-                       buf->st_mode |= S_IFCHR;
-                       break;
-               case 'b':
-                       break;
-               default:
-                       dprintk(DEBUG_ERROR, "Unknown special type %c (%s)\n",
-                               type, mistat->extension);
-               };
-               buf->st_rdev = MKDEV(major, minor);
-       } else
-               buf->st_rdev = 0;
+       return ret;
+}
 
-       buf->st_size = mistat->length;
+/**
+ * v9fs_blank_wstat - helper function to setup a 9P stat structure
+ * @v9ses: 9P session info (for determining extended mode)
+ * @wstat: structure to initialize
+ *
+ */
 
-       buf->st_blksize = sb->s_blocksize;
-       buf->st_blocks =
-           (buf->st_size + buf->st_blksize - 1) >> sb->s_blocksize_bits;
+static void
+v9fs_blank_wstat(struct v9fs_wstat *wstat)
+{
+       wstat->type = ~0;
+       wstat->dev = ~0;
+       wstat->qid.type = ~0;
+       wstat->qid.version = ~0;
+       *((long long *)&wstat->qid.path) = ~0;
+       wstat->mode = ~0;
+       wstat->atime = ~0;
+       wstat->mtime = ~0;
+       wstat->length = ~0;
+       wstat->name = NULL;
+       wstat->uid = NULL;
+       wstat->gid = NULL;
+       wstat->muid = NULL;
+       wstat->n_uid = ~0;
+       wstat->n_gid = ~0;
+       wstat->n_muid = ~0;
+       wstat->extension = NULL;
 }
 
 /**
@@ -242,7 +194,8 @@ v9fs_mistat2unix(struct v9fs_stat *mistat, struct stat *buf,
 
 struct inode *v9fs_get_inode(struct super_block *sb, int mode)
 {
-       struct inode *inode = NULL;
+       struct inode *inode;
+       struct v9fs_session_info *v9ses = sb->s_fs_info;
 
        dprintk(DEBUG_VFS, "super block: %p mode: %o\n", sb, mode);
 
@@ -255,24 +208,39 @@ struct inode *v9fs_get_inode(struct super_block *sb, int mode)
                inode->i_blocks = 0;
                inode->i_rdev = 0;
                inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME;
+               inode->i_mapping->a_ops = &v9fs_addr_operations;
 
                switch (mode & S_IFMT) {
                case S_IFIFO:
                case S_IFBLK:
                case S_IFCHR:
                case S_IFSOCK:
+                       if(!v9ses->extended) {
+                               dprintk(DEBUG_ERROR, "special files without extended mode\n");
+                               return ERR_PTR(-EINVAL);
+                       }
+                       init_special_inode(inode, inode->i_mode,
+                                          inode->i_rdev);
+                       break;
                case S_IFREG:
                        inode->i_op = &v9fs_file_inode_operations;
                        inode->i_fop = &v9fs_file_operations;
                        break;
+               case S_IFLNK:
+                       if(!v9ses->extended) {
+                               dprintk(DEBUG_ERROR, "extended modes used w/o 9P2000.u\n");
+                               return ERR_PTR(-EINVAL);
+                       }
+                       inode->i_op = &v9fs_symlink_inode_operations;
+                       break;
                case S_IFDIR:
                        inode->i_nlink++;
-                       inode->i_op = &v9fs_dir_inode_operations;
+                       if(v9ses->extended)
+                               inode->i_op = &v9fs_dir_inode_operations_ext;
+                       else
+                               inode->i_op = &v9fs_dir_inode_operations;
                        inode->i_fop = &v9fs_dir_operations;
                        break;
-               case S_IFLNK:
-                       inode->i_op = &v9fs_symlink_inode_operations;
-                       break;
                default:
                        dprintk(DEBUG_ERROR, "BAD mode 0x%x S_IFMT 0x%x\n",
                                mode, mode & S_IFMT);
@@ -285,158 +253,150 @@ struct inode *v9fs_get_inode(struct super_block *sb, int mode)
        return inode;
 }
 
-/**
- * v9fs_create - helper function to create files and directories
- * @dir: directory inode file is being created in
- * @file_dentry: dentry file is being created in
- * @perm: permissions file is being created with
- * @open_mode: resulting open mode for file ???
- *
- */
-
 static int
-v9fs_create(struct inode *dir,
-           struct dentry *file_dentry,
-           unsigned int perm, unsigned int open_mode)
+v9fs_create(struct v9fs_session_info *v9ses, u32 pfid, char *name, u32 perm,
+       u8 mode, char *extension, u32 *fidp, struct v9fs_qid *qid, u32 *iounit)
 {
-       struct v9fs_session_info *v9ses = v9fs_inode2v9ses(dir);
-       struct super_block *sb = dir->i_sb;
-       struct v9fs_fid *dirfid =
-           v9fs_fid_lookup(file_dentry->d_parent, FID_WALK);
-       struct v9fs_fid *fid = NULL;
-       struct inode *file_inode = NULL;
-       struct v9fs_fcall *fcall = NULL;
-       struct v9fs_qid qid;
-       struct stat newstat;
-       int dirfidnum = -1;
-       long newfid = -1;
-       int result = 0;
-       unsigned int iounit = 0;
-
-       perm = unixmode2p9mode(v9ses, perm);
-
-       dprintk(DEBUG_VFS, "dir: %p dentry: %p perm: %o mode: %o\n", dir,
-               file_dentry, perm, open_mode);
+       u32 fid;
+       int err;
+       struct v9fs_fcall *fcall;
 
-       if (!dirfid)
-               return -EBADF;
-
-       dirfidnum = dirfid->fid;
-       if (dirfidnum < 0) {
-               dprintk(DEBUG_ERROR, "No fid for the directory #%lu\n",
-                       dir->i_ino);
-               return -EBADF;
+       fid = v9fs_get_idpool(&v9ses->fidpool);
+       if (fid < 0) {
+               eprintk(KERN_WARNING, "no free fids available\n");
+               return -ENOSPC;
        }
 
-       if (file_dentry->d_inode) {
-               dprintk(DEBUG_ERROR,
-                       "Odd. There is an inode for dir %lu, name :%s:\n",
-                       dir->i_ino, file_dentry->d_name.name);
-               return -EEXIST;
+       err = v9fs_t_walk(v9ses, pfid, fid, NULL, &fcall);
+       if (err < 0) {
+               PRINT_FCALL_ERROR("clone error", fcall);
+               if (fcall && fcall->id == RWALK)
+                       goto clunk_fid;
+               else
+                       goto put_fid;
        }
+       kfree(fcall);
 
-       newfid = v9fs_get_idpool(&v9ses->fidpool);
-       if (newfid < 0) {
-               eprintk(KERN_WARNING, "no free fids available\n");
-               return -ENOSPC;
+       err = v9fs_t_create(v9ses, fid, name, perm, mode, extension, &fcall);
+       if (err < 0) {
+               PRINT_FCALL_ERROR("create fails", fcall);
+               goto clunk_fid;
        }
 
-       result = v9fs_t_walk(v9ses, dirfidnum, newfid, NULL, &fcall);
-       if (result < 0) {
-               dprintk(DEBUG_ERROR, "clone error: %s\n", FCALL_ERROR(fcall));
-               v9fs_put_idpool(newfid, &v9ses->fidpool);
-               newfid = 0;
-               goto CleanUpFid;
-       }
+       if (iounit)
+               *iounit = fcall->params.rcreate.iounit;
+
+       if (qid)
+               *qid = fcall->params.rcreate.qid;
+
+       if (fidp)
+               *fidp = fid;
 
        kfree(fcall);
+       return 0;
 
-       result = v9fs_t_create(v9ses, newfid, (char *)file_dentry->d_name.name,
-                              perm, open_mode, &fcall);
-       if (result < 0) {
-               dprintk(DEBUG_ERROR, "create fails: %s(%d)\n",
-                       FCALL_ERROR(fcall), result);
+clunk_fid:
+       v9fs_t_clunk(v9ses, fid);
+       fid = V9FS_NOFID;
 
-               goto CleanUpFid;
-       }
+put_fid:
+       if (fid != V9FS_NOFID)
+               v9fs_put_idpool(fid, &v9ses->fidpool);
 
-       iounit = fcall->params.rcreate.iounit;
-       qid = fcall->params.rcreate.qid;
        kfree(fcall);
+       return err;
+}
 
-       fid = v9fs_fid_create(file_dentry);
-       if (!fid) {
-               result = -ENOMEM;
-               goto CleanUpFid;
+static struct v9fs_fid*
+v9fs_clone_walk(struct v9fs_session_info *v9ses, u32 fid, struct dentry *dentry)
+{
+       int err;
+       u32 nfid;
+       struct v9fs_fid *ret;
+       struct v9fs_fcall *fcall;
+
+       nfid = v9fs_get_idpool(&v9ses->fidpool);
+       if (nfid < 0) {
+               eprintk(KERN_WARNING, "no free fids available\n");
+               return ERR_PTR(-ENOSPC);
        }
 
-       fid->fid = newfid;
-       fid->fidopen = 0;
-       fid->fidcreate = 1;
-       fid->qid = qid;
-       fid->iounit = iounit;
-       fid->rdir_pos = 0;
-       fid->rdir_fcall = NULL;
-       fid->v9ses = v9ses;
+       err = v9fs_t_walk(v9ses, fid, nfid, (char *) dentry->d_name.name,
+               &fcall);
 
-       if ((perm & V9FS_DMSYMLINK) || (perm & V9FS_DMLINK) ||
-           (perm & V9FS_DMNAMEDPIPE) || (perm & V9FS_DMSOCKET) ||
-           (perm & V9FS_DMDEVICE))
-               return 0;
+       if (err < 0) {
+               if (fcall && fcall->id == RWALK)
+                       goto clunk_fid;
 
-       result = v9fs_t_stat(v9ses, newfid, &fcall);
-       if (result < 0) {
-               dprintk(DEBUG_ERROR, "stat error: %s(%d)\n", FCALL_ERROR(fcall),
-                       result);
-               goto CleanUpFid;
+               PRINT_FCALL_ERROR("walk error", fcall);
+               v9fs_put_idpool(nfid, &v9ses->fidpool);
+               goto error;
        }
 
-       v9fs_mistat2unix(fcall->params.rstat.stat, &newstat, sb);
+       kfree(fcall);
+       fcall = NULL;
+       ret = v9fs_fid_create(v9ses, nfid);
+       if (!ret) {
+               err = -ENOMEM;
+               goto clunk_fid;
+       }
 
-       file_inode = v9fs_get_inode(sb, newstat.st_mode);
-       if ((!file_inode) || IS_ERR(file_inode)) {
-               dprintk(DEBUG_ERROR, "create inode failed\n");
-               result = -EBADF;
-               goto CleanUpFid;
+       err = v9fs_fid_insert(ret, dentry);
+       if (err < 0) {
+               v9fs_fid_destroy(ret);
+               goto clunk_fid;
        }
 
-       v9fs_mistat2inode(fcall->params.rstat.stat, file_inode, sb);
+       return ret;
+
+clunk_fid:
+       v9fs_t_clunk(v9ses, nfid);
+
+error:
        kfree(fcall);
-       d_instantiate(file_dentry, file_inode);
-
-       if (perm & V9FS_DMDIR) {
-               if (v9fs_t_clunk(v9ses, newfid, &fcall))
-                       dprintk(DEBUG_ERROR, "clunk for mkdir failed: %s\n",
-                               FCALL_ERROR(fcall));
-
-               v9fs_put_idpool(newfid, &v9ses->fidpool);
-               kfree(fcall);
-               fid->fidopen = 0;
-               fid->fidcreate = 0;
-               d_drop(file_dentry);
+       return ERR_PTR(err);
+}
+
+static struct inode *
+v9fs_inode_from_fid(struct v9fs_session_info *v9ses, u32 fid,
+       struct super_block *sb)
+{
+       int err, umode;
+       struct inode *ret;
+       struct v9fs_fcall *fcall;
+
+       ret = NULL;
+       err = v9fs_t_stat(v9ses, fid, &fcall);
+       if (err) {
+               PRINT_FCALL_ERROR("stat error", fcall);
+               goto error;
        }
 
-       return 0;
+       umode = p9mode2unixmode(v9ses, fcall->params.rstat.stat.mode);
+       ret = v9fs_get_inode(sb, umode);
+       if (IS_ERR(ret)) {
+               err = PTR_ERR(ret);
+               ret = NULL;
+               goto error;
+       }
 
-      CleanUpFid:
+       v9fs_stat2inode(&fcall->params.rstat.stat, ret, sb);
        kfree(fcall);
+       return ret;
 
-       if (newfid) {
-               if (v9fs_t_clunk(v9ses, newfid, &fcall))
-                       dprintk(DEBUG_ERROR, "clunk failed: %s\n",
-                               FCALL_ERROR(fcall));
+error:
+       kfree(fcall);
+       if (ret)
+               iput(ret);
 
-               v9fs_put_idpool(newfid, &v9ses->fidpool);
-               kfree(fcall);
-       }
-       return result;
+       return ERR_PTR(err);
 }
 
 /**
  * v9fs_remove - helper function to remove files and directories
- * @inode: directory inode that is being deleted
- * @dentry:  dentry that is being deleted
- * @rmdir: where we are a file or a directory
+ * @dir: directory inode that is being deleted
+ * @file:  dentry that is being deleted
+ * @rmdir: removing a directory
  *
  */
 
@@ -456,7 +416,7 @@ static int v9fs_remove(struct inode *dir, struct dentry *file, int rmdir)
        file_inode = file->d_inode;
        sb = file_inode->i_sb;
        v9ses = v9fs_inode2v9ses(file_inode);
-       v9fid = v9fs_fid_lookup(file, FID_OP);
+       v9fid = v9fs_fid_lookup(file);
 
        if (!v9fid) {
                dprintk(DEBUG_ERROR,
@@ -472,10 +432,9 @@ static int v9fs_remove(struct inode *dir, struct dentry *file, int rmdir)
        }
 
        result = v9fs_t_remove(v9ses, fid, &fcall);
-       if (result < 0)
-               dprintk(DEBUG_ERROR, "remove of file fails: %s(%d)\n",
-                       FCALL_ERROR(fcall), result);
-       else {
+       if (result < 0) {
+               PRINT_FCALL_ERROR("remove fails", fcall);
+       } else {
                v9fs_put_idpool(fid, &v9ses->fidpool);
                v9fs_fid_destroy(v9fid);
        }
@@ -484,33 +443,155 @@ static int v9fs_remove(struct inode *dir, struct dentry *file, int rmdir)
        return result;
 }
 
+static int
+v9fs_open_created(struct inode *inode, struct file *file)
+{
+       return 0;
+}
+
 /**
  * v9fs_vfs_create - VFS hook to create files
  * @inode: directory inode that is being deleted
  * @dentry:  dentry that is being deleted
- * @perm: create permissions
+ * @mode: create permissions
  * @nd: path information
  *
  */
 
 static int
-v9fs_vfs_create(struct inode *inode, struct dentry *dentry, int perm,
+v9fs_vfs_create(struct inode *dir, struct dentry *dentry, int mode,
                struct nameidata *nd)
 {
-       return v9fs_create(inode, dentry, perm, O_RDWR);
+       int err;
+       u32 fid, perm, iounit;
+       int flags;
+       struct v9fs_session_info *v9ses;
+       struct v9fs_fid *dfid, *vfid, *ffid;
+       struct inode *inode;
+       struct v9fs_qid qid;
+       struct file *filp;
+
+       inode = NULL;
+       vfid = NULL;
+       v9ses = v9fs_inode2v9ses(dir);
+       dfid = v9fs_fid_lookup(dentry->d_parent);
+       perm = unixmode2p9mode(v9ses, mode);
+
+       if (nd && nd->flags & LOOKUP_OPEN)
+               flags = nd->intent.open.flags - 1;
+       else
+               flags = O_RDWR;
+
+       err = v9fs_create(v9ses, dfid->fid, (char *) dentry->d_name.name,
+               perm, v9fs_uflags2omode(flags), NULL, &fid, &qid, &iounit);
+
+       if (err)
+               goto error;
+
+       vfid = v9fs_clone_walk(v9ses, dfid->fid, dentry);
+       if (IS_ERR(vfid)) {
+               err = PTR_ERR(vfid);
+               vfid = NULL;
+               goto error;
+       }
+
+       inode = v9fs_inode_from_fid(v9ses, vfid->fid, dir->i_sb);
+       if (IS_ERR(inode)) {
+               err = PTR_ERR(inode);
+               inode = NULL;
+               goto error;
+       }
+
+       dentry->d_op = &v9fs_dentry_operations;
+       d_instantiate(dentry, inode);
+
+       if (nd && nd->flags & LOOKUP_OPEN) {
+               ffid = v9fs_fid_create(v9ses, fid);
+               if (!ffid)
+                       return -ENOMEM;
+
+               filp = lookup_instantiate_filp(nd, dentry, v9fs_open_created);
+               if (IS_ERR(filp)) {
+                       v9fs_fid_destroy(ffid);
+                       return PTR_ERR(filp);
+               }
+
+               ffid->rdir_pos = 0;
+               ffid->rdir_fcall = NULL;
+               ffid->fidopen = 1;
+               ffid->iounit = iounit;
+               ffid->filp = filp;
+               filp->private_data = ffid;
+       }
+
+       return 0;
+
+error:
+       if (vfid)
+               v9fs_fid_destroy(vfid);
+
+       return err;
 }
 
 /**
  * v9fs_vfs_mkdir - VFS mkdir hook to create a directory
- * @i:  inode that is being unlinked
+ * @inode:  inode that is being unlinked
  * @dentry: dentry that is being unlinked
  * @mode: mode for new directory
  *
  */
 
-static int v9fs_vfs_mkdir(struct inode *inode, struct dentry *dentry, int mode)
+static int v9fs_vfs_mkdir(struct inode *dir, struct dentry *dentry, int mode)
 {
-       return v9fs_create(inode, dentry, mode | S_IFDIR, O_RDONLY);
+       int err;
+       u32 fid, perm;
+       struct v9fs_session_info *v9ses;
+       struct v9fs_fid *dfid, *vfid;
+       struct inode *inode;
+
+       inode = NULL;
+       vfid = NULL;
+       v9ses = v9fs_inode2v9ses(dir);
+       dfid = v9fs_fid_lookup(dentry->d_parent);
+       perm = unixmode2p9mode(v9ses, mode | S_IFDIR);
+
+       err = v9fs_create(v9ses, dfid->fid, (char *) dentry->d_name.name,
+               perm, V9FS_OREAD, NULL, &fid, NULL, NULL);
+
+       if (err) {
+               dprintk(DEBUG_ERROR, "create error %d\n", err);
+               goto error;
+       }
+
+       err = v9fs_t_clunk(v9ses, fid);
+       if (err) {
+               dprintk(DEBUG_ERROR, "clunk error %d\n", err);
+               goto error;
+       }
+
+       vfid = v9fs_clone_walk(v9ses, dfid->fid, dentry);
+       if (IS_ERR(vfid)) {
+               err = PTR_ERR(vfid);
+               vfid = NULL;
+               goto error;
+       }
+
+       inode = v9fs_inode_from_fid(v9ses, vfid->fid, dir->i_sb);
+       if (IS_ERR(inode)) {
+               err = PTR_ERR(inode);
+               inode = NULL;
+               goto error;
+       }
+
+       dentry->d_op = &v9fs_dentry_operations;
+       d_instantiate(dentry, inode);
+       return 0;
+
+error:
+       if (vfid)
+               v9fs_fid_destroy(vfid);
+
+       return err;
 }
 
 /**
@@ -530,17 +611,17 @@ static struct dentry *v9fs_vfs_lookup(struct inode *dir, struct dentry *dentry,
        struct v9fs_fid *fid;
        struct inode *inode;
        struct v9fs_fcall *fcall = NULL;
-       struct stat newstat;
        int dirfidnum = -1;
        int newfid = -1;
        int result = 0;
 
        dprintk(DEBUG_VFS, "dir: %p dentry: (%s) %p nameidata: %p\n",
-               dir, dentry->d_iname, dentry, nameidata);
+               dir, dentry->d_name.name, dentry, nameidata);
 
        sb = dir->i_sb;
        v9ses = v9fs_inode2v9ses(dir);
-       dirfid = v9fs_fid_lookup(dentry->d_parent, FID_WALK);
+       dentry->d_op = &v9fs_dentry_operations;
+       dirfid = v9fs_fid_lookup(dentry->d_parent);
 
        if (!dirfid) {
                dprintk(DEBUG_ERROR, "no dirfid\n");
@@ -561,21 +642,27 @@ static struct dentry *v9fs_vfs_lookup(struct inode *dir, struct dentry *dentry,
                return ERR_PTR(-ENOSPC);
        }
 
-       result =
-           v9fs_t_walk(v9ses, dirfidnum, newfid, (char *)dentry->d_name.name,
-                       NULL);
+       result = v9fs_t_walk(v9ses, dirfidnum, newfid,
+               (char *)dentry->d_name.name, &fcall);
+
        if (result < 0) {
-               v9fs_put_idpool(newfid, &v9ses->fidpool);
+               if (fcall && fcall->id == RWALK)
+                       v9fs_t_clunk(v9ses, newfid);
+               else
+                       v9fs_put_idpool(newfid, &v9ses->fidpool);
+
                if (result == -ENOENT) {
                        d_add(dentry, NULL);
-                       dprintk(DEBUG_ERROR,
+                       dprintk(DEBUG_VFS,
                                "Return negative dentry %p count %d\n",
                                dentry, atomic_read(&dentry->d_count));
+                       kfree(fcall);
                        return NULL;
                }
                dprintk(DEBUG_ERROR, "walk error:%d\n", result);
                goto FreeFcall;
        }
+       kfree(fcall);
 
        result = v9fs_t_stat(v9ses, newfid, &fcall);
        if (result < 0) {
@@ -583,8 +670,8 @@ static struct dentry *v9fs_vfs_lookup(struct inode *dir, struct dentry *dentry,
                goto FreeFcall;
        }
 
-       v9fs_mistat2unix(fcall->params.rstat.stat, &newstat, sb);
-       inode = v9fs_get_inode(sb, newstat.st_mode);
+       inode = v9fs_get_inode(sb, p9mode2unixmode(v9ses,
+               fcall->params.rstat.stat.mode));
 
        if (IS_ERR(inode) && (PTR_ERR(inode) == -ENOSPC)) {
                eprintk(KERN_WARNING, "inode alloc failes, returns %ld\n",
@@ -594,22 +681,21 @@ static struct dentry *v9fs_vfs_lookup(struct inode *dir, struct dentry *dentry,
                goto FreeFcall;
        }
 
-       inode->i_ino = v9fs_qid2ino(&fcall->params.rstat.stat->qid);
+       inode->i_ino = v9fs_qid2ino(&fcall->params.rstat.stat.qid);
 
-       fid = v9fs_fid_create(dentry);
+       fid = v9fs_fid_create(v9ses, newfid);
        if (fid == NULL) {
                dprintk(DEBUG_ERROR, "couldn't insert\n");
                result = -ENOMEM;
                goto FreeFcall;
        }
 
-       fid->fid = newfid;
-       fid->fidopen = 0;
-       fid->v9ses = v9ses;
-       fid->qid = fcall->params.rstat.stat->qid;
+       result = v9fs_fid_insert(fid, dentry);
+       if (result < 0)
+               goto FreeFcall;
 
-       dentry->d_op = &v9fs_dentry_operations;
-       v9fs_mistat2inode(fcall->params.rstat.stat, inode, inode->i_sb);
+       fid->qid = fcall->params.rstat.stat.qid;
+       v9fs_stat2inode(&fcall->params.rstat.stat, inode, inode->i_sb);
 
        d_add(dentry, inode);
        kfree(fcall);
@@ -624,7 +710,7 @@ static struct dentry *v9fs_vfs_lookup(struct inode *dir, struct dentry *dentry,
 /**
  * v9fs_vfs_unlink - VFS unlink hook to delete an inode
  * @i:  inode that is being unlinked
- * @dentry: dentry that is being unlinked
+ * @d: dentry that is being unlinked
  *
  */
 
@@ -636,7 +722,7 @@ static int v9fs_vfs_unlink(struct inode *i, struct dentry *d)
 /**
  * v9fs_vfs_rmdir - VFS unlink hook to delete a directory
  * @i:  inode that is being unlinked
- * @dentry: dentry that is being unlinked
+ * @d: dentry that is being unlinked
  *
  */
 
@@ -660,12 +746,12 @@ v9fs_vfs_rename(struct inode *old_dir, struct dentry *old_dentry,
 {
        struct inode *old_inode = old_dentry->d_inode;
        struct v9fs_session_info *v9ses = v9fs_inode2v9ses(old_inode);
-       struct v9fs_fid *oldfid = v9fs_fid_lookup(old_dentry, FID_WALK);
+       struct v9fs_fid *oldfid = v9fs_fid_lookup(old_dentry);
        struct v9fs_fid *olddirfid =
-           v9fs_fid_lookup(old_dentry->d_parent, FID_WALK);
+           v9fs_fid_lookup(old_dentry->d_parent);
        struct v9fs_fid *newdirfid =
-           v9fs_fid_lookup(new_dentry->d_parent, FID_WALK);
-       struct v9fs_stat *mistat = kmalloc(v9ses->maxdata, GFP_KERNEL);
+           v9fs_fid_lookup(new_dentry->d_parent);
+       struct v9fs_wstat wstat;
        struct v9fs_fcall *fcall = NULL;
        int fid = -1;
        int olddirfidnum = -1;
@@ -697,33 +783,22 @@ v9fs_vfs_rename(struct inode *old_dir, struct dentry *old_dentry,
                goto FreeFcallnBail;
        }
 
-       v9fs_blank_mistat(v9ses, mistat);
-
-       strcpy(mistat->data + 1, v9ses->name);
-       mistat->name = mistat->data + 1 + strlen(v9ses->name);
-
-       if (new_dentry->d_name.len >
-           (v9ses->maxdata - strlen(v9ses->name) - sizeof(struct v9fs_stat))) {
-               dprintk(DEBUG_ERROR, "new name too long\n");
-               goto FreeFcallnBail;
-       }
+       v9fs_blank_wstat(&wstat);
+       wstat.muid = v9ses->name;
+       wstat.name = (char *) new_dentry->d_name.name;
 
-       strcpy(mistat->name, new_dentry->d_name.name);
-       retval = v9fs_t_wstat(v9ses, fid, mistat, &fcall);
+       retval = v9fs_t_wstat(v9ses, fid, &wstat, &fcall);
 
       FreeFcallnBail:
-       kfree(mistat);
-
        if (retval < 0)
-               dprintk(DEBUG_ERROR, "v9fs_t_wstat error: %s\n",
-                       FCALL_ERROR(fcall));
+               PRINT_FCALL_ERROR("wstat error", fcall);
 
        kfree(fcall);
        return retval;
 }
 
 /**
- * v9fs_vfs_getattr - retreive file metadata
+ * v9fs_vfs_getattr - retrieve file metadata
  * @mnt - mount information
  * @dentry - file to get attributes on
  * @stat - metadata structure to populate
@@ -736,7 +811,7 @@ v9fs_vfs_getattr(struct vfsmount *mnt, struct dentry *dentry,
 {
        struct v9fs_fcall *fcall = NULL;
        struct v9fs_session_info *v9ses = v9fs_inode2v9ses(dentry->d_inode);
-       struct v9fs_fid *fid = v9fs_fid_lookup(dentry, FID_OP);
+       struct v9fs_fid *fid = v9fs_fid_lookup(dentry);
        int err = -EPERM;
 
        dprintk(DEBUG_VFS, "dentry: %p\n", dentry);
@@ -751,7 +826,7 @@ v9fs_vfs_getattr(struct vfsmount *mnt, struct dentry *dentry,
        if (err < 0)
                dprintk(DEBUG_ERROR, "stat error\n");
        else {
-               v9fs_mistat2inode(fcall->params.rstat.stat, dentry->d_inode,
+               v9fs_stat2inode(&fcall->params.rstat.stat, dentry->d_inode,
                                  dentry->d_inode->i_sb);
                generic_fillattr(dentry->d_inode, stat);
        }
@@ -770,111 +845,46 @@ v9fs_vfs_getattr(struct vfsmount *mnt, struct dentry *dentry,
 static int v9fs_vfs_setattr(struct dentry *dentry, struct iattr *iattr)
 {
        struct v9fs_session_info *v9ses = v9fs_inode2v9ses(dentry->d_inode);
-       struct v9fs_fid *fid = v9fs_fid_lookup(dentry, FID_OP);
-       struct v9fs_stat *mistat = kmalloc(v9ses->maxdata, GFP_KERNEL);
+       struct v9fs_fid *fid = v9fs_fid_lookup(dentry);
        struct v9fs_fcall *fcall = NULL;
+       struct v9fs_wstat wstat;
        int res = -EPERM;
 
        dprintk(DEBUG_VFS, "\n");
+
        if (!fid) {
                dprintk(DEBUG_ERROR,
                        "Couldn't find fid associated with dentry\n");
                return -EBADF;
        }
 
-       if (!mistat)
-               return -ENOMEM;
-
-       v9fs_blank_mistat(v9ses, mistat);
+       v9fs_blank_wstat(&wstat);
        if (iattr->ia_valid & ATTR_MODE)
-               mistat->mode = unixmode2p9mode(v9ses, iattr->ia_mode);
+               wstat.mode = unixmode2p9mode(v9ses, iattr->ia_mode);
 
        if (iattr->ia_valid & ATTR_MTIME)
-               mistat->mtime = iattr->ia_mtime.tv_sec;
+               wstat.mtime = iattr->ia_mtime.tv_sec;
 
        if (iattr->ia_valid & ATTR_ATIME)
-               mistat->atime = iattr->ia_atime.tv_sec;
+               wstat.atime = iattr->ia_atime.tv_sec;
 
        if (iattr->ia_valid & ATTR_SIZE)
-               mistat->length = iattr->ia_size;
+               wstat.length = iattr->ia_size;
 
        if (v9ses->extended) {
-               char *uid = kmalloc(strlen(mistat->uid), GFP_KERNEL);
-               char *gid = kmalloc(strlen(mistat->gid), GFP_KERNEL);
-               char *muid = kmalloc(strlen(mistat->muid), GFP_KERNEL);
-               char *name = kmalloc(strlen(mistat->name), GFP_KERNEL);
-               char *extension = kmalloc(strlen(mistat->extension),
-                                         GFP_KERNEL);
-
-               if ((!uid) || (!gid) || (!muid) || (!name) || (!extension)) {
-                       kfree(uid);
-                       kfree(gid);
-                       kfree(muid);
-                       kfree(name);
-                       kfree(extension);
-
-                       return -ENOMEM;
-               }
-
-               strcpy(uid, mistat->uid);
-               strcpy(gid, mistat->gid);
-               strcpy(muid, mistat->muid);
-               strcpy(name, mistat->name);
-               strcpy(extension, mistat->extension);
-
-               if (iattr->ia_valid & ATTR_UID) {
-                       if (strlen(uid) != 8) {
-                               dprintk(DEBUG_ERROR, "uid strlen is %u not 8\n",
-                                       (unsigned int)strlen(uid));
-                               sprintf(uid, "%08x", iattr->ia_uid);
-                       } else {
-                               kfree(uid);
-                               uid = kmalloc(9, GFP_KERNEL);
-                       }
+               if (iattr->ia_valid & ATTR_UID)
+                       wstat.n_uid = iattr->ia_uid;
 
-                       sprintf(uid, "%08x", iattr->ia_uid);
-                       mistat->n_uid = iattr->ia_uid;
-               }
-
-               if (iattr->ia_valid & ATTR_GID) {
-                       if (strlen(gid) != 8)
-                               dprintk(DEBUG_ERROR, "gid strlen is %u not 8\n",
-                                       (unsigned int)strlen(gid));
-                       else {
-                               kfree(gid);
-                               gid = kmalloc(9, GFP_KERNEL);
-                       }
-
-                       sprintf(gid, "%08x", iattr->ia_gid);
-                       mistat->n_gid = iattr->ia_gid;
-               }
-
-               mistat->uid = mistat->data;
-               strcpy(mistat->uid, uid);
-               mistat->gid = mistat->data + strlen(uid) + 1;
-               strcpy(mistat->gid, gid);
-               mistat->muid = mistat->gid + strlen(gid) + 1;
-               strcpy(mistat->muid, muid);
-               mistat->name = mistat->muid + strlen(muid) + 1;
-               strcpy(mistat->name, name);
-               mistat->extension = mistat->name + strlen(name) + 1;
-               strcpy(mistat->extension, extension);
-
-               kfree(uid);
-               kfree(gid);
-               kfree(muid);
-               kfree(name);
-               kfree(extension);
+               if (iattr->ia_valid & ATTR_GID)
+                       wstat.n_gid = iattr->ia_gid;
        }
 
-       res = v9fs_t_wstat(v9ses, fid->fid, mistat, &fcall);
+       res = v9fs_t_wstat(v9ses, fid->fid, &wstat, &fcall);
 
        if (res < 0)
-               dprintk(DEBUG_ERROR, "wstat error: %s\n", FCALL_ERROR(fcall));
+               PRINT_FCALL_ERROR("wstat error", fcall);
 
-       kfree(mistat);
        kfree(fcall);
-
        if (res >= 0)
                res = inode_setattr(dentry->d_inode, iattr);
 
@@ -882,51 +892,47 @@ static int v9fs_vfs_setattr(struct dentry *dentry, struct iattr *iattr)
 }
 
 /**
- * v9fs_mistat2inode - populate an inode structure with mistat info
- * @mistat: Plan 9 metadata (mistat) structure
+ * v9fs_stat2inode - populate an inode structure with mistat info
+ * @stat: Plan 9 metadata (mistat) structure
  * @inode: inode to populate
  * @sb: superblock of filesystem
  *
  */
 
 void
-v9fs_mistat2inode(struct v9fs_stat *mistat, struct inode *inode,
-                 struct super_block *sb)
+v9fs_stat2inode(struct v9fs_stat *stat, struct inode *inode,
+       struct super_block *sb)
 {
+       int n;
+       char ext[32];
        struct v9fs_session_info *v9ses = sb->s_fs_info;
 
        inode->i_nlink = 1;
 
-       inode->i_atime.tv_sec = mistat->atime;
-       inode->i_mtime.tv_sec = mistat->mtime;
-       inode->i_ctime.tv_sec = mistat->mtime;
+       inode->i_atime.tv_sec = stat->atime;
+       inode->i_mtime.tv_sec = stat->mtime;
+       inode->i_ctime.tv_sec = stat->mtime;
 
-       inode->i_uid = -1;
-       inode->i_gid = -1;
+       inode->i_uid = v9ses->uid;
+       inode->i_gid = v9ses->gid;
 
        if (v9ses->extended) {
-               /* TODO: string to uid mapping via user-space daemon */
-               inode->i_uid = mistat->n_uid;
-               inode->i_gid = mistat->n_gid;
-
-               if (mistat->n_uid == -1)
-                       sscanf(mistat->uid, "%x", &inode->i_uid);
-
-               if (mistat->n_gid == -1)
-                       sscanf(mistat->gid, "%x", &inode->i_gid);
+               inode->i_uid = stat->n_uid;
+               inode->i_gid = stat->n_gid;
        }
 
-       if (inode->i_uid == -1)
-               inode->i_uid = v9ses->uid;
-       if (inode->i_gid == -1)
-               inode->i_gid = v9ses->gid;
-
-       inode->i_mode = p9mode2unixmode(v9ses, mistat->mode);
+       inode->i_mode = p9mode2unixmode(v9ses, stat->mode);
        if ((S_ISBLK(inode->i_mode)) || (S_ISCHR(inode->i_mode))) {
                char type = 0;
                int major = -1;
                int minor = -1;
-               sscanf(mistat->extension, "%c %u %u", &type, &major, &minor);
+
+               n = stat->extension.len;
+               if (n > sizeof(ext)-1)
+                       n = sizeof(ext)-1;
+               memmove(ext, stat->extension.str, n);
+               ext[n] = 0;
+               sscanf(ext, "%c %u %u", &type, &major, &minor);
                switch (type) {
                case 'c':
                        inode->i_mode &= ~S_IFBLK;
@@ -935,14 +941,14 @@ v9fs_mistat2inode(struct v9fs_stat *mistat, struct inode *inode,
                case 'b':
                        break;
                default:
-                       dprintk(DEBUG_ERROR, "Unknown special type %c (%s)\n",
-                               type, mistat->extension);
+                       dprintk(DEBUG_ERROR, "Unknown special type %c (%.*s)\n",
+                               type, stat->extension.len, stat->extension.str);
                };
                inode->i_rdev = MKDEV(major, minor);
        } else
                inode->i_rdev = 0;
 
-       inode->i_size = mistat->length;
+       inode->i_size = stat->length;
 
        inode->i_blksize = sb->s_blocksize;
        inode->i_blocks =
@@ -970,77 +976,9 @@ ino_t v9fs_qid2ino(struct v9fs_qid *qid)
 }
 
 /**
- * v9fs_vfs_symlink - helper function to create symlinks
- * @dir: directory inode containing symlink
- * @dentry: dentry for symlink
- * @symname: symlink data
- *
- * See 9P2000.u RFC for more information
- *
- */
-
-static int
-v9fs_vfs_symlink(struct inode *dir, struct dentry *dentry, const char *symname)
-{
-       int retval = -EPERM;
-       struct v9fs_fid *newfid;
-       struct v9fs_session_info *v9ses = v9fs_inode2v9ses(dir);
-       struct super_block *sb = dir ? dir->i_sb : NULL;
-       struct v9fs_fcall *fcall = NULL;
-       struct v9fs_stat *mistat = kmalloc(v9ses->maxdata, GFP_KERNEL);
-
-       dprintk(DEBUG_VFS, " %lu,%s,%s\n", dir->i_ino, dentry->d_name.name,
-               symname);
-
-       if ((!dentry) || (!sb) || (!v9ses)) {
-               dprintk(DEBUG_ERROR, "problem with arguments\n");
-               return -EBADF;
-       }
-
-       if (!v9ses->extended) {
-               dprintk(DEBUG_ERROR, "not extended\n");
-               goto FreeFcall;
-       }
-
-       /* issue a create */
-       retval = v9fs_create(dir, dentry, S_IFLNK, 0);
-       if (retval != 0)
-               goto FreeFcall;
-
-       newfid = v9fs_fid_lookup(dentry, FID_OP);
-
-       /* issue a twstat */
-       v9fs_blank_mistat(v9ses, mistat);
-       strcpy(mistat->data + 1, symname);
-       mistat->extension = mistat->data + 1;
-       retval = v9fs_t_wstat(v9ses, newfid->fid, mistat, &fcall);
-       if (retval < 0) {
-               dprintk(DEBUG_ERROR, "v9fs_t_wstat error: %s\n",
-                       FCALL_ERROR(fcall));
-               goto FreeFcall;
-       }
-
-       kfree(fcall);
-
-       if (v9fs_t_clunk(v9ses, newfid->fid, &fcall)) {
-               dprintk(DEBUG_ERROR, "clunk for symlink failed: %s\n",
-                       FCALL_ERROR(fcall));
-               goto FreeFcall;
-       }
-
-       d_drop(dentry);         /* FID - will this also clunk? */
-
-      FreeFcall:
-       kfree(mistat);
-       kfree(fcall);
-
-       return retval;
-}
-
-/**
  * v9fs_readlink - read a symlink's location (internal version)
  * @dentry: dentry for symlink
- * @buf: buffer to load symlink location into
+ * @buffer: buffer to load symlink location into
  * @buflen: length of buffer
  *
  */
@@ -1051,7 +989,7 @@ static int v9fs_readlink(struct dentry *dentry, char *buffer, int buflen)
 
        struct v9fs_fcall *fcall = NULL;
        struct v9fs_session_info *v9ses = v9fs_inode2v9ses(dentry->d_inode);
-       struct v9fs_fid *fid = v9fs_fid_lookup(dentry, FID_OP);
+       struct v9fs_fid *fid = v9fs_fid_lookup(dentry);
 
        if (!fid) {
                dprintk(DEBUG_ERROR, "could not resolve fid from dentry\n");
@@ -1076,17 +1014,20 @@ static int v9fs_readlink(struct dentry *dentry, char *buffer, int buflen)
        if (!fcall)
                return -EIO;
 
-       if (!(fcall->params.rstat.stat->mode & V9FS_DMSYMLINK)) {
+       if (!(fcall->params.rstat.stat.mode & V9FS_DMSYMLINK)) {
                retval = -EINVAL;
                goto FreeFcall;
        }
 
        /* copy extension buffer into buffer */
-       if (strlen(fcall->params.rstat.stat->extension) < buflen)
-               buflen = strlen(fcall->params.rstat.stat->extension);
+       if (fcall->params.rstat.stat.extension.len < buflen)
+               buflen = fcall->params.rstat.stat.extension.len + 1;
 
-       memcpy(buffer, fcall->params.rstat.stat->extension, buflen + 1);
+       memmove(buffer, fcall->params.rstat.stat.extension.str, buflen - 1);
+       buffer[buflen-1] = 0;
 
+       dprintk(DEBUG_ERROR, "%s -> %.*s (%s)\n", dentry->d_name.name, fcall->params.rstat.stat.extension.len,
+               fcall->params.rstat.stat.extension.str, buffer);
        retval = buflen;
 
       FreeFcall:
@@ -1110,8 +1051,11 @@ static int v9fs_vfs_readlink(struct dentry *dentry, char __user * buffer,
        int ret;
        char *link = __getname();
 
-       if (strlen(link) < buflen)
-               buflen = strlen(link);
+       if (unlikely(!link))
+               return -ENOMEM;
+
+       if (buflen > PATH_MAX)
+               buflen = PATH_MAX;
 
        dprintk(DEBUG_VFS, " dentry: %s (%p)\n", dentry->d_iname, dentry);
 
@@ -1125,7 +1069,7 @@ static int v9fs_vfs_readlink(struct dentry *dentry, char __user * buffer,
                }
        }
 
-       putname(link);
+       __putname(link);
        return retval;
 }
 
@@ -1146,10 +1090,10 @@ static void *v9fs_vfs_follow_link(struct dentry *dentry, struct nameidata *nd)
        if (!link)
                link = ERR_PTR(-ENOMEM);
        else {
-               len = v9fs_readlink(dentry, link, strlen(link));
+               len = v9fs_readlink(dentry, link, PATH_MAX);
 
                if (len < 0) {
-                       putname(link);
+                       __putname(link);
                        link = ERR_PTR(len);
                } else
                        link[len] = 0;
@@ -1172,14 +1116,89 @@ static void v9fs_vfs_put_link(struct dentry *dentry, struct nameidata *nd, void
 
        dprintk(DEBUG_VFS, " %s %s\n", dentry->d_name.name, s);
        if (!IS_ERR(s))
-               putname(s);
+               __putname(s);
+}
+
+static int v9fs_vfs_mkspecial(struct inode *dir, struct dentry *dentry,
+       int mode, const char *extension)
+{
+       int err;
+       u32 fid, perm;
+       struct v9fs_session_info *v9ses;
+       struct v9fs_fid *dfid, *vfid;
+       struct inode *inode;
+
+       inode = NULL;
+       vfid = NULL;
+       v9ses = v9fs_inode2v9ses(dir);
+       dfid = v9fs_fid_lookup(dentry->d_parent);
+       perm = unixmode2p9mode(v9ses, mode);
+
+       if (!v9ses->extended) {
+               dprintk(DEBUG_ERROR, "not extended\n");
+               return -EPERM;
+       }
+
+       err = v9fs_create(v9ses, dfid->fid, (char *) dentry->d_name.name,
+               perm, V9FS_OREAD, (char *) extension, &fid, NULL, NULL);
+
+       if (err)
+               goto error;
+
+       err = v9fs_t_clunk(v9ses, fid);
+       if (err)
+               goto error;
+
+       vfid = v9fs_clone_walk(v9ses, dfid->fid, dentry);
+       if (IS_ERR(vfid)) {
+               err = PTR_ERR(vfid);
+               vfid = NULL;
+               goto error;
+       }
+
+       inode = v9fs_inode_from_fid(v9ses, vfid->fid, dir->i_sb);
+       if (IS_ERR(inode)) {
+               err = PTR_ERR(inode);
+               inode = NULL;
+               goto error;
+       }
+
+       dentry->d_op = &v9fs_dentry_operations;
+       d_instantiate(dentry, inode);
+       return 0;
+
+error:
+       if (vfid)
+               v9fs_fid_destroy(vfid);
+
+       return err;
+
+}
+
+/**
+ * v9fs_vfs_symlink - helper function to create symlinks
+ * @dir: directory inode containing symlink
+ * @dentry: dentry for symlink
+ * @symname: symlink data
+ *
+ * See 9P2000.u RFC for more information
+ *
+ */
+
+static int
+v9fs_vfs_symlink(struct inode *dir, struct dentry *dentry, const char *symname)
+{
+       dprintk(DEBUG_VFS, " %lu,%s,%s\n", dir->i_ino, dentry->d_name.name,
+               symname);
+
+       return v9fs_vfs_mkspecial(dir, dentry, S_IFLNK, symname);
 }
 
 /**
  * v9fs_vfs_link - create a hardlink
  * @old_dentry: dentry for file to link to
  * @dir: inode destination for new link
- * @new_dentry: dentry for link
+ * @dentry: dentry for link
  *
  */
 
@@ -1191,64 +1210,27 @@ static int
 v9fs_vfs_link(struct dentry *old_dentry, struct inode *dir,
              struct dentry *dentry)
 {
-       int retval = -EPERM;
-       struct v9fs_session_info *v9ses = v9fs_inode2v9ses(dir);
-       struct v9fs_fcall *fcall = NULL;
-       struct v9fs_stat *mistat = kmalloc(v9ses->maxdata, GFP_KERNEL);
-       struct v9fs_fid *oldfid = v9fs_fid_lookup(old_dentry, FID_OP);
-       struct v9fs_fid *newfid = NULL;
-       char *symname = __getname();
+       int retval;
+       struct v9fs_fid *oldfid;
+       char *name;
 
        dprintk(DEBUG_VFS, " %lu,%s,%s\n", dir->i_ino, dentry->d_name.name,
                old_dentry->d_name.name);
 
-       if (!v9ses->extended) {
-               dprintk(DEBUG_ERROR, "not extended\n");
-               goto FreeMem;
-       }
-
-       /* get fid of old_dentry */
-       sprintf(symname, "hardlink(%d)\n", oldfid->fid);
-
-       /* issue a create */
-       retval = v9fs_create(dir, dentry, V9FS_DMLINK, 0);
-       if (retval != 0)
-               goto FreeMem;
-
-       newfid = v9fs_fid_lookup(dentry, FID_OP);
-       if (!newfid) {
-               dprintk(DEBUG_ERROR, "couldn't resolve fid from dentry\n");
-               goto FreeMem;
-       }
-
-       /* issue a twstat */
-       v9fs_blank_mistat(v9ses, mistat);
-       strcpy(mistat->data + 1, symname);
-       mistat->extension = mistat->data + 1;
-       retval = v9fs_t_wstat(v9ses, newfid->fid, mistat, &fcall);
-       if (retval < 0) {
-               dprintk(DEBUG_ERROR, "v9fs_t_wstat error: %s\n",
-                       FCALL_ERROR(fcall));
-               goto FreeMem;
-       }
-
-       kfree(fcall);
-
-       if (v9fs_t_clunk(v9ses, newfid->fid, &fcall)) {
-               dprintk(DEBUG_ERROR, "clunk for symlink failed: %s\n",
-                       FCALL_ERROR(fcall));
-               goto FreeMem;
+       oldfid = v9fs_fid_lookup(old_dentry);
+       if (!oldfid) {
+               dprintk(DEBUG_ERROR, "can't find oldfid\n");
+               return -EPERM;
        }
 
-       d_drop(dentry);         /* FID - will this also clunk? */
+       name = __getname();
+       if (unlikely(!name))
+               return -ENOMEM;
 
-       kfree(fcall);
-       fcall = NULL;
+       sprintf(name, "%d\n", oldfid->fid);
+       retval = v9fs_vfs_mkspecial(dir, dentry, V9FS_DMLINK, name);
+       __putname(name);
 
-      FreeMem:
-       kfree(mistat);
-       kfree(fcall);
-       putname(symname);
        return retval;
 }
 
@@ -1264,85 +1246,37 @@ v9fs_vfs_link(struct dentry *old_dentry, struct inode *dir,
 static int
 v9fs_vfs_mknod(struct inode *dir, struct dentry *dentry, int mode, dev_t rdev)
 {
-       int retval = -EPERM;
-       struct v9fs_fid *newfid;
-       struct v9fs_session_info *v9ses = v9fs_inode2v9ses(dir);
-       struct v9fs_fcall *fcall = NULL;
-       struct v9fs_stat *mistat = kmalloc(v9ses->maxdata, GFP_KERNEL);
-       char *symname = __getname();
+       int retval;
+       char *name;
 
        dprintk(DEBUG_VFS, " %lu,%s mode: %x MAJOR: %u MINOR: %u\n", dir->i_ino,
                dentry->d_name.name, mode, MAJOR(rdev), MINOR(rdev));
 
-       if (!new_valid_dev(rdev)) {
-               retval = -EINVAL;
-               goto FreeMem;
-       }
-
-       if (!v9ses->extended) {
-               dprintk(DEBUG_ERROR, "not extended\n");
-               goto FreeMem;
-       }
-
-       /* issue a create */
-       retval = v9fs_create(dir, dentry, mode, 0);
-
-       if (retval != 0)
-               goto FreeMem;
-
-       newfid = v9fs_fid_lookup(dentry, FID_OP);
-       if (!newfid) {
-               dprintk(DEBUG_ERROR, "coudn't resove fid from dentry\n");
-               retval = -EINVAL;
-               goto FreeMem;
-       }
+       if (!new_valid_dev(rdev))
+               return -EINVAL;
 
+       name = __getname();
+       if (!name)
+               return -ENOMEM;
        /* build extension */
        if (S_ISBLK(mode))
-               sprintf(symname, "b %u %u", MAJOR(rdev), MINOR(rdev));
+               sprintf(name, "b %u %u", MAJOR(rdev), MINOR(rdev));
        else if (S_ISCHR(mode))
-               sprintf(symname, "c %u %u", MAJOR(rdev), MINOR(rdev));
-       else if (S_ISFIFO(mode)) ;      /* DO NOTHING */
+               sprintf(name, "c %u %u", MAJOR(rdev), MINOR(rdev));
+       else if (S_ISFIFO(mode))
+               *name = 0;
        else {
-               retval = -EINVAL;
-               goto FreeMem;
+               __putname(name);
+               return -EINVAL;
        }
 
-       if (!S_ISFIFO(mode)) {
-               /* issue a twstat */
-               v9fs_blank_mistat(v9ses, mistat);
-               strcpy(mistat->data + 1, symname);
-               mistat->extension = mistat->data + 1;
-               retval = v9fs_t_wstat(v9ses, newfid->fid, mistat, &fcall);
-               if (retval < 0) {
-                       dprintk(DEBUG_ERROR, "v9fs_t_wstat error: %s\n",
-                               FCALL_ERROR(fcall));
-                       goto FreeMem;
-               }
-
-               kfree(fcall);
-       }
-
-       /* need to update dcache so we show up */
-       kfree(fcall);
-
-       if (v9fs_t_clunk(v9ses, newfid->fid, &fcall)) {
-               dprintk(DEBUG_ERROR, "clunk for symlink failed: %s\n",
-                       FCALL_ERROR(fcall));
-               goto FreeMem;
-       }
-
-       d_drop(dentry);         /* FID - will this also clunk? */
-
-      FreeMem:
-       kfree(mistat);
-       kfree(fcall);
-       putname(symname);
+       retval = v9fs_vfs_mkspecial(dir, dentry, mode, name);
+       __putname(name);
 
        return retval;
 }
 
-static struct inode_operations v9fs_dir_inode_operations = {
+static struct inode_operations v9fs_dir_inode_operations_ext = {
        .create = v9fs_vfs_create,
        .lookup = v9fs_vfs_lookup,
        .symlink = v9fs_vfs_symlink,
@@ -1357,6 +1291,18 @@ static struct inode_operations v9fs_dir_inode_operations = {
        .setattr = v9fs_vfs_setattr,
 };
 
+static struct inode_operations v9fs_dir_inode_operations = {
+       .create = v9fs_vfs_create,
+       .lookup = v9fs_vfs_lookup,
+       .unlink = v9fs_vfs_unlink,
+       .mkdir = v9fs_vfs_mkdir,
+       .rmdir = v9fs_vfs_rmdir,
+       .mknod = v9fs_vfs_mknod,
+       .rename = v9fs_vfs_rename,
+       .getattr = v9fs_vfs_getattr,
+       .setattr = v9fs_vfs_setattr,
+};
+
 static struct inode_operations v9fs_file_inode_operations = {
        .getattr = v9fs_vfs_getattr,
        .setattr = v9fs_vfs_setattr,