Staging: et131x: Correct WRAP bit handling
[safe/jmp/linux-2.6] / drivers / staging / comedi / drivers / icp_multi.c
index 0415214..7a67fff 100644 (file)
@@ -50,6 +50,7 @@ Options:
  [1] - PCI slot number
 */
 
+#include <linux/interrupt.h>
 #include "../comedidev.h"
 
 #include <linux/delay.h>
@@ -108,12 +109,12 @@ Options:
 #define        Status_IRQ      0x00ff  /*  All interrupts */
 
 /*  Define analogue range */
-static const comedi_lrange range_analog = { 4, {
-                       UNI_RANGE(5),
-                       UNI_RANGE(10),
-                       BIP_RANGE(5),
-                       BIP_RANGE(10)
-       }
+static const struct comedi_lrange range_analog = { 4, {
+                                                      UNI_RANGE(5),
+                                                      UNI_RANGE(10),
+                                                      BIP_RANGE(5),
+                                                      BIP_RANGE(10)
+                                                      }
 };
 
 static const char range_codes_analog[] = { 0x00, 0x20, 0x10, 0x30 };
@@ -123,7 +124,8 @@ static const char range_codes_analog[] = { 0x00, 0x20, 0x10, 0x30 };
        Forward declarations
 ==============================================================================
 */
-static int icp_multi_attach(struct comedi_device *dev, comedi_devconfig *it);
+static int icp_multi_attach(struct comedi_device *dev,
+                           struct comedi_devconfig *it);
 static int icp_multi_detach(struct comedi_device *dev);
 
 /*
@@ -147,40 +149,40 @@ struct boardtype {
        int n_ctrs;             /*  num of counters */
        int ai_maxdata;         /*  resolution of A/D */
        int ao_maxdata;         /*  resolution of D/A */
-       const comedi_lrange *rangelist_ai;      /*  rangelist for A/D */
+       const struct comedi_lrange *rangelist_ai;       /*  rangelist for A/D */
        const char *rangecode;  /*  range codes for programming */
-       const comedi_lrange *rangelist_ao;      /*  rangelist for D/A */
+       const struct comedi_lrange *rangelist_ao;       /*  rangelist for D/A */
 };
 
 static const struct boardtype boardtypes[] = {
        {"icp_multi",           /*  Driver name */
-                       DEVICE_ID,      /*  PCI device ID */
-                       IORANGE_ICP_MULTI,      /*  I/O range length */
-                       1,      /*  1=Card supports interrupts */
-                       TYPE_ICP_MULTI, /*  Card type = ICP MULTI */
-                       16,     /*  Num of A/D channels */
-                       8,      /*  Num of A/D channels in diff mode */
-                       4,      /*  Num of D/A channels */
-                       16,     /*  Num of digital inputs */
-                       8,      /*  Num of digital outputs */
-                       4,      /*  Num of counters */
-                       0x0fff, /*  Resolution of A/D */
-                       0x0fff, /*  Resolution of D/A */
-                       &range_analog,  /*  Rangelist for A/D */
-                       range_codes_analog,     /*  Range codes for programming */
-               &range_analog}, /*  Rangelist for D/A */
+        DEVICE_ID,             /*  PCI device ID */
+        IORANGE_ICP_MULTI,     /*  I/O range length */
+        1,                     /*  1=Card supports interrupts */
+        TYPE_ICP_MULTI,        /*  Card type = ICP MULTI */
+        16,                    /*  Num of A/D channels */
+        8,                     /*  Num of A/D channels in diff mode */
+        4,                     /*  Num of D/A channels */
+        16,                    /*  Num of digital inputs */
+        8,                     /*  Num of digital outputs */
+        4,                     /*  Num of counters */
+        0x0fff,                /*  Resolution of A/D */
+        0x0fff,                /*  Resolution of D/A */
+        &range_analog,         /*  Rangelist for A/D */
+        range_codes_analog,    /*  Range codes for programming */
+        &range_analog},        /*  Rangelist for D/A */
 };
 
 #define n_boardtypes (sizeof(boardtypes)/sizeof(struct boardtype))
 
-static comedi_driver driver_icp_multi = {
-      driver_name:"icp_multi",
-      module : THIS_MODULE,
-      attach : icp_multi_attach,
-      detach : icp_multi_detach,
-      num_names : n_boardtypes,
-      board_name : &boardtypes[0].name,
-      offset : sizeof(struct boardtype),
+static struct comedi_driver driver_icp_multi = {
+driver_name:"icp_multi",
+module:THIS_MODULE,
+attach:icp_multi_attach,
+detach:icp_multi_detach,
+num_names:n_boardtypes,
+board_name:&boardtypes[0].name,
+offset:sizeof(struct boardtype),
 };
 
 COMEDI_INITCLEANUP(driver_icp_multi);
@@ -198,9 +200,9 @@ struct icp_multi_private {
        unsigned char act_chanlist_len; /*  len of scanlist */
        unsigned char act_chanlist_pos; /*  actual position in MUX list */
        unsigned int *ai_chanlist;      /*  actaul chanlist */
-       short *ai_data; /*  data buffer */
+       short *ai_data;         /*  data buffer */
        short ao_data[4];       /*  data output buffer */
-       short di_data;  /*  Digital input data */
+       short di_data;          /*  Digital input data */
        unsigned int do_data;   /*  Remember digital output data */
 };
 
@@ -214,11 +216,13 @@ struct icp_multi_private {
 */
 
 #if 0
-static int check_channel_list(struct comedi_device *dev, comedi_subdevice *s,
-       unsigned int *chanlist, unsigned int n_chan);
+static int check_channel_list(struct comedi_device *dev,
+                             struct comedi_subdevice *s,
+                             unsigned int *chanlist, unsigned int n_chan);
 #endif
-static void setup_channel_list(struct comedi_device *dev, comedi_subdevice *s,
-       unsigned int *chanlist, unsigned int n_chan);
+static void setup_channel_list(struct comedi_device *dev,
+                              struct comedi_subdevice *s,
+                              unsigned int *chanlist, unsigned int n_chan);
 static int icp_multi_reset(struct comedi_device *dev);
 
 /*
@@ -237,16 +241,17 @@ static int icp_multi_reset(struct comedi_device *dev);
 
        Parameters:
                struct comedi_device *dev       Pointer to current device structure
-               comedi_subdevice *s     Pointer to current subdevice structure
-               comedi_insn *insn       Pointer to current comedi instruction
+               struct comedi_subdevice *s      Pointer to current subdevice structure
+               struct comedi_insn *insn        Pointer to current comedi instruction
                unsigned int *data              Pointer to analogue input data
 
        Returns:int                     Nmuber of instructions executed
 
 ==============================================================================
 */
-static int icp_multi_insn_read_ai(struct comedi_device *dev, comedi_subdevice *s,
-       comedi_insn *insn, unsigned int *data)
+static int icp_multi_insn_read_ai(struct comedi_device *dev,
+                                 struct comedi_subdevice *s,
+                                 struct comedi_insn *insn, unsigned int *data)
 {
        int n, timeout;
 
@@ -266,45 +271,45 @@ static int icp_multi_insn_read_ai(struct comedi_device *dev, comedi_subdevice *s
 
 #ifdef ICP_MULTI_EXTDEBUG
        printk("icp_multi A ST=%4x IO=%p\n",
-               readw(devpriv->io_addr + ICP_MULTI_ADC_CSR),
-               devpriv->io_addr + ICP_MULTI_ADC_CSR);
+              readw(devpriv->io_addr + ICP_MULTI_ADC_CSR),
+              devpriv->io_addr + ICP_MULTI_ADC_CSR);
 #endif
 
        for (n = 0; n < insn->n; n++) {
                /*  Set start ADC bit */
                devpriv->AdcCmdStatus |= ADC_ST;
                writew(devpriv->AdcCmdStatus,
-                       devpriv->io_addr + ICP_MULTI_ADC_CSR);
+                      devpriv->io_addr + ICP_MULTI_ADC_CSR);
                devpriv->AdcCmdStatus &= ~ADC_ST;
 
 #ifdef ICP_MULTI_EXTDEBUG
                printk("icp multi B n=%d ST=%4x\n", n,
-                       readw(devpriv->io_addr + ICP_MULTI_ADC_CSR));
+                      readw(devpriv->io_addr + ICP_MULTI_ADC_CSR));
 #endif
 
-               comedi_udelay(1);
+               udelay(1);
 
 #ifdef ICP_MULTI_EXTDEBUG
                printk("icp multi C n=%d ST=%4x\n", n,
-                       readw(devpriv->io_addr + ICP_MULTI_ADC_CSR));
+                      readw(devpriv->io_addr + ICP_MULTI_ADC_CSR));
 #endif
 
                /*  Wait for conversion to complete, or get fed up waiting */
                timeout = 100;
                while (timeout--) {
                        if (!(readw(devpriv->io_addr +
-                                               ICP_MULTI_ADC_CSR) & ADC_BSY))
+                                   ICP_MULTI_ADC_CSR) & ADC_BSY))
                                goto conv_finish;
 
 #ifdef ICP_MULTI_EXTDEBUG
                        if (!(timeout % 10))
                                printk("icp multi D n=%d tm=%d ST=%4x\n", n,
-                                       timeout,
-                                       readw(devpriv->io_addr +
-                                               ICP_MULTI_ADC_CSR));
+                                      timeout,
+                                      readw(devpriv->io_addr +
+                                            ICP_MULTI_ADC_CSR));
 #endif
 
-                       comedi_udelay(1);
+                       udelay(1);
                }
 
                /*  If we reach here, a timeout has occurred */
@@ -317,19 +322,21 @@ static int icp_multi_insn_read_ai(struct comedi_device *dev, comedi_subdevice *s
                /*  Clear interrupt status */
                devpriv->IntStatus |= ADC_READY;
                writew(devpriv->IntStatus,
-                       devpriv->io_addr + ICP_MULTI_INT_STAT);
+                      devpriv->io_addr + ICP_MULTI_INT_STAT);
 
                /*  Clear data received */
                data[n] = 0;
 
 #ifdef ICP_MULTI_EXTDEBUG
-               printk("icp multi EDBG: END: icp_multi_insn_read_ai(...) n=%d\n", n);
+               printk
+                   ("icp multi EDBG: END: icp_multi_insn_read_ai(...) n=%d\n",
+                    n);
 #endif
                return -ETIME;
 
-             conv_finish:
+conv_finish:
                data[n] =
-                       (readw(devpriv->io_addr + ICP_MULTI_AI) >> 4) & 0x0fff;
+                   (readw(devpriv->io_addr + ICP_MULTI_AI) >> 4) & 0x0fff;
        }
 
        /*  Disable interrupt */
@@ -356,16 +363,17 @@ static int icp_multi_insn_read_ai(struct comedi_device *dev, comedi_subdevice *s
 
        Parameters:
                struct comedi_device *dev       Pointer to current device structure
-               comedi_subdevice *s     Pointer to current subdevice structure
-               comedi_insn *insn       Pointer to current comedi instruction
+               struct comedi_subdevice *s      Pointer to current subdevice structure
+               struct comedi_insn *insn        Pointer to current comedi instruction
                unsigned int *data              Pointer to analogue output data
 
        Returns:int                     Nmuber of instructions executed
 
 ==============================================================================
 */
-static int icp_multi_insn_write_ao(struct comedi_device *dev, comedi_subdevice *s,
-       comedi_insn *insn, unsigned int *data)
+static int icp_multi_insn_write_ao(struct comedi_device *dev,
+                                  struct comedi_subdevice *s,
+                                  struct comedi_insn *insn, unsigned int *data)
 {
        int n, chan, range, timeout;
 
@@ -400,18 +408,18 @@ static int icp_multi_insn_write_ao(struct comedi_device *dev, comedi_subdevice *
                timeout = 100;
                while (timeout--) {
                        if (!(readw(devpriv->io_addr +
-                                               ICP_MULTI_DAC_CSR) & DAC_BSY))
+                                   ICP_MULTI_DAC_CSR) & DAC_BSY))
                                goto dac_ready;
 
 #ifdef ICP_MULTI_EXTDEBUG
                        if (!(timeout % 10))
                                printk("icp multi A n=%d tm=%d ST=%4x\n", n,
-                                       timeout,
-                                       readw(devpriv->io_addr +
-                                               ICP_MULTI_DAC_CSR));
+                                      timeout,
+                                      readw(devpriv->io_addr +
+                                            ICP_MULTI_DAC_CSR));
 #endif
 
-                       comedi_udelay(1);
+                       udelay(1);
                }
 
                /*  If we reach here, a timeout has occurred */
@@ -424,24 +432,26 @@ static int icp_multi_insn_write_ao(struct comedi_device *dev, comedi_subdevice *
                /*  Clear interrupt status */
                devpriv->IntStatus |= DAC_READY;
                writew(devpriv->IntStatus,
-                       devpriv->io_addr + ICP_MULTI_INT_STAT);
+                      devpriv->io_addr + ICP_MULTI_INT_STAT);
 
                /*  Clear data received */
                devpriv->ao_data[chan] = 0;
 
 #ifdef ICP_MULTI_EXTDEBUG
-               printk("icp multi EDBG: END: icp_multi_insn_write_ao(...) n=%d\n", n);
+               printk
+                   ("icp multi EDBG: END: icp_multi_insn_write_ao(...) n=%d\n",
+                    n);
 #endif
                return -ETIME;
 
-             dac_ready:
+dac_ready:
                /*  Write data to analogue output data register */
                writew(data[n], devpriv->io_addr + ICP_MULTI_AO);
 
                /*  Set DAC_ST bit to write the data to selected channel */
                devpriv->DacCmdStatus |= DAC_ST;
                writew(devpriv->DacCmdStatus,
-                       devpriv->io_addr + ICP_MULTI_DAC_CSR);
+                      devpriv->io_addr + ICP_MULTI_DAC_CSR);
                devpriv->DacCmdStatus &= ~DAC_ST;
 
                /*  Save analogue output data */
@@ -464,16 +474,17 @@ static int icp_multi_insn_write_ao(struct comedi_device *dev, comedi_subdevice *
 
        Parameters:
                struct comedi_device *dev       Pointer to current device structure
-               comedi_subdevice *s     Pointer to current subdevice structure
-               comedi_insn *insn       Pointer to current comedi instruction
+               struct comedi_subdevice *s      Pointer to current subdevice structure
+               struct comedi_insn *insn        Pointer to current comedi instruction
                unsigned int *data              Pointer to analogue output data
 
        Returns:int                     Nmuber of instructions executed
 
 ==============================================================================
 */
-static int icp_multi_insn_read_ao(struct comedi_device *dev, comedi_subdevice *s,
-       comedi_insn *insn, unsigned int *data)
+static int icp_multi_insn_read_ao(struct comedi_device *dev,
+                                 struct comedi_subdevice *s,
+                                 struct comedi_insn *insn, unsigned int *data)
 {
        int n, chan;
 
@@ -497,16 +508,17 @@ static int icp_multi_insn_read_ao(struct comedi_device *dev, comedi_subdevice *s
 
        Parameters:
                struct comedi_device *dev       Pointer to current device structure
-               comedi_subdevice *s     Pointer to current subdevice structure
-               comedi_insn *insn       Pointer to current comedi instruction
+               struct comedi_subdevice *s      Pointer to current subdevice structure
+               struct comedi_insn *insn        Pointer to current comedi instruction
                unsigned int *data              Pointer to analogue output data
 
        Returns:int                     Nmuber of instructions executed
 
 ==============================================================================
 */
-static int icp_multi_insn_bits_di(struct comedi_device *dev, comedi_subdevice *s,
-       comedi_insn *insn, unsigned int *data)
+static int icp_multi_insn_bits_di(struct comedi_device *dev,
+                                 struct comedi_subdevice *s,
+                                 struct comedi_insn *insn, unsigned int *data)
 {
        data[1] = readw(devpriv->io_addr + ICP_MULTI_DI);
 
@@ -523,16 +535,17 @@ static int icp_multi_insn_bits_di(struct comedi_device *dev, comedi_subdevice *s
 
        Parameters:
                struct comedi_device *dev       Pointer to current device structure
-               comedi_subdevice *s     Pointer to current subdevice structure
-               comedi_insn *insn       Pointer to current comedi instruction
+               struct comedi_subdevice *s      Pointer to current subdevice structure
+               struct comedi_insn *insn        Pointer to current comedi instruction
                unsigned int *data              Pointer to analogue output data
 
        Returns:int                     Nmuber of instructions executed
 
 ==============================================================================
 */
-static int icp_multi_insn_bits_do(struct comedi_device *dev, comedi_subdevice *s,
-       comedi_insn *insn, unsigned int *data)
+static int icp_multi_insn_bits_do(struct comedi_device *dev,
+                                 struct comedi_subdevice *s,
+                                 struct comedi_insn *insn, unsigned int *data)
 {
 #ifdef ICP_MULTI_EXTDEBUG
        printk("icp multi EDBG: BGN: icp_multi_insn_bits_do(...)\n");
@@ -565,16 +578,17 @@ static int icp_multi_insn_bits_do(struct comedi_device *dev, comedi_subdevice *s
 
        Parameters:
                struct comedi_device *dev       Pointer to current device structure
-               comedi_subdevice *s     Pointer to current subdevice structure
-               comedi_insn *insn       Pointer to current comedi instruction
+               struct comedi_subdevice *s      Pointer to current subdevice structure
+               struct comedi_insn *insn        Pointer to current comedi instruction
                unsigned int *data              Pointer to counter data
 
        Returns:int                     Nmuber of instructions executed
 
 ==============================================================================
 */
-static int icp_multi_insn_read_ctr(struct comedi_device *dev, comedi_subdevice *s,
-       comedi_insn *insn, unsigned int *data)
+static int icp_multi_insn_read_ctr(struct comedi_device *dev,
+                                  struct comedi_subdevice *s,
+                                  struct comedi_insn *insn, unsigned int *data)
 {
        return 0;
 }
@@ -589,16 +603,18 @@ static int icp_multi_insn_read_ctr(struct comedi_device *dev, comedi_subdevice *
 
        Parameters:
                struct comedi_device *dev       Pointer to current device structure
-               comedi_subdevice *s     Pointer to current subdevice structure
-               comedi_insn *insn       Pointer to current comedi instruction
+               struct comedi_subdevice *s      Pointer to current subdevice structure
+               struct comedi_insn *insn        Pointer to current comedi instruction
                unsigned int *data              Pointer to counter data
 
        Returns:int                     Nmuber of instructions executed
 
 ==============================================================================
 */
-static int icp_multi_insn_write_ctr(struct comedi_device *dev, comedi_subdevice *s,
-       comedi_insn *insn, unsigned int *data)
+static int icp_multi_insn_write_ctr(struct comedi_device *dev,
+                                   struct comedi_subdevice *s,
+                                   struct comedi_insn *insn,
+                                   unsigned int *data)
 {
        return 0;
 }
@@ -618,14 +634,14 @@ static int icp_multi_insn_write_ctr(struct comedi_device *dev, comedi_subdevice
 
 ==============================================================================
 */
-static irqreturn_t interrupt_service_icp_multi(int irq, void *d PT_REGS_ARG)
+static irqreturn_t interrupt_service_icp_multi(int irq, void *d)
 {
        struct comedi_device *dev = d;
        int int_no;
 
 #ifdef ICP_MULTI_EXTDEBUG
        printk("icp multi EDBG: BGN: interrupt_service_icp_multi(%d,...)\n",
-               irq);
+              irq);
 #endif
 
        /*  Is this interrupt from our board? */
@@ -636,7 +652,7 @@ static irqreturn_t interrupt_service_icp_multi(int irq, void *d PT_REGS_ARG)
 
 #ifdef ICP_MULTI_EXTDEBUG
        printk("icp multi EDBG: interrupt_service_icp_multi() ST: %4x\n",
-               readw(devpriv->io_addr + ICP_MULTI_INT_STAT));
+              readw(devpriv->io_addr + ICP_MULTI_INT_STAT));
 #endif
 
        /*  Determine which interrupt is active & handle it */
@@ -680,7 +696,7 @@ static irqreturn_t interrupt_service_icp_multi(int irq, void *d PT_REGS_ARG)
 
        Parameters:
                struct comedi_device *dev       Pointer to current sevice structure
-               comedi_subdevice *s     Pointer to current subdevice structure
+               struct comedi_subdevice *s      Pointer to current subdevice structure
                unsigned int *chanlist  Pointer to packed channel list
                unsigned int n_chan     Number of channels to scan
 
@@ -689,8 +705,9 @@ static irqreturn_t interrupt_service_icp_multi(int irq, void *d PT_REGS_ARG)
 
 ==============================================================================
 */
-static int check_channel_list(struct comedi_device *dev, comedi_subdevice *s,
-       unsigned int *chanlist, unsigned int n_chan)
+static int check_channel_list(struct comedi_device *dev,
+                             struct comedi_subdevice *s,
+                             unsigned int *chanlist, unsigned int n_chan)
 {
        unsigned int i;
 
@@ -708,13 +725,13 @@ static int check_channel_list(struct comedi_device *dev, comedi_subdevice *s,
                if (CR_AREF(chanlist[i]) == AREF_DIFF) {
                        if (CR_CHAN(chanlist[i]) > this_board->n_aichand) {
                                comedi_error(dev,
-                                       "Incorrect differential ai channel number");
+                                            "Incorrect differential ai channel number");
                                return 0;
                        }
                } else {
                        if (CR_CHAN(chanlist[i]) > this_board->n_aichan) {
                                comedi_error(dev,
-                                       "Incorrect ai channel number");
+                                            "Incorrect ai channel number");
                                return 0;
                        }
                }
@@ -735,7 +752,7 @@ static int check_channel_list(struct comedi_device *dev, comedi_subdevice *s,
 
        Parameters:
                struct comedi_device *dev       Pointer to current sevice structure
-               comedi_subdevice *s     Pointer to current subdevice structure
+               struct comedi_subdevice *s      Pointer to current subdevice structure
                unsigned int *chanlist  Pointer to packed channel list
                unsigned int n_chan     Number of channels to scan
 
@@ -743,8 +760,9 @@ static int check_channel_list(struct comedi_device *dev, comedi_subdevice *s,
 
 ==============================================================================
 */
-static void setup_channel_list(struct comedi_device *dev, comedi_subdevice *s,
-       unsigned int *chanlist, unsigned int n_chan)
+static void setup_channel_list(struct comedi_device *dev,
+                              struct comedi_subdevice *s,
+                              unsigned int *chanlist, unsigned int n_chan)
 {
        unsigned int i, range, chanprog;
        unsigned int diff;
@@ -787,11 +805,11 @@ static void setup_channel_list(struct comedi_device *dev, comedi_subdevice *s,
 
                /* Output channel, range, mode to ICP Multi */
                writew(devpriv->AdcCmdStatus,
-                       devpriv->io_addr + ICP_MULTI_ADC_CSR);
+                      devpriv->io_addr + ICP_MULTI_ADC_CSR);
 
 #ifdef ICP_MULTI_EXTDEBUG
                printk("GS: %2d. [%4x]=%4x %4x\n", i, chanprog, range,
-                       devpriv->act_chanlist[i]);
+                      devpriv->act_chanlist[i]);
 #endif
        }
 
@@ -839,10 +857,10 @@ static int icp_multi_reset(struct comedi_device *dev)
 
                        /*  Output to command / status register */
                        writew(devpriv->DacCmdStatus,
-                               devpriv->io_addr + ICP_MULTI_DAC_CSR);
+                              devpriv->io_addr + ICP_MULTI_DAC_CSR);
 
                        /*  Delay to allow DAC time to recover */
-                       comedi_udelay(1);
+                       udelay(1);
                }
        /*  Digital outputs to 0 */
        writew(0, devpriv->io_addr + ICP_MULTI_DO);
@@ -864,15 +882,16 @@ static int icp_multi_reset(struct comedi_device *dev)
 
        Parameters:
                struct comedi_device *dev       Pointer to current device structure
-               comedi_devconfig *it    Pointer to current device configuration
+               struct comedi_devconfig *it     Pointer to current device configuration
 
        Returns:int     0 = success
 
 ==============================================================================
 */
-static int icp_multi_attach(struct comedi_device *dev, comedi_devconfig *it)
+static int icp_multi_attach(struct comedi_device *dev,
+                           struct comedi_devconfig *it)
 {
-       comedi_subdevice *s;
+       struct comedi_subdevice *s;
        int ret, subdev, n_subdevices;
        unsigned int irq;
        struct pcilst_struct *card = NULL;
@@ -890,15 +909,15 @@ static int icp_multi_attach(struct comedi_device *dev, comedi_devconfig *it)
        if (pci_list_builded++ == 0) {
                pci_card_list_init(PCI_VENDOR_ID_ICP,
 #ifdef ICP_MULTI_EXTDEBUG
-                       1
+                                  1
 #else
-                       0
+                                  0
 #endif
-                       );
+                   );
        }
 
        printk("Anne's comedi%d: icp_multi: board=%s", dev->minor,
-               this_board->name);
+              this_board->name);
 
        card = select_and_alloc_pci_card(PCI_VENDOR_ID_ICP,
                                         this_board->device_id, it->options[0],
@@ -910,7 +929,7 @@ static int icp_multi_attach(struct comedi_device *dev, comedi_devconfig *it)
        devpriv->card = card;
 
        if ((pci_card_data(card, &pci_bus, &pci_slot, &pci_func, &io_addr[0],
-                               &irq)) < 0) {
+                          &irq)) < 0) {
                printk(" - Can't get configuration data!\n");
                return -EIO;
        }
@@ -919,7 +938,7 @@ static int icp_multi_attach(struct comedi_device *dev, comedi_devconfig *it)
        devpriv->phys_iobase = iobase;
 
        printk(", b:s:f=%d:%d:%d, io=0x%8llx \n", pci_bus, pci_slot, pci_func,
-               (unsigned long long)iobase);
+              (unsigned long long)iobase);
 
        devpriv->io_addr = ioremap(iobase, ICP_MULTI_SIZE);
 
@@ -929,7 +948,7 @@ static int icp_multi_attach(struct comedi_device *dev, comedi_devconfig *it)
        }
 #ifdef ICP_MULTI_EXTDEBUG
        printk("0x%08llx mapped to %p, ", (unsigned long long)iobase,
-               devpriv->io_addr);
+              devpriv->io_addr);
 #endif
 
        dev->board_name = this_board->name;
@@ -954,9 +973,11 @@ static int icp_multi_attach(struct comedi_device *dev, comedi_devconfig *it)
 
        if (this_board->have_irq) {
                if (irq) {
-                       if (comedi_request_irq(irq, interrupt_service_icp_multi,
+                       if (request_irq(irq, interrupt_service_icp_multi,
                                        IRQF_SHARED, "Inova Icp Multi", dev)) {
-                               printk(", unable to allocate IRQ %u, DISABLING IT", irq);
+                               printk
+                                   (", unable to allocate IRQ %u, DISABLING IT",
+                                    irq);
                                irq = 0;        /* Can't use IRQ */
                        } else
                                printk(", irq=%u", irq);
@@ -1072,7 +1093,7 @@ static int icp_multi_detach(struct comedi_device *dev)
                        icp_multi_reset(dev);
 
        if (dev->irq)
-               comedi_free_irq(dev->irq, dev);
+               free_irq(dev->irq, dev);
 
        if (dev->private && devpriv->io_addr)
                iounmap(devpriv->io_addr);