[SCSI] sym53c8xx: Remove unnecessary check in queuecommand
[safe/jmp/linux-2.6] / drivers / scsi / iscsi_tcp.c
index 4e9f0d9..a21455d 100644 (file)
@@ -29,6 +29,7 @@
 #include <linux/types.h>
 #include <linux/list.h>
 #include <linux/inet.h>
+#include <linux/file.h>
 #include <linux/blkdev.h>
 #include <linux/crypto.h>
 #include <linux/delay.h>
@@ -236,10 +237,10 @@ iscsi_data_rsp(struct iscsi_conn *conn, struct iscsi_cmd_task *ctask)
        tcp_ctask->exp_datasn++;
 
        tcp_ctask->data_offset = be32_to_cpu(rhdr->offset);
-       if (tcp_ctask->data_offset + tcp_conn->in.datalen > sc->request_bufflen) {
+       if (tcp_ctask->data_offset + tcp_conn->in.datalen > scsi_bufflen(sc)) {
                debug_tcp("%s: data_offset(%d) + data_len(%d) > total_length_in(%d)\n",
                          __FUNCTION__, tcp_ctask->data_offset,
-                         tcp_conn->in.datalen, sc->request_bufflen);
+                         tcp_conn->in.datalen, scsi_bufflen(sc));
                return ISCSI_ERR_DATA_OFFSET;
        }
 
@@ -249,14 +250,14 @@ iscsi_data_rsp(struct iscsi_conn *conn, struct iscsi_cmd_task *ctask)
                        int res_count = be32_to_cpu(rhdr->residual_count);
 
                        if (res_count > 0 &&
-                           res_count <= sc->request_bufflen) {
-                               sc->resid = res_count;
+                           res_count <= scsi_bufflen(sc)) {
+                               scsi_set_resid(sc, res_count);
                                sc->result = (DID_OK << 16) | rhdr->cmd_status;
                        } else
                                sc->result = (DID_BAD_TARGET << 16) |
                                        rhdr->cmd_status;
                } else if (rhdr->flags & ISCSI_FLAG_DATA_OVERFLOW) {
-                       sc->resid = be32_to_cpu(rhdr->residual_count);
+                       scsi_set_resid(sc, be32_to_cpu(rhdr->residual_count));
                        sc->result = (DID_OK << 16) | rhdr->cmd_status;
                } else
                        sc->result = (DID_OK << 16) | rhdr->cmd_status;
@@ -284,6 +285,8 @@ iscsi_solicit_data_init(struct iscsi_conn *conn, struct iscsi_cmd_task *ctask,
 {
        struct iscsi_data *hdr;
        struct scsi_cmnd *sc = ctask->sc;
+       int i, sg_count = 0;
+       struct scatterlist *sg;
 
        hdr = &r2t->dtask.hdr;
        memset(hdr, 0, sizeof(struct iscsi_data));
@@ -311,39 +314,30 @@ iscsi_solicit_data_init(struct iscsi_conn *conn, struct iscsi_cmd_task *ctask,
        iscsi_buf_init_iov(&r2t->headbuf, (char*)hdr,
                           sizeof(struct iscsi_hdr));
 
-       if (sc->use_sg) {
-               int i, sg_count = 0;
-               struct scatterlist *sg = sc->request_buffer;
-
-               r2t->sg = NULL;
-               for (i = 0; i < sc->use_sg; i++, sg += 1) {
-                       /* FIXME: prefetch ? */
-                       if (sg_count + sg->length > r2t->data_offset) {
-                               int page_offset;
+       sg = scsi_sglist(sc);
+       r2t->sg = NULL;
+       for (i = 0; i < scsi_sg_count(sc); i++, sg += 1) {
+               /* FIXME: prefetch ? */
+               if (sg_count + sg->length > r2t->data_offset) {
+                       int page_offset;
 
-                               /* sg page found! */
+                       /* sg page found! */
 
-                               /* offset within this page */
-                               page_offset = r2t->data_offset - sg_count;
+                       /* offset within this page */
+                       page_offset = r2t->data_offset - sg_count;
 
-                               /* fill in this buffer */
-                               iscsi_buf_init_sg(&r2t->sendbuf, sg);
-                               r2t->sendbuf.sg.offset += page_offset;
-                               r2t->sendbuf.sg.length -= page_offset;
+                       /* fill in this buffer */
+                       iscsi_buf_init_sg(&r2t->sendbuf, sg);
+                       r2t->sendbuf.sg.offset += page_offset;
+                       r2t->sendbuf.sg.length -= page_offset;
 
-                               /* xmit logic will continue with next one */
-                               r2t->sg = sg + 1;
-                               break;
-                       }
-                       sg_count += sg->length;
+                       /* xmit logic will continue with next one */
+                       r2t->sg = sg + 1;
+                       break;
                }
-               BUG_ON(r2t->sg == NULL);
-       } else {
-               iscsi_buf_init_iov(&r2t->sendbuf,
-                           (char*)sc->request_buffer + r2t->data_offset,
-                           r2t->data_count);
-               r2t->sg = NULL;
+               sg_count += sg->length;
        }
+       BUG_ON(r2t->sg == NULL);
 }
 
 /**
@@ -403,11 +397,11 @@ iscsi_r2t_rsp(struct iscsi_conn *conn, struct iscsi_cmd_task *ctask)
                            r2t->data_length, session->max_burst);
 
        r2t->data_offset = be32_to_cpu(rhdr->data_offset);
-       if (r2t->data_offset + r2t->data_length > ctask->sc->request_bufflen) {
+       if (r2t->data_offset + r2t->data_length > scsi_bufflen(ctask->sc)) {
                spin_unlock(&session->lock);
                printk(KERN_ERR "iscsi_tcp: invalid R2T with data len %u at "
                       "offset %u and total length %d\n", r2t->data_length,
-                      r2t->data_offset, ctask->sc->request_bufflen);
+                      r2t->data_offset, scsi_bufflen(ctask->sc));
                return ISCSI_ERR_DATALEN;
        }
 
@@ -611,7 +605,7 @@ iscsi_ctask_copy(struct iscsi_tcp_conn *tcp_conn, struct iscsi_cmd_task *ctask,
               size, tcp_conn->in.offset, tcp_conn->in.copied);
 
        BUG_ON(size <= 0);
-       BUG_ON(tcp_ctask->sent + size > ctask->sc->request_bufflen);
+       BUG_ON(tcp_ctask->sent + size > scsi_bufflen(ctask->sc));
 
        rc = skb_copy_bits(tcp_conn->in.skb, tcp_conn->in.offset,
                           (char*)buf + (offset + tcp_conn->data_copied), size);
@@ -709,25 +703,8 @@ static int iscsi_scsi_data_in(struct iscsi_conn *conn)
 
        BUG_ON((void*)ctask != sc->SCp.ptr);
 
-       /*
-        * copying Data-In into the Scsi_Cmnd
-        */
-       if (!sc->use_sg) {
-               i = ctask->data_count;
-               rc = iscsi_ctask_copy(tcp_conn, ctask, sc->request_buffer,
-                                     sc->request_bufflen,
-                                     tcp_ctask->data_offset);
-               if (rc == -EAGAIN)
-                       return rc;
-               if (conn->datadgst_en)
-                       iscsi_recv_digest_update(tcp_conn, sc->request_buffer,
-                                                i);
-               rc = 0;
-               goto done;
-       }
-
        offset = tcp_ctask->data_offset;
-       sg = sc->request_buffer;
+       sg = scsi_sglist(sc);
 
        if (tcp_ctask->data_offset)
                for (i = 0; i < tcp_ctask->sg_count; i++)
@@ -736,7 +713,7 @@ static int iscsi_scsi_data_in(struct iscsi_conn *conn)
        if (offset < 0)
                offset = 0;
 
-       for (i = tcp_ctask->sg_count; i < sc->use_sg; i++) {
+       for (i = tcp_ctask->sg_count; i < scsi_sg_count(sc); i++) {
                char *dest;
 
                dest = kmap_atomic(sg[i].page, KM_SOFTIRQ0);
@@ -781,7 +758,6 @@ static int iscsi_scsi_data_in(struct iscsi_conn *conn)
        }
        BUG_ON(ctask->data_count);
 
-done:
        /* check for non-exceptional status */
        if (tcp_conn->in.hdr->flags & ISCSI_FLAG_DATA_STATUS) {
                debug_scsi("done [sc %lx res %d itt 0x%x flags 0x%x]\n",
@@ -1240,7 +1216,6 @@ iscsi_solicit_data_cont(struct iscsi_conn *conn, struct iscsi_cmd_task *ctask,
                        struct iscsi_r2t_info *r2t, int left)
 {
        struct iscsi_data *hdr;
-       struct scsi_cmnd *sc = ctask->sc;
        int new_offset;
 
        hdr = &r2t->dtask.hdr;
@@ -1270,15 +1245,8 @@ iscsi_solicit_data_cont(struct iscsi_conn *conn, struct iscsi_cmd_task *ctask,
        if (iscsi_buf_left(&r2t->sendbuf))
                return;
 
-       if (sc->use_sg) {
-               iscsi_buf_init_sg(&r2t->sendbuf, r2t->sg);
-               r2t->sg += 1;
-       } else {
-               iscsi_buf_init_iov(&r2t->sendbuf,
-                           (char*)sc->request_buffer + new_offset,
-                           r2t->data_count);
-               r2t->sg = NULL;
-       }
+       iscsi_buf_init_sg(&r2t->sendbuf, r2t->sg);
+       r2t->sg += 1;
 }
 
 static void iscsi_set_padding(struct iscsi_tcp_cmd_task *tcp_ctask,
@@ -1407,23 +1375,15 @@ iscsi_send_cmd_hdr(struct iscsi_conn *conn, struct iscsi_cmd_task *ctask)
                tcp_ctask->exp_datasn = 0;
 
                if (sc->sc_data_direction == DMA_TO_DEVICE) {
-                       if (sc->use_sg) {
-                               struct scatterlist *sg = sc->request_buffer;
-
-                               iscsi_buf_init_sg(&tcp_ctask->sendbuf, sg);
-                               tcp_ctask->sg = sg + 1;
-                               tcp_ctask->bad_sg = sg + sc->use_sg;
-                       } else {
-                               iscsi_buf_init_iov(&tcp_ctask->sendbuf,
-                                                  sc->request_buffer,
-                                                  sc->request_bufflen);
-                               tcp_ctask->sg = NULL;
-                               tcp_ctask->bad_sg = NULL;
-                       }
+                       struct scatterlist *sg = scsi_sglist(sc);
+
+                       iscsi_buf_init_sg(&tcp_ctask->sendbuf, sg);
+                       tcp_ctask->sg = sg + 1;
+                       tcp_ctask->bad_sg = sg + scsi_sg_count(sc);
 
                        debug_scsi("cmd [itt 0x%x total %d imm_data %d "
                                   "unsol count %d, unsol offset %d]\n",
-                                  ctask->itt, sc->request_bufflen,
+                                  ctask->itt, scsi_bufflen(sc),
                                   ctask->imm_count, ctask->unsol_count,
                                   ctask->unsol_offset);
                }
@@ -1869,18 +1829,22 @@ tcp_conn_alloc_fail:
 static void
 iscsi_tcp_release_conn(struct iscsi_conn *conn)
 {
+       struct iscsi_session *session = conn->session;
        struct iscsi_tcp_conn *tcp_conn = conn->dd_data;
+       struct socket *sock = tcp_conn->sock;
 
-       if (!tcp_conn->sock)
+       if (!sock)
                return;
 
-       sock_hold(tcp_conn->sock->sk);
+       sock_hold(sock->sk);
        iscsi_conn_restore_callbacks(tcp_conn);
-       sock_put(tcp_conn->sock->sk);
+       sock_put(sock->sk);
 
-       sock_release(tcp_conn->sock);
+       spin_lock_bh(&session->lock);
        tcp_conn->sock = NULL;
        conn->recv_lock = NULL;
+       spin_unlock_bh(&session->lock);
+       sockfd_put(sock);
 }
 
 static void
@@ -1911,6 +1875,46 @@ iscsi_tcp_conn_stop(struct iscsi_cls_conn *cls_conn, int flag)
        tcp_conn->hdr_size = sizeof(struct iscsi_hdr);
 }
 
+static int iscsi_tcp_get_addr(struct iscsi_conn *conn, struct socket *sock,
+                             char *buf, int *port,
+                             int (*getname)(struct socket *, struct sockaddr *,
+                                       int *addrlen))
+{
+       struct sockaddr_storage *addr;
+       struct sockaddr_in6 *sin6;
+       struct sockaddr_in *sin;
+       int rc = 0, len;
+
+       addr = kmalloc(sizeof(*addr), GFP_KERNEL);
+       if (!addr)
+               return -ENOMEM;
+
+       if (getname(sock, (struct sockaddr *) addr, &len)) {
+               rc = -ENODEV;
+               goto free_addr;
+       }
+
+       switch (addr->ss_family) {
+       case AF_INET:
+               sin = (struct sockaddr_in *)addr;
+               spin_lock_bh(&conn->session->lock);
+               sprintf(buf, NIPQUAD_FMT, NIPQUAD(sin->sin_addr.s_addr));
+               *port = be16_to_cpu(sin->sin_port);
+               spin_unlock_bh(&conn->session->lock);
+               break;
+       case AF_INET6:
+               sin6 = (struct sockaddr_in6 *)addr;
+               spin_lock_bh(&conn->session->lock);
+               sprintf(buf, NIP6_FMT, NIP6(sin6->sin6_addr));
+               *port = be16_to_cpu(sin6->sin6_port);
+               spin_unlock_bh(&conn->session->lock);
+               break;
+       }
+free_addr:
+       kfree(addr);
+       return rc;
+}
+
 static int
 iscsi_tcp_conn_bind(struct iscsi_cls_session *cls_session,
                    struct iscsi_cls_conn *cls_conn, uint64_t transport_eph,
@@ -1928,10 +1932,24 @@ iscsi_tcp_conn_bind(struct iscsi_cls_session *cls_session,
                printk(KERN_ERR "iscsi_tcp: sockfd_lookup failed %d\n", err);
                return -EEXIST;
        }
+       /*
+        * copy these values now because if we drop the session
+        * userspace may still want to query the values since we will
+        * be using them for the reconnect
+        */
+       err = iscsi_tcp_get_addr(conn, sock, conn->portal_address,
+                                &conn->portal_port, kernel_getpeername);
+       if (err)
+               goto free_socket;
+
+       err = iscsi_tcp_get_addr(conn, sock, conn->local_address,
+                               &conn->local_port, kernel_getsockname);
+       if (err)
+               goto free_socket;
 
        err = iscsi_conn_bind(cls_session, cls_conn, is_leading);
        if (err)
-               return err;
+               goto free_socket;
 
        /* bind iSCSI connection and socket */
        tcp_conn->sock = sock;
@@ -1955,8 +1973,11 @@ iscsi_tcp_conn_bind(struct iscsi_cls_session *cls_session,
         * set receive state machine into initial state
         */
        tcp_conn->in_progress = IN_PROGRESS_WAIT_HEADER;
-
        return 0;
+
+free_socket:
+       sockfd_put(sock);
+       return err;
 }
 
 /* called with host lock */
@@ -2076,33 +2097,18 @@ iscsi_tcp_conn_get_param(struct iscsi_cls_conn *cls_conn,
                         enum iscsi_param param, char *buf)
 {
        struct iscsi_conn *conn = cls_conn->dd_data;
-       struct iscsi_tcp_conn *tcp_conn = conn->dd_data;
-       struct inet_sock *inet;
-       struct ipv6_pinfo *np;
-       struct sock *sk;
        int len;
 
        switch(param) {
        case ISCSI_PARAM_CONN_PORT:
-               if (!tcp_conn->sock)
-                       return -EINVAL;
-
-               inet = inet_sk(tcp_conn->sock->sk);
-               len = sprintf(buf, "%hu\n", be16_to_cpu(inet->dport));
+               spin_lock_bh(&conn->session->lock);
+               len = sprintf(buf, "%hu\n", conn->portal_port);
+               spin_unlock_bh(&conn->session->lock);
                break;
        case ISCSI_PARAM_CONN_ADDRESS:
-               if (!tcp_conn->sock)
-                       return -EINVAL;
-
-               sk = tcp_conn->sock->sk;
-               if (sk->sk_family == PF_INET) {
-                       inet = inet_sk(sk);
-                       len = sprintf(buf, NIPQUAD_FMT "\n",
-                                     NIPQUAD(inet->daddr));
-               } else {
-                       np = inet6_sk(sk);
-                       len = sprintf(buf, NIP6_FMT "\n", NIP6(np->daddr));
-               }
+               spin_lock_bh(&conn->session->lock);
+               len = sprintf(buf, "%s\n", conn->portal_address);
+               spin_unlock_bh(&conn->session->lock);
                break;
        default:
                return iscsi_conn_get_param(cls_conn, param, buf);
@@ -2111,6 +2117,29 @@ iscsi_tcp_conn_get_param(struct iscsi_cls_conn *cls_conn,
        return len;
 }
 
+static int
+iscsi_tcp_host_get_param(struct Scsi_Host *shost, enum iscsi_host_param param,
+                        char *buf)
+{
+        struct iscsi_session *session = iscsi_hostdata(shost->hostdata);
+       int len;
+
+       switch (param) {
+       case ISCSI_HOST_PARAM_IPADDRESS:
+               spin_lock_bh(&session->lock);
+               if (!session->leadconn)
+                       len = -ENODEV;
+               else
+                       len = sprintf(buf, "%s\n",
+                                    session->leadconn->local_address);
+               spin_unlock_bh(&session->lock);
+               break;
+       default:
+               return iscsi_host_get_param(shost, param, buf);
+       }
+       return len;
+}
+
 static void
 iscsi_conn_get_stats(struct iscsi_cls_conn *cls_conn, struct iscsi_stats *stats)
 {
@@ -2187,11 +2216,13 @@ static void iscsi_tcp_session_destroy(struct iscsi_cls_session *cls_session)
 
 static int iscsi_tcp_slave_configure(struct scsi_device *sdev)
 {
+       blk_queue_bounce_limit(sdev->request_queue, BLK_BOUNCE_ANY);
        blk_queue_dma_alignment(sdev->request_queue, 0);
        return 0;
 }
 
 static struct scsi_host_template iscsi_sht = {
+       .module                 = THIS_MODULE,
        .name                   = "iSCSI Initiator over TCP/IP",
        .queuecommand           = iscsi_queuecommand,
        .change_queue_depth     = iscsi_change_queue_depth,
@@ -2232,8 +2263,9 @@ static struct iscsi_transport iscsi_tcp_transport = {
                                  ISCSI_TARGET_NAME | ISCSI_TPGT |
                                  ISCSI_USERNAME | ISCSI_PASSWORD |
                                  ISCSI_USERNAME_IN | ISCSI_PASSWORD_IN,
-       .host_param_mask        = ISCSI_HOST_HWADDRESS |
-                                 ISCSI_HOST_INITIATOR_NAME,
+       .host_param_mask        = ISCSI_HOST_HWADDRESS | ISCSI_HOST_IPADDRESS |
+                                 ISCSI_HOST_INITIATOR_NAME |
+                                 ISCSI_HOST_NETDEV_NAME,
        .host_template          = &iscsi_sht,
        .conndata_size          = sizeof(struct iscsi_conn),
        .max_conn               = 1,
@@ -2251,7 +2283,7 @@ static struct iscsi_transport iscsi_tcp_transport = {
        .start_conn             = iscsi_conn_start,
        .stop_conn              = iscsi_tcp_conn_stop,
        /* iscsi host params */
-       .get_host_param         = iscsi_host_get_param,
+       .get_host_param         = iscsi_tcp_host_get_param,
        .set_host_param         = iscsi_host_set_param,
        /* IO */
        .send_pdu               = iscsi_conn_send_pdu,