drm/nouveau: off by one in init_i2c_device_find()
[safe/jmp/linux-2.6] / drivers / scsi / fcoe / libfcoe.c
index 2960710..50aaa4b 100644 (file)
@@ -1,5 +1,6 @@
 /*
- * Copyright(c) 2007 - 2008 Intel Corporation. All rights reserved.
+ * Copyright (c) 2008-2009 Cisco Systems, Inc.  All rights reserved.
+ * Copyright (c) 2009 Intel Corporation.  All rights reserved.
  *
  * This program is free software; you can redistribute it and/or modify it
  * under the terms and conditions of the GNU General Public License,
  * Maintained at www.Open-FCoE.org
  */
 
+#include <linux/types.h>
 #include <linux/module.h>
-#include <linux/version.h>
 #include <linux/kernel.h>
+#include <linux/list.h>
 #include <linux/spinlock.h>
-#include <linux/skbuff.h>
+#include <linux/timer.h>
 #include <linux/netdevice.h>
 #include <linux/etherdevice.h>
 #include <linux/ethtool.h>
 #include <linux/if_ether.h>
 #include <linux/if_vlan.h>
-#include <linux/kthread.h>
-#include <linux/crc32.h>
-#include <linux/cpu.h>
-#include <linux/fs.h>
-#include <linux/sysfs.h>
-#include <linux/ctype.h>
-#include <scsi/scsi_tcq.h>
-#include <scsi/scsicam.h>
-#include <scsi/scsi_transport.h>
-#include <scsi/scsi_transport_fc.h>
+#include <linux/errno.h>
+#include <linux/bitops.h>
+#include <linux/slab.h>
 #include <net/rtnetlink.h>
 
+#include <scsi/fc/fc_els.h>
+#include <scsi/fc/fc_fs.h>
+#include <scsi/fc/fc_fip.h>
 #include <scsi/fc/fc_encaps.h>
+#include <scsi/fc/fc_fcoe.h>
 
 #include <scsi/libfc.h>
-#include <scsi/fc_frame.h>
 #include <scsi/libfcoe.h>
-#include <scsi/fc_transport_fcoe.h>
 
-static int debug_fcoe;
+MODULE_AUTHOR("Open-FCoE.org");
+MODULE_DESCRIPTION("FIP discovery protocol support for FCoE HBAs");
+MODULE_LICENSE("GPL v2");
 
-#define FCOE_MAX_QUEUE_DEPTH  256
+#define        FCOE_CTLR_MIN_FKA       500             /* min keep alive (mS) */
+#define        FCOE_CTLR_DEF_FKA       FIP_DEF_FKA     /* default keep alive (mS) */
 
-/* destination address mode */
-#define FCOE_GW_ADDR_MODE          0x00
-#define FCOE_FCOUI_ADDR_MODE       0x01
+static void fcoe_ctlr_timeout(unsigned long);
+static void fcoe_ctlr_timer_work(struct work_struct *);
+static void fcoe_ctlr_recv_work(struct work_struct *);
 
-#define FCOE_WORD_TO_BYTE  4
+static u8 fcoe_all_fcfs[ETH_ALEN] = FIP_ALL_FCF_MACS;
 
-MODULE_AUTHOR("Open-FCoE.org");
-MODULE_DESCRIPTION("FCoE");
-MODULE_LICENSE("GPL");
-
-/* fcoe host list */
-LIST_HEAD(fcoe_hostlist);
-DEFINE_RWLOCK(fcoe_hostlist_lock);
-DEFINE_TIMER(fcoe_timer, NULL, 0, 0);
-struct fcoe_percpu_s *fcoe_percpu[NR_CPUS];
-
-
-/* Function Prototyes */
-static int fcoe_check_wait_queue(struct fc_lport *);
-static void fcoe_insert_wait_queue_head(struct fc_lport *, struct sk_buff *);
-static void fcoe_insert_wait_queue(struct fc_lport *, struct sk_buff *);
-static void fcoe_recv_flogi(struct fcoe_softc *, struct fc_frame *, u8 *);
-#ifdef CONFIG_HOTPLUG_CPU
-static int fcoe_cpu_callback(struct notifier_block *, ulong, void *);
-#endif /* CONFIG_HOTPLUG_CPU */
-static int fcoe_device_notification(struct notifier_block *, ulong, void *);
-static void fcoe_dev_setup(void);
-static void fcoe_dev_cleanup(void);
-
-/* notification function from net device */
-static struct notifier_block fcoe_notifier = {
-       .notifier_call = fcoe_device_notification,
-};
-
-
-#ifdef CONFIG_HOTPLUG_CPU
-static struct notifier_block fcoe_cpu_notifier = {
-       .notifier_call = fcoe_cpu_callback,
-};
+unsigned int libfcoe_debug_logging;
+module_param_named(debug_logging, libfcoe_debug_logging, int, S_IRUGO|S_IWUSR);
+MODULE_PARM_DESC(debug_logging, "a bit mask of logging levels");
+
+#define LIBFCOE_LOGGING            0x01 /* General logging, not categorized */
+#define LIBFCOE_FIP_LOGGING 0x02 /* FIP logging */
+
+#define LIBFCOE_CHECK_LOGGING(LEVEL, CMD)              \
+do {                                                   \
+       if (unlikely(libfcoe_debug_logging & LEVEL))    \
+               do {                                    \
+                       CMD;                            \
+               } while (0);                            \
+} while (0)
+
+#define LIBFCOE_DBG(fmt, args...)                                      \
+       LIBFCOE_CHECK_LOGGING(LIBFCOE_LOGGING,                          \
+                             printk(KERN_INFO "libfcoe: " fmt, ##args);)
+
+#define LIBFCOE_FIP_DBG(fip, fmt, args...)                             \
+       LIBFCOE_CHECK_LOGGING(LIBFCOE_FIP_LOGGING,                      \
+                             printk(KERN_INFO "host%d: fip: " fmt,     \
+                                    (fip)->lp->host->host_no, ##args);)
 
 /**
- * fcoe_create_percpu_data - creates the associated cpu data
- * @cpu: index for the cpu where fcoe cpu data will be created
- *
- * create percpu stats block, from cpu add notifier
+ * fcoe_ctlr_mtu_valid() - Check if a FCF's MTU is valid
+ * @fcf: The FCF to check
  *
- * Returns: none
- **/
-static void fcoe_create_percpu_data(int cpu)
+ * Return non-zero if FCF fcoe_size has been validated.
+ */
+static inline int fcoe_ctlr_mtu_valid(const struct fcoe_fcf *fcf)
 {
-       struct fc_lport *lp;
-       struct fcoe_softc *fc;
-
-       write_lock_bh(&fcoe_hostlist_lock);
-       list_for_each_entry(fc, &fcoe_hostlist, list) {
-               lp = fc->lp;
-               if (lp->dev_stats[cpu] == NULL)
-                       lp->dev_stats[cpu] =
-                               kzalloc(sizeof(struct fcoe_dev_stats),
-                                       GFP_KERNEL);
-       }
-       write_unlock_bh(&fcoe_hostlist_lock);
+       return (fcf->flags & FIP_FL_SOL) != 0;
 }
 
 /**
- * fcoe_destroy_percpu_data - destroys the associated cpu data
- * @cpu: index for the cpu where fcoe cpu data will destroyed
- *
- * destroy percpu stats block called by cpu add/remove notifier
+ * fcoe_ctlr_fcf_usable() - Check if a FCF is usable
+ * @fcf: The FCF to check
  *
- * Retuns: none
- **/
-static void fcoe_destroy_percpu_data(int cpu)
+ * Return non-zero if the FCF is usable.
+ */
+static inline int fcoe_ctlr_fcf_usable(struct fcoe_fcf *fcf)
 {
-       struct fc_lport *lp;
-       struct fcoe_softc *fc;
+       u16 flags = FIP_FL_SOL | FIP_FL_AVAIL;
 
-       write_lock_bh(&fcoe_hostlist_lock);
-       list_for_each_entry(fc, &fcoe_hostlist, list) {
-               lp = fc->lp;
-               kfree(lp->dev_stats[cpu]);
-               lp->dev_stats[cpu] = NULL;
-       }
-       write_unlock_bh(&fcoe_hostlist_lock);
+       return (fcf->flags & flags) == flags;
 }
 
 /**
- * fcoe_cpu_callback - fcoe cpu hotplug event callback
- * @nfb: callback data block
- * @action: event triggering the callback
- * @hcpu: index for the cpu of this event
- *
- * this creates or destroys per cpu data for fcoe
+ * fcoe_ctlr_init() - Initialize the FCoE Controller instance
+ * @fip: The FCoE controller to initialize
+ */
+void fcoe_ctlr_init(struct fcoe_ctlr *fip)
+{
+       fip->state = FIP_ST_LINK_WAIT;
+       fip->mode = FIP_ST_AUTO;
+       INIT_LIST_HEAD(&fip->fcfs);
+       spin_lock_init(&fip->lock);
+       fip->flogi_oxid = FC_XID_UNKNOWN;
+       setup_timer(&fip->timer, fcoe_ctlr_timeout, (unsigned long)fip);
+       INIT_WORK(&fip->timer_work, fcoe_ctlr_timer_work);
+       INIT_WORK(&fip->recv_work, fcoe_ctlr_recv_work);
+       skb_queue_head_init(&fip->fip_recv_list);
+}
+EXPORT_SYMBOL(fcoe_ctlr_init);
+
+/**
+ * fcoe_ctlr_reset_fcfs() - Reset and free all FCFs for a controller
+ * @fip: The FCoE controller whose FCFs are to be reset
  *
- * Returns NOTIFY_OK always.
- **/
-static int fcoe_cpu_callback(struct notifier_block *nfb, unsigned long action,
-                            void *hcpu)
+ * Called with &fcoe_ctlr lock held.
+ */
+static void fcoe_ctlr_reset_fcfs(struct fcoe_ctlr *fip)
 {
-       unsigned int cpu = (unsigned long)hcpu;
+       struct fcoe_fcf *fcf;
+       struct fcoe_fcf *next;
 
-       switch (action) {
-       case CPU_ONLINE:
-               fcoe_create_percpu_data(cpu);
-               break;
-       case CPU_DEAD:
-               fcoe_destroy_percpu_data(cpu);
-               break;
-       default:
-               break;
+       fip->sel_fcf = NULL;
+       list_for_each_entry_safe(fcf, next, &fip->fcfs, list) {
+               list_del(&fcf->list);
+               kfree(fcf);
        }
-       return NOTIFY_OK;
+       fip->fcf_count = 0;
+       fip->sel_time = 0;
 }
-#endif /* CONFIG_HOTPLUG_CPU */
 
 /**
- * fcoe_rcv - this is the fcoe receive function called by NET_RX_SOFTIRQ
- * @skb: the receive skb
- * @dev: associated net device
- * @ptype: context
- * @odldev: last device
+ * fcoe_ctlr_destroy() - Disable and tear down a FCoE controller
+ * @fip: The FCoE controller to tear down
+ *
+ * This is called by FCoE drivers before freeing the &fcoe_ctlr.
  *
- * this function will receive the packet and build fc frame and pass it up
+ * The receive handler will have been deleted before this to guarantee
+ * that no more recv_work will be scheduled.
  *
- * Returns: 0 for success
- **/
-int fcoe_rcv(struct sk_buff *skb, struct net_device *dev,
-            struct packet_type *ptype, struct net_device *olddev)
+ * The timer routine will simply return once we set FIP_ST_DISABLED.
+ * This guarantees that no further timeouts or work will be scheduled.
+ */
+void fcoe_ctlr_destroy(struct fcoe_ctlr *fip)
 {
-       struct fc_lport *lp;
-       struct fcoe_rcv_info *fr;
-       struct fcoe_softc *fc;
-       struct fcoe_dev_stats *stats;
-       struct fc_frame_header *fh;
-       unsigned short oxid;
-       int cpu_idx;
-       struct fcoe_percpu_s *fps;
-
-       fc = container_of(ptype, struct fcoe_softc, fcoe_packet_type);
-       lp = fc->lp;
-       if (unlikely(lp == NULL)) {
-               FC_DBG("cannot find hba structure");
-               goto err2;
-       }
+       cancel_work_sync(&fip->recv_work);
+       skb_queue_purge(&fip->fip_recv_list);
+
+       spin_lock_bh(&fip->lock);
+       fip->state = FIP_ST_DISABLED;
+       fcoe_ctlr_reset_fcfs(fip);
+       spin_unlock_bh(&fip->lock);
+       del_timer_sync(&fip->timer);
+       cancel_work_sync(&fip->timer_work);
+}
+EXPORT_SYMBOL(fcoe_ctlr_destroy);
 
-       if (unlikely(debug_fcoe)) {
-               FC_DBG("skb_info: len:%d data_len:%d head:%p data:%p tail:%p "
-                      "end:%p sum:%d dev:%s", skb->len, skb->data_len,
-                      skb->head, skb->data, skb_tail_pointer(skb),
-                      skb_end_pointer(skb), skb->csum,
-                      skb->dev ? skb->dev->name : "<NULL>");
+/**
+ * fcoe_ctlr_fcoe_size() - Return the maximum FCoE size required for VN_Port
+ * @fip: The FCoE controller to get the maximum FCoE size from
+ *
+ * Returns the maximum packet size including the FCoE header and trailer,
+ * but not including any Ethernet or VLAN headers.
+ */
+static inline u32 fcoe_ctlr_fcoe_size(struct fcoe_ctlr *fip)
+{
+       /*
+        * Determine the max FCoE frame size allowed, including
+        * FCoE header and trailer.
+        * Note:  lp->mfs is currently the payload size, not the frame size.
+        */
+       return fip->lp->mfs + sizeof(struct fc_frame_header) +
+               sizeof(struct fcoe_hdr) + sizeof(struct fcoe_crc_eof);
+}
 
-       }
+/**
+ * fcoe_ctlr_solicit() - Send a FIP solicitation
+ * @fip: The FCoE controller to send the solicitation on
+ * @fcf: The destination FCF (if NULL, a multicast solicitation is sent)
+ */
+static void fcoe_ctlr_solicit(struct fcoe_ctlr *fip, struct fcoe_fcf *fcf)
+{
+       struct sk_buff *skb;
+       struct fip_sol {
+               struct ethhdr eth;
+               struct fip_header fip;
+               struct {
+                       struct fip_mac_desc mac;
+                       struct fip_wwn_desc wwnn;
+                       struct fip_size_desc size;
+               } __attribute__((packed)) desc;
+       }  __attribute__((packed)) *sol;
+       u32 fcoe_size;
+
+       skb = dev_alloc_skb(sizeof(*sol));
+       if (!skb)
+               return;
 
-       /* check for FCOE packet type */
-       if (unlikely(eth_hdr(skb)->h_proto != htons(ETH_P_FCOE))) {
-               FC_DBG("wrong FC type frame");
-               goto err;
-       }
+       sol = (struct fip_sol *)skb->data;
 
-       /*
-        * Check for minimum frame length, and make sure required FCoE
-        * and FC headers are pulled into the linear data area.
-        */
-       if (unlikely((skb->len < FCOE_MIN_FRAME) ||
-           !pskb_may_pull(skb, FCOE_HEADER_LEN)))
-               goto err;
+       memset(sol, 0, sizeof(*sol));
+       memcpy(sol->eth.h_dest, fcf ? fcf->fcf_mac : fcoe_all_fcfs, ETH_ALEN);
+       memcpy(sol->eth.h_source, fip->ctl_src_addr, ETH_ALEN);
+       sol->eth.h_proto = htons(ETH_P_FIP);
 
-       skb_set_transport_header(skb, sizeof(struct fcoe_hdr));
-       fh = (struct fc_frame_header *) skb_transport_header(skb);
+       sol->fip.fip_ver = FIP_VER_ENCAPS(FIP_VER);
+       sol->fip.fip_op = htons(FIP_OP_DISC);
+       sol->fip.fip_subcode = FIP_SC_SOL;
+       sol->fip.fip_dl_len = htons(sizeof(sol->desc) / FIP_BPW);
+       sol->fip.fip_flags = htons(FIP_FL_FPMA);
+       if (fip->spma)
+               sol->fip.fip_flags |= htons(FIP_FL_SPMA);
 
-       oxid = ntohs(fh->fh_ox_id);
+       sol->desc.mac.fd_desc.fip_dtype = FIP_DT_MAC;
+       sol->desc.mac.fd_desc.fip_dlen = sizeof(sol->desc.mac) / FIP_BPW;
+       memcpy(sol->desc.mac.fd_mac, fip->ctl_src_addr, ETH_ALEN);
 
-       fr = fcoe_dev_from_skb(skb);
-       fr->fr_dev = lp;
-       fr->ptype = ptype;
-       cpu_idx = 0;
-#ifdef CONFIG_SMP
-       /*
-        * The incoming frame exchange id(oxid) is ANDed with num of online
-        * cpu bits to get cpu_idx and then this cpu_idx is used for selecting
-        * a per cpu kernel thread from fcoe_percpu. In case the cpu is
-        * offline or no kernel thread for derived cpu_idx then cpu_idx is
-        * initialize to first online cpu index.
-        */
-       cpu_idx = oxid & (num_online_cpus() - 1);
-       if (!fcoe_percpu[cpu_idx] || !cpu_online(cpu_idx))
-               cpu_idx = first_cpu(cpu_online_map);
-#endif
-       fps = fcoe_percpu[cpu_idx];
+       sol->desc.wwnn.fd_desc.fip_dtype = FIP_DT_NAME;
+       sol->desc.wwnn.fd_desc.fip_dlen = sizeof(sol->desc.wwnn) / FIP_BPW;
+       put_unaligned_be64(fip->lp->wwnn, &sol->desc.wwnn.fd_wwn);
 
-       spin_lock_bh(&fps->fcoe_rx_list.lock);
-       __skb_queue_tail(&fps->fcoe_rx_list, skb);
-       if (fps->fcoe_rx_list.qlen == 1)
-               wake_up_process(fps->thread);
+       fcoe_size = fcoe_ctlr_fcoe_size(fip);
+       sol->desc.size.fd_desc.fip_dtype = FIP_DT_FCOE_SIZE;
+       sol->desc.size.fd_desc.fip_dlen = sizeof(sol->desc.size) / FIP_BPW;
+       sol->desc.size.fd_size = htons(fcoe_size);
 
-       spin_unlock_bh(&fps->fcoe_rx_list.lock);
+       skb_put(skb, sizeof(*sol));
+       skb->protocol = htons(ETH_P_FIP);
+       skb_reset_mac_header(skb);
+       skb_reset_network_header(skb);
+       fip->send(fip, skb);
 
-       return 0;
-err:
-#ifdef CONFIG_SMP
-       stats = lp->dev_stats[smp_processor_id()];
-#else
-       stats = lp->dev_stats[0];
-#endif
-       if (stats)
-               stats->ErrorFrames++;
-
-err2:
-       kfree_skb(skb);
-       return -1;
+       if (!fcf)
+               fip->sol_time = jiffies;
 }
-EXPORT_SYMBOL_GPL(fcoe_rcv);
 
 /**
- * fcoe_start_io - pass to netdev to start xmit for fcoe
- * @skb: the skb to be xmitted
+ * fcoe_ctlr_link_up() - Start FCoE controller
+ * @fip: The FCoE controller to start
  *
- * Returns: 0 for success
- **/
-static inline int fcoe_start_io(struct sk_buff *skb)
+ * Called from the LLD when the network link is ready.
+ */
+void fcoe_ctlr_link_up(struct fcoe_ctlr *fip)
 {
-       int rc;
-
-       skb_get(skb);
-       rc = dev_queue_xmit(skb);
-       if (rc != 0)
-               return rc;
-       kfree_skb(skb);
-       return 0;
+       spin_lock_bh(&fip->lock);
+       if (fip->state == FIP_ST_NON_FIP || fip->state == FIP_ST_AUTO) {
+               spin_unlock_bh(&fip->lock);
+               fc_linkup(fip->lp);
+       } else if (fip->state == FIP_ST_LINK_WAIT) {
+               fip->state = fip->mode;
+               spin_unlock_bh(&fip->lock);
+               if (fip->state == FIP_ST_AUTO)
+                       LIBFCOE_FIP_DBG(fip, "%s", "setting AUTO mode.\n");
+               fc_linkup(fip->lp);
+               fcoe_ctlr_solicit(fip, NULL);
+       } else
+               spin_unlock_bh(&fip->lock);
 }
+EXPORT_SYMBOL(fcoe_ctlr_link_up);
 
 /**
- * fcoe_get_paged_crc_eof - in case we need alloc a page for crc_eof
- * @skb: the skb to be xmitted
- * @tlen: total len
- *
- * Returns: 0 for success
- **/
-static int fcoe_get_paged_crc_eof(struct sk_buff *skb, int tlen)
+ * fcoe_ctlr_reset() - Reset a FCoE controller
+ * @fip:       The FCoE controller to reset
+ */
+static void fcoe_ctlr_reset(struct fcoe_ctlr *fip)
 {
-       struct fcoe_percpu_s *fps;
-       struct page *page;
-       int cpu_idx;
-
-       cpu_idx = get_cpu();
-       fps = fcoe_percpu[cpu_idx];
-       page = fps->crc_eof_page;
-       if (!page) {
-               page = alloc_page(GFP_ATOMIC);
-               if (!page) {
-                       put_cpu();
-                       return -ENOMEM;
-               }
-               fps->crc_eof_page = page;
-               WARN_ON(fps->crc_eof_offset != 0);
-       }
-
-       get_page(page);
-       skb_fill_page_desc(skb, skb_shinfo(skb)->nr_frags, page,
-                          fps->crc_eof_offset, tlen);
-       skb->len += tlen;
-       skb->data_len += tlen;
-       skb->truesize += tlen;
-       fps->crc_eof_offset += sizeof(struct fcoe_crc_eof);
-
-       if (fps->crc_eof_offset >= PAGE_SIZE) {
-               fps->crc_eof_page = NULL;
-               fps->crc_eof_offset = 0;
-               put_page(page);
-       }
-       put_cpu();
-       return 0;
+       fcoe_ctlr_reset_fcfs(fip);
+       del_timer(&fip->timer);
+       fip->ctlr_ka_time = 0;
+       fip->port_ka_time = 0;
+       fip->sol_time = 0;
+       fip->flogi_oxid = FC_XID_UNKNOWN;
+       fip->map_dest = 0;
 }
 
 /**
- * fcoe_fc_crc - calculates FC CRC in this fcoe skb
- * @fp: the fc_frame containg data to be checksummed
+ * fcoe_ctlr_link_down() - Stop a FCoE controller
+ * @fip: The FCoE controller to be stopped
  *
- * This uses crc32() to calculate the crc for fc frame
- * Return   : 32 bit crc
+ * Returns non-zero if the link was up and now isn't.
  *
- **/
-u32 fcoe_fc_crc(struct fc_frame *fp)
+ * Called from the LLD when the network link is not ready.
+ * There may be multiple calls while the link is down.
+ */
+int fcoe_ctlr_link_down(struct fcoe_ctlr *fip)
 {
-       struct sk_buff *skb = fp_skb(fp);
-       struct skb_frag_struct *frag;
-       unsigned char *data;
-       unsigned long off, len, clen;
-       u32 crc;
-       unsigned i;
-
-       crc = crc32(~0, skb->data, skb_headlen(skb));
-
-       for (i = 0; i < skb_shinfo(skb)->nr_frags; i++) {
-               frag = &skb_shinfo(skb)->frags[i];
-               off = frag->page_offset;
-               len = frag->size;
-               while (len > 0) {
-                       clen = min(len, PAGE_SIZE - (off & ~PAGE_MASK));
-                       data = kmap_atomic(frag->page + (off >> PAGE_SHIFT),
-                                          KM_SKB_DATA_SOFTIRQ);
-                       crc = crc32(crc, data + (off & ~PAGE_MASK), clen);
-                       kunmap_atomic(data, KM_SKB_DATA_SOFTIRQ);
-                       off += clen;
-                       len -= clen;
-               }
-       }
-       return crc;
+       int link_dropped;
+
+       LIBFCOE_FIP_DBG(fip, "link down.\n");
+       spin_lock_bh(&fip->lock);
+       fcoe_ctlr_reset(fip);
+       link_dropped = fip->state != FIP_ST_LINK_WAIT;
+       fip->state = FIP_ST_LINK_WAIT;
+       spin_unlock_bh(&fip->lock);
+
+       if (link_dropped)
+               fc_linkdown(fip->lp);
+       return link_dropped;
 }
-EXPORT_SYMBOL_GPL(fcoe_fc_crc);
+EXPORT_SYMBOL(fcoe_ctlr_link_down);
 
 /**
- * fcoe_xmit - FCoE frame transmit function
- * @lp:        the associated local port
- * @fp: the fc_frame to be transmitted
+ * fcoe_ctlr_send_keep_alive() - Send a keep-alive to the selected FCF
+ * @fip:   The FCoE controller to send the FKA on
+ * @lport: libfc fc_lport to send from
+ * @ports: 0 for controller keep-alive, 1 for port keep-alive
+ * @sa:           The source MAC address
  *
- * Return   : 0 for success
+ * A controller keep-alive is sent every fka_period (typically 8 seconds).
+ * The source MAC is the native MAC address.
  *
- **/
-int fcoe_xmit(struct fc_lport *lp, struct fc_frame *fp)
+ * A port keep-alive is sent every 90 seconds while logged in.
+ * The source MAC is the assigned mapped source address.
+ * The destination is the FCF's F-port.
+ */
+static void fcoe_ctlr_send_keep_alive(struct fcoe_ctlr *fip,
+                                     struct fc_lport *lport,
+                                     int ports, u8 *sa)
 {
-       int wlen, rc = 0;
-       u32 crc;
-       struct ethhdr *eh;
-       struct fcoe_crc_eof *cp;
        struct sk_buff *skb;
-       struct fcoe_dev_stats *stats;
-       struct fc_frame_header *fh;
-       unsigned int hlen;              /* header length implies the version */
-       unsigned int tlen;              /* trailer length */
-       unsigned int elen;              /* eth header, may include vlan */
-       int flogi_in_progress = 0;
-       struct fcoe_softc *fc;
-       u8 sof, eof;
-       struct fcoe_hdr *hp;
+       struct fip_kal {
+               struct ethhdr eth;
+               struct fip_header fip;
+               struct fip_mac_desc mac;
+       } __attribute__((packed)) *kal;
+       struct fip_vn_desc *vn;
+       u32 len;
+       struct fc_lport *lp;
+       struct fcoe_fcf *fcf;
 
-       WARN_ON((fr_len(fp) % sizeof(u32)) != 0);
+       fcf = fip->sel_fcf;
+       lp = fip->lp;
+       if (!fcf || !lp->port_id)
+               return;
 
-       fc = fcoe_softc(lp);
-       /*
-        * if it is a flogi then we need to learn gw-addr
-        * and my own fcid
-        */
-       fh = fc_frame_header_get(fp);
-       if (unlikely(fh->fh_r_ctl == FC_RCTL_ELS_REQ)) {
-               if (fc_frame_payload_op(fp) == ELS_FLOGI) {
-                       fc->flogi_oxid = ntohs(fh->fh_ox_id);
-                       fc->address_mode = FCOE_FCOUI_ADDR_MODE;
-                       fc->flogi_progress = 1;
-                       flogi_in_progress = 1;
-               } else if (fc->flogi_progress && ntoh24(fh->fh_s_id) != 0) {
-                       /*
-                        * Here we must've gotten an SID by accepting an FLOGI
-                        * from a point-to-point connection.  Switch to using
-                        * the source mac based on the SID.  The destination
-                        * MAC in this case would have been set by receving the
-                        * FLOGI.
-                        */
-                       fc_fcoe_set_mac(fc->data_src_addr, fh->fh_s_id);
-                       fc->flogi_progress = 0;
-               }
-       }
+       len = sizeof(*kal) + ports * sizeof(*vn);
+       skb = dev_alloc_skb(len);
+       if (!skb)
+               return;
 
-       skb = fp_skb(fp);
-       sof = fr_sof(fp);
-       eof = fr_eof(fp);
-
-       elen = (fc->real_dev->priv_flags & IFF_802_1Q_VLAN) ?
-               sizeof(struct vlan_ethhdr) : sizeof(struct ethhdr);
-       hlen = sizeof(struct fcoe_hdr);
-       tlen = sizeof(struct fcoe_crc_eof);
-       wlen = (skb->len - tlen + sizeof(crc)) / FCOE_WORD_TO_BYTE;
-
-       /* crc offload */
-       if (likely(lp->crc_offload)) {
-               skb->ip_summed = CHECKSUM_COMPLETE;
-               skb->csum_start = skb_headroom(skb);
-               skb->csum_offset = skb->len;
-               crc = 0;
-       } else {
-               skb->ip_summed = CHECKSUM_NONE;
-               crc = fcoe_fc_crc(fp);
+       kal = (struct fip_kal *)skb->data;
+       memset(kal, 0, len);
+       memcpy(kal->eth.h_dest, fcf->fcf_mac, ETH_ALEN);
+       memcpy(kal->eth.h_source, sa, ETH_ALEN);
+       kal->eth.h_proto = htons(ETH_P_FIP);
+
+       kal->fip.fip_ver = FIP_VER_ENCAPS(FIP_VER);
+       kal->fip.fip_op = htons(FIP_OP_CTRL);
+       kal->fip.fip_subcode = FIP_SC_KEEP_ALIVE;
+       kal->fip.fip_dl_len = htons((sizeof(kal->mac) +
+                                    ports * sizeof(*vn)) / FIP_BPW);
+       kal->fip.fip_flags = htons(FIP_FL_FPMA);
+       if (fip->spma)
+               kal->fip.fip_flags |= htons(FIP_FL_SPMA);
+
+       kal->mac.fd_desc.fip_dtype = FIP_DT_MAC;
+       kal->mac.fd_desc.fip_dlen = sizeof(kal->mac) / FIP_BPW;
+       memcpy(kal->mac.fd_mac, fip->ctl_src_addr, ETH_ALEN);
+       if (ports) {
+               vn = (struct fip_vn_desc *)(kal + 1);
+               vn->fd_desc.fip_dtype = FIP_DT_VN_ID;
+               vn->fd_desc.fip_dlen = sizeof(*vn) / FIP_BPW;
+               memcpy(vn->fd_mac, fip->get_src_addr(lport), ETH_ALEN);
+               hton24(vn->fd_fc_id, lport->port_id);
+               put_unaligned_be64(lport->wwpn, &vn->fd_wwpn);
        }
+       skb_put(skb, len);
+       skb->protocol = htons(ETH_P_FIP);
+       skb_reset_mac_header(skb);
+       skb_reset_network_header(skb);
+       fip->send(fip, skb);
+}
 
-       /* copy fc crc and eof to the skb buff */
-       if (skb_is_nonlinear(skb)) {
-               skb_frag_t *frag;
-               if (fcoe_get_paged_crc_eof(skb, tlen)) {
-                       kfree(skb);
-                       return -ENOMEM;
-               }
-               frag = &skb_shinfo(skb)->frags[skb_shinfo(skb)->nr_frags - 1];
-               cp = kmap_atomic(frag->page, KM_SKB_DATA_SOFTIRQ)
-                       + frag->page_offset;
+/**
+ * fcoe_ctlr_encaps() - Encapsulate an ELS frame for FIP, without sending it
+ * @fip:   The FCoE controller for the ELS frame
+ * @dtype: The FIP descriptor type for the frame
+ * @skb:   The FCoE ELS frame including FC header but no FCoE headers
+ *
+ * Returns non-zero error code on failure.
+ *
+ * The caller must check that the length is a multiple of 4.
+ *
+ * The @skb must have enough headroom (28 bytes) and tailroom (8 bytes).
+ * Headroom includes the FIP encapsulation description, FIP header, and
+ * Ethernet header.  The tailroom is for the FIP MAC descriptor.
+ */
+static int fcoe_ctlr_encaps(struct fcoe_ctlr *fip, struct fc_lport *lport,
+                           u8 dtype, struct sk_buff *skb)
+{
+       struct fip_encaps_head {
+               struct ethhdr eth;
+               struct fip_header fip;
+               struct fip_encaps encaps;
+       } __attribute__((packed)) *cap;
+       struct fip_mac_desc *mac;
+       struct fcoe_fcf *fcf;
+       size_t dlen;
+       u16 fip_flags;
+
+       fcf = fip->sel_fcf;
+       if (!fcf)
+               return -ENODEV;
+
+       /* set flags according to both FCF and lport's capability on SPMA */
+       fip_flags = fcf->flags;
+       fip_flags &= fip->spma ? FIP_FL_SPMA | FIP_FL_FPMA : FIP_FL_FPMA;
+       if (!fip_flags)
+               return -ENODEV;
+
+       dlen = sizeof(struct fip_encaps) + skb->len;    /* len before push */
+       cap = (struct fip_encaps_head *)skb_push(skb, sizeof(*cap));
+
+       memset(cap, 0, sizeof(*cap));
+       memcpy(cap->eth.h_dest, fcf->fcf_mac, ETH_ALEN);
+       memcpy(cap->eth.h_source, fip->ctl_src_addr, ETH_ALEN);
+       cap->eth.h_proto = htons(ETH_P_FIP);
+
+       cap->fip.fip_ver = FIP_VER_ENCAPS(FIP_VER);
+       cap->fip.fip_op = htons(FIP_OP_LS);
+       cap->fip.fip_subcode = FIP_SC_REQ;
+       cap->fip.fip_dl_len = htons((dlen + sizeof(*mac)) / FIP_BPW);
+       cap->fip.fip_flags = htons(fip_flags);
+
+       cap->encaps.fd_desc.fip_dtype = dtype;
+       cap->encaps.fd_desc.fip_dlen = dlen / FIP_BPW;
+
+       mac = (struct fip_mac_desc *)skb_put(skb, sizeof(*mac));
+       memset(mac, 0, sizeof(*mac));
+       mac->fd_desc.fip_dtype = FIP_DT_MAC;
+       mac->fd_desc.fip_dlen = sizeof(*mac) / FIP_BPW;
+       if (dtype != FIP_DT_FLOGI && dtype != FIP_DT_FDISC) {
+               memcpy(mac->fd_mac, fip->get_src_addr(lport), ETH_ALEN);
+       } else if (fip_flags & FIP_FL_SPMA) {
+               LIBFCOE_FIP_DBG(fip, "FLOGI/FDISC sent with SPMA\n");
+               memcpy(mac->fd_mac, fip->ctl_src_addr, ETH_ALEN);
        } else {
-               cp = (struct fcoe_crc_eof *)skb_put(skb, tlen);
+               LIBFCOE_FIP_DBG(fip, "FLOGI/FDISC sent with FPMA\n");
+               /* FPMA only FLOGI must leave the MAC desc set to all 0s */
        }
 
-       memset(cp, 0, sizeof(*cp));
-       cp->fcoe_eof = eof;
-       cp->fcoe_crc32 = cpu_to_le32(~crc);
-
-       if (skb_is_nonlinear(skb)) {
-               kunmap_atomic(cp, KM_SKB_DATA_SOFTIRQ);
-               cp = NULL;
-       }
-
-       /* adjust skb netowrk/transport offsets to match mac/fcoe/fc */
-       skb_push(skb, elen + hlen);
+       skb->protocol = htons(ETH_P_FIP);
        skb_reset_mac_header(skb);
        skb_reset_network_header(skb);
-       skb->mac_len = elen;
-       skb->protocol = htons(ETH_P_802_3);
-       skb->dev = fc->real_dev;
-
-       /* fill up mac and fcoe headers */
-       eh = eth_hdr(skb);
-       eh->h_proto = htons(ETH_P_FCOE);
-       if (fc->address_mode == FCOE_FCOUI_ADDR_MODE)
-               fc_fcoe_set_mac(eh->h_dest, fh->fh_d_id);
-       else
-               /* insert GW address */
-               memcpy(eh->h_dest, fc->dest_addr, ETH_ALEN);
-
-       if (unlikely(flogi_in_progress))
-               memcpy(eh->h_source, fc->ctl_src_addr, ETH_ALEN);
-       else
-               memcpy(eh->h_source, fc->data_src_addr, ETH_ALEN);
-
-       hp = (struct fcoe_hdr *)(eh + 1);
-       memset(hp, 0, sizeof(*hp));
-       if (FC_FCOE_VER)
-               FC_FCOE_ENCAPS_VER(hp, FC_FCOE_VER);
-       hp->fcoe_sof = sof;
-
-       /* update tx stats: regardless if LLD fails */
-       stats = lp->dev_stats[smp_processor_id()];
-       if (stats) {
-               stats->TxFrames++;
-               stats->TxWords += wlen;
-       }
-
-       /* send down to lld */
-       fr_dev(fp) = lp;
-       if (fc->fcoe_pending_queue.qlen)
-               rc = fcoe_check_wait_queue(lp);
-
-       if (rc == 0)
-               rc = fcoe_start_io(skb);
-
-       if (rc) {
-               fcoe_insert_wait_queue(lp, skb);
-               if (fc->fcoe_pending_queue.qlen > FCOE_MAX_QUEUE_DEPTH)
-                       lp->qfull = 1;
-       }
-
        return 0;
 }
-EXPORT_SYMBOL_GPL(fcoe_xmit);
 
-/*
- * fcoe_percpu_receive_thread - recv thread per cpu
- * @arg: ptr to the fcoe per cpu struct
+/**
+ * fcoe_ctlr_els_send() - Send an ELS frame encapsulated by FIP if appropriate.
+ * @fip:       FCoE controller.
+ * @lport:     libfc fc_lport to send from
+ * @skb:       FCoE ELS frame including FC header but no FCoE headers.
  *
- * Return: 0 for success
+ * Returns a non-zero error code if the frame should not be sent.
+ * Returns zero if the caller should send the frame with FCoE encapsulation.
  *
+ * The caller must check that the length is a multiple of 4.
+ * The SKB must have enough headroom (28 bytes) and tailroom (8 bytes).
  */
-int fcoe_percpu_receive_thread(void *arg)
+int fcoe_ctlr_els_send(struct fcoe_ctlr *fip, struct fc_lport *lport,
+                      struct sk_buff *skb)
 {
-       struct fcoe_percpu_s *p = arg;
-       u32 fr_len;
-       struct fc_lport *lp;
-       struct fcoe_rcv_info *fr;
-       struct fcoe_dev_stats *stats;
        struct fc_frame_header *fh;
-       struct sk_buff *skb;
-       struct fcoe_crc_eof crc_eof;
-       struct fc_frame *fp;
-       u8 *mac = NULL;
-       struct fcoe_softc *fc;
-       struct fcoe_hdr *hp;
-
-       set_user_nice(current, 19);
-
-       while (!kthread_should_stop()) {
-
-               spin_lock_bh(&p->fcoe_rx_list.lock);
-               while ((skb = __skb_dequeue(&p->fcoe_rx_list)) == NULL) {
-                       set_current_state(TASK_INTERRUPTIBLE);
-                       spin_unlock_bh(&p->fcoe_rx_list.lock);
-                       schedule();
-                       set_current_state(TASK_RUNNING);
-                       if (kthread_should_stop())
-                               return 0;
-                       spin_lock_bh(&p->fcoe_rx_list.lock);
-               }
-               spin_unlock_bh(&p->fcoe_rx_list.lock);
-               fr = fcoe_dev_from_skb(skb);
-               lp = fr->fr_dev;
-               if (unlikely(lp == NULL)) {
-                       FC_DBG("invalid HBA Structure");
-                       kfree_skb(skb);
-                       continue;
-               }
-
-               stats = lp->dev_stats[smp_processor_id()];
-
-               if (unlikely(debug_fcoe)) {
-                       FC_DBG("skb_info: len:%d data_len:%d head:%p data:%p "
-                              "tail:%p end:%p sum:%d dev:%s",
-                              skb->len, skb->data_len,
-                              skb->head, skb->data, skb_tail_pointer(skb),
-                              skb_end_pointer(skb), skb->csum,
-                              skb->dev ? skb->dev->name : "<NULL>");
-               }
-
-               /*
-                * Save source MAC address before discarding header.
-                */
-               fc = lport_priv(lp);
-               if (unlikely(fc->flogi_progress))
-                       mac = eth_hdr(skb)->h_source;
-
-               if (skb_is_nonlinear(skb))
-                       skb_linearize(skb);     /* not ideal */
-
-               /*
-                * Frame length checks and setting up the header pointers
-                * was done in fcoe_rcv already.
-                */
-               hp = (struct fcoe_hdr *) skb_network_header(skb);
-               fh = (struct fc_frame_header *) skb_transport_header(skb);
-
-               if (unlikely(FC_FCOE_DECAPS_VER(hp) != FC_FCOE_VER)) {
-                       if (stats) {
-                               if (stats->ErrorFrames < 5)
-                                       FC_DBG("unknown FCoE version %x",
-                                              FC_FCOE_DECAPS_VER(hp));
-                               stats->ErrorFrames++;
-                       }
-                       kfree_skb(skb);
-                       continue;
-               }
-
-               skb_pull(skb, sizeof(struct fcoe_hdr));
-               fr_len = skb->len - sizeof(struct fcoe_crc_eof);
-
-               if (stats) {
-                       stats->RxFrames++;
-                       stats->RxWords += fr_len / FCOE_WORD_TO_BYTE;
+       u16 old_xid;
+       u8 op;
+       u8 mac[ETH_ALEN];
+
+       fh = (struct fc_frame_header *)skb->data;
+       op = *(u8 *)(fh + 1);
+
+       if (op == ELS_FLOGI) {
+               old_xid = fip->flogi_oxid;
+               fip->flogi_oxid = ntohs(fh->fh_ox_id);
+               if (fip->state == FIP_ST_AUTO) {
+                       if (old_xid == FC_XID_UNKNOWN)
+                               fip->flogi_count = 0;
+                       fip->flogi_count++;
+                       if (fip->flogi_count < 3)
+                               goto drop;
+                       fip->map_dest = 1;
+                       return 0;
                }
+               if (fip->state == FIP_ST_NON_FIP)
+                       fip->map_dest = 1;
+       }
 
-               fp = (struct fc_frame *)skb;
-               fc_frame_init(fp);
-               fr_dev(fp) = lp;
-               fr_sof(fp) = hp->fcoe_sof;
-
-               /* Copy out the CRC and EOF trailer for access */
-               if (skb_copy_bits(skb, fr_len, &crc_eof, sizeof(crc_eof))) {
-                       kfree_skb(skb);
-                       continue;
-               }
-               fr_eof(fp) = crc_eof.fcoe_eof;
-               fr_crc(fp) = crc_eof.fcoe_crc32;
-               if (pskb_trim(skb, fr_len)) {
-                       kfree_skb(skb);
-                       continue;
-               }
+       if (fip->state == FIP_ST_NON_FIP)
+               return 0;
+       if (!fip->sel_fcf)
+               goto drop;
 
+       switch (op) {
+       case ELS_FLOGI:
+               op = FIP_DT_FLOGI;
+               break;
+       case ELS_FDISC:
+               if (ntoh24(fh->fh_s_id))
+                       return 0;
+               op = FIP_DT_FDISC;
+               break;
+       case ELS_LOGO:
+               if (fip->state != FIP_ST_ENABLED)
+                       return 0;
+               if (ntoh24(fh->fh_d_id) != FC_FID_FLOGI)
+                       return 0;
+               op = FIP_DT_LOGO;
+               break;
+       case ELS_LS_ACC:
+               if (fip->flogi_oxid == FC_XID_UNKNOWN)
+                       return 0;
+               if (!ntoh24(fh->fh_s_id))
+                       return 0;
+               if (fip->state == FIP_ST_AUTO)
+                       return 0;
                /*
-                * We only check CRC if no offload is available and if it is
-                * it's solicited data, in which case, the FCP layer would
-                * check it during the copy.
+                * Here we must've gotten an SID by accepting an FLOGI
+                * from a point-to-point connection.  Switch to using
+                * the source mac based on the SID.  The destination
+                * MAC in this case would have been set by receving the
+                * FLOGI.
                 */
-               if (lp->crc_offload)
-                       fr_flags(fp) &= ~FCPHF_CRC_UNCHECKED;
-               else
-                       fr_flags(fp) |= FCPHF_CRC_UNCHECKED;
-
-               fh = fc_frame_header_get(fp);
-               if (fh->fh_r_ctl == FC_RCTL_DD_SOL_DATA &&
-                   fh->fh_type == FC_TYPE_FCP) {
-                       fc_exch_recv(lp, lp->emp, fp);
-                       continue;
-               }
-               if (fr_flags(fp) & FCPHF_CRC_UNCHECKED) {
-                       if (le32_to_cpu(fr_crc(fp)) !=
-                           ~crc32(~0, skb->data, fr_len)) {
-                               if (debug_fcoe || stats->InvalidCRCCount < 5)
-                                       printk(KERN_WARNING "fcoe: dropping "
-                                              "frame with CRC error\n");
-                               stats->InvalidCRCCount++;
-                               stats->ErrorFrames++;
-                               fc_frame_free(fp);
-                               continue;
-                       }
-                       fr_flags(fp) &= ~FCPHF_CRC_UNCHECKED;
-               }
-               /* non flogi and non data exchanges are handled here */
-               if (unlikely(fc->flogi_progress))
-                       fcoe_recv_flogi(fc, fp, mac);
-               fc_exch_recv(lp, lp->emp, fp);
+               fip->flogi_oxid = FC_XID_UNKNOWN;
+               fc_fcoe_set_mac(mac, fh->fh_d_id);
+               fip->update_mac(lport, mac);
+               return 0;
+       default:
+               if (fip->state != FIP_ST_ENABLED)
+                       goto drop;
+               return 0;
        }
-       return 0;
+       if (fcoe_ctlr_encaps(fip, lport, op, skb))
+               goto drop;
+       fip->send(fip, skb);
+       return -EINPROGRESS;
+drop:
+       kfree_skb(skb);
+       return -EINVAL;
 }
+EXPORT_SYMBOL(fcoe_ctlr_els_send);
 
 /**
- * fcoe_recv_flogi - flogi receive function
- * @fc: associated fcoe_softc
- * @fp: the recieved frame
- * @sa: the source address of this flogi
+ * fcoe_ctlr_age_fcfs() - Reset and free all old FCFs for a controller
+ * @fip: The FCoE controller to free FCFs on
  *
- * This is responsible to parse the flogi response and sets the corresponding
- * mac address for the initiator, eitehr OUI based or GW based.
+ * Called with lock held and preemption disabled.
  *
- * Returns: none
- **/
-static void fcoe_recv_flogi(struct fcoe_softc *fc, struct fc_frame *fp, u8 *sa)
+ * An FCF is considered old if we have missed three advertisements.
+ * That is, there have been no valid advertisement from it for three
+ * times its keep-alive period including fuzz.
+ *
+ * In addition, determine the time when an FCF selection can occur.
+ *
+ * Also, increment the MissDiscAdvCount when no advertisement is received
+ * for the corresponding FCF for 1.5 * FKA_ADV_PERIOD (FC-BB-5 LESB).
+ */
+static void fcoe_ctlr_age_fcfs(struct fcoe_ctlr *fip)
 {
-       struct fc_frame_header *fh;
-       u8 op;
+       struct fcoe_fcf *fcf;
+       struct fcoe_fcf *next;
+       unsigned long sel_time = 0;
+       unsigned long mda_time = 0;
+       struct fcoe_dev_stats *stats;
 
-       fh = fc_frame_header_get(fp);
-       if (fh->fh_type != FC_TYPE_ELS)
-               return;
-       op = fc_frame_payload_op(fp);
-       if (op == ELS_LS_ACC && fh->fh_r_ctl == FC_RCTL_ELS_REP &&
-           fc->flogi_oxid == ntohs(fh->fh_ox_id)) {
-               /*
-                * FLOGI accepted.
-                * If the src mac addr is FC_OUI-based, then we mark the
-                * address_mode flag to use FC_OUI-based Ethernet DA.
-                * Otherwise we use the FCoE gateway addr
-                */
-               if (!compare_ether_addr(sa, (u8[6]) FC_FCOE_FLOGI_MAC)) {
-                       fc->address_mode = FCOE_FCOUI_ADDR_MODE;
-               } else {
-                       memcpy(fc->dest_addr, sa, ETH_ALEN);
-                       fc->address_mode = FCOE_GW_ADDR_MODE;
+       list_for_each_entry_safe(fcf, next, &fip->fcfs, list) {
+               mda_time = fcf->fka_period + (fcf->fka_period >> 1);
+               if ((fip->sel_fcf == fcf) &&
+                   (time_after(jiffies, fcf->time + mda_time))) {
+                       mod_timer(&fip->timer, jiffies + mda_time);
+                       stats = per_cpu_ptr(fip->lp->dev_stats,
+                                           smp_processor_id());
+                       stats->MissDiscAdvCount++;
+                       printk(KERN_INFO "libfcoe: host%d: Missing Discovery "
+                              "Advertisement for fab %16.16llx count %lld\n",
+                              fip->lp->host->host_no, fcf->fabric_name,
+                              stats->MissDiscAdvCount);
+               }
+               if (time_after(jiffies, fcf->time + fcf->fka_period * 3 +
+                              msecs_to_jiffies(FIP_FCF_FUZZ * 3))) {
+                       if (fip->sel_fcf == fcf)
+                               fip->sel_fcf = NULL;
+                       list_del(&fcf->list);
+                       WARN_ON(!fip->fcf_count);
+                       fip->fcf_count--;
+                       kfree(fcf);
+                       stats = per_cpu_ptr(fip->lp->dev_stats,
+                                           smp_processor_id());
+                       stats->VLinkFailureCount++;
+               } else if (fcoe_ctlr_mtu_valid(fcf) &&
+                          (!sel_time || time_before(sel_time, fcf->time))) {
+                       sel_time = fcf->time;
                }
-
-               /*
-                * Remove any previously-set unicast MAC filter.
-                * Add secondary FCoE MAC address filter for our OUI.
-                */
-               rtnl_lock();
-               if (compare_ether_addr(fc->data_src_addr, (u8[6]) { 0 }))
-                       dev_unicast_delete(fc->real_dev, fc->data_src_addr,
-                                          ETH_ALEN);
-               fc_fcoe_set_mac(fc->data_src_addr, fh->fh_d_id);
-               dev_unicast_add(fc->real_dev, fc->data_src_addr, ETH_ALEN);
-               rtnl_unlock();
-
-               fc->flogi_progress = 0;
-       } else if (op == ELS_FLOGI && fh->fh_r_ctl == FC_RCTL_ELS_REQ && sa) {
-               /*
-                * Save source MAC for point-to-point responses.
-                */
-               memcpy(fc->dest_addr, sa, ETH_ALEN);
-               fc->address_mode = FCOE_GW_ADDR_MODE;
+       }
+       if (sel_time) {
+               sel_time += msecs_to_jiffies(FCOE_CTLR_START_DELAY);
+               fip->sel_time = sel_time;
+               if (time_before(sel_time, fip->timer.expires))
+                       mod_timer(&fip->timer, sel_time);
+       } else {
+               fip->sel_time = 0;
        }
 }
 
 /**
- * fcoe_watchdog - fcoe timer callback
- * @vp:
- *
- * This checks the pending queue length for fcoe and set lport qfull
- * if the FCOE_MAX_QUEUE_DEPTH is reached. This is done for all fc_lport on the
- * fcoe_hostlist.
+ * fcoe_ctlr_parse_adv() - Decode a FIP advertisement into a new FCF entry
+ * @fip: The FCoE controller receiving the advertisement
+ * @skb: The received FIP advertisement frame
+ * @fcf: The resulting FCF entry
  *
- * Returns: 0 for success
- **/
-void fcoe_watchdog(ulong vp)
+ * Returns zero on a valid parsed advertisement,
+ * otherwise returns non zero value.
+ */
+static int fcoe_ctlr_parse_adv(struct fcoe_ctlr *fip,
+                              struct sk_buff *skb, struct fcoe_fcf *fcf)
 {
-       struct fc_lport *lp;
-       struct fcoe_softc *fc;
-       int qfilled = 0;
-
-       read_lock(&fcoe_hostlist_lock);
-       list_for_each_entry(fc, &fcoe_hostlist, list) {
-               lp = fc->lp;
-               if (lp) {
-                       if (fc->fcoe_pending_queue.qlen > FCOE_MAX_QUEUE_DEPTH)
-                               qfilled = 1;
-                       if (fcoe_check_wait_queue(lp) <  FCOE_MAX_QUEUE_DEPTH) {
-                               if (qfilled)
-                                       lp->qfull = 0;
+       struct fip_header *fiph;
+       struct fip_desc *desc = NULL;
+       struct fip_wwn_desc *wwn;
+       struct fip_fab_desc *fab;
+       struct fip_fka_desc *fka;
+       unsigned long t;
+       size_t rlen;
+       size_t dlen;
+
+       memset(fcf, 0, sizeof(*fcf));
+       fcf->fka_period = msecs_to_jiffies(FCOE_CTLR_DEF_FKA);
+
+       fiph = (struct fip_header *)skb->data;
+       fcf->flags = ntohs(fiph->fip_flags);
+
+       rlen = ntohs(fiph->fip_dl_len) * 4;
+       if (rlen + sizeof(*fiph) > skb->len)
+               return -EINVAL;
+
+       desc = (struct fip_desc *)(fiph + 1);
+       while (rlen > 0) {
+               dlen = desc->fip_dlen * FIP_BPW;
+               if (dlen < sizeof(*desc) || dlen > rlen)
+                       return -EINVAL;
+               switch (desc->fip_dtype) {
+               case FIP_DT_PRI:
+                       if (dlen != sizeof(struct fip_pri_desc))
+                               goto len_err;
+                       fcf->pri = ((struct fip_pri_desc *)desc)->fd_pri;
+                       break;
+               case FIP_DT_MAC:
+                       if (dlen != sizeof(struct fip_mac_desc))
+                               goto len_err;
+                       memcpy(fcf->fcf_mac,
+                              ((struct fip_mac_desc *)desc)->fd_mac,
+                              ETH_ALEN);
+                       if (!is_valid_ether_addr(fcf->fcf_mac)) {
+                               LIBFCOE_FIP_DBG(fip, "Invalid MAC address "
+                                               "in FIP adv\n");
+                               return -EINVAL;
                        }
+                       break;
+               case FIP_DT_NAME:
+                       if (dlen != sizeof(struct fip_wwn_desc))
+                               goto len_err;
+                       wwn = (struct fip_wwn_desc *)desc;
+                       fcf->switch_name = get_unaligned_be64(&wwn->fd_wwn);
+                       break;
+               case FIP_DT_FAB:
+                       if (dlen != sizeof(struct fip_fab_desc))
+                               goto len_err;
+                       fab = (struct fip_fab_desc *)desc;
+                       fcf->fabric_name = get_unaligned_be64(&fab->fd_wwn);
+                       fcf->vfid = ntohs(fab->fd_vfid);
+                       fcf->fc_map = ntoh24(fab->fd_map);
+                       break;
+               case FIP_DT_FKA:
+                       if (dlen != sizeof(struct fip_fka_desc))
+                               goto len_err;
+                       fka = (struct fip_fka_desc *)desc;
+                       if (fka->fd_flags & FIP_FKA_ADV_D)
+                               fcf->fd_flags = 1;
+                       t = ntohl(fka->fd_fka_period);
+                       if (t >= FCOE_CTLR_MIN_FKA)
+                               fcf->fka_period = msecs_to_jiffies(t);
+                       break;
+               case FIP_DT_MAP_OUI:
+               case FIP_DT_FCOE_SIZE:
+               case FIP_DT_FLOGI:
+               case FIP_DT_FDISC:
+               case FIP_DT_LOGO:
+               case FIP_DT_ELP:
+               default:
+                       LIBFCOE_FIP_DBG(fip, "unexpected descriptor type %x "
+                                       "in FIP adv\n", desc->fip_dtype);
+                       /* standard says ignore unknown descriptors >= 128 */
+                       if (desc->fip_dtype < FIP_DT_VENDOR_BASE)
+                               return -EINVAL;
+                       continue;
                }
+               desc = (struct fip_desc *)((char *)desc + dlen);
+               rlen -= dlen;
        }
-       read_unlock(&fcoe_hostlist_lock);
+       if (!fcf->fc_map || (fcf->fc_map & 0x10000))
+               return -EINVAL;
+       if (!fcf->switch_name || !fcf->fabric_name)
+               return -EINVAL;
+       return 0;
 
-       fcoe_timer.expires = jiffies + (1 * HZ);
-       add_timer(&fcoe_timer);
+len_err:
+       LIBFCOE_FIP_DBG(fip, "FIP length error in descriptor type %x len %zu\n",
+                       desc->fip_dtype, dlen);
+       return -EINVAL;
 }
 
-
 /**
- * fcoe_check_wait_queue - put the skb into fcoe pending xmit queue
- * @lp: the fc_port for this skb
- * @skb: the associated skb to be xmitted
- *
- * This empties the wait_queue, dequeue the head of the wait_queue queue
- * and calls fcoe_start_io() for each packet, if all skb have been
- * transmitted, return 0 if a error occurs, then restore wait_queue and
- * try again later.
- *
- * The wait_queue is used when the skb transmit fails. skb will go
- * in the wait_queue which will be emptied by the time function OR
- * by the next skb transmit.
- *
- * Returns: 0 for success
- **/
-static int fcoe_check_wait_queue(struct fc_lport *lp)
+ * fcoe_ctlr_recv_adv() - Handle an incoming advertisement
+ * @fip: The FCoE controller receiving the advertisement
+ * @skb: The received FIP packet
+ */
+static void fcoe_ctlr_recv_adv(struct fcoe_ctlr *fip, struct sk_buff *skb)
 {
-       int rc;
-       struct sk_buff *skb;
-       struct fcoe_softc *fc;
-
-       fc = fcoe_softc(lp);
-       spin_lock_bh(&fc->fcoe_pending_queue.lock);
+       struct fcoe_fcf *fcf;
+       struct fcoe_fcf new;
+       struct fcoe_fcf *found;
+       unsigned long sol_tov = msecs_to_jiffies(FCOE_CTRL_SOL_TOV);
+       int first = 0;
+       int mtu_valid;
+
+       if (fcoe_ctlr_parse_adv(fip, skb, &new))
+               return;
 
-       /*
-        * if interface pending queue full then set qfull in lport.
-        */
-       if (fc->fcoe_pending_queue.qlen > FCOE_MAX_QUEUE_DEPTH)
-               lp->qfull = 1;
-       if (fc->fcoe_pending_queue.qlen) {
-               while ((skb = __skb_dequeue(&fc->fcoe_pending_queue)) != NULL) {
-                       spin_unlock_bh(&fc->fcoe_pending_queue.lock);
-                       rc = fcoe_start_io(skb);
-                       if (rc) {
-                               fcoe_insert_wait_queue_head(lp, skb);
-                               return rc;
-                       }
-                       spin_lock_bh(&fc->fcoe_pending_queue.lock);
+       spin_lock_bh(&fip->lock);
+       first = list_empty(&fip->fcfs);
+       found = NULL;
+       list_for_each_entry(fcf, &fip->fcfs, list) {
+               if (fcf->switch_name == new.switch_name &&
+                   fcf->fabric_name == new.fabric_name &&
+                   fcf->fc_map == new.fc_map &&
+                   compare_ether_addr(fcf->fcf_mac, new.fcf_mac) == 0) {
+                       found = fcf;
+                       break;
                }
-               if (fc->fcoe_pending_queue.qlen < FCOE_MAX_QUEUE_DEPTH)
-                       lp->qfull = 0;
        }
-       spin_unlock_bh(&fc->fcoe_pending_queue.lock);
-       return fc->fcoe_pending_queue.qlen;
-}
-
-/**
- * fcoe_insert_wait_queue_head - puts skb to fcoe pending queue head
- * @lp: the fc_port for this skb
- * @skb: the associated skb to be xmitted
- *
- * Returns: none
- **/
-static void fcoe_insert_wait_queue_head(struct fc_lport *lp,
-                                       struct sk_buff *skb)
-{
-       struct fcoe_softc *fc;
+       if (!found) {
+               if (fip->fcf_count >= FCOE_CTLR_FCF_LIMIT)
+                       goto out;
 
-       fc = fcoe_softc(lp);
-       spin_lock_bh(&fc->fcoe_pending_queue.lock);
-       __skb_queue_head(&fc->fcoe_pending_queue, skb);
-       spin_unlock_bh(&fc->fcoe_pending_queue.lock);
-}
+               fcf = kmalloc(sizeof(*fcf), GFP_ATOMIC);
+               if (!fcf)
+                       goto out;
 
-/**
- * fcoe_insert_wait_queue - put the skb into fcoe pending queue tail
- * @lp: the fc_port for this skb
- * @skb: the associated skb to be xmitted
- *
- * Returns: none
- **/
-static void fcoe_insert_wait_queue(struct fc_lport *lp,
-                                  struct sk_buff *skb)
-{
-       struct fcoe_softc *fc;
+               fip->fcf_count++;
+               memcpy(fcf, &new, sizeof(new));
+               list_add(&fcf->list, &fip->fcfs);
+       } else {
+               /*
+                * Flags in advertisements are ignored once the FCF is
+                * selected.  Flags in unsolicited advertisements are
+                * ignored after a usable solicited advertisement
+                * has been received.
+                */
+               if (fcf == fip->sel_fcf) {
+                       fip->ctlr_ka_time -= fcf->fka_period;
+                       fip->ctlr_ka_time += new.fka_period;
+                       if (time_before(fip->ctlr_ka_time, fip->timer.expires))
+                               mod_timer(&fip->timer, fip->ctlr_ka_time);
+               } else if (!fcoe_ctlr_fcf_usable(fcf))
+                       fcf->flags = new.flags;
+               fcf->fka_period = new.fka_period;
+               memcpy(fcf->fcf_mac, new.fcf_mac, ETH_ALEN);
+       }
+       mtu_valid = fcoe_ctlr_mtu_valid(fcf);
+       fcf->time = jiffies;
+       if (!found) {
+               LIBFCOE_FIP_DBG(fip, "New FCF for fab %16.16llx "
+                               "map %x val %d\n",
+                               fcf->fabric_name, fcf->fc_map, mtu_valid);
+       }
 
-       fc = fcoe_softc(lp);
-       spin_lock_bh(&fc->fcoe_pending_queue.lock);
-       __skb_queue_tail(&fc->fcoe_pending_queue, skb);
-       spin_unlock_bh(&fc->fcoe_pending_queue.lock);
-}
+       /*
+        * If this advertisement is not solicited and our max receive size
+        * hasn't been verified, send a solicited advertisement.
+        */
+       if (!mtu_valid)
+               fcoe_ctlr_solicit(fip, fcf);
 
-/**
- * fcoe_dev_setup - setup link change notification interface
- *
- **/
-static void fcoe_dev_setup(void)
-{
        /*
-        * here setup a interface specific wd time to
-        * monitor the link state
+        * If its been a while since we did a solicit, and this is
+        * the first advertisement we've received, do a multicast
+        * solicitation to gather as many advertisements as we can
+        * before selection occurs.
         */
-       register_netdevice_notifier(&fcoe_notifier);
-}
+       if (first && time_after(jiffies, fip->sol_time + sol_tov))
+               fcoe_ctlr_solicit(fip, NULL);
 
-/**
- * fcoe_dev_setup - cleanup link change notification interface
- **/
-static void fcoe_dev_cleanup(void)
-{
-       unregister_netdevice_notifier(&fcoe_notifier);
+       /*
+        * If this is the first validated FCF, note the time and
+        * set a timer to trigger selection.
+        */
+       if (mtu_valid && !fip->sel_time && fcoe_ctlr_fcf_usable(fcf)) {
+               fip->sel_time = jiffies +
+                       msecs_to_jiffies(FCOE_CTLR_START_DELAY);
+               if (!timer_pending(&fip->timer) ||
+                   time_before(fip->sel_time, fip->timer.expires))
+                       mod_timer(&fip->timer, fip->sel_time);
+       }
+out:
+       spin_unlock_bh(&fip->lock);
 }
 
 /**
- * fcoe_device_notification - netdev event notification callback
- * @notifier: context of the notification
- * @event: type of event
- * @ptr: fixed array for output parsed ifname
- *
- * This function is called by the ethernet driver in case of link change event
- *
- * Returns: 0 for success
- **/
-static int fcoe_device_notification(struct notifier_block *notifier,
-                                   ulong event, void *ptr)
+ * fcoe_ctlr_recv_els() - Handle an incoming FIP encapsulated ELS frame
+ * @fip: The FCoE controller which received the packet
+ * @skb: The received FIP packet
+ */
+static void fcoe_ctlr_recv_els(struct fcoe_ctlr *fip, struct sk_buff *skb)
 {
-       struct fc_lport *lp = NULL;
-       struct net_device *real_dev = ptr;
-       struct fcoe_softc *fc;
+       struct fc_lport *lport = fip->lp;
+       struct fip_header *fiph;
+       struct fc_frame *fp = (struct fc_frame *)skb;
+       struct fc_frame_header *fh = NULL;
+       struct fip_desc *desc;
+       struct fip_encaps *els;
        struct fcoe_dev_stats *stats;
-       u32 new_link_up;
-       u32 mfs;
-       int rc = NOTIFY_OK;
-
-       read_lock(&fcoe_hostlist_lock);
-       list_for_each_entry(fc, &fcoe_hostlist, list) {
-               if (fc->real_dev == real_dev) {
-                       lp = fc->lp;
+       enum fip_desc_type els_dtype = 0;
+       u8 els_op;
+       u8 sub;
+       u8 granted_mac[ETH_ALEN] = { 0 };
+       size_t els_len = 0;
+       size_t rlen;
+       size_t dlen;
+
+       fiph = (struct fip_header *)skb->data;
+       sub = fiph->fip_subcode;
+       if (sub != FIP_SC_REQ && sub != FIP_SC_REP)
+               goto drop;
+
+       rlen = ntohs(fiph->fip_dl_len) * 4;
+       if (rlen + sizeof(*fiph) > skb->len)
+               goto drop;
+
+       desc = (struct fip_desc *)(fiph + 1);
+       while (rlen > 0) {
+               dlen = desc->fip_dlen * FIP_BPW;
+               if (dlen < sizeof(*desc) || dlen > rlen)
+                       goto drop;
+               switch (desc->fip_dtype) {
+               case FIP_DT_MAC:
+                       if (dlen != sizeof(struct fip_mac_desc))
+                               goto len_err;
+                       memcpy(granted_mac,
+                              ((struct fip_mac_desc *)desc)->fd_mac,
+                              ETH_ALEN);
+                       if (!is_valid_ether_addr(granted_mac)) {
+                               LIBFCOE_FIP_DBG(fip, "Invalid MAC address "
+                                               "in FIP ELS\n");
+                               goto drop;
+                       }
+                       memcpy(fr_cb(fp)->granted_mac, granted_mac, ETH_ALEN);
+                       break;
+               case FIP_DT_FLOGI:
+               case FIP_DT_FDISC:
+               case FIP_DT_LOGO:
+               case FIP_DT_ELP:
+                       if (fh)
+                               goto drop;
+                       if (dlen < sizeof(*els) + sizeof(*fh) + 1)
+                               goto len_err;
+                       els_len = dlen - sizeof(*els);
+                       els = (struct fip_encaps *)desc;
+                       fh = (struct fc_frame_header *)(els + 1);
+                       els_dtype = desc->fip_dtype;
                        break;
+               default:
+                       LIBFCOE_FIP_DBG(fip, "unexpected descriptor type %x "
+                                       "in FIP adv\n", desc->fip_dtype);
+                       /* standard says ignore unknown descriptors >= 128 */
+                       if (desc->fip_dtype < FIP_DT_VENDOR_BASE)
+                               goto drop;
+                       continue;
                }
-       }
-       read_unlock(&fcoe_hostlist_lock);
-       if (lp == NULL) {
-               rc = NOTIFY_DONE;
-               goto out;
+               desc = (struct fip_desc *)((char *)desc + dlen);
+               rlen -= dlen;
        }
 
-       new_link_up = lp->link_up;
-       switch (event) {
-       case NETDEV_DOWN:
-       case NETDEV_GOING_DOWN:
-               new_link_up = 0;
-               break;
-       case NETDEV_UP:
-       case NETDEV_CHANGE:
-               new_link_up = !fcoe_link_ok(lp);
-               break;
-       case NETDEV_CHANGEMTU:
-               mfs = fc->real_dev->mtu -
-                       (sizeof(struct fcoe_hdr) +
-                        sizeof(struct fcoe_crc_eof));
-               if (mfs >= FC_MIN_MAX_FRAME)
-                       fc_set_mfs(lp, mfs);
-               new_link_up = !fcoe_link_ok(lp);
-               break;
-       case NETDEV_REGISTER:
-               break;
-       default:
-               FC_DBG("unknown event %ld call", event);
-       }
-       if (lp->link_up != new_link_up) {
-               if (new_link_up)
-                       fc_linkup(lp);
-               else {
-                       stats = lp->dev_stats[smp_processor_id()];
-                       if (stats)
-                               stats->LinkFailureCount++;
-                       fc_linkdown(lp);
-                       fcoe_clean_pending_queue(lp);
-               }
-       }
-out:
-       return rc;
-}
+       if (!fh)
+               goto drop;
+       els_op = *(u8 *)(fh + 1);
 
-/**
- * fcoe_if_to_netdev - parse a name buffer to get netdev
- * @ifname: fixed array for output parsed ifname
- * @buffer: incoming buffer to be copied
- *
- * Returns: NULL or ptr to netdeive
- **/
-static struct net_device *fcoe_if_to_netdev(const char *buffer)
-{
-       char *cp;
-       char ifname[IFNAMSIZ + 2];
-
-       if (buffer) {
-               strlcpy(ifname, buffer, IFNAMSIZ);
-               cp = ifname + strlen(ifname);
-               while (--cp >= ifname && *cp == '\n')
-                       *cp = '\0';
-               return dev_get_by_name(&init_net, ifname);
-       }
-       return NULL;
+       if (els_dtype == FIP_DT_FLOGI && sub == FIP_SC_REP &&
+           fip->flogi_oxid == ntohs(fh->fh_ox_id) &&
+           els_op == ELS_LS_ACC && is_valid_ether_addr(granted_mac))
+               fip->flogi_oxid = FC_XID_UNKNOWN;
+
+       /*
+        * Convert skb into an fc_frame containing only the ELS.
+        */
+       skb_pull(skb, (u8 *)fh - skb->data);
+       skb_trim(skb, els_len);
+       fp = (struct fc_frame *)skb;
+       fc_frame_init(fp);
+       fr_sof(fp) = FC_SOF_I3;
+       fr_eof(fp) = FC_EOF_T;
+       fr_dev(fp) = lport;
+
+       stats = per_cpu_ptr(lport->dev_stats, get_cpu());
+       stats->RxFrames++;
+       stats->RxWords += skb->len / FIP_BPW;
+       put_cpu();
+
+       fc_exch_recv(lport, fp);
+       return;
+
+len_err:
+       LIBFCOE_FIP_DBG(fip, "FIP length error in descriptor type %x len %zu\n",
+                       desc->fip_dtype, dlen);
+drop:
+       kfree_skb(skb);
 }
 
 /**
- * fcoe_netdev_to_module_owner - finds out the nic drive moddule of the netdev
- * @netdev: the target netdev
+ * fcoe_ctlr_recv_els() - Handle an incoming link reset frame
+ * @fip: The FCoE controller that received the frame
+ * @fh:         The received FIP header
  *
- * Returns: ptr to the struct module, NULL for failure
- **/
-static struct module *fcoe_netdev_to_module_owner(
-       const struct net_device *netdev)
+ * There may be multiple VN_Port descriptors.
+ * The overall length has already been checked.
+ */
+static void fcoe_ctlr_recv_clr_vlink(struct fcoe_ctlr *fip,
+                                    struct fip_header *fh)
 {
-       struct device *dev;
+       struct fip_desc *desc;
+       struct fip_mac_desc *mp;
+       struct fip_wwn_desc *wp;
+       struct fip_vn_desc *vp;
+       size_t rlen;
+       size_t dlen;
+       struct fcoe_fcf *fcf = fip->sel_fcf;
+       struct fc_lport *lport = fip->lp;
+       u32     desc_mask;
+
+       LIBFCOE_FIP_DBG(fip, "Clear Virtual Link received\n");
+
+       if (!fcf || !lport->port_id)
+               return;
 
-       if (!netdev)
-               return NULL;
+       /*
+        * mask of required descriptors.  Validating each one clears its bit.
+        */
+       desc_mask = BIT(FIP_DT_MAC) | BIT(FIP_DT_NAME) | BIT(FIP_DT_VN_ID);
+
+       rlen = ntohs(fh->fip_dl_len) * FIP_BPW;
+       desc = (struct fip_desc *)(fh + 1);
+       while (rlen >= sizeof(*desc)) {
+               dlen = desc->fip_dlen * FIP_BPW;
+               if (dlen > rlen)
+                       return;
+               switch (desc->fip_dtype) {
+               case FIP_DT_MAC:
+                       mp = (struct fip_mac_desc *)desc;
+                       if (dlen < sizeof(*mp))
+                               return;
+                       if (compare_ether_addr(mp->fd_mac, fcf->fcf_mac))
+                               return;
+                       desc_mask &= ~BIT(FIP_DT_MAC);
+                       break;
+               case FIP_DT_NAME:
+                       wp = (struct fip_wwn_desc *)desc;
+                       if (dlen < sizeof(*wp))
+                               return;
+                       if (get_unaligned_be64(&wp->fd_wwn) != fcf->switch_name)
+                               return;
+                       desc_mask &= ~BIT(FIP_DT_NAME);
+                       break;
+               case FIP_DT_VN_ID:
+                       vp = (struct fip_vn_desc *)desc;
+                       if (dlen < sizeof(*vp))
+                               return;
+                       if (compare_ether_addr(vp->fd_mac,
+                                              fip->get_src_addr(lport)) == 0 &&
+                           get_unaligned_be64(&vp->fd_wwpn) == lport->wwpn &&
+                           ntoh24(vp->fd_fc_id) == lport->port_id)
+                               desc_mask &= ~BIT(FIP_DT_VN_ID);
+                       break;
+               default:
+                       /* standard says ignore unknown descriptors >= 128 */
+                       if (desc->fip_dtype < FIP_DT_VENDOR_BASE)
+                               return;
+                       break;
+               }
+               desc = (struct fip_desc *)((char *)desc + dlen);
+               rlen -= dlen;
+       }
 
-       dev = netdev->dev.parent;
-       if (!dev)
-               return NULL;
+       /*
+        * reset only if all required descriptors were present and valid.
+        */
+       if (desc_mask) {
+               LIBFCOE_FIP_DBG(fip, "missing descriptors mask %x\n",
+                               desc_mask);
+       } else {
+               LIBFCOE_FIP_DBG(fip, "performing Clear Virtual Link\n");
 
-       if (!dev->driver)
-               return NULL;
+               spin_lock_bh(&fip->lock);
+               per_cpu_ptr(lport->dev_stats,
+                           smp_processor_id())->VLinkFailureCount++;
+               fcoe_ctlr_reset(fip);
+               spin_unlock_bh(&fip->lock);
 
-       return dev->driver->owner;
+               fc_lport_reset(fip->lp);
+               fcoe_ctlr_solicit(fip, NULL);
+       }
 }
 
 /**
- * fcoe_ethdrv_get - holds the nic driver module by  try_module_get() for
- * the corresponding netdev.
- * @netdev: the target netdev
+ * fcoe_ctlr_recv() - Receive a FIP packet
+ * @fip: The FCoE controller that received the packet
+ * @skb: The received FIP packet
  *
- * Returns: 0 for succsss
- **/
-static int fcoe_ethdrv_get(const struct net_device *netdev)
+ * This may be called from either NET_RX_SOFTIRQ or IRQ.
+ */
+void fcoe_ctlr_recv(struct fcoe_ctlr *fip, struct sk_buff *skb)
 {
-       struct module *owner;
-
-       owner = fcoe_netdev_to_module_owner(netdev);
-       if (owner) {
-               printk(KERN_DEBUG "fcoe:hold driver module %s for %s\n",
-                      module_name(owner), netdev->name);
-               return  try_module_get(owner);
-       }
-       return -ENODEV;
+       skb_queue_tail(&fip->fip_recv_list, skb);
+       schedule_work(&fip->recv_work);
 }
+EXPORT_SYMBOL(fcoe_ctlr_recv);
 
 /**
- * fcoe_ethdrv_get - releases the nic driver module by module_put for
- * the corresponding netdev.
- * @netdev: the target netdev
+ * fcoe_ctlr_recv_handler() - Receive a FIP frame
+ * @fip: The FCoE controller that received the frame
+ * @skb: The received FIP frame
  *
- * Returns: 0 for succsss
- **/
-static int fcoe_ethdrv_put(const struct net_device *netdev)
+ * Returns non-zero if the frame is dropped.
+ */
+static int fcoe_ctlr_recv_handler(struct fcoe_ctlr *fip, struct sk_buff *skb)
 {
-       struct module *owner;
+       struct fip_header *fiph;
+       struct ethhdr *eh;
+       enum fip_state state;
+       u16 op;
+       u8 sub;
+
+       if (skb_linearize(skb))
+               goto drop;
+       if (skb->len < sizeof(*fiph))
+               goto drop;
+       eh = eth_hdr(skb);
+       if (compare_ether_addr(eh->h_dest, fip->ctl_src_addr) &&
+           compare_ether_addr(eh->h_dest, FIP_ALL_ENODE_MACS))
+               goto drop;
+       fiph = (struct fip_header *)skb->data;
+       op = ntohs(fiph->fip_op);
+       sub = fiph->fip_subcode;
+
+       if (FIP_VER_DECAPS(fiph->fip_ver) != FIP_VER)
+               goto drop;
+       if (ntohs(fiph->fip_dl_len) * FIP_BPW + sizeof(*fiph) > skb->len)
+               goto drop;
+
+       spin_lock_bh(&fip->lock);
+       state = fip->state;
+       if (state == FIP_ST_AUTO) {
+               fip->map_dest = 0;
+               fip->state = FIP_ST_ENABLED;
+               state = FIP_ST_ENABLED;
+               LIBFCOE_FIP_DBG(fip, "Using FIP mode\n");
+       }
+       spin_unlock_bh(&fip->lock);
+       if (state != FIP_ST_ENABLED)
+               goto drop;
 
-       owner = fcoe_netdev_to_module_owner(netdev);
-       if (owner) {
-               printk(KERN_DEBUG "fcoe:release driver module %s for %s\n",
-                      module_name(owner), netdev->name);
-               module_put(owner);
+       if (op == FIP_OP_LS) {
+               fcoe_ctlr_recv_els(fip, skb);   /* consumes skb */
                return 0;
        }
-       return -ENODEV;
+       if (op == FIP_OP_DISC && sub == FIP_SC_ADV)
+               fcoe_ctlr_recv_adv(fip, skb);
+       else if (op == FIP_OP_CTRL && sub == FIP_SC_CLR_VLINK)
+               fcoe_ctlr_recv_clr_vlink(fip, fiph);
+       kfree_skb(skb);
+       return 0;
+drop:
+       kfree_skb(skb);
+       return -1;
 }
 
 /**
- * fcoe_destroy- handles the destroy from sysfs
- * @buffer: expcted to be a eth if name
- * @kp: associated kernel param
+ * fcoe_ctlr_select() - Select the best FCF (if possible)
+ * @fip: The FCoE controller
+ *
+ * If there are conflicting advertisements, no FCF can be chosen.
  *
- * Returns: 0 for success
- **/
-static int fcoe_destroy(const char *buffer, struct kernel_param *kp)
+ * Called with lock held.
+ */
+static void fcoe_ctlr_select(struct fcoe_ctlr *fip)
 {
-       int rc;
-       struct net_device *netdev;
-
-       netdev = fcoe_if_to_netdev(buffer);
-       if (!netdev) {
-               rc = -ENODEV;
-               goto out_nodev;
-       }
-       /* look for existing lport */
-       if (!fcoe_hostlist_lookup(netdev)) {
-               rc = -ENODEV;
-               goto out_putdev;
-       }
-       /* pass to transport */
-       rc = fcoe_transport_release(netdev);
-       if (rc) {
-               printk(KERN_ERR "fcoe: fcoe_transport_release(%s) failed\n",
-                      netdev->name);
-               rc = -EIO;
-               goto out_putdev;
+       struct fcoe_fcf *fcf;
+       struct fcoe_fcf *best = NULL;
+
+       list_for_each_entry(fcf, &fip->fcfs, list) {
+               LIBFCOE_FIP_DBG(fip, "consider FCF for fab %16.16llx "
+                               "VFID %d map %x val %d\n",
+                               fcf->fabric_name, fcf->vfid,
+                               fcf->fc_map, fcoe_ctlr_mtu_valid(fcf));
+               if (!fcoe_ctlr_fcf_usable(fcf)) {
+                       LIBFCOE_FIP_DBG(fip, "FCF for fab %16.16llx "
+                                       "map %x %svalid %savailable\n",
+                                       fcf->fabric_name, fcf->fc_map,
+                                       (fcf->flags & FIP_FL_SOL) ? "" : "in",
+                                       (fcf->flags & FIP_FL_AVAIL) ?
+                                       "" : "un");
+                       continue;
+               }
+               if (!best) {
+                       best = fcf;
+                       continue;
+               }
+               if (fcf->fabric_name != best->fabric_name ||
+                   fcf->vfid != best->vfid ||
+                   fcf->fc_map != best->fc_map) {
+                       LIBFCOE_FIP_DBG(fip, "Conflicting fabric, VFID, "
+                                       "or FC-MAP\n");
+                       return;
+               }
+               if (fcf->pri < best->pri)
+                       best = fcf;
        }
-       fcoe_ethdrv_put(netdev);
-       rc = 0;
-out_putdev:
-       dev_put(netdev);
-out_nodev:
-       return rc;
+       fip->sel_fcf = best;
 }
 
 /**
- * fcoe_create - handles the create call from sysfs
- * @buffer: expcted to be a eth if name
- * @kp: associated kernel param
+ * fcoe_ctlr_timeout() - FIP timeout handler
+ * @arg: The FCoE controller that timed out
  *
- * Returns: 0 for success
- **/
-static int fcoe_create(const char *buffer, struct kernel_param *kp)
+ * Ages FCFs.  Triggers FCF selection if possible.  Sends keep-alives.
+ */
+static void fcoe_ctlr_timeout(unsigned long arg)
 {
-       int rc;
-       struct net_device *netdev;
-
-       netdev = fcoe_if_to_netdev(buffer);
-       if (!netdev) {
-               rc = -ENODEV;
-               goto out_nodev;
-       }
-       /* look for existing lport */
-       if (fcoe_hostlist_lookup(netdev)) {
-               rc = -EEXIST;
-               goto out_putdev;
-       }
-       fcoe_ethdrv_get(netdev);
-
-       /* pass to transport */
-       rc = fcoe_transport_attach(netdev);
-       if (rc) {
-               printk(KERN_ERR "fcoe: fcoe_transport_attach(%s) failed\n",
-                      netdev->name);
-               fcoe_ethdrv_put(netdev);
-               rc = -EIO;
-               goto out_putdev;
+       struct fcoe_ctlr *fip = (struct fcoe_ctlr *)arg;
+       struct fcoe_fcf *sel;
+       struct fcoe_fcf *fcf;
+       unsigned long next_timer = jiffies + msecs_to_jiffies(FIP_VN_KA_PERIOD);
+
+       spin_lock_bh(&fip->lock);
+       if (fip->state == FIP_ST_DISABLED) {
+               spin_unlock_bh(&fip->lock);
+               return;
        }
-       rc = 0;
-out_putdev:
-       dev_put(netdev);
-out_nodev:
-       return rc;
-}
 
-module_param_call(create, fcoe_create, NULL, NULL, S_IWUSR);
-__MODULE_PARM_TYPE(create, "string");
-MODULE_PARM_DESC(create, "Create fcoe port using net device passed in.");
-module_param_call(destroy, fcoe_destroy, NULL, NULL, S_IWUSR);
-__MODULE_PARM_TYPE(destroy, "string");
-MODULE_PARM_DESC(destroy, "Destroy fcoe port");
+       fcf = fip->sel_fcf;
+       fcoe_ctlr_age_fcfs(fip);
 
-/*
- * fcoe_link_ok - check if link is ok for the fc_lport
- * @lp: ptr to the fc_lport
- *
- * Any permanently-disqualifying conditions have been previously checked.
- * This also updates the speed setting, which may change with link for 100/1000.
- *
- * This function should probably be checking for PAUSE support at some point
- * in the future. Currently Per-priority-pause is not determinable using
- * ethtool, so we shouldn't be restrictive until that problem is resolved.
- *
- * Returns: 0 if link is OK for use by FCoE.
- *
- */
-int fcoe_link_ok(struct fc_lport *lp)
-{
-       struct fcoe_softc *fc = fcoe_softc(lp);
-       struct net_device *dev = fc->real_dev;
-       struct ethtool_cmd ecmd = { ETHTOOL_GSET };
-       int rc = 0;
-
-       if ((dev->flags & IFF_UP) && netif_carrier_ok(dev)) {
-               dev = fc->phys_dev;
-               if (dev->ethtool_ops->get_settings) {
-                       dev->ethtool_ops->get_settings(dev, &ecmd);
-                       lp->link_supported_speeds &=
-                               ~(FC_PORTSPEED_1GBIT | FC_PORTSPEED_10GBIT);
-                       if (ecmd.supported & (SUPPORTED_1000baseT_Half |
-                                             SUPPORTED_1000baseT_Full))
-                               lp->link_supported_speeds |= FC_PORTSPEED_1GBIT;
-                       if (ecmd.supported & SUPPORTED_10000baseT_Full)
-                               lp->link_supported_speeds |=
-                                       FC_PORTSPEED_10GBIT;
-                       if (ecmd.speed == SPEED_1000)
-                               lp->link_speed = FC_PORTSPEED_1GBIT;
-                       if (ecmd.speed == SPEED_10000)
-                               lp->link_speed = FC_PORTSPEED_10GBIT;
+       sel = fip->sel_fcf;
+       if (!sel && fip->sel_time && time_after_eq(jiffies, fip->sel_time)) {
+               fcoe_ctlr_select(fip);
+               sel = fip->sel_fcf;
+               fip->sel_time = 0;
+       }
+
+       if (sel != fcf) {
+               fcf = sel;              /* the old FCF may have been freed */
+               if (sel) {
+                       printk(KERN_INFO "libfcoe: host%d: FIP selected "
+                              "Fibre-Channel Forwarder MAC %pM\n",
+                              fip->lp->host->host_no, sel->fcf_mac);
+                       memcpy(fip->dest_addr, sel->fcf_mac, ETH_ALEN);
+                       fip->port_ka_time = jiffies +
+                               msecs_to_jiffies(FIP_VN_KA_PERIOD);
+                       fip->ctlr_ka_time = jiffies + sel->fka_period;
+               } else {
+                       printk(KERN_NOTICE "libfcoe: host%d: "
+                              "FIP Fibre-Channel Forwarder timed out.  "
+                              "Starting FCF discovery.\n",
+                              fip->lp->host->host_no);
+                       fip->reset_req = 1;
+                       schedule_work(&fip->timer_work);
                }
-       } else
-               rc = -1;
+       }
 
-       return rc;
-}
-EXPORT_SYMBOL_GPL(fcoe_link_ok);
+       if (sel && !sel->fd_flags) {
+               if (time_after_eq(jiffies, fip->ctlr_ka_time)) {
+                       fip->ctlr_ka_time = jiffies + sel->fka_period;
+                       fip->send_ctlr_ka = 1;
+               }
+               if (time_after(next_timer, fip->ctlr_ka_time))
+                       next_timer = fip->ctlr_ka_time;
 
-/*
- * fcoe_percpu_clean - frees skb of the corresponding lport from the per
- * cpu queue.
- * @lp: the fc_lport
- */
-void fcoe_percpu_clean(struct fc_lport *lp)
-{
-       int idx;
-       struct fcoe_percpu_s *pp;
-       struct fcoe_rcv_info *fr;
-       struct sk_buff_head *list;
-       struct sk_buff *skb, *next;
-       struct sk_buff *head;
-
-       for (idx = 0; idx < NR_CPUS; idx++) {
-               if (fcoe_percpu[idx]) {
-                       pp = fcoe_percpu[idx];
-                       spin_lock_bh(&pp->fcoe_rx_list.lock);
-                       list = &pp->fcoe_rx_list;
-                       head = list->next;
-                       for (skb = head; skb != (struct sk_buff *)list;
-                            skb = next) {
-                               next = skb->next;
-                               fr = fcoe_dev_from_skb(skb);
-                               if (fr->fr_dev == lp) {
-                                       __skb_unlink(skb, list);
-                                       kfree_skb(skb);
-                               }
-                       }
-                       spin_unlock_bh(&pp->fcoe_rx_list.lock);
+               if (time_after_eq(jiffies, fip->port_ka_time)) {
+                       fip->port_ka_time = jiffies +
+                               msecs_to_jiffies(FIP_VN_KA_PERIOD);
+                       fip->send_port_ka = 1;
                }
+               if (time_after(next_timer, fip->port_ka_time))
+                       next_timer = fip->port_ka_time;
+               mod_timer(&fip->timer, next_timer);
+       } else if (fip->sel_time) {
+               next_timer = fip->sel_time +
+                       msecs_to_jiffies(FCOE_CTLR_START_DELAY);
+               mod_timer(&fip->timer, next_timer);
        }
+       if (fip->send_ctlr_ka || fip->send_port_ka)
+               schedule_work(&fip->timer_work);
+       spin_unlock_bh(&fip->lock);
 }
-EXPORT_SYMBOL_GPL(fcoe_percpu_clean);
 
 /**
- * fcoe_clean_pending_queue - dequeue skb and free it
- * @lp: the corresponding fc_lport
+ * fcoe_ctlr_timer_work() - Worker thread function for timer work
+ * @work: Handle to a FCoE controller
  *
- * Returns: none
- **/
-void fcoe_clean_pending_queue(struct fc_lport *lp)
+ * Sends keep-alives and resets which must not
+ * be called from the timer directly, since they use a mutex.
+ */
+static void fcoe_ctlr_timer_work(struct work_struct *work)
 {
-       struct fcoe_softc  *fc = lport_priv(lp);
-       struct sk_buff *skb;
-
-       spin_lock_bh(&fc->fcoe_pending_queue.lock);
-       while ((skb = __skb_dequeue(&fc->fcoe_pending_queue)) != NULL) {
-               spin_unlock_bh(&fc->fcoe_pending_queue.lock);
-               kfree_skb(skb);
-               spin_lock_bh(&fc->fcoe_pending_queue.lock);
+       struct fcoe_ctlr *fip;
+       struct fc_lport *vport;
+       u8 *mac;
+       int reset;
+
+       fip = container_of(work, struct fcoe_ctlr, timer_work);
+       spin_lock_bh(&fip->lock);
+       reset = fip->reset_req;
+       fip->reset_req = 0;
+       spin_unlock_bh(&fip->lock);
+
+       if (reset)
+               fc_lport_reset(fip->lp);
+
+       if (fip->send_ctlr_ka) {
+               fip->send_ctlr_ka = 0;
+               fcoe_ctlr_send_keep_alive(fip, NULL, 0, fip->ctl_src_addr);
+       }
+       if (fip->send_port_ka) {
+               fip->send_port_ka = 0;
+               mutex_lock(&fip->lp->lp_mutex);
+               mac = fip->get_src_addr(fip->lp);
+               fcoe_ctlr_send_keep_alive(fip, fip->lp, 1, mac);
+               list_for_each_entry(vport, &fip->lp->vports, list) {
+                       mac = fip->get_src_addr(vport);
+                       fcoe_ctlr_send_keep_alive(fip, vport, 1, mac);
+               }
+               mutex_unlock(&fip->lp->lp_mutex);
        }
-       spin_unlock_bh(&fc->fcoe_pending_queue.lock);
 }
-EXPORT_SYMBOL_GPL(fcoe_clean_pending_queue);
 
 /**
- * libfc_host_alloc - allocate a Scsi_Host with room for the fc_lport
- * @sht: ptr to the scsi host templ
- * @priv_size: size of private data after fc_lport
- *
- * Returns: ptr to Scsi_Host
- * TODO - to libfc?
+ * fcoe_ctlr_recv_work() - Worker thread function for receiving FIP frames
+ * @recv_work: Handle to a FCoE controller
  */
-static inline struct Scsi_Host *libfc_host_alloc(
-       struct scsi_host_template *sht, int priv_size)
+static void fcoe_ctlr_recv_work(struct work_struct *recv_work)
 {
-       return scsi_host_alloc(sht, sizeof(struct fc_lport) + priv_size);
+       struct fcoe_ctlr *fip;
+       struct sk_buff *skb;
+
+       fip = container_of(recv_work, struct fcoe_ctlr, recv_work);
+       while ((skb = skb_dequeue(&fip->fip_recv_list)))
+               fcoe_ctlr_recv_handler(fip, skb);
 }
 
 /**
- * fcoe_host_alloc - allocate a Scsi_Host with room for the fcoe_softc
- * @sht: ptr to the scsi host templ
- * @priv_size: size of private data after fc_lport
+ * fcoe_ctlr_recv_flogi() - Snoop pre-FIP receipt of FLOGI response
+ * @fip: The FCoE controller
+ * @fp:         The FC frame to snoop
  *
- * Returns: ptr to Scsi_Host
- */
-struct Scsi_Host *fcoe_host_alloc(struct scsi_host_template *sht, int priv_size)
-{
-       return libfc_host_alloc(sht, sizeof(struct fcoe_softc) + priv_size);
-}
-EXPORT_SYMBOL_GPL(fcoe_host_alloc);
-
-/*
- * fcoe_reset - resets the fcoe
- * @shost: shost the reset is from
+ * Snoop potential response to FLOGI or even incoming FLOGI.
  *
- * Returns: always 0
+ * The caller has checked that we are waiting for login as indicated
+ * by fip->flogi_oxid != FC_XID_UNKNOWN.
+ *
+ * The caller is responsible for freeing the frame.
+ * Fill in the granted_mac address.
+ *
+ * Return non-zero if the frame should not be delivered to libfc.
  */
-int fcoe_reset(struct Scsi_Host *shost)
+int fcoe_ctlr_recv_flogi(struct fcoe_ctlr *fip, struct fc_lport *lport,
+                        struct fc_frame *fp)
 {
-       struct fc_lport *lport = shost_priv(shost);
-       fc_lport_reset(lport);
+       struct fc_frame_header *fh;
+       u8 op;
+       u8 *sa;
+
+       sa = eth_hdr(&fp->skb)->h_source;
+       fh = fc_frame_header_get(fp);
+       if (fh->fh_type != FC_TYPE_ELS)
+               return 0;
+
+       op = fc_frame_payload_op(fp);
+       if (op == ELS_LS_ACC && fh->fh_r_ctl == FC_RCTL_ELS_REP &&
+           fip->flogi_oxid == ntohs(fh->fh_ox_id)) {
+
+               spin_lock_bh(&fip->lock);
+               if (fip->state != FIP_ST_AUTO && fip->state != FIP_ST_NON_FIP) {
+                       spin_unlock_bh(&fip->lock);
+                       return -EINVAL;
+               }
+               fip->state = FIP_ST_NON_FIP;
+               LIBFCOE_FIP_DBG(fip,
+                               "received FLOGI LS_ACC using non-FIP mode\n");
+
+               /*
+                * FLOGI accepted.
+                * If the src mac addr is FC_OUI-based, then we mark the
+                * address_mode flag to use FC_OUI-based Ethernet DA.
+                * Otherwise we use the FCoE gateway addr
+                */
+               if (!compare_ether_addr(sa, (u8[6])FC_FCOE_FLOGI_MAC)) {
+                       fip->map_dest = 1;
+               } else {
+                       memcpy(fip->dest_addr, sa, ETH_ALEN);
+                       fip->map_dest = 0;
+               }
+               fip->flogi_oxid = FC_XID_UNKNOWN;
+               spin_unlock_bh(&fip->lock);
+               fc_fcoe_set_mac(fr_cb(fp)->granted_mac, fh->fh_d_id);
+       } else if (op == ELS_FLOGI && fh->fh_r_ctl == FC_RCTL_ELS_REQ && sa) {
+               /*
+                * Save source MAC for point-to-point responses.
+                */
+               spin_lock_bh(&fip->lock);
+               if (fip->state == FIP_ST_AUTO || fip->state == FIP_ST_NON_FIP) {
+                       memcpy(fip->dest_addr, sa, ETH_ALEN);
+                       fip->map_dest = 0;
+                       if (fip->state == FIP_ST_AUTO)
+                               LIBFCOE_FIP_DBG(fip, "received non-FIP FLOGI. "
+                                               "Setting non-FIP mode\n");
+                       fip->state = FIP_ST_NON_FIP;
+               }
+               spin_unlock_bh(&fip->lock);
+       }
        return 0;
 }
-EXPORT_SYMBOL_GPL(fcoe_reset);
+EXPORT_SYMBOL(fcoe_ctlr_recv_flogi);
 
-/*
- * fcoe_wwn_from_mac - converts 48-bit IEEE MAC address to 64-bit FC WWN.
- * @mac: mac address
- * @scheme: check port
- * @port: port indicator for converting
+/**
+ * fcoe_wwn_from_mac() - Converts a 48-bit IEEE MAC address to a 64-bit FC WWN
+ * @mac:    The MAC address to convert
+ * @scheme: The scheme to use when converting
+ * @port:   The port indicator for converting
  *
  * Returns: u64 fc world wide name
  */
@@ -1279,225 +1380,28 @@ u64 fcoe_wwn_from_mac(unsigned char mac[MAX_ADDR_LEN],
        return wwn;
 }
 EXPORT_SYMBOL_GPL(fcoe_wwn_from_mac);
-/*
- * fcoe_hostlist_lookup_softc - find the corresponding lport by a given device
- * @device: this is currently ptr to net_device
- *
- * Returns: NULL or the located fcoe_softc
- */
-static struct fcoe_softc *fcoe_hostlist_lookup_softc(
-       const struct net_device *dev)
-{
-       struct fcoe_softc *fc;
-
-       read_lock(&fcoe_hostlist_lock);
-       list_for_each_entry(fc, &fcoe_hostlist, list) {
-               if (fc->real_dev == dev) {
-                       read_unlock(&fcoe_hostlist_lock);
-                       return fc;
-               }
-       }
-       read_unlock(&fcoe_hostlist_lock);
-       return NULL;
-}
-
-/*
- * fcoe_hostlist_lookup - find the corresponding lport by netdev
- * @netdev: ptr to net_device
- *
- * Returns: 0 for success
- */
-struct fc_lport *fcoe_hostlist_lookup(const struct net_device *netdev)
-{
-       struct fcoe_softc *fc;
-
-       fc = fcoe_hostlist_lookup_softc(netdev);
-
-       return (fc) ? fc->lp : NULL;
-}
-EXPORT_SYMBOL_GPL(fcoe_hostlist_lookup);
-
-/*
- * fcoe_hostlist_add - add a lport to lports list
- * @lp: ptr to the fc_lport to badded
- *
- * Returns: 0 for success
- */
-int fcoe_hostlist_add(const struct fc_lport *lp)
-{
-       struct fcoe_softc *fc;
-
-       fc = fcoe_hostlist_lookup_softc(fcoe_netdev(lp));
-       if (!fc) {
-               fc = fcoe_softc(lp);
-               write_lock_bh(&fcoe_hostlist_lock);
-               list_add_tail(&fc->list, &fcoe_hostlist);
-               write_unlock_bh(&fcoe_hostlist_lock);
-       }
-       return 0;
-}
-EXPORT_SYMBOL_GPL(fcoe_hostlist_add);
-
-/*
- * fcoe_hostlist_remove - remove a lport from lports list
- * @lp: ptr to the fc_lport to badded
- *
- * Returns: 0 for success
- */
-int fcoe_hostlist_remove(const struct fc_lport *lp)
-{
-       struct fcoe_softc *fc;
-
-       fc = fcoe_hostlist_lookup_softc(fcoe_netdev(lp));
-       BUG_ON(!fc);
-       write_lock_bh(&fcoe_hostlist_lock);
-       list_del(&fc->list);
-       write_unlock_bh(&fcoe_hostlist_lock);
-
-       return 0;
-}
-EXPORT_SYMBOL_GPL(fcoe_hostlist_remove);
 
 /**
- * fcoe_libfc_config - sets up libfc related properties for lport
- * @lp: ptr to the fc_lport
- * @tt: libfc function template
+ * fcoe_libfc_config() - Sets up libfc related properties for local port
+ * @lp: The local port to configure libfc for
+ * @tt: The libfc function template
  *
  * Returns : 0 for success
- **/
-int fcoe_libfc_config(struct fc_lport *lp, struct libfc_function_template *tt)
+ */
+int fcoe_libfc_config(struct fc_lport *lport,
+                     struct libfc_function_template *tt)
 {
        /* Set the function pointers set by the LLDD */
-       memcpy(&lp->tt, tt, sizeof(*tt));
-       if (fc_fcp_init(lp))
+       memcpy(&lport->tt, tt, sizeof(*tt));
+       if (fc_fcp_init(lport))
                return -ENOMEM;
-       fc_exch_init(lp);
-       fc_elsct_init(lp);
-       fc_lport_init(lp);
-       fc_rport_init(lp);
-       fc_disc_init(lp);
+       fc_exch_init(lport);
+       fc_elsct_init(lport);
+       fc_lport_init(lport);
+       fc_rport_init(lport);
+       fc_disc_init(lport);
 
        return 0;
 }
 EXPORT_SYMBOL_GPL(fcoe_libfc_config);
 
-/**
- * fcoe_init - fcoe module loading initialization
- *
- * Initialization routine
- * 1. Will create fc transport software structure
- * 2. initialize the link list of port information structure
- *
- * Returns 0 on success, negative on failure
- **/
-static int __init fcoe_init(void)
-{
-       int cpu;
-       struct fcoe_percpu_s *p;
-
-
-       INIT_LIST_HEAD(&fcoe_hostlist);
-       rwlock_init(&fcoe_hostlist_lock);
-
-#ifdef CONFIG_HOTPLUG_CPU
-       register_cpu_notifier(&fcoe_cpu_notifier);
-#endif /* CONFIG_HOTPLUG_CPU */
-
-       /*
-        * initialize per CPU interrupt thread
-        */
-       for_each_online_cpu(cpu) {
-               p = kzalloc(sizeof(struct fcoe_percpu_s), GFP_KERNEL);
-               if (p) {
-                       p->thread = kthread_create(fcoe_percpu_receive_thread,
-                                                  (void *)p,
-                                                  "fcoethread/%d", cpu);
-
-                       /*
-                        * if there is no error then bind the thread to the cpu
-                        * initialize the semaphore and skb queue head
-                        */
-                       if (likely(!IS_ERR(p->thread))) {
-                               p->cpu = cpu;
-                               fcoe_percpu[cpu] = p;
-                               skb_queue_head_init(&p->fcoe_rx_list);
-                               kthread_bind(p->thread, cpu);
-                               wake_up_process(p->thread);
-                       } else {
-                               fcoe_percpu[cpu] = NULL;
-                               kfree(p);
-
-                       }
-               }
-       }
-
-       /*
-        * setup link change notification
-        */
-       fcoe_dev_setup();
-
-       init_timer(&fcoe_timer);
-       fcoe_timer.data = 0;
-       fcoe_timer.function = fcoe_watchdog;
-       fcoe_timer.expires = (jiffies + (10 * HZ));
-       add_timer(&fcoe_timer);
-
-       /* initiatlize the fcoe transport */
-       fcoe_transport_init();
-
-       fcoe_sw_init();
-
-       return 0;
-}
-module_init(fcoe_init);
-
-/**
- * fcoe_exit - fcoe module unloading cleanup
- *
- * Returns 0 on success, negative on failure
- **/
-static void __exit fcoe_exit(void)
-{
-       u32 idx;
-       struct fcoe_softc *fc, *tmp;
-       struct fcoe_percpu_s *p;
-       struct sk_buff *skb;
-
-       /*
-        * Stop all call back interfaces
-        */
-#ifdef CONFIG_HOTPLUG_CPU
-       unregister_cpu_notifier(&fcoe_cpu_notifier);
-#endif /* CONFIG_HOTPLUG_CPU */
-       fcoe_dev_cleanup();
-
-       /*
-        * stop timer
-        */
-       del_timer_sync(&fcoe_timer);
-
-       /* releases the assocaited fcoe transport for each lport */
-       list_for_each_entry_safe(fc, tmp, &fcoe_hostlist, list)
-               fcoe_transport_release(fc->real_dev);
-
-       for (idx = 0; idx < NR_CPUS; idx++) {
-               if (fcoe_percpu[idx]) {
-                       kthread_stop(fcoe_percpu[idx]->thread);
-                       p = fcoe_percpu[idx];
-                       spin_lock_bh(&p->fcoe_rx_list.lock);
-                       while ((skb = __skb_dequeue(&p->fcoe_rx_list)) != NULL)
-                               kfree_skb(skb);
-                       spin_unlock_bh(&p->fcoe_rx_list.lock);
-                       if (fcoe_percpu[idx]->crc_eof_page)
-                               put_page(fcoe_percpu[idx]->crc_eof_page);
-                       kfree(fcoe_percpu[idx]);
-               }
-       }
-
-       /* remove sw trasnport */
-       fcoe_sw_exit();
-
-       /* detach the transport */
-       fcoe_transport_exit();
-}
-module_exit(fcoe_exit);