[S390] 3270 console: convert from bootmem to slab
[safe/jmp/linux-2.6] / drivers / s390 / block / dasd_diag.c
index 3f9d704..644086b 100644 (file)
@@ -1,4 +1,4 @@
-/* 
+/*
  * File...........: linux/drivers/s390/block/dasd_diag.c
  * Author(s)......: Holger Smolinski <Holger.Smolinski@de.ibm.com>
  * Based on.......: linux/drivers/s390/block/mdisk.c
@@ -8,7 +8,8 @@
  *
  */
 
-#include <linux/config.h>
+#define KMSG_COMPONENT "dasd"
+
 #include <linux/stddef.h>
 #include <linux/kernel.h>
 #include <linux/slab.h>
@@ -25,6 +26,7 @@
 #include <asm/s390_ext.h>
 #include <asm/todclk.h>
 #include <asm/vtoc.h>
+#include <asm/diag.h>
 
 #include "dasd_int.h"
 #include "dasd_diag.h"
@@ -44,13 +46,14 @@ MODULE_LICENSE("GPL");
 #define DIAG_MAX_RETRIES       32
 #define DIAG_TIMEOUT           50 * HZ
 
-struct dasd_discipline dasd_diag_discipline;
+static struct dasd_discipline dasd_diag_discipline;
 
 struct dasd_diag_private {
        struct dasd_diag_characteristics rdc_data;
        struct dasd_diag_rw_io iob;
        struct dasd_diag_init_io iib;
        blocknum_t pt_block;
+       struct ccw_dev_id dev_id;
 };
 
 struct dasd_diag_req {
@@ -64,44 +67,26 @@ static const u8 DASD_DIAG_CMS1[] = { 0xc3, 0xd4, 0xe2, 0xf1 };/* EBCDIC CMS1 */
  * and function code cmd.
  * In case of an exception return 3. Otherwise return result of bitwise OR of
  * resulting condition code and DIAG return code. */
-static __inline__ int
-dia250(void *iob, int cmd)
+static inline int dia250(void *iob, int cmd)
 {
+       register unsigned long reg2 asm ("2") = (unsigned long) iob;
        typedef union {
                struct dasd_diag_init_io init_io;
                struct dasd_diag_rw_io rw_io;
        } addr_type;
        int rc;
 
-       __asm__ __volatile__(
-#ifdef CONFIG_64BIT
-               "       lghi    %0,3\n"
-               "       lgr     0,%3\n"
-               "       diag    0,%2,0x250\n"
-               "0:     ipm     %0\n"
-               "       srl     %0,28\n"
-               "       or      %0,1\n"
-               "1:\n"
-               ".section __ex_table,\"a\"\n"
-               "       .align 8\n"
-               "       .quad  0b,1b\n"
-               ".previous\n"
-#else
-               "       lhi     %0,3\n"
-               "       lr      0,%3\n"
-               "       diag    0,%2,0x250\n"
+       rc = 3;
+       asm volatile(
+               "       diag    2,%2,0x250\n"
                "0:     ipm     %0\n"
                "       srl     %0,28\n"
-               "       or      %0,1\n"
+               "       or      %0,3\n"
                "1:\n"
-               ".section __ex_table,\"a\"\n"
-               "       .align 4\n"
-               "       .long 0b,1b\n"
-               ".previous\n"
-#endif
-               : "=&d" (rc), "=m" (*(addr_type *) iob)
-               : "d" (cmd), "d" (iob), "m" (*(addr_type *) iob)
-               : "0", "1", "cc");
+               EX_TABLE(0b,1b)
+               : "+d" (rc), "=m" (*(addr_type *) iob)
+               : "d" (cmd), "d" (reg2), "m" (*(addr_type *) iob)
+               : "3", "cc");
        return rc;
 }
 
@@ -109,7 +94,7 @@ dia250(void *iob, int cmd)
  * block offset. On success, return zero and set end_block to contain the
  * number of blocks on the device minus the specified offset. Return non-zero
  * otherwise. */
-static __inline__ int
+static inline int
 mdsk_init_io(struct dasd_device *device, unsigned int blocksize,
             blocknum_t offset, blocknum_t *end_block)
 {
@@ -121,7 +106,7 @@ mdsk_init_io(struct dasd_device *device, unsigned int blocksize,
        iib = &private->iib;
        memset(iib, 0, sizeof (struct dasd_diag_init_io));
 
-       iib->dev_nr = _ccw_device_get_device_number(device->cdev);
+       iib->dev_nr = private->dev_id.devno;
        iib->block_size = blocksize;
        iib->offset = offset;
        iib->flaga = DASD_DIAG_FLAGA_DEFAULT;
@@ -136,7 +121,7 @@ mdsk_init_io(struct dasd_device *device, unsigned int blocksize,
 
 /* Remove block I/O environment for device. Return zero on success, non-zero
  * otherwise. */
-static __inline__ int
+static inline int
 mdsk_term_io(struct dasd_device * device)
 {
        struct dasd_diag_private *private;
@@ -146,7 +131,7 @@ mdsk_term_io(struct dasd_device * device)
        private = (struct dasd_diag_private *) device->private;
        iib = &private->iib;
        memset(iib, 0, sizeof (struct dasd_diag_init_io));
-       iib->dev_nr = _ccw_device_get_device_number(device->cdev);
+       iib->dev_nr = private->dev_id.devno;
        rc = dia250(iib, TERM_BIO);
        return rc;
 }
@@ -159,10 +144,10 @@ dasd_diag_erp(struct dasd_device *device)
        int rc;
 
        mdsk_term_io(device);
-       rc = mdsk_init_io(device, device->bp_block, 0, NULL);
+       rc = mdsk_init_io(device, device->block->bp_block, 0, NULL);
        if (rc)
-               DEV_MESSAGE(KERN_WARNING, device, "DIAG ERP unsuccessful, "
-                           "rc=%d", rc);
+               dev_warn(&device->cdev->dev, "DIAG ERP failed with "
+                           "rc=%d\n", rc);
 }
 
 /* Start a given request at the device. Return zero on success, non-zero
@@ -175,17 +160,17 @@ dasd_start_diag(struct dasd_ccw_req * cqr)
        struct dasd_diag_req *dreq;
        int rc;
 
-       device = cqr->device;
+       device = cqr->startdev;
        if (cqr->retries < 0) {
-               DEV_MESSAGE(KERN_WARNING, device, "DIAG start_IO: request %p "
+               DBF_DEV_EVENT(DBF_ERR, device, "DIAG start_IO: request %p "
                            "- no retry left)", cqr);
-               cqr->status = DASD_CQR_FAILED;
+               cqr->status = DASD_CQR_ERROR;
                return -EIO;
        }
        private = (struct dasd_diag_private *) device->private;
        dreq = (struct dasd_diag_req *) cqr->data;
 
-       private->iob.dev_nr = _ccw_device_get_device_number(device->cdev);
+       private->iob.dev_nr = private->dev_id.devno;
        private->iob.key = 0;
        private->iob.flags = DASD_DIAG_RWFLAG_ASYNC;
        private->iob.block_count = dreq->block_count;
@@ -201,7 +186,7 @@ dasd_start_diag(struct dasd_ccw_req * cqr)
        switch (rc) {
        case 0: /* Synchronous I/O finished successfully */
                cqr->stopclk = get_clock();
-               cqr->status = DASD_CQR_DONE;
+               cqr->status = DASD_CQR_SUCCESS;
                /* Indicate to calling function that only a dasd_schedule_bh()
                   and no timer is needed */
                 rc = -EACCES;
@@ -212,11 +197,12 @@ dasd_start_diag(struct dasd_ccw_req * cqr)
                break;
        default: /* Error condition */
                cqr->status = DASD_CQR_QUEUED;
-               DEV_MESSAGE(KERN_WARNING, device, "dia250 returned rc=%d", rc);
+               DBF_DEV_EVENT(DBF_WARNING, device, "dia250 returned rc=%d", rc);
                dasd_diag_erp(device);
                rc = -EIO;
                break;
        }
+       cqr->intrc = rc;
        return rc;
 }
 
@@ -226,18 +212,18 @@ dasd_diag_term_IO(struct dasd_ccw_req * cqr)
 {
        struct dasd_device *device;
 
-       device = cqr->device;
+       device = cqr->startdev;
        mdsk_term_io(device);
-       mdsk_init_io(device, device->bp_block, 0, NULL);
-       cqr->status = DASD_CQR_CLEAR;
+       mdsk_init_io(device, device->block->bp_block, 0, NULL);
+       cqr->status = DASD_CQR_CLEAR_PENDING;
        cqr->stopclk = get_clock();
-       dasd_schedule_bh(device);
+       dasd_schedule_device_bh(device);
        return 0;
 }
 
 /* Handle external interruption. */
 static void
-dasd_ext_handler(struct pt_regs *regs, __u16 code)
+dasd_ext_handler(__u16 code)
 {
        struct dasd_ccw_req *cqr, *next;
        struct dasd_device *device;
@@ -260,13 +246,14 @@ dasd_ext_handler(struct pt_regs *regs, __u16 code)
                return;
        }
        if (!ip) {              /* no intparm: unsolicited interrupt */
-               MESSAGE(KERN_DEBUG, "%s", "caught unsolicited interrupt");
+               DBF_EVENT(DBF_NOTICE, "%s", "caught unsolicited "
+                             "interrupt");
                return;
        }
        cqr = (struct dasd_ccw_req *) ip;
-       device = (struct dasd_device *) cqr->device;
+       device = (struct dasd_device *) cqr->startdev;
        if (strncmp(device->discipline->ebcname, (char *) &cqr->magic, 4)) {
-               DEV_MESSAGE(KERN_WARNING, device,
+               DBF_DEV_EVENT(DBF_WARNING, device,
                            " magic number of dasd_ccw_req 0x%08X doesn't"
                            " match discipline 0x%08X",
                            cqr->magic, *(int *) (&device->discipline->name));
@@ -277,10 +264,10 @@ dasd_ext_handler(struct pt_regs *regs, __u16 code)
        spin_lock_irqsave(get_ccwdev_lock(device->cdev), flags);
 
        /* Check for a pending clear operation */
-       if (cqr->status == DASD_CQR_CLEAR) {
-               cqr->status = DASD_CQR_QUEUED;
-               dasd_clear_timer(device);
-               dasd_schedule_bh(device);
+       if (cqr->status == DASD_CQR_CLEAR_PENDING) {
+               cqr->status = DASD_CQR_CLEARED;
+               dasd_device_clear_timer(device);
+               dasd_schedule_device_bh(device);
                spin_unlock_irqrestore(get_ccwdev_lock(device->cdev), flags);
                return;
        }
@@ -289,34 +276,30 @@ dasd_ext_handler(struct pt_regs *regs, __u16 code)
 
        expires = 0;
        if (status == 0) {
-               cqr->status = DASD_CQR_DONE;
+               cqr->status = DASD_CQR_SUCCESS;
                /* Start first request on queue if possible -> fast_io. */
                if (!list_empty(&device->ccw_queue)) {
                        next = list_entry(device->ccw_queue.next,
-                                         struct dasd_ccw_req, list);
+                                         struct dasd_ccw_req, devlist);
                        if (next->status == DASD_CQR_QUEUED) {
                                rc = dasd_start_diag(next);
                                if (rc == 0)
                                        expires = next->expires;
-                               else if (rc != -EACCES)
-                                       DEV_MESSAGE(KERN_WARNING, device, "%s",
-                                                   "Interrupt fastpath "
-                                                   "failed!");
                        }
                }
        } else {
                cqr->status = DASD_CQR_QUEUED;
-               DEV_MESSAGE(KERN_WARNING, device, "interrupt status for "
+               DBF_DEV_EVENT(DBF_DEBUG, device, "interrupt status for "
                            "request %p was %d (%d retries left)", cqr, status,
                            cqr->retries);
                dasd_diag_erp(device);
        }
 
        if (expires != 0)
-               dasd_set_timer(device, expires);
+               dasd_device_set_timer(device, expires);
        else
-               dasd_clear_timer(device);
-       dasd_schedule_bh(device);
+               dasd_device_clear_timer(device);
+       dasd_schedule_device_bh(device);
 
        spin_unlock_irqrestore(get_ccwdev_lock(device->cdev), flags);
 }
@@ -326,6 +309,7 @@ dasd_ext_handler(struct pt_regs *regs, __u16 code)
 static int
 dasd_diag_check_device(struct dasd_device *device)
 {
+       struct dasd_block *block;
        struct dasd_diag_private *private;
        struct dasd_diag_characteristics *rdc_data;
        struct dasd_diag_bio bio;
@@ -336,24 +320,38 @@ dasd_diag_check_device(struct dasd_device *device)
 
        private = (struct dasd_diag_private *) device->private;
        if (private == NULL) {
-               private = kmalloc(sizeof(struct dasd_diag_private),GFP_KERNEL);
+               private = kzalloc(sizeof(struct dasd_diag_private),GFP_KERNEL);
                if (private == NULL) {
-                       DEV_MESSAGE(KERN_WARNING, device, "%s",
-                               "memory allocation failed for private data");
+                       DBF_DEV_EVENT(DBF_WARNING, device, "%s",
+                               "Allocating memory for private DASD data "
+                                     "failed\n");
                        return -ENOMEM;
                }
+               ccw_device_get_id(device->cdev, &private->dev_id);
                device->private = (void *) private;
        }
+       block = dasd_alloc_block();
+       if (IS_ERR(block)) {
+               DBF_DEV_EVENT(DBF_WARNING, device, "%s",
+                           "could not allocate dasd block structure");
+               device->private = NULL;
+               kfree(private);
+               return PTR_ERR(block);
+       }
+       device->block = block;
+       block->base = device;
+
        /* Read Device Characteristics */
        rdc_data = (void *) &(private->rdc_data);
-       rdc_data->dev_nr = _ccw_device_get_device_number(device->cdev);
+       rdc_data->dev_nr = private->dev_id.devno;
        rdc_data->rdc_len = sizeof (struct dasd_diag_characteristics);
 
        rc = diag210((struct diag210 *) rdc_data);
        if (rc) {
-               DEV_MESSAGE(KERN_WARNING, device, "failed to retrieve device "
+               DBF_DEV_EVENT(DBF_WARNING, device, "failed to retrieve device "
                            "information (rc=%d)", rc);
-               return -ENOTSUPP;
+               rc = -EOPNOTSUPP;
+               goto out;
        }
 
        /* Figure out position of label block */
@@ -365,9 +363,10 @@ dasd_diag_check_device(struct dasd_device *device)
                private->pt_block = 2;
                break;
        default:
-               DEV_MESSAGE(KERN_WARNING, device, "unsupported device class "
-                           "(class=%d)", private->rdc_data.vdev_class);
-               return -ENOTSUPP;
+               dev_warn(&device->cdev->dev, "Device type %d is not supported "
+                           "in DIAG mode\n", private->rdc_data.vdev_class);
+               rc = -EOPNOTSUPP;
+               goto out;
        }
 
        DBF_DEV_EVENT(DBF_INFO, device,
@@ -382,9 +381,10 @@ dasd_diag_check_device(struct dasd_device *device)
        /* figure out blocksize of device */
        label = (struct vtoc_cms_label *) get_zeroed_page(GFP_KERNEL);
        if (label == NULL)  {
-               DEV_MESSAGE(KERN_WARNING, device, "%s",
+               DBF_DEV_EVENT(DBF_WARNING, device, "%s",
                            "No memory to allocate initialization request");
-               return -ENOMEM;
+               rc = -ENOMEM;
+               goto out;
        }
        rc = 0;
        end_block = 0;
@@ -405,69 +405,70 @@ dasd_diag_check_device(struct dasd_device *device)
                private->iob.flaga = DASD_DIAG_FLAGA_DEFAULT;
                rc = dia250(&private->iob, RW_BIO);
                if (rc == 3) {
-                       DEV_MESSAGE(KERN_WARNING, device, "%s",
-                               "DIAG call failed");
+                       dev_warn(&device->cdev->dev,
+                               "A 64-bit DIAG call failed\n");
                        rc = -EOPNOTSUPP;
-                       goto out;
+                       goto out_label;
                }
                mdsk_term_io(device);
                if (rc == 0)
                        break;
        }
        if (bsize > PAGE_SIZE) {
-               DEV_MESSAGE(KERN_WARNING, device, "device access failed "
-                           "(rc=%d)", rc);
+               dev_warn(&device->cdev->dev, "Accessing the DASD failed because"
+                        " of an incorrect format (rc=%d)\n", rc);
                rc = -EIO;
-               goto out;
+               goto out_label;
        }
        /* check for label block */
        if (memcmp(label->label_id, DASD_DIAG_CMS1,
                  sizeof(DASD_DIAG_CMS1)) == 0) {
                /* get formatted blocksize from label block */
                bsize = (unsigned int) label->block_size;
-               device->blocks = (unsigned long) label->block_count;
+               block->blocks = (unsigned long) label->block_count;
        } else
-               device->blocks = end_block;
-       device->bp_block = bsize;
-       device->s2b_shift = 0;  /* bits to shift 512 to get a block */
+               block->blocks = end_block;
+       block->bp_block = bsize;
+       block->s2b_shift = 0;   /* bits to shift 512 to get a block */
        for (sb = 512; sb < bsize; sb = sb << 1)
-               device->s2b_shift++;
-       rc = mdsk_init_io(device, device->bp_block, 0, NULL);
+               block->s2b_shift++;
+       rc = mdsk_init_io(device, block->bp_block, 0, NULL);
        if (rc) {
-               DEV_MESSAGE(KERN_WARNING, device, "DIAG initialization "
-                       "failed (rc=%d)", rc);
+               dev_warn(&device->cdev->dev, "DIAG initialization "
+                       "failed with rc=%d\n", rc);
                rc = -EIO;
        } else {
-               DEV_MESSAGE(KERN_INFO, device,
-                           "(%ld B/blk): %ldkB",
-                           (unsigned long) device->bp_block,
-                           (unsigned long) (device->blocks <<
-                               device->s2b_shift) >> 1);
+               dev_info(&device->cdev->dev,
+                        "New DASD with %ld byte/block, total size %ld KB\n",
+                        (unsigned long) block->bp_block,
+                        (unsigned long) (block->blocks <<
+                                         block->s2b_shift) >> 1);
        }
-out:
+out_label:
        free_page((long) label);
+out:
+       if (rc) {
+               device->block = NULL;
+               dasd_free_block(block);
+               device->private = NULL;
+               kfree(private);
+       }
        return rc;
 }
 
 /* Fill in virtual disk geometry for device. Return zero on success, non-zero
  * otherwise. */
 static int
-dasd_diag_fill_geometry(struct dasd_device *device, struct hd_geometry *geo)
+dasd_diag_fill_geometry(struct dasd_block *block, struct hd_geometry *geo)
 {
-       if (dasd_check_blocksize(device->bp_block) != 0)
+       if (dasd_check_blocksize(block->bp_block) != 0)
                return -EINVAL;
-       geo->cylinders = (device->blocks << device->s2b_shift) >> 10;
+       geo->cylinders = (block->blocks << block->s2b_shift) >> 10;
        geo->heads = 16;
-       geo->sectors = 128 >> device->s2b_shift;
+       geo->sectors = 128 >> block->s2b_shift;
        return 0;
 }
 
-static dasd_era_t
-dasd_diag_examine_error(struct dasd_ccw_req * cqr, struct irb * stat)
-{
-       return dasd_era_fatal;
-}
-
 static dasd_erp_fn_t
 dasd_diag_erp_action(struct dasd_ccw_req * cqr)
 {
@@ -482,20 +483,20 @@ dasd_diag_erp_postaction(struct dasd_ccw_req * cqr)
 
 /* Create DASD request from block device request. Return pointer to new
  * request on success, ERR_PTR otherwise. */
-static struct dasd_ccw_req *
-dasd_diag_build_cp(struct dasd_device * device, struct request *req)
+static struct dasd_ccw_req *dasd_diag_build_cp(struct dasd_device *memdev,
+                                              struct dasd_block *block,
+                                              struct request *req)
 {
        struct dasd_ccw_req *cqr;
        struct dasd_diag_req *dreq;
        struct dasd_diag_bio *dbio;
-       struct bio *bio;
+       struct req_iterator iter;
        struct bio_vec *bv;
        char *dst;
        unsigned int count, datasize;
        sector_t recid, first_rec, last_rec;
        unsigned int blksize, off;
        unsigned char rw_cmd;
-       int i;
 
        if (rq_data_dir(req) == READ)
                rw_cmd = MDSK_READ_REQ;
@@ -503,19 +504,18 @@ dasd_diag_build_cp(struct dasd_device * device, struct request *req)
                rw_cmd = MDSK_WRITE_REQ;
        else
                return ERR_PTR(-EINVAL);
-       blksize = device->bp_block;
+       blksize = block->bp_block;
        /* Calculate record id of first and last block. */
-       first_rec = req->sector >> device->s2b_shift;
-       last_rec = (req->sector + req->nr_sectors - 1) >> device->s2b_shift;
+       first_rec = blk_rq_pos(req) >> block->s2b_shift;
+       last_rec =
+               (blk_rq_pos(req) + blk_rq_sectors(req) - 1) >> block->s2b_shift;
        /* Check struct bio and count the number of blocks for the request. */
        count = 0;
-       rq_for_each_bio(bio, req) {
-               bio_for_each_segment(bv, bio, i) {
-                       if (bv->bv_len & (blksize - 1))
-                               /* Fba can only do full blocks. */
-                               return ERR_PTR(-EINVAL);
-                       count += bv->bv_len >> (device->s2b_shift + 9);
-               }
+       rq_for_each_segment(bv, req, iter) {
+               if (bv->bv_len & (blksize - 1))
+                       /* Fba can only do full blocks. */
+                       return ERR_PTR(-EINVAL);
+               count += bv->bv_len >> (block->s2b_shift + 9);
        }
        /* Paranoia. */
        if (count != last_rec - first_rec + 1)
@@ -524,33 +524,34 @@ dasd_diag_build_cp(struct dasd_device * device, struct request *req)
        datasize = sizeof(struct dasd_diag_req) +
                count*sizeof(struct dasd_diag_bio);
        cqr = dasd_smalloc_request(dasd_diag_discipline.name, 0,
-                                  datasize, device);
+                                  datasize, memdev);
        if (IS_ERR(cqr))
                return cqr;
-       
+
        dreq = (struct dasd_diag_req *) cqr->data;
        dreq->block_count = count;
        dbio = dreq->bio;
        recid = first_rec;
-       rq_for_each_bio(bio, req) {
-               bio_for_each_segment(bv, bio, i) {
-                       dst = page_address(bv->bv_page) + bv->bv_offset;
-                       for (off = 0; off < bv->bv_len; off += blksize) {
-                               memset(dbio, 0, sizeof (struct dasd_diag_bio));
-                               dbio->type = rw_cmd;
-                               dbio->block_number = recid + 1;
-                               dbio->buffer = dst;
-                               dbio++;
-                               dst += blksize;
-                               recid++;
-                       }
+       rq_for_each_segment(bv, req, iter) {
+               dst = page_address(bv->bv_page) + bv->bv_offset;
+               for (off = 0; off < bv->bv_len; off += blksize) {
+                       memset(dbio, 0, sizeof (struct dasd_diag_bio));
+                       dbio->type = rw_cmd;
+                       dbio->block_number = recid + 1;
+                       dbio->buffer = dst;
+                       dbio++;
+                       dst += blksize;
+                       recid++;
                }
        }
        cqr->retries = DIAG_MAX_RETRIES;
        cqr->buildclk = get_clock();
-       if (req->flags & REQ_FAILFAST)
+       if (blk_noretry_request(req) ||
+           block->base->features & DASD_FEATURE_FAILFAST)
                set_bit(DASD_CQR_FLAGS_FAILFAST, &cqr->flags);
-       cqr->device = device;
+       cqr->startdev = memdev;
+       cqr->memdev = memdev;
+       cqr->block = block;
        cqr->expires = DIAG_TIMEOUT;
        cqr->status = DASD_CQR_FILLED;
        return cqr;
@@ -564,10 +565,15 @@ dasd_diag_free_cp(struct dasd_ccw_req *cqr, struct request *req)
        int status;
 
        status = cqr->status == DASD_CQR_DONE;
-       dasd_sfree_request(cqr, cqr->device);
+       dasd_sfree_request(cqr, cqr->memdev);
        return status;
 }
 
+static void dasd_diag_handle_terminated_request(struct dasd_ccw_req *cqr)
+{
+       cqr->status = DASD_CQR_FILLED;
+};
+
 /* Fill in IOCTL data for device. */
 static int
 dasd_diag_fill_info(struct dasd_device * device,
@@ -591,11 +597,11 @@ static void
 dasd_diag_dump_sense(struct dasd_device *device, struct dasd_ccw_req * req,
                     struct irb *stat)
 {
-       DEV_MESSAGE(KERN_ERR, device, "%s",
+       DBF_DEV_EVENT(DBF_WARNING, device, "%s",
                    "dump sense not available for DIAG data");
 }
 
-struct dasd_discipline dasd_diag_discipline = {
+static struct dasd_discipline dasd_diag_discipline = {
        .owner = THIS_MODULE,
        .name = "DIAG",
        .ebcname = "DIAG",
@@ -604,7 +610,7 @@ struct dasd_discipline dasd_diag_discipline = {
        .fill_geometry = dasd_diag_fill_geometry,
        .start_IO = dasd_start_diag,
        .term_IO = dasd_diag_term_IO,
-       .examine_error = dasd_diag_examine_error,
+       .handle_terminated_request = dasd_diag_handle_terminated_request,
        .erp_action = dasd_diag_erp_action,
        .erp_postaction = dasd_diag_erp_postaction,
        .build_cp = dasd_diag_build_cp,
@@ -617,10 +623,8 @@ static int __init
 dasd_diag_init(void)
 {
        if (!MACHINE_IS_VM) {
-               MESSAGE_LOG(KERN_INFO,
-                           "Machine is not VM: %s "
-                           "discipline not initializing",
-                           dasd_diag_discipline.name);
+               pr_info("Discipline %s cannot be used without z/VM\n",
+                       dasd_diag_discipline.name);
                return -ENODEV;
        }
        ASCEBC(dasd_diag_discipline.ebcname, 4);