PNP: replace pnp_resource_table with dynamically allocated resources
[safe/jmp/linux-2.6] / drivers / pnp / pnpacpi / rsparser.c
index 3a4a644..9a45c25 100644 (file)
@@ -21,6 +21,8 @@
 #include <linux/kernel.h>
 #include <linux/acpi.h>
 #include <linux/pci.h>
+#include <linux/pnp.h>
+#include "../base.h"
 #include "pnpacpi.h"
 
 #ifdef CONFIG_IA64
 /*
  * Allocated Resources
  */
-static int irq_flags(int triggering, int polarity)
+static int irq_flags(int triggering, int polarity, int shareable)
 {
-       int flag;
+       int flags;
+
        if (triggering == ACPI_LEVEL_SENSITIVE) {
                if (polarity == ACPI_ACTIVE_LOW)
-                       flag = IORESOURCE_IRQ_LOWLEVEL;
+                       flags = IORESOURCE_IRQ_LOWLEVEL;
                else
-                       flag = IORESOURCE_IRQ_HIGHLEVEL;
-       }
-       else {
+                       flags = IORESOURCE_IRQ_HIGHLEVEL;
+       } else {
                if (polarity == ACPI_ACTIVE_LOW)
-                       flag = IORESOURCE_IRQ_LOWEDGE;
+                       flags = IORESOURCE_IRQ_LOWEDGE;
                else
-                       flag = IORESOURCE_IRQ_HIGHEDGE;
+                       flags = IORESOURCE_IRQ_HIGHEDGE;
        }
-       return flag;
+
+       if (shareable == ACPI_SHARED)
+               flags |= IORESOURCE_IRQ_SHAREABLE;
+
+       return flags;
 }
 
-static void decode_irq_flags(int flag, int *triggering, int *polarity)
+static void decode_irq_flags(struct pnp_dev *dev, int flags, int *triggering,
+                            int *polarity, int *shareable)
 {
-       switch (flag) {
+       switch (flags & (IORESOURCE_IRQ_LOWLEVEL | IORESOURCE_IRQ_HIGHLEVEL |
+                        IORESOURCE_IRQ_LOWEDGE  | IORESOURCE_IRQ_HIGHEDGE)) {
        case IORESOURCE_IRQ_LOWLEVEL:
                *triggering = ACPI_LEVEL_SENSITIVE;
                *polarity = ACPI_ACTIVE_LOW;
@@ -69,120 +77,169 @@ static void decode_irq_flags(int flag, int *triggering, int *polarity)
                *triggering = ACPI_EDGE_SENSITIVE;
                *polarity = ACPI_ACTIVE_HIGH;
                break;
+       default:
+               dev_err(&dev->dev, "can't encode invalid IRQ mode %#x\n",
+                       flags);
+               *triggering = ACPI_EDGE_SENSITIVE;
+               *polarity = ACPI_ACTIVE_HIGH;
+               break;
        }
+
+       if (flags & IORESOURCE_IRQ_SHAREABLE)
+               *shareable = ACPI_SHARED;
+       else
+               *shareable = ACPI_EXCLUSIVE;
 }
 
-static void
-pnpacpi_parse_allocated_irqresource(struct pnp_resource_table *res, u32 gsi,
-       int triggering, int polarity)
+static void pnpacpi_parse_allocated_irqresource(struct pnp_dev *dev,
+                                               u32 gsi, int triggering,
+                                               int polarity, int shareable)
 {
-       int i = 0;
-       int irq;
+       int irq, flags;
+       int p, t;
 
        if (!valid_IRQ(gsi))
                return;
 
-       while (!(res->irq_resource[i].flags & IORESOURCE_UNSET) &&
-                       i < PNP_MAX_IRQ)
-               i++;
-       if (i >= PNP_MAX_IRQ)
-               return;
+       /*
+        * in IO-APIC mode, use overrided attribute. Two reasons:
+        * 1. BIOS bug in DSDT
+        * 2. BIOS uses IO-APIC mode Interrupt Source Override
+        */
+       if (!acpi_get_override_irq(gsi, &t, &p)) {
+               t = t ? ACPI_LEVEL_SENSITIVE : ACPI_EDGE_SENSITIVE;
+               p = p ? ACPI_ACTIVE_LOW : ACPI_ACTIVE_HIGH;
+
+               if (triggering != t || polarity != p) {
+                       dev_warn(&dev->dev, "IRQ %d override to %s, %s\n",
+                               gsi, t ? "edge":"level", p ? "low":"high");
+                       triggering = t;
+                       polarity = p;
+               }
+       }
 
-       res->irq_resource[i].flags = IORESOURCE_IRQ;  // Also clears _UNSET flag
+       flags = irq_flags(triggering, polarity, shareable);
        irq = acpi_register_gsi(gsi, triggering, polarity);
-       if (irq < 0) {
-               res->irq_resource[i].flags |= IORESOURCE_DISABLED;
-               return;
-       }
+       if (irq >= 0)
+               pcibios_penalize_isa_irq(irq, 1);
+       else
+               flags |= IORESOURCE_DISABLED;
 
-       res->irq_resource[i].start = irq;
-       res->irq_resource[i].end = irq;
-       pcibios_penalize_isa_irq(irq, 1);
+       pnp_add_irq_resource(dev, irq, flags);
 }
 
-static void
-pnpacpi_parse_allocated_dmaresource(struct pnp_resource_table *res, u32 dma)
+static int dma_flags(int type, int bus_master, int transfer)
 {
-       int i = 0;
-       while (i < PNP_MAX_DMA &&
-                       !(res->dma_resource[i].flags & IORESOURCE_UNSET))
-               i++;
-       if (i < PNP_MAX_DMA) {
-               res->dma_resource[i].flags = IORESOURCE_DMA;  // Also clears _UNSET flag
-               if (dma == -1) {
-                       res->dma_resource[i].flags |= IORESOURCE_DISABLED;
-                       return;
-               }
-               res->dma_resource[i].start = dma;
-               res->dma_resource[i].end = dma;
+       int flags = 0;
+
+       if (bus_master)
+               flags |= IORESOURCE_DMA_MASTER;
+       switch (type) {
+       case ACPI_COMPATIBILITY:
+               flags |= IORESOURCE_DMA_COMPATIBLE;
+               break;
+       case ACPI_TYPE_A:
+               flags |= IORESOURCE_DMA_TYPEA;
+               break;
+       case ACPI_TYPE_B:
+               flags |= IORESOURCE_DMA_TYPEB;
+               break;
+       case ACPI_TYPE_F:
+               flags |= IORESOURCE_DMA_TYPEF;
+               break;
+       default:
+               /* Set a default value ? */
+               flags |= IORESOURCE_DMA_COMPATIBLE;
+               pnp_err("Invalid DMA type");
+       }
+       switch (transfer) {
+       case ACPI_TRANSFER_8:
+               flags |= IORESOURCE_DMA_8BIT;
+               break;
+       case ACPI_TRANSFER_8_16:
+               flags |= IORESOURCE_DMA_8AND16BIT;
+               break;
+       case ACPI_TRANSFER_16:
+               flags |= IORESOURCE_DMA_16BIT;
+               break;
+       default:
+               /* Set a default value ? */
+               flags |= IORESOURCE_DMA_8AND16BIT;
+               pnp_err("Invalid DMA transfer type");
        }
+
+       return flags;
 }
 
-static void
-pnpacpi_parse_allocated_ioresource(struct pnp_resource_table *res,
-       u64 io, u64 len)
+static void pnpacpi_parse_allocated_ioresource(struct pnp_dev *dev, u64 start,
+                                              u64 len, int io_decode)
 {
-       int i = 0;
-       while (!(res->port_resource[i].flags & IORESOURCE_UNSET) &&
-                       i < PNP_MAX_PORT)
-               i++;
-       if (i < PNP_MAX_PORT) {
-               res->port_resource[i].flags = IORESOURCE_IO;  // Also clears _UNSET flag
-               if (len <= 0 || (io + len -1) >= 0x10003) {
-                       res->port_resource[i].flags |= IORESOURCE_DISABLED;
-                       return;
-               }
-               res->port_resource[i].start = io;
-               res->port_resource[i].end = io + len - 1;
-       }
+       int flags = 0;
+       u64 end = start + len - 1;
+
+       if (io_decode == ACPI_DECODE_16)
+               flags |= PNP_PORT_FLAG_16BITADDR;
+       if (len == 0 || end >= 0x10003)
+               flags |= IORESOURCE_DISABLED;
+
+       pnp_add_io_resource(dev, start, end, flags);
 }
 
-static void
-pnpacpi_parse_allocated_memresource(struct pnp_resource_table *res,
-       u64 mem, u64 len)
+static void pnpacpi_parse_allocated_memresource(struct pnp_dev *dev,
+                                               u64 start, u64 len,
+                                               int write_protect)
 {
-       int i = 0;
-       while (!(res->mem_resource[i].flags & IORESOURCE_UNSET) &&
-                       (i < PNP_MAX_MEM))
-               i++;
-       if (i < PNP_MAX_MEM) {
-               res->mem_resource[i].flags = IORESOURCE_MEM;  // Also clears _UNSET flag
-               if (len <= 0) {
-                       res->mem_resource[i].flags |= IORESOURCE_DISABLED;
-                       return;
-               }
-               res->mem_resource[i].start = mem;
-               res->mem_resource[i].end = mem + len - 1;
-       }
+       int flags = 0;
+       u64 end = start + len - 1;
+
+       if (len == 0)
+               flags |= IORESOURCE_DISABLED;
+       if (write_protect == ACPI_READ_WRITE_MEMORY)
+               flags |= IORESOURCE_MEM_WRITEABLE;
+
+       pnp_add_mem_resource(dev, start, end, flags);
 }
 
-static void
-pnpacpi_parse_allocated_address_space(struct pnp_resource_table *res_table,
-       struct acpi_resource *res)
+static void pnpacpi_parse_allocated_address_space(struct pnp_dev *dev,
+                                                 struct acpi_resource *res)
 {
        struct acpi_resource_address64 addr, *p = &addr;
        acpi_status status;
 
        status = acpi_resource_to_address64(res, p);
        if (!ACPI_SUCCESS(status)) {
-               pnp_warn("PnPACPI: failed to convert resource type %d",
-                       res->type);
+               dev_warn(&dev->dev, "failed to convert resource type %d\n",
+                        res->type);
                return;
        }
 
+       if (p->producer_consumer == ACPI_PRODUCER)
+               return;
+
        if (p->resource_type == ACPI_MEMORY_RANGE)
-               pnpacpi_parse_allocated_memresource(res_table,
-                               p->minimum, p->address_length);
+               pnpacpi_parse_allocated_memresource(dev,
+                       p->minimum, p->address_length,
+                       p->info.mem.write_protect);
        else if (p->resource_type == ACPI_IO_RANGE)
-               pnpacpi_parse_allocated_ioresource(res_table,
-                               p->minimum, p->address_length);
+               pnpacpi_parse_allocated_ioresource(dev,
+                       p->minimum, p->address_length,
+                       p->granularity == 0xfff ? ACPI_DECODE_10 :
+                               ACPI_DECODE_16);
 }
 
 static acpi_status pnpacpi_allocated_resource(struct acpi_resource *res,
-       void *data)
+                                             void *data)
 {
-       struct pnp_resource_table *res_table = (struct pnp_resource_table *)data;
-       int i;
+       struct pnp_dev *dev = data;
+       struct acpi_resource_irq *irq;
+       struct acpi_resource_dma *dma;
+       struct acpi_resource_io *io;
+       struct acpi_resource_fixed_io *fixed_io;
+       struct acpi_resource_memory24 *memory24;
+       struct acpi_resource_memory32 *memory32;
+       struct acpi_resource_fixed_memory32 *fixed_memory32;
+       struct acpi_resource_extended_irq *extended_irq;
+       int i, flags;
 
        switch (res->type) {
        case ACPI_RESOURCE_TYPE_IRQ:
@@ -190,24 +247,33 @@ static acpi_status pnpacpi_allocated_resource(struct acpi_resource *res,
                 * Per spec, only one interrupt per descriptor is allowed in
                 * _CRS, but some firmware violates this, so parse them all.
                 */
-               for (i = 0; i < res->data.irq.interrupt_count; i++) {
-                       pnpacpi_parse_allocated_irqresource(res_table,
-                               res->data.irq.interrupts[i],
-                               res->data.irq.triggering,
-                               res->data.irq.polarity);
+               irq = &res->data.irq;
+               for (i = 0; i < irq->interrupt_count; i++) {
+                       pnpacpi_parse_allocated_irqresource(dev,
+                               irq->interrupts[i],
+                               irq->triggering,
+                               irq->polarity,
+                               irq->sharable);
                }
                break;
 
        case ACPI_RESOURCE_TYPE_DMA:
-               if (res->data.dma.channel_count > 0)
-                       pnpacpi_parse_allocated_dmaresource(res_table,
-                                       res->data.dma.channels[0]);
+               dma = &res->data.dma;
+               if (dma->channel_count > 0) {
+                       flags = dma_flags(dma->type, dma->bus_master,
+                                         dma->transfer);
+                       if (dma->channels[0] == (u8) -1)
+                               flags |= IORESOURCE_DISABLED;
+                       pnp_add_dma_resource(dev, dma->channels[0], flags);
+               }
                break;
 
        case ACPI_RESOURCE_TYPE_IO:
-               pnpacpi_parse_allocated_ioresource(res_table,
-                               res->data.io.minimum,
-                               res->data.io.address_length);
+               io = &res->data.io;
+               pnpacpi_parse_allocated_ioresource(dev,
+                       io->minimum,
+                       io->address_length,
+                       io->io_decode);
                break;
 
        case ACPI_RESOURCE_TYPE_START_DEPENDENT:
@@ -215,9 +281,11 @@ static acpi_status pnpacpi_allocated_resource(struct acpi_resource *res,
                break;
 
        case ACPI_RESOURCE_TYPE_FIXED_IO:
-               pnpacpi_parse_allocated_ioresource(res_table,
-                               res->data.fixed_io.address,
-                               res->data.fixed_io.address_length);
+               fixed_io = &res->data.fixed_io;
+               pnpacpi_parse_allocated_ioresource(dev,
+                       fixed_io->address,
+                       fixed_io->address_length,
+                       ACPI_DECODE_10);
                break;
 
        case ACPI_RESOURCE_TYPE_VENDOR:
@@ -227,35 +295,48 @@ static acpi_status pnpacpi_allocated_resource(struct acpi_resource *res,
                break;
 
        case ACPI_RESOURCE_TYPE_MEMORY24:
-               pnpacpi_parse_allocated_memresource(res_table,
-                               res->data.memory24.minimum,
-                               res->data.memory24.address_length);
+               memory24 = &res->data.memory24;
+               pnpacpi_parse_allocated_memresource(dev,
+                       memory24->minimum,
+                       memory24->address_length,
+                       memory24->write_protect);
                break;
        case ACPI_RESOURCE_TYPE_MEMORY32:
-               pnpacpi_parse_allocated_memresource(res_table,
-                               res->data.memory32.minimum,
-                               res->data.memory32.address_length);
+               memory32 = &res->data.memory32;
+               pnpacpi_parse_allocated_memresource(dev,
+                       memory32->minimum,
+                       memory32->address_length,
+                       memory32->write_protect);
                break;
        case ACPI_RESOURCE_TYPE_FIXED_MEMORY32:
-               pnpacpi_parse_allocated_memresource(res_table,
-                               res->data.fixed_memory32.address,
-                               res->data.fixed_memory32.address_length);
+               fixed_memory32 = &res->data.fixed_memory32;
+               pnpacpi_parse_allocated_memresource(dev,
+                       fixed_memory32->address,
+                       fixed_memory32->address_length,
+                       fixed_memory32->write_protect);
                break;
        case ACPI_RESOURCE_TYPE_ADDRESS16:
        case ACPI_RESOURCE_TYPE_ADDRESS32:
        case ACPI_RESOURCE_TYPE_ADDRESS64:
-               pnpacpi_parse_allocated_address_space(res_table, res);
+               pnpacpi_parse_allocated_address_space(dev, res);
                break;
 
        case ACPI_RESOURCE_TYPE_EXTENDED_ADDRESS64:
+               if (res->data.ext_address64.producer_consumer == ACPI_PRODUCER)
+                       return AE_OK;
                break;
 
        case ACPI_RESOURCE_TYPE_EXTENDED_IRQ:
-               for (i = 0; i < res->data.extended_irq.interrupt_count; i++) {
-                       pnpacpi_parse_allocated_irqresource(res_table,
-                               res->data.extended_irq.interrupts[i],
-                               res->data.extended_irq.triggering,
-                               res->data.extended_irq.polarity);
+               extended_irq = &res->data.extended_irq;
+               if (extended_irq->producer_consumer == ACPI_PRODUCER)
+                       return AE_OK;
+
+               for (i = 0; i < extended_irq->interrupt_count; i++) {
+                       pnpacpi_parse_allocated_irqresource(dev,
+                               extended_irq->interrupts[i],
+                               extended_irq->triggering,
+                               extended_irq->polarity,
+                               extended_irq->sharable);
                }
                break;
 
@@ -263,127 +344,106 @@ static acpi_status pnpacpi_allocated_resource(struct acpi_resource *res,
                break;
 
        default:
-               pnp_warn("PnPACPI: unknown resource type %d", res->type);
+               dev_warn(&dev->dev, "unknown resource type %d in _CRS\n",
+                        res->type);
                return AE_ERROR;
        }
 
        return AE_OK;
 }
 
-acpi_status pnpacpi_parse_allocated_resource(acpi_handle handle, struct pnp_resource_table *res)
+int pnpacpi_parse_allocated_resource(struct pnp_dev *dev)
 {
-       /* Blank the resource table values */
-       pnp_init_resource_table(res);
+       acpi_handle handle = dev->data;
+       acpi_status status;
 
-       return acpi_walk_resources(handle, METHOD_NAME__CRS, pnpacpi_allocated_resource, res);
+       dev_dbg(&dev->dev, "parse allocated resources\n");
+
+       pnp_init_resources(dev);
+
+       status = acpi_walk_resources(handle, METHOD_NAME__CRS,
+                                    pnpacpi_allocated_resource, dev);
+
+       if (ACPI_FAILURE(status)) {
+               if (status != AE_NOT_FOUND)
+                       dev_err(&dev->dev, "can't evaluate _CRS: %d", status);
+               return -EPERM;
+       }
+       return 0;
 }
 
-static void pnpacpi_parse_dma_option(struct pnp_option *option, struct acpi_resource_dma *p)
+static __init void pnpacpi_parse_dma_option(struct pnp_dev *dev,
+                                           struct pnp_option *option,
+                                           struct acpi_resource_dma *p)
 {
        int i;
-       struct pnp_dma * dma;
+       struct pnp_dma *dma;
 
        if (p->channel_count == 0)
                return;
-       dma = kcalloc(1, sizeof(struct pnp_dma), GFP_KERNEL);
+       dma = kzalloc(sizeof(struct pnp_dma), GFP_KERNEL);
        if (!dma)
                return;
 
-       for(i = 0; i < p->channel_count; i++)
+       for (i = 0; i < p->channel_count; i++)
                dma->map |= 1 << p->channels[i];
-       dma->flags = 0;
-       if (p->bus_master)
-               dma->flags |= IORESOURCE_DMA_MASTER;
-       switch (p->type) {
-       case ACPI_COMPATIBILITY:
-               dma->flags |= IORESOURCE_DMA_COMPATIBLE;
-               break;
-       case ACPI_TYPE_A:
-               dma->flags |= IORESOURCE_DMA_TYPEA;
-               break;
-       case ACPI_TYPE_B:
-               dma->flags |= IORESOURCE_DMA_TYPEB;
-               break;
-       case ACPI_TYPE_F:
-               dma->flags |= IORESOURCE_DMA_TYPEF;
-               break;
-       default:
-               /* Set a default value ? */
-               dma->flags |= IORESOURCE_DMA_COMPATIBLE;
-               pnp_err("Invalid DMA type");
-       }
-       switch (p->transfer) {
-       case ACPI_TRANSFER_8:
-               dma->flags |= IORESOURCE_DMA_8BIT;
-               break;
-       case ACPI_TRANSFER_8_16:
-               dma->flags |= IORESOURCE_DMA_8AND16BIT;
-               break;
-       case ACPI_TRANSFER_16:
-               dma->flags |= IORESOURCE_DMA_16BIT;
-               break;
-       default:
-               /* Set a default value ? */
-               dma->flags |= IORESOURCE_DMA_8AND16BIT;
-               pnp_err("Invalid DMA transfer type");
-       }
 
-       pnp_register_dma_resource(option, dma);
-       return;
-}
+       dma->flags = dma_flags(p->type, p->bus_master, p->transfer);
 
+       pnp_register_dma_resource(dev, option, dma);
+}
 
-static void pnpacpi_parse_irq_option(struct pnp_option *option,
-       struct acpi_resource_irq *p)
+static __init void pnpacpi_parse_irq_option(struct pnp_dev *dev,
+                                           struct pnp_option *option,
+                                           struct acpi_resource_irq *p)
 {
        int i;
        struct pnp_irq *irq;
 
        if (p->interrupt_count == 0)
                return;
-       irq = kcalloc(1, sizeof(struct pnp_irq), GFP_KERNEL);
+       irq = kzalloc(sizeof(struct pnp_irq), GFP_KERNEL);
        if (!irq)
                return;
 
-       for(i = 0; i < p->interrupt_count; i++)
+       for (i = 0; i < p->interrupt_count; i++)
                if (p->interrupts[i])
                        __set_bit(p->interrupts[i], irq->map);
-       irq->flags = irq_flags(p->triggering, p->polarity);
+       irq->flags = irq_flags(p->triggering, p->polarity, p->sharable);
 
-       pnp_register_irq_resource(option, irq);
-       return;
+       pnp_register_irq_resource(dev, option, irq);
 }
 
-static void pnpacpi_parse_ext_irq_option(struct pnp_option *option,
-       struct acpi_resource_extended_irq *p)
+static __init void pnpacpi_parse_ext_irq_option(struct pnp_dev *dev,
+                                               struct pnp_option *option,
+                                       struct acpi_resource_extended_irq *p)
 {
        int i;
        struct pnp_irq *irq;
 
        if (p->interrupt_count == 0)
                return;
-       irq = kcalloc(1, sizeof(struct pnp_irq), GFP_KERNEL);
+       irq = kzalloc(sizeof(struct pnp_irq), GFP_KERNEL);
        if (!irq)
                return;
 
-       for(i = 0; i < p->interrupt_count; i++)
+       for (i = 0; i < p->interrupt_count; i++)
                if (p->interrupts[i])
                        __set_bit(p->interrupts[i], irq->map);
-       irq->flags = irq_flags(p->triggering, p->polarity);
+       irq->flags = irq_flags(p->triggering, p->polarity, p->sharable);
 
-       pnp_register_irq_resource(option, irq);
-       return;
+       pnp_register_irq_resource(dev, option, irq);
 }
 
-static void
-pnpacpi_parse_port_option(struct pnp_option *option,
-       struct acpi_resource_io *io)
+static __init void pnpacpi_parse_port_option(struct pnp_dev *dev,
+                                            struct pnp_option *option,
+                                            struct acpi_resource_io *io)
 {
        struct pnp_port *port;
 
        if (io->address_length == 0)
                return;
-       port = kcalloc(1, sizeof(struct pnp_port), GFP_KERNEL);
+       port = kzalloc(sizeof(struct pnp_port), GFP_KERNEL);
        if (!port)
                return;
        port->min = io->minimum;
@@ -391,39 +451,37 @@ pnpacpi_parse_port_option(struct pnp_option *option,
        port->align = io->alignment;
        port->size = io->address_length;
        port->flags = ACPI_DECODE_16 == io->io_decode ?
-               PNP_PORT_FLAG_16BITADDR : 0;
-       pnp_register_port_resource(option, port);
-       return;
+           PNP_PORT_FLAG_16BITADDR : 0;
+       pnp_register_port_resource(dev, option, port);
 }
 
-static void
-pnpacpi_parse_fixed_port_option(struct pnp_option *option,
-       struct acpi_resource_fixed_io *io)
+static __init void pnpacpi_parse_fixed_port_option(struct pnp_dev *dev,
+                                                  struct pnp_option *option,
+                                       struct acpi_resource_fixed_io *io)
 {
        struct pnp_port *port;
 
        if (io->address_length == 0)
                return;
-       port = kcalloc(1, sizeof(struct pnp_port), GFP_KERNEL);
+       port = kzalloc(sizeof(struct pnp_port), GFP_KERNEL);
        if (!port)
                return;
        port->min = port->max = io->address;
        port->size = io->address_length;
        port->align = 0;
        port->flags = PNP_PORT_FLAG_FIXED;
-       pnp_register_port_resource(option, port);
-       return;
+       pnp_register_port_resource(dev, option, port);
 }
 
-static void
-pnpacpi_parse_mem24_option(struct pnp_option *option,
-       struct acpi_resource_memory24 *p)
+static __init void pnpacpi_parse_mem24_option(struct pnp_dev *dev,
+                                             struct pnp_option *option,
+                                             struct acpi_resource_memory24 *p)
 {
        struct pnp_mem *mem;
 
        if (p->address_length == 0)
                return;
-       mem = kcalloc(1, sizeof(struct pnp_mem), GFP_KERNEL);
+       mem = kzalloc(sizeof(struct pnp_mem), GFP_KERNEL);
        if (!mem)
                return;
        mem->min = p->minimum;
@@ -432,21 +490,20 @@ pnpacpi_parse_mem24_option(struct pnp_option *option,
        mem->size = p->address_length;
 
        mem->flags = (ACPI_READ_WRITE_MEMORY == p->write_protect) ?
-                       IORESOURCE_MEM_WRITEABLE : 0;
+           IORESOURCE_MEM_WRITEABLE : 0;
 
-       pnp_register_mem_resource(option, mem);
-       return;
+       pnp_register_mem_resource(dev, option, mem);
 }
 
-static void
-pnpacpi_parse_mem32_option(struct pnp_option *option,
-       struct acpi_resource_memory32 *p)
+static __init void pnpacpi_parse_mem32_option(struct pnp_dev *dev,
+                                             struct pnp_option *option,
+                                             struct acpi_resource_memory32 *p)
 {
        struct pnp_mem *mem;
 
        if (p->address_length == 0)
                return;
-       mem = kcalloc(1, sizeof(struct pnp_mem), GFP_KERNEL);
+       mem = kzalloc(sizeof(struct pnp_mem), GFP_KERNEL);
        if (!mem)
                return;
        mem->min = p->minimum;
@@ -455,21 +512,20 @@ pnpacpi_parse_mem32_option(struct pnp_option *option,
        mem->size = p->address_length;
 
        mem->flags = (ACPI_READ_WRITE_MEMORY == p->write_protect) ?
-                       IORESOURCE_MEM_WRITEABLE : 0;
+           IORESOURCE_MEM_WRITEABLE : 0;
 
-       pnp_register_mem_resource(option, mem);
-       return;
+       pnp_register_mem_resource(dev, option, mem);
 }
 
-static void
-pnpacpi_parse_fixed_mem32_option(struct pnp_option *option,
-       struct acpi_resource_fixed_memory32 *p)
+static __init void pnpacpi_parse_fixed_mem32_option(struct pnp_dev *dev,
+                                                   struct pnp_option *option,
+                                       struct acpi_resource_fixed_memory32 *p)
 {
        struct pnp_mem *mem;
 
        if (p->address_length == 0)
                return;
-       mem = kcalloc(1, sizeof(struct pnp_mem), GFP_KERNEL);
+       mem = kzalloc(sizeof(struct pnp_mem), GFP_KERNEL);
        if (!mem)
                return;
        mem->min = mem->max = p->address;
@@ -477,14 +533,14 @@ pnpacpi_parse_fixed_mem32_option(struct pnp_option *option,
        mem->align = 0;
 
        mem->flags = (ACPI_READ_WRITE_MEMORY == p->write_protect) ?
-                       IORESOURCE_MEM_WRITEABLE : 0;
+           IORESOURCE_MEM_WRITEABLE : 0;
 
-       pnp_register_mem_resource(option, mem);
-       return;
+       pnp_register_mem_resource(dev, option, mem);
 }
 
-static void
-pnpacpi_parse_address_option(struct pnp_option *option, struct acpi_resource *r)
+static __init void pnpacpi_parse_address_option(struct pnp_dev *dev,
+                                               struct pnp_option *option,
+                                               struct acpi_resource *r)
 {
        struct acpi_resource_address64 addr, *p = &addr;
        acpi_status status;
@@ -493,7 +549,8 @@ pnpacpi_parse_address_option(struct pnp_option *option, struct acpi_resource *r)
 
        status = acpi_resource_to_address64(r, p);
        if (!ACPI_SUCCESS(status)) {
-               pnp_warn("PnPACPI: failed to convert resource type %d", r->type);
+               pnp_warn("PnPACPI: failed to convert resource type %d",
+                        r->type);
                return;
        }
 
@@ -501,24 +558,25 @@ pnpacpi_parse_address_option(struct pnp_option *option, struct acpi_resource *r)
                return;
 
        if (p->resource_type == ACPI_MEMORY_RANGE) {
-               mem = kcalloc(1, sizeof(struct pnp_mem), GFP_KERNEL);
+               mem = kzalloc(sizeof(struct pnp_mem), GFP_KERNEL);
                if (!mem)
                        return;
                mem->min = mem->max = p->minimum;
                mem->size = p->address_length;
                mem->align = 0;
                mem->flags = (p->info.mem.write_protect ==
-                   ACPI_READ_WRITE_MEMORY) ? IORESOURCE_MEM_WRITEABLE : 0;
-               pnp_register_mem_resource(option, mem);
+                             ACPI_READ_WRITE_MEMORY) ? IORESOURCE_MEM_WRITEABLE
+                   : 0;
+               pnp_register_mem_resource(dev, option, mem);
        } else if (p->resource_type == ACPI_IO_RANGE) {
-               port = kcalloc(1, sizeof(struct pnp_port), GFP_KERNEL);
+               port = kzalloc(sizeof(struct pnp_port), GFP_KERNEL);
                if (!port)
                        return;
                port->min = port->max = p->minimum;
                port->size = p->address_length;
                port->align = 0;
                port->flags = PNP_PORT_FLAG_FIXED;
-               pnp_register_port_resource(option, port);
+               pnp_register_port_resource(dev, option, port);
        }
 }
 
@@ -528,123 +586,134 @@ struct acpipnp_parse_option_s {
        struct pnp_dev *dev;
 };
 
-static acpi_status pnpacpi_option_resource(struct acpi_resource *res,
-       void *data)
+static __init acpi_status pnpacpi_option_resource(struct acpi_resource *res,
+                                                 void *data)
 {
        int priority = 0;
-       struct acpipnp_parse_option_s *parse_data = (struct acpipnp_parse_option_s *)data;
+       struct acpipnp_parse_option_s *parse_data = data;
        struct pnp_dev *dev = parse_data->dev;
        struct pnp_option *option = parse_data->option;
 
        switch (res->type) {
-               case ACPI_RESOURCE_TYPE_IRQ:
-                       pnpacpi_parse_irq_option(option, &res->data.irq);
-                       break;
+       case ACPI_RESOURCE_TYPE_IRQ:
+               pnpacpi_parse_irq_option(dev, option, &res->data.irq);
+               break;
 
-               case ACPI_RESOURCE_TYPE_DMA:
-                       pnpacpi_parse_dma_option(option, &res->data.dma);
-                       break;
+       case ACPI_RESOURCE_TYPE_DMA:
+               pnpacpi_parse_dma_option(dev, option, &res->data.dma);
+               break;
 
-               case ACPI_RESOURCE_TYPE_START_DEPENDENT:
-                       switch (res->data.start_dpf.compatibility_priority) {
-                               case ACPI_GOOD_CONFIGURATION:
-                                       priority = PNP_RES_PRIORITY_PREFERRED;
-                                       break;
-
-                               case ACPI_ACCEPTABLE_CONFIGURATION:
-                                       priority = PNP_RES_PRIORITY_ACCEPTABLE;
-                                       break;
-
-                               case ACPI_SUB_OPTIMAL_CONFIGURATION:
-                                       priority = PNP_RES_PRIORITY_FUNCTIONAL;
-                                       break;
-                               default:
-                                       priority = PNP_RES_PRIORITY_INVALID;
-                                       break;
-                       }
-                       /* TBD: Considering performace/robustness bits */
-                       option = pnp_register_dependent_option(dev, priority);
-                       if (!option)
-                               return AE_ERROR;
-                       parse_data->option = option;
+       case ACPI_RESOURCE_TYPE_START_DEPENDENT:
+               switch (res->data.start_dpf.compatibility_priority) {
+               case ACPI_GOOD_CONFIGURATION:
+                       priority = PNP_RES_PRIORITY_PREFERRED;
                        break;
 
-               case ACPI_RESOURCE_TYPE_END_DEPENDENT:
-                       /*only one EndDependentFn is allowed*/
-                       if (!parse_data->option_independent) {
-                               pnp_warn("PnPACPI: more than one EndDependentFn");
-                               return AE_ERROR;
-                       }
-                       parse_data->option = parse_data->option_independent;
-                       parse_data->option_independent = NULL;
+               case ACPI_ACCEPTABLE_CONFIGURATION:
+                       priority = PNP_RES_PRIORITY_ACCEPTABLE;
                        break;
 
-               case ACPI_RESOURCE_TYPE_IO:
-                       pnpacpi_parse_port_option(option, &res->data.io);
+               case ACPI_SUB_OPTIMAL_CONFIGURATION:
+                       priority = PNP_RES_PRIORITY_FUNCTIONAL;
                        break;
-
-               case ACPI_RESOURCE_TYPE_FIXED_IO:
-                       pnpacpi_parse_fixed_port_option(option,
-                               &res->data.fixed_io);
+               default:
+                       priority = PNP_RES_PRIORITY_INVALID;
                        break;
+               }
+               /* TBD: Consider performance/robustness bits */
+               option = pnp_register_dependent_option(dev, priority);
+               if (!option)
+                       return AE_ERROR;
+               parse_data->option = option;
+               break;
 
-               case ACPI_RESOURCE_TYPE_VENDOR:
-               case ACPI_RESOURCE_TYPE_END_TAG:
-                       break;
+       case ACPI_RESOURCE_TYPE_END_DEPENDENT:
+               /*only one EndDependentFn is allowed */
+               if (!parse_data->option_independent) {
+                       dev_warn(&dev->dev, "more than one EndDependentFn "
+                                "in _PRS\n");
+                       return AE_ERROR;
+               }
+               parse_data->option = parse_data->option_independent;
+               parse_data->option_independent = NULL;
+               dev_dbg(&dev->dev, "end dependent options\n");
+               break;
 
-               case ACPI_RESOURCE_TYPE_MEMORY24:
-                       pnpacpi_parse_mem24_option(option, &res->data.memory24);
-                       break;
+       case ACPI_RESOURCE_TYPE_IO:
+               pnpacpi_parse_port_option(dev, option, &res->data.io);
+               break;
 
-               case ACPI_RESOURCE_TYPE_MEMORY32:
-                       pnpacpi_parse_mem32_option(option, &res->data.memory32);
-                       break;
+       case ACPI_RESOURCE_TYPE_FIXED_IO:
+               pnpacpi_parse_fixed_port_option(dev, option,
+                                               &res->data.fixed_io);
+               break;
 
-               case ACPI_RESOURCE_TYPE_FIXED_MEMORY32:
-                       pnpacpi_parse_fixed_mem32_option(option,
-                               &res->data.fixed_memory32);
-                       break;
+       case ACPI_RESOURCE_TYPE_VENDOR:
+       case ACPI_RESOURCE_TYPE_END_TAG:
+               break;
 
-               case ACPI_RESOURCE_TYPE_ADDRESS16:
-               case ACPI_RESOURCE_TYPE_ADDRESS32:
-               case ACPI_RESOURCE_TYPE_ADDRESS64:
-                       pnpacpi_parse_address_option(option, res);
-                       break;
+       case ACPI_RESOURCE_TYPE_MEMORY24:
+               pnpacpi_parse_mem24_option(dev, option, &res->data.memory24);
+               break;
 
-               case ACPI_RESOURCE_TYPE_EXTENDED_ADDRESS64:
-                       break;
+       case ACPI_RESOURCE_TYPE_MEMORY32:
+               pnpacpi_parse_mem32_option(dev, option, &res->data.memory32);
+               break;
 
-               case ACPI_RESOURCE_TYPE_EXTENDED_IRQ:
-                       pnpacpi_parse_ext_irq_option(option,
-                               &res->data.extended_irq);
-                       break;
+       case ACPI_RESOURCE_TYPE_FIXED_MEMORY32:
+               pnpacpi_parse_fixed_mem32_option(dev, option,
+                                                &res->data.fixed_memory32);
+               break;
 
-               case ACPI_RESOURCE_TYPE_GENERIC_REGISTER:
-                       break;
+       case ACPI_RESOURCE_TYPE_ADDRESS16:
+       case ACPI_RESOURCE_TYPE_ADDRESS32:
+       case ACPI_RESOURCE_TYPE_ADDRESS64:
+               pnpacpi_parse_address_option(dev, option, res);
+               break;
 
-               default:
-                       pnp_warn("PnPACPI: unknown resource type %d", res->type);
-                       return AE_ERROR;
+       case ACPI_RESOURCE_TYPE_EXTENDED_ADDRESS64:
+               break;
+
+       case ACPI_RESOURCE_TYPE_EXTENDED_IRQ:
+               pnpacpi_parse_ext_irq_option(dev, option,
+                                            &res->data.extended_irq);
+               break;
+
+       case ACPI_RESOURCE_TYPE_GENERIC_REGISTER:
+               break;
+
+       default:
+               dev_warn(&dev->dev, "unknown resource type %d in _PRS\n",
+                        res->type);
+               return AE_ERROR;
        }
 
        return AE_OK;
 }
 
-acpi_status pnpacpi_parse_resource_option_data(acpi_handle handle,
-       struct pnp_dev *dev)
+int __init pnpacpi_parse_resource_option_data(struct pnp_dev *dev)
 {
+       acpi_handle handle = dev->data;
        acpi_status status;
        struct acpipnp_parse_option_s parse_data;
 
+       dev_dbg(&dev->dev, "parse resource options\n");
+
        parse_data.option = pnp_register_independent_option(dev);
        if (!parse_data.option)
-               return AE_ERROR;
+               return -ENOMEM;
+
        parse_data.option_independent = parse_data.option;
        parse_data.dev = dev;
        status = acpi_walk_resources(handle, METHOD_NAME__PRS,
-               pnpacpi_option_resource, &parse_data);
+                                    pnpacpi_option_resource, &parse_data);
 
-       return status;
+       if (ACPI_FAILURE(status)) {
+               if (status != AE_NOT_FOUND)
+                       dev_err(&dev->dev, "can't evaluate _PRS: %d", status);
+               return -EPERM;
+       }
+       return 0;
 }
 
 static int pnpacpi_supported_resource(struct acpi_resource *res)
@@ -670,9 +739,9 @@ static int pnpacpi_supported_resource(struct acpi_resource *res)
  * Set resource
  */
 static acpi_status pnpacpi_count_resources(struct acpi_resource *res,
-       void *data)
+                                          void *data)
 {
-       int *res_cnt = (int *)data;
+       int *res_cnt = data;
 
        if (pnpacpi_supported_resource(res))
                (*res_cnt)++;
@@ -681,43 +750,47 @@ static acpi_status pnpacpi_count_resources(struct acpi_resource *res,
 
 static acpi_status pnpacpi_type_resources(struct acpi_resource *res, void *data)
 {
-       struct acpi_resource **resource = (struct acpi_resource **)data;
+       struct acpi_resource **resource = data;
 
        if (pnpacpi_supported_resource(res)) {
                (*resource)->type = res->type;
                (*resource)->length = sizeof(struct acpi_resource);
+               if (res->type == ACPI_RESOURCE_TYPE_IRQ)
+                       (*resource)->data.irq.descriptor_length =
+                                       res->data.irq.descriptor_length;
                (*resource)++;
        }
 
        return AE_OK;
 }
 
-int pnpacpi_build_resource_template(acpi_handle handle,
-       struct acpi_buffer *buffer)
+int pnpacpi_build_resource_template(struct pnp_dev *dev,
+                                   struct acpi_buffer *buffer)
 {
+       acpi_handle handle = dev->data;
        struct acpi_resource *resource;
        int res_cnt = 0;
        acpi_status status;
 
        status = acpi_walk_resources(handle, METHOD_NAME__CRS,
-               pnpacpi_count_resources, &res_cnt);
+                                    pnpacpi_count_resources, &res_cnt);
        if (ACPI_FAILURE(status)) {
-               pnp_err("Evaluate _CRS failed");
+               dev_err(&dev->dev, "can't evaluate _CRS: %d\n", status);
                return -EINVAL;
        }
        if (!res_cnt)
                return -EINVAL;
        buffer->length = sizeof(struct acpi_resource) * (res_cnt + 1) + 1;
-       buffer->pointer = kcalloc(1, buffer->length - 1, GFP_KERNEL);
+       buffer->pointer = kzalloc(buffer->length - 1, GFP_KERNEL);
        if (!buffer->pointer)
                return -ENOMEM;
-       pnp_dbg("Res cnt %d", res_cnt);
+
        resource = (struct acpi_resource *)buffer->pointer;
        status = acpi_walk_resources(handle, METHOD_NAME__CRS,
-               pnpacpi_type_resources, &resource);
+                                    pnpacpi_type_resources, &resource);
        if (ACPI_FAILURE(status)) {
                kfree(buffer->pointer);
-               pnp_err("Evaluate _CRS failed");
+               dev_err(&dev->dev, "can't evaluate _CRS: %d\n", status);
                return -EINVAL;
        }
        /* resource will pointer the end resource now */
@@ -726,175 +799,274 @@ int pnpacpi_build_resource_template(acpi_handle handle,
        return 0;
 }
 
-static void pnpacpi_encode_irq(struct acpi_resource *resource,
-       struct resource *p)
+static void pnpacpi_encode_irq(struct pnp_dev *dev,
+                              struct acpi_resource *resource,
+                              struct resource *p)
 {
-       int triggering, polarity;
+       struct acpi_resource_irq *irq = &resource->data.irq;
+       int triggering, polarity, shareable;
 
-       decode_irq_flags(p->flags & IORESOURCE_BITS, &triggering, &polarity);
-       resource->data.irq.triggering = triggering;
-       resource->data.irq.polarity = polarity;
-       if (triggering == ACPI_EDGE_SENSITIVE)
-               resource->data.irq.sharable = ACPI_EXCLUSIVE;
-       else
-               resource->data.irq.sharable = ACPI_SHARED;
-       resource->data.irq.interrupt_count = 1;
-       resource->data.irq.interrupts[0] = p->start;
+       if (!pnp_resource_enabled(p)) {
+               irq->interrupt_count = 0;
+               dev_dbg(&dev->dev, "  encode irq (%s)\n",
+                       p ? "disabled" : "missing");
+               return;
+       }
+
+       decode_irq_flags(dev, p->flags, &triggering, &polarity, &shareable);
+       irq->triggering = triggering;
+       irq->polarity = polarity;
+       irq->sharable = shareable;
+       irq->interrupt_count = 1;
+       irq->interrupts[0] = p->start;
+
+       dev_dbg(&dev->dev, "  encode irq %d %s %s %s (%d-byte descriptor)\n",
+               (int) p->start,
+               triggering == ACPI_LEVEL_SENSITIVE ? "level" : "edge",
+               polarity == ACPI_ACTIVE_LOW ? "low" : "high",
+               irq->sharable == ACPI_SHARED ? "shared" : "exclusive",
+               irq->descriptor_length);
 }
 
-static void pnpacpi_encode_ext_irq(struct acpi_resource *resource,
-       struct resource *p)
+static void pnpacpi_encode_ext_irq(struct pnp_dev *dev,
+                                  struct acpi_resource *resource,
+                                  struct resource *p)
 {
-       int triggering, polarity;
+       struct acpi_resource_extended_irq *extended_irq = &resource->data.extended_irq;
+       int triggering, polarity, shareable;
 
-       decode_irq_flags(p->flags & IORESOURCE_BITS, &triggering, &polarity);
-       resource->data.extended_irq.producer_consumer = ACPI_CONSUMER;
-       resource->data.extended_irq.triggering = triggering;
-       resource->data.extended_irq.polarity = polarity;
-       if (triggering == ACPI_EDGE_SENSITIVE)
-               resource->data.irq.sharable = ACPI_EXCLUSIVE;
-       else
-               resource->data.irq.sharable = ACPI_SHARED;
-       resource->data.extended_irq.interrupt_count = 1;
-       resource->data.extended_irq.interrupts[0] = p->start;
+       if (!pnp_resource_enabled(p)) {
+               extended_irq->interrupt_count = 0;
+               dev_dbg(&dev->dev, "  encode extended irq (%s)\n",
+                       p ? "disabled" : "missing");
+               return;
+       }
+
+       decode_irq_flags(dev, p->flags, &triggering, &polarity, &shareable);
+       extended_irq->producer_consumer = ACPI_CONSUMER;
+       extended_irq->triggering = triggering;
+       extended_irq->polarity = polarity;
+       extended_irq->sharable = shareable;
+       extended_irq->interrupt_count = 1;
+       extended_irq->interrupts[0] = p->start;
+
+       dev_dbg(&dev->dev, "  encode irq %d %s %s %s\n", (int) p->start,
+               triggering == ACPI_LEVEL_SENSITIVE ? "level" : "edge",
+               polarity == ACPI_ACTIVE_LOW ? "low" : "high",
+               extended_irq->sharable == ACPI_SHARED ? "shared" : "exclusive");
 }
 
-static void pnpacpi_encode_dma(struct acpi_resource *resource,
-       struct resource *p)
+static void pnpacpi_encode_dma(struct pnp_dev *dev,
+                              struct acpi_resource *resource,
+                              struct resource *p)
 {
+       struct acpi_resource_dma *dma = &resource->data.dma;
+
+       if (!pnp_resource_enabled(p)) {
+               dma->channel_count = 0;
+               dev_dbg(&dev->dev, "  encode dma (%s)\n",
+                       p ? "disabled" : "missing");
+               return;
+       }
+
        /* Note: pnp_assign_dma will copy pnp_dma->flags into p->flags */
-       if (p->flags & IORESOURCE_DMA_COMPATIBLE)
-               resource->data.dma.type = ACPI_COMPATIBILITY;
-       else if (p->flags & IORESOURCE_DMA_TYPEA)
-               resource->data.dma.type = ACPI_TYPE_A;
-       else if (p->flags & IORESOURCE_DMA_TYPEB)
-               resource->data.dma.type = ACPI_TYPE_B;
-       else if (p->flags & IORESOURCE_DMA_TYPEF)
-               resource->data.dma.type = ACPI_TYPE_F;
-       if (p->flags & IORESOURCE_DMA_8BIT)
-               resource->data.dma.transfer = ACPI_TRANSFER_8;
-       else if (p->flags & IORESOURCE_DMA_8AND16BIT)
-               resource->data.dma.transfer = ACPI_TRANSFER_8_16;
-       else if (p->flags & IORESOURCE_DMA_16BIT)
-               resource->data.dma.transfer = ACPI_TRANSFER_16;
-       resource->data.dma.bus_master = p->flags & IORESOURCE_DMA_MASTER;
-       resource->data.dma.channel_count = 1;
-       resource->data.dma.channels[0] = p->start;
-}
-
-static void pnpacpi_encode_io(struct acpi_resource *resource,
-       struct resource *p)
-{
-       /* Note: pnp_assign_port will copy pnp_port->flags into p->flags */
-       resource->data.io.io_decode = (p->flags & PNP_PORT_FLAG_16BITADDR)?
-               ACPI_DECODE_16 : ACPI_DECODE_10;
-       resource->data.io.minimum = p->start;
-       resource->data.io.maximum = p->end;
-       resource->data.io.alignment = 0; /* Correct? */
-       resource->data.io.address_length = p->end - p->start + 1;
-}
-
-static void pnpacpi_encode_fixed_io(struct acpi_resource *resource,
-       struct resource *p)
-{
-       resource->data.fixed_io.address = p->start;
-       resource->data.fixed_io.address_length = p->end - p->start + 1;
-}
-
-static void pnpacpi_encode_mem24(struct acpi_resource *resource,
-       struct resource *p)
-{
-       /* Note: pnp_assign_mem will copy pnp_mem->flags into p->flags */
-       resource->data.memory24.write_protect =
-               (p->flags & IORESOURCE_MEM_WRITEABLE) ?
-               ACPI_READ_WRITE_MEMORY : ACPI_READ_ONLY_MEMORY;
-       resource->data.memory24.minimum = p->start;
-       resource->data.memory24.maximum = p->end;
-       resource->data.memory24.alignment = 0;
-       resource->data.memory24.address_length = p->end - p->start + 1;
-}
-
-static void pnpacpi_encode_mem32(struct acpi_resource *resource,
-       struct resource *p)
-{
-       resource->data.memory32.write_protect =
-               (p->flags & IORESOURCE_MEM_WRITEABLE) ?
-               ACPI_READ_WRITE_MEMORY : ACPI_READ_ONLY_MEMORY;
-       resource->data.memory32.minimum = p->start;
-       resource->data.memory32.maximum = p->end;
-       resource->data.memory32.alignment = 0;
-       resource->data.memory32.address_length = p->end - p->start + 1;
-}
-
-static void pnpacpi_encode_fixed_mem32(struct acpi_resource *resource,
-       struct resource *p)
-{
-       resource->data.fixed_memory32.write_protect =
-               (p->flags & IORESOURCE_MEM_WRITEABLE) ?
-               ACPI_READ_WRITE_MEMORY : ACPI_READ_ONLY_MEMORY;
-       resource->data.fixed_memory32.address = p->start;
-       resource->data.fixed_memory32.address_length = p->end - p->start + 1;
-}
-
-int pnpacpi_encode_resources(struct pnp_resource_table *res_table,
-       struct acpi_buffer *buffer)
+       switch (p->flags & IORESOURCE_DMA_SPEED_MASK) {
+       case IORESOURCE_DMA_TYPEA:
+               dma->type = ACPI_TYPE_A;
+               break;
+       case IORESOURCE_DMA_TYPEB:
+               dma->type = ACPI_TYPE_B;
+               break;
+       case IORESOURCE_DMA_TYPEF:
+               dma->type = ACPI_TYPE_F;
+               break;
+       default:
+               dma->type = ACPI_COMPATIBILITY;
+       }
+
+       switch (p->flags & IORESOURCE_DMA_TYPE_MASK) {
+       case IORESOURCE_DMA_8BIT:
+               dma->transfer = ACPI_TRANSFER_8;
+               break;
+       case IORESOURCE_DMA_8AND16BIT:
+               dma->transfer = ACPI_TRANSFER_8_16;
+               break;
+       default:
+               dma->transfer = ACPI_TRANSFER_16;
+       }
+
+       dma->bus_master = !!(p->flags & IORESOURCE_DMA_MASTER);
+       dma->channel_count = 1;
+       dma->channels[0] = p->start;
+
+       dev_dbg(&dev->dev, "  encode dma %d "
+               "type %#x transfer %#x master %d\n",
+               (int) p->start, dma->type, dma->transfer, dma->bus_master);
+}
+
+static void pnpacpi_encode_io(struct pnp_dev *dev,
+                             struct acpi_resource *resource,
+                             struct resource *p)
+{
+       struct acpi_resource_io *io = &resource->data.io;
+
+       if (pnp_resource_enabled(p)) {
+               /* Note: pnp_assign_port copies pnp_port->flags into p->flags */
+               io->io_decode = (p->flags & PNP_PORT_FLAG_16BITADDR) ?
+                   ACPI_DECODE_16 : ACPI_DECODE_10;
+               io->minimum = p->start;
+               io->maximum = p->end;
+               io->alignment = 0;      /* Correct? */
+               io->address_length = p->end - p->start + 1;
+       } else {
+               io->minimum = 0;
+               io->address_length = 0;
+       }
+
+       dev_dbg(&dev->dev, "  encode io %#x-%#x decode %#x\n", io->minimum,
+               io->minimum + io->address_length - 1, io->io_decode);
+}
+
+static void pnpacpi_encode_fixed_io(struct pnp_dev *dev,
+                                   struct acpi_resource *resource,
+                                   struct resource *p)
+{
+       struct acpi_resource_fixed_io *fixed_io = &resource->data.fixed_io;
+
+       if (pnp_resource_enabled(p)) {
+               fixed_io->address = p->start;
+               fixed_io->address_length = p->end - p->start + 1;
+       } else {
+               fixed_io->address = 0;
+               fixed_io->address_length = 0;
+       }
+
+       dev_dbg(&dev->dev, "  encode fixed_io %#x-%#x\n", fixed_io->address,
+               fixed_io->address + fixed_io->address_length - 1);
+}
+
+static void pnpacpi_encode_mem24(struct pnp_dev *dev,
+                                struct acpi_resource *resource,
+                                struct resource *p)
+{
+       struct acpi_resource_memory24 *memory24 = &resource->data.memory24;
+
+       if (pnp_resource_enabled(p)) {
+               /* Note: pnp_assign_mem copies pnp_mem->flags into p->flags */
+               memory24->write_protect = p->flags & IORESOURCE_MEM_WRITEABLE ?
+                   ACPI_READ_WRITE_MEMORY : ACPI_READ_ONLY_MEMORY;
+               memory24->minimum = p->start;
+               memory24->maximum = p->end;
+               memory24->alignment = 0;
+               memory24->address_length = p->end - p->start + 1;
+       } else {
+               memory24->minimum = 0;
+               memory24->address_length = 0;
+       }
+
+       dev_dbg(&dev->dev, "  encode mem24 %#x-%#x write_protect %#x\n",
+               memory24->minimum,
+               memory24->minimum + memory24->address_length - 1,
+               memory24->write_protect);
+}
+
+static void pnpacpi_encode_mem32(struct pnp_dev *dev,
+                                struct acpi_resource *resource,
+                                struct resource *p)
+{
+       struct acpi_resource_memory32 *memory32 = &resource->data.memory32;
+
+       if (pnp_resource_enabled(p)) {
+               memory32->write_protect = p->flags & IORESOURCE_MEM_WRITEABLE ?
+                   ACPI_READ_WRITE_MEMORY : ACPI_READ_ONLY_MEMORY;
+               memory32->minimum = p->start;
+               memory32->maximum = p->end;
+               memory32->alignment = 0;
+               memory32->address_length = p->end - p->start + 1;
+       } else {
+               memory32->minimum = 0;
+               memory32->alignment = 0;
+       }
+
+       dev_dbg(&dev->dev, "  encode mem32 %#x-%#x write_protect %#x\n",
+               memory32->minimum,
+               memory32->minimum + memory32->address_length - 1,
+               memory32->write_protect);
+}
+
+static void pnpacpi_encode_fixed_mem32(struct pnp_dev *dev,
+                                      struct acpi_resource *resource,
+                                      struct resource *p)
+{
+       struct acpi_resource_fixed_memory32 *fixed_memory32 = &resource->data.fixed_memory32;
+
+       if (pnp_resource_enabled(p)) {
+               fixed_memory32->write_protect =
+                   p->flags & IORESOURCE_MEM_WRITEABLE ?
+                   ACPI_READ_WRITE_MEMORY : ACPI_READ_ONLY_MEMORY;
+               fixed_memory32->address = p->start;
+               fixed_memory32->address_length = p->end - p->start + 1;
+       } else {
+               fixed_memory32->address = 0;
+               fixed_memory32->address_length = 0;
+       }
+
+       dev_dbg(&dev->dev, "  encode fixed_mem32 %#x-%#x write_protect %#x\n",
+               fixed_memory32->address,
+               fixed_memory32->address + fixed_memory32->address_length - 1,
+               fixed_memory32->write_protect);
+}
+
+int pnpacpi_encode_resources(struct pnp_dev *dev, struct acpi_buffer *buffer)
 {
        int i = 0;
        /* pnpacpi_build_resource_template allocates extra mem */
-       int res_cnt = (buffer->length - 1)/sizeof(struct acpi_resource) - 1;
-       struct acpi_resource *resource = (struct acpi_resource*)buffer->pointer;
+       int res_cnt = (buffer->length - 1) / sizeof(struct acpi_resource) - 1;
+       struct acpi_resource *resource = buffer->pointer;
        int port = 0, irq = 0, dma = 0, mem = 0;
 
-       pnp_dbg("res cnt %d", res_cnt);
+       dev_dbg(&dev->dev, "encode %d resources\n", res_cnt);
        while (i < res_cnt) {
-               switch(resource->type) {
+               switch (resource->type) {
                case ACPI_RESOURCE_TYPE_IRQ:
-                       pnp_dbg("Encode irq");
-                       pnpacpi_encode_irq(resource,
-                               &res_table->irq_resource[irq]);
+                       pnpacpi_encode_irq(dev, resource,
+                              pnp_get_resource(dev, IORESOURCE_IRQ, irq));
                        irq++;
                        break;
 
                case ACPI_RESOURCE_TYPE_DMA:
-                       pnp_dbg("Encode dma");
-                       pnpacpi_encode_dma(resource,
-                               &res_table->dma_resource[dma]);
+                       pnpacpi_encode_dma(dev, resource,
+                               pnp_get_resource(dev, IORESOURCE_DMA, dma));
                        dma++;
                        break;
                case ACPI_RESOURCE_TYPE_IO:
-                       pnp_dbg("Encode io");
-                       pnpacpi_encode_io(resource,
-                               &res_table->port_resource[port]);
+                       pnpacpi_encode_io(dev, resource,
+                               pnp_get_resource(dev, IORESOURCE_IO, port));
                        port++;
                        break;
                case ACPI_RESOURCE_TYPE_FIXED_IO:
-                       pnp_dbg("Encode fixed io");
-                       pnpacpi_encode_fixed_io(resource,
-                               &res_table->port_resource[port]);
+                       pnpacpi_encode_fixed_io(dev, resource,
+                               pnp_get_resource(dev, IORESOURCE_IO, port));
                        port++;
                        break;
                case ACPI_RESOURCE_TYPE_MEMORY24:
-                       pnp_dbg("Encode mem24");
-                       pnpacpi_encode_mem24(resource,
-                               &res_table->mem_resource[mem]);
+                       pnpacpi_encode_mem24(dev, resource,
+                               pnp_get_resource(dev, IORESOURCE_MEM, mem));
                        mem++;
                        break;
                case ACPI_RESOURCE_TYPE_MEMORY32:
-                       pnp_dbg("Encode mem32");
-                       pnpacpi_encode_mem32(resource,
-                               &res_table->mem_resource[mem]);
+                       pnpacpi_encode_mem32(dev, resource,
+                               pnp_get_resource(dev, IORESOURCE_MEM, mem));
                        mem++;
                        break;
                case ACPI_RESOURCE_TYPE_FIXED_MEMORY32:
-                       pnp_dbg("Encode fixed mem32");
-                       pnpacpi_encode_fixed_mem32(resource,
-                               &res_table->mem_resource[mem]);
+                       pnpacpi_encode_fixed_mem32(dev, resource,
+                               pnp_get_resource(dev, IORESOURCE_MEM, mem));
                        mem++;
                        break;
                case ACPI_RESOURCE_TYPE_EXTENDED_IRQ:
-                       pnp_dbg("Encode ext irq");
-                       pnpacpi_encode_ext_irq(resource,
-                               &res_table->irq_resource[irq]);
+                       pnpacpi_encode_ext_irq(dev, resource,
+                               pnp_get_resource(dev, IORESOURCE_IRQ, irq));
                        irq++;
                        break;
                case ACPI_RESOURCE_TYPE_START_DEPENDENT:
@@ -906,8 +1078,9 @@ int pnpacpi_encode_resources(struct pnp_resource_table *res_table,
                case ACPI_RESOURCE_TYPE_ADDRESS64:
                case ACPI_RESOURCE_TYPE_EXTENDED_ADDRESS64:
                case ACPI_RESOURCE_TYPE_GENERIC_REGISTER:
-               default: /* other type */
-                       pnp_warn("unknown resource type %d", resource->type);
+               default:        /* other type */
+                       dev_warn(&dev->dev, "can't encode unknown resource "
+                                "type %d\n", resource->type);
                        return -EINVAL;
                }
                resource++;