PNP: add pnp_init_resources(struct pnp_dev *) interface
[safe/jmp/linux-2.6] / drivers / pnp / pnpacpi / rsparser.c
index 2a47e97..33dbf36 100644 (file)
 /*
  * Allocated Resources
  */
-static int irq_flags(int triggering, int polarity)
+static int irq_flags(int triggering, int polarity, int shareable)
 {
+       int flags;
+
        if (triggering == ACPI_LEVEL_SENSITIVE) {
                if (polarity == ACPI_ACTIVE_LOW)
-                       return IORESOURCE_IRQ_LOWLEVEL;
+                       flags = IORESOURCE_IRQ_LOWLEVEL;
                else
-                       return IORESOURCE_IRQ_HIGHLEVEL;
+                       flags = IORESOURCE_IRQ_HIGHLEVEL;
        } else {
                if (polarity == ACPI_ACTIVE_LOW)
-                       return IORESOURCE_IRQ_LOWEDGE;
+                       flags = IORESOURCE_IRQ_LOWEDGE;
                else
-                       return IORESOURCE_IRQ_HIGHEDGE;
+                       flags = IORESOURCE_IRQ_HIGHEDGE;
        }
+
+       if (shareable)
+               flags |= IORESOURCE_IRQ_SHAREABLE;
+
+       return flags;
 }
 
 static void decode_irq_flags(int flag, int *triggering, int *polarity)
@@ -69,10 +76,11 @@ static void decode_irq_flags(int flag, int *triggering, int *polarity)
        }
 }
 
-static void pnpacpi_parse_allocated_irqresource(struct pnp_resource_table *res,
+static void pnpacpi_parse_allocated_irqresource(struct pnp_dev *dev,
                                                u32 gsi, int triggering,
                                                int polarity, int shareable)
 {
+       struct pnp_resource_table *res = &dev->res;
        int i = 0;
        int irq;
        int p, t;
@@ -110,16 +118,13 @@ static void pnpacpi_parse_allocated_irqresource(struct pnp_resource_table *res,
        }
 
        res->irq_resource[i].flags = IORESOURCE_IRQ;    // Also clears _UNSET flag
-       res->irq_resource[i].flags |= irq_flags(triggering, polarity);
+       res->irq_resource[i].flags |= irq_flags(triggering, polarity, shareable);
        irq = acpi_register_gsi(gsi, triggering, polarity);
        if (irq < 0) {
                res->irq_resource[i].flags |= IORESOURCE_DISABLED;
                return;
        }
 
-       if (shareable)
-               res->irq_resource[i].flags |= IORESOURCE_IRQ_SHAREABLE;
-
        res->irq_resource[i].start = irq;
        res->irq_resource[i].end = irq;
        pcibios_penalize_isa_irq(irq, 1);
@@ -168,9 +173,10 @@ static int dma_flags(int type, int bus_master, int transfer)
        return flags;
 }
 
-static void pnpacpi_parse_allocated_dmaresource(struct pnp_resource_table *res,
+static void pnpacpi_parse_allocated_dmaresource(struct pnp_dev *dev,
                                                u32 dma, int flags)
 {
+       struct pnp_resource_table *res = &dev->res;
        int i = 0;
        static unsigned char warned;
 
@@ -193,9 +199,10 @@ static void pnpacpi_parse_allocated_dmaresource(struct pnp_resource_table *res,
        }
 }
 
-static void pnpacpi_parse_allocated_ioresource(struct pnp_resource_table *res,
+static void pnpacpi_parse_allocated_ioresource(struct pnp_dev *dev,
                                               u64 io, u64 len, int io_decode)
 {
+       struct pnp_resource_table *res = &dev->res;
        int i = 0;
        static unsigned char warned;
 
@@ -219,10 +226,11 @@ static void pnpacpi_parse_allocated_ioresource(struct pnp_resource_table *res,
        }
 }
 
-static void pnpacpi_parse_allocated_memresource(struct pnp_resource_table *res,
+static void pnpacpi_parse_allocated_memresource(struct pnp_dev *dev,
                                                u64 mem, u64 len,
                                                int write_protect)
 {
+       struct pnp_resource_table *res = &dev->res;
        int i = 0;
        static unsigned char warned;
 
@@ -247,7 +255,7 @@ static void pnpacpi_parse_allocated_memresource(struct pnp_resource_table *res,
        }
 }
 
-static void pnpacpi_parse_allocated_address_space(struct pnp_resource_table *res_table,
+static void pnpacpi_parse_allocated_address_space(struct pnp_dev *dev,
                                                  struct acpi_resource *res)
 {
        struct acpi_resource_address64 addr, *p = &addr;
@@ -264,11 +272,11 @@ static void pnpacpi_parse_allocated_address_space(struct pnp_resource_table *res
                return;
 
        if (p->resource_type == ACPI_MEMORY_RANGE)
-               pnpacpi_parse_allocated_memresource(res_table,
+               pnpacpi_parse_allocated_memresource(dev,
                        p->minimum, p->address_length,
                        p->info.mem.write_protect);
        else if (p->resource_type == ACPI_IO_RANGE)
-               pnpacpi_parse_allocated_ioresource(res_table,
+               pnpacpi_parse_allocated_ioresource(dev,
                        p->minimum, p->address_length,
                        p->granularity == 0xfff ? ACPI_DECODE_10 :
                                ACPI_DECODE_16);
@@ -277,7 +285,7 @@ static void pnpacpi_parse_allocated_address_space(struct pnp_resource_table *res
 static acpi_status pnpacpi_allocated_resource(struct acpi_resource *res,
                                              void *data)
 {
-       struct pnp_resource_table *res_table = data;
+       struct pnp_dev *dev = data;
        struct acpi_resource_irq *irq;
        struct acpi_resource_dma *dma;
        struct acpi_resource_io *io;
@@ -296,7 +304,7 @@ static acpi_status pnpacpi_allocated_resource(struct acpi_resource *res,
                 */
                irq = &res->data.irq;
                for (i = 0; i < irq->interrupt_count; i++) {
-                       pnpacpi_parse_allocated_irqresource(res_table,
+                       pnpacpi_parse_allocated_irqresource(dev,
                                irq->interrupts[i],
                                irq->triggering,
                                irq->polarity,
@@ -307,7 +315,7 @@ static acpi_status pnpacpi_allocated_resource(struct acpi_resource *res,
        case ACPI_RESOURCE_TYPE_DMA:
                dma = &res->data.dma;
                if (dma->channel_count > 0)
-                       pnpacpi_parse_allocated_dmaresource(res_table,
+                       pnpacpi_parse_allocated_dmaresource(dev,
                                dma->channels[0],
                                dma_flags(dma->type, dma->bus_master,
                                          dma->transfer));
@@ -315,7 +323,7 @@ static acpi_status pnpacpi_allocated_resource(struct acpi_resource *res,
 
        case ACPI_RESOURCE_TYPE_IO:
                io = &res->data.io;
-               pnpacpi_parse_allocated_ioresource(res_table,
+               pnpacpi_parse_allocated_ioresource(dev,
                        io->minimum,
                        io->address_length,
                        io->io_decode);
@@ -327,7 +335,7 @@ static acpi_status pnpacpi_allocated_resource(struct acpi_resource *res,
 
        case ACPI_RESOURCE_TYPE_FIXED_IO:
                fixed_io = &res->data.fixed_io;
-               pnpacpi_parse_allocated_ioresource(res_table,
+               pnpacpi_parse_allocated_ioresource(dev,
                        fixed_io->address,
                        fixed_io->address_length,
                        ACPI_DECODE_10);
@@ -341,21 +349,21 @@ static acpi_status pnpacpi_allocated_resource(struct acpi_resource *res,
 
        case ACPI_RESOURCE_TYPE_MEMORY24:
                memory24 = &res->data.memory24;
-               pnpacpi_parse_allocated_memresource(res_table,
+               pnpacpi_parse_allocated_memresource(dev,
                        memory24->minimum,
                        memory24->address_length,
                        memory24->write_protect);
                break;
        case ACPI_RESOURCE_TYPE_MEMORY32:
                memory32 = &res->data.memory32;
-               pnpacpi_parse_allocated_memresource(res_table,
+               pnpacpi_parse_allocated_memresource(dev,
                        memory32->minimum,
                        memory32->address_length,
                        memory32->write_protect);
                break;
        case ACPI_RESOURCE_TYPE_FIXED_MEMORY32:
                fixed_memory32 = &res->data.fixed_memory32;
-               pnpacpi_parse_allocated_memresource(res_table,
+               pnpacpi_parse_allocated_memresource(dev,
                        fixed_memory32->address,
                        fixed_memory32->address_length,
                        fixed_memory32->write_protect);
@@ -363,7 +371,7 @@ static acpi_status pnpacpi_allocated_resource(struct acpi_resource *res,
        case ACPI_RESOURCE_TYPE_ADDRESS16:
        case ACPI_RESOURCE_TYPE_ADDRESS32:
        case ACPI_RESOURCE_TYPE_ADDRESS64:
-               pnpacpi_parse_allocated_address_space(res_table, res);
+               pnpacpi_parse_allocated_address_space(dev, res);
                break;
 
        case ACPI_RESOURCE_TYPE_EXTENDED_ADDRESS64:
@@ -377,7 +385,7 @@ static acpi_status pnpacpi_allocated_resource(struct acpi_resource *res,
                        return AE_OK;
 
                for (i = 0; i < extended_irq->interrupt_count; i++) {
-                       pnpacpi_parse_allocated_irqresource(res_table,
+                       pnpacpi_parse_allocated_irqresource(dev,
                                extended_irq->interrupts[i],
                                extended_irq->triggering,
                                extended_irq->polarity,
@@ -396,17 +404,20 @@ static acpi_status pnpacpi_allocated_resource(struct acpi_resource *res,
        return AE_OK;
 }
 
-acpi_status pnpacpi_parse_allocated_resource(acpi_handle handle,
-                                            struct pnp_resource_table * res)
+acpi_status pnpacpi_parse_allocated_resource(struct pnp_dev *dev)
 {
-       /* Blank the resource table values */
-       pnp_init_resource_table(res);
+       acpi_handle handle = dev->data;
+
+       dev_dbg(&dev->dev, "parse allocated resources\n");
+
+       pnp_init_resources(dev);
 
        return acpi_walk_resources(handle, METHOD_NAME__CRS,
-                                  pnpacpi_allocated_resource, res);
+                                  pnpacpi_allocated_resource, dev);
 }
 
-static __init void pnpacpi_parse_dma_option(struct pnp_option *option,
+static __init void pnpacpi_parse_dma_option(struct pnp_dev *dev,
+                                           struct pnp_option *option,
                                            struct acpi_resource_dma *p)
 {
        int i;
@@ -423,10 +434,11 @@ static __init void pnpacpi_parse_dma_option(struct pnp_option *option,
 
        dma->flags = dma_flags(p->type, p->bus_master, p->transfer);
 
-       pnp_register_dma_resource(option, dma);
+       pnp_register_dma_resource(dev, option, dma);
 }
 
-static __init void pnpacpi_parse_irq_option(struct pnp_option *option,
+static __init void pnpacpi_parse_irq_option(struct pnp_dev *dev,
+                                           struct pnp_option *option,
                                            struct acpi_resource_irq *p)
 {
        int i;
@@ -441,12 +453,13 @@ static __init void pnpacpi_parse_irq_option(struct pnp_option *option,
        for (i = 0; i < p->interrupt_count; i++)
                if (p->interrupts[i])
                        __set_bit(p->interrupts[i], irq->map);
-       irq->flags = irq_flags(p->triggering, p->polarity);
+       irq->flags = irq_flags(p->triggering, p->polarity, p->sharable);
 
-       pnp_register_irq_resource(option, irq);
+       pnp_register_irq_resource(dev, option, irq);
 }
 
-static __init void pnpacpi_parse_ext_irq_option(struct pnp_option *option,
+static __init void pnpacpi_parse_ext_irq_option(struct pnp_dev *dev,
+                                               struct pnp_option *option,
                                        struct acpi_resource_extended_irq *p)
 {
        int i;
@@ -461,12 +474,13 @@ static __init void pnpacpi_parse_ext_irq_option(struct pnp_option *option,
        for (i = 0; i < p->interrupt_count; i++)
                if (p->interrupts[i])
                        __set_bit(p->interrupts[i], irq->map);
-       irq->flags = irq_flags(p->triggering, p->polarity);
+       irq->flags = irq_flags(p->triggering, p->polarity, p->sharable);
 
-       pnp_register_irq_resource(option, irq);
+       pnp_register_irq_resource(dev, option, irq);
 }
 
-static __init void pnpacpi_parse_port_option(struct pnp_option *option,
+static __init void pnpacpi_parse_port_option(struct pnp_dev *dev,
+                                            struct pnp_option *option,
                                             struct acpi_resource_io *io)
 {
        struct pnp_port *port;
@@ -482,10 +496,11 @@ static __init void pnpacpi_parse_port_option(struct pnp_option *option,
        port->size = io->address_length;
        port->flags = ACPI_DECODE_16 == io->io_decode ?
            PNP_PORT_FLAG_16BITADDR : 0;
-       pnp_register_port_resource(option, port);
+       pnp_register_port_resource(dev, option, port);
 }
 
-static __init void pnpacpi_parse_fixed_port_option(struct pnp_option *option,
+static __init void pnpacpi_parse_fixed_port_option(struct pnp_dev *dev,
+                                                  struct pnp_option *option,
                                        struct acpi_resource_fixed_io *io)
 {
        struct pnp_port *port;
@@ -499,10 +514,11 @@ static __init void pnpacpi_parse_fixed_port_option(struct pnp_option *option,
        port->size = io->address_length;
        port->align = 0;
        port->flags = PNP_PORT_FLAG_FIXED;
-       pnp_register_port_resource(option, port);
+       pnp_register_port_resource(dev, option, port);
 }
 
-static __init void pnpacpi_parse_mem24_option(struct pnp_option *option,
+static __init void pnpacpi_parse_mem24_option(struct pnp_dev *dev,
+                                             struct pnp_option *option,
                                              struct acpi_resource_memory24 *p)
 {
        struct pnp_mem *mem;
@@ -520,10 +536,11 @@ static __init void pnpacpi_parse_mem24_option(struct pnp_option *option,
        mem->flags = (ACPI_READ_WRITE_MEMORY == p->write_protect) ?
            IORESOURCE_MEM_WRITEABLE : 0;
 
-       pnp_register_mem_resource(option, mem);
+       pnp_register_mem_resource(dev, option, mem);
 }
 
-static __init void pnpacpi_parse_mem32_option(struct pnp_option *option,
+static __init void pnpacpi_parse_mem32_option(struct pnp_dev *dev,
+                                             struct pnp_option *option,
                                              struct acpi_resource_memory32 *p)
 {
        struct pnp_mem *mem;
@@ -541,10 +558,11 @@ static __init void pnpacpi_parse_mem32_option(struct pnp_option *option,
        mem->flags = (ACPI_READ_WRITE_MEMORY == p->write_protect) ?
            IORESOURCE_MEM_WRITEABLE : 0;
 
-       pnp_register_mem_resource(option, mem);
+       pnp_register_mem_resource(dev, option, mem);
 }
 
-static __init void pnpacpi_parse_fixed_mem32_option(struct pnp_option *option,
+static __init void pnpacpi_parse_fixed_mem32_option(struct pnp_dev *dev,
+                                                   struct pnp_option *option,
                                        struct acpi_resource_fixed_memory32 *p)
 {
        struct pnp_mem *mem;
@@ -561,10 +579,11 @@ static __init void pnpacpi_parse_fixed_mem32_option(struct pnp_option *option,
        mem->flags = (ACPI_READ_WRITE_MEMORY == p->write_protect) ?
            IORESOURCE_MEM_WRITEABLE : 0;
 
-       pnp_register_mem_resource(option, mem);
+       pnp_register_mem_resource(dev, option, mem);
 }
 
-static __init void pnpacpi_parse_address_option(struct pnp_option *option,
+static __init void pnpacpi_parse_address_option(struct pnp_dev *dev,
+                                               struct pnp_option *option,
                                                struct acpi_resource *r)
 {
        struct acpi_resource_address64 addr, *p = &addr;
@@ -592,7 +611,7 @@ static __init void pnpacpi_parse_address_option(struct pnp_option *option,
                mem->flags = (p->info.mem.write_protect ==
                              ACPI_READ_WRITE_MEMORY) ? IORESOURCE_MEM_WRITEABLE
                    : 0;
-               pnp_register_mem_resource(option, mem);
+               pnp_register_mem_resource(dev, option, mem);
        } else if (p->resource_type == ACPI_IO_RANGE) {
                port = kzalloc(sizeof(struct pnp_port), GFP_KERNEL);
                if (!port)
@@ -601,7 +620,7 @@ static __init void pnpacpi_parse_address_option(struct pnp_option *option,
                port->size = p->address_length;
                port->align = 0;
                port->flags = PNP_PORT_FLAG_FIXED;
-               pnp_register_port_resource(option, port);
+               pnp_register_port_resource(dev, option, port);
        }
 }
 
@@ -621,11 +640,11 @@ static __init acpi_status pnpacpi_option_resource(struct acpi_resource *res,
 
        switch (res->type) {
        case ACPI_RESOURCE_TYPE_IRQ:
-               pnpacpi_parse_irq_option(option, &res->data.irq);
+               pnpacpi_parse_irq_option(dev, option, &res->data.irq);
                break;
 
        case ACPI_RESOURCE_TYPE_DMA:
-               pnpacpi_parse_dma_option(option, &res->data.dma);
+               pnpacpi_parse_dma_option(dev, option, &res->data.dma);
                break;
 
        case ACPI_RESOURCE_TYPE_START_DEPENDENT:
@@ -660,14 +679,16 @@ static __init acpi_status pnpacpi_option_resource(struct acpi_resource *res,
                }
                parse_data->option = parse_data->option_independent;
                parse_data->option_independent = NULL;
+               dev_dbg(&dev->dev, "end dependent options\n");
                break;
 
        case ACPI_RESOURCE_TYPE_IO:
-               pnpacpi_parse_port_option(option, &res->data.io);
+               pnpacpi_parse_port_option(dev, option, &res->data.io);
                break;
 
        case ACPI_RESOURCE_TYPE_FIXED_IO:
-               pnpacpi_parse_fixed_port_option(option, &res->data.fixed_io);
+               pnpacpi_parse_fixed_port_option(dev, option,
+                                               &res->data.fixed_io);
                break;
 
        case ACPI_RESOURCE_TYPE_VENDOR:
@@ -675,29 +696,30 @@ static __init acpi_status pnpacpi_option_resource(struct acpi_resource *res,
                break;
 
        case ACPI_RESOURCE_TYPE_MEMORY24:
-               pnpacpi_parse_mem24_option(option, &res->data.memory24);
+               pnpacpi_parse_mem24_option(dev, option, &res->data.memory24);
                break;
 
        case ACPI_RESOURCE_TYPE_MEMORY32:
-               pnpacpi_parse_mem32_option(option, &res->data.memory32);
+               pnpacpi_parse_mem32_option(dev, option, &res->data.memory32);
                break;
 
        case ACPI_RESOURCE_TYPE_FIXED_MEMORY32:
-               pnpacpi_parse_fixed_mem32_option(option,
+               pnpacpi_parse_fixed_mem32_option(dev, option,
                                                 &res->data.fixed_memory32);
                break;
 
        case ACPI_RESOURCE_TYPE_ADDRESS16:
        case ACPI_RESOURCE_TYPE_ADDRESS32:
        case ACPI_RESOURCE_TYPE_ADDRESS64:
-               pnpacpi_parse_address_option(option, res);
+               pnpacpi_parse_address_option(dev, option, res);
                break;
 
        case ACPI_RESOURCE_TYPE_EXTENDED_ADDRESS64:
                break;
 
        case ACPI_RESOURCE_TYPE_EXTENDED_IRQ:
-               pnpacpi_parse_ext_irq_option(option, &res->data.extended_irq);
+               pnpacpi_parse_ext_irq_option(dev, option,
+                                            &res->data.extended_irq);
                break;
 
        case ACPI_RESOURCE_TYPE_GENERIC_REGISTER:
@@ -711,12 +733,14 @@ static __init acpi_status pnpacpi_option_resource(struct acpi_resource *res,
        return AE_OK;
 }
 
-acpi_status __init pnpacpi_parse_resource_option_data(acpi_handle handle,
-                                                     struct pnp_dev *dev)
+acpi_status __init pnpacpi_parse_resource_option_data(struct pnp_dev *dev)
 {
+       acpi_handle handle = dev->data;
        acpi_status status;
        struct acpipnp_parse_option_s parse_data;
 
+       dev_dbg(&dev->dev, "parse resource options\n");
+
        parse_data.option = pnp_register_independent_option(dev);
        if (!parse_data.option)
                return AE_ERROR;
@@ -773,9 +797,10 @@ static acpi_status pnpacpi_type_resources(struct acpi_resource *res, void *data)
        return AE_OK;
 }
 
-int pnpacpi_build_resource_template(acpi_handle handle,
+int pnpacpi_build_resource_template(struct pnp_dev *dev,
                                    struct acpi_buffer *buffer)
 {
+       acpi_handle handle = dev->data;
        struct acpi_resource *resource;
        int res_cnt = 0;
        acpi_status status;
@@ -792,7 +817,7 @@ int pnpacpi_build_resource_template(acpi_handle handle,
        buffer->pointer = kzalloc(buffer->length - 1, GFP_KERNEL);
        if (!buffer->pointer)
                return -ENOMEM;
-       pnp_dbg("Res cnt %d", res_cnt);
+
        resource = (struct acpi_resource *)buffer->pointer;
        status = acpi_walk_resources(handle, METHOD_NAME__CRS,
                                     pnpacpi_type_resources, &resource);
@@ -807,7 +832,8 @@ int pnpacpi_build_resource_template(acpi_handle handle,
        return 0;
 }
 
-static void pnpacpi_encode_irq(struct acpi_resource *resource,
+static void pnpacpi_encode_irq(struct pnp_dev *dev,
+                              struct acpi_resource *resource,
                               struct resource *p)
 {
        struct acpi_resource_irq *irq = &resource->data.irq;
@@ -822,9 +848,15 @@ static void pnpacpi_encode_irq(struct acpi_resource *resource,
                irq->sharable = ACPI_SHARED;
        irq->interrupt_count = 1;
        irq->interrupts[0] = p->start;
+
+       dev_dbg(&dev->dev, "  encode irq %d %s %s %s\n", (int) p->start,
+               triggering == ACPI_LEVEL_SENSITIVE ? "level" : "edge",
+               polarity == ACPI_ACTIVE_LOW ? "low" : "high",
+               irq->sharable == ACPI_SHARED ? "shared" : "exclusive");
 }
 
-static void pnpacpi_encode_ext_irq(struct acpi_resource *resource,
+static void pnpacpi_encode_ext_irq(struct pnp_dev *dev,
+                                  struct acpi_resource *resource,
                                   struct resource *p)
 {
        struct acpi_resource_extended_irq *extended_irq = &resource->data.extended_irq;
@@ -840,9 +872,15 @@ static void pnpacpi_encode_ext_irq(struct acpi_resource *resource,
                extended_irq->sharable = ACPI_SHARED;
        extended_irq->interrupt_count = 1;
        extended_irq->interrupts[0] = p->start;
+
+       dev_dbg(&dev->dev, "  encode irq %d %s %s %s\n", (int) p->start,
+               triggering == ACPI_LEVEL_SENSITIVE ? "level" : "edge",
+               polarity == ACPI_ACTIVE_LOW ? "low" : "high",
+               extended_irq->sharable == ACPI_SHARED ? "shared" : "exclusive");
 }
 
-static void pnpacpi_encode_dma(struct acpi_resource *resource,
+static void pnpacpi_encode_dma(struct pnp_dev *dev,
+                              struct acpi_resource *resource,
                               struct resource *p)
 {
        struct acpi_resource_dma *dma = &resource->data.dma;
@@ -876,9 +914,14 @@ static void pnpacpi_encode_dma(struct acpi_resource *resource,
        dma->bus_master = !!(p->flags & IORESOURCE_DMA_MASTER);
        dma->channel_count = 1;
        dma->channels[0] = p->start;
+
+       dev_dbg(&dev->dev, "  encode dma %d "
+               "type %#x transfer %#x master %d\n",
+               (int) p->start, dma->type, dma->transfer, dma->bus_master);
 }
 
-static void pnpacpi_encode_io(struct acpi_resource *resource,
+static void pnpacpi_encode_io(struct pnp_dev *dev,
+                             struct acpi_resource *resource,
                              struct resource *p)
 {
        struct acpi_resource_io *io = &resource->data.io;
@@ -890,18 +933,27 @@ static void pnpacpi_encode_io(struct acpi_resource *resource,
        io->maximum = p->end;
        io->alignment = 0;      /* Correct? */
        io->address_length = p->end - p->start + 1;
+
+       dev_dbg(&dev->dev, "  encode io %#llx-%#llx decode %#x\n",
+               (unsigned long long) p->start, (unsigned long long) p->end,
+               io->io_decode);
 }
 
-static void pnpacpi_encode_fixed_io(struct acpi_resource *resource,
+static void pnpacpi_encode_fixed_io(struct pnp_dev *dev,
+                                   struct acpi_resource *resource,
                                    struct resource *p)
 {
        struct acpi_resource_fixed_io *fixed_io = &resource->data.fixed_io;
 
        fixed_io->address = p->start;
        fixed_io->address_length = p->end - p->start + 1;
+
+       dev_dbg(&dev->dev, "  encode fixed_io %#llx-%#llx\n",
+               (unsigned long long) p->start, (unsigned long long) p->end);
 }
 
-static void pnpacpi_encode_mem24(struct acpi_resource *resource,
+static void pnpacpi_encode_mem24(struct pnp_dev *dev,
+                                struct acpi_resource *resource,
                                 struct resource *p)
 {
        struct acpi_resource_memory24 *memory24 = &resource->data.memory24;
@@ -914,9 +966,14 @@ static void pnpacpi_encode_mem24(struct acpi_resource *resource,
        memory24->maximum = p->end;
        memory24->alignment = 0;
        memory24->address_length = p->end - p->start + 1;
+
+       dev_dbg(&dev->dev, "  encode mem24 %#llx-%#llx write_protect %#x\n",
+               (unsigned long long) p->start, (unsigned long long) p->end,
+               memory24->write_protect);
 }
 
-static void pnpacpi_encode_mem32(struct acpi_resource *resource,
+static void pnpacpi_encode_mem32(struct pnp_dev *dev,
+                                struct acpi_resource *resource,
                                 struct resource *p)
 {
        struct acpi_resource_memory32 *memory32 = &resource->data.memory32;
@@ -928,9 +985,14 @@ static void pnpacpi_encode_mem32(struct acpi_resource *resource,
        memory32->maximum = p->end;
        memory32->alignment = 0;
        memory32->address_length = p->end - p->start + 1;
+
+       dev_dbg(&dev->dev, "  encode mem32 %#llx-%#llx write_protect %#x\n",
+               (unsigned long long) p->start, (unsigned long long) p->end,
+               memory32->write_protect);
 }
 
-static void pnpacpi_encode_fixed_mem32(struct acpi_resource *resource,
+static void pnpacpi_encode_fixed_mem32(struct pnp_dev *dev,
+                                      struct acpi_resource *resource,
                                       struct resource *p)
 {
        struct acpi_resource_fixed_memory32 *fixed_memory32 = &resource->data.fixed_memory32;
@@ -940,68 +1002,65 @@ static void pnpacpi_encode_fixed_mem32(struct acpi_resource *resource,
            ACPI_READ_WRITE_MEMORY : ACPI_READ_ONLY_MEMORY;
        fixed_memory32->address = p->start;
        fixed_memory32->address_length = p->end - p->start + 1;
+
+       dev_dbg(&dev->dev, "  encode fixed_mem32 %#llx-%#llx "
+               "write_protect %#x\n",
+               (unsigned long long) p->start, (unsigned long long) p->end,
+               fixed_memory32->write_protect);
 }
 
-int pnpacpi_encode_resources(struct pnp_resource_table *res_table,
-                            struct acpi_buffer *buffer)
+int pnpacpi_encode_resources(struct pnp_dev *dev, struct acpi_buffer *buffer)
 {
+       struct pnp_resource_table *res_table = &dev->res;
        int i = 0;
        /* pnpacpi_build_resource_template allocates extra mem */
        int res_cnt = (buffer->length - 1) / sizeof(struct acpi_resource) - 1;
        struct acpi_resource *resource = buffer->pointer;
        int port = 0, irq = 0, dma = 0, mem = 0;
 
-       pnp_dbg("res cnt %d", res_cnt);
+       dev_dbg(&dev->dev, "encode %d resources\n", res_cnt);
        while (i < res_cnt) {
                switch (resource->type) {
                case ACPI_RESOURCE_TYPE_IRQ:
-                       pnp_dbg("Encode irq");
-                       pnpacpi_encode_irq(resource,
+                       pnpacpi_encode_irq(dev, resource,
                                           &res_table->irq_resource[irq]);
                        irq++;
                        break;
 
                case ACPI_RESOURCE_TYPE_DMA:
-                       pnp_dbg("Encode dma");
-                       pnpacpi_encode_dma(resource,
+                       pnpacpi_encode_dma(dev, resource,
                                           &res_table->dma_resource[dma]);
                        dma++;
                        break;
                case ACPI_RESOURCE_TYPE_IO:
-                       pnp_dbg("Encode io");
-                       pnpacpi_encode_io(resource,
+                       pnpacpi_encode_io(dev, resource,
                                          &res_table->port_resource[port]);
                        port++;
                        break;
                case ACPI_RESOURCE_TYPE_FIXED_IO:
-                       pnp_dbg("Encode fixed io");
-                       pnpacpi_encode_fixed_io(resource,
+                       pnpacpi_encode_fixed_io(dev, resource,
                                                &res_table->
                                                port_resource[port]);
                        port++;
                        break;
                case ACPI_RESOURCE_TYPE_MEMORY24:
-                       pnp_dbg("Encode mem24");
-                       pnpacpi_encode_mem24(resource,
+                       pnpacpi_encode_mem24(dev, resource,
                                             &res_table->mem_resource[mem]);
                        mem++;
                        break;
                case ACPI_RESOURCE_TYPE_MEMORY32:
-                       pnp_dbg("Encode mem32");
-                       pnpacpi_encode_mem32(resource,
+                       pnpacpi_encode_mem32(dev, resource,
                                             &res_table->mem_resource[mem]);
                        mem++;
                        break;
                case ACPI_RESOURCE_TYPE_FIXED_MEMORY32:
-                       pnp_dbg("Encode fixed mem32");
-                       pnpacpi_encode_fixed_mem32(resource,
+                       pnpacpi_encode_fixed_mem32(dev, resource,
                                                   &res_table->
                                                   mem_resource[mem]);
                        mem++;
                        break;
                case ACPI_RESOURCE_TYPE_EXTENDED_IRQ:
-                       pnp_dbg("Encode ext irq");
-                       pnpacpi_encode_ext_irq(resource,
+                       pnpacpi_encode_ext_irq(dev, resource,
                                               &res_table->irq_resource[irq]);
                        irq++;
                        break;