PNP: replace pnp_resource_table with dynamically allocated resources
[safe/jmp/linux-2.6] / drivers / pnp / isapnp / core.c
index 38ff64d..ca4457e 100644 (file)
@@ -416,15 +416,12 @@ static struct pnp_dev *__init isapnp_parse_device(struct pnp_card *card,
        if (!dev)
                return NULL;
 
-       dev->regs = tmp[4];
        dev->card = card;
-       if (size > 5)
-               dev->regs |= tmp[5] << 8;
        dev->capabilities |= PNP_CONFIGURABLE;
        dev->capabilities |= PNP_READ;
        dev->capabilities |= PNP_WRITE;
        dev->capabilities |= PNP_DISABLE;
-       pnp_init_resource_table(&dev->res);
+       pnp_init_resources(dev);
        return dev;
 }
 
@@ -737,9 +734,8 @@ static int __init isapnp_create_device(struct pnp_card *card,
                                isapnp_skip_bytes(size);
                        return 1;
                default:
-                       printk(KERN_ERR
-                              "isapnp: unexpected or unknown tag type 0x%x for logical device %i (device %i), ignored\n",
-                              type, dev->number, card->number);
+                       dev_err(&dev->dev, "unknown tag %#x (card %i), "
+                               "ignored\n", type, card->number);
                }
 __skip:
                if (size > 0)
@@ -792,9 +788,8 @@ static void __init isapnp_parse_resource_map(struct pnp_card *card)
                                isapnp_skip_bytes(size);
                        return;
                default:
-                       printk(KERN_ERR
-                              "isapnp: unexpected or unknown tag type 0x%x for device %i, ignored\n",
-                              type, card->number);
+                       dev_err(&card->dev, "unknown tag %#x, ignored\n",
+                              type);
                }
 __skip:
                if (size > 0)
@@ -841,13 +836,6 @@ static int __init isapnp_build_device_list(void)
                isapnp_wake(csn);
                isapnp_peek(header, 9);
                checksum = isapnp_checksum(header);
-#if 0
-               printk(KERN_DEBUG
-                      "vendor: %02x:%02x:%02x:%02x:%02x:%02x:%02x:%02x:%02x\n",
-                      header[0], header[1], header[2], header[3], header[4],
-                      header[5], header[6], header[7], header[8]);
-               printk(KERN_DEBUG "checksum = 0x%x\n", checksum);
-#endif
                eisa_id = header[0] | header[1] << 8 |
                          header[2] << 16 | header[3] << 24;
                pnp_eisa_id_to_string(eisa_id, id);
@@ -855,6 +843,13 @@ static int __init isapnp_build_device_list(void)
                if (!card)
                        continue;
 
+#if 0
+               dev_info(&card->dev,
+                      "vendor: %02x:%02x:%02x:%02x:%02x:%02x:%02x:%02x:%02x\n",
+                      header[0], header[1], header[2], header[3], header[4],
+                      header[5], header[6], header[7], header[8]);
+               dev_info(&card->dev, "checksum = %#x\n", checksum);
+#endif
                INIT_LIST_HEAD(&card->devices);
                card->serial =
                    (header[7] << 24) | (header[6] << 16) | (header[5] << 8) |
@@ -862,9 +857,8 @@ static int __init isapnp_build_device_list(void)
                isapnp_checksum_value = 0x00;
                isapnp_parse_resource_map(card);
                if (isapnp_checksum_value != 0x00)
-                       printk(KERN_ERR
-                              "isapnp: checksum for device %i is not valid (0x%x)\n",
-                              csn, isapnp_checksum_value);
+                       dev_err(&card->dev, "invalid checksum %#x\n",
+                               isapnp_checksum_value);
                card->checksum = isapnp_checksum_value;
 
                pnp_add_card(card);
@@ -932,100 +926,87 @@ EXPORT_SYMBOL(isapnp_cfg_begin);
 EXPORT_SYMBOL(isapnp_cfg_end);
 EXPORT_SYMBOL(isapnp_write_byte);
 
-static int isapnp_read_resources(struct pnp_dev *dev,
-                                struct pnp_resource_table *res)
+static int isapnp_get_resources(struct pnp_dev *dev)
 {
-       int tmp, ret;
+       int i, ret;
 
+       dev_dbg(&dev->dev, "get resources\n");
+       pnp_init_resources(dev);
+       isapnp_cfg_begin(dev->card->number, dev->number);
        dev->active = isapnp_read_byte(ISAPNP_CFG_ACTIVATE);
-       if (dev->active) {
-               for (tmp = 0; tmp < ISAPNP_MAX_PORT; tmp++) {
-                       ret = isapnp_read_word(ISAPNP_CFG_PORT + (tmp << 1));
-                       if (!ret)
-                               continue;
-                       res->port_resource[tmp].start = ret;
-                       res->port_resource[tmp].flags = IORESOURCE_IO;
-               }
-               for (tmp = 0; tmp < ISAPNP_MAX_MEM; tmp++) {
-                       ret =
-                           isapnp_read_word(ISAPNP_CFG_MEM + (tmp << 3)) << 8;
-                       if (!ret)
-                               continue;
-                       res->mem_resource[tmp].start = ret;
-                       res->mem_resource[tmp].flags = IORESOURCE_MEM;
-               }
-               for (tmp = 0; tmp < ISAPNP_MAX_IRQ; tmp++) {
-                       ret =
-                           (isapnp_read_word(ISAPNP_CFG_IRQ + (tmp << 1)) >>
-                            8);
-                       if (!ret)
-                               continue;
-                       res->irq_resource[tmp].start =
-                           res->irq_resource[tmp].end = ret;
-                       res->irq_resource[tmp].flags = IORESOURCE_IRQ;
-               }
-               for (tmp = 0; tmp < ISAPNP_MAX_DMA; tmp++) {
-                       ret = isapnp_read_byte(ISAPNP_CFG_DMA + tmp);
-                       if (ret == 4)
-                               continue;
-                       res->dma_resource[tmp].start =
-                           res->dma_resource[tmp].end = ret;
-                       res->dma_resource[tmp].flags = IORESOURCE_DMA;
-               }
-       }
-       return 0;
-}
+       if (!dev->active)
+               goto __end;
 
-static int isapnp_get_resources(struct pnp_dev *dev,
-                               struct pnp_resource_table *res)
-{
-       int ret;
+       for (i = 0; i < ISAPNP_MAX_PORT; i++) {
+               ret = isapnp_read_word(ISAPNP_CFG_PORT + (i << 1));
+               pnp_add_io_resource(dev, ret, ret,
+                                   ret == 0 ? IORESOURCE_DISABLED : 0);
+       }
+       for (i = 0; i < ISAPNP_MAX_MEM; i++) {
+               ret = isapnp_read_word(ISAPNP_CFG_MEM + (i << 3)) << 8;
+               pnp_add_mem_resource(dev, ret, ret,
+                                    ret == 0 ? IORESOURCE_DISABLED : 0);
+       }
+       for (i = 0; i < ISAPNP_MAX_IRQ; i++) {
+               ret = isapnp_read_word(ISAPNP_CFG_IRQ + (i << 1)) >> 8;
+               pnp_add_irq_resource(dev, ret,
+                                    ret == 0 ? IORESOURCE_DISABLED : 0);
+       }
+       for (i = 0; i < ISAPNP_MAX_DMA; i++) {
+               ret = isapnp_read_byte(ISAPNP_CFG_DMA + i);
+               pnp_add_dma_resource(dev, ret,
+                                    ret == 4 ? IORESOURCE_DISABLED : 0);
+       }
 
-       pnp_init_resource_table(res);
-       isapnp_cfg_begin(dev->card->number, dev->number);
-       ret = isapnp_read_resources(dev, res);
+__end:
        isapnp_cfg_end();
-       return ret;
+       return 0;
 }
 
-static int isapnp_set_resources(struct pnp_dev *dev,
-                               struct pnp_resource_table *res)
+static int isapnp_set_resources(struct pnp_dev *dev)
 {
+       struct resource *res;
        int tmp;
 
+       dev_dbg(&dev->dev, "set resources\n");
        isapnp_cfg_begin(dev->card->number, dev->number);
        dev->active = 1;
-       for (tmp = 0;
-            tmp < ISAPNP_MAX_PORT
-            && (res->port_resource[tmp].
-                flags & (IORESOURCE_IO | IORESOURCE_UNSET)) == IORESOURCE_IO;
-            tmp++)
-               isapnp_write_word(ISAPNP_CFG_PORT + (tmp << 1),
-                                 res->port_resource[tmp].start);
-       for (tmp = 0;
-            tmp < ISAPNP_MAX_IRQ
-            && (res->irq_resource[tmp].
-                flags & (IORESOURCE_IRQ | IORESOURCE_UNSET)) == IORESOURCE_IRQ;
-            tmp++) {
-               int irq = res->irq_resource[tmp].start;
-               if (irq == 2)
-                       irq = 9;
-               isapnp_write_byte(ISAPNP_CFG_IRQ + (tmp << 1), irq);
+       for (tmp = 0; tmp < ISAPNP_MAX_PORT; tmp++) {
+               res = pnp_get_resource(dev, IORESOURCE_IO, tmp);
+               if (pnp_resource_enabled(res)) {
+                       dev_dbg(&dev->dev, "  set io  %d to %#llx\n",
+                               tmp, (unsigned long long) res->start);
+                       isapnp_write_word(ISAPNP_CFG_PORT + (tmp << 1),
+                                         res->start);
+               }
+       }
+       for (tmp = 0; tmp < ISAPNP_MAX_IRQ; tmp++) {
+               res = pnp_get_resource(dev, IORESOURCE_IRQ, tmp);
+               if (pnp_resource_enabled(res)) {
+                       int irq = res->start;
+                       if (irq == 2)
+                               irq = 9;
+                       dev_dbg(&dev->dev, "  set irq %d to %d\n", tmp, irq);
+                       isapnp_write_byte(ISAPNP_CFG_IRQ + (tmp << 1), irq);
+               }
+       }
+       for (tmp = 0; tmp < ISAPNP_MAX_DMA; tmp++) {
+               res = pnp_get_resource(dev, IORESOURCE_DMA, tmp);
+               if (pnp_resource_enabled(res)) {
+                       dev_dbg(&dev->dev, "  set dma %d to %lld\n",
+                               tmp, (unsigned long long) res->start);
+                       isapnp_write_byte(ISAPNP_CFG_DMA + tmp, res->start);
+               }
+       }
+       for (tmp = 0; tmp < ISAPNP_MAX_MEM; tmp++) {
+               res = pnp_get_resource(dev, IORESOURCE_MEM, tmp);
+               if (pnp_resource_enabled(res)) {
+                       dev_dbg(&dev->dev, "  set mem %d to %#llx\n",
+                               tmp, (unsigned long long) res->start);
+                       isapnp_write_word(ISAPNP_CFG_MEM + (tmp << 3),
+                                         (res->start >> 8) & 0xffff);
+               }
        }
-       for (tmp = 0;
-            tmp < ISAPNP_MAX_DMA
-            && (res->dma_resource[tmp].
-                flags & (IORESOURCE_DMA | IORESOURCE_UNSET)) == IORESOURCE_DMA;
-            tmp++)
-               isapnp_write_byte(ISAPNP_CFG_DMA + tmp,
-                                 res->dma_resource[tmp].start);
-       for (tmp = 0;
-            tmp < ISAPNP_MAX_MEM
-            && (res->mem_resource[tmp].
-                flags & (IORESOURCE_MEM | IORESOURCE_UNSET)) == IORESOURCE_MEM;
-            tmp++)
-               isapnp_write_word(ISAPNP_CFG_MEM + (tmp << 3),
-                                 (res->mem_resource[tmp].start >> 8) & 0xffff);
        /* FIXME: We aren't handling 32bit mems properly here */
        isapnp_activate(dev->number);
        isapnp_cfg_end();
@@ -1123,13 +1104,13 @@ static int __init isapnp_init(void)
        protocol_for_each_card(&isapnp_protocol, card) {
                cards++;
                if (isapnp_verbose) {
-                       printk(KERN_INFO "isapnp: Card '%s'\n",
-                              card->name[0] ? card->name : "Unknown");
+                       dev_info(&card->dev, "card '%s'\n",
+                              card->name[0] ? card->name : "unknown");
                        if (isapnp_verbose < 2)
                                continue;
                        card_for_each_dev(card, dev) {
-                               printk(KERN_INFO "isapnp:   Device '%s'\n",
-                                      dev->name[0] ? dev->name : "Unknown");
+                               dev_info(&card->dev, "device '%s'\n",
+                                      dev->name[0] ? dev->name : "unknown");
                        }
                }
        }