Merge branch 'master' into for-2.6.35
[safe/jmp/linux-2.6] / drivers / platform / x86 / asus-laptop.c
index bb8fb45..efe8f63 100644 (file)
 #include <linux/fb.h>
 #include <linux/leds.h>
 #include <linux/platform_device.h>
+#include <linux/uaccess.h>
+#include <linux/input.h>
+#include <linux/input/sparse-keymap.h>
+#include <linux/rfkill.h>
+#include <linux/slab.h>
 #include <acpi/acpi_drivers.h>
 #include <acpi/acpi_bus.h>
-#include <asm/uaccess.h>
-#include <linux/input.h>
 
 #define ASUS_LAPTOP_VERSION    "0.42"
 
@@ -76,15 +79,15 @@ static uint wapf = 1;
 module_param(wapf, uint, 0644);
 MODULE_PARM_DESC(wapf, "WAPF value");
 
-static uint wlan_status = 1;
-static uint bluetooth_status = 1;
+static int wlan_status = 1;
+static int bluetooth_status = 1;
 
-module_param(wlan_status, uint, 0644);
+module_param(wlan_status, int, 0644);
 MODULE_PARM_DESC(wlan_status, "Set the wireless status on boot "
                 "(0 = disabled, 1 = enabled, -1 = don't do anything). "
                 "default is 1");
 
-module_param(bluetooth_status, uint, 0644);
+module_param(bluetooth_status, int, 0644);
 MODULE_PARM_DESC(bluetooth_status, "Set the wireless status on boot "
                 "(0 = disabled, 1 = enabled, -1 = don't do anything). "
                 "default is 1");
@@ -92,8 +95,10 @@ MODULE_PARM_DESC(bluetooth_status, "Set the wireless status on boot "
 /*
  * Some events we use, same for all Asus
  */
-#define ATKD_BR_UP     0x10
-#define ATKD_BR_DOWN   0x20
+#define ATKD_BR_UP     0x10    /* (event & ~ATKD_BR_UP) = brightness level */
+#define ATKD_BR_DOWN   0x20    /* (event & ~ATKD_BR_DOWN) = britghness level */
+#define ATKD_BR_MIN    ATKD_BR_UP
+#define ATKD_BR_MAX    (ATKD_BR_DOWN | 0xF)    /* 0x2f */
 #define ATKD_LCD_ON    0x33
 #define ATKD_LCD_OFF   0x34
 
@@ -110,10 +115,6 @@ MODULE_PARM_DESC(bluetooth_status, "Set the wireless status on boot "
 #define WL_RSTS                0x01    /* internal Wifi */
 #define BT_RSTS                0x02    /* internal Bluetooth */
 
-#define ASUS_HANDLE(object, paths...)                                  \
-       static acpi_handle  object##_handle = NULL;                     \
-       static char *object##_paths[] = { paths }
-
 /* LED */
 #define METHOD_MLED            "MLED"
 #define METHOD_TLED            "TLED"
@@ -138,40 +139,44 @@ MODULE_PARM_DESC(bluetooth_status, "Set the wireless status on boot "
 #define METHOD_BRIGHTNESS_GET  "GPLV"
 
 /* Backlight */
-ASUS_HANDLE(lcd_switch, "\\_SB.PCI0.SBRG.EC0._Q10",    /* All new models */
-           "\\_SB.PCI0.ISA.EC0._Q10",  /* A1x */
-           "\\_SB.PCI0.PX40.ECD0._Q10",        /* L3C */
-           "\\_SB.PCI0.PX40.EC0.Q10",  /* M1A */
-           "\\_SB.PCI0.LPCB.EC0._Q10", /* P30 */
-           "\\_SB.PCI0.LPCB.EC0._Q0E", /* P30/P35 */
-           "\\_SB.PCI0.PX40.Q10",      /* S1x */
-           "\\Q10");           /* A2x, L2D, L3D, M2E */
+static acpi_handle lcd_switch_handle;
+static char *lcd_switch_paths[] = {
+  "\\_SB.PCI0.SBRG.EC0._Q10",  /* All new models */
+  "\\_SB.PCI0.ISA.EC0._Q10",   /* A1x */
+  "\\_SB.PCI0.PX40.ECD0._Q10", /* L3C */
+  "\\_SB.PCI0.PX40.EC0.Q10",   /* M1A */
+  "\\_SB.PCI0.LPCB.EC0._Q10",  /* P30 */
+  "\\_SB.PCI0.LPCB.EC0._Q0E", /* P30/P35 */
+  "\\_SB.PCI0.PX40.Q10",       /* S1x */
+  "\\Q10"};            /* A2x, L2D, L3D, M2E */
 
 /* Display */
 #define METHOD_SWITCH_DISPLAY  "SDSP"
-ASUS_HANDLE(display_get,
-           /* A6B, A6K A6R A7D F3JM L4R M6R A3G M6A M6V VX-1 V6J V6V W3Z */
-           "\\_SB.PCI0.P0P1.VGA.GETD",
-           /* A3E A4K, A4D A4L A6J A7J A8J Z71V M9V S5A M5A z33A W1Jc W2V G1 */
-           "\\_SB.PCI0.P0P2.VGA.GETD",
-           /* A6V A6Q */
-           "\\_SB.PCI0.P0P3.VGA.GETD",
-           /* A6T, A6M */
-           "\\_SB.PCI0.P0PA.VGA.GETD",
-           /* L3C */
-           "\\_SB.PCI0.PCI1.VGAC.NMAP",
-           /* Z96F */
-           "\\_SB.PCI0.VGA.GETD",
-           /* A2D */
-           "\\ACTD",
-           /* A4G Z71A W1N W5A W5F M2N M3N M5N M6N S1N S5N */
-           "\\ADVG",
-           /* P30 */
-           "\\DNXT",
-           /* A2H D1 L2D L3D L3H L2E L5D L5C M1A M2E L4L W3V */
-           "\\INFB",
-           /* A3F A6F A3N A3L M6N W3N W6A */
-           "\\SSTE");
+
+static acpi_handle display_get_handle;
+static char *display_get_paths[] = {
+  /* A6B, A6K A6R A7D F3JM L4R M6R A3G M6A M6V VX-1 V6J V6V W3Z */
+  "\\_SB.PCI0.P0P1.VGA.GETD",
+  /* A3E A4K, A4D A4L A6J A7J A8J Z71V M9V S5A M5A z33A W1Jc W2V G1 */
+  "\\_SB.PCI0.P0P2.VGA.GETD",
+  /* A6V A6Q */
+  "\\_SB.PCI0.P0P3.VGA.GETD",
+  /* A6T, A6M */
+  "\\_SB.PCI0.P0PA.VGA.GETD",
+  /* L3C */
+  "\\_SB.PCI0.PCI1.VGAC.NMAP",
+  /* Z96F */
+  "\\_SB.PCI0.VGA.GETD",
+  /* A2D */
+  "\\ACTD",
+  /* A4G Z71A W1N W5A W5F M2N M3N M5N M6N S1N S5N */
+  "\\ADVG",
+  /* P30 */
+  "\\DNXT",
+  /* A2H D1 L2D L3D L3H L2E L5D L5C M1A M2E L4L W3V */
+  "\\INFB",
+  /* A3F A6F A3N A3L M6N W3N W6A */
+  "\\SSTE"};
 
 #define METHOD_ALS_CONTROL     "ALSC" /* Z71A Z71V */
 #define METHOD_ALS_LEVEL       "ALSL" /* Z71A Z71V */
@@ -189,29 +194,12 @@ ASUS_HANDLE(display_get,
 /*
  * Define a specific led structure to keep the main structure clean
  */
-#define ASUS_DEFINE_LED(object)                                        \
-       int object##_wk;                                        \
-       struct work_struct object##_work;                       \
-       struct led_classdev object;
-
-
-#define led_to_asus(led_cdev, led)                                     \
-       container_of(container_of(led_cdev, struct asus_laptop_leds,    \
-                                 led),                                 \
-                    struct asus_laptop, leds)
-#define work_to_asus(work, led)                                                \
-       container_of(container_of(work, struct asus_laptop_leds,        \
-                                 led##_work),                          \
-                    struct asus_laptop, leds)
-
-struct asus_laptop_leds {
-       ASUS_DEFINE_LED(mled)
-       ASUS_DEFINE_LED(tled)
-       ASUS_DEFINE_LED(rled)
-       ASUS_DEFINE_LED(pled)
-       ASUS_DEFINE_LED(gled)
-       ASUS_DEFINE_LED(kled)
-       struct workqueue_struct *workqueue;
+struct asus_led {
+       int wk;
+       struct work_struct work;
+       struct led_classdev led;
+       struct asus_laptop *asus;
+       const char *method;
 };
 
 /*
@@ -229,12 +217,20 @@ struct asus_laptop {
        struct input_dev *inputdev;
        struct key_entry *keymap;
 
-       struct asus_laptop_leds leds;
+       struct asus_led mled;
+       struct asus_led tled;
+       struct asus_led rled;
+       struct asus_led pled;
+       struct asus_led gled;
+       struct asus_led kled;
+       struct workqueue_struct *led_workqueue;
 
        int wireless_status;
        bool have_rsts;
        int lcd_state;
 
+       struct rfkill *gps_rfkill;
+
        acpi_handle handle;     /* the handle of the hotk device */
        u32 ledd_status;        /* status of the LED display */
        u8 light_level;         /* light sensor level */
@@ -243,52 +239,49 @@ struct asus_laptop {
        u16 *keycode_map;
 };
 
-struct key_entry {
-       char type;
-       u8 code;
-       u16 keycode;
-};
-
-enum { KE_KEY, KE_END };
-
 static const struct key_entry asus_keymap[] = {
-       {KE_KEY, 0x02, KEY_SCREENLOCK},
-       {KE_KEY, 0x05, KEY_WLAN},
-       {KE_KEY, 0x08, KEY_F13},
-       {KE_KEY, 0x17, KEY_ZOOM},
-       {KE_KEY, 0x1f, KEY_BATTERY},
-       {KE_KEY, 0x30, KEY_VOLUMEUP},
-       {KE_KEY, 0x31, KEY_VOLUMEDOWN},
-       {KE_KEY, 0x32, KEY_MUTE},
-       {KE_KEY, 0x33, KEY_SWITCHVIDEOMODE},
-       {KE_KEY, 0x34, KEY_SWITCHVIDEOMODE},
-       {KE_KEY, 0x40, KEY_PREVIOUSSONG},
-       {KE_KEY, 0x41, KEY_NEXTSONG},
-       {KE_KEY, 0x43, KEY_STOPCD},
-       {KE_KEY, 0x45, KEY_PLAYPAUSE},
-       {KE_KEY, 0x4c, KEY_MEDIA},
-       {KE_KEY, 0x50, KEY_EMAIL},
-       {KE_KEY, 0x51, KEY_WWW},
-       {KE_KEY, 0x55, KEY_CALC},
-       {KE_KEY, 0x5C, KEY_SCREENLOCK},  /* Screenlock */
-       {KE_KEY, 0x5D, KEY_WLAN},
-       {KE_KEY, 0x5E, KEY_WLAN},
-       {KE_KEY, 0x5F, KEY_WLAN},
-       {KE_KEY, 0x60, KEY_SWITCHVIDEOMODE},
-       {KE_KEY, 0x61, KEY_SWITCHVIDEOMODE},
-       {KE_KEY, 0x62, KEY_SWITCHVIDEOMODE},
-       {KE_KEY, 0x63, KEY_SWITCHVIDEOMODE},
-       {KE_KEY, 0x6B, KEY_F13}, /* Lock Touchpad */
-       {KE_KEY, 0x82, KEY_CAMERA},
-       {KE_KEY, 0x88, KEY_WLAN },
-       {KE_KEY, 0x8A, KEY_PROG1},
-       {KE_KEY, 0x95, KEY_MEDIA},
-       {KE_KEY, 0x99, KEY_PHONE},
-       {KE_KEY, 0xc4, KEY_KBDILLUMUP},
-       {KE_KEY, 0xc5, KEY_KBDILLUMDOWN},
+       /* Lenovo SL Specific keycodes */
+       {KE_KEY, 0x02, { KEY_SCREENLOCK } },
+       {KE_KEY, 0x05, { KEY_WLAN } },
+       {KE_KEY, 0x08, { KEY_F13 } },
+       {KE_KEY, 0x17, { KEY_ZOOM } },
+       {KE_KEY, 0x1f, { KEY_BATTERY } },
+       /* End of Lenovo SL Specific keycodes */
+       {KE_KEY, 0x30, { KEY_VOLUMEUP } },
+       {KE_KEY, 0x31, { KEY_VOLUMEDOWN } },
+       {KE_KEY, 0x32, { KEY_MUTE } },
+       {KE_KEY, 0x33, { KEY_SWITCHVIDEOMODE } },
+       {KE_KEY, 0x34, { KEY_SWITCHVIDEOMODE } },
+       {KE_KEY, 0x40, { KEY_PREVIOUSSONG } },
+       {KE_KEY, 0x41, { KEY_NEXTSONG } },
+       {KE_KEY, 0x43, { KEY_STOPCD } },
+       {KE_KEY, 0x45, { KEY_PLAYPAUSE } },
+       {KE_KEY, 0x4c, { KEY_MEDIA } },
+       {KE_KEY, 0x50, { KEY_EMAIL } },
+       {KE_KEY, 0x51, { KEY_WWW } },
+       {KE_KEY, 0x55, { KEY_CALC } },
+       {KE_KEY, 0x5C, { KEY_SCREENLOCK } },  /* Screenlock */
+       {KE_KEY, 0x5D, { KEY_WLAN } },
+       {KE_KEY, 0x5E, { KEY_WLAN } },
+       {KE_KEY, 0x5F, { KEY_WLAN } },
+       {KE_KEY, 0x60, { KEY_SWITCHVIDEOMODE } },
+       {KE_KEY, 0x61, { KEY_SWITCHVIDEOMODE } },
+       {KE_KEY, 0x62, { KEY_SWITCHVIDEOMODE } },
+       {KE_KEY, 0x63, { KEY_SWITCHVIDEOMODE } },
+       {KE_KEY, 0x6B, { KEY_F13 } }, /* Lock Touchpad */
+       {KE_KEY, 0x7E, { KEY_BLUETOOTH } },
+       {KE_KEY, 0x7D, { KEY_BLUETOOTH } },
+       {KE_KEY, 0x82, { KEY_CAMERA } },
+       {KE_KEY, 0x88, { KEY_WLAN  } },
+       {KE_KEY, 0x8A, { KEY_PROG1 } },
+       {KE_KEY, 0x95, { KEY_MEDIA } },
+       {KE_KEY, 0x99, { KEY_PHONE } },
+       {KE_KEY, 0xc4, { KEY_KBDILLUMUP } },
+       {KE_KEY, 0xc5, { KEY_KBDILLUMDOWN } },
        {KE_END, 0},
 };
 
+
 /*
  * This function evaluates an ACPI method, given an int as parameter, the
  * method is searched within the scope of the handle, can be NULL. The output
@@ -350,7 +343,7 @@ static int acpi_check_handle(acpi_handle handle, const char *method,
 }
 
 /* Generic LED function */
-static int asus_led_set(struct asus_laptop *asus, char *method,
+static int asus_led_set(struct asus_laptop *asus, const char *method,
                         int value)
 {
        if (!strcmp(method, METHOD_MLED))
@@ -366,56 +359,29 @@ static int asus_led_set(struct asus_laptop *asus, char *method,
 /*
  * LEDs
  */
-#define ASUS_LED(object, ledname, max)                                 \
-       static void object##_led_set(struct led_classdev *led_cdev,     \
-                                    enum led_brightness value);        \
-       static enum led_brightness object##_led_get(                    \
-               struct led_classdev *led_cdev);                         \
-       static void object##_led_update(struct work_struct *ignored);   \
-       static struct led_classdev object##_led = {                     \
-               .name           = "asus::" ledname,                     \
-               .brightness_set = object##_led_set,                     \
-               .brightness_get = object##_led_get,                     \
-               .max_brightness = max                                   \
-       }
+/* /sys/class/led handlers */
+static void asus_led_cdev_set(struct led_classdev *led_cdev,
+                        enum led_brightness value)
+{
+       struct asus_led *led = container_of(led_cdev, struct asus_led, led);
+       struct asus_laptop *asus = led->asus;
 
-ASUS_LED(mled, "mail", 1);
-ASUS_LED(tled, "touchpad", 1);
-ASUS_LED(rled, "record", 1);
-ASUS_LED(pled, "phone", 1);
-ASUS_LED(gled, "gaming", 1);
-ASUS_LED(kled, "kbd_backlight", 3);
+       led->wk = !!value;
+       queue_work(asus->led_workqueue, &led->work);
+}
 
-/* /sys/class/led handlers */
-#define ASUS_LED_HANDLER(object, method)                               \
-       static void object##_led_set(struct led_classdev *led_cdev,     \
-                                    enum led_brightness value)         \
-       {                                                               \
-               struct asus_laptop *asus =                              \
-                       led_to_asus(led_cdev, object);                  \
-                                                                       \
-               asus->leds.object##_wk = (value > 0) ? 1 : 0;           \
-               queue_work(asus->leds.workqueue,                        \
-                          &asus->leds.object##_work);                  \
-       }                                                               \
-       static void object##_led_update(struct work_struct *work)       \
-       {                                                               \
-               struct asus_laptop *asus = work_to_asus(work, object);  \
-                                                                       \
-               int value = asus->leds.object##_wk;                     \
-               asus_led_set(asus, method, value);                      \
-       }                                                               \
-       static enum led_brightness object##_led_get(                    \
-               struct led_classdev *led_cdev)                          \
-       {                                                               \
-               return led_cdev->brightness;                            \
-       }
+static void asus_led_cdev_update(struct work_struct *work)
+{
+       struct asus_led *led = container_of(work, struct asus_led, work);
+       struct asus_laptop *asus = led->asus;
+
+       asus_led_set(asus, led->method, led->wk);
+}
 
-ASUS_LED_HANDLER(mled, METHOD_MLED);
-ASUS_LED_HANDLER(pled, METHOD_PLED);
-ASUS_LED_HANDLER(rled, METHOD_RLED);
-ASUS_LED_HANDLER(tled, METHOD_TLED);
-ASUS_LED_HANDLER(gled, METHOD_GLED);
+static enum led_brightness asus_led_cdev_get(struct led_classdev *led_cdev)
+{
+       return led_cdev->brightness;
+}
 
 /*
  * Keyboard backlight (also a LED)
@@ -455,67 +421,76 @@ static int asus_kled_set(struct asus_laptop *asus, int kblv)
        return 0;
 }
 
-static void kled_led_set(struct led_classdev *led_cdev,
-                        enum led_brightness value)
+static void asus_kled_cdev_set(struct led_classdev *led_cdev,
+                             enum led_brightness value)
 {
-       struct asus_laptop *asus = led_to_asus(led_cdev, kled);
+       struct asus_led *led = container_of(led_cdev, struct asus_led, led);
+       struct asus_laptop *asus = led->asus;
 
-       asus->leds.kled_wk = value;
-       queue_work(asus->leds.workqueue, &asus->leds.kled_work);
+       led->wk = value;
+       queue_work(asus->led_workqueue, &led->work);
 }
 
-static void kled_led_update(struct work_struct *work)
+static void asus_kled_cdev_update(struct work_struct *work)
 {
-       struct asus_laptop *asus = work_to_asus(work, kled);
+       struct asus_led *led = container_of(work, struct asus_led, work);
+       struct asus_laptop *asus = led->asus;
 
-       asus_kled_set(asus, asus->leds.kled_wk);
+       asus_kled_set(asus, led->wk);
 }
 
-static enum led_brightness kled_led_get(struct led_classdev *led_cdev)
+static enum led_brightness asus_kled_cdev_get(struct led_classdev *led_cdev)
 {
-       struct asus_laptop *asus = led_to_asus(led_cdev, kled);
+       struct asus_led *led = container_of(led_cdev, struct asus_led, led);
+       struct asus_laptop *asus = led->asus;
 
        return asus_kled_lvl(asus);
 }
 
-#define ASUS_LED_UNREGISTER(object)                            \
-       if (object##_led.dev)                                   \
-               led_classdev_unregister(&object##_led)
-
 static void asus_led_exit(struct asus_laptop *asus)
 {
-       ASUS_LED_UNREGISTER(mled);
-       ASUS_LED_UNREGISTER(tled);
-       ASUS_LED_UNREGISTER(pled);
-       ASUS_LED_UNREGISTER(rled);
-       ASUS_LED_UNREGISTER(gled);
-       ASUS_LED_UNREGISTER(kled);
-       if (asus->leds.workqueue) {
-               destroy_workqueue(asus->leds.workqueue);
-               asus->leds.workqueue = NULL;
+       if (asus->mled.led.dev)
+               led_classdev_unregister(&asus->mled.led);
+       if (asus->tled.led.dev)
+               led_classdev_unregister(&asus->tled.led);
+       if (asus->pled.led.dev)
+               led_classdev_unregister(&asus->pled.led);
+       if (asus->rled.led.dev)
+               led_classdev_unregister(&asus->rled.led);
+       if (asus->gled.led.dev)
+               led_classdev_unregister(&asus->gled.led);
+       if (asus->kled.led.dev)
+               led_classdev_unregister(&asus->kled.led);
+       if (asus->led_workqueue) {
+               destroy_workqueue(asus->led_workqueue);
+               asus->led_workqueue = NULL;
        }
 }
 
 /*  Ugly macro, need to fix that later */
-#define ASUS_LED_REGISTER(asus, object, _name, max, method)            \
-       do {                                                            \
-               struct led_classdev *ldev = &asus->leds.object;         \
-                                                                       \
-               if (method && acpi_check_handle(asus->handle, method, NULL)) \
-                       break ;                                         \
-                                                                       \
-               INIT_WORK(&asus->leds.object##_work, object##_led_update); \
-               ldev->name = "asus::" _name;                            \
-               ldev->brightness_set = object##_led_set;                \
-               ldev->max_brightness = max;                             \
-               rv = led_classdev_register(&asus->platform_device->dev, ldev); \
-               if (rv)                                                 \
-                       goto error;                                     \
-       } while (0)
+static int asus_led_register(struct asus_laptop *asus,
+                            struct asus_led *led,
+                            const char *name, const char *method)
+{
+       struct led_classdev *led_cdev = &led->led;
+
+       if (!method || acpi_check_handle(asus->handle, method, NULL))
+               return 0; /* Led not present */
+
+       led->asus = asus;
+       led->method = method;
+
+       INIT_WORK(&led->work, asus_led_cdev_update);
+       led_cdev->name = name;
+       led_cdev->brightness_set = asus_led_cdev_set;
+       led_cdev->brightness_get = asus_led_cdev_get;
+       led_cdev->max_brightness = 1;
+       return led_classdev_register(&asus->platform_device->dev, led_cdev);
+}
 
 static int asus_led_init(struct asus_laptop *asus)
 {
-       int rv;
+       int r;
 
        /*
         * Functions that actually update the LED's are called from a
@@ -523,22 +498,43 @@ static int asus_led_init(struct asus_laptop *asus)
         * subsystem asks, we avoid messing with the Asus ACPI stuff during a
         * potentially bad time, such as a timer interrupt.
         */
-       asus->leds.workqueue = create_singlethread_workqueue("led_workqueue");
-       if (!asus->leds.workqueue)
+       asus->led_workqueue = create_singlethread_workqueue("led_workqueue");
+       if (!asus->led_workqueue)
                return -ENOMEM;
 
-       ASUS_LED_REGISTER(asus, mled, "mail", 1, METHOD_MLED);
-       ASUS_LED_REGISTER(asus, tled, "touchpad", 1, METHOD_TLED);
-       ASUS_LED_REGISTER(asus, rled, "record", 1, METHOD_RLED);
-       ASUS_LED_REGISTER(asus, pled, "phone", 1, METHOD_PLED);
-       ASUS_LED_REGISTER(asus, gled, "gaming", 1, METHOD_GLED);
+       r = asus_led_register(asus, &asus->mled, "asus::mail", METHOD_MLED);
+       if (r)
+               goto error;
+       r = asus_led_register(asus, &asus->tled, "asus::touchpad", METHOD_TLED);
+       if (r)
+               goto error;
+       r = asus_led_register(asus, &asus->rled, "asus::record", METHOD_RLED);
+       if (r)
+               goto error;
+       r = asus_led_register(asus, &asus->pled, "asus::phone", METHOD_PLED);
+       if (r)
+               goto error;
+       r = asus_led_register(asus, &asus->gled, "asus::gaming", METHOD_GLED);
+       if (r)
+               goto error;
        if (!acpi_check_handle(asus->handle, METHOD_KBD_LIGHT_SET, NULL) &&
-           !acpi_check_handle(asus->handle, METHOD_KBD_LIGHT_GET, NULL))
-               ASUS_LED_REGISTER(asus, kled, "kbd_backlight", 3, NULL);
+           !acpi_check_handle(asus->handle, METHOD_KBD_LIGHT_GET, NULL)) {
+               struct asus_led *led = &asus->kled;
+               struct led_classdev *cdev = &led->led;
+
+               led->asus = asus;
+
+               INIT_WORK(&led->work, asus_kled_cdev_update);
+               cdev->name = "asus::kbd_backlight";
+               cdev->brightness_set = asus_kled_cdev_set;
+               cdev->brightness_get = asus_kled_cdev_get;
+               cdev->max_brightness = 3;
+               r = led_classdev_register(&asus->platform_device->dev, cdev);
+       }
 error:
-       if (rv)
+       if (r)
                asus_led_exit(asus);
-       return rv;
+       return r;
 }
 
 /*
@@ -630,16 +626,30 @@ static struct backlight_ops asusbl_ops = {
        .update_status = update_bl_status,
 };
 
+static int asus_backlight_notify(struct asus_laptop *asus)
+{
+       struct backlight_device *bd = asus->backlight_device;
+       int old = bd->props.brightness;
+
+       backlight_force_update(bd, BACKLIGHT_UPDATE_HOTKEY);
+
+       return old;
+}
+
 static int asus_backlight_init(struct asus_laptop *asus)
 {
        struct backlight_device *bd;
        struct device *dev = &asus->platform_device->dev;
+       struct backlight_properties props;
 
        if (!acpi_check_handle(asus->handle, METHOD_BRIGHTNESS_GET, NULL) &&
            !acpi_check_handle(asus->handle, METHOD_BRIGHTNESS_SET, NULL) &&
            lcd_switch_handle) {
+               memset(&props, 0, sizeof(struct backlight_properties));
+               props.max_brightness = 15;
+
                bd = backlight_device_register(ASUS_LAPTOP_FILE, dev,
-                                              asus, &asusbl_ops);
+                                              asus, &asusbl_ops, &props);
                if (IS_ERR(bd)) {
                        pr_err("Could not register asus backlight device\n");
                        asus->backlight_device = NULL;
@@ -648,7 +658,6 @@ static int asus_backlight_init(struct asus_laptop *asus)
 
                asus->backlight_device = bd;
 
-               bd->props.max_brightness = 15;
                bd->props.power = FB_BLANK_UNBLANK;
                bd->props.brightness = asus_read_brightness(bd);
                backlight_update_status(bd);
@@ -660,6 +669,7 @@ static void asus_backlight_exit(struct asus_laptop *asus)
 {
        if (asus->backlight_device)
                backlight_device_unregister(asus->backlight_device);
+       asus->backlight_device = NULL;
 }
 
 /*
@@ -681,8 +691,8 @@ static ssize_t show_infos(struct device *dev,
        acpi_status rv = AE_OK;
 
        /*
-        * We use the easy way, we don't care of off and count, so we don't set eof
-        * to 1
+        * We use the easy way, we don't care of off and count,
+        * so we don't set eof to 1
         */
 
        len += sprintf(page, ASUS_LAPTOP_NAME " " ASUS_LAPTOP_VERSION "\n");
@@ -898,7 +908,7 @@ static int read_display(struct asus_laptop *asus)
                        pr_warning("Error reading display status\n");
        }
 
-       value &= 0x0F;          /* needed for some models, shouldn't hurt others */
+       value &= 0x0F; /* needed for some models, shouldn't hurt others */
 
        return value;
 }
@@ -912,6 +922,8 @@ static ssize_t show_disp(struct device *dev,
 {
        struct asus_laptop *asus = dev_get_drvdata(dev);
 
+       if (!display_get_handle)
+               return -ENODEV;
        return sprintf(buf, "%d\n", read_display(asus));
 }
 
@@ -998,7 +1010,6 @@ static ssize_t store_lslvl(struct device *dev, struct device_attribute *attr,
 
 /*
  * GPS
- * TODO: use rfkill
  */
 static int asus_gps_status(struct asus_laptop *asus)
 {
@@ -1034,7 +1045,7 @@ static ssize_t show_gps(struct device *dev,
 static ssize_t store_gps(struct device *dev, struct device_attribute *attr,
                         const char *buf, size_t count)
 {
-       struct asus_laptop *asus = dev_get_drvdata(dev);
+       struct asus_laptop *asus = dev_get_drvdata(dev);
        int rv, value;
        int ret;
 
@@ -1044,129 +1055,109 @@ static ssize_t store_gps(struct device *dev, struct device_attribute *attr,
        ret = asus_gps_switch(asus, !!value);
        if (ret)
                return ret;
+       rfkill_set_sw_state(asus->gps_rfkill, !value);
        return rv;
 }
 
 /*
- * Input device (i.e. hotkeys)
+ * rfkill
  */
-static struct key_entry *asus_get_entry_by_scancode(struct asus_laptop *asus,
-                                                   int code)
+static int asus_gps_rfkill_set(void *data, bool blocked)
 {
-       struct key_entry *key;
+       acpi_handle handle = data;
 
-       for (key = asus->keymap; key->type != KE_END; key++)
-               if (code == key->code)
-                       return key;
-
-       return NULL;
+       return asus_gps_switch(handle, !blocked);
 }
 
-static struct key_entry *asus_get_entry_by_keycode(struct asus_laptop *asus,
-                                                  int code)
-{
-       struct key_entry *key;
-
-       for (key = asus->keymap; key->type != KE_END; key++)
-               if (code == key->keycode && key->type == KE_KEY)
-                       return key;
-
-       return NULL;
-}
+static const struct rfkill_ops asus_gps_rfkill_ops = {
+       .set_block = asus_gps_rfkill_set,
+};
 
-static int asus_getkeycode(struct input_dev *dev, int scancode, int *keycode)
+static void asus_rfkill_exit(struct asus_laptop *asus)
 {
-       struct asus_laptop *asus = input_get_drvdata(dev);
-       struct key_entry *key = asus_get_entry_by_scancode(asus, scancode);
-
-       if (key && key->type == KE_KEY) {
-               *keycode = key->keycode;
-               return 0;
+       if (asus->gps_rfkill) {
+               rfkill_unregister(asus->gps_rfkill);
+               rfkill_destroy(asus->gps_rfkill);
+               asus->gps_rfkill = NULL;
        }
-
-       return -EINVAL;
 }
 
-static int asus_setkeycode(struct input_dev *dev, int scancode, int keycode)
+static int asus_rfkill_init(struct asus_laptop *asus)
 {
-       struct asus_laptop *asus = input_get_drvdata(dev);
-       struct key_entry *key;
-       int old_keycode;
+       int result;
 
-       if (keycode < 0 || keycode > KEY_MAX)
+       if (acpi_check_handle(asus->handle, METHOD_GPS_ON, NULL) ||
+           acpi_check_handle(asus->handle, METHOD_GPS_OFF, NULL) ||
+           acpi_check_handle(asus->handle, METHOD_GPS_STATUS, NULL))
+               return 0;
+
+       asus->gps_rfkill = rfkill_alloc("asus-gps", &asus->platform_device->dev,
+                                       RFKILL_TYPE_GPS,
+                                       &asus_gps_rfkill_ops, NULL);
+       if (!asus->gps_rfkill)
                return -EINVAL;
 
-       key = asus_get_entry_by_scancode(asus, scancode);
-       if (key && key->type == KE_KEY) {
-               old_keycode = key->keycode;
-               key->keycode = keycode;
-               set_bit(keycode, dev->keybit);
-               if (!asus_get_entry_by_keycode(asus, old_keycode))
-                       clear_bit(old_keycode, dev->keybit);
-               return 0;
+       result = rfkill_register(asus->gps_rfkill);
+       if (result) {
+               rfkill_destroy(asus->gps_rfkill);
+               asus->gps_rfkill = NULL;
        }
 
-       return -EINVAL;
+       return result;
 }
 
+/*
+ * Input device (i.e. hotkeys)
+ */
 static void asus_input_notify(struct asus_laptop *asus, int event)
 {
-       struct key_entry *key;
-
-       key = asus_get_entry_by_scancode(asus, event);
-       if (!key)
-               return ;
-
-       switch (key->type) {
-       case KE_KEY:
-               input_report_key(asus->inputdev, key->keycode, 1);
-               input_sync(asus->inputdev);
-               input_report_key(asus->inputdev, key->keycode, 0);
-               input_sync(asus->inputdev);
-               break;
-       }
+       if (asus->inputdev)
+               sparse_keymap_report_event(asus->inputdev, event, 1, true);
 }
 
 static int asus_input_init(struct asus_laptop *asus)
 {
-       const struct key_entry *key;
-       int result;
+       struct input_dev *input;
+       int error;
 
-       asus->inputdev = input_allocate_device();
-       if (!asus->inputdev) {
+       input = input_allocate_device();
+       if (!input) {
                pr_info("Unable to allocate input device\n");
                return 0;
        }
-       asus->inputdev->name = "Asus Laptop extra buttons";
-       asus->inputdev->dev.parent = &asus->platform_device->dev;
-       asus->inputdev->phys = ASUS_LAPTOP_FILE "/input0";
-       asus->inputdev->id.bustype = BUS_HOST;
-       asus->inputdev->getkeycode = asus_getkeycode;
-       asus->inputdev->setkeycode = asus_setkeycode;
-       input_set_drvdata(asus->inputdev, asus);
-
-       asus->keymap = kmemdup(asus_keymap, sizeof(asus_keymap),
-                               GFP_KERNEL);
-       for (key = asus->keymap; key->type != KE_END; key++) {
-               switch (key->type) {
-               case KE_KEY:
-                       set_bit(EV_KEY, asus->inputdev->evbit);
-                       set_bit(key->keycode, asus->inputdev->keybit);
-                       break;
-               }
+       input->name = "Asus Laptop extra buttons";
+       input->phys = ASUS_LAPTOP_FILE "/input0";
+       input->id.bustype = BUS_HOST;
+       input->dev.parent = &asus->platform_device->dev;
+       input_set_drvdata(input, asus);
+
+       error = sparse_keymap_setup(input, asus_keymap, NULL);
+       if (error) {
+               pr_err("Unable to setup input device keymap\n");
+               goto err_keymap;
        }
-       result = input_register_device(asus->inputdev);
-       if (result) {
+       error = input_register_device(input);
+       if (error) {
                pr_info("Unable to register input device\n");
-               input_free_device(asus->inputdev);
+               goto err_device;
        }
-       return result;
+
+       asus->inputdev = input;
+       return 0;
+
+err_keymap:
+       sparse_keymap_free(input);
+err_device:
+       input_free_device(input);
+       return error;
 }
 
 static void asus_input_exit(struct asus_laptop *asus)
 {
-       if (asus->inputdev)
+       if (asus->inputdev) {
+               sparse_keymap_free(asus->inputdev);
                input_unregister_device(asus->inputdev);
+       }
 }
 
 /*
@@ -1193,80 +1184,126 @@ static void asus_acpi_notify(struct acpi_device *device, u32 event)
                                        dev_name(&asus->device->dev), event,
                                        count);
 
+       /* Brightness events are special */
+       if (event >= ATKD_BR_MIN && event <= ATKD_BR_MAX) {
+
+               /* Ignore them completely if the acpi video driver is used */
+               if (asus->backlight_device != NULL) {
+                       /* Update the backlight device. */
+                       asus_backlight_notify(asus);
+               }
+               return ;
+       }
        asus_input_notify(asus, event);
 }
 
-#define ASUS_CREATE_DEVICE_ATTR(_name)                                 \
-       struct device_attribute dev_attr_##_name = {                    \
-               .attr = {                                               \
-                       .name = __stringify(_name),                     \
-                       .mode = 0 },                                    \
-               .show   = NULL,                                         \
-               .store  = NULL,                                         \
+static DEVICE_ATTR(infos, S_IRUGO, show_infos, NULL);
+static DEVICE_ATTR(wlan, S_IRUGO | S_IWUSR, show_wlan, store_wlan);
+static DEVICE_ATTR(bluetooth, S_IRUGO | S_IWUSR, show_bluetooth,
+                  store_bluetooth);
+static DEVICE_ATTR(display, S_IRUGO | S_IWUSR, show_disp, store_disp);
+static DEVICE_ATTR(ledd, S_IRUGO | S_IWUSR, show_ledd, store_ledd);
+static DEVICE_ATTR(ls_level, S_IRUGO | S_IWUSR, show_lslvl, store_lslvl);
+static DEVICE_ATTR(ls_switch, S_IRUGO | S_IWUSR, show_lssw, store_lssw);
+static DEVICE_ATTR(gps, S_IRUGO | S_IWUSR, show_gps, store_gps);
+
+static void asus_sysfs_exit(struct asus_laptop *asus)
+{
+       struct platform_device *device = asus->platform_device;
+
+       device_remove_file(&device->dev, &dev_attr_infos);
+       device_remove_file(&device->dev, &dev_attr_wlan);
+       device_remove_file(&device->dev, &dev_attr_bluetooth);
+       device_remove_file(&device->dev, &dev_attr_display);
+       device_remove_file(&device->dev, &dev_attr_ledd);
+       device_remove_file(&device->dev, &dev_attr_ls_switch);
+       device_remove_file(&device->dev, &dev_attr_ls_level);
+       device_remove_file(&device->dev, &dev_attr_gps);
+}
+
+static int asus_sysfs_init(struct asus_laptop *asus)
+{
+       struct platform_device *device = asus->platform_device;
+       int err;
+
+       err = device_create_file(&device->dev, &dev_attr_infos);
+       if (err)
+               return err;
+
+       if (!acpi_check_handle(asus->handle, METHOD_WLAN, NULL)) {
+               err = device_create_file(&device->dev, &dev_attr_wlan);
+               if (err)
+                       return err;
        }
 
-#define ASUS_SET_DEVICE_ATTR(_name, _mode, _show, _store)              \
-       do {                                                            \
-               dev_attr_##_name.attr.mode = _mode;                     \
-               dev_attr_##_name.show = _show;                          \
-               dev_attr_##_name.store = _store;                        \
-       } while(0)
-
-static ASUS_CREATE_DEVICE_ATTR(infos);
-static ASUS_CREATE_DEVICE_ATTR(wlan);
-static ASUS_CREATE_DEVICE_ATTR(bluetooth);
-static ASUS_CREATE_DEVICE_ATTR(display);
-static ASUS_CREATE_DEVICE_ATTR(ledd);
-static ASUS_CREATE_DEVICE_ATTR(ls_switch);
-static ASUS_CREATE_DEVICE_ATTR(ls_level);
-static ASUS_CREATE_DEVICE_ATTR(gps);
-
-static struct attribute *asuspf_attributes[] = {
-       &dev_attr_infos.attr,
-       &dev_attr_wlan.attr,
-       &dev_attr_bluetooth.attr,
-       &dev_attr_display.attr,
-       &dev_attr_ledd.attr,
-       &dev_attr_ls_switch.attr,
-       &dev_attr_ls_level.attr,
-       &dev_attr_gps.attr,
-       NULL
-};
+       if (!acpi_check_handle(asus->handle, METHOD_BLUETOOTH, NULL)) {
+               err = device_create_file(&device->dev, &dev_attr_bluetooth);
+               if (err)
+                       return err;
+       }
 
-static struct attribute_group platform_attribute_group = {
-       .attrs = asuspf_attributes
-};
+       if (!acpi_check_handle(asus->handle, METHOD_SWITCH_DISPLAY, NULL)) {
+               err = device_create_file(&device->dev, &dev_attr_display);
+               if (err)
+                       return err;
+       }
+
+       if (!acpi_check_handle(asus->handle, METHOD_LEDD, NULL)) {
+               err = device_create_file(&device->dev, &dev_attr_ledd);
+               if (err)
+                       return err;
+       }
+
+       if (!acpi_check_handle(asus->handle, METHOD_ALS_CONTROL, NULL) &&
+           !acpi_check_handle(asus->handle, METHOD_ALS_LEVEL, NULL)) {
+               err = device_create_file(&device->dev, &dev_attr_ls_switch);
+               if (err)
+                       return err;
+               err = device_create_file(&device->dev, &dev_attr_ls_level);
+               if (err)
+                       return err;
+       }
+
+       if (!acpi_check_handle(asus->handle, METHOD_GPS_ON, NULL) &&
+           !acpi_check_handle(asus->handle, METHOD_GPS_OFF, NULL) &&
+           !acpi_check_handle(asus->handle, METHOD_GPS_STATUS, NULL)) {
+               err = device_create_file(&device->dev, &dev_attr_gps);
+               if (err)
+                       return err;
+       }
+
+       return err;
+}
 
 static int asus_platform_init(struct asus_laptop *asus)
 {
-       int result;
+       int err;
 
        asus->platform_device = platform_device_alloc(ASUS_LAPTOP_FILE, -1);
        if (!asus->platform_device)
                return -ENOMEM;
        platform_set_drvdata(asus->platform_device, asus);
 
-       result = platform_device_add(asus->platform_device);
-       if (result)
+       err = platform_device_add(asus->platform_device);
+       if (err)
                goto fail_platform_device;
 
-       result = sysfs_create_group(&asus->platform_device->dev.kobj,
-                                   &platform_attribute_group);
-       if (result)
+       err = asus_sysfs_init(asus);
+       if (err)
                goto fail_sysfs;
        return 0;
 
 fail_sysfs:
+       asus_sysfs_exit(asus);
        platform_device_del(asus->platform_device);
 fail_platform_device:
        platform_device_put(asus->platform_device);
-       return result;
+       return err;
 }
 
 static void asus_platform_exit(struct asus_laptop *asus)
 {
-       sysfs_remove_group(&asus->platform_device->dev.kobj,
-                          &platform_attribute_group);
+       asus_sysfs_exit(asus);
        platform_device_unregister(asus->platform_device);
 }
 
@@ -1277,40 +1314,6 @@ static struct platform_driver platform_driver = {
        }
 };
 
-static void asus_laptop_add_fs(struct asus_laptop *asus)
-{
-       ASUS_SET_DEVICE_ATTR(infos, 0444, show_infos, NULL);
-
-       if (!acpi_check_handle(asus->handle, METHOD_WLAN, NULL))
-               ASUS_SET_DEVICE_ATTR(wlan, 0644, show_wlan, store_wlan);
-
-       if (!acpi_check_handle(asus->handle, METHOD_BLUETOOTH, NULL))
-               ASUS_SET_DEVICE_ATTR(bluetooth, 0644,
-                                    show_bluetooth, store_bluetooth);
-
-       if (!acpi_check_handle(asus->handle, METHOD_SWITCH_DISPLAY, NULL)) {
-               if (display_get_handle)
-                       ASUS_SET_DEVICE_ATTR(display, 0644, show_disp,
-                                            store_disp);
-               else
-                       ASUS_SET_DEVICE_ATTR(display, 0200, NULL, store_disp);
-       }
-
-       if (!acpi_check_handle(asus->handle, METHOD_LEDD, NULL))
-               ASUS_SET_DEVICE_ATTR(ledd, 0644, show_ledd, store_ledd);
-
-       if (!acpi_check_handle(asus->handle, METHOD_ALS_CONTROL, NULL) &&
-           !acpi_check_handle(asus->handle, METHOD_ALS_LEVEL, NULL)) {
-               ASUS_SET_DEVICE_ATTR(ls_level, 0644, show_lslvl, store_lslvl);
-               ASUS_SET_DEVICE_ATTR(ls_switch, 0644, show_lssw, store_lssw);
-       }
-
-       if (!acpi_check_handle(asus->handle, METHOD_GPS_ON, NULL) &&
-           !acpi_check_handle(asus->handle, METHOD_GPS_OFF, NULL) &&
-           !acpi_check_handle(asus->handle, METHOD_GPS_STATUS, NULL))
-               ASUS_SET_DEVICE_ATTR(gps, 0644, show_gps, store_gps);
-}
-
 static int asus_handle_init(char *name, acpi_handle * handle,
                            char **paths, int num_paths)
 {
@@ -1440,8 +1443,6 @@ static int __devinit asus_acpi_init(struct asus_laptop *asus)
        if (result)
                return result;
 
-       asus_laptop_add_fs(asus);
-
        /* WLED and BLED are on by default */
        if (bluetooth_status >= 0)
                asus_bluetooth_set(asus, !!bluetooth_status);
@@ -1466,11 +1467,7 @@ static int __devinit asus_acpi_init(struct asus_laptop *asus)
                asus_als_level(asus, asus->light_level);
        }
 
-       /* GPS is on by default */
-       if (!acpi_check_handle(asus->handle, METHOD_GPS_ON, NULL) &&
-           !acpi_check_handle(asus->handle, METHOD_GPS_OFF, NULL) &&
-           !acpi_check_handle(asus->handle, METHOD_GPS_STATUS, NULL))
-               asus_gps_switch(asus, 1);
+       asus->lcd_state = 1; /* LCD should be on when the module load */
        return result;
 }
 
@@ -1517,9 +1514,15 @@ static int __devinit asus_acpi_add(struct acpi_device *device)
        if (result)
                goto fail_led;
 
+       result = asus_rfkill_init(asus);
+       if (result)
+               goto fail_rfkill;
+
        asus_device_present = true;
        return 0;
 
+fail_rfkill:
+       asus_led_exit(asus);
 fail_led:
        asus_input_exit(asus);
 fail_input:
@@ -1538,6 +1541,7 @@ static int asus_acpi_remove(struct acpi_device *device, int type)
        struct asus_laptop *asus = acpi_driver_data(device);
 
        asus_backlight_exit(asus);
+       asus_rfkill_exit(asus);
        asus_led_exit(asus);
        asus_input_exit(asus);
        asus_platform_exit(asus);