Merge branch 'master' into for-2.6.35
[safe/jmp/linux-2.6] / drivers / platform / x86 / asus-laptop.c
index 2349e88..efe8f63 100644 (file)
 #include <linux/fb.h>
 #include <linux/leds.h>
 #include <linux/platform_device.h>
+#include <linux/uaccess.h>
+#include <linux/input.h>
+#include <linux/input/sparse-keymap.h>
+#include <linux/rfkill.h>
+#include <linux/slab.h>
 #include <acpi/acpi_drivers.h>
 #include <acpi/acpi_bus.h>
-#include <asm/uaccess.h>
-#include <linux/input.h>
 
 #define ASUS_LAPTOP_VERSION    "0.42"
 
@@ -76,15 +79,15 @@ static uint wapf = 1;
 module_param(wapf, uint, 0644);
 MODULE_PARM_DESC(wapf, "WAPF value");
 
-static uint wireless_status = 1;
-static uint bluetooth_status = 1;
+static int wlan_status = 1;
+static int bluetooth_status = 1;
 
-module_param(wireless_status, uint, 0644);
-MODULE_PARM_DESC(wireless_status, "Set the wireless status on boot "
+module_param(wlan_status, int, 0644);
+MODULE_PARM_DESC(wlan_status, "Set the wireless status on boot "
                 "(0 = disabled, 1 = enabled, -1 = don't do anything). "
                 "default is 1");
 
-module_param(bluetooth_status, uint, 0644);
+module_param(bluetooth_status, int, 0644);
 MODULE_PARM_DESC(bluetooth_status, "Set the wireless status on boot "
                 "(0 = disabled, 1 = enabled, -1 = don't do anything). "
                 "default is 1");
@@ -92,8 +95,10 @@ MODULE_PARM_DESC(bluetooth_status, "Set the wireless status on boot "
 /*
  * Some events we use, same for all Asus
  */
-#define ATKD_BR_UP     0x10
-#define ATKD_BR_DOWN   0x20
+#define ATKD_BR_UP     0x10    /* (event & ~ATKD_BR_UP) = brightness level */
+#define ATKD_BR_DOWN   0x20    /* (event & ~ATKD_BR_DOWN) = britghness level */
+#define ATKD_BR_MIN    ATKD_BR_UP
+#define ATKD_BR_MAX    (ATKD_BR_DOWN | 0xF)    /* 0x2f */
 #define ATKD_LCD_ON    0x33
 #define ATKD_LCD_OFF   0x34
 
@@ -110,108 +115,91 @@ MODULE_PARM_DESC(bluetooth_status, "Set the wireless status on boot "
 #define WL_RSTS                0x01    /* internal Wifi */
 #define BT_RSTS                0x02    /* internal Bluetooth */
 
-#define ASUS_HANDLE(object, paths...)                                  \
-       static acpi_handle  object##_handle = NULL;                     \
-       static char *object##_paths[] = { paths }
-
 /* LED */
-ASUS_HANDLE(mled_set, ASUS_LAPTOP_PREFIX "MLED");
-ASUS_HANDLE(tled_set, ASUS_LAPTOP_PREFIX "TLED");
-ASUS_HANDLE(rled_set, ASUS_LAPTOP_PREFIX "RLED");      /* W1JC */
-ASUS_HANDLE(pled_set, ASUS_LAPTOP_PREFIX "PLED");      /* A7J */
-ASUS_HANDLE(gled_set, ASUS_LAPTOP_PREFIX "GLED");      /* G1, G2 (probably) */
+#define METHOD_MLED            "MLED"
+#define METHOD_TLED            "TLED"
+#define METHOD_RLED            "RLED"  /* W1JC */
+#define METHOD_PLED            "PLED"  /* A7J */
+#define METHOD_GLED            "GLED"  /* G1, G2 (probably) */
 
 /* LEDD */
-ASUS_HANDLE(ledd_set, ASUS_LAPTOP_PREFIX "SLCM");
+#define METHOD_LEDD            "SLCM"
 
 /*
  * Bluetooth and WLAN
  * WLED and BLED are not handled like other XLED, because in some dsdt
  * they also control the WLAN/Bluetooth device.
  */
-ASUS_HANDLE(wl_switch, ASUS_LAPTOP_PREFIX "WLED");
-ASUS_HANDLE(bt_switch, ASUS_LAPTOP_PREFIX "BLED");
-ASUS_HANDLE(wireless_status, ASUS_LAPTOP_PREFIX "RSTS");       /* All new models */
+#define METHOD_WLAN            "WLED"
+#define METHOD_BLUETOOTH       "BLED"
+#define METHOD_WL_STATUS       "RSTS"
 
 /* Brightness */
-ASUS_HANDLE(brightness_set, ASUS_LAPTOP_PREFIX "SPLV");
-ASUS_HANDLE(brightness_get, ASUS_LAPTOP_PREFIX "GPLV");
+#define METHOD_BRIGHTNESS_SET  "SPLV"
+#define METHOD_BRIGHTNESS_GET  "GPLV"
 
 /* Backlight */
-ASUS_HANDLE(lcd_switch, "\\_SB.PCI0.SBRG.EC0._Q10",    /* All new models */
-           "\\_SB.PCI0.ISA.EC0._Q10",  /* A1x */
-           "\\_SB.PCI0.PX40.ECD0._Q10",        /* L3C */
-           "\\_SB.PCI0.PX40.EC0.Q10",  /* M1A */
-           "\\_SB.PCI0.LPCB.EC0._Q10", /* P30 */
-           "\\_SB.PCI0.LPCB.EC0._Q0E", /* P30/P35 */
-           "\\_SB.PCI0.PX40.Q10",      /* S1x */
-           "\\Q10");           /* A2x, L2D, L3D, M2E */
+static acpi_handle lcd_switch_handle;
+static char *lcd_switch_paths[] = {
+  "\\_SB.PCI0.SBRG.EC0._Q10",  /* All new models */
+  "\\_SB.PCI0.ISA.EC0._Q10",   /* A1x */
+  "\\_SB.PCI0.PX40.ECD0._Q10", /* L3C */
+  "\\_SB.PCI0.PX40.EC0.Q10",   /* M1A */
+  "\\_SB.PCI0.LPCB.EC0._Q10",  /* P30 */
+  "\\_SB.PCI0.LPCB.EC0._Q0E", /* P30/P35 */
+  "\\_SB.PCI0.PX40.Q10",       /* S1x */
+  "\\Q10"};            /* A2x, L2D, L3D, M2E */
 
 /* Display */
-ASUS_HANDLE(display_set, ASUS_LAPTOP_PREFIX "SDSP");
-ASUS_HANDLE(display_get,
-           /* A6B, A6K A6R A7D F3JM L4R M6R A3G M6A M6V VX-1 V6J V6V W3Z */
-           "\\_SB.PCI0.P0P1.VGA.GETD",
-           /* A3E A4K, A4D A4L A6J A7J A8J Z71V M9V S5A M5A z33A W1Jc W2V G1 */
-           "\\_SB.PCI0.P0P2.VGA.GETD",
-           /* A6V A6Q */
-           "\\_SB.PCI0.P0P3.VGA.GETD",
-           /* A6T, A6M */
-           "\\_SB.PCI0.P0PA.VGA.GETD",
-           /* L3C */
-           "\\_SB.PCI0.PCI1.VGAC.NMAP",
-           /* Z96F */
-           "\\_SB.PCI0.VGA.GETD",
-           /* A2D */
-           "\\ACTD",
-           /* A4G Z71A W1N W5A W5F M2N M3N M5N M6N S1N S5N */
-           "\\ADVG",
-           /* P30 */
-           "\\DNXT",
-           /* A2H D1 L2D L3D L3H L2E L5D L5C M1A M2E L4L W3V */
-           "\\INFB",
-           /* A3F A6F A3N A3L M6N W3N W6A */
-           "\\SSTE");
-
-ASUS_HANDLE(ls_switch, ASUS_LAPTOP_PREFIX "ALSC"); /* Z71A Z71V */
-ASUS_HANDLE(ls_level, ASUS_LAPTOP_PREFIX "ALSL");       /* Z71A Z71V */
+#define METHOD_SWITCH_DISPLAY  "SDSP"
+
+static acpi_handle display_get_handle;
+static char *display_get_paths[] = {
+  /* A6B, A6K A6R A7D F3JM L4R M6R A3G M6A M6V VX-1 V6J V6V W3Z */
+  "\\_SB.PCI0.P0P1.VGA.GETD",
+  /* A3E A4K, A4D A4L A6J A7J A8J Z71V M9V S5A M5A z33A W1Jc W2V G1 */
+  "\\_SB.PCI0.P0P2.VGA.GETD",
+  /* A6V A6Q */
+  "\\_SB.PCI0.P0P3.VGA.GETD",
+  /* A6T, A6M */
+  "\\_SB.PCI0.P0PA.VGA.GETD",
+  /* L3C */
+  "\\_SB.PCI0.PCI1.VGAC.NMAP",
+  /* Z96F */
+  "\\_SB.PCI0.VGA.GETD",
+  /* A2D */
+  "\\ACTD",
+  /* A4G Z71A W1N W5A W5F M2N M3N M5N M6N S1N S5N */
+  "\\ADVG",
+  /* P30 */
+  "\\DNXT",
+  /* A2H D1 L2D L3D L3H L2E L5D L5C M1A M2E L4L W3V */
+  "\\INFB",
+  /* A3F A6F A3N A3L M6N W3N W6A */
+  "\\SSTE"};
+
+#define METHOD_ALS_CONTROL     "ALSC" /* Z71A Z71V */
+#define METHOD_ALS_LEVEL       "ALSL" /* Z71A Z71V */
 
 /* GPS */
 /* R2H use different handle for GPS on/off */
-ASUS_HANDLE(gps_on, ASUS_LAPTOP_PREFIX "SDON");        /* R2H */
-ASUS_HANDLE(gps_off, ASUS_LAPTOP_PREFIX "SDOF");       /* R2H */
-ASUS_HANDLE(gps_status, ASUS_LAPTOP_PREFIX "GPST");
+#define METHOD_GPS_ON          "SDON"
+#define METHOD_GPS_OFF         "SDOF"
+#define METHOD_GPS_STATUS      "GPST"
 
 /* Keyboard light */
-ASUS_HANDLE(kled_set, ASUS_LAPTOP_PREFIX "SLKB");
-ASUS_HANDLE(kled_get, ASUS_LAPTOP_PREFIX "GLKB");
+#define METHOD_KBD_LIGHT_SET   "SLKB"
+#define METHOD_KBD_LIGHT_GET   "GLKB"
 
 /*
  * Define a specific led structure to keep the main structure clean
  */
-#define ASUS_DEFINE_LED(object)                                        \
-       int object##_wk;                                        \
-       struct work_struct object##_work;                       \
-       struct led_classdev object;
-
-
-#define led_to_asus(led_cdev, led)                                     \
-       container_of(container_of(led_cdev, struct asus_laptop_leds,    \
-                                 led),                                 \
-                    struct asus_laptop, leds)
-#define work_to_asus(work, led)                                                \
-       container_of(container_of(work, struct asus_laptop_leds,        \
-                                 led##_work),                          \
-                    struct asus_laptop, leds)
-
-struct asus_laptop_leds {
-       ASUS_DEFINE_LED(mled)
-       ASUS_DEFINE_LED(tled)
-       ASUS_DEFINE_LED(rled)
-       ASUS_DEFINE_LED(pled)
-       ASUS_DEFINE_LED(gled)
-       ASUS_DEFINE_LED(kled)
-       struct workqueue_struct *workqueue;
+struct asus_led {
+       int wk;
+       struct work_struct work;
+       struct led_classdev led;
+       struct asus_laptop *asus;
+       const char *method;
 };
 
 /*
@@ -229,12 +217,20 @@ struct asus_laptop {
        struct input_dev *inputdev;
        struct key_entry *keymap;
 
-       struct asus_laptop_leds leds;
+       struct asus_led mled;
+       struct asus_led tled;
+       struct asus_led rled;
+       struct asus_led pled;
+       struct asus_led gled;
+       struct asus_led kled;
+       struct workqueue_struct *led_workqueue;
 
        int wireless_status;
        bool have_rsts;
        int lcd_state;
 
+       struct rfkill *gps_rfkill;
+
        acpi_handle handle;     /* the handle of the hotk device */
        u32 ledd_status;        /* status of the LED display */
        u8 light_level;         /* light sensor level */
@@ -243,52 +239,49 @@ struct asus_laptop {
        u16 *keycode_map;
 };
 
-struct key_entry {
-       char type;
-       u8 code;
-       u16 keycode;
-};
-
-enum { KE_KEY, KE_END };
-
 static const struct key_entry asus_keymap[] = {
-       {KE_KEY, 0x02, KEY_SCREENLOCK},
-       {KE_KEY, 0x05, KEY_WLAN},
-       {KE_KEY, 0x08, KEY_F13},
-       {KE_KEY, 0x17, KEY_ZOOM},
-       {KE_KEY, 0x1f, KEY_BATTERY},
-       {KE_KEY, 0x30, KEY_VOLUMEUP},
-       {KE_KEY, 0x31, KEY_VOLUMEDOWN},
-       {KE_KEY, 0x32, KEY_MUTE},
-       {KE_KEY, 0x33, KEY_SWITCHVIDEOMODE},
-       {KE_KEY, 0x34, KEY_SWITCHVIDEOMODE},
-       {KE_KEY, 0x40, KEY_PREVIOUSSONG},
-       {KE_KEY, 0x41, KEY_NEXTSONG},
-       {KE_KEY, 0x43, KEY_STOPCD},
-       {KE_KEY, 0x45, KEY_PLAYPAUSE},
-       {KE_KEY, 0x4c, KEY_MEDIA},
-       {KE_KEY, 0x50, KEY_EMAIL},
-       {KE_KEY, 0x51, KEY_WWW},
-       {KE_KEY, 0x55, KEY_CALC},
-       {KE_KEY, 0x5C, KEY_SCREENLOCK},  /* Screenlock */
-       {KE_KEY, 0x5D, KEY_WLAN},
-       {KE_KEY, 0x5E, KEY_WLAN},
-       {KE_KEY, 0x5F, KEY_WLAN},
-       {KE_KEY, 0x60, KEY_SWITCHVIDEOMODE},
-       {KE_KEY, 0x61, KEY_SWITCHVIDEOMODE},
-       {KE_KEY, 0x62, KEY_SWITCHVIDEOMODE},
-       {KE_KEY, 0x63, KEY_SWITCHVIDEOMODE},
-       {KE_KEY, 0x6B, KEY_F13}, /* Lock Touchpad */
-       {KE_KEY, 0x82, KEY_CAMERA},
-       {KE_KEY, 0x88, KEY_WLAN },
-       {KE_KEY, 0x8A, KEY_PROG1},
-       {KE_KEY, 0x95, KEY_MEDIA},
-       {KE_KEY, 0x99, KEY_PHONE},
-       {KE_KEY, 0xc4, KEY_KBDILLUMUP},
-       {KE_KEY, 0xc5, KEY_KBDILLUMDOWN},
+       /* Lenovo SL Specific keycodes */
+       {KE_KEY, 0x02, { KEY_SCREENLOCK } },
+       {KE_KEY, 0x05, { KEY_WLAN } },
+       {KE_KEY, 0x08, { KEY_F13 } },
+       {KE_KEY, 0x17, { KEY_ZOOM } },
+       {KE_KEY, 0x1f, { KEY_BATTERY } },
+       /* End of Lenovo SL Specific keycodes */
+       {KE_KEY, 0x30, { KEY_VOLUMEUP } },
+       {KE_KEY, 0x31, { KEY_VOLUMEDOWN } },
+       {KE_KEY, 0x32, { KEY_MUTE } },
+       {KE_KEY, 0x33, { KEY_SWITCHVIDEOMODE } },
+       {KE_KEY, 0x34, { KEY_SWITCHVIDEOMODE } },
+       {KE_KEY, 0x40, { KEY_PREVIOUSSONG } },
+       {KE_KEY, 0x41, { KEY_NEXTSONG } },
+       {KE_KEY, 0x43, { KEY_STOPCD } },
+       {KE_KEY, 0x45, { KEY_PLAYPAUSE } },
+       {KE_KEY, 0x4c, { KEY_MEDIA } },
+       {KE_KEY, 0x50, { KEY_EMAIL } },
+       {KE_KEY, 0x51, { KEY_WWW } },
+       {KE_KEY, 0x55, { KEY_CALC } },
+       {KE_KEY, 0x5C, { KEY_SCREENLOCK } },  /* Screenlock */
+       {KE_KEY, 0x5D, { KEY_WLAN } },
+       {KE_KEY, 0x5E, { KEY_WLAN } },
+       {KE_KEY, 0x5F, { KEY_WLAN } },
+       {KE_KEY, 0x60, { KEY_SWITCHVIDEOMODE } },
+       {KE_KEY, 0x61, { KEY_SWITCHVIDEOMODE } },
+       {KE_KEY, 0x62, { KEY_SWITCHVIDEOMODE } },
+       {KE_KEY, 0x63, { KEY_SWITCHVIDEOMODE } },
+       {KE_KEY, 0x6B, { KEY_F13 } }, /* Lock Touchpad */
+       {KE_KEY, 0x7E, { KEY_BLUETOOTH } },
+       {KE_KEY, 0x7D, { KEY_BLUETOOTH } },
+       {KE_KEY, 0x82, { KEY_CAMERA } },
+       {KE_KEY, 0x88, { KEY_WLAN  } },
+       {KE_KEY, 0x8A, { KEY_PROG1 } },
+       {KE_KEY, 0x95, { KEY_MEDIA } },
+       {KE_KEY, 0x99, { KEY_PHONE } },
+       {KE_KEY, 0xc4, { KEY_KBDILLUMUP } },
+       {KE_KEY, 0xc5, { KEY_KBDILLUMDOWN } },
        {KE_END, 0},
 };
 
+
 /*
  * This function evaluates an ACPI method, given an int as parameter, the
  * method is searched within the scope of the handle, can be NULL. The output
@@ -323,78 +316,77 @@ static int write_acpi_int(acpi_handle handle, const char *method, int val)
        return write_acpi_int_ret(handle, method, val, NULL);
 }
 
+static int acpi_check_handle(acpi_handle handle, const char *method,
+                            acpi_handle *ret)
+{
+       acpi_status status;
+
+       if (method == NULL)
+               return -ENODEV;
+
+       if (ret)
+               status = acpi_get_handle(handle, (char *)method,
+                                        ret);
+       else {
+               acpi_handle dummy;
+
+               status = acpi_get_handle(handle, (char *)method,
+                                        &dummy);
+       }
+
+       if (status != AE_OK) {
+               if (ret)
+                       pr_warning("Error finding %s\n", method);
+               return -ENODEV;
+       }
+       return 0;
+}
+
 /* Generic LED function */
-static void asus_led_set(struct asus_laptop *asus, acpi_handle handle,
+static int asus_led_set(struct asus_laptop *asus, const char *method,
                         int value)
 {
-       if (handle == mled_set_handle)
+       if (!strcmp(method, METHOD_MLED))
                value = !value;
-       else if (handle == gled_set_handle)
+       else if (!strcmp(method, METHOD_GLED))
                value = !value + 1;
        else
                value = !!value;
 
-       write_acpi_int(handle, NULL, value);
+       return write_acpi_int(asus->handle, method, value);
 }
 
 /*
  * LEDs
  */
-#define ASUS_LED(object, ledname, max)                                 \
-       static void object##_led_set(struct led_classdev *led_cdev,     \
-                                    enum led_brightness value);        \
-       static enum led_brightness object##_led_get(                    \
-               struct led_classdev *led_cdev);                         \
-       static void object##_led_update(struct work_struct *ignored);   \
-       static struct led_classdev object##_led = {                     \
-               .name           = "asus::" ledname,                     \
-               .brightness_set = object##_led_set,                     \
-               .brightness_get = object##_led_get,                     \
-               .max_brightness = max                                   \
-       }
+/* /sys/class/led handlers */
+static void asus_led_cdev_set(struct led_classdev *led_cdev,
+                        enum led_brightness value)
+{
+       struct asus_led *led = container_of(led_cdev, struct asus_led, led);
+       struct asus_laptop *asus = led->asus;
 
-ASUS_LED(mled, "mail", 1);
-ASUS_LED(tled, "touchpad", 1);
-ASUS_LED(rled, "record", 1);
-ASUS_LED(pled, "phone", 1);
-ASUS_LED(gled, "gaming", 1);
-ASUS_LED(kled, "kbd_backlight", 3);
+       led->wk = !!value;
+       queue_work(asus->led_workqueue, &led->work);
+}
 
-/* /sys/class/led handlers */
-#define ASUS_LED_HANDLER(object, mask)                                 \
-       static void object##_led_set(struct led_classdev *led_cdev,     \
-                                    enum led_brightness value)         \
-       {                                                               \
-               struct asus_laptop *asus =                              \
-                       led_to_asus(led_cdev, object);                  \
-                                                                       \
-               asus->leds.object##_wk = (value > 0) ? 1 : 0;           \
-               queue_work(asus->leds.workqueue,                        \
-                          &asus->leds.object##_work);                  \
-       }                                                               \
-       static void object##_led_update(struct work_struct *work)       \
-       {                                                               \
-               struct asus_laptop *asus = work_to_asus(work, object);  \
-                                                                       \
-               int value = asus->leds.object##_wk;                     \
-               asus_led_set(asus, object##_set_handle, value);         \
-       }                                                               \
-       static enum led_brightness object##_led_get(                    \
-               struct led_classdev *led_cdev)                          \
-       {                                                               \
-               return led_cdev->brightness;                            \
-       }
+static void asus_led_cdev_update(struct work_struct *work)
+{
+       struct asus_led *led = container_of(work, struct asus_led, work);
+       struct asus_laptop *asus = led->asus;
 
-ASUS_LED_HANDLER(mled, MLED_ON);
-ASUS_LED_HANDLER(pled, PLED_ON);
-ASUS_LED_HANDLER(rled, RLED_ON);
-ASUS_LED_HANDLER(tled, TLED_ON);
-ASUS_LED_HANDLER(gled, GLED_ON);
+       asus_led_set(asus, led->method, led->wk);
+}
+
+static enum led_brightness asus_led_cdev_get(struct led_classdev *led_cdev)
+{
+       return led_cdev->brightness;
+}
 
 /*
  * Keyboard backlight (also a LED)
  */
-static int get_kled_lvl(void)
+static int asus_kled_lvl(struct asus_laptop *asus)
 {
        unsigned long long kblv;
        struct acpi_object_list params;
@@ -406,86 +398,99 @@ static int get_kled_lvl(void)
        in_obj.type = ACPI_TYPE_INTEGER;
        in_obj.integer.value = 2;
 
-       rv = acpi_evaluate_integer(kled_get_handle, NULL, &params, &kblv);
+       rv = acpi_evaluate_integer(asus->handle, METHOD_KBD_LIGHT_GET,
+                                  &params, &kblv);
        if (ACPI_FAILURE(rv)) {
                pr_warning("Error reading kled level\n");
-               return 0;
+               return -ENODEV;
        }
        return kblv;
 }
 
-static int set_kled_lvl(struct asus_laptop *asus, int kblv)
+static int asus_kled_set(struct asus_laptop *asus, int kblv)
 {
        if (kblv > 0)
                kblv = (1 << 7) | (kblv & 0x7F);
        else
                kblv = 0;
 
-       if (write_acpi_int(kled_set_handle, NULL, kblv)) {
+       if (write_acpi_int(asus->handle, METHOD_KBD_LIGHT_SET, kblv)) {
                pr_warning("Keyboard LED display write failed\n");
                return -EINVAL;
        }
        return 0;
 }
 
-static void kled_led_set(struct led_classdev *led_cdev,
-                        enum led_brightness value)
+static void asus_kled_cdev_set(struct led_classdev *led_cdev,
+                             enum led_brightness value)
 {
-       struct asus_laptop *asus = led_to_asus(led_cdev, kled);
+       struct asus_led *led = container_of(led_cdev, struct asus_led, led);
+       struct asus_laptop *asus = led->asus;
 
-       asus->leds.kled_wk = value;
-       queue_work(asus->leds.workqueue, &asus->leds.kled_work);
+       led->wk = value;
+       queue_work(asus->led_workqueue, &led->work);
 }
 
-static void kled_led_update(struct work_struct *work)
+static void asus_kled_cdev_update(struct work_struct *work)
 {
-       struct asus_laptop *asus = work_to_asus(work, kled);
+       struct asus_led *led = container_of(work, struct asus_led, work);
+       struct asus_laptop *asus = led->asus;
 
-       set_kled_lvl(asus, asus->leds.kled_wk);
+       asus_kled_set(asus, led->wk);
 }
 
-static enum led_brightness kled_led_get(struct led_classdev *led_cdev)
+static enum led_brightness asus_kled_cdev_get(struct led_classdev *led_cdev)
 {
-       return get_kled_lvl();
-}
+       struct asus_led *led = container_of(led_cdev, struct asus_led, led);
+       struct asus_laptop *asus = led->asus;
 
-#define ASUS_LED_UNREGISTER(object)                            \
-       if (object##_led.dev)                                   \
-               led_classdev_unregister(&object##_led)
+       return asus_kled_lvl(asus);
+}
 
 static void asus_led_exit(struct asus_laptop *asus)
 {
-       ASUS_LED_UNREGISTER(mled);
-       ASUS_LED_UNREGISTER(tled);
-       ASUS_LED_UNREGISTER(pled);
-       ASUS_LED_UNREGISTER(rled);
-       ASUS_LED_UNREGISTER(gled);
-       ASUS_LED_UNREGISTER(kled);
-       if (asus->leds.workqueue) {
-               destroy_workqueue(asus->leds.workqueue);
-               asus->leds.workqueue = NULL;
+       if (asus->mled.led.dev)
+               led_classdev_unregister(&asus->mled.led);
+       if (asus->tled.led.dev)
+               led_classdev_unregister(&asus->tled.led);
+       if (asus->pled.led.dev)
+               led_classdev_unregister(&asus->pled.led);
+       if (asus->rled.led.dev)
+               led_classdev_unregister(&asus->rled.led);
+       if (asus->gled.led.dev)
+               led_classdev_unregister(&asus->gled.led);
+       if (asus->kled.led.dev)
+               led_classdev_unregister(&asus->kled.led);
+       if (asus->led_workqueue) {
+               destroy_workqueue(asus->led_workqueue);
+               asus->led_workqueue = NULL;
        }
 }
 
 /*  Ugly macro, need to fix that later */
-#define ASUS_LED_REGISTER(asus, object, _name, max)                    \
-       do {                                                            \
-               struct led_classdev *ldev = &asus->leds.object;         \
-               if (!object##_set_handle)                               \
-                       break ;                                         \
-                                                                       \
-               INIT_WORK(&asus->leds.object##_work, object##_led_update); \
-               ldev->name = "asus::" _name;                            \
-               ldev->brightness_set = object##_led_set;                \
-               ldev->max_brightness = max;                             \
-               rv = led_classdev_register(&asus->platform_device->dev, ldev); \
-               if (rv)                                                 \
-                       goto error;                                     \
-       } while (0)
+static int asus_led_register(struct asus_laptop *asus,
+                            struct asus_led *led,
+                            const char *name, const char *method)
+{
+       struct led_classdev *led_cdev = &led->led;
+
+       if (!method || acpi_check_handle(asus->handle, method, NULL))
+               return 0; /* Led not present */
+
+       led->asus = asus;
+       led->method = method;
+
+       INIT_WORK(&led->work, asus_led_cdev_update);
+       led_cdev->name = name;
+       led_cdev->brightness_set = asus_led_cdev_set;
+       led_cdev->brightness_get = asus_led_cdev_get;
+       led_cdev->max_brightness = 1;
+       return led_classdev_register(&asus->platform_device->dev, led_cdev);
+}
 
 static int asus_led_init(struct asus_laptop *asus)
 {
-       int rv;
+       int r;
 
        /*
         * Functions that actually update the LED's are called from a
@@ -493,21 +498,43 @@ static int asus_led_init(struct asus_laptop *asus)
         * subsystem asks, we avoid messing with the Asus ACPI stuff during a
         * potentially bad time, such as a timer interrupt.
         */
-       asus->leds.workqueue = create_singlethread_workqueue("led_workqueue");
-       if (!asus->leds.workqueue)
+       asus->led_workqueue = create_singlethread_workqueue("led_workqueue");
+       if (!asus->led_workqueue)
                return -ENOMEM;
 
-       ASUS_LED_REGISTER(asus, mled, "mail", 1);
-       ASUS_LED_REGISTER(asus, tled, "touchpad", 1);
-       ASUS_LED_REGISTER(asus, rled, "record", 1);
-       ASUS_LED_REGISTER(asus, pled, "phone", 1);
-       ASUS_LED_REGISTER(asus, gled, "gaming", 1);
-       if (kled_set_handle && kled_get_handle)
-               ASUS_LED_REGISTER(asus, kled, "kbd_backlight", 3);
+       r = asus_led_register(asus, &asus->mled, "asus::mail", METHOD_MLED);
+       if (r)
+               goto error;
+       r = asus_led_register(asus, &asus->tled, "asus::touchpad", METHOD_TLED);
+       if (r)
+               goto error;
+       r = asus_led_register(asus, &asus->rled, "asus::record", METHOD_RLED);
+       if (r)
+               goto error;
+       r = asus_led_register(asus, &asus->pled, "asus::phone", METHOD_PLED);
+       if (r)
+               goto error;
+       r = asus_led_register(asus, &asus->gled, "asus::gaming", METHOD_GLED);
+       if (r)
+               goto error;
+       if (!acpi_check_handle(asus->handle, METHOD_KBD_LIGHT_SET, NULL) &&
+           !acpi_check_handle(asus->handle, METHOD_KBD_LIGHT_GET, NULL)) {
+               struct asus_led *led = &asus->kled;
+               struct led_classdev *cdev = &led->led;
+
+               led->asus = asus;
+
+               INIT_WORK(&led->work, asus_kled_cdev_update);
+               cdev->name = "asus::kbd_backlight";
+               cdev->brightness_set = asus_kled_cdev_set;
+               cdev->brightness_get = asus_kled_cdev_get;
+               cdev->max_brightness = 3;
+               r = led_classdev_register(&asus->platform_device->dev, cdev);
+       }
 error:
-       if (rv)
+       if (r)
                asus_led_exit(asus);
-       return rv;
+       return r;
 }
 
 /*
@@ -555,21 +582,25 @@ static void lcd_blank(struct asus_laptop *asus, int blank)
        }
 }
 
-static int read_brightness(struct backlight_device *bd)
+static int asus_read_brightness(struct backlight_device *bd)
 {
+       struct asus_laptop *asus = bl_get_data(bd);
        unsigned long long value;
        acpi_status rv = AE_OK;
 
-       rv = acpi_evaluate_integer(brightness_get_handle, NULL, NULL, &value);
+       rv = acpi_evaluate_integer(asus->handle, METHOD_BRIGHTNESS_GET,
+                                  NULL, &value);
        if (ACPI_FAILURE(rv))
                pr_warning("Error reading brightness\n");
 
        return value;
 }
 
-static int set_brightness(struct backlight_device *bd, int value)
+static int asus_set_brightness(struct backlight_device *bd, int value)
 {
-       if (write_acpi_int(brightness_set_handle, NULL, value)) {
+       struct asus_laptop *asus = bl_get_data(bd);
+
+       if (write_acpi_int(asus->handle, METHOD_BRIGHTNESS_SET, value)) {
                pr_warning("Error changing brightness\n");
                return -EIO;
        }
@@ -582,7 +613,7 @@ static int update_bl_status(struct backlight_device *bd)
        int rv;
        int value = bd->props.brightness;
 
-       rv = set_brightness(bd, value);
+       rv = asus_set_brightness(bd, value);
        if (rv)
                return rv;
 
@@ -591,18 +622,34 @@ static int update_bl_status(struct backlight_device *bd)
 }
 
 static struct backlight_ops asusbl_ops = {
-       .get_brightness = read_brightness,
+       .get_brightness = asus_read_brightness,
        .update_status = update_bl_status,
 };
 
+static int asus_backlight_notify(struct asus_laptop *asus)
+{
+       struct backlight_device *bd = asus->backlight_device;
+       int old = bd->props.brightness;
+
+       backlight_force_update(bd, BACKLIGHT_UPDATE_HOTKEY);
+
+       return old;
+}
+
 static int asus_backlight_init(struct asus_laptop *asus)
 {
        struct backlight_device *bd;
        struct device *dev = &asus->platform_device->dev;
+       struct backlight_properties props;
+
+       if (!acpi_check_handle(asus->handle, METHOD_BRIGHTNESS_GET, NULL) &&
+           !acpi_check_handle(asus->handle, METHOD_BRIGHTNESS_SET, NULL) &&
+           lcd_switch_handle) {
+               memset(&props, 0, sizeof(struct backlight_properties));
+               props.max_brightness = 15;
 
-       if (brightness_set_handle && lcd_switch_handle) {
                bd = backlight_device_register(ASUS_LAPTOP_FILE, dev,
-                                              asus, &asusbl_ops);
+                                              asus, &asusbl_ops, &props);
                if (IS_ERR(bd)) {
                        pr_err("Could not register asus backlight device\n");
                        asus->backlight_device = NULL;
@@ -611,9 +658,8 @@ static int asus_backlight_init(struct asus_laptop *asus)
 
                asus->backlight_device = bd;
 
-               bd->props.max_brightness = 15;
-               bd->props.brightness = read_brightness(NULL);
                bd->props.power = FB_BLANK_UNBLANK;
+               bd->props.brightness = asus_read_brightness(bd);
                backlight_update_status(bd);
        }
        return 0;
@@ -623,6 +669,7 @@ static void asus_backlight_exit(struct asus_laptop *asus)
 {
        if (asus->backlight_device)
                backlight_device_unregister(asus->backlight_device);
+       asus->backlight_device = NULL;
 }
 
 /*
@@ -644,8 +691,8 @@ static ssize_t show_infos(struct device *dev,
        acpi_status rv = AE_OK;
 
        /*
-        * We use the easy way, we don't care of off and count, so we don't set eof
-        * to 1
+        * We use the easy way, we don't care of off and count,
+        * so we don't set eof to 1
         */
 
        len += sprintf(page, ASUS_LAPTOP_NAME " " ASUS_LAPTOP_VERSION "\n");
@@ -716,7 +763,7 @@ static int parse_arg(const char *buf, unsigned long count, int *val)
 
 static ssize_t sysfs_acpi_set(struct asus_laptop *asus,
                              const char *buf, size_t count,
-                             acpi_handle handle)
+                             const char *method)
 {
        int rv, value;
        int out = 0;
@@ -725,7 +772,7 @@ static ssize_t sysfs_acpi_set(struct asus_laptop *asus,
        if (rv > 0)
                out = value ? 1 : 0;
 
-       if (write_acpi_int(handle, NULL, value))
+       if (write_acpi_int(asus->handle, method, value))
                return -ENODEV;
        return rv;
 }
@@ -749,7 +796,7 @@ static ssize_t store_ledd(struct device *dev, struct device_attribute *attr,
 
        rv = parse_arg(buf, count, &value);
        if (rv > 0) {
-               if (write_acpi_int(ledd_set_handle, NULL, value))
+               if (write_acpi_int(asus->handle, METHOD_LEDD, value))
                        pr_warning("LED display write failed\n");
                else
                        asus->ledd_status = (u32) value;
@@ -768,7 +815,8 @@ static int asus_wireless_status(struct asus_laptop *asus, int mask)
        if (!asus->have_rsts)
                return (asus->wireless_status & mask) ? 1 : 0;
 
-       rv = acpi_evaluate_integer(wireless_status_handle, NULL, NULL, &status);
+       rv = acpi_evaluate_integer(asus->handle, METHOD_WL_STATUS,
+                                  NULL, &status);
        if (ACPI_FAILURE(rv)) {
                pr_warning("Error reading Wireless status\n");
                return -EINVAL;
@@ -779,6 +827,15 @@ static int asus_wireless_status(struct asus_laptop *asus, int mask)
 /*
  * WLAN
  */
+static int asus_wlan_set(struct asus_laptop *asus, int status)
+{
+       if (write_acpi_int(asus->handle, METHOD_WLAN, !!status)) {
+               pr_warning("Error setting wlan status to %d", status);
+               return -EIO;
+       }
+       return 0;
+}
+
 static ssize_t show_wlan(struct device *dev,
                         struct device_attribute *attr, char *buf)
 {
@@ -792,12 +849,21 @@ static ssize_t store_wlan(struct device *dev, struct device_attribute *attr,
 {
        struct asus_laptop *asus = dev_get_drvdata(dev);
 
-       return sysfs_acpi_set(asus, buf, count, wl_switch_handle);
+       return sysfs_acpi_set(asus, buf, count, METHOD_WLAN);
 }
 
 /*
  * Bluetooth
  */
+static int asus_bluetooth_set(struct asus_laptop *asus, int status)
+{
+       if (write_acpi_int(asus->handle, METHOD_BLUETOOTH, !!status)) {
+               pr_warning("Error setting bluetooth status to %d", status);
+               return -EIO;
+       }
+       return 0;
+}
+
 static ssize_t show_bluetooth(struct device *dev,
                              struct device_attribute *attr, char *buf)
 {
@@ -812,16 +878,16 @@ static ssize_t store_bluetooth(struct device *dev,
 {
        struct asus_laptop *asus = dev_get_drvdata(dev);
 
-       return sysfs_acpi_set(asus, buf, count, bt_switch_handle);
+       return sysfs_acpi_set(asus, buf, count, METHOD_BLUETOOTH);
 }
 
 /*
  * Display
  */
-static void set_display(struct asus_laptop *asus, int value)
+static void asus_set_display(struct asus_laptop *asus, int value)
 {
        /* no sanity check needed for now */
-       if (write_acpi_int(display_set_handle, NULL, value))
+       if (write_acpi_int(asus->handle, METHOD_SWITCH_DISPLAY, value))
                pr_warning("Error setting display\n");
        return;
 }
@@ -842,7 +908,7 @@ static int read_display(struct asus_laptop *asus)
                        pr_warning("Error reading display status\n");
        }
 
-       value &= 0x0F;          /* needed for some models, shouldn't hurt others */
+       value &= 0x0F; /* needed for some models, shouldn't hurt others */
 
        return value;
 }
@@ -856,6 +922,8 @@ static ssize_t show_disp(struct device *dev,
 {
        struct asus_laptop *asus = dev_get_drvdata(dev);
 
+       if (!display_get_handle)
+               return -ENODEV;
        return sprintf(buf, "%d\n", read_display(asus));
 }
 
@@ -874,16 +942,16 @@ static ssize_t store_disp(struct device *dev, struct device_attribute *attr,
 
        rv = parse_arg(buf, count, &value);
        if (rv > 0)
-               set_display(asus, value);
+               asus_set_display(asus, value);
        return rv;
 }
 
 /*
  * Light Sens
  */
-static void set_light_sens_switch(struct asus_laptop *asus, int value)
+static void asus_als_switch(struct asus_laptop *asus, int value)
 {
-       if (write_acpi_int(ls_switch_handle, NULL, value))
+       if (write_acpi_int(asus->handle, METHOD_ALS_CONTROL, value))
                pr_warning("Error setting light sensor switch\n");
        asus->light_switch = value;
 }
@@ -904,14 +972,14 @@ static ssize_t store_lssw(struct device *dev, struct device_attribute *attr,
 
        rv = parse_arg(buf, count, &value);
        if (rv > 0)
-               set_light_sens_switch(asus, value ? 1 : 0);
+               asus_als_switch(asus, value ? 1 : 0);
 
        return rv;
 }
 
-static void set_light_sens_level(struct asus_laptop *asus, int value)
+static void asus_als_level(struct asus_laptop *asus, int value)
 {
-       if (write_acpi_int(ls_level_handle, NULL, value))
+       if (write_acpi_int(asus->handle, METHOD_ALS_LEVEL, value))
                pr_warning("Error setting light sensor level\n");
        asus->light_level = value;
 }
@@ -934,7 +1002,7 @@ static ssize_t store_lslvl(struct device *dev, struct device_attribute *attr,
        if (rv > 0) {
                value = (0 < value) ? ((15 < value) ? 15 : value) : 0;
                /* 0 <= value <= 15 */
-               set_light_sens_level(asus, value);
+               asus_als_level(asus, value);
        }
 
        return rv;
@@ -942,14 +1010,14 @@ static ssize_t store_lslvl(struct device *dev, struct device_attribute *attr,
 
 /*
  * GPS
- * TODO: use rfkill
  */
 static int asus_gps_status(struct asus_laptop *asus)
 {
        unsigned long long status;
        acpi_status rv = AE_OK;
 
-       rv = acpi_evaluate_integer(gps_status_handle, NULL, NULL, &status);
+       rv = acpi_evaluate_integer(asus->handle, METHOD_GPS_STATUS,
+                                  NULL, &status);
        if (ACPI_FAILURE(rv)) {
                pr_warning("Error reading GPS status\n");
                return -ENODEV;
@@ -959,9 +1027,9 @@ static int asus_gps_status(struct asus_laptop *asus)
 
 static int asus_gps_switch(struct asus_laptop *asus, int status)
 {
-       acpi_handle handle = status ? gps_on_handle : gps_off_handle;
+       const char *meth = status ? METHOD_GPS_ON : METHOD_GPS_OFF;
 
-       if (write_acpi_int(handle, NULL, 0x02))
+       if (write_acpi_int(asus->handle, meth, 0x02))
                return -ENODEV;
        return 0;
 }
@@ -977,7 +1045,7 @@ static ssize_t show_gps(struct device *dev,
 static ssize_t store_gps(struct device *dev, struct device_attribute *attr,
                         const char *buf, size_t count)
 {
-       struct asus_laptop *asus = dev_get_drvdata(dev);
+       struct asus_laptop *asus = dev_get_drvdata(dev);
        int rv, value;
        int ret;
 
@@ -987,129 +1055,109 @@ static ssize_t store_gps(struct device *dev, struct device_attribute *attr,
        ret = asus_gps_switch(asus, !!value);
        if (ret)
                return ret;
+       rfkill_set_sw_state(asus->gps_rfkill, !value);
        return rv;
 }
 
 /*
- * Input device (i.e. hotkeys)
+ * rfkill
  */
-static struct key_entry *asus_get_entry_by_scancode(struct asus_laptop *asus,
-                                                   int code)
+static int asus_gps_rfkill_set(void *data, bool blocked)
 {
-       struct key_entry *key;
-
-       for (key = asus->keymap; key->type != KE_END; key++)
-               if (code == key->code)
-                       return key;
+       acpi_handle handle = data;
 
-       return NULL;
+       return asus_gps_switch(handle, !blocked);
 }
 
-static struct key_entry *asus_get_entry_by_keycode(struct asus_laptop *asus,
-                                                  int code)
-{
-       struct key_entry *key;
-
-       for (key = asus->keymap; key->type != KE_END; key++)
-               if (code == key->keycode && key->type == KE_KEY)
-                       return key;
-
-       return NULL;
-}
+static const struct rfkill_ops asus_gps_rfkill_ops = {
+       .set_block = asus_gps_rfkill_set,
+};
 
-static int asus_getkeycode(struct input_dev *dev, int scancode, int *keycode)
+static void asus_rfkill_exit(struct asus_laptop *asus)
 {
-       struct asus_laptop *asus = input_get_drvdata(dev);
-       struct key_entry *key = asus_get_entry_by_scancode(asus, scancode);
-
-       if (key && key->type == KE_KEY) {
-               *keycode = key->keycode;
-               return 0;
+       if (asus->gps_rfkill) {
+               rfkill_unregister(asus->gps_rfkill);
+               rfkill_destroy(asus->gps_rfkill);
+               asus->gps_rfkill = NULL;
        }
-
-       return -EINVAL;
 }
 
-static int asus_setkeycode(struct input_dev *dev, int scancode, int keycode)
+static int asus_rfkill_init(struct asus_laptop *asus)
 {
-       struct asus_laptop *asus = input_get_drvdata(dev);
-       struct key_entry *key;
-       int old_keycode;
+       int result;
+
+       if (acpi_check_handle(asus->handle, METHOD_GPS_ON, NULL) ||
+           acpi_check_handle(asus->handle, METHOD_GPS_OFF, NULL) ||
+           acpi_check_handle(asus->handle, METHOD_GPS_STATUS, NULL))
+               return 0;
 
-       if (keycode < 0 || keycode > KEY_MAX)
+       asus->gps_rfkill = rfkill_alloc("asus-gps", &asus->platform_device->dev,
+                                       RFKILL_TYPE_GPS,
+                                       &asus_gps_rfkill_ops, NULL);
+       if (!asus->gps_rfkill)
                return -EINVAL;
 
-       key = asus_get_entry_by_scancode(asus, scancode);
-       if (key && key->type == KE_KEY) {
-               old_keycode = key->keycode;
-               key->keycode = keycode;
-               set_bit(keycode, dev->keybit);
-               if (!asus_get_entry_by_keycode(asus, old_keycode))
-                       clear_bit(old_keycode, dev->keybit);
-               return 0;
+       result = rfkill_register(asus->gps_rfkill);
+       if (result) {
+               rfkill_destroy(asus->gps_rfkill);
+               asus->gps_rfkill = NULL;
        }
 
-       return -EINVAL;
+       return result;
 }
 
+/*
+ * Input device (i.e. hotkeys)
+ */
 static void asus_input_notify(struct asus_laptop *asus, int event)
 {
-       struct key_entry *key;
-
-       key = asus_get_entry_by_scancode(asus, event);
-       if (!key)
-               return ;
-
-       switch (key->type) {
-       case KE_KEY:
-               input_report_key(asus->inputdev, key->keycode, 1);
-               input_sync(asus->inputdev);
-               input_report_key(asus->inputdev, key->keycode, 0);
-               input_sync(asus->inputdev);
-               break;
-       }
+       if (asus->inputdev)
+               sparse_keymap_report_event(asus->inputdev, event, 1, true);
 }
 
 static int asus_input_init(struct asus_laptop *asus)
 {
-       const struct key_entry *key;
-       int result;
+       struct input_dev *input;
+       int error;
 
-       asus->inputdev = input_allocate_device();
-       if (!asus->inputdev) {
+       input = input_allocate_device();
+       if (!input) {
                pr_info("Unable to allocate input device\n");
                return 0;
        }
-       asus->inputdev->name = "Asus Laptop extra buttons";
-       asus->inputdev->dev.parent = &asus->platform_device->dev;
-       asus->inputdev->phys = ASUS_LAPTOP_FILE "/input0";
-       asus->inputdev->id.bustype = BUS_HOST;
-       asus->inputdev->getkeycode = asus_getkeycode;
-       asus->inputdev->setkeycode = asus_setkeycode;
-       input_set_drvdata(asus->inputdev, asus);
-
-       asus->keymap = kmemdup(asus_keymap, sizeof(asus_keymap),
-                               GFP_KERNEL);
-       for (key = asus->keymap; key->type != KE_END; key++) {
-               switch (key->type) {
-               case KE_KEY:
-                       set_bit(EV_KEY, asus->inputdev->evbit);
-                       set_bit(key->keycode, asus->inputdev->keybit);
-                       break;
-               }
+       input->name = "Asus Laptop extra buttons";
+       input->phys = ASUS_LAPTOP_FILE "/input0";
+       input->id.bustype = BUS_HOST;
+       input->dev.parent = &asus->platform_device->dev;
+       input_set_drvdata(input, asus);
+
+       error = sparse_keymap_setup(input, asus_keymap, NULL);
+       if (error) {
+               pr_err("Unable to setup input device keymap\n");
+               goto err_keymap;
        }
-       result = input_register_device(asus->inputdev);
-       if (result) {
+       error = input_register_device(input);
+       if (error) {
                pr_info("Unable to register input device\n");
-               input_free_device(asus->inputdev);
+               goto err_device;
        }
-       return result;
+
+       asus->inputdev = input;
+       return 0;
+
+err_keymap:
+       sparse_keymap_free(input);
+err_device:
+       input_free_device(input);
+       return error;
 }
 
 static void asus_input_exit(struct asus_laptop *asus)
 {
-       if (asus->inputdev)
+       if (asus->inputdev) {
+               sparse_keymap_free(asus->inputdev);
                input_unregister_device(asus->inputdev);
+       }
 }
 
 /*
@@ -1136,80 +1184,126 @@ static void asus_acpi_notify(struct acpi_device *device, u32 event)
                                        dev_name(&asus->device->dev), event,
                                        count);
 
+       /* Brightness events are special */
+       if (event >= ATKD_BR_MIN && event <= ATKD_BR_MAX) {
+
+               /* Ignore them completely if the acpi video driver is used */
+               if (asus->backlight_device != NULL) {
+                       /* Update the backlight device. */
+                       asus_backlight_notify(asus);
+               }
+               return ;
+       }
        asus_input_notify(asus, event);
 }
 
-#define ASUS_CREATE_DEVICE_ATTR(_name)                                 \
-       struct device_attribute dev_attr_##_name = {                    \
-               .attr = {                                               \
-                       .name = __stringify(_name),                     \
-                       .mode = 0 },                                    \
-               .show   = NULL,                                         \
-               .store  = NULL,                                         \
+static DEVICE_ATTR(infos, S_IRUGO, show_infos, NULL);
+static DEVICE_ATTR(wlan, S_IRUGO | S_IWUSR, show_wlan, store_wlan);
+static DEVICE_ATTR(bluetooth, S_IRUGO | S_IWUSR, show_bluetooth,
+                  store_bluetooth);
+static DEVICE_ATTR(display, S_IRUGO | S_IWUSR, show_disp, store_disp);
+static DEVICE_ATTR(ledd, S_IRUGO | S_IWUSR, show_ledd, store_ledd);
+static DEVICE_ATTR(ls_level, S_IRUGO | S_IWUSR, show_lslvl, store_lslvl);
+static DEVICE_ATTR(ls_switch, S_IRUGO | S_IWUSR, show_lssw, store_lssw);
+static DEVICE_ATTR(gps, S_IRUGO | S_IWUSR, show_gps, store_gps);
+
+static void asus_sysfs_exit(struct asus_laptop *asus)
+{
+       struct platform_device *device = asus->platform_device;
+
+       device_remove_file(&device->dev, &dev_attr_infos);
+       device_remove_file(&device->dev, &dev_attr_wlan);
+       device_remove_file(&device->dev, &dev_attr_bluetooth);
+       device_remove_file(&device->dev, &dev_attr_display);
+       device_remove_file(&device->dev, &dev_attr_ledd);
+       device_remove_file(&device->dev, &dev_attr_ls_switch);
+       device_remove_file(&device->dev, &dev_attr_ls_level);
+       device_remove_file(&device->dev, &dev_attr_gps);
+}
+
+static int asus_sysfs_init(struct asus_laptop *asus)
+{
+       struct platform_device *device = asus->platform_device;
+       int err;
+
+       err = device_create_file(&device->dev, &dev_attr_infos);
+       if (err)
+               return err;
+
+       if (!acpi_check_handle(asus->handle, METHOD_WLAN, NULL)) {
+               err = device_create_file(&device->dev, &dev_attr_wlan);
+               if (err)
+                       return err;
        }
 
-#define ASUS_SET_DEVICE_ATTR(_name, _mode, _show, _store)              \
-       do {                                                            \
-               dev_attr_##_name.attr.mode = _mode;                     \
-               dev_attr_##_name.show = _show;                          \
-               dev_attr_##_name.store = _store;                        \
-       } while(0)
-
-static ASUS_CREATE_DEVICE_ATTR(infos);
-static ASUS_CREATE_DEVICE_ATTR(wlan);
-static ASUS_CREATE_DEVICE_ATTR(bluetooth);
-static ASUS_CREATE_DEVICE_ATTR(display);
-static ASUS_CREATE_DEVICE_ATTR(ledd);
-static ASUS_CREATE_DEVICE_ATTR(ls_switch);
-static ASUS_CREATE_DEVICE_ATTR(ls_level);
-static ASUS_CREATE_DEVICE_ATTR(gps);
-
-static struct attribute *asuspf_attributes[] = {
-       &dev_attr_infos.attr,
-       &dev_attr_wlan.attr,
-       &dev_attr_bluetooth.attr,
-       &dev_attr_display.attr,
-       &dev_attr_ledd.attr,
-       &dev_attr_ls_switch.attr,
-       &dev_attr_ls_level.attr,
-       &dev_attr_gps.attr,
-       NULL
-};
+       if (!acpi_check_handle(asus->handle, METHOD_BLUETOOTH, NULL)) {
+               err = device_create_file(&device->dev, &dev_attr_bluetooth);
+               if (err)
+                       return err;
+       }
 
-static struct attribute_group platform_attribute_group = {
-       .attrs = asuspf_attributes
-};
+       if (!acpi_check_handle(asus->handle, METHOD_SWITCH_DISPLAY, NULL)) {
+               err = device_create_file(&device->dev, &dev_attr_display);
+               if (err)
+                       return err;
+       }
+
+       if (!acpi_check_handle(asus->handle, METHOD_LEDD, NULL)) {
+               err = device_create_file(&device->dev, &dev_attr_ledd);
+               if (err)
+                       return err;
+       }
+
+       if (!acpi_check_handle(asus->handle, METHOD_ALS_CONTROL, NULL) &&
+           !acpi_check_handle(asus->handle, METHOD_ALS_LEVEL, NULL)) {
+               err = device_create_file(&device->dev, &dev_attr_ls_switch);
+               if (err)
+                       return err;
+               err = device_create_file(&device->dev, &dev_attr_ls_level);
+               if (err)
+                       return err;
+       }
+
+       if (!acpi_check_handle(asus->handle, METHOD_GPS_ON, NULL) &&
+           !acpi_check_handle(asus->handle, METHOD_GPS_OFF, NULL) &&
+           !acpi_check_handle(asus->handle, METHOD_GPS_STATUS, NULL)) {
+               err = device_create_file(&device->dev, &dev_attr_gps);
+               if (err)
+                       return err;
+       }
+
+       return err;
+}
 
 static int asus_platform_init(struct asus_laptop *asus)
 {
-       int result;
+       int err;
 
        asus->platform_device = platform_device_alloc(ASUS_LAPTOP_FILE, -1);
        if (!asus->platform_device)
                return -ENOMEM;
        platform_set_drvdata(asus->platform_device, asus);
 
-       result = platform_device_add(asus->platform_device);
-       if (result)
+       err = platform_device_add(asus->platform_device);
+       if (err)
                goto fail_platform_device;
 
-       result = sysfs_create_group(&asus->platform_device->dev.kobj,
-                                   &platform_attribute_group);
-       if (result)
+       err = asus_sysfs_init(asus);
+       if (err)
                goto fail_sysfs;
        return 0;
 
 fail_sysfs:
+       asus_sysfs_exit(asus);
        platform_device_del(asus->platform_device);
 fail_platform_device:
        platform_device_put(asus->platform_device);
-       return result;
+       return err;
 }
 
 static void asus_platform_exit(struct asus_laptop *asus)
 {
-       sysfs_remove_group(&asus->platform_device->dev.kobj,
-                          &platform_attribute_group);
+       asus_sysfs_exit(asus);
        platform_device_unregister(asus->platform_device);
 }
 
@@ -1220,34 +1314,6 @@ static struct platform_driver platform_driver = {
        }
 };
 
-static void asus_laptop_add_fs(struct asus_laptop *asus)
-{
-       ASUS_SET_DEVICE_ATTR(infos, 0444, show_infos, NULL);
-
-       if (wl_switch_handle)
-               ASUS_SET_DEVICE_ATTR(wlan, 0644, show_wlan, store_wlan);
-
-       if (bt_switch_handle)
-               ASUS_SET_DEVICE_ATTR(bluetooth, 0644,
-                                    show_bluetooth, store_bluetooth);
-
-       if (display_set_handle && display_get_handle)
-               ASUS_SET_DEVICE_ATTR(display, 0644, show_disp, store_disp);
-       else if (display_set_handle)
-               ASUS_SET_DEVICE_ATTR(display, 0200, NULL, store_disp);
-
-       if (ledd_set_handle)
-               ASUS_SET_DEVICE_ATTR(ledd, 0644, show_ledd, store_ledd);
-
-       if (ls_switch_handle && ls_level_handle) {
-               ASUS_SET_DEVICE_ATTR(ls_level, 0644, show_lslvl, store_lslvl);
-               ASUS_SET_DEVICE_ATTR(ls_switch, 0644, show_lssw, store_lssw);
-       }
-
-       if (gps_status_handle && gps_on_handle && gps_off_handle)
-               ASUS_SET_DEVICE_ATTR(gps, 0644, show_gps, store_gps);
-}
-
 static int asus_handle_init(char *name, acpi_handle * handle,
                            char **paths, int num_paths)
 {
@@ -1308,8 +1374,8 @@ static int asus_laptop_get_info(struct asus_laptop *asus)
                       (uint) bsts_result);
 
        /* This too ... */
-       write_acpi_int(asus->handle, "CWAP", wapf);
-
+       if (write_acpi_int(asus->handle, "CWAP", wapf))
+               pr_err("Error calling CWAP(%d)\n", wapf);
        /*
         * Try to match the object returned by INIT to the specific model.
         * Handle every possible object (or the lack of thereof) the DSDT
@@ -1337,55 +1403,23 @@ static int asus_laptop_get_info(struct asus_laptop *asus)
        if (*string)
                pr_notice("  %s model detected\n", string);
 
-       ASUS_HANDLE_INIT(mled_set);
-       ASUS_HANDLE_INIT(tled_set);
-       ASUS_HANDLE_INIT(rled_set);
-       ASUS_HANDLE_INIT(pled_set);
-       ASUS_HANDLE_INIT(gled_set);
-
-       ASUS_HANDLE_INIT(ledd_set);
-
-       ASUS_HANDLE_INIT(kled_set);
-       ASUS_HANDLE_INIT(kled_get);
-
        /*
         * The HWRS method return informations about the hardware.
         * 0x80 bit is for WLAN, 0x100 for Bluetooth.
         * The significance of others is yet to be found.
-        * If we don't find the method, we assume the device are present.
         */
        status =
            acpi_evaluate_integer(asus->handle, "HRWS", NULL, &hwrs_result);
-       if (ACPI_FAILURE(status))
-               hwrs_result = WL_HWRS | BT_HWRS;
-
-       if (hwrs_result & WL_HWRS)
-               ASUS_HANDLE_INIT(wl_switch);
-       if (hwrs_result & BT_HWRS)
-               ASUS_HANDLE_INIT(bt_switch);
+       if (!ACPI_FAILURE(status))
+               pr_notice("  HRWS returned %x", (int)hwrs_result);
 
-       if (!ASUS_HANDLE_INIT(wireless_status))
+       if (!acpi_check_handle(asus->handle, METHOD_WL_STATUS, NULL))
                asus->have_rsts = true;
 
-       ASUS_HANDLE_INIT(brightness_set);
-       ASUS_HANDLE_INIT(brightness_get);
-
+       /* Scheduled for removal */
        ASUS_HANDLE_INIT(lcd_switch);
-
-       ASUS_HANDLE_INIT(display_set);
        ASUS_HANDLE_INIT(display_get);
 
-       /*
-        * There is a lot of models with "ALSL", but a few get
-        * a real light sens, so we need to check it.
-        */
-       if (!ASUS_HANDLE_INIT(ls_switch))
-               ASUS_HANDLE_INIT(ls_level);
-
-       ASUS_HANDLE_INIT(gps_on);
-       ASUS_HANDLE_INIT(gps_off);
-       ASUS_HANDLE_INIT(gps_status);
-
        kfree(model);
 
        return AE_OK;
@@ -1409,17 +1443,16 @@ static int __devinit asus_acpi_init(struct asus_laptop *asus)
        if (result)
                return result;
 
-       asus_laptop_add_fs(asus);
-
        /* WLED and BLED are on by default */
        if (bluetooth_status >= 0)
-               write_acpi_int(bt_switch_handle, NULL, !!bluetooth_status);
-       if (wireless_status >= 0)
-               write_acpi_int(wl_switch_handle, NULL, !!wireless_status);
+               asus_bluetooth_set(asus, !!bluetooth_status);
+
+       if (wlan_status >= 0)
+               asus_wlan_set(asus, !!wlan_status);
 
        /* Keyboard Backlight is on by default */
-       if (kled_set_handle)
-               set_kled_lvl(asus, 1);
+       if (!acpi_check_handle(asus->handle, METHOD_KBD_LIGHT_SET, NULL))
+               asus_kled_set(asus, 1);
 
        /* LED display is off by default */
        asus->ledd_status = 0xFFF;
@@ -1428,14 +1461,13 @@ static int __devinit asus_acpi_init(struct asus_laptop *asus)
        asus->light_switch = 0; /* Default to light sensor disabled */
        asus->light_level = 5;  /* level 5 for sensor sensitivity */
 
-       if (ls_switch_handle)
-               set_light_sens_switch(asus, asus->light_switch);
-
-       if (ls_level_handle)
-               set_light_sens_level(asus, asus->light_level);
+       if (!acpi_check_handle(asus->handle, METHOD_ALS_CONTROL, NULL) &&
+           !acpi_check_handle(asus->handle, METHOD_ALS_LEVEL, NULL)) {
+               asus_als_switch(asus, asus->light_switch);
+               asus_als_level(asus, asus->light_level);
+       }
 
-       /* GPS is on by default */
-       asus_gps_switch(asus, 1);
+       asus->lcd_state = 1; /* LCD should be on when the module load */
        return result;
 }
 
@@ -1482,9 +1514,15 @@ static int __devinit asus_acpi_add(struct acpi_device *device)
        if (result)
                goto fail_led;
 
+       result = asus_rfkill_init(asus);
+       if (result)
+               goto fail_rfkill;
+
        asus_device_present = true;
        return 0;
 
+fail_rfkill:
+       asus_led_exit(asus);
 fail_led:
        asus_input_exit(asus);
 fail_input:
@@ -1503,6 +1541,7 @@ static int asus_acpi_remove(struct acpi_device *device, int type)
        struct asus_laptop *asus = acpi_driver_data(device);
 
        asus_backlight_exit(asus);
+       asus_rfkill_exit(asus);
        asus_led_exit(asus);
        asus_input_exit(asus);
        asus_platform_exit(asus);