MSI: Consolidate MSI-X irq freeing code
[safe/jmp/linux-2.6] / drivers / pci / msi.c
index 01869b1..4f326f3 100644 (file)
@@ -68,6 +68,29 @@ static void msix_set_enable(struct pci_dev *dev, int enable)
        }
 }
 
+static void msix_flush_writes(unsigned int irq)
+{
+       struct msi_desc *entry;
+
+       entry = get_irq_msi(irq);
+       BUG_ON(!entry || !entry->dev);
+       switch (entry->msi_attrib.type) {
+       case PCI_CAP_ID_MSI:
+               /* nothing to do */
+               break;
+       case PCI_CAP_ID_MSIX:
+       {
+               int offset = entry->msi_attrib.entry_nr * PCI_MSIX_ENTRY_SIZE +
+                       PCI_MSIX_ENTRY_VECTOR_CTRL_OFFSET;
+               readl(entry->mask_base + offset);
+               break;
+       }
+       default:
+               BUG();
+               break;
+       }
+}
+
 static void msi_set_mask_bit(unsigned int irq, int flag)
 {
        struct msi_desc *entry;
@@ -94,12 +117,14 @@ static void msi_set_mask_bit(unsigned int irq, int flag)
                int offset = entry->msi_attrib.entry_nr * PCI_MSIX_ENTRY_SIZE +
                        PCI_MSIX_ENTRY_VECTOR_CTRL_OFFSET;
                writel(flag, entry->mask_base + offset);
+               readl(entry->mask_base + offset);
                break;
        }
        default:
                BUG();
                break;
        }
+       entry->msi_attrib.masked = !!flag;
 }
 
 void read_msi_msg(unsigned int irq, struct msi_msg *msg)
@@ -179,16 +204,19 @@ void write_msi_msg(unsigned int irq, struct msi_msg *msg)
        default:
                BUG();
        }
+       entry->msg = *msg;
 }
 
 void mask_msi_irq(unsigned int irq)
 {
        msi_set_mask_bit(irq, 1);
+       msix_flush_writes(irq);
 }
 
 void unmask_msi_irq(unsigned int irq)
 {
        msi_set_mask_bit(irq, 0);
+       msix_flush_writes(irq);
 }
 
 static int msi_free_irq(struct pci_dev* dev, int irq);
@@ -225,164 +253,60 @@ static struct msi_desc* alloc_msi_entry(void)
 }
 
 #ifdef CONFIG_PM
-static int __pci_save_msi_state(struct pci_dev *dev)
-{
-       int pos, i = 0;
-       u16 control;
-       struct pci_cap_saved_state *save_state;
-       u32 *cap;
-
-       if (!dev->msi_enabled)
-               return 0;
-
-       pos = pci_find_capability(dev, PCI_CAP_ID_MSI);
-       if (pos <= 0)
-               return 0;
-
-       save_state = kzalloc(sizeof(struct pci_cap_saved_state) + sizeof(u32) * 5,
-               GFP_KERNEL);
-       if (!save_state) {
-               printk(KERN_ERR "Out of memory in pci_save_msi_state\n");
-               return -ENOMEM;
-       }
-       cap = &save_state->data[0];
-
-       pci_read_config_dword(dev, pos, &cap[i++]);
-       control = cap[0] >> 16;
-       pci_read_config_dword(dev, pos + PCI_MSI_ADDRESS_LO, &cap[i++]);
-       if (control & PCI_MSI_FLAGS_64BIT) {
-               pci_read_config_dword(dev, pos + PCI_MSI_ADDRESS_HI, &cap[i++]);
-               pci_read_config_dword(dev, pos + PCI_MSI_DATA_64, &cap[i++]);
-       } else
-               pci_read_config_dword(dev, pos + PCI_MSI_DATA_32, &cap[i++]);
-       if (control & PCI_MSI_FLAGS_MASKBIT)
-               pci_read_config_dword(dev, pos + PCI_MSI_MASK_BIT, &cap[i++]);
-       save_state->cap_nr = PCI_CAP_ID_MSI;
-       pci_add_saved_cap(dev, save_state);
-       return 0;
-}
-
 static void __pci_restore_msi_state(struct pci_dev *dev)
 {
-       int i = 0, pos;
+       int pos;
        u16 control;
-       struct pci_cap_saved_state *save_state;
-       u32 *cap;
+       struct msi_desc *entry;
 
        if (!dev->msi_enabled)
                return;
 
-       save_state = pci_find_saved_cap(dev, PCI_CAP_ID_MSI);
-       pos = pci_find_capability(dev, PCI_CAP_ID_MSI);
-       if (!save_state || pos <= 0)
-               return;
-       cap = &save_state->data[0];
+       entry = get_irq_msi(dev->irq);
+       pos = entry->msi_attrib.pos;
 
        pci_intx(dev, 0);               /* disable intx */
-       control = cap[i++] >> 16;
        msi_set_enable(dev, 0);
-       pci_write_config_dword(dev, pos + PCI_MSI_ADDRESS_LO, cap[i++]);
-       if (control & PCI_MSI_FLAGS_64BIT) {
-               pci_write_config_dword(dev, pos + PCI_MSI_ADDRESS_HI, cap[i++]);
-               pci_write_config_dword(dev, pos + PCI_MSI_DATA_64, cap[i++]);
-       } else
-               pci_write_config_dword(dev, pos + PCI_MSI_DATA_32, cap[i++]);
-       if (control & PCI_MSI_FLAGS_MASKBIT)
-               pci_write_config_dword(dev, pos + PCI_MSI_MASK_BIT, cap[i++]);
+       write_msi_msg(dev->irq, &entry->msg);
+       if (entry->msi_attrib.maskbit)
+               msi_set_mask_bit(dev->irq, entry->msi_attrib.masked);
+
+       pci_read_config_word(dev, pos + PCI_MSI_FLAGS, &control);
+       control &= ~(PCI_MSI_FLAGS_QSIZE | PCI_MSI_FLAGS_ENABLE);
+       if (entry->msi_attrib.maskbit || !entry->msi_attrib.masked)
+               control |= PCI_MSI_FLAGS_ENABLE;
        pci_write_config_word(dev, pos + PCI_MSI_FLAGS, control);
-       pci_remove_saved_cap(save_state);
-       kfree(save_state);
-}
-
-static int __pci_save_msix_state(struct pci_dev *dev)
-{
-       int pos;
-       int irq, head, tail = 0;
-       u16 control;
-       struct pci_cap_saved_state *save_state;
-
-       if (!dev->msix_enabled)
-               return 0;
-
-       pos = pci_find_capability(dev, PCI_CAP_ID_MSIX);
-       if (pos <= 0)
-               return 0;
-
-       /* save the capability */
-       pci_read_config_word(dev, msi_control_reg(pos), &control);
-       save_state = kzalloc(sizeof(struct pci_cap_saved_state) + sizeof(u16),
-               GFP_KERNEL);
-       if (!save_state) {
-               printk(KERN_ERR "Out of memory in pci_save_msix_state\n");
-               return -ENOMEM;
-       }
-       *((u16 *)&save_state->data[0]) = control;
-
-       /* save the table */
-       irq = head = dev->first_msi_irq;
-       while (head != tail) {
-               struct msi_desc *entry;
-
-               entry = get_irq_msi(irq);
-               read_msi_msg(irq, &entry->msg_save);
-
-               tail = entry->link.tail;
-               irq = tail;
-       }
-
-       save_state->cap_nr = PCI_CAP_ID_MSIX;
-       pci_add_saved_cap(dev, save_state);
-       return 0;
-}
-
-int pci_save_msi_state(struct pci_dev *dev)
-{
-       int rc;
-
-       rc = __pci_save_msi_state(dev);
-       if (rc)
-               return rc;
-
-       rc = __pci_save_msix_state(dev);
-
-       return rc;
 }
 
 static void __pci_restore_msix_state(struct pci_dev *dev)
 {
-       u16 save;
        int pos;
        int irq, head, tail = 0;
        struct msi_desc *entry;
-       struct pci_cap_saved_state *save_state;
+       u16 control;
 
        if (!dev->msix_enabled)
                return;
 
-       save_state = pci_find_saved_cap(dev, PCI_CAP_ID_MSIX);
-       if (!save_state)
-               return;
-       save = *((u16 *)&save_state->data[0]);
-       pci_remove_saved_cap(save_state);
-       kfree(save_state);
-
-       pos = pci_find_capability(dev, PCI_CAP_ID_MSIX);
-       if (pos <= 0)
-               return;
-
        /* route the table */
        pci_intx(dev, 0);               /* disable intx */
        msix_set_enable(dev, 0);
        irq = head = dev->first_msi_irq;
+       entry = get_irq_msi(irq);
+       pos = entry->msi_attrib.pos;
        while (head != tail) {
                entry = get_irq_msi(irq);
-               write_msi_msg(irq, &entry->msg_save);
+               write_msi_msg(irq, &entry->msg);
+               msi_set_mask_bit(irq, entry->msi_attrib.masked);
 
                tail = entry->link.tail;
                irq = tail;
        }
 
-       pci_write_config_word(dev, msi_control_reg(pos), save);
+       pci_read_config_word(dev, pos + PCI_MSIX_FLAGS, &control);
+       control &= ~PCI_MSIX_FLAGS_MASKALL;
+       control |= PCI_MSIX_FLAGS_ENABLE;
+       pci_write_config_word(dev, pos + PCI_MSIX_FLAGS, control);
 }
 
 void pci_restore_msi_state(struct pci_dev *dev)
@@ -420,6 +344,7 @@ static int msi_capability_init(struct pci_dev *dev)
        entry->msi_attrib.is_64 = is_64bit_address(control);
        entry->msi_attrib.entry_nr = 0;
        entry->msi_attrib.maskbit = is_mask_bit_support(control);
+       entry->msi_attrib.masked = 1;
        entry->msi_attrib.default_irq = dev->irq;       /* Save IOAPIC IRQ */
        entry->msi_attrib.pos = pos;
        if (is_mask_bit_support(control)) {
@@ -507,6 +432,7 @@ static int msix_capability_init(struct pci_dev *dev,
                entry->msi_attrib.is_64 = 1;
                entry->msi_attrib.entry_nr = j;
                entry->msi_attrib.maskbit = 1;
+               entry->msi_attrib.masked = 1;
                entry->msi_attrib.default_irq = dev->irq;
                entry->msi_attrib.pos = pos;
                entry->dev = dev;
@@ -646,18 +572,15 @@ void pci_disable_msi(struct pci_dev* dev)
        if (!entry || !entry->dev || entry->msi_attrib.type != PCI_CAP_ID_MSI) {
                return;
        }
-       if (irq_has_action(dev->first_msi_irq)) {
-               printk(KERN_WARNING "PCI: %s: pci_disable_msi() called without "
-                      "free_irq() on MSI irq %d\n",
-                      pci_name(dev), dev->first_msi_irq);
-               BUG_ON(irq_has_action(dev->first_msi_irq));
-       } else {
-               default_irq = entry->msi_attrib.default_irq;
-               msi_free_irq(dev, dev->first_msi_irq);
 
-               /* Restore dev->irq to its default pin-assertion irq */
-               dev->irq = default_irq;
-       }
+       BUG_ON(irq_has_action(dev->first_msi_irq));
+
+       default_irq = entry->msi_attrib.default_irq;
+       msi_free_irq(dev, dev->first_msi_irq);
+
+       /* Restore dev->irq to its default pin-assertion irq */
+       dev->irq = default_irq;
+
        dev->first_msi_irq = 0;
 }
 
@@ -751,10 +674,26 @@ int pci_enable_msix(struct pci_dev* dev, struct msix_entry *entries, int nvec)
        return status;
 }
 
-void pci_disable_msix(struct pci_dev* dev)
+static void msix_free_all_irqs(struct pci_dev *dev)
 {
-       int irq, head, tail = 0, warning = 0;
+       int irq, head, tail = 0;
+
+       irq = head = dev->first_msi_irq;
+       while (head != tail) {
+               tail = get_irq_msi(irq)->link.tail;
 
+               BUG_ON(irq_has_action(irq));
+
+               if (irq != head)
+                       msi_free_irq(dev, irq);
+               irq = tail;
+       }
+       msi_free_irq(dev, irq);
+       dev->first_msi_irq = 0;
+}
+
+void pci_disable_msix(struct pci_dev* dev)
+{
        if (!pci_msi_enable)
                return;
        if (!dev)
@@ -767,23 +706,7 @@ void pci_disable_msix(struct pci_dev* dev)
        pci_intx(dev, 1);               /* enable intx */
        dev->msix_enabled = 0;
 
-       irq = head = dev->first_msi_irq;
-       while (head != tail) {
-               tail = get_irq_msi(irq)->link.tail;
-               if (irq_has_action(irq))
-                       warning = 1;
-               else if (irq != head)   /* Release MSI-X irq */
-                       msi_free_irq(dev, irq);
-               irq = tail;
-       }
-       msi_free_irq(dev, irq);
-       if (warning) {
-               printk(KERN_WARNING "PCI: %s: pci_disable_msix() called without "
-                       "free_irq() on all MSI-X irqs\n",
-                       pci_name(dev));
-               BUG_ON(warning > 0);
-       }
-       dev->first_msi_irq = 0;
+       msix_free_all_irqs(dev);
 }
 
 /**
@@ -801,37 +724,12 @@ void msi_remove_pci_irq_vectors(struct pci_dev* dev)
                return;
 
        if (dev->msi_enabled) {
-               if (irq_has_action(dev->first_msi_irq)) {
-                       printk(KERN_WARNING "PCI: %s: msi_remove_pci_irq_vectors() "
-                              "called without free_irq() on MSI irq %d\n",
-                              pci_name(dev), dev->first_msi_irq);
-                       BUG_ON(irq_has_action(dev->first_msi_irq));
-               } else /* Release MSI irq assigned to this device */
-                       msi_free_irq(dev, dev->first_msi_irq);
-       }
-       if (dev->msix_enabled) {
-               int irq, head, tail = 0, warning = 0;
-               void __iomem *base = NULL;
-
-               irq = head = dev->first_msi_irq;
-               while (head != tail) {
-                       tail = get_irq_msi(irq)->link.tail;
-                       base = get_irq_msi(irq)->mask_base;
-                       if (irq_has_action(irq))
-                               warning = 1;
-                       else if (irq != head) /* Release MSI-X irq */
-                               msi_free_irq(dev, irq);
-                       irq = tail;
-               }
-               msi_free_irq(dev, irq);
-               if (warning) {
-                       iounmap(base);
-                       printk(KERN_WARNING "PCI: %s: msi_remove_pci_irq_vectors() "
-                              "called without free_irq() on all MSI-X irqs\n",
-                              pci_name(dev));
-                       BUG_ON(warning > 0);
-               }
+               BUG_ON(irq_has_action(dev->first_msi_irq));
+               msi_free_irq(dev, dev->first_msi_irq);
        }
+
+       if (dev->msix_enabled)
+               msix_free_all_irqs(dev);
 }
 
 void pci_no_msi(void)