iwlwifi: fix *pci_probe error flow
[safe/jmp/linux-2.6] / drivers / net / wireless / iwlwifi / iwl-agn.c
index 5c6b3fe..18f6f68 100644 (file)
@@ -72,7 +72,7 @@
 #define VD
 #endif
 
-#ifdef CONFIG_IWLAGN_SPECTRUM_MEASUREMENT
+#ifdef CONFIG_IWLWIFI_SPECTRUM_MEASUREMENT
 #define VS "s"
 #else
 #define VS
@@ -94,66 +94,6 @@ MODULE_ALIAS("iwl4965");
 
 /**************************************************************/
 
-
-
-static void iwl_set_rxon_hwcrypto(struct iwl_priv *priv, int hw_decrypt)
-{
-       struct iwl_rxon_cmd *rxon = &priv->staging_rxon;
-
-       if (hw_decrypt)
-               rxon->filter_flags &= ~RXON_FILTER_DIS_DECRYPT_MSK;
-       else
-               rxon->filter_flags |= RXON_FILTER_DIS_DECRYPT_MSK;
-
-}
-
-/**
- * iwl_full_rxon_required - check if full RXON (vs RXON_ASSOC) cmd is needed
- * @priv: staging_rxon is compared to active_rxon
- *
- * If the RXON structure is changing enough to require a new tune,
- * or is clearing the RXON_FILTER_ASSOC_MSK, then return 1 to indicate that
- * a new tune (full RXON command, rather than RXON_ASSOC cmd) is required.
- */
-static int iwl_full_rxon_required(struct iwl_priv *priv)
-{
-
-       /* These items are only settable from the full RXON command */
-       if (!(iwl_is_associated(priv)) ||
-           compare_ether_addr(priv->staging_rxon.bssid_addr,
-                              priv->active_rxon.bssid_addr) ||
-           compare_ether_addr(priv->staging_rxon.node_addr,
-                              priv->active_rxon.node_addr) ||
-           compare_ether_addr(priv->staging_rxon.wlap_bssid_addr,
-                              priv->active_rxon.wlap_bssid_addr) ||
-           (priv->staging_rxon.dev_type != priv->active_rxon.dev_type) ||
-           (priv->staging_rxon.channel != priv->active_rxon.channel) ||
-           (priv->staging_rxon.air_propagation !=
-            priv->active_rxon.air_propagation) ||
-           (priv->staging_rxon.ofdm_ht_single_stream_basic_rates !=
-            priv->active_rxon.ofdm_ht_single_stream_basic_rates) ||
-           (priv->staging_rxon.ofdm_ht_dual_stream_basic_rates !=
-            priv->active_rxon.ofdm_ht_dual_stream_basic_rates) ||
-           (priv->staging_rxon.assoc_id != priv->active_rxon.assoc_id))
-               return 1;
-
-       /* flags, filter_flags, ofdm_basic_rates, and cck_basic_rates can
-        * be updated with the RXON_ASSOC command -- however only some
-        * flag transitions are allowed using RXON_ASSOC */
-
-       /* Check if we are not switching bands */
-       if ((priv->staging_rxon.flags & RXON_FLG_BAND_24G_MSK) !=
-           (priv->active_rxon.flags & RXON_FLG_BAND_24G_MSK))
-               return 1;
-
-       /* Check if we are switching association toggle */
-       if ((priv->staging_rxon.filter_flags & RXON_FILTER_ASSOC_MSK) !=
-               (priv->active_rxon.filter_flags & RXON_FILTER_ASSOC_MSK))
-               return 1;
-
-       return 0;
-}
-
 /**
  * iwl_commit_rxon - commit staging_rxon to hardware
  *
@@ -179,7 +119,7 @@ static int iwl_commit_rxon(struct iwl_priv *priv)
         * 5000, but will not damage 4965 */
        priv->staging_rxon.flags |= RXON_FLG_SELF_CTS_EN;
 
-       ret = iwl_agn_check_rxon_cmd(priv);
+       ret = iwl_check_rxon_cmd(priv);
        if (ret) {
                IWL_ERR(priv, "Invalid RXON configuration.  Not committing.\n");
                return -EINVAL;
@@ -207,7 +147,7 @@ static int iwl_commit_rxon(struct iwl_priv *priv)
         * we must clear the associated from the active configuration
         * before we apply the new config */
        if (iwl_is_associated(priv) && new_assoc) {
-               IWL_DEBUG_INFO("Toggling associated bit on current RXON\n");
+               IWL_DEBUG_INFO(priv, "Toggling associated bit on current RXON\n");
                active_rxon->filter_flags &= ~RXON_FILTER_ASSOC_MSK;
 
                ret = iwl_send_cmd_pdu(priv, REPLY_RXON,
@@ -223,7 +163,7 @@ static int iwl_commit_rxon(struct iwl_priv *priv)
                }
        }
 
-       IWL_DEBUG_INFO("Sending RXON\n"
+       IWL_DEBUG_INFO(priv, "Sending RXON\n"
                       "* with%s RXON_FILTER_ASSOC_MSK\n"
                       "* channel = %d\n"
                       "* bssid = %pM\n",
@@ -310,25 +250,11 @@ void iwl_update_chain_flags(struct iwl_priv *priv)
        iwl_commit_rxon(priv);
 }
 
-static int iwl_send_bt_config(struct iwl_priv *priv)
-{
-       struct iwl_bt_cmd bt_cmd = {
-               .flags = 3,
-               .lead_time = 0xAA,
-               .max_kill = 1,
-               .kill_ack_mask = 0,
-               .kill_cts_mask = 0,
-       };
-
-       return iwl_send_cmd_pdu(priv, REPLY_BT_CONFIG,
-                               sizeof(struct iwl_bt_cmd), &bt_cmd);
-}
-
 static void iwl_clear_free_frames(struct iwl_priv *priv)
 {
        struct list_head *element;
 
-       IWL_DEBUG_INFO("%d frames on pre-allocated heap on clear.\n",
+       IWL_DEBUG_INFO(priv, "%d frames on pre-allocated heap on clear.\n",
                       priv->frames_count);
 
        while (!list_empty(&priv->free_frames)) {
@@ -388,31 +314,6 @@ static unsigned int iwl_fill_beacon_frame(struct iwl_priv *priv,
        return priv->ibss_beacon->len;
 }
 
-static u8 iwl_rate_get_lowest_plcp(struct iwl_priv *priv)
-{
-       int i;
-       int rate_mask;
-
-       /* Set rate mask*/
-       if (priv->staging_rxon.flags & RXON_FLG_BAND_24G_MSK)
-               rate_mask = priv->active_rate_basic & IWL_CCK_RATES_MASK;
-       else
-               rate_mask = priv->active_rate_basic & IWL_OFDM_RATES_MASK;
-
-       /* Find lowest valid rate */
-       for (i = IWL_RATE_1M_INDEX; i != IWL_RATE_INVALID;
-                                       i = iwl_rates[i].next_ieee) {
-               if (rate_mask & (1 << i))
-                       return iwl_rates[i].plcp;
-       }
-
-       /* No valid rate was found. Assign the lowest one */
-       if (priv->staging_rxon.flags & RXON_FLG_BAND_24G_MSK)
-               return IWL_RATE_1M_PLCP;
-       else
-               return IWL_RATE_6M_PLCP;
-}
-
 static unsigned int iwl_hw_get_beacon_cmd(struct iwl_priv *priv,
                                       struct iwl_frame *frame, u8 rate)
 {
@@ -543,7 +444,7 @@ void iwl_hw_txq_free_tfd(struct iwl_priv *priv, struct iwl_tx_queue *txq)
                pci_unmap_single(dev,
                                pci_unmap_addr(&txq->cmd[index]->meta, mapping),
                                pci_unmap_len(&txq->cmd[index]->meta, len),
-                               PCI_DMA_TODEVICE);
+                               PCI_DMA_BIDIRECTIONAL);
 
        /* Unmap chunks, if any. */
        for (i = 1; i < num_tbs; i++) {
@@ -637,7 +538,7 @@ static void iwl_ht_conf(struct iwl_priv *priv,
        struct iwl_ht_info *iwl_conf = &priv->current_ht_config;
        struct ieee80211_sta *sta;
 
-       IWL_DEBUG_MAC80211("enter: \n");
+       IWL_DEBUG_MAC80211(priv, "enter: \n");
 
        if (!iwl_conf->is_ht)
                return;
@@ -697,7 +598,7 @@ static void iwl_ht_conf(struct iwl_priv *priv,
 
        rcu_read_unlock();
 
-       IWL_DEBUG_MAC80211("leave\n");
+       IWL_DEBUG_MAC80211(priv, "leave\n");
 }
 
 /*
@@ -722,7 +623,7 @@ static void iwl_activate_qos(struct iwl_priv *priv, u8 force)
                priv->qos_data.def_qos_parm.qos_flags |= QOS_PARAM_FLG_TGN_MSK;
 
        if (force || iwl_is_associated(priv)) {
-               IWL_DEBUG_QOS("send QoS cmd with Qos active=%d FLAGS=0x%X\n",
+               IWL_DEBUG_QOS(priv, "send QoS cmd with Qos active=%d FLAGS=0x%X\n",
                                priv->qos_data.qos_active,
                                priv->qos_data.def_qos_parm.qos_flags);
 
@@ -743,6 +644,9 @@ static u16 iwl_adjust_beacon_interval(u16 beacon_val)
                                        / MAX_UCODE_BEACON_INTERVAL;
        new_val = beacon_val / beacon_factor;
 
+       if (!new_val)
+               new_val = MAX_UCODE_BEACON_INTERVAL;
+
        return new_val;
 }
 
@@ -779,117 +683,16 @@ static void iwl_setup_rxon_timing(struct iwl_priv *priv)
        priv->rxon_timing.beacon_init_val = cpu_to_le32(interval_tm - rem);
 
        spin_unlock_irqrestore(&priv->lock, flags);
-       IWL_DEBUG_ASSOC("beacon interval %d beacon timer %d beacon tim %d\n",
+       IWL_DEBUG_ASSOC(priv, "beacon interval %d beacon timer %d beacon tim %d\n",
                        le16_to_cpu(priv->rxon_timing.beacon_interval),
                        le32_to_cpu(priv->rxon_timing.beacon_init_val),
                        le16_to_cpu(priv->rxon_timing.atim_window));
 }
 
-static void iwl_set_flags_for_band(struct iwl_priv *priv,
-                                  enum ieee80211_band band)
-{
-       if (band == IEEE80211_BAND_5GHZ) {
-               priv->staging_rxon.flags &=
-                   ~(RXON_FLG_BAND_24G_MSK | RXON_FLG_AUTO_DETECT_MSK
-                     | RXON_FLG_CCK_MSK);
-               priv->staging_rxon.flags |= RXON_FLG_SHORT_SLOT_MSK;
-       } else {
-               /* Copied from iwl_post_associate() */
-               if (priv->assoc_capability & WLAN_CAPABILITY_SHORT_SLOT_TIME)
-                       priv->staging_rxon.flags |= RXON_FLG_SHORT_SLOT_MSK;
-               else
-                       priv->staging_rxon.flags &= ~RXON_FLG_SHORT_SLOT_MSK;
-
-               if (priv->iw_mode == NL80211_IFTYPE_ADHOC)
-                       priv->staging_rxon.flags &= ~RXON_FLG_SHORT_SLOT_MSK;
-
-               priv->staging_rxon.flags |= RXON_FLG_BAND_24G_MSK;
-               priv->staging_rxon.flags |= RXON_FLG_AUTO_DETECT_MSK;
-               priv->staging_rxon.flags &= ~RXON_FLG_CCK_MSK;
-       }
-}
-
-/*
- * initialize rxon structure with default values from eeprom
- */
-static void iwl_connection_init_rx_config(struct iwl_priv *priv, int mode)
-{
-       const struct iwl_channel_info *ch_info;
-
-       memset(&priv->staging_rxon, 0, sizeof(priv->staging_rxon));
-
-       switch (mode) {
-       case NL80211_IFTYPE_AP:
-               priv->staging_rxon.dev_type = RXON_DEV_TYPE_AP;
-               break;
-
-       case NL80211_IFTYPE_STATION:
-               priv->staging_rxon.dev_type = RXON_DEV_TYPE_ESS;
-               priv->staging_rxon.filter_flags = RXON_FILTER_ACCEPT_GRP_MSK;
-               break;
-
-       case NL80211_IFTYPE_ADHOC:
-               priv->staging_rxon.dev_type = RXON_DEV_TYPE_IBSS;
-               priv->staging_rxon.flags = RXON_FLG_SHORT_PREAMBLE_MSK;
-               priv->staging_rxon.filter_flags = RXON_FILTER_BCON_AWARE_MSK |
-                                                 RXON_FILTER_ACCEPT_GRP_MSK;
-               break;
-
-       case NL80211_IFTYPE_MONITOR:
-               priv->staging_rxon.dev_type = RXON_DEV_TYPE_SNIFFER;
-               priv->staging_rxon.filter_flags = RXON_FILTER_PROMISC_MSK |
-                   RXON_FILTER_CTL2HOST_MSK | RXON_FILTER_ACCEPT_GRP_MSK;
-               break;
-       default:
-               IWL_ERR(priv, "Unsupported interface type %d\n", mode);
-               break;
-       }
-
-#if 0
-       /* TODO:  Figure out when short_preamble would be set and cache from
-        * that */
-       if (!hw_to_local(priv->hw)->short_preamble)
-               priv->staging_rxon.flags &= ~RXON_FLG_SHORT_PREAMBLE_MSK;
-       else
-               priv->staging_rxon.flags |= RXON_FLG_SHORT_PREAMBLE_MSK;
-#endif
-
-       ch_info = iwl_get_channel_info(priv, priv->band,
-                                      le16_to_cpu(priv->active_rxon.channel));
-
-       if (!ch_info)
-               ch_info = &priv->channel_info[0];
-
-       /*
-        * in some case A channels are all non IBSS
-        * in this case force B/G channel
-        */
-       if ((priv->iw_mode == NL80211_IFTYPE_ADHOC) &&
-           !(is_channel_ibss(ch_info)))
-               ch_info = &priv->channel_info[0];
-
-       priv->staging_rxon.channel = cpu_to_le16(ch_info->channel);
-       priv->band = ch_info->band;
-
-       iwl_set_flags_for_band(priv, priv->band);
-
-       priv->staging_rxon.ofdm_basic_rates =
-           (IWL_OFDM_RATES_MASK >> IWL_FIRST_OFDM_RATE) & 0xFF;
-       priv->staging_rxon.cck_basic_rates =
-           (IWL_CCK_RATES_MASK >> IWL_FIRST_CCK_RATE) & 0xF;
-
-       priv->staging_rxon.flags &= ~(RXON_FLG_CHANNEL_MODE_MIXED_MSK |
-                                       RXON_FLG_CHANNEL_MODE_PURE_40_MSK);
-       memcpy(priv->staging_rxon.node_addr, priv->mac_addr, ETH_ALEN);
-       memcpy(priv->staging_rxon.wlap_bssid_addr, priv->mac_addr, ETH_ALEN);
-       priv->staging_rxon.ofdm_ht_single_stream_basic_rates = 0xff;
-       priv->staging_rxon.ofdm_ht_dual_stream_basic_rates = 0xff;
-       iwl_set_rxon_chain(priv);
-}
-
 static int iwl_set_mode(struct iwl_priv *priv, int mode)
 {
        iwl_connection_init_rx_config(priv, mode);
+       iwl_set_rxon_chain(priv);
        memcpy(priv->staging_rxon.node_addr, priv->mac_addr, ETH_ALEN);
 
        iwl_clear_stations_table(priv);
@@ -901,7 +704,7 @@ static int iwl_set_mode(struct iwl_priv *priv, int mode)
        cancel_delayed_work(&priv->scan_check);
        if (iwl_scan_cancel_timeout(priv, 100)) {
                IWL_WARN(priv, "Aborted scan still in progress after 100ms\n");
-               IWL_DEBUG_MAC80211("leaving - scan abort failed.\n");
+               IWL_DEBUG_MAC80211(priv, "leaving - scan abort failed.\n");
                return -EAGAIN;
        }
 
@@ -910,54 +713,6 @@ static int iwl_set_mode(struct iwl_priv *priv, int mode)
        return 0;
 }
 
-static void iwl_set_rate(struct iwl_priv *priv)
-{
-       const struct ieee80211_supported_band *hw = NULL;
-       struct ieee80211_rate *rate;
-       int i;
-
-       hw = iwl_get_hw_mode(priv, priv->band);
-       if (!hw) {
-               IWL_ERR(priv, "Failed to set rate: unable to get hw mode\n");
-               return;
-       }
-
-       priv->active_rate = 0;
-       priv->active_rate_basic = 0;
-
-       for (i = 0; i < hw->n_bitrates; i++) {
-               rate = &(hw->bitrates[i]);
-               if (rate->hw_value < IWL_RATE_COUNT)
-                       priv->active_rate |= (1 << rate->hw_value);
-       }
-
-       IWL_DEBUG_RATE("Set active_rate = %0x, active_rate_basic = %0x\n",
-                      priv->active_rate, priv->active_rate_basic);
-
-       /*
-        * If a basic rate is configured, then use it (adding IWL_RATE_1M_MASK)
-        * otherwise set it to the default of all CCK rates and 6, 12, 24 for
-        * OFDM
-        */
-       if (priv->active_rate_basic & IWL_CCK_BASIC_RATES_MASK)
-               priv->staging_rxon.cck_basic_rates =
-                   ((priv->active_rate_basic &
-                     IWL_CCK_RATES_MASK) >> IWL_FIRST_CCK_RATE) & 0xF;
-       else
-               priv->staging_rxon.cck_basic_rates =
-                   (IWL_CCK_BASIC_RATES_MASK >> IWL_FIRST_CCK_RATE) & 0xF;
-
-       if (priv->active_rate_basic & IWL_OFDM_BASIC_RATES_MASK)
-               priv->staging_rxon.ofdm_basic_rates =
-                   ((priv->active_rate_basic &
-                     (IWL_OFDM_BASIC_RATES_MASK | IWL_RATE_6M_MASK)) >>
-                     IWL_FIRST_OFDM_RATE) & 0xFF;
-       else
-               priv->staging_rxon.ofdm_basic_rates =
-                  (IWL_OFDM_BASIC_RATES_MASK >> IWL_FIRST_OFDM_RATE) & 0xFF;
-}
-
-
 /******************************************************************************
  *
  * Generic RX handler implementations
@@ -972,19 +727,19 @@ static void iwl_rx_reply_alive(struct iwl_priv *priv,
 
        palive = &pkt->u.alive_frame;
 
-       IWL_DEBUG_INFO("Alive ucode status 0x%08X revision "
+       IWL_DEBUG_INFO(priv, "Alive ucode status 0x%08X revision "
                       "0x%01X 0x%01X\n",
                       palive->is_valid, palive->ver_type,
                       palive->ver_subtype);
 
        if (palive->ver_subtype == INITIALIZE_SUBTYPE) {
-               IWL_DEBUG_INFO("Initialization Alive received.\n");
+               IWL_DEBUG_INFO(priv, "Initialization Alive received.\n");
                memcpy(&priv->card_alive_init,
                       &pkt->u.alive_frame,
                       sizeof(struct iwl_init_alive_resp));
                pwork = &priv->init_alive_start;
        } else {
-               IWL_DEBUG_INFO("Runtime Alive received.\n");
+               IWL_DEBUG_INFO(priv, "Runtime Alive received.\n");
                memcpy(&priv->card_alive, &pkt->u.alive_frame,
                       sizeof(struct iwl_alive_resp));
                pwork = &priv->alive_start;
@@ -999,54 +754,6 @@ static void iwl_rx_reply_alive(struct iwl_priv *priv,
                IWL_WARN(priv, "uCode did not respond OK.\n");
 }
 
-static void iwl_rx_reply_error(struct iwl_priv *priv,
-                                  struct iwl_rx_mem_buffer *rxb)
-{
-       struct iwl_rx_packet *pkt = (struct iwl_rx_packet *)rxb->skb->data;
-
-       IWL_ERR(priv, "Error Reply type 0x%08X cmd %s (0x%02X) "
-               "seq 0x%04X ser 0x%08X\n",
-               le32_to_cpu(pkt->u.err_resp.error_type),
-               get_cmd_string(pkt->u.err_resp.cmd_id),
-               pkt->u.err_resp.cmd_id,
-               le16_to_cpu(pkt->u.err_resp.bad_cmd_seq_num),
-               le32_to_cpu(pkt->u.err_resp.error_info));
-}
-
-#define TX_STATUS_ENTRY(x) case TX_STATUS_FAIL_ ## x: return #x
-
-static void iwl_rx_csa(struct iwl_priv *priv, struct iwl_rx_mem_buffer *rxb)
-{
-       struct iwl_rx_packet *pkt = (struct iwl_rx_packet *)rxb->skb->data;
-       struct iwl_rxon_cmd *rxon = (void *)&priv->active_rxon;
-       struct iwl_csa_notification *csa = &(pkt->u.csa_notif);
-       IWL_DEBUG_11H("CSA notif: channel %d, status %d\n",
-                     le16_to_cpu(csa->channel), le32_to_cpu(csa->status));
-       rxon->channel = csa->channel;
-       priv->staging_rxon.channel = csa->channel;
-}
-
-static void iwl_rx_pm_sleep_notif(struct iwl_priv *priv,
-                                     struct iwl_rx_mem_buffer *rxb)
-{
-#ifdef CONFIG_IWLWIFI_DEBUG
-       struct iwl_rx_packet *pkt = (struct iwl_rx_packet *)rxb->skb->data;
-       struct iwl_sleep_notification *sleep = &(pkt->u.sleep_notif);
-       IWL_DEBUG_RX("sleep mode: %d, src: %d\n",
-                    sleep->pm_sleep_mode, sleep->pm_wakeup_src);
-#endif
-}
-
-static void iwl_rx_pm_debug_statistics_notif(struct iwl_priv *priv,
-                                            struct iwl_rx_mem_buffer *rxb)
-{
-       struct iwl_rx_packet *pkt = (struct iwl_rx_packet *)rxb->skb->data;
-       IWL_DEBUG_RADIO("Dumping %d bytes of unhandled "
-                       "notification for %s:\n",
-                       le32_to_cpu(pkt->len), get_cmd_string(pkt->hdr.cmd));
-       iwl_print_hex_dump(priv, IWL_DL_RADIO, pkt->u.raw, le32_to_cpu(pkt->len));
-}
-
 static void iwl_bg_beacon_update(struct work_struct *work)
 {
        struct iwl_priv *priv =
@@ -1105,7 +812,7 @@ static void iwl_rx_beacon_notif(struct iwl_priv *priv,
                (struct iwl4965_beacon_notif *)pkt->u.raw;
        u8 rate = iwl_hw_get_rate(beacon->beacon_notify_hdr.rate_n_flags);
 
-       IWL_DEBUG_RX("beacon status %x retries %d iss %d "
+       IWL_DEBUG_RX(priv, "beacon status %x retries %d iss %d "
                "tsf %d %d rate %d\n",
                le32_to_cpu(beacon->beacon_notify_hdr.u.status) & TX_STATUS_MSK,
                beacon->beacon_notify_hdr.failure_frame,
@@ -1128,7 +835,7 @@ static void iwl_rx_card_state_notif(struct iwl_priv *priv,
        u32 flags = le32_to_cpu(pkt->u.card_state_notif.flags);
        unsigned long status = priv->status;
 
-       IWL_DEBUG_RF_KILL("Card state received: HW:%s SW:%s\n",
+       IWL_DEBUG_RF_KILL(priv, "Card state received: HW:%s SW:%s\n",
                          (flags & HW_CARD_DISABLED) ? "Kill" : "On",
                          (flags & SW_CARD_DISABLED) ? "Kill" : "On");
 
@@ -1201,11 +908,7 @@ int iwl_set_pwr_src(struct iwl_priv *priv, enum iwl_pwr_src src)
                goto err;
 
        if (src == IWL_PWR_SRC_VAUX) {
-               u32 val;
-               ret = pci_read_config_dword(priv->pci_dev, PCI_CFG_POWER_SOURCE,
-                                           &val);
-
-               if (val & PCI_CFG_PMC_PME_FROM_D3COLD_SUPPORT)
+               if (pci_pme_capable(priv->pci_dev, PCI_D3cold))
                        iwl_set_bits_mask_prph(priv, APMG_PS_CTRL_REG,
                                               APMG_PS_CTRL_VAL_PWR_SRC_VAUX,
                                               ~APMG_PS_CTRL_MSK_PWR_SRC);
@@ -1290,7 +993,7 @@ void iwl_rx_handle(struct iwl_priv *priv)
 
        /* Rx interrupt, but nothing sent from uCode */
        if (i == r)
-               IWL_DEBUG(IWL_DL_RX, "r = %d, i = %d\n", r, i);
+               IWL_DEBUG_RX(priv, "r = %d, i = %d\n", r, i);
 
        if (iwl_rx_queue_space(rxq) > (RX_QUEUE_SIZE / 2))
                fill_rx = 1;
@@ -1330,12 +1033,12 @@ void iwl_rx_handle(struct iwl_priv *priv)
                 *   handle those that need handling via function in
                 *   rx_handlers table.  See iwl_setup_rx_handlers() */
                if (priv->rx_handlers[pkt->hdr.cmd]) {
-                       IWL_DEBUG(IWL_DL_RX, "r = %d, i = %d, %s, 0x%02x\n", r,
+                       IWL_DEBUG_RX(priv, "r = %d, i = %d, %s, 0x%02x\n", r,
                                i, get_cmd_string(pkt->hdr.cmd), pkt->hdr.cmd);
                        priv->rx_handlers[pkt->hdr.cmd] (priv, rxb);
                } else {
                        /* No handling needed */
-                       IWL_DEBUG(IWL_DL_RX,
+                       IWL_DEBUG_RX(priv,
                                "r %d i %d No handler needed for %s, 0x%02x\n",
                                r, i, get_cmd_string(pkt->hdr.cmd),
                                pkt->hdr.cmd);
@@ -1384,27 +1087,6 @@ void iwl_rx_handle(struct iwl_priv *priv)
        iwl_rx_queue_restock(priv);
 }
 
-#ifdef CONFIG_IWLWIFI_DEBUG
-static void iwl_print_rx_config_cmd(struct iwl_priv *priv)
-{
-       struct iwl_rxon_cmd *rxon = &priv->staging_rxon;
-
-       IWL_DEBUG_RADIO("RX CONFIG:\n");
-       iwl_print_hex_dump(priv, IWL_DL_RADIO, (u8 *) rxon, sizeof(*rxon));
-       IWL_DEBUG_RADIO("u16 channel: 0x%x\n", le16_to_cpu(rxon->channel));
-       IWL_DEBUG_RADIO("u32 flags: 0x%08X\n", le32_to_cpu(rxon->flags));
-       IWL_DEBUG_RADIO("u32 filter_flags: 0x%08x\n",
-                       le32_to_cpu(rxon->filter_flags));
-       IWL_DEBUG_RADIO("u8 dev_type: 0x%x\n", rxon->dev_type);
-       IWL_DEBUG_RADIO("u8 ofdm_basic_rates: 0x%02x\n",
-                       rxon->ofdm_basic_rates);
-       IWL_DEBUG_RADIO("u8 cck_basic_rates: 0x%02x\n", rxon->cck_basic_rates);
-       IWL_DEBUG_RADIO("u8[6] node_addr: %pM\n", rxon->node_addr);
-       IWL_DEBUG_RADIO("u8[6] bssid_addr: %pM\n", rxon->bssid_addr);
-       IWL_DEBUG_RADIO("u16 assoc_id: 0x%x\n", le16_to_cpu(rxon->assoc_id));
-}
-#endif
-
 /* call this function to flush any scheduled tasklet */
 static inline void iwl_synchronize_irq(struct iwl_priv *priv)
 {
@@ -1413,45 +1095,6 @@ static inline void iwl_synchronize_irq(struct iwl_priv *priv)
        tasklet_kill(&priv->irq_tasklet);
 }
 
-/**
- * iwl_irq_handle_error - called for HW or SW error interrupt from card
- */
-static void iwl_irq_handle_error(struct iwl_priv *priv)
-{
-       /* Set the FW error flag -- cleared on iwl_down */
-       set_bit(STATUS_FW_ERROR, &priv->status);
-
-       /* Cancel currently queued command. */
-       clear_bit(STATUS_HCMD_ACTIVE, &priv->status);
-
-#ifdef CONFIG_IWLWIFI_DEBUG
-       if (priv->debug_level & IWL_DL_FW_ERRORS) {
-               iwl_dump_nic_error_log(priv);
-               iwl_dump_nic_event_log(priv);
-               iwl_print_rx_config_cmd(priv);
-       }
-#endif
-
-       wake_up_interruptible(&priv->wait_command_queue);
-
-       /* Keep the restart process from trying to send host
-        * commands by clearing the INIT status bit */
-       clear_bit(STATUS_READY, &priv->status);
-
-       if (!test_bit(STATUS_EXIT_PENDING, &priv->status)) {
-               IWL_DEBUG(IWL_DL_FW_ERRORS,
-                         "Restarting adapter due to uCode error.\n");
-
-               if (iwl_is_associated(priv)) {
-                       memcpy(&priv->recovery_rxon, &priv->active_rxon,
-                              sizeof(priv->recovery_rxon));
-                       priv->error_recovering = 1;
-               }
-               if (priv->cfg->mod_params->restart_fw)
-                       queue_work(priv->workqueue, &priv->restart);
-       }
-}
-
 static void iwl_error_recovery(struct iwl_priv *priv)
 {
        unsigned long flags;
@@ -1496,7 +1139,7 @@ static void iwl_irq_tasklet(struct iwl_priv *priv)
        if (priv->debug_level & IWL_DL_ISR) {
                /* just for debug */
                inta_mask = iwl_read32(priv, CSR_INT_MASK);
-               IWL_DEBUG_ISR("inta 0x%08x, enabled 0x%08x, fh 0x%08x\n",
+               IWL_DEBUG_ISR(priv, "inta 0x%08x, enabled 0x%08x, fh 0x%08x\n",
                              inta, inta_mask, inta_fh);
        }
 #endif
@@ -1530,12 +1173,12 @@ static void iwl_irq_tasklet(struct iwl_priv *priv)
        if (priv->debug_level & (IWL_DL_ISR)) {
                /* NIC fires this, but we don't use it, redundant with WAKEUP */
                if (inta & CSR_INT_BIT_SCD)
-                       IWL_DEBUG_ISR("Scheduler finished to transmit "
+                       IWL_DEBUG_ISR(priv, "Scheduler finished to transmit "
                                      "the frame/frames.\n");
 
                /* Alive notification via Rx interrupt will do the real work */
                if (inta & CSR_INT_BIT_ALIVE)
-                       IWL_DEBUG_ISR("Alive interrupt\n");
+                       IWL_DEBUG_ISR(priv, "Alive interrupt\n");
        }
 #endif
        /* Safely ignore these bits for debug checks below */
@@ -1548,7 +1191,7 @@ static void iwl_irq_tasklet(struct iwl_priv *priv)
                                CSR_GP_CNTRL_REG_FLAG_HW_RF_KILL_SW))
                        hw_rf_kill = 1;
 
-               IWL_DEBUG(IWL_DL_RF_KILL, "RF_KILL bit toggled to %s.\n",
+               IWL_DEBUG_RF_KILL(priv, "RF_KILL bit toggled to %s.\n",
                                hw_rf_kill ? "disable radio" : "enable radio");
 
                /* driver only loads ucode once setting the interface up.
@@ -1583,7 +1226,7 @@ static void iwl_irq_tasklet(struct iwl_priv *priv)
 
        /* uCode wakes up after power-down sleep */
        if (inta & CSR_INT_BIT_WAKEUP) {
-               IWL_DEBUG_ISR("Wakeup interrupt\n");
+               IWL_DEBUG_ISR(priv, "Wakeup interrupt\n");
                iwl_rx_queue_update_write_ptr(priv, &priv->rxq);
                iwl_txq_update_write_ptr(priv, &priv->txq[0]);
                iwl_txq_update_write_ptr(priv, &priv->txq[1]);
@@ -1604,7 +1247,7 @@ static void iwl_irq_tasklet(struct iwl_priv *priv)
        }
 
        if (inta & CSR_INT_BIT_FH_TX) {
-               IWL_DEBUG_ISR("Tx interrupt\n");
+               IWL_DEBUG_ISR(priv, "Tx interrupt\n");
                handled |= CSR_INT_BIT_FH_TX;
                /* FH finished to write, send event */
                priv->ucode_write_complete = 1;
@@ -1630,71 +1273,13 @@ static void iwl_irq_tasklet(struct iwl_priv *priv)
                inta = iwl_read32(priv, CSR_INT);
                inta_mask = iwl_read32(priv, CSR_INT_MASK);
                inta_fh = iwl_read32(priv, CSR_FH_INT_STATUS);
-               IWL_DEBUG_ISR("End inta 0x%08x, enabled 0x%08x, fh 0x%08x, "
+               IWL_DEBUG_ISR(priv, "End inta 0x%08x, enabled 0x%08x, fh 0x%08x, "
                        "flags 0x%08lx\n", inta, inta_mask, inta_fh, flags);
        }
 #endif
        spin_unlock_irqrestore(&priv->lock, flags);
 }
 
-static irqreturn_t iwl_isr(int irq, void *data)
-{
-       struct iwl_priv *priv = data;
-       u32 inta, inta_mask;
-       u32 inta_fh;
-       if (!priv)
-               return IRQ_NONE;
-
-       spin_lock(&priv->lock);
-
-       /* Disable (but don't clear!) interrupts here to avoid
-        *    back-to-back ISRs and sporadic interrupts from our NIC.
-        * If we have something to service, the tasklet will re-enable ints.
-        * If we *don't* have something, we'll re-enable before leaving here. */
-       inta_mask = iwl_read32(priv, CSR_INT_MASK);  /* just for debug */
-       iwl_write32(priv, CSR_INT_MASK, 0x00000000);
-
-       /* Discover which interrupts are active/pending */
-       inta = iwl_read32(priv, CSR_INT);
-       inta_fh = iwl_read32(priv, CSR_FH_INT_STATUS);
-
-       /* Ignore interrupt if there's nothing in NIC to service.
-        * This may be due to IRQ shared with another device,
-        * or due to sporadic interrupts thrown from our NIC. */
-       if (!inta && !inta_fh) {
-               IWL_DEBUG_ISR("Ignore interrupt, inta == 0, inta_fh == 0\n");
-               goto none;
-       }
-
-       if ((inta == 0xFFFFFFFF) || ((inta & 0xFFFFFFF0) == 0xa5a5a5a0)) {
-               /* Hardware disappeared. It might have already raised
-                * an interrupt */
-               IWL_WARN(priv, "HARDWARE GONE?? INTA == 0x%08x\n", inta);
-               goto unplugged;
-       }
-
-       IWL_DEBUG_ISR("ISR inta 0x%08x, enabled 0x%08x, fh 0x%08x\n",
-                     inta, inta_mask, inta_fh);
-
-       inta &= ~CSR_INT_BIT_SCD;
-
-       /* iwl_irq_tasklet() will service interrupts and re-enable them */
-       if (likely(inta || inta_fh))
-               tasklet_schedule(&priv->irq_tasklet);
-
- unplugged:
-       spin_unlock(&priv->lock);
-       return IRQ_HANDLED;
-
- none:
-       /* re-enable interrupts here since we don't have anything to service. */
-       /* only Re-enable if diabled by irq */
-       if (test_bit(STATUS_INT_ENABLED, &priv->status))
-               iwl_enable_interrupts(priv);
-       spin_unlock(&priv->lock);
-       return IRQ_NONE;
-}
-
 /******************************************************************************
  *
  * uCode download functions
@@ -1755,7 +1340,7 @@ static int iwl_read_ucode(struct iwl_priv *priv)
                                        "Please use API v%u instead.\n",
                                          buf, api_max);
 
-                       IWL_DEBUG_INFO("Got firmware '%s' file (%zd bytes) from disk\n",
+                       IWL_DEBUG_INFO(priv, "Got firmware '%s' file (%zd bytes) from disk\n",
                                       buf, ucode_raw->size);
                        break;
                }
@@ -1806,17 +1391,17 @@ static int iwl_read_ucode(struct iwl_priv *priv)
               IWL_UCODE_API(priv->ucode_ver),
               IWL_UCODE_SERIAL(priv->ucode_ver));
 
-       IWL_DEBUG_INFO("f/w package hdr ucode version raw = 0x%x\n",
+       IWL_DEBUG_INFO(priv, "f/w package hdr ucode version raw = 0x%x\n",
                       priv->ucode_ver);
-       IWL_DEBUG_INFO("f/w package hdr runtime inst size = %u\n",
+       IWL_DEBUG_INFO(priv, "f/w package hdr runtime inst size = %u\n",
                       inst_size);
-       IWL_DEBUG_INFO("f/w package hdr runtime data size = %u\n",
+       IWL_DEBUG_INFO(priv, "f/w package hdr runtime data size = %u\n",
                       data_size);
-       IWL_DEBUG_INFO("f/w package hdr init inst size = %u\n",
+       IWL_DEBUG_INFO(priv, "f/w package hdr init inst size = %u\n",
                       init_size);
-       IWL_DEBUG_INFO("f/w package hdr init data size = %u\n",
+       IWL_DEBUG_INFO(priv, "f/w package hdr init data size = %u\n",
                       init_data_size);
-       IWL_DEBUG_INFO("f/w package hdr boot inst size = %u\n",
+       IWL_DEBUG_INFO(priv, "f/w package hdr boot inst size = %u\n",
                       boot_size);
 
        /* Verify size of file vs. image size info in file's header */
@@ -1824,7 +1409,7 @@ static int iwl_read_ucode(struct iwl_priv *priv)
                inst_size + data_size + init_size +
                init_data_size + boot_size) {
 
-               IWL_DEBUG_INFO("uCode file size %d too small\n",
+               IWL_DEBUG_INFO(priv, "uCode file size %d too small\n",
                               (int)ucode_raw->size);
                ret = -EINVAL;
                goto err_release;
@@ -1832,36 +1417,33 @@ static int iwl_read_ucode(struct iwl_priv *priv)
 
        /* Verify that uCode images will fit in card's SRAM */
        if (inst_size > priv->hw_params.max_inst_size) {
-               IWL_DEBUG_INFO("uCode instr len %d too large to fit in\n",
+               IWL_DEBUG_INFO(priv, "uCode instr len %d too large to fit in\n",
                               inst_size);
                ret = -EINVAL;
                goto err_release;
        }
 
        if (data_size > priv->hw_params.max_data_size) {
-               IWL_DEBUG_INFO("uCode data len %d too large to fit in\n",
+               IWL_DEBUG_INFO(priv, "uCode data len %d too large to fit in\n",
                                data_size);
                ret = -EINVAL;
                goto err_release;
        }
        if (init_size > priv->hw_params.max_inst_size) {
-               IWL_DEBUG_INFO
-                   ("uCode init instr len %d too large to fit in\n",
-                     init_size);
+               IWL_INFO(priv, "uCode init instr len %d too large to fit in\n",
+                       init_size);
                ret = -EINVAL;
                goto err_release;
        }
        if (init_data_size > priv->hw_params.max_data_size) {
-               IWL_DEBUG_INFO
-                   ("uCode init data len %d too large to fit in\n",
+               IWL_INFO(priv, "uCode init data len %d too large to fit in\n",
                      init_data_size);
                ret = -EINVAL;
                goto err_release;
        }
        if (boot_size > priv->hw_params.max_bsm_size) {
-               IWL_DEBUG_INFO
-                   ("uCode boot instr len %d too large to fit in\n",
-                     boot_size);
+               IWL_INFO(priv, "uCode boot instr len %d too large to fit in\n",
+                       boot_size);
                ret = -EINVAL;
                goto err_release;
        }
@@ -1880,6 +1462,10 @@ static int iwl_read_ucode(struct iwl_priv *priv)
        priv->ucode_data_backup.len = data_size;
        iwl_alloc_fw_desc(priv->pci_dev, &priv->ucode_data_backup);
 
+       if (!priv->ucode_code.v_addr || !priv->ucode_data.v_addr ||
+           !priv->ucode_data_backup.v_addr)
+               goto err_pci_alloc;
+
        /* Initialization instructions and data */
        if (init_size && init_data_size) {
                priv->ucode_init.len = init_size;
@@ -1906,16 +1492,16 @@ static int iwl_read_ucode(struct iwl_priv *priv)
        /* Runtime instructions (first block of data in file) */
        src = &ucode->data[0];
        len = priv->ucode_code.len;
-       IWL_DEBUG_INFO("Copying (but not loading) uCode instr len %Zd\n", len);
+       IWL_DEBUG_INFO(priv, "Copying (but not loading) uCode instr len %Zd\n", len);
        memcpy(priv->ucode_code.v_addr, src, len);
-       IWL_DEBUG_INFO("uCode instr buf vaddr = 0x%p, paddr = 0x%08x\n",
+       IWL_DEBUG_INFO(priv, "uCode instr buf vaddr = 0x%p, paddr = 0x%08x\n",
                priv->ucode_code.v_addr, (u32)priv->ucode_code.p_addr);
 
        /* Runtime data (2nd block)
         * NOTE:  Copy into backup buffer will be done in iwl_up()  */
        src = &ucode->data[inst_size];
        len = priv->ucode_data.len;
-       IWL_DEBUG_INFO("Copying (but not loading) uCode data len %Zd\n", len);
+       IWL_DEBUG_INFO(priv, "Copying (but not loading) uCode data len %Zd\n", len);
        memcpy(priv->ucode_data.v_addr, src, len);
        memcpy(priv->ucode_data_backup.v_addr, src, len);
 
@@ -1923,7 +1509,7 @@ static int iwl_read_ucode(struct iwl_priv *priv)
        if (init_size) {
                src = &ucode->data[inst_size + data_size];
                len = priv->ucode_init.len;
-               IWL_DEBUG_INFO("Copying (but not loading) init instr len %Zd\n",
+               IWL_DEBUG_INFO(priv, "Copying (but not loading) init instr len %Zd\n",
                                len);
                memcpy(priv->ucode_init.v_addr, src, len);
        }
@@ -1932,7 +1518,7 @@ static int iwl_read_ucode(struct iwl_priv *priv)
        if (init_data_size) {
                src = &ucode->data[inst_size + data_size + init_size];
                len = priv->ucode_init_data.len;
-               IWL_DEBUG_INFO("Copying (but not loading) init data len %Zd\n",
+               IWL_DEBUG_INFO(priv, "Copying (but not loading) init data len %Zd\n",
                               len);
                memcpy(priv->ucode_init_data.v_addr, src, len);
        }
@@ -1940,7 +1526,7 @@ static int iwl_read_ucode(struct iwl_priv *priv)
        /* Bootstrap instructions (5th block) */
        src = &ucode->data[inst_size + data_size + init_size + init_data_size];
        len = priv->ucode_boot.len;
-       IWL_DEBUG_INFO("Copying (but not loading) boot instr len %Zd\n", len);
+       IWL_DEBUG_INFO(priv, "Copying (but not loading) boot instr len %Zd\n", len);
        memcpy(priv->ucode_boot.v_addr, src, len);
 
        /* We have our copies now, allow OS release its copies */
@@ -1972,12 +1558,12 @@ static void iwl_alive_start(struct iwl_priv *priv)
 {
        int ret = 0;
 
-       IWL_DEBUG_INFO("Runtime Alive received.\n");
+       IWL_DEBUG_INFO(priv, "Runtime Alive received.\n");
 
        if (priv->card_alive.is_valid != UCODE_VALID_OK) {
                /* We had an error bringing up the hardware, so take it
                 * all the way back down so we can try again */
-               IWL_DEBUG_INFO("Alive failed.\n");
+               IWL_DEBUG_INFO(priv, "Alive failed.\n");
                goto restart;
        }
 
@@ -1987,7 +1573,7 @@ static void iwl_alive_start(struct iwl_priv *priv)
        if (iwl_verify_ucode(priv)) {
                /* Runtime instruction load was bad;
                 * take it all the way back down so we can try again */
-               IWL_DEBUG_INFO("Bad runtime uCode load.\n");
+               IWL_DEBUG_INFO(priv, "Bad runtime uCode load.\n");
                goto restart;
        }
 
@@ -2020,6 +1606,7 @@ static void iwl_alive_start(struct iwl_priv *priv)
        } else {
                /* Initialize our rx_config data */
                iwl_connection_init_rx_config(priv, priv->iw_mode);
+               iwl_set_rxon_chain(priv);
                memcpy(priv->staging_rxon.node_addr, priv->mac_addr, ETH_ALEN);
        }
 
@@ -2036,7 +1623,7 @@ static void iwl_alive_start(struct iwl_priv *priv)
 
        iwl_leds_register(priv);
 
-       IWL_DEBUG_INFO("ALIVE processing complete.\n");
+       IWL_DEBUG_INFO(priv, "ALIVE processing complete.\n");
        set_bit(STATUS_READY, &priv->status);
        wake_up_interruptible(&priv->wait_command_queue);
 
@@ -2070,7 +1657,7 @@ static void __iwl_down(struct iwl_priv *priv)
        unsigned long flags;
        int exit_pending = test_bit(STATUS_EXIT_PENDING, &priv->status);
 
-       IWL_DEBUG_INFO(DRV_NAME " is going down\n");
+       IWL_DEBUG_INFO(priv, DRV_NAME " is going down\n");
 
        if (!exit_pending)
                set_bit(STATUS_EXIT_PENDING, &priv->status);
@@ -2251,7 +1838,7 @@ static int __iwl_up(struct iwl_priv *priv)
                /* start card; "initialize" will load runtime ucode */
                iwl_nic_start(priv);
 
-               IWL_DEBUG_INFO(DRV_NAME " is coming up\n");
+               IWL_DEBUG_INFO(priv, DRV_NAME " is coming up\n");
 
                return 0;
        }
@@ -2372,7 +1959,7 @@ static void iwl_post_associate(struct iwl_priv *priv)
                return;
        }
 
-       IWL_DEBUG_ASSOC("Associated as %d to: %pM\n",
+       IWL_DEBUG_ASSOC(priv, "Associated as %d to: %pM\n",
                        priv->assoc_id, priv->active_rxon.bssid_addr);
 
 
@@ -2405,7 +1992,7 @@ static void iwl_post_associate(struct iwl_priv *priv)
        iwl_set_rxon_chain(priv);
        priv->staging_rxon.assoc_id = cpu_to_le16(priv->assoc_id);
 
-       IWL_DEBUG_ASSOC("assoc id %d beacon interval %d\n",
+       IWL_DEBUG_ASSOC(priv, "assoc id %d beacon interval %d\n",
                        priv->assoc_id, priv->beacon_int);
 
        if (priv->assoc_capability & WLAN_CAPABILITY_SHORT_PREAMBLE)
@@ -2478,7 +2065,7 @@ static int iwl_mac_start(struct ieee80211_hw *hw)
        struct iwl_priv *priv = hw->priv;
        int ret;
 
-       IWL_DEBUG_MAC80211("enter\n");
+       IWL_DEBUG_MAC80211(priv, "enter\n");
 
        /* we should be verifying the device is ready to be opened */
        mutex_lock(&priv->mutex);
@@ -2508,7 +2095,7 @@ static int iwl_mac_start(struct ieee80211_hw *hw)
        if (iwl_is_rfkill(priv))
                goto out;
 
-       IWL_DEBUG_INFO("Start UP work done.\n");
+       IWL_DEBUG_INFO(priv, "Start UP work done.\n");
 
        if (test_bit(STATUS_IN_SUSPEND, &priv->status))
                return 0;
@@ -2528,7 +2115,7 @@ static int iwl_mac_start(struct ieee80211_hw *hw)
 
 out:
        priv->is_open = 1;
-       IWL_DEBUG_MAC80211("leave\n");
+       IWL_DEBUG_MAC80211(priv, "leave\n");
        return 0;
 }
 
@@ -2536,10 +2123,10 @@ static void iwl_mac_stop(struct ieee80211_hw *hw)
 {
        struct iwl_priv *priv = hw->priv;
 
-       IWL_DEBUG_MAC80211("enter\n");
+       IWL_DEBUG_MAC80211(priv, "enter\n");
 
        if (!priv->is_open) {
-               IWL_DEBUG_MAC80211("leave - skip\n");
+               IWL_DEBUG_MAC80211(priv, "leave - skip\n");
                return;
        }
 
@@ -2562,22 +2149,22 @@ static void iwl_mac_stop(struct ieee80211_hw *hw)
        iwl_write32(priv, CSR_INT, 0xFFFFFFFF);
        iwl_enable_interrupts(priv);
 
-       IWL_DEBUG_MAC80211("leave\n");
+       IWL_DEBUG_MAC80211(priv, "leave\n");
 }
 
 static int iwl_mac_tx(struct ieee80211_hw *hw, struct sk_buff *skb)
 {
        struct iwl_priv *priv = hw->priv;
 
-       IWL_DEBUG_MACDUMP("enter\n");
+       IWL_DEBUG_MACDUMP(priv, "enter\n");
 
-       IWL_DEBUG_TX("dev->xmit(%d bytes) at rate 0x%02x\n", skb->len,
+       IWL_DEBUG_TX(priv, "dev->xmit(%d bytes) at rate 0x%02x\n", skb->len,
                     ieee80211_get_tx_rate(hw, IEEE80211_SKB_CB(skb))->bitrate);
 
        if (iwl_tx_skb(priv, skb))
                dev_kfree_skb_any(skb);
 
-       IWL_DEBUG_MACDUMP("leave\n");
+       IWL_DEBUG_MACDUMP(priv, "leave\n");
        return NETDEV_TX_OK;
 }
 
@@ -2587,10 +2174,10 @@ static int iwl_mac_add_interface(struct ieee80211_hw *hw,
        struct iwl_priv *priv = hw->priv;
        unsigned long flags;
 
-       IWL_DEBUG_MAC80211("enter: type %d\n", conf->type);
+       IWL_DEBUG_MAC80211(priv, "enter: type %d\n", conf->type);
 
        if (priv->vif) {
-               IWL_DEBUG_MAC80211("leave - vif != NULL\n");
+               IWL_DEBUG_MAC80211(priv, "leave - vif != NULL\n");
                return -EOPNOTSUPP;
        }
 
@@ -2603,7 +2190,7 @@ static int iwl_mac_add_interface(struct ieee80211_hw *hw,
        mutex_lock(&priv->mutex);
 
        if (conf->mac_addr) {
-               IWL_DEBUG_MAC80211("Set %pM\n", conf->mac_addr);
+               IWL_DEBUG_MAC80211(priv, "Set %pM\n", conf->mac_addr);
                memcpy(priv->mac_addr, conf->mac_addr, ETH_ALEN);
        }
 
@@ -2613,7 +2200,7 @@ static int iwl_mac_add_interface(struct ieee80211_hw *hw,
 
        mutex_unlock(&priv->mutex);
 
-       IWL_DEBUG_MAC80211("leave\n");
+       IWL_DEBUG_MAC80211(priv, "leave\n");
        return 0;
 }
 
@@ -2634,12 +2221,12 @@ static int iwl_mac_config(struct ieee80211_hw *hw, u32 changed)
        u16 channel;
 
        mutex_lock(&priv->mutex);
-       IWL_DEBUG_MAC80211("enter to channel %d\n", conf->channel->hw_value);
+       IWL_DEBUG_MAC80211(priv, "enter to channel %d\n", conf->channel->hw_value);
 
        priv->current_ht_config.is_ht = conf_is_ht(conf);
 
        if (conf->radio_enabled && iwl_radio_kill_sw_enable_radio(priv)) {
-               IWL_DEBUG_MAC80211("leave - RF-KILL - waiting for uCode\n");
+               IWL_DEBUG_MAC80211(priv, "leave - RF-KILL - waiting for uCode\n");
                goto out;
        }
 
@@ -2647,14 +2234,14 @@ static int iwl_mac_config(struct ieee80211_hw *hw, u32 changed)
                iwl_radio_kill_sw_disable_radio(priv);
 
        if (!iwl_is_ready(priv)) {
-               IWL_DEBUG_MAC80211("leave - not ready\n");
+               IWL_DEBUG_MAC80211(priv, "leave - not ready\n");
                ret = -EIO;
                goto out;
        }
 
        if (unlikely(!priv->cfg->mod_params->disable_hw_scan &&
                     test_bit(STATUS_SCANNING, &priv->status))) {
-               IWL_DEBUG_MAC80211("leave - scanning\n");
+               IWL_DEBUG_MAC80211(priv, "leave - scanning\n");
                mutex_unlock(&priv->mutex);
                return 0;
        }
@@ -2662,7 +2249,7 @@ static int iwl_mac_config(struct ieee80211_hw *hw, u32 changed)
        channel = ieee80211_frequency_to_channel(conf->channel->center_freq);
        ch_info = iwl_get_channel_info(priv, conf->channel->band, channel);
        if (!is_channel_valid(ch_info)) {
-               IWL_DEBUG_MAC80211("leave - invalid channel\n");
+               IWL_DEBUG_MAC80211(priv, "leave - invalid channel\n");
                ret = -EINVAL;
                goto out;
        }
@@ -2707,12 +2294,12 @@ static int iwl_mac_config(struct ieee80211_hw *hw, u32 changed)
 #endif
 
        if (!conf->radio_enabled) {
-               IWL_DEBUG_MAC80211("leave - radio disabled\n");
+               IWL_DEBUG_MAC80211(priv, "leave - radio disabled\n");
                goto out;
        }
 
        if (iwl_is_rfkill(priv)) {
-               IWL_DEBUG_MAC80211("leave - RF kill\n");
+               IWL_DEBUG_MAC80211(priv, "leave - RF kill\n");
                ret = -EIO;
                goto out;
        }
@@ -2722,9 +2309,9 @@ static int iwl_mac_config(struct ieee80211_hw *hw, u32 changed)
        else
                ret = iwl_power_set_user_mode(priv, IWL_POWER_MODE_CAM);
        if (ret)
-               IWL_DEBUG_MAC80211("Error setting power level\n");
+               IWL_DEBUG_MAC80211(priv, "Error setting power level\n");
 
-       IWL_DEBUG_MAC80211("TX Power old=%d new=%d\n",
+       IWL_DEBUG_MAC80211(priv, "TX Power old=%d new=%d\n",
                           priv->tx_power_user_lmt, conf->power_level);
 
        iwl_set_tx_power(priv, conf->power_level, false);
@@ -2738,9 +2325,9 @@ static int iwl_mac_config(struct ieee80211_hw *hw, u32 changed)
                   &priv->staging_rxon, sizeof(priv->staging_rxon)))
                iwl_commit_rxon(priv);
        else
-               IWL_DEBUG_INFO("No re-sending same RXON configuration.\n");
+               IWL_DEBUG_INFO(priv, "No re-sending same RXON configuration.\n");
 
-       IWL_DEBUG_MAC80211("leave\n");
+       IWL_DEBUG_MAC80211(priv, "leave\n");
 
 out:
        mutex_unlock(&priv->mutex);
@@ -2821,7 +2408,7 @@ static int iwl_mac_config_interface(struct ieee80211_hw *hw,
                return -EIO;
 
        if (priv->vif != vif) {
-               IWL_DEBUG_MAC80211("leave - priv->vif != vif\n");
+               IWL_DEBUG_MAC80211(priv, "leave - priv->vif != vif\n");
                return 0;
        }
 
@@ -2843,7 +2430,7 @@ static int iwl_mac_config_interface(struct ieee80211_hw *hw,
        mutex_lock(&priv->mutex);
 
        if (conf->bssid)
-               IWL_DEBUG_MAC80211("bssid: %pM\n", conf->bssid);
+               IWL_DEBUG_MAC80211(priv, "bssid: %pM\n", conf->bssid);
 
 /*
  * very dubious code was here; the probe filtering flag is never set:
@@ -2856,7 +2443,7 @@ static int iwl_mac_config_interface(struct ieee80211_hw *hw,
                if (!conf->bssid) {
                        conf->bssid = priv->mac_addr;
                        memcpy(priv->bssid, priv->mac_addr, ETH_ALEN);
-                       IWL_DEBUG_MAC80211("bssid was set to: %pM\n",
+                       IWL_DEBUG_MAC80211(priv, "bssid was set to: %pM\n",
                                           conf->bssid);
                }
                if (priv->ibss_beacon)
@@ -2875,7 +2462,7 @@ static int iwl_mac_config_interface(struct ieee80211_hw *hw,
                if (iwl_scan_cancel_timeout(priv, 100)) {
                        IWL_WARN(priv, "Aborted scan still in progress "
                                    "after 100ms\n");
-                       IWL_DEBUG_MAC80211("leaving - scan abort failed.\n");
+                       IWL_DEBUG_MAC80211(priv, "leaving - scan abort failed.\n");
                        mutex_unlock(&priv->mutex);
                        return -EAGAIN;
                }
@@ -2903,64 +2490,18 @@ static int iwl_mac_config_interface(struct ieee80211_hw *hw,
        }
 
  done:
-       IWL_DEBUG_MAC80211("leave\n");
+       IWL_DEBUG_MAC80211(priv, "leave\n");
        mutex_unlock(&priv->mutex);
 
        return 0;
 }
 
-static void iwl_configure_filter(struct ieee80211_hw *hw,
-                                unsigned int changed_flags,
-                                unsigned int *total_flags,
-                                int mc_count, struct dev_addr_list *mc_list)
-{
-       struct iwl_priv *priv = hw->priv;
-       __le32 *filter_flags = &priv->staging_rxon.filter_flags;
-
-       IWL_DEBUG_MAC80211("Enter: changed: 0x%x, total: 0x%x\n",
-                       changed_flags, *total_flags);
-
-       if (changed_flags & (FIF_OTHER_BSS | FIF_PROMISC_IN_BSS)) {
-               if (*total_flags & (FIF_OTHER_BSS | FIF_PROMISC_IN_BSS))
-                       *filter_flags |= RXON_FILTER_PROMISC_MSK;
-               else
-                       *filter_flags &= ~RXON_FILTER_PROMISC_MSK;
-       }
-       if (changed_flags & FIF_ALLMULTI) {
-               if (*total_flags & FIF_ALLMULTI)
-                       *filter_flags |= RXON_FILTER_ACCEPT_GRP_MSK;
-               else
-                       *filter_flags &= ~RXON_FILTER_ACCEPT_GRP_MSK;
-       }
-       if (changed_flags & FIF_CONTROL) {
-               if (*total_flags & FIF_CONTROL)
-                       *filter_flags |= RXON_FILTER_CTL2HOST_MSK;
-               else
-                       *filter_flags &= ~RXON_FILTER_CTL2HOST_MSK;
-       }
-       if (changed_flags & FIF_BCN_PRBRESP_PROMISC) {
-               if (*total_flags & FIF_BCN_PRBRESP_PROMISC)
-                       *filter_flags |= RXON_FILTER_BCON_AWARE_MSK;
-               else
-                       *filter_flags &= ~RXON_FILTER_BCON_AWARE_MSK;
-       }
-
-       /* We avoid iwl_commit_rxon here to commit the new filter flags
-        * since mac80211 will call ieee80211_hw_config immediately.
-        * (mc_list is not supported at this time). Otherwise, we need to
-        * queue a background iwl_commit_rxon work.
-        */
-
-       *total_flags &= FIF_OTHER_BSS | FIF_ALLMULTI | FIF_PROMISC_IN_BSS |
-                       FIF_BCN_PRBRESP_PROMISC | FIF_CONTROL;
-}
-
 static void iwl_mac_remove_interface(struct ieee80211_hw *hw,
                                     struct ieee80211_if_init_conf *conf)
 {
        struct iwl_priv *priv = hw->priv;
 
-       IWL_DEBUG_MAC80211("enter\n");
+       IWL_DEBUG_MAC80211(priv, "enter\n");
 
        mutex_lock(&priv->mutex);
 
@@ -2975,7 +2516,7 @@ static void iwl_mac_remove_interface(struct ieee80211_hw *hw,
        }
        mutex_unlock(&priv->mutex);
 
-       IWL_DEBUG_MAC80211("leave\n");
+       IWL_DEBUG_MAC80211(priv, "leave\n");
 
 }
 
@@ -2987,10 +2528,10 @@ static void iwl_bss_info_changed(struct ieee80211_hw *hw,
 {
        struct iwl_priv *priv = hw->priv;
 
-       IWL_DEBUG_MAC80211("changes = 0x%X\n", changes);
+       IWL_DEBUG_MAC80211(priv, "changes = 0x%X\n", changes);
 
        if (changes & BSS_CHANGED_ERP_PREAMBLE) {
-               IWL_DEBUG_MAC80211("ERP_PREAMBLE %d\n",
+               IWL_DEBUG_MAC80211(priv, "ERP_PREAMBLE %d\n",
                                   bss_conf->use_short_preamble);
                if (bss_conf->use_short_preamble)
                        priv->staging_rxon.flags |= RXON_FLG_SHORT_PREAMBLE_MSK;
@@ -2999,7 +2540,7 @@ static void iwl_bss_info_changed(struct ieee80211_hw *hw,
        }
 
        if (changes & BSS_CHANGED_ERP_CTS_PROT) {
-               IWL_DEBUG_MAC80211("ERP_CTS %d\n", bss_conf->use_cts_prot);
+               IWL_DEBUG_MAC80211(priv, "ERP_CTS %d\n", bss_conf->use_cts_prot);
                if (bss_conf->use_cts_prot && (priv->band != IEEE80211_BAND_5GHZ))
                        priv->staging_rxon.flags |= RXON_FLG_TGG_PROTECT_MSK;
                else
@@ -3012,7 +2553,7 @@ static void iwl_bss_info_changed(struct ieee80211_hw *hw,
        }
 
        if (changes & BSS_CHANGED_ASSOC) {
-               IWL_DEBUG_MAC80211("ASSOC %d\n", bss_conf->assoc);
+               IWL_DEBUG_MAC80211(priv, "ASSOC %d\n", bss_conf->assoc);
                /* This should never happen as this function should
                 * never be called from interrupt context. */
                if (WARN_ON_ONCE(in_interrupt()))
@@ -3034,83 +2575,26 @@ static void iwl_bss_info_changed(struct ieee80211_hw *hw,
                        mutex_unlock(&priv->mutex);
                } else {
                        priv->assoc_id = 0;
-                       IWL_DEBUG_MAC80211("DISASSOC %d\n", bss_conf->assoc);
+                       IWL_DEBUG_MAC80211(priv, "DISASSOC %d\n", bss_conf->assoc);
                }
        } else if (changes && iwl_is_associated(priv) && priv->assoc_id) {
-                       IWL_DEBUG_MAC80211("Associated Changes %d\n", changes);
+                       IWL_DEBUG_MAC80211(priv, "Associated Changes %d\n", changes);
                        iwl_send_rxon_assoc(priv);
        }
 
 }
 
-static int iwl_mac_hw_scan(struct ieee80211_hw *hw, u8 *ssid, size_t ssid_len)
-{
-       unsigned long flags;
-       struct iwl_priv *priv = hw->priv;
-       int ret;
-
-       IWL_DEBUG_MAC80211("enter\n");
-
-       mutex_lock(&priv->mutex);
-       spin_lock_irqsave(&priv->lock, flags);
-
-       if (!iwl_is_ready_rf(priv)) {
-               ret = -EIO;
-               IWL_DEBUG_MAC80211("leave - not ready or exit pending\n");
-               goto out_unlock;
-       }
-
-       /* We don't schedule scan within next_scan_jiffies period.
-        * Avoid scanning during possible EAPOL exchange, return
-        * success immediately.
-        */
-       if (priv->next_scan_jiffies &&
-           time_after(priv->next_scan_jiffies, jiffies)) {
-               IWL_DEBUG_SCAN("scan rejected: within next scan period\n");
-               queue_work(priv->workqueue, &priv->scan_completed);
-               ret = 0;
-               goto out_unlock;
-       }
-
-       /* if we just finished scan ask for delay */
-       if (iwl_is_associated(priv) && priv->last_scan_jiffies &&
-           time_after(priv->last_scan_jiffies + IWL_DELAY_NEXT_SCAN, jiffies)) {
-               IWL_DEBUG_SCAN("scan rejected: within previous scan period\n");
-               queue_work(priv->workqueue, &priv->scan_completed);
-               ret = 0;
-               goto out_unlock;
-       }
-
-       if (ssid_len) {
-               priv->one_direct_scan = 1;
-               priv->direct_ssid_len =  min_t(u8, ssid_len, IW_ESSID_MAX_SIZE);
-               memcpy(priv->direct_ssid, ssid, priv->direct_ssid_len);
-       } else {
-               priv->one_direct_scan = 0;
-       }
-
-       ret = iwl_scan_initiate(priv);
-
-       IWL_DEBUG_MAC80211("leave\n");
-
-out_unlock:
-       spin_unlock_irqrestore(&priv->lock, flags);
-       mutex_unlock(&priv->mutex);
-
-       return ret;
-}
-
 static void iwl_mac_update_tkip_key(struct ieee80211_hw *hw,
                        struct ieee80211_key_conf *keyconf, const u8 *addr,
                        u32 iv32, u16 *phase1key)
 {
 
        struct iwl_priv *priv = hw->priv;
-       IWL_DEBUG_MAC80211("enter\n");
+       IWL_DEBUG_MAC80211(priv, "enter\n");
 
        iwl_update_tkip_key(priv, keyconf, addr, iv32, phase1key);
 
-       IWL_DEBUG_MAC80211("leave\n");
+       IWL_DEBUG_MAC80211(priv, "leave\n");
 }
 
 static int iwl_mac_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd,
@@ -3124,16 +2608,16 @@ static int iwl_mac_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd,
        u8 sta_id;
        bool is_default_wep_key = false;
 
-       IWL_DEBUG_MAC80211("enter\n");
+       IWL_DEBUG_MAC80211(priv, "enter\n");
 
        if (priv->hw_params.sw_crypto) {
-               IWL_DEBUG_MAC80211("leave - hwcrypto disabled\n");
+               IWL_DEBUG_MAC80211(priv, "leave - hwcrypto disabled\n");
                return -EOPNOTSUPP;
        }
        addr = sta ? sta->addr : iwl_bcast_addr;
        sta_id = iwl_find_station(priv, addr);
        if (sta_id == IWL_INVALID_STATION) {
-               IWL_DEBUG_MAC80211("leave - %pM not in station map.\n",
+               IWL_DEBUG_MAC80211(priv, "leave - %pM not in station map.\n",
                                   addr);
                return -EINVAL;
 
@@ -3163,7 +2647,7 @@ static int iwl_mac_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd,
                else
                        ret = iwl_set_dynamic_key(priv, key, sta_id);
 
-               IWL_DEBUG_MAC80211("enable hwcrypto key\n");
+               IWL_DEBUG_MAC80211(priv, "enable hwcrypto key\n");
                break;
        case DISABLE_KEY:
                if (is_default_wep_key)
@@ -3171,13 +2655,13 @@ static int iwl_mac_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd,
                else
                        ret = iwl_remove_dynamic_key(priv, key, sta_id);
 
-               IWL_DEBUG_MAC80211("disable hwcrypto key\n");
+               IWL_DEBUG_MAC80211(priv, "disable hwcrypto key\n");
                break;
        default:
                ret = -EINVAL;
        }
 
-       IWL_DEBUG_MAC80211("leave\n");
+       IWL_DEBUG_MAC80211(priv, "leave\n");
 
        return ret;
 }
@@ -3189,15 +2673,15 @@ static int iwl_mac_conf_tx(struct ieee80211_hw *hw, u16 queue,
        unsigned long flags;
        int q;
 
-       IWL_DEBUG_MAC80211("enter\n");
+       IWL_DEBUG_MAC80211(priv, "enter\n");
 
        if (!iwl_is_ready_rf(priv)) {
-               IWL_DEBUG_MAC80211("leave - RF not ready\n");
+               IWL_DEBUG_MAC80211(priv, "leave - RF not ready\n");
                return -EIO;
        }
 
        if (queue >= AC_NUM) {
-               IWL_DEBUG_MAC80211("leave - queue >= AC_NUM %d\n", queue);
+               IWL_DEBUG_MAC80211(priv, "leave - queue >= AC_NUM %d\n", queue);
                return 0;
        }
 
@@ -3221,7 +2705,7 @@ static int iwl_mac_conf_tx(struct ieee80211_hw *hw, u16 queue,
 
        spin_unlock_irqrestore(&priv->lock, flags);
 
-       IWL_DEBUG_MAC80211("leave\n");
+       IWL_DEBUG_MAC80211(priv, "leave\n");
        return 0;
 }
 
@@ -3231,7 +2715,7 @@ static int iwl_mac_ampdu_action(struct ieee80211_hw *hw,
 {
        struct iwl_priv *priv = hw->priv;
 
-       IWL_DEBUG_HT("A-MPDU action on addr %pM tid %d\n",
+       IWL_DEBUG_HT(priv, "A-MPDU action on addr %pM tid %d\n",
                     sta->addr, tid);
 
        if (!(priv->cfg->sku & IWL_SKU_N))
@@ -3239,19 +2723,19 @@ static int iwl_mac_ampdu_action(struct ieee80211_hw *hw,
 
        switch (action) {
        case IEEE80211_AMPDU_RX_START:
-               IWL_DEBUG_HT("start Rx\n");
+               IWL_DEBUG_HT(priv, "start Rx\n");
                return iwl_sta_rx_agg_start(priv, sta->addr, tid, *ssn);
        case IEEE80211_AMPDU_RX_STOP:
-               IWL_DEBUG_HT("stop Rx\n");
+               IWL_DEBUG_HT(priv, "stop Rx\n");
                return iwl_sta_rx_agg_stop(priv, sta->addr, tid);
        case IEEE80211_AMPDU_TX_START:
-               IWL_DEBUG_HT("start Tx\n");
+               IWL_DEBUG_HT(priv, "start Tx\n");
                return iwl_tx_agg_start(priv, sta->addr, tid, ssn);
        case IEEE80211_AMPDU_TX_STOP:
-               IWL_DEBUG_HT("stop Tx\n");
+               IWL_DEBUG_HT(priv, "stop Tx\n");
                return iwl_tx_agg_stop(priv, sta->addr, tid);
        default:
-               IWL_DEBUG_HT("unknown\n");
+               IWL_DEBUG_HT(priv, "unknown\n");
                return -EINVAL;
                break;
        }
@@ -3267,10 +2751,10 @@ static int iwl_mac_get_tx_stats(struct ieee80211_hw *hw,
        struct iwl_queue *q;
        unsigned long flags;
 
-       IWL_DEBUG_MAC80211("enter\n");
+       IWL_DEBUG_MAC80211(priv, "enter\n");
 
        if (!iwl_is_ready_rf(priv)) {
-               IWL_DEBUG_MAC80211("leave - RF not ready\n");
+               IWL_DEBUG_MAC80211(priv, "leave - RF not ready\n");
                return -EIO;
        }
 
@@ -3288,7 +2772,7 @@ static int iwl_mac_get_tx_stats(struct ieee80211_hw *hw,
        }
        spin_unlock_irqrestore(&priv->lock, flags);
 
-       IWL_DEBUG_MAC80211("leave\n");
+       IWL_DEBUG_MAC80211(priv, "leave\n");
 
        return 0;
 }
@@ -3299,8 +2783,8 @@ static int iwl_mac_get_stats(struct ieee80211_hw *hw,
        struct iwl_priv *priv = hw->priv;
 
        priv = hw->priv;
-       IWL_DEBUG_MAC80211("enter\n");
-       IWL_DEBUG_MAC80211("leave\n");
+       IWL_DEBUG_MAC80211(priv, "enter\n");
+       IWL_DEBUG_MAC80211(priv, "leave\n");
 
        return 0;
 }
@@ -3311,7 +2795,7 @@ static void iwl_mac_reset_tsf(struct ieee80211_hw *hw)
        unsigned long flags;
 
        mutex_lock(&priv->mutex);
-       IWL_DEBUG_MAC80211("enter\n");
+       IWL_DEBUG_MAC80211(priv, "enter\n");
 
        spin_lock_irqsave(&priv->lock, flags);
        memset(&priv->current_ht_config, 0, sizeof(struct iwl_ht_info));
@@ -3338,7 +2822,7 @@ static void iwl_mac_reset_tsf(struct ieee80211_hw *hw)
        spin_unlock_irqrestore(&priv->lock, flags);
 
        if (!iwl_is_ready_rf(priv)) {
-               IWL_DEBUG_MAC80211("leave - not ready\n");
+               IWL_DEBUG_MAC80211(priv, "leave - not ready\n");
                mutex_unlock(&priv->mutex);
                return;
        }
@@ -3367,7 +2851,7 @@ static void iwl_mac_reset_tsf(struct ieee80211_hw *hw)
                                                     IEEE80211_CHAN_RADAR))
                                iwl_power_disable_management(priv, 3000);
 
-               IWL_DEBUG_MAC80211("leave - not in IBSS\n");
+               IWL_DEBUG_MAC80211(priv, "leave - not in IBSS\n");
                mutex_unlock(&priv->mutex);
                return;
        }
@@ -3376,7 +2860,7 @@ static void iwl_mac_reset_tsf(struct ieee80211_hw *hw)
 
        mutex_unlock(&priv->mutex);
 
-       IWL_DEBUG_MAC80211("leave\n");
+       IWL_DEBUG_MAC80211(priv, "leave\n");
 }
 
 static int iwl_mac_beacon_update(struct ieee80211_hw *hw, struct sk_buff *skb)
@@ -3385,15 +2869,15 @@ static int iwl_mac_beacon_update(struct ieee80211_hw *hw, struct sk_buff *skb)
        unsigned long flags;
        __le64 timestamp;
 
-       IWL_DEBUG_MAC80211("enter\n");
+       IWL_DEBUG_MAC80211(priv, "enter\n");
 
        if (!iwl_is_ready_rf(priv)) {
-               IWL_DEBUG_MAC80211("leave - RF not ready\n");
+               IWL_DEBUG_MAC80211(priv, "leave - RF not ready\n");
                return -EIO;
        }
 
        if (priv->iw_mode != NL80211_IFTYPE_ADHOC) {
-               IWL_DEBUG_MAC80211("leave - not IBSS\n");
+               IWL_DEBUG_MAC80211(priv, "leave - not IBSS\n");
                return -EIO;
        }
 
@@ -3408,7 +2892,7 @@ static int iwl_mac_beacon_update(struct ieee80211_hw *hw, struct sk_buff *skb)
        timestamp = ((struct ieee80211_mgmt *)skb->data)->u.beacon.timestamp;
        priv->timestamp = le64_to_cpu(timestamp);
 
-       IWL_DEBUG_MAC80211("leave\n");
+       IWL_DEBUG_MAC80211(priv, "leave\n");
        spin_unlock_irqrestore(&priv->lock, flags);
 
        iwl_reset_qos(priv);
@@ -3566,7 +3050,7 @@ static ssize_t store_flags(struct device *d,
                if (iwl_scan_cancel_timeout(priv, 100))
                        IWL_WARN(priv, "Could not cancel scan.\n");
                else {
-                       IWL_DEBUG_INFO("Commit rxon.flags = 0x%04X\n", flags);
+                       IWL_DEBUG_INFO(priv, "Commit rxon.flags = 0x%04X\n", flags);
                        priv->staging_rxon.flags = cpu_to_le32(flags);
                        iwl_commit_rxon(priv);
                }
@@ -3605,7 +3089,7 @@ static ssize_t store_filter_flags(struct device *d,
                if (iwl_scan_cancel_timeout(priv, 100))
                        IWL_WARN(priv, "Could not cancel scan.\n");
                else {
-                       IWL_DEBUG_INFO("Committing rxon.filter_flags = "
+                       IWL_DEBUG_INFO(priv, "Committing rxon.filter_flags = "
                                       "0x%04X\n", filter_flags);
                        priv->staging_rxon.filter_flags =
                                cpu_to_le32(filter_flags);
@@ -3642,7 +3126,7 @@ static ssize_t store_power_level(struct device *d,
 
        ret = iwl_power_set_user_mode(priv, mode);
        if (ret) {
-               IWL_DEBUG_MAC80211("failed setting power mode.\n");
+               IWL_DEBUG_MAC80211(priv, "failed setting power mode.\n");
                goto out;
        }
        ret = count;
@@ -3731,7 +3215,7 @@ static DEVICE_ATTR(statistics, S_IRUGO, show_statistics, NULL);
 
 static void iwl_setup_deferred_work(struct iwl_priv *priv)
 {
-       priv->workqueue = create_workqueue(DRV_NAME);
+       priv->workqueue = create_singlethread_workqueue(DRV_NAME);
 
        init_waitqueue_head(&priv->wait_command_queue);
 
@@ -3843,7 +3327,7 @@ static int iwl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 
        SET_IEEE80211_DEV(hw, &pdev->dev);
 
-       IWL_DEBUG_INFO("*** LOAD DRIVER ***\n");
+       IWL_DEBUG_INFO(priv, "*** LOAD DRIVER ***\n");
        priv->cfg = cfg;
        priv->pci_dev = pdev;
 
@@ -3892,9 +3376,9 @@ static int iwl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
                goto out_pci_release_regions;
        }
 
-       IWL_DEBUG_INFO("pci_resource_len = 0x%08llx\n",
+       IWL_DEBUG_INFO(priv, "pci_resource_len = 0x%08llx\n",
                (unsigned long long) pci_resource_len(pdev, 0));
-       IWL_DEBUG_INFO("pci_resource_base = %p\n", priv->hw_base);
+       IWL_DEBUG_INFO(priv, "pci_resource_base = %p\n", priv->hw_base);
 
        iwl_hw_detect(priv);
        IWL_INFO(priv, "Detected Intel Wireless WiFi Link %s REV=0x%X\n",
@@ -3907,7 +3391,7 @@ static int iwl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
        /* amp init */
        err = priv->cfg->ops->lib->apm_ops.init(priv);
        if (err < 0) {
-               IWL_DEBUG_INFO("Failed to init APMG\n");
+               IWL_DEBUG_INFO(priv, "Failed to init APMG\n");
                goto out_iounmap;
        }
        /*****************
@@ -3921,11 +3405,11 @@ static int iwl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
        }
        err = iwl_eeprom_check_version(priv);
        if (err)
-               goto out_iounmap;
+               goto out_free_eeprom;
 
        /* extract MAC Address */
        iwl_eeprom_get_mac(priv, priv->mac_addr);
-       IWL_DEBUG_INFO("MAC address: %pM\n", priv->mac_addr);
+       IWL_DEBUG_INFO(priv, "MAC address: %pM\n", priv->mac_addr);
        SET_IEEE80211_PERM_ADDR(priv->hw, priv->mac_addr);
 
        /************************
@@ -3952,7 +3436,7 @@ static int iwl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
        /* Disable radio (SW RF KILL) via parameter when loading driver */
        if (priv->cfg->mod_params->disable) {
                set_bit(STATUS_RF_KILL_SW, &priv->status);
-               IWL_DEBUG_INFO("Radio disabled.\n");
+               IWL_DEBUG_INFO(priv, "Radio disabled.\n");
        }
 
        /********************
@@ -3973,7 +3457,7 @@ static int iwl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
        err = sysfs_create_group(&pdev->dev.kobj, &iwl_attribute_group);
        if (err) {
                IWL_ERR(priv, "failed to create sysfs device attributes\n");
-               goto out_uninit_drv;
+               goto out_free_irq;
        }
 
        iwl_setup_deferred_work(priv);
@@ -4017,11 +3501,13 @@ static int iwl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
        return 0;
 
  out_remove_sysfs:
+       destroy_workqueue(priv->workqueue);
+       priv->workqueue = NULL;
        sysfs_remove_group(&pdev->dev.kobj, &iwl_attribute_group);
+ out_free_irq:
+       free_irq(priv->pci_dev->irq, priv);
  out_disable_msi:
        pci_disable_msi(priv->pci_dev);
-       pci_disable_device(priv->pci_dev);
- out_uninit_drv:
        iwl_uninit_drv(priv);
  out_free_eeprom:
        iwl_eeprom_free(priv);
@@ -4046,7 +3532,7 @@ static void __devexit iwl_pci_remove(struct pci_dev *pdev)
        if (!priv)
                return;
 
-       IWL_DEBUG_INFO("*** UNLOAD DRIVER ***\n");
+       IWL_DEBUG_INFO(priv, "*** UNLOAD DRIVER ***\n");
 
        iwl_dbgfs_unregister(priv);
        sysfs_remove_group(&pdev->dev.kobj, &iwl_attribute_group);
@@ -4129,9 +3615,12 @@ static int iwl_pci_suspend(struct pci_dev *pdev, pm_message_t state)
 static int iwl_pci_resume(struct pci_dev *pdev)
 {
        struct iwl_priv *priv = pci_get_drvdata(pdev);
+       int ret;
 
        pci_set_power_state(pdev, PCI_D0);
-       pci_enable_device(pdev);
+       ret = pci_enable_device(pdev);
+       if (ret)
+               return ret;
        pci_restore_state(pdev);
        iwl_enable_interrupts(priv);