iwlwifi: fix memory leak in command queue handling
[safe/jmp/linux-2.6] / drivers / net / wireless / b43 / phy_lp.c
index 37ba177..1e318d8 100644 (file)
@@ -1,9 +1,10 @@
 /*
 
   Broadcom B43 wireless driver
-  IEEE 802.11g LP-PHY driver
+  IEEE 802.11a/g LP-PHY driver
 
   Copyright (c) 2008-2009 Michael Buesch <mb@bu3sch.de>
+  Copyright (c) 2009 Gábor Stefanik <netrolller.3d@gmail.com>
 
   This program is free software; you can redistribute it and/or modify
   it under the terms of the GNU General Public License as published by
@@ -182,8 +183,8 @@ static void lpphy_adjust_gain_table(struct b43_wldev *dev, u32 freq)
        temp[1] = temp[0] + 0x1000;
        temp[2] = temp[0] + 0x2000;
 
-       b43_lptab_write_bulk(dev, B43_LPTAB16(12, 0), 3, temp);
        b43_lptab_write_bulk(dev, B43_LPTAB16(13, 0), 3, temp);
+       b43_lptab_write_bulk(dev, B43_LPTAB16(12, 0), 3, temp);
 }
 
 static void lpphy_table_init(struct b43_wldev *dev)
@@ -223,8 +224,8 @@ static void lpphy_baseband_rev0_1_init(struct b43_wldev *dev)
        b43_phy_maskset(dev, B43_LPPHY_VERYLOWGAINDB, 0xFF00, 0x0006);
        b43_phy_mask(dev, B43_LPPHY_RX_RADIO_CTL, 0xFFFE);
        b43_phy_maskset(dev, B43_LPPHY_CLIPCTRTHRESH, 0xFFE0, 0x0005);
-       b43_phy_maskset(dev, B43_LPPHY_CLIPCTRTHRESH, 0xFC10, 0x0180);
-       b43_phy_maskset(dev, B43_LPPHY_CLIPCTRTHRESH, 0x83FF, 0x3800);
+       b43_phy_maskset(dev, B43_LPPHY_CLIPCTRTHRESH, 0xFC1F, 0x0180);
+       b43_phy_maskset(dev, B43_LPPHY_CLIPCTRTHRESH, 0x83FF, 0x3C00);
        b43_phy_maskset(dev, B43_LPPHY_GAINDIRECTMISMATCH, 0xFFF0, 0x0005);
        b43_phy_maskset(dev, B43_LPPHY_GAIN_MISMATCH_LIMIT, 0xFFC0, 0x001A);
        b43_phy_maskset(dev, B43_LPPHY_CRS_ED_THRESH, 0xFF00, 0x00B3);
@@ -234,19 +235,15 @@ static void lpphy_baseband_rev0_1_init(struct b43_wldev *dev)
        if ((bus->sprom.boardflags_lo & B43_BFL_FEM) &&
           ((b43_current_band(dev->wl) == IEEE80211_BAND_5GHZ) ||
           (bus->sprom.boardflags_hi & B43_BFH_PAREF))) {
-               /* TODO:
-                * Set the LDO voltage to 0x0028 - FIXME: What is this?
-                * Call sb_pmu_set_ldo_voltage with 4 and the LDO voltage
-                *      as arguments
-                * Call sb_pmu_paref_ldo_enable with argument TRUE
-                */
+               ssb_pmu_set_ldo_voltage(&bus->chipco, LDO_PAREF, 0x28);
+               ssb_pmu_set_ldo_paref(&bus->chipco, true);
                if (dev->phy.rev == 0) {
                        b43_phy_maskset(dev, B43_LPPHY_LP_RF_SIGNAL_LUT,
                                        0xFFCF, 0x0010);
                }
                b43_lptab_write(dev, B43_LPTAB16(11, 7), 60);
        } else {
-               //TODO: Call ssb_pmu_paref_ldo_enable with argument FALSE
+               ssb_pmu_set_ldo_paref(&bus->chipco, false);
                b43_phy_maskset(dev, B43_LPPHY_LP_RF_SIGNAL_LUT,
                                0xFFCF, 0x0020);
                b43_lptab_write(dev, B43_LPTAB16(11, 7), 100);
@@ -340,11 +337,11 @@ static void lpphy_baseband_rev0_1_init(struct b43_wldev *dev)
        if (dev->phy.rev == 1) {
                tmp = b43_phy_read(dev, B43_LPPHY_CLIPCTRTHRESH);
                tmp2 = (tmp & 0x03E0) >> 5;
-               tmp2 |= tmp << 5;
+               tmp2 |= tmp2 << 5;
                b43_phy_write(dev, B43_LPPHY_4C3, tmp2);
-               tmp = b43_phy_read(dev, B43_LPPHY_OFDMSYNCTHRESH0);
+               tmp = b43_phy_read(dev, B43_LPPHY_GAINDIRECTMISMATCH);
                tmp2 = (tmp & 0x1F00) >> 8;
-               tmp2 |= tmp << 5;
+               tmp2 |= tmp2 << 5;
                b43_phy_write(dev, B43_LPPHY_4C4, tmp2);
                tmp = b43_phy_read(dev, B43_LPPHY_VERYLOWGAINDB);
                tmp2 = tmp & 0x00FF;
@@ -705,7 +702,7 @@ static void lpphy_set_rc_cap(struct b43_wldev *dev)
        u8 rc_cap = (lpphy->rc_cap & 0x1F) >> 1;
 
        if (dev->phy.rev == 1) //FIXME check channel 14!
-               rc_cap = max_t(u8, rc_cap + 5, 15);
+               rc_cap = min_t(u8, rc_cap + 5, 15);
 
        b43_radio_write(dev, B2062_N_RXBB_CALIB2,
                        max_t(u8, lpphy->rc_cap - 4, 0x80));
@@ -724,14 +721,44 @@ static void lpphy_set_bb_mult(struct b43_wldev *dev, u8 bb_mult)
        b43_lptab_write(dev, B43_LPTAB16(0, 87), (u16)bb_mult << 8);
 }
 
-static void lpphy_disable_crs(struct b43_wldev *dev)
+static void lpphy_set_deaf(struct b43_wldev *dev, bool user)
 {
+       struct b43_phy_lp *lpphy = dev->phy.lp;
+
+       if (user)
+               lpphy->crs_usr_disable = 1;
+       else
+               lpphy->crs_sys_disable = 1;
        b43_phy_maskset(dev, B43_LPPHY_CRSGAIN_CTL, 0xFF1F, 0x80);
+}
+
+static void lpphy_clear_deaf(struct b43_wldev *dev, bool user)
+{
+       struct b43_phy_lp *lpphy = dev->phy.lp;
+
+       if (user)
+               lpphy->crs_usr_disable = 0;
+       else
+               lpphy->crs_sys_disable = 0;
+
+       if (!lpphy->crs_usr_disable && !lpphy->crs_sys_disable) {
+               if (b43_current_band(dev->wl) == IEEE80211_BAND_2GHZ)
+                       b43_phy_maskset(dev, B43_LPPHY_CRSGAIN_CTL,
+                                       0xFF1F, 0x60);
+               else
+                       b43_phy_maskset(dev, B43_LPPHY_CRSGAIN_CTL,
+                                       0xFF1F, 0x20);
+       }
+}
+
+static void lpphy_disable_crs(struct b43_wldev *dev, bool user)
+{
+       lpphy_set_deaf(dev, user);
        b43_phy_maskset(dev, B43_LPPHY_RF_OVERRIDE_VAL_0, 0xFFFC, 0x1);
        b43_phy_set(dev, B43_LPPHY_RF_OVERRIDE_0, 0x3);
        b43_phy_mask(dev, B43_LPPHY_RF_OVERRIDE_VAL_0, 0xFFFB);
        b43_phy_set(dev, B43_LPPHY_RF_OVERRIDE_0, 0x4);
-       b43_phy_mask(dev, B43_LPPHY_RF_OVERRIDE_0, 0xFFF7);
+       b43_phy_mask(dev, B43_LPPHY_RF_OVERRIDE_VAL_0, 0xFFF7);
        b43_phy_set(dev, B43_LPPHY_RF_OVERRIDE_0, 0x8);
        b43_phy_set(dev, B43_LPPHY_RF_OVERRIDE_VAL_0, 0x10);
        b43_phy_set(dev, B43_LPPHY_RF_OVERRIDE_0, 0x10);
@@ -754,12 +781,9 @@ static void lpphy_disable_crs(struct b43_wldev *dev)
        b43_phy_write(dev, B43_LPPHY_RF_OVERRIDE_2, 0x3FF);
 }
 
-static void lpphy_restore_crs(struct b43_wldev *dev)
+static void lpphy_restore_crs(struct b43_wldev *dev, bool user)
 {
-       if (b43_current_band(dev->wl) == IEEE80211_BAND_2GHZ)
-               b43_phy_maskset(dev, B43_LPPHY_CRSGAIN_CTL, 0xFF1F, 0x60);
-       else
-               b43_phy_maskset(dev, B43_LPPHY_CRSGAIN_CTL, 0xFF1F, 0x20);
+       lpphy_clear_deaf(dev, user);
        b43_phy_mask(dev, B43_LPPHY_RF_OVERRIDE_0, 0xFF80);
        b43_phy_mask(dev, B43_LPPHY_RF_OVERRIDE_2, 0xFC00);
 }
@@ -805,10 +829,11 @@ static void lpphy_set_tx_gains(struct b43_wldev *dev,
                b43_phy_maskset(dev, B43_LPPHY_TX_GAIN_CTL_OVERRIDE_VAL,
                                0xF800, rf_gain);
        } else {
-               pa_gain = b43_phy_read(dev, B43_PHY_OFDM(0xFB)) & 0x7F00;
+               pa_gain = b43_phy_read(dev, B43_PHY_OFDM(0xFB)) & 0x1FC0;
+               pa_gain <<= 2;
                b43_phy_write(dev, B43_LPPHY_TX_GAIN_CTL_OVERRIDE_VAL,
                              (gains.pga << 8) | gains.gm);
-               b43_phy_maskset(dev, B43_LPPHY_TX_GAIN_CTL_OVERRIDE_VAL,
+               b43_phy_maskset(dev, B43_PHY_OFDM(0xFB),
                                0x8000, gains.pad | pa_gain);
                b43_phy_write(dev, B43_PHY_OFDM(0xFC),
                              (gains.pga << 8) | gains.gm);
@@ -822,7 +847,7 @@ static void lpphy_set_tx_gains(struct b43_wldev *dev,
                b43_phy_maskset(dev, B43_LPPHY_RF_OVERRIDE_2, 0xFF7F, 1 << 7);
                b43_phy_maskset(dev, B43_LPPHY_RF_OVERRIDE_2, 0xBFFF, 1 << 14);
        }
-       b43_phy_maskset(dev, B43_LPPHY_RF_OVERRIDE_2, 0xFFBF, 1 << 6);
+       b43_phy_maskset(dev, B43_LPPHY_AFE_CTL_OVR, 0xFFBF, 1 << 6);
 }
 
 static void lpphy_rev0_1_set_rx_gain(struct b43_wldev *dev, u32 gain)
@@ -862,33 +887,33 @@ static void lpphy_rev2plus_set_rx_gain(struct b43_wldev *dev, u32 gain)
        }
 }
 
-static void lpphy_enable_rx_gain_override(struct b43_wldev *dev)
+static void lpphy_disable_rx_gain_override(struct b43_wldev *dev)
 {
        b43_phy_mask(dev, B43_LPPHY_RF_OVERRIDE_0, 0xFFFE);
        b43_phy_mask(dev, B43_LPPHY_RF_OVERRIDE_0, 0xFFEF);
        b43_phy_mask(dev, B43_LPPHY_RF_OVERRIDE_0, 0xFFBF);
        if (dev->phy.rev >= 2) {
                b43_phy_mask(dev, B43_LPPHY_RF_OVERRIDE_2, 0xFEFF);
-               if (b43_current_band(dev->wl) != IEEE80211_BAND_2GHZ)
-                       return;
-               b43_phy_mask(dev, B43_LPPHY_RF_OVERRIDE_2, 0xFBFF);
-               b43_phy_mask(dev, B43_LPPHY_RF_OVERRIDE_2, 0xFFF7);
+               if (b43_current_band(dev->wl) == IEEE80211_BAND_2GHZ) {
+                       b43_phy_mask(dev, B43_LPPHY_RF_OVERRIDE_2, 0xFBFF);
+                       b43_phy_mask(dev, B43_PHY_OFDM(0xE5), 0xFFF7);
+               }
        } else {
                b43_phy_mask(dev, B43_LPPHY_RF_OVERRIDE_2, 0xFDFF);
        }
 }
 
-static void lpphy_disable_rx_gain_override(struct b43_wldev *dev)
+static void lpphy_enable_rx_gain_override(struct b43_wldev *dev)
 {
        b43_phy_set(dev, B43_LPPHY_RF_OVERRIDE_0, 0x1);
        b43_phy_set(dev, B43_LPPHY_RF_OVERRIDE_0, 0x10);
        b43_phy_set(dev, B43_LPPHY_RF_OVERRIDE_0, 0x40);
        if (dev->phy.rev >= 2) {
                b43_phy_set(dev, B43_LPPHY_RF_OVERRIDE_2, 0x100);
-               if (b43_current_band(dev->wl) != IEEE80211_BAND_2GHZ)
-                       return;
-               b43_phy_set(dev, B43_LPPHY_RF_OVERRIDE_2, 0x400);
-               b43_phy_set(dev, B43_LPPHY_RF_OVERRIDE_2, 0x8);
+               if (b43_current_band(dev->wl) == IEEE80211_BAND_2GHZ) {
+                       b43_phy_set(dev, B43_LPPHY_RF_OVERRIDE_2, 0x400);
+                       b43_phy_set(dev, B43_PHY_OFDM(0xE5), 0x8);
+               }
        } else {
                b43_phy_set(dev, B43_LPPHY_RF_OVERRIDE_2, 0x200);
        }
@@ -928,7 +953,7 @@ static void lpphy_run_ddfs(struct b43_wldev *dev, int i_on, int q_on,
        b43_phy_maskset(dev, B43_LPPHY_AFE_DDFS, 0xFF9F, scale_idx << 5);
        b43_phy_mask(dev, B43_LPPHY_AFE_DDFS, 0xFFFB);
        b43_phy_set(dev, B43_LPPHY_AFE_DDFS, 0x2);
-       b43_phy_set(dev, B43_LPPHY_AFE_DDFS, 0x20);
+       b43_phy_set(dev, B43_LPPHY_LP_PHY_CTL, 0x20);
 }
 
 static bool lpphy_rx_iq_est(struct b43_wldev *dev, u16 samples, u8 time,
@@ -940,7 +965,7 @@ static bool lpphy_rx_iq_est(struct b43_wldev *dev, u16 samples, u8 time,
        b43_phy_write(dev, B43_LPPHY_IQ_NUM_SMPLS_ADDR, samples);
        b43_phy_maskset(dev, B43_LPPHY_IQ_ENABLE_WAIT_TIME_ADDR, 0xFF00, time);
        b43_phy_mask(dev, B43_LPPHY_IQ_ENABLE_WAIT_TIME_ADDR, 0xFEFF);
-       b43_phy_set(dev, B43_LPPHY_IQ_ENABLE_WAIT_TIME_ADDR, 0xFDFF);
+       b43_phy_set(dev, B43_LPPHY_IQ_ENABLE_WAIT_TIME_ADDR, 0x200);
 
        for (i = 0; i < 500; i++) {
                if (!(b43_phy_read(dev,
@@ -980,6 +1005,7 @@ static int lpphy_loopback(struct b43_wldev *dev)
 
        b43_phy_maskset(dev, B43_LPPHY_RF_OVERRIDE_VAL_0, 0xFFFC, 0x3);
        b43_phy_set(dev, B43_LPPHY_RF_OVERRIDE_0, 0x3);
+       b43_phy_set(dev, B43_LPPHY_AFE_CTL_OVR, 1);
        b43_phy_mask(dev, B43_LPPHY_AFE_CTL_OVRVAL, 0xFFFE);
        b43_phy_set(dev, B43_LPPHY_RF_OVERRIDE_0, 0x800);
        b43_phy_set(dev, B43_LPPHY_RF_OVERRIDE_VAL_0, 0x800);
@@ -1003,34 +1029,27 @@ static int lpphy_loopback(struct b43_wldev *dev)
        return index;
 }
 
+/* Fixed-point division algorithm using only integer math. */
 static u32 lpphy_qdiv_roundup(u32 dividend, u32 divisor, u8 precision)
 {
-       u32 quotient, remainder, rbit, roundup, tmp;
+       u32 quotient, remainder;
 
-       if (divisor == 0) {
-               quotient = 0;
-               remainder = 0;
-       } else {
-               quotient = dividend / divisor;
-               remainder = dividend % divisor;
-       }
+       if (divisor == 0)
+               return 0;
 
-       rbit = divisor & 0x1;
-       roundup = (divisor >> 1) + rbit;
-       precision--;
+       quotient = dividend / divisor;
+       remainder = dividend % divisor;
 
-       while (precision != 0xFF) {
-               tmp = remainder - roundup;
+       while (precision > 0) {
                quotient <<= 1;
-               remainder <<= 1;
-               if (remainder >= roundup) {
-                       remainder = (tmp << 1) + rbit;
-                       quotient--;
+               if (remainder << 1 >= divisor) {
+                       quotient++;
+                       remainder = (remainder << 1) - divisor;
                }
                precision--;
        }
 
-       if (remainder >= roundup)
+       if (remainder << 1 >= divisor)
                quotient++;
 
        return quotient;
@@ -1113,9 +1132,9 @@ static void lpphy_set_tx_power_control(struct b43_wldev *dev,
        }
        if (dev->phy.rev >= 2) {
                if (mode == B43_LPPHY_TXPCTL_HW)
-                       b43_phy_maskset(dev, B43_PHY_OFDM(0xD0), 0xFD, 0x2);
+                       b43_phy_set(dev, B43_PHY_OFDM(0xD0), 0x2);
                else
-                       b43_phy_maskset(dev, B43_PHY_OFDM(0xD0), 0xFD, 0);
+                       b43_phy_mask(dev, B43_PHY_OFDM(0xD0), 0xFFFD);
        }
        lpphy_write_tx_pctl_mode_to_hardware(dev);
 }
@@ -1128,11 +1147,11 @@ static void lpphy_rev0_1_rc_calib(struct b43_wldev *dev)
        struct b43_phy_lp *lpphy = dev->phy.lp;
        struct lpphy_iq_est iq_est;
        struct lpphy_tx_gains tx_gains;
-       static const u32 ideal_pwr_table[22] = {
+       static const u32 ideal_pwr_table[21] = {
                0x10000, 0x10557, 0x10e2d, 0x113e0, 0x10f22, 0x0ff64,
                0x0eda2, 0x0e5d4, 0x0efd1, 0x0fbe8, 0x0b7b8, 0x04b35,
                0x01a5e, 0x00a0b, 0x00444, 0x001fd, 0x000ff, 0x00088,
-               0x0004c, 0x0002c, 0x0001a, 0xc0006,
+               0x0004c, 0x0002c, 0x0001a,
        };
        bool old_txg_ovr;
        u8 old_bbmult;
@@ -1147,10 +1166,10 @@ static void lpphy_rev0_1_rc_calib(struct b43_wldev *dev)
        err = b43_lpphy_op_switch_channel(dev, 7);
        if (err) {
                b43dbg(dev->wl,
-                      "RC calib: Failed to switch to channel 7, error = %d",
+                      "RC calib: Failed to switch to channel 7, error = %d\n",
                       err);
        }
-       old_txg_ovr = (b43_phy_read(dev, B43_LPPHY_AFE_CTL_OVR) >> 6) & 1;
+       old_txg_ovr = !!(b43_phy_read(dev, B43_LPPHY_AFE_CTL_OVR) & 0x40);
        old_bbmult = lpphy_get_bb_mult(dev);
        if (old_txg_ovr)
                tx_gains = lpphy_get_tx_gains(dev);
@@ -1165,7 +1184,7 @@ static void lpphy_rev0_1_rc_calib(struct b43_wldev *dev)
        old_txpctl = lpphy->txpctl_mode;
 
        lpphy_set_tx_power_control(dev, B43_LPPHY_TXPCTL_OFF);
-       lpphy_disable_crs(dev);
+       lpphy_disable_crs(dev, true);
        loopback = lpphy_loopback(dev);
        if (loopback == -1)
                goto finish;
@@ -1189,7 +1208,7 @@ static void lpphy_rev0_1_rc_calib(struct b43_wldev *dev)
                        mean_sq_pwr = ideal_pwr - normal_pwr;
                        mean_sq_pwr *= mean_sq_pwr;
                        inner_sum += mean_sq_pwr;
-                       if ((i = 128) || (inner_sum < mean_sq_pwr_min)) {
+                       if ((i == 128) || (inner_sum < mean_sq_pwr_min)) {
                                lpphy->rc_cap = i;
                                mean_sq_pwr_min = inner_sum;
                        }
@@ -1198,7 +1217,7 @@ static void lpphy_rev0_1_rc_calib(struct b43_wldev *dev)
        lpphy_stop_ddfs(dev);
 
 finish:
-       lpphy_restore_crs(dev);
+       lpphy_restore_crs(dev, true);
        b43_phy_write(dev, B43_LPPHY_RF_OVERRIDE_VAL_0, old_rf_ovrval);
        b43_phy_write(dev, B43_LPPHY_RF_OVERRIDE_0, old_rf_ovr);
        b43_phy_write(dev, B43_LPPHY_AFE_CTL_OVRVAL, old_afe_ovrval);
@@ -1482,6 +1501,14 @@ static void b43_lpphy_op_write(struct b43_wldev *dev, u16 reg, u16 value)
        b43_write16(dev, B43_MMIO_PHY_DATA, value);
 }
 
+static void b43_lpphy_op_maskset(struct b43_wldev *dev, u16 reg, u16 mask,
+                                u16 set)
+{
+       b43_write16(dev, B43_MMIO_PHY_CONTROL, reg);
+       b43_write16(dev, B43_MMIO_PHY_DATA,
+                   (b43_read16(dev, B43_MMIO_PHY_DATA) & mask) | set);
+}
+
 static u16 b43_lpphy_op_radio_read(struct b43_wldev *dev, u16 reg)
 {
        /* Register 1 is a 32-bit register. */
@@ -1898,8 +1925,8 @@ static void lpphy_b2062_reset_pll_bias(struct b43_wldev *dev)
 
 static void lpphy_b2062_vco_calib(struct b43_wldev *dev)
 {
-       b43_phy_write(dev, B2062_S_RFPLL_CTL21, 0x42);
-       b43_phy_write(dev, B2062_S_RFPLL_CTL21, 0x62);
+       b43_radio_write(dev, B2062_S_RFPLL_CTL21, 0x42);
+       b43_radio_write(dev, B2062_S_RFPLL_CTL21, 0x62);
        udelay(200);
 }
 
@@ -1958,7 +1985,7 @@ static int lpphy_b2062_tune(struct b43_wldev *dev,
        tmp6 = tmp5 / tmp4;
        tmp7 = tmp5 % tmp4;
        b43_radio_write(dev, B2062_S_RFPLL_CTL29, tmp6 + ((2 * tmp7) / tmp4));
-       tmp8 = b43_phy_read(dev, B2062_S_RFPLL_CTL19);
+       tmp8 = b43_radio_read(dev, B2062_S_RFPLL_CTL19);
        tmp9 = ((2 * tmp3 * (tmp8 + 1)) + (3 * tmp1)) / (6 * tmp1);
        b43_radio_write(dev, B2062_S_RFPLL_CTL23, (tmp9 >> 8) + 16);
        b43_radio_write(dev, B2062_S_RFPLL_CTL24, tmp9 & 0xFF);
@@ -1997,17 +2024,17 @@ static void lpphy_b2063_vco_calib(struct b43_wldev *dev)
 {
        u16 tmp;
 
-       b43_phy_mask(dev, B2063_PLL_SP1, ~0x40);
-       tmp = b43_phy_read(dev, B2063_PLL_JTAG_CALNRST) & 0xF8;
-       b43_phy_write(dev, B2063_PLL_JTAG_CALNRST, tmp);
+       b43_radio_mask(dev, B2063_PLL_SP1, ~0x40);
+       tmp = b43_radio_read(dev, B2063_PLL_JTAG_CALNRST) & 0xF8;
+       b43_radio_write(dev, B2063_PLL_JTAG_CALNRST, tmp);
        udelay(1);
-       b43_phy_write(dev, B2063_PLL_JTAG_CALNRST, tmp | 0x4);
+       b43_radio_write(dev, B2063_PLL_JTAG_CALNRST, tmp | 0x4);
        udelay(1);
-       b43_phy_write(dev, B2063_PLL_JTAG_CALNRST, tmp | 0x6);
+       b43_radio_write(dev, B2063_PLL_JTAG_CALNRST, tmp | 0x6);
        udelay(1);
-       b43_phy_write(dev, B2063_PLL_JTAG_CALNRST, tmp | 0x7);
+       b43_radio_write(dev, B2063_PLL_JTAG_CALNRST, tmp | 0x7);
        udelay(300);
-       b43_phy_set(dev, B2063_PLL_SP1, 0x40);
+       b43_radio_set(dev, B2063_PLL_SP1, 0x40);
 }
 
 static int lpphy_b2063_tune(struct b43_wldev *dev,
@@ -2102,31 +2129,31 @@ static int lpphy_b2063_tune(struct b43_wldev *dev,
                scale = 0;
                tmp5 = ((tmp4 + (tmp3 >> 1)) / tmp3) - 8;
        }
-       b43_phy_maskset(dev, B2063_PLL_JTAG_PLL_CP2, 0xFFC0, tmp5);
-       b43_phy_maskset(dev, B2063_PLL_JTAG_PLL_CP2, 0xFFBF, scale << 6);
+       b43_radio_maskset(dev, B2063_PLL_JTAG_PLL_CP2, 0xFFC0, tmp5);
+       b43_radio_maskset(dev, B2063_PLL_JTAG_PLL_CP2, 0xFFBF, scale << 6);
 
        tmp6 = lpphy_qdiv_roundup(100 * val1, val3, 16);
        tmp6 *= (tmp5 * 8) * (scale + 1);
        if (tmp6 > 150)
                tmp6 = 0;
 
-       b43_phy_maskset(dev, B2063_PLL_JTAG_PLL_CP3, 0xFFE0, tmp6);
-       b43_phy_maskset(dev, B2063_PLL_JTAG_PLL_CP3, 0xFFDF, scale << 5);
+       b43_radio_maskset(dev, B2063_PLL_JTAG_PLL_CP3, 0xFFE0, tmp6);
+       b43_radio_maskset(dev, B2063_PLL_JTAG_PLL_CP3, 0xFFDF, scale << 5);
 
-       b43_phy_maskset(dev, B2063_PLL_JTAG_PLL_XTAL_12, 0xFFFB, 0x4);
+       b43_radio_maskset(dev, B2063_PLL_JTAG_PLL_XTAL_12, 0xFFFB, 0x4);
        if (crystal_freq > 26000000)
-               b43_phy_set(dev, B2063_PLL_JTAG_PLL_XTAL_12, 0x2);
+               b43_radio_set(dev, B2063_PLL_JTAG_PLL_XTAL_12, 0x2);
        else
-               b43_phy_mask(dev, B2063_PLL_JTAG_PLL_XTAL_12, 0xFD);
+               b43_radio_mask(dev, B2063_PLL_JTAG_PLL_XTAL_12, 0xFD);
 
        if (val1 == 45)
-               b43_phy_set(dev, B2063_PLL_JTAG_PLL_VCO1, 0x2);
+               b43_radio_set(dev, B2063_PLL_JTAG_PLL_VCO1, 0x2);
        else
-               b43_phy_mask(dev, B2063_PLL_JTAG_PLL_VCO1, 0xFD);
+               b43_radio_mask(dev, B2063_PLL_JTAG_PLL_VCO1, 0xFD);
 
-       b43_phy_set(dev, B2063_PLL_SP2, 0x3);
+       b43_radio_set(dev, B2063_PLL_SP2, 0x3);
        udelay(1);
-       b43_phy_mask(dev, B2063_PLL_SP2, 0xFFFC);
+       b43_radio_mask(dev, B2063_PLL_SP2, 0xFFFC);
        lpphy_b2063_vco_calib(dev);
        b43_radio_write(dev, B2063_COMM15, old_comm15);
 
@@ -2136,10 +2163,9 @@ static int lpphy_b2063_tune(struct b43_wldev *dev,
 static int b43_lpphy_op_switch_channel(struct b43_wldev *dev,
                                       unsigned int new_channel)
 {
+       struct b43_phy_lp *lpphy = dev->phy.lp;
        int err;
 
-       b43_write16(dev, B43_MMIO_CHANNEL, new_channel);
-
        if (dev->phy.radio_ver == 0x2063) {
                err = lpphy_b2063_tune(dev, new_channel);
                if (err)
@@ -2152,6 +2178,9 @@ static int b43_lpphy_op_switch_channel(struct b43_wldev *dev,
                lpphy_adjust_gain_table(dev, channel2freq_lp(new_channel));
        }
 
+       lpphy->channel = new_channel;
+       b43_write16(dev, B43_MMIO_CHANNEL, new_channel);
+
        return 0;
 }
 
@@ -2163,10 +2192,9 @@ static int b43_lpphy_op_init(struct b43_wldev *dev)
        lpphy_baseband_init(dev);
        lpphy_radio_init(dev);
        lpphy_calibrate_rc(dev);
-       err = b43_lpphy_op_switch_channel(dev,
-                               b43_lpphy_op_get_default_chan(dev));
+       err = b43_lpphy_op_switch_channel(dev, 7);
        if (err) {
-               b43dbg(dev->wl, "Switch to init channel failed, error = %d.\n",
+               b43dbg(dev->wl, "Switch to channel 7 failed, error = %d.\n",
                       err);
        }
        lpphy_tx_pctl_init(dev);
@@ -2178,7 +2206,14 @@ static int b43_lpphy_op_init(struct b43_wldev *dev)
 
 static void b43_lpphy_op_set_rx_antenna(struct b43_wldev *dev, int antenna)
 {
-       //TODO
+       if (dev->phy.rev >= 2)
+               return; // rev2+ doesn't support antenna diversity
+
+       if (B43_WARN_ON(antenna > B43_ANTENNA_AUTO1))
+               return;
+
+       b43_phy_maskset(dev, B43_LPPHY_CRSGAIN_CTL, 0xFFFD, antenna & 0x2);
+       b43_phy_maskset(dev, B43_LPPHY_CRSGAIN_CTL, 0xFFFE, antenna & 0x1);
 }
 
 static void b43_lpphy_op_adjust_txpower(struct b43_wldev *dev)
@@ -2193,6 +2228,16 @@ static enum b43_txpwr_result b43_lpphy_op_recalc_txpower(struct b43_wldev *dev,
        return B43_TXPWR_RES_DONE;
 }
 
+void b43_lpphy_op_switch_analog(struct b43_wldev *dev, bool on)
+{
+       if (on) {
+               b43_phy_mask(dev, B43_LPPHY_AFE_CTL_OVR, 0xfff8);
+       } else {
+               b43_phy_set(dev, B43_LPPHY_AFE_CTL_OVRVAL, 0x0007);
+               b43_phy_set(dev, B43_LPPHY_AFE_CTL_OVR, 0x0007);
+       }
+}
+
 const struct b43_phy_operations b43_phyops_lp = {
        .allocate               = b43_lpphy_op_allocate,
        .free                   = b43_lpphy_op_free,
@@ -2200,10 +2245,11 @@ const struct b43_phy_operations b43_phyops_lp = {
        .init                   = b43_lpphy_op_init,
        .phy_read               = b43_lpphy_op_read,
        .phy_write              = b43_lpphy_op_write,
+       .phy_maskset            = b43_lpphy_op_maskset,
        .radio_read             = b43_lpphy_op_radio_read,
        .radio_write            = b43_lpphy_op_radio_write,
        .software_rfkill        = b43_lpphy_op_software_rfkill,
-       .switch_analog          = b43_phyop_switch_analog_generic,
+       .switch_analog          = b43_lpphy_op_switch_analog,
        .switch_channel         = b43_lpphy_op_switch_channel,
        .get_default_chan       = b43_lpphy_op_get_default_chan,
        .set_rx_antenna         = b43_lpphy_op_set_rx_antenna,