wireless: Small cleanups
[safe/jmp/linux-2.6] / drivers / net / 3c505.c
index 458cb9c..fdfb2b2 100644 (file)
@@ -169,21 +169,6 @@ static int elp_debug;
 
 /*****************************************************************
  *
- * useful macros
- *
- *****************************************************************/
-
-#ifndef        TRUE
-#define        TRUE    1
-#endif
-
-#ifndef        FALSE
-#define        FALSE   0
-#endif
-
-
-/*****************************************************************
- *
  * List of I/O-addresses we try to auto-sense
  * Last element MUST BE 0!
  *****************************************************************/
@@ -270,7 +255,7 @@ static inline void set_hsf(struct net_device *dev, int hsf)
        spin_unlock_irqrestore(&adapter->lock, flags);
 }
 
-static int start_receive(struct net_device *, pcb_struct *);
+static bool start_receive(struct net_device *, pcb_struct *);
 
 static inline void adapter_reset(struct net_device *dev)
 {
@@ -328,28 +313,28 @@ static inline void check_3c505_dma(struct net_device *dev)
 }
 
 /* Primitive functions used by send_pcb() */
-static inline unsigned int send_pcb_slow(unsigned int base_addr, unsigned char byte)
+static inline bool send_pcb_slow(unsigned int base_addr, unsigned char byte)
 {
        unsigned long timeout;
        outb_command(byte, base_addr);
        for (timeout = jiffies + 5*HZ/100; time_before(jiffies, timeout);) {
                if (inb_status(base_addr) & HCRE)
-                       return FALSE;
+                       return false;
        }
        printk(KERN_WARNING "3c505: send_pcb_slow timed out\n");
-       return TRUE;
+       return true;
 }
 
-static inline unsigned int send_pcb_fast(unsigned int base_addr, unsigned char byte)
+static inline bool send_pcb_fast(unsigned int base_addr, unsigned char byte)
 {
        unsigned int timeout;
        outb_command(byte, base_addr);
        for (timeout = 0; timeout < 40000; timeout++) {
                if (inb_status(base_addr) & HCRE)
-                       return FALSE;
+                       return false;
        }
        printk(KERN_WARNING "3c505: send_pcb_fast timed out\n");
-       return TRUE;
+       return true;
 }
 
 /* Check to see if the receiver needs restarting, and kick it if so */
@@ -386,7 +371,7 @@ static inline void prime_rx(struct net_device *dev)
  * timeout is reduced to 500us).
  */
 
-static int send_pcb(struct net_device *dev, pcb_struct * pcb)
+static bool send_pcb(struct net_device *dev, pcb_struct * pcb)
 {
        int i;
        unsigned long timeout;
@@ -396,14 +381,14 @@ static int send_pcb(struct net_device *dev, pcb_struct * pcb)
        check_3c505_dma(dev);
 
        if (adapter->dmaing && adapter->current_dma.direction == 0)
-               return FALSE;
+               return false;
 
        /* Avoid contention */
        if (test_and_set_bit(1, &adapter->send_pcb_semaphore)) {
                if (elp_debug >= 3) {
                        printk(KERN_DEBUG "%s: send_pcb entered while threaded\n", dev->name);
                }
-               return FALSE;
+               return false;
        }
        /*
         * load each byte into the command register and
@@ -435,7 +420,7 @@ static int send_pcb(struct net_device *dev, pcb_struct * pcb)
                switch (GET_ASF(dev->base_addr)) {
                case ASF_PCB_ACK:
                        adapter->send_pcb_semaphore = 0;
-                       return TRUE;
+                       return true;
 
                case ASF_PCB_NAK:
 #ifdef ELP_DEBUG
@@ -453,7 +438,7 @@ static int send_pcb(struct net_device *dev, pcb_struct * pcb)
        spin_unlock_irqrestore(&adapter->lock, flags);
       abort:
        adapter->send_pcb_semaphore = 0;
-       return FALSE;
+       return false;
 }
 
 
@@ -470,7 +455,7 @@ static int send_pcb(struct net_device *dev, pcb_struct * pcb)
  *
  *****************************************************************/
 
-static int receive_pcb(struct net_device *dev, pcb_struct * pcb)
+static bool receive_pcb(struct net_device *dev, pcb_struct * pcb)
 {
        int i, j;
        int total_length;
@@ -487,7 +472,7 @@ static int receive_pcb(struct net_device *dev, pcb_struct * pcb)
        while (((stat = get_status(dev->base_addr)) & ACRF) == 0 && time_before(jiffies, timeout));
        if (time_after_eq(jiffies, timeout)) {
                TIMEOUT_MSG(__LINE__);
-               return FALSE;
+               return false;
        }
        pcb->command = inb_command(dev->base_addr);
 
@@ -497,14 +482,14 @@ static int receive_pcb(struct net_device *dev, pcb_struct * pcb)
        if (time_after_eq(jiffies, timeout)) {
                TIMEOUT_MSG(__LINE__);
                printk(KERN_INFO "%s: status %02x\n", dev->name, stat);
-               return FALSE;
+               return false;
        }
        pcb->length = inb_command(dev->base_addr);
 
        if (pcb->length > MAX_PCB_DATA) {
                INVALID_PCB_MSG(pcb->length);
                adapter_reset(dev);
-               return FALSE;
+               return false;
        }
        /* read the data */
        spin_lock_irqsave(&adapter->lock, flags);
@@ -519,7 +504,7 @@ static int receive_pcb(struct net_device *dev, pcb_struct * pcb)
        spin_unlock_irqrestore(&adapter->lock, flags);
        if (j >= 20000) {
                TIMEOUT_MSG(__LINE__);
-               return FALSE;
+               return false;
        }
        /* woops, the last "data" byte was really the length! */
        total_length = pcb->data.raw[--i];
@@ -529,7 +514,7 @@ static int receive_pcb(struct net_device *dev, pcb_struct * pcb)
                if (elp_debug >= 2)
                        printk(KERN_WARNING "%s: mangled PCB received\n", dev->name);
                set_hsf(dev, HSF_PCB_NAK);
-               return FALSE;
+               return false;
        }
 
        if (pcb->command == CMD_RECEIVE_PACKET_COMPLETE) {
@@ -538,14 +523,14 @@ static int receive_pcb(struct net_device *dev, pcb_struct * pcb)
                                set_hsf(dev, HSF_PCB_NAK);
                                printk(KERN_WARNING "%s: PCB rejected, transfer in progress and backlog full\n", dev->name);
                                pcb->command = 0;
-                               return TRUE;
+                               return true;
                        } else {
                                pcb->command = 0xff;
                        }
                }
        }
        set_hsf(dev, HSF_PCB_ACK);
-       return TRUE;
+       return true;
 }
 
 /******************************************************
@@ -555,9 +540,9 @@ static int receive_pcb(struct net_device *dev, pcb_struct * pcb)
  *
  ******************************************************/
 
-static int start_receive(struct net_device *dev, pcb_struct * tx_pcb)
+static bool start_receive(struct net_device *dev, pcb_struct * tx_pcb)
 {
-       int status;
+       bool status;
        elp_device *adapter = dev->priv;
 
        if (elp_debug >= 3)
@@ -615,7 +600,6 @@ static void receive_packet(struct net_device *dev, int len)
        if (test_and_set_bit(0, (void *) &adapter->dmaing))
                printk(KERN_ERR "%s: rx blocked, DMA in progress, dir %d\n", dev->name, adapter->current_dma.direction);
 
-       skb->dev = dev;
        adapter->current_dma.direction = 0;
        adapter->current_dma.length = rlen;
        adapter->current_dma.skb = skb;
@@ -686,7 +670,7 @@ static irqreturn_t elp_interrupt(int irq, void *dev_id)
                                        memcpy(adapter->current_dma.target, adapter->dma_buffer, adapter->current_dma.length);
                                        }
                                        skb->protocol = eth_type_trans(skb,dev);
-                                       adapter->stats.rx_bytes += skb->len;
+                                       dev->stats.rx_bytes += skb->len;
                                        netif_rx(skb);
                                        dev->last_rx = jiffies;
                                }
@@ -789,12 +773,12 @@ static irqreturn_t elp_interrupt(int irq, void *dev_id)
                                         * received board statistics
                                         */
                                case CMD_NETWORK_STATISTICS_RESPONSE:
-                                       adapter->stats.rx_packets += adapter->irx_pcb.data.netstat.tot_recv;
-                                       adapter->stats.tx_packets += adapter->irx_pcb.data.netstat.tot_xmit;
-                                       adapter->stats.rx_crc_errors += adapter->irx_pcb.data.netstat.err_CRC;
-                                       adapter->stats.rx_frame_errors += adapter->irx_pcb.data.netstat.err_align;
-                                       adapter->stats.rx_fifo_errors += adapter->irx_pcb.data.netstat.err_ovrrun;
-                                       adapter->stats.rx_over_errors += adapter->irx_pcb.data.netstat.err_res;
+                                       dev->stats.rx_packets += adapter->irx_pcb.data.netstat.tot_recv;
+                                       dev->stats.tx_packets += adapter->irx_pcb.data.netstat.tot_xmit;
+                                       dev->stats.rx_crc_errors += adapter->irx_pcb.data.netstat.err_CRC;
+                                       dev->stats.rx_frame_errors += adapter->irx_pcb.data.netstat.err_align;
+                                       dev->stats.rx_fifo_errors += adapter->irx_pcb.data.netstat.err_ovrrun;
+                                       dev->stats.rx_over_errors += adapter->irx_pcb.data.netstat.err_res;
                                        adapter->got[CMD_NETWORK_STATISTICS] = 1;
                                        if (elp_debug >= 3)
                                                printk(KERN_DEBUG "%s: interrupt - statistics response received\n", dev->name);
@@ -810,11 +794,11 @@ static irqreturn_t elp_interrupt(int irq, void *dev_id)
                                                break;
                                        switch (adapter->irx_pcb.data.xmit_resp.c_stat) {
                                        case 0xffff:
-                                               adapter->stats.tx_aborted_errors++;
+                                               dev->stats.tx_aborted_errors++;
                                                printk(KERN_INFO "%s: transmit timed out, network cable problem?\n", dev->name);
                                                break;
                                        case 0xfffe:
-                                               adapter->stats.tx_fifo_errors++;
+                                               dev->stats.tx_fifo_errors++;
                                                printk(KERN_INFO "%s: transmit timed out, FIFO underrun\n", dev->name);
                                                break;
                                        }
@@ -985,7 +969,7 @@ static int elp_open(struct net_device *dev)
  *
  ******************************************************/
 
-static int send_packet(struct net_device *dev, struct sk_buff *skb)
+static bool send_packet(struct net_device *dev, struct sk_buff *skb)
 {
        elp_device *adapter = dev->priv;
        unsigned long target;
@@ -999,10 +983,10 @@ static int send_packet(struct net_device *dev, struct sk_buff *skb)
        if (test_and_set_bit(0, (void *) &adapter->busy)) {
                if (elp_debug >= 2)
                        printk(KERN_DEBUG "%s: transmit blocked\n", dev->name);
-               return FALSE;
+               return false;
        }
 
-       adapter->stats.tx_bytes += nlen;
+       dev->stats.tx_bytes += nlen;
 
        /*
         * send the adapter a transmit packet command. Ignore segment and offset
@@ -1016,7 +1000,7 @@ static int send_packet(struct net_device *dev, struct sk_buff *skb)
 
        if (!send_pcb(dev, &adapter->tx_pcb)) {
                adapter->busy = 0;
-               return FALSE;
+               return false;
        }
        /* if this happens, we die */
        if (test_and_set_bit(0, (void *) &adapter->dmaing))
@@ -1026,7 +1010,7 @@ static int send_packet(struct net_device *dev, struct sk_buff *skb)
        adapter->current_dma.start_time = jiffies;
 
        if ((unsigned long)(skb->data + nlen) >= MAX_DMA_ADDRESS || nlen != skb->len) {
-               memcpy(adapter->dma_buffer, skb->data, nlen);
+               skb_copy_from_linear_data(skb, adapter->dma_buffer, nlen);
                memset(adapter->dma_buffer+skb->len, 0, nlen-skb->len);
                target = isa_virt_to_bus(adapter->dma_buffer);
        }
@@ -1048,7 +1032,7 @@ static int send_packet(struct net_device *dev, struct sk_buff *skb)
        if (elp_debug >= 3)
                printk(KERN_DEBUG "%s: DMA transfer started\n", dev->name);
 
-       return TRUE;
+       return true;
 }
 
 /*
@@ -1057,7 +1041,6 @@ static int send_packet(struct net_device *dev, struct sk_buff *skb)
 
 static void elp_timeout(struct net_device *dev)
 {
-       elp_device *adapter = dev->priv;
        int stat;
 
        stat = inb_status(dev->base_addr);
@@ -1065,7 +1048,7 @@ static void elp_timeout(struct net_device *dev)
        if (elp_debug >= 1)
                printk(KERN_DEBUG "%s: status %#02x\n", dev->name, stat);
        dev->trans_start = jiffies;
-       adapter->stats.tx_dropped++;
+       dev->stats.tx_dropped++;
        netif_wake_queue(dev);
 }
 
@@ -1129,7 +1112,7 @@ static struct net_device_stats *elp_get_stats(struct net_device *dev)
        /* If the device is closed, just return the latest stats we have,
           - we cannot ask from the adapter without interrupts */
        if (!netif_running(dev))
-               return &adapter->stats;
+               return &dev->stats;
 
        /* send a get statistics command to the board */
        adapter->tx_pcb.command = CMD_NETWORK_STATISTICS;
@@ -1142,12 +1125,12 @@ static struct net_device_stats *elp_get_stats(struct net_device *dev)
                while (adapter->got[CMD_NETWORK_STATISTICS] == 0 && time_before(jiffies, timeout));
                if (time_after_eq(jiffies, timeout)) {
                        TIMEOUT_MSG(__LINE__);
-                       return &adapter->stats;
+                       return &dev->stats;
                }
        }
 
        /* statistics are now up to date */
-       return &adapter->stats;
+       return &dev->stats;
 }
 
 
@@ -1402,8 +1385,7 @@ static int __init elplus_setup(struct net_device *dev)
        unsigned long timeout;
        unsigned long cookie = 0;
        int err = -ENODEV;
-
-       SET_MODULE_OWNER(dev);
+       DECLARE_MAC_BUF(mac);
 
        /*
         *  setup adapter structure
@@ -1539,11 +1521,10 @@ static int __init elplus_setup(struct net_device *dev)
        /*
         * print remainder of startup message
         */
-       printk(KERN_INFO "%s: 3c505 at %#lx, irq %d, dma %d, ",
-              dev->name, dev->base_addr, dev->irq, dev->dma);
-       printk("addr %02x:%02x:%02x:%02x:%02x:%02x, ",
-              dev->dev_addr[0], dev->dev_addr[1], dev->dev_addr[2],
-              dev->dev_addr[3], dev->dev_addr[4], dev->dev_addr[5]);
+       printk(KERN_INFO "%s: 3c505 at %#lx, irq %d, dma %d, "
+              "addr %s, ",
+              dev->name, dev->base_addr, dev->irq, dev->dma,
+              print_mac(mac, dev->dev_addr));
 
        /*
         * read more information from the adapter
@@ -1589,7 +1570,6 @@ static int __init elplus_setup(struct net_device *dev)
        dev->set_multicast_list = elp_set_mc_list;      /* local */
        dev->ethtool_ops = &netdev_ethtool_ops;         /* local */
 
-       memset(&(adapter->stats), 0, sizeof(struct net_device_stats));
        dev->mem_start = dev->mem_end = 0;
 
        err = register_netdev(dev);
@@ -1670,7 +1650,7 @@ int __init init_module(void)
        return 0;
 }
 
-void cleanup_module(void)
+void __exit cleanup_module(void)
 {
        int this_dev;