async_tx: trim dma_async_tx_descriptor in 'no channel switch' case
[safe/jmp/linux-2.6] / drivers / misc / sgi-xp / xpc_sn2.c
index 01dd40e..7d71c04 100644 (file)
@@ -3,7 +3,7 @@
  * License.  See the file "COPYING" in the main directory of this archive
  * for more details.
  *
- * Copyright (c) 2008 Silicon Graphics, Inc.  All Rights Reserved.
+ * Copyright (c) 2008-2009 Silicon Graphics, Inc.  All Rights Reserved.
  */
 
 /*
  *
  */
 
-#include <linux/kernel.h>
 #include <linux/delay.h>
+#include <linux/slab.h>
 #include <asm/uncached.h>
+#include <asm/sn/mspec.h>
 #include <asm/sn/sn_sal.h>
 #include "xpc.h"
 
-static struct xpc_vars_sn2 *xpc_vars;  /* >>> Add _sn2 suffix? */
-static struct xpc_vars_part_sn2 *xpc_vars_part; /* >>> Add _sn2 suffix? */
+/*
+ * Define the number of u64s required to represent all the C-brick nasids
+ * as a bitmap.  The cross-partition kernel modules deal only with
+ * C-brick nasids, thus the need for bitmaps which don't account for
+ * odd-numbered (non C-brick) nasids.
+ */
+#define XPC_MAX_PHYSNODES_SN2  (MAX_NUMALINK_NODES / 2)
+#define XP_NASID_MASK_BYTES_SN2        ((XPC_MAX_PHYSNODES_SN2 + 7) / 8)
+#define XP_NASID_MASK_WORDS_SN2        ((XPC_MAX_PHYSNODES_SN2 + 63) / 64)
+
+/*
+ * Memory for XPC's amo variables is allocated by the MSPEC driver. These
+ * pages are located in the lowest granule. The lowest granule uses 4k pages
+ * for cached references and an alternate TLB handler to never provide a
+ * cacheable mapping for the entire region. This will prevent speculative
+ * reading of cached copies of our lines from being issued which will cause
+ * a PI FSB Protocol error to be generated by the SHUB. For XPC, we need 64
+ * amo variables (based on XP_MAX_NPARTITIONS_SN2) to identify the senders of
+ * NOTIFY IRQs, 128 amo variables (based on XP_NASID_MASK_WORDS_SN2) to identify
+ * the senders of ACTIVATE IRQs, 1 amo variable to identify which remote
+ * partitions (i.e., XPCs) consider themselves currently engaged with the
+ * local XPC and 1 amo variable to request partition deactivation.
+ */
+#define XPC_NOTIFY_IRQ_AMOS_SN2                0
+#define XPC_ACTIVATE_IRQ_AMOS_SN2      (XPC_NOTIFY_IRQ_AMOS_SN2 + \
+                                        XP_MAX_NPARTITIONS_SN2)
+#define XPC_ENGAGED_PARTITIONS_AMO_SN2 (XPC_ACTIVATE_IRQ_AMOS_SN2 + \
+                                        XP_NASID_MASK_WORDS_SN2)
+#define XPC_DEACTIVATE_REQUEST_AMO_SN2 (XPC_ENGAGED_PARTITIONS_AMO_SN2 + 1)
+
+/*
+ * Buffer used to store a local copy of portions of a remote partition's
+ * reserved page (either its header and part_nasids mask, or its vars).
+ */
+static void *xpc_remote_copy_buffer_base_sn2;
+static char *xpc_remote_copy_buffer_sn2;
+
+static struct xpc_vars_sn2 *xpc_vars_sn2;
+static struct xpc_vars_part_sn2 *xpc_vars_part_sn2;
+
+static int
+xpc_setup_partitions_sn2(void)
+{
+       /* nothing needs to be done */
+       return 0;
+}
+
+static void
+xpc_teardown_partitions_sn2(void)
+{
+       /* nothing needs to be done */
+}
 
 /* SH_IPI_ACCESS shub register value on startup */
-static u64 xpc_sh1_IPI_access;
-static u64 xpc_sh2_IPI_access0;
-static u64 xpc_sh2_IPI_access1;
-static u64 xpc_sh2_IPI_access2;
-static u64 xpc_sh2_IPI_access3;
+static u64 xpc_sh1_IPI_access_sn2;
+static u64 xpc_sh2_IPI_access0_sn2;
+static u64 xpc_sh2_IPI_access1_sn2;
+static u64 xpc_sh2_IPI_access2_sn2;
+static u64 xpc_sh2_IPI_access3_sn2;
 
 /*
  * Change protections to allow IPI operations.
@@ -38,15 +89,15 @@ xpc_allow_IPI_ops_sn2(void)
        int node;
        int nasid;
 
-       /* >>> The following should get moved into SAL. */
+       /* !!! The following should get moved into SAL. */
        if (is_shub2()) {
-               xpc_sh2_IPI_access0 =
+               xpc_sh2_IPI_access0_sn2 =
                    (u64)HUB_L((u64 *)LOCAL_MMR_ADDR(SH2_IPI_ACCESS0));
-               xpc_sh2_IPI_access1 =
+               xpc_sh2_IPI_access1_sn2 =
                    (u64)HUB_L((u64 *)LOCAL_MMR_ADDR(SH2_IPI_ACCESS1));
-               xpc_sh2_IPI_access2 =
+               xpc_sh2_IPI_access2_sn2 =
                    (u64)HUB_L((u64 *)LOCAL_MMR_ADDR(SH2_IPI_ACCESS2));
-               xpc_sh2_IPI_access3 =
+               xpc_sh2_IPI_access3_sn2 =
                    (u64)HUB_L((u64 *)LOCAL_MMR_ADDR(SH2_IPI_ACCESS3));
 
                for_each_online_node(node) {
@@ -61,7 +112,7 @@ xpc_allow_IPI_ops_sn2(void)
                              -1UL);
                }
        } else {
-               xpc_sh1_IPI_access =
+               xpc_sh1_IPI_access_sn2 =
                    (u64)HUB_L((u64 *)LOCAL_MMR_ADDR(SH1_IPI_ACCESS));
 
                for_each_online_node(node) {
@@ -81,24 +132,24 @@ xpc_disallow_IPI_ops_sn2(void)
        int node;
        int nasid;
 
-       /* >>> The following should get moved into SAL. */
+       /* !!! The following should get moved into SAL. */
        if (is_shub2()) {
                for_each_online_node(node) {
                        nasid = cnodeid_to_nasid(node);
                        HUB_S((u64 *)GLOBAL_MMR_ADDR(nasid, SH2_IPI_ACCESS0),
-                             xpc_sh2_IPI_access0);
+                             xpc_sh2_IPI_access0_sn2);
                        HUB_S((u64 *)GLOBAL_MMR_ADDR(nasid, SH2_IPI_ACCESS1),
-                             xpc_sh2_IPI_access1);
+                             xpc_sh2_IPI_access1_sn2);
                        HUB_S((u64 *)GLOBAL_MMR_ADDR(nasid, SH2_IPI_ACCESS2),
-                             xpc_sh2_IPI_access2);
+                             xpc_sh2_IPI_access2_sn2);
                        HUB_S((u64 *)GLOBAL_MMR_ADDR(nasid, SH2_IPI_ACCESS3),
-                             xpc_sh2_IPI_access3);
+                             xpc_sh2_IPI_access3_sn2);
                }
        } else {
                for_each_online_node(node) {
                        nasid = cnodeid_to_nasid(node);
                        HUB_S((u64 *)GLOBAL_MMR_ADDR(nasid, SH1_IPI_ACCESS),
-                             xpc_sh1_IPI_access);
+                             xpc_sh1_IPI_access_sn2);
                }
        }
 }
@@ -139,13 +190,13 @@ xpc_send_IRQ_sn2(struct amo *amo, u64 flag, int nasid, int phys_cpuid,
 
        local_irq_restore(irq_flags);
 
-       return ((ret == 0) ? xpSuccess : xpPioReadError);
+       return (ret == 0) ? xpSuccess : xpPioReadError;
 }
 
 static struct amo *
 xpc_init_IRQ_amo_sn2(int index)
 {
-       struct amo *amo = xpc_vars->amos_page + index;
+       struct amo *amo = xpc_vars_sn2->amos_page + index;
 
        (void)xpc_receive_IRQ_amo_sn2(amo);     /* clear amo variable */
        return amo;
@@ -161,7 +212,12 @@ xpc_init_IRQ_amo_sn2(int index)
 static irqreturn_t
 xpc_handle_activate_IRQ_sn2(int irq, void *dev_id)
 {
-       atomic_inc(&xpc_activate_IRQ_rcvd);
+       unsigned long irq_flags;
+
+       spin_lock_irqsave(&xpc_activate_IRQ_rcvd_lock, irq_flags);
+       xpc_activate_IRQ_rcvd++;
+       spin_unlock_irqrestore(&xpc_activate_IRQ_rcvd_lock, irq_flags);
+
        wake_up_interruptible(&xpc_activate_IRQ_wq);
        return IRQ_HANDLED;
 }
@@ -170,32 +226,34 @@ xpc_handle_activate_IRQ_sn2(int irq, void *dev_id)
  * Flag the appropriate amo variable and send an IRQ to the specified node.
  */
 static void
-xpc_send_activate_IRQ_sn2(u64 amos_page_pa, int from_nasid, int to_nasid,
-                         int to_phys_cpuid)
+xpc_send_activate_IRQ_sn2(unsigned long amos_page_pa, int from_nasid,
+                         int to_nasid, int to_phys_cpuid)
 {
-       int w_index = XPC_NASID_W_INDEX(from_nasid);
-       int b_index = XPC_NASID_B_INDEX(from_nasid);
        struct amo *amos = (struct amo *)__va(amos_page_pa +
-                                             (XPC_ACTIVATE_IRQ_AMOS *
+                                             (XPC_ACTIVATE_IRQ_AMOS_SN2 *
                                              sizeof(struct amo)));
 
-       (void)xpc_send_IRQ_sn2(&amos[w_index], (1UL << b_index), to_nasid,
+       (void)xpc_send_IRQ_sn2(&amos[BIT_WORD(from_nasid / 2)],
+                              BIT_MASK(from_nasid / 2), to_nasid,
                               to_phys_cpuid, SGI_XPC_ACTIVATE);
 }
 
 static void
 xpc_send_local_activate_IRQ_sn2(int from_nasid)
 {
-       int w_index = XPC_NASID_W_INDEX(from_nasid);
-       int b_index = XPC_NASID_B_INDEX(from_nasid);
-       struct amo *amos = (struct amo *)__va(xpc_vars->amos_page_pa +
-                                             (XPC_ACTIVATE_IRQ_AMOS *
+       unsigned long irq_flags;
+       struct amo *amos = (struct amo *)__va(xpc_vars_sn2->amos_page_pa +
+                                             (XPC_ACTIVATE_IRQ_AMOS_SN2 *
                                              sizeof(struct amo)));
 
        /* fake the sending and receipt of an activate IRQ from remote nasid */
-       FETCHOP_STORE_OP(TO_AMO((u64)&amos[w_index].variable), FETCHOP_OR,
-                        (1UL << b_index));
-       atomic_inc(&xpc_activate_IRQ_rcvd);
+       FETCHOP_STORE_OP(TO_AMO((u64)&amos[BIT_WORD(from_nasid / 2)].variable),
+                        FETCHOP_OR, BIT_MASK(from_nasid / 2));
+
+       spin_lock_irqsave(&xpc_activate_IRQ_rcvd_lock, irq_flags);
+       xpc_activate_IRQ_rcvd++;
+       spin_unlock_irqrestore(&xpc_activate_IRQ_rcvd_lock, irq_flags);
+
        wake_up_interruptible(&xpc_activate_IRQ_wq);
 }
 
@@ -222,7 +280,7 @@ xpc_check_for_sent_chctl_flags_sn2(struct xpc_partition *part)
        spin_unlock_irqrestore(&part->chctl_lock, irq_flags);
 
        dev_dbg(xpc_chan, "received notify IRQ from partid=%d, chctl.all_flags="
-               "0x%lx\n", XPC_PARTID(part), chctl.all_flags);
+               "0x%llx\n", XPC_PARTID(part), chctl.all_flags);
 
        xpc_wakeup_channel_mgr(part);
 }
@@ -249,7 +307,7 @@ xpc_handle_notify_IRQ_sn2(int irq, void *dev_id)
        short partid = (short)(u64)dev_id;
        struct xpc_partition *part = &xpc_partitions[partid];
 
-       DBUG_ON(partid < 0 || partid >= xp_max_npartitions);
+       DBUG_ON(partid < 0 || partid >= XP_MAX_NPARTITIONS_SN2);
 
        if (xpc_part_ref(part)) {
                xpc_check_for_sent_chctl_flags_sn2(part);
@@ -292,7 +350,7 @@ xpc_send_notify_IRQ_sn2(struct xpc_channel *ch, u8 chctl_flag,
        union xpc_channel_ctl_flags chctl = { 0 };
        enum xp_retval ret;
 
-       if (likely(part->act_state != XPC_P_DEACTIVATING)) {
+       if (likely(part->act_state != XPC_P_AS_DEACTIVATING)) {
                chctl.flags[ch->number] = chctl_flag;
                ret = xpc_send_IRQ_sn2(part_sn2->remote_chctl_amo_va,
                                       chctl.all_flags,
@@ -340,7 +398,7 @@ static void
 xpc_send_chctl_closerequest_sn2(struct xpc_channel *ch,
                                unsigned long *irq_flags)
 {
-       struct xpc_openclose_args *args = ch->local_openclose_args;
+       struct xpc_openclose_args *args = ch->sn.sn2.local_openclose_args;
 
        args->reason = ch->reason;
        XPC_SEND_NOTIFY_IRQ_SN2(ch, XPC_CHCTL_CLOSEREQUEST, irq_flags);
@@ -355,9 +413,9 @@ xpc_send_chctl_closereply_sn2(struct xpc_channel *ch, unsigned long *irq_flags)
 static void
 xpc_send_chctl_openrequest_sn2(struct xpc_channel *ch, unsigned long *irq_flags)
 {
-       struct xpc_openclose_args *args = ch->local_openclose_args;
+       struct xpc_openclose_args *args = ch->sn.sn2.local_openclose_args;
 
-       args->msg_size = ch->msg_size;
+       args->entry_size = ch->entry_size;
        args->local_nentries = ch->local_nentries;
        XPC_SEND_NOTIFY_IRQ_SN2(ch, XPC_CHCTL_OPENREQUEST, irq_flags);
 }
@@ -365,15 +423,22 @@ xpc_send_chctl_openrequest_sn2(struct xpc_channel *ch, unsigned long *irq_flags)
 static void
 xpc_send_chctl_openreply_sn2(struct xpc_channel *ch, unsigned long *irq_flags)
 {
-       struct xpc_openclose_args *args = ch->local_openclose_args;
+       struct xpc_openclose_args *args = ch->sn.sn2.local_openclose_args;
 
        args->remote_nentries = ch->remote_nentries;
        args->local_nentries = ch->local_nentries;
-       args->local_msgqueue_pa = __pa(ch->local_msgqueue);
+       args->local_msgqueue_pa = xp_pa(ch->sn.sn2.local_msgqueue);
        XPC_SEND_NOTIFY_IRQ_SN2(ch, XPC_CHCTL_OPENREPLY, irq_flags);
 }
 
 static void
+xpc_send_chctl_opencomplete_sn2(struct xpc_channel *ch,
+                               unsigned long *irq_flags)
+{
+       XPC_SEND_NOTIFY_IRQ_SN2(ch, XPC_CHCTL_OPENCOMPLETE, irq_flags);
+}
+
+static void
 xpc_send_chctl_msgrequest_sn2(struct xpc_channel *ch)
 {
        XPC_SEND_NOTIFY_IRQ_SN2(ch, XPC_CHCTL_MSGREQUEST, NULL);
@@ -385,6 +450,14 @@ xpc_send_chctl_local_msgrequest_sn2(struct xpc_channel *ch)
        XPC_SEND_LOCAL_NOTIFY_IRQ_SN2(ch, XPC_CHCTL_MSGREQUEST);
 }
 
+static enum xp_retval
+xpc_save_remote_msgqueue_pa_sn2(struct xpc_channel *ch,
+                               unsigned long msgqueue_pa)
+{
+       ch->sn.sn2.remote_msgqueue_pa = msgqueue_pa;
+       return xpSuccess;
+}
+
 /*
  * This next set of functions are used to keep track of when a partition is
  * potentially engaged in accessing memory belonging to another partition.
@@ -395,14 +468,15 @@ xpc_indicate_partition_engaged_sn2(struct xpc_partition *part)
 {
        unsigned long irq_flags;
        struct amo *amo = (struct amo *)__va(part->sn.sn2.remote_amos_page_pa +
-                                            (XPC_ENGAGED_PARTITIONS_AMO *
+                                            (XPC_ENGAGED_PARTITIONS_AMO_SN2 *
                                             sizeof(struct amo)));
 
        local_irq_save(irq_flags);
 
        /* set bit corresponding to our partid in remote partition's amo */
        FETCHOP_STORE_OP(TO_AMO((u64)&amo->variable), FETCHOP_OR,
-                        (1UL << sn_partition_id));
+                        BIT(sn_partition_id));
+
        /*
         * We must always use the nofault function regardless of whether we
         * are on a Shub 1.1 system or a Shub 1.2 slice 0xc processor. If we
@@ -422,14 +496,15 @@ xpc_indicate_partition_disengaged_sn2(struct xpc_partition *part)
        struct xpc_partition_sn2 *part_sn2 = &part->sn.sn2;
        unsigned long irq_flags;
        struct amo *amo = (struct amo *)__va(part_sn2->remote_amos_page_pa +
-                                            (XPC_ENGAGED_PARTITIONS_AMO *
+                                            (XPC_ENGAGED_PARTITIONS_AMO_SN2 *
                                             sizeof(struct amo)));
 
        local_irq_save(irq_flags);
 
        /* clear bit corresponding to our partid in remote partition's amo */
        FETCHOP_STORE_OP(TO_AMO((u64)&amo->variable), FETCHOP_AND,
-                        ~(1UL << sn_partition_id));
+                        ~BIT(sn_partition_id));
+
        /*
         * We must always use the nofault function regardless of whether we
         * are on a Shub 1.1 system or a Shub 1.2 slice 0xc processor. If we
@@ -452,35 +527,38 @@ xpc_indicate_partition_disengaged_sn2(struct xpc_partition *part)
                                  part_sn2->activate_IRQ_phys_cpuid);
 }
 
+static void
+xpc_assume_partition_disengaged_sn2(short partid)
+{
+       struct amo *amo = xpc_vars_sn2->amos_page +
+                         XPC_ENGAGED_PARTITIONS_AMO_SN2;
+
+       /* clear bit(s) based on partid mask in our partition's amo */
+       FETCHOP_STORE_OP(TO_AMO((u64)&amo->variable), FETCHOP_AND,
+                        ~BIT(partid));
+}
+
 static int
 xpc_partition_engaged_sn2(short partid)
 {
-       struct amo *amo = xpc_vars->amos_page + XPC_ENGAGED_PARTITIONS_AMO;
+       struct amo *amo = xpc_vars_sn2->amos_page +
+                         XPC_ENGAGED_PARTITIONS_AMO_SN2;
 
        /* our partition's amo variable ANDed with partid mask */
        return (FETCHOP_LOAD_OP(TO_AMO((u64)&amo->variable), FETCHOP_LOAD) &
-               (1UL << partid)) != 0;
+               BIT(partid)) != 0;
 }
 
 static int
 xpc_any_partition_engaged_sn2(void)
 {
-       struct amo *amo = xpc_vars->amos_page + XPC_ENGAGED_PARTITIONS_AMO;
+       struct amo *amo = xpc_vars_sn2->amos_page +
+                         XPC_ENGAGED_PARTITIONS_AMO_SN2;
 
        /* our partition's amo variable */
        return FETCHOP_LOAD_OP(TO_AMO((u64)&amo->variable), FETCHOP_LOAD) != 0;
 }
 
-static void
-xpc_assume_partition_disengaged_sn2(short partid)
-{
-       struct amo *amo = xpc_vars->amos_page + XPC_ENGAGED_PARTITIONS_AMO;
-
-       /* clear bit(s) based on partid mask in our partition's amo */
-       FETCHOP_STORE_OP(TO_AMO((u64)&amo->variable), FETCHOP_AND,
-                        ~(1UL << partid));
-}
-
 /* original protection values for each node */
 static u64 xpc_prot_vec_sn2[MAX_NUMNODES];
 
@@ -490,22 +568,17 @@ static u64 xpc_prot_vec_sn2[MAX_NUMNODES];
 static enum xp_retval
 xpc_allow_amo_ops_sn2(struct amo *amos_page)
 {
-       u64 nasid_array = 0;
-       int ret;
+       enum xp_retval ret = xpSuccess;
 
        /*
         * On SHUB 1.1, we cannot call sn_change_memprotect() since the BIST
         * collides with memory operations. On those systems we call
         * xpc_allow_amo_ops_shub_wars_1_1_sn2() instead.
         */
-       if (!enable_shub_wars_1_1()) {
-               ret = sn_change_memprotect(ia64_tpa((u64)amos_page), PAGE_SIZE,
-                                          SN_MEMPROT_ACCESS_CLASS_1,
-                                          &nasid_array);
-               if (ret != 0)
-                       return xpSalError;
-       }
-       return xpSuccess;
+       if (!enable_shub_wars_1_1())
+               ret = xp_expand_memprotect(ia64_tpa((u64)amos_page), PAGE_SIZE);
+
+       return ret;
 }
 
 /*
@@ -537,38 +610,58 @@ xpc_allow_amo_ops_shub_wars_1_1_sn2(void)
 }
 
 static enum xp_retval
-xpc_rsvd_page_init_sn2(struct xpc_rsvd_page *rp)
+xpc_get_partition_rsvd_page_pa_sn2(void *buf, u64 *cookie, unsigned long *rp_pa,
+                                  size_t *len)
+{
+       s64 status;
+       enum xp_retval ret;
+
+       status = sn_partition_reserved_page_pa((u64)buf, cookie,
+                       (u64 *)rp_pa, (u64 *)len);
+       if (status == SALRET_OK)
+               ret = xpSuccess;
+       else if (status == SALRET_MORE_PASSES)
+               ret = xpNeedMoreInfo;
+       else
+               ret = xpSalError;
+
+       return ret;
+}
+
+
+static int
+xpc_setup_rsvd_page_sn2(struct xpc_rsvd_page *rp)
 {
        struct amo *amos_page;
        int i;
        int ret;
 
-       xpc_vars = XPC_RP_VARS(rp);
+       xpc_vars_sn2 = XPC_RP_VARS(rp);
 
-       rp->sn.vars_pa = __pa(xpc_vars);
+       rp->sn.sn2.vars_pa = xp_pa(xpc_vars_sn2);
 
        /* vars_part array follows immediately after vars */
-       xpc_vars_part = (struct xpc_vars_part_sn2 *)((u8 *)XPC_RP_VARS(rp) +
-                                                    XPC_RP_VARS_SIZE);
+       xpc_vars_part_sn2 = (struct xpc_vars_part_sn2 *)((u8 *)XPC_RP_VARS(rp) +
+                                                        XPC_RP_VARS_SIZE);
 
        /*
-        * Before clearing xpc_vars, see if a page of amos had been previously
-        * allocated. If not we'll need to allocate one and set permissions
-        * so that cross-partition amos are allowed.
+        * Before clearing xpc_vars_sn2, see if a page of amos had been
+        * previously allocated. If not we'll need to allocate one and set
+        * permissions so that cross-partition amos are allowed.
         *
         * The allocated amo page needs MCA reporting to remain disabled after
         * XPC has unloaded.  To make this work, we keep a copy of the pointer
-        * to this page (i.e., amos_page) in the struct xpc_vars structure,
+        * to this page (i.e., amos_page) in the struct xpc_vars_sn2 structure,
         * which is pointed to by the reserved page, and re-use that saved copy
         * on subsequent loads of XPC. This amo page is never freed, and its
         * memory protections are never restricted.
         */
-       amos_page = xpc_vars->amos_page;
+       amos_page = xpc_vars_sn2->amos_page;
        if (amos_page == NULL) {
                amos_page = (struct amo *)TO_AMO(uncached_alloc_page(0, 1));
                if (amos_page == NULL) {
                        dev_err(xpc_part, "can't allocate page of amos\n");
-                       return xpNoMemory;
+                       return -ENOMEM;
                }
 
                /*
@@ -580,62 +673,88 @@ xpc_rsvd_page_init_sn2(struct xpc_rsvd_page *rp)
                        dev_err(xpc_part, "can't allow amo operations\n");
                        uncached_free_page(__IA64_UNCACHED_OFFSET |
                                           TO_PHYS((u64)amos_page), 1);
-                       return ret;
+                       return -EPERM;
                }
        }
 
-       /* clear xpc_vars */
-       memset(xpc_vars, 0, sizeof(struct xpc_vars_sn2));
+       /* clear xpc_vars_sn2 */
+       memset(xpc_vars_sn2, 0, sizeof(struct xpc_vars_sn2));
 
-       xpc_vars->version = XPC_V_VERSION;
-       xpc_vars->activate_IRQ_nasid = cpuid_to_nasid(0);
-       xpc_vars->activate_IRQ_phys_cpuid = cpu_physical_id(0);
-       xpc_vars->vars_part_pa = __pa(xpc_vars_part);
-       xpc_vars->amos_page_pa = ia64_tpa((u64)amos_page);
-       xpc_vars->amos_page = amos_page;        /* save for next load of XPC */
+       xpc_vars_sn2->version = XPC_V_VERSION;
+       xpc_vars_sn2->activate_IRQ_nasid = cpuid_to_nasid(0);
+       xpc_vars_sn2->activate_IRQ_phys_cpuid = cpu_physical_id(0);
+       xpc_vars_sn2->vars_part_pa = xp_pa(xpc_vars_part_sn2);
+       xpc_vars_sn2->amos_page_pa = ia64_tpa((u64)amos_page);
+       xpc_vars_sn2->amos_page = amos_page;    /* save for next load of XPC */
 
-       /* clear xpc_vars_part */
-       memset((u64 *)xpc_vars_part, 0, sizeof(struct xpc_vars_part_sn2) *
-              xp_max_npartitions);
+       /* clear xpc_vars_part_sn2 */
+       memset((u64 *)xpc_vars_part_sn2, 0, sizeof(struct xpc_vars_part_sn2) *
+              XP_MAX_NPARTITIONS_SN2);
 
        /* initialize the activate IRQ related amo variables */
-       for (i = 0; i < xp_nasid_mask_words; i++)
-               (void)xpc_init_IRQ_amo_sn2(XPC_ACTIVATE_IRQ_AMOS + i);
+       for (i = 0; i < xpc_nasid_mask_nlongs; i++)
+               (void)xpc_init_IRQ_amo_sn2(XPC_ACTIVATE_IRQ_AMOS_SN2 + i);
 
        /* initialize the engaged remote partitions related amo variables */
-       (void)xpc_init_IRQ_amo_sn2(XPC_ENGAGED_PARTITIONS_AMO);
-       (void)xpc_init_IRQ_amo_sn2(XPC_DEACTIVATE_REQUEST_AMO);
+       (void)xpc_init_IRQ_amo_sn2(XPC_ENGAGED_PARTITIONS_AMO_SN2);
+       (void)xpc_init_IRQ_amo_sn2(XPC_DEACTIVATE_REQUEST_AMO_SN2);
 
-       return xpSuccess;
+       return 0;
+}
+
+static int
+xpc_hb_allowed_sn2(short partid, void *heartbeating_to_mask)
+{
+       return test_bit(partid, heartbeating_to_mask);
+}
+
+static void
+xpc_allow_hb_sn2(short partid)
+{
+       DBUG_ON(xpc_vars_sn2 == NULL);
+       set_bit(partid, xpc_vars_sn2->heartbeating_to_mask);
+}
+
+static void
+xpc_disallow_hb_sn2(short partid)
+{
+       DBUG_ON(xpc_vars_sn2 == NULL);
+       clear_bit(partid, xpc_vars_sn2->heartbeating_to_mask);
+}
+
+static void
+xpc_disallow_all_hbs_sn2(void)
+{
+       DBUG_ON(xpc_vars_sn2 == NULL);
+       bitmap_zero(xpc_vars_sn2->heartbeating_to_mask, xp_max_npartitions);
 }
 
 static void
 xpc_increment_heartbeat_sn2(void)
 {
-       xpc_vars->heartbeat++;
+       xpc_vars_sn2->heartbeat++;
 }
 
 static void
 xpc_offline_heartbeat_sn2(void)
 {
        xpc_increment_heartbeat_sn2();
-       xpc_vars->heartbeat_offline = 1;
+       xpc_vars_sn2->heartbeat_offline = 1;
 }
 
 static void
 xpc_online_heartbeat_sn2(void)
 {
        xpc_increment_heartbeat_sn2();
-       xpc_vars->heartbeat_offline = 0;
+       xpc_vars_sn2->heartbeat_offline = 0;
 }
 
 static void
 xpc_heartbeat_init_sn2(void)
 {
-       DBUG_ON(xpc_vars == NULL);
+       DBUG_ON(xpc_vars_sn2 == NULL);
 
-       bitmap_zero(xpc_vars->heartbeating_to_mask, XP_MAX_NPARTITIONS_SN2);
-       xpc_heartbeating_to_mask = &xpc_vars->heartbeating_to_mask[0];
+       bitmap_zero(xpc_vars_sn2->heartbeating_to_mask, XP_MAX_NPARTITIONS_SN2);
        xpc_online_heartbeat_sn2();
 }
 
@@ -645,61 +764,37 @@ xpc_heartbeat_exit_sn2(void)
        xpc_offline_heartbeat_sn2();
 }
 
-/*
- * At periodic intervals, scan through all active partitions and ensure
- * their heartbeat is still active.  If not, the partition is deactivated.
- */
-static void
-xpc_check_remote_hb_sn2(void)
+static enum xp_retval
+xpc_get_remote_heartbeat_sn2(struct xpc_partition *part)
 {
        struct xpc_vars_sn2 *remote_vars;
-       struct xpc_partition *part;
-       short partid;
        enum xp_retval ret;
 
-       remote_vars = (struct xpc_vars_sn2 *)xpc_remote_copy_buffer;
-
-       for (partid = 0; partid < xp_max_npartitions; partid++) {
-
-               if (xpc_exiting)
-                       break;
+       remote_vars = (struct xpc_vars_sn2 *)xpc_remote_copy_buffer_sn2;
 
-               if (partid == sn_partition_id)
-                       continue;
-
-               part = &xpc_partitions[partid];
-
-               if (part->act_state == XPC_P_INACTIVE ||
-                   part->act_state == XPC_P_DEACTIVATING) {
-                       continue;
-               }
-
-               /* pull the remote_hb cache line */
-               ret = xp_remote_memcpy(remote_vars,
-                                      (void *)part->sn.sn2.remote_vars_pa,
-                                      XPC_RP_VARS_SIZE);
-               if (ret != xpSuccess) {
-                       XPC_DEACTIVATE_PARTITION(part, ret);
-                       continue;
-               }
-
-               dev_dbg(xpc_part, "partid = %d, heartbeat = %ld, last_heartbeat"
-                       " = %ld, heartbeat_offline = %ld, HB_mask[0] = 0x%lx\n",
-                       partid, remote_vars->heartbeat, part->last_heartbeat,
-                       remote_vars->heartbeat_offline,
-                       remote_vars->heartbeating_to_mask[0]);
-
-               if (((remote_vars->heartbeat == part->last_heartbeat) &&
-                    (remote_vars->heartbeat_offline == 0)) ||
-                   !xpc_hb_allowed(sn_partition_id,
-                                   &remote_vars->heartbeating_to_mask)) {
-
-                       XPC_DEACTIVATE_PARTITION(part, xpNoHeartbeat);
-                       continue;
-               }
+       /* pull the remote vars structure that contains the heartbeat */
+       ret = xp_remote_memcpy(xp_pa(remote_vars),
+                              part->sn.sn2.remote_vars_pa,
+                              XPC_RP_VARS_SIZE);
+       if (ret != xpSuccess)
+               return ret;
 
+       dev_dbg(xpc_part, "partid=%d, heartbeat=%lld, last_heartbeat=%lld, "
+               "heartbeat_offline=%lld, HB_mask[0]=0x%lx\n", XPC_PARTID(part),
+               remote_vars->heartbeat, part->last_heartbeat,
+               remote_vars->heartbeat_offline,
+               remote_vars->heartbeating_to_mask[0]);
+
+       if ((remote_vars->heartbeat == part->last_heartbeat &&
+           !remote_vars->heartbeat_offline) ||
+           !xpc_hb_allowed_sn2(sn_partition_id,
+                               remote_vars->heartbeating_to_mask)) {
+               ret = xpNoHeartbeat;
+       } else {
                part->last_heartbeat = remote_vars->heartbeat;
        }
+
+       return ret;
 }
 
 /*
@@ -709,7 +804,8 @@ xpc_check_remote_hb_sn2(void)
  * assumed to be of size XPC_RP_VARS_SIZE.
  */
 static enum xp_retval
-xpc_get_remote_vars_sn2(u64 remote_vars_pa, struct xpc_vars_sn2 *remote_vars)
+xpc_get_remote_vars_sn2(unsigned long remote_vars_pa,
+                       struct xpc_vars_sn2 *remote_vars)
 {
        enum xp_retval ret;
 
@@ -717,7 +813,7 @@ xpc_get_remote_vars_sn2(u64 remote_vars_pa, struct xpc_vars_sn2 *remote_vars)
                return xpVarsNotSet;
 
        /* pull over the cross partition variables */
-       ret = xp_remote_memcpy(remote_vars, (void *)remote_vars_pa,
+       ret = xp_remote_memcpy(xp_pa(remote_vars), remote_vars_pa,
                               XPC_RP_VARS_SIZE);
        if (ret != xpSuccess)
                return ret;
@@ -732,7 +828,7 @@ xpc_get_remote_vars_sn2(u64 remote_vars_pa, struct xpc_vars_sn2 *remote_vars)
 
 static void
 xpc_request_partition_activation_sn2(struct xpc_rsvd_page *remote_rp,
-                                    u64 remote_rp_pa, int nasid)
+                                    unsigned long remote_rp_pa, int nasid)
 {
        xpc_send_local_activate_IRQ_sn2(nasid);
 }
@@ -749,14 +845,15 @@ xpc_request_partition_deactivation_sn2(struct xpc_partition *part)
        struct xpc_partition_sn2 *part_sn2 = &part->sn.sn2;
        unsigned long irq_flags;
        struct amo *amo = (struct amo *)__va(part_sn2->remote_amos_page_pa +
-                                            (XPC_DEACTIVATE_REQUEST_AMO *
+                                            (XPC_DEACTIVATE_REQUEST_AMO_SN2 *
                                             sizeof(struct amo)));
 
        local_irq_save(irq_flags);
 
        /* set bit corresponding to our partid in remote partition's amo */
        FETCHOP_STORE_OP(TO_AMO((u64)&amo->variable), FETCHOP_OR,
-                        (1UL << sn_partition_id));
+                        BIT(sn_partition_id));
+
        /*
         * We must always use the nofault function regardless of whether we
         * are on a Shub 1.1 system or a Shub 1.2 slice 0xc processor. If we
@@ -784,14 +881,15 @@ xpc_cancel_partition_deactivation_request_sn2(struct xpc_partition *part)
 {
        unsigned long irq_flags;
        struct amo *amo = (struct amo *)__va(part->sn.sn2.remote_amos_page_pa +
-                                            (XPC_DEACTIVATE_REQUEST_AMO *
+                                            (XPC_DEACTIVATE_REQUEST_AMO_SN2 *
                                             sizeof(struct amo)));
 
        local_irq_save(irq_flags);
 
        /* clear bit corresponding to our partid in remote partition's amo */
        FETCHOP_STORE_OP(TO_AMO((u64)&amo->variable), FETCHOP_AND,
-                        ~(1UL << sn_partition_id));
+                        ~BIT(sn_partition_id));
+
        /*
         * We must always use the nofault function regardless of whether we
         * are on a Shub 1.1 system or a Shub 1.2 slice 0xc processor. If we
@@ -808,11 +906,12 @@ xpc_cancel_partition_deactivation_request_sn2(struct xpc_partition *part)
 static int
 xpc_partition_deactivation_requested_sn2(short partid)
 {
-       struct amo *amo = xpc_vars->amos_page + XPC_DEACTIVATE_REQUEST_AMO;
+       struct amo *amo = xpc_vars_sn2->amos_page +
+                         XPC_DEACTIVATE_REQUEST_AMO_SN2;
 
        /* our partition's amo variable ANDed with partid mask */
        return (FETCHOP_LOAD_OP(TO_AMO((u64)&amo->variable), FETCHOP_LOAD) &
-               (1UL << partid)) != 0;
+               BIT(partid)) != 0;
 }
 
 /*
@@ -820,8 +919,9 @@ xpc_partition_deactivation_requested_sn2(short partid)
  */
 static void
 xpc_update_partition_info_sn2(struct xpc_partition *part, u8 remote_rp_version,
-                             unsigned long *remote_rp_stamp, u64 remote_rp_pa,
-                             u64 remote_vars_pa,
+                             unsigned long *remote_rp_ts_jiffies,
+                             unsigned long remote_rp_pa,
+                             unsigned long remote_vars_pa,
                              struct xpc_vars_sn2 *remote_vars)
 {
        struct xpc_partition_sn2 *part_sn2 = &part->sn.sn2;
@@ -830,9 +930,9 @@ xpc_update_partition_info_sn2(struct xpc_partition *part, u8 remote_rp_version,
        dev_dbg(xpc_part, "  remote_rp_version = 0x%016x\n",
                part->remote_rp_version);
 
-       part->remote_rp_stamp = *remote_rp_stamp;
-       dev_dbg(xpc_part, "  remote_rp_stamp = 0x%016lx\n",
-               part->remote_rp_stamp);
+       part->remote_rp_ts_jiffies = *remote_rp_ts_jiffies;
+       dev_dbg(xpc_part, "  remote_rp_ts_jiffies = 0x%016lx\n",
+               part->remote_rp_ts_jiffies);
 
        part->remote_rp_pa = remote_rp_pa;
        dev_dbg(xpc_part, "  remote_rp_pa = 0x%016lx\n", part->remote_rp_pa);
@@ -841,8 +941,8 @@ xpc_update_partition_info_sn2(struct xpc_partition *part, u8 remote_rp_version,
        dev_dbg(xpc_part, "  remote_vars_pa = 0x%016lx\n",
                part_sn2->remote_vars_pa);
 
-       part->last_heartbeat = remote_vars->heartbeat;
-       dev_dbg(xpc_part, "  last_heartbeat = 0x%016lx\n",
+       part->last_heartbeat = remote_vars->heartbeat - 1;
+       dev_dbg(xpc_part, "  last_heartbeat = 0x%016llx\n",
                part->last_heartbeat);
 
        part_sn2->remote_vars_part_pa = remote_vars->vars_part_pa;
@@ -886,11 +986,11 @@ xpc_identify_activate_IRQ_req_sn2(int nasid)
 {
        struct xpc_rsvd_page *remote_rp;
        struct xpc_vars_sn2 *remote_vars;
-       u64 remote_rp_pa;
-       u64 remote_vars_pa;
+       unsigned long remote_rp_pa;
+       unsigned long remote_vars_pa;
        int remote_rp_version;
        int reactivate = 0;
-       unsigned long remote_rp_stamp = 0;
+       unsigned long remote_rp_ts_jiffies = 0;
        short partid;
        struct xpc_partition *part;
        struct xpc_partition_sn2 *part_sn2;
@@ -898,7 +998,7 @@ xpc_identify_activate_IRQ_req_sn2(int nasid)
 
        /* pull over the reserved page structure */
 
-       remote_rp = (struct xpc_rsvd_page *)xpc_remote_copy_buffer;
+       remote_rp = (struct xpc_rsvd_page *)xpc_remote_copy_buffer_sn2;
 
        ret = xpc_get_remote_rp(nasid, NULL, remote_rp, &remote_rp_pa);
        if (ret != xpSuccess) {
@@ -907,9 +1007,9 @@ xpc_identify_activate_IRQ_req_sn2(int nasid)
                return;
        }
 
-       remote_vars_pa = remote_rp->sn.vars_pa;
+       remote_vars_pa = remote_rp->sn.sn2.vars_pa;
        remote_rp_version = remote_rp->version;
-       remote_rp_stamp = remote_rp->stamp;
+       remote_rp_ts_jiffies = remote_rp->ts_jiffies;
 
        partid = remote_rp->SAL_partid;
        part = &xpc_partitions[partid];
@@ -917,7 +1017,7 @@ xpc_identify_activate_IRQ_req_sn2(int nasid)
 
        /* pull over the cross partition variables */
 
-       remote_vars = (struct xpc_vars_sn2 *)xpc_remote_copy_buffer;
+       remote_vars = (struct xpc_vars_sn2 *)xpc_remote_copy_buffer_sn2;
 
        ret = xpc_get_remote_vars_sn2(remote_vars_pa, remote_vars);
        if (ret != xpSuccess) {
@@ -931,15 +1031,17 @@ xpc_identify_activate_IRQ_req_sn2(int nasid)
        part->activate_IRQ_rcvd++;
 
        dev_dbg(xpc_part, "partid for nasid %d is %d; IRQs = %d; HB = "
-               "%ld:0x%lx\n", (int)nasid, (int)partid, part->activate_IRQ_rcvd,
+               "%lld:0x%lx\n", (int)nasid, (int)partid,
+               part->activate_IRQ_rcvd,
                remote_vars->heartbeat, remote_vars->heartbeating_to_mask[0]);
 
        if (xpc_partition_disengaged(part) &&
-           part->act_state == XPC_P_INACTIVE) {
+           part->act_state == XPC_P_AS_INACTIVE) {
 
                xpc_update_partition_info_sn2(part, remote_rp_version,
-                                             &remote_rp_stamp, remote_rp_pa,
-                                             remote_vars_pa, remote_vars);
+                                             &remote_rp_ts_jiffies,
+                                             remote_rp_pa, remote_vars_pa,
+                                             remote_vars);
 
                if (xpc_partition_deactivation_requested_sn2(partid)) {
                        /*
@@ -956,7 +1058,7 @@ xpc_identify_activate_IRQ_req_sn2(int nasid)
        DBUG_ON(part->remote_rp_version == 0);
        DBUG_ON(part_sn2->remote_vars_version == 0);
 
-       if (remote_rp_stamp != part->remote_rp_stamp) {
+       if (remote_rp_ts_jiffies != part->remote_rp_ts_jiffies) {
 
                /* the other side rebooted */
 
@@ -964,8 +1066,9 @@ xpc_identify_activate_IRQ_req_sn2(int nasid)
                DBUG_ON(xpc_partition_deactivation_requested_sn2(partid));
 
                xpc_update_partition_info_sn2(part, remote_rp_version,
-                                             &remote_rp_stamp, remote_rp_pa,
-                                             remote_vars_pa, remote_vars);
+                                             &remote_rp_ts_jiffies,
+                                             remote_rp_pa, remote_vars_pa,
+                                             remote_vars);
                reactivate = 1;
        }
 
@@ -990,28 +1093,31 @@ xpc_identify_activate_IRQ_req_sn2(int nasid)
 int
 xpc_identify_activate_IRQ_sender_sn2(void)
 {
-       int word, bit;
-       u64 nasid_mask;
+       int l;
+       int b;
+       unsigned long nasid_mask_long;
        u64 nasid;              /* remote nasid */
        int n_IRQs_detected = 0;
        struct amo *act_amos;
 
-       act_amos = xpc_vars->amos_page + XPC_ACTIVATE_IRQ_AMOS;
+       act_amos = xpc_vars_sn2->amos_page + XPC_ACTIVATE_IRQ_AMOS_SN2;
 
-       /* scan through act amo variable looking for non-zero entries */
-       for (word = 0; word < xp_nasid_mask_words; word++) {
+       /* scan through activate amo variables looking for non-zero entries */
+       for (l = 0; l < xpc_nasid_mask_nlongs; l++) {
 
                if (xpc_exiting)
                        break;
 
-               nasid_mask = xpc_receive_IRQ_amo_sn2(&act_amos[word]);
-               if (nasid_mask == 0) {
-                       /* no IRQs from nasids in this variable */
+               nasid_mask_long = xpc_receive_IRQ_amo_sn2(&act_amos[l]);
+
+               b = find_first_bit(&nasid_mask_long, BITS_PER_LONG);
+               if (b >= BITS_PER_LONG) {
+                       /* no IRQs from nasids in this amo variable */
                        continue;
                }
 
-               dev_dbg(xpc_part, "amo[%d] gave back 0x%lx\n", word,
-                       nasid_mask);
+               dev_dbg(xpc_part, "amo[%d] gave back 0x%lx\n", l,
+                       nasid_mask_long);
 
                /*
                 * If this nasid has been added to the machine since
@@ -1019,28 +1125,35 @@ xpc_identify_activate_IRQ_sender_sn2(void)
                 * remote nasid in our reserved pages machine mask.
                 * This is used in the event of module reload.
                 */
-               xpc_mach_nasids[word] |= nasid_mask;
+               xpc_mach_nasids[l] |= nasid_mask_long;
 
                /* locate the nasid(s) which sent interrupts */
 
-               for (bit = 0; bit < (8 * sizeof(u64)); bit++) {
-                       if (nasid_mask & (1UL << bit)) {
-                               n_IRQs_detected++;
-                               nasid = XPC_NASID_FROM_W_B(word, bit);
-                               dev_dbg(xpc_part, "interrupt from nasid %ld\n",
-                                       nasid);
-                               xpc_identify_activate_IRQ_req_sn2(nasid);
-                       }
-               }
+               do {
+                       n_IRQs_detected++;
+                       nasid = (l * BITS_PER_LONG + b) * 2;
+                       dev_dbg(xpc_part, "interrupt from nasid %lld\n", nasid);
+                       xpc_identify_activate_IRQ_req_sn2(nasid);
+
+                       b = find_next_bit(&nasid_mask_long, BITS_PER_LONG,
+                                         b + 1);
+               } while (b < BITS_PER_LONG);
        }
        return n_IRQs_detected;
 }
 
 static void
-xpc_process_activate_IRQ_rcvd_sn2(int n_IRQs_expected)
+xpc_process_activate_IRQ_rcvd_sn2(void)
 {
+       unsigned long irq_flags;
+       int n_IRQs_expected;
        int n_IRQs_detected;
 
+       spin_lock_irqsave(&xpc_activate_IRQ_rcvd_lock, irq_flags);
+       n_IRQs_expected = xpc_activate_IRQ_rcvd;
+       xpc_activate_IRQ_rcvd = 0;
+       spin_unlock_irqrestore(&xpc_activate_IRQ_rcvd_lock, irq_flags);
+
        n_IRQs_detected = xpc_identify_activate_IRQ_sender_sn2();
        if (n_IRQs_detected < n_IRQs_expected) {
                /* retry once to help avoid missing amo */
@@ -1049,92 +1162,63 @@ xpc_process_activate_IRQ_rcvd_sn2(int n_IRQs_expected)
 }
 
 /*
- * Setup the infrastructure necessary to support XPartition Communication
- * between the specified remote partition and the local one.
+ * Setup the channel structures that are sn2 specific.
  */
 static enum xp_retval
-xpc_setup_infrastructure_sn2(struct xpc_partition *part)
+xpc_setup_ch_structures_sn2(struct xpc_partition *part)
 {
        struct xpc_partition_sn2 *part_sn2 = &part->sn.sn2;
+       struct xpc_channel_sn2 *ch_sn2;
        enum xp_retval retval;
        int ret;
        int cpuid;
        int ch_number;
-       struct xpc_channel *ch;
        struct timer_list *timer;
        short partid = XPC_PARTID(part);
 
-       /*
-        * Allocate all of the channel structures as a contiguous chunk of
-        * memory.
-        */
-       DBUG_ON(part->channels != NULL);
-       part->channels = kzalloc(sizeof(struct xpc_channel) * XPC_MAX_NCHANNELS,
-                                GFP_KERNEL);
-       if (part->channels == NULL) {
-               dev_err(xpc_chan, "can't get memory for channels\n");
-               return xpNoMemory;
-       }
-
        /* allocate all the required GET/PUT values */
 
-       part_sn2->local_GPs = xpc_kzalloc_cacheline_aligned(XPC_GP_SIZE,
-                                                           GFP_KERNEL,
-                                                           &part_sn2->
-                                                           local_GPs_base);
+       part_sn2->local_GPs =
+           xpc_kzalloc_cacheline_aligned(XPC_GP_SIZE, GFP_KERNEL,
+                                         &part_sn2->local_GPs_base);
        if (part_sn2->local_GPs == NULL) {
                dev_err(xpc_chan, "can't get memory for local get/put "
                        "values\n");
-               retval = xpNoMemory;
-               goto out_1;
+               return xpNoMemory;
        }
 
-       part_sn2->remote_GPs = xpc_kzalloc_cacheline_aligned(XPC_GP_SIZE,
-                                                            GFP_KERNEL,
-                                                            &part_sn2->
-                                                            remote_GPs_base);
+       part_sn2->remote_GPs =
+           xpc_kzalloc_cacheline_aligned(XPC_GP_SIZE, GFP_KERNEL,
+                                         &part_sn2->remote_GPs_base);
        if (part_sn2->remote_GPs == NULL) {
                dev_err(xpc_chan, "can't get memory for remote get/put "
                        "values\n");
                retval = xpNoMemory;
-               goto out_2;
+               goto out_1;
        }
 
        part_sn2->remote_GPs_pa = 0;
 
        /* allocate all the required open and close args */
 
-       part->local_openclose_args =
-           xpc_kzalloc_cacheline_aligned(XPC_OPENCLOSE_ARGS_SIZE, GFP_KERNEL,
-                                         &part->local_openclose_args_base);
-       if (part->local_openclose_args == NULL) {
+       part_sn2->local_openclose_args =
+           xpc_kzalloc_cacheline_aligned(XPC_OPENCLOSE_ARGS_SIZE,
+                                         GFP_KERNEL, &part_sn2->
+                                         local_openclose_args_base);
+       if (part_sn2->local_openclose_args == NULL) {
                dev_err(xpc_chan, "can't get memory for local connect args\n");
                retval = xpNoMemory;
-               goto out_3;
-       }
-
-       part->remote_openclose_args =
-           xpc_kzalloc_cacheline_aligned(XPC_OPENCLOSE_ARGS_SIZE, GFP_KERNEL,
-                                         &part->remote_openclose_args_base);
-       if (part->remote_openclose_args == NULL) {
-               dev_err(xpc_chan, "can't get memory for remote connect args\n");
-               retval = xpNoMemory;
-               goto out_4;
+               goto out_2;
        }
 
        part_sn2->remote_openclose_args_pa = 0;
 
        part_sn2->local_chctl_amo_va = xpc_init_IRQ_amo_sn2(partid);
-       part->chctl.all_flags = 0;
-       spin_lock_init(&part->chctl_lock);
 
        part_sn2->notify_IRQ_nasid = 0;
        part_sn2->notify_IRQ_phys_cpuid = 0;
        part_sn2->remote_chctl_amo_va = NULL;
 
-       atomic_set(&part->channel_mgr_requests, 1);
-       init_waitqueue_head(&part->channel_mgr_wq);
-
        sprintf(part_sn2->notify_IRQ_owner, "xpc%02d", partid);
        ret = request_irq(SGI_XPC_NOTIFY, xpc_handle_notify_IRQ_sn2,
                          IRQF_SHARED, part_sn2->notify_IRQ_owner,
@@ -1143,7 +1227,7 @@ xpc_setup_infrastructure_sn2(struct xpc_partition *part)
                dev_err(xpc_chan, "can't register NOTIFY IRQ handler, "
                        "errno=%d\n", -ret);
                retval = xpLackOfResources;
-               goto out_5;
+               goto out_3;
        }
 
        /* Setup a timer to check for dropped notify IRQs */
@@ -1155,133 +1239,75 @@ xpc_setup_infrastructure_sn2(struct xpc_partition *part)
        timer->expires = jiffies + XPC_DROPPED_NOTIFY_IRQ_WAIT_INTERVAL;
        add_timer(timer);
 
-       part->nchannels = XPC_MAX_NCHANNELS;
-
-       atomic_set(&part->nchannels_active, 0);
-       atomic_set(&part->nchannels_engaged, 0);
-
        for (ch_number = 0; ch_number < part->nchannels; ch_number++) {
-               ch = &part->channels[ch_number];
-
-               ch->partid = partid;
-               ch->number = ch_number;
-               ch->flags = XPC_C_DISCONNECTED;
-
-               ch->sn.sn2.local_GP = &part_sn2->local_GPs[ch_number];
-               ch->local_openclose_args =
-                   &part->local_openclose_args[ch_number];
-
-               atomic_set(&ch->kthreads_assigned, 0);
-               atomic_set(&ch->kthreads_idle, 0);
-               atomic_set(&ch->kthreads_active, 0);
+               ch_sn2 = &part->channels[ch_number].sn.sn2;
 
-               atomic_set(&ch->references, 0);
-               atomic_set(&ch->n_to_notify, 0);
+               ch_sn2->local_GP = &part_sn2->local_GPs[ch_number];
+               ch_sn2->local_openclose_args =
+                   &part_sn2->local_openclose_args[ch_number];
 
-               spin_lock_init(&ch->lock);
-               mutex_init(&ch->sn.sn2.msg_to_pull_mutex);
-               init_completion(&ch->wdisconnect_wait);
-
-               atomic_set(&ch->n_on_msg_allocate_wq, 0);
-               init_waitqueue_head(&ch->msg_allocate_wq);
-               init_waitqueue_head(&ch->idle_wq);
+               mutex_init(&ch_sn2->msg_to_pull_mutex);
        }
 
        /*
-        * With the setting of the partition setup_state to XPC_P_SETUP, we're
-        * declaring that this partition is ready to go.
-        */
-       part->setup_state = XPC_P_SETUP;
-
-       /*
         * Setup the per partition specific variables required by the
         * remote partition to establish channel connections with us.
         *
         * The setting of the magic # indicates that these per partition
         * specific variables are ready to be used.
         */
-       xpc_vars_part[partid].GPs_pa = __pa(part_sn2->local_GPs);
-       xpc_vars_part[partid].openclose_args_pa =
-           __pa(part->local_openclose_args);
-       xpc_vars_part[partid].chctl_amo_pa = __pa(part_sn2->local_chctl_amo_va);
+       xpc_vars_part_sn2[partid].GPs_pa = xp_pa(part_sn2->local_GPs);
+       xpc_vars_part_sn2[partid].openclose_args_pa =
+           xp_pa(part_sn2->local_openclose_args);
+       xpc_vars_part_sn2[partid].chctl_amo_pa =
+           xp_pa(part_sn2->local_chctl_amo_va);
        cpuid = raw_smp_processor_id(); /* any CPU in this partition will do */
-       xpc_vars_part[partid].notify_IRQ_nasid = cpuid_to_nasid(cpuid);
-       xpc_vars_part[partid].notify_IRQ_phys_cpuid = cpu_physical_id(cpuid);
-       xpc_vars_part[partid].nchannels = part->nchannels;
-       xpc_vars_part[partid].magic = XPC_VP_MAGIC1;
+       xpc_vars_part_sn2[partid].notify_IRQ_nasid = cpuid_to_nasid(cpuid);
+       xpc_vars_part_sn2[partid].notify_IRQ_phys_cpuid =
+           cpu_physical_id(cpuid);
+       xpc_vars_part_sn2[partid].nchannels = part->nchannels;
+       xpc_vars_part_sn2[partid].magic = XPC_VP_MAGIC1_SN2;
 
        return xpSuccess;
 
-       /* setup of infrastructure failed */
-out_5:
-       kfree(part->remote_openclose_args_base);
-       part->remote_openclose_args = NULL;
-out_4:
-       kfree(part->local_openclose_args_base);
-       part->local_openclose_args = NULL;
+       /* setup of ch structures failed */
 out_3:
+       kfree(part_sn2->local_openclose_args_base);
+       part_sn2->local_openclose_args = NULL;
+out_2:
        kfree(part_sn2->remote_GPs_base);
        part_sn2->remote_GPs = NULL;
-out_2:
+out_1:
        kfree(part_sn2->local_GPs_base);
        part_sn2->local_GPs = NULL;
-out_1:
-       kfree(part->channels);
-       part->channels = NULL;
        return retval;
 }
 
 /*
- * Teardown the infrastructure necessary to support XPartition Communication
- * between the specified remote partition and the local one.
+ * Teardown the channel structures that are sn2 specific.
  */
 static void
-xpc_teardown_infrastructure_sn2(struct xpc_partition *part)
+xpc_teardown_ch_structures_sn2(struct xpc_partition *part)
 {
        struct xpc_partition_sn2 *part_sn2 = &part->sn.sn2;
        short partid = XPC_PARTID(part);
 
        /*
-        * We start off by making this partition inaccessible to local
-        * processes by marking it as no longer setup. Then we make it
-        * inaccessible to remote processes by clearing the XPC per partition
-        * specific variable's magic # (which indicates that these variables
-        * are no longer valid) and by ignoring all XPC notify IRQs sent to
-        * this partition.
+        * Indicate that the variables specific to the remote partition are no
+        * longer available for its use.
         */
-
-       DBUG_ON(atomic_read(&part->nchannels_engaged) != 0);
-       DBUG_ON(atomic_read(&part->nchannels_active) != 0);
-       DBUG_ON(part->setup_state != XPC_P_SETUP);
-       part->setup_state = XPC_P_WTEARDOWN;
-
-       xpc_vars_part[partid].magic = 0;
-
-       free_irq(SGI_XPC_NOTIFY, (void *)(u64)partid);
-
-       /*
-        * Before proceeding with the teardown we have to wait until all
-        * existing references cease.
-        */
-       wait_event(part->teardown_wq, (atomic_read(&part->references) == 0));
-
-       /* now we can begin tearing down the infrastructure */
-
-       part->setup_state = XPC_P_TORNDOWN;
+       xpc_vars_part_sn2[partid].magic = 0;
 
        /* in case we've still got outstanding timers registered... */
        del_timer_sync(&part_sn2->dropped_notify_IRQ_timer);
+       free_irq(SGI_XPC_NOTIFY, (void *)(u64)partid);
 
-       kfree(part->remote_openclose_args_base);
-       part->remote_openclose_args = NULL;
-       kfree(part->local_openclose_args_base);
-       part->local_openclose_args = NULL;
+       kfree(part_sn2->local_openclose_args_base);
+       part_sn2->local_openclose_args = NULL;
        kfree(part_sn2->remote_GPs_base);
        part_sn2->remote_GPs = NULL;
        kfree(part_sn2->local_GPs_base);
        part_sn2->local_GPs = NULL;
-       kfree(part->channels);
-       part->channels = NULL;
        part_sn2->local_chctl_amo_va = NULL;
 }
 
@@ -1289,25 +1315,25 @@ xpc_teardown_infrastructure_sn2(struct xpc_partition *part)
  * Create a wrapper that hides the underlying mechanism for pulling a cacheline
  * (or multiple cachelines) from a remote partition.
  *
- * src must be a cacheline aligned physical address on the remote partition.
+ * src_pa must be a cacheline aligned physical address on the remote partition.
  * dst must be a cacheline aligned virtual address on this partition.
  * cnt must be cacheline sized
  */
-/* >>> Replace this function by call to xp_remote_memcpy() or bte_copy()? */
+/* ??? Replace this function by call to xp_remote_memcpy() or bte_copy()? */
 static enum xp_retval
 xpc_pull_remote_cachelines_sn2(struct xpc_partition *part, void *dst,
-                              const void *src, size_t cnt)
+                              const unsigned long src_pa, size_t cnt)
 {
        enum xp_retval ret;
 
-       DBUG_ON((u64)src != L1_CACHE_ALIGN((u64)src));
-       DBUG_ON((u64)dst != L1_CACHE_ALIGN((u64)dst));
+       DBUG_ON(src_pa != L1_CACHE_ALIGN(src_pa));
+       DBUG_ON((unsigned long)dst != L1_CACHE_ALIGN((unsigned long)dst));
        DBUG_ON(cnt != L1_CACHE_ALIGN(cnt));
 
-       if (part->act_state == XPC_P_DEACTIVATING)
+       if (part->act_state == XPC_P_AS_DEACTIVATING)
                return part->reason;
 
-       ret = xp_remote_memcpy(dst, src, cnt);
+       ret = xp_remote_memcpy(xp_pa(dst), src_pa, cnt);
        if (ret != xpSuccess) {
                dev_dbg(xpc_chan, "xp_remote_memcpy() from partition %d failed,"
                        " ret=%d\n", XPC_PARTID(part), ret);
@@ -1327,7 +1353,8 @@ xpc_pull_remote_vars_part_sn2(struct xpc_partition *part)
        struct xpc_vars_part_sn2 *pulled_entry_cacheline =
            (struct xpc_vars_part_sn2 *)L1_CACHE_ALIGN((u64)buffer);
        struct xpc_vars_part_sn2 *pulled_entry;
-       u64 remote_entry_cacheline_pa, remote_entry_pa;
+       unsigned long remote_entry_cacheline_pa;
+       unsigned long remote_entry_pa;
        short partid = XPC_PARTID(part);
        enum xp_retval ret;
 
@@ -1347,7 +1374,7 @@ xpc_pull_remote_vars_part_sn2(struct xpc_partition *part)
                                                    (L1_CACHE_BYTES - 1)));
 
        ret = xpc_pull_remote_cachelines_sn2(part, pulled_entry_cacheline,
-                                            (void *)remote_entry_cacheline_pa,
+                                            remote_entry_cacheline_pa,
                                             L1_CACHE_BYTES);
        if (ret != xpSuccess) {
                dev_dbg(xpc_chan, "failed to pull XPC vars_part from "
@@ -1357,12 +1384,12 @@ xpc_pull_remote_vars_part_sn2(struct xpc_partition *part)
 
        /* see if they've been set up yet */
 
-       if (pulled_entry->magic != XPC_VP_MAGIC1 &&
-           pulled_entry->magic != XPC_VP_MAGIC2) {
+       if (pulled_entry->magic != XPC_VP_MAGIC1_SN2 &&
+           pulled_entry->magic != XPC_VP_MAGIC2_SN2) {
 
                if (pulled_entry->magic != 0) {
                        dev_dbg(xpc_chan, "partition %d's XPC vars_part for "
-                               "partition %d has bad magic value (=0x%lx)\n",
+                               "partition %d has bad magic value (=0x%llx)\n",
                                partid, sn_partition_id, pulled_entry->magic);
                        return xpBadMagic;
                }
@@ -1371,7 +1398,7 @@ xpc_pull_remote_vars_part_sn2(struct xpc_partition *part)
                return xpRetry;
        }
 
-       if (xpc_vars_part[partid].magic == XPC_VP_MAGIC1) {
+       if (xpc_vars_part_sn2[partid].magic == XPC_VP_MAGIC1_SN2) {
 
                /* validate the variables */
 
@@ -1401,10 +1428,10 @@ xpc_pull_remote_vars_part_sn2(struct xpc_partition *part)
 
                /* let the other side know that we've pulled their variables */
 
-               xpc_vars_part[partid].magic = XPC_VP_MAGIC2;
+               xpc_vars_part_sn2[partid].magic = XPC_VP_MAGIC2_SN2;
        }
 
-       if (pulled_entry->magic == XPC_VP_MAGIC1)
+       if (pulled_entry->magic == XPC_VP_MAGIC1_SN2)
                return xpRetry;
 
        return xpSuccess;
@@ -1462,7 +1489,7 @@ xpc_make_first_contact_sn2(struct xpc_partition *part)
                /* wait a 1/4 of a second or so */
                (void)msleep_interruptible(250);
 
-               if (part->act_state == XPC_P_DEACTIVATING)
+               if (part->act_state == XPC_P_AS_DEACTIVATING)
                        return part->reason;
        }
 
@@ -1494,7 +1521,7 @@ xpc_get_chctl_all_flags_sn2(struct xpc_partition *part)
        if (xpc_any_openclose_chctl_flags_set(&chctl)) {
                ret = xpc_pull_remote_cachelines_sn2(part, part->
                                                     remote_openclose_args,
-                                                    (void *)part_sn2->
+                                                    part_sn2->
                                                     remote_openclose_args_pa,
                                                     XPC_OPENCLOSE_ARGS_SIZE);
                if (ret != xpSuccess) {
@@ -1511,7 +1538,7 @@ xpc_get_chctl_all_flags_sn2(struct xpc_partition *part)
 
        if (xpc_any_msg_chctl_flags_set(&chctl)) {
                ret = xpc_pull_remote_cachelines_sn2(part, part_sn2->remote_GPs,
-                                               (void *)part_sn2->remote_GPs_pa,
+                                                    part_sn2->remote_GPs_pa,
                                                     XPC_GP_SIZE);
                if (ret != xpSuccess) {
                        XPC_DEACTIVATE_PARTITION(part, ret);
@@ -1528,18 +1555,165 @@ xpc_get_chctl_all_flags_sn2(struct xpc_partition *part)
 }
 
 /*
+ * Allocate the local message queue and the notify queue.
+ */
+static enum xp_retval
+xpc_allocate_local_msgqueue_sn2(struct xpc_channel *ch)
+{
+       struct xpc_channel_sn2 *ch_sn2 = &ch->sn.sn2;
+       unsigned long irq_flags;
+       int nentries;
+       size_t nbytes;
+
+       for (nentries = ch->local_nentries; nentries > 0; nentries--) {
+
+               nbytes = nentries * ch->entry_size;
+               ch_sn2->local_msgqueue =
+                   xpc_kzalloc_cacheline_aligned(nbytes, GFP_KERNEL,
+                                                 &ch_sn2->local_msgqueue_base);
+               if (ch_sn2->local_msgqueue == NULL)
+                       continue;
+
+               nbytes = nentries * sizeof(struct xpc_notify_sn2);
+               ch_sn2->notify_queue = kzalloc(nbytes, GFP_KERNEL);
+               if (ch_sn2->notify_queue == NULL) {
+                       kfree(ch_sn2->local_msgqueue_base);
+                       ch_sn2->local_msgqueue = NULL;
+                       continue;
+               }
+
+               spin_lock_irqsave(&ch->lock, irq_flags);
+               if (nentries < ch->local_nentries) {
+                       dev_dbg(xpc_chan, "nentries=%d local_nentries=%d, "
+                               "partid=%d, channel=%d\n", nentries,
+                               ch->local_nentries, ch->partid, ch->number);
+
+                       ch->local_nentries = nentries;
+               }
+               spin_unlock_irqrestore(&ch->lock, irq_flags);
+               return xpSuccess;
+       }
+
+       dev_dbg(xpc_chan, "can't get memory for local message queue and notify "
+               "queue, partid=%d, channel=%d\n", ch->partid, ch->number);
+       return xpNoMemory;
+}
+
+/*
+ * Allocate the cached remote message queue.
+ */
+static enum xp_retval
+xpc_allocate_remote_msgqueue_sn2(struct xpc_channel *ch)
+{
+       struct xpc_channel_sn2 *ch_sn2 = &ch->sn.sn2;
+       unsigned long irq_flags;
+       int nentries;
+       size_t nbytes;
+
+       DBUG_ON(ch->remote_nentries <= 0);
+
+       for (nentries = ch->remote_nentries; nentries > 0; nentries--) {
+
+               nbytes = nentries * ch->entry_size;
+               ch_sn2->remote_msgqueue =
+                   xpc_kzalloc_cacheline_aligned(nbytes, GFP_KERNEL, &ch_sn2->
+                                                 remote_msgqueue_base);
+               if (ch_sn2->remote_msgqueue == NULL)
+                       continue;
+
+               spin_lock_irqsave(&ch->lock, irq_flags);
+               if (nentries < ch->remote_nentries) {
+                       dev_dbg(xpc_chan, "nentries=%d remote_nentries=%d, "
+                               "partid=%d, channel=%d\n", nentries,
+                               ch->remote_nentries, ch->partid, ch->number);
+
+                       ch->remote_nentries = nentries;
+               }
+               spin_unlock_irqrestore(&ch->lock, irq_flags);
+               return xpSuccess;
+       }
+
+       dev_dbg(xpc_chan, "can't get memory for cached remote message queue, "
+               "partid=%d, channel=%d\n", ch->partid, ch->number);
+       return xpNoMemory;
+}
+
+/*
+ * Allocate message queues and other stuff associated with a channel.
+ *
+ * Note: Assumes all of the channel sizes are filled in.
+ */
+static enum xp_retval
+xpc_setup_msg_structures_sn2(struct xpc_channel *ch)
+{
+       struct xpc_channel_sn2 *ch_sn2 = &ch->sn.sn2;
+       enum xp_retval ret;
+
+       DBUG_ON(ch->flags & XPC_C_SETUP);
+
+       ret = xpc_allocate_local_msgqueue_sn2(ch);
+       if (ret == xpSuccess) {
+
+               ret = xpc_allocate_remote_msgqueue_sn2(ch);
+               if (ret != xpSuccess) {
+                       kfree(ch_sn2->local_msgqueue_base);
+                       ch_sn2->local_msgqueue = NULL;
+                       kfree(ch_sn2->notify_queue);
+                       ch_sn2->notify_queue = NULL;
+               }
+       }
+       return ret;
+}
+
+/*
+ * Free up message queues and other stuff that were allocated for the specified
+ * channel.
+ */
+static void
+xpc_teardown_msg_structures_sn2(struct xpc_channel *ch)
+{
+       struct xpc_channel_sn2 *ch_sn2 = &ch->sn.sn2;
+
+       DBUG_ON(!spin_is_locked(&ch->lock));
+
+       ch_sn2->remote_msgqueue_pa = 0;
+
+       ch_sn2->local_GP->get = 0;
+       ch_sn2->local_GP->put = 0;
+       ch_sn2->remote_GP.get = 0;
+       ch_sn2->remote_GP.put = 0;
+       ch_sn2->w_local_GP.get = 0;
+       ch_sn2->w_local_GP.put = 0;
+       ch_sn2->w_remote_GP.get = 0;
+       ch_sn2->w_remote_GP.put = 0;
+       ch_sn2->next_msg_to_pull = 0;
+
+       if (ch->flags & XPC_C_SETUP) {
+               dev_dbg(xpc_chan, "ch->flags=0x%x, partid=%d, channel=%d\n",
+                       ch->flags, ch->partid, ch->number);
+
+               kfree(ch_sn2->local_msgqueue_base);
+               ch_sn2->local_msgqueue = NULL;
+               kfree(ch_sn2->remote_msgqueue_base);
+               ch_sn2->remote_msgqueue = NULL;
+               kfree(ch_sn2->notify_queue);
+               ch_sn2->notify_queue = NULL;
+       }
+}
+
+/*
  * Notify those who wanted to be notified upon delivery of their message.
  */
 static void
 xpc_notify_senders_sn2(struct xpc_channel *ch, enum xp_retval reason, s64 put)
 {
-       struct xpc_notify *notify;
+       struct xpc_notify_sn2 *notify;
        u8 notify_type;
        s64 get = ch->sn.sn2.w_remote_GP.get - 1;
 
        while (++get < put && atomic_read(&ch->n_to_notify) > 0) {
 
-               notify = &ch->notify_queue[get % ch->local_nentries];
+               notify = &ch->sn.sn2.notify_queue[get % ch->local_nentries];
 
                /*
                 * See if the notify entry indicates it was associated with
@@ -1558,17 +1732,16 @@ xpc_notify_senders_sn2(struct xpc_channel *ch, enum xp_retval reason, s64 put)
                atomic_dec(&ch->n_to_notify);
 
                if (notify->func != NULL) {
-                       dev_dbg(xpc_chan, "notify->func() called, notify=0x%p, "
-                               "msg_number=%ld, partid=%d, channel=%d\n",
+                       dev_dbg(xpc_chan, "notify->func() called, notify=0x%p "
+                               "msg_number=%lld partid=%d channel=%d\n",
                                (void *)notify, get, ch->partid, ch->number);
 
                        notify->func(reason, ch->partid, ch->number,
                                     notify->key);
 
-                       dev_dbg(xpc_chan, "notify->func() returned, "
-                               "notify=0x%p, msg_number=%ld, partid=%d, "
-                               "channel=%d\n", (void *)notify, get,
-                               ch->partid, ch->number);
+                       dev_dbg(xpc_chan, "notify->func() returned, notify=0x%p"
+                               " msg_number=%lld partid=%d channel=%d\n",
+                               (void *)notify, get, ch->partid, ch->number);
                }
        }
 }
@@ -1586,14 +1759,15 @@ static inline void
 xpc_clear_local_msgqueue_flags_sn2(struct xpc_channel *ch)
 {
        struct xpc_channel_sn2 *ch_sn2 = &ch->sn.sn2;
-       struct xpc_msg *msg;
+       struct xpc_msg_sn2 *msg;
        s64 get;
 
        get = ch_sn2->w_remote_GP.get;
        do {
-               msg = (struct xpc_msg *)((u64)ch->local_msgqueue +
-                                        (get % ch->local_nentries) *
-                                        ch->msg_size);
+               msg = (struct xpc_msg_sn2 *)((u64)ch_sn2->local_msgqueue +
+                                            (get % ch->local_nentries) *
+                                            ch->entry_size);
+               DBUG_ON(!(msg->flags & XPC_M_SN2_READY));
                msg->flags = 0;
        } while (++get < ch_sn2->remote_GP.get);
 }
@@ -1605,24 +1779,37 @@ static inline void
 xpc_clear_remote_msgqueue_flags_sn2(struct xpc_channel *ch)
 {
        struct xpc_channel_sn2 *ch_sn2 = &ch->sn.sn2;
-       struct xpc_msg *msg;
-       s64 put;
+       struct xpc_msg_sn2 *msg;
+       s64 put, remote_nentries = ch->remote_nentries;
+
+       /* flags are zeroed when the buffer is allocated */
+       if (ch_sn2->remote_GP.put < remote_nentries)
+               return;
 
-       put = ch_sn2->w_remote_GP.put;
+       put = max(ch_sn2->w_remote_GP.put, remote_nentries);
        do {
-               msg = (struct xpc_msg *)((u64)ch->remote_msgqueue +
-                                        (put % ch->remote_nentries) *
-                                        ch->msg_size);
+               msg = (struct xpc_msg_sn2 *)((u64)ch_sn2->remote_msgqueue +
+                                            (put % remote_nentries) *
+                                            ch->entry_size);
+               DBUG_ON(!(msg->flags & XPC_M_SN2_READY));
+               DBUG_ON(!(msg->flags & XPC_M_SN2_DONE));
+               DBUG_ON(msg->number != put - remote_nentries);
                msg->flags = 0;
        } while (++put < ch_sn2->remote_GP.put);
 }
 
+static int
+xpc_n_of_deliverable_payloads_sn2(struct xpc_channel *ch)
+{
+       return ch->sn.sn2.w_remote_GP.put - ch->sn.sn2.w_local_GP.get;
+}
+
 static void
 xpc_process_msg_chctl_flags_sn2(struct xpc_partition *part, int ch_number)
 {
        struct xpc_channel *ch = &part->channels[ch_number];
        struct xpc_channel_sn2 *ch_sn2 = &ch->sn.sn2;
-       int nmsgs_sent;
+       int npayloads_sent;
 
        ch_sn2->remote_GP = part->sn.sn2.remote_GPs[ch_number];
 
@@ -1674,7 +1861,7 @@ xpc_process_msg_chctl_flags_sn2(struct xpc_partition *part, int ch_number)
 
                ch_sn2->w_remote_GP.get = ch_sn2->remote_GP.get;
 
-               dev_dbg(xpc_chan, "w_remote_GP.get changed to %ld, partid=%d, "
+               dev_dbg(xpc_chan, "w_remote_GP.get changed to %lld, partid=%d, "
                        "channel=%d\n", ch_sn2->w_remote_GP.get, ch->partid,
                        ch->number);
 
@@ -1694,37 +1881,40 @@ xpc_process_msg_chctl_flags_sn2(struct xpc_partition *part, int ch_number)
        if (ch_sn2->w_remote_GP.put != ch_sn2->remote_GP.put) {
                /*
                 * Clear msg->flags in previously received messages, so that
-                * they're ready for xpc_get_deliverable_msg().
+                * they're ready for xpc_get_deliverable_payload_sn2().
                 */
                xpc_clear_remote_msgqueue_flags_sn2(ch);
 
+               smp_wmb(); /* ensure flags have been cleared before bte_copy */
                ch_sn2->w_remote_GP.put = ch_sn2->remote_GP.put;
 
-               dev_dbg(xpc_chan, "w_remote_GP.put changed to %ld, partid=%d, "
+               dev_dbg(xpc_chan, "w_remote_GP.put changed to %lld, partid=%d, "
                        "channel=%d\n", ch_sn2->w_remote_GP.put, ch->partid,
                        ch->number);
 
-               nmsgs_sent = ch_sn2->w_remote_GP.put - ch_sn2->w_local_GP.get;
-               if (nmsgs_sent > 0) {
+               npayloads_sent = xpc_n_of_deliverable_payloads_sn2(ch);
+               if (npayloads_sent > 0) {
                        dev_dbg(xpc_chan, "msgs waiting to be copied and "
                                "delivered=%d, partid=%d, channel=%d\n",
-                               nmsgs_sent, ch->partid, ch->number);
+                               npayloads_sent, ch->partid, ch->number);
 
                        if (ch->flags & XPC_C_CONNECTEDCALLOUT_MADE)
-                               xpc_activate_kthreads(ch, nmsgs_sent);
+                               xpc_activate_kthreads(ch, npayloads_sent);
                }
        }
 
        xpc_msgqueue_deref(ch);
 }
 
-static struct xpc_msg *
+static struct xpc_msg_sn2 *
 xpc_pull_remote_msg_sn2(struct xpc_channel *ch, s64 get)
 {
        struct xpc_partition *part = &xpc_partitions[ch->partid];
        struct xpc_channel_sn2 *ch_sn2 = &ch->sn.sn2;
-       struct xpc_msg *remote_msg, *msg;
-       u32 msg_index, nmsgs;
+       unsigned long remote_msg_pa;
+       struct xpc_msg_sn2 *msg;
+       u32 msg_index;
+       u32 nmsgs;
        u64 msg_offset;
        enum xp_retval ret;
 
@@ -1746,17 +1936,17 @@ xpc_pull_remote_msg_sn2(struct xpc_channel *ch, s64 get)
                        nmsgs = ch->remote_nentries - msg_index;
                }
 
-               msg_offset = msg_index * ch->msg_size;
-               msg = (struct xpc_msg *)((u64)ch->remote_msgqueue + msg_offset);
-               remote_msg = (struct xpc_msg *)(ch->remote_msgqueue_pa +
-                                               msg_offset);
+               msg_offset = msg_index * ch->entry_size;
+               msg = (struct xpc_msg_sn2 *)((u64)ch_sn2->remote_msgqueue +
+                   msg_offset);
+               remote_msg_pa = ch_sn2->remote_msgqueue_pa + msg_offset;
 
-               ret = xpc_pull_remote_cachelines_sn2(part, msg, remote_msg,
-                                                    nmsgs * ch->msg_size);
+               ret = xpc_pull_remote_cachelines_sn2(part, msg, remote_msg_pa,
+                                                    nmsgs * ch->entry_size);
                if (ret != xpSuccess) {
 
                        dev_dbg(xpc_chan, "failed to pull %d msgs starting with"
-                               " msg %ld from partition %d, channel=%d, "
+                               " msg %lld from partition %d, channel=%d, "
                                "ret=%d\n", nmsgs, ch_sn2->next_msg_to_pull,
                                ch->partid, ch->number, ret);
 
@@ -1772,26 +1962,21 @@ xpc_pull_remote_msg_sn2(struct xpc_channel *ch, s64 get)
        mutex_unlock(&ch_sn2->msg_to_pull_mutex);
 
        /* return the message we were looking for */
-       msg_offset = (get % ch->remote_nentries) * ch->msg_size;
-       msg = (struct xpc_msg *)((u64)ch->remote_msgqueue + msg_offset);
+       msg_offset = (get % ch->remote_nentries) * ch->entry_size;
+       msg = (struct xpc_msg_sn2 *)((u64)ch_sn2->remote_msgqueue + msg_offset);
 
        return msg;
 }
 
-static int
-xpc_n_of_deliverable_msgs_sn2(struct xpc_channel *ch)
-{
-       return ch->sn.sn2.w_remote_GP.put - ch->sn.sn2.w_local_GP.get;
-}
-
 /*
- * Get a message to be delivered.
+ * Get the next deliverable message's payload.
  */
-static struct xpc_msg *
-xpc_get_deliverable_msg_sn2(struct xpc_channel *ch)
+static void *
+xpc_get_deliverable_payload_sn2(struct xpc_channel *ch)
 {
        struct xpc_channel_sn2 *ch_sn2 = &ch->sn.sn2;
-       struct xpc_msg *msg = NULL;
+       struct xpc_msg_sn2 *msg;
+       void *payload = NULL;
        s64 get;
 
        do {
@@ -1799,7 +1984,7 @@ xpc_get_deliverable_msg_sn2(struct xpc_channel *ch)
                        break;
 
                get = ch_sn2->w_local_GP.get;
-               rmb();  /* guarantee that .get loads before .put */
+               smp_rmb();      /* guarantee that .get loads before .put */
                if (get == ch_sn2->w_remote_GP.put)
                        break;
 
@@ -1813,7 +1998,7 @@ xpc_get_deliverable_msg_sn2(struct xpc_channel *ch)
                if (cmpxchg(&ch_sn2->w_local_GP.get, get, get + 1) == get) {
                        /* we got the entry referenced by get */
 
-                       dev_dbg(xpc_chan, "w_local_GP.get changed to %ld, "
+                       dev_dbg(xpc_chan, "w_local_GP.get changed to %lld, "
                                "partid=%d, channel=%d\n", get + 1,
                                ch->partid, ch->number);
 
@@ -1821,16 +2006,19 @@ xpc_get_deliverable_msg_sn2(struct xpc_channel *ch)
 
                        msg = xpc_pull_remote_msg_sn2(ch, get);
 
-                       DBUG_ON(msg != NULL && msg->number != get);
-                       DBUG_ON(msg != NULL && (msg->flags & XPC_M_DONE));
-                       DBUG_ON(msg != NULL && !(msg->flags & XPC_M_READY));
+                       if (msg != NULL) {
+                               DBUG_ON(msg->number != get);
+                               DBUG_ON(msg->flags & XPC_M_SN2_DONE);
+                               DBUG_ON(!(msg->flags & XPC_M_SN2_READY));
 
+                               payload = &msg->payload;
+                       }
                        break;
                }
 
        } while (1);
 
-       return msg;
+       return payload;
 }
 
 /*
@@ -1842,7 +2030,7 @@ static void
 xpc_send_msgs_sn2(struct xpc_channel *ch, s64 initial_put)
 {
        struct xpc_channel_sn2 *ch_sn2 = &ch->sn.sn2;
-       struct xpc_msg *msg;
+       struct xpc_msg_sn2 *msg;
        s64 put = initial_put + 1;
        int send_msgrequest = 0;
 
@@ -1852,11 +2040,12 @@ xpc_send_msgs_sn2(struct xpc_channel *ch, s64 initial_put)
                        if (put == ch_sn2->w_local_GP.put)
                                break;
 
-                       msg = (struct xpc_msg *)((u64)ch->local_msgqueue +
-                                                (put % ch->local_nentries) *
-                                                ch->msg_size);
+                       msg = (struct xpc_msg_sn2 *)((u64)ch_sn2->
+                                                    local_msgqueue + (put %
+                                                    ch->local_nentries) *
+                                                    ch->entry_size);
 
-                       if (!(msg->flags & XPC_M_READY))
+                       if (!(msg->flags & XPC_M_SN2_READY))
                                break;
 
                        put++;
@@ -1876,14 +2065,14 @@ xpc_send_msgs_sn2(struct xpc_channel *ch, s64 initial_put)
 
                /* we just set the new value of local_GP->put */
 
-               dev_dbg(xpc_chan, "local_GP->put changed to %ld, partid=%d, "
+               dev_dbg(xpc_chan, "local_GP->put changed to %lld, partid=%d, "
                        "channel=%d\n", put, ch->partid, ch->number);
 
                send_msgrequest = 1;
 
                /*
                 * We need to ensure that the message referenced by
-                * local_GP->put is not XPC_M_READY or that local_GP->put
+                * local_GP->put is not XPC_M_SN2_READY or that local_GP->put
                 * equals w_local_GP.put, so we'll go have a look.
                 */
                initial_put = put;
@@ -1899,10 +2088,10 @@ xpc_send_msgs_sn2(struct xpc_channel *ch, s64 initial_put)
  */
 static enum xp_retval
 xpc_allocate_msg_sn2(struct xpc_channel *ch, u32 flags,
-                    struct xpc_msg **address_of_msg)
+                    struct xpc_msg_sn2 **address_of_msg)
 {
        struct xpc_channel_sn2 *ch_sn2 = &ch->sn.sn2;
-       struct xpc_msg *msg;
+       struct xpc_msg_sn2 *msg;
        enum xp_retval ret;
        s64 put;
 
@@ -1916,7 +2105,7 @@ xpc_allocate_msg_sn2(struct xpc_channel *ch, u32 flags,
        while (1) {
 
                put = ch_sn2->w_local_GP.put;
-               rmb();  /* guarantee that .put loads before .get */
+               smp_rmb();      /* guarantee that .put loads before .get */
                if (put - ch_sn2->w_remote_GP.get < ch->local_nentries) {
 
                        /* There are available message entries. We need to try
@@ -1954,14 +2143,15 @@ xpc_allocate_msg_sn2(struct xpc_channel *ch, u32 flags,
        }
 
        /* get the message's address and initialize it */
-       msg = (struct xpc_msg *)((u64)ch->local_msgqueue +
-                                (put % ch->local_nentries) * ch->msg_size);
+       msg = (struct xpc_msg_sn2 *)((u64)ch_sn2->local_msgqueue +
+                                    (put % ch->local_nentries) *
+                                    ch->entry_size);
 
        DBUG_ON(msg->flags != 0);
        msg->number = put;
 
-       dev_dbg(xpc_chan, "w_local_GP.put changed to %ld; msg=0x%p, "
-               "msg_number=%ld, partid=%d, channel=%d\n", put + 1,
+       dev_dbg(xpc_chan, "w_local_GP.put changed to %lld; msg=0x%p, "
+               "msg_number=%lld, partid=%d, channel=%d\n", put + 1,
                (void *)msg, msg->number, ch->partid, ch->number);
 
        *address_of_msg = msg;
@@ -1974,19 +2164,20 @@ xpc_allocate_msg_sn2(struct xpc_channel *ch, u32 flags,
  * partition the message is being sent to.
  */
 static enum xp_retval
-xpc_send_msg_sn2(struct xpc_channel *ch, u32 flags, void *payload,
-                u16 payload_size, u8 notify_type, xpc_notify_func func,
-                void *key)
+xpc_send_payload_sn2(struct xpc_channel *ch, u32 flags, void *payload,
+                    u16 payload_size, u8 notify_type, xpc_notify_func func,
+                    void *key)
 {
        enum xp_retval ret = xpSuccess;
-       struct xpc_msg *msg = msg;
-       struct xpc_notify *notify = notify;
+       struct xpc_channel_sn2 *ch_sn2 = &ch->sn.sn2;
+       struct xpc_msg_sn2 *msg = msg;
+       struct xpc_notify_sn2 *notify = notify;
        s64 msg_number;
        s64 put;
 
        DBUG_ON(notify_type == XPC_N_CALL && func == NULL);
 
-       if (XPC_MSG_SIZE(payload_size) > ch->msg_size)
+       if (XPC_MSG_SIZE(payload_size) > ch->entry_size)
                return xpPayloadTooBig;
 
        xpc_msgqueue_ref(ch);
@@ -2011,16 +2202,16 @@ xpc_send_msg_sn2(struct xpc_channel *ch, u32 flags, void *payload,
                 * Tell the remote side to send an ACK interrupt when the
                 * message has been delivered.
                 */
-               msg->flags |= XPC_M_INTERRUPT;
+               msg->flags |= XPC_M_SN2_INTERRUPT;
 
                atomic_inc(&ch->n_to_notify);
 
-               notify = &ch->notify_queue[msg_number % ch->local_nentries];
+               notify = &ch_sn2->notify_queue[msg_number % ch->local_nentries];
                notify->func = func;
                notify->key = key;
                notify->type = notify_type;
 
-               /* >>> is a mb() needed here? */
+               /* ??? Is a mb() needed here? */
 
                if (ch->flags & XPC_C_DISCONNECTING) {
                        /*
@@ -2041,17 +2232,17 @@ xpc_send_msg_sn2(struct xpc_channel *ch, u32 flags, void *payload,
 
        memcpy(&msg->payload, payload, payload_size);
 
-       msg->flags |= XPC_M_READY;
+       msg->flags |= XPC_M_SN2_READY;
 
        /*
         * The preceding store of msg->flags must occur before the following
         * load of local_GP->put.
         */
-       mb();
+       smp_mb();
 
        /* see if the message is next in line to be sent, if so send it */
 
-       put = ch->sn.sn2.local_GP->put;
+       put = ch_sn2->local_GP->put;
        if (put == msg_number)
                xpc_send_msgs_sn2(ch, put);
 
@@ -2064,12 +2255,15 @@ out_1:
  * Now we actually acknowledge the messages that have been delivered and ack'd
  * by advancing the cached remote message queue's Get value and if requested
  * send a chctl msgrequest to the message sender's partition.
+ *
+ * If a message has XPC_M_SN2_INTERRUPT set, send an interrupt to the partition
+ * that sent the message.
  */
 static void
 xpc_acknowledge_msgs_sn2(struct xpc_channel *ch, s64 initial_get, u8 msg_flags)
 {
        struct xpc_channel_sn2 *ch_sn2 = &ch->sn.sn2;
-       struct xpc_msg *msg;
+       struct xpc_msg_sn2 *msg;
        s64 get = initial_get + 1;
        int send_msgrequest = 0;
 
@@ -2079,11 +2273,12 @@ xpc_acknowledge_msgs_sn2(struct xpc_channel *ch, s64 initial_get, u8 msg_flags)
                        if (get == ch_sn2->w_local_GP.get)
                                break;
 
-                       msg = (struct xpc_msg *)((u64)ch->remote_msgqueue +
-                                                (get % ch->remote_nentries) *
-                                                ch->msg_size);
+                       msg = (struct xpc_msg_sn2 *)((u64)ch_sn2->
+                                                    remote_msgqueue + (get %
+                                                    ch->remote_nentries) *
+                                                    ch->entry_size);
 
-                       if (!(msg->flags & XPC_M_DONE))
+                       if (!(msg->flags & XPC_M_SN2_DONE))
                                break;
 
                        msg_flags |= msg->flags;
@@ -2104,14 +2299,14 @@ xpc_acknowledge_msgs_sn2(struct xpc_channel *ch, s64 initial_get, u8 msg_flags)
 
                /* we just set the new value of local_GP->get */
 
-               dev_dbg(xpc_chan, "local_GP->get changed to %ld, partid=%d, "
+               dev_dbg(xpc_chan, "local_GP->get changed to %lld, partid=%d, "
                        "channel=%d\n", get, ch->partid, ch->number);
 
-               send_msgrequest = (msg_flags & XPC_M_INTERRUPT);
+               send_msgrequest = (msg_flags & XPC_M_SN2_INTERRUPT);
 
                /*
                 * We need to ensure that the message referenced by
-                * local_GP->get is not XPC_M_DONE or that local_GP->get
+                * local_GP->get is not XPC_M_SN2_DONE or that local_GP->get
                 * equals w_local_GP.get, so we'll go have a look.
                 */
                initial_get = get;
@@ -2122,25 +2317,30 @@ xpc_acknowledge_msgs_sn2(struct xpc_channel *ch, s64 initial_get, u8 msg_flags)
 }
 
 static void
-xpc_received_msg_sn2(struct xpc_channel *ch, struct xpc_msg *msg)
+xpc_received_payload_sn2(struct xpc_channel *ch, void *payload)
 {
+       struct xpc_msg_sn2 *msg;
+       s64 msg_number;
        s64 get;
-       s64 msg_number = msg->number;
 
-       dev_dbg(xpc_chan, "msg=0x%p, msg_number=%ld, partid=%d, channel=%d\n",
+       msg = container_of(payload, struct xpc_msg_sn2, payload);
+       msg_number = msg->number;
+
+       dev_dbg(xpc_chan, "msg=0x%p, msg_number=%lld, partid=%d, channel=%d\n",
                (void *)msg, msg_number, ch->partid, ch->number);
 
-       DBUG_ON((((u64)msg - (u64)ch->remote_msgqueue) / ch->msg_size) !=
+       DBUG_ON((((u64)msg - (u64)ch->sn.sn2.remote_msgqueue) / ch->entry_size) !=
                msg_number % ch->remote_nentries);
-       DBUG_ON(msg->flags & XPC_M_DONE);
+       DBUG_ON(!(msg->flags & XPC_M_SN2_READY));
+       DBUG_ON(msg->flags & XPC_M_SN2_DONE);
 
-       msg->flags |= XPC_M_DONE;
+       msg->flags |= XPC_M_SN2_DONE;
 
        /*
         * The preceding store of msg->flags must occur before the following
         * load of local_GP->get.
         */
-       mb();
+       smp_mb();
 
        /*
         * See if this message is next in line to be acknowledged as having
@@ -2151,51 +2351,86 @@ xpc_received_msg_sn2(struct xpc_channel *ch, struct xpc_msg *msg)
                xpc_acknowledge_msgs_sn2(ch, get, msg->flags);
 }
 
+static struct xpc_arch_operations xpc_arch_ops_sn2 = {
+       .setup_partitions = xpc_setup_partitions_sn2,
+       .teardown_partitions = xpc_teardown_partitions_sn2,
+       .process_activate_IRQ_rcvd = xpc_process_activate_IRQ_rcvd_sn2,
+       .get_partition_rsvd_page_pa = xpc_get_partition_rsvd_page_pa_sn2,
+       .setup_rsvd_page = xpc_setup_rsvd_page_sn2,
+
+       .allow_hb = xpc_allow_hb_sn2,
+       .disallow_hb = xpc_disallow_hb_sn2,
+       .disallow_all_hbs = xpc_disallow_all_hbs_sn2,
+       .increment_heartbeat = xpc_increment_heartbeat_sn2,
+       .offline_heartbeat = xpc_offline_heartbeat_sn2,
+       .online_heartbeat = xpc_online_heartbeat_sn2,
+       .heartbeat_init = xpc_heartbeat_init_sn2,
+       .heartbeat_exit = xpc_heartbeat_exit_sn2,
+       .get_remote_heartbeat = xpc_get_remote_heartbeat_sn2,
+
+       .request_partition_activation =
+               xpc_request_partition_activation_sn2,
+       .request_partition_reactivation =
+               xpc_request_partition_reactivation_sn2,
+       .request_partition_deactivation =
+               xpc_request_partition_deactivation_sn2,
+       .cancel_partition_deactivation_request =
+               xpc_cancel_partition_deactivation_request_sn2,
+
+       .setup_ch_structures = xpc_setup_ch_structures_sn2,
+       .teardown_ch_structures = xpc_teardown_ch_structures_sn2,
+
+       .make_first_contact = xpc_make_first_contact_sn2,
+
+       .get_chctl_all_flags = xpc_get_chctl_all_flags_sn2,
+       .send_chctl_closerequest = xpc_send_chctl_closerequest_sn2,
+       .send_chctl_closereply = xpc_send_chctl_closereply_sn2,
+       .send_chctl_openrequest = xpc_send_chctl_openrequest_sn2,
+       .send_chctl_openreply = xpc_send_chctl_openreply_sn2,
+       .send_chctl_opencomplete = xpc_send_chctl_opencomplete_sn2,
+       .process_msg_chctl_flags = xpc_process_msg_chctl_flags_sn2,
+
+       .save_remote_msgqueue_pa = xpc_save_remote_msgqueue_pa_sn2,
+
+       .setup_msg_structures = xpc_setup_msg_structures_sn2,
+       .teardown_msg_structures = xpc_teardown_msg_structures_sn2,
+
+       .indicate_partition_engaged = xpc_indicate_partition_engaged_sn2,
+       .indicate_partition_disengaged = xpc_indicate_partition_disengaged_sn2,
+       .partition_engaged = xpc_partition_engaged_sn2,
+       .any_partition_engaged = xpc_any_partition_engaged_sn2,
+       .assume_partition_disengaged = xpc_assume_partition_disengaged_sn2,
+
+       .n_of_deliverable_payloads = xpc_n_of_deliverable_payloads_sn2,
+       .send_payload = xpc_send_payload_sn2,
+       .get_deliverable_payload = xpc_get_deliverable_payload_sn2,
+       .received_payload = xpc_received_payload_sn2,
+       .notify_senders_of_disconnect = xpc_notify_senders_of_disconnect_sn2,
+};
+
 int
 xpc_init_sn2(void)
 {
        int ret;
+       size_t buf_size;
+
+       xpc_arch_ops = xpc_arch_ops_sn2;
 
-       xpc_rsvd_page_init = xpc_rsvd_page_init_sn2;
-       xpc_increment_heartbeat = xpc_increment_heartbeat_sn2;
-       xpc_offline_heartbeat = xpc_offline_heartbeat_sn2;
-       xpc_online_heartbeat = xpc_online_heartbeat_sn2;
-       xpc_heartbeat_init = xpc_heartbeat_init_sn2;
-       xpc_heartbeat_exit = xpc_heartbeat_exit_sn2;
-       xpc_check_remote_hb = xpc_check_remote_hb_sn2;
-
-       xpc_request_partition_activation = xpc_request_partition_activation_sn2;
-       xpc_request_partition_reactivation =
-           xpc_request_partition_reactivation_sn2;
-       xpc_request_partition_deactivation =
-           xpc_request_partition_deactivation_sn2;
-       xpc_cancel_partition_deactivation_request =
-           xpc_cancel_partition_deactivation_request_sn2;
-
-       xpc_process_activate_IRQ_rcvd = xpc_process_activate_IRQ_rcvd_sn2;
-       xpc_setup_infrastructure = xpc_setup_infrastructure_sn2;
-       xpc_teardown_infrastructure = xpc_teardown_infrastructure_sn2;
-       xpc_make_first_contact = xpc_make_first_contact_sn2;
-       xpc_get_chctl_all_flags = xpc_get_chctl_all_flags_sn2;
-       xpc_notify_senders_of_disconnect = xpc_notify_senders_of_disconnect_sn2;
-       xpc_process_msg_chctl_flags = xpc_process_msg_chctl_flags_sn2;
-       xpc_n_of_deliverable_msgs = xpc_n_of_deliverable_msgs_sn2;
-       xpc_get_deliverable_msg = xpc_get_deliverable_msg_sn2;
-
-       xpc_indicate_partition_engaged = xpc_indicate_partition_engaged_sn2;
-       xpc_partition_engaged = xpc_partition_engaged_sn2;
-       xpc_any_partition_engaged = xpc_any_partition_engaged_sn2;
-       xpc_indicate_partition_disengaged =
-           xpc_indicate_partition_disengaged_sn2;
-       xpc_assume_partition_disengaged = xpc_assume_partition_disengaged_sn2;
-
-       xpc_send_chctl_closerequest = xpc_send_chctl_closerequest_sn2;
-       xpc_send_chctl_closereply = xpc_send_chctl_closereply_sn2;
-       xpc_send_chctl_openrequest = xpc_send_chctl_openrequest_sn2;
-       xpc_send_chctl_openreply = xpc_send_chctl_openreply_sn2;
-
-       xpc_send_msg = xpc_send_msg_sn2;
-       xpc_received_msg = xpc_received_msg_sn2;
+       if (offsetof(struct xpc_msg_sn2, payload) > XPC_MSG_HDR_MAX_SIZE) {
+               dev_err(xpc_part, "header portion of struct xpc_msg_sn2 is "
+                       "larger than %d\n", XPC_MSG_HDR_MAX_SIZE);
+               return -E2BIG;
+       }
+
+       buf_size = max(XPC_RP_VARS_SIZE,
+                      XPC_RP_HEADER_SIZE + XP_NASID_MASK_BYTES_SN2);
+       xpc_remote_copy_buffer_sn2 = xpc_kmalloc_cacheline_aligned(buf_size,
+                                                                  GFP_KERNEL,
+                                             &xpc_remote_copy_buffer_base_sn2);
+       if (xpc_remote_copy_buffer_sn2 == NULL) {
+               dev_err(xpc_part, "can't get memory for remote copy buffer\n");
+               return -ENOMEM;
+       }
 
        /* open up protections for IPI and [potentially] amo operations */
        xpc_allow_IPI_ops_sn2();
@@ -2213,6 +2448,7 @@ xpc_init_sn2(void)
                dev_err(xpc_part, "can't register ACTIVATE IRQ handler, "
                        "errno=%d\n", -ret);
                xpc_disallow_IPI_ops_sn2();
+               kfree(xpc_remote_copy_buffer_base_sn2);
        }
        return ret;
 }
@@ -2222,4 +2458,5 @@ xpc_exit_sn2(void)
 {
        free_irq(SGI_XPC_ACTIVATE, NULL);
        xpc_disallow_IPI_ops_sn2();
+       kfree(xpc_remote_copy_buffer_base_sn2);
 }