ixgbe: Cleanup incorrect header comments
[safe/jmp/linux-2.6] / drivers / mfd / tc6393xb.c
index 2d87501..4bc5a08 100644 (file)
@@ -19,8 +19,8 @@
 #include <linux/io.h>
 #include <linux/irq.h>
 #include <linux/platform_device.h>
-#include <linux/fb.h>
 #include <linux/clk.h>
+#include <linux/err.h>
 #include <linux/mfd/core.h>
 #include <linux/mfd/tmio.h>
 #include <linux/mfd/tc6393xb.h>
@@ -112,6 +112,9 @@ struct tc6393xb {
 
 enum {
        TC6393XB_CELL_NAND,
+       TC6393XB_CELL_MMC,
+       TC6393XB_CELL_OHCI,
+       TC6393XB_CELL_FB,
 };
 
 /*--------------------------------------------------------------------------*/
@@ -126,7 +129,7 @@ static int tc6393xb_nand_enable(struct platform_device *nand)
 
        /* SMD buffer on */
        dev_dbg(&dev->dev, "SMD buffer on\n");
-       iowrite8(0xff, tc6393xb->scr + SCR_GPI_BCR(1));
+       tmio_iowrite8(0xff, tc6393xb->scr + SCR_GPI_BCR(1));
 
        spin_unlock_irqrestore(&tc6393xb->lock, flags);
 
@@ -135,25 +138,249 @@ static int tc6393xb_nand_enable(struct platform_device *nand)
 
 static struct resource __devinitdata tc6393xb_nand_resources[] = {
        {
-               .name   = TMIO_NAND_CONFIG,
-               .start  = 0x0100,
-               .end    = 0x01ff,
+               .start  = 0x1000,
+               .end    = 0x1007,
                .flags  = IORESOURCE_MEM,
        },
        {
-               .name   = TMIO_NAND_CONTROL,
-               .start  = 0x1000,
-               .end    = 0x1007,
+               .start  = 0x0100,
+               .end    = 0x01ff,
                .flags  = IORESOURCE_MEM,
        },
        {
-               .name   = TMIO_NAND_IRQ,
                .start  = IRQ_TC6393_NAND,
                .end    = IRQ_TC6393_NAND,
                .flags  = IORESOURCE_IRQ,
        },
 };
 
+static struct resource __devinitdata tc6393xb_mmc_resources[] = {
+       {
+               .start  = 0x800,
+               .end    = 0x9ff,
+               .flags  = IORESOURCE_MEM,
+       },
+       {
+               .start  = IRQ_TC6393_MMC,
+               .end    = IRQ_TC6393_MMC,
+               .flags  = IORESOURCE_IRQ,
+       },
+};
+
+static const struct resource tc6393xb_ohci_resources[] = {
+       {
+               .start  = 0x3000,
+               .end    = 0x31ff,
+               .flags  = IORESOURCE_MEM,
+       },
+       {
+               .start  = 0x0300,
+               .end    = 0x03ff,
+               .flags  = IORESOURCE_MEM,
+       },
+       {
+               .start  = 0x010000,
+               .end    = 0x017fff,
+               .flags  = IORESOURCE_MEM,
+       },
+       {
+               .start  = 0x018000,
+               .end    = 0x01ffff,
+               .flags  = IORESOURCE_MEM,
+       },
+       {
+               .start  = IRQ_TC6393_OHCI,
+               .end    = IRQ_TC6393_OHCI,
+               .flags  = IORESOURCE_IRQ,
+       },
+};
+
+static struct resource __devinitdata tc6393xb_fb_resources[] = {
+       {
+               .start  = 0x5000,
+               .end    = 0x51ff,
+               .flags  = IORESOURCE_MEM,
+       },
+       {
+               .start  = 0x0500,
+               .end    = 0x05ff,
+               .flags  = IORESOURCE_MEM,
+       },
+       {
+               .start  = 0x100000,
+               .end    = 0x1fffff,
+               .flags  = IORESOURCE_MEM,
+       },
+       {
+               .start  = IRQ_TC6393_FB,
+               .end    = IRQ_TC6393_FB,
+               .flags  = IORESOURCE_IRQ,
+       },
+};
+
+static int tc6393xb_ohci_enable(struct platform_device *dev)
+{
+       struct tc6393xb *tc6393xb = dev_get_drvdata(dev->dev.parent);
+       unsigned long flags;
+       u16 ccr;
+       u8 fer;
+
+       spin_lock_irqsave(&tc6393xb->lock, flags);
+
+       ccr = tmio_ioread16(tc6393xb->scr + SCR_CCR);
+       ccr |= SCR_CCR_USBCK;
+       tmio_iowrite16(ccr, tc6393xb->scr + SCR_CCR);
+
+       fer = tmio_ioread8(tc6393xb->scr + SCR_FER);
+       fer |= SCR_FER_USBEN;
+       tmio_iowrite8(fer, tc6393xb->scr + SCR_FER);
+
+       spin_unlock_irqrestore(&tc6393xb->lock, flags);
+
+       return 0;
+}
+
+static int tc6393xb_ohci_disable(struct platform_device *dev)
+{
+       struct tc6393xb *tc6393xb = dev_get_drvdata(dev->dev.parent);
+       unsigned long flags;
+       u16 ccr;
+       u8 fer;
+
+       spin_lock_irqsave(&tc6393xb->lock, flags);
+
+       fer = tmio_ioread8(tc6393xb->scr + SCR_FER);
+       fer &= ~SCR_FER_USBEN;
+       tmio_iowrite8(fer, tc6393xb->scr + SCR_FER);
+
+       ccr = tmio_ioread16(tc6393xb->scr + SCR_CCR);
+       ccr &= ~SCR_CCR_USBCK;
+       tmio_iowrite16(ccr, tc6393xb->scr + SCR_CCR);
+
+       spin_unlock_irqrestore(&tc6393xb->lock, flags);
+
+       return 0;
+}
+
+static int tc6393xb_fb_enable(struct platform_device *dev)
+{
+       struct tc6393xb *tc6393xb = dev_get_drvdata(dev->dev.parent);
+       unsigned long flags;
+       u16 ccr;
+
+       spin_lock_irqsave(&tc6393xb->lock, flags);
+
+       ccr = tmio_ioread16(tc6393xb->scr + SCR_CCR);
+       ccr &= ~SCR_CCR_MCLK_MASK;
+       ccr |= SCR_CCR_MCLK_48;
+       tmio_iowrite16(ccr, tc6393xb->scr + SCR_CCR);
+
+       spin_unlock_irqrestore(&tc6393xb->lock, flags);
+
+       return 0;
+}
+
+static int tc6393xb_fb_disable(struct platform_device *dev)
+{
+       struct tc6393xb *tc6393xb = dev_get_drvdata(dev->dev.parent);
+       unsigned long flags;
+       u16 ccr;
+
+       spin_lock_irqsave(&tc6393xb->lock, flags);
+
+       ccr = tmio_ioread16(tc6393xb->scr + SCR_CCR);
+       ccr &= ~SCR_CCR_MCLK_MASK;
+       ccr |= SCR_CCR_MCLK_OFF;
+       tmio_iowrite16(ccr, tc6393xb->scr + SCR_CCR);
+
+       spin_unlock_irqrestore(&tc6393xb->lock, flags);
+
+       return 0;
+}
+
+int tc6393xb_lcd_set_power(struct platform_device *fb, bool on)
+{
+       struct platform_device *dev = to_platform_device(fb->dev.parent);
+       struct tc6393xb *tc6393xb = platform_get_drvdata(dev);
+       u8 fer;
+       unsigned long flags;
+
+       spin_lock_irqsave(&tc6393xb->lock, flags);
+
+       fer = ioread8(tc6393xb->scr + SCR_FER);
+       if (on)
+               fer |= SCR_FER_SLCDEN;
+       else
+               fer &= ~SCR_FER_SLCDEN;
+       iowrite8(fer, tc6393xb->scr + SCR_FER);
+
+       spin_unlock_irqrestore(&tc6393xb->lock, flags);
+
+       return 0;
+}
+EXPORT_SYMBOL(tc6393xb_lcd_set_power);
+
+int tc6393xb_lcd_mode(struct platform_device *fb,
+                                       const struct fb_videomode *mode) {
+       struct platform_device *dev = to_platform_device(fb->dev.parent);
+       struct tc6393xb *tc6393xb = platform_get_drvdata(dev);
+       unsigned long flags;
+
+       spin_lock_irqsave(&tc6393xb->lock, flags);
+
+       iowrite16(mode->pixclock, tc6393xb->scr + SCR_PLL1CR + 0);
+       iowrite16(mode->pixclock >> 16, tc6393xb->scr + SCR_PLL1CR + 2);
+
+       spin_unlock_irqrestore(&tc6393xb->lock, flags);
+
+       return 0;
+}
+EXPORT_SYMBOL(tc6393xb_lcd_mode);
+
+static int tc6393xb_mmc_enable(struct platform_device *mmc)
+{
+       struct platform_device *dev = to_platform_device(mmc->dev.parent);
+       struct tc6393xb *tc6393xb = platform_get_drvdata(dev);
+
+       tmio_core_mmc_enable(tc6393xb->scr + 0x200, 0,
+               tc6393xb_mmc_resources[0].start & 0xfffe);
+
+       return 0;
+}
+
+static int tc6393xb_mmc_resume(struct platform_device *mmc)
+{
+       struct platform_device *dev = to_platform_device(mmc->dev.parent);
+       struct tc6393xb *tc6393xb = platform_get_drvdata(dev);
+
+       tmio_core_mmc_resume(tc6393xb->scr + 0x200, 0,
+               tc6393xb_mmc_resources[0].start & 0xfffe);
+
+       return 0;
+}
+
+static void tc6393xb_mmc_pwr(struct platform_device *mmc, int state)
+{
+       struct platform_device *dev = to_platform_device(mmc->dev.parent);
+       struct tc6393xb *tc6393xb = platform_get_drvdata(dev);
+
+       tmio_core_mmc_pwr(tc6393xb->scr + 0x200, 0, state);
+}
+
+static void tc6393xb_mmc_clk_div(struct platform_device *mmc, int state)
+{
+       struct platform_device *dev = to_platform_device(mmc->dev.parent);
+       struct tc6393xb *tc6393xb = platform_get_drvdata(dev);
+
+       tmio_core_mmc_clk_div(tc6393xb->scr + 0x200, 0, state);
+}
+
+static struct tmio_mmc_data tc6393xb_mmc_data = {
+       .hclk = 24000000,
+       .set_pwr = tc6393xb_mmc_pwr,
+       .set_clk_div = tc6393xb_mmc_clk_div,
+};
+
 static struct mfd_cell __devinitdata tc6393xb_cells[] = {
        [TC6393XB_CELL_NAND] = {
                .name = "tmio-nand",
@@ -161,6 +388,32 @@ static struct mfd_cell __devinitdata tc6393xb_cells[] = {
                .num_resources = ARRAY_SIZE(tc6393xb_nand_resources),
                .resources = tc6393xb_nand_resources,
        },
+       [TC6393XB_CELL_MMC] = {
+               .name = "tmio-mmc",
+               .enable = tc6393xb_mmc_enable,
+               .resume = tc6393xb_mmc_resume,
+               .driver_data = &tc6393xb_mmc_data,
+               .num_resources = ARRAY_SIZE(tc6393xb_mmc_resources),
+               .resources = tc6393xb_mmc_resources,
+       },
+       [TC6393XB_CELL_OHCI] = {
+               .name = "tmio-ohci",
+               .num_resources = ARRAY_SIZE(tc6393xb_ohci_resources),
+               .resources = tc6393xb_ohci_resources,
+               .enable = tc6393xb_ohci_enable,
+               .suspend = tc6393xb_ohci_disable,
+               .resume = tc6393xb_ohci_enable,
+               .disable = tc6393xb_ohci_disable,
+       },
+       [TC6393XB_CELL_FB] = {
+               .name = "tmio-fb",
+               .num_resources = ARRAY_SIZE(tc6393xb_fb_resources),
+               .resources = tc6393xb_fb_resources,
+               .enable = tc6393xb_fb_enable,
+               .suspend = tc6393xb_fb_disable,
+               .resume = tc6393xb_fb_enable,
+               .disable = tc6393xb_fb_disable,
+       },
 };
 
 /*--------------------------------------------------------------------------*/
@@ -171,7 +424,7 @@ static int tc6393xb_gpio_get(struct gpio_chip *chip,
        struct tc6393xb *tc6393xb = container_of(chip, struct tc6393xb, gpio);
 
        /* XXX: does dsr also represent inputs? */
-       return ioread8(tc6393xb->scr + SCR_GPO_DSR(offset / 8))
+       return tmio_ioread8(tc6393xb->scr + SCR_GPO_DSR(offset / 8))
                & TC_GPIO_BIT(offset);
 }
 
@@ -181,13 +434,13 @@ static void __tc6393xb_gpio_set(struct gpio_chip *chip,
        struct tc6393xb *tc6393xb = container_of(chip, struct tc6393xb, gpio);
        u8  dsr;
 
-       dsr = ioread8(tc6393xb->scr + SCR_GPO_DSR(offset / 8));
+       dsr = tmio_ioread8(tc6393xb->scr + SCR_GPO_DSR(offset / 8));
        if (value)
                dsr |= TC_GPIO_BIT(offset);
        else
                dsr &= ~TC_GPIO_BIT(offset);
 
-       iowrite8(dsr, tc6393xb->scr + SCR_GPO_DSR(offset / 8));
+       tmio_iowrite8(dsr, tc6393xb->scr + SCR_GPO_DSR(offset / 8));
 }
 
 static void tc6393xb_gpio_set(struct gpio_chip *chip,
@@ -212,9 +465,9 @@ static int tc6393xb_gpio_direction_input(struct gpio_chip *chip,
 
        spin_lock_irqsave(&tc6393xb->lock, flags);
 
-       doecr = ioread8(tc6393xb->scr + SCR_GPO_DOECR(offset / 8));
+       doecr = tmio_ioread8(tc6393xb->scr + SCR_GPO_DOECR(offset / 8));
        doecr &= ~TC_GPIO_BIT(offset);
-       iowrite8(doecr, tc6393xb->scr + SCR_GPO_DOECR(offset / 8));
+       tmio_iowrite8(doecr, tc6393xb->scr + SCR_GPO_DOECR(offset / 8));
 
        spin_unlock_irqrestore(&tc6393xb->lock, flags);
 
@@ -232,9 +485,9 @@ static int tc6393xb_gpio_direction_output(struct gpio_chip *chip,
 
        __tc6393xb_gpio_set(chip, offset, value);
 
-       doecr = ioread8(tc6393xb->scr + SCR_GPO_DOECR(offset / 8));
+       doecr = tmio_ioread8(tc6393xb->scr + SCR_GPO_DOECR(offset / 8));
        doecr |= TC_GPIO_BIT(offset);
-       iowrite8(doecr, tc6393xb->scr + SCR_GPO_DOECR(offset / 8));
+       tmio_iowrite8(doecr, tc6393xb->scr + SCR_GPO_DOECR(offset / 8));
 
        spin_unlock_irqrestore(&tc6393xb->lock, flags);
 
@@ -265,8 +518,8 @@ tc6393xb_irq(unsigned int irq, struct irq_desc *desc)
 
        irq_base = tc6393xb->irq_base;
 
-       while ((isr = ioread8(tc6393xb->scr + SCR_ISR) &
-                               ~ioread8(tc6393xb->scr + SCR_IMR)))
+       while ((isr = tmio_ioread8(tc6393xb->scr + SCR_ISR) &
+                               ~tmio_ioread8(tc6393xb->scr + SCR_IMR)))
                for (i = 0; i < TC6393XB_NR_IRQS; i++) {
                        if (isr & (1 << i))
                                generic_handle_irq(irq_base + i);
@@ -284,9 +537,9 @@ static void tc6393xb_irq_mask(unsigned int irq)
        u8 imr;
 
        spin_lock_irqsave(&tc6393xb->lock, flags);
-       imr = ioread8(tc6393xb->scr + SCR_IMR);
+       imr = tmio_ioread8(tc6393xb->scr + SCR_IMR);
        imr |= 1 << (irq - tc6393xb->irq_base);
-       iowrite8(imr, tc6393xb->scr + SCR_IMR);
+       tmio_iowrite8(imr, tc6393xb->scr + SCR_IMR);
        spin_unlock_irqrestore(&tc6393xb->lock, flags);
 }
 
@@ -297,9 +550,9 @@ static void tc6393xb_irq_unmask(unsigned int irq)
        u8 imr;
 
        spin_lock_irqsave(&tc6393xb->lock, flags);
-       imr = ioread8(tc6393xb->scr + SCR_IMR);
+       imr = tmio_ioread8(tc6393xb->scr + SCR_IMR);
        imr &= ~(1 << (irq - tc6393xb->irq_base));
-       iowrite8(imr, tc6393xb->scr + SCR_IMR);
+       tmio_iowrite8(imr, tc6393xb->scr + SCR_IMR);
        spin_unlock_irqrestore(&tc6393xb->lock, flags);
 }
 
@@ -324,7 +577,7 @@ static void tc6393xb_attach_irq(struct platform_device *dev)
                set_irq_flags(irq, IRQF_VALID | IRQF_PROBE);
        }
 
-       set_irq_type(tc6393xb->irq, IRQT_FALLING);
+       set_irq_type(tc6393xb->irq, IRQ_TYPE_EDGE_FALLING);
        set_irq_data(tc6393xb->irq, tc6393xb);
        set_irq_chained_handler(tc6393xb->irq, tc6393xb_irq);
 }
@@ -348,42 +601,12 @@ static void tc6393xb_detach_irq(struct platform_device *dev)
 
 /*--------------------------------------------------------------------------*/
 
-static int tc6393xb_hw_init(struct platform_device *dev)
-{
-       struct tc6393xb_platform_data *tcpd = dev->dev.platform_data;
-       struct tc6393xb *tc6393xb = platform_get_drvdata(dev);
-       int i;
-
-       iowrite8(tc6393xb->suspend_state.fer,   tc6393xb->scr + SCR_FER);
-       iowrite16(tcpd->scr_pll2cr,             tc6393xb->scr + SCR_PLL2CR);
-       iowrite16(tc6393xb->suspend_state.ccr,  tc6393xb->scr + SCR_CCR);
-       iowrite16(SCR_MCR_RDY_OPENDRAIN | SCR_MCR_RDY_UNK | SCR_MCR_RDY_EN |
-                 SCR_MCR_INT_OPENDRAIN | SCR_MCR_INT_UNK | SCR_MCR_INT_EN |
-                 BIT(15),                      tc6393xb->scr + SCR_MCR);
-       iowrite16(tcpd->scr_gper,               tc6393xb->scr + SCR_GPER);
-       iowrite8(0,                             tc6393xb->scr + SCR_IRR);
-       iowrite8(0xbf,                          tc6393xb->scr + SCR_IMR);
-
-       for (i = 0; i < 3; i++) {
-               iowrite8(tc6393xb->suspend_state.gpo_dsr[i],
-                                       tc6393xb->scr + SCR_GPO_DSR(i));
-               iowrite8(tc6393xb->suspend_state.gpo_doecr[i],
-                                       tc6393xb->scr + SCR_GPO_DOECR(i));
-               iowrite8(tc6393xb->suspend_state.gpi_bcr[i],
-                                       tc6393xb->scr + SCR_GPI_BCR(i));
-       }
-
-       return 0;
-}
-
 static int __devinit tc6393xb_probe(struct platform_device *dev)
 {
        struct tc6393xb_platform_data *tcpd = dev->dev.platform_data;
        struct tc6393xb *tc6393xb;
-       struct resource *iomem;
-       struct resource *rscr;
-       int retval, temp;
-       int i;
+       struct resource *iomem, *rscr;
+       int ret, temp;
 
        iomem = platform_get_resource(dev, IORESOURCE_MEM, 0);
        if (!iomem)
@@ -391,20 +614,26 @@ static int __devinit tc6393xb_probe(struct platform_device *dev)
 
        tc6393xb = kzalloc(sizeof *tc6393xb, GFP_KERNEL);
        if (!tc6393xb) {
-               retval = -ENOMEM;
+               ret = -ENOMEM;
                goto err_kzalloc;
        }
 
        spin_lock_init(&tc6393xb->lock);
 
        platform_set_drvdata(dev, tc6393xb);
+
+       ret = platform_get_irq(dev, 0);
+       if (ret >= 0)
+               tc6393xb->irq = ret;
+       else
+               goto err_noirq;
+
        tc6393xb->iomem = iomem;
-       tc6393xb->irq = platform_get_irq(dev, 0);
        tc6393xb->irq_base = tcpd->irq_base;
 
-       tc6393xb->clk = clk_get(&dev->dev, "GPIO27_CLK" /* "CK3P6MI" */);
+       tc6393xb->clk = clk_get(&dev->dev, "CLK_CK3P6MI");
        if (IS_ERR(tc6393xb->clk)) {
-               retval = PTR_ERR(tc6393xb->clk);
+               ret = PTR_ERR(tc6393xb->clk);
                goto err_clk_get;
        }
 
@@ -414,72 +643,93 @@ static int __devinit tc6393xb_probe(struct platform_device *dev)
        rscr->end = iomem->start + 0xff;
        rscr->flags = IORESOURCE_MEM;
 
-       retval = request_resource(iomem, rscr);
-       if (retval)
+       ret = request_resource(iomem, rscr);
+       if (ret)
                goto err_request_scr;
 
        tc6393xb->scr = ioremap(rscr->start, rscr->end - rscr->start + 1);
        if (!tc6393xb->scr) {
-               retval = -ENOMEM;
+               ret = -ENOMEM;
                goto err_ioremap;
        }
 
-       retval = clk_enable(tc6393xb->clk);
-       if (retval)
+       ret = clk_enable(tc6393xb->clk);
+       if (ret)
                goto err_clk_enable;
 
-       retval = tcpd->enable(dev);
-       if (retval)
+       ret = tcpd->enable(dev);
+       if (ret)
                goto err_enable;
 
-       tc6393xb->suspend_state.fer = 0;
-       for (i = 0; i < 3; i++) {
-               tc6393xb->suspend_state.gpo_dsr[i] =
-                       (tcpd->scr_gpo_dsr >> (8 * i)) & 0xff;
-               tc6393xb->suspend_state.gpo_doecr[i] =
-                       (tcpd->scr_gpo_doecr >> (8 * i)) & 0xff;
-       }
-       /*
-        * It may be necessary to change this back to
-        * platform-dependant code
-        */
-       tc6393xb->suspend_state.ccr = SCR_CCR_UNK1 |
-                                       SCR_CCR_HCLK_48;
-
-       retval = tc6393xb_hw_init(dev);
-       if (retval)
-               goto err_hw_init;
+       iowrite8(0,                             tc6393xb->scr + SCR_FER);
+       iowrite16(tcpd->scr_pll2cr,             tc6393xb->scr + SCR_PLL2CR);
+       iowrite16(SCR_CCR_UNK1 | SCR_CCR_HCLK_48,
+                                               tc6393xb->scr + SCR_CCR);
+       iowrite16(SCR_MCR_RDY_OPENDRAIN | SCR_MCR_RDY_UNK | SCR_MCR_RDY_EN |
+                 SCR_MCR_INT_OPENDRAIN | SCR_MCR_INT_UNK | SCR_MCR_INT_EN |
+                 BIT(15),                      tc6393xb->scr + SCR_MCR);
+       iowrite16(tcpd->scr_gper,               tc6393xb->scr + SCR_GPER);
+       iowrite8(0,                             tc6393xb->scr + SCR_IRR);
+       iowrite8(0xbf,                          tc6393xb->scr + SCR_IMR);
 
        printk(KERN_INFO "Toshiba tc6393xb revision %d at 0x%08lx, irq %d\n",
-                       ioread8(tc6393xb->scr + SCR_REVID),
+                       tmio_ioread8(tc6393xb->scr + SCR_REVID),
                        (unsigned long) iomem->start, tc6393xb->irq);
 
        tc6393xb->gpio.base = -1;
 
        if (tcpd->gpio_base >= 0) {
-               retval = tc6393xb_register_gpio(tc6393xb, tcpd->gpio_base);
-               if (retval)
+               ret = tc6393xb_register_gpio(tc6393xb, tcpd->gpio_base);
+               if (ret)
                        goto err_gpio_add;
        }
 
-       if (tc6393xb->irq)
-               tc6393xb_attach_irq(dev);
+       tc6393xb_attach_irq(dev);
 
-       tc6393xb_cells[TC6393XB_CELL_NAND].driver_data = tcpd->nand_data;
+       if (tcpd->setup) {
+               ret = tcpd->setup(dev);
+               if (ret)
+                       goto err_setup;
+       }
 
-       retval = mfd_add_devices(dev,
+       tc6393xb_cells[TC6393XB_CELL_NAND].driver_data = tcpd->nand_data;
+       tc6393xb_cells[TC6393XB_CELL_NAND].platform_data =
+               &tc6393xb_cells[TC6393XB_CELL_NAND];
+       tc6393xb_cells[TC6393XB_CELL_NAND].data_size =
+               sizeof(tc6393xb_cells[TC6393XB_CELL_NAND]);
+
+       tc6393xb_cells[TC6393XB_CELL_MMC].platform_data =
+               &tc6393xb_cells[TC6393XB_CELL_MMC];
+       tc6393xb_cells[TC6393XB_CELL_MMC].data_size =
+               sizeof(tc6393xb_cells[TC6393XB_CELL_MMC]);
+
+       tc6393xb_cells[TC6393XB_CELL_OHCI].platform_data =
+               &tc6393xb_cells[TC6393XB_CELL_OHCI];
+       tc6393xb_cells[TC6393XB_CELL_OHCI].data_size =
+               sizeof(tc6393xb_cells[TC6393XB_CELL_OHCI]);
+
+       tc6393xb_cells[TC6393XB_CELL_FB].driver_data = tcpd->fb_data;
+       tc6393xb_cells[TC6393XB_CELL_FB].platform_data =
+               &tc6393xb_cells[TC6393XB_CELL_FB];
+       tc6393xb_cells[TC6393XB_CELL_FB].data_size =
+               sizeof(tc6393xb_cells[TC6393XB_CELL_FB]);
+
+       ret = mfd_add_devices(&dev->dev, dev->id,
                        tc6393xb_cells, ARRAY_SIZE(tc6393xb_cells),
                        iomem, tcpd->irq_base);
 
-       return 0;
+       if (!ret)
+               return 0;
 
-       if (tc6393xb->irq)
-               tc6393xb_detach_irq(dev);
+       if (tcpd->teardown)
+               tcpd->teardown(dev);
+
+err_setup:
+       tc6393xb_detach_irq(dev);
 
 err_gpio_add:
        if (tc6393xb->gpio.base != -1)
                temp = gpiochip_remove(&tc6393xb->gpio);
-err_hw_init:
        tcpd->disable(dev);
 err_clk_enable:
        clk_disable(tc6393xb->clk);
@@ -489,10 +739,11 @@ err_ioremap:
        release_resource(&tc6393xb->rscr);
 err_request_scr:
        clk_put(tc6393xb->clk);
+err_noirq:
 err_clk_get:
        kfree(tc6393xb);
 err_kzalloc:
-       return retval;
+       return ret;
 }
 
 static int __devexit tc6393xb_remove(struct platform_device *dev)
@@ -501,10 +752,12 @@ static int __devexit tc6393xb_remove(struct platform_device *dev)
        struct tc6393xb *tc6393xb = platform_get_drvdata(dev);
        int ret;
 
-       mfd_remove_devices(dev);
+       mfd_remove_devices(&dev->dev);
+
+       if (tcpd->teardown)
+               tcpd->teardown(dev);
 
-       if (tc6393xb->irq)
-               tc6393xb_detach_irq(dev);
+       tc6393xb_detach_irq(dev);
 
        if (tc6393xb->gpio.base != -1) {
                ret = gpiochip_remove(&tc6393xb->gpio);
@@ -515,17 +768,11 @@ static int __devexit tc6393xb_remove(struct platform_device *dev)
        }
 
        ret = tcpd->disable(dev);
-
        clk_disable(tc6393xb->clk);
-
        iounmap(tc6393xb->scr);
-
        release_resource(&tc6393xb->rscr);
-
        platform_set_drvdata(dev, NULL);
-
        clk_put(tc6393xb->clk);
-
        kfree(tc6393xb);
 
        return ret;
@@ -536,8 +783,7 @@ static int tc6393xb_suspend(struct platform_device *dev, pm_message_t state)
 {
        struct tc6393xb_platform_data *tcpd = dev->dev.platform_data;
        struct tc6393xb *tc6393xb = platform_get_drvdata(dev);
-       int i;
-
+       int i, ret;
 
        tc6393xb->suspend_state.ccr = ioread16(tc6393xb->scr + SCR_CCR);
        tc6393xb->suspend_state.fer = ioread8(tc6393xb->scr + SCR_FER);
@@ -550,19 +796,48 @@ static int tc6393xb_suspend(struct platform_device *dev, pm_message_t state)
                tc6393xb->suspend_state.gpi_bcr[i] =
                        ioread8(tc6393xb->scr + SCR_GPI_BCR(i));
        }
+       ret = tcpd->suspend(dev);
+       clk_disable(tc6393xb->clk);
 
-       return tcpd->suspend(dev);
+       return ret;
 }
 
 static int tc6393xb_resume(struct platform_device *dev)
 {
        struct tc6393xb_platform_data *tcpd = dev->dev.platform_data;
-       int ret = tcpd->resume(dev);
+       struct tc6393xb *tc6393xb = platform_get_drvdata(dev);
+       int ret;
+       int i;
 
+       clk_enable(tc6393xb->clk);
+
+       ret = tcpd->resume(dev);
        if (ret)
                return ret;
 
-       return tc6393xb_hw_init(dev);
+       if (!tcpd->resume_restore)
+               return 0;
+
+       iowrite8(tc6393xb->suspend_state.fer,   tc6393xb->scr + SCR_FER);
+       iowrite16(tcpd->scr_pll2cr,             tc6393xb->scr + SCR_PLL2CR);
+       iowrite16(tc6393xb->suspend_state.ccr,  tc6393xb->scr + SCR_CCR);
+       iowrite16(SCR_MCR_RDY_OPENDRAIN | SCR_MCR_RDY_UNK | SCR_MCR_RDY_EN |
+                 SCR_MCR_INT_OPENDRAIN | SCR_MCR_INT_UNK | SCR_MCR_INT_EN |
+                 BIT(15),                      tc6393xb->scr + SCR_MCR);
+       iowrite16(tcpd->scr_gper,               tc6393xb->scr + SCR_GPER);
+       iowrite8(0,                             tc6393xb->scr + SCR_IRR);
+       iowrite8(0xbf,                          tc6393xb->scr + SCR_IMR);
+
+       for (i = 0; i < 3; i++) {
+               iowrite8(tc6393xb->suspend_state.gpo_dsr[i],
+                                       tc6393xb->scr + SCR_GPO_DSR(i));
+               iowrite8(tc6393xb->suspend_state.gpo_doecr[i],
+                                       tc6393xb->scr + SCR_GPO_DOECR(i));
+               iowrite8(tc6393xb->suspend_state.gpi_bcr[i],
+                                       tc6393xb->scr + SCR_GPI_BCR(i));
+       }
+
+       return 0;
 }
 #else
 #define tc6393xb_suspend NULL
@@ -594,7 +869,8 @@ static void __exit tc6393xb_exit(void)
 subsys_initcall(tc6393xb_init);
 module_exit(tc6393xb_exit);
 
-MODULE_LICENSE("GPL");
+MODULE_LICENSE("GPL v2");
 MODULE_AUTHOR("Ian Molton, Dmitry Baryshkov and Dirk Opfer");
 MODULE_DESCRIPTION("tc6393xb Toshiba Mobile IO Controller");
 MODULE_ALIAS("platform:tc6393xb");
+