ahci: disable SNotification capability for ich8
[safe/jmp/linux-2.6] / drivers / media / video / vino.c
index ed4394e..b034a81 100644 (file)
@@ -8,19 +8,21 @@
  *
  * Based on the previous version of the driver for 2.4 kernels by:
  * Copyright (C) 2003 Ladislav Michl <ladis@linux-mips.org>
+ *
+ * v4l2_device/v4l2_subdev conversion by:
+ * Copyright (C) 2009 Hans Verkuil <hverkuil@xs4all.nl>
+ *
+ * Note: this conversion is untested! Please contact the linux-media
+ * mailinglist if you can test this, together with the test results.
  */
 
 /*
  * TODO:
- * - remove "hacks" from memory allocation code and implement nopage()
+ * - remove "mark pages reserved-hacks" from memory allocation code
+ *   and implement fault()
  * - check decimation, calculating and reporting image size when
  *   using decimation
- * - check vino_acquire_input(), vino_set_input() and channel
- *   ownership handling
- * - report VINO error-interrupts via ioctls ?
- * - implement picture controls (all implemented?)
- * - use macros for boolean values (?)
- * - implement user mode buffers and overlay (?)
+ * - implement read(), user mode buffers and overlay (?)
  */
 
 #include <linux/init.h>
 #include <linux/interrupt.h>
 #include <linux/kernel.h>
 #include <linux/mm.h>
-#include <linux/moduleparam.h>
 #include <linux/time.h>
 #include <linux/version.h>
-
-#ifdef CONFIG_KMOD
 #include <linux/kmod.h>
-#endif
 
 #include <linux/i2c.h>
-#include <linux/i2c-algo-sgi.h>
 
-#include <linux/videodev.h>
 #include <linux/videodev2.h>
-#include <linux/video_decoder.h>
+#include <media/v4l2-device.h>
+#include <media/v4l2-ioctl.h>
+#include <linux/mutex.h>
 
 #include <asm/paccess.h>
 #include <asm/io.h>
  * debug info.
  * Note that the debug output also slows down the driver significantly */
 // #define VINO_DEBUG
+// #define VINO_DEBUG_INT
 
-#define VINO_MODULE_VERSION "0.0.3"
-#define VINO_VERSION_CODE KERNEL_VERSION(0, 0, 3)
+#define VINO_MODULE_VERSION "0.0.6"
+#define VINO_VERSION_CODE KERNEL_VERSION(0, 0, 6)
 
 MODULE_DESCRIPTION("SGI VINO Video4Linux2 driver");
 MODULE_VERSION(VINO_MODULE_VERSION);
 MODULE_AUTHOR("Mikael Nousiainen <tmnousia@cc.hut.fi>");
 MODULE_LICENSE("GPL");
 
-#define mem_map_reserve(p) set_bit(PG_reserved, &((p)->flags))
-#define mem_map_unreserve(p) clear_bit(PG_reserved, &((p)->flags))
-
 #ifdef VINO_DEBUG
 #define dprintk(x...) printk("VINO: " x);
 #else
@@ -91,15 +87,16 @@ MODULE_LICENSE("GPL");
 #define VINO_MIN_HEIGHT                        32
 
 #define VINO_CLIPPING_START_ODD_D1     1
-#define VINO_CLIPPING_START_ODD_PAL    1
-#define VINO_CLIPPING_START_ODD_NTSC   1
+#define VINO_CLIPPING_START_ODD_PAL    15
+#define VINO_CLIPPING_START_ODD_NTSC   12
 
 #define VINO_CLIPPING_START_EVEN_D1    2
-#define VINO_CLIPPING_START_EVEN_PAL   2
-#define VINO_CLIPPING_START_EVEN_NTSC  2
+#define VINO_CLIPPING_START_EVEN_PAL   15
+#define VINO_CLIPPING_START_EVEN_NTSC  12
 
 #define VINO_INPUT_CHANNEL_COUNT       3
 
+/* the number is the index for vino_inputs */
 #define VINO_INPUT_NONE                        -1
 #define VINO_INPUT_COMPOSITE           0
 #define VINO_INPUT_SVIDEO              1
@@ -107,15 +104,13 @@ MODULE_LICENSE("GPL");
 
 #define VINO_PAGE_RATIO                        (PAGE_SIZE / VINO_PAGE_SIZE)
 
-#define VINO_FIFO_THRESHOLD_DEFAULT    512
+#define VINO_FIFO_THRESHOLD_DEFAULT    16
 
-/*#define VINO_FRAMEBUFFER_SIZE                (VINO_PAL_WIDTH * VINO_PAL_HEIGHT * 4 \
-  + 2 * PAGE_SIZE)*/
 #define VINO_FRAMEBUFFER_SIZE          ((VINO_PAL_WIDTH \
                                          * VINO_PAL_HEIGHT * 4 \
                                          + 3 * PAGE_SIZE) & ~(PAGE_SIZE - 1))
 
-#define VINO_FRAMEBUFFER_MAX_COUNT     8
+#define VINO_FRAMEBUFFER_COUNT_MAX     8
 
 #define VINO_FRAMEBUFFER_UNUSED                0
 #define VINO_FRAMEBUFFER_IN_USE                1
@@ -131,27 +126,40 @@ MODULE_LICENSE("GPL");
 #define VINO_DUMMY_DESC_COUNT          4
 #define VINO_DESC_FETCH_DELAY          5       /* microseconds */
 
+#define VINO_MAX_FRAME_SKIP_COUNT      128
+
 /* the number is the index for vino_data_formats */
 #define VINO_DATA_FMT_NONE             -1
 #define VINO_DATA_FMT_GREY             0
 #define VINO_DATA_FMT_RGB332           1
 #define VINO_DATA_FMT_RGB32            2
 #define VINO_DATA_FMT_YUV              3
-//#define VINO_DATA_FMT_RGB24          4
 
 #define VINO_DATA_FMT_COUNT            4
 
+/* the number is the index for vino_data_norms */
 #define VINO_DATA_NORM_NONE            -1
 #define VINO_DATA_NORM_NTSC            0
 #define VINO_DATA_NORM_PAL             1
 #define VINO_DATA_NORM_SECAM           2
 #define VINO_DATA_NORM_D1              3
-/* The following is a special entry that can be used to
- * autodetect the norm. */
-#define VINO_DATA_NORM_AUTO            0xff
 
 #define VINO_DATA_NORM_COUNT           4
 
+/* I2C controller flags */
+#define SGI_I2C_FORCE_IDLE             (0 << 0)
+#define SGI_I2C_NOT_IDLE               (1 << 0)
+#define SGI_I2C_WRITE                  (0 << 1)
+#define SGI_I2C_READ                   (1 << 1)
+#define SGI_I2C_RELEASE_BUS            (0 << 2)
+#define SGI_I2C_HOLD_BUS               (1 << 2)
+#define SGI_I2C_XFER_DONE              (0 << 4)
+#define SGI_I2C_XFER_BUSY              (1 << 4)
+#define SGI_I2C_ACK                    (0 << 5)
+#define SGI_I2C_NACK                   (1 << 5)
+#define SGI_I2C_BUS_OK                 (0 << 7)
+#define SGI_I2C_BUS_ERR                        (1 << 7)
+
 /* Internal data structure definitions */
 
 struct vino_input {
@@ -232,7 +240,7 @@ struct vino_framebuffer_fifo {
        unsigned int head;
        unsigned int tail;
 
-       unsigned int data[VINO_FRAMEBUFFER_MAX_COUNT];
+       unsigned int data[VINO_FRAMEBUFFER_COUNT_MAX];
 };
 
 struct vino_framebuffer_queue {
@@ -246,13 +254,20 @@ struct vino_framebuffer_queue {
        struct vino_framebuffer_fifo in;
        struct vino_framebuffer_fifo out;
 
-       struct vino_framebuffer *buffer[VINO_FRAMEBUFFER_MAX_COUNT];
+       struct vino_framebuffer *buffer[VINO_FRAMEBUFFER_COUNT_MAX];
 
        spinlock_t queue_lock;
-       struct semaphore queue_sem;
+       struct mutex queue_mutex;
        wait_queue_head_t frame_wait_queue;
 };
 
+struct vino_interrupt_data {
+       struct timeval timestamp;
+       unsigned int frame_counter;
+       unsigned int skip_count;
+       unsigned int skip;
+};
+
 struct vino_channel_settings {
        unsigned int channel;
 
@@ -280,28 +295,28 @@ struct vino_channel_settings {
        /* the driver is currently processing the queue */
        int capturing;
 
-       struct semaphore sem;
+       struct mutex mutex;
        spinlock_t capture_lock;
 
        unsigned int users;
 
-       /* V4L support */
-       struct video_device *v4l_device;
-};
+       struct vino_interrupt_data int_data;
 
-struct vino_client {
-       /* the channel which owns this client:
-        * VINO_NO_CHANNEL, VINO_CHANNEL_A or VINO_CHANNEL_B */
-       unsigned int owner;
-       struct i2c_client *driver;
+       /* V4L support */
+       struct video_device *vdev;
 };
 
 struct vino_settings {
+       struct v4l2_device v4l2_dev;
        struct vino_channel_settings a;
        struct vino_channel_settings b;
 
-       struct vino_client decoder;
-       struct vino_client camera;
+       /* the channel which owns this client:
+        * VINO_NO_CHANNEL, VINO_CHANNEL_A or VINO_CHANNEL_B */
+       unsigned int decoder_owner;
+       struct v4l2_subdev *decoder;
+       unsigned int camera_owner;
+       struct v4l2_subdev *camera;
 
        /* a lock for vino register access */
        spinlock_t vino_lock;
@@ -315,7 +330,7 @@ struct vino_settings {
 /* Module parameters */
 
 /*
- * Using vino_pixel_conversion the ARGB32-format pixels supplied
+ * Using vino_pixel_conversion the ABGR32-format pixels supplied
  * by the VINO chip can be converted to more common formats
  * like RGBA32 (or probably RGB24 in the future). This way we
  * can give out data that can be specified correctly with
@@ -328,8 +343,10 @@ struct vino_settings {
  *
  * Use non-zero value to enable conversion.
  */
-static int vino_pixel_conversion = 0;
+static int vino_pixel_conversion;
+
 module_param_named(pixelconv, vino_pixel_conversion, int, 0);
+
 MODULE_PARM_DESC(pixelconv,
                 "enable pixel conversion (non-zero value enables)");
 
@@ -339,21 +356,33 @@ static struct sgi_vino *vino;
 
 static struct vino_settings *vino_drvdata;
 
+#define camera_call(o, f, args...) \
+       v4l2_subdev_call(vino_drvdata->camera, o, f, ##args)
+#define decoder_call(o, f, args...) \
+       v4l2_subdev_call(vino_drvdata->decoder, o, f, ##args)
+
 static const char *vino_driver_name = "vino";
 static const char *vino_driver_description = "SGI VINO";
 static const char *vino_bus_name = "GIO64 bus";
-static const char *vino_v4l_device_name_a = "SGI VINO Channel A";
-static const char *vino_v4l_device_name_b = "SGI VINO Channel B";
+static const char *vino_vdev_name_a = "SGI VINO Channel A";
+static const char *vino_vdev_name_b = "SGI VINO Channel B";
+
+static void vino_capture_tasklet(unsigned long channel);
+
+DECLARE_TASKLET(vino_tasklet_a, vino_capture_tasklet, VINO_CHANNEL_A);
+DECLARE_TASKLET(vino_tasklet_b, vino_capture_tasklet, VINO_CHANNEL_B);
 
 static const struct vino_input vino_inputs[] = {
        {
                .name           = "Composite",
-               .std            = V4L2_STD_NTSC | V4L2_STD_PAL | V4L2_STD_SECAM,
-       },{
+               .std            = V4L2_STD_NTSC | V4L2_STD_PAL
+               | V4L2_STD_SECAM,
+       }, {
                .name           = "S-Video",
-               .std            = V4L2_STD_NTSC | V4L2_STD_PAL | V4L2_STD_SECAM,
-       },{
-               .name           = "D1 (IndyCam)",
+               .std            = V4L2_STD_NTSC | V4L2_STD_PAL
+               | V4L2_STD_SECAM,
+       }, {
+               .name           = "D1/IndyCam",
                .std            = V4L2_STD_NTSC,
        }
 };
@@ -364,27 +393,22 @@ static const struct vino_data_format vino_data_formats[] = {
                .bpp            = 1,
                .pixelformat    = V4L2_PIX_FMT_GREY,
                .colorspace     = V4L2_COLORSPACE_SMPTE170M,
-       },{
+       }, {
                .description    = "8-bit dithered RGB 3-3-2",
                .bpp            = 1,
                .pixelformat    = V4L2_PIX_FMT_RGB332,
                .colorspace     = V4L2_COLORSPACE_SRGB,
-       },{
+       }, {
                .description    = "32-bit RGB",
                .bpp            = 4,
                .pixelformat    = V4L2_PIX_FMT_RGB32,
                .colorspace     = V4L2_COLORSPACE_SRGB,
-       },{
+       }, {
                .description    = "YUV 4:2:2",
-               .bpp            = 4,
+               .bpp            = 2,
                .pixelformat    = V4L2_PIX_FMT_YUYV, // XXX: swapped?
                .colorspace     = V4L2_COLORSPACE_SMPTE170M,
-       }/*,{
-               .description    = "24-bit RGB",
-               .bpp            = 3,
-               .pixelformat    = V4L2_PIX_FMT_RGB24,
-               .colorspace     = V4L2_COLORSPACE_SRGB,
-               }*/
+       }
 };
 
 static const struct vino_data_norm vino_data_norms[] = {
@@ -397,20 +421,20 @@ static const struct vino_data_norm vino_data_norms[] = {
                .width          = VINO_NTSC_WIDTH,
                .height         = VINO_NTSC_HEIGHT,
                .odd            = {
-                       .top    = VINO_CLIPPING_START_ODD_NTSC,
-                       .left   = 0,
+                       .top    = VINO_CLIPPING_START_ODD_NTSC,
+                       .left   = 0,
                        .bottom = VINO_CLIPPING_START_ODD_NTSC
                        + VINO_NTSC_HEIGHT / 2 - 1,
-                       .right  = VINO_NTSC_WIDTH,
+                       .right  = VINO_NTSC_WIDTH,
                },
                .even           = {
-                       .top    = VINO_CLIPPING_START_EVEN_NTSC,
-                       .left   = 0,
+                       .top    = VINO_CLIPPING_START_EVEN_NTSC,
+                       .left   = 0,
                        .bottom = VINO_CLIPPING_START_EVEN_NTSC
                        + VINO_NTSC_HEIGHT / 2 - 1,
-                       .right  = VINO_NTSC_WIDTH,
+                       .right  = VINO_NTSC_WIDTH,
                },
-       },{
+       }, {
                .description    = "PAL",
                .std            = V4L2_STD_PAL,
                .fps_min        = 5,
@@ -419,20 +443,20 @@ static const struct vino_data_norm vino_data_norms[] = {
                .width          = VINO_PAL_WIDTH,
                .height         = VINO_PAL_HEIGHT,
                .odd            = {
-                       .top    = VINO_CLIPPING_START_ODD_PAL,
-                       .left   = 0,
+                       .top    = VINO_CLIPPING_START_ODD_PAL,
+                       .left   = 0,
                        .bottom = VINO_CLIPPING_START_ODD_PAL
                        + VINO_PAL_HEIGHT / 2 - 1,
-                       .right  = VINO_PAL_WIDTH,
+                       .right  = VINO_PAL_WIDTH,
                },
                .even           = {
-                       .top    = VINO_CLIPPING_START_EVEN_PAL,
-                       .left   = 0,
+                       .top    = VINO_CLIPPING_START_EVEN_PAL,
+                       .left   = 0,
                        .bottom = VINO_CLIPPING_START_EVEN_PAL
                        + VINO_PAL_HEIGHT / 2 - 1,
-                       .right  = VINO_PAL_WIDTH,
+                       .right  = VINO_PAL_WIDTH,
                },
-       },{
+       }, {
                .description    = "SECAM",
                .std            = V4L2_STD_SECAM,
                .fps_min        = 5,
@@ -441,21 +465,21 @@ static const struct vino_data_norm vino_data_norms[] = {
                .width          = VINO_PAL_WIDTH,
                .height         = VINO_PAL_HEIGHT,
                .odd            = {
-                       .top    = VINO_CLIPPING_START_ODD_PAL,
-                       .left   = 0,
+                       .top    = VINO_CLIPPING_START_ODD_PAL,
+                       .left   = 0,
                        .bottom = VINO_CLIPPING_START_ODD_PAL
                        + VINO_PAL_HEIGHT / 2 - 1,
-                       .right  = VINO_PAL_WIDTH,
+                       .right  = VINO_PAL_WIDTH,
                },
                .even           = {
-                       .top    = VINO_CLIPPING_START_EVEN_PAL,
-                       .left   = 0,
+                       .top    = VINO_CLIPPING_START_EVEN_PAL,
+                       .left   = 0,
                        .bottom = VINO_CLIPPING_START_EVEN_PAL
                        + VINO_PAL_HEIGHT / 2 - 1,
-                       .right  = VINO_PAL_WIDTH,
+                       .right  = VINO_PAL_WIDTH,
                },
-       },{
-               .description    = "NTSC (D1 input)",
+       }, {
+               .description    = "NTSC/D1",
                .std            = V4L2_STD_NTSC,
                .fps_min        = 6,
                .fps_max        = 30,
@@ -463,18 +487,18 @@ static const struct vino_data_norm vino_data_norms[] = {
                .width          = VINO_NTSC_WIDTH,
                .height         = VINO_NTSC_HEIGHT,
                .odd            = {
-                       .top    = VINO_CLIPPING_START_ODD_D1,
-                       .left   = 0,
+                       .top    = VINO_CLIPPING_START_ODD_D1,
+                       .left   = 0,
                        .bottom = VINO_CLIPPING_START_ODD_D1
                        + VINO_NTSC_HEIGHT / 2 - 1,
-                       .right  = VINO_NTSC_WIDTH,
+                       .right  = VINO_NTSC_WIDTH,
                },
                .even           = {
-                       .top    = VINO_CLIPPING_START_EVEN_D1,
-                       .left   = 0,
+                       .top    = VINO_CLIPPING_START_EVEN_D1,
+                       .left   = 0,
                        .bottom = VINO_CLIPPING_START_EVEN_D1
                        + VINO_NTSC_HEIGHT / 2 - 1,
-                       .right  = VINO_NTSC_WIDTH,
+                       .right  = VINO_NTSC_WIDTH,
                },
        }
 };
@@ -490,9 +514,7 @@ struct v4l2_queryctrl vino_indycam_v4l2_controls[] = {
                .maximum = 1,
                .step = 1,
                .default_value = INDYCAM_AGC_DEFAULT,
-               .flags = 0,
-               .reserved = { 0, 0 },
-       },{
+       }, {
                .id = V4L2_CID_AUTO_WHITE_BALANCE,
                .type = V4L2_CTRL_TYPE_BOOLEAN,
                .name = "Automatic White Balance",
@@ -500,9 +522,7 @@ struct v4l2_queryctrl vino_indycam_v4l2_controls[] = {
                .maximum = 1,
                .step = 1,
                .default_value = INDYCAM_AWB_DEFAULT,
-               .flags = 0,
-               .reserved = { 0, 0 },
-       },{
+       }, {
                .id = V4L2_CID_GAIN,
                .type = V4L2_CTRL_TYPE_INTEGER,
                .name = "Gain",
@@ -510,29 +530,23 @@ struct v4l2_queryctrl vino_indycam_v4l2_controls[] = {
                .maximum = INDYCAM_GAIN_MAX,
                .step = 1,
                .default_value = INDYCAM_GAIN_DEFAULT,
-               .flags = 0,
-               .reserved = { 0, 0 },
-       },{
-               .id = V4L2_CID_PRIVATE_BASE,
+       }, {
+               .id = INDYCAM_CONTROL_RED_SATURATION,
                .type = V4L2_CTRL_TYPE_INTEGER,
                .name = "Red Saturation",
                .minimum = INDYCAM_RED_SATURATION_MIN,
                .maximum = INDYCAM_RED_SATURATION_MAX,
                .step = 1,
                .default_value = INDYCAM_RED_SATURATION_DEFAULT,
-               .flags = 0,
-               .reserved = { 0, 0 },
-       },{
-               .id = V4L2_CID_PRIVATE_BASE + 1,
+       }, {
+               .id = INDYCAM_CONTROL_BLUE_SATURATION,
                .type = V4L2_CTRL_TYPE_INTEGER,
                .name = "Blue Saturation",
                .minimum = INDYCAM_BLUE_SATURATION_MIN,
                .maximum = INDYCAM_BLUE_SATURATION_MAX,
                .step = 1,
                .default_value = INDYCAM_BLUE_SATURATION_DEFAULT,
-               .flags = 0,
-               .reserved = { 0, 0 },
-       },{
+       }, {
                .id = V4L2_CID_RED_BALANCE,
                .type = V4L2_CTRL_TYPE_INTEGER,
                .name = "Red Balance",
@@ -540,9 +554,7 @@ struct v4l2_queryctrl vino_indycam_v4l2_controls[] = {
                .maximum = INDYCAM_RED_BALANCE_MAX,
                .step = 1,
                .default_value = INDYCAM_RED_BALANCE_DEFAULT,
-               .flags = 0,
-               .reserved = { 0, 0 },
-       },{
+       }, {
                .id = V4L2_CID_BLUE_BALANCE,
                .type = V4L2_CTRL_TYPE_INTEGER,
                .name = "Blue Balance",
@@ -550,9 +562,7 @@ struct v4l2_queryctrl vino_indycam_v4l2_controls[] = {
                .maximum = INDYCAM_BLUE_BALANCE_MAX,
                .step = 1,
                .default_value = INDYCAM_BLUE_BALANCE_DEFAULT,
-               .flags = 0,
-               .reserved = { 0, 0 },
-       },{
+       }, {
                .id = V4L2_CID_EXPOSURE,
                .type = V4L2_CTRL_TYPE_INTEGER,
                .name = "Shutter Control",
@@ -560,9 +570,7 @@ struct v4l2_queryctrl vino_indycam_v4l2_controls[] = {
                .maximum = INDYCAM_SHUTTER_MAX,
                .step = 1,
                .default_value = INDYCAM_SHUTTER_DEFAULT,
-               .flags = 0,
-               .reserved = { 0, 0 },
-       },{
+       }, {
                .id = V4L2_CID_GAMMA,
                .type = V4L2_CTRL_TYPE_INTEGER,
                .name = "Gamma",
@@ -570,12 +578,10 @@ struct v4l2_queryctrl vino_indycam_v4l2_controls[] = {
                .maximum = INDYCAM_GAMMA_MAX,
                .step = 1,
                .default_value = INDYCAM_GAMMA_DEFAULT,
-               .flags = 0,
-               .reserved = { 0, 0 },
        }
 };
 
-#define VINO_SAA7191_V4L2_CONTROL_COUNT                2
+#define VINO_SAA7191_V4L2_CONTROL_COUNT                9
 
 struct v4l2_queryctrl vino_saa7191_v4l2_controls[] = {
        {
@@ -586,137 +592,73 @@ struct v4l2_queryctrl vino_saa7191_v4l2_controls[] = {
                .maximum = SAA7191_HUE_MAX,
                .step = 1,
                .default_value = SAA7191_HUE_DEFAULT,
-               .flags = 0,
-               .reserved = { 0, 0 },
-       },{
-               .id = V4L2_CID_PRIVATE_BASE,
+       }, {
+               .id = SAA7191_CONTROL_BANDPASS,
+               .type = V4L2_CTRL_TYPE_INTEGER,
+               .name = "Luminance Bandpass",
+               .minimum = SAA7191_BANDPASS_MIN,
+               .maximum = SAA7191_BANDPASS_MAX,
+               .step = 1,
+               .default_value = SAA7191_BANDPASS_DEFAULT,
+       }, {
+               .id = SAA7191_CONTROL_BANDPASS_WEIGHT,
+               .type = V4L2_CTRL_TYPE_INTEGER,
+               .name = "Luminance Bandpass Weight",
+               .minimum = SAA7191_BANDPASS_WEIGHT_MIN,
+               .maximum = SAA7191_BANDPASS_WEIGHT_MAX,
+               .step = 1,
+               .default_value = SAA7191_BANDPASS_WEIGHT_DEFAULT,
+       }, {
+               .id = SAA7191_CONTROL_CORING,
+               .type = V4L2_CTRL_TYPE_INTEGER,
+               .name = "HF Luminance Coring",
+               .minimum = SAA7191_CORING_MIN,
+               .maximum = SAA7191_CORING_MAX,
+               .step = 1,
+               .default_value = SAA7191_CORING_DEFAULT,
+       }, {
+               .id = SAA7191_CONTROL_FORCE_COLOUR,
+               .type = V4L2_CTRL_TYPE_BOOLEAN,
+               .name = "Force Colour",
+               .minimum = SAA7191_FORCE_COLOUR_MIN,
+               .maximum = SAA7191_FORCE_COLOUR_MAX,
+               .step = 1,
+               .default_value = SAA7191_FORCE_COLOUR_DEFAULT,
+       }, {
+               .id = SAA7191_CONTROL_CHROMA_GAIN,
+               .type = V4L2_CTRL_TYPE_INTEGER,
+               .name = "Chrominance Gain Control",
+               .minimum = SAA7191_CHROMA_GAIN_MIN,
+               .maximum = SAA7191_CHROMA_GAIN_MAX,
+               .step = 1,
+               .default_value = SAA7191_CHROMA_GAIN_DEFAULT,
+       }, {
+               .id = SAA7191_CONTROL_VTRC,
                .type = V4L2_CTRL_TYPE_BOOLEAN,
                .name = "VTR Time Constant",
                .minimum = SAA7191_VTRC_MIN,
                .maximum = SAA7191_VTRC_MAX,
                .step = 1,
                .default_value = SAA7191_VTRC_DEFAULT,
-               .flags = 0,
-               .reserved = { 0, 0 },
-       }
-};
-
-/* VINO I2C bus functions */
-
-unsigned i2c_vino_getctrl(void *data)
-{
-       return vino->i2c_control;
-}
-
-void i2c_vino_setctrl(void *data, unsigned val)
-{
-       vino->i2c_control = val;
-}
-
-unsigned i2c_vino_rdata(void *data)
-{
-       return vino->i2c_data;
-}
-
-void i2c_vino_wdata(void *data, unsigned val)
-{
-       vino->i2c_data = val;
-}
-
-static struct i2c_algo_sgi_data i2c_sgi_vino_data =
-{
-       .getctrl = &i2c_vino_getctrl,
-       .setctrl = &i2c_vino_setctrl,
-       .rdata   = &i2c_vino_rdata,
-       .wdata   = &i2c_vino_wdata,
-       .xfer_timeout = 200,
-       .ack_timeout  = 1000,
-};
-
-/*
- * There are two possible clients on VINO I2C bus, so we limit usage only
- * to them.
- */
-static int i2c_vino_client_reg(struct i2c_client *client)
-{
-       int ret = 0;
-
-       spin_lock(&vino_drvdata->input_lock);
-       switch (client->driver->id) {
-       case I2C_DRIVERID_SAA7191:
-               if (vino_drvdata->decoder.driver)
-                       ret = -EBUSY;
-               else
-                       vino_drvdata->decoder.driver = client;
-               break;
-       case I2C_DRIVERID_INDYCAM:
-               if (vino_drvdata->camera.driver)
-                       ret = -EBUSY;
-               else
-                       vino_drvdata->camera.driver = client;
-               break;
-       default:
-               ret = -ENODEV;
-       }
-       spin_unlock(&vino_drvdata->input_lock);
-
-       return ret;
-}
-
-static int i2c_vino_client_unreg(struct i2c_client *client)
-{
-       int ret = 0;
-
-       spin_lock(&vino_drvdata->input_lock);
-       if (client == vino_drvdata->decoder.driver) {
-               if (vino_drvdata->decoder.owner != VINO_NO_CHANNEL)
-                       ret = -EBUSY;
-               else
-                       vino_drvdata->decoder.driver = NULL;
-       } else if (client == vino_drvdata->camera.driver) {
-               if (vino_drvdata->camera.owner != VINO_NO_CHANNEL)
-                       ret = -EBUSY;
-               else
-                       vino_drvdata->camera.driver = NULL;
+       }, {
+               .id = SAA7191_CONTROL_LUMA_DELAY,
+               .type = V4L2_CTRL_TYPE_INTEGER,
+               .name = "Luminance Delay Compensation",
+               .minimum = SAA7191_LUMA_DELAY_MIN,
+               .maximum = SAA7191_LUMA_DELAY_MAX,
+               .step = 1,
+               .default_value = SAA7191_LUMA_DELAY_DEFAULT,
+       }, {
+               .id = SAA7191_CONTROL_VNR,
+               .type = V4L2_CTRL_TYPE_INTEGER,
+               .name = "Vertical Noise Reduction",
+               .minimum = SAA7191_VNR_MIN,
+               .maximum = SAA7191_VNR_MAX,
+               .step = 1,
+               .default_value = SAA7191_VNR_DEFAULT,
        }
-       spin_unlock(&vino_drvdata->input_lock);
-
-       return ret;
-}
-
-static struct i2c_adapter vino_i2c_adapter =
-{
-       .name                   = "VINO I2C bus",
-       .id                     = I2C_HW_SGI_VINO,
-       .algo_data              = &i2c_sgi_vino_data,
-       .client_register        = &i2c_vino_client_reg,
-       .client_unregister      = &i2c_vino_client_unreg,
 };
 
-static int vino_i2c_add_bus(void)
-{
-       return i2c_sgi_add_bus(&vino_i2c_adapter);
-}
-
-static int vino_i2c_del_bus(void)
-{
-       return i2c_sgi_del_bus(&vino_i2c_adapter);
-}
-
-static int i2c_camera_command(unsigned int cmd, void *arg)
-{
-       return vino_drvdata->camera.driver->
-               driver->command(vino_drvdata->camera.driver,
-                               cmd, arg);
-}
-
-static int i2c_decoder_command(unsigned int cmd, void *arg)
-{
-       return vino_drvdata->decoder.driver->
-               driver->command(vino_drvdata->decoder.driver,
-                               cmd, arg);
-}
-
 /* VINO framebuffer/DMA descriptor management */
 
 static void vino_free_buffer_with_count(struct vino_framebuffer *fb,
@@ -727,7 +669,7 @@ static void vino_free_buffer_with_count(struct vino_framebuffer *fb,
        dprintk("vino_free_buffer_with_count(): count = %d\n", count);
 
        for (i = 0; i < count; i++) {
-               mem_map_unreserve(virt_to_page(fb->desc_table.virtual[i]));
+               ClearPageReserved(virt_to_page((void *)fb->desc_table.virtual[i]));
                dma_unmap_single(NULL,
                                 fb->desc_table.dma_cpu[VINO_PAGE_RATIO * i],
                                 PAGE_SIZE, DMA_FROM_DEVICE);
@@ -805,7 +747,7 @@ static int vino_allocate_buffer(struct vino_framebuffer *fb,
                                dma_data_addr + VINO_PAGE_SIZE * j;
                }
 
-               mem_map_reserve(virt_to_page(fb->desc_table.virtual[i]));
+               SetPageReserved(virt_to_page((void *)fb->desc_table.virtual[i]));
        }
 
        /* page_count needs to be set anyway, because the descriptor table has
@@ -892,7 +834,7 @@ static int vino_prepare_user_buffer(struct vino_framebuffer *fb,
                                dma_data_addr + VINO_PAGE_SIZE * j;
                }
 
-               mem_map_reserve(virt_to_page(fb->desc_table.virtual[i]));
+               SetPageReserved(virt_to_page((void *)fb->desc_table.virtual[i]));
        }
 
        /* page_count needs to be set anyway, because the descriptor table has
@@ -926,14 +868,14 @@ static void vino_sync_buffer(struct vino_framebuffer *fb)
        dprintk("vino_sync_buffer():\n");
 
        for (i = 0; i < fb->desc_table.page_count; i++)
-               dma_sync_single(NULL,
-                               fb->desc_table.dma_cpu[VINO_PAGE_RATIO * i],
-                               PAGE_SIZE, DMA_FROM_DEVICE);
+               dma_sync_single_for_cpu(NULL,
+                                       fb->desc_table.dma_cpu[VINO_PAGE_RATIO * i],
+                                       PAGE_SIZE, DMA_FROM_DEVICE);
 }
 
 /* Framebuffer fifo functions (need to be locked externally) */
 
-static void vino_fifo_init(struct vino_framebuffer_fifo *f,
+static inline void vino_fifo_init(struct vino_framebuffer_fifo *f,
                           unsigned int length)
 {
        f->length = 0;
@@ -941,16 +883,18 @@ static void vino_fifo_init(struct vino_framebuffer_fifo *f,
        f->head = 0;
        f->tail = 0;
 
-       if (length > VINO_FRAMEBUFFER_MAX_COUNT)
-               length = VINO_FRAMEBUFFER_MAX_COUNT;
+       if (length > VINO_FRAMEBUFFER_COUNT_MAX)
+               length = VINO_FRAMEBUFFER_COUNT_MAX;
 
        f->length = length;
 }
 
 /* returns true/false */
-static int vino_fifo_has_id(struct vino_framebuffer_fifo *f, unsigned int id)
+static inline int vino_fifo_has_id(struct vino_framebuffer_fifo *f,
+                                  unsigned int id)
 {
        unsigned int i;
+
        for (i = f->head; i == (f->tail - 1); i = (i + 1) % f->length) {
                if (f->data[i] == id)
                        return 1;
@@ -959,13 +903,15 @@ static int vino_fifo_has_id(struct vino_framebuffer_fifo *f, unsigned int id)
        return 0;
 }
 
+#if 0
 /* returns true/false */
-static int vino_fifo_full(struct vino_framebuffer_fifo *f)
+static inline int vino_fifo_full(struct vino_framebuffer_fifo *f)
 {
        return (f->used == f->length);
 }
+#endif
 
-static unsigned int vino_fifo_get_used(struct vino_framebuffer_fifo *f)
+static inline unsigned int vino_fifo_get_used(struct vino_framebuffer_fifo *f)
 {
        return f->used;
 }
@@ -1046,11 +992,11 @@ static void vino_queue_free(struct vino_framebuffer_queue *q)
        if (q->type != VINO_MEMORY_MMAP)
                return;
 
-       down(&q->queue_sem);
+       mutex_lock(&q->queue_mutex);
 
        vino_queue_free_with_count(q, q->length);
 
-       up(&q->queue_sem);
+       mutex_unlock(&q->queue_mutex);
 }
 
 static int vino_queue_init(struct vino_framebuffer_queue *q,
@@ -1074,10 +1020,10 @@ static int vino_queue_init(struct vino_framebuffer_queue *q,
        if (*length < 1)
                return -EINVAL;
 
-       down(&q->queue_sem);
+       mutex_lock(&q->queue_mutex);
 
-       if (*length > VINO_FRAMEBUFFER_MAX_COUNT)
-               *length = VINO_FRAMEBUFFER_MAX_COUNT;
+       if (*length > VINO_FRAMEBUFFER_COUNT_MAX)
+               *length = VINO_FRAMEBUFFER_COUNT_MAX;
 
        q->length = 0;
 
@@ -1126,7 +1072,7 @@ static int vino_queue_init(struct vino_framebuffer_queue *q,
                q->magic = VINO_QUEUE_MAGIC;
        }
 
-       up(&q->queue_sem);
+       mutex_unlock(&q->queue_mutex);
 
        return ret;
 }
@@ -1313,6 +1259,7 @@ out:
        return ret;
 }
 
+#if 0
 static int vino_queue_get_total(struct vino_framebuffer_queue *q,
                                unsigned int *total)
 {
@@ -1338,6 +1285,7 @@ out:
 
        return ret;
 }
+#endif
 
 static struct vino_framebuffer *vino_queue_peek(struct
                                                vino_framebuffer_queue *q,
@@ -1467,16 +1415,18 @@ static void vino_update_line_size(struct vino_channel_settings *vcs)
        unsigned int w = vcs->clipping.right - vcs->clipping.left;
        unsigned int d = vcs->decimation;
        unsigned int bpp = vino_data_formats[vcs->data_format].bpp;
-        unsigned int lsize;
+       unsigned int lsize;
 
        dprintk("update_line_size(): before: w = %d, d = %d, "
                "line_size = %d\n", w, d, vcs->line_size);
-        /* line size must be multiple of 8 bytes */
+
+       /* line size must be multiple of 8 bytes */
        lsize = (bpp * (w / d)) & ~7;
        w = (lsize / bpp) * d;
 
        vcs->clipping.right = vcs->clipping.left + w;
        vcs->line_size = lsize;
+
        dprintk("update_line_size(): after: w = %d, d = %d, "
                "line_size = %d\n", w, d, vcs->line_size);
 }
@@ -1532,7 +1482,7 @@ static void vino_set_clipping(struct vino_channel_settings *vcs,
 }
 
 /* execute with input_lock locked */
-static void vino_set_default_clipping(struct vino_channel_settings *vcs)
+static inline void vino_set_default_clipping(struct vino_channel_settings *vcs)
 {
        vino_set_clipping(vcs, 0, 0, vino_data_norms[vcs->data_norm].width,
                          vino_data_norms[vcs->data_norm].height);
@@ -1556,8 +1506,7 @@ static void vino_set_scaling(struct vino_channel_settings *vcs,
 
        if (d < 1) {
                d = 1;
-       }
-       if (d > 8) {
+       } else if (d > 8) {
                d = 8;
        }
 
@@ -1570,7 +1519,7 @@ static void vino_set_scaling(struct vino_channel_settings *vcs,
 }
 
 /* execute with input_lock locked */
-static void vino_reset_scaling(struct vino_channel_settings *vcs)
+static inline void vino_set_default_scaling(struct vino_channel_settings *vcs)
 {
        vino_set_scaling(vcs, vcs->clipping.right - vcs->clipping.left,
                         vcs->clipping.bottom - vcs->clipping.top);
@@ -1649,11 +1598,189 @@ static void vino_set_framerate(struct vino_channel_settings *vcs,
 }
 
 /* execute with input_lock locked */
-static void vino_set_default_framerate(struct vino_channel_settings *vcs)
+static inline void vino_set_default_framerate(struct
+                                             vino_channel_settings *vcs)
 {
        vino_set_framerate(vcs, vino_data_norms[vcs->data_norm].fps_max);
 }
 
+/* VINO I2C bus functions */
+
+struct i2c_algo_sgi_data {
+       void *data;     /* private data for lowlevel routines */
+       unsigned (*getctrl)(void *data);
+       void (*setctrl)(void *data, unsigned val);
+       unsigned (*rdata)(void *data);
+       void (*wdata)(void *data, unsigned val);
+
+       int xfer_timeout;
+       int ack_timeout;
+};
+
+static int wait_xfer_done(struct i2c_algo_sgi_data *adap)
+{
+       int i;
+
+       for (i = 0; i < adap->xfer_timeout; i++) {
+               if ((adap->getctrl(adap->data) & SGI_I2C_XFER_BUSY) == 0)
+                       return 0;
+               udelay(1);
+       }
+
+       return -ETIMEDOUT;
+}
+
+static int wait_ack(struct i2c_algo_sgi_data *adap)
+{
+       int i;
+
+       if (wait_xfer_done(adap))
+               return -ETIMEDOUT;
+       for (i = 0; i < adap->ack_timeout; i++) {
+               if ((adap->getctrl(adap->data) & SGI_I2C_NACK) == 0)
+                       return 0;
+               udelay(1);
+       }
+
+       return -ETIMEDOUT;
+}
+
+static int force_idle(struct i2c_algo_sgi_data *adap)
+{
+       int i;
+
+       adap->setctrl(adap->data, SGI_I2C_FORCE_IDLE);
+       for (i = 0; i < adap->xfer_timeout; i++) {
+               if ((adap->getctrl(adap->data) & SGI_I2C_NOT_IDLE) == 0)
+                       goto out;
+               udelay(1);
+       }
+       return -ETIMEDOUT;
+out:
+       if (adap->getctrl(adap->data) & SGI_I2C_BUS_ERR)
+               return -EIO;
+       return 0;
+}
+
+static int do_address(struct i2c_algo_sgi_data *adap, unsigned int addr,
+                     int rd)
+{
+       if (rd)
+               adap->setctrl(adap->data, SGI_I2C_NOT_IDLE);
+       /* Check if bus is idle, eventually force it to do so */
+       if (adap->getctrl(adap->data) & SGI_I2C_NOT_IDLE)
+               if (force_idle(adap))
+                       return -EIO;
+       /* Write out the i2c chip address and specify operation */
+       adap->setctrl(adap->data,
+                     SGI_I2C_HOLD_BUS | SGI_I2C_WRITE | SGI_I2C_NOT_IDLE);
+       if (rd)
+               addr |= 1;
+       adap->wdata(adap->data, addr);
+       if (wait_ack(adap))
+               return -EIO;
+       return 0;
+}
+
+static int i2c_read(struct i2c_algo_sgi_data *adap, unsigned char *buf,
+                   unsigned int len)
+{
+       int i;
+
+       adap->setctrl(adap->data,
+                     SGI_I2C_HOLD_BUS | SGI_I2C_READ | SGI_I2C_NOT_IDLE);
+       for (i = 0; i < len; i++) {
+               if (wait_xfer_done(adap))
+                       return -EIO;
+               buf[i] = adap->rdata(adap->data);
+       }
+       adap->setctrl(adap->data, SGI_I2C_RELEASE_BUS | SGI_I2C_FORCE_IDLE);
+
+       return 0;
+
+}
+
+static int i2c_write(struct i2c_algo_sgi_data *adap, unsigned char *buf,
+                    unsigned int len)
+{
+       int i;
+
+       /* We are already in write state */
+       for (i = 0; i < len; i++) {
+               adap->wdata(adap->data, buf[i]);
+               if (wait_ack(adap))
+                       return -EIO;
+       }
+       return 0;
+}
+
+static int sgi_xfer(struct i2c_adapter *i2c_adap, struct i2c_msg *msgs,
+                   int num)
+{
+       struct i2c_algo_sgi_data *adap = i2c_adap->algo_data;
+       struct i2c_msg *p;
+       int i, err = 0;
+
+       for (i = 0; !err && i < num; i++) {
+               p = &msgs[i];
+               err = do_address(adap, p->addr, p->flags & I2C_M_RD);
+               if (err || !p->len)
+                       continue;
+               if (p->flags & I2C_M_RD)
+                       err = i2c_read(adap, p->buf, p->len);
+               else
+                       err = i2c_write(adap, p->buf, p->len);
+       }
+
+       return (err < 0) ? err : i;
+}
+
+static u32 sgi_func(struct i2c_adapter *adap)
+{
+       return I2C_FUNC_SMBUS_EMUL;
+}
+
+static const struct i2c_algorithm sgi_algo = {
+       .master_xfer    = sgi_xfer,
+       .functionality  = sgi_func,
+};
+
+static unsigned i2c_vino_getctrl(void *data)
+{
+       return vino->i2c_control;
+}
+
+static void i2c_vino_setctrl(void *data, unsigned val)
+{
+       vino->i2c_control = val;
+}
+
+static unsigned i2c_vino_rdata(void *data)
+{
+       return vino->i2c_data;
+}
+
+static void i2c_vino_wdata(void *data, unsigned val)
+{
+       vino->i2c_data = val;
+}
+
+static struct i2c_algo_sgi_data i2c_sgi_vino_data = {
+       .getctrl = &i2c_vino_getctrl,
+       .setctrl = &i2c_vino_setctrl,
+       .rdata   = &i2c_vino_rdata,
+       .wdata   = &i2c_vino_wdata,
+       .xfer_timeout = 200,
+       .ack_timeout  = 1000,
+};
+
+static struct i2c_adapter vino_i2c_adapter = {
+       .name                   = "VINO I2C bus",
+       .algo                   = &sgi_algo,
+       .algo_data              = &i2c_sgi_vino_data,
+       .owner                  = THIS_MODULE,
+};
+
 /*
  * Prepare VINO for DMA transfer...
  * (execute only with vino_lock and input_lock locked)
@@ -1687,6 +1814,9 @@ static int vino_dma_setup(struct vino_channel_settings *vcs,
         * should be more than enough time */
        udelay(VINO_DESC_FETCH_DELAY);
 
+       dprintk("vino_dma_setup(): start desc = %08x, next 4 desc = %08x\n",
+               ch->start_desc_tbl, ch->next_4_desc);
+
        /* set the alpha register */
        ch->alpha = vcs->alpha;
 
@@ -1700,9 +1830,6 @@ static int vino_dma_setup(struct vino_channel_settings *vcs,
                VINO_CLIP_EVEN(norm->even.top +
                               vcs->clipping.bottom / 2 - 1) |
                VINO_CLIP_X(vcs->clipping.right);
-       /* FIXME: end-of-field bug workaround
-                      VINO_CLIP_X(VINO_PAL_WIDTH);
-        */
 
        /* set the size of actual content in the buffer (DECIMATION !) */
        fb->data_size = ((vcs->clipping.right - vcs->clipping.left) /
@@ -1802,7 +1929,7 @@ static int vino_dma_setup(struct vino_channel_settings *vcs,
 }
 
 /* (execute only with vino_lock locked) */
-static void vino_dma_start(struct vino_channel_settings *vcs)
+static inline void vino_dma_start(struct vino_channel_settings *vcs)
 {
        u32 ctrl = vino->control;
 
@@ -1813,12 +1940,14 @@ static void vino_dma_start(struct vino_channel_settings *vcs)
 }
 
 /* (execute only with vino_lock locked) */
-static void vino_dma_stop(struct vino_channel_settings *vcs)
+static inline void vino_dma_stop(struct vino_channel_settings *vcs)
 {
        u32 ctrl = vino->control;
 
        ctrl &= (vcs->channel == VINO_CHANNEL_A) ?
                ~VINO_CTRL_A_DMA_ENBL : ~VINO_CTRL_B_DMA_ENBL;
+       ctrl &= (vcs->channel == VINO_CHANNEL_A) ?
+               ~VINO_CTRL_A_INT : ~VINO_CTRL_B_INT;
        vino->control = ctrl;
        dprintk("vino_dma_stop():\n");
 }
@@ -1902,7 +2031,7 @@ static int vino_capture_next(struct vino_channel_settings *vcs, int start)
        struct vino_framebuffer *fb;
        unsigned int incoming, id;
        int err = 0;
-       unsigned long flags, flags2;
+       unsigned long flags;
 
        dprintk("vino_capture_next():\n");
 
@@ -1943,10 +2072,6 @@ static int vino_capture_next(struct vino_channel_settings *vcs, int start)
                goto out;
        }
 
-       spin_lock_irqsave(&fb->state_lock, flags2);
-       fb->state = VINO_FRAMEBUFFER_UNUSED;
-       spin_unlock_irqrestore(&fb->state_lock, flags2);
-
        if (start) {
                vcs->capturing = 1;
        }
@@ -1964,7 +2089,7 @@ out:
        return err;
 }
 
-static int vino_is_capturing(struct vino_channel_settings *vcs)
+static inline int vino_is_capturing(struct vino_channel_settings *vcs)
 {
        int ret;
        unsigned long flags;
@@ -1989,12 +2114,10 @@ static int vino_wait_for_frame(struct vino_channel_settings *vcs)
        init_waitqueue_entry(&wait, current);
        /* add ourselves into wait queue */
        add_wait_queue(&vcs->fb_queue.frame_wait_queue, &wait);
-       /* and set current state */
-       set_current_state(TASK_INTERRUPTIBLE);
 
        /* to ensure that schedule_timeout will return immediately
-        * if VINO interrupt was triggred meanwhile */
-       schedule_timeout(HZ / 10);
+        * if VINO interrupt was triggered meanwhile */
+       schedule_timeout_interruptible(msecs_to_jiffies(100));
 
        if (signal_pending(current))
                err = -EINTR;
@@ -2076,6 +2199,7 @@ static void vino_capture_stop(struct vino_channel_settings *vcs)
        dprintk("vino_capture_stop():\n");
 
        spin_lock_irqsave(&vcs->capture_lock, flags);
+
        /* unset capturing to stop queue processing */
        vcs->capturing = 0;
 
@@ -2121,6 +2245,7 @@ out:
        spin_unlock_irqrestore(&vcs->capture_lock, flags);
 }
 
+#if 0
 static int vino_capture_failed(struct vino_channel_settings *vcs)
 {
        struct vino_framebuffer *fb;
@@ -2165,9 +2290,31 @@ static int vino_capture_failed(struct vino_channel_settings *vcs)
 
        return 0;
 }
+#endif
+
+static void vino_skip_frame(struct vino_channel_settings *vcs)
+{
+       struct vino_framebuffer *fb;
+       unsigned long flags;
+       unsigned int id;
+
+       spin_lock_irqsave(&vcs->capture_lock, flags);
+       fb = vino_queue_peek(&vcs->fb_queue, &id);
+       if (!fb) {
+               spin_unlock_irqrestore(&vcs->capture_lock, flags);
+               dprintk("vino_skip_frame(): vino_queue_peek() failed!\n");
+               return;
+       }
+       spin_unlock_irqrestore(&vcs->capture_lock, flags);
+
+       spin_lock_irqsave(&fb->state_lock, flags);
+       fb->state = VINO_FRAMEBUFFER_UNUSED;
+       spin_unlock_irqrestore(&fb->state_lock, flags);
+
+       vino_capture_next(vcs, 0);
+}
 
-static void vino_frame_done(struct vino_channel_settings *vcs,
-                           unsigned int fc)
+static void vino_frame_done(struct vino_channel_settings *vcs)
 {
        struct vino_framebuffer *fb;
        unsigned long flags;
@@ -2181,8 +2328,9 @@ static void vino_frame_done(struct vino_channel_settings *vcs,
        }
        spin_unlock_irqrestore(&vcs->capture_lock, flags);
 
-       fb->frame_counter = fc;
-       do_gettimeofday(&fb->timestamp);
+       fb->frame_counter = vcs->int_data.frame_counter;
+       memcpy(&fb->timestamp, &vcs->int_data.timestamp,
+              sizeof(struct timeval));
 
        spin_lock_irqsave(&fb->state_lock, flags);
        if (fb->state == VINO_FRAMEBUFFER_IN_USE)
@@ -2194,72 +2342,175 @@ static void vino_frame_done(struct vino_channel_settings *vcs,
        vino_capture_next(vcs, 0);
 }
 
-static irqreturn_t vino_interrupt(int irq, void *dev_id, struct pt_regs *regs)
+static void vino_capture_tasklet(unsigned long channel) {
+       struct vino_channel_settings *vcs;
+
+       vcs = (channel == VINO_CHANNEL_A)
+               ? &vino_drvdata->a : &vino_drvdata->b;
+
+       if (vcs->int_data.skip)
+               vcs->int_data.skip_count++;
+
+       if (vcs->int_data.skip && (vcs->int_data.skip_count
+                                  <= VINO_MAX_FRAME_SKIP_COUNT)) {
+               vino_skip_frame(vcs);
+       } else {
+               vcs->int_data.skip_count = 0;
+               vino_frame_done(vcs);
+       }
+}
+
+static irqreturn_t vino_interrupt(int irq, void *dev_id)
 {
-       u32 intr;
+       u32 ctrl, intr;
        unsigned int fc_a, fc_b;
-       int done_a = 0;
-       int done_b = 0;
+       int handled_a = 0, skip_a = 0, done_a = 0;
+       int handled_b = 0, skip_b = 0, done_b = 0;
+
+#ifdef VINO_DEBUG_INT
+       int loop = 0;
+       unsigned int line_count = vino->a.line_count,
+               page_index = vino->a.page_index,
+               field_counter = vino->a.field_counter,
+               start_desc_tbl = vino->a.start_desc_tbl,
+               next_4_desc = vino->a.next_4_desc;
+       unsigned int line_count_2,
+               page_index_2,
+               field_counter_2,
+               start_desc_tbl_2,
+               next_4_desc_2;
+#endif
 
        spin_lock(&vino_drvdata->vino_lock);
 
-       intr = vino->intr_status;
-       fc_a = vino->a.field_counter / 2;
-       fc_b = vino->b.field_counter / 2;
-
-       // TODO: handle error-interrupts in some special way ?
-
-       if (intr & VINO_INTSTAT_A) {
-               if (intr & VINO_INTSTAT_A_EOF) {
-                       vino_drvdata->a.field++;
-                       if (vino_drvdata->a.field > 1) {
+       while ((intr = vino->intr_status)) {
+               fc_a = vino->a.field_counter >> 1;
+               fc_b = vino->b.field_counter >> 1;
+
+               /* handle error-interrupts in some special way ?
+                * --> skips frames */
+               if (intr & VINO_INTSTAT_A) {
+                       if (intr & VINO_INTSTAT_A_EOF) {
+                               vino_drvdata->a.field++;
+                               if (vino_drvdata->a.field > 1) {
+                                       vino_dma_stop(&vino_drvdata->a);
+                                       vino_clear_interrupt(&vino_drvdata->a);
+                                       vino_drvdata->a.field = 0;
+                                       done_a = 1;
+                               } else {
+                                       if (vino->a.page_index
+                                           != vino_drvdata->a.line_size) {
+                                               vino->a.line_count = 0;
+                                               vino->a.page_index =
+                                                       vino_drvdata->
+                                                       a.line_size;
+                                               vino->a.next_4_desc =
+                                                       vino->a.start_desc_tbl;
+                                       }
+                               }
+                               dprintk("channel A end-of-field "
+                                       "interrupt: %04x\n", intr);
+                       } else {
                                vino_dma_stop(&vino_drvdata->a);
                                vino_clear_interrupt(&vino_drvdata->a);
                                vino_drvdata->a.field = 0;
-                               done_a = 1;
+                               skip_a = 1;
+                               dprintk("channel A error interrupt: %04x\n",
+                                       intr);
                        }
-                       dprintk("intr: channel A end-of-field interrupt: "
-                               "%04x\n", intr);
-               } else {
-                       vino_dma_stop(&vino_drvdata->a);
-                       vino_clear_interrupt(&vino_drvdata->a);
-                       done_a = 1;
-                       dprintk("channel A error interrupt: %04x\n", intr);
+
+#ifdef VINO_DEBUG_INT
+                       line_count_2 = vino->a.line_count;
+                       page_index_2 = vino->a.page_index;
+                       field_counter_2 = vino->a.field_counter;
+                       start_desc_tbl_2 = vino->a.start_desc_tbl;
+                       next_4_desc_2 = vino->a.next_4_desc;
+
+                       printk("intr = %04x, loop = %d, field = %d\n",
+                              intr, loop, vino_drvdata->a.field);
+                       printk("1- line count = %04d, page index = %04d, "
+                              "start = %08x, next = %08x\n"
+                              "   fieldc = %d, framec = %d\n",
+                              line_count, page_index, start_desc_tbl,
+                              next_4_desc, field_counter, fc_a);
+                       printk("12-line count = %04d, page index = %04d, "
+                              "   start = %08x, next = %08x\n",
+                              line_count_2, page_index_2, start_desc_tbl_2,
+                              next_4_desc_2);
+
+                       if (done_a)
+                               printk("\n");
+#endif
                }
-       }
-       if (intr & VINO_INTSTAT_B) {
-               if (intr & VINO_INTSTAT_B_EOF) {
-                       vino_drvdata->b.field++;
-                       if (vino_drvdata->b.field > 1) {
+
+               if (intr & VINO_INTSTAT_B) {
+                       if (intr & VINO_INTSTAT_B_EOF) {
+                               vino_drvdata->b.field++;
+                               if (vino_drvdata->b.field > 1) {
+                                       vino_dma_stop(&vino_drvdata->b);
+                                       vino_clear_interrupt(&vino_drvdata->b);
+                                       vino_drvdata->b.field = 0;
+                                       done_b = 1;
+                               }
+                               dprintk("channel B end-of-field "
+                                       "interrupt: %04x\n", intr);
+                       } else {
                                vino_dma_stop(&vino_drvdata->b);
                                vino_clear_interrupt(&vino_drvdata->b);
                                vino_drvdata->b.field = 0;
-                               done_b = 1;
+                               skip_b = 1;
+                               dprintk("channel B error interrupt: %04x\n",
+                                       intr);
                        }
-                       dprintk("intr: channel B end-of-field interrupt: "
-                               "%04x\n", intr);
-               } else {
-                       vino_dma_stop(&vino_drvdata->b);
-                       vino_clear_interrupt(&vino_drvdata->b);
-                       done_b = 1;
-                       dprintk("channel B error interrupt: %04x\n", intr);
                }
-       }
 
-       /* always remember to clear interrupt status */
-       vino->intr_status = ~intr;
+               /* Always remember to clear interrupt status.
+                * Disable VINO interrupts while we do this. */
+               ctrl = vino->control;
+               vino->control = ctrl & ~(VINO_CTRL_A_INT | VINO_CTRL_B_INT);
+               vino->intr_status = ~intr;
+               vino->control = ctrl;
 
-       spin_unlock(&vino_drvdata->vino_lock);
+               spin_unlock(&vino_drvdata->vino_lock);
 
-       if (done_a) {
-               vino_frame_done(&vino_drvdata->a, fc_a);
-               dprintk("channel A frame done, interrupt: %d\n", intr);
-       }
-       if (done_b) {
-               vino_frame_done(&vino_drvdata->b, fc_b);
-               dprintk("channel B frame done, interrupt: %d\n", intr);
+               if ((!handled_a) && (done_a || skip_a)) {
+                       if (!skip_a) {
+                               do_gettimeofday(&vino_drvdata->
+                                               a.int_data.timestamp);
+                               vino_drvdata->a.int_data.frame_counter = fc_a;
+                       }
+                       vino_drvdata->a.int_data.skip = skip_a;
+
+                       dprintk("channel A %s, interrupt: %d\n",
+                               skip_a ? "skipping frame" : "frame done",
+                               intr);
+                       tasklet_hi_schedule(&vino_tasklet_a);
+                       handled_a = 1;
+               }
+
+               if ((!handled_b) && (done_b || skip_b)) {
+                       if (!skip_b) {
+                               do_gettimeofday(&vino_drvdata->
+                                               b.int_data.timestamp);
+                               vino_drvdata->b.int_data.frame_counter = fc_b;
+                       }
+                       vino_drvdata->b.int_data.skip = skip_b;
+
+                       dprintk("channel B %s, interrupt: %d\n",
+                               skip_b ? "skipping frame" : "frame done",
+                               intr);
+                       tasklet_hi_schedule(&vino_tasklet_b);
+                       handled_b = 1;
+               }
+
+#ifdef VINO_DEBUG_INT
+               loop++;
+#endif
+               spin_lock(&vino_drvdata->vino_lock);
        }
 
+       spin_unlock(&vino_drvdata->vino_lock);
+
        return IRQ_HANDLED;
 }
 
@@ -2279,33 +2530,15 @@ static int vino_get_saa7191_input(int input)
        }
 }
 
-static int vino_get_saa7191_norm(int norm)
-{
-       switch (norm) {
-       case VINO_DATA_NORM_AUTO:
-               return SAA7191_NORM_AUTO;
-       case VINO_DATA_NORM_PAL:
-               return SAA7191_NORM_PAL;
-       case VINO_DATA_NORM_NTSC:
-               return SAA7191_NORM_NTSC;
-       case VINO_DATA_NORM_SECAM:
-               return SAA7191_NORM_SECAM;
-       default:
-               printk(KERN_ERR "VINO: vino_get_saa7191_norm(): "
-                      "invalid norm!\n");
-               return -1;
-       }
-}
-
 /* execute with input_lock locked */
 static int vino_is_input_owner(struct vino_channel_settings *vcs)
 {
        switch(vcs->input) {
        case VINO_INPUT_COMPOSITE:
        case VINO_INPUT_SVIDEO:
-               return (vino_drvdata->decoder.owner == vcs->channel);
+               return vino_drvdata->decoder_owner == vcs->channel;
        case VINO_INPUT_D1:
-               return (vino_drvdata->camera.owner == vcs->channel);
+               return vino_drvdata->camera_owner == vcs->channel;
        default:
                return 0;
        }
@@ -2313,42 +2546,61 @@ static int vino_is_input_owner(struct vino_channel_settings *vcs)
 
 static int vino_acquire_input(struct vino_channel_settings *vcs)
 {
+       unsigned long flags;
        int ret = 0;
 
        dprintk("vino_acquire_input():\n");
 
-       spin_lock(&vino_drvdata->input_lock);
+       spin_lock_irqsave(&vino_drvdata->input_lock, flags);
 
        /* First try D1 and then SAA7191 */
-       if (vino_drvdata->camera.driver
-           && (vino_drvdata->camera.owner == VINO_NO_CHANNEL)) {
-               if (i2c_use_client(vino_drvdata->camera.driver)) {
-                       ret = -ENODEV;
-                       goto out;
-               }
-
-               vino_drvdata->camera.owner = vcs->channel;
+       if (vino_drvdata->camera
+           && (vino_drvdata->camera_owner == VINO_NO_CHANNEL)) {
+               vino_drvdata->camera_owner = vcs->channel;
                vcs->input = VINO_INPUT_D1;
                vcs->data_norm = VINO_DATA_NORM_D1;
-       } else if (vino_drvdata->decoder.driver
-                  && (vino_drvdata->decoder.owner == VINO_NO_CHANNEL)) {
-               int saa7191_input;
-               int saa7191_norm;
+       } else if (vino_drvdata->decoder
+                  && (vino_drvdata->decoder_owner == VINO_NO_CHANNEL)) {
+               int input;
+               int data_norm;
+               v4l2_std_id norm;
+
+               input = VINO_INPUT_COMPOSITE;
 
-               if (i2c_use_client(vino_drvdata->decoder.driver)) {
-                       ret = -ENODEV;
+               ret = decoder_call(video, s_routing,
+                               vino_get_saa7191_input(input), 0, 0);
+               if (ret) {
+                       ret = -EINVAL;
                        goto out;
                }
 
-               vino_drvdata->decoder.owner = vcs->channel;
-               vcs->input = VINO_INPUT_COMPOSITE;
-               vcs->data_norm = VINO_DATA_NORM_PAL;
+               spin_unlock_irqrestore(&vino_drvdata->input_lock, flags);
 
-               saa7191_input = vino_get_saa7191_input(vcs->input);
-               i2c_decoder_command(DECODER_SET_INPUT, &saa7191_input);
+               /* Don't hold spinlocks while auto-detecting norm
+                * as it may take a while... */
+
+               ret = decoder_call(video, querystd, &norm);
+               if (!ret) {
+                       for (data_norm = 0; data_norm < 3; data_norm++) {
+                               if (vino_data_norms[data_norm].std & norm)
+                                       break;
+                       }
+                       if (data_norm == 3)
+                               data_norm = VINO_DATA_NORM_PAL;
+                       ret = decoder_call(core, s_std, norm);
+               }
 
-               saa7191_norm = vino_get_saa7191_norm(vcs->data_norm);
-               i2c_decoder_command(DECODER_SAA7191_SET_NORM, &saa7191_norm);
+               spin_lock_irqsave(&vino_drvdata->input_lock, flags);
+
+               if (ret) {
+                       ret = -EINVAL;
+                       goto out;
+               }
+
+               vino_drvdata->decoder_owner = vcs->channel;
+
+               vcs->input = input;
+               vcs->data_norm = data_norm;
        } else {
                vcs->input = (vcs->channel == VINO_CHANNEL_A) ?
                        vino_drvdata->b.input : vino_drvdata->a.input;
@@ -2361,15 +2613,14 @@ static int vino_acquire_input(struct vino_channel_settings *vcs)
                goto out;
        }
 
-       if (vino_is_input_owner(vcs)) {
-               vino_set_default_clipping(vcs);
-               vino_set_default_framerate(vcs);
-       }
+       vino_set_default_clipping(vcs);
+       vino_set_default_scaling(vcs);
+       vino_set_default_framerate(vcs);
 
        dprintk("vino_acquire_input(): %s\n", vino_inputs[vcs->input].name);
 
 out:
-       spin_unlock(&vino_drvdata->input_lock);
+       spin_unlock_irqrestore(&vino_drvdata->input_lock, flags);
 
        return ret;
 }
@@ -2378,45 +2629,68 @@ static int vino_set_input(struct vino_channel_settings *vcs, int input)
 {
        struct vino_channel_settings *vcs2 = (vcs->channel == VINO_CHANNEL_A) ?
                &vino_drvdata->b : &vino_drvdata->a;
+       unsigned long flags;
        int ret = 0;
 
        dprintk("vino_set_input():\n");
 
-       spin_lock(&vino_drvdata->input_lock);
+       spin_lock_irqsave(&vino_drvdata->input_lock, flags);
 
        if (vcs->input == input)
                goto out;
 
-       switch(input) {
+       switch (input) {
        case VINO_INPUT_COMPOSITE:
        case VINO_INPUT_SVIDEO:
-               if (!vino_drvdata->decoder.driver) {
+               if (!vino_drvdata->decoder) {
                        ret = -EINVAL;
                        goto out;
                }
 
-               if (vino_drvdata->decoder.owner == VINO_NO_CHANNEL) {
-                       if (i2c_use_client(vino_drvdata->decoder.driver)) {
-                               ret = -ENODEV;
+               if (vino_drvdata->decoder_owner == VINO_NO_CHANNEL) {
+                       vino_drvdata->decoder_owner = vcs->channel;
+               }
+
+               if (vino_drvdata->decoder_owner == vcs->channel) {
+                       int data_norm;
+                       v4l2_std_id norm;
+
+                       ret = decoder_call(video, s_routing,
+                                       vino_get_saa7191_input(input), 0, 0);
+                       if (ret) {
+                               vino_drvdata->decoder_owner = VINO_NO_CHANNEL;
+                               ret = -EINVAL;
                                goto out;
                        }
-                       vino_drvdata->decoder.owner = vcs->channel;
-               }
 
-               if (vino_drvdata->decoder.owner == vcs->channel) {
-                       int saa7191_input;
-                       int saa7191_norm;
+                       spin_unlock_irqrestore(&vino_drvdata->input_lock, flags);
 
-                       vcs->input = input;
-                       vcs->data_norm = VINO_DATA_NORM_PAL;
+                       /* Don't hold spinlocks while auto-detecting norm
+                        * as it may take a while... */
 
-                       saa7191_input = vino_get_saa7191_input(vcs->input);
-                       i2c_decoder_command(DECODER_SET_INPUT, &saa7191_input);
-                       saa7191_norm = vino_get_saa7191_norm(vcs->data_norm);
-                       i2c_decoder_command(DECODER_SAA7191_SET_NORM,
-                                           &saa7191_norm);
+                       ret = decoder_call(video, querystd, &norm);
+                       if (!ret) {
+                               for (data_norm = 0; data_norm < 3; data_norm++) {
+                                       if (vino_data_norms[data_norm].std & norm)
+                                               break;
+                               }
+                               if (data_norm == 3)
+                                       data_norm = VINO_DATA_NORM_PAL;
+                               ret = decoder_call(core, s_std, norm);
+                       }
+
+                       spin_lock_irqsave(&vino_drvdata->input_lock, flags);
+
+                       if (ret) {
+                               vino_drvdata->decoder_owner = VINO_NO_CHANNEL;
+                               ret = -EINVAL;
+                               goto out;
+                       }
+
+                       vcs->input = input;
+                       vcs->data_norm = data_norm;
                } else {
-                       if (vcs2->input != input) {
+                       if (input != vcs2->input) {
                                ret = -EBUSY;
                                goto out;
                        }
@@ -2425,40 +2699,31 @@ static int vino_set_input(struct vino_channel_settings *vcs, int input)
                        vcs->data_norm = vcs2->data_norm;
                }
 
-               if (vino_drvdata->camera.owner == vcs->channel) {
+               if (vino_drvdata->camera_owner == vcs->channel) {
                        /* Transfer the ownership or release the input */
                        if (vcs2->input == VINO_INPUT_D1) {
-                               vino_drvdata->camera.owner = vcs2->channel;
+                               vino_drvdata->camera_owner = vcs2->channel;
                        } else {
-                               i2c_release_client(vino_drvdata->
-                                                  camera.driver);
-                               vino_drvdata->camera.owner = VINO_NO_CHANNEL;
+                               vino_drvdata->camera_owner = VINO_NO_CHANNEL;
                        }
                }
                break;
        case VINO_INPUT_D1:
-               if (!vino_drvdata->camera.driver) {
+               if (!vino_drvdata->camera) {
                        ret = -EINVAL;
                        goto out;
                }
 
-               if (vino_drvdata->camera.owner == VINO_NO_CHANNEL) {
-                       if (i2c_use_client(vino_drvdata->camera.driver)) {
-                               ret = -ENODEV;
-                               goto out;
-                       }
-                       vino_drvdata->camera.owner = vcs->channel;
-               }
+               if (vino_drvdata->camera_owner == VINO_NO_CHANNEL)
+                       vino_drvdata->camera_owner = vcs->channel;
 
-               if (vino_drvdata->decoder.owner == vcs->channel) {
+               if (vino_drvdata->decoder_owner == vcs->channel) {
                        /* Transfer the ownership or release the input */
                        if ((vcs2->input == VINO_INPUT_COMPOSITE) ||
                                 (vcs2->input == VINO_INPUT_SVIDEO)) {
-                               vino_drvdata->decoder.owner = vcs2->channel;
+                               vino_drvdata->decoder_owner = vcs2->channel;
                        } else {
-                               i2c_release_client(vino_drvdata->
-                                                  decoder.driver);
-                               vino_drvdata->decoder.owner = VINO_NO_CHANNEL;
+                               vino_drvdata->decoder_owner = VINO_NO_CHANNEL;
                        }
                }
 
@@ -2471,12 +2736,13 @@ static int vino_set_input(struct vino_channel_settings *vcs, int input)
        }
 
        vino_set_default_clipping(vcs);
+       vino_set_default_scaling(vcs);
        vino_set_default_framerate(vcs);
 
        dprintk("vino_set_input(): %s\n", vino_inputs[vcs->input].name);
 
 out:
-       spin_unlock(&vino_drvdata->input_lock);
+       spin_unlock_irqrestore(&vino_drvdata->input_lock, flags);
 
        return ret;
 }
@@ -2485,40 +2751,43 @@ static void vino_release_input(struct vino_channel_settings *vcs)
 {
        struct vino_channel_settings *vcs2 = (vcs->channel == VINO_CHANNEL_A) ?
                &vino_drvdata->b : &vino_drvdata->a;
+       unsigned long flags;
 
        dprintk("vino_release_input():\n");
 
-       spin_lock(&vino_drvdata->input_lock);
+       spin_lock_irqsave(&vino_drvdata->input_lock, flags);
 
        /* Release ownership of the channel
         * and if the other channel takes input from
         * the same source, transfer the ownership */
-       if (vino_drvdata->camera.owner == vcs->channel) {
+       if (vino_drvdata->camera_owner == vcs->channel) {
                if (vcs2->input == VINO_INPUT_D1) {
-                       vino_drvdata->camera.owner = vcs2->channel;
+                       vino_drvdata->camera_owner = vcs2->channel;
                } else {
-                       i2c_release_client(vino_drvdata->camera.driver);
-                       vino_drvdata->camera.owner = VINO_NO_CHANNEL;
+                       vino_drvdata->camera_owner = VINO_NO_CHANNEL;
                }
-       } else if (vino_drvdata->decoder.owner == vcs->channel) {
+       } else if (vino_drvdata->decoder_owner == vcs->channel) {
                if ((vcs2->input == VINO_INPUT_COMPOSITE) ||
                         (vcs2->input == VINO_INPUT_SVIDEO)) {
-                       vino_drvdata->decoder.owner = vcs2->channel;
+                       vino_drvdata->decoder_owner = vcs2->channel;
                } else {
-                       i2c_release_client(vino_drvdata->decoder.driver);
-                       vino_drvdata->decoder.owner = VINO_NO_CHANNEL;
+                       vino_drvdata->decoder_owner = VINO_NO_CHANNEL;
                }
        }
        vcs->input = VINO_INPUT_NONE;
 
-       spin_unlock(&vino_drvdata->input_lock);
+       spin_unlock_irqrestore(&vino_drvdata->input_lock, flags);
 }
 
 /* execute with input_lock locked */
 static int vino_set_data_norm(struct vino_channel_settings *vcs,
-                             unsigned int data_norm)
+                             unsigned int data_norm,
+                             unsigned long *flags)
 {
-       int saa7191_norm;
+       int err = 0;
+
+       if (data_norm == vcs->data_norm)
+               return 0;
 
        switch (vcs->input) {
        case VINO_INPUT_D1:
@@ -2527,18 +2796,40 @@ static int vino_set_data_norm(struct vino_channel_settings *vcs,
                        return -EINVAL;
                break;
        case VINO_INPUT_COMPOSITE:
-       case VINO_INPUT_SVIDEO:
+       case VINO_INPUT_SVIDEO: {
+               v4l2_std_id norm;
+
+               if ((data_norm != VINO_DATA_NORM_PAL)
+                   && (data_norm != VINO_DATA_NORM_NTSC)
+                   && (data_norm != VINO_DATA_NORM_SECAM))
+                       return -EINVAL;
+
+               spin_unlock_irqrestore(&vino_drvdata->input_lock, *flags);
+
+               /* Don't hold spinlocks while setting norm
+                * as it may take a while... */
+
+               norm = vino_data_norms[data_norm].std;
+               err = decoder_call(core, s_std, norm);
+
+               spin_lock_irqsave(&vino_drvdata->input_lock, *flags);
 
-               saa7191_norm = vino_get_saa7191_norm(data_norm);
+               if (err)
+                       goto out;
 
-               i2c_decoder_command(DECODER_SAA7191_SET_NORM, &saa7191_norm);
                vcs->data_norm = data_norm;
+
+               vino_set_default_clipping(vcs);
+               vino_set_default_scaling(vcs);
+               vino_set_default_framerate(vcs);
                break;
+       }
        default:
                return -EINVAL;
        }
 
-       return 0;
+out:
+       return err;
 }
 
 /* V4L2 helper functions */
@@ -2555,39 +2846,13 @@ static int vino_find_data_format(__u32 pixelformat)
        return VINO_DATA_FMT_NONE;
 }
 
-static int vino_enum_data_norm(struct vino_channel_settings *vcs, __u32 index)
-{
-       int data_norm = VINO_DATA_NORM_NONE;
-
-       spin_lock(&vino_drvdata->input_lock);
-       switch(vcs->input) {
-       case VINO_INPUT_COMPOSITE:
-       case VINO_INPUT_SVIDEO:
-               if (index == 0) {
-                       data_norm = VINO_DATA_NORM_PAL;
-               } else if (index == 1) {
-                       data_norm = VINO_DATA_NORM_NTSC;
-               } else if (index == 2) {
-                       data_norm = VINO_DATA_NORM_SECAM;
-               }
-               break;
-       case VINO_INPUT_D1:
-               if (index == 0) {
-                       data_norm = VINO_DATA_NORM_D1;
-               }
-               break;
-       }
-       spin_unlock(&vino_drvdata->input_lock);
-
-       return data_norm;
-}
-
-static int vino_enum_input(struct vino_channel_settings *vcs, __u32 index)
+static int vino_int_enum_input(struct vino_channel_settings *vcs, __u32 index)
 {
        int input = VINO_INPUT_NONE;
+       unsigned long flags;
 
-       spin_lock(&vino_drvdata->input_lock);
-       if (vino_drvdata->decoder.driver && vino_drvdata->camera.driver) {
+       spin_lock_irqsave(&vino_drvdata->input_lock, flags);
+       if (vino_drvdata->decoder && vino_drvdata->camera) {
                switch (index) {
                case 0:
                        input = VINO_INPUT_COMPOSITE;
@@ -2599,7 +2864,7 @@ static int vino_enum_input(struct vino_channel_settings *vcs, __u32 index)
                        input = VINO_INPUT_D1;
                        break;
                }
-       } else if (vino_drvdata->decoder.driver) {
+       } else if (vino_drvdata->decoder) {
                switch (index) {
                case 0:
                        input = VINO_INPUT_COMPOSITE;
@@ -2608,14 +2873,14 @@ static int vino_enum_input(struct vino_channel_settings *vcs, __u32 index)
                        input = VINO_INPUT_SVIDEO;
                        break;
                }
-       } else if (vino_drvdata->camera.driver) {
+       } else if (vino_drvdata->camera) {
                switch (index) {
                case 0:
                        input = VINO_INPUT_D1;
                        break;
                }
        }
-       spin_unlock(&vino_drvdata->input_lock);
+       spin_unlock_irqrestore(&vino_drvdata->input_lock, flags);
 
        return input;
 }
@@ -2626,7 +2891,7 @@ static __u32 vino_find_input_index(struct vino_channel_settings *vcs)
        __u32 index = 0;
        // FIXME: detect when no inputs available
 
-       if (vino_drvdata->decoder.driver && vino_drvdata->camera.driver) {
+       if (vino_drvdata->decoder && vino_drvdata->camera) {
                switch (vcs->input) {
                case VINO_INPUT_COMPOSITE:
                        index = 0;
@@ -2638,7 +2903,7 @@ static __u32 vino_find_input_index(struct vino_channel_settings *vcs)
                        index = 2;
                        break;
                }
-       } else if (vino_drvdata->decoder.driver) {
+       } else if (vino_drvdata->decoder) {
                switch (vcs->input) {
                case VINO_INPUT_COMPOSITE:
                        index = 0;
@@ -2647,7 +2912,7 @@ static __u32 vino_find_input_index(struct vino_channel_settings *vcs)
                        index = 1;
                        break;
                }
-       } else if (vino_drvdata->camera.driver) {
+       } else if (vino_drvdata->camera) {
                switch (vcs->input) {
                case VINO_INPUT_D1:
                        index = 0;
@@ -2660,7 +2925,8 @@ static __u32 vino_find_input_index(struct vino_channel_settings *vcs)
 
 /* V4L2 ioctls */
 
-static void vino_v4l2_querycap(struct v4l2_capability *cap)
+static int vino_querycap(struct file *file, void *__fh,
+               struct v4l2_capability *cap)
 {
        memset(cap, 0, sizeof(struct v4l2_capability));
 
@@ -2672,16 +2938,18 @@ static void vino_v4l2_querycap(struct v4l2_capability *cap)
                V4L2_CAP_VIDEO_CAPTURE |
                V4L2_CAP_STREAMING;
        // V4L2_CAP_OVERLAY, V4L2_CAP_READWRITE
+       return 0;
 }
 
-static int vino_v4l2_enuminput(struct vino_channel_settings *vcs,
+static int vino_enum_input(struct file *file, void *__fh,
                               struct v4l2_input *i)
 {
+       struct vino_channel_settings *vcs = video_drvdata(file);
        __u32 index = i->index;
        int input;
        dprintk("requested index = %d\n", index);
 
-       input = vino_enum_input(vcs, index);
+       input = vino_int_enum_input(vcs, index);
        if (input == VINO_INPUT_NONE)
                return -EINVAL;
 
@@ -2692,27 +2960,23 @@ static int vino_v4l2_enuminput(struct vino_channel_settings *vcs,
        i->std = vino_inputs[input].std;
        strcpy(i->name, vino_inputs[input].name);
 
-       if ((input == VINO_INPUT_COMPOSITE)
-           || (input == VINO_INPUT_SVIDEO)) {
-               struct saa7191_status status;
-               i2c_decoder_command(DECODER_SAA7191_GET_STATUS, &status);
-               i->status |= status.signal ? 0 : V4L2_IN_ST_NO_SIGNAL;
-               i->status |= status.color ? 0 : V4L2_IN_ST_NO_COLOR;
-       }
-
+       if (input == VINO_INPUT_COMPOSITE || input == VINO_INPUT_SVIDEO)
+               decoder_call(video, g_input_status, &i->status);
        return 0;
 }
 
-static int vino_v4l2_g_input(struct vino_channel_settings *vcs,
-                            struct v4l2_input *i)
+static int vino_g_input(struct file *file, void *__fh,
+                            unsigned int *i)
 {
+       struct vino_channel_settings *vcs = video_drvdata(file);
        __u32 index;
        int input;
+       unsigned long flags;
 
-       spin_lock(&vino_drvdata->input_lock);
+       spin_lock_irqsave(&vino_drvdata->input_lock, flags);
        input = vcs->input;
        index = vino_find_input_index(vcs);
-       spin_unlock(&vino_drvdata->input_lock);
+       spin_unlock_irqrestore(&vino_drvdata->input_lock, flags);
 
        dprintk("input = %d\n", input);
 
@@ -2720,78 +2984,84 @@ static int vino_v4l2_g_input(struct vino_channel_settings *vcs,
                return -EINVAL;
        }
 
-       memset(i, 0, sizeof(struct v4l2_input));
-
-       i->index = index;
-       i->type = V4L2_INPUT_TYPE_CAMERA;
-       i->std = vino_inputs[input].std;
-       strcpy(i->name, vino_inputs[input].name);
+       *i = index;
 
        return 0;
 }
 
-static int vino_v4l2_s_input(struct vino_channel_settings *vcs,
-                            struct v4l2_input *i)
+static int vino_s_input(struct file *file, void *__fh,
+                            unsigned int i)
 {
+       struct vino_channel_settings *vcs = video_drvdata(file);
        int input;
-       dprintk("requested input = %d\n", i->index);
+       dprintk("requested input = %d\n", i);
 
-       input = vino_enum_input(vcs, i->index);
+       input = vino_int_enum_input(vcs, i);
        if (input == VINO_INPUT_NONE)
                return -EINVAL;
 
        return vino_set_input(vcs, input);
 }
 
-static int vino_v4l2_enumstd(struct vino_channel_settings *vcs,
-                            struct v4l2_standard *s)
+static int vino_querystd(struct file *file, void *__fh,
+                             v4l2_std_id *std)
 {
-       int index = s->index;
-       int data_norm = vino_enum_data_norm(vcs, index);
-       dprintk("standard index = %d\n", index);
-
-       if (data_norm == VINO_DATA_NORM_NONE)
-               return -EINVAL;
+       struct vino_channel_settings *vcs = video_drvdata(file);
+       unsigned long flags;
+       int err = 0;
 
-       dprintk("standard name = %s\n",
-              vino_data_norms[data_norm].description);
+       spin_lock_irqsave(&vino_drvdata->input_lock, flags);
 
-       memset(s, 0, sizeof(struct v4l2_standard));
-       s->index = index;
+       switch (vcs->input) {
+       case VINO_INPUT_D1:
+               *std = vino_inputs[vcs->input].std;
+               break;
+       case VINO_INPUT_COMPOSITE:
+       case VINO_INPUT_SVIDEO: {
+               decoder_call(video, querystd, std);
+               break;
+       }
+       default:
+               err = -EINVAL;
+       }
 
-       s->id = vino_data_norms[data_norm].std;
-       s->frameperiod.numerator = 1;
-       s->frameperiod.denominator =
-               vino_data_norms[data_norm].fps_max;
-       s->framelines =
-               vino_data_norms[data_norm].framelines;
-       strcpy(s->name,
-              vino_data_norms[data_norm].description);
+       spin_unlock_irqrestore(&vino_drvdata->input_lock, flags);
 
-       return 0;
+       return err;
 }
 
-static int vino_v4l2_g_std(struct vino_channel_settings *vcs,
+static int vino_g_std(struct file *file, void *__fh,
                           v4l2_std_id *std)
 {
-       spin_lock(&vino_drvdata->input_lock);
-       dprintk("current standard = %d\n", vcs->data_norm);
+       struct vino_channel_settings *vcs = video_drvdata(file);
+       unsigned long flags;
+
+       spin_lock_irqsave(&vino_drvdata->input_lock, flags);
+
        *std = vino_data_norms[vcs->data_norm].std;
-       spin_unlock(&vino_drvdata->input_lock);
+       dprintk("current standard = %d\n", vcs->data_norm);
+
+       spin_unlock_irqrestore(&vino_drvdata->input_lock, flags);
 
        return 0;
 }
 
-static int vino_v4l2_s_std(struct vino_channel_settings *vcs,
+static int vino_s_std(struct file *file, void *__fh,
                           v4l2_std_id *std)
 {
+       struct vino_channel_settings *vcs = video_drvdata(file);
+       unsigned long flags;
        int ret = 0;
 
-       spin_lock(&vino_drvdata->input_lock);
+       spin_lock_irqsave(&vino_drvdata->input_lock, flags);
+
+       if (!vino_is_input_owner(vcs)) {
+               ret = -EBUSY;
+               goto out;
+       }
 
        /* check if the standard is valid for the current input */
-       if (vino_is_input_owner(vcs)
-           && (vino_inputs[vcs->input].std & (*std))) {
+       if ((*std) & vino_inputs[vcs->input].std) {
                dprintk("standard accepted\n");
 
                /* change the video norm for SAA7191
@@ -2801,211 +3071,179 @@ static int vino_v4l2_s_std(struct vino_channel_settings *vcs,
                        goto out;
 
                if ((*std) & V4L2_STD_PAL) {
-                       vino_set_data_norm(vcs, VINO_DATA_NORM_PAL);
-                       vcs->data_norm = VINO_DATA_NORM_PAL;
+                       ret = vino_set_data_norm(vcs, VINO_DATA_NORM_PAL,
+                                                &flags);
                } else if ((*std) & V4L2_STD_NTSC) {
-                       vino_set_data_norm(vcs, VINO_DATA_NORM_NTSC);
-                       vcs->data_norm = VINO_DATA_NORM_NTSC;
+                       ret = vino_set_data_norm(vcs, VINO_DATA_NORM_NTSC,
+                                                &flags);
                } else if ((*std) & V4L2_STD_SECAM) {
-                       vino_set_data_norm(vcs, VINO_DATA_NORM_SECAM);
-                       vcs->data_norm = VINO_DATA_NORM_SECAM;
+                       ret = vino_set_data_norm(vcs, VINO_DATA_NORM_SECAM,
+                                                &flags);
                } else {
                        ret = -EINVAL;
                }
+
+               if (ret) {
+                       ret = -EINVAL;
+               }
        } else {
                ret = -EINVAL;
        }
 
 out:
-       spin_unlock(&vino_drvdata->input_lock);
+       spin_unlock_irqrestore(&vino_drvdata->input_lock, flags);
 
        return ret;
 }
 
-static int vino_v4l2_enum_fmt(struct vino_channel_settings *vcs,
+static int vino_enum_fmt_vid_cap(struct file *file, void *__fh,
                              struct v4l2_fmtdesc *fd)
 {
-       enum v4l2_buf_type type = fd->type;
-       int index = fd->index;
-       dprintk("format index = %d\n", index);
+       dprintk("format index = %d\n", fd->index);
 
-       switch (fd->type) {
-       case V4L2_BUF_TYPE_VIDEO_CAPTURE:
-               if ((fd->index < 0) ||
-                   (fd->index >= VINO_DATA_FMT_COUNT))
-                       return -EINVAL;
-               dprintk("format name = %s\n",
-                      vino_data_formats[index].description);
-
-               memset(fd, 0, sizeof(struct v4l2_fmtdesc));
-               fd->index = index;
-               fd->type = type;
-               fd->pixelformat = vino_data_formats[index].pixelformat;
-               strcpy(fd->description, vino_data_formats[index].description);
-               break;
-       case V4L2_BUF_TYPE_VIDEO_OVERLAY:
-       default:
+       if (fd->index >= VINO_DATA_FMT_COUNT)
                return -EINVAL;
-       }
+       dprintk("format name = %s\n", vino_data_formats[fd->index].description);
 
+       fd->pixelformat = vino_data_formats[fd->index].pixelformat;
+       strcpy(fd->description, vino_data_formats[fd->index].description);
        return 0;
 }
 
-static int vino_v4l2_try_fmt(struct vino_channel_settings *vcs,
+static int vino_try_fmt_vid_cap(struct file *file, void *__fh,
                             struct v4l2_format *f)
 {
+       struct vino_channel_settings *vcs = video_drvdata(file);
        struct vino_channel_settings tempvcs;
+       unsigned long flags;
+       struct v4l2_pix_format *pf = &f->fmt.pix;
 
-       switch (f->type) {
-       case V4L2_BUF_TYPE_VIDEO_CAPTURE: {
-               struct v4l2_pix_format *pf = &f->fmt.pix;
-
-               dprintk("requested: w = %d, h = %d\n",
-                      pf->width, pf->height);
+       dprintk("requested: w = %d, h = %d\n",
+                       pf->width, pf->height);
 
-               spin_lock(&vino_drvdata->input_lock);
-               memcpy(&tempvcs, vcs, sizeof(struct vino_channel_settings));
-               spin_unlock(&vino_drvdata->input_lock);
+       spin_lock_irqsave(&vino_drvdata->input_lock, flags);
+       memcpy(&tempvcs, vcs, sizeof(struct vino_channel_settings));
+       spin_unlock_irqrestore(&vino_drvdata->input_lock, flags);
 
-               tempvcs.data_format = vino_find_data_format(pf->pixelformat);
-               if (tempvcs.data_format == VINO_DATA_FMT_NONE) {
-                       tempvcs.data_format = VINO_DATA_FMT_RGB32;
-                       pf->pixelformat =
-                               vino_data_formats[tempvcs.data_format].
-                               pixelformat;
-               }
-
-               /* data format must be set before clipping/scaling */
-               vino_set_scaling(&tempvcs, pf->width, pf->height);
+       tempvcs.data_format = vino_find_data_format(pf->pixelformat);
+       if (tempvcs.data_format == VINO_DATA_FMT_NONE) {
+               tempvcs.data_format = VINO_DATA_FMT_GREY;
+               pf->pixelformat =
+                       vino_data_formats[tempvcs.data_format].
+                       pixelformat;
+       }
 
-               dprintk("data format = %s\n",
-                      vino_data_formats[tempvcs.data_format].description);
+       /* data format must be set before clipping/scaling */
+       vino_set_scaling(&tempvcs, pf->width, pf->height);
 
-               pf->width = (tempvcs.clipping.right - tempvcs.clipping.left) /
-                       tempvcs.decimation;
-               pf->height = (tempvcs.clipping.bottom - tempvcs.clipping.top) /
-                       tempvcs.decimation;
+       dprintk("data format = %s\n",
+                       vino_data_formats[tempvcs.data_format].description);
 
-               pf->field = V4L2_FIELD_INTERLACED;
-               pf->bytesperline = tempvcs.line_size;
-               pf->sizeimage = tempvcs.line_size *
-                       (tempvcs.clipping.bottom - tempvcs.clipping.top) /
-                       tempvcs.decimation;
-               pf->colorspace =
-                       vino_data_formats[tempvcs.data_format].colorspace;
+       pf->width = (tempvcs.clipping.right - tempvcs.clipping.left) /
+               tempvcs.decimation;
+       pf->height = (tempvcs.clipping.bottom - tempvcs.clipping.top) /
+               tempvcs.decimation;
 
-               pf->priv = 0;
-               break;
-       }
-       case V4L2_BUF_TYPE_VIDEO_OVERLAY:
-       default:
-               return -EINVAL;
-       }
+       pf->field = V4L2_FIELD_INTERLACED;
+       pf->bytesperline = tempvcs.line_size;
+       pf->sizeimage = tempvcs.line_size *
+               (tempvcs.clipping.bottom - tempvcs.clipping.top) /
+               tempvcs.decimation;
+       pf->colorspace =
+               vino_data_formats[tempvcs.data_format].colorspace;
 
+       pf->priv = 0;
        return 0;
 }
 
-static int vino_v4l2_g_fmt(struct vino_channel_settings *vcs,
+static int vino_g_fmt_vid_cap(struct file *file, void *__fh,
                           struct v4l2_format *f)
 {
-       switch (f->type) {
-       case V4L2_BUF_TYPE_VIDEO_CAPTURE: {
-               struct v4l2_pix_format *pf = &f->fmt.pix;
-               spin_lock(&vino_drvdata->input_lock);
-
-               pf->width = (vcs->clipping.right - vcs->clipping.left) /
-                       vcs->decimation;
-               pf->height = (vcs->clipping.bottom - vcs->clipping.top) /
-                       vcs->decimation;
-               pf->pixelformat =
-                       vino_data_formats[vcs->data_format].pixelformat;
+       struct vino_channel_settings *vcs = video_drvdata(file);
+       unsigned long flags;
+       struct v4l2_pix_format *pf = &f->fmt.pix;
 
-               pf->field = V4L2_FIELD_INTERLACED;
-               pf->bytesperline = vcs->line_size;
-               pf->sizeimage = vcs->line_size *
-                       (vcs->clipping.bottom - vcs->clipping.top) /
-                       vcs->decimation;
-               pf->colorspace =
-                       vino_data_formats[vcs->data_format].colorspace;
+       spin_lock_irqsave(&vino_drvdata->input_lock, flags);
 
-               pf->priv = 0;
+       pf->width = (vcs->clipping.right - vcs->clipping.left) /
+               vcs->decimation;
+       pf->height = (vcs->clipping.bottom - vcs->clipping.top) /
+               vcs->decimation;
+       pf->pixelformat =
+               vino_data_formats[vcs->data_format].pixelformat;
 
-               spin_unlock(&vino_drvdata->input_lock);
-               break;
-       }
-       case V4L2_BUF_TYPE_VIDEO_OVERLAY:
-       default:
-               return -EINVAL;
-       }
+       pf->field = V4L2_FIELD_INTERLACED;
+       pf->bytesperline = vcs->line_size;
+       pf->sizeimage = vcs->line_size *
+               (vcs->clipping.bottom - vcs->clipping.top) /
+               vcs->decimation;
+       pf->colorspace =
+               vino_data_formats[vcs->data_format].colorspace;
+
+       pf->priv = 0;
 
+       spin_unlock_irqrestore(&vino_drvdata->input_lock, flags);
        return 0;
 }
 
-static int vino_v4l2_s_fmt(struct vino_channel_settings *vcs,
+static int vino_s_fmt_vid_cap(struct file *file, void *__fh,
                           struct v4l2_format *f)
 {
+       struct vino_channel_settings *vcs = video_drvdata(file);
        int data_format;
+       unsigned long flags;
+       struct v4l2_pix_format *pf = &f->fmt.pix;
 
-       switch (f->type) {
-       case V4L2_BUF_TYPE_VIDEO_CAPTURE: {
-               struct v4l2_pix_format *pf = &f->fmt.pix;
-               spin_lock(&vino_drvdata->input_lock);
+       spin_lock_irqsave(&vino_drvdata->input_lock, flags);
 
-               if (!vino_is_input_owner(vcs)) {
-                       spin_unlock(&vino_drvdata->input_lock);
-                       return -EINVAL;
-               }
+       data_format = vino_find_data_format(pf->pixelformat);
 
-               data_format = vino_find_data_format(pf->pixelformat);
-               if (data_format == VINO_DATA_FMT_NONE) {
-                       vcs->data_format = VINO_DATA_FMT_RGB32;
-                       pf->pixelformat =
-                               vino_data_formats[vcs->data_format].
-                               pixelformat;
-               } else {
-                       vcs->data_format = data_format;
-               }
+       if (data_format == VINO_DATA_FMT_NONE) {
+               vcs->data_format = VINO_DATA_FMT_GREY;
+               pf->pixelformat =
+                       vino_data_formats[vcs->data_format].
+                       pixelformat;
+       } else {
+               vcs->data_format = data_format;
+       }
 
-               /* data format must be set before clipping/scaling */
-               vino_set_scaling(vcs, pf->width, pf->height);
+       /* data format must be set before clipping/scaling */
+       vino_set_scaling(vcs, pf->width, pf->height);
 
-               dprintk("data format = %s\n",
-                      vino_data_formats[vcs->data_format].description);
+       dprintk("data format = %s\n",
+              vino_data_formats[vcs->data_format].description);
 
-               pf->width = vcs->clipping.right - vcs->clipping.left;
-               pf->height = vcs->clipping.bottom - vcs->clipping.top;
+       pf->width = vcs->clipping.right - vcs->clipping.left;
+       pf->height = vcs->clipping.bottom - vcs->clipping.top;
 
-               pf->field = V4L2_FIELD_INTERLACED;
-               pf->bytesperline = vcs->line_size;
-               pf->sizeimage = vcs->line_size *
-                       (vcs->clipping.bottom - vcs->clipping.top) /
-                       vcs->decimation;
-               pf->colorspace =
-                       vino_data_formats[vcs->data_format].colorspace;
+       pf->field = V4L2_FIELD_INTERLACED;
+       pf->bytesperline = vcs->line_size;
+       pf->sizeimage = vcs->line_size *
+               (vcs->clipping.bottom - vcs->clipping.top) /
+               vcs->decimation;
+       pf->colorspace =
+               vino_data_formats[vcs->data_format].colorspace;
 
-               pf->priv = 0;
-
-               spin_unlock(&vino_drvdata->input_lock);
-               break;
-       }
-       case V4L2_BUF_TYPE_VIDEO_OVERLAY:
-       default:
-               return -EINVAL;
-       }
+       pf->priv = 0;
 
+       spin_unlock_irqrestore(&vino_drvdata->input_lock, flags);
        return 0;
 }
 
-static int vino_v4l2_cropcap(struct vino_channel_settings *vcs,
+static int vino_cropcap(struct file *file, void *__fh,
                             struct v4l2_cropcap *ccap)
 {
+       struct vino_channel_settings *vcs = video_drvdata(file);
        const struct vino_data_norm *norm;
+       unsigned long flags;
 
        switch (ccap->type) {
        case V4L2_BUF_TYPE_VIDEO_CAPTURE:
-               spin_lock(&vino_drvdata->input_lock);
+               spin_lock_irqsave(&vino_drvdata->input_lock, flags);
+
                norm = &vino_data_norms[vcs->data_norm];
-               spin_unlock(&vino_drvdata->input_lock);
+
+               spin_unlock_irqrestore(&vino_drvdata->input_lock, flags);
 
                ccap->bounds.left = 0;
                ccap->bounds.top = 0;
@@ -3025,19 +3263,22 @@ static int vino_v4l2_cropcap(struct vino_channel_settings *vcs,
        return 0;
 }
 
-static int vino_v4l2_g_crop(struct vino_channel_settings *vcs,
+static int vino_g_crop(struct file *file, void *__fh,
                            struct v4l2_crop *c)
 {
+       struct vino_channel_settings *vcs = video_drvdata(file);
+       unsigned long flags;
+
        switch (c->type) {
        case V4L2_BUF_TYPE_VIDEO_CAPTURE:
-               spin_lock(&vino_drvdata->input_lock);
+               spin_lock_irqsave(&vino_drvdata->input_lock, flags);
 
                c->c.left = vcs->clipping.left;
                c->c.top = vcs->clipping.top;
                c->c.width = vcs->clipping.right - vcs->clipping.left;
                c->c.height = vcs->clipping.bottom - vcs->clipping.top;
 
-               spin_unlock(&vino_drvdata->input_lock);
+               spin_unlock_irqrestore(&vino_drvdata->input_lock, flags);
                break;
        case V4L2_BUF_TYPE_VIDEO_OVERLAY:
        default:
@@ -3047,21 +3288,20 @@ static int vino_v4l2_g_crop(struct vino_channel_settings *vcs,
        return 0;
 }
 
-static int vino_v4l2_s_crop(struct vino_channel_settings *vcs,
+static int vino_s_crop(struct file *file, void *__fh,
                            struct v4l2_crop *c)
 {
+       struct vino_channel_settings *vcs = video_drvdata(file);
+       unsigned long flags;
+
        switch (c->type) {
        case V4L2_BUF_TYPE_VIDEO_CAPTURE:
-               spin_lock(&vino_drvdata->input_lock);
+               spin_lock_irqsave(&vino_drvdata->input_lock, flags);
 
-               if (!vino_is_input_owner(vcs)) {
-                       spin_unlock(&vino_drvdata->input_lock);
-                       return -EINVAL;
-               }
                vino_set_clipping(vcs, c->c.left, c->c.top,
                                  c->c.width, c->c.height);
 
-               spin_unlock(&vino_drvdata->input_lock);
+               spin_unlock_irqrestore(&vino_drvdata->input_lock, flags);
                break;
        case V4L2_BUF_TYPE_VIDEO_OVERLAY:
        default:
@@ -3071,103 +3311,83 @@ static int vino_v4l2_s_crop(struct vino_channel_settings *vcs,
        return 0;
 }
 
-static int vino_v4l2_g_parm(struct vino_channel_settings *vcs,
+static int vino_g_parm(struct file *file, void *__fh,
                            struct v4l2_streamparm *sp)
 {
-       switch (sp->type) {
-       case V4L2_BUF_TYPE_VIDEO_CAPTURE: {
-               struct v4l2_captureparm *cp = &sp->parm.capture;
-               memset(cp, 0, sizeof(struct v4l2_captureparm));
+       struct vino_channel_settings *vcs = video_drvdata(file);
+       unsigned long flags;
+       struct v4l2_captureparm *cp = &sp->parm.capture;
 
-               cp->capability = V4L2_CAP_TIMEPERFRAME;
-               cp->timeperframe.numerator = 1;
+       cp->capability = V4L2_CAP_TIMEPERFRAME;
+       cp->timeperframe.numerator = 1;
 
-               spin_lock(&vino_drvdata->input_lock);
-               cp->timeperframe.denominator = vcs->fps;
-               spin_unlock(&vino_drvdata->input_lock);
+       spin_lock_irqsave(&vino_drvdata->input_lock, flags);
 
-               // TODO: cp->readbuffers = xxx;
-               break;
-       }
-       case V4L2_BUF_TYPE_VIDEO_OVERLAY:
-       default:
-               return -EINVAL;
-       }
+       cp->timeperframe.denominator = vcs->fps;
+
+       spin_unlock_irqrestore(&vino_drvdata->input_lock, flags);
+
+       /* TODO: cp->readbuffers = xxx; */
 
        return 0;
 }
 
-static int vino_v4l2_s_parm(struct vino_channel_settings *vcs,
+static int vino_s_parm(struct file *file, void *__fh,
                            struct v4l2_streamparm *sp)
 {
-       switch (sp->type) {
-       case V4L2_BUF_TYPE_VIDEO_CAPTURE: {
-               struct v4l2_captureparm *cp = &sp->parm.capture;
+       struct vino_channel_settings *vcs = video_drvdata(file);
+       unsigned long flags;
+       struct v4l2_captureparm *cp = &sp->parm.capture;
 
-               spin_lock(&vino_drvdata->input_lock);
-               if (!vino_is_input_owner(vcs)) {
-                       spin_unlock(&vino_drvdata->input_lock);
-                       return -EINVAL;
-               }
+       spin_lock_irqsave(&vino_drvdata->input_lock, flags);
 
-               if ((cp->timeperframe.numerator == 0) ||
-                   (cp->timeperframe.denominator == 0)) {
-                       /* reset framerate */
-                       vino_set_default_framerate(vcs);
-               } else {
-                       vino_set_framerate(vcs, cp->timeperframe.denominator /
-                                          cp->timeperframe.numerator);
-               }
-               spin_unlock(&vino_drvdata->input_lock);
-
-               // TODO: set buffers according to cp->readbuffers
-               break;
-       }
-       case V4L2_BUF_TYPE_VIDEO_OVERLAY:
-       default:
-               return -EINVAL;
+       if ((cp->timeperframe.numerator == 0) ||
+           (cp->timeperframe.denominator == 0)) {
+               /* reset framerate */
+               vino_set_default_framerate(vcs);
+       } else {
+               vino_set_framerate(vcs, cp->timeperframe.denominator /
+                                  cp->timeperframe.numerator);
        }
 
+       spin_unlock_irqrestore(&vino_drvdata->input_lock, flags);
+
        return 0;
 }
 
-static int vino_v4l2_reqbufs(struct vino_channel_settings *vcs,
+static int vino_reqbufs(struct file *file, void *__fh,
                             struct v4l2_requestbuffers *rb)
 {
+       struct vino_channel_settings *vcs = video_drvdata(file);
+
        if (vcs->reading)
                return -EBUSY;
 
-       switch (rb->type) {
-       case V4L2_BUF_TYPE_VIDEO_CAPTURE: {
-               // TODO: check queue type
-               if (rb->memory != V4L2_MEMORY_MMAP) {
-                       dprintk("type not mmap\n");
-                       return -EINVAL;
-               }
+       /* TODO: check queue type */
+       if (rb->memory != V4L2_MEMORY_MMAP) {
+               dprintk("type not mmap\n");
+               return -EINVAL;
+       }
 
+       dprintk("count = %d\n", rb->count);
+       if (rb->count > 0) {
                if (vino_is_capturing(vcs)) {
                        dprintk("busy, capturing\n");
                        return -EBUSY;
                }
 
-               dprintk("count = %d\n", rb->count);
-               if (rb->count > 0) {
-                       if (vino_queue_has_mapped_buffers(&vcs->fb_queue)) {
-                               dprintk("busy, buffers still mapped\n");
-                               return -EBUSY;
-                       } else {
-                               vino_queue_free(&vcs->fb_queue);
-                               vino_queue_init(&vcs->fb_queue, &rb->count);
-                       }
+               if (vino_queue_has_mapped_buffers(&vcs->fb_queue)) {
+                       dprintk("busy, buffers still mapped\n");
+                       return -EBUSY;
                } else {
-                       vino_capture_stop(vcs);
+                       vcs->streaming = 0;
                        vino_queue_free(&vcs->fb_queue);
+                       vino_queue_init(&vcs->fb_queue, &rb->count);
                }
-               break;
-       }
-       case V4L2_BUF_TYPE_VIDEO_OVERLAY:
-       default:
-               return -EINVAL;
+       } else {
+               vcs->streaming = 0;
+               vino_capture_stop(vcs);
+               vino_queue_free(&vcs->fb_queue);
        }
 
        return 0;
@@ -3211,152 +3431,135 @@ static void vino_v4l2_get_buffer_status(struct vino_channel_settings *vcs,
                fb->id, fb->size, fb->data_size, fb->offset);
 }
 
-static int vino_v4l2_querybuf(struct vino_channel_settings *vcs,
+static int vino_querybuf(struct file *file, void *__fh,
                              struct v4l2_buffer *b)
 {
+       struct vino_channel_settings *vcs = video_drvdata(file);
+       struct vino_framebuffer *fb;
+
        if (vcs->reading)
                return -EBUSY;
 
-       switch (b->type) {
-       case V4L2_BUF_TYPE_VIDEO_CAPTURE: {
-               struct vino_framebuffer *fb;
-
-               // TODO: check queue type
-               if (b->index >= vino_queue_get_length(&vcs->fb_queue)) {
-                       dprintk("invalid index = %d\n",
-                              b->index);
-                       return -EINVAL;
-               }
-
-               fb = vino_queue_get_buffer(&vcs->fb_queue,
-                                          b->index);
-               if (fb == NULL) {
-                       dprintk("vino_queue_get_buffer() failed");
-                       return -EINVAL;
-               }
-
-               vino_v4l2_get_buffer_status(vcs, fb, b);
-               break;
+       /* TODO: check queue type */
+       if (b->index >= vino_queue_get_length(&vcs->fb_queue)) {
+               dprintk("invalid index = %d\n",
+                      b->index);
+               return -EINVAL;
        }
-       case V4L2_BUF_TYPE_VIDEO_OVERLAY:
-       default:
+
+       fb = vino_queue_get_buffer(&vcs->fb_queue,
+                                  b->index);
+       if (fb == NULL) {
+               dprintk("vino_queue_get_buffer() failed");
                return -EINVAL;
        }
 
+       vino_v4l2_get_buffer_status(vcs, fb, b);
+
        return 0;
 }
 
-static int vino_v4l2_qbuf(struct vino_channel_settings *vcs,
+static int vino_qbuf(struct file *file, void *__fh,
                          struct v4l2_buffer *b)
 {
+       struct vino_channel_settings *vcs = video_drvdata(file);
+       struct vino_framebuffer *fb;
+       int ret;
+
        if (vcs->reading)
                return -EBUSY;
 
-       switch (b->type) {
-       case V4L2_BUF_TYPE_VIDEO_CAPTURE: {
-               struct vino_framebuffer *fb;
-               int ret;
-
-               // TODO: check queue type
-               if (b->memory != V4L2_MEMORY_MMAP) {
-                       dprintk("type not mmap\n");
-                       return -EINVAL;
-               }
+       /* TODO: check queue type */
+       if (b->memory != V4L2_MEMORY_MMAP) {
+               dprintk("type not mmap\n");
+               return -EINVAL;
+       }
 
-               fb = vino_capture_enqueue(vcs, b->index);
-               if (fb == NULL)
-                       return -EINVAL;
+       fb = vino_capture_enqueue(vcs, b->index);
+       if (fb == NULL)
+               return -EINVAL;
 
-               vino_v4l2_get_buffer_status(vcs, fb, b);
+       vino_v4l2_get_buffer_status(vcs, fb, b);
 
-               if (vcs->streaming) {
-                       ret = vino_capture_next(vcs, 1);
-                       if (ret)
-                               return ret;
-               }
-               break;
-       }
-       case V4L2_BUF_TYPE_VIDEO_OVERLAY:
-       default:
-               return -EINVAL;
+       if (vcs->streaming) {
+               ret = vino_capture_next(vcs, 1);
+               if (ret)
+                       return ret;
        }
 
        return 0;
 }
 
-static int vino_v4l2_dqbuf(struct vino_channel_settings *vcs,
-                          struct v4l2_buffer *b,
-                          unsigned int nonblocking)
+static int vino_dqbuf(struct file *file, void *__fh,
+                          struct v4l2_buffer *b)
 {
+       struct vino_channel_settings *vcs = video_drvdata(file);
+       unsigned int nonblocking = file->f_flags & O_NONBLOCK;
+       struct vino_framebuffer *fb;
+       unsigned int incoming, outgoing;
+       int err;
+
        if (vcs->reading)
                return -EBUSY;
 
-       switch (b->type) {
-       case V4L2_BUF_TYPE_VIDEO_CAPTURE: {
-               struct vino_framebuffer *fb;
-               unsigned int incoming, outgoing;
-               int err;
+       /* TODO: check queue type */
+
+       err = vino_queue_get_incoming(&vcs->fb_queue, &incoming);
+       if (err) {
+               dprintk("vino_queue_get_incoming() failed\n");
+               return -EINVAL;
+       }
+       err = vino_queue_get_outgoing(&vcs->fb_queue, &outgoing);
+       if (err) {
+               dprintk("vino_queue_get_outgoing() failed\n");
+               return -EINVAL;
+       }
 
-               // TODO: check queue type
+       dprintk("incoming = %d, outgoing = %d\n", incoming, outgoing);
 
-               err = vino_queue_get_incoming(&vcs->fb_queue, &incoming);
-               if (err) {
-                       dprintk("vino_queue_get_incoming() failed\n");
-                       return -EIO;
+       if (outgoing == 0) {
+               if (incoming == 0) {
+                       dprintk("no incoming or outgoing buffers\n");
+                       return -EINVAL;
                }
-               err = vino_queue_get_outgoing(&vcs->fb_queue, &outgoing);
-               if (err) {
-                       dprintk("vino_queue_get_outgoing() failed\n");
-                       return -EIO;
+               if (nonblocking) {
+                       dprintk("non-blocking I/O was selected and "
+                               "there are no buffers to dequeue\n");
+                       return -EAGAIN;
                }
 
-               dprintk("incoming = %d, outgoing = %d\n", incoming, outgoing);
-
-               if (outgoing == 0) {
-                       if (incoming == 0) {
-                               dprintk("no incoming or outgoing buffers\n");
-                               return -EINVAL;
-                       }
-                       if (nonblocking) {
-                               dprintk("non-blocking I/O was selected and "
-                                       "there are no buffers to dequeue\n");
-                               return -EAGAIN;
-                       }
-
+               err = vino_wait_for_frame(vcs);
+               if (err) {
                        err = vino_wait_for_frame(vcs);
                        if (err) {
-                               err = vino_wait_for_frame(vcs);
-                               if (err) {
-                                       /* interrupted */
-                                       vino_capture_failed(vcs);
-                                       return -EIO;
-                               }
+                               /* interrupted or no frames captured because of
+                                * frame skipping */
+                               /* vino_capture_failed(vcs); */
+                               return -EIO;
                        }
                }
-
-               fb = vino_queue_remove(&vcs->fb_queue, &b->index);
-               if (fb == NULL) {
-                       dprintk("vino_queue_remove() failed\n");
-                       return -EINVAL;
-               }
-
-               err = vino_check_buffer(vcs, fb);
-               if (err)
-                       return -EIO;
-
-               vino_v4l2_get_buffer_status(vcs, fb, b);
-               break;
        }
-       case V4L2_BUF_TYPE_VIDEO_OVERLAY:
-       default:
+
+       fb = vino_queue_remove(&vcs->fb_queue, &b->index);
+       if (fb == NULL) {
+               dprintk("vino_queue_remove() failed\n");
                return -EINVAL;
        }
 
+       err = vino_check_buffer(vcs, fb);
+
+       vino_v4l2_get_buffer_status(vcs, fb, b);
+
+       if (err)
+               return -EIO;
+
        return 0;
 }
 
-static int vino_v4l2_streamon(struct vino_channel_settings *vcs)
+static int vino_streamon(struct file *file, void *__fh,
+               enum v4l2_buf_type i)
 {
+       struct vino_channel_settings *vcs = video_drvdata(file);
        unsigned int incoming;
        int ret;
        if (vcs->reading)
@@ -3393,27 +3596,31 @@ static int vino_v4l2_streamon(struct vino_channel_settings *vcs)
        return 0;
 }
 
-static int vino_v4l2_streamoff(struct vino_channel_settings *vcs)
+static int vino_streamoff(struct file *file, void *__fh,
+               enum v4l2_buf_type i)
 {
+       struct vino_channel_settings *vcs = video_drvdata(file);
        if (vcs->reading)
                return -EBUSY;
 
        if (!vcs->streaming)
                return 0;
 
-       vino_capture_stop(vcs);
        vcs->streaming = 0;
+       vino_capture_stop(vcs);
 
        return 0;
 }
 
-static int vino_v4l2_queryctrl(struct vino_channel_settings *vcs,
+static int vino_queryctrl(struct file *file, void *__fh,
                               struct v4l2_queryctrl *queryctrl)
 {
+       struct vino_channel_settings *vcs = video_drvdata(file);
+       unsigned long flags;
        int i;
        int err = 0;
 
-       spin_lock(&vino_drvdata->input_lock);
+       spin_lock_irqsave(&vino_drvdata->input_lock, flags);
 
        switch (vcs->input) {
        case VINO_INPUT_D1:
@@ -3423,6 +3630,7 @@ static int vino_v4l2_queryctrl(struct vino_channel_settings *vcs,
                                memcpy(queryctrl,
                                       &vino_indycam_v4l2_controls[i],
                                       sizeof(struct v4l2_queryctrl));
+                               queryctrl->reserved[0] = 0;
                                goto found;
                        }
                }
@@ -3437,6 +3645,7 @@ static int vino_v4l2_queryctrl(struct vino_channel_settings *vcs,
                                memcpy(queryctrl,
                                       &vino_saa7191_v4l2_controls[i],
                                       sizeof(struct v4l2_queryctrl));
+                               queryctrl->reserved[0] = 0;
                                goto found;
                        }
                }
@@ -3448,219 +3657,145 @@ static int vino_v4l2_queryctrl(struct vino_channel_settings *vcs,
        }
 
  found:
-       spin_unlock(&vino_drvdata->input_lock);
+       spin_unlock_irqrestore(&vino_drvdata->input_lock, flags);
 
        return err;
 }
 
-static int vino_v4l2_g_ctrl(struct vino_channel_settings *vcs,
+static int vino_g_ctrl(struct file *file, void *__fh,
                            struct v4l2_control *control)
 {
-       struct indycam_control indycam_ctrl;
-       struct saa7191_control saa7191_ctrl;
+       struct vino_channel_settings *vcs = video_drvdata(file);
+       unsigned long flags;
+       int i;
        int err = 0;
 
-       spin_lock(&vino_drvdata->input_lock);
+       spin_lock_irqsave(&vino_drvdata->input_lock, flags);
 
        switch (vcs->input) {
-       case VINO_INPUT_D1:
-               i2c_camera_command(DECODER_INDYCAM_GET_CONTROLS,
-                                  &indycam_ctrl);
+       case VINO_INPUT_D1: {
+               err = -EINVAL;
+               for (i = 0; i < VINO_INDYCAM_V4L2_CONTROL_COUNT; i++) {
+                       if (vino_indycam_v4l2_controls[i].id == control->id) {
+                               err = 0;
+                               break;
+                       }
+               }
 
-               switch(control->id) {
-               case V4L2_CID_AUTOGAIN:
-                       control->value = indycam_ctrl.agc;
-                       break;
-               case V4L2_CID_AUTO_WHITE_BALANCE:
-                       control->value = indycam_ctrl.awb;
-                       break;
-               case V4L2_CID_GAIN:
-                       control->value = indycam_ctrl.gain;
-                       break;
-               case V4L2_CID_PRIVATE_BASE:
-                       control->value = indycam_ctrl.red_saturation;
-                       break;
-               case V4L2_CID_PRIVATE_BASE + 1:
-                       control->value = indycam_ctrl.blue_saturation;
-                       break;
-               case V4L2_CID_RED_BALANCE:
-                       control->value = indycam_ctrl.red_balance;
-                       break;
-               case V4L2_CID_BLUE_BALANCE:
-                       control->value = indycam_ctrl.blue_balance;
-                       break;
-               case V4L2_CID_EXPOSURE:
-                       control->value = indycam_ctrl.shutter;
-                       break;
-               case V4L2_CID_GAMMA:
-                       control->value = indycam_ctrl.gamma;
-                       break;
-               default:
+               if (err)
+                       goto out;
+
+               err = camera_call(core, g_ctrl, control);
+               if (err)
                        err = -EINVAL;
-               }
                break;
+       }
        case VINO_INPUT_COMPOSITE:
-       case VINO_INPUT_SVIDEO:
-               i2c_decoder_command(DECODER_SAA7191_GET_CONTROLS,
-                                  &saa7191_ctrl);
+       case VINO_INPUT_SVIDEO: {
+               err = -EINVAL;
+               for (i = 0; i < VINO_SAA7191_V4L2_CONTROL_COUNT; i++) {
+                       if (vino_saa7191_v4l2_controls[i].id == control->id) {
+                               err = 0;
+                               break;
+                       }
+               }
 
-               switch(control->id) {
-               case V4L2_CID_HUE:
-                       control->value = saa7191_ctrl.hue;
-                       break;
-               case V4L2_CID_PRIVATE_BASE:
-                       control->value = saa7191_ctrl.vtrc;
-                       break;
-               default:
+               if (err)
+                       goto out;
+
+               err = decoder_call(core, g_ctrl, control);
+               if (err)
                        err = -EINVAL;
-               }
                break;
+       }
        default:
                err =  -EINVAL;
        }
 
-       spin_unlock(&vino_drvdata->input_lock);
+out:
+       spin_unlock_irqrestore(&vino_drvdata->input_lock, flags);
 
        return err;
 }
 
-static int vino_v4l2_s_ctrl(struct vino_channel_settings *vcs,
+static int vino_s_ctrl(struct file *file, void *__fh,
                            struct v4l2_control *control)
 {
-       struct indycam_control indycam_ctrl;
-       struct saa7191_control saa7191_ctrl;
+       struct vino_channel_settings *vcs = video_drvdata(file);
+       unsigned long flags;
        int i;
        int err = 0;
 
-       spin_lock(&vino_drvdata->input_lock);
+       spin_lock_irqsave(&vino_drvdata->input_lock, flags);
+
+       if (!vino_is_input_owner(vcs)) {
+               err = -EBUSY;
+               goto out;
+       }
 
        switch (vcs->input) {
-       case VINO_INPUT_D1:
+       case VINO_INPUT_D1: {
+               err = -EINVAL;
                for (i = 0; i < VINO_INDYCAM_V4L2_CONTROL_COUNT; i++) {
-                       if (vino_indycam_v4l2_controls[i].id ==
-                           control->id) {
-                               if ((control->value >=
-                                    vino_indycam_v4l2_controls[i].minimum)
-                                   && (control->value <=
-                                       vino_indycam_v4l2_controls[i].
-                                       maximum)) {
-                                       goto ok1;
-                               } else {
-                                       err = -ERANGE;
-                                       goto error;
-                               }
+                       if (vino_indycam_v4l2_controls[i].id == control->id) {
+                               err = 0;
+                               break;
                        }
                }
-               err = -EINVAL;
-               goto error;
-
-ok1:
-               indycam_ctrl.agc = INDYCAM_VALUE_UNCHANGED;
-               indycam_ctrl.awb = INDYCAM_VALUE_UNCHANGED;
-               indycam_ctrl.shutter = INDYCAM_VALUE_UNCHANGED;
-               indycam_ctrl.gain = INDYCAM_VALUE_UNCHANGED;
-               indycam_ctrl.red_balance = INDYCAM_VALUE_UNCHANGED;
-               indycam_ctrl.blue_balance = INDYCAM_VALUE_UNCHANGED;
-               indycam_ctrl.red_saturation = INDYCAM_VALUE_UNCHANGED;
-               indycam_ctrl.blue_saturation = INDYCAM_VALUE_UNCHANGED;
-               indycam_ctrl.gamma = INDYCAM_VALUE_UNCHANGED;
-
-               switch(control->id) {
-               case V4L2_CID_AUTOGAIN:
-                       indycam_ctrl.agc = control->value;
-                       break;
-               case V4L2_CID_AUTO_WHITE_BALANCE:
-                       indycam_ctrl.awb = control->value;
-                       break;
-               case V4L2_CID_GAIN:
-                       indycam_ctrl.gain = control->value;
-                       break;
-               case V4L2_CID_PRIVATE_BASE:
-                       indycam_ctrl.red_saturation = control->value;
-                       break;
-               case V4L2_CID_PRIVATE_BASE + 1:
-                       indycam_ctrl.blue_saturation = control->value;
-                       break;
-               case V4L2_CID_RED_BALANCE:
-                       indycam_ctrl.red_balance = control->value;
-                       break;
-               case V4L2_CID_BLUE_BALANCE:
-                       indycam_ctrl.blue_balance = control->value;
-                       break;
-               case V4L2_CID_EXPOSURE:
-                       indycam_ctrl.shutter = control->value;
-                       break;
-               case V4L2_CID_GAMMA:
-                       indycam_ctrl.gamma = control->value;
-                       break;
-               default:
-                       err =  -EINVAL;
+               if (err)
+                       goto out;
+               if (control->value < vino_indycam_v4l2_controls[i].minimum ||
+                   control->value > vino_indycam_v4l2_controls[i].maximum) {
+                       err = -ERANGE;
+                       goto out;
                }
-
-               if (!err)
-                       i2c_camera_command(DECODER_INDYCAM_SET_CONTROLS,
-                                          &indycam_ctrl);
+               err = camera_call(core, s_ctrl, control);
+               if (err)
+                       err = -EINVAL;
                break;
+       }
        case VINO_INPUT_COMPOSITE:
-       case VINO_INPUT_SVIDEO:
+       case VINO_INPUT_SVIDEO: {
+               err = -EINVAL;
                for (i = 0; i < VINO_SAA7191_V4L2_CONTROL_COUNT; i++) {
-                       if (vino_saa7191_v4l2_controls[i].id ==
-                           control->id) {
-                               if ((control->value >=
-                                    vino_saa7191_v4l2_controls[i].minimum)
-                                   && (control->value <=
-                                       vino_saa7191_v4l2_controls[i].
-                                       maximum)) {
-                                       goto ok2;
-                               } else {
-                                       err = -ERANGE;
-                                       goto error;
-                               }
+                       if (vino_saa7191_v4l2_controls[i].id == control->id) {
+                               err = 0;
+                               break;
                        }
                }
-               err = -EINVAL;
-               goto error;
-
-ok2:
-               saa7191_ctrl.hue = SAA7191_VALUE_UNCHANGED;
-               saa7191_ctrl.vtrc = SAA7191_VALUE_UNCHANGED;
-
-               switch(control->id) {
-               case V4L2_CID_HUE:
-                       saa7191_ctrl.hue = control->value;
-                       break;
-               case V4L2_CID_PRIVATE_BASE:
-                       saa7191_ctrl.vtrc = control->value;
-                       break;
-               default:
-                       err =  -EINVAL;
+               if (err)
+                       goto out;
+               if (control->value < vino_saa7191_v4l2_controls[i].minimum ||
+                   control->value > vino_saa7191_v4l2_controls[i].maximum) {
+                       err = -ERANGE;
+                       goto out;
                }
 
-               if (!err)
-                       i2c_decoder_command(DECODER_SAA7191_SET_CONTROLS,
-                                           &saa7191_ctrl);
+               err = decoder_call(core, s_ctrl, control);
+               if (err)
+                       err = -EINVAL;
                break;
+       }
        default:
                err =  -EINVAL;
        }
 
-error:
-       spin_unlock(&vino_drvdata->input_lock);
+out:
+       spin_unlock_irqrestore(&vino_drvdata->input_lock, flags);
 
        return err;
 }
 
 /* File operations */
 
-static int vino_open(struct inode *inode, struct file *file)
+static int vino_open(struct file *file)
 {
-       struct video_device *dev = video_devdata(file);
-       struct vino_channel_settings *vcs = video_get_drvdata(dev);
+       struct vino_channel_settings *vcs = video_drvdata(file);
        int ret = 0;
        dprintk("open(): channel = %c\n",
               (vcs->channel == VINO_CHANNEL_A) ? 'A' : 'B');
 
-       down(&vcs->sem);
+       mutex_lock(&vcs->mutex);
 
        if (vcs->users) {
                dprintk("open(): driver busy\n");
@@ -3677,20 +3812,19 @@ static int vino_open(struct inode *inode, struct file *file)
        vcs->users++;
 
  out:
-       up(&vcs->sem);
+       mutex_unlock(&vcs->mutex);
 
        dprintk("open(): %s!\n", ret ? "failed" : "complete");
 
        return ret;
 }
 
-static int vino_close(struct inode *inode, struct file *file)
+static int vino_close(struct file *file)
 {
-       struct video_device *dev = video_devdata(file);
-       struct vino_channel_settings *vcs = video_get_drvdata(dev);
+       struct vino_channel_settings *vcs = video_drvdata(file);
        dprintk("close():\n");
 
-       down(&vcs->sem);
+       mutex_lock(&vcs->mutex);
 
        vcs->users--;
 
@@ -3702,7 +3836,7 @@ static int vino_close(struct inode *inode, struct file *file)
                vino_queue_free(&vcs->fb_queue);
        }
 
-       up(&vcs->sem);
+       mutex_unlock(&vcs->mutex);
 
        return 0;
 }
@@ -3723,15 +3857,14 @@ static void vino_vm_close(struct vm_area_struct *vma)
        dprintk("vino_vm_close(): count = %d\n", fb->map_count);
 }
 
-static struct vm_operations_struct vino_vm_ops = {
+static const struct vm_operations_struct vino_vm_ops = {
        .open   = vino_vm_open,
        .close  = vino_vm_close,
 };
 
 static int vino_mmap(struct file *file, struct vm_area_struct *vma)
 {
-       struct video_device *dev = video_devdata(file);
-       struct vino_channel_settings *vcs = video_get_drvdata(dev);
+       struct vino_channel_settings *vcs = video_drvdata(file);
 
        unsigned long start = vma->vm_start;
        unsigned long size = vma->vm_end - vma->vm_start;
@@ -3745,7 +3878,7 @@ static int vino_mmap(struct file *file, struct vm_area_struct *vma)
 
        // TODO: reject mmap if already mapped
 
-       if (down_interruptible(&vcs->sem))
+       if (mutex_lock_interruptible(&vcs->mutex))
                return -EINTR;
 
        if (vcs->reading) {
@@ -3829,15 +3962,14 @@ found:
        vma->vm_ops = &vino_vm_ops;
 
 out:
-       up(&vcs->sem);
+       mutex_unlock(&vcs->mutex);
 
        return ret;
 }
 
 static unsigned int vino_poll(struct file *file, poll_table *pt)
 {
-       struct video_device *dev = video_devdata(file);
-       struct vino_channel_settings *vcs = video_get_drvdata(dev);
+       struct vino_channel_settings *vcs = video_drvdata(file);
        unsigned int outgoing;
        unsigned int ret = 0;
 
@@ -3865,184 +3997,104 @@ static unsigned int vino_poll(struct file *file, poll_table *pt)
 over:
        dprintk("poll(): data %savailable\n",
                (outgoing > 0) ? "" : "not ");
-       if (outgoing > 0) {
+
+       if (outgoing > 0)
                ret = POLLIN | POLLRDNORM;
-       }
 
 error:
-
        return ret;
 }
 
-static int vino_do_ioctl(struct inode *inode, struct file *file,
-                     unsigned int cmd, void *arg)
-{
-       struct video_device *dev = video_devdata(file);
-       struct vino_channel_settings *vcs = video_get_drvdata(dev);
-
-       switch (_IOC_TYPE(cmd)) {
-       case 'v':
-               dprintk("ioctl(): V4L1 unsupported (0x%08x)\n", cmd);
-               break;
-       case 'V':
-               dprintk("ioctl(): V4L2 %s (0x%08x)\n",
-                       v4l2_ioctl_names[_IOC_NR(cmd)], cmd);
-               break;
-       default:
-               dprintk("ioctl(): unsupported command 0x%08x\n", cmd);
-       }
-
-       switch (cmd) {
-       /* TODO: V4L1 interface (use compatibility layer?) */
-       /* V4L2 interface */
-       case VIDIOC_QUERYCAP: {
-               vino_v4l2_querycap(arg);
-               break;
-       }
-       case VIDIOC_ENUMINPUT: {
-               return vino_v4l2_enuminput(vcs, arg);
-       }
-       case VIDIOC_G_INPUT: {
-               return vino_v4l2_g_input(vcs, arg);
-       }
-       case VIDIOC_S_INPUT: {
-               return vino_v4l2_s_input(vcs, arg);
-       }
-       case VIDIOC_ENUMSTD: {
-               return vino_v4l2_enumstd(vcs, arg);
-       }
-       case VIDIOC_G_STD: {
-               return vino_v4l2_g_std(vcs, arg);
-       }
-       case VIDIOC_S_STD: {
-               return vino_v4l2_s_std(vcs, arg);
-       }
-       case VIDIOC_ENUM_FMT: {
-               return vino_v4l2_enum_fmt(vcs, arg);
-       }
-       case VIDIOC_TRY_FMT: {
-               return vino_v4l2_try_fmt(vcs, arg);
-       }
-       case VIDIOC_G_FMT: {
-               return vino_v4l2_g_fmt(vcs, arg);
-       }
-       case VIDIOC_S_FMT: {
-               return vino_v4l2_s_fmt(vcs, arg);
-       }
-       case VIDIOC_CROPCAP: {
-               return vino_v4l2_cropcap(vcs, arg);
-       }
-       case VIDIOC_G_CROP: {
-               return vino_v4l2_g_crop(vcs, arg);
-       }
-       case VIDIOC_S_CROP: {
-               return vino_v4l2_s_crop(vcs, arg);
-       }
-       case VIDIOC_G_PARM: {
-               return vino_v4l2_g_parm(vcs, arg);
-       }
-       case VIDIOC_S_PARM: {
-               return vino_v4l2_s_parm(vcs, arg);
-       }
-       case VIDIOC_REQBUFS: {
-               return vino_v4l2_reqbufs(vcs, arg);
-       }
-       case VIDIOC_QUERYBUF: {
-               return vino_v4l2_querybuf(vcs, arg);
-       }
-       case VIDIOC_QBUF: {
-               return vino_v4l2_qbuf(vcs, arg);
-       }
-       case VIDIOC_DQBUF: {
-               return vino_v4l2_dqbuf(vcs, arg, file->f_flags & O_NONBLOCK);
-       }
-       case VIDIOC_STREAMON: {
-               return vino_v4l2_streamon(vcs);
-       }
-       case VIDIOC_STREAMOFF: {
-               return vino_v4l2_streamoff(vcs);
-       }
-       case VIDIOC_QUERYCTRL: {
-               return vino_v4l2_queryctrl(vcs, arg);
-       }
-       case VIDIOC_G_CTRL: {
-               return vino_v4l2_g_ctrl(vcs, arg);
-       }
-       case VIDIOC_S_CTRL: {
-               return vino_v4l2_s_ctrl(vcs, arg);
-       }
-       default:
-               return -ENOIOCTLCMD;
-       }
-
-       return 0;
-}
-
-static int vino_ioctl(struct inode *inode, struct file *file,
+static long vino_ioctl(struct file *file,
                      unsigned int cmd, unsigned long arg)
 {
-       struct video_device *dev = video_devdata(file);
-       struct vino_channel_settings *vcs = video_get_drvdata(dev);
-       int ret;
+       struct vino_channel_settings *vcs = video_drvdata(file);
+       long ret;
 
-       if (down_interruptible(&vcs->sem))
+       if (mutex_lock_interruptible(&vcs->mutex))
                return -EINTR;
 
-       ret = video_usercopy(inode, file, cmd, arg, vino_do_ioctl);
+       ret = video_ioctl2(file, cmd, arg);
 
-       up(&vcs->sem);
+       mutex_unlock(&vcs->mutex);
 
        return ret;
 }
 
 /* Initialization and cleanup */
 
-// __initdata
-static int vino_init_stage = 0;
+/* __initdata */
+static int vino_init_stage;
+
+const struct v4l2_ioctl_ops vino_ioctl_ops = {
+       .vidioc_enum_fmt_vid_cap     = vino_enum_fmt_vid_cap,
+       .vidioc_g_fmt_vid_cap        = vino_g_fmt_vid_cap,
+       .vidioc_s_fmt_vid_cap        = vino_s_fmt_vid_cap,
+       .vidioc_try_fmt_vid_cap      = vino_try_fmt_vid_cap,
+       .vidioc_querycap             = vino_querycap,
+       .vidioc_enum_input           = vino_enum_input,
+       .vidioc_g_input              = vino_g_input,
+       .vidioc_s_input              = vino_s_input,
+       .vidioc_g_std                = vino_g_std,
+       .vidioc_s_std                = vino_s_std,
+       .vidioc_querystd             = vino_querystd,
+       .vidioc_cropcap              = vino_cropcap,
+       .vidioc_s_crop               = vino_s_crop,
+       .vidioc_g_crop               = vino_g_crop,
+       .vidioc_s_parm               = vino_s_parm,
+       .vidioc_g_parm               = vino_g_parm,
+       .vidioc_reqbufs              = vino_reqbufs,
+       .vidioc_querybuf             = vino_querybuf,
+       .vidioc_qbuf                 = vino_qbuf,
+       .vidioc_dqbuf                = vino_dqbuf,
+       .vidioc_streamon             = vino_streamon,
+       .vidioc_streamoff            = vino_streamoff,
+       .vidioc_queryctrl            = vino_queryctrl,
+       .vidioc_g_ctrl               = vino_g_ctrl,
+       .vidioc_s_ctrl               = vino_s_ctrl,
+};
 
-static struct file_operations vino_fops = {
+static const struct v4l2_file_operations vino_fops = {
        .owner          = THIS_MODULE,
        .open           = vino_open,
        .release        = vino_close,
-       .ioctl          = vino_ioctl,
+       .unlocked_ioctl = vino_ioctl,
        .mmap           = vino_mmap,
        .poll           = vino_poll,
-       .llseek         = no_llseek,
 };
 
-static struct video_device v4l_device_template = {
+static struct video_device vdev_template = {
        .name           = "NOT SET",
-       //.type         = VID_TYPE_CAPTURE | VID_TYPE_SUBCAPTURE |
-       //      VID_TYPE_CLIPPING | VID_TYPE_SCALES, VID_TYPE_OVERLAY
-       .hardware       = VID_HARDWARE_VINO,
        .fops           = &vino_fops,
+       .ioctl_ops      = &vino_ioctl_ops,
+       .tvnorms        = V4L2_STD_NTSC | V4L2_STD_PAL | V4L2_STD_SECAM,
        .minor          = -1,
 };
 
 static void vino_module_cleanup(int stage)
 {
        switch(stage) {
+       case 11:
+               video_unregister_device(vino_drvdata->b.vdev);
+               vino_drvdata->b.vdev = NULL;
        case 10:
-               video_unregister_device(vino_drvdata->b.v4l_device);
-               vino_drvdata->b.v4l_device = NULL;
+               video_unregister_device(vino_drvdata->a.vdev);
+               vino_drvdata->a.vdev = NULL;
        case 9:
-               video_unregister_device(vino_drvdata->a.v4l_device);
-               vino_drvdata->a.v4l_device = NULL;
+               i2c_del_adapter(&vino_i2c_adapter);
        case 8:
-               vino_i2c_del_bus();
-       case 7:
                free_irq(SGI_VINO_IRQ, NULL);
+       case 7:
+               if (vino_drvdata->b.vdev) {
+                       video_device_release(vino_drvdata->b.vdev);
+                       vino_drvdata->b.vdev = NULL;
+               }
        case 6:
-               if (vino_drvdata->b.v4l_device) {
-                       video_device_release(vino_drvdata->b.v4l_device);
-                       vino_drvdata->b.v4l_device = NULL;
+               if (vino_drvdata->a.vdev) {
+                       video_device_release(vino_drvdata->a.vdev);
+                       vino_drvdata->a.vdev = NULL;
                }
        case 5:
-               if (vino_drvdata->a.v4l_device) {
-                       video_device_release(vino_drvdata->a.v4l_device);
-                       vino_drvdata->a.v4l_device = NULL;
-               }
-       case 4:
                /* all entries in dma_cpu dummy table have the same address */
                dma_unmap_single(NULL,
                                 vino_drvdata->dummy_desc_table.dma_cpu[0],
@@ -4052,8 +4104,10 @@ static void vino_module_cleanup(int stage)
                                  (void *)vino_drvdata->
                                  dummy_desc_table.dma_cpu,
                                  vino_drvdata->dummy_desc_table.dma);
-       case 3:
+       case 4:
                free_page(vino_drvdata->dummy_page);
+       case 3:
+               v4l2_device_unregister(&vino_drvdata->v4l2_dev);
        case 2:
                kfree(vino_drvdata);
        case 1:
@@ -4100,8 +4154,7 @@ static int vino_probe(void)
                return -ENODEV;
        }
 
-       printk(KERN_INFO "VINO with chip ID %ld, revision %ld found\n",
-              VINO_ID_VALUE(rev_id), VINO_REV_NUM(rev_id));
+       printk(KERN_INFO "VINO revision %ld found\n", VINO_REV_NUM(rev_id));
 
        return 0;
 }
@@ -4109,15 +4162,20 @@ static int vino_probe(void)
 static int vino_init(void)
 {
        dma_addr_t dma_dummy_address;
+       int err;
        int i;
 
-       vino_drvdata = (struct vino_settings *)
-               kmalloc(sizeof(struct vino_settings), GFP_KERNEL);
+       vino_drvdata = kzalloc(sizeof(struct vino_settings), GFP_KERNEL);
        if (!vino_drvdata) {
                vino_module_cleanup(vino_init_stage);
                return -ENOMEM;
        }
-       memset(vino_drvdata, 0, sizeof(struct vino_settings));
+       vino_init_stage++;
+       strlcpy(vino_drvdata->v4l2_dev.name, "vino",
+                       sizeof(vino_drvdata->v4l2_dev.name));
+       err = v4l2_device_register(NULL, &vino_drvdata->v4l2_dev);
+       if (err)
+               return err;
        vino_init_stage++;
 
        /* create a dummy dma descriptor */
@@ -4178,26 +4236,27 @@ static int vino_init_channel_settings(struct vino_channel_settings *vcs,
 
        vcs->capturing = 0;
 
-       init_MUTEX(&vcs->sem);
+       mutex_init(&vcs->mutex);
        spin_lock_init(&vcs->capture_lock);
 
-       init_MUTEX(&vcs->fb_queue.queue_sem);
+       mutex_init(&vcs->fb_queue.queue_mutex);
        spin_lock_init(&vcs->fb_queue.queue_lock);
        init_waitqueue_head(&vcs->fb_queue.frame_wait_queue);
 
-       vcs->v4l_device = video_device_alloc();
-       if (!vcs->v4l_device) {
+       vcs->vdev = video_device_alloc();
+       if (!vcs->vdev) {
                vino_module_cleanup(vino_init_stage);
                return -ENOMEM;
        }
        vino_init_stage++;
 
-       memcpy(vcs->v4l_device, &v4l_device_template,
+       memcpy(vcs->vdev, &vdev_template,
               sizeof(struct video_device));
-       strcpy(vcs->v4l_device->name, name);
-       vcs->v4l_device->release = video_device_release;
+       strcpy(vcs->vdev->name, name);
+       vcs->vdev->release = video_device_release;
+       vcs->vdev->v4l2_dev = &vino_drvdata->v4l2_dev;
 
-       video_set_drvdata(vcs->v4l_device, vcs);
+       video_set_drvdata(vcs->vdev, vcs);
 
        return 0;
 }
@@ -4223,12 +4282,12 @@ static int __init vino_module_init(void)
        spin_lock_init(&vino_drvdata->input_lock);
 
        ret = vino_init_channel_settings(&vino_drvdata->a, VINO_CHANNEL_A,
-                                   vino_v4l_device_name_a);
+                                   vino_vdev_name_a);
        if (ret)
                return ret;
 
        ret = vino_init_channel_settings(&vino_drvdata->b, VINO_CHANNEL_B,
-                                   vino_v4l_device_name_b);
+                                   vino_vdev_name_b);
        if (ret)
                return ret;
 
@@ -4244,15 +4303,16 @@ static int __init vino_module_init(void)
        }
        vino_init_stage++;
 
-       ret = vino_i2c_add_bus();
+       ret = i2c_add_adapter(&vino_i2c_adapter);
        if (ret) {
                printk(KERN_ERR "VINO I2C bus registration failed\n");
                vino_module_cleanup(vino_init_stage);
                return ret;
        }
+       i2c_set_adapdata(&vino_i2c_adapter, &vino_drvdata->v4l2_dev);
        vino_init_stage++;
 
-       ret = video_register_device(vino_drvdata->a.v4l_device,
+       ret = video_register_device(vino_drvdata->a.vdev,
                                    VFL_TYPE_GRABBER, -1);
        if (ret < 0) {
                printk(KERN_ERR "VINO channel A Video4Linux-device "
@@ -4262,7 +4322,7 @@ static int __init vino_module_init(void)
        }
        vino_init_stage++;
 
-       ret = video_register_device(vino_drvdata->b.v4l_device,
+       ret = video_register_device(vino_drvdata->b.vdev,
                                    VFL_TYPE_GRABBER, -1);
        if (ret < 0) {
                printk(KERN_ERR "VINO channel B Video4Linux-device "
@@ -4272,10 +4332,12 @@ static int __init vino_module_init(void)
        }
        vino_init_stage++;
 
-#if defined(CONFIG_KMOD) && defined(MODULE)
-       request_module("saa7191");
-       request_module("indycam");
-#endif
+       vino_drvdata->decoder =
+               v4l2_i2c_new_subdev(&vino_drvdata->v4l2_dev, &vino_i2c_adapter,
+                              "saa7191", "saa7191", 0, I2C_ADDRS(0x45));
+       vino_drvdata->camera =
+               v4l2_i2c_new_subdev(&vino_drvdata->v4l2_dev, &vino_i2c_adapter,
+                              "indycam", "indycam", 0, I2C_ADDRS(0x2b));
 
        dprintk("init complete!\n");