V4L/DVB (13310): uvcvideo: Return -EINVAL instead of -ENODEV in read()
[safe/jmp/linux-2.6] / drivers / media / video / indycam.c
index 26dd06e..3d69401 100644 (file)
 #include <linux/major.h>
 #include <linux/module.h>
 #include <linux/mm.h>
-#include <linux/sched.h>
 #include <linux/slab.h>
 
-#include <linux/videodev.h>
 /* IndyCam decodes stream of photons into digital image representation ;-) */
-#include <linux/video_decoder.h>
+#include <linux/videodev2.h>
 #include <linux/i2c.h>
+#include <media/v4l2-device.h>
+#include <media/v4l2-chip-ident.h>
+#include <media/v4l2-i2c-drv.h>
 
 #include "indycam.h"
 
-//#define INDYCAM_DEBUG
-
-#define INDYCAM_MODULE_VERSION "0.0.3"
+#define INDYCAM_MODULE_VERSION "0.0.5"
 
 MODULE_DESCRIPTION("SGI IndyCam driver");
 MODULE_VERSION(INDYCAM_MODULE_VERSION);
 MODULE_AUTHOR("Mikael Nousiainen <tmnousia@cc.hut.fi>");
 MODULE_LICENSE("GPL");
 
+
+// #define INDYCAM_DEBUG
+
 #ifdef INDYCAM_DEBUG
 #define dprintk(x...) printk("IndyCam: " x);
 #define indycam_regdump(client) indycam_regdump_debug(client)
@@ -45,15 +47,18 @@ MODULE_LICENSE("GPL");
 #endif
 
 struct indycam {
-       struct i2c_client *client;
-       int version;
+       struct v4l2_subdev sd;
+       u8 version;
 };
 
-static struct i2c_driver i2c_driver_indycam;
+static inline struct indycam *to_indycam(struct v4l2_subdev *sd)
+{
+       return container_of(sd, struct indycam, sd);
+}
 
-static const unsigned char initseq[] = {
+static const u8 initseq[] = {
        INDYCAM_CONTROL_AGCENA,         /* INDYCAM_CONTROL */
-       INDYCAM_SHUTTER_DEFAULT,        /* INDYCAM_SHUTTER */
+       INDYCAM_SHUTTER_60,             /* INDYCAM_SHUTTER */
        INDYCAM_GAIN_DEFAULT,           /* INDYCAM_GAIN */
        0x00,                           /* INDYCAM_BRIGHTNESS (read-only) */
        INDYCAM_RED_BALANCE_DEFAULT,    /* INDYCAM_RED_BALANCE */
@@ -64,12 +69,12 @@ static const unsigned char initseq[] = {
 
 /* IndyCam register handling */
 
-static int indycam_read_reg(struct i2c_client *client, unsigned char reg,
-                            unsigned char *value)
+static int indycam_read_reg(struct v4l2_subdev *sd, u8 reg, u8 *value)
 {
+       struct i2c_client *client = v4l2_get_subdevdata(sd);
        int ret;
 
-       if (reg == INDYCAM_RESET) {
+       if (reg == INDYCAM_REG_RESET) {
                dprintk("indycam_read_reg(): "
                        "skipping write-only register %d\n", reg);
                *value = 0;
@@ -77,24 +82,24 @@ static int indycam_read_reg(struct i2c_client *client, unsigned char reg,
        }
 
        ret = i2c_smbus_read_byte_data(client, reg);
+
        if (ret < 0) {
                printk(KERN_ERR "IndyCam: indycam_read_reg(): read failed, "
                       "register = 0x%02x\n", reg);
                return ret;
        }
 
-       *value = (unsigned char)ret;
+       *value = (u8)ret;
 
        return 0;
 }
 
-static int indycam_write_reg(struct i2c_client *client, unsigned char reg,
-                            unsigned char value)
+static int indycam_write_reg(struct v4l2_subdev *sd, u8 reg, u8 value)
 {
+       struct i2c_client *client = v4l2_get_subdevdata(sd);
        int err;
 
-       if ((reg == INDYCAM_BRIGHTNESS)
-           || (reg == INDYCAM_VERSION)) {
+       if (reg == INDYCAM_REG_BRIGHTNESS || reg == INDYCAM_REG_VERSION) {
                dprintk("indycam_write_reg(): "
                        "skipping read-only register %d\n", reg);
                return 0;
@@ -102,6 +107,7 @@ static int indycam_write_reg(struct i2c_client *client, unsigned char reg,
 
        dprintk("Writing Reg %d = 0x%02x\n", reg, value);
        err = i2c_smbus_write_byte_data(client, reg, value);
+
        if (err) {
                printk(KERN_ERR "IndyCam: indycam_write_reg(): write failed, "
                       "register = 0x%02x, value = 0x%02x\n", reg, value);
@@ -109,14 +115,13 @@ static int indycam_write_reg(struct i2c_client *client, unsigned char reg,
        return err;
 }
 
-static int indycam_write_block(struct i2c_client *client, unsigned char reg,
-                               unsigned char length, unsigned char *data)
+static int indycam_write_block(struct v4l2_subdev *sd, u8 reg,
+                              u8 length, u8 *data)
 {
-       unsigned char i;
-       int err;
+       int i, err;
 
-       for (i = reg; i < length; i++) {
-               err = indycam_write_reg(client, reg + i, data[i]);
+       for (i = 0; i < length; i++) {
+               err = indycam_write_reg(sd, reg + i, data[i]);
                if (err)
                        return err;
        }
@@ -127,284 +132,255 @@ static int indycam_write_block(struct i2c_client *client, unsigned char reg,
 /* Helper functions */
 
 #ifdef INDYCAM_DEBUG
-static void indycam_regdump_debug(struct i2c_client *client)
+static void indycam_regdump_debug(struct v4l2_subdev *sd)
 {
        int i;
-       unsigned char val;
+       u8 val;
 
        for (i = 0; i < 9; i++) {
-               indycam_read_reg(client, i, &val);
+               indycam_read_reg(sd, i, &val);
                dprintk("Reg %d = 0x%02x\n", i, val);
        }
 }
 #endif
 
-static int indycam_get_controls(struct i2c_client *client,
-                               struct indycam_control *ctrl)
+static int indycam_g_ctrl(struct v4l2_subdev *sd, struct v4l2_control *ctrl)
 {
-       unsigned char ctrl_reg;
-
-       indycam_read_reg(client, INDYCAM_CONTROL, &ctrl_reg);
-       ctrl->agc = (ctrl_reg & INDYCAM_CONTROL_AGCENA)
-               ? INDYCAM_VALUE_ENABLED
-               : INDYCAM_VALUE_DISABLED;
-       ctrl->awb = (ctrl_reg & INDYCAM_CONTROL_AWBCTL)
-               ? INDYCAM_VALUE_ENABLED
-               : INDYCAM_VALUE_DISABLED;
-       indycam_read_reg(client, INDYCAM_SHUTTER,
-                        (unsigned char *)&ctrl->shutter);
-       indycam_read_reg(client, INDYCAM_GAIN,
-                        (unsigned char *)&ctrl->gain);
-       indycam_read_reg(client, INDYCAM_RED_BALANCE,
-                        (unsigned char *)&ctrl->red_balance);
-       indycam_read_reg(client, INDYCAM_BLUE_BALANCE,
-                        (unsigned char *)&ctrl->blue_balance);
-       indycam_read_reg(client, INDYCAM_RED_SATURATION,
-                        (unsigned char *)&ctrl->red_saturation);
-       indycam_read_reg(client, INDYCAM_BLUE_SATURATION,
-                        (unsigned char *)&ctrl->blue_saturation);
-       indycam_read_reg(client, INDYCAM_GAMMA,
-                        (unsigned char *)&ctrl->gamma);
+       struct indycam *camera = to_indycam(sd);
+       u8 reg;
+       int ret = 0;
+
+       switch (ctrl->id) {
+       case V4L2_CID_AUTOGAIN:
+       case V4L2_CID_AUTO_WHITE_BALANCE:
+               ret = indycam_read_reg(sd, INDYCAM_REG_CONTROL, &reg);
+               if (ret)
+                       return -EIO;
+               if (ctrl->id == V4L2_CID_AUTOGAIN)
+                       ctrl->value = (reg & INDYCAM_CONTROL_AGCENA)
+                               ? 1 : 0;
+               else
+                       ctrl->value = (reg & INDYCAM_CONTROL_AWBCTL)
+                               ? 1 : 0;
+               break;
+       case V4L2_CID_EXPOSURE:
+               ret = indycam_read_reg(sd, INDYCAM_REG_SHUTTER, &reg);
+               if (ret)
+                       return -EIO;
+               ctrl->value = ((s32)reg == 0x00) ? 0xff : ((s32)reg - 1);
+               break;
+       case V4L2_CID_GAIN:
+               ret = indycam_read_reg(sd, INDYCAM_REG_GAIN, &reg);
+               if (ret)
+                       return -EIO;
+               ctrl->value = (s32)reg;
+               break;
+       case V4L2_CID_RED_BALANCE:
+               ret = indycam_read_reg(sd, INDYCAM_REG_RED_BALANCE, &reg);
+               if (ret)
+                       return -EIO;
+               ctrl->value = (s32)reg;
+               break;
+       case V4L2_CID_BLUE_BALANCE:
+               ret = indycam_read_reg(sd, INDYCAM_REG_BLUE_BALANCE, &reg);
+               if (ret)
+                       return -EIO;
+               ctrl->value = (s32)reg;
+               break;
+       case INDYCAM_CONTROL_RED_SATURATION:
+               ret = indycam_read_reg(sd,
+                                      INDYCAM_REG_RED_SATURATION, &reg);
+               if (ret)
+                       return -EIO;
+               ctrl->value = (s32)reg;
+               break;
+       case INDYCAM_CONTROL_BLUE_SATURATION:
+               ret = indycam_read_reg(sd,
+                                      INDYCAM_REG_BLUE_SATURATION, &reg);
+               if (ret)
+                       return -EIO;
+               ctrl->value = (s32)reg;
+               break;
+       case V4L2_CID_GAMMA:
+               if (camera->version == CAMERA_VERSION_MOOSE) {
+                       ret = indycam_read_reg(sd,
+                                              INDYCAM_REG_GAMMA, &reg);
+                       if (ret)
+                               return -EIO;
+                       ctrl->value = (s32)reg;
+               } else {
+                       ctrl->value = INDYCAM_GAMMA_DEFAULT;
+               }
+               break;
+       default:
+               ret = -EINVAL;
+       }
 
-       return 0;
+       return ret;
 }
 
-static int indycam_set_controls(struct i2c_client *client,
-                               struct indycam_control *ctrl)
+static int indycam_s_ctrl(struct v4l2_subdev *sd, struct v4l2_control *ctrl)
 {
-       unsigned char ctrl_reg;
+       struct indycam *camera = to_indycam(sd);
+       u8 reg;
+       int ret = 0;
+
+       switch (ctrl->id) {
+       case V4L2_CID_AUTOGAIN:
+       case V4L2_CID_AUTO_WHITE_BALANCE:
+               ret = indycam_read_reg(sd, INDYCAM_REG_CONTROL, &reg);
+               if (ret)
+                       break;
 
-       indycam_read_reg(client, INDYCAM_CONTROL, &ctrl_reg);
-       if (ctrl->agc != INDYCAM_VALUE_UNCHANGED) {
-               if (ctrl->agc)
-                       ctrl_reg |= INDYCAM_CONTROL_AGCENA;
-               else
-                       ctrl_reg &= ~INDYCAM_CONTROL_AGCENA;
-       }
-       if (ctrl->awb != INDYCAM_VALUE_UNCHANGED) {
-               if (ctrl->awb)
-                       ctrl_reg |= INDYCAM_CONTROL_AWBCTL;
-               else
-                       ctrl_reg &= ~INDYCAM_CONTROL_AWBCTL;
+               if (ctrl->id == V4L2_CID_AUTOGAIN) {
+                       if (ctrl->value)
+                               reg |= INDYCAM_CONTROL_AGCENA;
+                       else
+                               reg &= ~INDYCAM_CONTROL_AGCENA;
+               } else {
+                       if (ctrl->value)
+                               reg |= INDYCAM_CONTROL_AWBCTL;
+                       else
+                               reg &= ~INDYCAM_CONTROL_AWBCTL;
+               }
+
+               ret = indycam_write_reg(sd, INDYCAM_REG_CONTROL, reg);
+               break;
+       case V4L2_CID_EXPOSURE:
+               reg = (ctrl->value == 0xff) ? 0x00 : (ctrl->value + 1);
+               ret = indycam_write_reg(sd, INDYCAM_REG_SHUTTER, reg);
+               break;
+       case V4L2_CID_GAIN:
+               ret = indycam_write_reg(sd, INDYCAM_REG_GAIN, ctrl->value);
+               break;
+       case V4L2_CID_RED_BALANCE:
+               ret = indycam_write_reg(sd, INDYCAM_REG_RED_BALANCE,
+                                       ctrl->value);
+               break;
+       case V4L2_CID_BLUE_BALANCE:
+               ret = indycam_write_reg(sd, INDYCAM_REG_BLUE_BALANCE,
+                                       ctrl->value);
+               break;
+       case INDYCAM_CONTROL_RED_SATURATION:
+               ret = indycam_write_reg(sd, INDYCAM_REG_RED_SATURATION,
+                                       ctrl->value);
+               break;
+       case INDYCAM_CONTROL_BLUE_SATURATION:
+               ret = indycam_write_reg(sd, INDYCAM_REG_BLUE_SATURATION,
+                                       ctrl->value);
+               break;
+       case V4L2_CID_GAMMA:
+               if (camera->version == CAMERA_VERSION_MOOSE) {
+                       ret = indycam_write_reg(sd, INDYCAM_REG_GAMMA,
+                                               ctrl->value);
+               }
+               break;
+       default:
+               ret = -EINVAL;
        }
-       indycam_write_reg(client, INDYCAM_CONTROL, ctrl_reg);
-
-       if (ctrl->shutter >= 0)
-               indycam_write_reg(client, INDYCAM_SHUTTER, ctrl->shutter);
-       if (ctrl->gain >= 0)
-               indycam_write_reg(client, INDYCAM_GAIN, ctrl->gain);
-       if (ctrl->red_balance >= 0)
-               indycam_write_reg(client, INDYCAM_RED_BALANCE,
-                                 ctrl->red_balance);
-       if (ctrl->blue_balance >= 0)
-               indycam_write_reg(client, INDYCAM_BLUE_BALANCE,
-                                 ctrl->blue_balance);
-       if (ctrl->red_saturation >= 0)
-               indycam_write_reg(client, INDYCAM_RED_SATURATION,
-                                 ctrl->red_saturation);
-       if (ctrl->blue_saturation >= 0)
-               indycam_write_reg(client, INDYCAM_BLUE_SATURATION,
-                                 ctrl->blue_saturation);
-       if (ctrl->gamma >= 0)
-               indycam_write_reg(client, INDYCAM_GAMMA, ctrl->gamma);
 
-       return 0;
+       return ret;
 }
 
 /* I2C-interface */
 
-static int indycam_attach(struct i2c_adapter *adap, int addr, int kind)
+static int indycam_g_chip_ident(struct v4l2_subdev *sd,
+               struct v4l2_dbg_chip_ident *chip)
 {
-       int err = 0;
-       struct indycam *camera;
-       struct i2c_client *client;
+       struct i2c_client *client = v4l2_get_subdevdata(sd);
+       struct indycam *camera = to_indycam(sd);
 
-       printk(KERN_INFO "SGI IndyCam driver version %s\n",
-              INDYCAM_MODULE_VERSION);
+       return v4l2_chip_ident_i2c_client(client, chip, V4L2_IDENT_INDYCAM,
+                      camera->version);
+}
 
-       client = kmalloc(sizeof(struct i2c_client), GFP_KERNEL);
-       if (!client)
-               return -ENOMEM;
-       camera = kmalloc(sizeof(struct indycam), GFP_KERNEL);
-       if (!camera) {
-               err = -ENOMEM;
-               goto out_free_client;
-       }
+/* ----------------------------------------------------------------------- */
 
-       memset(client, 0, sizeof(struct i2c_client));
-       memset(camera, 0, sizeof(struct indycam));
+static const struct v4l2_subdev_core_ops indycam_core_ops = {
+       .g_chip_ident = indycam_g_chip_ident,
+       .g_ctrl = indycam_g_ctrl,
+       .s_ctrl = indycam_s_ctrl,
+};
 
-       client->addr = addr;
-       client->adapter = adap;
-       client->driver = &i2c_driver_indycam;
-       client->flags = 0;
-       strcpy(client->name, "IndyCam client");
-       i2c_set_clientdata(client, camera);
+static const struct v4l2_subdev_ops indycam_ops = {
+       .core = &indycam_core_ops,
+};
 
-       camera->client = client;
+static int indycam_probe(struct i2c_client *client,
+                         const struct i2c_device_id *id)
+{
+       int err = 0;
+       struct indycam *camera;
+       struct v4l2_subdev *sd;
 
-       err = i2c_attach_client(client);
-       if (err)
-               goto out_free_camera;
+       v4l_info(client, "chip found @ 0x%x (%s)\n",
+                       client->addr << 1, client->adapter->name);
 
-       camera->version = i2c_smbus_read_byte_data(client, INDYCAM_VERSION);
+       camera = kzalloc(sizeof(struct indycam), GFP_KERNEL);
+       if (!camera)
+               return -ENOMEM;
+
+       sd = &camera->sd;
+       v4l2_i2c_subdev_init(sd, client, &indycam_ops);
+
+       camera->version = i2c_smbus_read_byte_data(client,
+                                                  INDYCAM_REG_VERSION);
        if (camera->version != CAMERA_VERSION_INDY &&
            camera->version != CAMERA_VERSION_MOOSE) {
-               err = -ENODEV;
-               goto out_detach_client;
+               kfree(camera);
+               return -ENODEV;
        }
+
        printk(KERN_INFO "IndyCam v%d.%d detected\n",
               INDYCAM_VERSION_MAJOR(camera->version),
               INDYCAM_VERSION_MINOR(camera->version));
 
-       indycam_regdump(client);
+       indycam_regdump(sd);
 
        // initialize
-       err = indycam_write_block(client, 0, sizeof(initseq),
-                                 (unsigned char *)&initseq);
+       err = indycam_write_block(sd, 0, sizeof(initseq), (u8 *)&initseq);
        if (err) {
-               printk(KERN_ERR "IndyCam initalization failed\n");
-               err = -EIO;
-               goto out_detach_client;
+               printk(KERN_ERR "IndyCam initialization failed\n");
+               kfree(camera);
+               return -EIO;
        }
 
-       indycam_regdump(client);
+       indycam_regdump(sd);
 
        // white balance
-       err = indycam_write_reg(client, INDYCAM_CONTROL,
+       err = indycam_write_reg(sd, INDYCAM_REG_CONTROL,
                          INDYCAM_CONTROL_AGCENA | INDYCAM_CONTROL_AWBCTL);
        if (err) {
-               printk(KERN_ERR "IndyCam white balance "
-                      "initialization failed\n");
-               err = -EIO;
-               goto out_detach_client;
+               printk(KERN_ERR "IndyCam: White balancing camera failed\n");
+               kfree(camera);
+               return -EIO;
        }
 
-       indycam_regdump(client);
+       indycam_regdump(sd);
 
        printk(KERN_INFO "IndyCam initialized\n");
 
        return 0;
-
-out_detach_client:
-       i2c_detach_client(client);
-out_free_camera:
-       kfree(camera);
-out_free_client:
-       kfree(client);
-       return err;
 }
 
-static int indycam_probe(struct i2c_adapter *adap)
+static int indycam_remove(struct i2c_client *client)
 {
-       /* Indy specific crap */
-       if (adap->id == I2C_HW_SGI_VINO)
-               return indycam_attach(adap, INDYCAM_ADDR, 0);
-       /* Feel free to add probe here :-) */
-       return -ENODEV;
-}
-
-static int indycam_detach(struct i2c_client *client)
-{
-       struct indycam *camera = i2c_get_clientdata(client);
+       struct v4l2_subdev *sd = i2c_get_clientdata(client);
 
-       i2c_detach_client(client);
-       kfree(camera);
-       kfree(client);
+       v4l2_device_unregister_subdev(sd);
+       kfree(to_indycam(sd));
        return 0;
 }
 
-static int indycam_command(struct i2c_client *client, unsigned int cmd,
-                          void *arg)
-{
-       // struct indycam *camera = i2c_get_clientdata(client);
-
-       /* The old video_decoder interface just isn't enough,
-        * so we'll use some custom commands. */
-       switch (cmd) {
-       case DECODER_GET_CAPABILITIES: {
-               struct video_decoder_capability *cap = arg;
-
-               cap->flags  = VIDEO_DECODER_NTSC;
-               cap->inputs = 1;
-               cap->outputs = 1;
-               break;
-       }
-       case DECODER_GET_STATUS: {
-               int *iarg = arg;
-
-               *iarg = DECODER_STATUS_GOOD | DECODER_STATUS_NTSC |
-                       DECODER_STATUS_COLOR;
-               break;
-       }
-       case DECODER_SET_NORM: {
-               int *iarg = arg;
-
-               switch (*iarg) {
-               case VIDEO_MODE_NTSC:
-                       break;
-               default:
-                       return -EINVAL;
-               }
-               break;
-       }
-       case DECODER_SET_INPUT: {
-               int *iarg = arg;
-
-               if (*iarg != 0)
-                       return -EINVAL;
-               break;
-       }
-       case DECODER_SET_OUTPUT: {
-               int *iarg = arg;
-
-               if (*iarg != 0)
-                       return -EINVAL;
-               break;
-       }
-       case DECODER_ENABLE_OUTPUT: {
-               /* Always enabled */
-               break;
-       }
-       case DECODER_SET_PICTURE: {
-               // struct video_picture *pic = arg;
-               /* TODO: convert values for indycam_set_controls() */
-               break;
-       }
-       case DECODER_INDYCAM_GET_CONTROLS: {
-               struct indycam_control *ctrl = arg;
-               indycam_get_controls(client, ctrl);
-       }
-       case DECODER_INDYCAM_SET_CONTROLS: {
-               struct indycam_control *ctrl = arg;
-               indycam_set_controls(client, ctrl);
-       }
-       default:
-               return -EINVAL;
-       }
-
-       return 0;
-}
-
-static struct i2c_driver i2c_driver_indycam = {
-       .owner          = THIS_MODULE,
-       .name           = "indycam",
-       .id             = I2C_DRIVERID_INDYCAM,
-       .flags          = I2C_DF_NOTIFY,
-       .attach_adapter = indycam_probe,
-       .detach_client  = indycam_detach,
-       .command        = indycam_command,
+static const struct i2c_device_id indycam_id[] = {
+       { "indycam", 0 },
+       { }
 };
+MODULE_DEVICE_TABLE(i2c, indycam_id);
 
-static int __init indycam_init(void)
-{
-       return i2c_add_driver(&i2c_driver_indycam);
-}
-
-static void __exit indycam_exit(void)
-{
-       i2c_del_driver(&i2c_driver_indycam);
-}
-
-module_init(indycam_init);
-module_exit(indycam_exit);
+static struct v4l2_i2c_driver_data v4l2_i2c_data = {
+       .name = "indycam",
+       .probe = indycam_probe,
+       .remove = indycam_remove,
+       .id_table = indycam_id,
+};