V4L/DVB (8482): videodev: move all ioctl callbacks to a new v4l2_ioctl_ops struct
[safe/jmp/linux-2.6] / drivers / media / video / em28xx / em28xx-video.c
index 8a4d221..fcfc741 100644 (file)
@@ -1,5 +1,6 @@
 /*
-   em28xx-video.c - driver for Empia EM2800/EM2820/2840 USB video capture devices
+   em28xx-video.c - driver for Empia EM2800/EM2820/2840 USB
+                   video capture devices
 
    Copyright (C) 2005 Ludovico Cavedon <cavedon@sssup.it>
                      Markus Rechberger <mrechberger@gmail.com>
 #include <linux/i2c.h>
 #include <linux/version.h>
 #include <linux/mm.h>
-#include <linux/video_decoder.h>
 #include <linux/mutex.h>
 
 #include "em28xx.h"
 #include <media/v4l2-common.h>
+#include <media/v4l2-ioctl.h>
 #include <media/msp3400.h>
+#include <media/tuner.h>
 
 #define DRIVER_AUTHOR "Ludovico Cavedon <cavedon@sssup.it>, " \
                      "Markus Rechberger <mrechberger@gmail.com>, " \
 
 #define DRIVER_NAME         "em28xx"
 #define DRIVER_DESC         "Empia em28xx based USB video device driver"
-#define EM28XX_VERSION_CODE  KERNEL_VERSION(0, 0, 1)
+#define EM28XX_VERSION_CODE  KERNEL_VERSION(0, 1, 0)
 
 #define em28xx_videodbg(fmt, arg...) do {\
        if (video_debug) \
                printk(KERN_INFO "%s %s :"fmt, \
-                        dev->name, __FUNCTION__ , ##arg); } while (0)
+                        dev->name, __func__ , ##arg); } while (0)
+
+static unsigned int isoc_debug;
+module_param(isoc_debug, int, 0644);
+MODULE_PARM_DESC(isoc_debug, "enable debug messages [isoc transfers]");
+
+#define em28xx_isocdbg(fmt, arg...) \
+do {\
+       if (isoc_debug) { \
+               printk(KERN_INFO "%s %s :"fmt, \
+                        dev->name, __func__ , ##arg); \
+       } \
+  } while (0)
 
 MODULE_AUTHOR(DRIVER_AUTHOR);
 MODULE_DESCRIPTION(DRIVER_DESC);
@@ -62,44 +76,25 @@ static LIST_HEAD(em28xx_devlist);
 
 static unsigned int card[]     = {[0 ... (EM28XX_MAXBOARDS - 1)] = UNSET };
 static unsigned int video_nr[] = {[0 ... (EM28XX_MAXBOARDS - 1)] = UNSET };
-static unsigned int vbi_nr[] = {[0 ... (EM28XX_MAXBOARDS - 1)] = UNSET };
+static unsigned int vbi_nr[]   = {[0 ... (EM28XX_MAXBOARDS - 1)] = UNSET };
+static unsigned int radio_nr[] = {[0 ... (EM28XX_MAXBOARDS - 1)] = UNSET };
+
 module_param_array(card,  int, NULL, 0444);
 module_param_array(video_nr, int, NULL, 0444);
 module_param_array(vbi_nr, int, NULL, 0444);
-MODULE_PARM_DESC(card,"card type");
-MODULE_PARM_DESC(video_nr,"video device numbers");
-MODULE_PARM_DESC(vbi_nr,"vbi device numbers");
+module_param_array(radio_nr, int, NULL, 0444);
+MODULE_PARM_DESC(card,     "card type");
+MODULE_PARM_DESC(video_nr, "video device numbers");
+MODULE_PARM_DESC(vbi_nr,   "vbi device numbers");
+MODULE_PARM_DESC(radio_nr, "radio device numbers");
 
-static unsigned int video_debug = 0;
-module_param(video_debug,int,0644);
-MODULE_PARM_DESC(video_debug,"enable debug messages [video]");
+static unsigned int video_debug;
+module_param(video_debug, int, 0644);
+MODULE_PARM_DESC(video_debug, "enable debug messages [video]");
 
 /* Bitmask marking allocated devices from 0 to EM28XX_MAXBOARDS */
 static unsigned long em28xx_devused;
 
-/* supported tv norms */
-static struct em28xx_tvnorm tvnorms[] = {
-       {
-               .name = "PAL",
-               .id = V4L2_STD_PAL,
-               .mode = VIDEO_MODE_PAL,
-        }, {
-               .name = "NTSC",
-               .id = V4L2_STD_NTSC,
-               .mode = VIDEO_MODE_NTSC,
-       }, {
-                .name = "SECAM",
-                .id = V4L2_STD_SECAM,
-                .mode = VIDEO_MODE_SECAM,
-       }, {
-               .name = "PAL-M",
-               .id = V4L2_STD_PAL_M,
-               .mode = VIDEO_MODE_PAL,
-       }
-};
-
-#define TVNORMS ARRAY_SIZE(tvnorms)
-
 /* supported controls */
 /* Common to all boards */
 static struct v4l2_queryctrl em28xx_qctrl[] = {
@@ -112,7 +107,7 @@ static struct v4l2_queryctrl em28xx_qctrl[] = {
                .step = 0x1,
                .default_value = 0x1f,
                .flags = 0,
-       },{
+       }, {
                .id = V4L2_CID_AUDIO_MUTE,
                .type = V4L2_CTRL_TYPE_BOOLEAN,
                .name = "Mute",
@@ -126,8 +121,391 @@ static struct v4l2_queryctrl em28xx_qctrl[] = {
 
 static struct usb_driver em28xx_usb_driver;
 
+/* ------------------------------------------------------------------
+       DMA and thread functions
+   ------------------------------------------------------------------*/
+
+/*
+ * Announces that a buffer were filled and request the next
+ */
+static inline void buffer_filled(struct em28xx *dev,
+                                 struct em28xx_dmaqueue *dma_q,
+                                 struct em28xx_buffer *buf)
+{
+       /* Advice that buffer was filled */
+       em28xx_isocdbg("[%p/%d] wakeup\n", buf, buf->vb.i);
+       buf->vb.state = VIDEOBUF_DONE;
+       buf->vb.field_count++;
+       do_gettimeofday(&buf->vb.ts);
+
+       dev->isoc_ctl.buf = NULL;
+
+       list_del(&buf->vb.queue);
+       wake_up(&buf->vb.done);
+}
+
+/*
+ * Identify the buffer header type and properly handles
+ */
+static void em28xx_copy_video(struct em28xx *dev,
+                             struct em28xx_dmaqueue  *dma_q,
+                             struct em28xx_buffer *buf,
+                             unsigned char *p,
+                             unsigned char *outp, unsigned long len)
+{
+       void *fieldstart, *startwrite, *startread;
+       int  linesdone, currlinedone, offset, lencopy, remain;
+       int bytesperline = dev->width << 1;
+
+       if (dma_q->pos + len > buf->vb.size)
+               len = buf->vb.size - dma_q->pos;
+
+       if (p[0] != 0x88 && p[0] != 0x22) {
+               em28xx_isocdbg("frame is not complete\n");
+               len += 4;
+       } else
+               p += 4;
+
+       startread = p;
+       remain = len;
+
+       /* Interlaces frame */
+       if (buf->top_field)
+               fieldstart = outp;
+       else
+               fieldstart = outp + bytesperline;
+
+       linesdone = dma_q->pos / bytesperline;
+       currlinedone = dma_q->pos % bytesperline;
+       offset = linesdone * bytesperline * 2 + currlinedone;
+       startwrite = fieldstart + offset;
+       lencopy = bytesperline - currlinedone;
+       lencopy = lencopy > remain ? remain : lencopy;
+
+       if ((char *)startwrite + lencopy > (char *)outp + buf->vb.size) {
+               em28xx_isocdbg("Overflow of %zi bytes past buffer end (1)\n",
+                              ((char *)startwrite + lencopy) -
+                              ((char *)outp + buf->vb.size));
+               lencopy = remain = (char *)outp + buf->vb.size - (char *)startwrite;
+       }
+       if (lencopy <= 0)
+               return;
+       memcpy(startwrite, startread, lencopy);
+
+       remain -= lencopy;
+
+       while (remain > 0) {
+               startwrite += lencopy + bytesperline;
+               startread += lencopy;
+               if (bytesperline > remain)
+                       lencopy = remain;
+               else
+                       lencopy = bytesperline;
+
+               if ((char *)startwrite + lencopy > (char *)outp + buf->vb.size) {
+                       em28xx_isocdbg("Overflow of %zi bytes past buffer end (2)\n",
+                                      ((char *)startwrite + lencopy) -
+                                      ((char *)outp + buf->vb.size));
+                       lencopy = remain = (char *)outp + buf->vb.size -
+                                          (char *)startwrite;
+               }
+               if (lencopy <= 0)
+                       break;
+
+               memcpy(startwrite, startread, lencopy);
+
+               remain -= lencopy;
+       }
+
+       dma_q->pos += len;
+}
+
+static inline void print_err_status(struct em28xx *dev,
+                                    int packet, int status)
+{
+       char *errmsg = "Unknown";
+
+       switch (status) {
+       case -ENOENT:
+               errmsg = "unlinked synchronuously";
+               break;
+       case -ECONNRESET:
+               errmsg = "unlinked asynchronuously";
+               break;
+       case -ENOSR:
+               errmsg = "Buffer error (overrun)";
+               break;
+       case -EPIPE:
+               errmsg = "Stalled (device not responding)";
+               break;
+       case -EOVERFLOW:
+               errmsg = "Babble (bad cable?)";
+               break;
+       case -EPROTO:
+               errmsg = "Bit-stuff error (bad cable?)";
+               break;
+       case -EILSEQ:
+               errmsg = "CRC/Timeout (could be anything)";
+               break;
+       case -ETIME:
+               errmsg = "Device does not respond";
+               break;
+       }
+       if (packet < 0) {
+               em28xx_isocdbg("URB status %d [%s].\n", status, errmsg);
+       } else {
+               em28xx_isocdbg("URB packet %d, status %d [%s].\n",
+                              packet, status, errmsg);
+       }
+}
+
+/*
+ * video-buf generic routine to get the next available buffer
+ */
+static inline void get_next_buf(struct em28xx_dmaqueue *dma_q,
+                                         struct em28xx_buffer **buf)
+{
+       struct em28xx *dev = container_of(dma_q, struct em28xx, vidq);
+       char *outp;
+
+       if (list_empty(&dma_q->active)) {
+               em28xx_isocdbg("No active queue to serve\n");
+               dev->isoc_ctl.buf = NULL;
+               *buf = NULL;
+               return;
+       }
+
+       /* Get the next buffer */
+       *buf = list_entry(dma_q->active.next, struct em28xx_buffer, vb.queue);
+
+       /* Cleans up buffer - Usefull for testing for frame/URB loss */
+       outp = videobuf_to_vmalloc(&(*buf)->vb);
+       memset(outp, 0, (*buf)->vb.size);
+
+       dev->isoc_ctl.buf = *buf;
+
+       return;
+}
+
+/*
+ * Controls the isoc copy of each urb packet
+ */
+static inline int em28xx_isoc_copy(struct em28xx *dev, struct urb *urb)
+{
+       struct em28xx_buffer    *buf;
+       struct em28xx_dmaqueue  *dma_q = urb->context;
+       unsigned char *outp = NULL;
+       int i, len = 0, rc = 1;
+       unsigned char *p;
+
+       if (!dev)
+               return 0;
+
+       if ((dev->state & DEV_DISCONNECTED) || (dev->state & DEV_MISCONFIGURED))
+               return 0;
+
+       if (urb->status < 0) {
+               print_err_status(dev, -1, urb->status);
+               if (urb->status == -ENOENT)
+                       return 0;
+       }
+
+       buf = dev->isoc_ctl.buf;
+       if (buf != NULL)
+               outp = videobuf_to_vmalloc(&buf->vb);
+
+       for (i = 0; i < urb->number_of_packets; i++) {
+               int status = urb->iso_frame_desc[i].status;
+
+               if (status < 0) {
+                       print_err_status(dev, i, status);
+                       if (urb->iso_frame_desc[i].status != -EPROTO)
+                               continue;
+               }
+
+               len = urb->iso_frame_desc[i].actual_length - 4;
+
+               if (urb->iso_frame_desc[i].actual_length <= 0) {
+                       /* em28xx_isocdbg("packet %d is empty",i); - spammy */
+                       continue;
+               }
+               if (urb->iso_frame_desc[i].actual_length >
+                                               dev->max_pkt_size) {
+                       em28xx_isocdbg("packet bigger than packet size");
+                       continue;
+               }
+
+               p = urb->transfer_buffer + urb->iso_frame_desc[i].offset;
+
+               /* FIXME: incomplete buffer checks where removed to make
+                  logic simpler. Impacts of those changes should be evaluated
+                */
+               if (p[0] == 0x33 && p[1] == 0x95 && p[2] == 0x00) {
+                       em28xx_isocdbg("VBI HEADER!!!\n");
+                       /* FIXME: Should add vbi copy */
+                       continue;
+               }
+               if (p[0] == 0x22 && p[1] == 0x5a) {
+                       em28xx_isocdbg("Video frame %d, length=%i, %s\n", p[2],
+                                      len, (p[2] & 1)? "odd" : "even");
+
+                       if (!(p[2] & 1)) {
+                               if (buf != NULL)
+                                       buffer_filled(dev, dma_q, buf);
+                               get_next_buf(dma_q, &buf);
+                               if (buf == NULL)
+                                       outp = NULL;
+                               else
+                                       outp = videobuf_to_vmalloc(&buf->vb);
+                       }
+
+                       if (buf != NULL) {
+                               if (p[2] & 1)
+                                       buf->top_field = 0;
+                               else
+                                       buf->top_field = 1;
+                       }
+
+                       dma_q->pos = 0;
+               }
+               if (buf != NULL)
+                       em28xx_copy_video(dev, dma_q, buf, p, outp, len);
+       }
+       return rc;
+}
+
+/* ------------------------------------------------------------------
+       Videobuf operations
+   ------------------------------------------------------------------*/
+
+static int
+buffer_setup(struct videobuf_queue *vq, unsigned int *count, unsigned int *size)
+{
+       struct em28xx_fh *fh = vq->priv_data;
+       struct em28xx        *dev = fh->dev;
+       struct v4l2_frequency f;
+
+       *size = 16 * fh->dev->width * fh->dev->height >> 3;
+       if (0 == *count)
+               *count = EM28XX_DEF_BUF;
+
+       if (*count < EM28XX_MIN_BUF)
+               *count = EM28XX_MIN_BUF;
+
+       /* Ask tuner to go to analog mode */
+       memset(&f, 0, sizeof(f));
+       f.frequency = dev->ctl_freq;
+
+       em28xx_i2c_call_clients(dev, VIDIOC_S_FREQUENCY, &f);
+
+       return 0;
+}
+
+/* This is called *without* dev->slock held; please keep it that way */
+static void free_buffer(struct videobuf_queue *vq, struct em28xx_buffer *buf)
+{
+       struct em28xx_fh     *fh  = vq->priv_data;
+       struct em28xx        *dev = fh->dev;
+       unsigned long flags = 0;
+       if (in_interrupt())
+               BUG();
+
+       /* We used to wait for the buffer to finish here, but this didn't work
+          because, as we were keeping the state as VIDEOBUF_QUEUED,
+          videobuf_queue_cancel marked it as finished for us.
+          (Also, it could wedge forever if the hardware was misconfigured.)
+
+          This should be safe; by the time we get here, the buffer isn't
+          queued anymore. If we ever start marking the buffers as
+          VIDEOBUF_ACTIVE, it won't be, though.
+       */
+       spin_lock_irqsave(&dev->slock, flags);
+       if (dev->isoc_ctl.buf == buf)
+               dev->isoc_ctl.buf = NULL;
+       spin_unlock_irqrestore(&dev->slock, flags);
+
+       videobuf_vmalloc_free(&buf->vb);
+       buf->vb.state = VIDEOBUF_NEEDS_INIT;
+}
+
+static int
+buffer_prepare(struct videobuf_queue *vq, struct videobuf_buffer *vb,
+                                               enum v4l2_field field)
+{
+       struct em28xx_fh     *fh  = vq->priv_data;
+       struct em28xx_buffer *buf = container_of(vb, struct em28xx_buffer, vb);
+       struct em28xx        *dev = fh->dev;
+       int                  rc = 0, urb_init = 0;
+
+       /* FIXME: It assumes depth = 16 */
+       /* The only currently supported format is 16 bits/pixel */
+       buf->vb.size = 16 * dev->width * dev->height >> 3;
+
+       if (0 != buf->vb.baddr  &&  buf->vb.bsize < buf->vb.size)
+               return -EINVAL;
+
+       buf->vb.width  = dev->width;
+       buf->vb.height = dev->height;
+       buf->vb.field  = field;
+
+       if (VIDEOBUF_NEEDS_INIT == buf->vb.state) {
+               rc = videobuf_iolock(vq, &buf->vb, NULL);
+               if (rc < 0)
+                       goto fail;
+       }
+
+       if (!dev->isoc_ctl.num_bufs)
+               urb_init = 1;
+
+       if (urb_init) {
+               rc = em28xx_init_isoc(dev, EM28XX_NUM_PACKETS,
+                                     EM28XX_NUM_BUFS, dev->max_pkt_size,
+                                     em28xx_isoc_copy);
+               if (rc < 0)
+                       goto fail;
+       }
+
+       buf->vb.state = VIDEOBUF_PREPARED;
+       return 0;
+
+fail:
+       free_buffer(vq, buf);
+       return rc;
+}
+
+static void
+buffer_queue(struct videobuf_queue *vq, struct videobuf_buffer *vb)
+{
+       struct em28xx_buffer    *buf     = container_of(vb, struct em28xx_buffer, vb);
+       struct em28xx_fh        *fh      = vq->priv_data;
+       struct em28xx           *dev     = fh->dev;
+       struct em28xx_dmaqueue  *vidq    = &dev->vidq;
+
+       buf->vb.state = VIDEOBUF_QUEUED;
+       list_add_tail(&buf->vb.queue, &vidq->active);
+
+}
+
+static void buffer_release(struct videobuf_queue *vq,
+                               struct videobuf_buffer *vb)
+{
+       struct em28xx_buffer   *buf  = container_of(vb, struct em28xx_buffer, vb);
+       struct em28xx_fh       *fh   = vq->priv_data;
+       struct em28xx          *dev  = (struct em28xx *)fh->dev;
+
+       em28xx_isocdbg("em28xx: called buffer_release\n");
+
+       free_buffer(vq, buf);
+}
+
+static struct videobuf_queue_ops em28xx_video_qops = {
+       .buf_setup      = buffer_setup,
+       .buf_prepare    = buffer_prepare,
+       .buf_queue      = buffer_queue,
+       .buf_release    = buffer_release,
+};
 
-/*********************  v4l2 interface  ******************************************/
+/*********************  v4l2 interface  **************************************/
 
 /*
  * em28xx_config()
@@ -142,15 +520,13 @@ static int em28xx_config(struct em28xx *dev)
 
        /* enable vbi capturing */
 
-/*     em28xx_write_regs_req(dev,0x00,0x0e,"\xC0",1); audio register */
-/*     em28xx_write_regs_req(dev,0x00,0x0f,"\x80",1); clk register */
-       em28xx_write_regs_req(dev,0x00,0x11,"\x51",1);
+/*     em28xx_write_regs_req(dev, 0x00, 0x0e, "\xC0", 1); audio register */
+/*     em28xx_write_regs_req(dev, 0x00, 0x0f, "\x80", 1); clk register */
+       em28xx_write_regs_req(dev, 0x00, 0x11, "\x51", 1);
 
-       em28xx_audio_usb_mute(dev, 1);
        dev->mute = 1;          /* maybe not the right place... */
        dev->volume = 0x1f;
-       em28xx_audio_analog_set(dev);
-       em28xx_audio_analog_setup(dev);
+
        em28xx_outfmt_set_yuv422(dev);
        em28xx_colorlevels_set_default(dev);
        em28xx_compression_disable(dev);
@@ -173,26 +549,8 @@ static void em28xx_config_i2c(struct em28xx *dev)
        em28xx_i2c_call_clients(dev, VIDIOC_STREAMON, NULL);
 }
 
-/*
- * em28xx_empty_framequeues()
- * prepare queues for incoming and outgoing frames
- */
-static void em28xx_empty_framequeues(struct em28xx *dev)
-{
-       u32 i;
-
-       INIT_LIST_HEAD(&dev->inqueue);
-       INIT_LIST_HEAD(&dev->outqueue);
-
-       for (i = 0; i < EM28XX_NUM_FRAMES; i++) {
-               dev->frame[i].state = F_UNUSED;
-               dev->frame[i].buf.bytesused = 0;
-       }
-}
-
 static void video_mux(struct em28xx *dev, int index)
 {
-       int ainput;
        struct v4l2_routing route;
 
        route.input = INPUT(index)->vmux;
@@ -202,27 +560,19 @@ static void video_mux(struct em28xx *dev, int index)
 
        em28xx_i2c_call_clients(dev, VIDIOC_INT_S_VIDEO_ROUTING, &route);
 
-       em28xx_videodbg("Setting input index=%d, vmux=%d, amux=%d\n",index,route.input,dev->ctl_ainput);
-
        if (dev->has_msp34xx) {
-               if (dev->i2s_speed)
-                       em28xx_i2c_call_clients(dev, VIDIOC_INT_I2S_CLOCK_FREQ, &dev->i2s_speed);
+               if (dev->i2s_speed) {
+                       em28xx_i2c_call_clients(dev, VIDIOC_INT_I2S_CLOCK_FREQ,
+                               &dev->i2s_speed);
+               }
                route.input = dev->ctl_ainput;
                route.output = MSP_OUTPUT(MSP_SC_IN_DSP_SCART1);
                /* Note: this is msp3400 specific */
-               em28xx_i2c_call_clients(dev, VIDIOC_INT_S_AUDIO_ROUTING, &route);
-               ainput = EM28XX_AUDIO_SRC_TUNER;
-               em28xx_audio_source(dev, ainput);
-       } else {
-               switch (dev->ctl_ainput) {
-                       case 0:
-                               ainput = EM28XX_AUDIO_SRC_TUNER;
-                               break;
-                       default:
-                               ainput = EM28XX_AUDIO_SRC_LINE;
-               }
-               em28xx_audio_source(dev, ainput);
+               em28xx_i2c_call_clients(dev, VIDIOC_INT_S_AUDIO_ROUTING,
+                       &route);
        }
+
+       em28xx_audio_analog_set(dev);
 }
 
 /* Usage lock check functions */
@@ -235,15 +585,12 @@ static int res_get(struct em28xx_fh *fh)
        if (fh->stream_on)
                return rc;
 
-       mutex_lock(&dev->lock);
-
        if (dev->stream_on)
-               rc = -EINVAL;
-       else {
-               dev->stream_on = 1;
-               fh->stream_on  = 1;
-       }
+               return -EINVAL;
 
+       mutex_lock(&dev->lock);
+       dev->stream_on = 1;
+       fh->stream_on  = 1;
        mutex_unlock(&dev->lock);
        return rc;
 }
@@ -264,1298 +611,1307 @@ static void res_free(struct em28xx_fh *fh)
 }
 
 /*
- * em28xx_v4l2_open()
- * inits the device and starts isoc transfer
+ * em28xx_get_ctrl()
+ * return the current saturation, brightness or contrast, mute state
  */
-static int em28xx_v4l2_open(struct inode *inode, struct file *filp)
+static int em28xx_get_ctrl(struct em28xx *dev, struct v4l2_control *ctrl)
 {
-       int minor = iminor(inode);
-       int errCode = 0;
-       struct em28xx *h,*dev = NULL;
-       struct em28xx_fh *fh;
+       switch (ctrl->id) {
+       case V4L2_CID_AUDIO_MUTE:
+               ctrl->value = dev->mute;
+               return 0;
+       case V4L2_CID_AUDIO_VOLUME:
+               ctrl->value = dev->volume;
+               return 0;
+       default:
+               return -EINVAL;
+       }
+}
 
-       list_for_each_entry(h, &em28xx_devlist, devlist) {
-               if (h->vdev->minor == minor) {
-                       dev  = h;
-                       dev->type = V4L2_BUF_TYPE_VIDEO_CAPTURE;
-               }
-               if (h->vbi_dev->minor == minor) {
-                       dev  = h;
-                       dev->type = V4L2_BUF_TYPE_VBI_CAPTURE;
+/*
+ * em28xx_set_ctrl()
+ * mute or set new saturation, brightness or contrast
+ */
+static int em28xx_set_ctrl(struct em28xx *dev, const struct v4l2_control *ctrl)
+{
+       switch (ctrl->id) {
+       case V4L2_CID_AUDIO_MUTE:
+               if (ctrl->value != dev->mute) {
+                       dev->mute = ctrl->value;
+                       return em28xx_audio_analog_set(dev);
                }
+               return 0;
+       case V4L2_CID_AUDIO_VOLUME:
+               dev->volume = ctrl->value;
+               return em28xx_audio_analog_set(dev);
+       default:
+               return -EINVAL;
        }
-       if (NULL == dev)
-               return -ENODEV;
-
-       em28xx_videodbg("open minor=%d type=%s users=%d\n",
-                               minor,v4l2_type_names[dev->type],dev->users);
+}
 
-       fh = kzalloc(sizeof(struct em28xx_fh), GFP_KERNEL);
+static int check_dev(struct em28xx *dev)
+{
+       if (dev->state & DEV_DISCONNECTED) {
+               em28xx_errdev("v4l2 ioctl: device not present\n");
+               return -ENODEV;
+       }
 
-       if (!fh) {
-               em28xx_errdev("em28xx-video.c: Out of memory?!\n");
-               return -ENOMEM;
+       if (dev->state & DEV_MISCONFIGURED) {
+               em28xx_errdev("v4l2 ioctl: device is misconfigured; "
+                             "close and open it again\n");
+               return -EIO;
        }
-       mutex_lock(&dev->lock);
-       fh->dev = dev;
-       filp->private_data = fh;
+       return 0;
+}
 
-       if (dev->type == V4L2_BUF_TYPE_VIDEO_CAPTURE && dev->users == 0) {
-               em28xx_set_alternate(dev);
+static void get_scale(struct em28xx *dev,
+                       unsigned int width, unsigned int height,
+                       unsigned int *hscale, unsigned int *vscale)
+{
+       unsigned int          maxw   = norm_maxw(dev);
+       unsigned int          maxh   = norm_maxh(dev);
 
-               dev->width = norm_maxw(dev);
-               dev->height = norm_maxh(dev);
-               dev->frame_size = dev->width * dev->height * 2;
-               dev->field_size = dev->frame_size >> 1; /*both_fileds ? dev->frame_size>>1 : dev->frame_size; */
-               dev->bytesperline = dev->width * 2;
-               dev->hscale = 0;
-               dev->vscale = 0;
+       *hscale = (((unsigned long)maxw) << 12) / width - 4096L;
+       if (*hscale >= 0x4000)
+               *hscale = 0x3fff;
 
-               em28xx_capture_start(dev, 1);
-               em28xx_resolution_set(dev);
+       *vscale = (((unsigned long)maxh) << 12) / height - 4096L;
+       if (*vscale >= 0x4000)
+               *vscale = 0x3fff;
+}
 
+/* ------------------------------------------------------------------
+       IOCTL vidioc handling
+   ------------------------------------------------------------------*/
 
-               /* start the transfer */
-               errCode = em28xx_init_isoc(dev);
-               if (errCode)
-                       goto err;
+static int vidioc_g_fmt_vid_cap(struct file *file, void *priv,
+                                       struct v4l2_format *f)
+{
+       struct em28xx_fh      *fh  = priv;
+       struct em28xx         *dev = fh->dev;
 
-               em28xx_empty_framequeues(dev);
-       }
+       mutex_lock(&dev->lock);
 
-       dev->users++;
+       f->fmt.pix.width = dev->width;
+       f->fmt.pix.height = dev->height;
+       f->fmt.pix.pixelformat = V4L2_PIX_FMT_YUYV;
+       f->fmt.pix.bytesperline = dev->width * 2;
+       f->fmt.pix.sizeimage = f->fmt.pix.bytesperline  * dev->height;
+       f->fmt.pix.colorspace = V4L2_COLORSPACE_SMPTE170M;
+
+       /* FIXME: TOP? NONE? BOTTOM? ALTENATE? */
+       f->fmt.pix.field = dev->interlaced ?
+                          V4L2_FIELD_INTERLACED : V4L2_FIELD_TOP;
 
-err:
        mutex_unlock(&dev->lock);
-       return errCode;
+       return 0;
 }
 
-/*
- * em28xx_realease_resources()
- * unregisters the v4l2,i2c and usb devices
- * called when the device gets disconected or at module unload
-*/
-static void em28xx_release_resources(struct em28xx *dev)
+static int vidioc_try_fmt_vid_cap(struct file *file, void *priv,
+                       struct v4l2_format *f)
 {
+       struct em28xx_fh      *fh    = priv;
+       struct em28xx         *dev   = fh->dev;
+       int                   width  = f->fmt.pix.width;
+       int                   height = f->fmt.pix.height;
+       unsigned int          maxw   = norm_maxw(dev);
+       unsigned int          maxh   = norm_maxh(dev);
+       unsigned int          hscale, vscale;
+
+       /* width must even because of the YUYV format
+          height must be even because of interlacing */
+       height &= 0xfffe;
+       width &= 0xfffe;
 
-       /*FIXME: I2C IR should be disconnected */
+       if (height < 32)
+               height = 32;
+       if (height > maxh)
+               height = maxh;
+       if (width < 48)
+               width = 48;
+       if (width > maxw)
+               width = maxw;
 
-       em28xx_info("V4L2 devices /dev/video%d and /dev/vbi%d deregistered\n",
-                               dev->vdev->minor-MINOR_VFL_TYPE_GRABBER_MIN,
-                               dev->vbi_dev->minor-MINOR_VFL_TYPE_VBI_MIN);
-       list_del(&dev->devlist);
-       video_unregister_device(dev->vdev);
-       video_unregister_device(dev->vbi_dev);
-       em28xx_i2c_unregister(dev);
-       usb_put_dev(dev->udev);
+       mutex_lock(&dev->lock);
 
+       if (dev->is_em2800) {
+               /* the em2800 can only scale down to 50% */
+               if (height % (maxh / 2))
+                       height = maxh;
+               if (width % (maxw / 2))
+                       width = maxw;
+               /* according to empiatech support */
+               /* the MaxPacketSize is to small to support */
+               /* framesizes larger than 640x480 @ 30 fps */
+               /* or 640x576 @ 25 fps. As this would cut */
+               /* of a part of the image we prefer */
+               /* 360x576 or 360x480 for now */
+               if (width == maxw && height == maxh)
+                       width /= 2;
+       }
 
-       /* Mark device as unused */
-       em28xx_devused&=~(1<<dev->devno);
+       get_scale(dev, width, height, &hscale, &vscale);
+
+       width = (((unsigned long)maxw) << 12) / (hscale + 4096L);
+       height = (((unsigned long)maxh) << 12) / (vscale + 4096L);
+
+       f->fmt.pix.width = width;
+       f->fmt.pix.height = height;
+       f->fmt.pix.pixelformat = V4L2_PIX_FMT_YUYV;
+       f->fmt.pix.bytesperline = width * 2;
+       f->fmt.pix.sizeimage = width * 2 * height;
+       f->fmt.pix.colorspace = V4L2_COLORSPACE_SMPTE170M;
+       f->fmt.pix.field = V4L2_FIELD_INTERLACED;
+
+       mutex_unlock(&dev->lock);
+       return 0;
 }
 
-/*
- * em28xx_v4l2_close()
- * stops streaming and deallocates all resources allocated by the v4l2 calls and ioctls
- */
-static int em28xx_v4l2_close(struct inode *inode, struct file *filp)
+static int vidioc_s_fmt_vid_cap(struct file *file, void *priv,
+                       struct v4l2_format *f)
 {
-       struct em28xx_fh *fh  = filp->private_data;
-       struct em28xx    *dev = fh->dev;
-       int              errCode;
-
-       em28xx_videodbg("users=%d\n", dev->users);
+       struct em28xx_fh      *fh  = priv;
+       struct em28xx         *dev = fh->dev;
+       int                   rc;
 
+       rc = check_dev(dev);
+       if (rc < 0)
+               return rc;
 
-       if (res_check(fh))
-               res_free(fh);
+       vidioc_try_fmt_vid_cap(file, priv, f);
 
        mutex_lock(&dev->lock);
 
-       if (dev->users == 1) {
-               em28xx_uninit_isoc(dev);
-               em28xx_release_buffers(dev);
-               dev->io = IO_NONE;
-
-               /* the device is already disconnect,
-                  free the remaining resources */
-               if (dev->state & DEV_DISCONNECTED) {
-                       em28xx_release_resources(dev);
-                       mutex_unlock(&dev->lock);
-                       kfree(dev);
-                       return 0;
-               }
+       if (videobuf_queue_is_busy(&fh->vb_vidq)) {
+               em28xx_errdev("%s queue busy\n", __func__);
+               rc = -EBUSY;
+               goto out;
+       }
 
-               /* set alternate 0 */
-               dev->alt = 0;
-               em28xx_videodbg("setting alternate 0\n");
-               errCode = usb_set_interface(dev->udev, 0, 0);
-               if (errCode < 0) {
-                       em28xx_errdev("cannot change alternate number to "
-                                       "0 (error=%i)\n", errCode);
-               }
+       if (dev->stream_on && !fh->stream_on) {
+               em28xx_errdev("%s device in use by another fh\n", __func__);
+               rc = -EBUSY;
+               goto out;
        }
-       kfree(fh);
-       dev->users--;
-       wake_up_interruptible_nr(&dev->open, 1);
+
+       /* set new image size */
+       dev->width = f->fmt.pix.width;
+       dev->height = f->fmt.pix.height;
+       get_scale(dev, dev->width, dev->height, &dev->hscale, &dev->vscale);
+
+       em28xx_set_alternate(dev);
+       em28xx_resolution_set(dev);
+
+       rc = 0;
+
+out:
        mutex_unlock(&dev->lock);
-       return 0;
+       return rc;
 }
 
-/*
- * em28xx_v4l2_read()
- * will allocate buffers when called for the first time
- */
-static ssize_t
-em28xx_v4l2_read(struct file *filp, char __user * buf, size_t count,
-                loff_t * f_pos)
+static int vidioc_s_std(struct file *file, void *priv, v4l2_std_id * norm)
 {
-       struct em28xx_frame_t *f, *i;
-       unsigned long lock_flags;
-       int ret = 0;
-       struct em28xx_fh *fh = filp->private_data;
-       struct em28xx *dev = fh->dev;
+       struct em28xx_fh   *fh  = priv;
+       struct em28xx      *dev = fh->dev;
+       struct v4l2_format f;
+       int                rc;
 
-       /* FIXME: read() is not prepared to allow changing the video
-          resolution while streaming. Seems a bug at em28xx_set_fmt
-        */
+       rc = check_dev(dev);
+       if (rc < 0)
+               return rc;
 
-       if (unlikely(res_get(fh) < 0))
-               return -EBUSY;
+       mutex_lock(&dev->lock);
+       dev->norm = *norm;
+       mutex_unlock(&dev->lock);
+
+       /* Adjusts width/height, if needed */
+       f.fmt.pix.width = dev->width;
+       f.fmt.pix.height = dev->height;
+       vidioc_try_fmt_vid_cap(file, priv, &f);
 
        mutex_lock(&dev->lock);
 
-       if (dev->type == V4L2_BUF_TYPE_VIDEO_CAPTURE)
-               em28xx_videodbg("V4l2_Buf_type_videocapture is set\n");
+       /* set new image size */
+       dev->width = f.fmt.pix.width;
+       dev->height = f.fmt.pix.height;
+       get_scale(dev, dev->width, dev->height, &dev->hscale, &dev->vscale);
 
-       if (dev->type == V4L2_BUF_TYPE_VBI_CAPTURE) {
-               em28xx_videodbg("V4L2_BUF_TYPE_VBI_CAPTURE is set\n");
-               em28xx_videodbg("not supported yet! ...\n");
-               if (copy_to_user(buf, "", 1)) {
-                       mutex_unlock(&dev->lock);
-                       return -EFAULT;
-               }
-               mutex_unlock(&dev->lock);
-               return (1);
-       }
-       if (dev->type == V4L2_BUF_TYPE_SLICED_VBI_CAPTURE) {
-               em28xx_videodbg("V4L2_BUF_TYPE_SLICED_VBI_CAPTURE is set\n");
-               em28xx_videodbg("not supported yet! ...\n");
-               if (copy_to_user(buf, "", 1)) {
-                       mutex_unlock(&dev->lock);
-                       return -EFAULT;
-               }
-               mutex_unlock(&dev->lock);
-               return (1);
-       }
+       em28xx_resolution_set(dev);
+       em28xx_i2c_call_clients(dev, VIDIOC_S_STD, &dev->norm);
 
-       if (dev->state & DEV_DISCONNECTED) {
-               em28xx_videodbg("device not present\n");
-               mutex_unlock(&dev->lock);
-               return -ENODEV;
-       }
+       mutex_unlock(&dev->lock);
+       return 0;
+}
 
-       if (dev->state & DEV_MISCONFIGURED) {
-               em28xx_videodbg("device misconfigured; close and open it again\n");
-               mutex_unlock(&dev->lock);
-               return -EIO;
-       }
+static const char *iname[] = {
+       [EM28XX_VMUX_COMPOSITE1] = "Composite1",
+       [EM28XX_VMUX_COMPOSITE2] = "Composite2",
+       [EM28XX_VMUX_COMPOSITE3] = "Composite3",
+       [EM28XX_VMUX_COMPOSITE4] = "Composite4",
+       [EM28XX_VMUX_SVIDEO]     = "S-Video",
+       [EM28XX_VMUX_TELEVISION] = "Television",
+       [EM28XX_VMUX_CABLE]      = "Cable TV",
+       [EM28XX_VMUX_DVB]        = "DVB",
+       [EM28XX_VMUX_DEBUG]      = "for debug only",
+};
+
+static int vidioc_enum_input(struct file *file, void *priv,
+                               struct v4l2_input *i)
+{
+       struct em28xx_fh   *fh  = priv;
+       struct em28xx      *dev = fh->dev;
+       unsigned int       n;
 
-       if (dev->io == IO_MMAP) {
-               em28xx_videodbg ("IO method is set to mmap; close and open"
-                               " the device again to choose the read method\n");
-               mutex_unlock(&dev->lock);
+       n = i->index;
+       if (n >= MAX_EM28XX_INPUT)
+               return -EINVAL;
+       if (0 == INPUT(n)->type)
                return -EINVAL;
-       }
 
-       if (dev->io == IO_NONE) {
-               if (!em28xx_request_buffers(dev, EM28XX_NUM_READ_FRAMES)) {
-                       em28xx_errdev("read failed, not enough memory\n");
-                       mutex_unlock(&dev->lock);
-                       return -ENOMEM;
-               }
-               dev->io = IO_READ;
-               dev->stream = STREAM_ON;
-               em28xx_queue_unusedframes(dev);
-       }
+       i->index = n;
+       i->type = V4L2_INPUT_TYPE_CAMERA;
 
-       if (!count) {
-               mutex_unlock(&dev->lock);
-               return 0;
-       }
+       strcpy(i->name, iname[INPUT(n)->type]);
 
-       if (list_empty(&dev->outqueue)) {
-               if (filp->f_flags & O_NONBLOCK) {
-                       mutex_unlock(&dev->lock);
-                       return -EAGAIN;
-               }
-               ret = wait_event_interruptible
-                   (dev->wait_frame,
-                    (!list_empty(&dev->outqueue)) ||
-                    (dev->state & DEV_DISCONNECTED));
-               if (ret) {
-                       mutex_unlock(&dev->lock);
-                       return ret;
-               }
-               if (dev->state & DEV_DISCONNECTED) {
-                       mutex_unlock(&dev->lock);
-                       return -ENODEV;
-               }
-               dev->video_bytesread = 0;
-       }
+       if ((EM28XX_VMUX_TELEVISION == INPUT(n)->type) ||
+               (EM28XX_VMUX_CABLE == INPUT(n)->type))
+               i->type = V4L2_INPUT_TYPE_TUNER;
 
-       f = list_entry(dev->outqueue.prev, struct em28xx_frame_t, frame);
+       i->std = dev->vdev->tvnorms;
 
-       em28xx_queue_unusedframes(dev);
+       return 0;
+}
 
-       if (count > f->buf.length)
-               count = f->buf.length;
+static int vidioc_g_input(struct file *file, void *priv, unsigned int *i)
+{
+       struct em28xx_fh   *fh  = priv;
+       struct em28xx      *dev = fh->dev;
 
-       if ((dev->video_bytesread + count) > dev->frame_size)
-               count = dev->frame_size - dev->video_bytesread;
+       *i = dev->ctl_input;
 
-       if (copy_to_user(buf, f->bufmem+dev->video_bytesread, count)) {
-               em28xx_err("Error while copying to user\n");
-               return -EFAULT;
-       }
-       dev->video_bytesread += count;
+       return 0;
+}
 
-       if (dev->video_bytesread == dev->frame_size) {
-               spin_lock_irqsave(&dev->queue_lock, lock_flags);
-               list_for_each_entry(i, &dev->outqueue, frame)
-                                   i->state = F_UNUSED;
-               INIT_LIST_HEAD(&dev->outqueue);
-               spin_unlock_irqrestore(&dev->queue_lock, lock_flags);
+static int vidioc_s_input(struct file *file, void *priv, unsigned int i)
+{
+       struct em28xx_fh   *fh  = priv;
+       struct em28xx      *dev = fh->dev;
+       int                rc;
 
-               em28xx_queue_unusedframes(dev);
-               dev->video_bytesread = 0;
-       }
+       rc = check_dev(dev);
+       if (rc < 0)
+               return rc;
+
+       if (i >= MAX_EM28XX_INPUT)
+               return -EINVAL;
+       if (0 == INPUT(i)->type)
+               return -EINVAL;
+
+       mutex_lock(&dev->lock);
 
-       *f_pos += count;
+       video_mux(dev, i);
 
        mutex_unlock(&dev->lock);
+       return 0;
+}
+
+static int vidioc_g_audio(struct file *file, void *priv, struct v4l2_audio *a)
+{
+       struct em28xx_fh   *fh    = priv;
+       struct em28xx      *dev   = fh->dev;
+       unsigned int        index = a->index;
 
-       return count;
+       if (a->index > 1)
+               return -EINVAL;
+
+       index = dev->ctl_ainput;
+
+       if (index == 0)
+               strcpy(a->name, "Television");
+       else
+               strcpy(a->name, "Line In");
+
+       a->capability = V4L2_AUDCAP_STEREO;
+       a->index = index;
+
+       return 0;
 }
 
-/*
- * em28xx_v4l2_poll()
- * will allocate buffers when called for the first time
- */
-static unsigned int em28xx_v4l2_poll(struct file *filp, poll_table * wait)
+static int vidioc_s_audio(struct file *file, void *priv, struct v4l2_audio *a)
 {
-       unsigned int mask = 0;
-       struct em28xx_fh *fh = filp->private_data;
-       struct em28xx *dev = fh->dev;
+       struct em28xx_fh   *fh  = priv;
+       struct em28xx      *dev = fh->dev;
 
-       if (unlikely(res_get(fh) < 0))
-               return POLLERR;
+       if (a->index != dev->ctl_ainput)
+               return -EINVAL;
 
-       mutex_lock(&dev->lock);
+       return 0;
+}
 
-       if (dev->state & DEV_DISCONNECTED) {
-               em28xx_videodbg("device not present\n");
-       } else if (dev->state & DEV_MISCONFIGURED) {
-               em28xx_videodbg("device is misconfigured; close and open it again\n");
-       } else {
-               if (dev->io == IO_NONE) {
-                       if (!em28xx_request_buffers
-                           (dev, EM28XX_NUM_READ_FRAMES)) {
-                               em28xx_warn
-                                   ("poll() failed, not enough memory\n");
-                       } else {
-                               dev->io = IO_READ;
-                               dev->stream = STREAM_ON;
+static int vidioc_queryctrl(struct file *file, void *priv,
+                               struct v4l2_queryctrl *qc)
+{
+       struct em28xx_fh      *fh  = priv;
+       struct em28xx         *dev = fh->dev;
+       int                   id  = qc->id;
+       int                   i;
+       int                   rc;
+
+       rc = check_dev(dev);
+       if (rc < 0)
+               return rc;
+
+       memset(qc, 0, sizeof(*qc));
+
+       qc->id = id;
+
+       if (!dev->has_msp34xx) {
+               for (i = 0; i < ARRAY_SIZE(em28xx_qctrl); i++) {
+                       if (qc->id && qc->id == em28xx_qctrl[i].id) {
+                               memcpy(qc, &(em28xx_qctrl[i]), sizeof(*qc));
+                               return 0;
                        }
                }
+       }
+       mutex_lock(&dev->lock);
+       em28xx_i2c_call_clients(dev, VIDIOC_QUERYCTRL, qc);
+       mutex_unlock(&dev->lock);
 
-               if (dev->io == IO_READ) {
-                       em28xx_queue_unusedframes(dev);
-                       poll_wait(filp, &dev->wait_frame, wait);
+       if (qc->type)
+               return 0;
+       else
+               return -EINVAL;
+}
 
-                       if (!list_empty(&dev->outqueue))
-                               mask |= POLLIN | POLLRDNORM;
+static int vidioc_g_ctrl(struct file *file, void *priv,
+                               struct v4l2_control *ctrl)
+{
+       struct em28xx_fh      *fh  = priv;
+       struct em28xx         *dev = fh->dev;
+       int                   rc;
 
-                       mutex_unlock(&dev->lock);
+       rc = check_dev(dev);
+       if (rc < 0)
+               return rc;
+       mutex_lock(&dev->lock);
 
-                       return mask;
+       if (!dev->has_msp34xx)
+               rc = em28xx_get_ctrl(dev, ctrl);
+       else
+               rc = -EINVAL;
+
+       if (rc == -EINVAL) {
+               em28xx_i2c_call_clients(dev, VIDIOC_G_CTRL, ctrl);
+               rc = 0;
+       }
+
+       mutex_unlock(&dev->lock);
+       return rc;
+}
+
+static int vidioc_s_ctrl(struct file *file, void *priv,
+                               struct v4l2_control *ctrl)
+{
+       struct em28xx_fh      *fh  = priv;
+       struct em28xx         *dev = fh->dev;
+       u8                    i;
+       int                   rc;
+
+       rc = check_dev(dev);
+       if (rc < 0)
+               return rc;
+
+       mutex_lock(&dev->lock);
+
+       if (dev->has_msp34xx)
+               em28xx_i2c_call_clients(dev, VIDIOC_S_CTRL, ctrl);
+       else {
+               rc = 1;
+               for (i = 0; i < ARRAY_SIZE(em28xx_qctrl); i++) {
+                       if (ctrl->id == em28xx_qctrl[i].id) {
+                               if (ctrl->value < em28xx_qctrl[i].minimum ||
+                                   ctrl->value > em28xx_qctrl[i].maximum) {
+                                       rc = -ERANGE;
+                                       break;
+                               }
+
+                               rc = em28xx_set_ctrl(dev, ctrl);
+                               break;
+                       }
                }
        }
 
+       /* Control not found - try to send it to the attached devices */
+       if (rc == 1) {
+               em28xx_i2c_call_clients(dev, VIDIOC_S_CTRL, ctrl);
+               rc = 0;
+       }
+
        mutex_unlock(&dev->lock);
-       return POLLERR;
+       return rc;
 }
 
-/*
- * em28xx_vm_open()
- */
-static void em28xx_vm_open(struct vm_area_struct *vma)
+static int vidioc_g_tuner(struct file *file, void *priv,
+                               struct v4l2_tuner *t)
 {
-       struct em28xx_frame_t *f = vma->vm_private_data;
-       f->vma_use_count++;
+       struct em28xx_fh      *fh  = priv;
+       struct em28xx         *dev = fh->dev;
+       int                   rc;
+
+       rc = check_dev(dev);
+       if (rc < 0)
+               return rc;
+
+       if (0 != t->index)
+               return -EINVAL;
+
+       strcpy(t->name, "Tuner");
+
+       mutex_lock(&dev->lock);
+
+       em28xx_i2c_call_clients(dev, VIDIOC_G_TUNER, t);
+
+       mutex_unlock(&dev->lock);
+       return 0;
 }
 
-/*
- * em28xx_vm_close()
- */
-static void em28xx_vm_close(struct vm_area_struct *vma)
+static int vidioc_s_tuner(struct file *file, void *priv,
+                               struct v4l2_tuner *t)
 {
-       /* NOTE: buffers are not freed here */
-       struct em28xx_frame_t *f = vma->vm_private_data;
+       struct em28xx_fh      *fh  = priv;
+       struct em28xx         *dev = fh->dev;
+       int                   rc;
+
+       rc = check_dev(dev);
+       if (rc < 0)
+               return rc;
 
-       if (f->vma_use_count)
-               f->vma_use_count--;
+       if (0 != t->index)
+               return -EINVAL;
+
+       mutex_lock(&dev->lock);
+
+       em28xx_i2c_call_clients(dev, VIDIOC_S_TUNER, t);
+
+       mutex_unlock(&dev->lock);
+       return 0;
 }
 
-static struct vm_operations_struct em28xx_vm_ops = {
-       .open = em28xx_vm_open,
-       .close = em28xx_vm_close,
-};
+static int vidioc_g_frequency(struct file *file, void *priv,
+                               struct v4l2_frequency *f)
+{
+       struct em28xx_fh      *fh  = priv;
+       struct em28xx         *dev = fh->dev;
 
-/*
- * em28xx_v4l2_mmap()
- */
-static int em28xx_v4l2_mmap(struct file *filp, struct vm_area_struct *vma)
+       f->type = fh->radio ? V4L2_TUNER_RADIO : V4L2_TUNER_ANALOG_TV;
+       f->frequency = dev->ctl_freq;
+
+       return 0;
+}
+
+static int vidioc_s_frequency(struct file *file, void *priv,
+                               struct v4l2_frequency *f)
 {
-       struct em28xx_fh *fh    = filp->private_data;
-       struct em28xx    *dev   = fh->dev;
-       unsigned long    size   = vma->vm_end - vma->vm_start;
-       unsigned long    start  = vma->vm_start;
-       void             *pos;
-       u32              i;
+       struct em28xx_fh      *fh  = priv;
+       struct em28xx         *dev = fh->dev;
+       int                   rc;
 
-       if (unlikely(res_get(fh) < 0))
-               return -EBUSY;
+       rc = check_dev(dev);
+       if (rc < 0)
+               return rc;
+
+       if (0 != f->tuner)
+               return -EINVAL;
+
+       if (unlikely(0 == fh->radio && f->type != V4L2_TUNER_ANALOG_TV))
+               return -EINVAL;
+       if (unlikely(1 == fh->radio && f->type != V4L2_TUNER_RADIO))
+               return -EINVAL;
 
        mutex_lock(&dev->lock);
 
-       if (dev->state & DEV_DISCONNECTED) {
-               em28xx_videodbg("mmap: device not present\n");
-               mutex_unlock(&dev->lock);
-               return -ENODEV;
-       }
+       dev->ctl_freq = f->frequency;
+       em28xx_i2c_call_clients(dev, VIDIOC_S_FREQUENCY, f);
 
-       if (dev->state & DEV_MISCONFIGURED) {
-               em28xx_videodbg ("mmap: Device is misconfigured; close and "
-                                               "open it again\n");
-               mutex_unlock(&dev->lock);
-               return -EIO;
-       }
+       mutex_unlock(&dev->lock);
+       return 0;
+}
 
-       if (dev->io != IO_MMAP || !(vma->vm_flags & VM_WRITE) ||
-           size != PAGE_ALIGN(dev->frame[0].buf.length)) {
-               mutex_unlock(&dev->lock);
-               return -EINVAL;
+#ifdef CONFIG_VIDEO_ADV_DEBUG
+static int em28xx_reg_len(int reg)
+{
+       switch (reg) {
+       case EM28XX_R40_AC97LSB:
+       case EM28XX_R30_HSCALELOW:
+       case EM28XX_R32_VSCALELOW:
+               return 2;
+       default:
+               return 1;
        }
+}
 
-       for (i = 0; i < dev->num_frames; i++) {
-               if ((dev->frame[i].buf.m.offset >> PAGE_SHIFT) == vma->vm_pgoff)
-                       break;
-       }
-       if (i == dev->num_frames) {
-               em28xx_videodbg("mmap: user supplied mapping address is out of range\n");
-               mutex_unlock(&dev->lock);
+static int vidioc_g_register(struct file *file, void *priv,
+                            struct v4l2_register *reg)
+{
+       struct em28xx_fh      *fh  = priv;
+       struct em28xx         *dev = fh->dev;
+       int ret;
+
+       if (!v4l2_chip_match_host(reg->match_type, reg->match_chip))
                return -EINVAL;
-       }
 
-       /* VM_IO is eventually going to replace PageReserved altogether */
-       vma->vm_flags |= VM_IO;
-       vma->vm_flags |= VM_RESERVED;   /* avoid to swap out this VMA */
+       if (em28xx_reg_len(reg->reg) == 1) {
+               ret = em28xx_read_reg(dev, reg->reg);
+               if (ret < 0)
+                       return ret;
 
-       pos = dev->frame[i].bufmem;
-       while (size > 0) {      /* size is page-aligned */
-               if (vm_insert_page(vma, start, vmalloc_to_page(pos))) {
-                       em28xx_videodbg("mmap: vm_insert_page failed\n");
-                       mutex_unlock(&dev->lock);
-                       return -EAGAIN;
-               }
-               start += PAGE_SIZE;
-               pos += PAGE_SIZE;
-               size -= PAGE_SIZE;
+               reg->val = ret;
+       } else {
+               __le64 val = 0;
+               ret = em28xx_read_reg_req_len(dev, USB_REQ_GET_STATUS,
+                                                  reg->reg, (char *)&val, 2);
+               if (ret < 0)
+                       return ret;
+
+               reg->val = le64_to_cpu(val);
        }
 
-       vma->vm_ops = &em28xx_vm_ops;
-       vma->vm_private_data = &dev->frame[i];
+       return 0;
+}
+
+static int vidioc_s_register(struct file *file, void *priv,
+                            struct v4l2_register *reg)
+{
+       struct em28xx_fh      *fh  = priv;
+       struct em28xx         *dev = fh->dev;
+       __le64 buf;
 
-       em28xx_vm_open(vma);
-       mutex_unlock(&dev->lock);
-       return 0;
+       buf = cpu_to_le64(reg->val);
+
+       return em28xx_write_regs(dev, reg->reg, (char *)&buf,
+                                em28xx_reg_len(reg->reg));
 }
+#endif
 
-/*
- * em28xx_get_ctrl()
- * return the current saturation, brightness or contrast, mute state
- */
-static int em28xx_get_ctrl(struct em28xx *dev, struct v4l2_control *ctrl)
+
+static int vidioc_cropcap(struct file *file, void *priv,
+                                       struct v4l2_cropcap *cc)
 {
-       switch (ctrl->id) {
-       case V4L2_CID_AUDIO_MUTE:
-               ctrl->value = dev->mute;
-               return 0;
-       case V4L2_CID_AUDIO_VOLUME:
-               ctrl->value = dev->volume;
-               return 0;
-       default:
+       struct em28xx_fh      *fh  = priv;
+       struct em28xx         *dev = fh->dev;
+
+       if (cc->type != V4L2_BUF_TYPE_VIDEO_CAPTURE)
                return -EINVAL;
-       }
+
+       cc->bounds.left = 0;
+       cc->bounds.top = 0;
+       cc->bounds.width = dev->width;
+       cc->bounds.height = dev->height;
+       cc->defrect = cc->bounds;
+       cc->pixelaspect.numerator = 54; /* 4:3 FIXME: remove magic numbers */
+       cc->pixelaspect.denominator = 59;
+
+       return 0;
 }
 
-/*
- * em28xx_set_ctrl()
- * mute or set new saturation, brightness or contrast
- */
-static int em28xx_set_ctrl(struct em28xx *dev, const struct v4l2_control *ctrl)
+static int vidioc_streamon(struct file *file, void *priv,
+                                       enum v4l2_buf_type type)
 {
-       switch (ctrl->id) {
-       case V4L2_CID_AUDIO_MUTE:
-               if (ctrl->value != dev->mute) {
-                       dev->mute = ctrl->value;
-                       em28xx_audio_usb_mute(dev, ctrl->value);
-                       return em28xx_audio_analog_set(dev);
-               }
-               return 0;
-       case V4L2_CID_AUDIO_VOLUME:
-               dev->volume = ctrl->value;
-               return em28xx_audio_analog_set(dev);
-       default:
-               return -EINVAL;
-       }
+       struct em28xx_fh      *fh  = priv;
+       struct em28xx         *dev = fh->dev;
+       int                   rc;
+
+       rc = check_dev(dev);
+       if (rc < 0)
+               return rc;
+
+
+       if (unlikely(res_get(fh) < 0))
+               return -EBUSY;
+
+       return (videobuf_streamon(&fh->vb_vidq));
 }
 
-/*
- * em28xx_stream_interrupt()
- * stops streaming
- */
-static int em28xx_stream_interrupt(struct em28xx *dev)
+static int vidioc_streamoff(struct file *file, void *priv,
+                                       enum v4l2_buf_type type)
 {
-       int ret = 0;
+       struct em28xx_fh      *fh  = priv;
+       struct em28xx         *dev = fh->dev;
+       int                   rc;
 
-       /* stop reading from the device */
+       rc = check_dev(dev);
+       if (rc < 0)
+               return rc;
 
-       dev->stream = STREAM_INTERRUPT;
-       ret = wait_event_timeout(dev->wait_stream,
-                                (dev->stream == STREAM_OFF) ||
-                                (dev->state & DEV_DISCONNECTED),
-                                EM28XX_URB_TIMEOUT);
-       if (dev->state & DEV_DISCONNECTED)
-               return -ENODEV;
-       else if (ret) {
-               dev->state |= DEV_MISCONFIGURED;
-               em28xx_videodbg("device is misconfigured; close and "
-                       "open /dev/video%d again\n",
-                               dev->vdev->minor-MINOR_VFL_TYPE_GRABBER_MIN);
-               return ret;
-       }
+       if (fh->type != V4L2_BUF_TYPE_VIDEO_CAPTURE)
+               return -EINVAL;
+       if (type != fh->type)
+               return -EINVAL;
+
+       videobuf_streamoff(&fh->vb_vidq);
+       res_free(fh);
 
        return 0;
 }
 
-static int em28xx_set_norm(struct em28xx *dev, int width, int height)
+static int vidioc_querycap(struct file *file, void  *priv,
+                                       struct v4l2_capability *cap)
 {
-       unsigned int hscale, vscale;
-       unsigned int maxh, maxw;
+       struct em28xx_fh      *fh  = priv;
+       struct em28xx         *dev = fh->dev;
 
-       maxw = norm_maxw(dev);
-       maxh = norm_maxh(dev);
+       strlcpy(cap->driver, "em28xx", sizeof(cap->driver));
+       strlcpy(cap->card, em28xx_boards[dev->model].name, sizeof(cap->card));
+       strlcpy(cap->bus_info, dev->udev->dev.bus_id, sizeof(cap->bus_info));
 
-       /* width must even because of the YUYV format */
-       /* height must be even because of interlacing */
-       height &= 0xfffe;
-       width &= 0xfffe;
+       cap->version = EM28XX_VERSION_CODE;
 
-       if (height < 32)
-               height = 32;
-       if (height > maxh)
-               height = maxh;
-       if (width < 48)
-               width = 48;
-       if (width > maxw)
-               width = maxw;
+       cap->capabilities =
+                       V4L2_CAP_SLICED_VBI_CAPTURE |
+                       V4L2_CAP_VIDEO_CAPTURE |
+                       V4L2_CAP_AUDIO |
+                       V4L2_CAP_READWRITE | V4L2_CAP_STREAMING;
 
-       if ((hscale = (((unsigned long)maxw) << 12) / width - 4096L) >= 0x4000)
-               hscale = 0x3fff;
-       width = (((unsigned long)maxw) << 12) / (hscale + 4096L);
+       if (dev->tuner_type != TUNER_ABSENT)
+               cap->capabilities |= V4L2_CAP_TUNER;
 
-       if ((vscale = (((unsigned long)maxh) << 12) / height - 4096L) >= 0x4000)
-               vscale = 0x3fff;
-       height = (((unsigned long)maxh) << 12) / (vscale + 4096L);
+       return 0;
+}
 
-       /* set new image size */
-       dev->width = width;
-       dev->height = height;
-       dev->frame_size = dev->width * dev->height * 2;
-       dev->field_size = dev->frame_size >> 1; /*both_fileds ? dev->frame_size>>1 : dev->frame_size; */
-       dev->bytesperline = dev->width * 2;
-       dev->hscale = hscale;
-       dev->vscale = vscale;
+static int vidioc_enum_fmt_vid_cap(struct file *file, void  *priv,
+                                       struct v4l2_fmtdesc *fmtd)
+{
+       if (fmtd->index != 0)
+               return -EINVAL;
 
-       em28xx_resolution_set(dev);
+       fmtd->type = V4L2_BUF_TYPE_VIDEO_CAPTURE;
+       strcpy(fmtd->description, "Packed YUY2");
+       fmtd->pixelformat = V4L2_PIX_FMT_YUYV;
+       memset(fmtd->reserved, 0, sizeof(fmtd->reserved));
 
        return 0;
 }
 
-static int em28xx_get_fmt(struct em28xx *dev, struct v4l2_format *format)
+/* Sliced VBI ioctls */
+static int vidioc_g_fmt_sliced_vbi_cap(struct file *file, void *priv,
+                                       struct v4l2_format *f)
 {
-       em28xx_videodbg("VIDIOC_G_FMT: type=%s\n",
-               (format->type ==V4L2_BUF_TYPE_VIDEO_CAPTURE) ?
-               "V4L2_BUF_TYPE_VIDEO_CAPTURE" :
-               (format->type ==V4L2_BUF_TYPE_VBI_CAPTURE) ?
-               "V4L2_BUF_TYPE_VBI_CAPTURE" :
-               (format->type ==V4L2_CAP_SLICED_VBI_CAPTURE) ?
-               "V4L2_BUF_TYPE_SLICED_VBI_CAPTURE " :
-               "not supported");
+       struct em28xx_fh      *fh  = priv;
+       struct em28xx         *dev = fh->dev;
+       int                   rc;
 
-       switch (format->type) {
-       case V4L2_BUF_TYPE_VIDEO_CAPTURE:
-       {
-               format->fmt.pix.width = dev->width;
-               format->fmt.pix.height = dev->height;
-               format->fmt.pix.pixelformat = V4L2_PIX_FMT_YUYV;
-               format->fmt.pix.bytesperline = dev->bytesperline;
-               format->fmt.pix.sizeimage = dev->frame_size;
-               format->fmt.pix.colorspace = V4L2_COLORSPACE_SMPTE170M;
-               format->fmt.pix.field = dev->interlaced ? V4L2_FIELD_INTERLACED : V4L2_FIELD_TOP;       /* FIXME: TOP? NONE? BOTTOM? ALTENATE? */
-
-               em28xx_videodbg("VIDIOC_G_FMT: %dx%d\n", dev->width,
-                       dev->height);
-               break;
-       }
+       rc = check_dev(dev);
+       if (rc < 0)
+               return rc;
 
-       case V4L2_BUF_TYPE_SLICED_VBI_CAPTURE:
-       {
-               format->fmt.sliced.service_set=0;
+       mutex_lock(&dev->lock);
 
-               em28xx_i2c_call_clients(dev,VIDIOC_G_FMT,format);
+       f->fmt.sliced.service_set = 0;
 
-               if (format->fmt.sliced.service_set==0)
-                       return -EINVAL;
+       em28xx_i2c_call_clients(dev, VIDIOC_G_FMT, f);
 
-               break;
-       }
+       if (f->fmt.sliced.service_set == 0)
+               rc = -EINVAL;
 
-       default:
-               return -EINVAL;
-       }
-       return (0);
+       mutex_unlock(&dev->lock);
+       return rc;
 }
 
-static int em28xx_set_fmt(struct em28xx *dev, unsigned int cmd, struct v4l2_format *format)
+static int vidioc_try_set_sliced_vbi_cap(struct file *file, void *priv,
+                       struct v4l2_format *f)
 {
-       u32 i;
-       int ret = 0;
-       int width = format->fmt.pix.width;
-       int height = format->fmt.pix.height;
-       unsigned int hscale, vscale;
-       unsigned int maxh, maxw;
+       struct em28xx_fh      *fh  = priv;
+       struct em28xx         *dev = fh->dev;
+       int                   rc;
 
-       maxw = norm_maxw(dev);
-       maxh = norm_maxh(dev);
+       rc = check_dev(dev);
+       if (rc < 0)
+               return rc;
 
-       em28xx_videodbg("%s: type=%s\n",
-                       cmd == VIDIOC_TRY_FMT ?
-                       "VIDIOC_TRY_FMT" : "VIDIOC_S_FMT",
-                       format->type == V4L2_BUF_TYPE_VIDEO_CAPTURE ?
-                       "V4L2_BUF_TYPE_VIDEO_CAPTURE" :
-                       format->type == V4L2_BUF_TYPE_VBI_CAPTURE ?
-                       "V4L2_BUF_TYPE_VBI_CAPTURE " :
-                       "not supported");
+       mutex_lock(&dev->lock);
+       em28xx_i2c_call_clients(dev, VIDIOC_G_FMT, f);
+       mutex_unlock(&dev->lock);
 
-       if (format->type == V4L2_BUF_TYPE_SLICED_VBI_CAPTURE) {
-               em28xx_i2c_call_clients(dev,VIDIOC_G_FMT,format);
+       if (f->fmt.sliced.service_set == 0)
+               return -EINVAL;
 
-               if (format->fmt.sliced.service_set==0)
-                       return -EINVAL;
+       return 0;
+}
 
-               return 0;
-       }
 
+static int vidioc_reqbufs(struct file *file, void *priv,
+                         struct v4l2_requestbuffers *rb)
+{
+       struct em28xx_fh      *fh  = priv;
+       struct em28xx         *dev = fh->dev;
+       int                   rc;
 
-       if (format->type != V4L2_BUF_TYPE_VIDEO_CAPTURE)
-               return -EINVAL;
+       rc = check_dev(dev);
+       if (rc < 0)
+               return rc;
 
-       em28xx_videodbg("%s: requested %dx%d\n",
-               cmd == VIDIOC_TRY_FMT ?
-               "VIDIOC_TRY_FMT" : "VIDIOC_S_FMT",
-               format->fmt.pix.width, format->fmt.pix.height);
+       return (videobuf_reqbufs(&fh->vb_vidq, rb));
+}
 
-       /* FIXME: Move some code away from here */
-       /* width must even because of the YUYV format */
-       /* height must be even because of interlacing */
-       height &= 0xfffe;
-       width &= 0xfffe;
+static int vidioc_querybuf(struct file *file, void *priv,
+                          struct v4l2_buffer *b)
+{
+       struct em28xx_fh      *fh  = priv;
+       struct em28xx         *dev = fh->dev;
+       int                   rc;
 
-       if (height < 32)
-               height = 32;
-       if (height > maxh)
-               height = maxh;
-       if (width < 48)
-               width = 48;
-       if (width > maxw)
-               width = maxw;
+       rc = check_dev(dev);
+       if (rc < 0)
+               return rc;
 
-       if(dev->is_em2800){
-               /* the em2800 can only scale down to 50% */
-               if(height % (maxh / 2))
-                       height=maxh;
-               if(width % (maxw / 2))
-                       width=maxw;
-               /* according to empiatech support */
-               /* the MaxPacketSize is to small to support */
-               /* framesizes larger than 640x480 @ 30 fps */
-               /* or 640x576 @ 25 fps. As this would cut */
-               /* of a part of the image we prefer */
-               /* 360x576 or 360x480 for now */
-               if(width == maxw && height == maxh)
-                       width /= 2;
-       }
+       return (videobuf_querybuf(&fh->vb_vidq, b));
+}
 
-       if ((hscale = (((unsigned long)maxw) << 12) / width - 4096L) >= 0x4000)
-               hscale = 0x3fff;
+static int vidioc_qbuf(struct file *file, void *priv, struct v4l2_buffer *b)
+{
+       struct em28xx_fh      *fh  = priv;
+       struct em28xx         *dev = fh->dev;
+       int                   rc;
 
-       width = (((unsigned long)maxw) << 12) / (hscale + 4096L);
+       rc = check_dev(dev);
+       if (rc < 0)
+               return rc;
 
-       if ((vscale = (((unsigned long)maxh) << 12) / height - 4096L) >= 0x4000)
-               vscale = 0x3fff;
+       return (videobuf_qbuf(&fh->vb_vidq, b));
+}
 
-       height = (((unsigned long)maxh) << 12) / (vscale + 4096L);
+static int vidioc_dqbuf(struct file *file, void *priv, struct v4l2_buffer *b)
+{
+       struct em28xx_fh      *fh  = priv;
+       struct em28xx         *dev = fh->dev;
+       int                   rc;
 
-       format->fmt.pix.width = width;
-       format->fmt.pix.height = height;
-       format->fmt.pix.pixelformat = V4L2_PIX_FMT_YUYV;
-       format->fmt.pix.bytesperline = width * 2;
-       format->fmt.pix.sizeimage = width * 2 * height;
-       format->fmt.pix.colorspace = V4L2_COLORSPACE_SMPTE170M;
-       format->fmt.pix.field = V4L2_FIELD_INTERLACED;
+       rc = check_dev(dev);
+       if (rc < 0)
+               return rc;
 
-       em28xx_videodbg("%s: returned %dx%d (%d, %d)\n",
-               cmd == VIDIOC_TRY_FMT ?
-               "VIDIOC_TRY_FMT" :"VIDIOC_S_FMT",
-               format->fmt.pix.width, format->fmt.pix.height, hscale, vscale);
+       return (videobuf_dqbuf(&fh->vb_vidq, b,
+                               file->f_flags & O_NONBLOCK));
+}
 
-       if (cmd == VIDIOC_TRY_FMT)
-               return 0;
+#ifdef CONFIG_VIDEO_V4L1_COMPAT
+static int vidiocgmbuf(struct file *file, void *priv, struct video_mbuf *mbuf)
+{
+       struct em28xx_fh  *fh = priv;
 
-       for (i = 0; i < dev->num_frames; i++)
-               if (dev->frame[i].vma_use_count) {
-                       em28xx_videodbg("VIDIOC_S_FMT failed. "
-                               "Unmap the buffers first.\n");
-                       return -EINVAL;
-               }
+       return videobuf_cgmbuf(&fh->vb_vidq, mbuf, 8);
+}
+#endif
 
-       /* stop io in case it is already in progress */
-       if (dev->stream == STREAM_ON) {
-               em28xx_videodbg("VIDIOC_SET_FMT: interrupting stream\n");
-               if ((ret = em28xx_stream_interrupt(dev)))
-                       return ret;
-       }
 
-       em28xx_release_buffers(dev);
-       dev->io = IO_NONE;
+/* ----------------------------------------------------------- */
+/* RADIO ESPECIFIC IOCTLS                                      */
+/* ----------------------------------------------------------- */
 
-       /* set new image size */
-       dev->width = width;
-       dev->height = height;
-       dev->frame_size = dev->width * dev->height * 2;
-       dev->field_size = dev->frame_size >> 1;
-       dev->bytesperline = dev->width * 2;
-       dev->hscale = hscale;
-       dev->vscale = vscale;
-       em28xx_uninit_isoc(dev);
-       em28xx_set_alternate(dev);
-       em28xx_capture_start(dev, 1);
-       em28xx_resolution_set(dev);
-       em28xx_init_isoc(dev);
+static int radio_querycap(struct file *file, void  *priv,
+                         struct v4l2_capability *cap)
+{
+       struct em28xx *dev = ((struct em28xx_fh *)priv)->dev;
 
+       strlcpy(cap->driver, "em28xx", sizeof(cap->driver));
+       strlcpy(cap->card, em28xx_boards[dev->model].name, sizeof(cap->card));
+       strlcpy(cap->bus_info, dev->udev->dev.bus_id, sizeof(cap->bus_info));
+
+       cap->version = EM28XX_VERSION_CODE;
+       cap->capabilities = V4L2_CAP_TUNER;
        return 0;
 }
 
-/*
- * em28xx_v4l2_do_ioctl()
- * This function is _not_ called directly, but from
- * em28xx_v4l2_ioctl. Userspace
- * copying is done already, arg is a kernel pointer.
- */
-static int em28xx_do_ioctl(struct inode *inode, struct file *filp,
-                          struct em28xx *dev, unsigned int cmd, void *arg,
-                          v4l2_kioctl driver_ioctl)
+static int radio_g_tuner(struct file *file, void *priv,
+                        struct v4l2_tuner *t)
 {
-       struct em28xx_fh *fh = filp->private_data;
-       int ret;
+       struct em28xx *dev = ((struct em28xx_fh *)priv)->dev;
 
-       switch (cmd) {
-               /* ---------- tv norms ---------- */
-       case VIDIOC_ENUMSTD:
-       {
-               struct v4l2_standard *e = arg;
-               unsigned int i;
-
-               i = e->index;
-               if (i >= TVNORMS)
-                       return -EINVAL;
-               ret = v4l2_video_std_construct(e, tvnorms[e->index].id,
-                                               tvnorms[e->index].name);
-               e->index = i;
-               if (ret < 0)
-                       return ret;
-               return 0;
-       }
-       case VIDIOC_G_STD:
-       {
-               v4l2_std_id *id = arg;
+       if (unlikely(t->index > 0))
+               return -EINVAL;
 
-               *id = dev->tvnorm->id;
-               return 0;
-       }
-       case VIDIOC_S_STD:
-       {
-               v4l2_std_id *id = arg;
-               unsigned int i;
+       strcpy(t->name, "Radio");
+       t->type = V4L2_TUNER_RADIO;
 
-               for (i = 0; i < TVNORMS; i++)
-                       if (*id == tvnorms[i].id)
-                               break;
-               if (i == TVNORMS)
-                       for (i = 0; i < TVNORMS; i++)
-                               if (*id & tvnorms[i].id)
-                                       break;
-               if (i == TVNORMS)
-                       return -EINVAL;
+       em28xx_i2c_call_clients(dev, VIDIOC_G_TUNER, t);
+       return 0;
+}
+
+static int radio_enum_input(struct file *file, void *priv,
+                           struct v4l2_input *i)
+{
+       if (i->index != 0)
+               return -EINVAL;
+       strcpy(i->name, "Radio");
+       i->type = V4L2_INPUT_TYPE_TUNER;
 
-               mutex_lock(&dev->lock);
-               dev->tvnorm = &tvnorms[i];
+       return 0;
+}
+
+static int radio_g_audio(struct file *file, void *priv, struct v4l2_audio *a)
+{
+       if (unlikely(a->index))
+               return -EINVAL;
 
-               em28xx_set_norm(dev, dev->width, dev->height);
+       strcpy(a->name, "Radio");
+       return 0;
+}
 
-               em28xx_i2c_call_clients(dev, VIDIOC_S_STD,
-                                       &dev->tvnorm->id);
+static int radio_s_tuner(struct file *file, void *priv,
+                        struct v4l2_tuner *t)
+{
+       struct em28xx *dev = ((struct em28xx_fh *)priv)->dev;
 
-               mutex_unlock(&dev->lock);
+       if (0 != t->index)
+               return -EINVAL;
 
-               return 0;
-       }
+       em28xx_i2c_call_clients(dev, VIDIOC_S_TUNER, t);
 
-       /* ------ input switching ---------- */
-       case VIDIOC_ENUMINPUT:
-       {
-               struct v4l2_input *i = arg;
-               unsigned int n;
-               static const char *iname[] = {
-                       [EM28XX_VMUX_COMPOSITE1] = "Composite1",
-                       [EM28XX_VMUX_COMPOSITE2] = "Composite2",
-                       [EM28XX_VMUX_COMPOSITE3] = "Composite3",
-                       [EM28XX_VMUX_COMPOSITE4] = "Composite4",
-                       [EM28XX_VMUX_SVIDEO] = "S-Video",
-                       [EM28XX_VMUX_TELEVISION] = "Television",
-                       [EM28XX_VMUX_CABLE] = "Cable TV",
-                       [EM28XX_VMUX_DVB] = "DVB",
-                       [EM28XX_VMUX_DEBUG] = "for debug only",
-               };
-
-               n = i->index;
-               if (n >= MAX_EM28XX_INPUT)
-                       return -EINVAL;
-               if (0 == INPUT(n)->type)
-                       return -EINVAL;
-               memset(i, 0, sizeof(*i));
-               i->index = n;
-               i->type = V4L2_INPUT_TYPE_CAMERA;
-               strcpy(i->name, iname[INPUT(n)->type]);
-               if ((EM28XX_VMUX_TELEVISION == INPUT(n)->type) ||
-                       (EM28XX_VMUX_CABLE == INPUT(n)->type))
-                       i->type = V4L2_INPUT_TYPE_TUNER;
-               for (n = 0; n < ARRAY_SIZE(tvnorms); n++)
-                       i->std |= tvnorms[n].id;
-               return 0;
-       }
-       case VIDIOC_G_INPUT:
-       {
-               int *i = arg;
-               *i = dev->ctl_input;
+       return 0;
+}
 
-               return 0;
-       }
-       case VIDIOC_S_INPUT:
-       {
-               int *index = arg;
+static int radio_s_audio(struct file *file, void *fh,
+                        struct v4l2_audio *a)
+{
+       return 0;
+}
 
-               if (*index >= MAX_EM28XX_INPUT)
-                       return -EINVAL;
-               if (0 == INPUT(*index)->type)
-                       return -EINVAL;
+static int radio_s_input(struct file *file, void *fh, unsigned int i)
+{
+       return 0;
+}
 
-               mutex_lock(&dev->lock);
-               video_mux(dev, *index);
-               mutex_unlock(&dev->lock);
+static int radio_queryctrl(struct file *file, void *priv,
+                          struct v4l2_queryctrl *qc)
+{
+       int i;
 
-               return 0;
-       }
-       case VIDIOC_G_AUDIO:
-       {
-               struct v4l2_audio *a = arg;
-               unsigned int index = a->index;
-
-               if (a->index > 1)
-                       return -EINVAL;
-               memset(a, 0, sizeof(*a));
-               index = dev->ctl_ainput;
-
-               if (index == 0) {
-                       strcpy(a->name, "Television");
-               } else {
-                       strcpy(a->name, "Line In");
+       if (qc->id <  V4L2_CID_BASE ||
+               qc->id >= V4L2_CID_LASTP1)
+               return -EINVAL;
+
+       for (i = 0; i < ARRAY_SIZE(em28xx_qctrl); i++) {
+               if (qc->id && qc->id == em28xx_qctrl[i].id) {
+                       memcpy(qc, &(em28xx_qctrl[i]), sizeof(*qc));
+                       return 0;
                }
-               a->capability = V4L2_AUDCAP_STEREO;
-               a->index = index;
-               return 0;
        }
-       case VIDIOC_S_AUDIO:
-       {
-               struct v4l2_audio *a = arg;
 
-               if (a->index != dev->ctl_ainput)
-                       return -EINVAL;
+       return -EINVAL;
+}
 
-               return 0;
-       }
+/*
+ * em28xx_v4l2_open()
+ * inits the device and starts isoc transfer
+ */
+static int em28xx_v4l2_open(struct inode *inode, struct file *filp)
+{
+       int minor = iminor(inode);
+       int errCode = 0, radio = 0;
+       struct em28xx *h, *dev = NULL;
+       struct em28xx_fh *fh;
+       enum v4l2_buf_type fh_type = 0;
 
-       /* --- controls ---------------------------------------------- */
-       case VIDIOC_QUERYCTRL:
-       {
-               struct v4l2_queryctrl *qc = arg;
-               int i, id=qc->id;
-
-               memset(qc,0,sizeof(*qc));
-               qc->id=id;
-
-               if (!dev->has_msp34xx) {
-                       for (i = 0; i < ARRAY_SIZE(em28xx_qctrl); i++) {
-                               if (qc->id && qc->id == em28xx_qctrl[i].id) {
-                                       memcpy(qc, &(em28xx_qctrl[i]),
-                                       sizeof(*qc));
-                                       return 0;
-                               }
-                       }
+       list_for_each_entry(h, &em28xx_devlist, devlist) {
+               if (h->vdev->minor == minor) {
+                       dev  = h;
+                       fh_type = V4L2_BUF_TYPE_VIDEO_CAPTURE;
+               }
+               if (h->vbi_dev->minor == minor) {
+                       dev  = h;
+                       fh_type = V4L2_BUF_TYPE_VBI_CAPTURE;
+               }
+               if (h->radio_dev &&
+                   h->radio_dev->minor == minor) {
+                       radio = 1;
+                       dev   = h;
                }
-               mutex_lock(&dev->lock);
-               em28xx_i2c_call_clients(dev,cmd,qc);
-               mutex_unlock(&dev->lock);
-               if (qc->type)
-                       return 0;
-               else
-                       return -EINVAL;
        }
-       case VIDIOC_G_CTRL:
-       {
-               struct v4l2_control *ctrl = arg;
-               int retval=-EINVAL;
-
-               if (!dev->has_msp34xx)
-                       retval=em28xx_get_ctrl(dev, ctrl);
-               if (retval==-EINVAL) {
-                       mutex_lock(&dev->lock);
-                       em28xx_i2c_call_clients(dev,cmd,arg);
-                       mutex_unlock(&dev->lock);
-                       return 0;
-               } else return retval;
+       if (NULL == dev)
+               return -ENODEV;
+
+       em28xx_videodbg("open minor=%d type=%s users=%d\n",
+                               minor, v4l2_type_names[fh_type], dev->users);
+
+
+       fh = kzalloc(sizeof(struct em28xx_fh), GFP_KERNEL);
+       if (!fh) {
+               em28xx_errdev("em28xx-video.c: Out of memory?!\n");
+               return -ENOMEM;
        }
-       case VIDIOC_S_CTRL:
-       {
-               struct v4l2_control *ctrl = arg;
-               u8 i;
-               mutex_lock(&dev->lock);
-
-               if (!dev->has_msp34xx){
-                       for (i = 0; i < ARRAY_SIZE(em28xx_qctrl); i++) {
-                               if (ctrl->id == em28xx_qctrl[i].id) {
-                                       int retval=-EINVAL;
-                                       if (ctrl->value <
-                                       em28xx_qctrl[i].minimum
-                                       || ctrl->value >
-                                       em28xx_qctrl[i].maximum)
-                                               return -ERANGE;
-                                       retval = em28xx_set_ctrl(dev, ctrl);
-                                       mutex_unlock(&dev->lock);
-                                       return retval;
-                               }
-                       }
-               }
+       mutex_lock(&dev->lock);
+       fh->dev = dev;
+       fh->radio = radio;
+       fh->type = fh_type;
+       filp->private_data = fh;
+
+       if (fh->type == V4L2_BUF_TYPE_VIDEO_CAPTURE && dev->users == 0) {
+               dev->width = norm_maxw(dev);
+               dev->height = norm_maxh(dev);
+               dev->hscale = 0;
+               dev->vscale = 0;
+
+               em28xx_set_mode(dev, EM28XX_ANALOG_MODE);
+               em28xx_set_alternate(dev);
+               em28xx_resolution_set(dev);
+
+               /* Needed, since GPIO might have disabled power of
+                  some i2c device
+                */
+               em28xx_config_i2c(dev);
 
-               em28xx_i2c_call_clients(dev,cmd,arg);
-               mutex_unlock(&dev->lock);
-               return 0;
-       }
-       /* --- tuner ioctls ------------------------------------------ */
-       case VIDIOC_G_TUNER:
-       {
-               struct v4l2_tuner *t = arg;
-
-               if (0 != t->index)
-                       return -EINVAL;
-
-               memset(t, 0, sizeof(*t));
-               strcpy(t->name, "Tuner");
-               mutex_lock(&dev->lock);
-               /* let clients fill in the remainder of this struct */
-               em28xx_i2c_call_clients(dev, cmd, t);
-               mutex_unlock(&dev->lock);
-               em28xx_videodbg("VIDIO_G_TUNER: signal=%x, afc=%x\n", t->signal,
-                               t->afc);
-               return 0;
        }
-       case VIDIOC_S_TUNER:
-       {
-               struct v4l2_tuner *t = arg;
-
-               if (0 != t->index)
-                       return -EINVAL;
-               mutex_lock(&dev->lock);
-               /* let clients handle this */
-               em28xx_i2c_call_clients(dev, cmd, t);
-               mutex_unlock(&dev->lock);
-               return 0;
+       if (fh->radio) {
+               em28xx_videodbg("video_open: setting radio device\n");
+               em28xx_i2c_call_clients(dev, AUDC_SET_RADIO, NULL);
        }
-       case VIDIOC_G_FREQUENCY:
-       {
-               struct v4l2_frequency *f = arg;
 
-               memset(f, 0, sizeof(*f));
-               f->type = V4L2_TUNER_ANALOG_TV;
-               f->frequency = dev->ctl_freq;
+       dev->users++;
 
-               return 0;
-       }
-       case VIDIOC_S_FREQUENCY:
-       {
-               struct v4l2_frequency *f = arg;
+       videobuf_queue_vmalloc_init(&fh->vb_vidq, &em28xx_video_qops,
+                       NULL, &dev->slock, fh->type, V4L2_FIELD_INTERLACED,
+                       sizeof(struct em28xx_buffer), fh);
+
+       mutex_unlock(&dev->lock);
 
-               if (0 != f->tuner)
-                       return -EINVAL;
+       return errCode;
+}
+
+/*
+ * em28xx_realease_resources()
+ * unregisters the v4l2,i2c and usb devices
+ * called when the device gets disconected or at module unload
+*/
+static void em28xx_release_resources(struct em28xx *dev)
+{
 
-               if (V4L2_TUNER_ANALOG_TV != f->type)
-                       return -EINVAL;
+       /*FIXME: I2C IR should be disconnected */
 
-               mutex_lock(&dev->lock);
-               dev->ctl_freq = f->frequency;
-               em28xx_i2c_call_clients(dev, VIDIOC_S_FREQUENCY, f);
-               mutex_unlock(&dev->lock);
-               return 0;
+       em28xx_info("V4L2 devices /dev/video%d and /dev/vbi%d deregistered\n",
+                               dev->vdev->minor-MINOR_VFL_TYPE_GRABBER_MIN,
+                               dev->vbi_dev->minor-MINOR_VFL_TYPE_VBI_MIN);
+       list_del(&dev->devlist);
+       if (dev->sbutton_input_dev)
+               em28xx_deregister_snapshot_button(dev);
+       if (dev->radio_dev) {
+               if (-1 != dev->radio_dev->minor)
+                       video_unregister_device(dev->radio_dev);
+               else
+                       video_device_release(dev->radio_dev);
+               dev->radio_dev = NULL;
        }
-       case VIDIOC_CROPCAP:
-       {
-               struct v4l2_cropcap *cc = arg;
-
-               if (cc->type != V4L2_BUF_TYPE_VIDEO_CAPTURE)
-                       return -EINVAL;
-               cc->bounds.left = 0;
-               cc->bounds.top = 0;
-               cc->bounds.width = dev->width;
-               cc->bounds.height = dev->height;
-               cc->defrect = cc->bounds;
-               cc->pixelaspect.numerator = 54; /* 4:3 FIXME: remove magic numbers */
-               cc->pixelaspect.denominator = 59;
-               return 0;
+       if (dev->vbi_dev) {
+               if (-1 != dev->vbi_dev->minor)
+                       video_unregister_device(dev->vbi_dev);
+               else
+                       video_device_release(dev->vbi_dev);
+               dev->vbi_dev = NULL;
        }
-       case VIDIOC_STREAMON:
-       {
-               int *type = arg;
+       if (dev->vdev) {
+               if (-1 != dev->vdev->minor)
+                       video_unregister_device(dev->vdev);
+               else
+                       video_device_release(dev->vdev);
+               dev->vdev = NULL;
+       }
+       em28xx_i2c_unregister(dev);
+       usb_put_dev(dev->udev);
+
+       /* Mark device as unused */
+       em28xx_devused &= ~(1<<dev->devno);
+}
+
+/*
+ * em28xx_v4l2_close()
+ * stops streaming and deallocates all resources allocated by the v4l2
+ * calls and ioctls
+ */
+static int em28xx_v4l2_close(struct inode *inode, struct file *filp)
+{
+       struct em28xx_fh *fh  = filp->private_data;
+       struct em28xx    *dev = fh->dev;
+       int              errCode;
 
-               if (*type != V4L2_BUF_TYPE_VIDEO_CAPTURE
-                       || dev->io != IO_MMAP)
-                       return -EINVAL;
+       em28xx_videodbg("users=%d\n", dev->users);
 
-               if (list_empty(&dev->inqueue))
-                       return -EINVAL;
 
-               if (unlikely(res_get(fh) < 0))
-                       return -EBUSY;
+       if (res_check(fh))
+               res_free(fh);
 
-               dev->stream = STREAM_ON;        /* FIXME: Start video capture here? */
+       mutex_lock(&dev->lock);
 
-               em28xx_videodbg("VIDIOC_STREAMON: starting stream\n");
+       if (dev->users == 1) {
+               videobuf_stop(&fh->vb_vidq);
+               videobuf_mmap_free(&fh->vb_vidq);
 
-               return 0;
-       }
-       case VIDIOC_STREAMOFF:
-       {
-               int *type = arg;
-               int ret;
-
-               if (*type != V4L2_BUF_TYPE_VIDEO_CAPTURE
-                       || dev->io != IO_MMAP)
-                       return -EINVAL;
-
-               mutex_lock(&dev->lock);
-               if (dev->stream == STREAM_ON) {
-                       em28xx_videodbg ("VIDIOC_STREAMOFF: interrupting stream\n");
-                       if ((ret = em28xx_stream_interrupt(dev))){
-                               mutex_unlock(&dev->lock);
-                               return ret;
-                       }
+               /* the device is already disconnect,
+                  free the remaining resources */
+               if (dev->state & DEV_DISCONNECTED) {
+                       em28xx_release_resources(dev);
+                       mutex_unlock(&dev->lock);
+                       kfree(dev);
+                       return 0;
                }
 
-               em28xx_empty_framequeues(dev);
-               mutex_unlock(&dev->lock);
+               /* do this before setting alternate! */
+               em28xx_uninit_isoc(dev);
+               em28xx_set_mode(dev, EM28XX_MODE_UNDEFINED);
 
-               return 0;
-       }
-       default:
-               return v4l_compat_translate_ioctl(inode, filp, cmd, arg,
-                                                 driver_ioctl);
+               /* set alternate 0 */
+               dev->alt = 0;
+               em28xx_videodbg("setting alternate 0\n");
+               errCode = usb_set_interface(dev->udev, 0, 0);
+               if (errCode < 0) {
+                       em28xx_errdev("cannot change alternate number to "
+                                       "0 (error=%i)\n", errCode);
+               }
        }
+       kfree(fh);
+       dev->users--;
+       wake_up_interruptible_nr(&dev->open, 1);
+       mutex_unlock(&dev->lock);
        return 0;
 }
 
 /*
- * em28xx_v4l2_do_ioctl()
- * This function is _not_ called directly, but from
- * em28xx_v4l2_ioctl. Userspace
- * copying is done already, arg is a kernel pointer.
+ * em28xx_v4l2_read()
+ * will allocate buffers when called for the first time
  */
-static int em28xx_video_do_ioctl(struct inode *inode, struct file *filp,
-                                unsigned int cmd, void *arg)
+static ssize_t
+em28xx_v4l2_read(struct file *filp, char __user *buf, size_t count,
+                loff_t *pos)
 {
        struct em28xx_fh *fh = filp->private_data;
-       struct em28xx *dev   = fh->dev;
+       struct em28xx *dev = fh->dev;
+       int rc;
 
-       if (!dev)
-               return -ENODEV;
+       rc = check_dev(dev);
+       if (rc < 0)
+               return rc;
 
-       if (video_debug > 1)
-               v4l_print_ioctl(dev->name,cmd);
-
-       switch (cmd) {
-
-               /* --- capabilities ------------------------------------------ */
-       case VIDIOC_QUERYCAP:
-               {
-               struct v4l2_capability *cap = arg;
-
-               memset(cap, 0, sizeof(*cap));
-               strlcpy(cap->driver, "em28xx", sizeof(cap->driver));
-               strlcpy(cap->card, em28xx_boards[dev->model].name,
-                       sizeof(cap->card));
-               strlcpy(cap->bus_info, dev->udev->dev.bus_id,
-                       sizeof(cap->bus_info));
-               cap->version = EM28XX_VERSION_CODE;
-               cap->capabilities =
-                               V4L2_CAP_SLICED_VBI_CAPTURE |
-                               V4L2_CAP_VIDEO_CAPTURE |
-                               V4L2_CAP_AUDIO |
-                               V4L2_CAP_READWRITE | V4L2_CAP_STREAMING;
-               if (dev->has_tuner)
-                       cap->capabilities |= V4L2_CAP_TUNER;
-               return 0;
-       }
-       /* --- capture ioctls ---------------------------------------- */
-       case VIDIOC_ENUM_FMT:
-       {
-               struct v4l2_fmtdesc *fmtd = arg;
-
-               if (fmtd->index != 0)
-                       return -EINVAL;
-               memset(fmtd, 0, sizeof(*fmtd));
-               fmtd->type = V4L2_BUF_TYPE_VIDEO_CAPTURE;
-               strcpy(fmtd->description, "Packed YUY2");
-               fmtd->pixelformat = V4L2_PIX_FMT_YUYV;
-               memset(fmtd->reserved, 0, sizeof(fmtd->reserved));
-               return 0;
-       }
-       case VIDIOC_G_FMT:
-       {
-               int retval;
-               mutex_lock(&dev->lock);
-               retval = em28xx_get_fmt(dev, (struct v4l2_format *) arg);
-               mutex_unlock(&dev->lock);
-               return retval;
+       /* FIXME: read() is not prepared to allow changing the video
+          resolution while streaming. Seems a bug at em28xx_set_fmt
+        */
 
+       if (fh->type == V4L2_BUF_TYPE_VIDEO_CAPTURE) {
+               if (unlikely(res_get(fh)))
+                       return -EBUSY;
+
+               return videobuf_read_stream(&fh->vb_vidq, buf, count, pos, 0,
+                                       filp->f_flags & O_NONBLOCK);
        }
-       case VIDIOC_TRY_FMT:
-       case VIDIOC_S_FMT:
-       {
-               int retval;
-               mutex_lock(&dev->lock);
-               retval = em28xx_set_fmt(dev, cmd, (struct v4l2_format *)arg);
-               mutex_unlock(&dev->lock);
-               return retval;
-       }
+       return 0;
+}
 
-       case VIDIOC_REQBUFS:
-       {
-               struct v4l2_requestbuffers *rb = arg;
-               u32 i;
-               int ret;
-
-               if (rb->type != V4L2_BUF_TYPE_VIDEO_CAPTURE ||
-                       rb->memory != V4L2_MEMORY_MMAP)
-                       return -EINVAL;
-
-               if (dev->io == IO_READ) {
-                       em28xx_videodbg ("method is set to read;"
-                               " close and open the device again to"
-                               " choose the mmap I/O method\n");
-                       return -EINVAL;
-               }
+/*
+ * em28xx_v4l2_poll()
+ * will allocate buffers when called for the first time
+ */
+static unsigned int em28xx_v4l2_poll(struct file *filp, poll_table * wait)
+{
+       struct em28xx_fh *fh = filp->private_data;
+       struct em28xx *dev = fh->dev;
+       int rc;
 
-               for (i = 0; i < dev->num_frames; i++)
-                       if (dev->frame[i].vma_use_count) {
-                               em28xx_videodbg ("VIDIOC_REQBUFS failed; previous buffers are still mapped\n");
-                               return -EINVAL;
-                       }
+       rc = check_dev(dev);
+       if (rc < 0)
+               return rc;
 
-               mutex_lock(&dev->lock);
-               if (dev->stream == STREAM_ON) {
-                       em28xx_videodbg("VIDIOC_REQBUFS: interrupting stream\n");
-                       if ((ret = em28xx_stream_interrupt(dev))){
-                               mutex_unlock(&dev->lock);
-                               return ret;
-                       }
-               }
+       if (unlikely(res_get(fh) < 0))
+               return POLLERR;
+
+       if (V4L2_BUF_TYPE_VIDEO_CAPTURE != fh->type)
+               return POLLERR;
 
-               em28xx_empty_framequeues(dev);
+       return videobuf_poll_stream(filp, &fh->vb_vidq, wait);
+}
 
-               em28xx_release_buffers(dev);
-               if (rb->count)
-                       rb->count =
-                               em28xx_request_buffers(dev, rb->count);
+/*
+ * em28xx_v4l2_mmap()
+ */
+static int em28xx_v4l2_mmap(struct file *filp, struct vm_area_struct *vma)
+{
+       struct em28xx_fh *fh    = filp->private_data;
+       struct em28xx    *dev   = fh->dev;
+       int              rc;
 
-               dev->frame_current = NULL;
+       if (unlikely(res_get(fh) < 0))
+               return -EBUSY;
 
-               em28xx_videodbg ("VIDIOC_REQBUFS: setting io method to mmap: num bufs %i\n",
-                                               rb->count);
-               dev->io = rb->count ? IO_MMAP : IO_NONE;
-               mutex_unlock(&dev->lock);
-               return 0;
-       }
-       case VIDIOC_QUERYBUF:
-       {
-               struct v4l2_buffer *b = arg;
+       rc = check_dev(dev);
+       if (rc < 0)
+               return rc;
 
-               if (b->type != V4L2_BUF_TYPE_VIDEO_CAPTURE ||
-                       b->index >= dev->num_frames || dev->io != IO_MMAP)
-                       return -EINVAL;
+       rc = videobuf_mmap_mapper(&fh->vb_vidq, vma);
 
-               memcpy(b, &dev->frame[b->index].buf, sizeof(*b));
+       em28xx_videodbg("vma start=0x%08lx, size=%ld, ret=%d\n",
+               (unsigned long)vma->vm_start,
+               (unsigned long)vma->vm_end-(unsigned long)vma->vm_start,
+               rc);
 
-               if (dev->frame[b->index].vma_use_count) {
-                       b->flags |= V4L2_BUF_FLAG_MAPPED;
-               }
-               if (dev->frame[b->index].state == F_DONE)
-                       b->flags |= V4L2_BUF_FLAG_DONE;
-               else if (dev->frame[b->index].state != F_UNUSED)
-                       b->flags |= V4L2_BUF_FLAG_QUEUED;
-               return 0;
-       }
-       case VIDIOC_QBUF:
-       {
-               struct v4l2_buffer *b = arg;
-               unsigned long lock_flags;
+       return rc;
+}
 
-               if (b->type != V4L2_BUF_TYPE_VIDEO_CAPTURE ||
-                       b->index >= dev->num_frames || dev->io != IO_MMAP) {
-                       return -EINVAL;
-               }
+static const struct file_operations em28xx_v4l_fops = {
+       .owner         = THIS_MODULE,
+       .open          = em28xx_v4l2_open,
+       .release       = em28xx_v4l2_close,
+       .read          = em28xx_v4l2_read,
+       .poll          = em28xx_v4l2_poll,
+       .mmap          = em28xx_v4l2_mmap,
+       .ioctl         = video_ioctl2,
+       .llseek        = no_llseek,
+       .compat_ioctl  = v4l_compat_ioctl32,
+};
 
-               if (dev->frame[b->index].state != F_UNUSED) {
-                       return -EAGAIN;
-               }
-               dev->frame[b->index].state = F_QUEUED;
+static const struct v4l2_ioctl_ops video_ioctl_ops = {
+       .vidioc_querycap            = vidioc_querycap,
+       .vidioc_enum_fmt_vid_cap    = vidioc_enum_fmt_vid_cap,
+       .vidioc_g_fmt_vid_cap       = vidioc_g_fmt_vid_cap,
+       .vidioc_try_fmt_vid_cap     = vidioc_try_fmt_vid_cap,
+       .vidioc_s_fmt_vid_cap       = vidioc_s_fmt_vid_cap,
+       .vidioc_g_audio             = vidioc_g_audio,
+       .vidioc_s_audio             = vidioc_s_audio,
+       .vidioc_cropcap             = vidioc_cropcap,
+
+       .vidioc_g_fmt_sliced_vbi_cap   = vidioc_g_fmt_sliced_vbi_cap,
+       .vidioc_try_fmt_sliced_vbi_cap = vidioc_try_set_sliced_vbi_cap,
+       .vidioc_s_fmt_sliced_vbi_cap   = vidioc_try_set_sliced_vbi_cap,
+
+       .vidioc_reqbufs             = vidioc_reqbufs,
+       .vidioc_querybuf            = vidioc_querybuf,
+       .vidioc_qbuf                = vidioc_qbuf,
+       .vidioc_dqbuf               = vidioc_dqbuf,
+       .vidioc_s_std               = vidioc_s_std,
+       .vidioc_enum_input          = vidioc_enum_input,
+       .vidioc_g_input             = vidioc_g_input,
+       .vidioc_s_input             = vidioc_s_input,
+       .vidioc_queryctrl           = vidioc_queryctrl,
+       .vidioc_g_ctrl              = vidioc_g_ctrl,
+       .vidioc_s_ctrl              = vidioc_s_ctrl,
+       .vidioc_streamon            = vidioc_streamon,
+       .vidioc_streamoff           = vidioc_streamoff,
+       .vidioc_g_tuner             = vidioc_g_tuner,
+       .vidioc_s_tuner             = vidioc_s_tuner,
+       .vidioc_g_frequency         = vidioc_g_frequency,
+       .vidioc_s_frequency         = vidioc_s_frequency,
+#ifdef CONFIG_VIDEO_ADV_DEBUG
+       .vidioc_g_register          = vidioc_g_register,
+       .vidioc_s_register          = vidioc_s_register,
+#endif
+#ifdef CONFIG_VIDEO_V4L1_COMPAT
+       .vidiocgmbuf                = vidiocgmbuf,
+#endif
+};
 
-               /* add frame to fifo */
-               spin_lock_irqsave(&dev->queue_lock, lock_flags);
-               list_add_tail(&dev->frame[b->index].frame,
-                               &dev->inqueue);
-               spin_unlock_irqrestore(&dev->queue_lock, lock_flags);
+static const struct video_device em28xx_video_template = {
+       .fops                       = &em28xx_v4l_fops,
+       .release                    = video_device_release,
+       .ioctl_ops                  = &video_ioctl_ops,
 
-               return 0;
-       }
-       case VIDIOC_DQBUF:
-       {
-               struct v4l2_buffer *b = arg;
-               struct em28xx_frame_t *f;
-               unsigned long lock_flags;
-               int ret = 0;
-
-               if (b->type != V4L2_BUF_TYPE_VIDEO_CAPTURE
-                       || dev->io != IO_MMAP)
-                       return -EINVAL;
-
-               if (list_empty(&dev->outqueue)) {
-                       if (dev->stream == STREAM_OFF)
-                               return -EINVAL;
-                       if (filp->f_flags & O_NONBLOCK)
-                               return -EAGAIN;
-                       ret = wait_event_interruptible
-                               (dev->wait_frame,
-                               (!list_empty(&dev->outqueue)) ||
-                               (dev->state & DEV_DISCONNECTED));
-                       if (ret)
-                               return ret;
-                       if (dev->state & DEV_DISCONNECTED)
-                               return -ENODEV;
-               }
+       .minor                      = -1,
+
+       .tvnorms                    = V4L2_STD_ALL,
+       .current_norm               = V4L2_STD_PAL,
+};
 
-               spin_lock_irqsave(&dev->queue_lock, lock_flags);
-               f = list_entry(dev->outqueue.next,
-                               struct em28xx_frame_t, frame);
-               list_del(dev->outqueue.next);
-               spin_unlock_irqrestore(&dev->queue_lock, lock_flags);
+static const struct file_operations radio_fops = {
+       .owner         = THIS_MODULE,
+       .open          = em28xx_v4l2_open,
+       .release       = em28xx_v4l2_close,
+       .ioctl         = video_ioctl2,
+       .compat_ioctl  = v4l_compat_ioctl32,
+       .llseek        = no_llseek,
+};
 
-               f->state = F_UNUSED;
-               memcpy(b, &f->buf, sizeof(*b));
+static const struct v4l2_ioctl_ops radio_ioctl_ops = {
+       .vidioc_querycap      = radio_querycap,
+       .vidioc_g_tuner       = radio_g_tuner,
+       .vidioc_enum_input    = radio_enum_input,
+       .vidioc_g_audio       = radio_g_audio,
+       .vidioc_s_tuner       = radio_s_tuner,
+       .vidioc_s_audio       = radio_s_audio,
+       .vidioc_s_input       = radio_s_input,
+       .vidioc_queryctrl     = radio_queryctrl,
+       .vidioc_g_ctrl        = vidioc_g_ctrl,
+       .vidioc_s_ctrl        = vidioc_s_ctrl,
+       .vidioc_g_frequency   = vidioc_g_frequency,
+       .vidioc_s_frequency   = vidioc_s_frequency,
+#ifdef CONFIG_VIDEO_ADV_DEBUG
+       .vidioc_g_register    = vidioc_g_register,
+       .vidioc_s_register    = vidioc_s_register,
+#endif
+};
 
-               if (f->vma_use_count)
-                       b->flags |= V4L2_BUF_FLAG_MAPPED;
+static struct video_device em28xx_radio_template = {
+       .name                 = "em28xx-radio",
+       .type                 = VID_TYPE_TUNER,
+       .fops                 = &radio_fops,
+       .ioctl_ops            = &radio_ioctl_ops,
+       .minor                = -1,
+};
 
-               return 0;
-       }
-       default:
-               return em28xx_do_ioctl(inode, filp, dev, cmd, arg,
-                                      em28xx_video_do_ioctl);
+/******************************** usb interface ******************************/
+
+
+static LIST_HEAD(em28xx_extension_devlist);
+static DEFINE_MUTEX(em28xx_extension_devlist_lock);
+
+int em28xx_register_extension(struct em28xx_ops *ops)
+{
+       struct em28xx *dev = NULL;
+
+       mutex_lock(&em28xx_extension_devlist_lock);
+       list_add_tail(&ops->next, &em28xx_extension_devlist);
+       list_for_each_entry(dev, &em28xx_devlist, devlist) {
+               if (dev)
+                       ops->init(dev);
        }
+       printk(KERN_INFO "Em28xx: Initialized (%s) extension\n", ops->name);
+       mutex_unlock(&em28xx_extension_devlist_lock);
        return 0;
 }
+EXPORT_SYMBOL(em28xx_register_extension);
 
-/*
- * em28xx_v4l2_ioctl()
- * handle v4l2 ioctl the main action happens in em28xx_v4l2_do_ioctl()
- */
-static int em28xx_v4l2_ioctl(struct inode *inode, struct file *filp,
-                            unsigned int cmd, unsigned long arg)
+void em28xx_unregister_extension(struct em28xx_ops *ops)
 {
-       int ret = 0;
-       struct em28xx_fh *fh = filp->private_data;
-       struct em28xx *dev   = fh->dev;
-
-       if (dev->state & DEV_DISCONNECTED) {
-               em28xx_errdev("v4l2 ioctl: device not present\n");
-               return -ENODEV;
-       }
+       struct em28xx *dev = NULL;
 
-       if (dev->state & DEV_MISCONFIGURED) {
-               em28xx_errdev
-                   ("v4l2 ioctl: device is misconfigured; close and open it again\n");
-               return -EIO;
+       list_for_each_entry(dev, &em28xx_devlist, devlist) {
+               if (dev)
+                       ops->fini(dev);
        }
 
-       ret = video_usercopy(inode, filp, cmd, arg, em28xx_video_do_ioctl);
-
-       return ret;
+       mutex_lock(&em28xx_extension_devlist_lock);
+       printk(KERN_INFO "Em28xx: Removed (%s) extension\n", ops->name);
+       list_del(&ops->next);
+       mutex_unlock(&em28xx_extension_devlist_lock);
 }
+EXPORT_SYMBOL(em28xx_unregister_extension);
 
-static const struct file_operations em28xx_v4l_fops = {
-       .owner = THIS_MODULE,
-       .open = em28xx_v4l2_open,
-       .release = em28xx_v4l2_close,
-       .ioctl = em28xx_v4l2_ioctl,
-       .read = em28xx_v4l2_read,
-       .poll = em28xx_v4l2_poll,
-       .mmap = em28xx_v4l2_mmap,
-       .llseek = no_llseek,
-       .compat_ioctl   = v4l_compat_ioctl32,
-
-};
+static struct video_device *em28xx_vdev_init(struct em28xx *dev,
+                                            const struct video_device *template,
+                                            const int type,
+                                            const char *type_name)
+{
+       struct video_device *vfd;
+
+       vfd = video_device_alloc();
+       if (NULL == vfd)
+               return NULL;
+       *vfd = *template;
+       vfd->minor   = -1;
+       vfd->parent = &dev->udev->dev;
+       vfd->release = video_device_release;
+       vfd->type = type;
+       vfd->debug = video_debug;
+
+       snprintf(vfd->name, sizeof(vfd->name), "%s %s",
+                dev->name, type_name);
+
+       return vfd;
+}
 
-/******************************** usb interface *****************************************/
 
 /*
  * em28xx_init_dev()
@@ -1564,14 +1920,15 @@ static const struct file_operations em28xx_v4l_fops = {
 static int em28xx_init_dev(struct em28xx **devhandle, struct usb_device *udev,
                           int minor)
 {
+       struct em28xx_ops *ops = NULL;
        struct em28xx *dev = *devhandle;
        int retval = -ENOMEM;
-       int errCode, i;
+       int errCode;
        unsigned int maxh, maxw;
 
        dev->udev = udev;
        mutex_init(&dev->lock);
-       spin_lock_init(&dev->queue_lock);
+       spin_lock_init(&dev->slock);
        init_waitqueue_head(&dev->open);
        init_waitqueue_head(&dev->wait_frame);
        init_waitqueue_head(&dev->wait_stream);
@@ -1583,16 +1940,6 @@ static int em28xx_init_dev(struct em28xx **devhandle, struct usb_device *udev,
        dev->em28xx_read_reg_req = em28xx_read_reg_req;
        dev->is_em2800 = em28xx_boards[dev->model].is_em2800;
 
-       /* setup video picture settings for saa7113h */
-       memset(&dev->vpic, 0, sizeof(dev->vpic));
-       dev->vpic.colour = 128 << 8;
-       dev->vpic.hue = 128 << 8;
-       dev->vpic.brightness = 128 << 8;
-       dev->vpic.contrast = 192 << 8;
-       dev->vpic.whiteness = 128 << 8; /* This one isn't used */
-       dev->vpic.depth = 16;
-       dev->vpic.palette = VIDEO_PALETTE_YUV422;
-
        em28xx_pre_card_setup(dev);
 
        errCode = em28xx_config(dev);
@@ -1609,18 +1956,14 @@ static int em28xx_init_dev(struct em28xx **devhandle, struct usb_device *udev,
        /* Do board specific init and eeprom reading */
        em28xx_card_setup(dev);
 
+       /* Configure audio */
+       em28xx_audio_analog_set(dev);
+
        /* configure the device */
        em28xx_config_i2c(dev);
 
-       for (i = 0; i < TVNORMS; i++)
-               if (em28xx_boards[dev->model].norm == tvnorms[i].mode)
-                       break;
-       if (i == TVNORMS)
-               i = 0;
-
-       dev->tvnorm = &tvnorms[i];      /* set default norm */
-
-       em28xx_videodbg("tvnorm=%s\n", dev->tvnorm->name);
+       /* set default norm */
+       dev->norm = em28xx_video_template.current_norm;
 
        maxw = norm_maxw(dev);
        maxh = norm_maxh(dev);
@@ -1629,55 +1972,64 @@ static int em28xx_init_dev(struct em28xx **devhandle, struct usb_device *udev,
        dev->width = maxw;
        dev->height = maxh;
        dev->interlaced = EM28XX_INTERLACED_DEFAULT;
-       dev->field_size = dev->width * dev->height;
-       dev->frame_size =
-           dev->interlaced ? dev->field_size << 1 : dev->field_size;
-       dev->bytesperline = dev->width * 2;
        dev->hscale = 0;
        dev->vscale = 0;
        dev->ctl_input = 2;
 
        errCode = em28xx_config(dev);
 
-       /* allocate and fill v4l2 device struct */
-       dev->vdev = video_device_alloc();
+       list_add_tail(&dev->devlist, &em28xx_devlist);
+
+       /* allocate and fill video video_device struct */
+       dev->vdev = em28xx_vdev_init(dev, &em28xx_video_template,
+                                         VID_TYPE_CAPTURE, "video");
        if (NULL == dev->vdev) {
                em28xx_errdev("cannot allocate video_device.\n");
-               em28xx_devused&=~(1<<dev->devno);
-               kfree(dev);
-               return -ENOMEM;
+               goto fail_unreg;
        }
+       if (dev->tuner_type != TUNER_ABSENT)
+               dev->vdev->type |= VID_TYPE_TUNER;
 
-       dev->vbi_dev = video_device_alloc();
-       if (NULL == dev->vbi_dev) {
-               em28xx_errdev("cannot allocate video_device.\n");
-               kfree(dev->vdev);
-               em28xx_devused&=~(1<<dev->devno);
-               kfree(dev);
-               return -ENOMEM;
+       /* register v4l2 video video_device */
+       retval = video_register_device(dev->vdev, VFL_TYPE_GRABBER,
+                                      video_nr[dev->devno]);
+       if (retval) {
+               em28xx_errdev("unable to register video device (error=%i).\n",
+                             retval);
+               goto fail_unreg;
        }
 
-       /* Fills VBI device info */
-       dev->vbi_dev->type = VFL_TYPE_VBI;
-       dev->vbi_dev->fops = &em28xx_v4l_fops;
-       dev->vbi_dev->minor = -1;
-       dev->vbi_dev->dev = &dev->udev->dev;
-       dev->vbi_dev->release = video_device_release;
-       snprintf(dev->vbi_dev->name, sizeof(dev->vbi_dev->name), "%s#%d %s",
-                                                        "em28xx",dev->devno,"vbi");
-
-       /* Fills CAPTURE device info */
-       dev->vdev->type = VID_TYPE_CAPTURE;
-       if (dev->has_tuner)
-               dev->vdev->type |= VID_TYPE_TUNER;
-       dev->vdev->fops = &em28xx_v4l_fops;
-       dev->vdev->minor = -1;
-       dev->vdev->dev = &dev->udev->dev;
-       dev->vdev->release = video_device_release;
-       snprintf(dev->vdev->name, sizeof(dev->vbi_dev->name), "%s#%d %s",
-                                                        "em28xx",dev->devno,"video");
+       /* Allocate and fill vbi video_device struct */
+       dev->vbi_dev = em28xx_vdev_init(dev, &em28xx_video_template,
+                                         VFL_TYPE_VBI, "vbi");
+       /* register v4l2 vbi video_device */
+       if (video_register_device(dev->vbi_dev, VFL_TYPE_VBI,
+                                       vbi_nr[dev->devno]) < 0) {
+               em28xx_errdev("unable to register vbi device\n");
+               retval = -ENODEV;
+               goto fail_unreg;
+       }
+
+       if (em28xx_boards[dev->model].radio.type == EM28XX_RADIO) {
+               dev->radio_dev = em28xx_vdev_init(dev, &em28xx_radio_template,
+                                       VFL_TYPE_RADIO, "radio");
+               if (NULL == dev->radio_dev) {
+                       em28xx_errdev("cannot allocate video_device.\n");
+                       goto fail_unreg;
+               }
+               retval = video_register_device(dev->radio_dev, VFL_TYPE_RADIO,
+                                           radio_nr[dev->devno]);
+               if (retval < 0) {
+                       em28xx_errdev("can't register radio device\n");
+                       goto fail_unreg;
+               }
+               em28xx_info("Registered radio device as /dev/radio%d\n",
+                           dev->radio_dev->minor & 0x1f);
+       }
 
-       list_add_tail(&dev->devlist,&em28xx_devlist);
+       /* init video dma queues */
+       INIT_LIST_HEAD(&dev->vidq.active);
+       INIT_LIST_HEAD(&dev->vidq.queued);
 
 
        if (dev->has_msp34xx) {
@@ -1686,43 +2038,55 @@ static int em28xx_init_dev(struct em28xx **devhandle, struct usb_device *udev,
                msleep(3);
                em28xx_write_regs_req(dev, 0x00, 0x08, "\xff", 1);
                msleep(3);
-
-       }
-       video_mux(dev, 0);
-
-       /* register v4l2 device */
-       if ((retval = video_register_device(dev->vdev, VFL_TYPE_GRABBER,
-                                        video_nr[dev->devno]))) {
-               em28xx_errdev("unable to register video device (error=%i).\n",
-                             retval);
-               mutex_unlock(&dev->lock);
-               list_del(&dev->devlist);
-               video_device_release(dev->vdev);
-               em28xx_devused&=~(1<<dev->devno);
-               kfree(dev);
-               return -ENODEV;
        }
 
-       if (video_register_device(dev->vbi_dev, VFL_TYPE_VBI,
-                                       vbi_nr[dev->devno]) < 0) {
-               printk("unable to register vbi device\n");
-               mutex_unlock(&dev->lock);
-               list_del(&dev->devlist);
-               video_device_release(dev->vbi_dev);
-               video_device_release(dev->vdev);
-               em28xx_devused&=~(1<<dev->devno);
-               kfree(dev);
-               return -ENODEV;
-       } else {
-               printk("registered VBI\n");
-       }
+       video_mux(dev, 0);
 
        em28xx_info("V4L2 device registered as /dev/video%d and /dev/vbi%d\n",
                                dev->vdev->minor-MINOR_VFL_TYPE_GRABBER_MIN,
                                dev->vbi_dev->minor-MINOR_VFL_TYPE_VBI_MIN);
 
+       mutex_lock(&em28xx_extension_devlist_lock);
+       if (!list_empty(&em28xx_extension_devlist)) {
+               list_for_each_entry(ops, &em28xx_extension_devlist, next) {
+                       if (ops->id)
+                               ops->init(dev);
+               }
+       }
+       mutex_unlock(&em28xx_extension_devlist_lock);
+
        return 0;
+
+fail_unreg:
+       em28xx_release_resources(dev);
+       mutex_unlock(&dev->lock);
+       kfree(dev);
+       return retval;
+}
+
+#if defined(CONFIG_MODULES) && defined(MODULE)
+static void request_module_async(struct work_struct *work)
+{
+       struct em28xx *dev = container_of(work,
+                            struct em28xx, request_module_wk);
+
+       if (dev->has_audio_class)
+               request_module("snd-usb-audio");
+       else
+               request_module("em28xx-alsa");
+
+       if (dev->has_dvb)
+               request_module("em28xx-dvb");
+}
+
+static void request_modules(struct em28xx *dev)
+{
+       INIT_WORK(&dev->request_module_wk, request_module_async);
+       schedule_work(&dev->request_module_wk);
 }
+#else
+#define request_modules(dev)
+#endif /* CONFIG_MODULES */
 
 /*
  * em28xx_usb_probe()
@@ -1742,22 +2106,24 @@ static int em28xx_usb_probe(struct usb_interface *interface,
        ifnum = interface->altsetting[0].desc.bInterfaceNumber;
 
        /* Check to see next free device and mark as used */
-       nr=find_first_zero_bit(&em28xx_devused,EM28XX_MAXBOARDS);
-       em28xx_devused|=1<<nr;
+       nr = find_first_zero_bit(&em28xx_devused, EM28XX_MAXBOARDS);
+       em28xx_devused |= 1<<nr;
 
        /* Don't register audio interfaces */
        if (interface->altsetting[0].desc.bInterfaceClass == USB_CLASS_AUDIO) {
                em28xx_err(DRIVER_NAME " audio device (%04x:%04x): interface %i, class %i\n",
-                               udev->descriptor.idVendor,udev->descriptor.idProduct,
+                               udev->descriptor.idVendor,
+                               udev->descriptor.idProduct,
                                ifnum,
                                interface->altsetting[0].desc.bInterfaceClass);
 
-               em28xx_devused&=~(1<<nr);
+               em28xx_devused &= ~(1<<nr);
                return -ENODEV;
        }
 
        em28xx_err(DRIVER_NAME " new video device (%04x:%04x): interface %i, class %i\n",
-                       udev->descriptor.idVendor,udev->descriptor.idProduct,
+                       udev->descriptor.idVendor,
+                       udev->descriptor.idProduct,
                        ifnum,
                        interface->altsetting[0].desc.bInterfaceClass);
 
@@ -1767,18 +2133,19 @@ static int em28xx_usb_probe(struct usb_interface *interface,
        if ((endpoint->bmAttributes & USB_ENDPOINT_XFERTYPE_MASK) !=
            USB_ENDPOINT_XFER_ISOC) {
                em28xx_err(DRIVER_NAME " probing error: endpoint is non-ISO endpoint!\n");
-               em28xx_devused&=~(1<<nr);
+               em28xx_devused &= ~(1<<nr);
                return -ENODEV;
        }
        if ((endpoint->bEndpointAddress & USB_ENDPOINT_DIR_MASK) == USB_DIR_OUT) {
                em28xx_err(DRIVER_NAME " probing error: endpoint is ISO OUT endpoint!\n");
-               em28xx_devused&=~(1<<nr);
+               em28xx_devused &= ~(1<<nr);
                return -ENODEV;
        }
 
        if (nr >= EM28XX_MAXBOARDS) {
-               printk (DRIVER_NAME ": Supports only %i em28xx boards.\n",EM28XX_MAXBOARDS);
-               em28xx_devused&=~(1<<nr);
+               printk(DRIVER_NAME ": Supports only %i em28xx boards.\n",
+                               EM28XX_MAXBOARDS);
+               em28xx_devused &= ~(1<<nr);
                return -ENOMEM;
        }
 
@@ -1786,25 +2153,38 @@ static int em28xx_usb_probe(struct usb_interface *interface,
        dev = kzalloc(sizeof(*dev), GFP_KERNEL);
        if (dev == NULL) {
                em28xx_err(DRIVER_NAME ": out of memory!\n");
-               em28xx_devused&=~(1<<nr);
+               em28xx_devused &= ~(1<<nr);
                return -ENOMEM;
        }
 
        snprintf(dev->name, 29, "em28xx #%d", nr);
        dev->devno = nr;
        dev->model = id->driver_info;
+       dev->alt   = -1;
+
+       /* Checks if audio is provided by some interface */
+       for (i = 0; i < udev->config->desc.bNumInterfaces; i++) {
+               uif = udev->config->interface[i];
+               if (uif->altsetting[0].desc.bInterfaceClass == USB_CLASS_AUDIO) {
+                       dev->has_audio_class = 1;
+                       break;
+               }
+       }
+
+       printk(KERN_INFO DRIVER_NAME " %s usb audio class\n",
+                  dev->has_audio_class ? "Has" : "Doesn't have");
 
        /* compute alternate max packet sizes */
        uif = udev->actconfig->interface[0];
 
-       dev->num_alt=uif->num_altsetting;
-       em28xx_info("Alternate settings: %i\n",dev->num_alt);
-//     dev->alt_max_pkt_size = kmalloc(sizeof(*dev->alt_max_pkt_size)*
-       dev->alt_max_pkt_size = kmalloc(32*
-                                               dev->num_alt,GFP_KERNEL);
+       dev->num_alt = uif->num_altsetting;
+       em28xx_info("Alternate settings: %i\n", dev->num_alt);
+/*     dev->alt_max_pkt_size = kmalloc(sizeof(*dev->alt_max_pkt_size)* */
+       dev->alt_max_pkt_size = kmalloc(32 * dev->num_alt, GFP_KERNEL);
+
        if (dev->alt_max_pkt_size == NULL) {
                em28xx_errdev("out of memory!\n");
-               em28xx_devused&=~(1<<nr);
+               em28xx_devused &= ~(1<<nr);
                kfree(dev);
                return -ENOMEM;
        }
@@ -1814,11 +2194,11 @@ static int em28xx_usb_probe(struct usb_interface *interface,
                                                        wMaxPacketSize);
                dev->alt_max_pkt_size[i] =
                    (tmp & 0x07ff) * (((tmp & 0x1800) >> 11) + 1);
-               em28xx_info("Alternate setting %i, max size= %i\n",i,
-                                                       dev->alt_max_pkt_size[i]);
+               em28xx_info("Alternate setting %i, max size= %i\n", i,
+                                               dev->alt_max_pkt_size[i]);
        }
 
-       if ((card[nr]>=0)&&(card[nr]<em28xx_bcount))
+       if ((card[nr] >= 0) && (card[nr] < em28xx_bcount))
                dev->model = card[nr];
 
        /* allocate device struct */
@@ -1830,6 +2210,9 @@ static int em28xx_usb_probe(struct usb_interface *interface,
 
        /* save our data pointer in this interface device */
        usb_set_intfdata(interface, dev);
+
+       request_modules(dev);
+
        return 0;
 }
 
@@ -1841,6 +2224,7 @@ static int em28xx_usb_probe(struct usb_interface *interface,
 static void em28xx_usb_disconnect(struct usb_interface *interface)
 {
        struct em28xx *dev;
+       struct em28xx_ops *ops = NULL;
 
        dev = usb_get_intfdata(interface);
        usb_set_intfdata(interface, NULL);
@@ -1850,7 +2234,8 @@ static void em28xx_usb_disconnect(struct usb_interface *interface)
 
        em28xx_info("disconnecting %s\n", dev->vdev->name);
 
-       /* wait until all current v4l2 io is finished then deallocate resources */
+       /* wait until all current v4l2 io is finished then deallocate
+          resources */
        mutex_lock(&dev->lock);
 
        wake_up_interruptible_all(&dev->open);
@@ -1870,15 +2255,20 @@ static void em28xx_usb_disconnect(struct usb_interface *interface)
                dev->state |= DEV_DISCONNECTED;
                em28xx_release_resources(dev);
        }
-
-
        mutex_unlock(&dev->lock);
 
+       mutex_lock(&em28xx_extension_devlist_lock);
+       if (!list_empty(&em28xx_extension_devlist)) {
+               list_for_each_entry(ops, &em28xx_extension_devlist, next) {
+                       ops->fini(dev);
+               }
+       }
+       mutex_unlock(&em28xx_extension_devlist_lock);
+
        if (!dev->users) {
                kfree(dev->alt_max_pkt_size);
                kfree(dev);
        }
-
 }
 
 static struct usb_driver em28xx_usb_driver = {