V4L/DVB (10805): Add support for NetUP Dual DVB-S2 CI card
[safe/jmp/linux-2.6] / drivers / media / video / cx23885 / cx23885-core.c
index a602ac8..1b40145 100644 (file)
@@ -1,7 +1,7 @@
 /*
  *  Driver for the Conexant CX23885 PCIe bridge
  *
- *  Copyright (c) 2006 Steven Toth <stoth@hauppauge.com>
+ *  Copyright (c) 2006 Steven Toth <stoth@linuxtv.org>
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License as published by
 #include <asm/div64.h>
 
 #include "cx23885.h"
+#include "cimax2.h"
 
 MODULE_DESCRIPTION("Driver for cx23885 based TV cards");
-MODULE_AUTHOR("Steven Toth <stoth@hauppauge.com>");
+MODULE_AUTHOR("Steven Toth <stoth@linuxtv.org>");
 MODULE_LICENSE("GPL");
 
-static unsigned int debug = 0;
-module_param(debug,int,0644);
-MODULE_PARM_DESC(debug,"enable debug messages");
+static unsigned int debug;
+module_param(debug, int, 0644);
+MODULE_PARM_DESC(debug, "enable debug messages");
 
 static unsigned int card[]  = {[0 ... (CX23885_MAXBOARDS - 1)] = UNSET };
 module_param_array(card,  int, NULL, 0444);
-MODULE_PARM_DESC(card,"card type");
+MODULE_PARM_DESC(card, "card type");
 
-#define dprintk(level,fmt, arg...)     if (debug >= level) \
-       printk(KERN_DEBUG "%s/0: " fmt, dev->name , ## arg)
+#define dprintk(level, fmt, arg...)\
+       do { if (debug >= level)\
+               printk(KERN_DEBUG "%s/0: " fmt, dev->name, ## arg);\
+       } while (0)
 
 static unsigned int cx23885_devcount;
 
 static DEFINE_MUTEX(devlist);
-static LIST_HEAD(cx23885_devlist);
+LIST_HEAD(cx23885_devlist);
 
 #define NO_SYNC_LINE (-1U)
 
-/*
- * CX23885 Assumptions
+/* FIXME, these allocations will change when
+ * analog arrives. The be reviewed.
+ * CX23887 Assumptions
  * 1 line = 16 bytes of CDT
  * cmds size = 80
  * cdt size = 16 * linesize
@@ -75,17 +79,16 @@ static LIST_HEAD(cx23885_devlist);
 
 static struct sram_channel cx23885_sram_channels[] = {
        [SRAM_CH01] = {
-               .name           = "test ch1",
+               .name           = "VID A",
                .cmds_start     = 0x10000,
-               .ctrl_start     = 0x10500,
-               .cdt            = 0x10900,
-               .fifo_start     = 0x3000,
-               .fifo_size      = 0x1000,
+               .ctrl_start     = 0x10380,
+               .cdt            = 0x104c0,
+               .fifo_start     = 0x40,
+               .fifo_size      = 0x2800,
                .ptr1_reg       = DMA1_PTR1,
                .ptr2_reg       = DMA1_PTR2,
                .cnt1_reg       = DMA1_CNT1,
                .cnt2_reg       = DMA1_CNT2,
-               .jumponly       = 1,
        },
        [SRAM_CH02] = {
                .name           = "ch2",
@@ -102,8 +105,8 @@ static struct sram_channel cx23885_sram_channels[] = {
        [SRAM_CH03] = {
                .name           = "TS1 B",
                .cmds_start     = 0x100A0,
-               .ctrl_start     = 0x10780,
-               .cdt            = 0x10400,
+               .ctrl_start     = 0x10400,
+               .cdt            = 0x10580,
                .fifo_start     = 0x5000,
                .fifo_size      = 0x1000,
                .ptr1_reg       = DMA3_PTR1,
@@ -138,8 +141,8 @@ static struct sram_channel cx23885_sram_channels[] = {
        [SRAM_CH06] = {
                .name           = "TS2 C",
                .cmds_start     = 0x10140,
-               .ctrl_start     = 0x10680,
-               .cdt            = 0x10480,
+               .ctrl_start     = 0x10440,
+               .cdt            = 0x105e0,
                .fifo_start     = 0x6000,
                .fifo_size      = 0x1000,
                .ptr1_reg       = DMA5_PTR1,
@@ -185,34 +188,14 @@ static struct sram_channel cx23885_sram_channels[] = {
        },
 };
 
-/* FIXME, these allocations will change when
- * analog arrives. The be reviewed.
- * CX23887 Assumptions
- * 1 line = 16 bytes of CDT
- * cmds size = 80
- * cdt size = 16 * linesize
- * iqsize = 64
- * maxlines = 6
- *
- * Address Space:
- * 0x00000000 0x00008fff FIFO clusters
- * 0x00010000 0x000104af Channel Management Data Structures
- * 0x000104b0 0x000104ff Free
- * 0x00010500 0x000108bf 15 channels * iqsize
- * 0x000108c0 0x000108ff Free
- * 0x00010900 0x00010e9f IQ's + Cluster Descriptor Tables
- *                       15 channels * (iqsize + (maxlines * linesize))
- * 0x00010ea0 0x00010xxx Free
- */
-
 static struct sram_channel cx23887_sram_channels[] = {
        [SRAM_CH01] = {
-               .name           = "test ch1",
-               .cmds_start     = 0x0,
-               .ctrl_start     = 0x0,
-               .cdt            = 0x0,
-               .fifo_start     = 0x0,
-               .fifo_size      = 0x0,
+               .name           = "VID A",
+               .cmds_start     = 0x10000,
+               .ctrl_start     = 0x105b0,
+               .cdt            = 0x107b0,
+               .fifo_start     = 0x40,
+               .fifo_size      = 0x2800,
                .ptr1_reg       = DMA1_PTR1,
                .ptr2_reg       = DMA1_PTR2,
                .cnt1_reg       = DMA1_CNT1,
@@ -231,12 +214,12 @@ static struct sram_channel cx23887_sram_channels[] = {
                .cnt2_reg       = DMA2_CNT2,
        },
        [SRAM_CH03] = {
-               .name           = "ch3",
-               .cmds_start     = 0x0,
-               .ctrl_start     = 0x0,
-               .cdt            = 0x0,
-               .fifo_start     = 0x0,
-               .fifo_size      = 0x0,
+               .name           = "TS1 B",
+               .cmds_start     = 0x100A0,
+               .ctrl_start     = 0x10630,
+               .cdt            = 0x10870,
+               .fifo_start     = 0x5000,
+               .fifo_size      = 0x1000,
                .ptr1_reg       = DMA3_PTR1,
                .ptr2_reg       = DMA3_PTR2,
                .cnt1_reg       = DMA3_CNT1,
@@ -269,7 +252,7 @@ static struct sram_channel cx23887_sram_channels[] = {
        [SRAM_CH06] = {
                .name           = "TS2 C",
                .cmds_start     = 0x10140,
-               .ctrl_start     = 0x10680,
+               .ctrl_start     = 0x10670,
                .cdt            = 0x108d0,
                .fifo_start     = 0x6000,
                .fifo_size      = 0x1000,
@@ -319,25 +302,25 @@ static struct sram_channel cx23887_sram_channels[] = {
 static int cx23885_risc_decode(u32 risc)
 {
        static char *instr[16] = {
-               [ RISC_SYNC    >> 28 ] = "sync",
-               [ RISC_WRITE   >> 28 ] = "write",
-               [ RISC_WRITEC  >> 28 ] = "writec",
-               [ RISC_READ    >> 28 ] = "read",
-               [ RISC_READC   >> 28 ] = "readc",
-               [ RISC_JUMP    >> 28 ] = "jump",
-               [ RISC_SKIP    >> 28 ] = "skip",
-               [ RISC_WRITERM >> 28 ] = "writerm",
-               [ RISC_WRITECM >> 28 ] = "writecm",
-               [ RISC_WRITECR >> 28 ] = "writecr",
+               [RISC_SYNC    >> 28] = "sync",
+               [RISC_WRITE   >> 28] = "write",
+               [RISC_WRITEC  >> 28] = "writec",
+               [RISC_READ    >> 28] = "read",
+               [RISC_READC   >> 28] = "readc",
+               [RISC_JUMP    >> 28] = "jump",
+               [RISC_SKIP    >> 28] = "skip",
+               [RISC_WRITERM >> 28] = "writerm",
+               [RISC_WRITECM >> 28] = "writecm",
+               [RISC_WRITECR >> 28] = "writecr",
        };
        static int incr[16] = {
-               [ RISC_WRITE   >> 28 ] = 3,
-               [ RISC_JUMP    >> 28 ] = 3,
-               [ RISC_SKIP    >> 28 ] = 1,
-               [ RISC_SYNC    >> 28 ] = 1,
-               [ RISC_WRITERM >> 28 ] = 3,
-               [ RISC_WRITECM >> 28 ] = 3,
-               [ RISC_WRITECR >> 28 ] = 4,
+               [RISC_WRITE   >> 28] = 3,
+               [RISC_JUMP    >> 28] = 3,
+               [RISC_SKIP    >> 28] = 1,
+               [RISC_SYNC    >> 28] = 1,
+               [RISC_WRITERM >> 28] = 3,
+               [RISC_WRITECM >> 28] = 3,
+               [RISC_WRITECR >> 28] = 4,
        };
        static char *bits[] = {
                "12",   "13",   "14",   "resync",
@@ -356,7 +339,7 @@ static int cx23885_risc_decode(u32 risc)
        return incr[risc >> 28] ? incr[risc >> 28] : 1;
 }
 
-static void cx23885_wakeup(struct cx23885_tsport *port,
+void cx23885_wakeup(struct cx23885_tsport *port,
                           struct cx23885_dmaqueue *q, u32 count)
 {
        struct cx23885_dev *dev = port->dev;
@@ -382,26 +365,24 @@ static void cx23885_wakeup(struct cx23885_tsport *port,
                list_del(&buf->vb.queue);
                wake_up(&buf->vb.done);
        }
-       if (list_empty(&q->active)) {
+       if (list_empty(&q->active))
                del_timer(&q->timeout);
-       } else {
+       else
                mod_timer(&q->timeout, jiffies + BUFFER_TIMEOUT);
-       }
        if (bc != 1)
-               printk("%s: %d buffers handled (should be 1)\n",
-                      __FUNCTION__, bc);
+               printk(KERN_WARNING "%s: %d buffers handled (should be 1)\n",
+                      __func__, bc);
 }
 
-static int cx23885_sram_channel_setup(struct cx23885_dev *dev,
+int cx23885_sram_channel_setup(struct cx23885_dev *dev,
                                      struct sram_channel *ch,
                                      unsigned int bpl, u32 risc)
 {
        unsigned int i, lines;
        u32 cdt;
 
-       if (ch->cmds_start == 0)
-       {
-               dprintk(1, "%s() Erasing channel [%s]\n", __FUNCTION__,
+       if (ch->cmds_start == 0) {
+               dprintk(1, "%s() Erasing channel [%s]\n", __func__,
                        ch->name);
                cx_write(ch->ptr1_reg, 0);
                cx_write(ch->ptr2_reg, 0);
@@ -409,7 +390,7 @@ static int cx23885_sram_channel_setup(struct cx23885_dev *dev,
                cx_write(ch->cnt1_reg, 0);
                return 0;
        } else {
-               dprintk(1, "%s() Configuring channel [%s]\n", __FUNCTION__,
+               dprintk(1, "%s() Configuring channel [%s]\n", __func__,
                        ch->name);
        }
 
@@ -420,13 +401,13 @@ static int cx23885_sram_channel_setup(struct cx23885_dev *dev,
                lines = 6;
        BUG_ON(lines < 2);
 
-       cx_write(8 + 0, cpu_to_le32(RISC_JUMP | RISC_IRQ1 | RISC_CNT_INC) );
-       cx_write(8 + 4, cpu_to_le32(8) );
-       cx_write(8 + 8, cpu_to_le32(0) );
+       cx_write(8 + 0, RISC_JUMP | RISC_IRQ1 | RISC_CNT_INC);
+       cx_write(8 + 4, 8);
+       cx_write(8 + 8, 0);
 
        /* write CDT */
        for (i = 0; i < lines; i++) {
-               dprintk(2, "%s() 0x%08x <- 0x%08x\n", __FUNCTION__, cdt + 16*i,
+               dprintk(2, "%s() 0x%08x <- 0x%08x\n", __func__, cdt + 16*i,
                        ch->fifo_start + bpl*i);
                cx_write(cdt + 16*i, ch->fifo_start + bpl*i);
                cx_write(cdt + 16*i +  4, 0);
@@ -436,15 +417,15 @@ static int cx23885_sram_channel_setup(struct cx23885_dev *dev,
 
        /* write CMDS */
        if (ch->jumponly)
-               cx_write(ch->cmds_start +  0, 8);
+               cx_write(ch->cmds_start + 0, 8);
        else
-               cx_write(ch->cmds_start +  0, risc);
+               cx_write(ch->cmds_start + 0, risc);
        cx_write(ch->cmds_start +  4, 0); /* 64 bits 63-32 */
        cx_write(ch->cmds_start +  8, cdt);
        cx_write(ch->cmds_start + 12, (lines*16) >> 3);
        cx_write(ch->cmds_start + 16, ch->ctrl_start);
        if (ch->jumponly)
-               cx_write(ch->cmds_start + 20, 0x80000000 | (64 >> 2) );
+               cx_write(ch->cmds_start + 20, 0x80000000 | (64 >> 2));
        else
                cx_write(ch->cmds_start + 20, 64 >> 2);
        for (i = 24; i < 80; i += 4)
@@ -454,9 +435,9 @@ static int cx23885_sram_channel_setup(struct cx23885_dev *dev,
        cx_write(ch->ptr1_reg, ch->fifo_start);
        cx_write(ch->ptr2_reg, cdt);
        cx_write(ch->cnt2_reg, (lines*16) >> 3);
-       cx_write(ch->cnt1_reg, (bpl >> 3) -1);
+       cx_write(ch->cnt1_reg, (bpl >> 3) - 1);
 
-       dprintk(2,"[bridge %d] sram setup %s: bpl=%d lines=%d\n",
+       dprintk(2, "[bridge %d] sram setup %s: bpl=%d lines=%d\n",
                dev->bridge,
                ch->name,
                bpl,
@@ -465,7 +446,7 @@ static int cx23885_sram_channel_setup(struct cx23885_dev *dev,
        return 0;
 }
 
-static void cx23885_sram_channel_dump(struct cx23885_dev *dev,
+void cx23885_sram_channel_dump(struct cx23885_dev *dev,
                                      struct sram_channel *ch)
 {
        static char *name[] = {
@@ -487,43 +468,43 @@ static void cx23885_sram_channel_dump(struct cx23885_dev *dev,
        u32 risc;
        unsigned int i, j, n;
 
-       printk("%s: %s - dma channel status dump\n",
+       printk(KERN_WARNING "%s: %s - dma channel status dump\n",
               dev->name, ch->name);
        for (i = 0; i < ARRAY_SIZE(name); i++)
-               printk("%s:   cmds: %-15s: 0x%08x\n",
+               printk(KERN_WARNING "%s:   cmds: %-15s: 0x%08x\n",
                       dev->name, name[i],
                       cx_read(ch->cmds_start + 4*i));
 
        for (i = 0; i < 4; i++) {
                risc = cx_read(ch->cmds_start + 4 * (i + 14));
-               printk("%s:   risc%d: ", dev->name, i);
+               printk(KERN_WARNING "%s:   risc%d: ", dev->name, i);
                cx23885_risc_decode(risc);
        }
        for (i = 0; i < (64 >> 2); i += n) {
                risc = cx_read(ch->ctrl_start + 4 * i);
                /* No consideration for bits 63-32 */
 
-               printk("%s:   (0x%08x) iq %x: ", dev->name,
+               printk(KERN_WARNING "%s:   (0x%08x) iq %x: ", dev->name,
                       ch->ctrl_start + 4 * i, i);
                n = cx23885_risc_decode(risc);
                for (j = 1; j < n; j++) {
                        risc = cx_read(ch->ctrl_start + 4 * (i + j));
-                       printk("%s:   iq %x: 0x%08x [ arg #%d ]\n",
+                       printk(KERN_WARNING "%s:   iq %x: 0x%08x [ arg #%d ]\n",
                               dev->name, i+j, risc, j);
                }
        }
 
-       printk("%s: fifo: 0x%08x -> 0x%x\n",
+       printk(KERN_WARNING "%s: fifo: 0x%08x -> 0x%x\n",
               dev->name, ch->fifo_start, ch->fifo_start+ch->fifo_size);
-       printk("%s: ctrl: 0x%08x -> 0x%x\n",
+       printk(KERN_WARNING "%s: ctrl: 0x%08x -> 0x%x\n",
               dev->name, ch->ctrl_start, ch->ctrl_start + 6*16);
-       printk("%s:   ptr1_reg: 0x%08x\n",
+       printk(KERN_WARNING "%s:   ptr1_reg: 0x%08x\n",
               dev->name, cx_read(ch->ptr1_reg));
-       printk("%s:   ptr2_reg: 0x%08x\n",
+       printk(KERN_WARNING "%s:   ptr2_reg: 0x%08x\n",
               dev->name, cx_read(ch->ptr2_reg));
-       printk("%s:   cnt1_reg: 0x%08x\n",
+       printk(KERN_WARNING "%s:   cnt1_reg: 0x%08x\n",
               dev->name, cx_read(ch->cnt1_reg));
-       printk("%s:   cnt2_reg: 0x%08x\n",
+       printk(KERN_WARNING "%s:   cnt2_reg: 0x%08x\n",
               dev->name, cx_read(ch->cnt2_reg));
 }
 
@@ -533,15 +514,15 @@ static void cx23885_risc_disasm(struct cx23885_tsport *port,
        struct cx23885_dev *dev = port->dev;
        unsigned int i, j, n;
 
-       printk("%s: risc disasm: %p [dma=0x%08lx]\n",
+       printk(KERN_INFO "%s: risc disasm: %p [dma=0x%08lx]\n",
               dev->name, risc->cpu, (unsigned long)risc->dma);
        for (i = 0; i < (risc->size >> 2); i += n) {
-               printk("%s:   %04d: ", dev->name, i);
-               n = cx23885_risc_decode(risc->cpu[i]);
+               printk(KERN_INFO "%s:   %04d: ", dev->name, i);
+               n = cx23885_risc_decode(le32_to_cpu(risc->cpu[i]));
                for (j = 1; j < n; j++)
-                       printk("%s:   %04d: 0x%08x [ arg #%d ]\n",
+                       printk(KERN_INFO "%s:   %04d: 0x%08x [ arg #%d ]\n",
                               dev->name, i + j, risc->cpu[i + j], j);
-               if (risc->cpu[i] == RISC_JUMP)
+               if (risc->cpu[i] == cpu_to_le32(RISC_JUMP))
                        break;
        }
 }
@@ -578,7 +559,7 @@ static void cx23885_shutdown(struct cx23885_dev *dev)
 
 static void cx23885_reset(struct cx23885_dev *dev)
 {
-       dprintk(1, "%s()\n", __FUNCTION__);
+       dprintk(1, "%s()\n", __func__);
 
        cx23885_shutdown(dev);
 
@@ -589,18 +570,22 @@ static void cx23885_reset(struct cx23885_dev *dev)
        cx_write(AUDIO_INT_INT_STAT, 0xffffffff);
        cx_write(AUDIO_EXT_INT_STAT, 0xffffffff);
        cx_write(CLK_DELAY, cx_read(CLK_DELAY) & 0x80000000);
+       cx_write(PAD_CTRL, 0x00500300);
 
        mdelay(100);
 
-       cx23885_sram_channel_setup(dev, &dev->sram_channels[ SRAM_CH01 ], 188*4, 0);
-       cx23885_sram_channel_setup(dev, &dev->sram_channels[ SRAM_CH02 ], 128, 0);
-       cx23885_sram_channel_setup(dev, &dev->sram_channels[ SRAM_CH03 ], 188*4, 0);
-       cx23885_sram_channel_setup(dev, &dev->sram_channels[ SRAM_CH04 ], 128, 0);
-       cx23885_sram_channel_setup(dev, &dev->sram_channels[ SRAM_CH05 ], 128, 0);
-       cx23885_sram_channel_setup(dev, &dev->sram_channels[ SRAM_CH06 ], 188*4, 0);
-       cx23885_sram_channel_setup(dev, &dev->sram_channels[ SRAM_CH07 ], 128, 0);
-       cx23885_sram_channel_setup(dev, &dev->sram_channels[ SRAM_CH08 ], 128, 0);
-       cx23885_sram_channel_setup(dev, &dev->sram_channels[ SRAM_CH09 ], 128, 0);
+       cx23885_sram_channel_setup(dev, &dev->sram_channels[SRAM_CH01],
+               720*4, 0);
+       cx23885_sram_channel_setup(dev, &dev->sram_channels[SRAM_CH02], 128, 0);
+       cx23885_sram_channel_setup(dev, &dev->sram_channels[SRAM_CH03],
+               188*4, 0);
+       cx23885_sram_channel_setup(dev, &dev->sram_channels[SRAM_CH04], 128, 0);
+       cx23885_sram_channel_setup(dev, &dev->sram_channels[SRAM_CH05], 128, 0);
+       cx23885_sram_channel_setup(dev, &dev->sram_channels[SRAM_CH06],
+               188*4, 0);
+       cx23885_sram_channel_setup(dev, &dev->sram_channels[SRAM_CH07], 128, 0);
+       cx23885_sram_channel_setup(dev, &dev->sram_channels[SRAM_CH08], 128, 0);
+       cx23885_sram_channel_setup(dev, &dev->sram_channels[SRAM_CH09], 128, 0);
 
        cx23885_gpio_setup(dev);
 }
@@ -608,13 +593,13 @@ static void cx23885_reset(struct cx23885_dev *dev)
 
 static int cx23885_pci_quirks(struct cx23885_dev *dev)
 {
-       dprintk(1, "%s()\n", __FUNCTION__);
+       dprintk(1, "%s()\n", __func__);
 
        /* The cx23885 bridge has a weird bug which causes NMI to be asserted
         * when DMA begins if RDR_TLCTL0 bit4 is not cleared. It does not
         * occur on the cx23887 bridge.
         */
-       if(dev->bridge == CX23885_BRIDGE_885)
+       if (dev->bridge == CX23885_BRIDGE_885)
                cx_clear(RDR_TLCTL0, 1 << 4);
 
        return 0;
@@ -622,28 +607,31 @@ static int cx23885_pci_quirks(struct cx23885_dev *dev)
 
 static int get_resources(struct cx23885_dev *dev)
 {
-       if (request_mem_region(pci_resource_start(dev->pci,0),
-                              pci_resource_len(dev->pci,0),
+       if (request_mem_region(pci_resource_start(dev->pci, 0),
+                              pci_resource_len(dev->pci, 0),
                               dev->name))
                return 0;
 
        printk(KERN_ERR "%s: can't get MMIO memory @ 0x%llx\n",
-               dev->name, (unsigned long long)pci_resource_start(dev->pci,0));
+               dev->name, (unsigned long long)pci_resource_start(dev->pci, 0));
 
        return -EBUSY;
 }
 
 static void cx23885_timeout(unsigned long data);
-static int cx23885_risc_stopper(struct pci_dev *pci, struct btcx_riscmem *risc,
+int cx23885_risc_stopper(struct pci_dev *pci, struct btcx_riscmem *risc,
                                u32 reg, u32 mask, u32 value);
 
-static int cx23885_init_tsport(struct cx23885_dev *dev, struct cx23885_tsport *port, int portno)
+static int cx23885_init_tsport(struct cx23885_dev *dev,
+       struct cx23885_tsport *port, int portno)
 {
-       dprintk(1, "%s(portno=%d)\n", __FUNCTION__, portno);
+       dprintk(1, "%s(portno=%d)\n", __func__, portno);
 
        /* Transport bus init dma queue  - Common settings */
        port->dma_ctl_val        = 0x11; /* Enable RISC controller and Fifo */
        port->ts_int_msk_val     = 0x1111; /* TS port bits for RISC */
+       port->vld_misc_val       = 0x0;
+       port->hw_sop_ctrl_val    = (0x47 << 16 | 188 << 4);
 
        spin_lock_init(&port->slock);
        port->dev = dev;
@@ -655,7 +643,18 @@ static int cx23885_init_tsport(struct cx23885_dev *dev, struct cx23885_tsport *p
        port->mpegq.timeout.data = (unsigned long)port;
        init_timer(&port->mpegq.timeout);
 
-       switch(portno) {
+       mutex_init(&port->frontends.lock);
+       INIT_LIST_HEAD(&port->frontends.felist);
+       port->frontends.active_fe_id = 0;
+
+       /* This should be hardcoded allow a single frontend
+        * attachment to this tsport, keeping the -dvb.c
+        * code clean and safe.
+        */
+       if (!port->num_frontends)
+               port->num_frontends = 1;
+
+       switch (portno) {
        case 1:
                port->reg_gpcnt          = VID_B_GPCNT;
                port->reg_gpcnt_ctl      = VID_B_GPCNT_CTL;
@@ -670,7 +669,7 @@ static int cx23885_init_tsport(struct cx23885_dev *dev, struct cx23885_tsport *p
                port->reg_ts_clk_en      = VID_B_TS_CLK_EN;
                port->reg_src_sel        = VID_B_SRC_SEL;
                port->reg_ts_int_msk     = VID_B_INT_MSK;
-               port->reg_ts_int_stat   = VID_B_INT_STAT;
+               port->reg_ts_int_stat    = VID_B_INT_STAT;
                port->sram_chno          = SRAM_CH03; /* VID_B */
                port->pci_irqmask        = 0x02; /* VID_B bit1 */
                break;
@@ -730,14 +729,14 @@ static void cx23885_dev_checkrevision(struct cx23885_dev *dev)
                break;
        default:
                printk(KERN_ERR "%s() New hardware revision found 0x%x\n",
-                       __FUNCTION__, dev->hwrevision);
+                       __func__, dev->hwrevision);
        }
        if (dev->hwrevision)
                printk(KERN_INFO "%s() Hardware revision = 0x%02x\n",
-                       __FUNCTION__, dev->hwrevision);
+                       __func__, dev->hwrevision);
        else
                printk(KERN_ERR "%s() Hardware revision unknown 0x%x\n",
-                       __FUNCTION__, dev->hwrevision);
+                       __func__, dev->hwrevision);
 }
 
 static int cx23885_dev_setup(struct cx23885_dev *dev)
@@ -756,18 +755,22 @@ static int cx23885_dev_setup(struct cx23885_dev *dev)
        mutex_unlock(&devlist);
 
        /* Configure the internal memory */
-       if(dev->pci->device == 0x8880) {
+       if (dev->pci->device == 0x8880) {
                dev->bridge = CX23885_BRIDGE_887;
+               /* Apply a sensible clock frequency for the PCIe bridge */
+               dev->clk_freq = 25000000;
                dev->sram_channels = cx23887_sram_channels;
        } else
-       if(dev->pci->device == 0x8852) {
+       if (dev->pci->device == 0x8852) {
                dev->bridge = CX23885_BRIDGE_885;
+               /* Apply a sensible clock frequency for the PCIe bridge */
+               dev->clk_freq = 28000000;
                dev->sram_channels = cx23885_sram_channels;
        } else
                BUG();
 
        dprintk(1, "%s() Memory configured for PCIe bridge type %d\n",
-               __FUNCTION__, dev->bridge);
+               __func__, dev->bridge);
 
        /* board config */
        dev->board = UNSET;
@@ -782,9 +785,15 @@ static int cx23885_dev_setup(struct cx23885_dev *dev)
                cx23885_card_list(dev);
        }
 
+       /* If the user specific a clk freq override, apply it */
+       if (cx23885_boards[dev->board].clk_freq > 0)
+               dev->clk_freq = cx23885_boards[dev->board].clk_freq;
+
        dev->pci_bus  = dev->pci->bus->number;
        dev->pci_slot = PCI_SLOT(dev->pci->devfn);
        dev->pci_irqmask = 0x001f00;
+       if (cx23885_boards[dev->board].cimax > 0)
+               dev->pci_irqmask |= 0x01800000; /* for CiMaxes */
 
        /* External Master 1 Bus */
        dev->i2c_bus[0].nr = 0;
@@ -816,10 +825,12 @@ static int cx23885_dev_setup(struct cx23885_dev *dev)
        dev->i2c_bus[2].reg_wdata = I2C3_WDATA;
        dev->i2c_bus[2].i2c_period = (0x07 << 24); /* 1.95MHz */
 
-       if(cx23885_boards[dev->board].portb == CX23885_MPEG_DVB)
+       if ((cx23885_boards[dev->board].portb == CX23885_MPEG_DVB) ||
+               (cx23885_boards[dev->board].portb == CX23885_MPEG_ENCODER))
                cx23885_init_tsport(dev, &dev->ts1, 1);
 
-       if(cx23885_boards[dev->board].portc == CX23885_MPEG_DVB)
+       if ((cx23885_boards[dev->board].portc == CX23885_MPEG_DVB) ||
+               (cx23885_boards[dev->board].portc == CX23885_MPEG_ENCODER))
                cx23885_init_tsport(dev, &dev->ts2, 2);
 
        if (get_resources(dev) < 0) {
@@ -833,8 +844,8 @@ static int cx23885_dev_setup(struct cx23885_dev *dev)
        }
 
        /* PCIe stuff */
-       dev->lmmio = ioremap(pci_resource_start(dev->pci,0),
-                            pci_resource_len(dev->pci,0));
+       dev->lmmio = ioremap(pci_resource_start(dev->pci, 0),
+                            pci_resource_len(dev->pci, 0));
 
        dev->bmmio = (u8 __iomem *)dev->lmmio;
 
@@ -846,27 +857,60 @@ static int cx23885_dev_setup(struct cx23885_dev *dev)
 
        cx23885_pci_quirks(dev);
 
+       /* Assume some sensible defaults */
+       dev->tuner_type = cx23885_boards[dev->board].tuner_type;
+       dev->tuner_addr = cx23885_boards[dev->board].tuner_addr;
+       dev->radio_type = cx23885_boards[dev->board].radio_type;
+       dev->radio_addr = cx23885_boards[dev->board].radio_addr;
+
+       dprintk(1, "%s() tuner_type = 0x%x tuner_addr = 0x%x\n",
+               __func__, dev->tuner_type, dev->tuner_addr);
+       dprintk(1, "%s() radio_type = 0x%x radio_addr = 0x%x\n",
+               __func__, dev->radio_type, dev->radio_addr);
+
        /* init hardware */
        cx23885_reset(dev);
 
        cx23885_i2c_register(&dev->i2c_bus[0]);
        cx23885_i2c_register(&dev->i2c_bus[1]);
        cx23885_i2c_register(&dev->i2c_bus[2]);
-       cx23885_call_i2c_clients (&dev->i2c_bus[0], TUNER_SET_STANDBY, NULL);
        cx23885_card_setup(dev);
+       cx23885_call_i2c_clients(&dev->i2c_bus[0], TUNER_SET_STANDBY, NULL);
        cx23885_ir_init(dev);
 
-       if(cx23885_boards[dev->board].portb == CX23885_MPEG_DVB) {
+       if (cx23885_boards[dev->board].porta == CX23885_ANALOG_VIDEO) {
+               if (cx23885_video_register(dev) < 0) {
+                       printk(KERN_ERR "%s() Failed to register analog "
+                               "video adapters on VID_A\n", __func__);
+               }
+       }
+
+       if (cx23885_boards[dev->board].portb == CX23885_MPEG_DVB) {
                if (cx23885_dvb_register(&dev->ts1) < 0) {
                        printk(KERN_ERR "%s() Failed to register dvb adapters on VID_B\n",
-                              __FUNCTION__);
+                              __func__);
+               }
+       } else
+       if (cx23885_boards[dev->board].portb == CX23885_MPEG_ENCODER) {
+               if (cx23885_417_register(dev) < 0) {
+                       printk(KERN_ERR
+                               "%s() Failed to register 417 on VID_B\n",
+                              __func__);
                }
        }
 
-       if(cx23885_boards[dev->board].portc == CX23885_MPEG_DVB) {
+       if (cx23885_boards[dev->board].portc == CX23885_MPEG_DVB) {
                if (cx23885_dvb_register(&dev->ts2) < 0) {
-                       printk(KERN_ERR "%s() Failed to register dvb adapters on VID_C\n",
-                              __FUNCTION__);
+                       printk(KERN_ERR
+                               "%s() Failed to register dvb on VID_C\n",
+                              __func__);
+               }
+       } else
+       if (cx23885_boards[dev->board].portc == CX23885_MPEG_ENCODER) {
+               if (cx23885_417_register(dev) < 0) {
+                       printk(KERN_ERR
+                               "%s() Failed to register 417 on VID_C\n",
+                              __func__);
                }
        }
 
@@ -877,18 +921,27 @@ static int cx23885_dev_setup(struct cx23885_dev *dev)
 
 static void cx23885_dev_unregister(struct cx23885_dev *dev)
 {
-       release_mem_region(pci_resource_start(dev->pci,0),
-                          pci_resource_len(dev->pci,0));
+       release_mem_region(pci_resource_start(dev->pci, 0),
+                          pci_resource_len(dev->pci, 0));
 
        if (!atomic_dec_and_test(&dev->refcount))
                return;
 
-       if(cx23885_boards[dev->board].portb == CX23885_MPEG_DVB)
+       if (cx23885_boards[dev->board].porta == CX23885_ANALOG_VIDEO)
+               cx23885_video_unregister(dev);
+
+       if (cx23885_boards[dev->board].portb == CX23885_MPEG_DVB)
                cx23885_dvb_unregister(&dev->ts1);
 
-       if(cx23885_boards[dev->board].portc == CX23885_MPEG_DVB)
+       if (cx23885_boards[dev->board].portb == CX23885_MPEG_ENCODER)
+               cx23885_417_unregister(dev);
+
+       if (cx23885_boards[dev->board].portc == CX23885_MPEG_DVB)
                cx23885_dvb_unregister(&dev->ts2);
 
+       if (cx23885_boards[dev->board].portc == CX23885_MPEG_ENCODER)
+               cx23885_417_unregister(dev);
+
        cx23885_i2c_unregister(&dev->i2c_bus[2]);
        cx23885_i2c_unregister(&dev->i2c_bus[1]);
        cx23885_i2c_unregister(&dev->i2c_bus[0]);
@@ -896,7 +949,7 @@ static void cx23885_dev_unregister(struct cx23885_dev *dev)
        iounmap(dev->lmmio);
 }
 
-static u32* cx23885_risc_field(u32 *rp, struct scatterlist *sglist,
+static __le32 *cx23885_risc_field(__le32 *rp, struct scatterlist *sglist,
                               unsigned int offset, u32 sync_line,
                               unsigned int bpl, unsigned int padding,
                               unsigned int lines)
@@ -917,31 +970,31 @@ static u32* cx23885_risc_field(u32 *rp, struct scatterlist *sglist,
                }
                if (bpl <= sg_dma_len(sg)-offset) {
                        /* fits into current chunk */
-                       *(rp++)=cpu_to_le32(RISC_WRITE|RISC_SOL|RISC_EOL|bpl);
-                       *(rp++)=cpu_to_le32(sg_dma_address(sg)+offset);
-                       *(rp++)=cpu_to_le32(0); /* bits 63-32 */
-                       offset+=bpl;
+                       *(rp++) = cpu_to_le32(RISC_WRITE|RISC_SOL|RISC_EOL|bpl);
+                       *(rp++) = cpu_to_le32(sg_dma_address(sg)+offset);
+                       *(rp++) = cpu_to_le32(0); /* bits 63-32 */
+                       offset += bpl;
                } else {
                        /* scanline needs to be split */
                        todo = bpl;
-                       *(rp++)=cpu_to_le32(RISC_WRITE|RISC_SOL|
+                       *(rp++) = cpu_to_le32(RISC_WRITE|RISC_SOL|
                                            (sg_dma_len(sg)-offset));
-                       *(rp++)=cpu_to_le32(sg_dma_address(sg)+offset);
-                       *(rp++)=cpu_to_le32(0); /* bits 63-32 */
+                       *(rp++) = cpu_to_le32(sg_dma_address(sg)+offset);
+                       *(rp++) = cpu_to_le32(0); /* bits 63-32 */
                        todo -= (sg_dma_len(sg)-offset);
                        offset = 0;
                        sg++;
                        while (todo > sg_dma_len(sg)) {
-                               *(rp++)=cpu_to_le32(RISC_WRITE|
+                               *(rp++) = cpu_to_le32(RISC_WRITE|
                                                    sg_dma_len(sg));
-                               *(rp++)=cpu_to_le32(sg_dma_address(sg));
-                               *(rp++)=cpu_to_le32(0); /* bits 63-32 */
+                               *(rp++) = cpu_to_le32(sg_dma_address(sg));
+                               *(rp++) = cpu_to_le32(0); /* bits 63-32 */
                                todo -= sg_dma_len(sg);
                                sg++;
                        }
-                       *(rp++)=cpu_to_le32(RISC_WRITE|RISC_EOL|todo);
-                       *(rp++)=cpu_to_le32(sg_dma_address(sg));
-                       *(rp++)=cpu_to_le32(0); /* bits 63-32 */
+                       *(rp++) = cpu_to_le32(RISC_WRITE|RISC_EOL|todo);
+                       *(rp++) = cpu_to_le32(sg_dma_address(sg));
+                       *(rp++) = cpu_to_le32(0); /* bits 63-32 */
                        offset += todo;
                }
                offset += padding;
@@ -950,6 +1003,47 @@ static u32* cx23885_risc_field(u32 *rp, struct scatterlist *sglist,
        return rp;
 }
 
+int cx23885_risc_buffer(struct pci_dev *pci, struct btcx_riscmem *risc,
+                       struct scatterlist *sglist, unsigned int top_offset,
+                       unsigned int bottom_offset, unsigned int bpl,
+                       unsigned int padding, unsigned int lines)
+{
+       u32 instructions, fields;
+       __le32 *rp;
+       int rc;
+
+       fields = 0;
+       if (UNSET != top_offset)
+               fields++;
+       if (UNSET != bottom_offset)
+               fields++;
+
+       /* estimate risc mem: worst case is one write per page border +
+          one write per scan line + syncs + jump (all 2 dwords).  Padding
+          can cause next bpl to start close to a page border.  First DMA
+          region may be smaller than PAGE_SIZE */
+       /* write and jump need and extra dword */
+       instructions  = fields * (1 + ((bpl + padding) * lines)
+               / PAGE_SIZE + lines);
+       instructions += 2;
+       rc = btcx_riscmem_alloc(pci, risc, instructions*12);
+       if (rc < 0)
+               return rc;
+
+       /* write risc instructions */
+       rp = risc->cpu;
+       if (UNSET != top_offset)
+               rp = cx23885_risc_field(rp, sglist, top_offset, 0,
+                                       bpl, padding, lines);
+       if (UNSET != bottom_offset)
+               rp = cx23885_risc_field(rp, sglist, bottom_offset, 0x200,
+                                       bpl, padding, lines);
+
+       /* save pointer to jmp instruction address */
+       risc->jmp = rp;
+       BUG_ON((risc->jmp - risc->cpu + 2) * sizeof(*risc->cpu) > risc->size);
+       return 0;
+}
 
 static int cx23885_risc_databuffer(struct pci_dev *pci,
                                   struct btcx_riscmem *risc,
@@ -958,7 +1052,7 @@ static int cx23885_risc_databuffer(struct pci_dev *pci,
                                   unsigned int lines)
 {
        u32 instructions;
-       u32 *rp;
+       __le32 *rp;
        int rc;
 
        /* estimate risc mem: worst case is one write per page border +
@@ -969,7 +1063,8 @@ static int cx23885_risc_databuffer(struct pci_dev *pci,
        instructions  = 1 + (bpl * lines) / PAGE_SIZE + lines;
        instructions += 1;
 
-       if ((rc = btcx_riscmem_alloc(pci,risc,instructions*12)) < 0)
+       rc = btcx_riscmem_alloc(pci, risc, instructions*12);
+       if (rc < 0)
                return rc;
 
        /* write risc instructions */
@@ -978,17 +1073,18 @@ static int cx23885_risc_databuffer(struct pci_dev *pci,
 
        /* save pointer to jmp instruction address */
        risc->jmp = rp;
-       BUG_ON((risc->jmp - risc->cpu + 2) * sizeof (*risc->cpu) > risc->size);
+       BUG_ON((risc->jmp - risc->cpu + 2) * sizeof(*risc->cpu) > risc->size);
        return 0;
 }
 
-static int cx23885_risc_stopper(struct pci_dev *pci, struct btcx_riscmem *risc,
+int cx23885_risc_stopper(struct pci_dev *pci, struct btcx_riscmem *risc,
                                u32 reg, u32 mask, u32 value)
 {
-       u32 *rp;
+       __le32 *rp;
        int rc;
 
-       if ((rc = btcx_riscmem_alloc(pci, risc, 4*16)) < 0)
+       rc = btcx_riscmem_alloc(pci, risc, 4*16);
+       if (rc < 0)
                return rc;
 
        /* write risc instructions */
@@ -1011,62 +1107,151 @@ void cx23885_free_buffer(struct videobuf_queue *q, struct cx23885_buffer *buf)
        videobuf_waiton(&buf->vb, 0, 0);
        videobuf_dma_unmap(q, dma);
        videobuf_dma_free(dma);
-       btcx_riscmem_free((struct pci_dev *)q->dev, &buf->risc);
+       btcx_riscmem_free(to_pci_dev(q->dev), &buf->risc);
        buf->vb.state = VIDEOBUF_NEEDS_INIT;
 }
 
+static void cx23885_tsport_reg_dump(struct cx23885_tsport *port)
+{
+       struct cx23885_dev *dev = port->dev;
+
+       dprintk(1, "%s() Register Dump\n", __func__);
+       dprintk(1, "%s() DEV_CNTRL2               0x%08X\n", __func__,
+               cx_read(DEV_CNTRL2));
+       dprintk(1, "%s() PCI_INT_MSK              0x%08X\n", __func__,
+               cx_read(PCI_INT_MSK));
+       dprintk(1, "%s() AUD_INT_INT_MSK          0x%08X\n", __func__,
+               cx_read(AUDIO_INT_INT_MSK));
+       dprintk(1, "%s() AUD_INT_DMA_CTL          0x%08X\n", __func__,
+               cx_read(AUD_INT_DMA_CTL));
+       dprintk(1, "%s() AUD_EXT_INT_MSK          0x%08X\n", __func__,
+               cx_read(AUDIO_EXT_INT_MSK));
+       dprintk(1, "%s() AUD_EXT_DMA_CTL          0x%08X\n", __func__,
+               cx_read(AUD_EXT_DMA_CTL));
+       dprintk(1, "%s() PAD_CTRL                 0x%08X\n", __func__,
+               cx_read(PAD_CTRL));
+       dprintk(1, "%s() ALT_PIN_OUT_SEL          0x%08X\n", __func__,
+               cx_read(ALT_PIN_OUT_SEL));
+       dprintk(1, "%s() GPIO2                    0x%08X\n", __func__,
+               cx_read(GPIO2));
+       dprintk(1, "%s() gpcnt(0x%08X)          0x%08X\n", __func__,
+               port->reg_gpcnt, cx_read(port->reg_gpcnt));
+       dprintk(1, "%s() gpcnt_ctl(0x%08X)      0x%08x\n", __func__,
+               port->reg_gpcnt_ctl, cx_read(port->reg_gpcnt_ctl));
+       dprintk(1, "%s() dma_ctl(0x%08X)        0x%08x\n", __func__,
+               port->reg_dma_ctl, cx_read(port->reg_dma_ctl));
+       if (port->reg_src_sel)
+               dprintk(1, "%s() src_sel(0x%08X)        0x%08x\n", __func__,
+                       port->reg_src_sel, cx_read(port->reg_src_sel));
+       dprintk(1, "%s() lngth(0x%08X)          0x%08x\n", __func__,
+               port->reg_lngth, cx_read(port->reg_lngth));
+       dprintk(1, "%s() hw_sop_ctrl(0x%08X)    0x%08x\n", __func__,
+               port->reg_hw_sop_ctrl, cx_read(port->reg_hw_sop_ctrl));
+       dprintk(1, "%s() gen_ctrl(0x%08X)       0x%08x\n", __func__,
+               port->reg_gen_ctrl, cx_read(port->reg_gen_ctrl));
+       dprintk(1, "%s() bd_pkt_status(0x%08X)  0x%08x\n", __func__,
+               port->reg_bd_pkt_status, cx_read(port->reg_bd_pkt_status));
+       dprintk(1, "%s() sop_status(0x%08X)     0x%08x\n", __func__,
+               port->reg_sop_status, cx_read(port->reg_sop_status));
+       dprintk(1, "%s() fifo_ovfl_stat(0x%08X) 0x%08x\n", __func__,
+               port->reg_fifo_ovfl_stat, cx_read(port->reg_fifo_ovfl_stat));
+       dprintk(1, "%s() vld_misc(0x%08X)       0x%08x\n", __func__,
+               port->reg_vld_misc, cx_read(port->reg_vld_misc));
+       dprintk(1, "%s() ts_clk_en(0x%08X)      0x%08x\n", __func__,
+               port->reg_ts_clk_en, cx_read(port->reg_ts_clk_en));
+       dprintk(1, "%s() ts_int_msk(0x%08X)     0x%08x\n", __func__,
+               port->reg_ts_int_msk, cx_read(port->reg_ts_int_msk));
+}
+
 static int cx23885_start_dma(struct cx23885_tsport *port,
                             struct cx23885_dmaqueue *q,
                             struct cx23885_buffer   *buf)
 {
        struct cx23885_dev *dev = port->dev;
+       u32 reg;
 
-       dprintk(1, "%s() w: %d, h: %d, f: %d\n", __FUNCTION__,
+       dprintk(1, "%s() w: %d, h: %d, f: %d\n", __func__,
                buf->vb.width, buf->vb.height, buf->vb.field);
 
+       /* Stop the fifo and risc engine for this port */
+       cx_clear(port->reg_dma_ctl, port->dma_ctl_val);
+
        /* setup fifo + format */
        cx23885_sram_channel_setup(dev,
-                                  &dev->sram_channels[ port->sram_chno ],
+                                  &dev->sram_channels[port->sram_chno],
                                   port->ts_packet_size, buf->risc.dma);
-       if(debug > 5) {
-               cx23885_sram_channel_dump(dev, &dev->sram_channels[ port->sram_chno ] );
+       if (debug > 5) {
+               cx23885_sram_channel_dump(dev,
+                       &dev->sram_channels[port->sram_chno]);
                cx23885_risc_disasm(port, &buf->risc);
        }
 
        /* write TS length to chip */
        cx_write(port->reg_lngth, buf->vb.width);
 
-       if ( (!(cx23885_boards[dev->board].portb & CX23885_MPEG_DVB)) &&
-               (!(cx23885_boards[dev->board].portc & CX23885_MPEG_DVB)) ) {
-               printk( "%s() Failed. Unsupported value in .portb/c (0x%08x)/(0x%08x)\n",
-                       __FUNCTION__,
+       if ((!(cx23885_boards[dev->board].portb & CX23885_MPEG_DVB)) &&
+               (!(cx23885_boards[dev->board].portc & CX23885_MPEG_DVB))) {
+               printk("%s() Unsupported .portb/c (0x%08x)/(0x%08x)\n",
+                       __func__,
                        cx23885_boards[dev->board].portb,
-                       cx23885_boards[dev->board].portc );
+                       cx23885_boards[dev->board].portc);
                return -EINVAL;
        }
 
+       if (cx23885_boards[dev->board].portb == CX23885_MPEG_ENCODER)
+               cx23885_av_clk(dev, 0);
+
        udelay(100);
 
        /* If the port supports SRC SELECT, configure it */
-       if(port->reg_src_sel)
+       if (port->reg_src_sel)
                cx_write(port->reg_src_sel, port->src_sel_val);
 
-       cx_write(port->reg_hw_sop_ctrl, 0x47 << 16 | 188 << 4);
+       cx_write(port->reg_hw_sop_ctrl, port->hw_sop_ctrl_val);
        cx_write(port->reg_ts_clk_en, port->ts_clk_en_val);
-       cx_write(port->reg_vld_misc, 0x00);
+       cx_write(port->reg_vld_misc, port->vld_misc_val);
        cx_write(port->reg_gen_ctrl, port->gen_ctrl_val);
        udelay(100);
 
-       // NOTE: this is 2 (reserved) for portb, does it matter?
+       /* NOTE: this is 2 (reserved) for portb, does it matter? */
        /* reset counter to zero */
        cx_write(port->reg_gpcnt_ctl, 3);
        q->count = 1;
 
-       switch(dev->bridge) {
+       /* Set VIDB pins to input */
+       if (cx23885_boards[dev->board].portb == CX23885_MPEG_DVB) {
+               reg = cx_read(PAD_CTRL);
+               reg &= ~0x3; /* Clear TS1_OE & TS1_SOP_OE */
+               cx_write(PAD_CTRL, reg);
+       }
+
+       /* Set VIDC pins to input */
+       if (cx23885_boards[dev->board].portc == CX23885_MPEG_DVB) {
+               reg = cx_read(PAD_CTRL);
+               reg &= ~0x4; /* Clear TS2_SOP_OE */
+               cx_write(PAD_CTRL, reg);
+       }
+
+       if (cx23885_boards[dev->board].portb == CX23885_MPEG_ENCODER) {
+
+               reg = cx_read(PAD_CTRL);
+               reg = reg & ~0x1;    /* Clear TS1_OE */
+
+               /* FIXME, bit 2 writing here is questionable */
+               /* set TS1_SOP_OE and TS1_OE_HI */
+               reg = reg | 0xa;
+               cx_write(PAD_CTRL, reg);
+
+               /* FIXME and these two registers should be documented. */
+               cx_write(CLK_DELAY, cx_read(CLK_DELAY) | 0x80000011);
+               cx_write(ALT_PIN_OUT_SEL, 0x10100045);
+       }
+
+       switch (dev->bridge) {
        case CX23885_BRIDGE_885:
        case CX23885_BRIDGE_887:
                /* enable irqs */
-               dprintk(1, "%s() enabling TS int's and DMA\n", __FUNCTION__ );
+               dprintk(1, "%s() enabling TS int's and DMA\n", __func__);
                cx_set(port->reg_ts_int_msk,  port->ts_int_msk_val);
                cx_set(port->reg_dma_ctl, port->dma_ctl_val);
                cx_set(PCI_INT_MSK, dev->pci_irqmask | port->pci_irqmask);
@@ -1077,34 +1262,59 @@ static int cx23885_start_dma(struct cx23885_tsport *port,
 
        cx_set(DEV_CNTRL2, (1<<5)); /* Enable RISC controller */
 
+       if (cx23885_boards[dev->board].portb == CX23885_MPEG_ENCODER)
+               cx23885_av_clk(dev, 1);
+
+       if (debug > 4)
+               cx23885_tsport_reg_dump(port);
+
        return 0;
 }
 
 static int cx23885_stop_dma(struct cx23885_tsport *port)
 {
        struct cx23885_dev *dev = port->dev;
-       dprintk(1, "%s()\n", __FUNCTION__);
+       u32 reg;
+
+       dprintk(1, "%s()\n", __func__);
 
        /* Stop interrupts and DMA */
        cx_clear(port->reg_ts_int_msk, port->ts_int_msk_val);
        cx_clear(port->reg_dma_ctl, port->dma_ctl_val);
 
+       if (cx23885_boards[dev->board].portb == CX23885_MPEG_ENCODER) {
+
+               reg = cx_read(PAD_CTRL);
+
+               /* Set TS1_OE */
+               reg = reg | 0x1;
+
+               /* clear TS1_SOP_OE and TS1_OE_HI */
+               reg = reg & ~0xa;
+               cx_write(PAD_CTRL, reg);
+               cx_write(port->reg_src_sel, 0);
+               cx_write(port->reg_gen_ctrl, 8);
+
+       }
+
+       if (cx23885_boards[dev->board].portb == CX23885_MPEG_ENCODER)
+               cx23885_av_clk(dev, 0);
+
        return 0;
 }
 
-static int cx23885_restart_queue(struct cx23885_tsport *port,
+int cx23885_restart_queue(struct cx23885_tsport *port,
                                struct cx23885_dmaqueue *q)
 {
        struct cx23885_dev *dev = port->dev;
        struct cx23885_buffer *buf;
 
-       dprintk(5, "%s()\n", __FUNCTION__);
-       if (list_empty(&q->active))
-       {
+       dprintk(5, "%s()\n", __func__);
+       if (list_empty(&q->active)) {
                struct cx23885_buffer *prev;
                prev = NULL;
 
-               dprintk(5, "%s() queue is empty\n", __FUNCTION__);
+               dprintk(5, "%s() queue is empty\n", __func__);
 
                for (;;) {
                        if (list_empty(&q->queued))
@@ -1118,7 +1328,7 @@ static int cx23885_restart_queue(struct cx23885_tsport *port,
                                buf->vb.state = VIDEOBUF_ACTIVE;
                                buf->count    = q->count++;
                                mod_timer(&q->timeout, jiffies+BUFFER_TIMEOUT);
-                               dprintk(5, "[%p/%d] restart_queue - first active\n",
+                               dprintk(5, "[%p/%d] restart_queue - f/active\n",
                                        buf, buf->vb.i);
 
                        } else if (prev->vb.width  == buf->vb.width  &&
@@ -1129,8 +1339,9 @@ static int cx23885_restart_queue(struct cx23885_tsport *port,
                                buf->vb.state = VIDEOBUF_ACTIVE;
                                buf->count    = q->count++;
                                prev->risc.jmp[1] = cpu_to_le32(buf->risc.dma);
-                               prev->risc.jmp[2] = cpu_to_le32(0); /* 64 bit bits 63-32 */
-                               dprintk(5,"[%p/%d] restart_queue - move to active\n",
+                               /* 64 bit bits 63-32 */
+                               prev->risc.jmp[2] = cpu_to_le32(0);
+                               dprintk(5, "[%p/%d] restart_queue - m/active\n",
                                        buf, buf->vb.i);
                        } else {
                                return 0;
@@ -1159,7 +1370,7 @@ int cx23885_buf_prepare(struct videobuf_queue *q, struct cx23885_tsport *port,
        int size = port->ts_packet_size * port->ts_packet_count;
        int rc;
 
-       dprintk(1, "%s: %p\n", __FUNCTION__, buf);
+       dprintk(1, "%s: %p\n", __func__, buf);
        if (0 != buf->vb.baddr  &&  buf->vb.bsize < size)
                return -EINVAL;
 
@@ -1169,7 +1380,8 @@ int cx23885_buf_prepare(struct videobuf_queue *q, struct cx23885_tsport *port,
                buf->vb.size   = size;
                buf->vb.field  = field /*V4L2_FIELD_TOP*/;
 
-               if (0 != (rc = videobuf_iolock(q, &buf->vb, NULL)))
+               rc = videobuf_iolock(q, &buf->vb, NULL);
+               if (0 != rc)
                        goto fail;
                cx23885_risc_databuffer(dev->pci, &buf->risc,
                                        videobuf_to_dma(&buf->vb)->sglist,
@@ -1195,16 +1407,16 @@ void cx23885_buf_queue(struct cx23885_tsport *port, struct cx23885_buffer *buf)
        buf->risc.jmp[2] = cpu_to_le32(0); /* bits 63-32 */
 
        if (list_empty(&cx88q->active)) {
-               dprintk( 1, "queue is empty - first active\n" );
+               dprintk(1, "queue is empty - first active\n");
                list_add_tail(&buf->vb.queue, &cx88q->active);
                cx23885_start_dma(port, cx88q, buf);
                buf->vb.state = VIDEOBUF_ACTIVE;
                buf->count    = cx88q->count++;
                mod_timer(&cx88q->timeout, jiffies + BUFFER_TIMEOUT);
                dprintk(1, "[%p/%d] %s - first active\n",
-                       buf, buf->vb.i, __FUNCTION__);
+                       buf, buf->vb.i, __func__);
        } else {
-               dprintk( 1, "queue is not empty - append to active\n" );
+               dprintk(1, "queue is not empty - append to active\n");
                prev = list_entry(cx88q->active.prev, struct cx23885_buffer,
                                  vb.queue);
                list_add_tail(&buf->vb.queue, &cx88q->active);
@@ -1212,8 +1424,8 @@ void cx23885_buf_queue(struct cx23885_tsport *port, struct cx23885_buffer *buf)
                buf->count    = cx88q->count++;
                prev->risc.jmp[1] = cpu_to_le32(buf->risc.dma);
                prev->risc.jmp[2] = cpu_to_le32(0); /* 64 bit bits 63-32 */
-               dprintk( 1, "[%p/%d] %s - append to active\n",
-                        buf, buf->vb.i, __FUNCTION__);
+               dprintk(1, "[%p/%d] %s - append to active\n",
+                        buf, buf->vb.i, __func__);
        }
 }
 
@@ -1238,51 +1450,131 @@ static void do_cancel_buffers(struct cx23885_tsport *port, char *reason,
                        buf, buf->vb.i, reason, (unsigned long)buf->risc.dma);
        }
        if (restart) {
-               dprintk(1, "restarting queue\n" );
+               dprintk(1, "restarting queue\n");
                cx23885_restart_queue(port, q);
        }
        spin_unlock_irqrestore(&port->slock, flags);
 }
 
+void cx23885_cancel_buffers(struct cx23885_tsport *port)
+{
+       struct cx23885_dev *dev = port->dev;
+       struct cx23885_dmaqueue *q = &port->mpegq;
+
+       dprintk(1, "%s()\n", __func__);
+       del_timer_sync(&q->timeout);
+       cx23885_stop_dma(port);
+       do_cancel_buffers(port, "cancel", 0);
+}
 
 static void cx23885_timeout(unsigned long data)
 {
        struct cx23885_tsport *port = (struct cx23885_tsport *)data;
        struct cx23885_dev *dev = port->dev;
 
-       dprintk(1, "%s()\n",__FUNCTION__);
+       dprintk(1, "%s()\n", __func__);
 
        if (debug > 5)
-               cx23885_sram_channel_dump(dev, &dev->sram_channels[ port->sram_chno ]);
+               cx23885_sram_channel_dump(dev,
+                       &dev->sram_channels[port->sram_chno]);
 
        cx23885_stop_dma(port);
        do_cancel_buffers(port, "timeout", 1);
 }
 
+int cx23885_irq_417(struct cx23885_dev *dev, u32 status)
+{
+       /* FIXME: port1 assumption here. */
+       struct cx23885_tsport *port = &dev->ts1;
+       int count = 0;
+       int handled = 0;
+
+       if (status == 0)
+               return handled;
+
+       count = cx_read(port->reg_gpcnt);
+       dprintk(7, "status: 0x%08x  mask: 0x%08x count: 0x%x\n",
+               status, cx_read(port->reg_ts_int_msk), count);
+
+       if ((status & VID_B_MSK_BAD_PKT)         ||
+               (status & VID_B_MSK_OPC_ERR)     ||
+               (status & VID_B_MSK_VBI_OPC_ERR) ||
+               (status & VID_B_MSK_SYNC)        ||
+               (status & VID_B_MSK_VBI_SYNC)    ||
+               (status & VID_B_MSK_OF)          ||
+               (status & VID_B_MSK_VBI_OF)) {
+               printk(KERN_ERR "%s: V4L mpeg risc op code error, status "
+                       "= 0x%x\n", dev->name, status);
+               if (status & VID_B_MSK_BAD_PKT)
+                       dprintk(1, "        VID_B_MSK_BAD_PKT\n");
+               if (status & VID_B_MSK_OPC_ERR)
+                       dprintk(1, "        VID_B_MSK_OPC_ERR\n");
+               if (status & VID_B_MSK_VBI_OPC_ERR)
+                       dprintk(1, "        VID_B_MSK_VBI_OPC_ERR\n");
+               if (status & VID_B_MSK_SYNC)
+                       dprintk(1, "        VID_B_MSK_SYNC\n");
+               if (status & VID_B_MSK_VBI_SYNC)
+                       dprintk(1, "        VID_B_MSK_VBI_SYNC\n");
+               if (status & VID_B_MSK_OF)
+                       dprintk(1, "        VID_B_MSK_OF\n");
+               if (status & VID_B_MSK_VBI_OF)
+                       dprintk(1, "        VID_B_MSK_VBI_OF\n");
+
+               cx_clear(port->reg_dma_ctl, port->dma_ctl_val);
+               cx23885_sram_channel_dump(dev,
+                       &dev->sram_channels[port->sram_chno]);
+               cx23885_417_check_encoder(dev);
+       } else if (status & VID_B_MSK_RISCI1) {
+               dprintk(7, "        VID_B_MSK_RISCI1\n");
+               spin_lock(&port->slock);
+               cx23885_wakeup(port, &port->mpegq, count);
+               spin_unlock(&port->slock);
+       } else if (status & VID_B_MSK_RISCI2) {
+               dprintk(7, "        VID_B_MSK_RISCI2\n");
+               spin_lock(&port->slock);
+               cx23885_restart_queue(port, &port->mpegq);
+               spin_unlock(&port->slock);
+       }
+       if (status) {
+               cx_write(port->reg_ts_int_stat, status);
+               handled = 1;
+       }
+
+       return handled;
+}
+
 static int cx23885_irq_ts(struct cx23885_tsport *port, u32 status)
 {
        struct cx23885_dev *dev = port->dev;
        int handled = 0;
        u32 count;
 
-       if ( (status & VID_BC_MSK_OPC_ERR) ||
-            (status & VID_BC_MSK_BAD_PKT) ||
-            (status & VID_BC_MSK_SYNC) ||
-            (status & VID_BC_MSK_OF))
-       {
+       if ((status & VID_BC_MSK_OPC_ERR) ||
+               (status & VID_BC_MSK_BAD_PKT) ||
+               (status & VID_BC_MSK_SYNC) ||
+               (status & VID_BC_MSK_OF)) {
+
                if (status & VID_BC_MSK_OPC_ERR)
-                       dprintk(7, " (VID_BC_MSK_OPC_ERR 0x%08x)\n", VID_BC_MSK_OPC_ERR);
+                       dprintk(7, " (VID_BC_MSK_OPC_ERR 0x%08x)\n",
+                               VID_BC_MSK_OPC_ERR);
+
                if (status & VID_BC_MSK_BAD_PKT)
-                       dprintk(7, " (VID_BC_MSK_BAD_PKT 0x%08x)\n", VID_BC_MSK_BAD_PKT);
+                       dprintk(7, " (VID_BC_MSK_BAD_PKT 0x%08x)\n",
+                               VID_BC_MSK_BAD_PKT);
+
                if (status & VID_BC_MSK_SYNC)
-                       dprintk(7, " (VID_BC_MSK_SYNC    0x%08x)\n", VID_BC_MSK_SYNC);
+                       dprintk(7, " (VID_BC_MSK_SYNC    0x%08x)\n",
+                               VID_BC_MSK_SYNC);
+
                if (status & VID_BC_MSK_OF)
-                       dprintk(7, " (VID_BC_MSK_OF      0x%08x)\n", VID_BC_MSK_OF);
+                       dprintk(7, " (VID_BC_MSK_OF      0x%08x)\n",
+                               VID_BC_MSK_OF);
 
                printk(KERN_ERR "%s: mpeg risc op code error\n", dev->name);
 
                cx_clear(port->reg_dma_ctl, port->dma_ctl_val);
-               cx23885_sram_channel_dump(dev, &dev->sram_channels[ port->sram_chno ]);
+               cx23885_sram_channel_dump(dev,
+                       &dev->sram_channels[port->sram_chno]);
 
        } else if (status & VID_BC_MSK_RISCI1) {
 
@@ -1316,66 +1608,119 @@ static irqreturn_t cx23885_irq(int irq, void *dev_id)
        struct cx23885_tsport *ts1 = &dev->ts1;
        struct cx23885_tsport *ts2 = &dev->ts2;
        u32 pci_status, pci_mask;
+       u32 vida_status, vida_mask;
        u32 ts1_status, ts1_mask;
        u32 ts2_status, ts2_mask;
-       int ts1_count = 0, ts2_count = 0, handled = 0;
+       int vida_count = 0, ts1_count = 0, ts2_count = 0, handled = 0;
 
        pci_status = cx_read(PCI_INT_STAT);
        pci_mask = cx_read(PCI_INT_MSK);
+       vida_status = cx_read(VID_A_INT_STAT);
+       vida_mask = cx_read(VID_A_INT_MSK);
        ts1_status = cx_read(VID_B_INT_STAT);
        ts1_mask = cx_read(VID_B_INT_MSK);
        ts2_status = cx_read(VID_C_INT_STAT);
        ts2_mask = cx_read(VID_C_INT_MSK);
 
-       if ( (pci_status == 0) && (ts2_status == 0) && (ts1_status == 0) )
+       if ((pci_status == 0) && (ts2_status == 0) && (ts1_status == 0))
                goto out;
 
+       vida_count = cx_read(VID_A_GPCNT);
        ts1_count = cx_read(ts1->reg_gpcnt);
        ts2_count = cx_read(ts2->reg_gpcnt);
-       dprintk(7, "pci_status: 0x%08x  pci_mask: 0x%08x\n", pci_status, pci_mask );
-       dprintk(7, "ts1_status: 0x%08x  ts1_mask: 0x%08x count: 0x%x\n", ts1_status, ts1_mask, ts1_count );
-       dprintk(7, "ts2_status: 0x%08x  ts2_mask: 0x%08x count: 0x%x\n", ts2_status, ts2_mask, ts2_count );
-
-       if ( (pci_status & PCI_MSK_RISC_RD) ||
-            (pci_status & PCI_MSK_RISC_WR) ||
-            (pci_status & PCI_MSK_AL_RD) ||
-            (pci_status & PCI_MSK_AL_WR) ||
-            (pci_status & PCI_MSK_APB_DMA) ||
-            (pci_status & PCI_MSK_VID_C) ||
-            (pci_status & PCI_MSK_VID_B) ||
-            (pci_status & PCI_MSK_VID_A) ||
-            (pci_status & PCI_MSK_AUD_INT) ||
-            (pci_status & PCI_MSK_AUD_EXT) )
-       {
+       dprintk(7, "pci_status: 0x%08x  pci_mask: 0x%08x\n",
+               pci_status, pci_mask);
+       dprintk(7, "vida_status: 0x%08x vida_mask: 0x%08x count: 0x%x\n",
+               vida_status, vida_mask, vida_count);
+       dprintk(7, "ts1_status: 0x%08x  ts1_mask: 0x%08x count: 0x%x\n",
+               ts1_status, ts1_mask, ts1_count);
+       dprintk(7, "ts2_status: 0x%08x  ts2_mask: 0x%08x count: 0x%x\n",
+               ts2_status, ts2_mask, ts2_count);
+
+       if ((pci_status & PCI_MSK_RISC_RD) ||
+           (pci_status & PCI_MSK_RISC_WR) ||
+           (pci_status & PCI_MSK_AL_RD) ||
+           (pci_status & PCI_MSK_AL_WR) ||
+           (pci_status & PCI_MSK_APB_DMA) ||
+           (pci_status & PCI_MSK_VID_C) ||
+           (pci_status & PCI_MSK_VID_B) ||
+           (pci_status & PCI_MSK_VID_A) ||
+           (pci_status & PCI_MSK_AUD_INT) ||
+           (pci_status & PCI_MSK_AUD_EXT) ||
+           (pci_status & PCI_MSK_GPIO0) ||
+           (pci_status & PCI_MSK_GPIO1)) {
 
                if (pci_status & PCI_MSK_RISC_RD)
-                       dprintk(7, " (PCI_MSK_RISC_RD   0x%08x)\n", PCI_MSK_RISC_RD);
+                       dprintk(7, " (PCI_MSK_RISC_RD   0x%08x)\n",
+                               PCI_MSK_RISC_RD);
+
                if (pci_status & PCI_MSK_RISC_WR)
-                       dprintk(7, " (PCI_MSK_RISC_WR   0x%08x)\n", PCI_MSK_RISC_WR);
+                       dprintk(7, " (PCI_MSK_RISC_WR   0x%08x)\n",
+                               PCI_MSK_RISC_WR);
+
                if (pci_status & PCI_MSK_AL_RD)
-                       dprintk(7, " (PCI_MSK_AL_RD     0x%08x)\n", PCI_MSK_AL_RD);
+                       dprintk(7, " (PCI_MSK_AL_RD     0x%08x)\n",
+                               PCI_MSK_AL_RD);
+
                if (pci_status & PCI_MSK_AL_WR)
-                       dprintk(7, " (PCI_MSK_AL_WR     0x%08x)\n", PCI_MSK_AL_WR);
+                       dprintk(7, " (PCI_MSK_AL_WR     0x%08x)\n",
+                               PCI_MSK_AL_WR);
+
                if (pci_status & PCI_MSK_APB_DMA)
-                       dprintk(7, " (PCI_MSK_APB_DMA   0x%08x)\n", PCI_MSK_APB_DMA);
+                       dprintk(7, " (PCI_MSK_APB_DMA   0x%08x)\n",
+                               PCI_MSK_APB_DMA);
+
                if (pci_status & PCI_MSK_VID_C)
-                       dprintk(7, " (PCI_MSK_VID_C     0x%08x)\n", PCI_MSK_VID_C);
+                       dprintk(7, " (PCI_MSK_VID_C     0x%08x)\n",
+                               PCI_MSK_VID_C);
+
                if (pci_status & PCI_MSK_VID_B)
-                       dprintk(7, " (PCI_MSK_VID_B     0x%08x)\n", PCI_MSK_VID_B);
+                       dprintk(7, " (PCI_MSK_VID_B     0x%08x)\n",
+                               PCI_MSK_VID_B);
+
                if (pci_status & PCI_MSK_VID_A)
-                       dprintk(7, " (PCI_MSK_VID_A     0x%08x)\n", PCI_MSK_VID_A);
+                       dprintk(7, " (PCI_MSK_VID_A     0x%08x)\n",
+                               PCI_MSK_VID_A);
+
                if (pci_status & PCI_MSK_AUD_INT)
-                       dprintk(7, " (PCI_MSK_AUD_INT   0x%08x)\n", PCI_MSK_AUD_INT);
+                       dprintk(7, " (PCI_MSK_AUD_INT   0x%08x)\n",
+                               PCI_MSK_AUD_INT);
+
                if (pci_status & PCI_MSK_AUD_EXT)
-                       dprintk(7, " (PCI_MSK_AUD_EXT   0x%08x)\n", PCI_MSK_AUD_EXT);
+                       dprintk(7, " (PCI_MSK_AUD_EXT   0x%08x)\n",
+                               PCI_MSK_AUD_EXT);
+
+               if (pci_status & PCI_MSK_GPIO0)
+                       dprintk(7, " (PCI_MSK_GPIO0     0x%08x)\n",
+                               PCI_MSK_GPIO0);
 
+               if (pci_status & PCI_MSK_GPIO1)
+                       dprintk(7, " (PCI_MSK_GPIO1     0x%08x)\n",
+                               PCI_MSK_GPIO1);
        }
 
-       if (ts1_status)
-               handled += cx23885_irq_ts(ts1, ts1_status);
+       if ((pci_status & PCI_MSK_GPIO0) || (pci_status & PCI_MSK_GPIO1))
+               /* handled += cx23885_irq_gpio(dev, pci_status); */
+               handled += netup_ci_slot_status(dev, pci_status);
 
-       if (ts2_status)
-               handled += cx23885_irq_ts(ts2, ts2_status);
+       if (ts1_status) {
+               if (cx23885_boards[dev->board].portb == CX23885_MPEG_DVB)
+                       handled += cx23885_irq_ts(ts1, ts1_status);
+               else
+               if (cx23885_boards[dev->board].portb == CX23885_MPEG_ENCODER)
+                       handled += cx23885_irq_417(dev, ts1_status);
+       }
+
+       if (ts2_status) {
+               if (cx23885_boards[dev->board].portc == CX23885_MPEG_DVB)
+                       handled += cx23885_irq_ts(ts2, ts2_status);
+               else
+               if (cx23885_boards[dev->board].portc == CX23885_MPEG_ENCODER)
+                       handled += cx23885_irq_417(dev, ts2_status);
+       }
+
+       if (vida_status)
+               handled += cx23885_video_irq(dev, vida_status);
 
        if (handled)
                cx_write(PCI_INT_STAT, pci_status);
@@ -1411,7 +1756,8 @@ static int __devinit cx23885_initdev(struct pci_dev *pci_dev,
        printk(KERN_INFO "%s/0: found at %s, rev: %d, irq: %d, "
               "latency: %d, mmio: 0x%llx\n", dev->name,
               pci_name(pci_dev), dev->pci_rev, pci_dev->irq,
-              dev->pci_lat, (unsigned long long)pci_resource_start(pci_dev,0));
+              dev->pci_lat,
+               (unsigned long long)pci_resource_start(pci_dev, 0));
 
        pci_set_master(pci_dev);
        if (!pci_dma_supported(pci_dev, 0xffffffff)) {
@@ -1429,6 +1775,8 @@ static int __devinit cx23885_initdev(struct pci_dev *pci_dev,
        }
 
        pci_set_drvdata(pci_dev, dev);
+       cx_set(PCI_INT_MSK, 0x01800000); /* for NetUP */
+
        return 0;
 
 fail_irq:
@@ -1465,13 +1813,13 @@ static struct pci_device_id cx23885_pci_tbl[] = {
                .device       = 0x8852,
                .subvendor    = PCI_ANY_ID,
                .subdevice    = PCI_ANY_ID,
-       },{
+       }, {
                /* CX23887 Rev 2 */
                .vendor       = 0x14f1,
                .device       = 0x8880,
                .subvendor    = PCI_ANY_ID,
                .subdevice    = PCI_ANY_ID,
-       },{
+       }, {
                /* --- end of list --- */
        }
 };
@@ -1509,9 +1857,3 @@ module_init(cx23885_init);
 module_exit(cx23885_fini);
 
 /* ----------------------------------------------------------- */
-/*
- * Local variables:
- * c-basic-offset: 8
- * End:
- * kate: eol "unix"; indent-width 3; remove-trailing-space on; replace-trailing-space-save on; tab-width 8; replace-tabs off; space-indent off; mixed-indent off
- */