IB/ipath: Fix incorrect check for max physical address in TID
[safe/jmp/linux-2.6] / drivers / infiniband / hw / ipath / ipath_fs.c
index 79a60f0..23faba9 100644 (file)
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2006 QLogic, Inc. All rights reserved.
+ * Copyright (c) 2006, 2007 QLogic Corporation. All rights reserved.
  * Copyright (c) 2006 PathScale, Inc. All rights reserved.
  *
  * This software is available to you under a choice of one of two
@@ -38,7 +38,6 @@
 #include <linux/pagemap.h>
 #include <linux/init.h>
 #include <linux/namei.h>
-#include <linux/pci.h>
 
 #include "ipath_kernel.h"
 
@@ -47,7 +46,7 @@
 static struct super_block *ipath_super;
 
 static int ipathfs_mknod(struct inode *dir, struct dentry *dentry,
-                        int mode, struct file_operations *fops,
+                        int mode, const struct file_operations *fops,
                         void *data)
 {
        int error;
@@ -81,7 +80,7 @@ bail:
 
 static int create_file(const char *name, mode_t mode,
                       struct dentry *parent, struct dentry **dentry,
-                      struct file_operations *fops, void *data)
+                      const struct file_operations *fops, void *data)
 {
        int error;
 
@@ -105,196 +104,27 @@ static ssize_t atomic_stats_read(struct file *file, char __user *buf,
                                       sizeof ipath_stats);
 }
 
-static struct file_operations atomic_stats_ops = {
+static const struct file_operations atomic_stats_ops = {
        .read = atomic_stats_read,
 };
 
-#define NUM_COUNTERS sizeof(struct infinipath_counters) / sizeof(u64)
-
 static ssize_t atomic_counters_read(struct file *file, char __user *buf,
                                    size_t count, loff_t *ppos)
 {
-       u64 counters[NUM_COUNTERS];
-       u16 i;
+       struct infinipath_counters counters;
        struct ipath_devdata *dd;
 
        dd = file->f_path.dentry->d_inode->i_private;
+       dd->ipath_f_read_counters(dd, &counters);
 
-       for (i = 0; i < NUM_COUNTERS; i++)
-               counters[i] = ipath_snap_cntr(dd, i);
-
-       return simple_read_from_buffer(buf, count, ppos, counters,
+       return simple_read_from_buffer(buf, count, ppos, &counters,
                                       sizeof counters);
 }
 
-static struct file_operations atomic_counters_ops = {
+static const struct file_operations atomic_counters_ops = {
        .read = atomic_counters_read,
 };
 
-static ssize_t atomic_node_info_read(struct file *file, char __user *buf,
-                                    size_t count, loff_t *ppos)
-{
-       u32 nodeinfo[10];
-       struct ipath_devdata *dd;
-       u64 guid;
-
-       dd = file->f_path.dentry->d_inode->i_private;
-
-       guid = be64_to_cpu(dd->ipath_guid);
-
-       nodeinfo[0] =                   /* BaseVersion is SMA */
-               /* ClassVersion is SMA */
-               (1 << 8)                /* NodeType  */
-               | (1 << 0);             /* NumPorts */
-       nodeinfo[1] = (u32) (guid >> 32);
-       nodeinfo[2] = (u32) (guid & 0xffffffff);
-       /* PortGUID == SystemImageGUID for us */
-       nodeinfo[3] = nodeinfo[1];
-       /* PortGUID == SystemImageGUID for us */
-       nodeinfo[4] = nodeinfo[2];
-       /* PortGUID == NodeGUID for us */
-       nodeinfo[5] = nodeinfo[3];
-       /* PortGUID == NodeGUID for us */
-       nodeinfo[6] = nodeinfo[4];
-       nodeinfo[7] = (4 << 16) /* we support 4 pkeys */
-               | (dd->ipath_deviceid << 0);
-       /* our chip version as 16 bits major, 16 bits minor */
-       nodeinfo[8] = dd->ipath_minrev | (dd->ipath_majrev << 16);
-       nodeinfo[9] = (dd->ipath_unit << 24) | (dd->ipath_vendorid << 0);
-
-       return simple_read_from_buffer(buf, count, ppos, nodeinfo,
-                                      sizeof nodeinfo);
-}
-
-static struct file_operations atomic_node_info_ops = {
-       .read = atomic_node_info_read,
-};
-
-static ssize_t atomic_port_info_read(struct file *file, char __user *buf,
-                                    size_t count, loff_t *ppos)
-{
-       u32 portinfo[13];
-       u32 tmp, tmp2;
-       struct ipath_devdata *dd;
-
-       dd = file->f_path.dentry->d_inode->i_private;
-
-       /* so we only initialize non-zero fields. */
-       memset(portinfo, 0, sizeof portinfo);
-
-       /*
-        * Notimpl yet M_Key (64)
-        * Notimpl yet GID (64)
-        */
-
-       portinfo[4] = (dd->ipath_lid << 16);
-
-       /*
-        * Notimpl yet SMLID.
-        * CapabilityMask is 0, we don't support any of these
-        * DiagCode is 0; we don't store any diag info for now Notimpl yet
-        * M_KeyLeasePeriod (we don't support M_Key)
-        */
-
-       /* LocalPortNum is whichever port number they ask for */
-       portinfo[7] = (dd->ipath_unit << 24)
-               /* LinkWidthEnabled */
-               | (2 << 16)
-               /* LinkWidthSupported (really 2, but not IB valid) */
-               | (3 << 8)
-               /* LinkWidthActive */
-               | (2 << 0);
-       tmp = dd->ipath_lastibcstat & IPATH_IBSTATE_MASK;
-       tmp2 = 5;
-       if (tmp == IPATH_IBSTATE_INIT)
-               tmp = 2;
-       else if (tmp == IPATH_IBSTATE_ARM)
-               tmp = 3;
-       else if (tmp == IPATH_IBSTATE_ACTIVE)
-               tmp = 4;
-       else {
-               tmp = 0;        /* down */
-               tmp2 = tmp & 0xf;
-       }
-
-       portinfo[8] = (1 << 28) /* LinkSpeedSupported */
-               | (tmp << 24)   /* PortState */
-               | (tmp2 << 20)  /* PortPhysicalState */
-               | (2 << 16)
-
-               /* LinkDownDefaultState */
-               /* M_KeyProtectBits == 0 */
-               /* NotImpl yet LMC == 0 (we can support all values) */
-               | (1 << 4)      /* LinkSpeedActive */
-               | (1 << 0);     /* LinkSpeedEnabled */
-       switch (dd->ipath_ibmtu) {
-       case 4096:
-               tmp = 5;
-               break;
-       case 2048:
-               tmp = 4;
-               break;
-       case 1024:
-               tmp = 3;
-               break;
-       case 512:
-               tmp = 2;
-               break;
-       case 256:
-               tmp = 1;
-               break;
-       default:                /* oops, something is wrong */
-               ipath_dbg("Problem, ipath_ibmtu 0x%x not a valid IB MTU, "
-                         "treat as 2048\n", dd->ipath_ibmtu);
-               tmp = 4;
-               break;
-       }
-       portinfo[9] = (tmp << 28)
-               /* NeighborMTU */
-               /* Notimpl MasterSMSL */
-               | (1 << 20)
-
-               /* VLCap */
-               /* Notimpl InitType (actually, an SMA decision) */
-               /* VLHighLimit is 0 (only one VL) */
-               ; /* VLArbitrationHighCap is 0 (only one VL) */
-       portinfo[10] =  /* VLArbitrationLowCap is 0 (only one VL) */
-               /* InitTypeReply is SMA decision */
-               (5 << 16)       /* MTUCap 4096 */
-               | (7 << 13)     /* VLStallCount */
-               | (0x1f << 8)   /* HOQLife */
-               | (1 << 4)
-
-               /* OperationalVLs 0 */
-               /* PartitionEnforcementInbound */
-               /* PartitionEnforcementOutbound not enforced */
-               /* FilterRawinbound not enforced */
-               ;               /* FilterRawOutbound not enforced */
-       /* M_KeyViolations are not counted by hardware, SMA can count */
-       tmp = ipath_read_creg32(dd, dd->ipath_cregs->cr_errpkey);
-       /* P_KeyViolations are counted by hardware. */
-       portinfo[11] = ((tmp & 0xffff) << 0);
-       portinfo[12] =
-               /* Q_KeyViolations are not counted by hardware */
-               (1 << 8)
-
-               /* GUIDCap */
-               /* SubnetTimeOut handled by SMA */
-               /* RespTimeValue handled by SMA */
-               ;
-       /* LocalPhyErrors are programmed to max */
-       portinfo[12] |= (0xf << 20)
-               | (0xf << 16)   /* OverRunErrors are programmed to max */
-               ;
-
-       return simple_read_from_buffer(buf, count, ppos, portinfo,
-                                      sizeof portinfo);
-}
-
-static struct file_operations atomic_port_info_ops = {
-       .read = atomic_port_info_read,
-};
-
 static ssize_t flash_read(struct file *file, char __user *buf,
                          size_t count, loff_t *ppos)
 {
@@ -394,7 +224,7 @@ bail:
        return ret;
 }
 
-static struct file_operations flash_ops = {
+static const struct file_operations flash_ops = {
        .read = flash_read,
        .write = flash_write,
 };
@@ -408,8 +238,7 @@ static int create_device_files(struct super_block *sb,
 
        snprintf(unit, sizeof unit, "%02d", dd->ipath_unit);
        ret = create_file(unit, S_IFDIR|S_IRUGO|S_IXUGO, sb->s_root, &dir,
-                         (struct file_operations *) &simple_dir_operations,
-                         dd);
+                         &simple_dir_operations, dd);
        if (ret) {
                printk(KERN_ERR "create_file(%s) failed: %d\n", unit, ret);
                goto bail;
@@ -423,22 +252,6 @@ static int create_device_files(struct super_block *sb,
                goto bail;
        }
 
-       ret = create_file("node_info", S_IFREG|S_IRUGO, dir, &tmp,
-                         &atomic_node_info_ops, dd);
-       if (ret) {
-               printk(KERN_ERR "create_file(%s/node_info) "
-                      "failed: %d\n", unit, ret);
-               goto bail;
-       }
-
-       ret = create_file("port_info", S_IFREG|S_IRUGO, dir, &tmp,
-                         &atomic_port_info_ops, dd);
-       if (ret) {
-               printk(KERN_ERR "create_file(%s/port_info) "
-                      "failed: %d\n", unit, ret);
-               goto bail;
-       }
-
        ret = create_file("flash", S_IFREG|S_IWUSR|S_IRUGO, dir, &tmp,
                          &flash_ops, dd);
        if (ret) {
@@ -451,12 +264,18 @@ bail:
        return ret;
 }
 
-static void remove_file(struct dentry *parent, char *name)
+static int remove_file(struct dentry *parent, char *name)
 {
        struct dentry *tmp;
+       int ret;
 
        tmp = lookup_one_len(name, parent, strlen(name));
 
+       if (IS_ERR(tmp)) {
+               ret = PTR_ERR(tmp);
+               goto bail;
+       }
+
        spin_lock(&dcache_lock);
        spin_lock(&tmp->d_lock);
        if (!(d_unhashed(tmp) && tmp->d_inode)) {
@@ -469,6 +288,14 @@ static void remove_file(struct dentry *parent, char *name)
                spin_unlock(&tmp->d_lock);
                spin_unlock(&dcache_lock);
        }
+
+       ret = 0;
+bail:
+       /*
+        * We don't expect clients to care about the return value, but
+        * it's there if they need it.
+        */
+       return ret;
 }
 
 static int remove_device_files(struct super_block *sb,
@@ -490,8 +317,6 @@ static int remove_device_files(struct super_block *sb,
        }
 
        remove_file(dir, "flash");
-       remove_file(dir, "port_info");
-       remove_file(dir, "node_info");
        remove_file(dir, "atomic_counters");
        d_delete(dir);
        ret = simple_rmdir(root->d_inode, dir);
@@ -510,7 +335,7 @@ static int ipathfs_fill_super(struct super_block *sb, void *data,
        int ret;
 
        static struct tree_descr files[] = {
-               [1] = {"atomic_stats", &atomic_stats_ops, S_IRUGO},
+               [2] = {"atomic_stats", &atomic_stats_ops, S_IRUGO},
                {""},
        };