siimage: remove proc_reports_siimage()
[safe/jmp/linux-2.6] / drivers / ide / pci / siimage.c
index 689786d..590ce7b 100644 (file)
@@ -1,10 +1,8 @@
 /*
- * linux/drivers/ide/pci/siimage.c             Version 1.17    Oct 18 2007
- *
  * Copyright (C) 2001-2002     Andre Hedrick <andre@linux-ide.org>
  * Copyright (C) 2003          Red Hat <alan@redhat.com>
  * Copyright (C) 2007          MontaVista Software, Inc.
- * Copyright (C) 2007          Bartlomiej Zolnierkiewicz
+ * Copyright (C) 2007-2008     Bartlomiej Zolnierkiewicz
  *
  *  May be copied or modified under the terms of the GNU General Public License
  *
@@ -26,7 +24,7 @@
  *
  *     If you have strange problems with nVidia chipset systems please
  *     see the SI support documentation and update your system BIOS
- *     if neccessary
+ *     if necessary
  *
  *  The Dell DRAC4 has some interesting features including effectively hot
  *  unplugging/replugging the virtual CD interface when the DRAC is reset.
@@ -41,7 +39,6 @@
 #include <linux/types.h>
 #include <linux/module.h>
 #include <linux/pci.h>
-#include <linux/delay.h>
 #include <linux/hdreg.h>
 #include <linux/ide.h>
 #include <linux/init.h>
@@ -57,8 +54,8 @@
  
 static int pdev_is_sata(struct pci_dev *pdev)
 {
-       switch(pdev->device)
-       {
+#ifdef CONFIG_BLK_DEV_IDE_SATA
+       switch(pdev->device) {
                case PCI_DEVICE_ID_SII_3112:
                case PCI_DEVICE_ID_SII_1210SA:
                        return 1;
@@ -66,9 +63,10 @@ static int pdev_is_sata(struct pci_dev *pdev)
                        return 0;
        }
        BUG();
+#endif
        return 0;
 }
+
 /**
  *     is_sata                 -       check if hwif is SATA
  *     @hwif:  interface to check
@@ -78,7 +76,7 @@ static int pdev_is_sata(struct pci_dev *pdev)
  
 static inline int is_sata(ide_hwif_t *hwif)
 {
-       return pdev_is_sata(hwif->pci_dev);
+       return pdev_is_sata(to_pci_dev(hwif->dev));
 }
 
 /**
@@ -126,6 +124,54 @@ static inline unsigned long siimage_seldev(ide_drive_t *drive, int r)
        return base;
 }
 
+static u8 sil_ioread8(struct pci_dev *dev, unsigned long addr)
+{
+       u8 tmp = 0;
+
+       if (pci_get_drvdata(dev))
+               tmp = readb((void __iomem *)addr);
+       else
+               pci_read_config_byte(dev, addr, &tmp);
+
+       return tmp;
+}
+
+static u16 sil_ioread16(struct pci_dev *dev, unsigned long addr)
+{
+       u16 tmp = 0;
+
+       if (pci_get_drvdata(dev))
+               tmp = readw((void __iomem *)addr);
+       else
+               pci_read_config_word(dev, addr, &tmp);
+
+       return tmp;
+}
+
+static void sil_iowrite8(struct pci_dev *dev, u8 val, unsigned long addr)
+{
+       if (pci_get_drvdata(dev))
+               writeb(val, (void __iomem *)addr);
+       else
+               pci_write_config_byte(dev, addr, val);
+}
+
+static void sil_iowrite16(struct pci_dev *dev, u16 val, unsigned long addr)
+{
+       if (pci_get_drvdata(dev))
+               writew(val, (void __iomem *)addr);
+       else
+               pci_write_config_word(dev, addr, val);
+}
+
+static void sil_iowrite32(struct pci_dev *dev, u32 val, unsigned long addr)
+{
+       if (pci_get_drvdata(dev))
+               writel(val, (void __iomem *)addr);
+       else
+               pci_write_config_dword(dev, addr, val);
+}
+
 /**
  *     sil_udma_filter         -       compute UDMA mask
  *     @drive: IDE device
@@ -136,34 +182,32 @@ static inline unsigned long siimage_seldev(ide_drive_t *drive, int r)
  *     SI3112 SATA controller life is a bit simpler.
  */
 
-static u8 sil_udma_filter(ide_drive_t *drive)
+static u8 sil_pata_udma_filter(ide_drive_t *drive)
 {
        ide_hwif_t *hwif = drive->hwif;
+       struct pci_dev *dev = to_pci_dev(hwif->dev);
        unsigned long base = (unsigned long) hwif->hwif_data;
-       u8 mask = 0, scsc = 0;
+       u8 mask = 0, scsc;
 
-       if (hwif->mmio)
-               scsc = hwif->INB(base + 0x4A);
-       else
-               pci_read_config_byte(hwif->pci_dev, 0x8A, &scsc);
-
-       if (is_sata(hwif)) {
-               mask = strstr(drive->id->model, "Maxtor") ? 0x3f : 0x7f;
-               goto out;
-       }
+       scsc = sil_ioread8(dev, base + (hwif->mmio ? 0x4A : 0x8A));
 
        if ((scsc & 0x30) == 0x10)      /* 133 */
-               mask = 0x7f;
+               mask = ATA_UDMA6;
        else if ((scsc & 0x30) == 0x20) /* 2xPCI */
-               mask = 0x7f;
+               mask = ATA_UDMA6;
        else if ((scsc & 0x30) == 0x00) /* 100 */
-               mask = 0x3f;
+               mask = ATA_UDMA5;
        else    /* Disabled ? */
                BUG();
-out:
+
        return mask;
 }
 
+static u8 sil_sata_udma_filter(ide_drive_t *drive)
+{
+       return strstr(drive->id->model, "Maxtor") ? ATA_UDMA5 : ATA_UDMA6;
+}
+
 /**
  *     sil_set_pio_mode        -       set host controller for PIO mode
  *     @drive: drive
@@ -180,6 +224,7 @@ static void sil_set_pio_mode(ide_drive_t *drive, u8 pio)
        const u16 data_speed[]  = { 0x328a, 0x2283, 0x1104, 0x10c3, 0x10c1 };
 
        ide_hwif_t *hwif        = HWIF(drive);
+       struct pci_dev *dev     = to_pci_dev(hwif->dev);
        ide_drive_t *pair       = ide_get_paired_drive(drive);
        u32 speedt              = 0;
        u16 speedp              = 0;
@@ -204,34 +249,20 @@ static void sil_set_pio_mode(ide_drive_t *drive, u8 pio)
        speedp = data_speed[pio];
        speedt = tf_speed[tf_pio];
 
-       if (hwif->mmio) {
-               hwif->OUTW(speedp, addr);
-               hwif->OUTW(speedt, tfaddr);
-               /* Now set up IORDY */
-               if (pio > 2)
-                       hwif->OUTW(hwif->INW(tfaddr-2)|0x200, tfaddr-2);
-               else
-                       hwif->OUTW(hwif->INW(tfaddr-2)&~0x200, tfaddr-2);
-
-               mode = hwif->INB(base + addr_mask);
-               mode &= ~(unit ? 0x30 : 0x03);
-               mode |= (unit ? 0x10 : 0x01);
-               hwif->OUTB(mode, base + addr_mask);
-       } else {
-               pci_write_config_word(hwif->pci_dev, addr, speedp);
-               pci_write_config_word(hwif->pci_dev, tfaddr, speedt);
-               pci_read_config_word(hwif->pci_dev, tfaddr-2, &speedp);
-               speedp &= ~0x200;
-               /* Set IORDY for mode 3 or 4 */
-               if (pio > 2)
-                       speedp |= 0x200;
-               pci_write_config_word(hwif->pci_dev, tfaddr-2, speedp);
-
-               pci_read_config_byte(hwif->pci_dev, addr_mask, &mode);
-               mode &= ~(unit ? 0x30 : 0x03);
-               mode |= (unit ? 0x10 : 0x01);
-               pci_write_config_byte(hwif->pci_dev, addr_mask, mode);
-       }
+       sil_iowrite16(dev, speedp, addr);
+       sil_iowrite16(dev, speedt, tfaddr);
+
+       /* now set up IORDY */
+       speedp = sil_ioread16(dev, tfaddr - 2);
+       speedp &= ~0x200;
+       if (pio > 2)
+               speedp |= 0x200;
+       sil_iowrite16(dev, speedp, tfaddr - 2);
+
+       mode = sil_ioread8(dev, base + addr_mask);
+       mode &= ~(unit ? 0x30 : 0x03);
+       mode |= (unit ? 0x10 : 0x01);
+       sil_iowrite8(dev, mode, base + addr_mask);
 }
 
 /**
@@ -249,6 +280,7 @@ static void sil_set_dma_mode(ide_drive_t *drive, const u8 speed)
        u16 dma[]               = { 0x2208, 0x10C2, 0x10C1 };
 
        ide_hwif_t *hwif        = HWIF(drive);
+       struct pci_dev *dev     = to_pci_dev(hwif->dev);
        u16 ultra = 0, multi    = 0;
        u8 mode = 0, unit       = drive->select.b.unit;
        unsigned long base      = (unsigned long)hwif->hwif_data;
@@ -259,17 +291,10 @@ static void sil_set_dma_mode(ide_drive_t *drive, const u8 speed)
        unsigned long ma        = siimage_seldev(drive, 0x08);
        unsigned long ua        = siimage_seldev(drive, 0x0C);
 
-       if (hwif->mmio) {
-               scsc = hwif->INB(base + 0x4A);
-               mode = hwif->INB(base + addr_mask);
-               multi = hwif->INW(ma);
-               ultra = hwif->INW(ua);
-       } else {
-               pci_read_config_byte(hwif->pci_dev, 0x8A, &scsc);
-               pci_read_config_byte(hwif->pci_dev, addr_mask, &mode);
-               pci_read_config_word(hwif->pci_dev, ma, &multi);
-               pci_read_config_word(hwif->pci_dev, ua, &ultra);
-       }
+       scsc = sil_ioread8(dev, base + (hwif->mmio ? 0x4A : 0x8A));
+       mode = sil_ioread8(dev, base + addr_mask);
+       multi = sil_ioread16(dev, ma);
+       ultra = sil_ioread16(dev, ua);
 
        mode &= ~((unit) ? 0x30 : 0x03);
        ultra &= ~0x3F;
@@ -277,44 +302,26 @@ static void sil_set_dma_mode(ide_drive_t *drive, const u8 speed)
 
        scsc = is_sata(hwif) ? 1 : scsc;
 
-       switch(speed) {
-               case XFER_MW_DMA_2:
-               case XFER_MW_DMA_1:
-               case XFER_MW_DMA_0:
-                       multi = dma[speed - XFER_MW_DMA_0];
-                       mode |= ((unit) ? 0x20 : 0x02);
-                       break;
-               case XFER_UDMA_6:
-               case XFER_UDMA_5:
-               case XFER_UDMA_4:
-               case XFER_UDMA_3:
-               case XFER_UDMA_2:
-               case XFER_UDMA_1:
-               case XFER_UDMA_0:
-                       multi = dma[2];
-                       ultra |= ((scsc) ? (ultra6[speed - XFER_UDMA_0]) :
-                                          (ultra5[speed - XFER_UDMA_0]));
-                       mode |= ((unit) ? 0x30 : 0x03);
-                       break;
-               default:
-                       return;
-       }
-
-       if (hwif->mmio) {
-               hwif->OUTB(mode, base + addr_mask);
-               hwif->OUTW(multi, ma);
-               hwif->OUTW(ultra, ua);
+       if (speed >= XFER_UDMA_0) {
+               multi = dma[2];
+               ultra |= (scsc ? ultra6[speed - XFER_UDMA_0] :
+                                ultra5[speed - XFER_UDMA_0]);
+               mode |= (unit ? 0x30 : 0x03);
        } else {
-               pci_write_config_byte(hwif->pci_dev, addr_mask, mode);
-               pci_write_config_word(hwif->pci_dev, ma, multi);
-               pci_write_config_word(hwif->pci_dev, ua, ultra);
+               multi = dma[speed - XFER_MW_DMA_0];
+               mode |= (unit ? 0x20 : 0x02);
        }
+
+       sil_iowrite8(dev, mode, base + addr_mask);
+       sil_iowrite16(dev, multi, ma);
+       sil_iowrite16(dev, ultra, ua);
 }
 
 /* returns 1 if dma irq issued, 0 otherwise */
-static int siimage_io_ide_dma_test_irq (ide_drive_t *drive)
+static int siimage_io_dma_test_irq(ide_drive_t *drive)
 {
        ide_hwif_t *hwif        = HWIF(drive);
+       struct pci_dev *dev     = to_pci_dev(hwif->dev);
        u8 dma_altstat          = 0;
        unsigned long addr      = siimage_selreg(hwif, 1);
 
@@ -323,37 +330,41 @@ static int siimage_io_ide_dma_test_irq (ide_drive_t *drive)
                return 1;
 
        /* return 1 if Device INTR asserted */
-       pci_read_config_byte(hwif->pci_dev, addr, &dma_altstat);
+       pci_read_config_byte(dev, addr, &dma_altstat);
        if (dma_altstat & 8)
                return 0;       //return 1;
        return 0;
 }
 
 /**
- *     siimage_mmio_ide_dma_test_irq   -       check we caused an IRQ
+ *     siimage_mmio_dma_test_irq       -       check we caused an IRQ
  *     @drive: drive we are testing
  *
  *     Check if we caused an IDE DMA interrupt. We may also have caused
  *     SATA status interrupts, if so we clean them up and continue.
  */
-static int siimage_mmio_ide_dma_test_irq (ide_drive_t *drive)
+
+static int siimage_mmio_dma_test_irq(ide_drive_t *drive)
 {
        ide_hwif_t *hwif        = HWIF(drive);
-       unsigned long base      = (unsigned long)hwif->hwif_data;
        unsigned long addr      = siimage_selreg(hwif, 0x1);
+       void __iomem *sata_error_addr
+               = (void __iomem *)hwif->sata_scr[SATA_ERROR_OFFSET];
 
-       if (SATA_ERROR_REG) {
+       if (sata_error_addr) {
+               unsigned long base = (unsigned long)hwif->hwif_data;
                u32 ext_stat = readl((void __iomem *)(base + 0x10));
                u8 watchdog = 0;
+
                if (ext_stat & ((hwif->channel) ? 0x40 : 0x10)) {
-                       u32 sata_error = readl((void __iomem *)SATA_ERROR_REG);
-                       writel(sata_error, (void __iomem *)SATA_ERROR_REG);
+                       u32 sata_error = readl(sata_error_addr);
+
+                       writel(sata_error, sata_error_addr);
                        watchdog = (sata_error & 0x00680000) ? 1 : 0;
                        printk(KERN_WARNING "%s: sata_error = 0x%08x, "
                                "watchdog = %d, %s\n",
                                drive->name, sata_error, watchdog,
-                               __FUNCTION__);
+                               __func__);
 
                } else {
                        watchdog = (ext_stat & 0x8000) ? 1 : 0;
@@ -375,161 +386,60 @@ static int siimage_mmio_ide_dma_test_irq (ide_drive_t *drive)
        return 0;
 }
 
-/**
- *     siimage_busproc         -       bus isolation ioctl
- *     @drive: drive to isolate/restore
- *     @state: bus state to set
- *
- *     Used by the SII3112 to handle bus isolation. As this is a 
- *     SATA controller the work required is quite limited, we 
- *     just have to clean up the statistics
- */
-static int siimage_busproc (ide_drive_t * drive, int state)
+static int siimage_dma_test_irq(ide_drive_t *drive)
 {
-       ide_hwif_t *hwif        = HWIF(drive);
-       u32 stat_config         = 0;
-       unsigned long addr      = siimage_selreg(hwif, 0);
-
-       if (hwif->mmio)
-               stat_config = readl((void __iomem *)addr);
+       if (drive->hwif->mmio)
+               return siimage_mmio_dma_test_irq(drive);
        else
-               pci_read_config_dword(hwif->pci_dev, addr, &stat_config);
-
-       switch (state) {
-               case BUSSTATE_ON:
-                       hwif->drives[0].failures = 0;
-                       hwif->drives[1].failures = 0;
-                       break;
-               case BUSSTATE_OFF:
-                       hwif->drives[0].failures = hwif->drives[0].max_failures + 1;
-                       hwif->drives[1].failures = hwif->drives[1].max_failures + 1;
-                       break;
-               case BUSSTATE_TRISTATE:
-                       hwif->drives[0].failures = hwif->drives[0].max_failures + 1;
-                       hwif->drives[1].failures = hwif->drives[1].max_failures + 1;
-                       break;
-               default:
-                       return -EINVAL;
-       }
-       hwif->bus_state = state;
-       return 0;
+               return siimage_io_dma_test_irq(drive);
 }
 
 /**
- *     siimage_reset_poll      -       wait for sata reset
+ *     sil_sata_reset_poll     -       wait for SATA reset
  *     @drive: drive we are resetting
  *
  *     Poll the SATA phy and see whether it has come back from the dead
  *     yet.
  */
-static int siimage_reset_poll (ide_drive_t *drive)
+
+static int sil_sata_reset_poll(ide_drive_t *drive)
 {
-       if (SATA_STATUS_REG) {
-               ide_hwif_t *hwif        = HWIF(drive);
+       ide_hwif_t *hwif = drive->hwif;
+       void __iomem *sata_status_addr
+               = (void __iomem *)hwif->sata_scr[SATA_STATUS_OFFSET];
 
-               /* SATA_STATUS_REG is valid only when in MMIO mode */
-               if ((readl((void __iomem *)SATA_STATUS_REG) & 0x03) != 0x03) {
+       if (sata_status_addr) {
+               /* SATA Status is available only when in MMIO mode */
+               u32 sata_stat = readl(sata_status_addr);
+
+               if ((sata_stat & 0x03) != 0x03) {
                        printk(KERN_WARNING "%s: reset phy dead, status=0x%08x\n",
-                               hwif->name, readl((void __iomem *)SATA_STATUS_REG));
+                                           hwif->name, sata_stat);
                        HWGROUP(drive)->polling = 0;
                        return ide_started;
                }
-               return 0;
-       } else {
-               return 0;
        }
+
+       return 0;
 }
 
 /**
- *     siimage_pre_reset       -       reset hook
+ *     sil_sata_pre_reset      -       reset hook
  *     @drive: IDE device being reset
  *
  *     For the SATA devices we need to handle recalibration/geometry
  *     differently
  */
-static void siimage_pre_reset (ide_drive_t *drive)
-{
-       if (drive->media != ide_disk)
-               return;
 
-       if (is_sata(HWIF(drive)))
-       {
+static void sil_sata_pre_reset(ide_drive_t *drive)
+{
+       if (drive->media == ide_disk) {
                drive->special.b.set_geometry = 0;
                drive->special.b.recalibrate = 0;
        }
 }
 
 /**
- *     siimage_reset   -       reset a device on an siimage controller
- *     @drive: drive to reset
- *
- *     Perform a controller level reset fo the device. For
- *     SATA we must also check the PHY.
- */
-static void siimage_reset (ide_drive_t *drive)
-{
-       ide_hwif_t *hwif        = HWIF(drive);
-       u8 reset                = 0;
-       unsigned long addr      = siimage_selreg(hwif, 0);
-
-       if (hwif->mmio) {
-               reset = hwif->INB(addr);
-               hwif->OUTB((reset|0x03), addr);
-               /* FIXME:posting */
-               udelay(25);
-               hwif->OUTB(reset, addr);
-               (void) hwif->INB(addr);
-       } else {
-               pci_read_config_byte(hwif->pci_dev, addr, &reset);
-               pci_write_config_byte(hwif->pci_dev, addr, reset|0x03);
-               udelay(25);
-               pci_write_config_byte(hwif->pci_dev, addr, reset);
-               pci_read_config_byte(hwif->pci_dev, addr, &reset);
-       }
-
-       if (SATA_STATUS_REG) {
-               /* SATA_STATUS_REG is valid only when in MMIO mode */
-               u32 sata_stat = readl((void __iomem *)SATA_STATUS_REG);
-               printk(KERN_WARNING "%s: reset phy, status=0x%08x, %s\n",
-                       hwif->name, sata_stat, __FUNCTION__);
-               if (!(sata_stat)) {
-                       printk(KERN_WARNING "%s: reset phy dead, status=0x%08x\n",
-                               hwif->name, sata_stat);
-                       drive->failures++;
-               }
-       }
-
-}
-
-/**
- *     proc_reports_siimage            -       add siimage controller to proc
- *     @dev: PCI device
- *     @clocking: SCSC value
- *     @name: controller name
- *
- *     Report the clocking mode of the controller and add it to
- *     the /proc interface layer
- */
-static void proc_reports_siimage (struct pci_dev *dev, u8 clocking, const char *name)
-{
-       if (!pdev_is_sata(dev)) {
-               printk(KERN_INFO "%s: BASE CLOCK ", name);
-               clocking &= 0x03;
-               switch (clocking) {
-                       case 0x03: printk("DISABLED!\n"); break;
-                       case 0x02: printk("== 2X PCI\n"); break;
-                       case 0x01: printk("== 133\n"); break;
-                       case 0x00: printk("== 100\n"); break;
-               }
-       }
-}
-
-/**
  *     setup_mmio_siimage      -       switch an SI controller into MMIO
  *     @dev: PCI device we are configuring
  *     @name: device name
@@ -541,28 +451,23 @@ static void proc_reports_siimage (struct pci_dev *dev, u8 clocking, const char *
  
 static unsigned int setup_mmio_siimage (struct pci_dev *dev, const char *name)
 {
-       unsigned long bar5      = pci_resource_start(dev, 5);
+       resource_size_t bar5    = pci_resource_start(dev, 5);
        unsigned long barsize   = pci_resource_len(dev, 5);
-       u8 tmpbyte      = 0;
        void __iomem *ioaddr;
-       u32 tmp, irq_mask;
 
        /*
         *      Drop back to PIO if we can't map the mmio. Some
         *      systems seem to get terminally confused in the PCI
         *      spaces.
         */
-        
-       if(!request_mem_region(bar5, barsize, name))
-       {
+       if (!request_mem_region(bar5, barsize, name)) {
                printk(KERN_WARNING "siimage: IDE controller MMIO ports not available.\n");
                return 0;
        }
-               
+
        ioaddr = ioremap(bar5, barsize);
 
-       if (ioaddr == NULL)
-       {
+       if (ioaddr == NULL) {
                release_mem_region(bar5, barsize);
                return 0;
        }
@@ -570,62 +475,6 @@ static unsigned int setup_mmio_siimage (struct pci_dev *dev, const char *name)
        pci_set_master(dev);
        pci_set_drvdata(dev, (void *) ioaddr);
 
-       if (pdev_is_sata(dev)) {
-               /* make sure IDE0/1 interrupts are not masked */
-               irq_mask = (1 << 22) | (1 << 23);
-               tmp = readl(ioaddr + 0x48);
-               if (tmp & irq_mask) {
-                       tmp &= ~irq_mask;
-                       writel(tmp, ioaddr + 0x48);
-                       readl(ioaddr + 0x48); /* flush */
-               }
-               writel(0, ioaddr + 0x148);
-               writel(0, ioaddr + 0x1C8);
-       }
-
-       writeb(0, ioaddr + 0xB4);
-       writeb(0, ioaddr + 0xF4);
-       tmpbyte = readb(ioaddr + 0x4A);
-
-       switch(tmpbyte & 0x30) {
-               case 0x00:
-                       /* In 100 MHz clocking, try and switch to 133 */
-                       writeb(tmpbyte|0x10, ioaddr + 0x4A);
-                       break;
-               case 0x10:
-                       /* On 133Mhz clocking */
-                       break;
-               case 0x20:
-                       /* On PCIx2 clocking */
-                       break;
-               case 0x30:
-                       /* Clocking is disabled */
-                       /* 133 clock attempt to force it on */
-                       writeb(tmpbyte & ~0x20, ioaddr + 0x4A);
-                       break;
-       }
-       
-       writeb(      0x72, ioaddr + 0xA1);
-       writew(    0x328A, ioaddr + 0xA2);
-       writel(0x62DD62DD, ioaddr + 0xA4);
-       writel(0x43924392, ioaddr + 0xA8);
-       writel(0x40094009, ioaddr + 0xAC);
-       writeb(      0x72, ioaddr + 0xE1);
-       writew(    0x328A, ioaddr + 0xE2);
-       writel(0x62DD62DD, ioaddr + 0xE4);
-       writel(0x43924392, ioaddr + 0xE8);
-       writel(0x40094009, ioaddr + 0xEC);
-
-       if (pdev_is_sata(dev)) {
-               writel(0xFFFF0000, ioaddr + 0x108);
-               writel(0xFFFF0000, ioaddr + 0x188);
-               writel(0x00680000, ioaddr + 0x148);
-               writel(0x00680000, ioaddr + 0x1C8);
-       }
-
-       tmpbyte = readb(ioaddr + 0x4A);
-
-       proc_reports_siimage(dev, (tmpbyte>>4), name);
        return 1;
 }
 
@@ -640,50 +489,87 @@ static unsigned int setup_mmio_siimage (struct pci_dev *dev, const char *name)
 
 static unsigned int __devinit init_chipset_siimage(struct pci_dev *dev, const char *name)
 {
-       u8 rev = dev->revision, tmpbyte = 0, BA5_EN = 0;
+       unsigned long base, scsc_addr;
+       void __iomem *ioaddr = NULL;
+       u8 rev = dev->revision, tmp = 0, BA5_EN = 0;
 
        pci_write_config_byte(dev, PCI_CACHE_LINE_SIZE, rev ? 1 : 255);
 
        pci_read_config_byte(dev, 0x8A, &BA5_EN);
-       if ((BA5_EN & 0x01) || (pci_resource_start(dev, 5))) {
-               if (setup_mmio_siimage(dev, name)) {
-                       return 0;
+
+       if ((BA5_EN & 0x01) || pci_resource_start(dev, 5)) {
+               if (setup_mmio_siimage(dev, name))
+                       ioaddr = pci_get_drvdata(dev);
+       }
+
+       base = (unsigned long)ioaddr;
+
+       if (ioaddr && pdev_is_sata(dev)) {
+               u32 tmp32, irq_mask;
+
+               /* make sure IDE0/1 interrupts are not masked */
+               irq_mask = (1 << 22) | (1 << 23);
+               tmp32 = readl(ioaddr + 0x48);
+               if (tmp32 & irq_mask) {
+                       tmp32 &= ~irq_mask;
+                       writel(tmp32, ioaddr + 0x48);
+                       readl(ioaddr + 0x48); /* flush */
                }
+               writel(0, ioaddr + 0x148);
+               writel(0, ioaddr + 0x1C8);
        }
 
-       pci_write_config_byte(dev, 0x80, 0x00);
-       pci_write_config_byte(dev, 0x84, 0x00);
-       pci_read_config_byte(dev, 0x8A, &tmpbyte);
-       switch(tmpbyte & 0x30) {
-               case 0x00:
-                       /* 133 clock attempt to force it on */
-                       pci_write_config_byte(dev, 0x8A, tmpbyte|0x10);
-               case 0x30:
-                       /* if clocking is disabled */
-                       /* 133 clock attempt to force it on */
-                       pci_write_config_byte(dev, 0x8A, tmpbyte & ~0x20);
-               case 0x10:
-                       /* 133 already */
-                       break;
-               case 0x20:
-                       /* BIOS set PCI x2 clocking */
-                       break;
+       sil_iowrite8(dev, 0, base ? (base + 0xB4) : 0x80);
+       sil_iowrite8(dev, 0, base ? (base + 0xF4) : 0x84);
+
+       scsc_addr = base ? (base + 0x4A) : 0x8A;
+       tmp = sil_ioread8(dev, scsc_addr);
+
+       switch (tmp & 0x30) {
+       case 0x00:
+               /* On 100MHz clocking, try and switch to 133MHz */
+               sil_iowrite8(dev, tmp | 0x10, scsc_addr);
+               break;
+       case 0x30:
+               /* Clocking is disabled, attempt to force 133MHz clocking. */
+               sil_iowrite8(dev, tmp & ~0x20, scsc_addr);
+       case 0x10:
+               /* On 133Mhz clocking. */
+               break;
+       case 0x20:
+               /* On PCIx2 clocking. */
+               break;
        }
 
-       pci_read_config_byte(dev,   0x8A, &tmpbyte);
+       tmp = sil_ioread8(dev, scsc_addr);
 
-       pci_write_config_byte(dev,  0xA1, 0x72);
-       pci_write_config_word(dev,  0xA2, 0x328A);
-       pci_write_config_dword(dev, 0xA4, 0x62DD62DD);
-       pci_write_config_dword(dev, 0xA8, 0x43924392);
-       pci_write_config_dword(dev, 0xAC, 0x40094009);
-       pci_write_config_byte(dev,  0xB1, 0x72);
-       pci_write_config_word(dev,  0xB2, 0x328A);
-       pci_write_config_dword(dev, 0xB4, 0x62DD62DD);
-       pci_write_config_dword(dev, 0xB8, 0x43924392);
-       pci_write_config_dword(dev, 0xBC, 0x40094009);
+       sil_iowrite8(dev,        0x72, base + 0xA1);
+       sil_iowrite16(dev,     0x328A, base + 0xA2);
+       sil_iowrite32(dev, 0x62DD62DD, base + 0xA4);
+       sil_iowrite32(dev, 0x43924392, base + 0xA8);
+       sil_iowrite32(dev, 0x40094009, base + 0xAC);
+       sil_iowrite8(dev,        0x72, base ? (base + 0xE1) : 0xB1);
+       sil_iowrite16(dev,     0x328A, base ? (base + 0xE2) : 0xB2);
+       sil_iowrite32(dev, 0x62DD62DD, base ? (base + 0xE4) : 0xB4);
+       sil_iowrite32(dev, 0x43924392, base ? (base + 0xE8) : 0xB8);
+       sil_iowrite32(dev, 0x40094009, base ? (base + 0xEC) : 0xBC);
+
+       if (base && pdev_is_sata(dev)) {
+               writel(0xFFFF0000, ioaddr + 0x108);
+               writel(0xFFFF0000, ioaddr + 0x188);
+               writel(0x00680000, ioaddr + 0x148);
+               writel(0x00680000, ioaddr + 0x1C8);
+       }
+
+       /* report the clocking mode of the controller */
+       if (!pdev_is_sata(dev)) {
+               static const char *clk_str[] =
+                       { "== 100", "== 133", "== 2X PCI", "DISABLED!" };
+
+               tmp >>= 4;
+               printk(KERN_INFO "%s: BASE CLOCK %s\n", name, clk_str[tmp & 3]);
+       }
 
-       proc_reports_siimage(dev, (tmpbyte>>4), name);
        return 0;
 }
 
@@ -702,16 +588,18 @@ static unsigned int __devinit init_chipset_siimage(struct pci_dev *dev, const ch
 
 static void __devinit init_mmio_iops_siimage(ide_hwif_t *hwif)
 {
-       struct pci_dev *dev     = hwif->pci_dev;
+       struct pci_dev *dev     = to_pci_dev(hwif->dev);
        void *addr              = pci_get_drvdata(dev);
        u8 ch                   = hwif->channel;
-       hw_regs_t               hw;
        unsigned long           base;
 
+       struct ide_io_ports *io_ports = &hwif->io_ports;
+
        /*
         *      Fill in the basic HWIF bits
         */
 
+       hwif->host_flags |= IDE_HFLAG_MMIO;
        default_hwif_mmiops(hwif);
        hwif->hwif_data                 = addr;
 
@@ -721,7 +609,7 @@ static void __devinit init_mmio_iops_siimage(ide_hwif_t *hwif)
         *      based I/O
         */
 
-       memset(&hw, 0, sizeof(hw_regs_t));
+       memset(io_ports, 0, sizeof(*io_ports));
 
        base = (unsigned long)addr;
        if (ch)
@@ -734,17 +622,15 @@ static void __devinit init_mmio_iops_siimage(ide_hwif_t *hwif)
         *      so we can't currently use it sanely since we want to
         *      use LBA48 mode.
         */     
-       hw.io_ports[IDE_DATA_OFFSET]    = base;
-       hw.io_ports[IDE_ERROR_OFFSET]   = base + 1;
-       hw.io_ports[IDE_NSECTOR_OFFSET] = base + 2;
-       hw.io_ports[IDE_SECTOR_OFFSET]  = base + 3;
-       hw.io_ports[IDE_LCYL_OFFSET]    = base + 4;
-       hw.io_ports[IDE_HCYL_OFFSET]    = base + 5;
-       hw.io_ports[IDE_SELECT_OFFSET]  = base + 6;
-       hw.io_ports[IDE_STATUS_OFFSET]  = base + 7;
-       hw.io_ports[IDE_CONTROL_OFFSET] = base + 10;
-
-       hw.io_ports[IDE_IRQ_OFFSET]     = 0;
+       io_ports->data_addr     = base;
+       io_ports->error_addr    = base + 1;
+       io_ports->nsect_addr    = base + 2;
+       io_ports->lbal_addr     = base + 3;
+       io_ports->lbam_addr     = base + 4;
+       io_ports->lbah_addr     = base + 5;
+       io_ports->device_addr   = base + 6;
+       io_ports->status_addr   = base + 7;
+       io_ports->ctl_addr      = base + 10;
 
        if (pdev_is_sata(dev)) {
                base = (unsigned long)addr;
@@ -753,21 +639,11 @@ static void __devinit init_mmio_iops_siimage(ide_hwif_t *hwif)
                hwif->sata_scr[SATA_STATUS_OFFSET]      = base + 0x104;
                hwif->sata_scr[SATA_ERROR_OFFSET]       = base + 0x108;
                hwif->sata_scr[SATA_CONTROL_OFFSET]     = base + 0x100;
-               hwif->sata_misc[SATA_MISC_OFFSET]       = base + 0x140;
-               hwif->sata_misc[SATA_PHY_OFFSET]        = base + 0x144;
-               hwif->sata_misc[SATA_IEN_OFFSET]        = base + 0x148;
        }
 
-       hw.irq                          = hwif->pci_dev->irq;
-
-       memcpy(&hwif->hw, &hw, sizeof(hw));
-       memcpy(hwif->io_ports, hwif->hw.io_ports, sizeof(hwif->hw.io_ports));
+       hwif->irq = dev->irq;
 
-       hwif->irq                       = hw.irq;
-
-               base = (unsigned long) addr;
-
-       hwif->dma_base                  = base + (ch ? 0x08 : 0x00);
+       hwif->dma_base = (unsigned long)addr + (ch ? 0x08 : 0x00);
 
        hwif->mmio = 1;
 }
@@ -777,9 +653,6 @@ static int is_dev_seagate_sata(ide_drive_t *drive)
        const char *s = &drive->id->model[0];
        unsigned len;
 
-       if (!drive->present)
-               return 0;
-
        len = strnlen(s, sizeof(drive->id->model));
 
        if ((len > 4) && (!memcmp(s, "ST", 2))) {
@@ -794,18 +667,20 @@ static int is_dev_seagate_sata(ide_drive_t *drive)
 }
 
 /**
- *     siimage_fixup           -       post probe fixups
- *     @hwif: interface to fix up
+ *     sil_quirkproc           -       post probe fixups
+ *     @drive: drive
  *
  *     Called after drive probe we use this to decide whether the
  *     Seagate fixup must be applied. This used to be in init_iops but
  *     that can occur before we know what drives are present.
  */
 
-static void __devinit siimage_fixup(ide_hwif_t *hwif)
+static void __devinit sil_quirkproc(ide_drive_t *drive)
 {
+       ide_hwif_t *hwif = drive->hwif;
+
        /* Try and raise the rqsize */
-       if (!is_sata(hwif) || !is_dev_seagate_sata(&hwif->drives[0]))
+       if (!is_sata(hwif) || !is_dev_seagate_sata(drive))
                hwif->rqsize = 128;
 }
 
@@ -821,100 +696,74 @@ static void __devinit siimage_fixup(ide_hwif_t *hwif)
 
 static void __devinit init_iops_siimage(ide_hwif_t *hwif)
 {
+       struct pci_dev *dev = to_pci_dev(hwif->dev);
+
        hwif->hwif_data = NULL;
 
        /* Pessimal until we finish probing */
        hwif->rqsize = 15;
 
-       if (pci_get_drvdata(hwif->pci_dev) == NULL)
+       if (pci_get_drvdata(dev) == NULL)
                return;
 
        init_mmio_iops_siimage(hwif);
 }
 
 /**
- *     ata66_siimage   -       check for 80 pin cable
+ *     sil_cable_detect        -       cable detection
  *     @hwif: interface to check
  *
  *     Check for the presence of an ATA66 capable cable on the
  *     interface.
  */
 
-static u8 __devinit ata66_siimage(ide_hwif_t *hwif)
+static u8 __devinit sil_cable_detect(ide_hwif_t *hwif)
 {
+       struct pci_dev *dev = to_pci_dev(hwif->dev);
        unsigned long addr = siimage_selreg(hwif, 0);
-       u8 ata66 = 0;
-
-       if (pci_get_drvdata(hwif->pci_dev) == NULL)
-               pci_read_config_byte(hwif->pci_dev, addr, &ata66);
-       else
-               ata66 = hwif->INB(addr);
+       u8 ata66 = sil_ioread8(dev, addr);
 
        return (ata66 & 0x01) ? ATA_CBL_PATA80 : ATA_CBL_PATA40;
 }
 
-/**
- *     init_hwif_siimage       -       set up hwif structs
- *     @hwif: interface to set up
- *
- *     We do the basic set up of the interface structure. The SIIMAGE
- *     requires several custom handlers so we override the default
- *     ide DMA handlers appropriately
- */
-
-static void __devinit init_hwif_siimage(ide_hwif_t *hwif)
-{
-       hwif->resetproc = &siimage_reset;
-       hwif->set_pio_mode = &sil_set_pio_mode;
-       hwif->set_dma_mode = &sil_set_dma_mode;
-       hwif->reset_poll = &siimage_reset_poll;
-       hwif->pre_reset = &siimage_pre_reset;
-       hwif->udma_filter = &sil_udma_filter;
-
-       if(is_sata(hwif)) {
-               static int first = 1;
-
-               hwif->busproc   = &siimage_busproc;
-
-               if (first) {
-                       printk(KERN_INFO "siimage: For full SATA support you should use the libata sata_sil module.\n");
-                       first = 0;
-               }
-       }
-
-       if (hwif->dma_base == 0)
-               return;
-
-       if (is_sata(hwif))
-               hwif->host_flags |= IDE_HFLAG_NO_ATAPI_DMA;
+static const struct ide_port_ops sil_pata_port_ops = {
+       .set_pio_mode           = sil_set_pio_mode,
+       .set_dma_mode           = sil_set_dma_mode,
+       .quirkproc              = sil_quirkproc,
+       .udma_filter            = sil_pata_udma_filter,
+       .cable_detect           = sil_cable_detect,
+};
 
-       if (hwif->cbl != ATA_CBL_PATA40_SHORT)
-               hwif->cbl = ata66_siimage(hwif);
+static const struct ide_port_ops sil_sata_port_ops = {
+       .set_pio_mode           = sil_set_pio_mode,
+       .set_dma_mode           = sil_set_dma_mode,
+       .reset_poll             = sil_sata_reset_poll,
+       .pre_reset              = sil_sata_pre_reset,
+       .quirkproc              = sil_quirkproc,
+       .udma_filter            = sil_sata_udma_filter,
+       .cable_detect           = sil_cable_detect,
+};
 
-       if (hwif->mmio) {
-               hwif->ide_dma_test_irq = &siimage_mmio_ide_dma_test_irq;
-       } else {
-               hwif->ide_dma_test_irq = & siimage_io_ide_dma_test_irq;
-       }
-}
+static struct ide_dma_ops sil_dma_ops = {
+       .dma_test_irq           = siimage_dma_test_irq,
+};
 
-#define DECLARE_SII_DEV(name_str)                      \
+#define DECLARE_SII_DEV(name_str, p_ops)               \
        {                                               \
                .name           = name_str,             \
                .init_chipset   = init_chipset_siimage, \
                .init_iops      = init_iops_siimage,    \
-               .init_hwif      = init_hwif_siimage,    \
-               .fixup          = siimage_fixup,        \
-               .host_flags     = IDE_HFLAG_BOOTABLE,   \
+               .port_ops       = p_ops,                \
+               .dma_ops        = &sil_dma_ops,         \
                .pio_mask       = ATA_PIO4,             \
                .mwdma_mask     = ATA_MWDMA2,           \
                .udma_mask      = ATA_UDMA6,            \
        }
 
-static ide_pci_device_t siimage_chipsets[] __devinitdata = {
-       /* 0 */ DECLARE_SII_DEV("SiI680"),
-       /* 1 */ DECLARE_SII_DEV("SiI3112 Serial ATA"),
-       /* 2 */ DECLARE_SII_DEV("Adaptec AAR-1210SA")
+static const struct ide_port_info siimage_chipsets[] __devinitdata = {
+       /* 0 */ DECLARE_SII_DEV("SiI680",               &sil_pata_port_ops),
+       /* 1 */ DECLARE_SII_DEV("SiI3112 Serial ATA",   &sil_sata_port_ops),
+       /* 2 */ DECLARE_SII_DEV("Adaptec AAR-1210SA",   &sil_sata_port_ops)
 };
 
 /**
@@ -928,7 +777,24 @@ static ide_pci_device_t siimage_chipsets[] __devinitdata = {
  
 static int __devinit siimage_init_one(struct pci_dev *dev, const struct pci_device_id *id)
 {
-       return ide_setup_pci_device(dev, &siimage_chipsets[id->driver_data]);
+       struct ide_port_info d;
+       u8 idx = id->driver_data;
+
+       d = siimage_chipsets[idx];
+
+       if (idx) {
+               static int first = 1;
+
+               if (first) {
+                       printk(KERN_INFO "siimage: For full SATA support you "
+                               "should use the libata sata_sil module.\n");
+                       first = 0;
+               }
+
+               d.host_flags |= IDE_HFLAG_NO_ATAPI_DMA;
+       }
+
+       return ide_setup_pci_device(dev, &d);
 }
 
 static const struct pci_device_id siimage_pci_tbl[] = {