cs5536: use ->pio_mode value to determine pair device speed
[safe/jmp/linux-2.6] / drivers / ide / ide-taskfile.c
index 0c908ca..cc8633c 100644 (file)
  *  The big the bad and the ugly.
  */
 
-#include <linux/module.h>
 #include <linux/types.h>
 #include <linux/string.h>
 #include <linux/kernel.h>
-#include <linux/timer.h>
-#include <linux/mm.h>
 #include <linux/sched.h>
 #include <linux/interrupt.h>
-#include <linux/major.h>
 #include <linux/errno.h>
-#include <linux/genhd.h>
-#include <linux/blkpg.h>
 #include <linux/slab.h>
-#include <linux/pci.h>
 #include <linux/delay.h>
 #include <linux/hdreg.h>
 #include <linux/ide.h>
-#include <linux/bitops.h>
 #include <linux/scatterlist.h>
+#include <linux/uaccess.h>
 
-#include <asm/byteorder.h>
-#include <asm/irq.h>
-#include <asm/uaccess.h>
 #include <asm/io.h>
 
-void ide_tf_dump(const char *s, struct ide_taskfile *tf)
+void ide_tf_readback(ide_drive_t *drive, struct ide_cmd *cmd)
+{
+       ide_hwif_t *hwif = drive->hwif;
+       const struct ide_tp_ops *tp_ops = hwif->tp_ops;
+
+       /* Be sure we're looking at the low order bytes */
+       tp_ops->write_devctl(hwif, ATA_DEVCTL_OBS);
+
+       tp_ops->tf_read(drive, &cmd->tf, cmd->valid.in.tf);
+
+       if (cmd->tf_flags & IDE_TFLAG_LBA48) {
+               tp_ops->write_devctl(hwif, ATA_HOB | ATA_DEVCTL_OBS);
+
+               tp_ops->tf_read(drive, &cmd->hob, cmd->valid.in.hob);
+       }
+}
+
+void ide_tf_dump(const char *s, struct ide_cmd *cmd)
 {
 #ifdef DEBUG
        printk("%s: tf: feat 0x%02x nsect 0x%02x lbal 0x%02x "
                "lbam 0x%02x lbah 0x%02x dev 0x%02x cmd 0x%02x\n",
-               s, tf->feature, tf->nsect, tf->lbal,
-               tf->lbam, tf->lbah, tf->device, tf->command);
-       printk("%s: hob: nsect 0x%02x lbal 0x%02x "
-               "lbam 0x%02x lbah 0x%02x\n",
-               s, tf->hob_nsect, tf->hob_lbal,
-               tf->hob_lbam, tf->hob_lbah);
+              s, cmd->tf.feature, cmd->tf.nsect,
+              cmd->tf.lbal, cmd->tf.lbam, cmd->tf.lbah,
+              cmd->tf.device, cmd->tf.command);
+       printk("%s: hob: nsect 0x%02x lbal 0x%02x lbam 0x%02x lbah 0x%02x\n",
+              s, cmd->hob.nsect, cmd->hob.lbal, cmd->hob.lbam, cmd->hob.lbah);
 #endif
 }
 
-int taskfile_lib_get_identify (ide_drive_t *drive, u8 *buf)
+int taskfile_lib_get_identify(ide_drive_t *drive, u8 *buf)
 {
-       ide_task_t args;
+       struct ide_cmd cmd;
 
-       memset(&args, 0, sizeof(ide_task_t));
-       args.tf.nsect = 0x01;
+       memset(&cmd, 0, sizeof(cmd));
+       cmd.tf.nsect = 0x01;
        if (drive->media == ide_disk)
-               args.tf.command = WIN_IDENTIFY;
+               cmd.tf.command = ATA_CMD_ID_ATA;
        else
-               args.tf.command = WIN_PIDENTIFY;
-       args.tf_flags   = IDE_TFLAG_TF | IDE_TFLAG_DEVICE;
-       args.data_phase = TASKFILE_IN;
-       return ide_raw_taskfile(drive, &args, buf, 1);
-}
+               cmd.tf.command = ATA_CMD_ID_ATAPI;
+       cmd.valid.out.tf = IDE_VALID_OUT_TF | IDE_VALID_DEVICE;
+       cmd.valid.in.tf  = IDE_VALID_IN_TF  | IDE_VALID_DEVICE;
+       cmd.protocol = ATA_PROT_PIO;
 
-static int inline task_dma_ok(ide_task_t *task)
-{
-       if (blk_fs_request(task->rq) || (task->tf_flags & IDE_TFLAG_FLAGGED))
-               return 1;
-
-       switch (task->tf.command) {
-               case WIN_WRITEDMA_ONCE:
-               case WIN_WRITEDMA:
-               case WIN_WRITEDMA_EXT:
-               case WIN_READDMA_ONCE:
-               case WIN_READDMA:
-               case WIN_READDMA_EXT:
-               case WIN_IDENTIFY_DMA:
-                       return 1;
-       }
-
-       return 0;
+       return ide_raw_taskfile(drive, &cmd, buf, 1);
 }
 
 static ide_startstop_t task_no_data_intr(ide_drive_t *);
-static ide_startstop_t set_geometry_intr(ide_drive_t *);
-static ide_startstop_t recal_intr(ide_drive_t *);
-static ide_startstop_t set_multmode_intr(ide_drive_t *);
-static ide_startstop_t pre_task_out_intr(ide_drive_t *, struct request *);
-static ide_startstop_t task_in_intr(ide_drive_t *);
+static ide_startstop_t pre_task_out_intr(ide_drive_t *, struct ide_cmd *);
+static ide_startstop_t task_pio_intr(ide_drive_t *);
 
-ide_startstop_t do_rw_taskfile (ide_drive_t *drive, ide_task_t *task)
+ide_startstop_t do_rw_taskfile(ide_drive_t *drive, struct ide_cmd *orig_cmd)
 {
-       ide_hwif_t *hwif        = HWIF(drive);
-       struct ide_taskfile *tf = &task->tf;
+       ide_hwif_t *hwif = drive->hwif;
+       struct ide_cmd *cmd = &hwif->cmd;
+       struct ide_taskfile *tf = &cmd->tf;
        ide_handler_t *handler = NULL;
+       const struct ide_tp_ops *tp_ops = hwif->tp_ops;
        const struct ide_dma_ops *dma_ops = hwif->dma_ops;
 
-       if (task->data_phase == TASKFILE_MULTI_IN ||
-           task->data_phase == TASKFILE_MULTI_OUT) {
-               if (!drive->mult_count) {
-                       printk(KERN_ERR "%s: multimode not set!\n",
-                                       drive->name);
-                       return ide_stopped;
-               }
+       if (orig_cmd->protocol == ATA_PROT_PIO &&
+           (orig_cmd->tf_flags & IDE_TFLAG_MULTI_PIO) &&
+           drive->mult_count == 0) {
+               pr_err("%s: multimode not set!\n", drive->name);
+               return ide_stopped;
        }
 
-       if (task->tf_flags & IDE_TFLAG_FLAGGED)
-               task->tf_flags |= IDE_TFLAG_FLAGGED_SET_IN_FLAGS;
+       if (orig_cmd->ftf_flags & IDE_FTFLAG_FLAGGED)
+               orig_cmd->ftf_flags |= IDE_FTFLAG_SET_IN_FLAGS;
+
+       memcpy(cmd, orig_cmd, sizeof(*cmd));
+
+       if ((cmd->tf_flags & IDE_TFLAG_DMA_PIO_FALLBACK) == 0) {
+               ide_tf_dump(drive->name, cmd);
+               tp_ops->write_devctl(hwif, ATA_DEVCTL_OBS);
 
-       if ((task->tf_flags & IDE_TFLAG_DMA_PIO_FALLBACK) == 0) {
-               ide_tf_dump(drive->name, tf);
-               hwif->tf_load(drive, task);
+               if (cmd->ftf_flags & IDE_FTFLAG_OUT_DATA) {
+                       u8 data[2] = { cmd->tf.data, cmd->hob.data };
+
+                       tp_ops->output_data(drive, cmd, data, 2);
+               }
+
+               if (cmd->valid.out.tf & IDE_VALID_DEVICE) {
+                       u8 HIHI = (cmd->tf_flags & IDE_TFLAG_LBA48) ?
+                                 0xE0 : 0xEF;
+
+                       if (!(cmd->ftf_flags & IDE_FTFLAG_FLAGGED))
+                               cmd->tf.device &= HIHI;
+                       cmd->tf.device |= drive->select;
+               }
+
+               tp_ops->tf_load(drive, &cmd->hob, cmd->valid.out.hob);
+               tp_ops->tf_load(drive, &cmd->tf,  cmd->valid.out.tf);
        }
 
-       switch (task->data_phase) {
-       case TASKFILE_MULTI_OUT:
-       case TASKFILE_OUT:
-               hwif->OUTBSYNC(drive, tf->command, hwif->io_ports.command_addr);
-               ndelay(400);    /* FIXME */
-               return pre_task_out_intr(drive, task->rq);
-       case TASKFILE_MULTI_IN:
-       case TASKFILE_IN:
-               handler = task_in_intr;
+       switch (cmd->protocol) {
+       case ATA_PROT_PIO:
+               if (cmd->tf_flags & IDE_TFLAG_WRITE) {
+                       tp_ops->exec_command(hwif, tf->command);
+                       ndelay(400);    /* FIXME */
+                       return pre_task_out_intr(drive, cmd);
+               }
+               handler = task_pio_intr;
                /* fall-through */
-       case TASKFILE_NO_DATA:
+       case ATA_PROT_NODATA:
                if (handler == NULL)
                        handler = task_no_data_intr;
-               /* WIN_{SPECIFY,RESTORE,SETMULT} use custom handlers */
-               if (task->tf_flags & IDE_TFLAG_CUSTOM_HANDLER) {
-                       switch (tf->command) {
-                       case WIN_SPECIFY: handler = set_geometry_intr;  break;
-                       case WIN_RESTORE: handler = recal_intr;         break;
-                       case WIN_SETMULT: handler = set_multmode_intr;  break;
-                       }
-               }
-               ide_execute_command(drive, tf->command, handler,
-                                   WAIT_WORSTCASE, NULL);
+               ide_execute_command(drive, cmd, handler, WAIT_WORSTCASE);
                return ide_started;
-       default:
-               if (task_dma_ok(task) == 0 || drive->using_dma == 0 ||
-                   dma_ops->dma_setup(drive))
+       case ATA_PROT_DMA:
+               if (ide_dma_prepare(drive, cmd))
                        return ide_stopped;
-               dma_ops->dma_exec_cmd(drive, tf->command);
+               hwif->expiry = dma_ops->dma_timer_expiry;
+               ide_execute_command(drive, cmd, ide_dma_intr, 2 * WAIT_CMD);
                dma_ops->dma_start(drive);
+       default:
                return ide_started;
        }
 }
 EXPORT_SYMBOL_GPL(do_rw_taskfile);
 
-/*
- * set_multmode_intr() is invoked on completion of a WIN_SETMULT cmd.
- */
-static ide_startstop_t set_multmode_intr(ide_drive_t *drive)
-{
-       u8 stat = ide_read_status(drive);
-
-       if (OK_STAT(stat, READY_STAT, BAD_STAT))
-               drive->mult_count = drive->mult_req;
-       else {
-               drive->mult_req = drive->mult_count = 0;
-               drive->special.b.recalibrate = 1;
-               (void) ide_dump_status(drive, "set_multmode", stat);
-       }
-       return ide_stopped;
-}
-
-/*
- * set_geometry_intr() is invoked on completion of a WIN_SPECIFY cmd.
- */
-static ide_startstop_t set_geometry_intr(ide_drive_t *drive)
-{
-       int retries = 5;
-       u8 stat;
-
-       while (((stat = ide_read_status(drive)) & BUSY_STAT) && retries--)
-               udelay(10);
-
-       if (OK_STAT(stat, READY_STAT, BAD_STAT))
-               return ide_stopped;
-
-       if (stat & (ERR_STAT|DRQ_STAT))
-               return ide_error(drive, "set_geometry_intr", stat);
-
-       BUG_ON(HWGROUP(drive)->handler != NULL);
-       ide_set_handler(drive, &set_geometry_intr, WAIT_WORSTCASE, NULL);
-       return ide_started;
-}
-
-/*
- * recal_intr() is invoked on completion of a WIN_RESTORE (recalibrate) cmd.
- */
-static ide_startstop_t recal_intr(ide_drive_t *drive)
-{
-       u8 stat = ide_read_status(drive);
-
-       if (!OK_STAT(stat, READY_STAT, BAD_STAT))
-               return ide_error(drive, "recal_intr", stat);
-       return ide_stopped;
-}
-
-/*
- * Handler for commands without a data phase
- */
 static ide_startstop_t task_no_data_intr(ide_drive_t *drive)
 {
-       ide_task_t *args        = HWGROUP(drive)->rq->special;
+       ide_hwif_t *hwif = drive->hwif;
+       struct ide_cmd *cmd = &hwif->cmd;
+       struct ide_taskfile *tf = &cmd->tf;
+       int custom = (cmd->tf_flags & IDE_TFLAG_CUSTOM_HANDLER) ? 1 : 0;
+       int retries = (custom && tf->command == ATA_CMD_INIT_DEV_PARAMS) ? 5 : 1;
        u8 stat;
 
        local_irq_enable_in_hardirq();
-       stat = ide_read_status(drive);
 
-       if (!OK_STAT(stat, READY_STAT, BAD_STAT))
+       while (1) {
+               stat = hwif->tp_ops->read_status(hwif);
+               if ((stat & ATA_BUSY) == 0 || retries-- == 0)
+                       break;
+               udelay(10);
+       };
+
+       if (!OK_STAT(stat, ATA_DRDY, BAD_STAT)) {
+               if (custom && tf->command == ATA_CMD_SET_MULTI) {
+                       drive->mult_req = drive->mult_count = 0;
+                       drive->special_flags |= IDE_SFLAG_RECALIBRATE;
+                       (void)ide_dump_status(drive, __func__, stat);
+                       return ide_stopped;
+               } else if (custom && tf->command == ATA_CMD_INIT_DEV_PARAMS) {
+                       if ((stat & (ATA_ERR | ATA_DRQ)) == 0) {
+                               ide_set_handler(drive, &task_no_data_intr,
+                                               WAIT_WORSTCASE);
+                               return ide_started;
+                       }
+               }
                return ide_error(drive, "task_no_data_intr", stat);
-               /* calls ide_end_drive_cmd */
+       }
 
-       if (args)
-               ide_end_drive_cmd(drive, stat, ide_read_error(drive));
+       if (custom && tf->command == ATA_CMD_SET_MULTI)
+               drive->mult_count = drive->mult_req;
+
+       if (custom == 0 || tf->command == ATA_CMD_IDLEIMMEDIATE ||
+           tf->command == ATA_CMD_CHK_POWER) {
+               struct request *rq = hwif->rq;
+
+               if (blk_pm_request(rq))
+                       ide_complete_pm_rq(drive, rq);
+               else
+                       ide_finish_cmd(drive, cmd, stat);
+       }
 
        return ide_stopped;
 }
 
 static u8 wait_drive_not_busy(ide_drive_t *drive)
 {
+       ide_hwif_t *hwif = drive->hwif;
        int retries;
        u8 stat;
 
        /*
-        * Last sector was transfered, wait until drive is ready.
-        * This can take up to 10 usec, but we will wait max 1 ms.
+        * Last sector was transfered, wait until device is ready.  This can
+        * take up to 6 ms on some ATAPI devices, so we will wait max 10 ms.
         */
-       for (retries = 0; retries < 100; retries++) {
-               stat = ide_read_status(drive);
+       for (retries = 0; retries < 1000; retries++) {
+               stat = hwif->tp_ops->read_status(hwif);
 
-               if (stat & BUSY_STAT)
+               if (stat & ATA_BUSY)
                        udelay(10);
                else
                        break;
        }
 
-       if (stat & BUSY_STAT)
-               printk(KERN_ERR "%s: drive still BUSY!\n", drive->name);
+       if (stat & ATA_BUSY)
+               pr_err("%s: drive still BUSY!\n", drive->name);
 
        return stat;
 }
 
-static void ide_pio_sector(ide_drive_t *drive, struct request *rq,
-                          unsigned int write)
+void ide_pio_bytes(ide_drive_t *drive, struct ide_cmd *cmd,
+                  unsigned int write, unsigned int len)
 {
        ide_hwif_t *hwif = drive->hwif;
        struct scatterlist *sg = hwif->sg_table;
-       struct scatterlist *cursg = hwif->cursg;
+       struct scatterlist *cursg = cmd->cursg;
+       unsigned long uninitialized_var(flags);
        struct page *page;
-#ifdef CONFIG_HIGHMEM
-       unsigned long flags;
-#endif
        unsigned int offset;
        u8 *buf;
 
-       cursg = hwif->cursg;
-       if (!cursg) {
-               cursg = sg;
-               hwif->cursg = sg;
-       }
+       cursg = cmd->cursg;
+       if (cursg == NULL)
+               cursg = cmd->cursg = sg;
 
-       page = sg_page(cursg);
-       offset = cursg->offset + hwif->cursg_ofs * SECTOR_SIZE;
+       while (len) {
+               unsigned nr_bytes = min(len, cursg->length - cmd->cursg_ofs);
+               int page_is_high;
 
-       /* get the current page and offset */
-       page = nth_page(page, (offset >> PAGE_SHIFT));
-       offset %= PAGE_SIZE;
+               if (nr_bytes > PAGE_SIZE)
+                       nr_bytes = PAGE_SIZE;
 
-#ifdef CONFIG_HIGHMEM
-       local_irq_save(flags);
-#endif
-       buf = kmap_atomic(page, KM_BIO_SRC_IRQ) + offset;
+               page = sg_page(cursg);
+               offset = cursg->offset + cmd->cursg_ofs;
 
-       hwif->nleft--;
-       hwif->cursg_ofs++;
+               /* get the current page and offset */
+               page = nth_page(page, (offset >> PAGE_SHIFT));
+               offset %= PAGE_SIZE;
 
-       if ((hwif->cursg_ofs * SECTOR_SIZE) == cursg->length) {
-               hwif->cursg = sg_next(hwif->cursg);
-               hwif->cursg_ofs = 0;
-       }
+               page_is_high = PageHighMem(page);
+               if (page_is_high)
+                       local_irq_save(flags);
 
-       /* do the actual data transfer */
-       if (write)
-               hwif->output_data(drive, rq, buf, SECTOR_SIZE);
-       else
-               hwif->input_data(drive, rq, buf, SECTOR_SIZE);
+               buf = kmap_atomic(page, KM_BIO_SRC_IRQ) + offset;
 
-       kunmap_atomic(buf, KM_BIO_SRC_IRQ);
-#ifdef CONFIG_HIGHMEM
-       local_irq_restore(flags);
-#endif
-}
+               cmd->nleft -= nr_bytes;
+               cmd->cursg_ofs += nr_bytes;
 
-static void ide_pio_multi(ide_drive_t *drive, struct request *rq,
-                         unsigned int write)
-{
-       unsigned int nsect;
+               if (cmd->cursg_ofs == cursg->length) {
+                       cursg = cmd->cursg = sg_next(cmd->cursg);
+                       cmd->cursg_ofs = 0;
+               }
+
+               /* do the actual data transfer */
+               if (write)
+                       hwif->tp_ops->output_data(drive, cmd, buf, nr_bytes);
+               else
+                       hwif->tp_ops->input_data(drive, cmd, buf, nr_bytes);
+
+               kunmap_atomic(buf, KM_BIO_SRC_IRQ);
 
-       nsect = min_t(unsigned int, drive->hwif->nleft, drive->mult_count);
-       while (nsect--)
-               ide_pio_sector(drive, rq, write);
+               if (page_is_high)
+                       local_irq_restore(flags);
+
+               len -= nr_bytes;
+       }
 }
+EXPORT_SYMBOL_GPL(ide_pio_bytes);
 
-static void ide_pio_datablock(ide_drive_t *drive, struct request *rq,
-                                    unsigned int write)
+static void ide_pio_datablock(ide_drive_t *drive, struct ide_cmd *cmd,
+                             unsigned int write)
 {
-       u8 saved_io_32bit = drive->io_32bit;
+       unsigned int nr_bytes;
 
-       if (rq->bio)    /* fs request */
-               rq->errors = 0;
+       u8 saved_io_32bit = drive->io_32bit;
 
-       if (rq->cmd_type == REQ_TYPE_ATA_TASKFILE) {
-               ide_task_t *task = rq->special;
+       if (cmd->tf_flags & IDE_TFLAG_FS)
+               cmd->rq->errors = 0;
 
-               if (task->tf_flags & IDE_TFLAG_IO_16BIT)
-                       drive->io_32bit = 0;
-       }
+       if (cmd->tf_flags & IDE_TFLAG_IO_16BIT)
+               drive->io_32bit = 0;
 
        touch_softlockup_watchdog();
 
-       switch (drive->hwif->data_phase) {
-       case TASKFILE_MULTI_IN:
-       case TASKFILE_MULTI_OUT:
-               ide_pio_multi(drive, rq, write);
-               break;
-       default:
-               ide_pio_sector(drive, rq, write);
-               break;
-       }
+       if (cmd->tf_flags & IDE_TFLAG_MULTI_PIO)
+               nr_bytes = min_t(unsigned, cmd->nleft, drive->mult_count << 9);
+       else
+               nr_bytes = SECTOR_SIZE;
+
+       ide_pio_bytes(drive, cmd, write, nr_bytes);
 
        drive->io_32bit = saved_io_32bit;
 }
 
-static ide_startstop_t task_error(ide_drive_t *drive, struct request *rq,
-                                 const char *s, u8 stat)
+static void ide_error_cmd(ide_drive_t *drive, struct ide_cmd *cmd)
 {
-       if (rq->bio) {
-               ide_hwif_t *hwif = drive->hwif;
-               int sectors = hwif->nsect - hwif->nleft;
-
-               switch (hwif->data_phase) {
-               case TASKFILE_IN:
-                       if (hwif->nleft)
-                               break;
-                       /* fall through */
-               case TASKFILE_OUT:
-                       sectors--;
-                       break;
-               case TASKFILE_MULTI_IN:
-                       if (hwif->nleft)
-                               break;
-                       /* fall through */
-               case TASKFILE_MULTI_OUT:
-                       sectors -= drive->mult_count;
-               default:
-                       break;
+       if (cmd->tf_flags & IDE_TFLAG_FS) {
+               int nr_bytes = cmd->nbytes - cmd->nleft;
+
+               if (cmd->protocol == ATA_PROT_PIO &&
+                   ((cmd->tf_flags & IDE_TFLAG_WRITE) || cmd->nleft == 0)) {
+                       if (cmd->tf_flags & IDE_TFLAG_MULTI_PIO)
+                               nr_bytes -= drive->mult_count << 9;
+                       else
+                               nr_bytes -= SECTOR_SIZE;
                }
 
-               if (sectors > 0) {
-                       ide_driver_t *drv;
-
-                       drv = *(ide_driver_t **)rq->rq_disk->private_data;
-                       drv->end_request(drive, 1, sectors);
-               }
+               if (nr_bytes > 0)
+                       ide_complete_rq(drive, 0, nr_bytes);
        }
-       return ide_error(drive, s, stat);
 }
 
-void task_end_request(ide_drive_t *drive, struct request *rq, u8 stat)
+void ide_finish_cmd(ide_drive_t *drive, struct ide_cmd *cmd, u8 stat)
 {
-       if (rq->cmd_type == REQ_TYPE_ATA_TASKFILE) {
-               u8 err = ide_read_error(drive);
-
-               ide_end_drive_cmd(drive, stat, err);
-               return;
-       }
+       struct request *rq = drive->hwif->rq;
+       u8 err = ide_read_error(drive), nsect = cmd->tf.nsect;
+       u8 set_xfer = !!(cmd->tf_flags & IDE_TFLAG_SET_XFER);
 
-       if (rq->rq_disk) {
-               ide_driver_t *drv;
+       ide_complete_cmd(drive, cmd, stat, err);
+       rq->errors = err;
 
-               drv = *(ide_driver_t **)rq->rq_disk->private_data;;
-               drv->end_request(drive, 1, rq->nr_sectors);
-       } else
-               ide_end_request(drive, 1, rq->nr_sectors);
-}
-
-/*
- * We got an interrupt on a task_in case, but no errors and no DRQ.
- *
- * It might be a spurious irq (shared irq), but it might be a
- * command that had no output.
- */
-static ide_startstop_t task_in_unexpected(ide_drive_t *drive, struct request *rq, u8 stat)
-{
-       /* Command all done? */
-       if (OK_STAT(stat, READY_STAT, BUSY_STAT)) {
-               task_end_request(drive, rq, stat);
-               return ide_stopped;
+       if (err == 0 && set_xfer) {
+               ide_set_xfer_rate(drive, nsect);
+               ide_driveid_update(drive);
        }
 
-       /* Assume it was a spurious irq */
-       ide_set_handler(drive, &task_in_intr, WAIT_WORSTCASE, NULL);
-       return ide_started;
+       ide_complete_rq(drive, err ? -EIO : 0, blk_rq_bytes(rq));
 }
 
 /*
- * Handler for command with PIO data-in phase (Read/Read Multiple).
+ * Handler for command with PIO data phase.
  */
-static ide_startstop_t task_in_intr(ide_drive_t *drive)
+static ide_startstop_t task_pio_intr(ide_drive_t *drive)
 {
        ide_hwif_t *hwif = drive->hwif;
-       struct request *rq = HWGROUP(drive)->rq;
-       u8 stat = ide_read_status(drive);
+       struct ide_cmd *cmd = &drive->hwif->cmd;
+       u8 stat = hwif->tp_ops->read_status(hwif);
+       u8 write = !!(cmd->tf_flags & IDE_TFLAG_WRITE);
+
+       if (write == 0) {
+               /* Error? */
+               if (stat & ATA_ERR)
+                       goto out_err;
+
+               /* Didn't want any data? Odd. */
+               if ((stat & ATA_DRQ) == 0) {
+                       /* Command all done? */
+                       if (OK_STAT(stat, ATA_DRDY, ATA_BUSY))
+                               goto out_end;
+
+                       /* Assume it was a spurious irq */
+                       goto out_wait;
+               }
+       } else {
+               if (!OK_STAT(stat, DRIVE_READY, drive->bad_wstat))
+                       goto out_err;
 
-       /* Error? */
-       if (stat & ERR_STAT)
-               return task_error(drive, rq, __func__, stat);
+               /* Deal with unexpected ATA data phase. */
+               if (((stat & ATA_DRQ) == 0) ^ (cmd->nleft == 0))
+                       goto out_err;
+       }
 
-       /* Didn't want any data? Odd. */
-       if (!(stat & DRQ_STAT))
-               return task_in_unexpected(drive, rq, stat);
+       if (write && cmd->nleft == 0)
+               goto out_end;
 
-       ide_pio_datablock(drive, rq, 0);
+       /* Still data left to transfer. */
+       ide_pio_datablock(drive, cmd, write);
 
        /* Are we done? Check status and finish transfer. */
-       if (!hwif->nleft) {
+       if (write == 0 && cmd->nleft == 0) {
                stat = wait_drive_not_busy(drive);
                if (!OK_STAT(stat, 0, BAD_STAT))
-                       return task_error(drive, rq, __func__, stat);
-               task_end_request(drive, rq, stat);
-               return ide_stopped;
-       }
-
-       /* Still data left to transfer. */
-       ide_set_handler(drive, &task_in_intr, WAIT_WORSTCASE, NULL);
-
-       return ide_started;
-}
-
-/*
- * Handler for command with PIO data-out phase (Write/Write Multiple).
- */
-static ide_startstop_t task_out_intr (ide_drive_t *drive)
-{
-       ide_hwif_t *hwif = drive->hwif;
-       struct request *rq = HWGROUP(drive)->rq;
-       u8 stat = ide_read_status(drive);
+                       goto out_err;
 
-       if (!OK_STAT(stat, DRIVE_READY, drive->bad_wstat))
-               return task_error(drive, rq, __func__, stat);
-
-       /* Deal with unexpected ATA data phase. */
-       if (((stat & DRQ_STAT) == 0) ^ !hwif->nleft)
-               return task_error(drive, rq, __func__, stat);
-
-       if (!hwif->nleft) {
-               task_end_request(drive, rq, stat);
-               return ide_stopped;
+               goto out_end;
        }
-
+out_wait:
        /* Still data left to transfer. */
-       ide_pio_datablock(drive, rq, 1);
-       ide_set_handler(drive, &task_out_intr, WAIT_WORSTCASE, NULL);
-
+       ide_set_handler(drive, &task_pio_intr, WAIT_WORSTCASE);
        return ide_started;
+out_end:
+       if ((cmd->tf_flags & IDE_TFLAG_FS) == 0)
+               ide_finish_cmd(drive, cmd, stat);
+       else
+               ide_complete_rq(drive, 0, blk_rq_sectors(cmd->rq) << 9);
+       return ide_stopped;
+out_err:
+       ide_error_cmd(drive, cmd);
+       return ide_error(drive, __func__, stat);
 }
 
-static ide_startstop_t pre_task_out_intr(ide_drive_t *drive, struct request *rq)
+static ide_startstop_t pre_task_out_intr(ide_drive_t *drive,
+                                        struct ide_cmd *cmd)
 {
        ide_startstop_t startstop;
 
-       if (ide_wait_stat(&startstop, drive, DRQ_STAT,
+       if (ide_wait_stat(&startstop, drive, ATA_DRQ,
                          drive->bad_wstat, WAIT_DRQ)) {
-               printk(KERN_ERR "%s: no DRQ after issuing %sWRITE%s\n",
-                               drive->name,
-                               drive->hwif->data_phase ? "MULT" : "",
-                               drive->addressing ? "_EXT" : "");
+               pr_err("%s: no DRQ after issuing %sWRITE%s\n", drive->name,
+                       (cmd->tf_flags & IDE_TFLAG_MULTI_PIO) ? "MULT" : "",
+                       (drive->dev_flags & IDE_DFLAG_LBA48) ? "_EXT" : "");
                return startstop;
        }
 
-       if (!drive->unmask)
+       if ((drive->dev_flags & IDE_DFLAG_UNMASK) == 0)
                local_irq_disable();
 
-       ide_set_handler(drive, &task_out_intr, WAIT_WORSTCASE, NULL);
-       ide_pio_datablock(drive, rq, 1);
+       ide_set_handler(drive, &task_pio_intr, WAIT_WORSTCASE);
+
+       ide_pio_datablock(drive, cmd, 1);
 
        return ide_started;
 }
 
-int ide_raw_taskfile(ide_drive_t *drive, ide_task_t *task, u8 *buf, u16 nsect)
+int ide_raw_taskfile(ide_drive_t *drive, struct ide_cmd *cmd, u8 *buf,
+                    u16 nsect)
 {
-       struct request rq;
+       struct request *rq;
+       int error;
+
+       rq = blk_get_request(drive->queue, READ, __GFP_WAIT);
+       rq->cmd_type = REQ_TYPE_ATA_TASKFILE;
 
-       blk_rq_init(NULL, &rq);
-       rq.cmd_type = REQ_TYPE_ATA_TASKFILE;
-       rq.buffer = buf;
+       if (cmd->tf_flags & IDE_TFLAG_WRITE)
+               rq->cmd_flags |= REQ_RW;
 
        /*
         * (ks) We transfer currently only whole sectors.
@@ -504,33 +441,37 @@ int ide_raw_taskfile(ide_drive_t *drive, ide_task_t *task, u8 *buf, u16 nsect)
         * if we would find a solution to transfer any size.
         * To support special commands like READ LONG.
         */
-       rq.hard_nr_sectors = rq.nr_sectors = nsect;
-       rq.hard_cur_sectors = rq.current_nr_sectors = nsect;
+       if (nsect) {
+               error = blk_rq_map_kern(drive->queue, rq, buf,
+                                       nsect * SECTOR_SIZE, __GFP_WAIT);
+               if (error)
+                       goto put_req;
+       }
 
-       if (task->tf_flags & IDE_TFLAG_WRITE)
-               rq.cmd_flags |= REQ_RW;
+       rq->special = cmd;
+       cmd->rq = rq;
 
-       rq.special = task;
-       task->rq = &rq;
+       error = blk_execute_rq(drive->queue, NULL, rq, 0);
 
-       return ide_do_drive_cmd(drive, &rq, ide_wait);
+put_req:
+       blk_put_request(rq);
+       return error;
 }
-
 EXPORT_SYMBOL(ide_raw_taskfile);
 
-int ide_no_data_taskfile(ide_drive_t *drive, ide_task_t *task)
+int ide_no_data_taskfile(ide_drive_t *drive, struct ide_cmd *cmd)
 {
-       task->data_phase = TASKFILE_NO_DATA;
+       cmd->protocol = ATA_PROT_NODATA;
 
-       return ide_raw_taskfile(drive, task, NULL, 0);
+       return ide_raw_taskfile(drive, cmd, NULL, 0);
 }
 EXPORT_SYMBOL_GPL(ide_no_data_taskfile);
 
 #ifdef CONFIG_IDE_TASK_IOCTL
-int ide_taskfile_ioctl (ide_drive_t *drive, unsigned int cmd, unsigned long arg)
+int ide_taskfile_ioctl(ide_drive_t *drive, unsigned long arg)
 {
        ide_task_request_t      *req_task;
-       ide_task_t              args;
+       struct ide_cmd          cmd;
        u8 *outbuf              = NULL;
        u8 *inbuf               = NULL;
        u8 *data_buf            = NULL;
@@ -541,10 +482,9 @@ int ide_taskfile_ioctl (ide_drive_t *drive, unsigned int cmd, unsigned long arg)
        u16 nsect               = 0;
        char __user *buf = (char __user *)arg;
 
-//     printk("IDE Taskfile ...\n");
-
        req_task = kzalloc(tasksize, GFP_KERNEL);
-       if (req_task == NULL) return -ENOMEM;
+       if (req_task == NULL)
+               return -ENOMEM;
        if (copy_from_user(req_task, buf, tasksize)) {
                kfree(req_task);
                return -EFAULT;
@@ -552,7 +492,7 @@ int ide_taskfile_ioctl (ide_drive_t *drive, unsigned int cmd, unsigned long arg)
 
        taskout = req_task->out_size;
        taskin  = req_task->in_size;
-       
+
        if (taskin > 65536 || taskout > 65536) {
                err = -EINVAL;
                goto abort;
@@ -584,119 +524,131 @@ int ide_taskfile_ioctl (ide_drive_t *drive, unsigned int cmd, unsigned long arg)
                }
        }
 
-       memset(&args, 0, sizeof(ide_task_t));
+       memset(&cmd, 0, sizeof(cmd));
 
-       memcpy(&args.tf_array[0], req_task->hob_ports, HDIO_DRIVE_HOB_HDR_SIZE - 2);
-       memcpy(&args.tf_array[6], req_task->io_ports, HDIO_DRIVE_TASK_HDR_SIZE);
+       memcpy(&cmd.hob, req_task->hob_ports, HDIO_DRIVE_HOB_HDR_SIZE - 2);
+       memcpy(&cmd.tf,  req_task->io_ports,  HDIO_DRIVE_TASK_HDR_SIZE);
 
-       args.data_phase = req_task->data_phase;
+       cmd.valid.out.tf = IDE_VALID_DEVICE;
+       cmd.valid.in.tf  = IDE_VALID_DEVICE | IDE_VALID_IN_TF;
+       cmd.tf_flags = IDE_TFLAG_IO_16BIT;
 
-       args.tf_flags = IDE_TFLAG_IO_16BIT | IDE_TFLAG_DEVICE |
-                       IDE_TFLAG_IN_TF;
-       if (drive->addressing == 1)
-               args.tf_flags |= (IDE_TFLAG_LBA48 | IDE_TFLAG_IN_HOB);
+       if (drive->dev_flags & IDE_DFLAG_LBA48) {
+               cmd.tf_flags |= IDE_TFLAG_LBA48;
+               cmd.valid.in.hob = IDE_VALID_IN_HOB;
+       }
 
        if (req_task->out_flags.all) {
-               args.tf_flags |= IDE_TFLAG_FLAGGED;
+               cmd.ftf_flags |= IDE_FTFLAG_FLAGGED;
 
                if (req_task->out_flags.b.data)
-                       args.tf_flags |= IDE_TFLAG_OUT_DATA;
+                       cmd.ftf_flags |= IDE_FTFLAG_OUT_DATA;
 
                if (req_task->out_flags.b.nsector_hob)
-                       args.tf_flags |= IDE_TFLAG_OUT_HOB_NSECT;
+                       cmd.valid.out.hob |= IDE_VALID_NSECT;
                if (req_task->out_flags.b.sector_hob)
-                       args.tf_flags |= IDE_TFLAG_OUT_HOB_LBAL;
+                       cmd.valid.out.hob |= IDE_VALID_LBAL;
                if (req_task->out_flags.b.lcyl_hob)
-                       args.tf_flags |= IDE_TFLAG_OUT_HOB_LBAM;
+                       cmd.valid.out.hob |= IDE_VALID_LBAM;
                if (req_task->out_flags.b.hcyl_hob)
-                       args.tf_flags |= IDE_TFLAG_OUT_HOB_LBAH;
+                       cmd.valid.out.hob |= IDE_VALID_LBAH;
 
                if (req_task->out_flags.b.error_feature)
-                       args.tf_flags |= IDE_TFLAG_OUT_FEATURE;
+                       cmd.valid.out.tf  |= IDE_VALID_FEATURE;
                if (req_task->out_flags.b.nsector)
-                       args.tf_flags |= IDE_TFLAG_OUT_NSECT;
+                       cmd.valid.out.tf  |= IDE_VALID_NSECT;
                if (req_task->out_flags.b.sector)
-                       args.tf_flags |= IDE_TFLAG_OUT_LBAL;
+                       cmd.valid.out.tf  |= IDE_VALID_LBAL;
                if (req_task->out_flags.b.lcyl)
-                       args.tf_flags |= IDE_TFLAG_OUT_LBAM;
+                       cmd.valid.out.tf  |= IDE_VALID_LBAM;
                if (req_task->out_flags.b.hcyl)
-                       args.tf_flags |= IDE_TFLAG_OUT_LBAH;
+                       cmd.valid.out.tf  |= IDE_VALID_LBAH;
        } else {
-               args.tf_flags |= IDE_TFLAG_OUT_TF;
-               if (args.tf_flags & IDE_TFLAG_LBA48)
-                       args.tf_flags |= IDE_TFLAG_OUT_HOB;
+               cmd.valid.out.tf |= IDE_VALID_OUT_TF;
+               if (cmd.tf_flags & IDE_TFLAG_LBA48)
+                       cmd.valid.out.hob |= IDE_VALID_OUT_HOB;
        }
 
        if (req_task->in_flags.b.data)
-               args.tf_flags |= IDE_TFLAG_IN_DATA;
-
-       switch(req_task->data_phase) {
-               case TASKFILE_MULTI_OUT:
-                       if (!drive->mult_count) {
-                               /* (hs): give up if multcount is not set */
-                               printk(KERN_ERR "%s: %s Multimode Write " \
-                                       "multcount is not set\n",
-                                       drive->name, __func__);
-                               err = -EPERM;
-                               goto abort;
-                       }
-                       /* fall through */
-               case TASKFILE_OUT:
-                       /* fall through */
-               case TASKFILE_OUT_DMAQ:
-               case TASKFILE_OUT_DMA:
-                       nsect = taskout / SECTOR_SIZE;
-                       data_buf = outbuf;
-                       break;
-               case TASKFILE_MULTI_IN:
-                       if (!drive->mult_count) {
-                               /* (hs): give up if multcount is not set */
-                               printk(KERN_ERR "%s: %s Multimode Read failure " \
-                                       "multcount is not set\n",
-                                       drive->name, __func__);
-                               err = -EPERM;
-                               goto abort;
-                       }
-                       /* fall through */
-               case TASKFILE_IN:
-                       /* fall through */
-               case TASKFILE_IN_DMAQ:
-               case TASKFILE_IN_DMA:
-                       nsect = taskin / SECTOR_SIZE;
-                       data_buf = inbuf;
-                       break;
-               case TASKFILE_NO_DATA:
-                       break;
-               default:
-                       err = -EFAULT;
+               cmd.ftf_flags |= IDE_FTFLAG_IN_DATA;
+
+       if (req_task->req_cmd == IDE_DRIVE_TASK_RAW_WRITE) {
+               /* fixup data phase if needed */
+               if (req_task->data_phase == TASKFILE_IN_DMAQ ||
+                   req_task->data_phase == TASKFILE_IN_DMA)
+                       cmd.tf_flags |= IDE_TFLAG_WRITE;
+       }
+
+       cmd.protocol = ATA_PROT_DMA;
+
+       switch (req_task->data_phase) {
+       case TASKFILE_MULTI_OUT:
+               if (!drive->mult_count) {
+                       /* (hs): give up if multcount is not set */
+                       pr_err("%s: %s Multimode Write multcount is not set\n",
+                               drive->name, __func__);
+                       err = -EPERM;
                        goto abort;
+               }
+               cmd.tf_flags |= IDE_TFLAG_MULTI_PIO;
+               /* fall through */
+       case TASKFILE_OUT:
+               cmd.protocol = ATA_PROT_PIO;
+               /* fall through */
+       case TASKFILE_OUT_DMAQ:
+       case TASKFILE_OUT_DMA:
+               cmd.tf_flags |= IDE_TFLAG_WRITE;
+               nsect = taskout / SECTOR_SIZE;
+               data_buf = outbuf;
+               break;
+       case TASKFILE_MULTI_IN:
+               if (!drive->mult_count) {
+                       /* (hs): give up if multcount is not set */
+                       pr_err("%s: %s Multimode Read multcount is not set\n",
+                               drive->name, __func__);
+                       err = -EPERM;
+                       goto abort;
+               }
+               cmd.tf_flags |= IDE_TFLAG_MULTI_PIO;
+               /* fall through */
+       case TASKFILE_IN:
+               cmd.protocol = ATA_PROT_PIO;
+               /* fall through */
+       case TASKFILE_IN_DMAQ:
+       case TASKFILE_IN_DMA:
+               nsect = taskin / SECTOR_SIZE;
+               data_buf = inbuf;
+               break;
+       case TASKFILE_NO_DATA:
+               cmd.protocol = ATA_PROT_NODATA;
+               break;
+       default:
+               err = -EFAULT;
+               goto abort;
        }
 
        if (req_task->req_cmd == IDE_DRIVE_TASK_NO_DATA)
                nsect = 0;
        else if (!nsect) {
-               nsect = (args.tf.hob_nsect << 8) | args.tf.nsect;
+               nsect = (cmd.hob.nsect << 8) | cmd.tf.nsect;
 
                if (!nsect) {
-                       printk(KERN_ERR "%s: in/out command without data\n",
+                       pr_err("%s: in/out command without data\n",
                                        drive->name);
                        err = -EFAULT;
                        goto abort;
                }
        }
 
-       if (req_task->req_cmd == IDE_DRIVE_TASK_RAW_WRITE)
-               args.tf_flags |= IDE_TFLAG_WRITE;
-
-       err = ide_raw_taskfile(drive, &args, data_buf, nsect);
+       err = ide_raw_taskfile(drive, &cmd, data_buf, nsect);
 
-       memcpy(req_task->hob_ports, &args.tf_array[0], HDIO_DRIVE_HOB_HDR_SIZE - 2);
-       memcpy(req_task->io_ports, &args.tf_array[6], HDIO_DRIVE_TASK_HDR_SIZE);
+       memcpy(req_task->hob_ports, &cmd.hob, HDIO_DRIVE_HOB_HDR_SIZE - 2);
+       memcpy(req_task->io_ports,  &cmd.tf,  HDIO_DRIVE_TASK_HDR_SIZE);
 
-       if ((args.tf_flags & IDE_TFLAG_FLAGGED_SET_IN_FLAGS) &&
+       if ((cmd.ftf_flags & IDE_FTFLAG_SET_IN_FLAGS) &&
            req_task->in_flags.all == 0) {
                req_task->in_flags.all = IDE_TASKFILE_STD_IN_FLAGS;
-               if (drive->addressing == 1)
+               if (drive->dev_flags & IDE_DFLAG_LBA48)
                        req_task->in_flags.all |= (IDE_HOB_STD_IN_FLAGS << 8);
        }
 
@@ -723,113 +675,6 @@ abort:
        kfree(outbuf);
        kfree(inbuf);
 
-//     printk("IDE Taskfile ioctl ended. rc = %i\n", err);
-
        return err;
 }
 #endif
-
-int ide_cmd_ioctl (ide_drive_t *drive, unsigned int cmd, unsigned long arg)
-{
-       u8 *buf = NULL;
-       int bufsize = 0, err = 0;
-       u8 args[4], xfer_rate = 0;
-       ide_task_t tfargs;
-       struct ide_taskfile *tf = &tfargs.tf;
-       struct hd_driveid *id = drive->id;
-
-       if (NULL == (void *) arg) {
-               struct request rq;
-
-               ide_init_drive_cmd(&rq);
-               rq.cmd_type = REQ_TYPE_ATA_TASKFILE;
-
-               return ide_do_drive_cmd(drive, &rq, ide_wait);
-       }
-
-       if (copy_from_user(args, (void __user *)arg, 4))
-               return -EFAULT;
-
-       memset(&tfargs, 0, sizeof(ide_task_t));
-       tf->feature = args[2];
-       if (args[0] == WIN_SMART) {
-               tf->nsect = args[3];
-               tf->lbal  = args[1];
-               tf->lbam  = 0x4f;
-               tf->lbah  = 0xc2;
-               tfargs.tf_flags = IDE_TFLAG_OUT_TF | IDE_TFLAG_IN_NSECT;
-       } else {
-               tf->nsect = args[1];
-               tfargs.tf_flags = IDE_TFLAG_OUT_FEATURE |
-                                 IDE_TFLAG_OUT_NSECT | IDE_TFLAG_IN_NSECT;
-       }
-       tf->command = args[0];
-       tfargs.data_phase = args[3] ? TASKFILE_IN : TASKFILE_NO_DATA;
-
-       if (args[3]) {
-               tfargs.tf_flags |= IDE_TFLAG_IO_16BIT;
-               bufsize = SECTOR_WORDS * 4 * args[3];
-               buf = kzalloc(bufsize, GFP_KERNEL);
-               if (buf == NULL)
-                       return -ENOMEM;
-       }
-
-       if (tf->command == WIN_SETFEATURES &&
-           tf->feature == SETFEATURES_XFER &&
-           tf->nsect >= XFER_SW_DMA_0 &&
-           (id->dma_ultra || id->dma_mword || id->dma_1word)) {
-               xfer_rate = args[1];
-               if (tf->nsect > XFER_UDMA_2 && !eighty_ninty_three(drive)) {
-                       printk(KERN_WARNING "%s: UDMA speeds >UDMA33 cannot "
-                                           "be set\n", drive->name);
-                       goto abort;
-               }
-       }
-
-       err = ide_raw_taskfile(drive, &tfargs, buf, args[3]);
-
-       args[0] = tf->status;
-       args[1] = tf->error;
-       args[2] = tf->nsect;
-
-       if (!err && xfer_rate) {
-               /* active-retuning-calls future */
-               ide_set_xfer_rate(drive, xfer_rate);
-               ide_driveid_update(drive);
-       }
-abort:
-       if (copy_to_user((void __user *)arg, &args, 4))
-               err = -EFAULT;
-       if (buf) {
-               if (copy_to_user((void __user *)(arg + 4), buf, bufsize))
-                       err = -EFAULT;
-               kfree(buf);
-       }
-       return err;
-}
-
-int ide_task_ioctl (ide_drive_t *drive, unsigned int cmd, unsigned long arg)
-{
-       void __user *p = (void __user *)arg;
-       int err = 0;
-       u8 args[7];
-       ide_task_t task;
-
-       if (copy_from_user(args, p, 7))
-               return -EFAULT;
-
-       memset(&task, 0, sizeof(task));
-       memcpy(&task.tf_array[7], &args[1], 6);
-       task.tf.command = args[0];
-       task.tf_flags = IDE_TFLAG_TF | IDE_TFLAG_DEVICE;
-
-       err = ide_no_data_taskfile(drive, &task);
-
-       args[0] = task.tf.command;
-       memcpy(&args[1], &task.tf_array[7], 6);
-
-       if (copy_to_user(p, args, 7))
-               err = -EFAULT;
-
-       return err;
-}