spi: pxa2xx: limit reaches -1
[safe/jmp/linux-2.6] / drivers / ide / ide-cd.c
index 5319e7a..3aec19d 100644 (file)
@@ -265,35 +265,62 @@ static void ide_cd_complete_failed_rq(ide_drive_t *drive, struct request *rq)
                cdrom_analyze_sense_data(drive, NULL, sense);
 }
 
+
 /*
+ * Allow the drive 5 seconds to recover; some devices will return NOT_READY
+ * while flushing data from cache.
+ *
+ * returns: 0 failed (write timeout expired)
+ *         1 success
+ */
+static int ide_cd_breathe(ide_drive_t *drive, struct request *rq)
+{
+
+       struct cdrom_info *info = drive->driver_data;
+
+       if (!rq->errors)
+               info->write_timeout = jiffies + ATAPI_WAIT_WRITE_BUSY;
+
+       rq->errors = 1;
+
+       if (time_after(jiffies, info->write_timeout))
+               return 0;
+       else {
+               struct request_queue *q = drive->queue;
+               unsigned long flags;
+
+               /*
+                * take a breather relying on the unplug timer to kick us again
+                */
+
+               spin_lock_irqsave(q->queue_lock, flags);
+               blk_plug_device(q);
+               spin_unlock_irqrestore(q->queue_lock, flags);
+
+               return 1;
+       }
+}
+
+/**
  * Returns:
  * 0: if the request should be continued.
  * 1: if the request will be going through error recovery.
  * 2: if the request should be ended.
  */
-static int cdrom_decode_status(ide_drive_t *drive, int good_stat, int *stat_ret)
+static int cdrom_decode_status(ide_drive_t *drive, u8 stat)
 {
        ide_hwif_t *hwif = drive->hwif;
        struct request *rq = hwif->rq;
-       int stat, err, sense_key;
-
-       /* check for errors */
-       stat = hwif->tp_ops->read_status(hwif);
-
-       if (stat_ret)
-               *stat_ret = stat;
-
-       if (OK_STAT(stat, good_stat, BAD_R_STAT))
-               return 0;
+       int err, sense_key, do_end_request = 0;
+       u8 quiet = rq->cmd_flags & REQ_QUIET;
 
        /* get the IDE error register */
        err = ide_read_error(drive);
        sense_key = err >> 4;
 
-       ide_debug_log(IDE_DBG_RQ, "stat: 0x%x, good_stat: 0x%x, cmd[0]: 0x%x, "
-                                 "rq->cmd_type: 0x%x, err: 0x%x",
-                                 stat, good_stat, rq->cmd[0], rq->cmd_type,
-                                 err);
+       ide_debug_log(IDE_DBG_RQ, "cmd: 0x%x, rq->cmd_type: 0x%x, err: 0x%x, "
+                                 "stat 0x%x",
+                                 rq->cmd[0], rq->cmd_type, err, stat);
 
        if (blk_sense_request(rq)) {
                /*
@@ -303,151 +330,108 @@ static int cdrom_decode_status(ide_drive_t *drive, int good_stat, int *stat_ret)
                 */
                rq->cmd_flags |= REQ_FAILED;
                return 2;
-       } else if (blk_pc_request(rq) || rq->cmd_type == REQ_TYPE_ATA_PC) {
-               /* All other functions, except for READ. */
+       }
 
-               /*
-                * if we have an error, pass back CHECK_CONDITION as the
-                * scsi status byte
-                */
-               if (blk_pc_request(rq) && !rq->errors)
-                       rq->errors = SAM_STAT_CHECK_CONDITION;
+       /* if we have an error, pass CHECK_CONDITION as the SCSI status byte */
+       if (blk_pc_request(rq) && !rq->errors)
+               rq->errors = SAM_STAT_CHECK_CONDITION;
 
-               /* check for tray open */
-               if (sense_key == NOT_READY) {
-                       cdrom_saw_media_change(drive);
-               } else if (sense_key == UNIT_ATTENTION) {
-                       /* check for media change */
+       if (blk_noretry_request(rq))
+               do_end_request = 1;
+
+       switch (sense_key) {
+       case NOT_READY:
+               if (blk_fs_request(rq) && rq_data_dir(rq) == WRITE) {
+                       if (ide_cd_breathe(drive, rq))
+                               return 1;
+               } else {
                        cdrom_saw_media_change(drive);
-                       return 0;
-               } else if (sense_key == ILLEGAL_REQUEST &&
-                          rq->cmd[0] == GPCMD_START_STOP_UNIT) {
-                       /*
-                        * Don't print error message for this condition--
-                        * SFF8090i indicates that 5/24/00 is the correct
-                        * response to a request to close the tray if the
-                        * drive doesn't have that capability.
-                        * cdrom_log_sense() knows this!
-                        */
-               } else if (!(rq->cmd_flags & REQ_QUIET)) {
-                       /* otherwise, print an error */
-                       ide_dump_status(drive, "packet command error", stat);
+
+                       if (blk_fs_request(rq) && !quiet)
+                               printk(KERN_ERR PFX "%s: tray open\n",
+                                       drive->name);
                }
+               do_end_request = 1;
+               break;
+       case UNIT_ATTENTION:
+               cdrom_saw_media_change(drive);
 
-               rq->cmd_flags |= REQ_FAILED;
+               if (blk_fs_request(rq) == 0)
+                       return 0;
 
                /*
-                * instead of playing games with moving completions around,
-                * remove failed request completely and end it when the
-                * request sense has completed
+                * Arrange to retry the request but be sure to give up if we've
+                * retried too many times.
                 */
-               goto end_request;
-
-       } else if (blk_fs_request(rq)) {
-               int do_end_request = 0;
-
-               /* handle errors from READ and WRITE requests */
-
-               if (blk_noretry_request(rq))
+               if (++rq->errors > ERROR_MAX)
                        do_end_request = 1;
-
-               if (sense_key == NOT_READY) {
-                       /* tray open */
-                       if (rq_data_dir(rq) == READ) {
-                               cdrom_saw_media_change(drive);
-
-                               /* fail the request */
-                               printk(KERN_ERR PFX "%s: tray open\n",
-                                               drive->name);
-                               do_end_request = 1;
-                       } else {
-                               struct cdrom_info *info = drive->driver_data;
-
-                               /*
-                                * Allow the drive 5 seconds to recover, some
-                                * devices will return this error while flushing
-                                * data from cache.
-                                */
-                               if (!rq->errors)
-                                       info->write_timeout = jiffies +
-                                                       ATAPI_WAIT_WRITE_BUSY;
-                               rq->errors = 1;
-                               if (time_after(jiffies, info->write_timeout))
-                                       do_end_request = 1;
-                               else {
-                                       struct request_queue *q = drive->queue;
-                                       unsigned long flags;
-
-                                       /*
-                                        * take a breather relying on the unplug
-                                        * timer to kick us again
-                                        */
-                                       spin_lock_irqsave(q->queue_lock, flags);
-                                       blk_plug_device(q);
-                                       spin_unlock_irqrestore(q->queue_lock, flags);
-
-                                       return 1;
-                               }
-                       }
-               } else if (sense_key == UNIT_ATTENTION) {
-                       /* media change */
-                       cdrom_saw_media_change(drive);
-
-                       /*
-                        * Arrange to retry the request but be sure to give up
-                        * if we've retried too many times.
-                        */
-                       if (++rq->errors > ERROR_MAX)
-                               do_end_request = 1;
-               } else if (sense_key == ILLEGAL_REQUEST ||
-                          sense_key == DATA_PROTECT) {
-                       /*
-                        * No point in retrying after an illegal request or data
-                        * protect error.
-                        */
+               break;
+       case ILLEGAL_REQUEST:
+               /*
+                * Don't print error message for this condition -- SFF8090i
+                * indicates that 5/24/00 is the correct response to a request
+                * to close the tray if the drive doesn't have that capability.
+                *
+                * cdrom_log_sense() knows this!
+                */
+               if (rq->cmd[0] == GPCMD_START_STOP_UNIT)
+                       break;
+               /* fall-through */
+       case DATA_PROTECT:
+               /*
+                * No point in retrying after an illegal request or data
+                * protect error.
+                */
+               if (!quiet)
                        ide_dump_status(drive, "command error", stat);
-                       do_end_request = 1;
-               } else if (sense_key == MEDIUM_ERROR) {
-                       /*
-                        * No point in re-trying a zillion times on a bad
-                        * sector. If we got here the error is not correctable.
-                        */
-                       ide_dump_status(drive, "media error (bad sector)",
+               do_end_request = 1;
+               break;
+       case MEDIUM_ERROR:
+               /*
+                * No point in re-trying a zillion times on a bad sector.
+                * If we got here the error is not correctable.
+                */
+               if (!quiet)
+                       ide_dump_status(drive, "media error "
+                                       "(bad sector)", stat);
+               do_end_request = 1;
+               break;
+       case BLANK_CHECK:
+               /* disk appears blank? */
+               if (!quiet)
+                       ide_dump_status(drive, "media error (blank)",
                                        stat);
-                       do_end_request = 1;
-               } else if (sense_key == BLANK_CHECK) {
-                       /* disk appears blank ?? */
-                       ide_dump_status(drive, "media error (blank)", stat);
-                       do_end_request = 1;
-               } else if ((err & ~ATA_ABORTED) != 0) {
+               do_end_request = 1;
+               break;
+       default:
+               if (blk_fs_request(rq) == 0)
+                       break;
+               if (err & ~ATA_ABORTED) {
                        /* go to the default handler for other errors */
                        ide_error(drive, "cdrom_decode_status", stat);
                        return 1;
-               } else if ((++rq->errors > ERROR_MAX)) {
+               } else if (++rq->errors > ERROR_MAX)
                        /* we've racked up too many retries, abort */
                        do_end_request = 1;
-               }
-
-               /*
-                * End a request through request sense analysis when we have
-                * sense data. We need this in order to perform end of media
-                * processing.
-                */
-               if (do_end_request)
-                       goto end_request;
+       }
 
-               /*
-                * If we got a CHECK_CONDITION status, queue
-                * a request sense command.
-                */
-               if (stat & ATA_ERR)
-                       cdrom_queue_request_sense(drive, NULL, NULL);
-               return 1;
-       } else {
-               blk_dump_rq_flags(rq, PFX "bad rq");
-               return 2;
+       if (blk_fs_request(rq) == 0) {
+               rq->cmd_flags |= REQ_FAILED;
+               do_end_request = 1;
        }
 
+       /*
+        * End a request through request sense analysis when we have sense data.
+        * We need this in order to perform end of media processing.
+        */
+       if (do_end_request)
+               goto end_request;
+
+       /* if we got a CHECK_CONDITION status, queue a request sense command */
+       if (stat & ATA_ERR)
+               cdrom_queue_request_sense(drive, NULL, NULL);
+       return 1;
+
 end_request:
        if (stat & ATA_ERR) {
                struct request_queue *q = drive->queue;
@@ -624,21 +608,22 @@ static ide_startstop_t cdrom_newpc_intr(ide_drive_t *drive)
        struct ide_cmd *cmd = &hwif->cmd;
        struct request *rq = hwif->rq;
        ide_expiry_t *expiry = NULL;
-       int dma_error = 0, dma, stat, thislen, uptodate = 0;
+       int dma_error = 0, dma, thislen, uptodate = 0;
        int write = (rq_data_dir(rq) == WRITE) ? 1 : 0, rc, nsectors;
        int sense = blk_sense_request(rq);
        unsigned int timeout;
        u16 len;
-       u8 ireason;
+       u8 ireason, stat;
 
-       ide_debug_log(IDE_DBG_PC, "cmd[0]: 0x%x, write: 0x%x",
-                                 rq->cmd[0], write);
+       ide_debug_log(IDE_DBG_PC, "cmd: 0x%x, write: 0x%x", rq->cmd[0], write);
 
        /* check for errors */
        dma = drive->dma;
        if (dma) {
                drive->dma = 0;
+               drive->waiting_for_dma = 0;
                dma_error = hwif->dma_ops->dma_end(drive);
+               ide_dma_unmap_sg(drive, cmd);
                if (dma_error) {
                        printk(KERN_ERR PFX "%s: DMA %s error\n", drive->name,
                                        write ? "write" : "read");
@@ -646,11 +631,16 @@ static ide_startstop_t cdrom_newpc_intr(ide_drive_t *drive)
                }
        }
 
-       rc = cdrom_decode_status(drive, 0, &stat);
-       if (rc) {
-               if (rc == 2)
-                       goto out_end;
-               return ide_stopped;
+       /* check status */
+       stat = hwif->tp_ops->read_status(hwif);
+
+       if (!OK_STAT(stat, 0, BAD_R_STAT)) {
+               rc = cdrom_decode_status(drive, stat);
+               if (rc) {
+                       if (rc == 2)
+                               goto out_end;
+                       return ide_stopped;
+               }
        }
 
        /* using dma, transfer is complete now */