hwmon: (asus_atk0110) Refactor interface probe code
[safe/jmp/linux-2.6] / drivers / hwmon / thmc50.c
index 76a3859..7dfb4de 100644 (file)
@@ -35,8 +35,12 @@ MODULE_LICENSE("GPL");
 static const unsigned short normal_i2c[] = { 0x2c, 0x2d, 0x2e, I2C_CLIENT_END };
 
 /* Insmod parameters */
-I2C_CLIENT_INSMOD_2(thmc50, adm1022);
-I2C_CLIENT_MODULE_PARM(adm1022_temp3, "List of adapter,address pairs "
+enum chips { thmc50, adm1022 };
+
+static unsigned short adm1022_temp3[16];
+static unsigned int adm1022_temp3_num;
+module_param_array(adm1022_temp3, ushort, &adm1022_temp3_num, 0);
+MODULE_PARM_DESC(adm1022_temp3, "List of adapter,address pairs "
                        "to enable 3rd temperature (ADM1022 only)");
 
 /* Many THMC50 constants specified below */
@@ -55,12 +59,14 @@ I2C_CLIENT_MODULE_PARM(adm1022_temp3, "List of adapter,address pairs "
 static const u8 THMC50_REG_TEMP[] = { 0x27, 0x26, 0x20 };
 static const u8 THMC50_REG_TEMP_MIN[] = { 0x3A, 0x38, 0x2C };
 static const u8 THMC50_REG_TEMP_MAX[] = { 0x39, 0x37, 0x2B };
+static const u8 THMC50_REG_TEMP_CRITICAL[] = { 0x13, 0x14, 0x14 };
+static const u8 THMC50_REG_TEMP_DEFAULT[] = { 0x17, 0x18, 0x18 };
 
 #define THMC50_REG_CONF_nFANOFF                        0x20
+#define THMC50_REG_CONF_PROGRAMMED             0x08
 
 /* Each client has this additional data */
 struct thmc50_data {
-       struct i2c_client client;
        struct device *hwmon_dev;
 
        struct mutex update_lock;
@@ -73,21 +79,36 @@ struct thmc50_data {
        s8 temp_input[3];
        s8 temp_max[3];
        s8 temp_min[3];
+       s8 temp_critical[3];
        u8 analog_out;
        u8 alarms;
 };
 
-static int thmc50_attach_adapter(struct i2c_adapter *adapter);
-static int thmc50_detach_client(struct i2c_client *client);
+static int thmc50_detect(struct i2c_client *client,
+                        struct i2c_board_info *info);
+static int thmc50_probe(struct i2c_client *client,
+                       const struct i2c_device_id *id);
+static int thmc50_remove(struct i2c_client *client);
 static void thmc50_init_client(struct i2c_client *client);
 static struct thmc50_data *thmc50_update_device(struct device *dev);
 
+static const struct i2c_device_id thmc50_id[] = {
+       { "adm1022", adm1022 },
+       { "thmc50", thmc50 },
+       { }
+};
+MODULE_DEVICE_TABLE(i2c, thmc50_id);
+
 static struct i2c_driver thmc50_driver = {
+       .class = I2C_CLASS_HWMON,
        .driver = {
                .name = "thmc50",
        },
-       .attach_adapter = thmc50_attach_adapter,
-       .detach_client = thmc50_detach_client,
+       .probe = thmc50_probe,
+       .remove = thmc50_remove,
+       .id_table = thmc50_id,
+       .detect = thmc50_detect,
+       .address_list = normal_i2c,
 };
 
 static ssize_t show_analog_out(struct device *dev,
@@ -186,6 +207,15 @@ static ssize_t set_temp_max(struct device *dev, struct device_attribute *attr,
        return count;
 }
 
+static ssize_t show_temp_critical(struct device *dev,
+                                 struct device_attribute *attr,
+                                 char *buf)
+{
+       int nr = to_sensor_dev_attr(attr)->index;
+       struct thmc50_data *data = thmc50_update_device(dev);
+       return sprintf(buf, "%d\n", data->temp_critical[nr] * 1000);
+}
+
 static ssize_t show_alarm(struct device *dev, struct device_attribute *attr,
                          char *buf)
 {
@@ -201,7 +231,9 @@ static SENSOR_DEVICE_ATTR(temp##offset##_input, S_IRUGO, show_temp, \
 static SENSOR_DEVICE_ATTR(temp##offset##_min, S_IRUGO | S_IWUSR,       \
                        show_temp_min, set_temp_min, offset - 1);       \
 static SENSOR_DEVICE_ATTR(temp##offset##_max, S_IRUGO | S_IWUSR,       \
-                       show_temp_max, set_temp_max, offset - 1);
+                       show_temp_max, set_temp_max, offset - 1);       \
+static SENSOR_DEVICE_ATTR(temp##offset##_crit, S_IRUGO,                        \
+                       show_temp_critical, NULL, offset - 1);
 
 temp_reg(1);
 temp_reg(2);
@@ -221,10 +253,12 @@ static struct attribute *thmc50_attributes[] = {
        &sensor_dev_attr_temp1_max.dev_attr.attr,
        &sensor_dev_attr_temp1_min.dev_attr.attr,
        &sensor_dev_attr_temp1_input.dev_attr.attr,
+       &sensor_dev_attr_temp1_crit.dev_attr.attr,
        &sensor_dev_attr_temp1_alarm.dev_attr.attr,
        &sensor_dev_attr_temp2_max.dev_attr.attr,
        &sensor_dev_attr_temp2_min.dev_attr.attr,
        &sensor_dev_attr_temp2_input.dev_attr.attr,
+       &sensor_dev_attr_temp2_crit.dev_attr.attr,
        &sensor_dev_attr_temp2_alarm.dev_attr.attr,
        &sensor_dev_attr_temp2_fault.dev_attr.attr,
        &sensor_dev_attr_pwm1.dev_attr.attr,
@@ -241,6 +275,7 @@ static struct attribute *temp3_attributes[] = {
        &sensor_dev_attr_temp3_max.dev_attr.attr,
        &sensor_dev_attr_temp3_min.dev_attr.attr,
        &sensor_dev_attr_temp3_input.dev_attr.attr,
+       &sensor_dev_attr_temp3_crit.dev_attr.attr,
        &sensor_dev_attr_temp3_alarm.dev_attr.attr,
        &sensor_dev_attr_temp3_fault.dev_attr.attr,
        NULL
@@ -250,99 +285,83 @@ static const struct attribute_group temp3_group = {
        .attrs = temp3_attributes,
 };
 
-static int thmc50_detect(struct i2c_adapter *adapter, int address, int kind)
+/* Return 0 if detection is successful, -ENODEV otherwise */
+static int thmc50_detect(struct i2c_client *client,
+                        struct i2c_board_info *info)
 {
        unsigned company;
        unsigned revision;
        unsigned config;
-       struct i2c_client *client;
-       struct thmc50_data *data;
-       struct device *dev;
-       int err = 0;
+       struct i2c_adapter *adapter = client->adapter;
        const char *type_name;
 
        if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA)) {
                pr_debug("thmc50: detect failed, "
                         "smbus byte data not supported!\n");
-               goto exit;
+               return -ENODEV;
        }
 
-       /* OK. For now, we presume we have a valid client. We now create the
-          client structure, even though we cannot fill it completely yet.
-          But it allows us to access thmc50 registers. */
-       if (!(data = kzalloc(sizeof(struct thmc50_data), GFP_KERNEL))) {
-               pr_debug("thmc50: detect failed, kzalloc failed!\n");
-               err = -ENOMEM;
-               goto exit;
-       }
-
-       client = &data->client;
-       i2c_set_clientdata(client, data);
-       client->addr = address;
-       client->adapter = adapter;
-       client->driver = &thmc50_driver;
-       dev = &client->dev;
-
        pr_debug("thmc50: Probing for THMC50 at 0x%2X on bus %d\n",
                 client->addr, i2c_adapter_id(client->adapter));
 
-       /* Now, we do the remaining detection. */
        company = i2c_smbus_read_byte_data(client, THMC50_REG_COMPANY_ID);
        revision = i2c_smbus_read_byte_data(client, THMC50_REG_DIE_CODE);
        config = i2c_smbus_read_byte_data(client, THMC50_REG_CONF);
+       if (revision < 0xc0 || (config & 0x10))
+               return -ENODEV;
 
-       if (kind == 0)
-               kind = thmc50;
-       else if (kind < 0) {
-               err = -ENODEV;
-               if (revision >= 0xc0 && ((config & 0x10) == 0)) {
-                       if (company == 0x49) {
-                               kind = thmc50;
-                               err = 0;
-                       } else if (company == 0x41) {
-                               kind = adm1022;
-                               err = 0;
-                       }
-               }
-       }
-       if (err == -ENODEV) {
-               pr_debug("thmc50: Detection of THMC50/ADM1022 failed\n");
-               goto exit_free;
-       }
-       data->type = kind;
-
-       if (kind == adm1022) {
+       if (company == 0x41) {
                int id = i2c_adapter_id(client->adapter);
                int i;
 
                type_name = "adm1022";
-               data->has_temp3 = (config >> 7) & 1;    /* config MSB */
                for (i = 0; i + 1 < adm1022_temp3_num; i += 2)
                        if (adm1022_temp3[i] == id &&
-                           adm1022_temp3[i + 1] == address) {
+                           adm1022_temp3[i + 1] == client->addr) {
                                /* enable 2nd remote temp */
-                               data->has_temp3 = 1;
+                               config |= (1 << 7);
+                               i2c_smbus_write_byte_data(client,
+                                                         THMC50_REG_CONF,
+                                                         config);
                                break;
                        }
-       } else {
+       } else if (company == 0x49) {
                type_name = "thmc50";
+       } else {
+               pr_debug("thmc50: Detection of THMC50/ADM1022 failed\n");
+               return -ENODEV;
        }
+
        pr_debug("thmc50: Detected %s (version %x, revision %x)\n",
                 type_name, (revision >> 4) - 0xc, revision & 0xf);
 
-       /* Fill in the remaining client fields & put it into the global list */
-       strlcpy(client->name, type_name, I2C_NAME_SIZE);
-       mutex_init(&data->update_lock);
+       strlcpy(info->type, type_name, I2C_NAME_SIZE);
 
-       /* Tell the I2C layer a new client has arrived */
-       if ((err = i2c_attach_client(client)))
-               goto exit_free;
+       return 0;
+}
+
+static int thmc50_probe(struct i2c_client *client,
+                       const struct i2c_device_id *id)
+{
+       struct thmc50_data *data;
+       int err;
+
+       data = kzalloc(sizeof(struct thmc50_data), GFP_KERNEL);
+       if (!data) {
+               pr_debug("thmc50: detect failed, kzalloc failed!\n");
+               err = -ENOMEM;
+               goto exit;
+       }
+
+       i2c_set_clientdata(client, data);
+       data->type = id->driver_data;
+       mutex_init(&data->update_lock);
 
        thmc50_init_client(client);
 
        /* Register sysfs hooks */
        if ((err = sysfs_create_group(&client->dev.kobj, &thmc50_group)))
-               goto exit_detach;
+               goto exit_free;
 
        /* Register ADM1022 sysfs hooks */
        if (data->has_temp3)
@@ -364,34 +383,21 @@ exit_remove_sysfs:
                sysfs_remove_group(&client->dev.kobj, &temp3_group);
 exit_remove_sysfs_thmc50:
        sysfs_remove_group(&client->dev.kobj, &thmc50_group);
-exit_detach:
-       i2c_detach_client(client);
 exit_free:
        kfree(data);
 exit:
        return err;
 }
 
-static int thmc50_attach_adapter(struct i2c_adapter *adapter)
-{
-       if (!(adapter->class & I2C_CLASS_HWMON))
-               return 0;
-       return i2c_probe(adapter, &addr_data, thmc50_detect);
-}
-
-static int thmc50_detach_client(struct i2c_client *client)
+static int thmc50_remove(struct i2c_client *client)
 {
        struct thmc50_data *data = i2c_get_clientdata(client);
-       int err;
 
        hwmon_device_unregister(data->hwmon_dev);
        sysfs_remove_group(&client->dev.kobj, &thmc50_group);
        if (data->has_temp3)
                sysfs_remove_group(&client->dev.kobj, &temp3_group);
 
-       if ((err = i2c_detach_client(client)))
-               return err;
-
        kfree(data);
 
        return 0;
@@ -412,8 +418,8 @@ static void thmc50_init_client(struct i2c_client *client)
        }
        config = i2c_smbus_read_byte_data(client, THMC50_REG_CONF);
        config |= 0x1;  /* start the chip if it is in standby mode */
-       if (data->has_temp3)
-               config |= 0x80;         /* enable 2nd remote temp */
+       if (data->type == adm1022 && (config & (1 << 7)))
+               data->has_temp3 = 1;
        i2c_smbus_write_byte_data(client, THMC50_REG_CONF, config);
 }
 
@@ -430,6 +436,10 @@ static struct thmc50_data *thmc50_update_device(struct device *dev)
 
                int temps = data->has_temp3 ? 3 : 2;
                int i;
+               int prog = i2c_smbus_read_byte_data(client, THMC50_REG_CONF);
+
+               prog &= THMC50_REG_CONF_PROGRAMMED;
+
                for (i = 0; i < temps; i++) {
                        data->temp_input[i] = i2c_smbus_read_byte_data(client,
                                                THMC50_REG_TEMP[i]);
@@ -437,6 +447,10 @@ static struct thmc50_data *thmc50_update_device(struct device *dev)
                                                THMC50_REG_TEMP_MAX[i]);
                        data->temp_min[i] = i2c_smbus_read_byte_data(client,
                                                THMC50_REG_TEMP_MIN[i]);
+                       data->temp_critical[i] =
+                               i2c_smbus_read_byte_data(client,
+                                       prog ? THMC50_REG_TEMP_CRITICAL[i]
+                                            : THMC50_REG_TEMP_DEFAULT[i]);
                }
                data->analog_out =
                    i2c_smbus_read_byte_data(client, THMC50_REG_ANALOG_OUT);