hwmon: (lm85) Simplify RANGE_TO_REG
[safe/jmp/linux-2.6] / drivers / hwmon / lm85.c
index 6b676df..94a10ec 100644 (file)
@@ -5,6 +5,7 @@
     Copyright (c) 2002, 2003  Philip Pokorny <ppokorny@penguincomputing.com>
     Copyright (c) 2003        Margit Schubert-While <margitsw@t-online.de>
     Copyright (c) 2004        Justin Thiessen <jthiessen@penguincomputing.com>
+    Copyright (C) 2007, 2008  Jean Delvare <khali@linux-fr.org>
 
     Chip details at          <http://www.national.com/ds/LM/LM85.pdf>
 
@@ -173,40 +174,39 @@ static int RANGE_TO_REG(int range)
 {
        int i;
 
-       if (range >= lm85_range_map[15])
-               return 15;
-
        /* Find the closest match */
-       for (i = 14; i >= 0; --i) {
-               if (range >= lm85_range_map[i]) {
-                       if ((lm85_range_map[i + 1] - range) <
-                                       (range - lm85_range_map[i]))
-                               return i + 1;
-                       return i;
-               }
+       for (i = 0; i < 15; ++i) {
+               if (range <= (lm85_range_map[i] + lm85_range_map[i + 1]) / 2)
+                       break;
        }
 
-       return 0;
+       return i;
 }
 #define RANGE_FROM_REG(val)    lm85_range_map[(val) & 0x0f]
 
 /* These are the PWM frequency encodings */
 static const int lm85_freq_map[8] = { /* 1 Hz */
-       10, 15, 23, 30, 38, 47, 62, 94
+       10, 15, 23, 30, 38, 47, 61, 94
+};
+static const int adm1027_freq_map[8] = { /* 1 Hz */
+       11, 15, 22, 29, 35, 44, 59, 88
 };
 
-static int FREQ_TO_REG(int freq)
+static int FREQ_TO_REG(const int *map, int freq)
 {
        int i;
 
-       if (freq >= lm85_freq_map[7])
-               return 7;
+       /* Find the closest match */
        for (i = 0; i < 7; ++i)
-               if (freq <= lm85_freq_map[i])
+               if (freq <= (map[i] + map[i + 1]) / 2)
                        break;
        return i;
 }
-#define FREQ_FROM_REG(val)     lm85_freq_map[(val) & 0x07]
+
+static int FREQ_FROM_REG(const int *map, u8 reg)
+{
+       return map[reg & 0x07];
+}
 
 /* Since we can't use strings, I'm abusing these numbers
  *   to stand in for the following meanings:
@@ -282,8 +282,8 @@ struct lm85_autofan {
 /* For each registered chip, we need to keep some data in memory.
    The structure is dynamically allocated. */
 struct lm85_data {
-       struct i2c_client client;
        struct device *hwmon_dev;
+       const int *freq_map;
        enum chips type;
 
        struct mutex update_lock;
@@ -310,22 +310,40 @@ struct lm85_data {
        struct lm85_zone zone[3];
 };
 
-static int lm85_attach_adapter(struct i2c_adapter *adapter);
-static int lm85_detect(struct i2c_adapter *adapter, int address,
-                       int kind);
-static int lm85_detach_client(struct i2c_client *client);
+static int lm85_detect(struct i2c_client *client, int kind,
+                      struct i2c_board_info *info);
+static int lm85_probe(struct i2c_client *client,
+                     const struct i2c_device_id *id);
+static int lm85_remove(struct i2c_client *client);
 
 static int lm85_read_value(struct i2c_client *client, u8 reg);
 static void lm85_write_value(struct i2c_client *client, u8 reg, int value);
 static struct lm85_data *lm85_update_device(struct device *dev);
 
 
+static const struct i2c_device_id lm85_id[] = {
+       { "adm1027", adm1027 },
+       { "adt7463", adt7463 },
+       { "lm85", any_chip },
+       { "lm85b", lm85b },
+       { "lm85c", lm85c },
+       { "emc6d100", emc6d100 },
+       { "emc6d101", emc6d100 },
+       { "emc6d102", emc6d102 },
+       { }
+};
+MODULE_DEVICE_TABLE(i2c, lm85_id);
+
 static struct i2c_driver lm85_driver = {
+       .class          = I2C_CLASS_HWMON,
        .driver = {
                .name   = "lm85",
        },
-       .attach_adapter = lm85_attach_adapter,
-       .detach_client  = lm85_detach_client,
+       .probe          = lm85_probe,
+       .remove         = lm85_remove,
+       .id_table       = lm85_id,
+       .detect         = lm85_detect,
+       .address_data   = &addr_data,
 };
 
 
@@ -533,7 +551,8 @@ static ssize_t show_pwm_freq(struct device *dev,
 {
        int nr = to_sensor_dev_attr(attr)->index;
        struct lm85_data *data = lm85_update_device(dev);
-       return sprintf(buf, "%d\n", FREQ_FROM_REG(data->pwm_freq[nr]));
+       return sprintf(buf, "%d\n", FREQ_FROM_REG(data->freq_map,
+                                                 data->pwm_freq[nr]));
 }
 
 static ssize_t set_pwm_freq(struct device *dev,
@@ -545,7 +564,7 @@ static ssize_t set_pwm_freq(struct device *dev,
        long val = simple_strtol(buf, NULL, 10);
 
        mutex_lock(&data->update_lock);
-       data->pwm_freq[nr] = FREQ_TO_REG(val);
+       data->pwm_freq[nr] = FREQ_TO_REG(data->freq_map, val);
        lm85_write_value(client, LM85_REG_AFAN_RANGE(nr),
                (data->zone[nr].range << 4)
                | data->pwm_freq[nr]);
@@ -956,13 +975,6 @@ temp_auto(1);
 temp_auto(2);
 temp_auto(3);
 
-static int lm85_attach_adapter(struct i2c_adapter *adapter)
-{
-       if (!(adapter->class & I2C_CLASS_HWMON))
-               return 0;
-       return i2c_probe(adapter, &addr_data, lm85_detect);
-}
-
 static struct attribute *lm85_attributes[] = {
        &sensor_dev_attr_fan1_input.dev_attr.attr,
        &sensor_dev_attr_fan2_input.dev_attr.attr,
@@ -1102,30 +1114,19 @@ static void lm85_init_client(struct i2c_client *client)
                dev_warn(&client->dev, "Device is not ready\n");
 }
 
-static int lm85_detect(struct i2c_adapter *adapter, int address,
-               int kind)
+/* Return 0 if detection is successful, -ENODEV otherwise */
+static int lm85_detect(struct i2c_client *client, int kind,
+                      struct i2c_board_info *info)
 {
-       struct i2c_client *client;
-       struct lm85_data *data;
-       int err = 0;
+       struct i2c_adapter *adapter = client->adapter;
+       int address = client->addr;
        const char *type_name;
 
        if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA)) {
                /* We need to be able to do byte I/O */
-               goto ERROR0;
+               return -ENODEV;
        }
 
-       if (!(data = kzalloc(sizeof(struct lm85_data), GFP_KERNEL))) {
-               err = -ENOMEM;
-               goto ERROR0;
-       }
-
-       client = &data->client;
-       i2c_set_clientdata(client, data);
-       client->addr = address;
-       client->adapter = adapter;
-       client->driver = &lm85_driver;
-
        /* If auto-detecting, determine the chip type */
        if (kind < 0) {
                int company = lm85_read_value(client, LM85_REG_COMPANY);
@@ -1139,7 +1140,7 @@ static int lm85_detect(struct i2c_adapter *adapter, int address,
                if ((verstep & LM85_VERSTEP_VMASK) != LM85_VERSTEP_GENERIC) {
                        dev_dbg(&adapter->dev, "Autodetection failed: "
                                "unsupported version\n");
-                       goto ERROR1;
+                       return -ENODEV;
                }
                kind = any_chip;
 
@@ -1177,11 +1178,10 @@ static int lm85_detect(struct i2c_adapter *adapter, int address,
                } else {
                        dev_dbg(&adapter->dev, "Autodetection failed: "
                                "unknown vendor\n");
-                       goto ERROR1;
+                       return -ENODEV;
                }
        }
 
-       /* Fill in the chip specific driver values */
        switch (kind) {
        case lm85b:
                type_name = "lm85b";
@@ -1204,16 +1204,36 @@ static int lm85_detect(struct i2c_adapter *adapter, int address,
        default:
                type_name = "lm85";
        }
-       strlcpy(client->name, type_name, I2C_NAME_SIZE);
+       strlcpy(info->type, type_name, I2C_NAME_SIZE);
 
-       /* Fill in the remaining client fields */
-       data->type = kind;
+       return 0;
+}
+
+static int lm85_probe(struct i2c_client *client,
+                     const struct i2c_device_id *id)
+{
+       struct lm85_data *data;
+       int err;
+
+       data = kzalloc(sizeof(struct lm85_data), GFP_KERNEL);
+       if (!data)
+               return -ENOMEM;
+
+       i2c_set_clientdata(client, data);
+       data->type = id->driver_data;
        mutex_init(&data->update_lock);
 
-       /* Tell the I2C layer a new client has arrived */
-       err = i2c_attach_client(client);
-       if (err)
-               goto ERROR1;
+       /* Fill in the chip specific driver values */
+       switch (data->type) {
+       case adm1027:
+       case adt7463:
+       case emc6d100:
+       case emc6d102:
+               data->freq_map = adm1027_freq_map;
+               break;
+       default:
+               data->freq_map = lm85_freq_map;
+       }
 
        /* Set the VRM version */
        data->vrm = vid_which_vrm();
@@ -1224,18 +1244,18 @@ static int lm85_detect(struct i2c_adapter *adapter, int address,
        /* Register sysfs hooks */
        err = sysfs_create_group(&client->dev.kobj, &lm85_group);
        if (err)
-               goto ERROR2;
+               goto ERROR1;
 
        /* The ADT7463 has an optional VRM 10 mode where pin 21 is used
           as a sixth digital VID input rather than an analog input. */
        data->vid = lm85_read_value(client, LM85_REG_VID);
-       if (!(kind == adt7463 && (data->vid & 0x80)))
+       if (!(data->type == adt7463 && (data->vid & 0x80)))
                if ((err = sysfs_create_group(&client->dev.kobj,
                                        &lm85_group_in4)))
                        goto ERROR3;
 
        /* The EMC6D100 has 3 additional voltage inputs */
-       if (kind == emc6d100)
+       if (data->type == emc6d100)
                if ((err = sysfs_create_group(&client->dev.kobj,
                                        &lm85_group_in567)))
                        goto ERROR3;
@@ -1252,17 +1272,14 @@ static int lm85_detect(struct i2c_adapter *adapter, int address,
  ERROR3:
        sysfs_remove_group(&client->dev.kobj, &lm85_group);
        sysfs_remove_group(&client->dev.kobj, &lm85_group_in4);
-       if (kind == emc6d100)
+       if (data->type == emc6d100)
                sysfs_remove_group(&client->dev.kobj, &lm85_group_in567);
- ERROR2:
-       i2c_detach_client(client);
  ERROR1:
        kfree(data);
- ERROR0:
        return err;
 }
 
-static int lm85_detach_client(struct i2c_client *client)
+static int lm85_remove(struct i2c_client *client)
 {
        struct lm85_data *data = i2c_get_clientdata(client);
        hwmon_device_unregister(data->hwmon_dev);
@@ -1270,7 +1287,6 @@ static int lm85_detach_client(struct i2c_client *client)
        sysfs_remove_group(&client->dev.kobj, &lm85_group_in4);
        if (data->type == emc6d100)
                sysfs_remove_group(&client->dev.kobj, &lm85_group_in567);
-       i2c_detach_client(client);
        kfree(data);
        return 0;
 }