drm/drm_crtc: return -EFAULT on copy_to_user errors
[safe/jmp/linux-2.6] / drivers / edac / i5100_edac.c
index 43430bf..ee9753c 100644 (file)
  * Intel 5100X Chipset Memory Controller Hub (MCH) - Datasheet
  *      http://download.intel.com/design/chipsets/datashts/318378.pdf
  *
+ * The intel 5100 has two independent channels. EDAC core currently
+ * can not reflect this configuration so instead the chip-select
+ * rows for each respective channel are layed out one after another,
+ * the first half belonging to channel 0, the second half belonging
+ * to channel 1.
  */
 #include <linux/module.h>
 #include <linux/init.h>
 #include <linux/pci.h>
 #include <linux/pci_ids.h>
-#include <linux/slab.h>
 #include <linux/edac.h>
 #include <linux/delay.h>
 #include <linux/mmzone.h>
 
 #include "edac_core.h"
 
-/* register addresses and bit field accessors... */
+/* register addresses */
 
 /* device 16, func 1 */
+#define I5100_MC               0x40    /* Memory Control Register */
+#define        I5100_MC_SCRBEN_MASK    (1 << 7)
+#define        I5100_MC_SCRBDONE_MASK  (1 << 4)
 #define I5100_MS               0x44    /* Memory Status Register */
 #define I5100_SPDDATA          0x48    /* Serial Presence Detect Status Reg */
-#define                I5100_SPDDATA_RDO(a)    ((a) >> 15 & 1)
-#define                I5100_SPDDATA_SBE(a)    ((a) >> 13 & 1)
-#define                I5100_SPDDATA_BUSY(a)   ((a) >> 12 & 1)
-#define                I5100_SPDDATA_DATA(a)   ((a)       & ((1 << 8) - 1))
 #define I5100_SPDCMD           0x4c    /* Serial Presence Detect Command Reg */
-#define                I5100_SPDCMD_DTI(a)     (((a) & ((1 << 4) - 1)) << 28)
-#define                I5100_SPDCMD_CKOVRD(a)  (((a) & 1)              << 27)
-#define                I5100_SPDCMD_SA(a)      (((a) & ((1 << 3) - 1)) << 24)
-#define                I5100_SPDCMD_BA(a)      (((a) & ((1 << 8) - 1)) << 16)
-#define                I5100_SPDCMD_DATA(a)    (((a) & ((1 << 8) - 1)) <<  8)
-#define                I5100_SPDCMD_CMD(a)     ((a) & 1)
 #define I5100_TOLM             0x6c    /* Top of Low Memory */
-#define                I5100_TOLM_TOLM(a)      ((a) >> 12 & ((1 << 4) - 1))
 #define I5100_MIR0             0x80    /* Memory Interleave Range 0 */
 #define I5100_MIR1             0x84    /* Memory Interleave Range 1 */
 #define I5100_AMIR_0           0x8c    /* Adjusted Memory Interleave Range 0 */
 #define I5100_AMIR_1           0x90    /* Adjusted Memory Interleave Range 1 */
-#define                I5100_MIR_LIMIT(a)      ((a) >> 4 & ((1 << 12) - 1))
-#define                I5100_MIR_WAY1(a)       ((a) >> 1 & 1)
-#define                I5100_MIR_WAY0(a)       ((a)      & 1)
 #define I5100_FERR_NF_MEM      0xa0    /* MC First Non Fatal Errors */
-#define                I5100_FERR_NF_MEM_CHAN_INDX(a)  ((a) >> 28 & 1)
-#define                I5100_FERR_NF_MEM_SPD_MASK      (1 << 18)
 #define                I5100_FERR_NF_MEM_M16ERR_MASK   (1 << 16)
 #define                I5100_FERR_NF_MEM_M15ERR_MASK   (1 << 15)
 #define                I5100_FERR_NF_MEM_M14ERR_MASK   (1 << 14)
-#define                I5100_FERR_NF_MEM_
-#define                I5100_FERR_NF_MEM_
+#define                I5100_FERR_NF_MEM_M12ERR_MASK   (1 << 12)
+#define                I5100_FERR_NF_MEM_M11ERR_MASK   (1 << 11)
+#define                I5100_FERR_NF_MEM_M10ERR_MASK   (1 << 10)
+#define                I5100_FERR_NF_MEM_M6ERR_MASK    (1 << 6)
+#define                I5100_FERR_NF_MEM_M5ERR_MASK    (1 << 5)
+#define                I5100_FERR_NF_MEM_M4ERR_MASK    (1 << 4)
+#define                I5100_FERR_NF_MEM_M1ERR_MASK    1
 #define                I5100_FERR_NF_MEM_ANY_MASK      \
                        (I5100_FERR_NF_MEM_M16ERR_MASK | \
                        I5100_FERR_NF_MEM_M15ERR_MASK | \
-                       I5100_FERR_NF_MEM_M14ERR_MASK)
-#define                I5100_FERR_NF_MEM_ANY(a)  ((a) & I5100_FERR_NF_MEM_ANY_MASK)
+                       I5100_FERR_NF_MEM_M14ERR_MASK | \
+                       I5100_FERR_NF_MEM_M12ERR_MASK | \
+                       I5100_FERR_NF_MEM_M11ERR_MASK | \
+                       I5100_FERR_NF_MEM_M10ERR_MASK | \
+                       I5100_FERR_NF_MEM_M6ERR_MASK | \
+                       I5100_FERR_NF_MEM_M5ERR_MASK | \
+                       I5100_FERR_NF_MEM_M4ERR_MASK | \
+                       I5100_FERR_NF_MEM_M1ERR_MASK)
 #define        I5100_NERR_NF_MEM       0xa4    /* MC Next Non-Fatal Errors */
-#define                I5100_NERR_NF_MEM_ANY(a)  I5100_FERR_NF_MEM_ANY(a)
+#define I5100_EMASK_MEM                0xa8    /* MC Error Mask Register */
 
 /* device 21 and 22, func 0 */
 #define I5100_MTR_0    0x154   /* Memory Technology Registers 0-3 */
 #define I5100_DMIR     0x15c   /* DIMM Interleave Range */
-#define                I5100_DMIR_LIMIT(a)     ((a) >> 16 & ((1 << 11) - 1))
-#define                I5100_DMIR_RANK(a, i)   ((a) >> (4 * i) & ((1 <<  2) - 1))
-#define I5100_MTR_4    0x1b0   /* Memory Technology Registers 4,5 */
-#define                I5100_MTR_PRESENT(a)    ((a) >> 10 & 1)
-#define                I5100_MTR_ETHROTTLE(a)  ((a) >>  9 & 1)
-#define                I5100_MTR_WIDTH(a)      ((a) >>  8 & 1)
-#define                I5100_MTR_NUMBANK(a)    ((a) >>  6 & 1)
-#define                I5100_MTR_NUMROW(a)     ((a) >>  2 & ((1 << 2) - 1))
-#define                I5100_MTR_NUMCOL(a)     ((a)       & ((1 << 2) - 1))
 #define        I5100_VALIDLOG  0x18c   /* Valid Log Markers */
-#define                I5100_VALIDLOG_REDMEMVALID(a)   ((a) >> 2 & 1)
-#define                I5100_VALIDLOG_RECMEMVALID(a)   ((a) >> 1 & 1)
-#define                I5100_VALIDLOG_NRECMEMVALID(a)  ((a)      & 1)
 #define        I5100_NRECMEMA  0x190   /* Non-Recoverable Memory Error Log Reg A */
-#define                I5100_NRECMEMA_MERR(a)          ((a) >> 15 & ((1 << 5) - 1))
-#define                I5100_NRECMEMA_BANK(a)          ((a) >> 12 & ((1 << 3) - 1))
-#define                I5100_NRECMEMA_RANK(a)          ((a) >>  8 & ((1 << 3) - 1))
-#define                I5100_NRECMEMA_DM_BUF_ID(a)     ((a)       & ((1 << 8) - 1))
 #define        I5100_NRECMEMB  0x194   /* Non-Recoverable Memory Error Log Reg B */
-#define                I5100_NRECMEMB_CAS(a)           ((a) >> 16 & ((1 << 13) - 1))
-#define                I5100_NRECMEMB_RAS(a)           ((a)       & ((1 << 16) - 1))
 #define        I5100_REDMEMA   0x198   /* Recoverable Memory Data Error Log Reg A */
-#define                I5100_REDMEMA_SYNDROME(a)       (a)
 #define        I5100_REDMEMB   0x19c   /* Recoverable Memory Data Error Log Reg B */
-#define                I5100_REDMEMB_ECC_LOCATOR(a)    ((a) & ((1 << 18) - 1))
 #define        I5100_RECMEMA   0x1a0   /* Recoverable Memory Error Log Reg A */
-#define                I5100_RECMEMA_MERR(a)           I5100_NRECMEMA_MERR(a)
-#define                I5100_RECMEMA_BANK(a)           I5100_NRECMEMA_BANK(a)
-#define                I5100_RECMEMA_RANK(a)           I5100_NRECMEMA_RANK(a)
-#define                I5100_RECMEMA_DM_BUF_ID(a)      I5100_NRECMEMA_DM_BUF_ID(a)
 #define        I5100_RECMEMB   0x1a4   /* Recoverable Memory Error Log Reg B */
-#define                I5100_RECMEMB_CAS(a)            I5100_NRECMEMB_CAS(a)
-#define                I5100_RECMEMB_RAS(a)            I5100_NRECMEMB_RAS(a)
+#define I5100_MTR_4    0x1b0   /* Memory Technology Registers 4,5 */
+
+/* bit field accessors */
+
+static inline u32 i5100_mc_scrben(u32 mc)
+{
+       return mc >> 7 & 1;
+}
+
+static inline u32 i5100_mc_errdeten(u32 mc)
+{
+       return mc >> 5 & 1;
+}
+
+static inline u32 i5100_mc_scrbdone(u32 mc)
+{
+       return mc >> 4 & 1;
+}
+
+static inline u16 i5100_spddata_rdo(u16 a)
+{
+       return a >> 15 & 1;
+}
+
+static inline u16 i5100_spddata_sbe(u16 a)
+{
+       return a >> 13 & 1;
+}
+
+static inline u16 i5100_spddata_busy(u16 a)
+{
+       return a >> 12 & 1;
+}
+
+static inline u16 i5100_spddata_data(u16 a)
+{
+       return a & ((1 << 8) - 1);
+}
+
+static inline u32 i5100_spdcmd_create(u32 dti, u32 ckovrd, u32 sa, u32 ba,
+                                     u32 data, u32 cmd)
+{
+       return  ((dti & ((1 << 4) - 1))  << 28) |
+               ((ckovrd & 1)            << 27) |
+               ((sa & ((1 << 3) - 1))   << 24) |
+               ((ba & ((1 << 8) - 1))   << 16) |
+               ((data & ((1 << 8) - 1)) <<  8) |
+               (cmd & 1);
+}
+
+static inline u16 i5100_tolm_tolm(u16 a)
+{
+       return a >> 12 & ((1 << 4) - 1);
+}
+
+static inline u16 i5100_mir_limit(u16 a)
+{
+       return a >> 4 & ((1 << 12) - 1);
+}
+
+static inline u16 i5100_mir_way1(u16 a)
+{
+       return a >> 1 & 1;
+}
+
+static inline u16 i5100_mir_way0(u16 a)
+{
+       return a & 1;
+}
+
+static inline u32 i5100_ferr_nf_mem_chan_indx(u32 a)
+{
+       return a >> 28 & 1;
+}
+
+static inline u32 i5100_ferr_nf_mem_any(u32 a)
+{
+       return a & I5100_FERR_NF_MEM_ANY_MASK;
+}
+
+static inline u32 i5100_nerr_nf_mem_any(u32 a)
+{
+       return i5100_ferr_nf_mem_any(a);
+}
+
+static inline u32 i5100_dmir_limit(u32 a)
+{
+       return a >> 16 & ((1 << 11) - 1);
+}
+
+static inline u32 i5100_dmir_rank(u32 a, u32 i)
+{
+       return a >> (4 * i) & ((1 << 2) - 1);
+}
+
+static inline u16 i5100_mtr_present(u16 a)
+{
+       return a >> 10 & 1;
+}
+
+static inline u16 i5100_mtr_ethrottle(u16 a)
+{
+       return a >> 9 & 1;
+}
+
+static inline u16 i5100_mtr_width(u16 a)
+{
+       return a >> 8 & 1;
+}
+
+static inline u16 i5100_mtr_numbank(u16 a)
+{
+       return a >> 6 & 1;
+}
+
+static inline u16 i5100_mtr_numrow(u16 a)
+{
+       return a >> 2 & ((1 << 2) - 1);
+}
+
+static inline u16 i5100_mtr_numcol(u16 a)
+{
+       return a & ((1 << 2) - 1);
+}
+
+
+static inline u32 i5100_validlog_redmemvalid(u32 a)
+{
+       return a >> 2 & 1;
+}
+
+static inline u32 i5100_validlog_recmemvalid(u32 a)
+{
+       return a >> 1 & 1;
+}
+
+static inline u32 i5100_validlog_nrecmemvalid(u32 a)
+{
+       return a & 1;
+}
+
+static inline u32 i5100_nrecmema_merr(u32 a)
+{
+       return a >> 15 & ((1 << 5) - 1);
+}
+
+static inline u32 i5100_nrecmema_bank(u32 a)
+{
+       return a >> 12 & ((1 << 3) - 1);
+}
+
+static inline u32 i5100_nrecmema_rank(u32 a)
+{
+       return a >>  8 & ((1 << 3) - 1);
+}
+
+static inline u32 i5100_nrecmema_dm_buf_id(u32 a)
+{
+       return a & ((1 << 8) - 1);
+}
+
+static inline u32 i5100_nrecmemb_cas(u32 a)
+{
+       return a >> 16 & ((1 << 13) - 1);
+}
+
+static inline u32 i5100_nrecmemb_ras(u32 a)
+{
+       return a & ((1 << 16) - 1);
+}
+
+static inline u32 i5100_redmemb_ecc_locator(u32 a)
+{
+       return a & ((1 << 18) - 1);
+}
+
+static inline u32 i5100_recmema_merr(u32 a)
+{
+       return i5100_nrecmema_merr(a);
+}
+
+static inline u32 i5100_recmema_bank(u32 a)
+{
+       return i5100_nrecmema_bank(a);
+}
+
+static inline u32 i5100_recmema_rank(u32 a)
+{
+       return i5100_nrecmema_rank(a);
+}
+
+static inline u32 i5100_recmema_dm_buf_id(u32 a)
+{
+       return i5100_nrecmema_dm_buf_id(a);
+}
+
+static inline u32 i5100_recmemb_cas(u32 a)
+{
+       return i5100_nrecmemb_cas(a);
+}
+
+static inline u32 i5100_recmemb_ras(u32 a)
+{
+       return i5100_nrecmemb_ras(a);
+}
 
 /* some generic limits */
-#define I5100_MAX_RANKS_PER_CTLR       6
-#define I5100_MAX_CTLRS                        2
+#define I5100_MAX_RANKS_PER_CHAN       6
+#define I5100_CHANNELS                     2
 #define I5100_MAX_RANKS_PER_DIMM       4
 #define I5100_DIMM_ADDR_LINES          (6 - 3) /* 64 bits / 8 bits per byte */
-#define I5100_MAX_DIMM_SLOTS_PER_CTLR  4
+#define I5100_MAX_DIMM_SLOTS_PER_CHAN  4
 #define I5100_MAX_RANK_INTERLEAVE      4
 #define I5100_MAX_DMIRS                        5
+#define I5100_SCRUB_REFRESH_RATE       (5 * 60 * HZ)
 
 struct i5100_priv {
        /* ranks on each dimm -- 0 maps to not present -- obtained via SPD */
-       int dimm_numrank[I5100_MAX_CTLRS][I5100_MAX_DIMM_SLOTS_PER_CTLR];
+       int dimm_numrank[I5100_CHANNELS][I5100_MAX_DIMM_SLOTS_PER_CHAN];
 
        /*
         * mainboard chip select map -- maps i5100 chip selects to
         * DIMM slot chip selects.  In the case of only 4 ranks per
-        * controller, the mapping is fairly obvious but not unique.
-        * we map -1 -> NC and assume both controllers use the same
+        * channel, the mapping is fairly obvious but not unique.
+        * we map -1 -> NC and assume both channels use the same
         * map...
         *
         */
-       int dimm_csmap[I5100_MAX_DIMM_SLOTS_PER_CTLR][I5100_MAX_RANKS_PER_DIMM];
+       int dimm_csmap[I5100_MAX_DIMM_SLOTS_PER_CHAN][I5100_MAX_RANKS_PER_DIMM];
 
        /* memory interleave range */
        struct {
                u64      limit;
                unsigned way[2];
-       } mir[I5100_MAX_CTLRS];
+       } mir[I5100_CHANNELS];
 
        /* adjusted memory interleave range register */
-       unsigned amir[I5100_MAX_CTLRS];
+       unsigned amir[I5100_CHANNELS];
 
        /* dimm interleave range */
        struct {
                unsigned rank[I5100_MAX_RANK_INTERLEAVE];
                u64      limit;
-       } dmir[I5100_MAX_CTLRS][I5100_MAX_DMIRS];
+       } dmir[I5100_CHANNELS][I5100_MAX_DMIRS];
 
        /* memory technology registers... */
        struct {
@@ -145,71 +327,41 @@ struct i5100_priv {
                unsigned numbank;       /* 2 or 3 lines */
                unsigned numrow;        /* 13 .. 16 lines */
                unsigned numcol;        /* 11 .. 12 lines */
-       } mtr[I5100_MAX_CTLRS][I5100_MAX_RANKS_PER_CTLR];
+       } mtr[I5100_CHANNELS][I5100_MAX_RANKS_PER_CHAN];
 
        u64 tolm;               /* top of low memory in bytes */
-       unsigned ranksperctlr;  /* number of ranks per controller */
+       unsigned ranksperchan;  /* number of ranks per channel */
 
        struct pci_dev *mc;     /* device 16 func 1 */
        struct pci_dev *ch0mm;  /* device 21 func 0 */
        struct pci_dev *ch1mm;  /* device 22 func 0 */
+
+       struct delayed_work i5100_scrubbing;
+       int scrub_enable;
 };
 
-/* map a rank/ctlr to a slot number on the mainboard */
+/* map a rank/chan to a slot number on the mainboard */
 static int i5100_rank_to_slot(const struct mem_ctl_info *mci,
-                             int ctlr, int rank)
+                             int chan, int rank)
 {
        const struct i5100_priv *priv = mci->pvt_info;
        int i;
 
-       for (i = 0; i < I5100_MAX_DIMM_SLOTS_PER_CTLR; i++) {
+       for (i = 0; i < I5100_MAX_DIMM_SLOTS_PER_CHAN; i++) {
                int j;
-               const int numrank = priv->dimm_numrank[ctlr][i];
+               const int numrank = priv->dimm_numrank[chan][i];
 
                for (j = 0; j < numrank; j++)
                        if (priv->dimm_csmap[i][j] == rank)
-                               return i * 2 + ctlr;
+                               return i * 2 + chan;
        }
 
        return -1;
 }
 
-/*
- * The processor bus memory addresses are broken into three
- * pieces, whereas the controller addresses are contiguous.
- *
- * here we map from the controller address space to the
- * processor address space:
- *
- *    Processor Address Space
- * +-----------------------------+
- * |                             |
- * |  "high" memory addresses    |
- * |                             |
- * +-----------------------------+ <- 4GB on the i5100
- * |                             |
- * |  other non-memory addresses |
- * |                             |
- * +-----------------------------+ <- top of low memory
- * |                             |
- * | "low" memory addresses      |
- * |                             |
- * +-----------------------------+
- */
-static unsigned long i5100_ctl_page_to_phys(struct mem_ctl_info *mci,
-                                           unsigned long cntlr_addr)
-{
-       const struct i5100_priv *priv = mci->pvt_info;
-
-       if (cntlr_addr < priv->tolm)
-               return cntlr_addr;
-
-       return (1ULL << 32) + (cntlr_addr - priv->tolm);
-}
-
 static const char *i5100_err_msg(unsigned err)
 {
-       const char *merrs[] = {
+       static const char *merrs[] = {
                "unknown", /* 0 */
                "uncorrectable data ECC on replay", /* 1 */
                "unknown", /* 2 */
@@ -242,32 +394,32 @@ static const char *i5100_err_msg(unsigned err)
        return "none";
 }
 
-/* convert csrow index into a rank (per controller -- 0..5) */
+/* convert csrow index into a rank (per channel -- 0..5) */
 static int i5100_csrow_to_rank(const struct mem_ctl_info *mci, int csrow)
 {
        const struct i5100_priv *priv = mci->pvt_info;
 
-       return csrow % priv->ranksperctlr;
+       return csrow % priv->ranksperchan;
 }
 
-/* convert csrow index into a controller (0..1) */
-static int i5100_csrow_to_cntlr(const struct mem_ctl_info *mci, int csrow)
+/* convert csrow index into a channel (0..1) */
+static int i5100_csrow_to_chan(const struct mem_ctl_info *mci, int csrow)
 {
        const struct i5100_priv *priv = mci->pvt_info;
 
-       return csrow / priv->ranksperctlr;
+       return csrow / priv->ranksperchan;
 }
 
 static unsigned i5100_rank_to_csrow(const struct mem_ctl_info *mci,
-                                   int ctlr, int rank)
+                                   int chan, int rank)
 {
        const struct i5100_priv *priv = mci->pvt_info;
 
-       return ctlr * priv->ranksperctlr + rank;
+       return chan * priv->ranksperchan + rank;
 }
 
 static void i5100_handle_ce(struct mem_ctl_info *mci,
-                           int ctlr,
+                           int chan,
                            unsigned bank,
                            unsigned rank,
                            unsigned long syndrome,
@@ -275,12 +427,12 @@ static void i5100_handle_ce(struct mem_ctl_info *mci,
                            unsigned ras,
                            const char *msg)
 {
-       const int csrow = i5100_rank_to_csrow(mci, ctlr, rank);
+       const int csrow = i5100_rank_to_csrow(mci, chan, rank);
 
        printk(KERN_ERR
-               "CE ctlr %d, bank %u, rank %u, syndrome 0x%lx, "
+               "CE chan %d, bank %u, rank %u, syndrome 0x%lx, "
                "cas %u, ras %u, csrow %u, label \"%s\": %s\n",
-               ctlr, bank, rank, syndrome, cas, ras,
+               chan, bank, rank, syndrome, cas, ras,
                csrow, mci->csrows[csrow].channels[0].label, msg);
 
        mci->ce_count++;
@@ -289,7 +441,7 @@ static void i5100_handle_ce(struct mem_ctl_info *mci,
 }
 
 static void i5100_handle_ue(struct mem_ctl_info *mci,
-                           int ctlr,
+                           int chan,
                            unsigned bank,
                            unsigned rank,
                            unsigned long syndrome,
@@ -297,23 +449,23 @@ static void i5100_handle_ue(struct mem_ctl_info *mci,
                            unsigned ras,
                            const char *msg)
 {
-       const int csrow = i5100_rank_to_csrow(mci, ctlr, rank);
+       const int csrow = i5100_rank_to_csrow(mci, chan, rank);
 
        printk(KERN_ERR
-               "UE ctlr %d, bank %u, rank %u, syndrome 0x%lx, "
+               "UE chan %d, bank %u, rank %u, syndrome 0x%lx, "
                "cas %u, ras %u, csrow %u, label \"%s\": %s\n",
-               ctlr, bank, rank, syndrome, cas, ras,
+               chan, bank, rank, syndrome, cas, ras,
                csrow, mci->csrows[csrow].channels[0].label, msg);
 
        mci->ue_count++;
        mci->csrows[csrow].ue_count++;
 }
 
-static void i5100_read_log(struct mem_ctl_info *mci, int ctlr,
+static void i5100_read_log(struct mem_ctl_info *mci, int chan,
                           u32 ferr, u32 nerr)
 {
        struct i5100_priv *priv = mci->pvt_info;
-       struct pci_dev *pdev = (ctlr) ? priv->ch1mm : priv->ch0mm;
+       struct pci_dev *pdev = (chan) ? priv->ch1mm : priv->ch0mm;
        u32 dw;
        u32 dw2;
        unsigned syndrome = 0;
@@ -326,24 +478,24 @@ static void i5100_read_log(struct mem_ctl_info *mci, int ctlr,
 
        pci_read_config_dword(pdev, I5100_VALIDLOG, &dw);
 
-       if (I5100_VALIDLOG_REDMEMVALID(dw)) {
+       if (i5100_validlog_redmemvalid(dw)) {
                pci_read_config_dword(pdev, I5100_REDMEMA, &dw2);
-               syndrome = I5100_REDMEMA_SYNDROME(dw2);
+               syndrome = dw2;
                pci_read_config_dword(pdev, I5100_REDMEMB, &dw2);
-               ecc_loc = I5100_REDMEMB_ECC_LOCATOR(dw2);
+               ecc_loc = i5100_redmemb_ecc_locator(dw2);
        }
 
-       if (I5100_VALIDLOG_RECMEMVALID(dw)) {
+       if (i5100_validlog_recmemvalid(dw)) {
                const char *msg;
 
                pci_read_config_dword(pdev, I5100_RECMEMA, &dw2);
-               merr = I5100_RECMEMA_MERR(dw2);
-               bank = I5100_RECMEMA_BANK(dw2);
-               rank = I5100_RECMEMA_RANK(dw2);
+               merr = i5100_recmema_merr(dw2);
+               bank = i5100_recmema_bank(dw2);
+               rank = i5100_recmema_rank(dw2);
 
                pci_read_config_dword(pdev, I5100_RECMEMB, &dw2);
-               cas = I5100_RECMEMB_CAS(dw2);
-               ras = I5100_RECMEMB_RAS(dw2);
+               cas = i5100_recmemb_cas(dw2);
+               ras = i5100_recmemb_ras(dw2);
 
                /* FIXME:  not really sure if this is what merr is...
                 */
@@ -352,20 +504,20 @@ static void i5100_read_log(struct mem_ctl_info *mci, int ctlr,
                else
                        msg = i5100_err_msg(nerr);
 
-               i5100_handle_ce(mci, ctlr, bank, rank, syndrome, cas, ras, msg);
+               i5100_handle_ce(mci, chan, bank, rank, syndrome, cas, ras, msg);
        }
 
-       if (I5100_VALIDLOG_NRECMEMVALID(dw)) {
+       if (i5100_validlog_nrecmemvalid(dw)) {
                const char *msg;
 
                pci_read_config_dword(pdev, I5100_NRECMEMA, &dw2);
-               merr = I5100_NRECMEMA_MERR(dw2);
-               bank = I5100_NRECMEMA_BANK(dw2);
-               rank = I5100_NRECMEMA_RANK(dw2);
+               merr = i5100_nrecmema_merr(dw2);
+               bank = i5100_nrecmema_bank(dw2);
+               rank = i5100_nrecmema_rank(dw2);
 
                pci_read_config_dword(pdev, I5100_NRECMEMB, &dw2);
-               cas = I5100_NRECMEMB_CAS(dw2);
-               ras = I5100_NRECMEMB_RAS(dw2);
+               cas = i5100_nrecmemb_cas(dw2);
+               ras = i5100_nrecmemb_ras(dw2);
 
                /* FIXME:  not really sure if this is what merr is...
                 */
@@ -374,7 +526,7 @@ static void i5100_read_log(struct mem_ctl_info *mci, int ctlr,
                else
                        msg = i5100_err_msg(nerr);
 
-               i5100_handle_ue(mci, ctlr, bank, rank, syndrome, cas, ras, msg);
+               i5100_handle_ue(mci, chan, bank, rank, syndrome, cas, ras, msg);
        }
 
        pci_write_config_dword(pdev, I5100_VALIDLOG, dw);
@@ -387,7 +539,7 @@ static void i5100_check_error(struct mem_ctl_info *mci)
 
 
        pci_read_config_dword(priv->mc, I5100_FERR_NF_MEM, &dw);
-       if (I5100_FERR_NF_MEM_ANY(dw)) {
+       if (i5100_ferr_nf_mem_any(dw)) {
                u32 dw2;
 
                pci_read_config_dword(priv->mc, I5100_NERR_NF_MEM, &dw2);
@@ -396,10 +548,84 @@ static void i5100_check_error(struct mem_ctl_info *mci)
                                               dw2);
                pci_write_config_dword(priv->mc, I5100_FERR_NF_MEM, dw);
 
-               i5100_read_log(mci, I5100_FERR_NF_MEM_CHAN_INDX(dw),
-                              I5100_FERR_NF_MEM_ANY(dw),
-                              I5100_NERR_NF_MEM_ANY(dw2));
+               i5100_read_log(mci, i5100_ferr_nf_mem_chan_indx(dw),
+                              i5100_ferr_nf_mem_any(dw),
+                              i5100_nerr_nf_mem_any(dw2));
+       }
+}
+
+/* The i5100 chipset will scrub the entire memory once, then
+ * set a done bit. Continuous scrubbing is achieved by enqueing
+ * delayed work to a workqueue, checking every few minutes if
+ * the scrubbing has completed and if so reinitiating it.
+ */
+
+static void i5100_refresh_scrubbing(struct work_struct *work)
+{
+       struct delayed_work *i5100_scrubbing = container_of(work,
+                                                           struct delayed_work,
+                                                           work);
+       struct i5100_priv *priv = container_of(i5100_scrubbing,
+                                              struct i5100_priv,
+                                              i5100_scrubbing);
+       u32 dw;
+
+       pci_read_config_dword(priv->mc, I5100_MC, &dw);
+
+       if (priv->scrub_enable) {
+
+               pci_read_config_dword(priv->mc, I5100_MC, &dw);
+
+               if (i5100_mc_scrbdone(dw)) {
+                       dw |= I5100_MC_SCRBEN_MASK;
+                       pci_write_config_dword(priv->mc, I5100_MC, dw);
+                       pci_read_config_dword(priv->mc, I5100_MC, &dw);
+               }
+
+               schedule_delayed_work(&(priv->i5100_scrubbing),
+                                     I5100_SCRUB_REFRESH_RATE);
+       }
+}
+/*
+ * The bandwidth is based on experimentation, feel free to refine it.
+ */
+static int i5100_set_scrub_rate(struct mem_ctl_info *mci,
+                                      u32 *bandwidth)
+{
+       struct i5100_priv *priv = mci->pvt_info;
+       u32 dw;
+
+       pci_read_config_dword(priv->mc, I5100_MC, &dw);
+       if (*bandwidth) {
+               priv->scrub_enable = 1;
+               dw |= I5100_MC_SCRBEN_MASK;
+               schedule_delayed_work(&(priv->i5100_scrubbing),
+                                     I5100_SCRUB_REFRESH_RATE);
+       } else {
+               priv->scrub_enable = 0;
+               dw &= ~I5100_MC_SCRBEN_MASK;
+               cancel_delayed_work(&(priv->i5100_scrubbing));
        }
+       pci_write_config_dword(priv->mc, I5100_MC, dw);
+
+       pci_read_config_dword(priv->mc, I5100_MC, &dw);
+
+       *bandwidth = 5900000 * i5100_mc_scrben(dw);
+
+       return 0;
+}
+
+static int i5100_get_scrub_rate(struct mem_ctl_info *mci,
+                               u32 *bandwidth)
+{
+       struct i5100_priv *priv = mci->pvt_info;
+       u32 dw;
+
+       pci_read_config_dword(priv->mc, I5100_MC, &dw);
+
+       *bandwidth = 5900000 * i5100_mc_scrben(dw);
+
+       return 0;
 }
 
 static struct pci_dev *pci_get_device_func(unsigned vendor,
@@ -425,19 +651,19 @@ static unsigned long __devinit i5100_npages(struct mem_ctl_info *mci,
                                            int csrow)
 {
        struct i5100_priv *priv = mci->pvt_info;
-       const unsigned ctlr_rank = i5100_csrow_to_rank(mci, csrow);
-       const unsigned ctlr = i5100_csrow_to_cntlr(mci, csrow);
+       const unsigned chan_rank = i5100_csrow_to_rank(mci, csrow);
+       const unsigned chan = i5100_csrow_to_chan(mci, csrow);
        unsigned addr_lines;
 
        /* dimm present? */
-       if (!priv->mtr[ctlr][ctlr_rank].present)
+       if (!priv->mtr[chan][chan_rank].present)
                return 0ULL;
 
        addr_lines =
                I5100_DIMM_ADDR_LINES +
-               priv->mtr[ctlr][ctlr_rank].numcol +
-               priv->mtr[ctlr][ctlr_rank].numrow +
-               priv->mtr[ctlr][ctlr_rank].numbank;
+               priv->mtr[chan][chan_rank].numcol +
+               priv->mtr[chan][chan_rank].numrow +
+               priv->mtr[chan][chan_rank].numbank;
 
        return (unsigned long)
                ((unsigned long long) (1ULL << addr_lines) / PAGE_SIZE);
@@ -449,11 +675,11 @@ static void __devinit i5100_init_mtr(struct mem_ctl_info *mci)
        struct pci_dev *mms[2] = { priv->ch0mm, priv->ch1mm };
        int i;
 
-       for (i = 0; i < I5100_MAX_CTLRS; i++) {
+       for (i = 0; i < I5100_CHANNELS; i++) {
                int j;
                struct pci_dev *pdev = mms[i];
 
-               for (j = 0; j < I5100_MAX_RANKS_PER_CTLR; j++) {
+               for (j = 0; j < I5100_MAX_RANKS_PER_CHAN; j++) {
                        const unsigned addr =
                                (j < 4) ? I5100_MTR_0 + j * 2 :
                                          I5100_MTR_4 + (j - 4) * 2;
@@ -461,12 +687,12 @@ static void __devinit i5100_init_mtr(struct mem_ctl_info *mci)
 
                        pci_read_config_word(pdev, addr, &w);
 
-                       priv->mtr[i][j].present = I5100_MTR_PRESENT(w);
-                       priv->mtr[i][j].ethrottle = I5100_MTR_ETHROTTLE(w);
-                       priv->mtr[i][j].width = 4 + 4 * I5100_MTR_WIDTH(w);
-                       priv->mtr[i][j].numbank = 2 + I5100_MTR_NUMBANK(w);
-                       priv->mtr[i][j].numrow = 13 + I5100_MTR_NUMROW(w);
-                       priv->mtr[i][j].numcol = 10 + I5100_MTR_NUMCOL(w);
+                       priv->mtr[i][j].present = i5100_mtr_present(w);
+                       priv->mtr[i][j].ethrottle = i5100_mtr_ethrottle(w);
+                       priv->mtr[i][j].width = 4 + 4 * i5100_mtr_width(w);
+                       priv->mtr[i][j].numbank = 2 + i5100_mtr_numbank(w);
+                       priv->mtr[i][j].numrow = 13 + i5100_mtr_numrow(w);
+                       priv->mtr[i][j].numcol = 10 + i5100_mtr_numcol(w);
                }
        }
 }
@@ -480,35 +706,30 @@ static int i5100_read_spd_byte(const struct mem_ctl_info *mci,
 {
        struct i5100_priv *priv = mci->pvt_info;
        u16 w;
-       u32 dw;
        unsigned long et;
 
        pci_read_config_word(priv->mc, I5100_SPDDATA, &w);
-       if (I5100_SPDDATA_BUSY(w))
+       if (i5100_spddata_busy(w))
                return -1;
 
-       dw =    I5100_SPDCMD_DTI(0xa) |
-               I5100_SPDCMD_CKOVRD(1) |
-               I5100_SPDCMD_SA(ch * 4 + slot) |
-               I5100_SPDCMD_BA(addr) |
-               I5100_SPDCMD_DATA(0) |
-               I5100_SPDCMD_CMD(0);
-       pci_write_config_dword(priv->mc, I5100_SPDCMD, dw);
+       pci_write_config_dword(priv->mc, I5100_SPDCMD,
+                              i5100_spdcmd_create(0xa, 1, ch * 4 + slot, addr,
+                                                  0, 0));
 
        /* wait up to 100ms */
        et = jiffies + HZ / 10;
        udelay(100);
        while (1) {
                pci_read_config_word(priv->mc, I5100_SPDDATA, &w);
-               if (!I5100_SPDDATA_BUSY(w))
+               if (!i5100_spddata_busy(w))
                        break;
                udelay(100);
        }
 
-       if (!I5100_SPDDATA_RDO(w) || I5100_SPDDATA_SBE(w))
+       if (!i5100_spddata_rdo(w) || i5100_spddata_sbe(w))
                return -1;
 
-       *byte = I5100_SPDDATA_DATA(w);
+       *byte = i5100_spddata_data(w);
 
        return 0;
 }
@@ -517,7 +738,6 @@ static int i5100_read_spd_byte(const struct mem_ctl_info *mci,
  * fill dimm chip select map
  *
  * FIXME:
- *   o only valid for 4 ranks per controller
  *   o not the only way to may chip selects to dimm slots
  *   o investigate if there is some way to obtain this map from the bios
  */
@@ -526,9 +746,7 @@ static void __devinit i5100_init_dimm_csmap(struct mem_ctl_info *mci)
        struct i5100_priv *priv = mci->pvt_info;
        int i;
 
-       WARN_ON(priv->ranksperctlr != 4);
-
-       for (i = 0; i < I5100_MAX_DIMM_SLOTS_PER_CTLR; i++) {
+       for (i = 0; i < I5100_MAX_DIMM_SLOTS_PER_CHAN; i++) {
                int j;
 
                for (j = 0; j < I5100_MAX_RANKS_PER_DIMM; j++)
@@ -536,12 +754,21 @@ static void __devinit i5100_init_dimm_csmap(struct mem_ctl_info *mci)
        }
 
        /* only 2 chip selects per slot... */
-       priv->dimm_csmap[0][0] = 0;
-       priv->dimm_csmap[0][1] = 3;
-       priv->dimm_csmap[1][0] = 1;
-       priv->dimm_csmap[1][1] = 2;
-       priv->dimm_csmap[2][0] = 2;
-       priv->dimm_csmap[3][0] = 3;
+       if (priv->ranksperchan == 4) {
+               priv->dimm_csmap[0][0] = 0;
+               priv->dimm_csmap[0][1] = 3;
+               priv->dimm_csmap[1][0] = 1;
+               priv->dimm_csmap[1][1] = 2;
+               priv->dimm_csmap[2][0] = 2;
+               priv->dimm_csmap[3][0] = 3;
+       } else {
+               priv->dimm_csmap[0][0] = 0;
+               priv->dimm_csmap[0][1] = 1;
+               priv->dimm_csmap[1][0] = 2;
+               priv->dimm_csmap[1][1] = 3;
+               priv->dimm_csmap[2][0] = 4;
+               priv->dimm_csmap[2][1] = 5;
+       }
 }
 
 static void __devinit i5100_init_dimm_layout(struct pci_dev *pdev,
@@ -550,10 +777,10 @@ static void __devinit i5100_init_dimm_layout(struct pci_dev *pdev,
        struct i5100_priv *priv = mci->pvt_info;
        int i;
 
-       for (i = 0; i < I5100_MAX_CTLRS; i++) {
+       for (i = 0; i < I5100_CHANNELS; i++) {
                int j;
 
-               for (j = 0; j < I5100_MAX_DIMM_SLOTS_PER_CTLR; j++) {
+               for (j = 0; j < I5100_MAX_DIMM_SLOTS_PER_CHAN; j++) {
                        u8 rank;
 
                        if (i5100_read_spd_byte(mci, i, j, 5, &rank) < 0)
@@ -576,24 +803,24 @@ static void __devinit i5100_init_interleaving(struct pci_dev *pdev,
        int i;
 
        pci_read_config_word(pdev, I5100_TOLM, &w);
-       priv->tolm = (u64) I5100_TOLM_TOLM(w) * 256 * 1024 * 1024;
+       priv->tolm = (u64) i5100_tolm_tolm(w) * 256 * 1024 * 1024;
 
        pci_read_config_word(pdev, I5100_MIR0, &w);
-       priv->mir[0].limit = (u64) I5100_MIR_LIMIT(w) << 28;
-       priv->mir[0].way[1] = I5100_MIR_WAY1(w);
-       priv->mir[0].way[0] = I5100_MIR_WAY0(w);
+       priv->mir[0].limit = (u64) i5100_mir_limit(w) << 28;
+       priv->mir[0].way[1] = i5100_mir_way1(w);
+       priv->mir[0].way[0] = i5100_mir_way0(w);
 
        pci_read_config_word(pdev, I5100_MIR1, &w);
-       priv->mir[1].limit = (u64) I5100_MIR_LIMIT(w) << 28;
-       priv->mir[1].way[1] = I5100_MIR_WAY1(w);
-       priv->mir[1].way[0] = I5100_MIR_WAY0(w);
+       priv->mir[1].limit = (u64) i5100_mir_limit(w) << 28;
+       priv->mir[1].way[1] = i5100_mir_way1(w);
+       priv->mir[1].way[0] = i5100_mir_way0(w);
 
        pci_read_config_word(pdev, I5100_AMIR_0, &w);
        priv->amir[0] = w;
        pci_read_config_word(pdev, I5100_AMIR_1, &w);
        priv->amir[1] = w;
 
-       for (i = 0; i < I5100_MAX_CTLRS; i++) {
+       for (i = 0; i < I5100_CHANNELS; i++) {
                int j;
 
                for (j = 0; j < 5; j++) {
@@ -602,10 +829,10 @@ static void __devinit i5100_init_interleaving(struct pci_dev *pdev,
                        pci_read_config_dword(mms[i], I5100_DMIR + j * 4, &dw);
 
                        priv->dmir[i][j].limit =
-                               (u64) I5100_DMIR_LIMIT(dw) << 28;
+                               (u64) i5100_dmir_limit(dw) << 28;
                        for (k = 0; k < I5100_MAX_RANKS_PER_DIMM; k++)
                                priv->dmir[i][j].rank[k] =
-                                       I5100_DMIR_RANK(dw, k);
+                                       i5100_dmir_rank(dw, k);
                }
        }
 
@@ -620,7 +847,7 @@ static void __devinit i5100_init_csrows(struct mem_ctl_info *mci)
 
        for (i = 0; i < mci->nr_csrows; i++) {
                const unsigned long npages = i5100_npages(mci, i);
-               const unsigned cntlr = i5100_csrow_to_cntlr(mci, i);
+               const unsigned chan = i5100_csrow_to_chan(mci, i);
                const unsigned rank = i5100_csrow_to_rank(mci, i);
 
                if (!npages)
@@ -638,7 +865,7 @@ static void __devinit i5100_init_csrows(struct mem_ctl_info *mci)
                mci->csrows[i].grain = 32;
                mci->csrows[i].csrow_idx = i;
                mci->csrows[i].dtype =
-                       (priv->mtr[cntlr][rank].width == 4) ? DEV_X4 : DEV_X8;
+                       (priv->mtr[chan][rank].width == 4) ? DEV_X4 : DEV_X8;
                mci->csrows[i].ue_count = 0;
                mci->csrows[i].ce_count = 0;
                mci->csrows[i].mtype = MEM_RDDR2;
@@ -650,7 +877,7 @@ static void __devinit i5100_init_csrows(struct mem_ctl_info *mci)
                mci->csrows[i].channels[0].csrow = mci->csrows + i;
                snprintf(mci->csrows[i].channels[0].label,
                         sizeof(mci->csrows[i].channels[0].label),
-                        "DIMM%u", i5100_rank_to_slot(mci, cntlr, rank));
+                        "DIMM%u", i5100_rank_to_slot(mci, chan, rank));
 
                total_pages += npages;
        }
@@ -676,22 +903,30 @@ static int __devinit i5100_init_one(struct pci_dev *pdev,
                goto bail;
        }
 
+       /* ECC enabled? */
+       pci_read_config_dword(pdev, I5100_MC, &dw);
+       if (!i5100_mc_errdeten(dw)) {
+               printk(KERN_INFO "i5100_edac: ECC not enabled.\n");
+               ret = -ENODEV;
+               goto bail_pdev;
+       }
+
        /* figure out how many ranks, from strapped state of 48GB_Mode input */
        pci_read_config_dword(pdev, I5100_MS, &dw);
        ranksperch = !!(dw & (1 << 8)) * 2 + 4;
 
-       if (ranksperch != 4) {
-               /* FIXME: get 6 ranks / controller to work - need hw... */
-               printk(KERN_INFO "i5100_edac: unsupported configuration.\n");
-               ret = -ENODEV;
-               goto bail;
-       }
+       /* enable error reporting... */
+       pci_read_config_dword(pdev, I5100_EMASK_MEM, &dw);
+       dw &= ~I5100_FERR_NF_MEM_ANY_MASK;
+       pci_write_config_dword(pdev, I5100_EMASK_MEM, dw);
 
        /* device 21, func 0, Channel 0 Memory Map, Error Flag/Mask, etc... */
        ch0mm = pci_get_device_func(PCI_VENDOR_ID_INTEL,
                                    PCI_DEVICE_ID_INTEL_5100_21, 0);
-       if (!ch0mm)
-               return -ENODEV;
+       if (!ch0mm) {
+               ret = -ENODEV;
+               goto bail_pdev;
+       }
 
        rc = pci_enable_device(ch0mm);
        if (rc < 0) {
@@ -704,7 +939,7 @@ static int __devinit i5100_init_one(struct pci_dev *pdev,
                                    PCI_DEVICE_ID_INTEL_5100_22, 0);
        if (!ch1mm) {
                ret = -ENODEV;
-               goto bail_ch0;
+               goto bail_disable_ch0;
        }
 
        rc = pci_enable_device(ch1mm);
@@ -716,17 +951,27 @@ static int __devinit i5100_init_one(struct pci_dev *pdev,
        mci = edac_mc_alloc(sizeof(*priv), ranksperch * 2, 1, 0);
        if (!mci) {
                ret = -ENOMEM;
-               goto bail_ch1;
+               goto bail_disable_ch1;
        }
 
        mci->dev = &pdev->dev;
 
        priv = mci->pvt_info;
-       priv->ranksperctlr = ranksperch;
+       priv->ranksperchan = ranksperch;
        priv->mc = pdev;
        priv->ch0mm = ch0mm;
        priv->ch1mm = ch1mm;
 
+       INIT_DELAYED_WORK(&(priv->i5100_scrubbing), i5100_refresh_scrubbing);
+
+       /* If scrubbing was already enabled by the bios, start maintaining it */
+       pci_read_config_dword(pdev, I5100_MC, &dw);
+       if (i5100_mc_scrben(dw)) {
+               priv->scrub_enable = 1;
+               schedule_delayed_work(&(priv->i5100_scrubbing),
+                                     I5100_SCRUB_REFRESH_RATE);
+       }
+
        i5100_init_dimm_layout(pdev, mci);
        i5100_init_interleaving(pdev, mci);
 
@@ -737,9 +982,11 @@ static int __devinit i5100_init_one(struct pci_dev *pdev,
        mci->mod_ver = "not versioned";
        mci->ctl_name = "i5100";
        mci->dev_name = pci_name(pdev);
-       mci->ctl_page_to_phys = i5100_ctl_page_to_phys;
+       mci->ctl_page_to_phys = NULL;
 
        mci->edac_check = i5100_check_error;
+       mci->set_sdram_scrub_rate = i5100_set_scrub_rate;
+       mci->get_sdram_scrub_rate = i5100_get_scrub_rate;
 
        i5100_init_csrows(mci);
 
@@ -755,20 +1002,31 @@ static int __devinit i5100_init_one(struct pci_dev *pdev,
 
        if (edac_mc_add_mc(mci)) {
                ret = -ENODEV;
-               goto bail_mc;
+               goto bail_scrub;
        }
 
-       goto bail;
+       return ret;
 
-bail_mc:
+bail_scrub:
+       priv->scrub_enable = 0;
+       cancel_delayed_work_sync(&(priv->i5100_scrubbing));
        edac_mc_free(mci);
 
+bail_disable_ch1:
+       pci_disable_device(ch1mm);
+
 bail_ch1:
        pci_dev_put(ch1mm);
 
+bail_disable_ch0:
+       pci_disable_device(ch0mm);
+
 bail_ch0:
        pci_dev_put(ch0mm);
 
+bail_pdev:
+       pci_disable_device(pdev);
+
 bail:
        return ret;
 }
@@ -784,6 +1042,13 @@ static void __devexit i5100_remove_one(struct pci_dev *pdev)
                return;
 
        priv = mci->pvt_info;
+
+       priv->scrub_enable = 0;
+       cancel_delayed_work_sync(&(priv->i5100_scrubbing));
+
+       pci_disable_device(pdev);
+       pci_disable_device(priv->ch0mm);
+       pci_disable_device(priv->ch1mm);
        pci_dev_put(priv->ch0mm);
        pci_dev_put(priv->ch1mm);