kill unused invalidate_inode_pages helper
[safe/jmp/linux-2.6] / drivers / char / isicom.c
index 4159292..300d5bd 100644 (file)
 #include <linux/fs.h>
 #include <linux/sched.h>
 #include <linux/serial.h>
+#include <linux/smp_lock.h>
 #include <linux/mm.h>
 #include <linux/interrupt.h>
 #include <linux/timer.h>
@@ -792,35 +793,30 @@ static inline void isicom_setup_board(struct isi_board *bp)
 {
        int channel;
        struct isi_port *port;
-       unsigned long flags;
 
-       spin_lock_irqsave(&bp->card_lock, flags);
-       if (bp->status & BOARD_ACTIVE) {
-               spin_unlock_irqrestore(&bp->card_lock, flags);
-               return;
+       bp->count++;
+       if (!(bp->status & BOARD_INIT)) {
+               port = bp->ports;
+               for (channel = 0; channel < bp->port_count; channel++, port++)
+                       drop_dtr_rts(port);
        }
-       port = bp->ports;
-       bp->status |= BOARD_ACTIVE;
-       for (channel = 0; channel < bp->port_count; channel++, port++)
-               drop_dtr_rts(port);
-       spin_unlock_irqrestore(&bp->card_lock, flags);
+       bp->status |= BOARD_ACTIVE | BOARD_INIT;
 }
 
-static int isicom_setup_port(struct tty_struct *tty)
+/* Activate and thus setup board are protected from races against shutdown
+   by the tty_port mutex */
+
+static int isicom_activate(struct tty_port *tport, struct tty_struct *tty)
 {
-       struct isi_port *port = tty->driver_data;
+       struct isi_port *port = container_of(tport, struct isi_port, port);
        struct isi_board *card = port->card;
        unsigned long flags;
 
-       if (port->port.flags & ASYNC_INITIALIZED)
-               return 0;
-       if (tty_port_alloc_xmit_buf(&port->port) < 0)
+       if (tty_port_alloc_xmit_buf(tport) < 0)
                return -ENOMEM;
 
        spin_lock_irqsave(&card->card_lock, flags);
-       clear_bit(TTY_IO_ERROR, &tty->flags);
-       if (port->port.count == 1)
-               card->count++;
+       isicom_setup_board(card);
 
        port->xmit_cnt = port->xmit_head = port->xmit_tail = 0;
 
@@ -831,9 +827,7 @@ static int isicom_setup_port(struct tty_struct *tty)
                outw(((ISICOM_KILLTX | ISICOM_KILLRX) << 8) | 0x06, card->base);
                InterruptTheCard(card->base);
        }
-
        isicom_config_port(tty);
-       port->port.flags |= ASYNC_INITIALIZED;
        spin_unlock_irqrestore(&card->card_lock, flags);
 
        return 0;
@@ -845,94 +839,62 @@ static int isicom_carrier_raised(struct tty_port *port)
        return (ip->status & ISI_DCD)?1 : 0;
 }
 
-static int isicom_open(struct tty_struct *tty, struct file *filp)
+static struct tty_port *isicom_find_port(struct tty_struct *tty)
 {
        struct isi_port *port;
        struct isi_board *card;
        unsigned int board;
-       int error, line;
+       int line = tty->index;
 
-       line = tty->index;
        if (line < 0 || line > PORT_COUNT-1)
-               return -ENODEV;
+               return NULL;
        board = BOARD(line);
        card = &isi_card[board];
 
        if (!(card->status & FIRMWARE_LOADED))
-               return -ENODEV;
+               return NULL;
 
        /*  open on a port greater than the port count for the card !!! */
        if (line > ((board * 16) + card->port_count - 1))
-               return -ENODEV;
+               return NULL;
 
        port = &isi_ports[line];
        if (isicom_paranoia_check(port, tty->name, "isicom_open"))
-               return -ENODEV;
+               return NULL;
 
-       isicom_setup_board(card);
-
-       /* FIXME: locking on port.count etc */
-       port->port.count++;
-       tty->driver_data = port;
-       tty_port_tty_set(&port->port, tty);
-       error = isicom_setup_port(tty);
-       if (error == 0)
-               error = tty_port_block_til_ready(&port->port, tty, filp);
-       return error;
+       return &port->port;
 }
 
-/* close et all */
-
-static inline void isicom_shutdown_board(struct isi_board *bp)
+static int isicom_open(struct tty_struct *tty, struct file *filp)
 {
-       if (bp->status & BOARD_ACTIVE)
-               bp->status &= ~BOARD_ACTIVE;
+       struct isi_port *port;
+       struct isi_board *card;
+       struct tty_port *tport;
+
+       tport = isicom_find_port(tty);
+       if (tport == NULL)
+               return -ENODEV;
+       port = container_of(tport, struct isi_port, port);
+       card = &isi_card[BOARD(tty->index)];
+
+       return tty_port_open(tport, tty, filp);
 }
 
+/* close et all */
+
 /* card->lock HAS to be held */
 static void isicom_shutdown_port(struct isi_port *port)
 {
        struct isi_board *card = port->card;
-       struct tty_struct *tty;
-
-       tty = tty_port_tty_get(&port->port);
-
-       if (!(port->port.flags & ASYNC_INITIALIZED)) {
-               tty_kref_put(tty);
-               return;
-       }
-
-       tty_port_free_xmit_buf(&port->port);
-       port->port.flags &= ~ASYNC_INITIALIZED;
-       /* 3rd October 2000 : Vinayak P Risbud */
-       tty_port_tty_set(&port->port, NULL);
-
-       /*Fix done by Anil .S on 30-04-2001
-       remote login through isi port has dtr toggle problem
-       due to which the carrier drops before the password prompt
-       appears on the remote end. Now we drop the dtr only if the
-       HUPCL(Hangup on close) flag is set for the tty*/
-
-       if (C_HUPCL(tty))
-               /* drop dtr on this port */
-               drop_dtr(port);
-
-       /* any other port uninits  */
-       if (tty)
-               set_bit(TTY_IO_ERROR, &tty->flags);
 
        if (--card->count < 0) {
                pr_dbg("isicom_shutdown_port: bad board(0x%lx) count %d.\n",
                        card->base, card->count);
                card->count = 0;
        }
-
-       /* last port was closed, shutdown that boad too */
-       if (C_HUPCL(tty)) {
-               if (!card->count)
-                       isicom_shutdown_board(card);
-       }
-       tty_kref_put(tty);
+       /* last port was closed, shutdown that board too */
+       if (!card->count)
+               card->status &= BOARD_ACTIVE;
 }
 
 static void isicom_flush_buffer(struct tty_struct *tty)
@@ -951,32 +913,29 @@ static void isicom_flush_buffer(struct tty_struct *tty)
        tty_wakeup(tty);
 }
 
-static void isicom_close(struct tty_struct *tty, struct file *filp)
+static void isicom_shutdown(struct tty_port *port)
 {
-       struct isi_port *ip = tty->driver_data;
-       struct tty_port *port = &ip->port;
-       struct isi_board *card;
+       struct isi_port *ip = container_of(port, struct isi_port, port);
+       struct isi_board *card = ip->card;
        unsigned long flags;
 
-       BUG_ON(!ip);
-
-       card = ip->card;
-       if (isicom_paranoia_check(ip, tty->name, "isicom_close"))
-               return;
-
        /* indicate to the card that no more data can be received
           on this port */
        spin_lock_irqsave(&card->card_lock, flags);
-       if (port->flags & ASYNC_INITIALIZED) {
-               card->port_status &= ~(1 << ip->channel);
-               outw(card->port_status, card->base + 0x02);
-       }
+       card->port_status &= ~(1 << ip->channel);
+       outw(card->port_status, card->base + 0x02);
        isicom_shutdown_port(ip);
        spin_unlock_irqrestore(&card->card_lock, flags);
+       tty_port_free_xmit_buf(port);
+}
 
-       isicom_flush_buffer(tty);
-       
-       tty_port_close_end(port, tty);
+static void isicom_close(struct tty_struct *tty, struct file *filp)
+{
+       struct isi_port *ip = tty->driver_data;
+       struct tty_port *port = &ip->port;
+       if (isicom_paranoia_check(ip, tty->name, "isicom_close"))
+               return;
+       tty_port_close(port, tty, filp);
 }
 
 /* write et all */
@@ -1306,15 +1265,9 @@ static void isicom_start(struct tty_struct *tty)
 static void isicom_hangup(struct tty_struct *tty)
 {
        struct isi_port *port = tty->driver_data;
-       unsigned long flags;
 
        if (isicom_paranoia_check(port, tty->name, "isicom_hangup"))
                return;
-
-       spin_lock_irqsave(&port->card->card_lock, flags);
-       isicom_shutdown_port(port);
-       spin_unlock_irqrestore(&port->card->card_lock, flags);
-
        tty_port_hangup(&port->port);
 }
 
@@ -1347,6 +1300,8 @@ static const struct tty_operations isicom_ops = {
 static const struct tty_port_operations isicom_port_ops = {
        .carrier_raised         = isicom_carrier_raised,
        .dtr_rts                = isicom_dtr_rts,
+       .activate               = isicom_activate,
+       .shutdown               = isicom_shutdown,
 };
 
 static int __devinit reset_card(struct pci_dev *pdev,
@@ -1478,10 +1433,10 @@ static int __devinit load_firmware(struct pci_dev *pdev,
                status = inw(base + 0x4);
                if (status != 0) {
                        dev_warn(&pdev->dev, "Card%d rejected load header:\n"
-                               KERN_WARNING "Address:0x%x\n"
-                               KERN_WARNING "Count:0x%x\n"
-                               KERN_WARNING "Status:0x%x\n",
-                               index + 1, frame->addr, frame->count, status);
+                                "Address:0x%x\n"
+                                "Count:0x%x\n"
+                                "Status:0x%x\n",
+                                index + 1, frame->addr, frame->count, status);
                        goto errrelfw;
                }
                outsw(base, frame->data, word_count);
@@ -1526,10 +1481,10 @@ static int __devinit load_firmware(struct pci_dev *pdev,
                status = inw(base + 0x4);
                if (status != 0) {
                        dev_warn(&pdev->dev, "Card%d rejected verify header:\n"
-                               KERN_WARNING "Address:0x%x\n"
-                               KERN_WARNING "Count:0x%x\n"
-                               KERN_WARNING "Status: 0x%x\n",
-                               index + 1, frame->addr, frame->count, status);
+                                "Address:0x%x\n"
+                                "Count:0x%x\n"
+                                "Status: 0x%x\n",
+                                index + 1, frame->addr, frame->count, status);
                        goto errrelfw;
                }