ARM: 5874/1: serial21285: fix disable_irq-from-interrupt-handler deadlock
[safe/jmp/linux-2.6] / drivers / acpi / utils.c
index ce093d4..811fec1 100644 (file)
 #include <acpi/acpi_bus.h>
 #include <acpi/acpi_drivers.h>
 
+#include "internal.h"
+
 #define _COMPONENT             ACPI_BUS_COMPONENT
-ACPI_MODULE_NAME("acpi_utils")
+ACPI_MODULE_NAME("utils");
 
 /* --------------------------------------------------------------------------
                             Object Evaluation Helpers
    -------------------------------------------------------------------------- */
+static void
+acpi_util_eval_error(acpi_handle h, acpi_string p, acpi_status s)
+{
 #ifdef ACPI_DEBUG_OUTPUT
-#define acpi_util_eval_error(h,p,s) {\
-       char prefix[80] = {'\0'};\
-       struct acpi_buffer buffer = {sizeof(prefix), prefix};\
-       acpi_get_name(h, ACPI_FULL_PATHNAME, &buffer);\
-       ACPI_DEBUG_PRINT((ACPI_DB_INFO, "Evaluate [%s.%s]: %s\n",\
-               (char *) prefix, p, acpi_format_exception(s))); }
+       char prefix[80] = {'\0'};
+       struct acpi_buffer buffer = {sizeof(prefix), prefix};
+       acpi_get_name(h, ACPI_FULL_PATHNAME, &buffer);
+       ACPI_DEBUG_PRINT((ACPI_DB_INFO, "Evaluate [%s.%s]: %s\n",
+               (char *) prefix, p, acpi_format_exception(s)));
 #else
-#define acpi_util_eval_error(h,p,s)
+       return;
 #endif
+}
+
 acpi_status
 acpi_extract_package(union acpi_object *package,
                     struct acpi_buffer *format, struct acpi_buffer *buffer)
@@ -58,33 +64,32 @@ acpi_extract_package(union acpi_object *package,
        u8 *head = NULL;
        u8 *tail = NULL;
 
-       ACPI_FUNCTION_TRACE("acpi_extract_package");
 
        if (!package || (package->type != ACPI_TYPE_PACKAGE)
            || (package->package.count < 1)) {
-               ACPI_WARNING((AE_INFO, "Invalid package argument"));
-               return_ACPI_STATUS(AE_BAD_PARAMETER);
+               printk(KERN_WARNING PREFIX "Invalid package argument\n");
+               return AE_BAD_PARAMETER;
        }
 
        if (!format || !format->pointer || (format->length < 1)) {
-               ACPI_WARNING((AE_INFO, "Invalid format argument"));
-               return_ACPI_STATUS(AE_BAD_PARAMETER);
+               printk(KERN_WARNING PREFIX "Invalid format argument\n");
+               return AE_BAD_PARAMETER;
        }
 
        if (!buffer) {
-               ACPI_WARNING((AE_INFO, "Invalid buffer argument"));
-               return_ACPI_STATUS(AE_BAD_PARAMETER);
+               printk(KERN_WARNING PREFIX "Invalid buffer argument\n");
+               return AE_BAD_PARAMETER;
        }
 
        format_count = (format->length / sizeof(char)) - 1;
        if (format_count > package->package.count) {
-               ACPI_WARNING((AE_INFO, "Format specifies more objects [%d]"
-                             " than exist in package [%d].",
-                             format_count, package->package.count));
-               return_ACPI_STATUS(AE_BAD_DATA);
+               printk(KERN_WARNING PREFIX "Format specifies more objects [%d]"
+                             " than exist in package [%d].\n",
+                             format_count, package->package.count);
+               return AE_BAD_DATA;
        }
 
-       format_string = (char *)format->pointer;
+       format_string = format->pointer;
 
        /*
         * Calculate size_required.
@@ -94,7 +99,7 @@ acpi_extract_package(union acpi_object *package,
                union acpi_object *element = &(package->package.elements[i]);
 
                if (!element) {
-                       return_ACPI_STATUS(AE_BAD_DATA);
+                       return AE_BAD_DATA;
                }
 
                switch (element->type) {
@@ -112,11 +117,11 @@ acpi_extract_package(union acpi_object *package,
                                tail_offset += sizeof(char *);
                                break;
                        default:
-                               ACPI_WARNING((AE_INFO, "Invalid package element"
+                               printk(KERN_WARNING PREFIX "Invalid package element"
                                              " [%d]: got number, expecing"
-                                             " [%c]",
-                                             i, format_string[i]));
-                               return_ACPI_STATUS(AE_BAD_DATA);
+                                             " [%c]\n",
+                                             i, format_string[i]);
+                               return AE_BAD_DATA;
                                break;
                        }
                        break;
@@ -138,11 +143,11 @@ acpi_extract_package(union acpi_object *package,
                                tail_offset += sizeof(u8 *);
                                break;
                        default:
-                               ACPI_WARNING((AE_INFO, "Invalid package element"
+                               printk(KERN_WARNING PREFIX "Invalid package element"
                                              " [%d] got string/buffer,"
-                                             " expecing [%c]",
-                                             i, format_string[i]));
-                               return_ACPI_STATUS(AE_BAD_DATA);
+                                             " expecing [%c]\n",
+                                             i, format_string[i]);
+                               return AE_BAD_DATA;
                                break;
                        }
                        break;
@@ -153,7 +158,7 @@ acpi_extract_package(union acpi_object *package,
                                          "Found unsupported element at index=%d\n",
                                          i));
                        /* TBD: handle nested packages... */
-                       return_ACPI_STATUS(AE_SUPPORT);
+                       return AE_SUPPORT;
                        break;
                }
        }
@@ -163,9 +168,9 @@ acpi_extract_package(union acpi_object *package,
         */
        if (buffer->length < size_required) {
                buffer->length = size_required;
-               return_ACPI_STATUS(AE_BUFFER_OVERFLOW);
+               return AE_BUFFER_OVERFLOW;
        } else if (buffer->length != size_required || !buffer->pointer) {
-               return_ACPI_STATUS(AE_BAD_PARAMETER);
+               return AE_BAD_PARAMETER;
        }
 
        head = buffer->pointer;
@@ -180,7 +185,7 @@ acpi_extract_package(union acpi_object *package,
                union acpi_object *element = &(package->package.elements[i]);
 
                if (!element) {
-                       return_ACPI_STATUS(AE_BAD_DATA);
+                       return AE_BAD_DATA;
                }
 
                switch (element->type) {
@@ -245,7 +250,7 @@ acpi_extract_package(union acpi_object *package,
                }
        }
 
-       return_ACPI_STATUS(AE_OK);
+       return AE_OK;
 }
 
 EXPORT_SYMBOL(acpi_extract_package);
@@ -253,43 +258,33 @@ EXPORT_SYMBOL(acpi_extract_package);
 acpi_status
 acpi_evaluate_integer(acpi_handle handle,
                      acpi_string pathname,
-                     struct acpi_object_list *arguments, unsigned long *data)
+                     struct acpi_object_list *arguments, unsigned long long *data)
 {
        acpi_status status = AE_OK;
-       union acpi_object *element;
+       union acpi_object element;
        struct acpi_buffer buffer = { 0, NULL };
 
-       ACPI_FUNCTION_TRACE("acpi_evaluate_integer");
-
        if (!data)
-               return_ACPI_STATUS(AE_BAD_PARAMETER);
-
-       element = kmalloc(sizeof(union acpi_object), GFP_KERNEL);
-       if (!element)
-               return_ACPI_STATUS(AE_NO_MEMORY);
+               return AE_BAD_PARAMETER;
 
-       memset(element, 0, sizeof(union acpi_object));
        buffer.length = sizeof(union acpi_object);
-       buffer.pointer = element;
+       buffer.pointer = &element;
        status = acpi_evaluate_object(handle, pathname, arguments, &buffer);
        if (ACPI_FAILURE(status)) {
                acpi_util_eval_error(handle, pathname, status);
-               kfree(element);
-               return_ACPI_STATUS(status);
+               return status;
        }
 
-       if (element->type != ACPI_TYPE_INTEGER) {
+       if (element.type != ACPI_TYPE_INTEGER) {
                acpi_util_eval_error(handle, pathname, AE_BAD_DATA);
-               kfree(element);
-               return_ACPI_STATUS(AE_BAD_DATA);
+               return AE_BAD_DATA;
        }
 
-       *data = element->integer.value;
-       kfree(element);
+       *data = element.integer.value;
 
-       ACPI_DEBUG_PRINT((ACPI_DB_INFO, "Return value [%lu]\n", *data));
+       ACPI_DEBUG_PRINT((ACPI_DB_INFO, "Return value [%llu]\n", *data));
 
-       return_ACPI_STATUS(AE_OK);
+       return AE_OK;
 }
 
 EXPORT_SYMBOL(acpi_evaluate_integer);
@@ -304,15 +299,14 @@ acpi_evaluate_string(acpi_handle handle,
        acpi_object *element = NULL;
        acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL };
 
-       ACPI_FUNCTION_TRACE("acpi_evaluate_string");
 
        if (!data)
-               return_ACPI_STATUS(AE_BAD_PARAMETER);
+               return AE_BAD_PARAMETER;
 
        status = acpi_evaluate_object(handle, pathname, arguments, &buffer);
        if (ACPI_FAILURE(status)) {
                acpi_util_eval_error(handle, pathname, status);
-               return_ACPI_STATUS(status);
+               return status;
        }
 
        element = (acpi_object *) buffer.pointer;
@@ -321,23 +315,22 @@ acpi_evaluate_string(acpi_handle handle,
            || (element->type != ACPI_TYPE_BUFFER)
            || !element->string.length) {
                acpi_util_eval_error(handle, pathname, AE_BAD_DATA);
-               return_ACPI_STATUS(AE_BAD_DATA);
+               return AE_BAD_DATA;
        }
 
-       *data = kmalloc(element->string.length + 1, GFP_KERNEL);
+       *data = kzalloc(element->string.length + 1, GFP_KERNEL);
        if (!data) {
-               ACPI_ERROR((AE_INFO, "Memory allocation"));
-               return_VALUE(-ENOMEM);
+               printk(KERN_ERR PREFIX "Memory allocation\n");
+               return -ENOMEM;
        }
-       memset(*data, 0, element->string.length + 1);
 
        memcpy(*data, element->string.pointer, element->string.length);
 
        ACPI_DEBUG_PRINT((ACPI_DB_INFO, "Return value [%s]\n", *data));
 
-       acpi_os_free(buffer.pointer);
+       kfree(buffer.pointer);
 
-       return_ACPI_STATUS(AE_OK);
+       return AE_OK;
 }
 #endif
 
@@ -353,10 +346,9 @@ acpi_evaluate_reference(acpi_handle handle,
        struct acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL };
        u32 i = 0;
 
-       ACPI_FUNCTION_TRACE("acpi_evaluate_reference");
 
        if (!list) {
-               return_ACPI_STATUS(AE_BAD_PARAMETER);
+               return AE_BAD_PARAMETER;
        }
 
        /* Evaluate object. */
@@ -365,32 +357,32 @@ acpi_evaluate_reference(acpi_handle handle,
        if (ACPI_FAILURE(status))
                goto end;
 
-       package = (union acpi_object *)buffer.pointer;
+       package = buffer.pointer;
 
        if ((buffer.length == 0) || !package) {
-               ACPI_ERROR((AE_INFO, "No return object (len %X ptr %p)",
-                           (unsigned)buffer.length, package));
+               printk(KERN_ERR PREFIX "No return object (len %X ptr %p)\n",
+                           (unsigned)buffer.length, package);
                status = AE_BAD_DATA;
                acpi_util_eval_error(handle, pathname, status);
                goto end;
        }
        if (package->type != ACPI_TYPE_PACKAGE) {
-               ACPI_ERROR((AE_INFO, "Expecting a [Package], found type %X",
-                           package->type));
+               printk(KERN_ERR PREFIX "Expecting a [Package], found type %X\n",
+                           package->type);
                status = AE_BAD_DATA;
                acpi_util_eval_error(handle, pathname, status);
                goto end;
        }
        if (!package->package.count) {
-               ACPI_ERROR((AE_INFO, "[Package] has zero elements (%p)",
-                           package));
+               printk(KERN_ERR PREFIX "[Package] has zero elements (%p)\n",
+                           package);
                status = AE_BAD_DATA;
                acpi_util_eval_error(handle, pathname, status);
                goto end;
        }
 
        if (package->package.count > ACPI_MAX_HANDLES) {
-               return_ACPI_STATUS(AE_NO_MEMORY);
+               return AE_NO_MEMORY;
        }
        list->count = package->package.count;
 
@@ -400,15 +392,21 @@ acpi_evaluate_reference(acpi_handle handle,
 
                element = &(package->package.elements[i]);
 
-               if (element->type != ACPI_TYPE_ANY) {
+               if (element->type != ACPI_TYPE_LOCAL_REFERENCE) {
                        status = AE_BAD_DATA;
-                       ACPI_ERROR((AE_INFO,
-                                   "Expecting a [Reference] package element, found type %X",
-                                   element->type));
+                       printk(KERN_ERR PREFIX
+                                   "Expecting a [Reference] package element, found type %X\n",
+                                   element->type);
                        acpi_util_eval_error(handle, pathname, status);
                        break;
                }
 
+               if (!element->reference.handle) {
+                       printk(KERN_WARNING PREFIX "Invalid reference in"
+                              " package %s\n", pathname);
+                       status = AE_NULL_ENTRY;
+                       break;
+               }
                /* Get the  acpi_handle. */
 
                list->handles[i] = element->reference.handle;
@@ -422,9 +420,9 @@ acpi_evaluate_reference(acpi_handle handle,
                //kfree(list->handles);
        }
 
-       acpi_os_free(buffer.pointer);
+       kfree(buffer.pointer);
 
-       return_ACPI_STATUS(status);
+       return status;
 }
 
 EXPORT_SYMBOL(acpi_evaluate_reference);