x86: paravirt spinlocks, modular build fix
[safe/jmp/linux-2.6] / arch / x86 / kernel / vm86_32.c
index 157e4be..38f566f 100644 (file)
 
 
 #define KVM86  ((struct kernel_vm86_struct *)regs)
-#define VMPI   KVM86->vm86plus
+#define VMPI   KVM86->vm86plus
 
 
 /*
  * 8- and 16-bit register defines..
  */
-#define AL(regs)       (((unsigned char *)&((regs)->pt.eax))[0])
-#define AH(regs)       (((unsigned char *)&((regs)->pt.eax))[1])
-#define IP(regs)       (*(unsigned short *)&((regs)->pt.eip))
-#define SP(regs)       (*(unsigned short *)&((regs)->pt.esp))
+#define AL(regs)       (((unsigned char *)&((regs)->pt.ax))[0])
+#define AH(regs)       (((unsigned char *)&((regs)->pt.ax))[1])
+#define IP(regs)       (*(unsigned short *)&((regs)->pt.ip))
+#define SP(regs)       (*(unsigned short *)&((regs)->pt.sp))
 
 /*
  * virtual flags (16 and 32-bit versions)
@@ -81,7 +81,7 @@
 #define VFLAGS (*(unsigned short *)&(current->thread.v86flags))
 #define VEFLAGS        (current->thread.v86flags)
 
-#define set_flags(X,new,mask) \
+#define set_flags(X, new, mask) \
 ((X) = ((X) & ~(mask)) | ((new) & (mask)))
 
 #define SAFE_MASK      (0xDD5)
@@ -93,12 +93,14 @@ static int copy_vm86_regs_to_user(struct vm86_regs __user *user,
 {
        int ret = 0;
 
-       /* kernel_vm86_regs is missing xgs, so copy everything up to
-          (but not including) orig_eax, and then rest including orig_eax. */
-       ret += copy_to_user(user, regs, offsetof(struct kernel_vm86_regs, pt.orig_eax));
-       ret += copy_to_user(&user->orig_eax, &regs->pt.orig_eax,
+       /*
+        * kernel_vm86_regs is missing gs, so copy everything up to
+        * (but not including) orig_eax, and then rest including orig_eax.
+        */
+       ret += copy_to_user(user, regs, offsetof(struct kernel_vm86_regs, pt.orig_ax));
+       ret += copy_to_user(&user->orig_eax, &regs->pt.orig_ax,
                            sizeof(struct kernel_vm86_regs) -
-                           offsetof(struct kernel_vm86_regs, pt.orig_eax));
+                           offsetof(struct kernel_vm86_regs, pt.orig_ax));
 
        return ret;
 }
@@ -110,18 +112,17 @@ static int copy_vm86_regs_from_user(struct kernel_vm86_regs *regs,
 {
        int ret = 0;
 
-       /* copy eax-xfs inclusive */
-       ret += copy_from_user(regs, user, offsetof(struct kernel_vm86_regs, pt.orig_eax));
-       /* copy orig_eax-__gsh+extra */
-       ret += copy_from_user(&regs->pt.orig_eax, &user->orig_eax,
+       /* copy ax-fs inclusive */
+       ret += copy_from_user(regs, user, offsetof(struct kernel_vm86_regs, pt.orig_ax));
+       /* copy orig_ax-__gsh+extra */
+       ret += copy_from_user(&regs->pt.orig_ax, &user->orig_eax,
                              sizeof(struct kernel_vm86_regs) -
-                             offsetof(struct kernel_vm86_regs, pt.orig_eax) +
+                             offsetof(struct kernel_vm86_regs, pt.orig_ax) +
                              extra);
        return ret;
 }
 
-struct pt_regs * FASTCALL(save_v86_state(struct kernel_vm86_regs * regs));
-struct pt_regs * fastcall save_v86_state(struct kernel_vm86_regs * regs)
+struct pt_regs *save_v86_state(struct kernel_vm86_regs *regs)
 {
        struct tss_struct *tss;
        struct pt_regs *ret;
@@ -138,24 +139,24 @@ struct pt_regs * fastcall save_v86_state(struct kernel_vm86_regs * regs)
                printk("no vm86_info: BAD\n");
                do_exit(SIGSEGV);
        }
-       set_flags(regs->pt.eflags, VEFLAGS, VIF_MASK | current->thread.v86mask);
-       tmp = copy_vm86_regs_to_user(&current->thread.vm86_info->regs,regs);
-       tmp += put_user(current->thread.screen_bitmap,&current->thread.vm86_info->screen_bitmap);
+       set_flags(regs->pt.flags, VEFLAGS, X86_EFLAGS_VIF | current->thread.v86mask);
+       tmp = copy_vm86_regs_to_user(&current->thread.vm86_info->regs, regs);
+       tmp += put_user(current->thread.screen_bitmap, &current->thread.vm86_info->screen_bitmap);
        if (tmp) {
                printk("vm86: could not access userspace vm86_info\n");
                do_exit(SIGSEGV);
        }
 
        tss = &per_cpu(init_tss, get_cpu());
-       current->thread.esp0 = current->thread.saved_esp0;
+       current->thread.sp0 = current->thread.saved_sp0;
        current->thread.sysenter_cs = __KERNEL_CS;
-       load_esp0(tss, &current->thread);
-       current->thread.saved_esp0 = 0;
+       load_sp0(tss, &current->thread);
+       current->thread.saved_sp0 = 0;
        put_cpu();
 
        ret = KVM86->regs32;
 
-       ret->xfs = current->thread.saved_fs;
+       ret->fs = current->thread.saved_fs;
        loadsegment(gs, current->thread.saved_gs);
 
        return ret;
@@ -197,7 +198,7 @@ static void do_sys_vm86(struct kernel_vm86_struct *info, struct task_struct *tsk
 
 asmlinkage int sys_vm86old(struct pt_regs regs)
 {
-       struct vm86_struct __user *v86 = (struct vm86_struct __user *)regs.ebx;
+       struct vm86_struct __user *v86 = (struct vm86_struct __user *)regs.bx;
        struct kernel_vm86_struct info; /* declare this _on top_,
                                         * this avoids wasting of stack space.
                                         * This remains on the stack until we
@@ -207,7 +208,7 @@ asmlinkage int sys_vm86old(struct pt_regs regs)
        int tmp, ret = -EPERM;
 
        tsk = current;
-       if (tsk->thread.saved_esp0)
+       if (tsk->thread.saved_sp0)
                goto out;
        tmp = copy_vm86_regs_from_user(&info.regs, &v86->regs,
                                       offsetof(struct kernel_vm86_struct, vm86plus) -
@@ -237,28 +238,29 @@ asmlinkage int sys_vm86(struct pt_regs regs)
        struct vm86plus_struct __user *v86;
 
        tsk = current;
-       switch (regs.ebx) {
-               case VM86_REQUEST_IRQ:
-               case VM86_FREE_IRQ:
-               case VM86_GET_IRQ_BITS:
-               case VM86_GET_AND_RESET_IRQ:
-                       ret = do_vm86_irq_handling(regs.ebx, (int)regs.ecx);
-                       goto out;
-               case VM86_PLUS_INSTALL_CHECK:
-                       /* NOTE: on old vm86 stuff this will return the error
-                          from access_ok(), because the subfunction is
-                          interpreted as (invalid) address to vm86_struct.
-                          So the installation check works.
-                        */
-                       ret = 0;
-                       goto out;
+       switch (regs.bx) {
+       case VM86_REQUEST_IRQ:
+       case VM86_FREE_IRQ:
+       case VM86_GET_IRQ_BITS:
+       case VM86_GET_AND_RESET_IRQ:
+               ret = do_vm86_irq_handling(regs.bx, (int)regs.cx);
+               goto out;
+       case VM86_PLUS_INSTALL_CHECK:
+               /*
+                * NOTE: on old vm86 stuff this will return the error
+                *  from access_ok(), because the subfunction is
+                *  interpreted as (invalid) address to vm86_struct.
+                *  So the installation check works.
+                */
+               ret = 0;
+               goto out;
        }
 
        /* we come here only for functions VM86_ENTER, VM86_ENTER_NO_BYPASS */
        ret = -EPERM;
-       if (tsk->thread.saved_esp0)
+       if (tsk->thread.saved_sp0)
                goto out;
-       v86 = (struct vm86plus_struct __user *)regs.ecx;
+       v86 = (struct vm86plus_struct __user *)regs.cx;
        tmp = copy_vm86_regs_from_user(&info.regs, &v86->regs,
                                       offsetof(struct kernel_vm86_struct, regs32) -
                                       sizeof(info.regs));
@@ -281,52 +283,52 @@ static void do_sys_vm86(struct kernel_vm86_struct *info, struct task_struct *tsk
 /*
  * make sure the vm86() system call doesn't try to do anything silly
  */
-       info->regs.pt.xds = 0;
-       info->regs.pt.xes = 0;
-       info->regs.pt.xfs = 0;
+       info->regs.pt.ds = 0;
+       info->regs.pt.es = 0;
+       info->regs.pt.fs = 0;
 
 /* we are clearing gs later just before "jmp resume_userspace",
  * because it is not saved/restored.
  */
 
 /*
- * The eflags register is also special: we cannot trust that the user
+ * The flags register is also special: we cannot trust that the user
  * has set it up safely, so this makes sure interrupt etc flags are
  * inherited from protected mode.
  */
-       VEFLAGS = info->regs.pt.eflags;
-       info->regs.pt.eflags &= SAFE_MASK;
-       info->regs.pt.eflags |= info->regs32->eflags & ~SAFE_MASK;
-       info->regs.pt.eflags |= VM_MASK;
+       VEFLAGS = info->regs.pt.flags;
+       info->regs.pt.flags &= SAFE_MASK;
+       info->regs.pt.flags |= info->regs32->flags & ~SAFE_MASK;
+       info->regs.pt.flags |= X86_VM_MASK;
 
        switch (info->cpu_type) {
-               case CPU_286:
-                       tsk->thread.v86mask = 0;
-                       break;
-               case CPU_386:
-                       tsk->thread.v86mask = NT_MASK | IOPL_MASK;
-                       break;
-               case CPU_486:
-                       tsk->thread.v86mask = AC_MASK | NT_MASK | IOPL_MASK;
-                       break;
-               default:
-                       tsk->thread.v86mask = ID_MASK | AC_MASK | NT_MASK | IOPL_MASK;
-                       break;
+       case CPU_286:
+               tsk->thread.v86mask = 0;
+               break;
+       case CPU_386:
+               tsk->thread.v86mask = X86_EFLAGS_NT | X86_EFLAGS_IOPL;
+               break;
+       case CPU_486:
+               tsk->thread.v86mask = X86_EFLAGS_AC | X86_EFLAGS_NT | X86_EFLAGS_IOPL;
+               break;
+       default:
+               tsk->thread.v86mask = X86_EFLAGS_ID | X86_EFLAGS_AC | X86_EFLAGS_NT | X86_EFLAGS_IOPL;
+               break;
        }
 
 /*
- * Save old state, set default return value (%eax) to 0
+ * Save old state, set default return value (%ax) to 0
  */
-       info->regs32->eax = 0;
-       tsk->thread.saved_esp0 = tsk->thread.esp0;
-       tsk->thread.saved_fs = info->regs32->xfs;
+       info->regs32->ax = 0;
+       tsk->thread.saved_sp0 = tsk->thread.sp0;
+       tsk->thread.saved_fs = info->regs32->fs;
        savesegment(gs, tsk->thread.saved_gs);
 
        tss = &per_cpu(init_tss, get_cpu());
-       tsk->thread.esp0 = (unsigned long) &info->VM86_TSS_ESP0;
+       tsk->thread.sp0 = (unsigned long) &info->VM86_TSS_ESP0;
        if (cpu_has_sep)
                tsk->thread.sysenter_cs = 0;
-       load_esp0(tss, &tsk->thread);
+       load_sp0(tss, &tsk->thread);
        put_cpu();
 
        tsk->thread.screen_bitmap = info->screen_bitmap;
@@ -347,86 +349,87 @@ static void do_sys_vm86(struct kernel_vm86_struct *info, struct task_struct *tsk
        /* we never return here */
 }
 
-static inline void return_to_32bit(struct kernel_vm86_regs * regs16, int retval)
+static inline void return_to_32bit(struct kernel_vm86_regs *regs16, int retval)
 {
-       struct pt_regs * regs32;
+       struct pt_regs *regs32;
 
        regs32 = save_v86_state(regs16);
-       regs32->eax = retval;
+       regs32->ax = retval;
        __asm__ __volatile__("movl %0,%%esp\n\t"
                "movl %1,%%ebp\n\t"
                "jmp resume_userspace"
                : : "r" (regs32), "r" (current_thread_info()));
 }
 
-static inline void set_IF(struct kernel_vm86_regs * regs)
+static inline void set_IF(struct kernel_vm86_regs *regs)
 {
-       VEFLAGS |= VIF_MASK;
-       if (VEFLAGS & VIP_MASK)
+       VEFLAGS |= X86_EFLAGS_VIF;
+       if (VEFLAGS & X86_EFLAGS_VIP)
                return_to_32bit(regs, VM86_STI);
 }
 
-static inline void clear_IF(struct kernel_vm86_regs * regs)
+static inline void clear_IF(struct kernel_vm86_regs *regs)
 {
-       VEFLAGS &= ~VIF_MASK;
+       VEFLAGS &= ~X86_EFLAGS_VIF;
 }
 
-static inline void clear_TF(struct kernel_vm86_regs * regs)
+static inline void clear_TF(struct kernel_vm86_regs *regs)
 {
-       regs->pt.eflags &= ~TF_MASK;
+       regs->pt.flags &= ~X86_EFLAGS_TF;
 }
 
-static inline void clear_AC(struct kernel_vm86_regs * regs)
+static inline void clear_AC(struct kernel_vm86_regs *regs)
 {
-       regs->pt.eflags &= ~AC_MASK;
+       regs->pt.flags &= ~X86_EFLAGS_AC;
 }
 
-/* It is correct to call set_IF(regs) from the set_vflags_*
+/*
+ * It is correct to call set_IF(regs) from the set_vflags_*
  * functions. However someone forgot to call clear_IF(regs)
  * in the opposite case.
  * After the command sequence CLI PUSHF STI POPF you should
- * end up with interrups disabled, but you ended up with
+ * end up with interrupts disabled, but you ended up with
  * interrupts enabled.
  *  ( I was testing my own changes, but the only bug I
  *    could find was in a function I had not changed. )
  * [KD]
  */
 
-static inline void set_vflags_long(unsigned long eflags, struct kernel_vm86_regs * regs)
+static inline void set_vflags_long(unsigned long flags, struct kernel_vm86_regs *regs)
 {
-       set_flags(VEFLAGS, eflags, current->thread.v86mask);
-       set_flags(regs->pt.eflags, eflags, SAFE_MASK);
-       if (eflags & IF_MASK)
+       set_flags(VEFLAGS, flags, current->thread.v86mask);
+       set_flags(regs->pt.flags, flags, SAFE_MASK);
+       if (flags & X86_EFLAGS_IF)
                set_IF(regs);
        else
                clear_IF(regs);
 }
 
-static inline void set_vflags_short(unsigned short flags, struct kernel_vm86_regs * regs)
+static inline void set_vflags_short(unsigned short flags, struct kernel_vm86_regs *regs)
 {
        set_flags(VFLAGS, flags, current->thread.v86mask);
-       set_flags(regs->pt.eflags, flags, SAFE_MASK);
-       if (flags & IF_MASK)
+       set_flags(regs->pt.flags, flags, SAFE_MASK);
+       if (flags & X86_EFLAGS_IF)
                set_IF(regs);
        else
                clear_IF(regs);
 }
 
-static inline unsigned long get_vflags(struct kernel_vm86_regs * regs)
+static inline unsigned long get_vflags(struct kernel_vm86_regs *regs)
 {
-       unsigned long flags = regs->pt.eflags & RETURN_MASK;
+       unsigned long flags = regs->pt.flags & RETURN_MASK;
 
-       if (VEFLAGS & VIF_MASK)
-               flags |= IF_MASK;
-       flags |= IOPL_MASK;
+       if (VEFLAGS & X86_EFLAGS_VIF)
+               flags |= X86_EFLAGS_IF;
+       flags |= X86_EFLAGS_IOPL;
        return flags | (VEFLAGS & current->thread.v86mask);
 }
 
-static inline int is_revectored(int nr, struct revectored_struct * bitmap)
+static inline int is_revectored(int nr, struct revectored_struct *bitmap)
 {
        __asm__ __volatile__("btl %2,%1\n\tsbbl %0,%0"
                :"=r" (nr)
-               :"m" (*bitmap),"r" (nr));
+               :"m" (*bitmap), "r" (nr));
        return nr;
 }
 
@@ -438,7 +441,7 @@ static inline int is_revectored(int nr, struct revectored_struct * bitmap)
                ptr--; \
                if (put_user(__val, base + ptr) < 0) \
                        goto err_label; \
-       } while(0)
+       } while (0)
 
 #define pushw(base, ptr, val, err_label) \
        do { \
@@ -449,7 +452,7 @@ static inline int is_revectored(int nr, struct revectored_struct * bitmap)
                ptr--; \
                if (put_user(val_byte(__val, 0), base + ptr) < 0) \
                        goto err_label; \
-       } while(0)
+       } while (0)
 
 #define pushl(base, ptr, val, err_label) \
        do { \
@@ -466,7 +469,7 @@ static inline int is_revectored(int nr, struct revectored_struct * bitmap)
                ptr--; \
                if (put_user(val_byte(__val, 0), base + ptr) < 0) \
                        goto err_label; \
-       } while(0)
+       } while (0)
 
 #define popb(base, ptr, err_label) \
        ({ \
@@ -513,16 +516,16 @@ static inline int is_revectored(int nr, struct revectored_struct * bitmap)
  * in userspace is always better than an Oops anyway.) [KD]
  */
 static void do_int(struct kernel_vm86_regs *regs, int i,
-    unsigned char __user * ssp, unsigned short sp)
+    unsigned char __user *ssp, unsigned short sp)
 {
        unsigned long __user *intr_ptr;
        unsigned long segoffs;
 
-       if (regs->pt.xcs == BIOSSEG)
+       if (regs->pt.cs == BIOSSEG)
                goto cannot_handle;
        if (is_revectored(i, &KVM86->int_revectored))
                goto cannot_handle;
-       if (i==0x21 && is_revectored(AH(regs),&KVM86->int21_revectored))
+       if (i == 0x21 && is_revectored(AH(regs), &KVM86->int21_revectored))
                goto cannot_handle;
        intr_ptr = (unsigned long __user *) (i << 2);
        if (get_user(segoffs, intr_ptr))
@@ -530,9 +533,9 @@ static void do_int(struct kernel_vm86_regs *regs, int i,
        if ((segoffs >> 16) == BIOSSEG)
                goto cannot_handle;
        pushw(ssp, sp, get_vflags(regs), cannot_handle);
-       pushw(ssp, sp, regs->pt.xcs, cannot_handle);
+       pushw(ssp, sp, regs->pt.cs, cannot_handle);
        pushw(ssp, sp, IP(regs), cannot_handle);
-       regs->pt.xcs = segoffs >> 16;
+       regs->pt.cs = segoffs >> 16;
        SP(regs) -= 6;
        IP(regs) = segoffs & 0xffff;
        clear_TF(regs);
@@ -544,30 +547,23 @@ cannot_handle:
        return_to_32bit(regs, VM86_INTx + (i << 8));
 }
 
-int handle_vm86_trap(struct kernel_vm86_regs * regs, long error_code, int trapno)
+int handle_vm86_trap(struct kernel_vm86_regs *regs, long error_code, int trapno)
 {
        if (VMPI.is_vm86pus) {
-               if ( (trapno==3) || (trapno==1) )
+               if ((trapno == 3) || (trapno == 1))
                        return_to_32bit(regs, VM86_TRAP + (trapno << 8));
-               do_int(regs, trapno, (unsigned char __user *) (regs->pt.xss << 4), SP(regs));
+               do_int(regs, trapno, (unsigned char __user *) (regs->pt.ss << 4), SP(regs));
                return 0;
        }
-       if (trapno !=1)
+       if (trapno != 1)
                return 1; /* we let this handle by the calling routine */
-       if (current->ptrace & PT_PTRACED) {
-               unsigned long flags;
-               spin_lock_irqsave(&current->sighand->siglock, flags);
-               sigdelset(&current->blocked, SIGTRAP);
-               recalc_sigpending();
-               spin_unlock_irqrestore(&current->sighand->siglock, flags);
-       }
-       send_sig(SIGTRAP, current, 1);
        current->thread.trap_no = trapno;
        current->thread.error_code = error_code;
+       force_sig(SIGTRAP, current);
        return 0;
 }
 
-void handle_vm86_fault(struct kernel_vm86_regs * regs, long error_code)
+void handle_vm86_fault(struct kernel_vm86_regs *regs, long error_code)
 {
        unsigned char opcode;
        unsigned char __user *csp;
@@ -577,18 +573,18 @@ void handle_vm86_fault(struct kernel_vm86_regs * regs, long error_code)
 
 #define CHECK_IF_IN_TRAP \
        if (VMPI.vm86dbg_active && VMPI.vm86dbg_TFpendig) \
-               newflags |= TF_MASK
+               newflags |= X86_EFLAGS_TF
 #define VM86_FAULT_RETURN do { \
-       if (VMPI.force_return_for_pic  && (VEFLAGS & (IF_MASK | VIF_MASK))) \
+       if (VMPI.force_return_for_pic  && (VEFLAGS & (X86_EFLAGS_IF | X86_EFLAGS_VIF))) \
                return_to_32bit(regs, VM86_PICRETURN); \
-       if (orig_flags & TF_MASK) \
+       if (orig_flags & X86_EFLAGS_TF) \
                handle_vm86_trap(regs, 0, 1); \
        return; } while (0)
 
-       orig_flags = *(unsigned short *)&regs->pt.eflags;
+       orig_flags = *(unsigned short *)&regs->pt.flags;
 
-       csp = (unsigned char __user *) (regs->pt.xcs << 4);
-       ssp = (unsigned char __user *) (regs->pt.xss << 4);
+       csp = (unsigned char __user *) (regs->pt.cs << 4);
+       ssp = (unsigned char __user *) (regs->pt.ss << 4);
        sp = SP(regs);
        ip = IP(regs);
 
@@ -596,17 +592,17 @@ void handle_vm86_fault(struct kernel_vm86_regs * regs, long error_code)
        pref_done = 0;
        do {
                switch (opcode = popb(csp, ip, simulate_sigsegv)) {
-                       case 0x66:      /* 32-bit data */     data32=1; break;
-                       case 0x67:      /* 32-bit address */  break;
-                       case 0x2e:      /* CS */              break;
-                       case 0x3e:      /* DS */              break;
-                       case 0x26:      /* ES */              break;
-                       case 0x36:      /* SS */              break;
-                       case 0x65:      /* GS */              break;
-                       case 0x64:      /* FS */              break;
-                       case 0xf2:      /* repnz */       break;
-                       case 0xf3:      /* rep */             break;
-                       default: pref_done = 1;
+               case 0x66:      /* 32-bit data */     data32 = 1; break;
+               case 0x67:      /* 32-bit address */  break;
+               case 0x2e:      /* CS */              break;
+               case 0x3e:      /* DS */              break;
+               case 0x26:      /* ES */              break;
+               case 0x36:      /* SS */              break;
+               case 0x65:      /* GS */              break;
+               case 0x64:      /* FS */              break;
+               case 0xf2:      /* repnz */       break;
+               case 0xf3:      /* rep */             break;
+               default: pref_done = 1;
                }
        } while (!pref_done);
 
@@ -629,7 +625,7 @@ void handle_vm86_fault(struct kernel_vm86_regs * regs, long error_code)
                {
                unsigned long newflags;
                if (data32) {
-                       newflags=popl(ssp, sp, simulate_sigsegv);
+                       newflags = popl(ssp, sp, simulate_sigsegv);
                        SP(regs) += 4;
                } else {
                        newflags = popw(ssp, sp, simulate_sigsegv);
@@ -637,20 +633,20 @@ void handle_vm86_fault(struct kernel_vm86_regs * regs, long error_code)
                }
                IP(regs) = ip;
                CHECK_IF_IN_TRAP;
-               if (data32) {
+               if (data32)
                        set_vflags_long(newflags, regs);
-               } else {
+               else
                        set_vflags_short(newflags, regs);
-               }
+
                VM86_FAULT_RETURN;
                }
 
        /* int xx */
        case 0xcd: {
-               int intno=popb(csp, ip, simulate_sigsegv);
+               int intno = popb(csp, ip, simulate_sigsegv);
                IP(regs) = ip;
                if (VMPI.vm86dbg_active) {
-                       if ( (1 << (intno &7)) & VMPI.vm86dbg_intxxtab[intno >> 3] )
+                       if ((1 << (intno & 7)) & VMPI.vm86dbg_intxxtab[intno >> 3])
                                return_to_32bit(regs, VM86_INTx + (intno << 8));
                }
                do_int(regs, intno, ssp, sp);
@@ -664,9 +660,9 @@ void handle_vm86_fault(struct kernel_vm86_regs * regs, long error_code)
                unsigned long newcs;
                unsigned long newflags;
                if (data32) {
-                       newip=popl(ssp, sp, simulate_sigsegv);
-                       newcs=popl(ssp, sp, simulate_sigsegv);
-                       newflags=popl(ssp, sp, simulate_sigsegv);
+                       newip = popl(ssp, sp, simulate_sigsegv);
+                       newcs = popl(ssp, sp, simulate_sigsegv);
+                       newflags = popl(ssp, sp, simulate_sigsegv);
                        SP(regs) += 12;
                } else {
                        newip = popw(ssp, sp, simulate_sigsegv);
@@ -675,7 +671,7 @@ void handle_vm86_fault(struct kernel_vm86_regs * regs, long error_code)
                        SP(regs) += 6;
                }
                IP(regs) = newip;
-               regs->pt.xcs = newcs;
+               regs->pt.cs = newcs;
                CHECK_IF_IN_TRAP;
                if (data32) {
                        set_vflags_long(newflags, regs);
@@ -735,18 +731,18 @@ static struct vm86_irqs {
 static DEFINE_SPINLOCK(irqbits_lock);
 static int irqbits;
 
-#define ALLOWED_SIGS ( 1 /* 0 = don't send a signal */ \
+#define ALLOWED_SIGS (1 /* 0 = don't send a signal */ \
        | (1 << SIGUSR1) | (1 << SIGUSR2) | (1 << SIGIO)  | (1 << SIGURG) \
-       | (1 << SIGUNUSED) )
-       
+       | (1 << SIGUNUSED))
+
 static irqreturn_t irq_handler(int intno, void *dev_id)
 {
        int irq_bit;
        unsigned long flags;
 
-       spin_lock_irqsave(&irqbits_lock, flags);        
+       spin_lock_irqsave(&irqbits_lock, flags);
        irq_bit = 1 << intno;
-       if ((irqbits & irq_bit) || ! vm86_irqs[intno].tsk)
+       if ((irqbits & irq_bit) || !vm86_irqs[intno].tsk)
                goto out;
        irqbits |= irq_bit;
        if (vm86_irqs[intno].sig)
@@ -760,7 +756,7 @@ static irqreturn_t irq_handler(int intno, void *dev_id)
        return IRQ_HANDLED;
 
 out:
-       spin_unlock_irqrestore(&irqbits_lock, flags);   
+       spin_unlock_irqrestore(&irqbits_lock, flags);
        return IRQ_NONE;
 }
 
@@ -771,9 +767,9 @@ static inline void free_vm86_irq(int irqnumber)
        free_irq(irqnumber, NULL);
        vm86_irqs[irqnumber].tsk = NULL;
 
-       spin_lock_irqsave(&irqbits_lock, flags);        
+       spin_lock_irqsave(&irqbits_lock, flags);
        irqbits &= ~(1 << irqnumber);
-       spin_unlock_irqrestore(&irqbits_lock, flags);   
+       spin_unlock_irqrestore(&irqbits_lock, flags);
 }
 
 void release_vm86_irqs(struct task_struct *task)
@@ -789,10 +785,10 @@ static inline int get_and_reset_irq(int irqnumber)
        int bit;
        unsigned long flags;
        int ret = 0;
-       
+
        if (invalid_vm86_irq(irqnumber)) return 0;
        if (vm86_irqs[irqnumber].tsk != current) return 0;
-       spin_lock_irqsave(&irqbits_lock, flags);        
+       spin_lock_irqsave(&irqbits_lock, flags);
        bit = irqbits & (1 << irqnumber);
        irqbits &= ~bit;
        if (bit) {
@@ -800,7 +796,7 @@ static inline int get_and_reset_irq(int irqnumber)
                ret = 1;
        }
 
-       spin_unlock_irqrestore(&irqbits_lock, flags);   
+       spin_unlock_irqrestore(&irqbits_lock, flags);
        return ret;
 }