AMD IOMMU: move invalidation command building to a separate function
[safe/jmp/linux-2.6] / arch / x86 / kernel / microcode_amd.c
index e68e723..c25fdb3 100644 (file)
@@ -47,28 +47,29 @@ MODULE_LICENSE("GPL v2");
 #define UCODE_UCODE_TYPE           0x00000001
 
 struct equiv_cpu_entry {
-       unsigned int installed_cpu;
-       unsigned int fixed_errata_mask;
-       unsigned int fixed_errata_compare;
-       unsigned int equiv_cpu;
-};
+       u32     installed_cpu;
+       u32     fixed_errata_mask;
+       u32     fixed_errata_compare;
+       u16     equiv_cpu;
+       u16     res;
+} __attribute__((packed));
 
 struct microcode_header_amd {
-       unsigned int  data_code;
-       unsigned int  patch_id;
-       unsigned char mc_patch_data_id[2];
-       unsigned char mc_patch_data_len;
-       unsigned char init_flag;
-       unsigned int  mc_patch_data_checksum;
-       unsigned int  nb_dev_id;
-       unsigned int  sb_dev_id;
-       u16 processor_rev_id;
-       unsigned char nb_rev_id;
-       unsigned char sb_rev_id;
-       unsigned char bios_api_rev;
-       unsigned char reserved1[3];
-       unsigned int  match_reg[8];
-};
+       u32     data_code;
+       u32     patch_id;
+       u16     mc_patch_data_id;
+       u8      mc_patch_data_len;
+       u8      init_flag;
+       u32     mc_patch_data_checksum;
+       u32     nb_dev_id;
+       u32     sb_dev_id;
+       u16     processor_rev_id;
+       u8      nb_rev_id;
+       u8      sb_rev_id;
+       u8      bios_api_rev;
+       u8      reserved1[3];
+       u32     match_reg[8];
+} __attribute__((packed));
 
 struct microcode_amd {
        struct microcode_header_amd hdr;
@@ -90,27 +91,21 @@ static int collect_cpu_info_amd(int cpu, struct cpu_signature *csig)
        u32 dummy;
 
        memset(csig, 0, sizeof(*csig));
-
        if (c->x86_vendor != X86_VENDOR_AMD || c->x86 < 0x10) {
-               printk(KERN_ERR "microcode: CPU%d not a capable AMD processor\n",
-                      cpu);
+               printk(KERN_WARNING "microcode: CPU%d: AMD CPU family 0x%x not "
+                      "supported\n", cpu, c->x86);
                return -1;
        }
-
        rdmsr(MSR_AMD64_PATCH_LEVEL, csig->rev, dummy);
-
-       printk(KERN_INFO "microcode: collect_cpu_info_amd : patch_id=0x%x\n",
-               csig->rev);
-
+       printk(KERN_INFO "microcode: CPU%d: patch_level=0x%x\n", cpu, csig->rev);
        return 0;
 }
 
 static int get_matching_microcode(int cpu, void *mc, int rev)
 {
        struct microcode_header_amd *mc_header = mc;
-       struct pci_dev *nb_pci_dev, *sb_pci_dev;
        unsigned int current_cpu_id;
-       unsigned int equiv_cpu_id = 0x00;
+       u16 equiv_cpu_id = 0;
        unsigned int i = 0;
 
        BUG_ON(equiv_cpu_table == NULL);
@@ -118,51 +113,30 @@ static int get_matching_microcode(int cpu, void *mc, int rev)
 
        while (equiv_cpu_table[i].installed_cpu != 0) {
                if (current_cpu_id == equiv_cpu_table[i].installed_cpu) {
-                       equiv_cpu_id = equiv_cpu_table[i].equiv_cpu & 0xffff;
+                       equiv_cpu_id = equiv_cpu_table[i].equiv_cpu;
                        break;
                }
                i++;
        }
 
        if (!equiv_cpu_id) {
-               printk(KERN_ERR "microcode: CPU%d cpu_id "
-                      "not found in equivalent cpu table\n", cpu);
+               printk(KERN_WARNING "microcode: CPU%d: cpu revision "
+                      "not listed in equivalent cpu table\n", cpu);
                return 0;
        }
 
        if (mc_header->processor_rev_id != equiv_cpu_id) {
-               printk(KERN_ERR "microcode: CPU%d patch does not match "
-                      "(processor_rev_id: %x, eqiv_cpu_id: %x)\n",
+               printk(KERN_ERR "microcode: CPU%d: patch mismatch "
+                      "(processor_rev_id: %x, equiv_cpu_id: %x)\n",
                       cpu, mc_header->processor_rev_id, equiv_cpu_id);
                return 0;
        }
 
-       /* ucode may be northbridge specific */
-       if (mc_header->nb_dev_id) {
-               nb_pci_dev = pci_get_device(PCI_VENDOR_ID_AMD,
-                                           (mc_header->nb_dev_id & 0xff),
-                                           NULL);
-               if ((!nb_pci_dev) ||
-                   (mc_header->nb_rev_id != nb_pci_dev->revision)) {
-                       printk(KERN_ERR "microcode: CPU%d NB mismatch\n", cpu);
-                       pci_dev_put(nb_pci_dev);
-                       return 0;
-               }
-               pci_dev_put(nb_pci_dev);
-       }
-
-       /* ucode may be southbridge specific */
-       if (mc_header->sb_dev_id) {
-               sb_pci_dev = pci_get_device(PCI_VENDOR_ID_AMD,
-                                           (mc_header->sb_dev_id & 0xff),
-                                           NULL);
-               if ((!sb_pci_dev) ||
-                   (mc_header->sb_rev_id != sb_pci_dev->revision)) {
-                       printk(KERN_ERR "microcode: CPU%d SB mismatch\n", cpu);
-                       pci_dev_put(sb_pci_dev);
-                       return 0;
-               }
-               pci_dev_put(sb_pci_dev);
+       /* ucode might be chipset specific -- currently we don't support this */
+       if (mc_header->nb_dev_id || mc_header->sb_dev_id) {
+               printk(KERN_ERR "microcode: CPU%d: loading of chipset "
+                      "specific code not yet supported\n", cpu);
+               return 0;
        }
 
        if (mc_header->patch_id <= rev)
@@ -186,22 +160,20 @@ static void apply_microcode_amd(int cpu)
                return;
 
        spin_lock_irqsave(&microcode_update_lock, flags);
-       wrmsrl(MSR_AMD64_PATCH_LOADER, &mc_amd->hdr.data_code);
+       wrmsrl(MSR_AMD64_PATCH_LOADER, (u64)(long)&mc_amd->hdr.data_code);
        /* get patch id after patching */
        rdmsr(MSR_AMD64_PATCH_LEVEL, rev, dummy);
        spin_unlock_irqrestore(&microcode_update_lock, flags);
 
        /* check current patch id and patch's id for match */
        if (rev != mc_amd->hdr.patch_id) {
-               printk(KERN_ERR "microcode: CPU%d update from revision "
-                      "0x%x to 0x%x failed\n", cpu_num,
-                      mc_amd->hdr.patch_id, rev);
+               printk(KERN_ERR "microcode: CPU%d: update failed "
+                      "(for patch_level=0x%x)\n", cpu, mc_amd->hdr.patch_id);
                return;
        }
 
-       printk(KERN_INFO "microcode: CPU%d updated from revision "
-              "0x%x to 0x%x\n",
-              cpu_num, uci->cpu_sig.rev, mc_amd->hdr.patch_id);
+       printk(KERN_INFO "microcode: CPU%d: updated (new patch_level=0x%x)\n",
+              cpu, rev);
 
        uci->cpu_sig.rev = rev;
 }
@@ -223,18 +195,18 @@ static void *get_next_ucode(const u8 *buf, unsigned int size,
                return NULL;
 
        if (section_hdr[0] != UCODE_UCODE_TYPE) {
-               printk(KERN_ERR "microcode: error! "
-                      "Wrong microcode payload type field\n");
+               printk(KERN_ERR "microcode: error: invalid type field in "
+                      "container file section header\n");
                return NULL;
        }
 
        total_size = (unsigned long) (section_hdr[4] + (section_hdr[5] << 8));
 
-       printk(KERN_INFO "microcode: size %u, total_size %u\n",
-               size, total_size);
+       printk(KERN_DEBUG "microcode: size %u, total_size %u\n",
+              size, total_size);
 
        if (total_size > size || total_size > UCODE_MAX_SIZE) {
-               printk(KERN_ERR "microcode: error! Bad data in microcode data file\n");
+               printk(KERN_ERR "microcode: error: size mismatch\n");
                return NULL;
        }
 
@@ -264,14 +236,15 @@ static int install_equiv_cpu_table(const u8 *buf)
        size = buf_pos[2];
 
        if (buf_pos[1] != UCODE_EQUIV_CPU_TABLE_TYPE || !size) {
-               printk(KERN_ERR "microcode: error! "
-                      "Wrong microcode equivalent cpu table\n");
+               printk(KERN_ERR "microcode: error: invalid type field in "
+                      "container file section header\n");
                return 0;
        }
 
        equiv_cpu_table = (struct equiv_cpu_entry *) vmalloc(size);
        if (!equiv_cpu_table) {
-               printk(KERN_ERR "microcode: error, can't allocate memory for equiv CPU table\n");
+               printk(KERN_ERR "microcode: failed to allocate "
+                      "equivalent CPU table\n");
                return 0;
        }
 
@@ -304,7 +277,8 @@ static int generic_load_microcode(int cpu, const u8 *data, size_t size)
 
        offset = install_equiv_cpu_table(ucode_ptr);
        if (!offset) {
-               printk(KERN_ERR "microcode: installing equivalent cpu table failed\n");
+               printk(KERN_ERR "microcode: failed to create "
+                      "equivalent cpu table\n");
                return -EINVAL;
        }
 
@@ -360,8 +334,7 @@ static int request_microcode_fw(int cpu, struct device *device)
 
        ret = request_firmware(&firmware, fw_name, device);
        if (ret) {
-               printk(KERN_ERR "microcode: ucode data file %s load failed\n",
-                      fw_name);
+               printk(KERN_ERR "microcode: failed to load file %s\n", fw_name);
                return ret;
        }
 
@@ -374,8 +347,8 @@ static int request_microcode_fw(int cpu, struct device *device)
 
 static int request_microcode_user(int cpu, const void __user *buf, size_t size)
 {
-       printk(KERN_WARNING "microcode: AMD microcode update via "
-              "/dev/cpu/microcode is not supported\n");
+       printk(KERN_INFO "microcode: AMD microcode update via "
+              "/dev/cpu/microcode not supported\n");
        return -1;
 }
 
@@ -399,3 +372,4 @@ struct microcode_ops * __init init_amd_microcode(void)
 {
        return &microcode_amd_ops;
 }
+