mqueue: apply mathematics distributivity on mq_bytes calculation

[safe/jmp/linux-2.6] / Documentation / SubmitChecklist

diff --git a/Documentation/SubmitChecklist b/Documentation/SubmitChecklist
index 3af3e65..1053a56 100644 (file)
--- a/Documentation/SubmitChecklist
+++ b/Documentation/SubmitChecklist
@@ -1,4 +1,4 @@
-Linux Kernel patch sumbittal checklist
+Linux Kernel patch submission checklist

 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
 Here are some basic things that developers should do if they want to see their
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
 Here are some basic things that developers should do if they want to see their


@@ -9,19 +9,22 @@ Documentation/SubmittingPatches and elsewhere regarding submitting Linux
 kernel patches.
 
 
 kernel patches.
 
 

-

 1: Builds cleanly with applicable or modified CONFIG options =y, =m, and
    =n.  No gcc warnings/errors, no linker warnings/errors.
 
 2: Passes allnoconfig, allmodconfig
 
 3: Builds on multiple CPU architectures by using local cross-compile tools
 1: Builds cleanly with applicable or modified CONFIG options =y, =m, and
    =n.  No gcc warnings/errors, no linker warnings/errors.
 
 2: Passes allnoconfig, allmodconfig
 
 3: Builds on multiple CPU architectures by using local cross-compile tools

-   or something like PLM at OSDL.
+   or some other build farm.

 
 4: ppc64 is a good architecture for cross-compilation checking because it
    tends to use `unsigned long' for 64-bit quantities.
 
 
 4: ppc64 is a good architecture for cross-compilation checking because it
    tends to use `unsigned long' for 64-bit quantities.
 

-5: Matches kernel coding style(!)
+5: Check your patch for general style as detailed in
+   Documentation/CodingStyle.  Check for trivial violations with the
+   patch style checker prior to submission (scripts/checkpatch.pl).
+   You should be able to justify all violations that remain in
+   your patch.

 
 6: Any new or modified CONFIG options don't muck up the config menu.
 
 
 6: Any new or modified CONFIG options don't muck up the config menu.
 


@@ -51,7 +54,7 @@ kernel patches.
     CONFIG_PREEMPT.
 
 14: If the patch affects IO/Disk, etc: has been tested with and without
     CONFIG_PREEMPT.
 
 14: If the patch affects IO/Disk, etc: has been tested with and without

-    CONFIG_LBD.
+    CONFIG_LBDAF.

 
 15: All codepaths have been exercised with all lockdep features enabled.
 
 
 15: All codepaths have been exercised with all lockdep features enabled.
 


@@ -64,11 +67,13 @@ kernel patches.
 
 19: All new userspace interfaces are documented in Documentation/ABI/.
     See Documentation/ABI/README for more information.
 
 19: All new userspace interfaces are documented in Documentation/ABI/.
     See Documentation/ABI/README for more information.

+    Patches that change userspace interfaces should be CCed to
+    linux-api@vger.kernel.org.

 
 20: Check that it all passes `make headers_check'.
 
 21: Has been checked with injection of at least slab and page-allocation
 
 20: Check that it all passes `make headers_check'.
 
 21: Has been checked with injection of at least slab and page-allocation

-    fauilures.  See Documentation/fault-injection/.
+    failures.  See Documentation/fault-injection/.

 
     If the new code is substantial, addition of subsystem-specific fault
     injection might be appropriate.
 
     If the new code is substantial, addition of subsystem-specific fault
     injection might be appropriate.


@@ -81,6 +86,8 @@ kernel patches.
     that it still works with all of the other queued patches and various
     changes in the VM, VFS, and other subsystems.
 
     that it still works with all of the other queued patches and various
     changes in the VM, VFS, and other subsystems.
 

-24: Avoid whitespace damage such as indenting with spaces or whitespace
-    at the end of lines.  You can test this by feeding the patch to
-    "git apply --check --whitespace=error-all"
+24: All memory barriers {e.g., barrier(), rmb(), wmb()} need a comment in the
+    source code that explains the logic of what they are doing and why.
+
+25: If any ioctl's are added by the patch, then also update
+    Documentation/ioctl/ioctl-number.txt.