2 # (c) 2001, Dave Jones. <davej@codemonkey.org.uk> (the file handling bit)
3 # (c) 2005, Joel Schopp <jschopp@austin.ibm.com> (the ugly bit)
4 # (c) 2007, Andy Whitcroft <apw@uk.ibm.com> (new conditions, test suite, etc)
5 # Licensed under the terms of the GNU GPL License version 2
14 use Getopt::Long qw(:config no_auto_abbrev);
31 'q|quiet+' => \$quiet,
33 'signoff!' => \$chk_signoff,
34 'patch!' => \$chk_patch,
38 'subjective!' => \$check,
41 'summary!' => \$summary,
42 'mailback!' => \$mailback,
43 'summary-file!' => \$summary_file,
46 'test-only=s' => \$tst_only,
52 print "usage: $P [options] patchfile\n";
53 print "version: $V\n";
54 print "options: -q => quiet\n";
55 print " --no-tree => run without a kernel tree\n";
56 print " --terse => one line per report\n";
57 print " --emacs => emacs compile window format\n";
58 print " --file => check a source file\n";
59 print " --strict => enable more subjective tests\n";
60 print " --root => path to the kernel tree root\n";
61 print " --no-summary => suppress the per-file summary\n";
62 print " --summary-file => include the filename in summary\n";
70 for my $key (keys %debug) {
71 eval "\${dbg_$key} = '$debug{$key}';"
81 if (!top_of_kernel_tree($root)) {
82 die "$P: $root: --root does not point at a valid tree\n";
85 if (top_of_kernel_tree('.')) {
87 } elsif ($0 =~ m@(.*)/scripts/[^/]*$@ &&
88 top_of_kernel_tree($1)) {
94 print "Must be run from the top-level dir. of a kernel tree\n";
99 my $emitted_corrupt = 0;
101 our $Ident = qr{[A-Za-z_][A-Za-z\d_]*};
102 our $Storage = qr{extern|static|asmlinkage};
116 __(?:mem|cpu|dev|)(?:initdata|init)|
117 ____cacheline_aligned|
118 ____cacheline_aligned_in_smp|
119 ____cacheline_internodealigned_in_smp
122 our $Inline = qr{inline|__always_inline|noinline};
123 our $Member = qr{->$Ident|\.$Ident|\[[^]]*\]};
124 our $Lval = qr{$Ident(?:$Member)*};
126 our $Constant = qr{(?:[0-9]+|0x[0-9a-fA-F]+)[UL]*};
127 our $Assignment = qr{(?:\*\=|/=|%=|\+=|-=|<<=|>>=|&=|\^=|\|=|=)};
131 &&|\|\||,|\^|\+\+|--|&|\||\+|-|\*|\/|%
139 [\x09\x0A\x0D\x20-\x7E] # ASCII
140 | [\xC2-\xDF][\x80-\xBF] # non-overlong 2-byte
141 | \xE0[\xA0-\xBF][\x80-\xBF] # excluding overlongs
142 | [\xE1-\xEC\xEE\xEF][\x80-\xBF]{2} # straight 3-byte
143 | \xED[\x80-\x9F][\x80-\xBF] # excluding surrogates
144 | \xF0[\x90-\xBF][\x80-\xBF]{2} # planes 1-3
145 | [\xF1-\xF3][\x80-\xBF]{3} # planes 4-15
146 | \xF4[\x80-\x8F][\x80-\xBF]{2} # plane 16
151 qr{(?:unsigned\s+)?char},
152 qr{(?:unsigned\s+)?short},
153 qr{(?:unsigned\s+)?int},
154 qr{(?:unsigned\s+)?long},
155 qr{(?:unsigned\s+)?long\s+int},
156 qr{(?:unsigned\s+)?long\s+long},
157 qr{(?:unsigned\s+)?long\s+long\s+int},
162 qr{(?:__)?(?:u|s|be|le)(?:8|16|32|64)},
167 qr{${Ident}_handler},
168 qr{${Ident}_handler_fn},
170 our @modifierList = (
175 my $mods = "(?x: \n" . join("|\n ", @modifierList) . "\n)";
176 my $all = "(?x: \n" . join("|\n ", @typeList) . "\n)";
177 $Modifier = qr{(?:$Attribute|$Sparse|$mods)};
179 (?:$Modifier\s+|const\s+)*
181 (?:typeof|__typeof__)\s*\(\s*\**\s*$Ident\s*\)|
184 (?:\s+$Modifier|\s+const)*
188 (?:\s*\*+\s*const|\s*\*+|(?:\s*\[\s*\])+)?
189 (?:\s+$Inline|\s+$Modifier)*
191 $Declare = qr{(?:$Storage\s+)?$Type};
195 $chk_signoff = 0 if ($file);
197 my @dep_includes = ();
198 my @dep_functions = ();
199 my $removal = "Documentation/feature-removal-schedule.txt";
200 if ($tree && -f "$root/$removal") {
201 open(REMOVE, "<$root/$removal") ||
202 die "$P: $removal: open failed - $!\n";
204 if (/^Check:\s+(.*\S)/) {
205 for my $entry (split(/[, ]+/, $1)) {
206 if ($entry =~ m@include/(.*)@) {
207 push(@dep_includes, $1);
209 } elsif ($entry !~ m@/@) {
210 push(@dep_functions, $entry);
220 for my $filename (@ARGV) {
222 open(FILE, "diff -u /dev/null $filename|") ||
223 die "$P: $filename: diff failed - $!\n";
225 open(FILE, "<$filename") ||
226 die "$P: $filename: open failed - $!\n";
228 if ($filename eq '-') {
229 $vname = 'Your patch';
238 if (!process($filename)) {
247 sub top_of_kernel_tree {
251 "COPYING", "CREDITS", "Kbuild", "MAINTAINERS", "Makefile",
252 "README", "Documentation", "arch", "include", "drivers",
253 "fs", "init", "ipc", "kernel", "lib", "scripts",
256 foreach my $check (@tree_check) {
257 if (! -e $root . '/' . $check) {
269 for my $c (split(//, $str)) {
273 for (; ($n % 8) != 0; $n++) {
285 (my $res = shift) =~ tr/\t/ /c;
292 # Drop the diff line leader and expand tabs
294 $line = expand_tabs($line);
296 # Pick the indent from the front of the line.
297 my ($white) = ($line =~ /^(\s*)/);
299 return (length($line), length($white));
302 my $sanitise_quote = '';
304 sub sanitise_line_reset {
305 my ($in_comment) = @_;
308 $sanitise_quote = '*/';
310 $sanitise_quote = '';
323 # Always copy over the diff marker.
324 $res = substr($line, 0, 1);
326 for ($off = 1; $off < length($line); $off++) {
327 $c = substr($line, $off, 1);
329 # Comments we are wacking completly including the begin
330 # and end, all to $;.
331 if ($sanitise_quote eq '' && substr($line, $off, 2) eq '/*') {
332 $sanitise_quote = '*/';
334 substr($res, $off, 2, "$;$;");
338 if ($sanitise_quote eq '*/' && substr($line, $off, 2) eq '*/') {
339 $sanitise_quote = '';
340 substr($res, $off, 2, "$;$;");
345 # A \ in a string means ignore the next character.
346 if (($sanitise_quote eq "'" || $sanitise_quote eq '"') &&
348 substr($res, $off, 2, 'XX');
353 if ($c eq "'" || $c eq '"') {
354 if ($sanitise_quote eq '') {
355 $sanitise_quote = $c;
357 substr($res, $off, 1, $c);
359 } elsif ($sanitise_quote eq $c) {
360 $sanitise_quote = '';
364 #print "SQ:$sanitise_quote\n";
365 if ($off != 0 && $sanitise_quote eq '*/' && $c ne "\t") {
366 substr($res, $off, 1, $;);
367 } elsif ($off != 0 && $sanitise_quote && $c ne "\t") {
368 substr($res, $off, 1, 'X');
370 substr($res, $off, 1, $c);
374 # The pathname on a #include may be surrounded by '<' and '>'.
375 if ($res =~ /^.\s*\#\s*include\s+\<(.*)\>/) {
376 my $clean = 'X' x length($1);
377 $res =~ s@\<.*\>@<$clean>@;
379 # The whole of a #error is a string.
380 } elsif ($res =~ /^.\s*\#\s*(?:error|warning)\s+(.*)\b/) {
381 my $clean = 'X' x length($1);
382 $res =~ s@(\#\s*(?:error|warning)\s+).*@$1$clean@;
388 sub ctx_statement_block {
389 my ($linenr, $remain, $off) = @_;
390 my $line = $linenr - 1;
406 #warn "CSB: blk<$blk> remain<$remain>\n";
407 # If we are about to drop off the end, pull in more
410 for (; $remain > 0; $line++) {
411 last if (!defined $lines[$line]);
412 next if ($lines[$line] =~ /^-/);
415 $blk .= $lines[$line] . "\n";
420 # Bail if there is no further context.
421 #warn "CSB: blk<$blk> off<$off> len<$len>\n";
427 $c = substr($blk, $off, 1);
428 $remainder = substr($blk, $off);
430 #warn "CSB: c<$c> type<$type> level<$level> remainder<$remainder> coff_set<$coff_set>\n";
431 # Statement ends at the ';' or a close '}' at the
433 if ($level == 0 && $c eq ';') {
437 # An else is really a conditional as long as its not else if
438 if ($level == 0 && $coff_set == 0 &&
439 (!defined($p) || $p =~ /(?:\s|\}|\+)/) &&
440 $remainder =~ /^(else)(?:\s|{)/ &&
441 $remainder !~ /^else\s+if\b/) {
442 $coff = $off + length($1) - 1;
444 #warn "CSB: mark coff<$coff> soff<$soff> 1<$1>\n";
445 #warn "[" . substr($blk, $soff, $coff - $soff + 1) . "]\n";
448 if (($type eq '' || $type eq '(') && $c eq '(') {
452 if ($type eq '(' && $c eq ')') {
454 $type = ($level != 0)? '(' : '';
456 if ($level == 0 && $coff < $soff) {
459 #warn "CSB: mark coff<$coff>\n";
462 if (($type eq '' || $type eq '{') && $c eq '{') {
466 if ($type eq '{' && $c eq '}') {
468 $type = ($level != 0)? '{' : '';
476 # We are truly at the end, so shuffle to the next line.
483 my $statement = substr($blk, $soff, $off - $soff + 1);
484 my $condition = substr($blk, $soff, $coff - $soff + 1);
486 #warn "STATEMENT<$statement>\n";
487 #warn "CONDITION<$condition>\n";
489 #print "coff<$coff> soff<$off> loff<$loff>\n";
491 return ($statement, $condition,
492 $line, $remain + 1, $off - $loff + 1, $level);
495 sub statement_lines {
498 # Strip the diff line prefixes and rip blank lines at start and end.
499 $stmt =~ s/(^|\n)./$1/g;
503 my @stmt_lines = ($stmt =~ /\n/g);
505 return $#stmt_lines + 2;
508 sub statement_rawlines {
511 my @stmt_lines = ($stmt =~ /\n/g);
513 return $#stmt_lines + 2;
516 sub statement_block_size {
519 $stmt =~ s/(^|\n)./$1/g;
525 my @stmt_lines = ($stmt =~ /\n/g);
526 my @stmt_statements = ($stmt =~ /;/g);
528 my $stmt_lines = $#stmt_lines + 2;
529 my $stmt_statements = $#stmt_statements + 1;
531 if ($stmt_lines > $stmt_statements) {
534 return $stmt_statements;
538 sub ctx_statement_full {
539 my ($linenr, $remain, $off) = @_;
540 my ($statement, $condition, $level);
544 # Grab the first conditional/block pair.
545 ($statement, $condition, $linenr, $remain, $off, $level) =
546 ctx_statement_block($linenr, $remain, $off);
547 #print "F: c<$condition> s<$statement> remain<$remain>\n";
548 push(@chunks, [ $condition, $statement ]);
549 if (!($remain > 0 && $condition =~ /^\s*(?:\n[+-])?\s*(?:if|else|do)\b/s)) {
550 return ($level, $linenr, @chunks);
553 # Pull in the following conditional/block pairs and see if they
554 # could continue the statement.
556 ($statement, $condition, $linenr, $remain, $off, $level) =
557 ctx_statement_block($linenr, $remain, $off);
558 #print "C: c<$condition> s<$statement> remain<$remain>\n";
559 last if (!($remain > 0 && $condition =~ /^(?:\s*\n[+-])*\s*(?:else|do)\b/s));
561 push(@chunks, [ $condition, $statement ]);
564 return ($level, $linenr, @chunks);
568 my ($linenr, $remain, $outer, $open, $close, $off) = @_;
570 my $start = $linenr - 1;
577 for ($line = $start; $remain > 0; $line++) {
578 next if ($rawlines[$line] =~ /^-/);
581 $blk .= $rawlines[$line];
582 foreach my $c (split(//, $rawlines[$line])) {
583 ##print "C<$c>L<$level><$open$close>O<$off>\n";
589 if ($c eq $close && $level > 0) {
591 last if ($level == 0);
592 } elsif ($c eq $open) {
597 if (!$outer || $level <= 1) {
598 push(@res, $rawlines[$line]);
601 last if ($level == 0);
604 return ($level, @res);
606 sub ctx_block_outer {
607 my ($linenr, $remain) = @_;
609 my ($level, @r) = ctx_block_get($linenr, $remain, 1, '{', '}', 0);
613 my ($linenr, $remain) = @_;
615 my ($level, @r) = ctx_block_get($linenr, $remain, 0, '{', '}', 0);
619 my ($linenr, $remain, $off) = @_;
621 my ($level, @r) = ctx_block_get($linenr, $remain, 0, '(', ')', $off);
624 sub ctx_block_level {
625 my ($linenr, $remain) = @_;
627 return ctx_block_get($linenr, $remain, 0, '{', '}', 0);
629 sub ctx_statement_level {
630 my ($linenr, $remain, $off) = @_;
632 return ctx_block_get($linenr, $remain, 0, '(', ')', $off);
635 sub ctx_locate_comment {
636 my ($first_line, $end_line) = @_;
638 # Catch a comment on the end of the line itself.
639 my ($current_comment) = ($rawlines[$end_line - 1] =~ m@.*(/\*.*\*/)\s*(?:\\\s*)?$@);
640 return $current_comment if (defined $current_comment);
642 # Look through the context and try and figure out if there is a
645 $current_comment = '';
646 for (my $linenr = $first_line; $linenr < $end_line; $linenr++) {
647 my $line = $rawlines[$linenr - 1];
649 if ($linenr == $first_line and $line =~ m@^.\s*\*@) {
652 if ($line =~ m@/\*@) {
655 if (!$in_comment && $current_comment ne '') {
656 $current_comment = '';
658 $current_comment .= $line . "\n" if ($in_comment);
659 if ($line =~ m@\*/@) {
664 chomp($current_comment);
665 return($current_comment);
667 sub ctx_has_comment {
668 my ($first_line, $end_line) = @_;
669 my $cmt = ctx_locate_comment($first_line, $end_line);
671 ##print "LINE: $rawlines[$end_line - 1 ]\n";
672 ##print "CMMT: $cmt\n";
678 my ($linenr, $cnt) = @_;
680 my $offset = $linenr - 1;
685 $line = $rawlines[$offset++];
686 next if (defined($line) && $line =~ /^-/);
698 while ($vet =~ /([^[:cntrl:]]*)([[:cntrl:]]|$)/g) {
701 $coded = sprintf("^%c", unpack('C', $2) + 64);
710 my $av_preprocessor = 0;
716 $av_preprocessor = 0;
718 @av_paren_type = ('E');
719 $av_pend_colon = 'O';
722 sub annotate_values {
723 my ($stream, $type) = @_;
726 my $var = '_' x length($stream);
729 print "$stream\n" if ($dbg_values > 1);
731 while (length($cur)) {
732 @av_paren_type = ('E') if ($#av_paren_type < 0);
733 print " <" . join('', @av_paren_type) .
734 "> <$type> <$av_pending>" if ($dbg_values > 1);
735 if ($cur =~ /^(\s+)/o) {
736 print "WS($1)\n" if ($dbg_values > 1);
737 if ($1 =~ /\n/ && $av_preprocessor) {
738 $type = pop(@av_paren_type);
739 $av_preprocessor = 0;
742 } elsif ($cur =~ /^($Type)\s*(?:$Ident|,|\)|\()/) {
743 print "DECLARE($1)\n" if ($dbg_values > 1);
746 } elsif ($cur =~ /^($Modifier)\s*/) {
747 print "MODIFIER($1)\n" if ($dbg_values > 1);
750 } elsif ($cur =~ /^(\#\s*define\s*$Ident)(\(?)/o) {
751 print "DEFINE($1,$2)\n" if ($dbg_values > 1);
752 $av_preprocessor = 1;
753 push(@av_paren_type, $type);
759 } elsif ($cur =~ /^(\#\s*(?:undef\s*$Ident|include\b))/o) {
760 print "UNDEF($1)\n" if ($dbg_values > 1);
761 $av_preprocessor = 1;
762 push(@av_paren_type, $type);
764 } elsif ($cur =~ /^(\#\s*(?:ifdef|ifndef|if))/o) {
765 print "PRE_START($1)\n" if ($dbg_values > 1);
766 $av_preprocessor = 1;
768 push(@av_paren_type, $type);
769 push(@av_paren_type, $type);
772 } elsif ($cur =~ /^(\#\s*(?:else|elif))/o) {
773 print "PRE_RESTART($1)\n" if ($dbg_values > 1);
774 $av_preprocessor = 1;
776 push(@av_paren_type, $av_paren_type[$#av_paren_type]);
780 } elsif ($cur =~ /^(\#\s*(?:endif))/o) {
781 print "PRE_END($1)\n" if ($dbg_values > 1);
783 $av_preprocessor = 1;
785 # Assume all arms of the conditional end as this
786 # one does, and continue as if the #endif was not here.
788 push(@av_paren_type, $type);
791 } elsif ($cur =~ /^(\\\n)/o) {
792 print "PRECONT($1)\n" if ($dbg_values > 1);
794 } elsif ($cur =~ /^(__attribute__)\s*\(?/o) {
795 print "ATTR($1)\n" if ($dbg_values > 1);
799 } elsif ($cur =~ /^(sizeof)\s*(\()?/o) {
800 print "SIZEOF($1)\n" if ($dbg_values > 1);
806 } elsif ($cur =~ /^(if|while|for)\b/o) {
807 print "COND($1)\n" if ($dbg_values > 1);
811 } elsif ($cur =~/^(case)/o) {
812 print "CASE($1)\n" if ($dbg_values > 1);
813 $av_pend_colon = 'C';
816 } elsif ($cur =~/^(return|else|goto|typeof|__typeof__)\b/o) {
817 print "KEYWORD($1)\n" if ($dbg_values > 1);
820 } elsif ($cur =~ /^(\()/o) {
821 print "PAREN('$1')\n" if ($dbg_values > 1);
822 push(@av_paren_type, $av_pending);
826 } elsif ($cur =~ /^(\))/o) {
827 my $new_type = pop(@av_paren_type);
828 if ($new_type ne '_') {
830 print "PAREN('$1') -> $type\n"
831 if ($dbg_values > 1);
833 print "PAREN('$1')\n" if ($dbg_values > 1);
836 } elsif ($cur =~ /^($Ident)\s*\(/o) {
837 print "FUNC($1)\n" if ($dbg_values > 1);
841 } elsif ($cur =~ /^($Ident\s*):/) {
843 $av_pend_colon = 'L';
844 } elsif ($type eq 'T') {
845 $av_pend_colon = 'B';
847 print "IDENT_COLON($1,$type>$av_pend_colon)\n" if ($dbg_values > 1);
850 } elsif ($cur =~ /^($Ident|$Constant)/o) {
851 print "IDENT($1)\n" if ($dbg_values > 1);
854 } elsif ($cur =~ /^($Assignment)/o) {
855 print "ASSIGN($1)\n" if ($dbg_values > 1);
858 } elsif ($cur =~/^(;|{|})/) {
859 print "END($1)\n" if ($dbg_values > 1);
861 $av_pend_colon = 'O';
863 } elsif ($cur =~ /^(\?)/o) {
864 print "QUESTION($1)\n" if ($dbg_values > 1);
867 } elsif ($cur =~ /^(:)/o) {
868 print "COLON($1,$av_pend_colon)\n" if ($dbg_values > 1);
870 substr($var, length($res), 1, $av_pend_colon);
871 if ($av_pend_colon eq 'C' || $av_pend_colon eq 'L') {
876 $av_pend_colon = 'O';
878 } elsif ($cur =~ /^(;|\[)/o) {
879 print "CLOSE($1)\n" if ($dbg_values > 1);
882 } elsif ($cur =~ /^(-(?![->])|\+(?!\+)|\*|\&\&|\&)/o) {
885 print "OPV($1)\n" if ($dbg_values > 1);
892 substr($var, length($res), 1, $variant);
895 } elsif ($cur =~ /^($Operators)/o) {
896 print "OP($1)\n" if ($dbg_values > 1);
897 if ($1 ne '++' && $1 ne '--') {
901 } elsif ($cur =~ /(^.)/o) {
902 print "C($1)\n" if ($dbg_values > 1);
905 $cur = substr($cur, length($1));
906 $res .= $type x length($1);
914 my ($possible, $line) = @_;
916 print "CHECK<$possible> ($line)\n" if ($dbg_possible > 2);
917 if ($possible !~ /(?:
930 ^(?:typedef|struct|enum)\b
932 # Check for modifiers.
933 $possible =~ s/\s*$Storage\s*//g;
934 $possible =~ s/\s*$Sparse\s*//g;
935 if ($possible =~ /^\s*$/) {
937 } elsif ($possible =~ /\s/) {
938 $possible =~ s/\s*$Type\s*//g;
939 for my $modifier (split(' ', $possible)) {
940 warn "MODIFIER: $modifier ($possible) ($line)\n" if ($dbg_possible);
941 push(@modifierList, $modifier);
945 warn "POSSIBLE: $possible ($line)\n" if ($dbg_possible);
946 push(@typeList, $possible);
950 warn "NOTPOSS: $possible ($line)\n" if ($dbg_possible > 1);
957 if (defined $tst_only && $_[0] !~ /\Q$tst_only\E/) {
960 my $line = $prefix . $_[0];
962 $line = (split('\n', $line))[0] . "\n" if ($terse);
964 push(our @report, $line);
972 if (report("ERROR: $_[0]\n")) {
978 if (report("WARNING: $_[0]\n")) {
984 if ($check && report("CHECK: $_[0]\n")) {
990 sub check_absolute_file {
991 my ($absolute, $herecurr) = @_;
992 my $file = $absolute;
994 ##print "absolute<$absolute>\n";
996 # See if any suffix of this path is a path within the tree.
997 while ($file =~ s@^[^/]*/@@) {
998 if (-f "$root/$file") {
999 ##print "file<$file>\n";
1007 # It is, so see if the prefix is acceptable.
1008 my $prefix = $absolute;
1009 substr($prefix, -length($file)) = '';
1011 ##print "prefix<$prefix>\n";
1012 if ($prefix ne ".../") {
1013 WARN("use relative pathname instead of absolute in changelog text\n" . $herecurr);
1018 my $filename = shift;
1024 my $stashrawline="";
1041 # Trace the real file/line as we go.
1047 my $comment_edge = 0;
1050 my $prev_values = 'E';
1053 my %suppress_ifbraces;
1055 # Pre-scan the patch sanitizing the lines.
1056 # Pre-scan the patch looking for any __setup documentation.
1058 my @setup_docs = ();
1061 sanitise_line_reset();
1063 foreach my $rawline (@rawlines) {
1067 if ($rawline=~/^\+\+\+\s+(\S+)/) {
1069 if ($1 =~ m@Documentation/kernel-parameters.txt$@) {
1074 if ($rawline=~/^\@\@ -\d+(?:,\d+)? \+(\d+)(,(\d+))? \@\@/) {
1083 # Guestimate if this is a continuing comment. Run
1084 # the context looking for a comment "edge". If this
1085 # edge is a close comment then we must be in a comment
1089 for (my $ln = $linenr + 1; $cnt > 0; $ln++) {
1090 next if (defined $rawlines[$ln - 1] &&
1091 $rawlines[$ln - 1] =~ /^-/);
1093 #print "RAW<$rawlines[$ln - 1]>\n";
1094 ($edge) = (defined $rawlines[$ln - 1] &&
1095 $rawlines[$ln - 1] =~ m@(/\*|\*/)@);
1096 last if (defined $edge);
1098 if (defined $edge && $edge eq '*/') {
1102 # Guestimate if this is a continuing comment. If this
1103 # is the start of a diff block and this line starts
1104 # ' *' then it is very likely a comment.
1105 if (!defined $edge &&
1106 $rawlines[$linenr] =~ m@^.\s* \*(?:\s|$)@)
1111 ##print "COMMENT:$in_comment edge<$edge> $rawline\n";
1112 sanitise_line_reset($in_comment);
1114 } elsif ($realcnt && $rawline =~ /^(?:\+| |$)/) {
1115 # Standardise the strings and chars within the input to
1116 # simplify matching -- only bother with positive lines.
1117 $line = sanitise_line($rawline);
1119 push(@lines, $line);
1122 $realcnt-- if ($line =~ /^(?:\+| |$)/);
1127 #print "==>$rawline\n";
1128 #print "-->$line\n";
1130 if ($setup_docs && $line =~ /^\+/) {
1131 push(@setup_docs, $line);
1139 foreach my $line (@lines) {
1142 my $rawline = $rawlines[$linenr - 1];
1143 my $hunk_line = ($realcnt != 0);
1145 #extract the line range in the file after the patch is applied
1146 if ($line=~/^\@\@ -\d+(?:,\d+)? \+(\d+)(,(\d+))? \@\@/) {
1148 $first_line = $linenr + 1;
1158 %suppress_ifbraces = ();
1161 # track the line number as we move through the hunk, note that
1162 # new versions of GNU diff omit the leading space on completely
1163 # blank context lines so we need to count that too.
1164 } elsif ($line =~ /^( |\+|$)/) {
1166 $realcnt-- if ($realcnt != 0);
1168 # Measure the line length and indent.
1169 ($length, $indent) = line_stats($rawline);
1171 # Track the previous line.
1172 ($prevline, $stashline) = ($stashline, $line);
1173 ($previndent, $stashindent) = ($stashindent, $indent);
1174 ($prevrawline, $stashrawline) = ($stashrawline, $rawline);
1176 #warn "line<$line>\n";
1178 } elsif ($realcnt == 1) {
1182 #make up the handle for any error we report on this line
1183 $prefix = "$filename:$realline: " if ($emacs && $file);
1184 $prefix = "$filename:$linenr: " if ($emacs && !$file);
1186 $here = "#$linenr: " if (!$file);
1187 $here = "#$realline: " if ($file);
1189 # extract the filename as it passes
1190 if ($line=~/^\+\+\+\s+(\S+)/) {
1192 $realfile =~ s@^[^/]*/@@;
1194 if ($realfile =~ m@^include/asm/@) {
1195 ERROR("do not modify files in include/asm, change architecture specific files in include/asm-<architecture>\n" . "$here$rawline\n");
1200 $here .= "FILE: $realfile:$realline:" if ($realcnt != 0);
1202 my $hereline = "$here\n$rawline\n";
1203 my $herecurr = "$here\n$rawline\n";
1204 my $hereprev = "$here\n$prevrawline\n$rawline\n";
1206 $cnt_lines++ if ($realcnt != 0);
1208 #check the patch for a signoff:
1209 if ($line =~ /^\s*signed-off-by:/i) {
1210 # This is a signoff, if ugly, so do not double report.
1212 if (!($line =~ /^\s*Signed-off-by:/)) {
1213 WARN("Signed-off-by: is the preferred form\n" .
1216 if ($line =~ /^\s*signed-off-by:\S/i) {
1217 WARN("space required after Signed-off-by:\n" .
1222 # Check for wrappage within a valid hunk of the file
1223 if ($realcnt != 0 && $line !~ m{^(?:\+|-| |\\ No newline|$)}) {
1224 ERROR("patch seems to be corrupt (line wrapped?)\n" .
1225 $herecurr) if (!$emitted_corrupt++);
1228 # Check for absolute kernel paths.
1230 while ($line =~ m{(?:^|\s)(/\S*)}g) {
1233 if ($file =~ m{^(.*?)(?::\d+)+:?$} &&
1234 check_absolute_file($1, $herecurr)) {
1237 check_absolute_file($file, $herecurr);
1242 # UTF-8 regex found at http://www.w3.org/International/questions/qa-forms-utf-8.en.php
1243 if (($realfile =~ /^$/ || $line =~ /^\+/) &&
1244 $rawline !~ m/^$UTF8*$/) {
1245 my ($utf8_prefix) = ($rawline =~ /^($UTF8*)/);
1247 my $blank = copy_spacing($rawline);
1248 my $ptr = substr($blank, 0, length($utf8_prefix)) . "^";
1249 my $hereptr = "$hereline$ptr\n";
1251 ERROR("Invalid UTF-8, patch and commit message should be encoded in UTF-8\n" . $hereptr);
1254 # ignore non-hunk lines and lines being removed
1255 next if (!$hunk_line || $line =~ /^-/);
1257 #trailing whitespace
1258 if ($line =~ /^\+.*\015/) {
1259 my $herevet = "$here\n" . cat_vet($rawline) . "\n";
1260 ERROR("DOS line endings\n" . $herevet);
1262 } elsif ($rawline =~ /^\+.*\S\s+$/ || $rawline =~ /^\+\s+$/) {
1263 my $herevet = "$here\n" . cat_vet($rawline) . "\n";
1264 ERROR("trailing whitespace\n" . $herevet);
1267 # check we are in a valid source file if not then ignore this hunk
1268 next if ($realfile !~ /\.(h|c|s|S|pl|sh)$/);
1271 if ($line =~ /^\+/ && $prevrawline !~ /\/\*\*/ &&
1272 $rawline !~ /^.\s*\*\s*\@$Ident\s/ &&
1273 $line !~ /^\+\s*printk\s*\(\s*(?:KERN_\S+\s*)?"[X\t]*"\s*(?:,|\)\s*;)\s*$/ &&
1276 WARN("line over 80 characters\n" . $herecurr);
1279 # check for adding lines without a newline.
1280 if ($line =~ /^\+/ && defined $lines[$linenr] && $lines[$linenr] =~ /^\\ No newline at end of file/) {
1281 WARN("adding a line without newline at end of file\n" . $herecurr);
1284 # check we are in a valid source file C or perl if not then ignore this hunk
1285 next if ($realfile !~ /\.(h|c|pl)$/);
1287 # at the beginning of a line any tabs must come first and anything
1288 # more than 8 must use tabs.
1289 if ($rawline =~ /^\+\s* \t\s*\S/ ||
1290 $rawline =~ /^\+\s* \s*/) {
1291 my $herevet = "$here\n" . cat_vet($rawline) . "\n";
1292 ERROR("code indent should use tabs where possible\n" . $herevet);
1295 # check we are in a valid C source file if not then ignore this hunk
1296 next if ($realfile !~ /\.(h|c)$/);
1298 # check for RCS/CVS revision markers
1299 if ($rawline =~ /^\+.*\$(Revision|Log|Id)(?:\$|)/) {
1300 WARN("CVS style keyword markers, these will _not_ be updated\n". $herecurr);
1303 # Check for potential 'bare' types
1304 my ($stat, $cond, $line_nr_next, $remain_next);
1305 if ($realcnt && $line =~ /.\s*\S/) {
1306 ($stat, $cond, $line_nr_next, $remain_next) =
1307 ctx_statement_block($linenr, $realcnt, 0);
1308 $stat =~ s/\n./\n /g;
1309 $cond =~ s/\n./\n /g;
1314 # Ignore goto labels.
1315 if ($s =~ /$Ident:\*$/s) {
1317 # Ignore functions being called
1318 } elsif ($s =~ /^.\s*$Ident\s*\(/s) {
1320 # declarations always start with types
1321 } elsif ($prev_values eq 'E' && $s =~ /^.\s*(?:$Storage\s+)?(?:$Inline\s+)?(?:const\s+)?((?:\s*$Ident)+?)\b(?:\s+$Sparse)?\s*\**\s*(?:$Ident|\(\*[^\)]*\))(?:\s*$Modifier)?\s*(?:;|=|,|\()/s) {
1324 possible($type, "A:" . $s);
1326 # definitions in global scope can only start with types
1327 } elsif ($s =~ /^.(?:$Storage\s+)?(?:$Inline\s+)?(?:const\s+)?($Ident)\b/s) {
1328 possible($1, "B:" . $s);
1331 # any (foo ... *) is a pointer cast, and foo is a type
1332 while ($s =~ /\(($Ident)(?:\s+$Sparse)*\s*\*+\s*\)/sg) {
1333 possible($1, "C:" . $s);
1336 # Check for any sort of function declaration.
1337 # int foo(something bar, other baz);
1338 # void (*store_gdt)(x86_descr_ptr *);
1339 if ($prev_values eq 'E' && $s =~ /^(.(?:typedef\s*)?(?:(?:$Storage|$Inline)\s*)*\s*$Type\s*(?:\b$Ident|\(\*\s*$Ident\))\s*)\(/s) {
1340 my ($name_len) = length($1);
1343 substr($ctx, 0, $name_len + 1, '');
1344 $ctx =~ s/\)[^\)]*$//;
1346 for my $arg (split(/\s*,\s*/, $ctx)) {
1347 if ($arg =~ /^(?:const\s+)?($Ident)(?:\s+$Sparse)*\s*\**\s*(:?\b$Ident)?$/s || $arg =~ /^($Ident)$/s) {
1349 possible($1, "D:" . $s);
1357 # Checks which may be anchored in the context.
1360 # Check for switch () and associated case and default
1361 # statements should be at the same indent.
1362 if ($line=~/\bswitch\s*\(.*\)/) {
1365 my @ctx = ctx_block_outer($linenr, $realcnt);
1367 for my $ctx (@ctx) {
1368 my ($clen, $cindent) = line_stats($ctx);
1369 if ($ctx =~ /^\+\s*(case\s+|default:)/ &&
1370 $indent != $cindent) {
1371 $err .= "$sep$ctx\n";
1378 ERROR("switch and case should be at the same indent\n$hereline$err");
1382 # if/while/etc brace do not go on next line, unless defining a do while loop,
1383 # or if that brace on the next line is for something else
1384 if ($line =~ /(.*)\b((?:if|while|for|switch)\s*\(|do\b|else\b)/ && $line !~ /^.\s*\#/) {
1385 my $pre_ctx = "$1$2";
1387 my ($level, @ctx) = ctx_statement_level($linenr, $realcnt, 0);
1388 my $ctx_cnt = $realcnt - $#ctx - 1;
1389 my $ctx = join("\n", @ctx);
1391 my $ctx_ln = $linenr;
1392 my $ctx_skip = $realcnt;
1394 while ($ctx_skip > $ctx_cnt || ($ctx_skip == $ctx_cnt &&
1395 defined $lines[$ctx_ln - 1] &&
1396 $lines[$ctx_ln - 1] =~ /^-/)) {
1397 ##print "SKIP<$ctx_skip> CNT<$ctx_cnt>\n";
1398 $ctx_skip-- if (!defined $lines[$ctx_ln - 1] || $lines[$ctx_ln - 1] !~ /^-/);
1402 #print "realcnt<$realcnt> ctx_cnt<$ctx_cnt>\n";
1403 #print "pre<$pre_ctx>\nline<$line>\nctx<$ctx>\nnext<$lines[$ctx_ln - 1]>\n";
1405 if ($ctx !~ /{\s*/ && defined($lines[$ctx_ln -1]) && $lines[$ctx_ln - 1] =~ /^\+\s*{/) {
1406 ERROR("that open brace { should be on the previous line\n" .
1407 "$here\n$ctx\n$lines[$ctx_ln - 1]\n");
1409 if ($level == 0 && $pre_ctx !~ /}\s*while\s*\($/ &&
1410 $ctx =~ /\)\s*\;\s*$/ &&
1411 defined $lines[$ctx_ln - 1])
1413 my ($nlength, $nindent) = line_stats($lines[$ctx_ln - 1]);
1414 if ($nindent > $indent) {
1415 WARN("trailing semicolon indicates no statements, indent implies otherwise\n" .
1416 "$here\n$ctx\n$lines[$ctx_ln - 1]\n");
1421 # Check relative indent for conditionals and blocks.
1422 if ($line =~ /\b(?:(?:if|while|for)\s*\(|do\b)/ && $line !~ /^.\s*#/ && $line !~ /\}\s*while\s*/) {
1423 my ($s, $c) = ($stat, $cond);
1425 substr($s, 0, length($c), '');
1427 # Make sure we remove the line prefixes as we have
1428 # none on the first line, and are going to readd them
1432 # Find out how long the conditional actually is.
1433 my @newlines = ($c =~ /\n/gs);
1434 my $cond_lines = 1 + $#newlines;
1436 # We want to check the first line inside the block
1437 # starting at the end of the conditional, so remove:
1438 # 1) any blank line termination
1439 # 2) any opening brace { on end of the line
1441 my $continuation = 0;
1443 $s =~ s/^.*\bdo\b//;
1445 if ($s =~ s/^\s*\\//) {
1448 if ($s =~ s/^\s*?\n//) {
1453 # Also ignore a loop construct at the end of a
1454 # preprocessor statement.
1455 if (($prevline =~ /^.\s*#\s*define\s/ ||
1456 $prevline =~ /\\\s*$/) && $continuation == 0) {
1461 while ($cond_ptr != $cond_lines) {
1462 $cond_ptr = $cond_lines;
1465 # 1) blank lines, they should be at 0,
1466 # 2) preprocessor lines, and
1468 if ($s =~ /^\s*?\n/ ||
1469 $s =~ /^\s*#\s*?/ ||
1470 $s =~ /^\s*$Ident\s*:/) {
1476 my (undef, $sindent) = line_stats("+" . $s);
1477 my $stat_real = raw_line($linenr, $cond_lines);
1479 # Check if either of these lines are modified, else
1480 # this is not this patch's fault.
1481 if (!defined($stat_real) ||
1482 $stat !~ /^\+/ && $stat_real !~ /^\+/) {
1485 if (defined($stat_real) && $cond_lines > 1) {
1486 $stat_real = "[...]\n$stat_real";
1489 #print "line<$line> prevline<$prevline> indent<$indent> sindent<$sindent> check<$check> continuation<$continuation> s<$s> cond_lines<$cond_lines> stat_real<$stat_real> stat<$stat>\n";
1491 if ($check && (($sindent % 8) != 0 ||
1492 ($sindent <= $indent && $s ne ''))) {
1493 WARN("suspect code indent for conditional statements ($indent, $sindent)\n" . $herecurr . "$stat_real\n");
1497 # Track the 'values' across context and added lines.
1498 my $opline = $line; $opline =~ s/^./ /;
1499 my ($curr_values, $curr_vars) =
1500 annotate_values($opline . "\n", $prev_values);
1501 $curr_values = $prev_values . $curr_values;
1503 my $outline = $opline; $outline =~ s/\t/ /g;
1504 print "$linenr > .$outline\n";
1505 print "$linenr > $curr_values\n";
1506 print "$linenr > $curr_vars\n";
1508 $prev_values = substr($curr_values, -1);
1510 #ignore lines not being added
1511 if ($line=~/^[^\+]/) {next;}
1513 # TEST: allow direct testing of the type matcher.
1515 if ($line =~ /^.\s*$Declare\s*$/) {
1516 ERROR("TEST: is type\n" . $herecurr);
1517 } elsif ($dbg_type > 1 && $line =~ /^.+($Declare)/) {
1518 ERROR("TEST: is not type ($1 is)\n". $herecurr);
1522 # TEST: allow direct testing of the attribute matcher.
1524 if ($line =~ /^.\s*$Attribute\s*$/) {
1525 ERROR("TEST: is attr\n" . $herecurr);
1526 } elsif ($dbg_attr > 1 && $line =~ /^.+($Attribute)/) {
1527 ERROR("TEST: is not attr ($1 is)\n". $herecurr);
1532 # check for initialisation to aggregates open brace on the next line
1533 if ($prevline =~ /$Declare\s*$Ident\s*=\s*$/ &&
1534 $line =~ /^.\s*{/) {
1535 ERROR("that open brace { should be on the previous line\n" . $hereprev);
1539 # Checks which are anchored on the added line.
1542 # check for malformed paths in #include statements (uses RAW line)
1543 if ($rawline =~ m{^.\s*\#\s*include\s+[<"](.*)[">]}) {
1545 if ($path =~ m{//}) {
1546 ERROR("malformed #include filename\n" .
1551 # no C99 // comments
1552 if ($line =~ m{//}) {
1553 ERROR("do not use C99 // comments\n" . $herecurr);
1555 # Remove C99 comments.
1557 $opline =~ s@//.*@@;
1559 #EXPORT_SYMBOL should immediately follow its function closing }.
1560 if (($line =~ /EXPORT_SYMBOL.*\((.*)\)/) ||
1561 ($line =~ /EXPORT_UNUSED_SYMBOL.*\((.*)\)/)) {
1563 if (($prevline !~ /^}/) &&
1564 ($prevline !~ /^\+}/) &&
1565 ($prevline !~ /^ }/) &&
1566 ($prevline !~ /^.DECLARE_$Ident\(\Q$name\E\)/) &&
1567 ($prevline !~ /^.LIST_HEAD\(\Q$name\E\)/) &&
1568 ($prevline !~ /^.$Type\s*\(\s*\*\s*\Q$name\E\s*\)\s*\(/) &&
1569 ($prevline !~ /\b\Q$name\E(?:\s+$Attribute)?\s*(?:;|=|\[)/)) {
1570 WARN("EXPORT_SYMBOL(foo); should immediately follow its function/variable\n" . $herecurr);
1574 # check for external initialisers.
1575 if ($line =~ /^.$Type\s*$Ident\s*(?:\s+$Modifier)*\s*=\s*(0|NULL|false)\s*;/) {
1576 ERROR("do not initialise externals to 0 or NULL\n" .
1579 # check for static initialisers.
1580 if ($line =~ /\s*static\s.*=\s*(0|NULL|false)\s*;/) {
1581 ERROR("do not initialise statics to 0 or NULL\n" .
1585 # check for new typedefs, only function parameters and sparse annotations
1587 if ($line =~ /\btypedef\s/ &&
1588 $line !~ /\btypedef\s+$Type\s+\(\s*\*?$Ident\s*\)\s*\(/ &&
1589 $line !~ /\btypedef\s+$Type\s+$Ident\s*\(/ &&
1590 $line !~ /\b__bitwise(?:__|)\b/) {
1591 WARN("do not add new typedefs\n" . $herecurr);
1594 # * goes on variable not on type
1595 if ($line =~ m{\($NonptrType(\*+)(?:\s+const)?\)}) {
1596 ERROR("\"(foo$1)\" should be \"(foo $1)\"\n" .
1599 } elsif ($line =~ m{\($NonptrType\s+(\*+)(?!\s+const)\s+\)}) {
1600 ERROR("\"(foo $1 )\" should be \"(foo $1)\"\n" .
1603 } elsif ($line =~ m{\b$NonptrType(\*+)(?:\s+(?:$Attribute|$Sparse))?\s+[A-Za-z\d_]+}) {
1604 ERROR("\"foo$1 bar\" should be \"foo $1bar\"\n" .
1607 } elsif ($line =~ m{\b$NonptrType\s+(\*+)(?!\s+(?:$Attribute|$Sparse))\s+[A-Za-z\d_]+}) {
1608 ERROR("\"foo $1 bar\" should be \"foo $1bar\"\n" .
1612 # # no BUG() or BUG_ON()
1613 # if ($line =~ /\b(BUG|BUG_ON)\b/) {
1614 # print "Try to use WARN_ON & Recovery code rather than BUG() or BUG_ON()\n";
1615 # print "$herecurr";
1619 if ($line =~ /\bLINUX_VERSION_CODE\b/) {
1620 WARN("LINUX_VERSION_CODE should be avoided, code should be for the version to which it is merged\n" . $herecurr);
1623 # printk should use KERN_* levels. Note that follow on printk's on the
1624 # same line do not need a level, so we use the current block context
1625 # to try and find and validate the current printk. In summary the current
1626 # printk includes all preceeding printk's which have no newline on the end.
1627 # we assume the first bad printk is the one to report.
1628 if ($line =~ /\bprintk\((?!KERN_)\s*"/) {
1630 for (my $ln = $linenr - 1; $ln >= $first_line; $ln--) {
1631 #print "CHECK<$lines[$ln - 1]\n";
1632 # we have a preceeding printk if it ends
1633 # with "\n" ignore it, else it is to blame
1634 if ($lines[$ln - 1] =~ m{\bprintk\(}) {
1635 if ($rawlines[$ln - 1] !~ m{\\n"}) {
1642 WARN("printk() should include KERN_ facility level\n" . $herecurr);
1646 # function brace can't be on same line, except for #defines of do while,
1647 # or if closed on same line
1648 if (($line=~/$Type\s*$Ident\(.*\).*\s{/) and
1649 !($line=~/\#\s*define.*do\s{/) and !($line=~/}/)) {
1650 ERROR("open brace '{' following function declarations go on the next line\n" . $herecurr);
1653 # open braces for enum, union and struct go on the same line.
1654 if ($line =~ /^.\s*{/ &&
1655 $prevline =~ /^.\s*(?:typedef\s+)?(enum|union|struct)(?:\s+$Ident)?\s*$/) {
1656 ERROR("open brace '{' following $1 go on the same line\n" . $hereprev);
1659 # check for spacing round square brackets; allowed:
1660 # 1. with a type on the left -- int [] a;
1661 # 2. at the beginning of a line for slice initialisers -- [0...10] = 5,
1662 # 3. inside a curly brace -- = { [0...10] = 5 }
1663 while ($line =~ /(.*?\s)\[/g) {
1664 my ($where, $prefix) = ($-[1], $1);
1665 if ($prefix !~ /$Type\s+$/ &&
1666 ($where != 0 || $prefix !~ /^.\s+$/) &&
1667 $prefix !~ /{\s+$/) {
1668 ERROR("space prohibited before open square bracket '['\n" . $herecurr);
1672 # check for spaces between functions and their parentheses.
1673 while ($line =~ /($Ident)\s+\(/g) {
1675 my $ctx_before = substr($line, 0, $-[1]);
1676 my $ctx = "$ctx_before$name";
1678 # Ignore those directives where spaces _are_ permitted.
1680 if|for|while|switch|return|case|
1681 volatile|__volatile__|
1682 __attribute__|format|__extension__|
1686 # cpp #define statements have non-optional spaces, ie
1687 # if there is a space between the name and the open
1688 # parenthesis it is simply not a parameter group.
1689 } elsif ($ctx_before =~ /^.\s*\#\s*define\s*$/) {
1691 # cpp #elif statement condition may start with a (
1692 } elsif ($ctx =~ /^.\s*\#\s*elif\s*$/) {
1694 # If this whole things ends with a type its most
1695 # likely a typedef for a function.
1696 } elsif ($ctx =~ /$Type$/) {
1699 WARN("space prohibited between function name and open parenthesis '('\n" . $herecurr);
1702 # Check operator spacing.
1703 if (!($line=~/\#\s*include/)) {
1705 <<=|>>=|<=|>=|==|!=|
1706 \+=|-=|\*=|\/=|%=|\^=|\|=|&=|
1707 =>|->|<<|>>|<|>|=|!|~|
1708 &&|\|\||,|\^|\+\+|--|&|\||\+|-|\*|\/|%|
1711 my @elements = split(/($ops|;)/, $opline);
1714 my $blank = copy_spacing($opline);
1716 for (my $n = 0; $n < $#elements; $n += 2) {
1717 $off += length($elements[$n]);
1719 # Pick up the preceeding and succeeding characters.
1720 my $ca = substr($opline, 0, $off);
1722 if (length($opline) >= ($off + length($elements[$n + 1]))) {
1723 $cc = substr($opline, $off + length($elements[$n + 1]));
1725 my $cb = "$ca$;$cc";
1728 $a = 'V' if ($elements[$n] ne '');
1729 $a = 'W' if ($elements[$n] =~ /\s$/);
1730 $a = 'C' if ($elements[$n] =~ /$;$/);
1731 $a = 'B' if ($elements[$n] =~ /(\[|\()$/);
1732 $a = 'O' if ($elements[$n] eq '');
1733 $a = 'E' if ($ca =~ /^\s*$/);
1735 my $op = $elements[$n + 1];
1738 if (defined $elements[$n + 2]) {
1739 $c = 'V' if ($elements[$n + 2] ne '');
1740 $c = 'W' if ($elements[$n + 2] =~ /^\s/);
1741 $c = 'C' if ($elements[$n + 2] =~ /^$;/);
1742 $c = 'B' if ($elements[$n + 2] =~ /^(\)|\]|;)/);
1743 $c = 'O' if ($elements[$n + 2] eq '');
1744 $c = 'E' if ($elements[$n + 2] =~ /\s*\\$/);
1749 my $ctx = "${a}x${c}";
1751 my $at = "(ctx:$ctx)";
1753 my $ptr = substr($blank, 0, $off) . "^";
1754 my $hereptr = "$hereline$ptr\n";
1756 # Pull out the value of this operator.
1757 my $op_type = substr($curr_values, $off + 1, 1);
1759 # Get the full operator variant.
1760 my $opv = $op . substr($curr_vars, $off, 1);
1762 # Ignore operators passed as parameters.
1763 if ($op_type ne 'V' &&
1764 $ca =~ /\s$/ && $cc =~ /^\s*,/) {
1767 # } elsif ($op =~ /^$;+$/) {
1769 # ; should have either the end of line or a space or \ after it
1770 } elsif ($op eq ';') {
1771 if ($ctx !~ /.x[WEBC]/ &&
1772 $cc !~ /^\\/ && $cc !~ /^;/) {
1773 ERROR("space required after that '$op' $at\n" . $hereptr);
1777 } elsif ($op eq '//') {
1781 # : when part of a bitfield
1782 } elsif ($op eq '->' || $opv eq ':B') {
1783 if ($ctx =~ /Wx.|.xW/) {
1784 ERROR("spaces prohibited around that '$op' $at\n" . $hereptr);
1787 # , must have a space on the right.
1788 } elsif ($op eq ',') {
1789 if ($ctx !~ /.x[WEC]/ && $cc !~ /^}/) {
1790 ERROR("space required after that '$op' $at\n" . $hereptr);
1793 # '*' as part of a type definition -- reported already.
1794 } elsif ($opv eq '*_') {
1795 #warn "'*' is part of type\n";
1797 # unary operators should have a space before and
1798 # none after. May be left adjacent to another
1799 # unary operator, or a cast
1800 } elsif ($op eq '!' || $op eq '~' ||
1801 $opv eq '*U' || $opv eq '-U' ||
1802 $opv eq '&U' || $opv eq '&&U') {
1803 if ($ctx !~ /[WEBC]x./ && $ca !~ /(?:\)|!|~|\*|-|\&|\||\+\+|\-\-|\{)$/) {
1804 ERROR("space required before that '$op' $at\n" . $hereptr);
1806 if ($op eq '*' && $cc =~/\s*const\b/) {
1807 # A unary '*' may be const
1809 } elsif ($ctx =~ /.xW/) {
1810 ERROR("space prohibited after that '$op' $at\n" . $hereptr);
1813 # unary ++ and unary -- are allowed no space on one side.
1814 } elsif ($op eq '++' or $op eq '--') {
1815 if ($ctx !~ /[WEOBC]x[^W]/ && $ctx !~ /[^W]x[WOBEC]/) {
1816 ERROR("space required one side of that '$op' $at\n" . $hereptr);
1818 if ($ctx =~ /Wx[BE]/ ||
1819 ($ctx =~ /Wx./ && $cc =~ /^;/)) {
1820 ERROR("space prohibited before that '$op' $at\n" . $hereptr);
1822 if ($ctx =~ /ExW/) {
1823 ERROR("space prohibited after that '$op' $at\n" . $hereptr);
1827 # << and >> may either have or not have spaces both sides
1828 } elsif ($op eq '<<' or $op eq '>>' or
1829 $op eq '&' or $op eq '^' or $op eq '|' or
1830 $op eq '+' or $op eq '-' or
1831 $op eq '*' or $op eq '/' or
1834 if ($ctx =~ /Wx[^WCE]|[^WCE]xW/) {
1835 ERROR("need consistent spacing around '$op' $at\n" .
1839 # A colon needs no spaces before when it is
1840 # terminating a case value or a label.
1841 } elsif ($opv eq ':C' || $opv eq ':L') {
1842 if ($ctx =~ /Wx./) {
1843 ERROR("space prohibited before that '$op' $at\n" . $hereptr);
1846 # All the others need spaces both sides.
1847 } elsif ($ctx !~ /[EWC]x[CWE]/) {
1850 # Ignore email addresses <foo@bar>
1852 $cc =~ /^\S+\@\S+>/) ||
1854 $ca =~ /<\S+\@\S+$/))
1860 if (($opv eq ':O' && $ca =~ /\?$/) ||
1861 ($op eq '?' && $cc =~ /^:/)) {
1866 ERROR("spaces required around that '$op' $at\n" . $hereptr);
1869 $off += length($elements[$n + 1]);
1873 # check for multiple assignments
1874 if ($line =~ /^.\s*$Lval\s*=\s*$Lval\s*=(?!=)/) {
1875 CHK("multiple assignments should be avoided\n" . $herecurr);
1878 ## # check for multiple declarations, allowing for a function declaration
1880 ## if ($line =~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Ident.*/ &&
1881 ## $line !~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Type\s*$Ident.*/) {
1883 ## # Remove any bracketed sections to ensure we do not
1884 ## # falsly report the parameters of functions.
1886 ## while ($ln =~ s/\([^\(\)]*\)//g) {
1888 ## if ($ln =~ /,/) {
1889 ## WARN("declaring multiple variables together should be avoided\n" . $herecurr);
1893 #need space before brace following if, while, etc
1894 if (($line =~ /\(.*\){/ && $line !~ /\($Type\){/) ||
1896 ERROR("space required before the open brace '{'\n" . $herecurr);
1899 # closing brace should have a space following it when it has anything
1901 if ($line =~ /}(?!(?:,|;|\)))\S/) {
1902 ERROR("space required after that close brace '}'\n" . $herecurr);
1905 # check spacing on square brackets
1906 if ($line =~ /\[\s/ && $line !~ /\[\s*$/) {
1907 ERROR("space prohibited after that open square bracket '['\n" . $herecurr);
1909 if ($line =~ /\s\]/) {
1910 ERROR("space prohibited before that close square bracket ']'\n" . $herecurr);
1913 # check spacing on parentheses
1914 if ($line =~ /\(\s/ && $line !~ /\(\s*(?:\\)?$/ &&
1915 $line !~ /for\s*\(\s+;/) {
1916 ERROR("space prohibited after that open parenthesis '('\n" . $herecurr);
1918 if ($line =~ /(\s+)\)/ && $line !~ /^.\s*\)/ &&
1919 $line !~ /for\s*\(.*;\s+\)/ &&
1920 $line !~ /:\s+\)/) {
1921 ERROR("space prohibited before that close parenthesis ')'\n" . $herecurr);
1924 #goto labels aren't indented, allow a single space however
1925 if ($line=~/^.\s+[A-Za-z\d_]+:(?![0-9]+)/ and
1926 !($line=~/^. [A-Za-z\d_]+:/) and !($line=~/^.\s+default:/)) {
1927 WARN("labels should not be indented\n" . $herecurr);
1930 # Return is not a function.
1931 if (defined($stat) && $stat =~ /^.\s*return(\s*)(\(.*);/s) {
1935 # Flatten any parentheses and braces
1936 $value =~ s/\)\(/\) \(/g;
1937 while ($value =~ s/\([^\(\)]*\)/1/) {
1940 if ($value =~ /^(?:$Ident|-?$Constant)$/) {
1941 ERROR("return is not a function, parentheses are not required\n" . $herecurr);
1943 } elsif ($spacing !~ /\s+/) {
1944 ERROR("space required before the open parenthesis '('\n" . $herecurr);
1948 # Need a space before open parenthesis after if, while etc
1949 if ($line=~/\b(if|while|for|switch)\(/) {
1950 ERROR("space required before the open parenthesis '('\n" . $herecurr);
1953 # Check for illegal assignment in if conditional -- and check for trailing
1954 # statements after the conditional.
1955 if ($line =~ /\b(?:if|while|for)\s*\(/ && $line !~ /^.\s*#/) {
1956 my ($s, $c) = ($stat, $cond);
1958 if ($c =~ /\bif\s*\(.*[^<>!=]=[^=].*/) {
1959 ERROR("do not use assignment in if condition\n" . $herecurr);
1962 # Find out what is on the end of the line after the
1964 substr($s, 0, length($c), '');
1966 $s =~ s/$;//g; # Remove any comments
1967 if (length($c) && $s !~ /^\s*{?\s*\\*\s*$/ &&
1968 $c !~ /}\s*while\s*/)
1970 ERROR("trailing statements should be on next line\n" . $herecurr);
1974 # Check for bitwise tests written as boolean
1986 WARN("boolean test with hexadecimal, perhaps just 1 \& or \|?\n" . $herecurr);
1989 # if and else should not have general statements after it
1990 if ($line =~ /^.\s*(?:}\s*)?else\b(.*)/) {
1992 $s =~ s/$;//g; # Remove any comments
1993 if ($s !~ /^\s*(?:\sif|(?:{|)\s*\\?\s*$)/) {
1994 ERROR("trailing statements should be on next line\n" . $herecurr);
1997 # case and default should not have general statements after them
1998 if ($line =~ /^.\s*(?:case\s*.*|default\s*):/g &&
2000 (?:\s*{)?(?:\s*$;*)(?:\s*\\)?\s*$|
2004 ERROR("trailing statements should be on next line\n" . $herecurr);
2007 # Check for }<nl>else {, these must be at the same
2008 # indent level to be relevant to each other.
2009 if ($prevline=~/}\s*$/ and $line=~/^.\s*else\s*/ and
2010 $previndent == $indent) {
2011 ERROR("else should follow close brace '}'\n" . $hereprev);
2014 if ($prevline=~/}\s*$/ and $line=~/^.\s*while\s*/ and
2015 $previndent == $indent) {
2016 my ($s, $c) = ctx_statement_block($linenr, $realcnt, 0);
2018 # Find out what is on the end of the line after the
2020 substr($s, 0, length($c), '');
2023 if ($s =~ /^\s*;/) {
2024 ERROR("while should follow close brace '}'\n" . $hereprev);
2028 #studly caps, commented out until figure out how to distinguish between use of existing and adding new
2029 # if (($line=~/[\w_][a-z\d]+[A-Z]/) and !($line=~/print/)) {
2030 # print "No studly caps, use _\n";
2031 # print "$herecurr";
2035 #no spaces allowed after \ in define
2036 if ($line=~/\#\s*define.*\\\s$/) {
2037 WARN("Whitepspace after \\ makes next lines useless\n" . $herecurr);
2040 #warn if <asm/foo.h> is #included and <linux/foo.h> is available (uses RAW line)
2041 if ($tree && $rawline =~ m{^.\s*\#\s*include\s*\<asm\/(.*)\.h\>}) {
2043 my $checkfile = "include/linux/$file";
2044 if (-f "$root/$checkfile" &&
2045 $realfile ne $checkfile &&
2048 if ($realfile =~ m{^arch/}) {
2049 CHK("Consider using #include <linux/$file> instead of <asm/$file>\n" . $herecurr);
2051 WARN("Use #include <linux/$file> instead of <asm/$file>\n" . $herecurr);
2056 # multi-statement macros should be enclosed in a do while loop, grab the
2057 # first statement and ensure its the whole macro if its not enclosed
2058 # in a known good container
2059 if ($realfile !~ m@/vmlinux.lds.h$@ &&
2060 $line =~ /^.\s*\#\s*define\s*$Ident(\()?/) {
2063 my ($off, $dstat, $dcond, $rest);
2066 my $args = defined($1);
2068 # Find the end of the macro and limit our statement
2070 while ($cnt > 0 && defined $lines[$ln - 1] &&
2071 $lines[$ln - 1] =~ /^(?:-|..*\\$)/)
2073 $ctx .= $rawlines[$ln - 1] . "\n";
2074 $cnt-- if ($lines[$ln - 1] !~ /^-/);
2077 $ctx .= $rawlines[$ln - 1];
2079 ($dstat, $dcond, $ln, $cnt, $off) =
2080 ctx_statement_block($linenr, $ln - $linenr + 1, 0);
2081 #print "dstat<$dstat> dcond<$dcond> cnt<$cnt> off<$off>\n";
2082 #print "LINE<$lines[$ln-1]> len<" . length($lines[$ln-1]) . "\n";
2084 # Extract the remainder of the define (if any) and
2085 # rip off surrounding spaces, and trailing \'s.
2087 while ($off != 0 || ($cnt > 0 && $rest =~ /\\\s*$/)) {
2088 #print "ADDING cnt<$cnt> $off <" . substr($lines[$ln - 1], $off) . "> rest<$rest>\n";
2089 if ($off != 0 || $lines[$ln - 1] !~ /^-/) {
2090 $rest .= substr($lines[$ln - 1], $off) . "\n";
2096 $rest =~ s/\\\n.//g;
2100 # Clean up the original statement.
2102 substr($dstat, 0, length($dcond), '');
2104 $dstat =~ s/^.\s*\#\s*define\s+$Ident\s*//;
2107 $dstat =~ s/\\\n.//g;
2108 $dstat =~ s/^\s*//s;
2109 $dstat =~ s/\s*$//s;
2111 # Flatten any parentheses and braces
2112 while ($dstat =~ s/\([^\(\)]*\)/1/) {
2114 while ($dstat =~ s/\{[^\{\}]*\}/1/) {
2117 my $exceptions = qr{
2125 #print "REST<$rest>\n";
2127 if ($rest !~ /while\s*\(/ &&
2128 $dstat !~ /$exceptions/)
2130 ERROR("Macros with multiple statements should be enclosed in a do - while loop\n" . "$here\n$ctx\n");
2133 } elsif ($ctx !~ /;/) {
2135 $dstat !~ /^(?:$Ident|-?$Constant)$/ &&
2136 $dstat !~ /$exceptions/ &&
2137 $dstat =~ /$Operators/)
2139 ERROR("Macros with complex values should be enclosed in parenthesis\n" . "$here\n$ctx\n");
2144 # check for redundant bracing round if etc
2145 if ($line =~ /(^.*)\bif\b/ && $1 !~ /else\s*$/) {
2146 my ($level, $endln, @chunks) =
2147 ctx_statement_full($linenr, $realcnt, 1);
2148 #print "chunks<$#chunks> linenr<$linenr> endln<$endln> level<$level>\n";
2149 #print "APW: <<$chunks[1][0]>><<$chunks[1][1]>>\n";
2150 if ($#chunks > 0 && $level == 0) {
2153 my $herectx = $here . "\n";
2154 my $ln = $linenr - 1;
2155 for my $chunk (@chunks) {
2156 my ($cond, $block) = @{$chunk};
2158 # If the condition carries leading newlines, then count those as offsets.
2159 my ($whitespace) = ($cond =~ /^((?:\s*\n[+-])*\s*)/s);
2160 my $offset = statement_rawlines($whitespace) - 1;
2162 #print "COND<$cond> whitespace<$whitespace> offset<$offset>\n";
2164 # We have looked at and allowed this specific line.
2165 $suppress_ifbraces{$ln + $offset} = 1;
2167 $herectx .= "$rawlines[$ln + $offset]\n[...]\n";
2168 $ln += statement_rawlines($block) - 1;
2170 substr($block, 0, length($cond), '');
2172 $seen++ if ($block =~ /^\s*{/);
2174 #print "cond<$cond> block<$block> allowed<$allowed>\n";
2175 if (statement_lines($cond) > 1) {
2176 #print "APW: ALLOWED: cond<$cond>\n";
2179 if ($block =~/\b(?:if|for|while)\b/) {
2180 #print "APW: ALLOWED: block<$block>\n";
2183 if (statement_block_size($block) > 1) {
2184 #print "APW: ALLOWED: lines block<$block>\n";
2188 if ($seen && !$allowed) {
2189 WARN("braces {} are not necessary for any arm of this statement\n" . $herectx);
2193 if (!defined $suppress_ifbraces{$linenr - 1} &&
2194 $line =~ /\b(if|while|for|else)\b/) {
2197 # Check the pre-context.
2198 if (substr($line, 0, $-[0]) =~ /(\}\s*)$/) {
2199 #print "APW: ALLOWED: pre<$1>\n";
2203 my ($level, $endln, @chunks) =
2204 ctx_statement_full($linenr, $realcnt, $-[0]);
2206 # Check the condition.
2207 my ($cond, $block) = @{$chunks[0]};
2208 #print "CHECKING<$linenr> cond<$cond> block<$block>\n";
2209 if (defined $cond) {
2210 substr($block, 0, length($cond), '');
2212 if (statement_lines($cond) > 1) {
2213 #print "APW: ALLOWED: cond<$cond>\n";
2216 if ($block =~/\b(?:if|for|while)\b/) {
2217 #print "APW: ALLOWED: block<$block>\n";
2220 if (statement_block_size($block) > 1) {
2221 #print "APW: ALLOWED: lines block<$block>\n";
2224 # Check the post-context.
2225 if (defined $chunks[1]) {
2226 my ($cond, $block) = @{$chunks[1]};
2227 if (defined $cond) {
2228 substr($block, 0, length($cond), '');
2230 if ($block =~ /^\s*\{/) {
2231 #print "APW: ALLOWED: chunk-1 block<$block>\n";
2235 if ($level == 0 && $block =~ /^\s*\{/ && !$allowed) {
2236 my $herectx = $here . "\n";;
2237 my $cnt = statement_rawlines($block);
2239 for (my $n = 0; $n < $cnt; $n++) {
2240 $herectx .= raw_line($linenr, $n) . "\n";;
2243 WARN("braces {} are not necessary for single statement blocks\n" . $herectx);
2247 # don't include deprecated include files (uses RAW line)
2248 for my $inc (@dep_includes) {
2249 if ($rawline =~ m@^.\s*\#\s*include\s*\<$inc>@) {
2250 ERROR("Don't use <$inc>: see Documentation/feature-removal-schedule.txt\n" . $herecurr);
2254 # don't use deprecated functions
2255 for my $func (@dep_functions) {
2256 if ($line =~ /\b$func\b/) {
2257 ERROR("Don't use $func(): see Documentation/feature-removal-schedule.txt\n" . $herecurr);
2261 # no volatiles please
2262 my $asm_volatile = qr{\b(__asm__|asm)\s+(__volatile__|volatile)\b};
2263 if ($line =~ /\bvolatile\b/ && $line !~ /$asm_volatile/) {
2264 WARN("Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt\n" . $herecurr);
2267 # SPIN_LOCK_UNLOCKED & RW_LOCK_UNLOCKED are deprecated
2268 if ($line =~ /\b(SPIN_LOCK_UNLOCKED|RW_LOCK_UNLOCKED)/) {
2269 ERROR("Use of $1 is deprecated: see Documentation/spinlocks.txt\n" . $herecurr);
2273 if ($line =~ /^.\s*\#\s*if\s+0\b/) {
2274 CHK("if this code is redundant consider removing it\n" .
2278 # check for needless kfree() checks
2279 if ($prevline =~ /\bif\s*\(([^\)]*)\)/) {
2281 if ($line =~ /\bkfree\(\Q$expr\E\);/) {
2282 WARN("kfree(NULL) is safe this check is probably not required\n" . $hereprev);
2285 # check for needless usb_free_urb() checks
2286 if ($prevline =~ /\bif\s*\(([^\)]*)\)/) {
2288 if ($line =~ /\busb_free_urb\(\Q$expr\E\);/) {
2289 WARN("usb_free_urb(NULL) is safe this check is probably not required\n" . $hereprev);
2293 # warn about #ifdefs in C files
2294 # if ($line =~ /^.\s*\#\s*if(|n)def/ && ($realfile =~ /\.c$/)) {
2295 # print "#ifdef in C files should be avoided\n";
2296 # print "$herecurr";
2300 # warn about spacing in #ifdefs
2301 if ($line =~ /^.\s*\#\s*(ifdef|ifndef|elif)\s\s+/) {
2302 ERROR("exactly one space required after that #$1\n" . $herecurr);
2305 # check for spinlock_t definitions without a comment.
2306 if ($line =~ /^.\s*(struct\s+mutex|spinlock_t)\s+\S+;/ ||
2307 $line =~ /^.\s*(DEFINE_MUTEX)\s*\(/) {
2309 if (!ctx_has_comment($first_line, $linenr)) {
2310 CHK("$1 definition without comment\n" . $herecurr);
2313 # check for memory barriers without a comment.
2314 if ($line =~ /\b(mb|rmb|wmb|read_barrier_depends|smp_mb|smp_rmb|smp_wmb|smp_read_barrier_depends)\(/) {
2315 if (!ctx_has_comment($first_line, $linenr)) {
2316 CHK("memory barrier without comment\n" . $herecurr);
2319 # check of hardware specific defines
2320 if ($line =~ m@^.\s*\#\s*if.*\b(__i386__|__powerpc64__|__sun__|__s390x__)\b@ && $realfile !~ m@include/asm-@) {
2321 CHK("architecture specific defines should be avoided\n" . $herecurr);
2324 # check the location of the inline attribute, that it is between
2325 # storage class and type.
2326 if ($line =~ /\b$Type\s+$Inline\b/ ||
2327 $line =~ /\b$Inline\s+$Storage\b/) {
2328 ERROR("inline keyword should sit between storage class and type\n" . $herecurr);
2331 # Check for __inline__ and __inline, prefer inline
2332 if ($line =~ /\b(__inline__|__inline)\b/) {
2333 WARN("plain inline is preferred over $1\n" . $herecurr);
2336 # check for new externs in .c files.
2337 if ($realfile =~ /\.c$/ && defined $stat &&
2338 $stat =~ /^.\s*(?:extern\s+)?$Type\s+($Ident)(\s*)\(/s)
2340 my $function_name = $1;
2341 my $paren_space = $2;
2344 if (defined $cond) {
2345 substr($s, 0, length($cond), '');
2347 if ($s =~ /^\s*;/ &&
2348 $function_name ne 'uninitialized_var')
2350 WARN("externs should be avoided in .c files\n" . $herecurr);
2353 if ($paren_space =~ /\n/) {
2354 WARN("arguments for function declarations should follow identifier\n" . $herecurr);
2357 } elsif ($realfile =~ /\.c$/ && defined $stat &&
2358 $stat =~ /^.\s*extern\s+/)
2360 WARN("externs should be avoided in .c files\n" . $herecurr);
2363 # checks for new __setup's
2364 if ($rawline =~ /\b__setup\("([^"]*)"/) {
2367 if (!grep(/$name/, @setup_docs)) {
2368 CHK("__setup appears un-documented -- check Documentation/kernel-parameters.txt\n" . $herecurr);
2372 # check for pointless casting of kmalloc return
2373 if ($line =~ /\*\s*\)\s*k[czm]alloc\b/) {
2374 WARN("unnecessary cast may hide bugs, see http://c-faq.com/malloc/mallocnocast.html\n" . $herecurr);
2377 # check for gcc specific __FUNCTION__
2378 if ($line =~ /__FUNCTION__/) {
2379 WARN("__func__ should be used instead of gcc specific __FUNCTION__\n" . $herecurr);
2382 # check for semaphores used as mutexes
2383 if ($line =~ /^.\s*(DECLARE_MUTEX|init_MUTEX)\s*\(/) {
2384 WARN("mutexes are preferred for single holder semaphores\n" . $herecurr);
2386 # check for semaphores used as mutexes
2387 if ($line =~ /^.\s*init_MUTEX_LOCKED\s*\(/) {
2388 WARN("consider using a completion\n" . $herecurr);
2390 # recommend strict_strto* over simple_strto*
2391 if ($line =~ /\bsimple_(strto.*?)\s*\(/) {
2392 WARN("consider using strict_$1 in preference to simple_$1\n" . $herecurr);
2394 # check for __initcall(), use device_initcall() explicitly please
2395 if ($line =~ /^.\s*__initcall\s*\(/) {
2396 WARN("please use device_initcall() instead of __initcall()\n" . $herecurr);
2399 # use of NR_CPUS is usually wrong
2400 # ignore definitions of NR_CPUS and usage to define arrays as likely right
2401 if ($line =~ /\bNR_CPUS\b/ &&
2402 $line !~ /^.\s*\s*#\s*if\b.*\bNR_CPUS\b/ &&
2403 $line !~ /^.\s*\s*#\s*define\b.*\bNR_CPUS\b/ &&
2404 $line !~ /^.\s*$Declare\s.*\[[^\]]*NR_CPUS[^\]]*\]/ &&
2405 $line !~ /\[[^\]]*\.\.\.[^\]]*NR_CPUS[^\]]*\]/ &&
2406 $line !~ /\[[^\]]*NR_CPUS[^\]]*\.\.\.[^\]]*\]/)
2408 WARN("usage of NR_CPUS is often wrong - consider using cpu_possible(), num_possible_cpus(), for_each_possible_cpu(), etc\n" . $herecurr);
2411 # check for %L{u,d,i} in strings
2413 while ($line =~ /(?:^|")([X\t]*)(?:"|$)/g) {
2414 $string = substr($rawline, $-[1], $+[1] - $-[1]);
2415 $string =~ s/%%/__/g;
2416 if ($string =~ /(?<!%)%L[udi]/) {
2417 WARN("\%Ld/%Lu are not-standard C, use %lld/%llu\n" . $herecurr);
2423 # If we have no input at all, then there is nothing to report on
2424 # so just keep quiet.
2425 if ($#rawlines == -1) {
2429 # In mailback mode only produce a report in the negative, for
2430 # things that appear to be patches.
2431 if ($mailback && ($clean == 1 || !$is_patch)) {
2435 # This is not a patch, and we are are in 'no-patch' mode so
2437 if (!$chk_patch && !$is_patch) {
2442 ERROR("Does not appear to be a unified-diff format patch\n");
2444 if ($is_patch && $chk_signoff && $signoff == 0) {
2445 ERROR("Missing Signed-off-by: line(s)\n");
2448 print report_dump();
2449 if ($summary && !($clean == 1 && $quiet == 1)) {
2450 print "$filename " if ($summary_file);
2451 print "total: $cnt_error errors, $cnt_warn warnings, " .
2452 (($check)? "$cnt_chk checks, " : "") .
2453 "$cnt_lines lines checked\n";
2454 print "\n" if ($quiet == 0);
2457 if ($clean == 1 && $quiet == 0) {
2458 print "$vname has no obvious style problems and is ready for submission.\n"
2460 if ($clean == 0 && $quiet == 0) {
2461 print "$vname has style problems, please review. If any of these errors\n";
2462 print "are false positives report them to the maintainer, see\n";
2463 print "CHECKPATCH in MAINTAINERS.\n";