2 * linux/net/sunrpc/xprt.c
4 * This is a generic RPC call interface supporting congestion avoidance,
5 * and asynchronous calls.
7 * The interface works like this:
9 * - When a process places a call, it allocates a request slot if
10 * one is available. Otherwise, it sleeps on the backlog queue
12 * - Next, the caller puts together the RPC message, stuffs it into
13 * the request struct, and calls xprt_transmit().
14 * - xprt_transmit sends the message and installs the caller on the
15 * transport's wait list. At the same time, it installs a timer that
16 * is run after the packet's timeout has expired.
17 * - When a packet arrives, the data_ready handler walks the list of
18 * pending requests for that transport. If a matching XID is found, the
19 * caller is woken up, and the timer removed.
20 * - When no reply arrives within the timeout interval, the timer is
21 * fired by the kernel and runs xprt_timer(). It either adjusts the
22 * timeout values (minor timeout) or wakes up the caller with a status
24 * - When the caller receives a notification from RPC that a reply arrived,
25 * it should release the RPC slot, and process the reply.
26 * If the call timed out, it may choose to retry the operation by
27 * adjusting the initial timeout value, and simply calling rpc_call
30 * Support for async RPC is done through a set of RPC-specific scheduling
31 * primitives that `transparently' work for processes as well as async
32 * tasks that rely on callbacks.
34 * Copyright (C) 1995-1997, Olaf Kirch <okir@monad.swb.de>
36 * Transport switch API copyright (C) 2005, Chuck Lever <cel@netapp.com>
39 #include <linux/module.h>
41 #include <linux/types.h>
42 #include <linux/interrupt.h>
43 #include <linux/workqueue.h>
44 #include <linux/random.h>
46 #include <linux/sunrpc/clnt.h>
53 # undef RPC_DEBUG_DATA
54 # define RPCDBG_FACILITY RPCDBG_XPRT
60 static void xprt_request_init(struct rpc_task *, struct rpc_xprt *);
61 static inline void do_xprt_reserve(struct rpc_task *);
62 static void xprt_connect_status(struct rpc_task *task);
63 static int __xprt_get_cong(struct rpc_xprt *, struct rpc_task *);
65 static int xprt_clear_backlog(struct rpc_xprt *xprt);
68 * Serialize write access to transports, in order to prevent different
69 * requests from interfering with each other.
70 * Also prevents transport connects from colliding with writes.
73 __xprt_lock_write(struct rpc_xprt *xprt, struct rpc_task *task)
75 struct rpc_rqst *req = task->tk_rqstp;
77 if (test_and_set_bit(XPRT_LOCKED, &xprt->state)) {
78 if (task == xprt->snd_task)
82 if (xprt->nocong || __xprt_get_cong(xprt, task)) {
83 xprt->snd_task = task;
85 req->rq_bytes_sent = 0;
90 smp_mb__before_clear_bit();
91 clear_bit(XPRT_LOCKED, &xprt->state);
92 smp_mb__after_clear_bit();
94 dprintk("RPC: %4d failed to lock transport %p\n", task->tk_pid, xprt);
96 task->tk_status = -EAGAIN;
97 if (req && req->rq_ntrans)
98 rpc_sleep_on(&xprt->resend, task, NULL, NULL);
100 rpc_sleep_on(&xprt->sending, task, NULL, NULL);
105 xprt_lock_write(struct rpc_xprt *xprt, struct rpc_task *task)
109 spin_lock_bh(&xprt->transport_lock);
110 retval = __xprt_lock_write(xprt, task);
111 spin_unlock_bh(&xprt->transport_lock);
117 __xprt_lock_write_next(struct rpc_xprt *xprt)
119 struct rpc_task *task;
121 if (test_and_set_bit(XPRT_LOCKED, &xprt->state))
123 if (!xprt->nocong && RPCXPRT_CONGESTED(xprt))
125 task = rpc_wake_up_next(&xprt->resend);
127 task = rpc_wake_up_next(&xprt->sending);
131 if (xprt->nocong || __xprt_get_cong(xprt, task)) {
132 struct rpc_rqst *req = task->tk_rqstp;
133 xprt->snd_task = task;
135 req->rq_bytes_sent = 0;
141 smp_mb__before_clear_bit();
142 clear_bit(XPRT_LOCKED, &xprt->state);
143 smp_mb__after_clear_bit();
147 * Releases the transport for use by other requests.
150 __xprt_release_write(struct rpc_xprt *xprt, struct rpc_task *task)
152 if (xprt->snd_task == task) {
153 xprt->snd_task = NULL;
154 smp_mb__before_clear_bit();
155 clear_bit(XPRT_LOCKED, &xprt->state);
156 smp_mb__after_clear_bit();
157 __xprt_lock_write_next(xprt);
162 xprt_release_write(struct rpc_xprt *xprt, struct rpc_task *task)
164 spin_lock_bh(&xprt->transport_lock);
165 __xprt_release_write(xprt, task);
166 spin_unlock_bh(&xprt->transport_lock);
170 * Van Jacobson congestion avoidance. Check if the congestion window
171 * overflowed. Put the task to sleep if this is the case.
174 __xprt_get_cong(struct rpc_xprt *xprt, struct rpc_task *task)
176 struct rpc_rqst *req = task->tk_rqstp;
180 dprintk("RPC: %4d xprt_cwnd_limited cong = %ld cwnd = %ld\n",
181 task->tk_pid, xprt->cong, xprt->cwnd);
182 if (RPCXPRT_CONGESTED(xprt))
185 xprt->cong += RPC_CWNDSCALE;
190 * Adjust the congestion window, and wake up the next task
191 * that has been sleeping due to congestion
194 __xprt_put_cong(struct rpc_xprt *xprt, struct rpc_rqst *req)
199 xprt->cong -= RPC_CWNDSCALE;
200 __xprt_lock_write_next(xprt);
204 * Adjust RPC congestion window
205 * We use a time-smoothed congestion estimator to avoid heavy oscillation.
208 xprt_adjust_cwnd(struct rpc_xprt *xprt, int result)
213 if (result >= 0 && cwnd <= xprt->cong) {
214 /* The (cwnd >> 1) term makes sure
215 * the result gets rounded properly. */
216 cwnd += (RPC_CWNDSCALE * RPC_CWNDSCALE + (cwnd >> 1)) / cwnd;
217 if (cwnd > RPC_MAXCWND(xprt))
218 cwnd = RPC_MAXCWND(xprt);
219 __xprt_lock_write_next(xprt);
220 } else if (result == -ETIMEDOUT) {
222 if (cwnd < RPC_CWNDSCALE)
223 cwnd = RPC_CWNDSCALE;
225 dprintk("RPC: cong %ld, cwnd was %ld, now %ld\n",
226 xprt->cong, xprt->cwnd, cwnd);
231 * xprt_wake_pending_tasks - wake all tasks on a transport's pending queue
232 * @xprt: transport with waiting tasks
233 * @status: result code to plant in each task before waking it
236 void xprt_wake_pending_tasks(struct rpc_xprt *xprt, int status)
239 rpc_wake_up_status(&xprt->pending, status);
241 rpc_wake_up(&xprt->pending);
244 static void xprt_reset_majortimeo(struct rpc_rqst *req)
246 struct rpc_timeout *to = &req->rq_xprt->timeout;
248 req->rq_majortimeo = req->rq_timeout;
249 if (to->to_exponential)
250 req->rq_majortimeo <<= to->to_retries;
252 req->rq_majortimeo += to->to_increment * to->to_retries;
253 if (req->rq_majortimeo > to->to_maxval || req->rq_majortimeo == 0)
254 req->rq_majortimeo = to->to_maxval;
255 req->rq_majortimeo += jiffies;
259 * xprt_adjust_timeout - adjust timeout values for next retransmit
260 * @req: RPC request containing parameters to use for the adjustment
263 int xprt_adjust_timeout(struct rpc_rqst *req)
265 struct rpc_xprt *xprt = req->rq_xprt;
266 struct rpc_timeout *to = &xprt->timeout;
269 if (time_before(jiffies, req->rq_majortimeo)) {
270 if (to->to_exponential)
271 req->rq_timeout <<= 1;
273 req->rq_timeout += to->to_increment;
274 if (to->to_maxval && req->rq_timeout >= to->to_maxval)
275 req->rq_timeout = to->to_maxval;
277 pprintk("RPC: %lu retrans\n", jiffies);
279 req->rq_timeout = to->to_initval;
281 xprt_reset_majortimeo(req);
282 /* Reset the RTT counters == "slow start" */
283 spin_lock_bh(&xprt->transport_lock);
284 rpc_init_rtt(req->rq_task->tk_client->cl_rtt, to->to_initval);
285 spin_unlock_bh(&xprt->transport_lock);
286 pprintk("RPC: %lu timeout\n", jiffies);
290 if (req->rq_timeout == 0) {
291 printk(KERN_WARNING "xprt_adjust_timeout: rq_timeout = 0!\n");
292 req->rq_timeout = 5 * HZ;
297 static void xprt_autoclose(void *args)
299 struct rpc_xprt *xprt = (struct rpc_xprt *)args;
301 xprt_disconnect(xprt);
302 xprt->ops->close(xprt);
303 xprt_release_write(xprt, NULL);
307 * xprt_disconnect - mark a transport as disconnected
308 * @xprt: transport to flag for disconnect
311 void xprt_disconnect(struct rpc_xprt *xprt)
313 dprintk("RPC: disconnected transport %p\n", xprt);
314 spin_lock_bh(&xprt->transport_lock);
315 xprt_clear_connected(xprt);
316 xprt_wake_pending_tasks(xprt, -ENOTCONN);
317 spin_unlock_bh(&xprt->transport_lock);
321 xprt_init_autodisconnect(unsigned long data)
323 struct rpc_xprt *xprt = (struct rpc_xprt *)data;
325 spin_lock(&xprt->transport_lock);
326 if (!list_empty(&xprt->recv) || xprt->shutdown)
328 if (test_and_set_bit(XPRT_LOCKED, &xprt->state))
330 spin_unlock(&xprt->transport_lock);
331 if (xprt_connecting(xprt))
332 xprt_release_write(xprt, NULL);
334 schedule_work(&xprt->task_cleanup);
337 spin_unlock(&xprt->transport_lock);
341 * xprt_connect - schedule a transport connect operation
342 * @task: RPC task that is requesting the connect
345 void xprt_connect(struct rpc_task *task)
347 struct rpc_xprt *xprt = task->tk_xprt;
349 dprintk("RPC: %4d xprt_connect xprt %p %s connected\n", task->tk_pid,
350 xprt, (xprt_connected(xprt) ? "is" : "is not"));
352 if (xprt->shutdown) {
353 task->tk_status = -EIO;
356 if (!xprt->addr.sin_port) {
357 task->tk_status = -EIO;
360 if (!xprt_lock_write(xprt, task))
362 if (xprt_connected(xprt))
363 xprt_release_write(xprt, task);
366 task->tk_rqstp->rq_bytes_sent = 0;
368 task->tk_timeout = RPC_CONNECT_TIMEOUT;
369 rpc_sleep_on(&xprt->pending, task, xprt_connect_status, NULL);
370 xprt->ops->connect(task);
375 static void xprt_connect_status(struct rpc_task *task)
377 struct rpc_xprt *xprt = task->tk_xprt;
379 if (task->tk_status >= 0) {
380 dprintk("RPC: %4d xprt_connect_status: connection established\n",
385 switch (task->tk_status) {
388 dprintk("RPC: %4d xprt_connect_status: server %s refused connection\n",
389 task->tk_pid, task->tk_client->cl_server);
392 dprintk("RPC: %4d xprt_connect_status: connection broken\n",
396 dprintk("RPC: %4d xprt_connect_status: connect attempt timed out\n",
400 dprintk("RPC: %4d xprt_connect_status: error %d connecting to server %s\n",
401 task->tk_pid, -task->tk_status, task->tk_client->cl_server);
402 xprt_release_write(xprt, task);
403 task->tk_status = -EIO;
407 /* if soft mounted, just cause this RPC to fail */
408 if (RPC_IS_SOFT(task)) {
409 xprt_release_write(xprt, task);
410 task->tk_status = -EIO;
415 * xprt_lookup_rqst - find an RPC request corresponding to an XID
416 * @xprt: transport on which the original request was transmitted
417 * @xid: RPC XID of incoming reply
420 struct rpc_rqst *xprt_lookup_rqst(struct rpc_xprt *xprt, u32 xid)
422 struct list_head *pos;
423 struct rpc_rqst *req = NULL;
425 list_for_each(pos, &xprt->recv) {
426 struct rpc_rqst *entry = list_entry(pos, struct rpc_rqst, rq_list);
427 if (entry->rq_xid == xid) {
436 * xprt_complete_rqst - called when reply processing is complete
437 * @xprt: controlling transport
438 * @req: RPC request that just completed
439 * @copied: actual number of bytes received from the transport
442 void xprt_complete_rqst(struct rpc_xprt *xprt, struct rpc_rqst *req, int copied)
444 struct rpc_task *task = req->rq_task;
445 struct rpc_clnt *clnt = task->tk_client;
447 /* Adjust congestion window */
449 unsigned timer = task->tk_msg.rpc_proc->p_timer;
450 xprt_adjust_cwnd(xprt, copied);
451 __xprt_put_cong(xprt, req);
453 if (req->rq_ntrans == 1)
454 rpc_update_rtt(clnt->cl_rtt, timer,
455 (long)jiffies - req->rq_xtime);
456 rpc_set_timeo(clnt->cl_rtt, timer, req->rq_ntrans - 1);
461 /* Profile only reads for now */
463 static unsigned long nextstat;
464 static unsigned long pkt_rtt, pkt_len, pkt_cnt;
467 pkt_len += req->rq_slen + copied;
468 pkt_rtt += jiffies - req->rq_xtime;
469 if (time_before(nextstat, jiffies)) {
470 printk("RPC: %lu %ld cwnd\n", jiffies, xprt->cwnd);
471 printk("RPC: %ld %ld %ld %ld stat\n",
472 jiffies, pkt_cnt, pkt_len, pkt_rtt);
473 pkt_rtt = pkt_len = pkt_cnt = 0;
474 nextstat = jiffies + 5 * HZ;
479 dprintk("RPC: %4d has input (%d bytes)\n", task->tk_pid, copied);
480 list_del_init(&req->rq_list);
481 req->rq_received = req->rq_private_buf.len = copied;
483 /* ... and wake up the process. */
484 rpc_wake_up_task(task);
489 * RPC receive timeout handler.
492 xprt_timer(struct rpc_task *task)
494 struct rpc_rqst *req = task->tk_rqstp;
495 struct rpc_xprt *xprt = req->rq_xprt;
497 spin_lock(&xprt->transport_lock);
498 if (req->rq_received)
501 xprt_adjust_cwnd(req->rq_xprt, -ETIMEDOUT);
502 __xprt_put_cong(xprt, req);
504 dprintk("RPC: %4d xprt_timer (%s request)\n",
505 task->tk_pid, req ? "pending" : "backlogged");
507 task->tk_status = -ETIMEDOUT;
509 task->tk_timeout = 0;
510 rpc_wake_up_task(task);
511 spin_unlock(&xprt->transport_lock);
515 * xprt_prepare_transmit - reserve the transport before sending a request
516 * @task: RPC task about to send a request
519 int xprt_prepare_transmit(struct rpc_task *task)
521 struct rpc_rqst *req = task->tk_rqstp;
522 struct rpc_xprt *xprt = req->rq_xprt;
525 dprintk("RPC: %4d xprt_prepare_transmit\n", task->tk_pid);
530 spin_lock_bh(&xprt->transport_lock);
531 if (req->rq_received && !req->rq_bytes_sent) {
532 err = req->rq_received;
535 if (!__xprt_lock_write(xprt, task)) {
540 if (!xprt_connected(xprt)) {
545 spin_unlock_bh(&xprt->transport_lock);
550 * xprt_transmit - send an RPC request on a transport
551 * @task: controlling RPC task
553 * We have to copy the iovec because sendmsg fiddles with its contents.
555 void xprt_transmit(struct rpc_task *task)
557 struct rpc_clnt *clnt = task->tk_client;
558 struct rpc_rqst *req = task->tk_rqstp;
559 struct rpc_xprt *xprt = req->rq_xprt;
562 dprintk("RPC: %4d xprt_transmit(%u)\n", task->tk_pid, req->rq_slen);
565 if (!req->rq_received) {
566 if (list_empty(&req->rq_list)) {
567 spin_lock_bh(&xprt->transport_lock);
568 /* Update the softirq receive buffer */
569 memcpy(&req->rq_private_buf, &req->rq_rcv_buf,
570 sizeof(req->rq_private_buf));
571 /* Add request to the receive list */
572 list_add_tail(&req->rq_list, &xprt->recv);
573 spin_unlock_bh(&xprt->transport_lock);
574 xprt_reset_majortimeo(req);
575 /* Turn off autodisconnect */
576 del_singleshot_timer_sync(&xprt->timer);
578 } else if (!req->rq_bytes_sent)
581 status = xprt->ops->send_request(task);
585 /* Note: at this point, task->tk_sleeping has not yet been set,
586 * hence there is no danger of the waking up task being put on
587 * schedq, and being picked up by a parallel run of rpciod().
589 task->tk_status = status;
593 task->tk_timeout = RPC_REESTABLISH_TIMEOUT;
594 rpc_sleep_on(&xprt->sending, task, NULL, NULL);
600 xprt_disconnect(xprt);
602 xprt_release_write(xprt, task);
605 dprintk("RPC: %4d xmit complete\n", task->tk_pid);
606 /* Set the task's receive timeout value */
607 spin_lock_bh(&xprt->transport_lock);
609 int timer = task->tk_msg.rpc_proc->p_timer;
610 task->tk_timeout = rpc_calc_rto(clnt->cl_rtt, timer);
611 task->tk_timeout <<= rpc_ntimeo(clnt->cl_rtt, timer) + req->rq_retries;
612 if (task->tk_timeout > xprt->timeout.to_maxval || task->tk_timeout == 0)
613 task->tk_timeout = xprt->timeout.to_maxval;
615 task->tk_timeout = req->rq_timeout;
616 /* Don't race with disconnect */
617 if (!xprt_connected(xprt))
618 task->tk_status = -ENOTCONN;
619 else if (!req->rq_received)
620 rpc_sleep_on(&xprt->pending, task, NULL, xprt_timer);
621 __xprt_release_write(xprt, task);
622 spin_unlock_bh(&xprt->transport_lock);
625 static inline void do_xprt_reserve(struct rpc_task *task)
627 struct rpc_xprt *xprt = task->tk_xprt;
632 if (!list_empty(&xprt->free)) {
633 struct rpc_rqst *req = list_entry(xprt->free.next, struct rpc_rqst, rq_list);
634 list_del_init(&req->rq_list);
635 task->tk_rqstp = req;
636 xprt_request_init(task, xprt);
639 dprintk("RPC: waiting for request slot\n");
640 task->tk_status = -EAGAIN;
641 task->tk_timeout = 0;
642 rpc_sleep_on(&xprt->backlog, task, NULL, NULL);
646 * xprt_reserve - allocate an RPC request slot
647 * @task: RPC task requesting a slot allocation
649 * If no more slots are available, place the task on the transport's
652 void xprt_reserve(struct rpc_task *task)
654 struct rpc_xprt *xprt = task->tk_xprt;
656 task->tk_status = -EIO;
657 if (!xprt->shutdown) {
658 spin_lock(&xprt->reserve_lock);
659 do_xprt_reserve(task);
660 spin_unlock(&xprt->reserve_lock);
664 static inline u32 xprt_alloc_xid(struct rpc_xprt *xprt)
669 static inline void xprt_init_xid(struct rpc_xprt *xprt)
671 get_random_bytes(&xprt->xid, sizeof(xprt->xid));
674 static void xprt_request_init(struct rpc_task *task, struct rpc_xprt *xprt)
676 struct rpc_rqst *req = task->tk_rqstp;
678 req->rq_timeout = xprt->timeout.to_initval;
681 req->rq_xid = xprt_alloc_xid(xprt);
682 dprintk("RPC: %4d reserved req %p xid %08x\n", task->tk_pid,
683 req, ntohl(req->rq_xid));
687 * xprt_release - release an RPC request slot
688 * @task: task which is finished with the slot
691 void xprt_release(struct rpc_task *task)
693 struct rpc_xprt *xprt = task->tk_xprt;
694 struct rpc_rqst *req;
696 if (!(req = task->tk_rqstp))
698 spin_lock_bh(&xprt->transport_lock);
699 __xprt_release_write(xprt, task);
700 __xprt_put_cong(xprt, req);
701 if (!list_empty(&req->rq_list))
702 list_del(&req->rq_list);
703 xprt->last_used = jiffies;
704 if (list_empty(&xprt->recv) && !xprt->shutdown)
705 mod_timer(&xprt->timer,
706 xprt->last_used + RPC_IDLE_DISCONNECT_TIMEOUT);
707 spin_unlock_bh(&xprt->transport_lock);
708 task->tk_rqstp = NULL;
709 memset(req, 0, sizeof(*req)); /* mark unused */
711 dprintk("RPC: %4d release request %p\n", task->tk_pid, req);
713 spin_lock(&xprt->reserve_lock);
714 list_add(&req->rq_list, &xprt->free);
715 xprt_clear_backlog(xprt);
716 spin_unlock(&xprt->reserve_lock);
720 * xprt_set_timeout - set constant RPC timeout
721 * @to: RPC timeout parameters to set up
722 * @retr: number of retries
723 * @incr: amount of increase after each retry
726 void xprt_set_timeout(struct rpc_timeout *to, unsigned int retr, unsigned long incr)
729 to->to_increment = incr;
730 to->to_maxval = to->to_initval + (incr * retr);
731 to->to_retries = retr;
732 to->to_exponential = 0;
735 static struct rpc_xprt *xprt_setup(int proto, struct sockaddr_in *ap, struct rpc_timeout *to)
738 struct rpc_xprt *xprt;
739 struct rpc_rqst *req;
741 if ((xprt = kmalloc(sizeof(struct rpc_xprt), GFP_KERNEL)) == NULL)
742 return ERR_PTR(-ENOMEM);
743 memset(xprt, 0, sizeof(*xprt)); /* Nnnngh! */
749 result = xs_setup_udp(xprt, to);
752 result = xs_setup_tcp(xprt, to);
755 printk(KERN_ERR "RPC: unrecognized transport protocol: %d\n",
762 return ERR_PTR(result);
765 spin_lock_init(&xprt->transport_lock);
766 spin_lock_init(&xprt->reserve_lock);
767 init_waitqueue_head(&xprt->cong_wait);
769 INIT_LIST_HEAD(&xprt->free);
770 INIT_LIST_HEAD(&xprt->recv);
771 INIT_WORK(&xprt->task_cleanup, xprt_autoclose, xprt);
772 init_timer(&xprt->timer);
773 xprt->timer.function = xprt_init_autodisconnect;
774 xprt->timer.data = (unsigned long) xprt;
775 xprt->last_used = jiffies;
777 rpc_init_wait_queue(&xprt->pending, "xprt_pending");
778 rpc_init_wait_queue(&xprt->sending, "xprt_sending");
779 rpc_init_wait_queue(&xprt->resend, "xprt_resend");
780 rpc_init_priority_wait_queue(&xprt->backlog, "xprt_backlog");
782 /* initialize free list */
783 for (req = &xprt->slot[xprt->max_reqs-1]; req >= &xprt->slot[0]; req--)
784 list_add(&req->rq_list, &xprt->free);
788 dprintk("RPC: created transport %p with %u slots\n", xprt,
795 * xprt_create_proto - create an RPC client transport
796 * @proto: requested transport protocol
797 * @sap: remote peer's address
798 * @to: timeout parameters for new transport
801 struct rpc_xprt *xprt_create_proto(int proto, struct sockaddr_in *sap, struct rpc_timeout *to)
803 struct rpc_xprt *xprt;
805 xprt = xprt_setup(proto, sap, to);
807 dprintk("RPC: xprt_create_proto failed\n");
809 dprintk("RPC: xprt_create_proto created xprt %p\n", xprt);
813 static void xprt_shutdown(struct rpc_xprt *xprt)
816 rpc_wake_up(&xprt->sending);
817 rpc_wake_up(&xprt->resend);
818 xprt_wake_pending_tasks(xprt, -EIO);
819 rpc_wake_up(&xprt->backlog);
820 wake_up(&xprt->cong_wait);
821 del_timer_sync(&xprt->timer);
824 static int xprt_clear_backlog(struct rpc_xprt *xprt) {
825 rpc_wake_up_next(&xprt->backlog);
826 wake_up(&xprt->cong_wait);
831 * xprt_destroy - destroy an RPC transport, killing off all requests.
832 * @xprt: transport to destroy
835 int xprt_destroy(struct rpc_xprt *xprt)
837 dprintk("RPC: destroying transport %p\n", xprt);
839 xprt->ops->destroy(xprt);